*** jruano has joined #openstack-ceilometer | 00:00 | |
*** htruta has quit IRC | 00:05 | |
*** ankita_wagh has quit IRC | 00:54 | |
*** thorst has joined #openstack-ceilometer | 00:55 | |
*** boris-42 has joined #openstack-ceilometer | 00:57 | |
*** thorst has quit IRC | 00:57 | |
*** ddieterly has joined #openstack-ceilometer | 01:22 | |
*** pauldix has joined #openstack-ceilometer | 01:23 | |
openstackgerrit | liusheng proposed openstack/aodh: Add alembic support for aodh https://review.openstack.org/206459 | 01:28 |
---|---|---|
*** ddieterl_ has joined #openstack-ceilometer | 01:43 | |
*** ddieterly has quit IRC | 01:44 | |
*** ankita_wagh has joined #openstack-ceilometer | 01:48 | |
*** ankita_wagh has quit IRC | 01:48 | |
*** ankita_wagh has joined #openstack-ceilometer | 01:49 | |
*** pauldix has quit IRC | 01:53 | |
*** pauldix has joined #openstack-ceilometer | 01:55 | |
*** pauldix has quit IRC | 01:59 | |
*** ankita_wagh has quit IRC | 02:19 | |
*** jwcroppe has quit IRC | 02:28 | |
*** jwcroppe has joined #openstack-ceilometer | 02:29 | |
*** openstackgerrit has quit IRC | 02:31 | |
*** openstackgerrit has joined #openstack-ceilometer | 02:31 | |
*** jwcroppe has quit IRC | 02:33 | |
*** ankita_wagh has joined #openstack-ceilometer | 02:47 | |
*** ankita_wagh has quit IRC | 02:47 | |
*** ankita_wagh has joined #openstack-ceilometer | 02:48 | |
*** ddieterl_ has quit IRC | 02:52 | |
*** h00327910__ has quit IRC | 03:28 | |
*** jwcroppe has joined #openstack-ceilometer | 03:43 | |
*** fabian1 has joined #openstack-ceilometer | 03:48 | |
*** ddieterly has joined #openstack-ceilometer | 03:53 | |
*** edmondsw has quit IRC | 03:56 | |
*** ddieterly has quit IRC | 03:57 | |
*** pauldix has joined #openstack-ceilometer | 03:59 | |
*** pauldix has quit IRC | 04:04 | |
*** haigang has joined #openstack-ceilometer | 04:07 | |
*** liusheng has quit IRC | 04:09 | |
*** liusheng has joined #openstack-ceilometer | 04:10 | |
*** yprokule has joined #openstack-ceilometer | 04:22 | |
*** htruta___ has joined #openstack-ceilometer | 04:23 | |
*** deepthi has joined #openstack-ceilometer | 04:24 | |
*** htruta___ has quit IRC | 04:26 | |
*** htruta_____ has joined #openstack-ceilometer | 04:29 | |
*** htruta_____ has quit IRC | 04:30 | |
openstackgerrit | Merged openstack/ceilometer: fix gnocchi resources yaml https://review.openstack.org/206235 | 04:48 |
*** ddieterly has joined #openstack-ceilometer | 04:54 | |
*** fawadkhaliq has joined #openstack-ceilometer | 04:55 | |
*** ddieterly has quit IRC | 04:58 | |
openstackgerrit | Merged openstack/ceilometer: Imported Translations from Transifex https://review.openstack.org/206897 | 05:03 |
openstackgerrit | Merged openstack/ceilometer: distributed coordinated notifications https://review.openstack.org/203818 | 05:04 |
*** jaosorior has joined #openstack-ceilometer | 05:23 | |
*** ig0r_ has joined #openstack-ceilometer | 05:25 | |
*** jruano has quit IRC | 05:29 | |
openstackgerrit | Rohit Jaiswal proposed openstack/python-ceilometerclient: tenant_id not required with keystone v3 https://review.openstack.org/207724 | 05:31 |
*** jwcroppe has quit IRC | 05:43 | |
*** ddieterly has joined #openstack-ceilometer | 05:55 | |
*** ddieterly has quit IRC | 05:59 | |
*** ig0r__ has joined #openstack-ceilometer | 06:11 | |
*** ig0r_ has quit IRC | 06:12 | |
*** jwcroppe has joined #openstack-ceilometer | 06:15 | |
*** dikonoor has joined #openstack-ceilometer | 06:28 | |
*** jiaxi has joined #openstack-ceilometer | 06:43 | |
jiaxi | liusheng: Hello | 06:43 |
*** lsmola has joined #openstack-ceilometer | 06:44 | |
*** belmoreira has joined #openstack-ceilometer | 06:52 | |
*** ddieterly has joined #openstack-ceilometer | 06:56 | |
*** jwcroppe has quit IRC | 06:59 | |
*** ddieterly has quit IRC | 07:00 | |
*** Ala has joined #openstack-ceilometer | 07:08 | |
*** boris-42 has quit IRC | 07:10 | |
*** jiaxi has quit IRC | 07:27 | |
*** exploreshaifali has joined #openstack-ceilometer | 07:37 | |
*** jaosorior has quit IRC | 07:44 | |
*** jaosorior has joined #openstack-ceilometer | 07:47 | |
openstackgerrit | Merged openstack/ceilometer: Make the partition coordinator log more readable https://review.openstack.org/207338 | 07:47 |
sileht | hum, the kafka publisher is well buggy | 07:52 |
haypo | hi. i have issues with python 3 and gabbi. it looks like cdent wrote gabbi, i guess that he can help :) | 07:52 |
haypo | maybe i should wait for him | 07:52 |
sileht | haypo, perhaps I can help, I have already do one patch for gabbi :p | 07:53 |
haypo | with my latest python 3 patch, https://review.openstack.org/207661 , only gabbi tests are failing | 07:53 |
haypo | sileht: it looks like the unit test expects Unicode, whereas the HTTP response is bytes | 07:53 |
haypo | sileht: the error is truncated, but you should only see types: str not in bytes, http://paste.openstack.org/show/406552/ | 07:54 |
haypo | sileht: the pattern _is_ in the output | 07:55 |
sileht | I see, it fails because we compare bytes with str | 07:56 |
haypo | ceilometer/tests/gabbi/gabbits/resources-empty.yaml: | 07:56 |
haypo | response_strings: | 07:56 |
haypo | - unrecognized field in query | 07:56 |
haypo | sileht: ^^ it's gabbi "response_strings" check | 07:56 |
haypo | sileht: PyPI says that gabbi is compatible with Python 3 | 07:57 |
haypo | so maybe we misuse gabbi? | 07:57 |
haypo | sileht: to be clear, if we fix the 16 gabbi failures, all unit tests with pass on Python 3. maybe it can motivate you :-D | 07:58 |
haypo | all unit tests _will_ pass, sorry | 07:58 |
sileht | At first glance the body is decoded to utf8 by gabbi, I wonder why we get bytes | 07:59 |
* sileht continues digging | 07:59 | |
*** _nadya_ has joined #openstack-ceilometer | 08:01 | |
*** afazekas has joined #openstack-ceilometer | 08:09 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/ceilometer: Fixes the kafka publisher https://review.openstack.org/207769 | 08:21 |
*** deepthi has quit IRC | 08:24 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/ceilometer: Fixes the kafka publisher https://review.openstack.org/207769 | 08:24 |
*** exploreshaifali_ has joined #openstack-ceilometer | 08:28 | |
*** exploreshaifali has quit IRC | 08:30 | |
*** yassine has joined #openstack-ceilometer | 08:40 | |
*** exploreshaifali_ has quit IRC | 08:54 | |
*** exploreshaifali has joined #openstack-ceilometer | 08:54 | |
*** ddieterly has joined #openstack-ceilometer | 08:57 | |
*** nijaba has quit IRC | 09:01 | |
*** ddieterly has quit IRC | 09:02 | |
*** exploreshaifali has quit IRC | 09:02 | |
*** ityaptin has joined #openstack-ceilometer | 09:02 | |
*** exploreshaifali has joined #openstack-ceilometer | 09:02 | |
ityaptin | jd__: Hi! | 09:03 |
ityaptin | jd__: Are you working on InlfuxDb right now? Do you mind if I update this CR with get_cross_metric functional today? | 09:04 |
jd__ | ityaptin: go ahead | 09:05 |
jd__ | ityaptin: though It'd be more comfortable if we fix this patch, merge it, and then add new features | 09:06 |
ityaptin | jd__: Ok, understand. Then I will start to research failing tests now. | 09:08 |
jd__ | thanks ityaptin | 09:08 |
*** ankita_wagh has quit IRC | 09:26 | |
*** hhuang has joined #openstack-ceilometer | 09:28 | |
*** ankita_wagh has joined #openstack-ceilometer | 09:32 | |
openstackgerrit | Ilya Tyaptin proposed openstack/ceilometer: Initial separating unit and functional tests https://review.openstack.org/204128 | 09:47 |
*** ankita_wagh has quit IRC | 09:51 | |
*** _nadya_ has quit IRC | 09:59 | |
*** _nadya_ has joined #openstack-ceilometer | 09:59 | |
*** pauldix has joined #openstack-ceilometer | 10:02 | |
*** _nadya_ has quit IRC | 10:04 | |
*** pauldix has quit IRC | 10:06 | |
*** fabian1 has left #openstack-ceilometer | 10:08 | |
ityaptin | jd__: Also I found a bug in SearchMetricController. We don't cast unicode time str to datetime. How do you think it will be enough if i fix it in InlfuxDb patch or I should create separate CR? | 10:50 |
*** cdent has joined #openstack-ceilometer | 10:51 | |
*** eglynn has joined #openstack-ceilometer | 10:54 | |
*** ddieterly has joined #openstack-ceilometer | 10:59 | |
*** _nadya_ has joined #openstack-ceilometer | 11:02 | |
*** ddieterly has quit IRC | 11:03 | |
*** eglynn_ has joined #openstack-ceilometer | 11:06 | |
*** eglynn has quit IRC | 11:09 | |
*** ig0r__ has quit IRC | 11:15 | |
openstackgerrit | Chris Dent proposed openstack/aodh: Clean up permissions in function post_test_hook https://review.openstack.org/207840 | 11:16 |
*** ig0r_ has joined #openstack-ceilometer | 11:19 | |
*** afazekas has quit IRC | 11:31 | |
*** dikonoor has quit IRC | 11:34 | |
*** pauldix has joined #openstack-ceilometer | 11:40 | |
*** eglynn_ has quit IRC | 11:49 | |
*** exploreshaifali has quit IRC | 11:50 | |
openstackgerrit | Merged openstack/aodh: Port remaining tests to Python 3 https://review.openstack.org/207547 | 11:55 |
*** thorst has joined #openstack-ceilometer | 11:55 | |
*** bdossant has joined #openstack-ceilometer | 11:55 | |
*** pauldix has quit IRC | 11:58 | |
*** ddieterly has joined #openstack-ceilometer | 11:59 | |
openstackgerrit | Ilya Tyaptin proposed openstack/gnocchi: InfluxDB storage driver https://review.openstack.org/165407 | 12:04 |
*** ddieterly has quit IRC | 12:04 | |
*** gordc has joined #openstack-ceilometer | 12:09 | |
jd__ | ityaptin: do you want a hand to fix those last tests in InfluxDB? | 12:12 |
*** ddieterly has joined #openstack-ceilometer | 12:14 | |
*** ddieterly has quit IRC | 12:24 | |
sileht | cdent, https://github.com/cdent/python3-wsgi-intercept/pull/32 | 12:24 |
*** haigang has quit IRC | 12:25 | |
sileht | haypo, ^ | 12:26 |
* cdent looks | 12:26 | |
*** thumpba has joined #openstack-ceilometer | 12:28 | |
sileht | cdent, ceilometer does that changing header after start_response have been run | 12:29 |
cdent | a) that's a very nice catch b) shame on ceilometer for doing that | 12:29 |
sileht | swift does that too | 12:30 |
cdent | is weak sauce | 12:30 |
cdent | swift is like the poster child of "does weird stuff" | 12:30 |
* cdent merges | 12:30 | |
sileht | cdent, haypo found the bug, because on py34 we can't compare bytes and str | 12:30 |
sileht | cdent, and because the headers are missed, the body is not decoded | 12:31 |
sileht | haypo, only 4 tests fails now on py34 | 12:31 |
*** eglynn_ has joined #openstack-ceilometer | 12:31 | |
sileht | cdent, who should handle this exception http://paste.openstack.org/show/406586/ ? | 12:32 |
sileht | seems come from test with xfail: true | 12:33 |
*** thumpba has quit IRC | 12:33 | |
cdent | sileht: that'll be a bug from 1.1.5 release last night | 12:33 |
sileht | oh cool | 12:33 |
cdent | roll back to gabbi 1.1.4 while I fix it | 12:33 |
* sileht downgrade | 12:33 | |
cdent | unexpected success is I think the main area of not proper coverage in gabbi | 12:34 |
*** dikonoor has joined #openstack-ceilometer | 12:35 | |
*** edmondsw has joined #openstack-ceilometer | 12:36 | |
*** _nadya_ has quit IRC | 12:36 | |
*** _nadya_ has joined #openstack-ceilometer | 12:36 | |
cdent | sileht: new wsgi-intercept released | 12:37 |
*** eglynn_ has quit IRC | 12:39 | |
*** eglynn_ has joined #openstack-ceilometer | 12:39 | |
*** _nadya_ has quit IRC | 12:40 | |
*** _nadya_ has joined #openstack-ceilometer | 12:41 | |
jd__ | cdent: there are +2A holes in my branch :D | 12:41 |
jd__ | cdent: in my clean up conf things for aodh | 12:41 |
cdent | jd__: noted | 12:41 |
haypo | "14:37 < cdent> sileht: new wsgi-intercept released" woooot | 12:43 |
cdent | haypo: now working on fixing the gabbi unexpected success problem | 12:44 |
sileht | haypo, just one test fail now, I'm fixing it | 12:44 |
haypo | "unexpected success problem" haha, i like this concept | 12:45 |
haypo | sileht: ok. i let you fix remaining issues | 12:45 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/ceilometer: mongo: fix lastest python3 bug https://review.openstack.org/207872 | 12:45 |
sileht | haypo, ^ | 12:46 |
haypo | sileht: latest or last? | 12:46 |
sileht | haypo, both is more powerfull ;p | 12:46 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/ceilometer: mongo: fix latest python3 bug https://review.openstack.org/207872 | 12:47 |
haypo | sileht: i used sort(key=lambda obj: sorted(obj.items()) in some projets | 12:47 |
haypo | projects | 12:47 |
haypo | sileht: but i also like your choice to fix it ;) | 12:48 |
haypo | sileht: hum. i'm not sure that dict items will always be in the same order | 12:49 |
haypo | sileht: dict buckets are filled randomly | 12:49 |
sileht | haypo, I will change for you version so | 12:50 |
*** jiaxi has joined #openstack-ceilometer | 12:50 | |
*** ddieterly has joined #openstack-ceilometer | 12:52 | |
*** ddieterly has quit IRC | 12:53 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/ceilometer: fix latest python3 bugs https://review.openstack.org/207872 | 12:53 |
sileht | haypo, with your version ^ | 12:54 |
sileht | it's more readable | 12:54 |
sileht | haypo, does ceilometer the first application that have all unittests that pass py34 ? | 12:54 |
haypo | sileht: sorry, o | 12:56 |
haypo | no | 12:56 |
haypo | sileht: https://wiki.openstack.org/wiki/Python3#OpenStack_applications | 12:57 |
sileht | sniff | 12:57 |
haypo | sileht: gnocchi, ironic, rally have a full python3 support | 12:57 |
haypo | sileht: aodh maybe, i don't know if my patch is accepted or not ;) | 12:57 |
haypo | sileht: ah, it's merged ;) | 12:57 |
sileht | haypo, http://paste.openstack.org/show/406590/ \o/ | 12:58 |
* sileht run py34 test on mysql | 13:00 | |
*** eglynn_ has quit IRC | 13:04 | |
sileht | all py34 tests pass mysql backend too :) | 13:04 |
haypo | sileht: oh, you event wrote a uni test for python3-wsgi-intercept | 13:05 |
haypo | sileht, cdent : there are one version of wsgi-intercept for python 3, and another for python 2? two code bases? | 13:06 |
cdent | haypo: no, same version | 13:06 |
cdent | it's just the repo name that is python3 | 13:06 |
cdent | it is because at the time there were several version of wsgi-intercept sort of working towards the future | 13:06 |
cdent | and I started working on a pure python3 one | 13:07 |
cdent | and it turned out that it was easy to make work in both and I sort of ended up the official maintainer | 13:07 |
cdent | I should probably change the name of the repo | 13:07 |
cdent | what do you think? | 13:07 |
haypo | cdent: change the name of the repo to have the same name than PyPI | 13:07 |
*** eglynn_ has joined #openstack-ceilometer | 13:08 | |
*** eglynn_ has quit IRC | 13:08 | |
haypo | sorry, i didn't check the name of these projects | 13:08 |
haypo | sileht was faster than me | 13:08 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/gnocchi: api: dogpile cache for getting resource https://review.openstack.org/207521 | 13:10 |
haypo | sileht: did you fix the remaining "/ 100"? | 13:15 |
sileht | haypo, no, tests are passing :p | 13:15 |
haypo | sileht: i see, you hate opendaylight | 13:15 |
sileht | haypo, I hate untested stuffs | 13:16 |
haypo | sileht: ok, i'm writing a fix | 13:16 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/gnocchi: gate: fixup gabbi live tests https://review.openstack.org/206510 | 13:18 |
*** htruta has joined #openstack-ceilometer | 13:18 | |
haypo | sileht: in ceilometer/compute/virt/vmware/inspector.py, "cpu_util = cpu_util / 100" is supposed to return a float or an int? | 13:19 |
sileht | haypo, float I guess | 13:19 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/gnocchi: Don't update resource if nothing has changed https://review.openstack.org/207522 | 13:22 |
openstackgerrit | Victor Stinner proposed openstack/ceilometer: Fix Python 3 issue in opendaylight client https://review.openstack.org/207896 | 13:23 |
cdent | sileht, haypo: new gabbi just released, ought to fix the unexpected success problem | 13:23 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/ceilometer: Fixes the kafka publisher https://review.openstack.org/207769 | 13:23 |
*** fabian4 has joined #openstack-ceilometer | 13:24 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/ceilometer: mongo: fix last python3 bugs https://review.openstack.org/207872 | 13:26 |
*** primechuck has joined #openstack-ceilometer | 13:26 | |
sileht | cdent, cool https://review.openstack.org/#/c/207872/ should pass the py34 job on next pypi mirror sync, so | 13:26 |
jiaxi | https://github.com/openstack/ceilometer/blob/master/ceilometer/agent/base.py L221-L223 What does the code mean ? | 13:31 |
cdent | jiaxi: it's possible to run the polling agent with a limited set of pollster plugins | 13:32 |
cdent | so that's basically saying: only give me the extensions declared in pollster_list | 13:33 |
cdent | pollster_list isn't often used, from what I can tell | 13:33 |
jiaxi | cdent: the code means running the pollster plugins ? Not like | 13:34 |
jiaxi | cdent: only use namespace ? | 13:34 |
cdent | I'm sorry, I don't really understand your question. | 13:34 |
jiaxi | def __init__(self, namespaces, pollster_list, group_prefix=None): | 13:35 |
jiaxi | pollster_list is often None | 13:35 |
jiaxi | namespace == 'computer' or 'central' | 13:35 |
jiaxi | computer -> compute | 13:35 |
cdent | yes | 13:36 |
jiaxi | cdent: https://github.com/openstack/ceilometer/blob/master/ceilometer/agent/base.py L225 What does L225 mean ? | 13:37 |
cdent | the previous few lines are determing which extensions (PollsterPlugins) are going to be available to the polling agent, line 225 establishes them for later use by the polling agent | 13:38 |
cdent | later in the code when polling tasks are being created, the extension will be used to determine how they are created | 13:39 |
gordc | sileht: is your patch suppose to be dependent on https://review.openstack.org/#/c/207896/ | 13:41 |
gordc | py3 patch | 13:41 |
jiaxi | cdent: Great explain . Thank you . cdent. | 13:41 |
sileht | gordc, yes | 13:41 |
sileht | gordc, no | 13:41 |
gordc | lol | 13:41 |
sileht | gordc, int(r.status_code / 100) and r.status_code // 100 | 13:42 |
sileht | are the same thing | 13:42 |
sileht | gordc,just the opendaylight is a really fix | 13:42 |
gordc | right... so you don't need that to enable all py3 tests? | 13:43 |
sileht | gordc, no | 13:43 |
sileht | gordc, opendaylight tests just doesn't catch that py3 bug | 13:43 |
gordc | i'm just going to trust you. too lazy to wait for check. | 13:44 |
gordc | sileht: i don' think this is possible but is there a way to update only the endpoints of a listener? or do you have to recreate listener with new endpoints? | 13:48 |
* sileht thinks | 13:48 | |
sileht | gordc, no you have to recreate the listener because the endpoints define the queue/topic/exchange to listen on | 13:49 |
*** eglynn_ has joined #openstack-ceilometer | 13:49 | |
gordc | sileht: yeah, that's what i figured. thanks for confirmation. | 13:50 |
*** jiaxi has quit IRC | 13:51 | |
sileht | gordc, with kombu it's totally realisty to subscribe/unsubscribe some stuffs, but oslo.messaging is really inflexible for that | 13:52 |
gordc | is it because the endpoints all share one connection? | 13:53 |
*** jiaxi has joined #openstack-ceilometer | 13:54 | |
sileht | gordc, this is true, but that's not really the problem | 13:54 |
*** jaosorior has quit IRC | 13:54 | |
sileht | gordc, this is because we browse endpoint to get the list of the implemented method, to listen only those implements | 13:56 |
sileht | ie: you impement 'info', so we listen '<the-target-or-config-topics>-info' | 13:57 |
*** IBerezovskiy has joined #openstack-ceilometer | 13:58 | |
gordc | sileht: ah. got it. it does this all at startup. | 13:58 |
sileht | gordc, yes, I think we could do later but we need to add a new driver API, I see how this can be done for rabbit, but I have no idea for other. | 13:59 |
cdent | jd__: I think I got most of them, there are two that still have unresolved comments | 13:59 |
gordc | sileht: no worries. not that important. | 14:00 |
*** rbak has joined #openstack-ceilometer | 14:00 | |
gordc | sileht: i think if you swap endpoints while listener is active you might end up missing notifications on some endpoints anyways | 14:01 |
sileht | gordc, when your notification ring need to rebuilded, all connections to rabbit are closed, then reopen, when we just need to send to rabbit msgs | 14:01 |
sileht | *to send some rabbit msgs* | 14:01 |
sileht | gordc, anyways that just an improvements | 14:01 |
gordc | sileht: agreed. | 14:02 |
openstackgerrit | Drew Thorstensen proposed openstack/ceilometer: Provide base method for inspect_memory_resident https://review.openstack.org/207907 | 14:03 |
*** IBerezovskiy has quit IRC | 14:03 | |
*** eglynn_ has quit IRC | 14:04 | |
*** IBerezovskiy has joined #openstack-ceilometer | 14:04 | |
jd__ | cdent: thanks I'll reply/fix | 14:05 |
sileht | gordc, this you can take a look to https://review.openstack.org/#/c/207137/ , I'm sure a PTL like this kind of tests :p | 14:07 |
gordc | sileht: i don't like tests | 14:08 |
gordc | sileht: are we going to create gate/check on this? | 14:09 |
sileht | gordc, yes sir | 14:09 |
gordc | :) | 14:09 |
*** IBerezovskiy has quit IRC | 14:11 | |
*** fabian4 has quit IRC | 14:17 | |
*** jruano has joined #openstack-ceilometer | 14:21 | |
*** h00327910__ has joined #openstack-ceilometer | 14:24 | |
*** prad has joined #openstack-ceilometer | 14:26 | |
gordc | hmmm we need a way to have both gnocchi enabled and events... | 14:27 |
*** Ala has quit IRC | 14:28 | |
*** nijaba has joined #openstack-ceilometer | 14:31 | |
cdent | gordc: isn't it good we are actually trying to use the things we are creating. so many holes we find. is good | 14:33 |
sileht | gordc, create two topic on client side (nova/glance/...) and 1 collector for each purpose | 14:33 |
cdent | sileht: that's an onerous requirement for exisiting installations | 14:34 |
gordc | sileht: that's the workaround i proposed: https://bugs.launchpad.net/ceilometer/+bug/1480333 | 14:37 |
openstack | Launchpad bug 1480333 in Ceilometer "event consumption needs to be disabled on gnocchi dispatcher" [Undecided,New] | 14:37 |
gordc | we need to publish to a non-default topic and have a second collector | 14:37 |
gordc | the only way to get this working in default is to have gnocchi dispatch also set up a event connection... | 14:38 |
openstackgerrit | Merged openstack/aodh: storage: always use get_connection_from_config() https://review.openstack.org/205561 | 14:38 |
*** fabian4 has joined #openstack-ceilometer | 14:38 | |
openstackgerrit | Merged openstack/aodh: tests.db: simplify connection handling https://review.openstack.org/205562 | 14:39 |
openstackgerrit | Merged openstack/aodh: mongodb: stop using global config object https://review.openstack.org/205563 | 14:39 |
*** fawadkhaliq has quit IRC | 14:41 | |
*** dikonoor has quit IRC | 14:42 | |
gordc | sileht: what's the local.conf configuration i need to give more workers to swift for gnocchi? | 14:43 |
*** exploreshaifali has joined #openstack-ceilometer | 14:45 | |
*** ddaskal has joined #openstack-ceilometer | 14:50 | |
gordc | also, i think i asked last week. but i believe gnocchi has a hard requirement on valid uuid... most of OpenStack is non-sense with ids... what do we do? | 14:51 |
*** fawadkhaliq has joined #openstack-ceilometer | 14:54 | |
openstackgerrit | Merged openstack/aodh: api: fix alarm deletion and update https://review.openstack.org/207140 | 14:58 |
ityaptin | jd__: I found what we can fix it if add lazy='joined' parameter to sqalachemy_base.Metric: https://github.com/openstack/gnocchi/blob/master/gnocchi/indexer/sqlalchemy_base.py#L153 | 14:59 |
*** fawadkhaliq has quit IRC | 14:59 | |
ityaptin | jd__: Aslo, this issue affects not only tests but real running too. | 15:00 |
*** jiaxi has quit IRC | 15:00 | |
ityaptin | jd__: If we add lazy parameter then inspect from [1] think what archive_policy loaded and show it in json output. [1] https://github.com/openstack/gnocchi/blob/master/gnocchi/indexer/sqlalchemy_base.py#L176 | 15:03 |
openstackgerrit | Rohit Jaiswal proposed openstack/python-ceilometerclient: tenant_id not required with keystone v3 https://review.openstack.org/207724 | 15:03 |
*** exploreshaifali has quit IRC | 15:04 | |
*** fawadkhaliq has joined #openstack-ceilometer | 15:06 | |
openstackgerrit | Ilya Tyaptin proposed openstack/gnocchi: InfluxDB storage driver https://review.openstack.org/165407 | 15:08 |
ityaptin | jd__: ^^^ Tests pass, but even we query metrics without loading `archive_policy` it loads in jsonify. | 15:09 |
jd__ | ityaptin: but all tests pass? | 15:10 |
ityaptin | jd__: yep | 15:11 |
jd__ | ityaptin: so I don't get what the problem is? :) | 15:13 |
ityaptin | jd__: it affects expect output of several requests :( | 15:14 |
jd__ | ityaptin: and that's not caught by tests? | 15:14 |
ityaptin | jd__: Not | 15:14 |
jd__ | ityaptin: could you write a test then? | 15:14 |
jd__ | I'd fix the issue | 15:15 |
ityaptin | jd__: I afraid I don't have time to write the test today :( | 15:15 |
gordc | jd__: is there some configuration you need to do to get influxdb running test? | 15:16 |
gordc | i always see: requests.exceptions.ConnectionError: ('Connection aborted.', error(111, 'Connection refused')) | 15:16 |
jd__ | ityaptin: ok no worry, that can wait next week :) | 15:16 |
jd__ | gordc: are you sure you have influx 0.9? | 15:16 |
ityaptin | jd__: And next week :( I am going to vacation since Monday. | 15:17 |
jd__ | gordc: likely the bash script does not start it and the test continues – I already noticed that | 15:17 |
jd__ | ityaptin: ah damn it – do you still have time to at least give me an example in the review so I can investigate? | 15:17 |
gordc | jd__: hmm.. i have 0.9.2. i'll check script | 15:17 |
ityaptin | jd__: Yes, give me a minute. | 15:18 |
*** ankita_wagh has joined #openstack-ceilometer | 15:18 | |
ityaptin | jd__: http://pastebin.com/sUxmphcv | 15:20 |
*** haypo has left #openstack-ceilometer | 15:21 | |
gordc | jd__: stupid path issue. https://github.com/influxdb/influxdb/issues/2933 | 15:21 |
ityaptin | jd__: Metric.archive_policy[1] is loaded in function Metric.jsonify(), because Metric inspection[3] thinks what archive_policy is loaded [3]. | 15:22 |
openstackgerrit | Rohit Jaiswal proposed openstack/python-ceilometerclient: tenant_id not required with keystone v3 https://review.openstack.org/207724 | 15:22 |
ityaptin | jd__: [1]https://github.com/openstack/gnocchi/blob/master/gnocchi/indexer/sqlalchemy_base.py#L153 | 15:22 |
ityaptin | jd_: [3] https://github.com/openstack/gnocchi/blob/master/gnocchi/indexer/sqlalchemy_base.py#L172 | 15:23 |
*** belmoreira has quit IRC | 15:24 | |
jd__ | ityaptin: where do you see that what you mark as "expected" is actually expected? | 15:24 |
jd__ | AFAIK what's expected is what is returned, i.e. the full archive policy description | 15:25 |
jd__ | andI don't think it's a problem with InfluxDB actually | 15:25 |
ityaptin | jd__: It's not Influxdb fail, but I fix issue with adding lazy="joined" to Metric.archive_policy relationship | 15:27 |
ityaptin | jd__: expected I see at gnocchi master | 15:27 |
jd__ | ok I'll check that out | 15:28 |
ityaptin | jd__: By default we expected a short metric definition output in /v1/metric/, but after my patch /v1/metric show full definition | 15:28 |
jd__ | ityaptin: yeah I get that I just don't see the relationship with Influx yet but I'll take a look into it don't worry :) | 15:29 |
jd__ | I've added a note on the patch so I check that on Monday | 15:29 |
jd__ | if the rest works, we'll merge the patch :) | 15:30 |
ityaptin | jd__: ok, cool, thanx! | 15:30 |
jd__ | thanks to you for your work ityaptin :) | 15:30 |
openstackgerrit | Merged openstack/ceilometer: Fix WSGI replacement_start_response() on Python 3 https://review.openstack.org/207551 | 15:31 |
*** ankita_wagh has quit IRC | 15:31 | |
*** ankita_wagh has joined #openstack-ceilometer | 15:32 | |
*** fabian4 has left #openstack-ceilometer | 15:34 | |
openstackgerrit | Saba proposed openstack/ceilometer: Corrected unit of snmp based harware disk and memory meters https://review.openstack.org/207199 | 15:37 |
*** jruano has quit IRC | 15:37 | |
openstackgerrit | Julien Danjou proposed openstack/aodh: tests.api: remove unused argument/config option https://review.openstack.org/205969 | 15:43 |
openstackgerrit | Julien Danjou proposed openstack/aodh: api: fix alarm group declaration https://review.openstack.org/206470 | 15:43 |
openstackgerrit | Julien Danjou proposed openstack/aodh: api: remove global conf and local pecan config https://review.openstack.org/205971 | 15:44 |
openstackgerrit | Julien Danjou proposed openstack/aodh: gnocchi: stop using global conf object for Gnocchi evaluator https://review.openstack.org/206471 | 15:44 |
openstackgerrit | Julien Danjou proposed openstack/aodh: api: remove force_canonical option https://review.openstack.org/205970 | 15:44 |
openstackgerrit | Julien Danjou proposed openstack/aodh: api: stop using a global Enforcer object https://review.openstack.org/205572 | 15:44 |
openstackgerrit | Julien Danjou proposed openstack/aodh: evaluator: remove global conf usage from threshold evaluator https://review.openstack.org/205973 | 15:44 |
openstackgerrit | Julien Danjou proposed openstack/aodh: api.hooks: stop using global conf object https://review.openstack.org/205571 | 15:44 |
openstackgerrit | Julien Danjou proposed openstack/aodh: rpc: remove global conf usage from notifier https://review.openstack.org/205972 | 15:44 |
openstackgerrit | Julien Danjou proposed openstack/aodh: mongodb: stop relying on global conf object in utils https://review.openstack.org/205975 | 15:44 |
openstackgerrit | Julien Danjou proposed openstack/aodh: mongodb: replace custom retry code by retrying https://review.openstack.org/205974 | 15:44 |
openstackgerrit | Julien Danjou proposed openstack/aodh: storage: only retry connection, not driver finding https://review.openstack.org/206589 | 15:44 |
openstackgerrit | Julien Danjou proposed openstack/aodh: Stop using global conf object https://review.openstack.org/206573 | 15:44 |
*** IBerezovskiy has joined #openstack-ceilometer | 15:47 | |
*** dikonoor has joined #openstack-ceilometer | 15:51 | |
cdent | jd__: I +A those two I was being whiny about | 15:52 |
jd__ | thanks cdent I actually fixed your comments :) | 15:52 |
cdent | yeah, and I exclaimed on gerrit just how much better that's going to make my weekend | 15:53 |
cdent | without those changes I would have been in a deep blue funk | 15:53 |
*** bdossant has quit IRC | 16:03 | |
*** ildikov has quit IRC | 16:09 | |
openstackgerrit | Saba proposed openstack/ceilometer: Corrected unit of snmp based harware disk and memory meters https://review.openstack.org/207199 | 16:10 |
*** _cjones_ has joined #openstack-ceilometer | 16:11 | |
*** rbak has quit IRC | 16:17 | |
*** ildikov has joined #openstack-ceilometer | 16:21 | |
*** dikonoor has quit IRC | 16:23 | |
*** yprokule has quit IRC | 16:25 | |
*** ddieterly has joined #openstack-ceilometer | 16:31 | |
*** primechuck has quit IRC | 16:33 | |
*** primechuck has joined #openstack-ceilometer | 16:33 | |
*** primechuck has quit IRC | 16:33 | |
cdent | jd__ ++ on the blog post, really nice. I'll give it a review for typos and the like later but the content is good. | 16:33 |
*** primechuck has joined #openstack-ceilometer | 16:33 | |
jd__ | thanks cdent! | 16:33 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ceilometer: Updated from global requirements https://review.openstack.org/205650 | 16:35 |
*** rbak has joined #openstack-ceilometer | 16:35 | |
*** ddieterly has quit IRC | 16:37 | |
*** briancline has joined #openstack-ceilometer | 16:43 | |
*** ddieterly has joined #openstack-ceilometer | 16:45 | |
*** rbak has quit IRC | 16:46 | |
*** ddieterly has quit IRC | 16:49 | |
*** _nadya_ has quit IRC | 16:52 | |
*** _nadya_ has joined #openstack-ceilometer | 16:53 | |
*** _nadya_ has quit IRC | 16:57 | |
*** rbak has joined #openstack-ceilometer | 17:00 | |
*** rbak has quit IRC | 17:03 | |
*** rbak has joined #openstack-ceilometer | 17:05 | |
*** IBerezovskiy has quit IRC | 17:05 | |
openstackgerrit | Chris Dent proposed openstack/aodh: Correct database functional tests https://review.openstack.org/207840 | 17:07 |
cdent | jd__: if you're still around that ^ is pretty important | 17:07 |
cdent | the mysql unit tests had been skipping, the pymsql driver wasn't able to be used, and a whole slew of stuff with the tests was not actually doing what I think we thought they were | 17:08 |
cdent | a test run without my changes http://logs.openstack.org/40/207840/1/check/gate-aodh-python27/9d7aed5/console.html#_2015-07-31_13_31_08_969 shows too many skips | 17:09 |
*** Ephur has joined #openstack-ceilometer | 17:10 | |
*** cdent_ has joined #openstack-ceilometer | 17:13 | |
*** cdent has quit IRC | 17:14 | |
*** cdent_ is now known as cdent | 17:14 | |
cdent | gordc: you still around | 17:18 |
cdent | I have some findings to report on long running ceilo+gnocchi | 17:18 |
*** pauldix has joined #openstack-ceilometer | 17:19 | |
*** ankita_wagh has quit IRC | 17:22 | |
*** _nadya_ has joined #openstack-ceilometer | 17:23 | |
*** fawadkhaliq has quit IRC | 17:23 | |
*** fawadkhaliq has joined #openstack-ceilometer | 17:23 | |
openstackgerrit | Merged openstack/aodh: api.hooks: stop using global conf object https://review.openstack.org/205571 | 17:26 |
openstackgerrit | Merged openstack/aodh: api: stop using a global Enforcer object https://review.openstack.org/205572 | 17:27 |
openstackgerrit | Merged openstack/aodh: tests.api: remove unused argument/config option https://review.openstack.org/205969 | 17:27 |
openstackgerrit | Merged openstack/aodh: api: remove force_canonical option https://review.openstack.org/205970 | 17:27 |
openstackgerrit | Rohit Jaiswal proposed openstack/ceilometer: Fixes querying alarm history with severity field https://review.openstack.org/200238 | 17:28 |
*** _nadya_ has quit IRC | 17:32 | |
openstackgerrit | Merged openstack/aodh: api: remove global conf and local pecan config https://review.openstack.org/205971 | 17:34 |
openstackgerrit | Merged openstack/aodh: rpc: remove global conf usage from notifier https://review.openstack.org/205972 | 17:34 |
openstackgerrit | Merged openstack/aodh: evaluator: remove global conf usage from threshold evaluator https://review.openstack.org/205973 | 17:35 |
*** ankita_wagh has joined #openstack-ceilometer | 17:42 | |
*** rbak has quit IRC | 17:52 | |
*** exploreshaifali has joined #openstack-ceilometer | 17:52 | |
*** ankita_w_ has joined #openstack-ceilometer | 18:02 | |
*** rbak has joined #openstack-ceilometer | 18:04 | |
*** ankita_wagh has quit IRC | 18:05 | |
openstackgerrit | Rohit Jaiswal proposed openstack/ceilometer: Masks messaging_urls in logs during debug mode https://review.openstack.org/208011 | 18:06 |
*** rbak has quit IRC | 18:07 | |
openstackgerrit | Merged openstack/aodh: mongodb: replace custom retry code by retrying https://review.openstack.org/205974 | 18:09 |
openstackgerrit | Merged openstack/aodh: mongodb: stop relying on global conf object in utils https://review.openstack.org/205975 | 18:09 |
openstackgerrit | Merged openstack/aodh: api: fix alarm group declaration https://review.openstack.org/206470 | 18:10 |
openstackgerrit | Merged openstack/aodh: gnocchi: stop using global conf object for Gnocchi evaluator https://review.openstack.org/206471 | 18:10 |
openstackgerrit | Merged openstack/aodh: Stop using global conf object https://review.openstack.org/206573 | 18:10 |
openstackgerrit | Merged openstack/aodh: storage: only retry connection, not driver finding https://review.openstack.org/206589 | 18:10 |
openstackgerrit | Merged openstack/ceilometer: Remove the compute inspector choice restriction https://review.openstack.org/207592 | 18:11 |
openstackgerrit | Merged openstack/ceilometer: tests: add an integration test https://review.openstack.org/207137 | 18:11 |
*** ankita_w_ has quit IRC | 18:11 | |
*** ankita_wagh has joined #openstack-ceilometer | 18:11 | |
*** ildikov has quit IRC | 18:19 | |
*** pauldix has quit IRC | 18:27 | |
*** pauldix has joined #openstack-ceilometer | 18:27 | |
openstackgerrit | Michael Bayer proposed openstack/gnocchi: Switch to facade https://review.openstack.org/204669 | 18:32 |
*** ildikov has joined #openstack-ceilometer | 18:36 | |
openstackgerrit | Chris Dent proposed openstack/aodh: Correct database functional tests https://review.openstack.org/207840 | 18:39 |
*** fawadkhaliq has quit IRC | 18:40 | |
*** jruano has joined #openstack-ceilometer | 18:46 | |
*** exploreshaifali has quit IRC | 18:49 | |
*** rbak has joined #openstack-ceilometer | 18:52 | |
*** ddieterly has joined #openstack-ceilometer | 18:56 | |
*** ddieterly has quit IRC | 18:57 | |
*** ddieterly has joined #openstack-ceilometer | 18:58 | |
*** fawadkhaliq has joined #openstack-ceilometer | 19:05 | |
*** fawadkhaliq has quit IRC | 19:09 | |
*** rjaiswal has joined #openstack-ceilometer | 19:13 | |
rjaiswal | gordc: put some comments on https://review.openstack.org/#/c/207724/ | 19:14 |
gordc | rjaiswal: k. i'll take a look | 19:16 |
rjaiswal | thanks gordc | 19:17 |
*** afazekas has joined #openstack-ceilometer | 19:18 | |
*** _nadya_ has joined #openstack-ceilometer | 19:20 | |
gordc | rjaiswal: k. thanks for pointing out shell part | 19:20 |
gordc | i don't know understand where we are validating it in client | 19:20 |
gordc | it's not actually validated in the part you linked. it just uses one or the other | 19:21 |
gordc | https://github.com/openstack/python-ceilometerclient/blob/master/ceilometerclient/client.py#L232-L235 | 19:21 |
rjaiswal | from here, i think:https://github.com/openstack/python-ceilometerclient/blob/master/ceilometerclient/client.py#L259 | 19:24 |
rjaiswal | which in turn from here - https://github.com/openstack/python-ceilometerclient/blob/master/ceilometerclient/v2/client.py#L68 | 19:25 |
*** ig0r_ has quit IRC | 19:26 | |
*** afazekas has quit IRC | 19:26 | |
gordc | rjaiswal: right, but if we don't pass in project or tenant then it'll just be None. | 19:27 |
gordc | https://github.com/openstack/python-ceilometerclient/blob/master/ceilometerclient/client.py#L232-L235 doesn't actually validate. it just takes one or the other | 19:27 |
gordc | but if both are None. it'll still keep going... and i think we always need tenant or project. | 19:28 |
rjaiswal | Yes, the shell does the validation, i think | 19:28 |
rjaiswal | https://github.com/openstack/python-ceilometerclient/blob/master/ceilometerclient/shell.py#L219 | 19:28 |
rjaiswal | https://github.com/openstack/python-ceilometerclient/blob/master/ceilometerclient/shell.py#L184 | 19:29 |
gordc | right. so the shell is validated, so if you run command line it'll be valided. if i run client in python it won't go through shell part. | 19:30 |
rjaiswal | gordc: sure, makes sense | 19:30 |
rjaiswal | i will add the validation of the shell in the client as well | 19:30 |
rjaiswal | would that work | 19:31 |
gordc | rjaiswal: cool :). i think that makes sense... or it could just be friday. | 19:31 |
gordc | rjaiswal: had a question but why is the test change needed? | 19:31 |
gordc | i think i forgot to ask that. | 19:31 |
rjaiswal | so the test was passing initially with a command error because of the bug, but with the fix it raised an unauthorized error and not a command error | 19:32 |
*** openstack has joined #openstack-ceilometer | 19:33 | |
*** ChanServ sets mode: +v openstackstatus | 19:33 | |
rjaiswal | when we mocked it with the AuthPlugin, it actually started testing the V3 code | 19:33 |
gordc | hm that's so weird. i'll just accept it as so weird test we have. | 19:34 |
rjaiswal | so now its similar to https://github.com/openstack/python-ceilometerclient/blob/master/ceilometerclient/tests/unit/test_shell.py#L117 | 19:34 |
rjaiswal | the bug fix uncovered a test regression | 19:35 |
gordc | ah cool. nice | 19:35 |
rjaiswal | thanks gordc, will make the change and upload a new patchset | 19:36 |
gordc | rjaiswal: also regarding your listener patch. i have no idea how to do it. i think it's something we have to settle with... or wait for pool feature. | 19:36 |
gordc | sounds good | 19:36 |
rjaiswal | ok | 19:36 |
rjaiswal | gordc: yeah, i wanted to have that fixed before introducing dynamic event pipeline | 19:37 |
gordc | yeah... it'd be better to do it that way. but i think as long as pipeline's aren't adjusted a lot it should be ok. | 19:38 |
gordc | you can raise priority if you find the above isn't true isn't reality. | 19:39 |
gordc | in reality* | 19:39 |
rjaiswal | ok | 19:44 |
*** ddaskal has quit IRC | 19:50 | |
*** eglynn_ has joined #openstack-ceilometer | 19:52 | |
*** cdent has quit IRC | 20:11 | |
*** eglynn_ has quit IRC | 20:17 | |
*** cdent has joined #openstack-ceilometer | 20:22 | |
*** ildikov has quit IRC | 20:24 | |
*** _nadya_ has quit IRC | 20:33 | |
*** _nadya_ has joined #openstack-ceilometer | 20:33 | |
*** hhuang has quit IRC | 20:34 | |
openstackgerrit | Merged openstack/ceilometer: Provide base method for inspect_memory_resident https://review.openstack.org/207907 | 20:35 |
openstackgerrit | Rohit Jaiswal proposed openstack/python-ceilometerclient: tenant_id not required with keystone v3 https://review.openstack.org/207724 | 20:35 |
*** _nadya_ has quit IRC | 20:38 | |
*** ildikov has joined #openstack-ceilometer | 20:41 | |
*** ankita_w_ has joined #openstack-ceilometer | 20:42 | |
*** ankita_w_ has quit IRC | 20:43 | |
*** ankita_wagh has quit IRC | 20:44 | |
*** hhuang has joined #openstack-ceilometer | 20:47 | |
*** thorst has quit IRC | 20:50 | |
openstackgerrit | Chris Dent proposed openstack/aodh: Correct database functional tests https://review.openstack.org/207840 | 21:01 |
*** fawadkhaliq has joined #openstack-ceilometer | 21:06 | |
*** changbl has quit IRC | 21:09 | |
*** fawadkhaliq has quit IRC | 21:11 | |
*** prad has quit IRC | 21:14 | |
*** cdent has quit IRC | 21:15 | |
*** ddaskal has joined #openstack-ceilometer | 21:19 | |
*** boris-42 has joined #openstack-ceilometer | 21:23 | |
*** superflyy has joined #openstack-ceilometer | 21:31 | |
*** yassine has quit IRC | 21:31 | |
*** primechuck has quit IRC | 21:43 | |
*** thorst has joined #openstack-ceilometer | 21:51 | |
*** thorst has quit IRC | 21:53 | |
*** ildikov has quit IRC | 21:56 | |
openstackgerrit | Rohit Jaiswal proposed openstack/ceilometer: Adds support for dynamic event pipeline https://review.openstack.org/208068 | 22:01 |
*** gordc has quit IRC | 22:04 | |
*** primechuck has joined #openstack-ceilometer | 22:04 | |
openstackgerrit | Merged openstack/ceilometer: gnocchi: reduce the number of patch to gnocchi API https://review.openstack.org/202589 | 22:05 |
*** htruta_____ has joined #openstack-ceilometer | 22:07 | |
*** pauldix has quit IRC | 22:11 | |
*** ddaskal has quit IRC | 22:11 | |
*** pauldix has joined #openstack-ceilometer | 22:12 | |
*** htruta_____ has quit IRC | 22:20 | |
*** htruta has quit IRC | 22:21 | |
*** ddieterly has quit IRC | 22:21 | |
*** jruano has quit IRC | 22:40 | |
*** superflyy has quit IRC | 22:52 | |
*** primechuck has quit IRC | 23:10 | |
*** _cjones_ has quit IRC | 23:18 | |
*** pauldix has quit IRC | 23:31 | |
*** julim has quit IRC | 23:37 | |
*** rjaiswal has quit IRC | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!