*** pauldix has joined #openstack-ceilometer | 00:05 | |
*** pauldix has quit IRC | 00:06 | |
*** pauldix has joined #openstack-ceilometer | 00:07 | |
*** haigang has joined #openstack-ceilometer | 00:35 | |
*** ddieterly has joined #openstack-ceilometer | 00:40 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ceilometer: Updated from global requirements https://review.openstack.org/205650 | 00:43 |
---|---|---|
openstackgerrit | OpenStack Proposal Bot proposed openstack/ceilometermiddleware: Updated from global requirements https://review.openstack.org/204849 | 00:43 |
*** edmondsw has quit IRC | 00:45 | |
openstackgerrit | gordon chung proposed openstack/ceilometer: group pollsters by interval https://review.openstack.org/208745 | 00:57 |
rjaiswal | requesting reviews for https://review.openstack.org/#/c/207724/ | 01:11 |
*** exploreshaifali has quit IRC | 01:12 | |
*** haigang has quit IRC | 01:26 | |
*** haigang has joined #openstack-ceilometer | 01:27 | |
*** wayneeseguin has quit IRC | 01:31 | |
*** wayneeseguin has joined #openstack-ceilometer | 01:31 | |
*** thorst has quit IRC | 01:42 | |
*** ityaptin has quit IRC | 01:55 | |
*** ddieterly has quit IRC | 01:55 | |
*** ddieterly has joined #openstack-ceilometer | 02:14 | |
*** fabian1 has joined #openstack-ceilometer | 02:16 | |
*** pauldix has quit IRC | 02:35 | |
*** pauldix has joined #openstack-ceilometer | 02:36 | |
*** fabian1 has quit IRC | 02:43 | |
*** fabian1 has joined #openstack-ceilometer | 02:58 | |
openstackgerrit | gordon chung proposed openstack/ceilometer: group pollsters by interval https://review.openstack.org/208745 | 03:35 |
*** eglynn_ has joined #openstack-ceilometer | 03:42 | |
*** eglynn_ has quit IRC | 03:47 | |
*** afazekas has joined #openstack-ceilometer | 03:54 | |
openstackgerrit | gordon chung proposed openstack/ceilometer: minimise scope of hmac mocking https://review.openstack.org/208783 | 03:59 |
openstackgerrit | liusheng proposed openstack/ceilometer-specs: Support composite threshold rule alarm https://review.openstack.org/208786 | 04:10 |
*** ddieterly has quit IRC | 04:17 | |
*** haigang has quit IRC | 04:22 | |
*** yprokule has joined #openstack-ceilometer | 04:23 | |
*** haigang has joined #openstack-ceilometer | 04:25 | |
*** jdandrea has quit IRC | 04:30 | |
*** pauldix has joined #openstack-ceilometer | 04:37 | |
*** rohit has joined #openstack-ceilometer | 04:41 | |
*** pauldix has quit IRC | 04:41 | |
*** julim has quit IRC | 04:47 | |
*** rjaiswal has quit IRC | 04:50 | |
*** haigang has quit IRC | 05:04 | |
*** changbl has joined #openstack-ceilometer | 05:09 | |
*** fawadkhaliq has joined #openstack-ceilometer | 05:14 | |
*** fawadk has joined #openstack-ceilometer | 05:15 | |
*** fawadkhaliq has quit IRC | 05:18 | |
*** neelabh_ has joined #openstack-ceilometer | 05:28 | |
neelabh_ | which Rest API can get all tenant instance information | 05:36 |
neelabh_ | I want to fetch all instance through rest-api, please tell me the Rest-api which can call the all tenant instance.. | 05:37 |
*** ddieterly has joined #openstack-ceilometer | 05:49 | |
*** haigang has joined #openstack-ceilometer | 05:50 | |
*** afazekas has quit IRC | 05:50 | |
*** ddieterly has quit IRC | 05:53 | |
*** nadya has joined #openstack-ceilometer | 06:21 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ceilometer: Imported Translations from Transifex https://review.openstack.org/208833 | 06:27 |
*** belmoreira has joined #openstack-ceilometer | 06:31 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/aodh: Imported Translations from Transifex https://review.openstack.org/208841 | 06:33 |
*** ddieterly has joined #openstack-ceilometer | 06:49 | |
*** ddieterly has quit IRC | 06:54 | |
*** h00327910__ has joined #openstack-ceilometer | 07:01 | |
*** nadya has quit IRC | 07:02 | |
*** admin0 has joined #openstack-ceilometer | 07:05 | |
*** ityaptin has joined #openstack-ceilometer | 07:08 | |
*** cmyster has joined #openstack-ceilometer | 07:10 | |
*** cmyster has joined #openstack-ceilometer | 07:10 | |
*** fawadkhaliq has joined #openstack-ceilometer | 07:12 | |
openstackgerrit | Merged openstack/aodh: Imported Translations from Transifex https://review.openstack.org/208841 | 07:14 |
openstackgerrit | Merged openstack/gnocchi: gate: fixup gabbi live tests https://review.openstack.org/206510 | 07:14 |
*** fawadk has quit IRC | 07:14 | |
*** fawadk has joined #openstack-ceilometer | 07:15 | |
*** fawadkhaliq has quit IRC | 07:18 | |
*** safchain has joined #openstack-ceilometer | 07:35 | |
*** cdent has joined #openstack-ceilometer | 07:36 | |
*** lsmola has joined #openstack-ceilometer | 07:42 | |
cdent | so, jd__, sileht: This stuff I've been doing to make aodh functional tests go has made it pretty clear to me we need to get them going sooner than later because our test coverage for "running in real life" completely sucks without them (as evidenced by the keystonemiddleware issue, but there are others). | 07:42 |
cdent | However, I'm really sure what to do next. | 07:43 |
*** nadya has joined #openstack-ceilometer | 07:43 | |
sileht | cdent, tell me perhaps I can help (instead of fixing wsme ;p) | 07:43 |
cdent | have you seen my responses to your comments | 07:44 |
* sileht opens gerrit | 07:44 | |
cdent | the core issue at this point is how to give a conf to a middleware that is paste deployed | 07:44 |
cdent | or we need to make aodh not paste deploy | 07:44 |
cdent | that's the current hangup, but it seems there might be others | 07:45 |
*** fawadk has quit IRC | 07:45 | |
sileht | I got it | 07:48 |
*** tasdomas has quit IRC | 07:49 | |
*** tasdomas has joined #openstack-ceilometer | 07:49 | |
*** ddieterly has joined #openstack-ceilometer | 07:50 | |
sileht | cdent, gabbi xfail is just awesome to track API issues | 07:55 |
*** ddieterly has quit IRC | 07:55 | |
cdent | i know right! :) | 07:56 |
*** fawadkhaliq has joined #openstack-ceilometer | 07:57 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/ceilometer: WIP: Remove xfail tests fixed in wsme https://review.openstack.org/208467 | 08:01 |
*** yassine has joined #openstack-ceilometer | 08:01 | |
*** yassine has quit IRC | 08:01 | |
*** fabian1 has quit IRC | 08:02 | |
*** yassine has joined #openstack-ceilometer | 08:03 | |
*** Ala has joined #openstack-ceilometer | 08:04 | |
*** fawadkhaliq has quit IRC | 08:06 | |
*** bdossant has joined #openstack-ceilometer | 08:14 | |
*** _gryf has joined #openstack-ceilometer | 08:17 | |
sileht | cdent, I see a solution for the keystone middleware issue | 08:21 |
sileht | cdent, the configuration of the middleware must be done into the api_paste configuration file | 08:21 |
cdent | nice! | 08:21 |
cdent | well yeah, I considered that option but it seems...weird | 08:21 |
sileht | cdent, the middleware starts to look into the paste configuration and then fallback to oslo.config | 08:22 |
*** fabian1 has joined #openstack-ceilometer | 08:22 | |
cdent | what do we tell people who are installing aodh: oh by the way you know how all the config you normally do goes in this one file over here usually, well for this particular thing you need to put it in here | 08:22 |
sileht | cdent, <= havana all applications was doing , I don't remember why but everybody switch to oslo.config | 08:22 |
cdent | to which they respond: well I dont' have to do that for anything else, like nova or keystone, so what's special about aodh? | 08:22 |
sileht | I known this really sucks a wsgi 'middleware' just rely to a dict nothing else any other thing sucks | 08:23 |
sileht | I have an other idea, I will propose a change to keystonemiddle sound | 08:24 |
*** Ala has quit IRC | 08:33 | |
sileht | sound/soon | 08:34 |
*** wayneeseguin has quit IRC | 08:35 | |
*** titilambert has quit IRC | 08:35 | |
*** bdossant has quit IRC | 08:36 | |
*** wayneeseguin has joined #openstack-ceilometer | 08:37 | |
*** titilambert has joined #openstack-ceilometer | 08:37 | |
*** bdossant has joined #openstack-ceilometer | 08:37 | |
*** pauldix has joined #openstack-ceilometer | 08:38 | |
*** Ala has joined #openstack-ceilometer | 08:39 | |
*** Ala has quit IRC | 08:41 | |
*** Ala has joined #openstack-ceilometer | 08:42 | |
*** pauldix has quit IRC | 08:43 | |
*** bdossant has quit IRC | 08:43 | |
*** bdossant has joined #openstack-ceilometer | 08:44 | |
openstackgerrit | Chris Dent proposed openstack/aodh: Correct database functional tests https://review.openstack.org/207840 | 08:49 |
cdent | jd__, sileht: there's another issue related to the aodh functional tests that I'm not clear about, but seem to have a memory of it coming up somewhere else: http://logs.openstack.org/40/207840/7/experimental/gate-aodh-dsvm-functional-mongodb/c5d311e/logs/apache/aodh.txt.gz#_2015-08-03_20_54_47_959554 | 08:50 |
*** ddieterly has joined #openstack-ceilometer | 08:51 | |
*** alexpilotti has quit IRC | 08:51 | |
*** alexpilotti has joined #openstack-ceilometer | 08:52 | |
*** ddieterly has quit IRC | 08:56 | |
sileht | cdent, this looks a bug into the translation middleware | 08:56 |
sileht | cdent, I guess ceilometer have the same bug | 08:56 |
cdent | sileht: I tried to find an existing bug but had no luck so I guess I'll make one? | 08:59 |
sileht | cdent, unfortunatly I guess this bug, just hide another exception | 09:01 |
cdent | yeah | 09:01 |
cdent | infinite onion | 09:01 |
cdent | https://bugs.launchpad.net/aodh/+bug/1481244 | 09:08 |
openstack | Launchpad bug 1481244 in Ceilometer "TranslationHook middleware can lose track of its thread local storage" [Undecided,New] | 09:08 |
openstackgerrit | Merged openstack/ceilometermiddleware: Updated from global requirements https://review.openstack.org/204849 | 09:13 |
*** boris-42 has quit IRC | 09:30 | |
*** fawadkhaliq has joined #openstack-ceilometer | 09:31 | |
*** Ala has quit IRC | 09:41 | |
*** rmar04 has joined #openstack-ceilometer | 09:43 | |
rmar04 | Morning! QQ! How best do I purge old data from Ceilometer MongoDB. Is there any way built in to do this? | 09:44 |
*** neelabh_ has quit IRC | 09:46 | |
cdent | rmar04: there's a command line script called ceilometer-expirer, but mongodb has built in time to live setting, see here: http://docs.openstack.org/admin-guide-cloud/content/section_telemetry-storing-data.html | 09:46 |
*** ddieterly has joined #openstack-ceilometer | 09:52 | |
*** openstackgerrit_ has joined #openstack-ceilometer | 09:53 | |
rmar04 | oh excellent! I will take a look! thanks! | 09:53 |
*** ddieterly has quit IRC | 09:57 | |
*** neelabh_ has joined #openstack-ceilometer | 10:00 | |
*** rmar04 has quit IRC | 10:10 | |
*** haigang has quit IRC | 10:14 | |
sileht | cdent, my proposal to fix the keystonemiddleware crap: | 10:21 |
sileht | https://review.openstack.org/208965 | 10:21 |
* cdent looks | 10:30 | |
cdent | sileht: does this also get rid of the need for the keystoneclient.auth hack ? | 10:33 |
sileht | cdent, yes | 10:33 |
cdent | cool | 10:33 |
cdent | looks like a reasonable compromise | 10:34 |
sileht | I haven't tested yet in real an env | 10:34 |
sileht | I guess I just have to start aodh api and do a request to ensure it works? | 10:34 |
* sileht will try | 10:34 | |
*** fawadk has joined #openstack-ceilometer | 10:35 | |
cdent | sileht: pretty much. the default devstack keystone doesn't use https, but the if it is not loading the aodh.conf then it will try to | 10:35 |
cdent | brb | 10:35 |
cdent | s/if it/if the middleware/ | 10:35 |
*** fawadkhaliq has quit IRC | 10:37 | |
*** fawadkhaliq has joined #openstack-ceilometer | 10:38 | |
*** fawadk has quit IRC | 10:43 | |
sileht | cdent, it works | 10:45 |
cdent | \o/ | 10:45 |
* sileht have missed something it works even without my change | 10:46 | |
* sileht doesn't have le latest aodg | 10:47 | |
cdent | hmmm | 10:47 |
cdent | that's kind of what I meant above about how our testing coverage is not ideal: we've move a _lot_ changes recently that are pretty much untested | 10:48 |
*** jaosorior has joined #openstack-ceilometer | 10:48 | |
sileht | cdent, it works, I was missed some jd changes :) | 10:49 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/aodh: WIP: Load keystonemiddleware configuration https://review.openstack.org/208989 | 10:53 |
*** ddieterly has joined #openstack-ceilometer | 10:53 | |
*** ddieterly has quit IRC | 10:58 | |
*** eglynn_ has joined #openstack-ceilometer | 10:59 | |
*** nadya has quit IRC | 11:02 | |
*** nadya has joined #openstack-ceilometer | 11:06 | |
*** nadya has quit IRC | 11:07 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/ceilometer: Disable a test that fail really often in gate https://review.openstack.org/208994 | 11:09 |
cdent | sileht: doesn't gordc have a patch for that already? | 11:12 |
*** Ala has joined #openstack-ceilometer | 11:15 | |
*** fabian1 has left #openstack-ceilometer | 11:15 | |
* cdent has picnic | 11:17 | |
*** julim has joined #openstack-ceilometer | 11:25 | |
*** thorst has joined #openstack-ceilometer | 11:27 | |
*** bdossant_ has joined #openstack-ceilometer | 11:27 | |
*** bdossant has quit IRC | 11:29 | |
*** bdossant_ has quit IRC | 11:30 | |
*** openstackgerrit has quit IRC | 11:31 | |
*** openstackgerrit_ is now known as openstackgerrit | 11:31 | |
*** openstackgerrit has quit IRC | 11:32 | |
*** openstackgerrit_ has joined #openstack-ceilometer | 11:32 | |
*** openstackgerrit_ is now known as openstackgerrit | 11:32 | |
*** openstackgerrit_ has joined #openstack-ceilometer | 11:33 | |
*** eglynn_ has quit IRC | 11:43 | |
*** eglynn__ has joined #openstack-ceilometer | 11:44 | |
*** fawadkhaliq has quit IRC | 11:48 | |
*** Ala has quit IRC | 11:53 | |
*** ddieterly has joined #openstack-ceilometer | 11:54 | |
*** haigang has joined #openstack-ceilometer | 11:56 | |
*** gordc has joined #openstack-ceilometer | 11:58 | |
*** ddieterly has quit IRC | 11:58 | |
*** haigang has quit IRC | 11:59 | |
*** Ala has joined #openstack-ceilometer | 12:07 | |
*** pauldix has joined #openstack-ceilometer | 12:15 | |
openstackgerrit | gordon chung proposed openstack/ceilometer: minimise scope of hmac mocking https://review.openstack.org/208783 | 12:16 |
*** openstackgerrit has quit IRC | 12:16 | |
*** openstackgerrit has joined #openstack-ceilometer | 12:16 | |
*** fawadkhaliq has joined #openstack-ceilometer | 12:23 | |
*** edmondsw has joined #openstack-ceilometer | 12:27 | |
*** Ala has quit IRC | 12:33 | |
*** Ala has joined #openstack-ceilometer | 12:38 | |
*** nadya has joined #openstack-ceilometer | 12:42 | |
*** nadya has quit IRC | 12:43 | |
*** cdent has quit IRC | 12:48 | |
*** pauldix has quit IRC | 12:48 | |
*** alexpilotti has quit IRC | 12:52 | |
*** alexpilotti has joined #openstack-ceilometer | 12:53 | |
*** ildikov has joined #openstack-ceilometer | 12:56 | |
*** nadya has joined #openstack-ceilometer | 13:00 | |
*** jruano has joined #openstack-ceilometer | 13:01 | |
*** jdandrea has joined #openstack-ceilometer | 13:02 | |
*** primechuck has joined #openstack-ceilometer | 13:04 | |
*** primechuck has quit IRC | 13:05 | |
*** cdent has joined #openstack-ceilometer | 13:31 | |
*** pauldix has joined #openstack-ceilometer | 13:32 | |
*** pauldix has quit IRC | 13:37 | |
*** pauldix has joined #openstack-ceilometer | 13:37 | |
*** tongli has joined #openstack-ceilometer | 13:38 | |
*** dikonoor has joined #openstack-ceilometer | 13:39 | |
dikonoor | gordc:Hi gordc . Who else should be reviewing this spec https://review.openstack.org/#/c/207141/ | 13:40 |
gordc | dikonoor: anyone :) | 13:42 |
gordc | i would probably start working on it in meantime. | 13:43 |
*** thumpba has joined #openstack-ceilometer | 13:43 | |
openstackgerrit | Merged openstack/ceilometer: [MongoDB] Refactor indexes for meter and resources https://review.openstack.org/207409 | 13:43 |
dikonoor | gordc: ok sure .Could you suggest someone else we can add as reviewer | 13:44 |
gordc | dikonoor: i should mention there's ~3weeks until freeze | 13:44 |
dikonoor | gordc: Ah..ok..good that you mentioned that | 13:44 |
* gordc thinks about who to throw under the bus | 13:44 | |
gordc | cores you have 3minutes to bribe me to not mention your name. | 13:45 |
dikonoor | gordc: Please think hard and get someone to review so that we don't have to go back and forth with the fix :) | 13:45 |
dikonoor | gordc: or can you give another +2 ;-P | 13:46 |
gordc | dikonoor: i could. but i don't trust myself after my first taste of power. | 13:47 |
cdent | dikonoor: that's been on my list to give a proper review, but I keep getting distracted by live bugs | 13:47 |
cdent | but it is still on my radar | 13:47 |
gordc | dikonoor: i've added a few ppl. | 13:48 |
dikonoor | gordc:cdent: Thanks very much | 13:48 |
gordc | cdent: my comments in https://bugs.launchpad.net/ceilometer/+bug/1480442 make sense? | 13:50 |
openstack | Launchpad bug 1480442 in Ceilometer "stop polling per pipeline" [High,Triaged] - Assigned to gordon chung (chungg) | 13:50 |
*** Ala has quit IRC | 13:52 | |
cdent | I think I'm just going to have to take your word for it gordc, I tried, really hard to fall in love with the pipeline.yaml format but it rejects me, over and over | 13:53 |
cdent | It is just way too overloaded | 13:53 |
gordc | cdent: yeah. i think it's because we're still reusing part of pipeline logic in polling but we really shouldn't be. | 13:54 |
*** yprokule has quit IRC | 13:54 | |
cdent | gordc: thanks for point out where the cache is being used but it still doesn't really make it clear how the cache got broken | 13:56 |
cdent | pretend I'm five | 13:56 |
*** changbl has quit IRC | 13:56 | |
*** yprokule has joined #openstack-ceilometer | 13:57 | |
*** Ala has joined #openstack-ceilometer | 13:58 | |
gordc | cdent: cache is built each polling cycle. cache is per pollingtask. cache is not shared across pollingtask because they are not necessarily run at same time (just same interval) | 13:59 |
cdent | yeah, I get that, but I don't get what the cache is caching | 13:59 |
gordc | cdent: we don't have tests. i'm too tired to write tests | 13:59 |
cdent | and how that would impact sample handling | 13:59 |
gordc | it's caching the results from service polls | 13:59 |
gordc | it's two parts. | 14:00 |
gordc | we process each pipeline as it's own... it's not gather data, feed through pipeline... it's enter pipeline, gather data. | 14:00 |
gordc | so it polls per pipeline. | 14:01 |
cdent | so the cache answers "did I already do this one?" | 14:03 |
gordc | the cache saves the poll.. so if you polled in one pipeline, a subsequent poll will use cache if it exists | 14:03 |
gordc | yes | 14:03 |
gordc | did i already do this one (during this poll cycle) | 14:03 |
cdent | we should completely wreck pipeline.yaml at some point in the future | 14:05 |
cdent | (along with everything else) | 14:07 |
gordc | yeah... or we need to build a polling yaml... i think one of the issues is we're building the sample at polling agent | 14:07 |
ildikov | cdent: +1 (maybe not for everything at least yet :) ) | 14:08 |
_gryf | ?ver | 14:08 |
_gryf | ups | 14:08 |
*** changbl has joined #openstack-ceilometer | 14:09 | |
gordc | caching is first issue. second issue is because it's still pipeline based, it's sending cpu meter twice because it's defined in pipeline. but in reality, the pipeline would've tossed one of the cpu samples when building cpu_util | 14:11 |
* sileht can't get https://review.openstack.org/#/c/206560/ merged after 5 recheck, because of the f*@!#^W eventlet, responsible of our notification test bug | 14:12 | |
gordc | sileht: fifth time is charm. | 14:12 |
gordc | i wonder what is different that is causing that test to fail more often now. | 14:13 |
gordc | sileht: we can block test, take my patch, or delete the test... | 14:13 |
sileht | gordc, I would give a try to your change, it should reduce the bug occurence a lot | 14:14 |
gordc | sileht: kk. that or we delete... don't tell anyone we deleted it. | 14:14 |
cdent | I think deleting it kind of makes sense: there's always a slim chance that hmac will be called when eventlet is active | 14:15 |
* sileht just erase the last line from its history | 14:15 | |
*** eglynn__ has quit IRC | 14:15 | |
cdent | it's a bogus test | 14:15 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/ceilometer: Disable a test that fail really often in gate https://review.openstack.org/208994 | 14:15 |
gordc | i'm going to walk away from computer for a bit. whatever happens happens. | 14:16 |
sileht | :) | 14:16 |
* sileht starts investigation on a less funny bug: https://bugs.launchpad.net/gnocchi/+bug/1479429 | 14:18 | |
openstack | Launchpad bug 1479429 in Gnocchi "aggregation: issue when one of the resource is no more updated" [Undecided,New] | 14:18 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ceilometer: Updated from global requirements https://review.openstack.org/205650 | 14:21 |
gordc | https://review.openstack.org/#/c/208783 | 14:27 |
cdent | aw man, I was totally gonna +A that | 14:30 |
gordc | cdent: lol wanted to minimise the blood on people's hands. | 14:31 |
gordc | but go ahead and double it. | 14:31 |
*** jasonamyers has joined #openstack-ceilometer | 14:36 | |
*** yprokule has quit IRC | 14:37 | |
*** rbak has joined #openstack-ceilometer | 14:40 | |
*** pradk has joined #openstack-ceilometer | 14:41 | |
*** yprokule has joined #openstack-ceilometer | 14:44 | |
idegtiarov | gordc, hi! could you please take a look at ML about Timeout Event Alarms i've sent it today. I need your help in choosing the best way for its implementation. | 14:51 |
gordc | idegtiarov: sure thing. will take a look in a bit. | 14:52 |
gordc | idegtiarov: you have a link? | 14:52 |
*** rjaiswal has joined #openstack-ceilometer | 14:54 | |
idegtiarov | gordc, sorry not yet /me trying to find | 14:54 |
gordc | idegtiarov: nm. i found it in email. | 14:55 |
idegtiarov | gordc, thanks | 14:55 |
*** rbak has quit IRC | 14:55 | |
*** rbak has joined #openstack-ceilometer | 14:57 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/aodh: gnocchi: percent_of_overlap=0 for agg. alarms https://review.openstack.org/209109 | 14:58 |
rjaiswal | gordc: https://review.openstack.org/#/c/207724/, https://review.openstack.org/#/c/200238/ ready for review, request you take a look | 14:59 |
*** belmoreira has quit IRC | 15:01 | |
gordc | rjaiswal: is there a reason you're making the alarm change in ceilometer and not aodh? | 15:07 |
gordc | alarms in ceilometer are deprecated. | 15:07 |
rjaiswal | gordc: same change in aodh is blocked in aodh for lack of migration schema: https://review.openstack.org/#/c/200315/ | 15:13 |
*** pradk has quit IRC | 15:14 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/aodh: gnocchi: percent_of_overlap=0 for agg. alarms https://review.openstack.org/209109 | 15:16 |
gordc | rjaiswal: migrations are being merged as we speak https://review.openstack.org/#/c/206459/ | 15:18 |
gordc | jd__: want to unblock rjaiswal's patch? | 15:18 |
rjaiswal | gordc: cool! | 15:19 |
sileht | cdent, I wonder if we can add something to check the len of a json array in gabbi | 15:22 |
*** IBerezovskiy has joined #openstack-ceilometer | 15:23 | |
cdent | sileht: I've thought about that several times and was hoping there was someway to do with jsonpath, or an extension to jsonpath (the library, jsonpath_rw) has some ways to extend itself | 15:24 |
cdent | but I've yet to get around to it | 15:25 |
cdent | one hackyway to get the same test is to: | 15:25 |
cdent | $.foo[-1]: somevalue | 15:25 |
cdent | $.foo[10]: the samevalue | 15:25 |
cdent | this confirms the list is 11 long | 15:25 |
cdent | well, "confirms" is a bit strong | 15:25 |
openstackgerrit | Merged openstack/aodh: Use mocked object to test log message https://review.openstack.org/208205 | 15:26 |
openstackgerrit | Merged openstack/aodh: Add alembic support for aodh https://review.openstack.org/206459 | 15:26 |
sileht | I see but heat generates everything with uuid and hash, it's hard to predict something | 15:26 |
*** edmondsw has quit IRC | 15:26 | |
* cdent nods | 15:26 | |
* sileht try to write the downscaling gabbit scenario to showup https://bugs.launchpad.net/gnocchi/+bug/1479429 | 15:27 | |
openstack | Launchpad bug 1479429 in Gnocchi "aggregation: issue when one of the resource is no more updated" [Undecided,New] - Assigned to Mehdi Abaakouk (sileht) | 15:27 |
*** pradk has joined #openstack-ceilometer | 15:27 | |
cdent | sileht: if you can figure out "named operators" on here, http://jsonpath-rw.readthedocs.org/en/latest/#jsonpath-syntax | 15:29 |
cdent | that might be a start in the right direction | 15:29 |
sileht | interesting | 15:30 |
cdent | `parent` looks like an existing extension | 15:30 |
cdent | It's not clear from the code if the ability to add extension ever got exposed with a friendly api | 15:31 |
cdent | https://github.com/kennknowles/python-jsonpath-rw/blob/master/jsonpath_rw/parser.py#L94 | 15:32 |
rjaiswal | thanks gordc | 15:33 |
openstackgerrit | Pradeep Kilambi proposed openstack/ceilometer: Update install docs with gnocchi dispatcher info https://review.openstack.org/206110 | 15:34 |
sileht | cdent, Thanks, I think I see how to implement 'len' :) | 15:35 |
cdent | awesome | 15:35 |
*** IBerezovskiy has quit IRC | 15:36 | |
*** IBerezovskiy has joined #openstack-ceilometer | 15:37 | |
*** yassine has quit IRC | 15:47 | |
openstackgerrit | Tom Cocozzello proposed openstack/ceilometermiddleware: Activate pep8 check that _ is imported https://review.openstack.org/209145 | 15:48 |
*** Ala has quit IRC | 15:56 | |
*** primechuck has joined #openstack-ceilometer | 15:56 | |
*** pauldix has quit IRC | 15:57 | |
*** pauldix has joined #openstack-ceilometer | 15:57 | |
*** jasonamyers has quit IRC | 15:58 | |
*** _cjones_ has joined #openstack-ceilometer | 16:00 | |
*** nadya has quit IRC | 16:12 | |
*** luv has left #openstack-ceilometer | 16:13 | |
sileht | cdent, https://github.com/cdent/gabbi/pull/76 | 16:14 |
* cdent looks | 16:15 | |
gordc | rjaiswal: are you looking at this bug? https://bugs.launchpad.net/ceilometer/+bug/1475441 | 16:15 |
openstack | Launchpad bug 1475441 in Ceilometer "rgw still throwing errors" [Medium,Triaged] - Assigned to Rohit Jaiswal (rohit-jaiswal-3) | 16:15 |
cdent | sileht: that's very cool | 16:16 |
cdent | I've got some questions, but I'll put them on the pull | 16:17 |
*** pauldix has quit IRC | 16:17 | |
*** pauldix has joined #openstack-ceilometer | 16:18 | |
openstackgerrit | gordon chung proposed openstack/ceilometer: add poll history to avoid duplicate samples https://review.openstack.org/209160 | 16:20 |
rjaiswal | gorc: yes, i was thinking of pulling the import of the rgwclient in the init method | 16:25 |
rjaiswal | gordc: regarding https://bugs.launchpad.net/ceilometer/+bug/1475441 ^^ | 16:27 |
openstack | Launchpad bug 1475441 in Ceilometer "rgw still throwing errors" [Medium,Triaged] - Assigned to Rohit Jaiswal (rohit-jaiswal-3) | 16:27 |
*** openstackgerrit_ has quit IRC | 16:29 | |
gordc | rjaiswal: kk. the main problem right now is that it's not actually using the PollsterPermanentError properly | 16:33 |
gordc | it's pass the error in. https://github.com/openstack/ceilometer/blob/master/ceilometer/objectstore/rgw.py#L97 | 16:33 |
gordc | it should be passing in the resource | 16:33 |
rjaiswal | gordc: got it, will give that a try | 16:35 |
*** edmondsw has joined #openstack-ceilometer | 16:42 | |
cdent | gordc i'm sure you already know this, but all the changes you've needed to make to recover from my polling agent change mean we have pretty bad coverage of reality (whatever the cover numbers might say) | 16:46 |
cdent | sorry about that, by the way, I overestimated the amount of sanity in the system and the coverage too | 16:47 |
cdent | :( | 16:47 |
gordc | cdent: yeah... i noticed. | 16:47 |
gordc | i was going to write some tests but realise there were no tests to copy/modify | 16:48 |
gordc | and i hate writing tests so i don't really want to continue my patches. | 16:48 |
cdent | oh dear | 16:48 |
cdent | might be time to write the pollster equivalent of gabbi | 16:49 |
gordc | cdent: you? i know you're not talking about me! | 16:50 |
cdent | I was hoping for some as yet unknown third party to come along and make it happen | 16:50 |
gordc | same. i've been waiting for a while. | 16:50 |
cdent | what have you been doing to find these issues in the first place? | 16:50 |
cdent | maybe we should just automate that | 16:50 |
gordc | i'm waiting for someone who will write tests for my patches... where can i find this person | 16:51 |
cdent | sileht, jd__, prad and you too gordc : https://tank.peermore.com/tanks/cdent-rhat/LongRunningGnocchi | 16:51 |
*** fawadkhaliq has quit IRC | 16:52 | |
gordc | the double poll issue? i can't recall... i put a breakpoint in nova_client code...i can't remember why | 16:52 |
*** jasonamyers has joined #openstack-ceilometer | 16:53 | |
cdent | do we have a design summit topics etherpad running yet? | 16:53 |
gordc | nope. | 16:54 |
cdent | gordc: I think your guy just showed up | 16:54 |
cdent | jasonamyers loves tests | 16:54 |
jasonamyers | WAT? | 16:54 |
gordc | jasonamyers: yeah?!?! i've got a few patches for you | 16:54 |
* jasonamyers looks for the textual close button.... | 16:54 | |
cdent | :) | 16:54 |
gordc | no tests... but hte code is there. it's relativley easy to understand with zero context | 16:55 |
jasonamyers | okay | 16:55 |
cdent | gordc is lucifer | 16:55 |
jasonamyers | I've normally got that zero context stuff nailed | 16:55 |
cdent | he lies on top of his lies | 16:55 |
jasonamyers | ha | 16:55 |
gordc | lol two lies make a truth. | 16:55 |
gordc | i'm an honest man. | 16:55 |
jasonamyers | that math... isn't proven | 16:56 |
jasonamyers | okay so link me a review? | 16:56 |
gordc | cdent: there's no etherpad. you can start one... or you can add it to future roadmap? | 16:56 |
cdent | i'll look at the roadmap | 16:56 |
gordc | jasonamyers: i was joking. i don't feel like forcing someone to write tests for my stupid code.lol | 16:57 |
* jasonamyers shrugs okay | 16:57 | |
gordc | jasonamyers: that said, if you know how to test the polling agent logic that'd be great | 16:57 |
jasonamyers | the polling agent has logic? | 16:57 |
jasonamyers | hahaha | 16:57 |
gordc | :) | 16:57 |
gordc | this is pretty much the entire logic https://github.com/openstack/ceilometer/blob/master/ceilometer/agent/base.py#L131 | 16:57 |
jasonamyers | what part of that logic? | 16:57 |
gordc | but if you grep it in tests, it's never actually called. | 16:58 |
jasonamyers | Oh lord | 16:58 |
gordc | which is why this happened: https://bugs.launchpad.net/ceilometer/+bug/1480442 | 16:58 |
openstack | Launchpad bug 1480442 in Ceilometer "stop polling per pipeline" [High,In progress] - Assigned to gordon chung (chungg) | 16:58 |
gordc | nice side effect of my fix is i think it knocks the load on nova-api and compute agent down even more... | 16:59 |
jasonamyers | woot | 16:59 |
gordc | that or i made wrong changes and it's doing jack all now | 16:59 |
jasonamyers | I could test this | 16:59 |
jasonamyers | you got options here | 17:00 |
jasonamyers | so you can mock self | 17:00 |
jasonamyers | to return whatever | 17:00 |
jasonamyers | or replace it with a named_tuple | 17:01 |
jasonamyers | not gonna be fun, but it's doable | 17:01 |
jasonamyers | you need far to many tests for this one method though | 17:01 |
gordc | yeah. there's a bunch of different filtering done in the poll_and_notify method | 17:02 |
jasonamyers | I'd break that out | 17:02 |
jasonamyers | so it's easier to test stand alone | 17:02 |
jasonamyers | also line 155 is a waste | 17:03 |
jasonamyers | nevermind I see the duplicated logging now | 17:03 |
jasonamyers | but we continue with it anyway | 17:03 |
*** julim has quit IRC | 17:04 | |
gordc | should we think about how we want to properly separate pipeline from polling agent instead? i feel like we might be creating tests we'll end up scrapping | 17:05 |
gordc | i also said the above because i'm lazy and don't like writing tests.lol | 17:05 |
gordc | but not the entire reason | 17:05 |
jasonamyers | I don't mind writing tests | 17:06 |
jasonamyers | so long as they live for more than a month | 17:06 |
gordc | jasonamyers: well they'll live 3 months. i can't promise they live any longer | 17:06 |
jasonamyers | so if this was me, I'd break out the duplication check and black_listing check | 17:07 |
jasonamyers | that's a complex testable part that could just be a function call here | 17:08 |
jasonamyers | doing that makes mocking that part out more effective | 17:08 |
jasonamyers | it also gets non polling logic out of here | 17:08 |
jasonamyers | then we can mock out the pollster to return whatever for get_samples and publisher_utils to do the right thing as well | 17:09 |
gordc | jasonamyers: you have coding time available still? | 17:09 |
jasonamyers | a touch yet | 17:09 |
jasonamyers | s/yet/yeah | 17:09 |
jasonamyers | is there a ticket to clean this up? | 17:09 |
gordc | nope. | 17:10 |
jasonamyers | do you have something already where I just add these tests | 17:10 |
jasonamyers | or can I just submit something standalone? | 17:10 |
jasonamyers | that doesn't have a BP or a bug | 17:10 |
cdent | jasonamyers: maybe dependent patch on gordc's | 17:11 |
cdent | no bp or bug really required | 17:11 |
jasonamyers | he never linked me the patch :P | 17:11 |
cdent | ah, well | 17:12 |
gordc | https://review.openstack.org/#/q/status:open+project:openstack/ceilometer+branch:master+topic:bug/1480442,n,z | 17:12 |
gordc | i got side tracked looking at test history | 17:12 |
gordc | i think the one test we had got lost | 17:12 |
cdent | I killed some tests in my changes, I think | 17:13 |
gordc | cdent: don't acknowledge it... just do what we did earlier. delete and move on. | 17:14 |
gordc | bbl. grabbing lunch | 17:15 |
openstackgerrit | Matthew Edmonds proposed openstack/ceilometer-specs: Events RBAC via Policy https://review.openstack.org/207141 | 17:15 |
jasonamyers | okay so how do I make a patch or gordc's work? | 17:17 |
*** exploreshaifali has joined #openstack-ceilometer | 17:18 | |
*** dikonoor has quit IRC | 17:19 | |
cdent | jasonamyers: go to your ceilo checkout, make sure you're up to date with master, do a `git review -d whatever_his_review_number_is` | 17:19 |
cdent | then make a new branch from that | 17:19 |
cdent | when you do your own git review to submit, it will say you're submitting two things, zomg, are you sure | 17:20 |
cdent | and you are, in fact, sure | 17:20 |
cdent | that make sense? | 17:20 |
jasonamyers | yeap | 17:22 |
jasonamyers | one it | 17:22 |
*** pauldix has quit IRC | 17:23 | |
*** pauldix has joined #openstack-ceilometer | 17:24 | |
*** julim has joined #openstack-ceilometer | 17:34 | |
*** exploreshaifali_ has joined #openstack-ceilometer | 17:39 | |
gordc | cdent: anything blocking https://review.openstack.org/#/c/203032? | 17:40 |
* cdent looks | 17:40 | |
cdent | no, I just felt obliged to not +1 it until somebody else came round and had a look | 17:41 |
cdent | I'm happy to see it merge | 17:41 |
gordc | cool cool | 17:41 |
*** exploreshaifali has quit IRC | 17:41 | |
cdent | when they comments are that long it always gets a bit "who has yet more to say?" | 17:42 |
*** david-lyle has quit IRC | 17:48 | |
*** exploreshaifali_ has quit IRC | 17:58 | |
*** exploreshaifali has joined #openstack-ceilometer | 18:01 | |
cdent | sileht: new gabbi with len will be released sometime this evening | 18:03 |
openstackgerrit | Julien Danjou proposed openstack/gnocchi: InfluxDB storage driver https://review.openstack.org/165407 | 18:16 |
openstackgerrit | Julien Danjou proposed openstack/gnocchi: indexer: always eagerly load archive_policy https://review.openstack.org/209208 | 18:16 |
cdent | sileht: gabbi 1.2.0 released | 18:17 |
*** tongli has quit IRC | 18:19 | |
*** exploreshaifali has quit IRC | 18:19 | |
*** yprokule has quit IRC | 18:27 | |
*** pauldix has quit IRC | 18:37 | |
*** neelabh_ has quit IRC | 18:37 | |
*** boris-42 has joined #openstack-ceilometer | 18:53 | |
*** exploreshaifali has joined #openstack-ceilometer | 18:56 | |
*** exploreshaifali has quit IRC | 18:57 | |
*** ryanpetrello has quit IRC | 19:01 | |
*** exploreshaifali has joined #openstack-ceilometer | 19:02 | |
*** exploreshaifali_ has joined #openstack-ceilometer | 19:05 | |
*** exploreshaifali has quit IRC | 19:07 | |
*** exploreshaifali_ has quit IRC | 19:15 | |
*** nadya has joined #openstack-ceilometer | 19:22 | |
openstackgerrit | Merged openstack/python-ceilometerclient: tenant_id not required with keystone v3 https://review.openstack.org/207724 | 19:29 |
*** ryanpetrello has joined #openstack-ceilometer | 19:29 | |
openstackgerrit | Merged openstack/ceilometer: minimise scope of hmac mocking https://review.openstack.org/208783 | 19:39 |
nadya | cdent: Chris, hi! Have you ever faced with error "keystonemiddleware.auth_token._exceptions.ConfigurationError: unable to access signing_dir /var/cache/ceilometer"? | 19:42 |
pradk | nadya, permissions issue may be? | 19:45 |
*** lsmola has quit IRC | 19:46 | |
nadya | pradk: yep, it's during functional testing on gate... Not sure that I should explicitly grant permissions for this directory | 19:47 |
nadya | aha, this is CEILOMETER_AUTH_CACHE_DIR | 19:49 |
pradk | yea its set in devstack/settings file looks like | 19:50 |
gordc | prad: i'm going to add a tag to denote non-metric meters so we can block them in yaml def | 19:55 |
gordc | cool? | 19:55 |
*** ekarlso has quit IRC | 19:55 | |
*** ekarlso has joined #openstack-ceilometer | 19:57 | |
*** jasonamyers has quit IRC | 19:59 | |
pradk | gordc, add a tag where? | 20:03 |
*** thumpba has quit IRC | 20:03 | |
gordc | pradk: hmm i just thought some more. i'll just look for the hardcoded volume = 1 values and block them when loading (and disable_non_metric_meters is on. | 20:05 |
gordc | seems easier. i'll try that | 20:05 |
pradk | gordc, yea that might be simpler | 20:05 |
pradk | cool | 20:06 |
gordc | any luck getting the arithmetic stuff work? to compute volume value | 20:06 |
gordc | i vaguely recall the transformers do something similar so it might be worth looking at if you haven't started | 20:07 |
pradk | gordc, i started looking it that a little bit.. its turning out more tricky than i hoped | 20:08 |
pradk | gordc, so do the computation at the transformer level ? | 20:09 |
gordc | pradk: no | 20:09 |
gordc | but i think there is a transformer which does something similar to what you would need to do. | 20:09 |
pradk | oh ok | 20:09 |
nadya | gordc: Gordon, do you know if plugin.sh for Ceilometer is already in use during CI? | 20:11 |
gordc | nadya: i recall cdent is blocked by grenade i believe? | 20:12 |
cdent | what about me? | 20:13 |
gordc | i think there's a few gaps in that process the qa didn't figure out yet... don't quote me on that. | 20:13 |
cdent | oh yeah, that's correct | 20:13 |
cdent | I'm sort of working on aspects of that righ tnow | 20:14 |
cdent | but it is a bit tedious | 20:14 |
cdent | things have to move into place kind of out of order | 20:14 |
cdent | however, right now in the gate devstack/plugin.sh is not being used for any non-experimental jobs | 20:14 |
nadya | cdent: ok... do you have one minute for one quick question? | 20:15 |
cdent | I can try | 20:15 |
nadya | cdent: I'm still fighting with functional tests and have a problem with accessing CEILOMETER_AUTH_CACHE_DIR . Have you ever faced with it? | 20:17 |
nadya | it looks as follows | 20:17 |
nadya | keystonemiddleware.auth_token._exceptions.ConfigurationError: unable to access signing_dir /var/cache/ceilometer | 20:17 |
cdent | no, one sec, let me look in the code | 20:17 |
cdent | nadya: is $STACK_USER being set somewhere? | 20:19 |
cdent | if that's wrong then it may cause issues | 20:19 |
cdent | actually it may be the other way round | 20:20 |
cdent | nadya, in post_test_hook.sh the tests are being run as jenkins | 20:20 |
cdent | they should probably run as stack or $STACK_USER | 20:20 |
cdent | I made some changes to the aodh version of the same file, here: | 20:20 |
cdent | https://review.openstack.org/#/c/207840/8/aodh/tests/functional/hooks/post_test_hook.sh,cm | 20:20 |
nadya | cdent: great, I'll try that | 20:21 |
openstackgerrit | Merged openstack/ceilometer-specs: Events RBAC via Policy https://review.openstack.org/207141 | 20:22 |
openstackgerrit | Chris Dent proposed openstack/ceilometer: Grenade plugin using devstack plugin for ceilometer https://review.openstack.org/196441 | 20:29 |
gordc | pradk: apparently if you run eval("test['abc'] - test['def']") it'll actually compute properly. | 20:34 |
pradk | yea but eval is evil :) | 20:35 |
gordc | yeah. but if we're inputting the values... | 20:35 |
pradk | thats definitely one way | 20:35 |
pradk | i'm curious if someoe passes in 'rm -rf /*' and we eval it.. would that be the end of openstack ? :P | 20:36 |
gordc | what happens if i run that? don't tell me such things... i'll try it. | 20:37 |
pradk | lol gordc | 20:37 |
gordc | if you don't see me in a few minutes, just assume everything is gone. | 20:37 |
pradk | haha | 20:37 |
*** admin0 has quit IRC | 20:38 | |
openstackgerrit | Merged openstack/ceilometer: Updated from global requirements https://review.openstack.org/205650 | 20:43 |
openstackgerrit | Nadya Shakhat proposed openstack/ceilometer: Initial separating unit and functional tests https://review.openstack.org/204128 | 20:46 |
openstackgerrit | Merged openstack/ceilometer: Fix some gabbi tests https://review.openstack.org/208455 | 20:50 |
*** cdent has quit IRC | 21:00 | |
openstackgerrit | Nadya Shakhat proposed openstack/ceilometer: Initial separating unit and functional tests https://review.openstack.org/204128 | 21:03 |
*** nadya has quit IRC | 21:03 | |
*** thorst has quit IRC | 21:13 | |
*** pauldix has joined #openstack-ceilometer | 21:33 | |
*** safchain has quit IRC | 21:33 | |
*** thorst has joined #openstack-ceilometer | 21:36 | |
*** thumpba has joined #openstack-ceilometer | 21:38 | |
*** thorst has quit IRC | 21:42 | |
openstackgerrit | gordon chung proposed openstack/ceilometer: disable non-metric meter definitions https://review.openstack.org/209266 | 21:47 |
*** thumpba has quit IRC | 21:48 | |
*** thumpba has joined #openstack-ceilometer | 21:49 | |
*** primechuck has quit IRC | 21:52 | |
*** thumpba_ has joined #openstack-ceilometer | 21:56 | |
*** thumpba has quit IRC | 21:59 | |
*** edmondsw has quit IRC | 22:02 | |
*** thumpba_ has quit IRC | 22:03 | |
*** julim has quit IRC | 22:05 | |
*** pradk has quit IRC | 22:05 | |
*** thumpba has joined #openstack-ceilometer | 22:05 | |
*** julim has joined #openstack-ceilometer | 22:05 | |
*** julim has quit IRC | 22:05 | |
*** thumpba has quit IRC | 22:08 | |
*** thumpba has joined #openstack-ceilometer | 22:09 | |
*** thumpba has quit IRC | 22:09 | |
*** thumpba has joined #openstack-ceilometer | 22:10 | |
openstackgerrit | gordon chung proposed openstack/ceilometer: add poll history to avoid duplicate samples https://review.openstack.org/209160 | 22:20 |
*** gordc has quit IRC | 22:22 | |
*** thumpba has quit IRC | 22:31 | |
*** nijaba_ has joined #openstack-ceilometer | 22:33 | |
*** nijaba_ has quit IRC | 22:33 | |
*** nijaba_ has joined #openstack-ceilometer | 22:33 | |
*** nijaba has quit IRC | 22:34 | |
*** rbak has quit IRC | 22:35 | |
*** boris-42 has quit IRC | 22:40 | |
*** jaosorior has quit IRC | 23:14 | |
*** pauldix has quit IRC | 23:31 | |
*** thorst has joined #openstack-ceilometer | 23:31 | |
*** pauldix has joined #openstack-ceilometer | 23:35 | |
*** pauldix has quit IRC | 23:36 | |
*** boris-42 has joined #openstack-ceilometer | 23:37 | |
*** pauldix has joined #openstack-ceilometer | 23:44 | |
*** pauldix has quit IRC | 23:48 | |
*** pauldix has joined #openstack-ceilometer | 23:49 | |
*** pauldix has quit IRC | 23:52 | |
*** pauldix has joined #openstack-ceilometer | 23:56 | |
*** pauldix has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!