sc` | respun the repo build and the monolith still passes | 00:25 |
---|---|---|
sc` | as far as our testing framework says, the patches are good to go | 00:25 |
*** higgins has quit IRC | 02:18 | |
*** higgins has joined #openstack-chef | 02:18 | |
*** higgins` has joined #openstack-chef | 02:22 | |
*** higgins has quit IRC | 02:28 | |
*** eroux has quit IRC | 07:09 | |
*** eroux has joined #openstack-chef | 07:18 | |
*** s-mutin has joined #openstack-chef | 09:40 | |
*** mutin-s has quit IRC | 09:43 | |
sc` | the tl;dr on why they weren't passing was because of %r{} acting strangely for certain strings. changing it to %() alleviated the rubocop and rspec warnings | 12:11 |
*** os-chef-bot has joined #openstack-chef | 12:19 | |
sc` | bodgix: pike is going to be where cookstyle comes into play. i don't know if we'll want to tackle chef 13 in that release, or kick it to queens | 13:06 |
sc` | cookstyle looks to be a pretty easy change, and it can autocorrect most of its complaints | 13:07 |
sc` | that, with delivery local and perhaps inspec might be about all that the throughput can handle. maybe tk will speed that up | 13:08 |
sc` | zuulv3 looms if we want to tackle multinode again, or rock out some ansible playbooks. the latter seems like more work than i'd be willing to dole out | 13:09 |
bodgix | sc`: thanks for explaining. The patches look good to me anyway. I commented on the patch in case you haven't heard about cookstyle but looks like you;re on top of that :-) Actually, on second thought, cookstyle had some annoying rules which I wasn't used to. Especially it requires a comma after the last element of a hash which looks very strange to me… But maybe that's what the chef community is more used to | 13:18 |
sc` | yeah :) | 13:20 |
sc` | these cookbooks work all the way up to chef 12.21, which is the last release of chef-client 12. chef 13 is going to require refactoring | 13:22 |
sc` | pretty much the only thing cookstyle wants to do over straight rubocop is add a comma after the last element of every. single. hash. | 13:24 |
sc` | switching to cookstyle would be big fat cosmetic patches that only adds extra characters because... something | 13:25 |
sc` | in other words, some easy low hanging fruit commits | 13:26 |
sc` | i think enough time has passed since my message to the mailing list | 15:05 |
sc` | calbers: how do you feel about adding Ramereth to openstack-chef-core? | 15:05 |
sc` | idle on irc, but not gerrit :D | 15:06 |
calbers | sc` feeling good about it :) | 15:06 |
sc` | capital. looks like that's unanimous | 15:07 |
sc` | by the power of greyskull, i open a new browser tab | 15:07 |
calbers | :D do it | 15:08 |
sc` | and it is so | 15:09 |
sc` | Ramereth: you're officially part of openstack-chef-core. welcome! (one of us, one of us) | 15:10 |
calbers | Ramereth Welcome o/ | 15:12 |
sc` | i typically filter on [chef] and a few others to separate out the different bits of noise | 15:14 |
*** Dinesh_Bhor has quit IRC | 15:15 | |
sc` | our bug tracker is probably one of the least used in all of openstack, but it still exists | 15:22 |
sc` | i've done some light housekeeping here and there, but it's kind of stale | 15:23 |
sc` | most people prefer to hold on to their bugs, it seems :D | 15:24 |
*** openstackgerrit has joined #openstack-chef | 15:42 | |
openstackgerrit | Merged openstack/cookbook-openstack-network master: Fixes for Ocata, style and lint fixes for chefdk https://review.openstack.org/489869 | 15:42 |
openstackgerrit | Merged openstack/cookbook-openstack-telemetry master: Style and lint fixes for chefdk, deprecated Gemfile https://review.openstack.org/489871 | 15:44 |
openstackgerrit | Merged openstack/cookbook-openstack-compute master: Added cellv2 support https://review.openstack.org/469179 | 15:51 |
sc` | looks like 482567 needs to be poked with a sharp stick | 15:57 |
Ramereth | wooo | 16:26 |
* Ramereth feels like he's been knighted | 16:26 | |
Ramereth | sc` calbers: thanks! | 16:26 |
sc` | i considered jklare's message yesterday as a +1 :D | 16:28 |
*** higgins` has quit IRC | 18:23 | |
*** higgins has joined #openstack-chef | 18:26 | |
*** os-chef-bot has quit IRC | 19:30 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!