sc` | apt and yum were moved into chef core | 00:44 |
---|---|---|
sc` | we rely on both at present, but it's become unnecessary to do so | 00:45 |
openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-telemetry master: Replace ceilometer-dbsync by ceilometer-upgrade as dbsync is removed in pike release https://review.openstack.org/515250 | 01:05 |
Seb-Solon | sc`: well you still have to add the ppa / repository for openstack. You would prefer to do it with a simple chef file resource? | 01:06 |
sc` | that's handled in chef core | 01:06 |
sc` | apt_repository / yum_repository are in core | 01:06 |
Seb-Solon | oh you mean the extra apt dep | 01:07 |
Seb-Solon | yeah I saw that dep but did really look at why it was there :) | 01:07 |
Seb-Solon | and unfortunately the apt_repository has a bug actually | 01:08 |
Seb-Solon | sc`: regarding the review, am I good in terms of commit message and how I did it? I am doing the other so let me know if I made a mistake on the first one. Last time I used openstack gerrit was like 2 years ago :) | 01:10 |
Seb-Solon | sc`: for the platform family should I use the Partial-Bug as there are several commit for the same bug or Closes-Bug each time? Close will automatically change the status right? | 01:22 |
openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-block-storage master: Replace platform_family method and use attribute instead https://review.openstack.org/515255 | 02:00 |
openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-block-storage master: Replace platform_family method and use attribute instead https://review.openstack.org/515255 | 02:00 |
openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-compute master: Replace platform_family method and use attribute instead https://review.openstack.org/515256 | 02:00 |
openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-image master: Replace platform_family method and use attribute instead https://review.openstack.org/515257 | 02:00 |
openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-network master: Replace platform_family method and use attribute instead https://review.openstack.org/515258 | 02:00 |
openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-orchestration master: Replace platform_family method and use attribute instead https://review.openstack.org/515259 | 02:01 |
openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-telemetry master: Replace platform_family method and use attribute instead https://review.openstack.org/515260 | 02:02 |
sc` | Seb-Solon: for 515250, i'd probably have it start with something like "Replace ceilometer-dbsync with ceilometer-upgrade" and then say it was deprecated in the body. for the others, Partial-Bug and do Closes-Bug on the last one | 02:28 |
sc` | i think i do my word wrapping at 72 characters | 02:28 |
sc` | i tend to do my reviews in the third person | 02:32 |
sc` | it's been a long week | 02:34 |
*** mrodden has quit IRC | 02:41 | |
*** mrodden has joined #openstack-chef | 02:44 | |
openstackgerrit | Jens Harbott (frickler) proposed openstack/openstack-chef-repo master: WIP: Implement native zuul v3 tests https://review.openstack.org/508463 | 05:49 |
openstackgerrit | Jens Harbott (frickler) proposed openstack/openstack-chef-repo master: WIP: Implement native zuul v3 tests https://review.openstack.org/508463 | 06:01 |
openstackgerrit | Jens Harbott (frickler) proposed openstack/openstack-chef-repo master: WIP: Implement native zuul v3 tests https://review.openstack.org/508463 | 06:18 |
frickler | wow, that went better than expected ^^ now only need to collect the logs properly | 07:53 |
openstackgerrit | Jens Harbott (frickler) proposed openstack/openstack-chef-repo master: Implement native zuul v3 tests https://review.openstack.org/508463 | 08:55 |
openstackgerrit | Jens Harbott (frickler) proposed openstack/cookbook-openstack-common master: Add native zuul v3 jobs defined in openstack-chef-repo https://review.openstack.org/515349 | 10:08 |
*** jklare_ has joined #openstack-chef | 10:09 | |
*** jklare has quit IRC | 10:12 | |
*** jklare_ is now known as jklare | 10:12 | |
openstackgerrit | Jens Harbott (frickler) proposed openstack/openstack-chef-repo master: Implement native zuul v3 tests https://review.openstack.org/508463 | 11:22 |
openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-telemetry master: Replace ceilometer-dbsync by ceilometer-upgrade https://review.openstack.org/515250 | 13:19 |
openstackgerrit | Jens Harbott (frickler) proposed openstack/openstack-chef-repo master: Implement native zuul v3 tests https://review.openstack.org/508463 | 15:41 |
sc` | frickler: nice! | 15:50 |
sc` | zuulv3 + test-kitchen could be a possibility, instead of firing off the integration from a separate bit of code | 15:52 |
sc` | at least i'd hope that would work. the requirement would be getting docker on the integration vms | 15:53 |
sc` | http://www.coglib.com/~icordasc/blog/2017/02/configuring-docker-on-openstack-ci.html | 16:57 |
sc` | hmmmm | 16:57 |
openstackgerrit | Jens Harbott (frickler) proposed openstack/openstack-chef-repo master: Implement native zuul v3 tests https://review.openstack.org/508463 | 17:10 |
openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-network master: Fix control_exchange attribute https://review.openstack.org/515477 | 17:16 |
Seb-Solon | sc`: te test failed on the network cookbook du to something not related | 17:16 |
Seb-Solon | this is the fix for that | 17:16 |
Seb-Solon | My git review batch command is ready for the platform family issue. Except the commit message, nothing left? | 17:18 |
*** eroux has joined #openstack-chef | 18:10 | |
sc` | Seb-Solon: not surprising something unrelated came up. there are some ops-database and ops-messaging changes that need to be made, but it's unrelated to platform_family | 21:10 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!