| *** mago_ has joined #openstack-chef | 07:58 | |
| *** Seb-Solo` has joined #openstack-chef | 09:28 | |
| *** Seb-Solon has quit IRC | 09:30 | |
| Seb-Solo` | thanks for the tip, fixing it | 13:06 |
|---|---|---|
| *** Seb-Solo` is now known as Seb-Solon | 13:06 | |
| openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-telemetry master: Add: Aodh support into telemetry https://review.openstack.org/580225 | 13:10 |
| Seb-Solon | scas, is cookbook style enable for dns? I've just run it and it corrected a "# rubocop:disable Documentation" line. Not sure if it was intended | 13:13 |
| scas | oh. you're stepping into territory covered by one of my changes. | 13:17 |
| scas | https://review.openstack.org/#/c/575724/3/recipes/dashboard.rb | 13:18 |
| scas | it is intended as far as cookstyle is concerned | 13:18 |
| scas | jklare: calbers: frickler: speaking of, is there anything particularly glaring about 575724? in my changes across all of the other cookbooks, i noted a discrepancy with how the identity endpoint is handled and made them all look the same to better anticipate a change in common. not only that, but my kitchen runs were failing otherwise | 13:23 |
| Seb-Solon | ok so I'm just gonna revert this specific part fixed by the cookstyle -a run | 13:26 |
| scas | Seb-Solon: what i do in such cases is base my change off of the already proposed change a la 'git review -d' | 13:27 |
| scas | or don't do cookstyle -a and do a Depends-On on mine | 13:27 |
| scas | either way. 575724 does contain the results of 'cookstyle -a' | 13:28 |
| Seb-Solon | by revert in meant do not commit this diff | 13:28 |
| scas | :D | 13:28 |
| Seb-Solon | i havent done a git review for the dns yet so this is good | 13:28 |
| scas | alternately, surgically fix the complaints that cookstyle emitted | 13:28 |
| Seb-Solon | but i'll keep that -d option in mind to help me | 13:28 |
| scas | i go the lazy route and stack changes when i'm blocked by myself | 13:29 |
| frickler | scas: I'm currently working on a patch to partially revert your identity cleanup. we do need both an internal and a public identity endpoint in our setup | 13:30 |
| frickler | scas: that may also affect 575724 then | 13:30 |
| scas | frickler: okay. that's unfortunate, but appreciate the clarity | 13:30 |
| scas | it was a risky change that needed to happen in some form | 13:31 |
| scas | our friends from behind the gfw even picked up on it | 13:31 |
| openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-dns master: Add: sink service in designate https://review.openstack.org/580381 | 13:31 |
| frickler | scas: yes, the cleanup in itself is good, it was just a bit too much for our particular use case. that's why I won't propose a complete revert, but will try to fix things for us in a followup | 13:32 |
| scas | i did leave the internal/external/admin endpoint methods in, but reduced it all to serving a single keystone endpoint | 13:34 |
| scas | but, yeah. cut too much off. | 13:34 |
| Seb-Solon | http://logs.openstack.org/25/580225/3/check/openstack-chef-repo-rake/33b6a9f/ara-report/result/0c4b9775-438e-4a0b-9774-b66f0b60c2db/ | 14:29 |
| Seb-Solon | Looks like it is a bit more complex for the rake test | 14:29 |
| Seb-Solon | I guess I have to update the specc file to reflect the new behavior? | 14:29 |
| *** os-chef-bot has quit IRC | 14:31 | |
| scas | Seb-Solon: i think either the test or the spec helper itself | 15:08 |
| scas | Seb-Solon: add a stanza to this block https://github.com/openstack/cookbook-openstack-telemetry/blob/master/spec/spec_helper.rb#L24 | 15:34 |
| scas | untested, that should get things testing | 15:34 |
| scas | if you have chefdk installed locally, you can run the tests through 'delivery local' | 15:34 |
| *** mago_ has quit IRC | 16:11 | |
| Seb-Solon | you usually do 'allM I guess ? | 16:34 |
| scas | yeah. i'll run 'delivery local all' | 16:36 |
| scas | it's eventually what i want to replace the rake test with, since it's more dogfoodish | 16:36 |
| scas | plus, it looks better | 16:36 |
| Seb-Solon | erf, can't test locally without setting up a docker or something because i have dep conflicts with my current cookbook | 16:45 |
| scas | for vagrant? you shouldn't need docker | 16:46 |
| scas | but dokken does work | 16:46 |
| scas | everything to make it work with centos is merged, too | 16:47 |
| *** os-chef-bot has joined #openstack-chef | 16:52 | |
| Seb-Solon | well docker or vagrant , i have no dedicated env for now | 16:52 |
| Seb-Solon | i am manually doing it now, will try to build up a more convininet stuff to test after | 16:53 |
| Seb-Solon | btw, do you usually backport stuff of other branches? | 16:53 |
| scas | if it needs to be, but i don't regularly build older branches. those come from mostly the cloudbau folks if anyone | 16:56 |
| Seb-Solon | for now I am in sync with pike but once my review are merge i am hesitating. I guess I could wait for the queen release but I am afraid the queens cookbooks are not compatible with the pike openstack version | 16:59 |
| scas | what i do to augment my lack of available local testing kit is lease some bargain bin servers with intel chipsets | 16:59 |
| scas | but, it's largely time-dependent, and my time has numerous pulls | 17:00 |
| scas | when the keystone changes are solidified is probably when queens will be branched off and shipped to supermarket. i'm looking into automating this process to speed this turnaround up | 17:01 |
| scas | that will have a direct impact on the cookbook release process | 17:01 |
| Seb-Solon | ok | 17:04 |
| Seb-Solon | look like the test a running, jsut failing on centos stuff, ubuntu part is getting green. (i am on debian) | 17:04 |
| openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-telemetry master: Add: Aodh support into telemetry https://review.openstack.org/580225 | 17:06 |
| Seb-Solon | hope this time is the good one. AFK during build :) | 17:06 |
| scas | yeah. on a good zuul day, it takes maybe 20-40 minutes for a build to pop out | 17:07 |
| scas | kitchen gets 20 minutes consistently | 17:07 |
| scas | but i haven't benched that inside a vm | 17:08 |
| scas | my wip dokken testing is closest to timing | 17:08 |
| scas | looking at the logs, integration takes 30 or so minutes with dokken | 17:10 |
| Seb-Solon | 138 jobs in queue apparently, gonna take some time to build :) | 18:43 |
| scas | maybe tripleo again with the container testing... | 18:56 |
| Seb-Solon | (Wow finally +1 :) ) | 19:44 |
| scas | yup. i mentioned something in #openstack-infra and it turned out to have something to explore. other than that, zuul was just busy | 19:45 |
| scas | was/is | 19:46 |
| openstackgerrit | Seb-Solon proposed openstack/cookbook-openstack-dns master: Add: sink service in designate https://review.openstack.org/580381 | 19:55 |
| Seb-Solon | (forgot the link to the bug) | 19:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!