frickler | Ramereth: jklare: the usual solution for this kind of issues is to simply make the problematic job non-voting in the zuul.yaml, no need to apply any superpowers | 08:11 |
---|---|---|
frickler | I'm -1 on some other issues though, left comments in gerrit | 08:12 |
*** openstackgerrit has joined #openstack-chef | 08:21 | |
openstackgerrit | Jens Harbott (frickler) proposed openstack/openstack-chef master: DNM: Install chef pkg safely https://review.opendev.org/668386 | 08:21 |
*** laurent\ has joined #openstack-chef | 15:28 | |
*** laurent\ has quit IRC | 15:28 | |
Ramereth | frickler: thanks for the comments and the heads up. How do you make the job non-voting in zuul.yaml properly? | 15:28 |
Ramereth | do you have an example I can look at | 15:29 |
*** laurent\ has joined #openstack-chef | 15:33 | |
*** s-mutin has joined #openstack-chef | 18:23 | |
*** mutin-s has quit IRC | 18:23 | |
*** s-mutin has quit IRC | 18:31 | |
*** s-mutin has joined #openstack-chef | 18:31 | |
frickler | Ramereth: https://opendev.org/openstack/devstack/src/branch/master/.zuul.yaml#L553 | 18:58 |
*** mutin-s has joined #openstack-chef | 18:58 | |
frickler | https://zuul-ci.org/docs/zuul/user/config.html#attr-job.voting | 18:59 |
*** s-mutin has quit IRC | 19:00 | |
Ramereth | frickler: gotcha. Thanks! So would we eventually revert that voting status once all of those are merged? | 19:02 |
frickler | Ramereth: exactly, you can already create a patch for that now, depending on the last patch of your stack | 19:04 |
Ramereth | ah, so the last one that gets merged would likely revert that | 19:05 |
Ramereth | btw, i'm going to confirm your comments on the identity cookbook once I test it locally | 19:05 |
Ramereth | thanks for the feedback | 19:05 |
*** mutin-s has quit IRC | 19:10 | |
*** s-mutin has joined #openstack-chef | 19:12 | |
frickler | Ramereth: thx, will check back tomorrow | 19:14 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!