| *** xmltok has left #openstack-cinder | 00:00 | |
| *** bswartz has joined #openstack-cinder | 00:05 | |
| *** scottda_ has quit IRC | 00:06 | |
| *** fischerw has quit IRC | 00:07 | |
| *** fischerw has joined #openstack-cinder | 00:07 | |
| thingee | jamielennox: thank you | 00:08 |
|---|---|---|
| jamielennox | thingee: any time - let me know what i can do to help | 00:08 |
| *** tbarron has quit IRC | 00:09 | |
| *** scottda_ has joined #openstack-cinder | 00:09 | |
| *** hemna has joined #openstack-cinder | 00:11 | |
| *** fischerw has quit IRC | 00:14 | |
| *** ryanpetrello has quit IRC | 00:15 | |
| *** scottda_ has quit IRC | 00:17 | |
| *** mudassirlatif has quit IRC | 00:19 | |
| *** jwang has joined #openstack-cinder | 00:23 | |
| *** scottda_ has joined #openstack-cinder | 00:26 | |
| *** hemna has quit IRC | 00:27 | |
| *** tsekiyam_ has joined #openstack-cinder | 00:28 | |
| *** hemna has joined #openstack-cinder | 00:30 | |
| thingee | jamielennox: thank you | 00:30 |
| thingee | jamielennox: whoops | 00:30 |
| *** tsekiyama has quit IRC | 00:31 | |
| *** Masahiro has joined #openstack-cinder | 00:33 | |
| *** crose has joined #openstack-cinder | 00:34 | |
| *** scottda_ has quit IRC | 00:34 | |
| *** crose has quit IRC | 00:34 | |
| *** hemna has quit IRC | 00:34 | |
| *** david-ly_ has joined #openstack-cinder | 00:36 | |
| *** Masahiro has quit IRC | 00:38 | |
| *** annashen has quit IRC | 00:38 | |
| *** btran has quit IRC | 00:39 | |
| *** david-ly_ has quit IRC | 00:41 | |
| *** hemna has joined #openstack-cinder | 00:42 | |
| *** hemna_ has joined #openstack-cinder | 00:47 | |
| *** hemna has quit IRC | 00:48 | |
| *** ryanpetrello has joined #openstack-cinder | 00:49 | |
| *** ebalduf has quit IRC | 00:54 | |
| *** jungleboyj has joined #openstack-cinder | 00:55 | |
| *** Masahiro has joined #openstack-cinder | 00:56 | |
| *** dannywilson has quit IRC | 00:57 | |
| *** scottda_ has joined #openstack-cinder | 01:00 | |
| *** scottda_ has quit IRC | 01:04 | |
| *** _cjones_ has quit IRC | 01:05 | |
| *** hemna_ has quit IRC | 01:06 | |
| *** hemna_ has joined #openstack-cinder | 01:07 | |
| openstackgerrit | Anthony Lee proposed openstack/cinder: Add driver filter and evaluator for scheduler https://review.openstack.org/129987 | 01:18 |
| *** rlucio has quit IRC | 01:24 | |
| *** hemna_ has quit IRC | 01:24 | |
| *** hemna_ has joined #openstack-cinder | 01:25 | |
| *** patrickeast has quit IRC | 01:27 | |
| *** tsekiyam_ has quit IRC | 01:33 | |
| *** nellysmitt has joined #openstack-cinder | 01:37 | |
| *** mtanino has quit IRC | 01:38 | |
| *** kfox1111 has quit IRC | 01:39 | |
| *** nellysmitt has quit IRC | 01:42 | |
| *** kaufer has joined #openstack-cinder | 01:42 | |
| *** leeantho has quit IRC | 01:44 | |
| *** kaufer has quit IRC | 01:50 | |
| *** nosnos has joined #openstack-cinder | 01:50 | |
| *** hemna_ has quit IRC | 01:54 | |
| *** hemna_ has joined #openstack-cinder | 01:55 | |
| *** fandi has quit IRC | 01:55 | |
| *** mriedem1 has joined #openstack-cinder | 01:56 | |
| *** mriedem has quit IRC | 01:57 | |
| *** elazro has quit IRC | 02:03 | |
| *** rwsu has quit IRC | 02:03 | |
| *** elazro has joined #openstack-cinder | 02:03 | |
| *** hemna_ has quit IRC | 02:06 | |
| *** scottda_ has joined #openstack-cinder | 02:06 | |
| *** hemna_ has joined #openstack-cinder | 02:07 | |
| *** thingee has quit IRC | 02:10 | |
| *** ryanpetrello has quit IRC | 02:14 | |
| *** haomaiwa_ has joined #openstack-cinder | 02:15 | |
| *** Mandell has joined #openstack-cinder | 02:16 | |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Capitalize the first letter in log message. https://review.openstack.org/145111 | 02:25 |
| *** scottda_ has quit IRC | 02:27 | |
| *** JoeGTN1 has quit IRC | 02:32 | |
| *** annashen has joined #openstack-cinder | 02:33 | |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Correct import order https://review.openstack.org/145112 | 02:36 |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Correct import order https://review.openstack.org/145112 | 02:38 |
| *** thelo has joined #openstack-cinder | 02:41 | |
| *** thelo has quit IRC | 02:41 | |
| *** thelo has joined #openstack-cinder | 02:42 | |
| openstackgerrit | Li Min Liu proposed openstack/cinder: Add secondary sshpool for san storage drivers https://review.openstack.org/145113 | 02:43 |
| *** kaisers1 has joined #openstack-cinder | 02:44 | |
| *** mberlin1 has joined #openstack-cinder | 02:45 | |
| *** kaisers has quit IRC | 02:45 | |
| *** mberlin has quit IRC | 02:46 | |
| *** Mandell has quit IRC | 02:54 | |
| *** takedakn has joined #openstack-cinder | 02:55 | |
| *** Mandell has joined #openstack-cinder | 02:58 | |
| *** scottda_ has joined #openstack-cinder | 03:00 | |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Fix argument order in assertEqual https://review.openstack.org/145118 | 03:03 |
| *** scottda_ has quit IRC | 03:06 | |
| *** scottda_ has joined #openstack-cinder | 03:10 | |
| *** scottda_ has quit IRC | 03:14 | |
| *** hemna_ has quit IRC | 03:15 | |
| *** nosnos has quit IRC | 03:34 | |
| *** bkopilov has quit IRC | 03:37 | |
| *** nellysmitt has joined #openstack-cinder | 03:38 | |
| *** ryanpetrello has joined #openstack-cinder | 03:38 | |
| *** takedakn has quit IRC | 03:39 | |
| *** nellysmitt has quit IRC | 03:42 | |
| *** david-lyle has joined #openstack-cinder | 03:48 | |
| *** ebalduf has joined #openstack-cinder | 03:52 | |
| *** ryanpetrello has quit IRC | 03:55 | |
| *** Longgeek has joined #openstack-cinder | 03:56 | |
| *** Longgeek has quit IRC | 03:57 | |
| *** dannywilson has joined #openstack-cinder | 03:58 | |
| *** dannywilson has quit IRC | 04:02 | |
| *** Longgeek has joined #openstack-cinder | 04:03 | |
| *** mriedem1 has quit IRC | 04:04 | |
| *** ho__ has joined #openstack-cinder | 04:06 | |
| *** ho has quit IRC | 04:09 | |
| *** abhijeetm has joined #openstack-cinder | 04:23 | |
| *** annashen has quit IRC | 04:24 | |
| *** david-lyle is now known as david-lyle_afk | 04:25 | |
| *** Mandell has quit IRC | 04:28 | |
| *** nosnos has joined #openstack-cinder | 04:29 | |
| *** Mandell has joined #openstack-cinder | 04:29 | |
| *** avishay has joined #openstack-cinder | 04:29 | |
| *** mogami has joined #openstack-cinder | 04:38 | |
| *** mudassirlatif has joined #openstack-cinder | 04:42 | |
| *** annashen has joined #openstack-cinder | 04:51 | |
| *** anshul has joined #openstack-cinder | 05:04 | |
| *** e0ne has joined #openstack-cinder | 05:09 | |
| *** bkopilov has joined #openstack-cinder | 05:11 | |
| *** e0ne has quit IRC | 05:11 | |
| *** ebalduf has quit IRC | 05:11 | |
| *** BharatK has joined #openstack-cinder | 05:14 | |
| *** k4n0 has joined #openstack-cinder | 05:24 | |
| *** k4n0 has quit IRC | 05:25 | |
| *** annashen has quit IRC | 05:28 | |
| *** pradipta_away is now known as pradipta | 05:29 | |
| *** mogami has quit IRC | 05:29 | |
| *** deepakcs has joined #openstack-cinder | 05:33 | |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Fix the continuation line indent https://review.openstack.org/145131 | 05:38 |
| *** nellysmitt has joined #openstack-cinder | 05:38 | |
| *** annashen has joined #openstack-cinder | 05:40 | |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Fix the continuation line indent https://review.openstack.org/145131 | 05:40 |
| openstackgerrit | xing-yang proposed openstack/cinder: Support over subscription in thin provisioning https://review.openstack.org/142171 | 05:41 |
| *** nellysmitt has quit IRC | 05:43 | |
| *** annashen has quit IRC | 05:45 | |
| *** PaulCuzner has joined #openstack-cinder | 05:46 | |
| *** nshaikh has joined #openstack-cinder | 05:47 | |
| openstackgerrit | Bharat Kumar Kobagana proposed openstack/cinder: Fix argument order in assertEqual: tests/test_glusterfs.py https://review.openstack.org/145133 | 05:49 |
| *** Longgeek has quit IRC | 05:51 | |
| *** sandywalsh has quit IRC | 05:55 | |
| *** Mandell has quit IRC | 05:55 | |
| *** Mandell has joined #openstack-cinder | 05:55 | |
| *** sandywalsh has joined #openstack-cinder | 05:57 | |
| *** Mandell has quit IRC | 05:57 | |
| *** Mandell has joined #openstack-cinder | 05:58 | |
| *** annashen has joined #openstack-cinder | 06:01 | |
| *** deepakcs has quit IRC | 06:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex https://review.openstack.org/144933 | 06:06 |
| *** Longgeek has joined #openstack-cinder | 06:09 | |
| *** ho__ has quit IRC | 06:14 | |
| *** mudassirlatif has quit IRC | 06:21 | |
| *** Mandell has quit IRC | 06:26 | |
| *** mudassirlatif has joined #openstack-cinder | 06:26 | |
| *** mudassirlatif has quit IRC | 06:32 | |
| openstackgerrit | Abhijeet Malawade proposed openstack/cinder: Get volume from db again before updating it's status https://review.openstack.org/145143 | 06:43 |
| *** annashen has quit IRC | 06:46 | |
| *** nlevinki has joined #openstack-cinder | 06:49 | |
| *** ho has joined #openstack-cinder | 06:52 | |
| *** Mandell has joined #openstack-cinder | 06:55 | |
| *** anshul has quit IRC | 07:02 | |
| *** e0ne has joined #openstack-cinder | 07:02 | |
| *** jamielennox is now known as jamielennox|away | 07:03 | |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Fix assertEqual argument order in tests/ root dir https://review.openstack.org/145118 | 07:03 |
| *** lpetrut has joined #openstack-cinder | 07:11 | |
| openstackgerrit | Abhijeet Malawade proposed openstack/cinder: Get volume from db again before updating it's status https://review.openstack.org/144409 | 07:12 |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Correct import order https://review.openstack.org/145112 | 07:12 |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Correct import order in qos_specs_manage.py https://review.openstack.org/145112 | 07:13 |
| *** e0ne has quit IRC | 07:18 | |
| *** EduardBiceriMate has joined #openstack-cinder | 07:21 | |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Capitalize the first letter in log message. https://review.openstack.org/145111 | 07:22 |
| *** deepakcs has joined #openstack-cinder | 07:24 | |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Capitalize the first letter in log messages. https://review.openstack.org/145111 | 07:26 |
| openstackgerrit | Accela Zhao proposed openstack/cinder: Fix the continuation line indent to pass flake8 https://review.openstack.org/145131 | 07:27 |
| *** mudassirlatif has joined #openstack-cinder | 07:27 | |
| *** tshefi has joined #openstack-cinder | 07:32 | |
| *** nellysmitt has joined #openstack-cinder | 07:39 | |
| *** mudassirlatif has quit IRC | 07:40 | |
| *** BharatK_ has joined #openstack-cinder | 07:41 | |
| *** BharatK has quit IRC | 07:43 | |
| *** nellysmitt has quit IRC | 07:43 | |
| *** anshul has joined #openstack-cinder | 07:45 | |
| *** chlong has quit IRC | 07:49 | |
| *** chlong has joined #openstack-cinder | 07:49 | |
| openstackgerrit | AmitKumarDas proposed openstack/cinder: Adds cinder iscsi driver for CloudByte storage https://review.openstack.org/102511 | 07:50 |
| *** chlong has quit IRC | 07:51 | |
| *** chlong has joined #openstack-cinder | 07:53 | |
| *** teju has joined #openstack-cinder | 07:58 | |
| *** fandi has joined #openstack-cinder | 08:08 | |
| *** afazekas has joined #openstack-cinder | 08:14 | |
| openstackgerrit | Bharat Kumar Kobagana proposed openstack/cinder: Fix argument order in assertEqual: tests/test_image_utils.py https://review.openstack.org/145162 | 08:21 |
| *** cnesa has joined #openstack-cinder | 08:30 | |
| *** nellysmitt has joined #openstack-cinder | 08:33 | |
| openstackgerrit | Bharat Kumar Kobagana proposed openstack/cinder: Fix argument order in assertEqual: tests/test_nfs.py https://review.openstack.org/145166 | 08:39 |
| *** alecv has joined #openstack-cinder | 08:48 | |
| *** EduardBiceriMate has quit IRC | 08:51 | |
| *** lpetrut has quit IRC | 08:55 | |
| openstackgerrit | Bharat Kumar Kobagana proposed openstack/cinder: Fix argument order in assertEqual: tests/test_rbd.py https://review.openstack.org/145173 | 08:56 |
| *** deepakcs has quit IRC | 08:58 | |
| *** jistr has joined #openstack-cinder | 08:58 | |
| *** jpich has joined #openstack-cinder | 08:59 | |
| *** nshaikh has quit IRC | 09:01 | |
| *** mogami has joined #openstack-cinder | 09:06 | |
| *** jordanP has joined #openstack-cinder | 09:06 | |
| *** nshaikh has joined #openstack-cinder | 09:06 | |
| *** nellysmitt has quit IRC | 09:08 | |
| *** lpetrut has joined #openstack-cinder | 09:10 | |
| *** mogami has quit IRC | 09:11 | |
| *** nellysmitt has joined #openstack-cinder | 09:12 | |
| *** lpetrut has quit IRC | 09:25 | |
| *** Masahiro has quit IRC | 09:27 | |
| *** Masahiro has joined #openstack-cinder | 09:27 | |
| *** Masahiro has quit IRC | 09:31 | |
| *** TobiasE has joined #openstack-cinder | 09:31 | |
| *** Masahiro has joined #openstack-cinder | 09:37 | |
| *** abehl has joined #openstack-cinder | 09:39 | |
| *** Masahiro has quit IRC | 09:39 | |
| *** anshul has quit IRC | 09:39 | |
| *** Mandell has quit IRC | 09:45 | |
| *** cnesa has quit IRC | 09:48 | |
| *** annashen has joined #openstack-cinder | 09:49 | |
| *** Masahiro has joined #openstack-cinder | 09:50 | |
| *** Masahiro has quit IRC | 09:53 | |
| *** Masahiro has joined #openstack-cinder | 09:57 | |
| *** mkoderer_cloud has joined #openstack-cinder | 10:00 | |
| *** Masahiro has quit IRC | 10:00 | |
| *** lpetrut has joined #openstack-cinder | 10:00 | |
| *** alexpilotti has joined #openstack-cinder | 10:02 | |
| *** alonmarx_ has joined #openstack-cinder | 10:08 | |
| *** annashen has quit IRC | 10:08 | |
| *** abehl has quit IRC | 10:08 | |
| *** Masahiro has joined #openstack-cinder | 10:09 | |
| *** alonmarx has quit IRC | 10:11 | |
| *** Masahiro has quit IRC | 10:14 | |
| *** Raj_ has joined #openstack-cinder | 10:14 | |
| *** cnesa1 has joined #openstack-cinder | 10:15 | |
| *** pradipta is now known as pradipta_away | 10:15 | |
| Raj_ | Hi any one knw | 10:16 |
| Raj_ | Failed to run task cinder.scheduler.flows.create_volume.ScheduleCreateVolumeTask;volume:create: No valid host was found. No weighed hosts available | 10:16 |
| Raj_ | No valid host was found. No weighed hosts available error out volume | 10:16 |
| Raj_ | error while creating volume with | 10:16 |
| Raj_ | capabilities:replication in key | 10:16 |
| Raj_ | pls any one help | 10:16 |
| *** timcl has quit IRC | 10:19 | |
| *** cnesa1 has left #openstack-cinder | 10:19 | |
| *** cnesa1 has joined #openstack-cinder | 10:19 | |
| *** cnesa1 has left #openstack-cinder | 10:20 | |
| *** cnesa1 has joined #openstack-cinder | 10:20 | |
| *** cnesa1 has quit IRC | 10:21 | |
| *** cnesa1 has joined #openstack-cinder | 10:21 | |
| *** abehl has joined #openstack-cinder | 10:22 | |
| avishay | Raj_: you have no backend available that reports the replication capability | 10:22 |
| Raj_ | Changed the code in my driver | 10:23 |
| Raj_ | iee. | 10:23 |
| Raj_ | avishay: stats = {'driver_version': VERSION, 'free_capacity_gb': 0, 'reserved_percentage': 0, 'storage_protocol': 'iSCSI', 'total_capacity_gb': 0, 'vendor_name': 'Symantec', 'volume_backend_name': 'SYMC_VxVM', 'replication_support': True} | 10:24 |
| Raj_ | avishay : i added it in def _update_volume_stats(self) | 10:24 |
| Raj_ | data['replication_support']=True | 10:25 |
| Raj_ | need to add anywhere else ..? | 10:25 |
| avishay | Raj_: https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/ibm/storwize_svc/replication.py#L184 | 10:25 |
| avishay | data['replication'] = True | 10:25 |
| *** e0ne has joined #openstack-cinder | 10:25 | |
| Raj_ | avishay : need to change from data['replication_support']=True to data['replication']=True | 10:26 |
| Raj_ | avishay but in https://review.openstack.org/#/c/98308/6/specs/juno/volume-replication.rst doc they given to do | 10:26 |
| Raj_ | replication support | 10:26 |
| Raj_ | avishay: | 10:26 |
| avishay | Raj_: again, there is a difference between a design document and the actual implementation | 10:27 |
| avishay | Raj_: If you code with a design document as a guide, you're gonna have a bad time | 10:28 |
| Raj_ | ohhh | 10:29 |
| Raj_ | avishay: thanks alot | 10:29 |
| Raj_ | avishay : so need to see code only ... | 10:29 |
| Raj_ | avishay: u wann say so no any proper guide is there | 10:30 |
| avishay | Raj_: correct | 10:31 |
| Raj_ | avishay: can u just tell me | 10:34 |
| Raj_ | avishay: the methods that i need to implement | 10:35 |
| Raj_ | ie promote replica | 10:35 |
| Raj_ | reneeable replica | 10:35 |
| *** nikesh_vedams has quit IRC | 10:39 | |
| avishay | Raj_: https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L737 | 10:39 |
| avishay | Raj_: reenable_replication, get_replication_status, promote_replica | 10:39 |
| Raj_ | avishay: only three ... if u consider the basic driver ... | 10:40 |
| avishay | yes | 10:41 |
| Raj_ | avishay: then this methods will call create_replica delete_replica etc ..??? or this thing is own driver dependent ..?? | 10:42 |
| Raj_ | avishay: one more it is must to provide the 2nd storage info .... ie enable_backends= strg1, strg2 etc ...??? | 10:44 |
| Raj_ | in cinder.conf file ..? | 10:44 |
| *** Longgeek has quit IRC | 10:51 | |
| *** Longgeek has joined #openstack-cinder | 10:51 | |
| avishay | Raj_: driver dependent | 10:51 |
| avishay | Raj_: I already told you, communication with the second storage should be in the conf file, yes | 10:52 |
| *** Masahiro has joined #openstack-cinder | 10:54 | |
| Raj_ | you have any ...?? example for that | 10:54 |
| avishay | Raj_: there was the IBM patch, but they did it wrong | 10:54 |
| avishay | Raj_: if your driver inherits from san.py and uses those config options, add to san.py | 10:55 |
| Raj_ | no my driver is not using san.py file | 10:56 |
| Raj_ | avishay: is there is any other way for that .. | 10:56 |
| *** Masahiro has quit IRC | 10:58 | |
| *** Masahiro has joined #openstack-cinder | 11:00 | |
| *** e0ne is now known as e0ne_ | 11:09 | |
| *** BharatK_ has quit IRC | 11:12 | |
| *** haomaiwa_ has quit IRC | 11:14 | |
| *** e0ne_ has quit IRC | 11:20 | |
| *** e0ne has joined #openstack-cinder | 11:30 | |
| *** marcusvrn1 has joined #openstack-cinder | 11:30 | |
| *** marcusvrn has quit IRC | 11:31 | |
| *** TobiasE has quit IRC | 11:31 | |
| *** nshaikh has quit IRC | 11:33 | |
| *** nshaikh has joined #openstack-cinder | 11:38 | |
| *** TobiasE has joined #openstack-cinder | 11:46 | |
| *** ho has quit IRC | 11:48 | |
| *** Masahiro has quit IRC | 11:48 | |
| *** nellysmitt has quit IRC | 11:50 | |
| *** jaypipes has joined #openstack-cinder | 11:51 | |
| *** avishay has quit IRC | 11:52 | |
| *** fandi has quit IRC | 11:56 | |
| *** michiel-k has joined #openstack-cinder | 11:58 | |
| michiel-k | I've got an issue with uploading a boot-from-volume volume to Glance, where Glance says the uploaded image is 0 bytes, but the data is actually there (checksum is different). | 12:00 |
| michiel-k | Details: https://ask.openstack.org/en/question/57477/cinder-copy-to-image-does-not-set-glance-image-size/ | 12:00 |
| *** pradipta_away is now known as pradipta | 12:03 | |
| *** nellysmitt has joined #openstack-cinder | 12:16 | |
| *** timcl has joined #openstack-cinder | 12:29 | |
| DuncanT | The checksum being different suggests maybe the upload failed in some way? | 12:31 |
| DuncanT | michiel-k: Does downloading the image to a new volume actually work? | 12:32 |
| DuncanT | michiel-k: Also have you tried on devstack with swift rather than ceph? It might be that swift as a glance backend auto-populates that field but not ceph? (I'm guessing here) | 12:33 |
| *** marcusvrn1 has quit IRC | 12:42 | |
| erlon_ | eharney: aroud? | 12:42 |
| *** marcusvrn has joined #openstack-cinder | 12:43 | |
| *** ryanpetrello has joined #openstack-cinder | 12:46 | |
| *** Masahiro has joined #openstack-cinder | 12:49 | |
| michiel-k | Upload succeeds, because uploading a volume which has not been attached/modified results in the expected checksum. Also creating a new empty 1GB volume results in the md5 checksum for 1gb of zero data | 12:53 |
| michiel-k | Downloading the image to a new volume (boot from volume for example) does work | 12:53 |
| *** Masahiro has quit IRC | 12:54 | |
| michiel-k | DuncanT: i haven't tested it on devstack yet, but i have been browsing the source code of Cinder, and have found no evidence of setting size either in the abstract VolumeDriver class (cinder/volume/driver.py) or in the driver implementation of lvm or rbd, or anywhere before that (API layer for example). I will see if i can test it on Devstack today | 12:59 |
| *** teju has left #openstack-cinder | 12:59 | |
| *** marcusvrn has quit IRC | 13:00 | |
| DuncanT | Ok, it might well be nobody has noticed that the size in glance is wrong, then. If so, good spot; can you raise a bug against tempest to implement a check for it, once the fi is in, please? | 13:00 |
| *** marcusvrn has joined #openstack-cinder | 13:01 | |
| michiel-k | I'm currently installing devstack and will report back here. Haven't reported a bug yet, or implemented a tempest check before, but when i get to that step, i will consult here to report/implement it :) | 13:02 |
| *** IanGovett has joined #openstack-cinder | 13:05 | |
| DuncanT | Welcome to the mad house :-) | 13:05 |
| e0ne | hi DuncanT: could you please help me? where i can find some info about state machine implementation? blueprints, specs, review requests, etc | 13:07 |
| *** takedakn has joined #openstack-cinder | 13:08 | |
| *** fandi has joined #openstack-cinder | 13:11 | |
| *** pradipta is now known as pradipta_away | 13:16 | |
| *** e0ne is now known as e0ne_ | 13:25 | |
| openstackgerrit | Yusuke Hayashi proposed openstack/cinder: Move 3 Fujitsu ETERNUS DX related file https://review.openstack.org/144131 | 13:27 |
| DuncanT | e0ne_: https://review.openstack.org/#/c/110434/ is a starting point | 13:32 |
| DuncanT | e0ne_: I don't actually have a current set of links, I've been focusing (and failing at) rpc version clamping recently, and ignoring the state machine a bit since other people seemed to be trying to progress it | 13:33 |
| DuncanT | That review links to two blueprints | 13:34 |
| DuncanT | And two dependant patches | 13:34 |
| *** bswartz has quit IRC | 13:34 | |
| *** e0ne_ has quit IRC | 13:35 | |
| *** crose has joined #openstack-cinder | 13:38 | |
| *** marcusvrn has quit IRC | 13:40 | |
| *** mwichmann has joined #openstack-cinder | 13:45 | |
| *** Mandell has joined #openstack-cinder | 13:46 | |
| *** lpabon has joined #openstack-cinder | 13:47 | |
| *** Mandell has quit IRC | 13:50 | |
| openstackgerrit | Eduard Biceri-Matei proposed openstack/cinder: New Cinder volume driver for openvstorage https://review.openstack.org/130733 | 13:51 |
| *** EduardBiceriMate has joined #openstack-cinder | 13:54 | |
| *** e0ne has joined #openstack-cinder | 13:58 | |
| *** scottda_ has joined #openstack-cinder | 13:58 | |
| *** Raj_ has left #openstack-cinder | 13:58 | |
| *** Raj_ has quit IRC | 13:59 | |
| *** patrickeast has joined #openstack-cinder | 13:59 | |
| e0ne | DuncanT: thanks! i'm looking on issues with '-ing state' and try to find all evailable related info | 13:59 |
| *** scottda_ has quit IRC | 13:59 | |
| *** Masahiro has joined #openstack-cinder | 14:00 | |
| *** scottda_ has joined #openstack-cinder | 14:01 | |
| *** abhijeetm has quit IRC | 14:01 | |
| *** scottda_ has quit IRC | 14:01 | |
| *** Longgeek has quit IRC | 14:04 | |
| *** nosnos has quit IRC | 14:04 | |
| *** Longgeek has joined #openstack-cinder | 14:05 | |
| *** kaufer has joined #openstack-cinder | 14:05 | |
| *** Masahiro has quit IRC | 14:05 | |
| *** Longgeek has quit IRC | 14:06 | |
| *** Longgeek has joined #openstack-cinder | 14:07 | |
| *** Longgeek has quit IRC | 14:09 | |
| *** Longgeek_ has joined #openstack-cinder | 14:09 | |
| *** Longgeek_ has quit IRC | 14:11 | |
| *** dustins has joined #openstack-cinder | 14:11 | |
| *** bswartz has joined #openstack-cinder | 14:11 | |
| *** Longgeek has joined #openstack-cinder | 14:12 | |
| *** Longgeek has quit IRC | 14:13 | |
| *** Longgeek has joined #openstack-cinder | 14:14 | |
| *** vmtyler has joined #openstack-cinder | 14:15 | |
| *** vmtyler has quit IRC | 14:17 | |
| *** vmtyler has joined #openstack-cinder | 14:17 | |
| *** BharatK has joined #openstack-cinder | 14:17 | |
| *** cnesa1 has quit IRC | 14:18 | |
| *** michiel-k has quit IRC | 14:20 | |
| *** cnesa1 has joined #openstack-cinder | 14:21 | |
| *** kragniz has quit IRC | 14:22 | |
| *** kragniz has joined #openstack-cinder | 14:22 | |
| *** patrickeast has quit IRC | 14:25 | |
| *** Yogi1 has joined #openstack-cinder | 14:26 | |
| openstackgerrit | Yusuke Hayashi proposed openstack/cinder: Move 3 Fujitsu ETERNUS DX related file https://review.openstack.org/144131 | 14:27 |
| *** mriedem has joined #openstack-cinder | 14:28 | |
| *** cnesa1 has quit IRC | 14:28 | |
| *** michiel-k has joined #openstack-cinder | 14:33 | |
| openstackgerrit | Yusuke Hayashi proposed openstack/cinder: Move 3 Fujitsu ETERNUS DX related file https://review.openstack.org/144131 | 14:34 |
| *** Longgeek has quit IRC | 14:36 | |
| *** jungleboyj has quit IRC | 14:37 | |
| openstackgerrit | Steven Kaufer proposed openstack/cinder: GET volumes API sorting REST/volume/DB updates https://review.openstack.org/141915 | 14:39 |
| openstackgerrit | Steven Kaufer proposed openstack/cinder: GET volumes API sorting enhancements common utilities https://review.openstack.org/141914 | 14:39 |
| *** Mandell has joined #openstack-cinder | 14:46 | |
| *** cnesa has joined #openstack-cinder | 14:49 | |
| *** thangp has joined #openstack-cinder | 14:52 | |
| *** nellysmitt has quit IRC | 14:54 | |
| *** crose has quit IRC | 14:55 | |
| *** jistr has quit IRC | 14:56 | |
| *** Longgeek has joined #openstack-cinder | 14:56 | |
| *** jistr has joined #openstack-cinder | 14:57 | |
| *** hypnosb has quit IRC | 14:59 | |
| *** hypnosb has joined #openstack-cinder | 14:59 | |
| *** krtaylor has quit IRC | 15:03 | |
| *** takedakn1 has joined #openstack-cinder | 15:06 | |
| *** BharatK has quit IRC | 15:06 | |
| *** EduardBiceriMate has quit IRC | 15:07 | |
| *** takedakn has quit IRC | 15:08 | |
| *** jcru has joined #openstack-cinder | 15:10 | |
| *** nshaikh has quit IRC | 15:10 | |
| *** scottda_ has joined #openstack-cinder | 15:11 | |
| *** krtaylor has joined #openstack-cinder | 15:11 | |
| *** avishay has joined #openstack-cinder | 15:12 | |
| *** scottda_ has quit IRC | 15:13 | |
| *** changbl has quit IRC | 15:14 | |
| *** mtanino has joined #openstack-cinder | 15:15 | |
| *** annashen has joined #openstack-cinder | 15:16 | |
| *** fischerw has joined #openstack-cinder | 15:18 | |
| *** marcusvrn has joined #openstack-cinder | 15:19 | |
| *** annashen has quit IRC | 15:20 | |
| *** Mandell has quit IRC | 15:20 | |
| *** nlevinki has quit IRC | 15:26 | |
| *** Mandell has joined #openstack-cinder | 15:26 | |
| *** bkopilov has quit IRC | 15:33 | |
| *** takedakn1 has quit IRC | 15:40 | |
| *** nlevinki has joined #openstack-cinder | 15:41 | |
| *** abehl has quit IRC | 15:41 | |
| *** esker has joined #openstack-cinder | 15:42 | |
| *** jungleboyj has joined #openstack-cinder | 15:45 | |
| *** marcusvrn1 has joined #openstack-cinder | 15:46 | |
| *** marcusvrn has quit IRC | 15:46 | |
| *** bkopilov has joined #openstack-cinder | 15:48 | |
| *** rwsu has joined #openstack-cinder | 15:48 | |
| *** alecv has quit IRC | 15:48 | |
| *** Masahiro has joined #openstack-cinder | 15:49 | |
| *** barra204_ has joined #openstack-cinder | 15:52 | |
| *** barra204_ is now known as shakamunyi | 15:53 | |
| *** Masahiro has quit IRC | 15:54 | |
| *** EduardBiceriMate has joined #openstack-cinder | 15:54 | |
| *** Mandell has quit IRC | 15:56 | |
| *** e0ne is now known as e0ne_ | 15:57 | |
| *** TobiasE1 has joined #openstack-cinder | 15:57 | |
| *** hemnafk is now known as hemna | 15:57 | |
| *** TobiasE has quit IRC | 15:57 | |
| *** bswartz has quit IRC | 15:59 | |
| *** Yogi11 has joined #openstack-cinder | 15:59 | |
| *** Yogi1 has quit IRC | 16:02 | |
| *** dustins_ has joined #openstack-cinder | 16:02 | |
| *** dustins has quit IRC | 16:03 | |
| *** timcl has quit IRC | 16:03 | |
| *** timcl1 has joined #openstack-cinder | 16:03 | |
| *** BharatK has joined #openstack-cinder | 16:06 | |
| *** e0ne_ is now known as e0ne | 16:06 | |
| *** TobiasE has joined #openstack-cinder | 16:08 | |
| *** TobiasE1 has quit IRC | 16:09 | |
| *** dustins_ has quit IRC | 16:10 | |
| *** dustins has joined #openstack-cinder | 16:11 | |
| *** bswartz has joined #openstack-cinder | 16:12 | |
| *** tsekiyama has joined #openstack-cinder | 16:13 | |
| *** mikedillion has joined #openstack-cinder | 16:13 | |
| *** mikedillion has quit IRC | 16:14 | |
| *** jistr has quit IRC | 16:15 | |
| *** jistr has joined #openstack-cinder | 16:16 | |
| *** jistr has quit IRC | 16:17 | |
| *** jistr has joined #openstack-cinder | 16:17 | |
| *** dannywilson has joined #openstack-cinder | 16:17 | |
| *** dannywilson has quit IRC | 16:19 | |
| *** dannywilson has joined #openstack-cinder | 16:19 | |
| *** mkoderer_cloud has quit IRC | 16:23 | |
| *** Miouge has joined #openstack-cinder | 16:27 | |
| *** xyang has joined #openstack-cinder | 16:28 | |
| *** TobiasE has quit IRC | 16:29 | |
| *** jdurgin1 has joined #openstack-cinder | 16:30 | |
| *** e0ne is now known as e0ne_ | 16:31 | |
| *** bkopilov has quit IRC | 16:34 | |
| *** nlevinki has quit IRC | 16:35 | |
| *** tshefi has quit IRC | 16:36 | |
| *** e0ne_ has quit IRC | 16:41 | |
| *** cnesa has quit IRC | 16:43 | |
| *** IanGovett has quit IRC | 16:43 | |
| openstackgerrit | j_king proposed openstack/cinder: Update eqlx_cli_max_retries help text https://review.openstack.org/144656 | 16:49 |
| *** nellysmitt has joined #openstack-cinder | 16:50 | |
| *** _cjones_ has joined #openstack-cinder | 16:50 | |
| *** IanGovett has joined #openstack-cinder | 16:51 | |
| *** avishay has quit IRC | 17:02 | |
| *** bswartz has quit IRC | 17:02 | |
| *** jpich has quit IRC | 17:04 | |
| *** dustins has quit IRC | 17:05 | |
| *** timcl1 has quit IRC | 17:05 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/python-cinderclient: WIP Add volume multi attach support https://review.openstack.org/85856 | 17:06 |
| jungleboyj | hemna: We were just talking about that this morning. :-) | 17:06 |
| hemna | uh oh. | 17:06 |
| *** e0ne has joined #openstack-cinder | 17:07 | |
| hemna | what did I do? | 17:07 |
| *** dustins has joined #openstack-cinder | 17:07 | |
| *** timcl has joined #openstack-cinder | 17:07 | |
| jungleboyj | hemna: Internal teams want to take the code and start trying it. Any reason they can't try to use it? | 17:07 |
| hemna | jungleboyj, there isn't any support in nova for it yet :( | 17:07 |
| hemna | jungleboyj, let me find the nova patch | 17:07 |
| *** Yogi11 has quit IRC | 17:08 | |
| hemna | jungleboyj, but, the multi-attach patch should still work either way. meaning that it doesn't break cinder :P | 17:08 |
| jgriffith | e0ne: ping | 17:09 |
| hemna | jungleboyj, https://review.openstack.org/#/c/143114/ | 17:09 |
| e0ne | jgriffith: hi | 17:09 |
| jgriffith | e0ne: howdy! | 17:09 |
| jgriffith | e0ne: re https://review.openstack.org/#/c/144739/2/cinder/api/v2/volumes.py | 17:09 |
| e0ne | jgriffith: yep, i've seen DuncanT's comment. i'll need to try to use one db query and remove nested loop | 17:10 |
| hemna | e0ne, what are you working on wrt the states ? | 17:10 |
| jgriffith | e0ne: I wouldn't block on it | 17:10 |
| e0ne | jgriffith, hemna: excuse me, i must go home right now. will you be able here in 2 hours? | 17:11 |
| jgriffith | e0ne: and honestly not exactly sure what DuncanT might have in mind | 17:11 |
| DuncanT | e0ne: You can keep the loop maybe, just flatten what is returning into a simple list rather than a query first? | 17:11 |
| hemna | e0ne, yah | 17:11 |
| jgriffith | e0ne: NP, or we can catch up tomorrow morning (I'll be around earlier) :) | 17:11 |
| jgriffith | DuncanT: +1 | 17:11 |
| DuncanT | e0ne: They are pretty damn unlikely to get big enough to use enough memory to be overly scary | 17:12 |
| hemna | anyone looking into adding '-ing' checks in the API to prevent actions, so we can remove the volume manager local locks ? | 17:12 |
| e0ne | jgriffith: i'll be here tonight. my working day starts at noon and ends late sometimes:) | 17:12 |
| *** mikedillion has joined #openstack-cinder | 17:13 | |
| jgriffith | hemna: sorry, I'm afraid I didn't really follow that | 17:13 |
| e0ne | i've got some ideas for my patch. i'll add it today | 17:13 |
| jgriffith | hacking checks in the API to prevent actions? | 17:13 |
| jgriffith | or you "mean" '-ing' as in doing something checks | 17:13 |
| jgriffith | ? | 17:13 |
| hemna | jgriffith, so we talked about adding some checks in the API to stop actions at the API level if a volume is in an 'ing' state. so we could remove the volume manager local file locks | 17:13 |
| e0ne | hemna: i and team would like to start looking on '-ing' statuses issues | 17:13 |
| hemna | jgriffith, yah basically | 17:14 |
| jgriffith | haha! Yes, ok that's much better :) | 17:14 |
| * jgriffith was like WTF? | 17:14 | |
| hemna | heh | 17:14 |
| * e0ne be back in ~2 hours | 17:14 | |
| hemna | it's something I'm interested in for K | 17:14 |
| jgriffith | hemna: so I'm not sure how that plays now with the object stuff and all that's going on | 17:14 |
| jgriffith | hemna: should be complimentary | 17:14 |
| jgriffith | but don't know | 17:14 |
| hemna | yah I dunno either | 17:14 |
| hemna | is the object stuff being worked on ? | 17:15 |
| jgriffith | hemna: honestly I was hoping we would start with that approach before going full blown objects and conductor | 17:15 |
| hemna | I'd like to do something for K to remove the volume manager locks | 17:15 |
| hemna | jgriffith, agreed | 17:15 |
| jgriffith | hemna: I think it would "solve" a number of races pretty easily | 17:15 |
| jgriffith | but oh well | 17:15 |
| jgriffith | let's try harder first :) | 17:15 |
| hemna | lol | 17:15 |
| *** nikesh_vedams has joined #openstack-cinder | 17:15 | |
| hemna | is someone working on the object stuff ? | 17:16 |
| jgriffith | hemna: thangp is working on it pretty hard | 17:16 |
| jungleboyj | hemna: I was afraid of that ... no Nova changes yet. Any chance of those progressing in Kilo? | 17:16 |
| hemna | ah ok | 17:16 |
| thangp | hemma: i have most of the code up for review | 17:16 |
| hemna | jungleboyj, the nova patch looks pretty sad currently IMHO | 17:16 |
| jgriffith | thangp: it looks pretty good by the way (IMHO) | 17:16 |
| thangp | hemna: just working on unit tests right now, should have it for next week | 17:16 |
| hemna | jungleboyj, I just pinged Tobias on his status. I'd like to see it get finished ASAP. | 17:16 |
| *** e0ne has quit IRC | 17:17 | |
| thangp | jgriffith: thx | 17:17 |
| jgriffith | thangp: I haven't loaded it up and hammered on it, but the code came out cleaner than I had expected | 17:17 |
| hemna | thangp, url ? | 17:17 |
| *** e0ne has joined #openstack-cinder | 17:17 | |
| thangp | hemna: https://review.openstack.org/#/c/131873/ and https://review.openstack.org/#/c/133566/ | 17:17 |
| jungleboyj | hemna: Ok. Would be nice if we didn't have to wait another release on that. | 17:17 |
| *** e0ne has quit IRC | 17:17 | |
| hemna | jungleboyj, yes. I want this one off my back finally. | 17:17 |
| *** Yogi11 has joined #openstack-cinder | 17:18 | |
| hemna | jungleboyj, it might get to the point of us deciding to allow the cinder side changes in w/o nova or not. | 17:18 |
| hemna | just so we can move on. | 17:18 |
| hemna | bleh | 17:18 |
| jungleboyj | hemna: +1 | 17:18 |
| hemna | jgriffith, when you have time, I'd like your feedback on one of the issues you raised in my multi-attach patch | 17:18 |
| *** rushil has quit IRC | 17:19 | |
| *** Longgeek has quit IRC | 17:19 | |
| *** jistr has quit IRC | 17:22 | |
| *** marcusvrn1 has quit IRC | 17:23 | |
| *** Longgeek has joined #openstack-cinder | 17:25 | |
| *** jdurgin1 has quit IRC | 17:27 | |
| *** mikedillion has quit IRC | 17:29 | |
| jgriffith | hemna: sure | 17:30 |
| *** thingee has joined #openstack-cinder | 17:30 | |
| thingee | DuncanT: ping | 17:32 |
| jgriffith | hemna: which comments :) | 17:34 |
| hemna | what to do when the attachment id isn't passed in at detach time. | 17:35 |
| hemna | you mentioned allowing and defaulting to detach every volume. | 17:35 |
| jgriffith | hemna: yeah, you don't like my idea? | 17:35 |
| hemna | I guess I just hadn't thought of that. | 17:35 |
| jgriffith | hemna: so I was just thinking that I liked that behavior in the case of... | 17:36 |
| hemna | basically what I have in place now is that the code will check to see if the volume is attached more than once. | 17:36 |
| jgriffith | "I'm done with this POS volume, I want to delete it" | 17:36 |
| hemna | and if the attachment id isn't passed it throws an exception. | 17:36 |
| jgriffith | I just say "detach"... and "delete" | 17:36 |
| jgriffith | done | 17:36 |
| hemna | which basically protects the other attachments. | 17:36 |
| *** Yogi11 has quit IRC | 17:36 | |
| hemna | yah I get that | 17:36 |
| hemna | I just want to make sure I do the right thing. | 17:36 |
| jgriffith | hemna: yeah, so I see your check and that's totally cool | 17:36 |
| hemna | I was just trying to be conservative about it. | 17:37 |
| jgriffith | hemna: I'm just trying to think about the "default" case which I still think should be single attach | 17:37 |
| hemna | I do see the value in a mass detach though | 17:37 |
| jgriffith | making the second part an "optional" | 17:37 |
| DuncanT | thingee: Hi | 17:37 |
| jgriffith | hemna: so that's part of it, the other part was just the "normal" behavior and call | 17:37 |
| hemna | so I think this check only happens if the volume is shareable | 17:37 |
| hemna | if it's not shareable, then it won't have more than 1 attachment | 17:38 |
| hemna | and it should still work as today. | 17:38 |
| DuncanT | thingee: Cooking, so lagged replies, but I'm about | 17:38 |
| *** Masahiro has joined #openstack-cinder | 17:38 | |
| hemna | the question is, what to do about the shareable volumes that have more than 1 attachment. | 17:38 |
| jgriffith | hemna: yeah, but you MUST pass in the attachment_id though right | 17:38 |
| jgriffith | that's the part I was thinking of ditching | 17:38 |
| hemna | the API defaults to None now. | 17:38 |
| jgriffith | lemme look at update :) | 17:39 |
| *** cl__ has quit IRC | 17:39 | |
| hemna | https://review.openstack.org/#/c/85847/14/cinder/api/contrib/admin_actions.py | 17:40 |
| hemna | I guess I could make it more explicit and add a default in the function definitions for the rpcapi as well | 17:41 |
| hemna | attachment_id=None | 17:41 |
| *** jungleboyj has quit IRC | 17:42 | |
| hemna | I have that in the volume manager's detach_volume fwiw | 17:42 |
| jgriffith | hemna: sorry... distracted, somebody's at my desk; gimmie a minute | 17:42 |
| hemna | also https://review.openstack.org/#/c/85856/5/cinderclient/v2/volumes.py | 17:42 |
| hemna | I added a None default for the cinderclient as well. fwiw. | 17:43 |
| *** Masahiro has quit IRC | 17:43 | |
| nikesh_vedams | hi i have a doubt,in cinder support matrix,what host assisted means in cinder volume migration? | 17:43 |
| hemna | jgriffith, no worries. I'm on a conf call as well. | 17:43 |
| hemna | nikesh_vedams, when a driver can do the migration itself. | 17:43 |
| hemna | nikesh_vedams, basically the backend array/storage can do the migration instead of cinder doing it the hard way. | 17:44 |
| *** changbl has joined #openstack-cinder | 17:45 | |
| *** thangp has quit IRC | 17:46 | |
| *** thangp has joined #openstack-cinder | 17:46 | |
| nikesh_vedams | hemna:i checked hp3par code and i understood that it is doing migration under different cpg under same domain and same array so if domain and array is differnt then | 17:47 |
| nikesh_vedams | how volume migration will take place | 17:48 |
| hemna | nikesh_vedams, yup. if the volume is going to land on the same host, then the driver gets an chance to do the migration itself. | 17:49 |
| hemna | nikesh_vedams, the cpg, domain tests are just an artifact of the 3PAR itself. | 17:49 |
| *** cl__ has joined #openstack-cinder | 17:51 | |
| *** leeantho has joined #openstack-cinder | 17:54 | |
| *** marcusvrn has joined #openstack-cinder | 17:55 | |
| *** Longgeek has quit IRC | 17:56 | |
| *** Longgeek has joined #openstack-cinder | 17:57 | |
| nikesh_vedams | hemna: thanks,one more thing i have wrote cinder driver for dothill array which is similar to HPMSA array,when i am running "/driver_certs/cinder_driver_cert.sh",all tests are passed,only 2-3 test cases are failing | 17:57 |
| *** cl__ has quit IRC | 17:57 | |
| nikesh_vedams | and those tests cases are running good individually | 17:58 |
| nikesh_vedams | but overall this script is saying driver faield | 17:58 |
| nikesh_vedams | failed | 17:58 |
| nikesh_vedams | created all in one node with tempest environment as suggested by jgriffith earlier | 17:59 |
| *** jordanP has quit IRC | 18:00 | |
| *** rushil has joined #openstack-cinder | 18:00 | |
| *** jamielennox|away is now known as jamielennox | 18:01 | |
| *** afazekas has quit IRC | 18:01 | |
| openstackgerrit | j_king proposed openstack/cinder: Update eqlx_cli_max_retries help text https://review.openstack.org/144656 | 18:01 |
| thingee | DuncanT: I sent you an email earlier about the rpc clamp spec. Are we going to be seeing an update on that soon? | 18:04 |
| jgriffith | nikesh_vedams: results/logs for those failing tests? | 18:05 |
| jgriffith | nikesh_vedams: we can't possibly guess :) | 18:06 |
| *** _cjones_ has quit IRC | 18:06 | |
| thingee | jamielennox: hey so I was looking at adding the hack in the session request method. I don't have a project id to prepend. | 18:07 |
| thingee | jamielennox: should I just add project id to the interface and delete the kwarg before calling session super __init__() | 18:07 |
| *** e0ne has joined #openstack-cinder | 18:08 | |
| *** tbarron has joined #openstack-cinder | 18:08 | |
| jamielennox | thingee: so i have a review that makes it available: https://review.openstack.org/#/c/118520/ | 18:09 |
| thingee | jamielennox: oh sorry, you did mention that yesterday | 18:09 |
| jamielennox | however for the mean time you'll probably need to fetch it yourself | 18:09 |
| thingee | my bad | 18:09 |
| thingee | thanks | 18:09 |
| jamielennox | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/httpclient.py#L101 | 18:10 |
| thingee | jamielennox: got it thanks | 18:10 |
| jamielennox | is how keystoneclient does it, but looking at it now that assumes self.session.auth where it should be (self.auth or self.session.auth) | 18:10 |
| nikesh_vedams | ok i will provide,one more doubt is that cinder driver can do migration by taking help of array/backend or creating another volume and copy the contents in it.is both way will called host assisted volume migration | 18:11 |
| *** mudassirlatif has joined #openstack-cinder | 18:12 | |
| jamielennox | thingee: i also don't think you'll need the second case that keystoneclient implements, so just: | 18:12 |
| jamielennox | auth = self.auth or self.session.auth | 18:12 |
| jamielennox | if hasattr(auth, 'get_access'): | 18:12 |
| jamielennox | user_id = auth.get_access(self.session).user_id | 18:12 |
| *** patrickeast has joined #openstack-cinder | 18:13 | |
| *** _cjones_ has joined #openstack-cinder | 18:15 | |
| hemna | ugh | 18:16 |
| hemna | ImportError: cannot import name _lazy | 18:16 |
| thingee | jamielennox: looks like tenant_id is an empty string | 18:16 |
| hemna | from oslo.i18n import _lazy | 18:16 |
| hemna | puking in jenkins | 18:16 |
| jamielennox | thingee: tenant_id coming from where? | 18:17 |
| hemna | oslo is so much fun | 18:17 |
| thingee | self.session.auth.tenant_id | 18:17 |
| *** annashen has joined #openstack-cinder | 18:18 | |
| jamielennox | thingee: that would be the result of what you provided the plugin when you created it, not the auth that it received | 18:18 |
| *** afazekas has joined #openstack-cinder | 18:18 | |
| jamielennox | the get_access(session) will return the current authorization if valid or fetch a new one | 18:18 |
| thingee | jamielennox: ah ha got it working | 18:19 |
| thingee | whew | 18:19 |
| thingee | my mistake | 18:19 |
| *** setmason has joined #openstack-cinder | 18:19 | |
| setmason | Has the mid-cycle meetup date/location been planned? | 18:19 |
| hemna | ugh | 18:20 |
| hemna | oslo.i18n moved all of their code into oslo_i18n | 18:20 |
| hemna | ! | 18:20 |
| hemna | breaking everything | 18:20 |
| hemna | wth | 18:20 |
| hemna | *sigh* | 18:20 |
| hemna | https://github.com/openstack/oslo.i18n/tree/master/oslo_i18n | 18:20 |
| *** thingee has quit IRC | 18:21 | |
| hemna | where is our oslo rep ? :P | 18:21 |
| *** e0ne has quit IRC | 18:21 | |
| smcginnis | setmason: Here's info: https://etherpad.openstack.org/p/cinder-kilo-midcycle-meetup | 18:21 |
| DuncanT | thingee: Yes. I've some prototype code that helps clear up what needs doing, and I'll try to push a spec update before the meeting tomorrow | 18:22 |
| *** BharatK has quit IRC | 18:22 | |
| DuncanT | hema: Ok, so I suggest we tell the oslo team we're keeping our own forks of all their stuff unless they stop pulling this crap | 18:23 |
| *** thingee has joined #openstack-cinder | 18:23 | |
| *** patrickeast has quit IRC | 18:23 | |
| DuncanT | 8:22 PM <DuncanT> thingee: Yes. I've some prototype code that helps clear up what needs doing, and I'll try to push a spec update before the meeting tomorrow | 18:23 |
| *** patrickeast_ has joined #openstack-cinder | 18:23 | |
| *** patrickeast_ is now known as patrickeast | 18:23 | |
| nikesh_vedams | heman: if cinder driver creates another volume and copy contents in it,means doing volume migration in hard way then is it called host assisted volume migration? | 18:23 |
| *** asselin has quit IRC | 18:23 | |
| nikesh_vedams | hemna: if cinder driver creates another volume and copy contents in it,means doing volume migration in hard way then is it called host assisted volume migration? | 18:24 |
| thingee | setmason: not sure if anyone answered your question since I dropped but midcycle meetup info is here https://etherpad.openstack.org/p/cinder-kilo-midcycle-meetup | 18:24 |
| thingee | DuncanT: ok thanks | 18:24 |
| *** bkopilov has joined #openstack-cinder | 18:25 | |
| *** bswartz has joined #openstack-cinder | 18:25 | |
| *** Longgeek_ has joined #openstack-cinder | 18:27 | |
| *** asselin has joined #openstack-cinder | 18:28 | |
| *** Yogi1 has joined #openstack-cinder | 18:29 | |
| *** Longgeek has quit IRC | 18:30 | |
| *** jistr has joined #openstack-cinder | 18:30 | |
| *** setmason has left #openstack-cinder | 18:30 | |
| *** jistr has quit IRC | 18:31 | |
| *** nellysmitt has quit IRC | 18:31 | |
| *** jistr has joined #openstack-cinder | 18:32 | |
| nikesh_vedams | jgriffith: sent you mail having tempest log | 18:32 |
| *** bswartz has quit IRC | 18:35 | |
| thingee | jamielennox: what would be the case auth doesn't have get_access? | 18:39 |
| jamielennox | so the majority of plugins are IdenttiyPlugins - as in they talk to keystone | 18:39 |
| *** jungleboyj has joined #openstack-cinder | 18:40 | |
| jamielennox | thingee: there is the provision that they don't have to be - you can use whatever you like as a plugin | 18:40 |
| jgriffith | nikesh_vedams: Details: (VolumesActionsV1Test:test_volume_force_delete_when_volume_is_attaching) Failed to delete volume c1d8f0f1-6555-4007-91ae-c01afac02014 within the required time (196 s). | 18:40 |
| jamielennox | thingee: and the one that is most likely is token/endpoint, as in use this existing token with this known endpoint - if you do that then there's really nothing i can do about getting the project_id | 18:40 |
| jgriffith | nikesh_vedams: any chance your driver has locks in int? | 18:41 |
| jgriffith | it | 18:41 |
| *** nellysmitt has joined #openstack-cinder | 18:42 | |
| jgriffith | nikesh_vedams: so you actually have one test that fails and takes everything down with it | 18:43 |
| jgriffith | nikesh_vedams: do you have the c-vol logs? | 18:45 |
| kvidvans | Anyone I can talk to regarding the mid-cycle meetup... Oracle may have another person joining, but it looks like the limit of 20 persons has been reached: https://etherpad.openstack.org/p/cinder-kilo-midcycle-meetup | 18:45 |
| *** nellysmitt has quit IRC | 18:46 | |
| *** Mandell has joined #openstack-cinder | 18:47 | |
| thingee | kvidvans: talk to jungleboyj | 18:47 |
| nikesh_vedams | jgrffith:no i donot have now,but individually these these test cases are passing | 18:48 |
| kvidvans | thingee: thanks | 18:48 |
| nikesh_vedams | jgriffith:can i increase this 196 s | 18:49 |
| *** xyang has quit IRC | 18:50 | |
| nikesh_vedams | jgriffith: i am using lock concepts from HPMSA code | 18:51 |
| *** timcl has quit IRC | 18:53 | |
| *** timcl has joined #openstack-cinder | 18:54 | |
| *** Longgeek_ has quit IRC | 19:01 | |
| thingee | jungleboyj: ping | 19:02 |
| *** Longgeek has joined #openstack-cinder | 19:04 | |
| *** julim has joined #openstack-cinder | 19:05 | |
| *** shakamunyi has quit IRC | 19:07 | |
| jgriffith | nikesh_vedams: looks like maybe one of the parallel jobs is locking the driver so you can't perform the delete | 19:10 |
| jgriffith | nikesh_vedams: and thus the timeout | 19:10 |
| *** dkingshott has joined #openstack-cinder | 19:10 | |
| thingee | jungleboyj, jgriffith: http://paste.openstack.org/show/155785/ | 19:11 |
| jgriffith | nikesh_vedams: that's why they pass individually | 19:11 |
| jgriffith | thingee: w00t | 19:11 |
| thingee | finally | 19:11 |
| thingee | all thanks to jamielennox for being patient with me | 19:11 |
| *** Miouge has quit IRC | 19:12 | |
| jamielennox | thingee: i've been going through heat recently, you'll need to fix something there as it relies upon testing if either volume or voluemv2 is in the catalog for version | 19:13 |
| thingee | jamielennox: yeah and tripleo and nova | 19:14 |
| jamielennox | ok, just thought i'd mention | 19:15 |
| thingee | jamielennox: no thanks for mentioning it. It's not going to be an easy change | 19:15 |
| *** Miouge has joined #openstack-cinder | 19:16 | |
| jamielennox | whilst i have attention can we just pass https://review.openstack.org/#/c/131163/ already - it's a fairly obvious fix | 19:16 |
| thingee | jamielennox: ah yes, I just came across that myself, thanks | 19:16 |
| jamielennox | maybe it doesn't matter if we are going to fix nova to not retrieve that value from the URL any more | 19:18 |
| *** e0ne has joined #openstack-cinder | 19:18 | |
| *** e0ne is now known as e0ne_ | 19:19 | |
| nikesh_vedams | jgriffith:so this is failing my driver :( | 19:20 |
| jgriffith | nikesh_vedams: as well it should | 19:20 |
| nikesh_vedams | jgriffith:how can i increase this 196s | 19:22 |
| nikesh_vedams | and do you know some one who know HPMSA cinder volume driver testing | 19:23 |
| nikesh_vedams | may be he also faced this type of issues | 19:24 |
| *** ryanpetrello_ has joined #openstack-cinder | 19:25 | |
| *** Masahiro has joined #openstack-cinder | 19:27 | |
| *** ryanpetrello has quit IRC | 19:27 | |
| *** ryanpetrello_ is now known as ryanpetrello | 19:27 | |
| *** bswartz has joined #openstack-cinder | 19:28 | |
| *** e0ne_ has quit IRC | 19:28 | |
| jgriffith | nikesh_vedams: are you just copying their work or developing your own? | 19:29 |
| *** Masahiro has quit IRC | 19:31 | |
| *** xyang has joined #openstack-cinder | 19:32 | |
| thingee | jamielennox: is there common code in keystone client for / GET version discovery? | 19:33 |
| nikesh_vedams | jgriffith:after copying the work, i am adding features whats not provided by it | 19:34 |
| nikesh_vedams | because my array is similar to that | 19:34 |
| *** e0ne has joined #openstack-cinder | 19:34 | |
| jamielennox | thingee: you can use keystoneclient.discover.Discover | 19:35 |
| jamielennox | that gives you the basics | 19:35 |
| jamielennox | however if you already have auth then you can just do | 19:36 |
| jamielennox | auth.get_endpoint(session, service_type='volume', interface='public', version=(2, 0)) | 19:36 |
| jamielennox | it will return a string if it finds one otherwise None | 19:36 |
| e0ne | i'm back | 19:37 |
| *** david-lyle_afk is now known as david-lyle | 19:39 | |
| e0ne | jgriffith, hemna: i'm ready to discuss my patch and '-ing status' | 19:40 |
| * e0ne looking to today's irc logs | 19:41 | |
| *** lpetrut has quit IRC | 19:44 | |
| *** hypnosb has quit IRC | 19:47 | |
| *** hypnosb has joined #openstack-cinder | 19:48 | |
| *** shakamunyi has joined #openstack-cinder | 19:52 | |
| e0ne | hemna: btw, is any update with brick and agent? | 19:54 |
| *** barra204_ has joined #openstack-cinder | 19:55 | |
| *** shakamunyi has quit IRC | 19:58 | |
| hemna | e0ne, lunch....bbiab | 20:01 |
| e0ne | hemna: bon appetit! | 20:02 |
| * jungleboyj is eating as well and thinking about tiramisu :-) | 20:03 | |
| e0ne | again... tiramisu... | 20:04 |
| *** leeantho has quit IRC | 20:04 | |
| *** sseverson has quit IRC | 20:04 | |
| smcginnis | jungleboyj: Always bringing up the good desserts. :) | 20:04 |
| jungleboyj | e0ne: That was for you. | 20:05 |
| *** asselin has quit IRC | 20:05 | |
| *** KurtMartin has quit IRC | 20:05 | |
| *** fischerw has quit IRC | 20:05 | |
| jungleboyj | smcginnis: Of course. | 20:05 |
| *** sseverson has joined #openstack-cinder | 20:05 | |
| *** leeantho has joined #openstack-cinder | 20:05 | |
| *** asselin has joined #openstack-cinder | 20:05 | |
| *** KurtMartin has joined #openstack-cinder | 20:05 | |
| *** fischerw has joined #openstack-cinder | 20:05 | |
| e0ne | jungleboyj: :) | 20:05 |
| jungleboyj | I am going to have to settle for Christmas Cookies at the moment though. | 20:06 |
| thingee | jungleboyj: did you see my link earlier | 20:06 |
| thingee | jungleboyj: no more volume and volumev2 service types | 20:07 |
| jungleboyj | No, I didn't see that earlier. | 20:08 |
| *** sseverson has quit IRC | 20:08 | |
| *** KurtMartin has quit IRC | 20:08 | |
| *** fischerw has quit IRC | 20:08 | |
| openstackgerrit | Tomoki Sekiyama proposed openstack/cinder: Failover to alternative iSCSI portals on login failure https://review.openstack.org/140877 | 20:08 |
| *** leeantho has quit IRC | 20:08 | |
| *** asselin has quit IRC | 20:08 | |
| jungleboyj | thingee: Where was that? | 20:08 |
| openstackgerrit | Tomoki Sekiyama proposed openstack/cinder: Enhance iSCSI multipath support https://review.openstack.org/134681 | 20:08 |
| *** KurtMartin has joined #openstack-cinder | 20:08 | |
| *** sseverson has joined #openstack-cinder | 20:08 | |
| thingee | jungleboyj: http://paste.openstack.org/show/155785/ | 20:08 |
| *** leeantho has joined #openstack-cinder | 20:08 | |
| jungleboyj | thingee: How does that work? | 20:09 |
| *** lpetrut has joined #openstack-cinder | 20:12 | |
| thingee | jungleboyj: uses keystoneclient's discovery with the specified version from the client | 20:16 |
| jungleboyj | thingee: Nice. So, is that an option that is set up with keystone then? | 20:17 |
| *** jistr has quit IRC | 20:25 | |
| *** _cjones_ has quit IRC | 20:25 | |
| *** Mandell has quit IRC | 20:26 | |
| *** tellesnobrega has quit IRC | 20:28 | |
| ameade_ | looks like oslo.i18n 1.2.0 is gonna break gate, just a heads up | 20:36 |
| ameade_ | cinder unittests barf with " from oslo.i18n import _lazy | 20:37 |
| ameade_ | ImportError: cannot import name _lazy" | 20:37 |
| ameade_ | dhellmann: ^^ | 20:37 |
| ameade_ | thingee: ^^ | 20:37 |
| dhellmann | ameade_: hmm. I wonder why cinder's tests are importing a private module from oslo.i18n? | 20:38 |
| dhellmann | it's possible those tests could be rewritten using the fixture that provides explicit access to lazy and immediate translation - http://docs.openstack.org/developer/oslo.i18n/api.html#module-oslo_i18n.fixture | 20:40 |
| thingee | jungleboyj: ^ | 20:41 |
| *** tellesnobrega has joined #openstack-cinder | 20:41 | |
| *** akerr has joined #openstack-cinder | 20:42 | |
| *** _cjones_ has joined #openstack-cinder | 20:42 | |
| *** nellysmitt has joined #openstack-cinder | 20:43 | |
| smcginnis | hemna: ^ | 20:43 |
| smcginnis | hemna: Weren't you having fun with that earlier? | 20:43 |
| *** pcaruana is now known as pcaruana|afk| | 20:45 | |
| jgriffith | dhellmann: thingee test.py | 20:45 |
| jgriffith | :( | 20:45 |
| thingee | heh | 20:45 |
| thingee | test.py fixes all | 20:45 |
| *** mudassirlatif has quit IRC | 20:45 | |
| dhellmann | the enable_lazy() function is also exposed as oslo.i18n.enable_lazy() | 20:46 |
| dhellmann | but the flag being kept in that module is not part of its public API, so it is not exposed | 20:46 |
| jgriffith | dhellmann: cool | 20:47 |
| jgriffith | thingee: dhellmann think I've got it fixed | 20:47 |
| jgriffith | thingee: dhellmann lemme get a bug logged and I'll push it | 20:47 |
| jgriffith | (after tests finish) | 20:47 |
| dhellmann | if you really need to turn it on and off globally in a test, a new fixture could be created to do that, too, but that's not thread safe so I'm not sure it's a good idea to be doing | 20:47 |
| *** vmtyler has quit IRC | 20:47 | |
| dhellmann | jgriffith: cool | 20:47 |
| *** Mandell has joined #openstack-cinder | 20:47 | |
| jgriffith | dhellmann: I just removed it from the test completely | 20:47 |
| jgriffith | dhellmann: seems like bad juju to have it there anyway | 20:48 |
| *** nellysmitt has quit IRC | 20:48 | |
| dhellmann | does that mean you're not testing the wsgi stack with translatable exceptions? or that you're *always* testing with translatable exceptions? | 20:48 |
| jgriffith | dhellmann: it is, but it's doing it in its own setup (IIRC) | 20:49 |
| dhellmann | ok | 20:49 |
| jgriffith | dhellmann: should probably make sure :) | 20:49 |
| jgriffith | dhellmann: thingee ummmm... WTF? | 20:55 |
| *** jcru has quit IRC | 20:55 | |
| jgriffith | dhellmann: I think we have a problem here.... | 20:56 |
| *** mudassirlatif has joined #openstack-cinder | 20:56 | |
| jgriffith | ahhh... wait, I see | 20:56 |
| jgriffith | geesh.... | 20:56 |
| *** mudassirlatif has quit IRC | 20:56 | |
| jgriffith | anybody know why we do a cinder.i18n.py file? | 20:57 |
| jgriffith | ahh... | 20:57 |
| jgriffith | ok, now I'm catching up LOL | 20:57 |
| jgriffith | dhellmann: how about disable? | 20:58 |
| jgriffith | or is that default on init I suppose | 21:00 |
| jgriffith | sorry... | 21:00 |
| * jgriffith is talking to himself | 21:00 | |
| jgriffith | or talking out loud virtually | 21:00 |
| *** timcl has quit IRC | 21:00 | |
| *** esker has quit IRC | 21:01 | |
| dhellmann | jgriffith: lazy translation is disabled by default | 21:01 |
| dhellmann | an enable_lazy() takes a boolean so it can be turned off explicitly, too | 21:01 |
| jgriffith | dhellmann: yeah, but our stupid wrapper doesn't :( | 21:02 |
| jgriffith | dhellmann: see if what I have now works, else I'll change that up | 21:02 |
| jgriffith | dhellmann: not sure why it failed this last go around, but I'm looking | 21:02 |
| hemna | jgriffith, oslo.i18n moved all of their files into a different dir | 21:02 |
| dhellmann | jgriffith: it might be simplest to add a fixture to oslo.i18n | 21:02 |
| hemna | I saw it earlier today when some of my patches started puking | 21:02 |
| *** IanGovett has quit IRC | 21:03 | |
| dhellmann | hemna: we provided backwards compatibility shims for all of the public APIs. You guys are messing around with private parts of the library still. | 21:03 |
| hemna | thanks for the notice! | 21:03 |
| dhellmann | hemna: You may want to start following the -dev mailing list. We've been talking about this work there quite a bit. | 21:03 |
| jgriffith | hemna: thanks for fixing it up... oh wait :) | 21:03 |
| hemna | I think we are all on the dev mailing list, but since it's so full of lots of discussions, it's easy to miss stuff | 21:04 |
| hemna | it would have been nice to be notified in here. | 21:04 |
| hemna | oh well. | 21:04 |
| jgriffith | hemna: :) | 21:04 |
| *** _cjones_ has quit IRC | 21:05 | |
| jgriffith | hemna: but the point is we shouldn't be trying to pull in those priv modules anyway | 21:06 |
| thingee | jgriffith: +1 | 21:06 |
| hemna | yah I don't disagree with that | 21:06 |
| thingee | also we do have some designated to filter throught he noise and let us know when there are changes we should be concerned about | 21:06 |
| hemna | I'm not sure who did that and for what reason. maybe it's cruft from a long while ago | 21:06 |
| thingee | some=someone | 21:07 |
| hemna | I'm just saying it sucks to find out about it with failing patches in jenkins is all. | 21:07 |
| thingee | jungleboyj: :) | 21:07 |
| dhellmann | I'll remind our liaisons to make sure they communicate our plans with their "home" teams. That's part of why we have designated points of contact. | 21:07 |
| hemna | dhellmann, +1 | 21:07 |
| thingee | dhellmann: +1 | 21:07 |
| hemna | dhellmann, thanks man. I think that will help. At least then, you can say....see we told you! :P | 21:08 |
| jgriffith | we have too many unit tests :) | 21:10 |
| hemna | rm -rf cinder/tests | 21:10 |
| jgriffith | We should delete them all and start over :) | 21:10 |
| hemna | :P | 21:10 |
| jgriffith | hemna: :) | 21:10 |
| jgriffith | Or I need more cores to run them faster | 21:10 |
| openstackgerrit | Corey Bryant proposed openstack/cinder: Handle ISCSIConnector.get_initiator() OSError https://review.openstack.org/145342 | 21:10 |
| jgriffith | down to 2 | 21:11 |
| jgriffith | DOH!! wsgi tests LOL | 21:11 |
| jungleboyj | I have a feeling I have missed something here. Scrolling through the history. | 21:11 |
| hemna | so it looks like it's isolated to cinder/test.py ? | 21:11 |
| e0ne | jgriffith: it won't help you. our tests can't be run in parallel now:( | 21:11 |
| hemna | _lazy.enable_lazy(enable=False) | 21:11 |
| jgriffith | hemna: no, already did that | 21:12 |
| jgriffith | hemna: back_use_lazy = _lazy.USE_LAZY | 21:12 |
| hemna | jgriffith, oh you have a patch up already ? | 21:12 |
| *** asselin has joined #openstack-cinder | 21:12 | |
| jgriffith | e0ne: you're such a downer! | 21:12 |
| jgriffith | hemna: yes | 21:12 |
| *** tsekiyama has quit IRC | 21:12 | |
| hemna | jgriffith, ok cool. thanks. I was going to look into it. | 21:12 |
| hemna | nm! | 21:12 |
| e0ne | hm.. | 21:13 |
| *** tsekiyama has joined #openstack-cinder | 21:15 | |
| jgriffith | dhellmann: is there a handy get method? | 21:15 |
| *** Masahiro has joined #openstack-cinder | 21:16 | |
| *** westmaas has joined #openstack-cinder | 21:16 | |
| * jgriffith could just go look :) | 21:16 | |
| dhellmann | jgriffith: get method? | 21:16 |
| *** westmaas has left #openstack-cinder | 21:16 | |
| jgriffith | so there's some places where someobdy did "_lazy.USE_LAZY" | 21:17 |
| jgriffith | and put it in their setup/teardown for checks | 21:17 |
| jgriffith | or, cleanup | 21:17 |
| jgriffith | I should say | 21:17 |
| jgriffith | more proper would probably be to set it explicitly for each test | 21:17 |
| dhellmann | yeah, that's the part I was suggesting might warrant a new fixture to toggle it on and restore it. The use of that flag is an implementation detail. At some point we're going to just turn on lazy translation and leave it on all the time. | 21:18 |
| jgriffith | dhellmann: yeah, all coming together now | 21:18 |
| *** _cjones_ has joined #openstack-cinder | 21:18 | |
| *** Longgeek has quit IRC | 21:18 | |
| *** Miouge has quit IRC | 21:19 | |
| *** Masahiro has quit IRC | 21:20 | |
| *** scottda_ has joined #openstack-cinder | 21:20 | |
| *** _cjones_ has quit IRC | 21:25 | |
| *** scottda_ has quit IRC | 21:27 | |
| *** russellb has joined #openstack-cinder | 21:27 | |
| *** scottda_ has joined #openstack-cinder | 21:27 | |
| jungleboyj | hemna: Finally caught up on the discussion. I apologize. I think it is my bad for not explicitly mentioning some of the changes coming from Oslo. | 21:28 |
| jungleboyj | I have been working on getting things merged bug haven't really discussed what is going on. | 21:28 |
| jungleboyj | hemna: Next will be changes for the change in name space. I can put some discussion on the calendar in tomorrow's meeting to cover that to make sure everyone knows what is going on. | 21:29 |
| hemna | ok that'd be cool | 21:29 |
| *** xyang has quit IRC | 21:29 | |
| hemna | was there simply no mechanism in oslo.i18n that required us to put those calls to _lazy.* in the first place ? | 21:30 |
| *** _cjones_ has joined #openstack-cinder | 21:31 | |
| *** lpabon has quit IRC | 21:32 | |
| jungleboyj | So, the whole enable_lazy stuff is the work I did a release or two ago. You don't have t explicitly enable it in each module because it is enabled at the top level in the bin/cinder-* files. | 21:33 |
| jgriffith | jungleboyj: well... that's not the problem :( | 21:33 |
| jungleboyj | In unit test, however, it does need to be explicitly set if you are testing translation is disabled by default. | 21:34 |
| jgriffith | jungleboyj: the problem is it was imported like "import _lazy" | 21:34 |
| jgriffith | then used directly, "_lazy.enable()" | 21:34 |
| jgriffith | and most of the unit tests that did this and had it didn't need it | 21:34 |
| jgriffith | jungleboyj: the wsgi test however I haven't quite figured out what it breaks, but it's hosed without it | 21:35 |
| jgriffith | jungleboyj: mostly a result of the BACK_LAZY ting that was going on I suspect | 21:35 |
| *** _cjones_ has quit IRC | 21:35 | |
| jgriffith | jungleboyj: ahhh :) | 21:36 |
| jgriffith | another no no | 21:36 |
| jgriffith | ok fixed, I think | 21:36 |
| jungleboyj | Oh, I haven't seen the use of _lazy ... Would need to go look at that. The wsgi test does weird stuff with enable_lazy | 21:36 |
| jgriffith | jungleboyj: hemna k, gimmie a few while it runs thorugh all tests one last time | 21:37 |
| hemna | coolio | 21:37 |
| jungleboyj | Ok. Happy to look once it is out there. | 21:38 |
| *** barra204_ has quit IRC | 21:39 | |
| *** barra204_ has joined #openstack-cinder | 21:40 | |
| smcginnis | https://github.com/openstack/cinder/blame/master/cinder/tests/api/middleware/test_faults.py | 21:41 |
| *** lpabon has joined #openstack-cinder | 21:41 | |
| jungleboyj | Ah ... Jim. | 21:42 |
| * hemna points finger | 21:42 | |
| jungleboyj | I was going to guess it had something to do with what he was working on. | 21:43 |
| jungleboyj | What do you know, he isn't surprised there was an issue with the namespace changes. | 21:43 |
| jgriffith | jungleboyj: I'm thinking that folks might be missing the point still :) | 21:44 |
| *** scottda_ has quit IRC | 21:44 | |
| jungleboyj | jgriffith: ? | 21:44 |
| hemna | jgriffith, +1 | 21:44 |
| jgriffith | jungleboyj: we really "shouldn't" care if the name space for the internals of the lib change | 21:44 |
| jgriffith | we shouldn't have been poking around there to begin with :) | 21:44 |
| jgriffith | That's the whole point of using a lib :) | 21:44 |
| thingee | jgriffith: +1 | 21:45 |
| jgriffith | jungleboyj: hemna and someobdy did it with _message as well | 21:45 |
| smcginnis | Be _lazy. | 21:45 |
| jgriffith | smcginnis: true-dat | 21:45 |
| jgriffith | :) | 21:45 |
| jungleboyj | Agreed. | 21:45 |
| *** mudassirlatif has joined #openstack-cinder | 21:46 | |
| jungleboyj | Some of this is due to the process of moving from incubator to library though, correct? We are finding issues as we go. | 21:47 |
| *** PaulCuzner has quit IRC | 21:47 | |
| jgriffith | jungleboyj: honestly... why are we even testing translations in cinder anyway? | 21:47 |
| jgriffith | ie in tests/api/middleware/test_faults | 21:48 |
| jungleboyj | jgriffith: That is a good question. | 21:48 |
| jungleboyj | Oh yuck, I see why this is a problem. | 21:49 |
| jungleboyj | Shouldn't be using anything from oslo.i18n anymore. | 21:50 |
| jgriffith | jungleboyj: no, that's not really it either | 21:50 |
| jgriffith | jungleboyj: but you shouldn't be using i18n._* | 21:50 |
| jgriffith | the *_* being the point | 21:51 |
| hemna | yah just the public apis that i18n supplies is all we should be using | 21:51 |
| jgriffith | private means there's no contractual guarantee in the interface | 21:51 |
| jgriffith | it's just that, private/internal... may be gone tomorrow | 21:51 |
| jgriffith | and today is tomorrow :) | 21:51 |
| dhellmann | heh | 21:52 |
| jungleboyj | Gotcha. | 21:52 |
| *** _cjones_ has joined #openstack-cinder | 21:52 | |
| *** ryanpetrello_ has joined #openstack-cinder | 21:55 | |
| *** ryanpetrello has quit IRC | 21:56 | |
| *** ryanpetrello_ is now known as ryanpetrello | 21:56 | |
| *** IanGovett has joined #openstack-cinder | 21:56 | |
| thingee | jgriffith: thanks for looking into this | 21:57 |
| thingee | jgriffith: honestly I would be fine with just ripping out the tests | 21:58 |
| jungleboyj | thingee: +2 | 22:00 |
| jungleboyj | To the thanks for looking into this. | 22:00 |
| jgriffith | thingee: I'm adding skips to the last few that I couldn't get figured out | 22:00 |
| jgriffith | running unit tests and pep8 again, then pushing it | 22:00 |
| jungleboyj | jgriffith: I will look. Jim and I can probably get the other test cases fixed once I see you patch. | 22:01 |
| jgriffith | jungleboyj: okie-dokie | 22:01 |
| *** e0ne has quit IRC | 22:02 | |
| thingee | jungleboyj: Reevaluate if we want to keep 'em | 22:02 |
| jungleboyj | thingee: Can do. | 22:03 |
| jungleboyj | back in a bit. Need to get Logan from Daycare. | 22:03 |
| *** jecarey has joined #openstack-cinder | 22:03 | |
| *** dustins has quit IRC | 22:05 | |
| *** rushil has quit IRC | 22:05 | |
| *** kmartin has joined #openstack-cinder | 22:06 | |
| jgriffith | dam hacking rules!!! | 22:06 |
| thingee | not dot in the title of a commit message | 22:06 |
| thingee | j/k | 22:06 |
| jgriffith | thingee: lmao | 22:07 |
| jgriffith | thingee: you'r killin me 'smalls' | 22:07 |
| *** KurtMartin has quit IRC | 22:08 | |
| *** bswartz has quit IRC | 22:09 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Remove import of private _lazy module https://review.openstack.org/145359 | 22:09 |
| hemna | lgtm | 22:12 |
| *** barra204_ has quit IRC | 22:12 | |
| hemna | only a partial fix for 1408099 ? | 22:12 |
| thingee | hemna: we're skipping tests | 22:13 |
| *** barra204 has joined #openstack-cinder | 22:13 | |
| thingee | once those are fixed, the bug will be completed | 22:13 |
| hemna | I see, chicken/egg | 22:13 |
| *** Yogi1 has quit IRC | 22:13 | |
| thingee | not exactly. jgriffith just couldn't figure out why they were still failing. jungleboyj is going to take a look at them and reevaluate if we're going to be testing translations. | 22:15 |
| thingee | hemna: ^ | 22:15 |
| hemna | ah ok | 22:15 |
| *** Mandell has quit IRC | 22:16 | |
| *** tries__ has quit IRC | 22:18 | |
| *** tbarron has quit IRC | 22:22 | |
| *** annashen has quit IRC | 22:24 | |
| dhellmann | jgriffith: now that I'm done with meetings, I had time to put together https://review.openstack.org/145364 | 22:31 |
| jgriffith | dhellmann: nice! | 22:32 |
| dhellmann | that may make it easier to unskip those remaining tests | 22:32 |
| jgriffith | dhellmann: that's perfect | 22:32 |
| jgriffith | dhellmann: yeah, but it turns out there were some other private methods being called in those ones I skipped | 22:32 |
| dhellmann | it's EOD here, so I'll leave it up for review and we'll see if we can get it merged tomorrow | 22:33 |
| dhellmann | jgriffith: oh? | 22:33 |
| jgriffith | dhellmann: but regardless, we'll sort that out and use this fixture. | 22:33 |
| jgriffith | yeah... | 22:33 |
| jgriffith | dhellmann: _message.gettext.translation | 22:34 |
| jgriffith | dhellmann: that's actually the one that caused me to add the skips | 22:34 |
| dhellmann | wow, that's calling the stdlib module translation function directly | 22:34 |
| dhellmann | what on earth? | 22:34 |
| jgriffith | dhellmann: indeed.. but your words are much kinder and appropriate than mine were | 22:35 |
| dhellmann | if it's just testing that the translation is returning the expected value, you can probably remove the test, but if it's trying to do something else we should talk about the details | 22:35 |
| jgriffith | dhellmann: yeah, first glance seemed just testing the translation which led to my 3'rd 'Whiskey Tango Foxtrot' of the afternoon | 22:36 |
| jgriffith | I'll likely just remove them but wanted to get the gate going again | 22:36 |
| jgriffith | will let jungleboyj and Jim (original authors) sort it out | 22:37 |
| dhellmann | jgriffith: sounds good | 22:37 |
| jecarey | dhellmann, jgriffith I was going to work with jungleboyj on fixing it. I just took what was there and made it work. | 22:37 |
| jgriffith | dhellmann: thanks for the help, and the super speedy turn on that fixture | 22:37 |
| dhellmann | jungleboyj and jecarey: we can add more tests to oslo.i18n if you think there's a gap | 22:37 |
| dhellmann | jecarey: yeah, this looked like an evolved situation :-) | 22:38 |
| jgriffith | jecarey: good point... likely legacy, you're just hosed cuz you touched it last :) | 22:38 |
| *** emagana has joined #openstack-cinder | 22:38 | |
| *** Mandell has joined #openstack-cinder | 22:38 | |
| *** thangp has quit IRC | 22:38 | |
| jecarey | jgriffith, that will teach me to help out on cinder ;) | 22:40 |
| jgriffith | jecarey: no please! | 22:42 |
| jgriffith | jecarey: I'll work on it if you like | 22:42 |
| jgriffith | don't go!!!! | 22:42 |
| jgriffith | :) | 22:42 |
| jecarey | jgriffith, lol :) | 22:42 |
| jecarey | jgriffith, I'm happy to work on it. Looking at your patch, I wonder if you should just turn lazy off and skip anything that fails. | 22:44 |
| jecarey | You're turning it on and since it is global anything run after that would run with it on. | 22:44 |
| jungleboyj | I am back. | 22:49 |
| *** kaufer has quit IRC | 22:50 | |
| jgriffith | jecarey: yeah, that's what *most* of them do anyway I think | 22:51 |
| jgriffith | jecarey: just the test_faults one is diff | 22:51 |
| jgriffith | and wsgi | 22:51 |
| jgriffith | wsgi needs to do some testing with it on me thinks | 22:51 |
| jecarey | Ijgriffith I wonder if we should just change it to use the new innards of oslo_i18n and then when the fixture is available fix this right. | 22:55 |
| *** lcurtis has joined #openstack-cinder | 22:56 | |
| *** ryanpetrello has quit IRC | 22:56 | |
| jecarey | jgriffith, ^^ + that way we won't run into problems because we change the global and didn't change it back. | 22:56 |
| *** Masahiro has joined #openstack-cinder | 23:04 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Implement clone_image caching on SolidFire https://review.openstack.org/142859 | 23:05 |
| *** KurtMartin has joined #openstack-cinder | 23:07 | |
| *** annashen has joined #openstack-cinder | 23:07 | |
| *** KurtMartin has quit IRC | 23:09 | |
| *** Masahiro has quit IRC | 23:09 | |
| *** kmartin has quit IRC | 23:10 | |
| *** ebalduf has joined #openstack-cinder | 23:12 | |
| *** alexpilotti has quit IRC | 23:12 | |
| *** annashen has quit IRC | 23:14 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Fix order of assertEqual in test_solidfire https://review.openstack.org/145373 | 23:14 |
| jgriffith | jecarey: you mean make the same mistake again? | 23:15 |
| *** annashen has joined #openstack-cinder | 23:15 | |
| jgriffith | jecarey: so absolutely don't want to see use of private members again if that's what you mean | 23:15 |
| jecarey | jgriffith, I meant only to get the gate going again. We have to fix it. | 23:16 |
| jecarey | jgriffith, I'm just concerned because the global isn't getting restored. Might be better to just skip anything that requires lazy on for now. | 23:18 |
| jecarey | an remove messing with the global at all. | 23:18 |
| *** emagana has quit IRC | 23:20 | |
| *** hypnosb has quit IRC | 23:20 | |
| *** julim has quit IRC | 23:20 | |
| *** marcusvrn has quit IRC | 23:20 | |
| *** changbl has quit IRC | 23:20 | |
| *** kaisers1 has quit IRC | 23:20 | |
| *** markstur has quit IRC | 23:20 | |
| *** saltsa has quit IRC | 23:21 | |
| *** git-harry has quit IRC | 23:21 | |
| *** frakt_ has quit IRC | 23:21 | |
| *** wolsen has quit IRC | 23:21 | |
| *** dosaboy has quit IRC | 23:21 | |
| *** leseb has quit IRC | 23:21 | |
| *** mkoderer has quit IRC | 23:21 | |
| *** patrickeast has quit IRC | 23:21 | |
| *** afazekas has quit IRC | 23:21 | |
| *** mtanino has quit IRC | 23:21 | |
| *** sgotliv has quit IRC | 23:21 | |
| *** med_ has quit IRC | 23:21 | |
| *** bnemec has quit IRC | 23:21 | |
| *** vukcrni has quit IRC | 23:21 | |
| *** gpocentek has quit IRC | 23:21 | |
| *** SergeyLukjanov has quit IRC | 23:21 | |
| *** flip214 has quit IRC | 23:21 | |
| *** ekarlso- has quit IRC | 23:21 | |
| *** cburgess_ has quit IRC | 23:21 | |
| *** winston-d has quit IRC | 23:21 | |
| *** Anticimex has quit IRC | 23:21 | |
| *** netapp has quit IRC | 23:21 | |
| *** git-harry has joined #openstack-cinder | 23:21 | |
| *** markstur has joined #openstack-cinder | 23:21 | |
| jgriffith | jecarey: looking, may not even need that there; might be cruft from when I was messing with other things | 23:21 |
| *** kaisers has joined #openstack-cinder | 23:21 | |
| jgriffith | stand by | 23:21 |
| *** julim has joined #openstack-cinder | 23:21 | |
| *** changbl has joined #openstack-cinder | 23:21 | |
| *** emagana has joined #openstack-cinder | 23:21 | |
| *** wolsen has joined #openstack-cinder | 23:21 | |
| *** frakt has joined #openstack-cinder | 23:21 | |
| *** marcusvrn has joined #openstack-cinder | 23:22 | |
| *** mkoderer has joined #openstack-cinder | 23:22 | |
| *** mriedem has quit IRC | 23:22 | |
| *** patrickeast has joined #openstack-cinder | 23:22 | |
| *** afazekas has joined #openstack-cinder | 23:22 | |
| *** mtanino has joined #openstack-cinder | 23:22 | |
| *** sgotliv has joined #openstack-cinder | 23:22 | |
| *** med_ has joined #openstack-cinder | 23:22 | |
| *** bnemec has joined #openstack-cinder | 23:22 | |
| *** vukcrni has joined #openstack-cinder | 23:22 | |
| *** gpocentek has joined #openstack-cinder | 23:22 | |
| *** SergeyLukjanov has joined #openstack-cinder | 23:22 | |
| *** flip214 has joined #openstack-cinder | 23:22 | |
| *** ekarlso- has joined #openstack-cinder | 23:22 | |
| *** cburgess_ has joined #openstack-cinder | 23:22 | |
| *** winston-d has joined #openstack-cinder | 23:22 | |
| *** Anticimex has joined #openstack-cinder | 23:22 | |
| *** netapp has joined #openstack-cinder | 23:22 | |
| *** leseb has joined #openstack-cinder | 23:24 | |
| *** boris-42 has quit IRC | 23:24 | |
| *** vukcrni has quit IRC | 23:24 | |
| *** lpetrut has quit IRC | 23:25 | |
| *** vukcrni has joined #openstack-cinder | 23:25 | |
| *** boris-42 has joined #openstack-cinder | 23:26 | |
| *** dosaboy has joined #openstack-cinder | 23:26 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Remove import of private _lazy module https://review.openstack.org/145359 | 23:28 |
| jungleboyj | I am not sure about the patch you pushed up. I am trying something else real quick. | 23:28 |
| openstackgerrit | Anthony Lee proposed openstack/cinder: Add driver filter and evaluator for scheduler https://review.openstack.org/129987 | 23:28 |
| jgriffith | jungleboyj: I'm really over the bike-shedding on this at this point TBH | 23:29 |
| *** akerr has quit IRC | 23:29 | |
| jgriffith | jungleboyj: you guys want to dig in and offer something better have at it | 23:29 |
| jgriffith | jungleboyj: and updating to call the private methods in the libs is NOT acceptable | 23:29 |
| jgriffith | those tests aren't all that useful IMO anyway | 23:30 |
| jgriffith | if the i18n translation layers are broken and not being tested we have bigger problems | 23:30 |
| *** saltsa has joined #openstack-cinder | 23:31 | |
| *** jecarey has quit IRC | 23:33 | |
| jungleboyj | jgriffith: Give me a minute. If I can't make progress in a few minutes, then lets push a patch that disables the failing tests. Then we can get the gate unblocked and I will work on fixing the test cases. | 23:33 |
| jungleboyj | No, wasn't going to go down that route. | 23:34 |
| jgriffith | jungleboyj: umm... that's what i just did isn't it? | 23:34 |
| jgriffith | jungleboyj: whatever... do your thing | 23:34 |
| * jgriffith out | 23:34 | |
| jgriffith | somebody can always do it better :) | 23:35 |
| jungleboyj | jgriffith: In the second patch? | 23:35 |
| jgriffith | jungleboyj: yes..... ? | 23:35 |
| jungleboyj | Ok, yes. I will merge that one if I don't figure something out here shortly. | 23:35 |
| jgriffith | jungleboyj: what are you "trying to figure out"? | 23:36 |
| jgriffith | jungleboyj: you can't import something that doesn't exist | 23:36 |
| *** annashen has quit IRC | 23:36 | |
| jgriffith | jungleboyj: what is there to figure out exactly? | 23:36 |
| jgriffith | jungleboyj: I'm just curious... and you've now pulled me back in :) | 23:36 |
| jungleboyj | jgriffith: Well, I am thinking that the test cases should work if we just enable lazy in setup and disable. | 23:36 |
| jgriffith | jungleboyj: you would think that, but you would likely be wrong :) | 23:37 |
| jungleboyj | All the other stuff in there was trying to save the state. | 23:37 |
| jungleboyj | jgriffith: Did you try that? | 23:37 |
| jgriffith | jungleboyj: yes I did | 23:37 |
| * jungleboyj sighs. | 23:37 | |
| jgriffith | jungleboyj: but you should go for it | 23:38 |
| jgriffith | maybe you'll do something different than I did | 23:38 |
| jgriffith | jungleboyj: the only file that's really changed is test_faults | 23:38 |
| jgriffith | jungleboyj: everything else is just modified to use the "correct" method instead of going direct into the library guts | 23:38 |
| jgriffith | jungleboyj: I'm really not sure why this is a big deal? | 23:39 |
| thingee | jungleboyj: what are you trying to do? | 23:39 |
| jungleboyj | jgriffith: Ok. That is good. I will merge what you have then. | 23:39 |
| jungleboyj | thingee: Trying to understand a way to get the test cases to work again, but maybe that isn't necessary. | 23:40 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Remove unused variables from ensure_export() https://review.openstack.org/145381 | 23:40 |
| jgriffith | jungleboyj: honestly I'm suspicious that these tests are like MANY other tests that actually don't really test *anything* except some clever hackiness that's been written in a test | 23:42 |
| jgriffith | just sayin :) | 23:42 |
| thingee | jgriffith: +1 | 23:42 |
| thingee | jungleboyj: this is why I was asking for these to be reevaluated before actually trying to fix them | 23:43 |
| jgriffith | harlowja_away: I would if I could :) | 23:43 |
| *** barra204 has quit IRC | 23:43 | |
| jungleboyj | jgriffith: thingee Ok. Lets merge John's patch and I will work with Jim to understand what the test cases do and send a follow up patch accordingly. Either removing the test cases or fixing. | 23:44 |
| jungleboyj | jgriffith: thingee Sound like a plan? | 23:44 |
| thingee | jungleboyj: that's what I thought the plan was originally. I would like the gate unblocked. :) | 23:44 |
| jungleboyj | thingee: Why? | 23:45 |
| jungleboyj | ;-) | 23:45 |
| *** kumartin has joined #openstack-cinder | 23:52 | |
| *** kumartin is now known as kmartin | 23:52 | |
| *** ho has joined #openstack-cinder | 23:53 | |
| *** hypnosb has joined #openstack-cinder | 23:55 | |
| *** ryanpetrello has joined #openstack-cinder | 23:57 | |
| *** dkingshott has quit IRC | 23:58 | |
| hemna | the patch is still puking in dsvm-tempest-full :( | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!