Tuesday, 2015-01-06

*** xmltok has left #openstack-cinder00:00
*** bswartz has joined #openstack-cinder00:05
*** scottda_ has quit IRC00:06
*** fischerw has quit IRC00:07
*** fischerw has joined #openstack-cinder00:07
thingeejamielennox: thank you00:08
jamielennoxthingee: any time - let me know what i can do to help00:08
*** tbarron has quit IRC00:09
*** scottda_ has joined #openstack-cinder00:09
*** hemna has joined #openstack-cinder00:11
*** fischerw has quit IRC00:14
*** ryanpetrello has quit IRC00:15
*** scottda_ has quit IRC00:17
*** mudassirlatif has quit IRC00:19
*** jwang has joined #openstack-cinder00:23
*** scottda_ has joined #openstack-cinder00:26
*** hemna has quit IRC00:27
*** tsekiyam_ has joined #openstack-cinder00:28
*** hemna has joined #openstack-cinder00:30
thingeejamielennox: thank you00:30
thingeejamielennox: whoops00:30
*** tsekiyama has quit IRC00:31
*** Masahiro has joined #openstack-cinder00:33
*** crose has joined #openstack-cinder00:34
*** scottda_ has quit IRC00:34
*** crose has quit IRC00:34
*** hemna has quit IRC00:34
*** david-ly_ has joined #openstack-cinder00:36
*** Masahiro has quit IRC00:38
*** annashen has quit IRC00:38
*** btran has quit IRC00:39
*** david-ly_ has quit IRC00:41
*** hemna has joined #openstack-cinder00:42
*** hemna_ has joined #openstack-cinder00:47
*** hemna has quit IRC00:48
*** ryanpetrello has joined #openstack-cinder00:49
*** ebalduf has quit IRC00:54
*** jungleboyj has joined #openstack-cinder00:55
*** Masahiro has joined #openstack-cinder00:56
*** dannywilson has quit IRC00:57
*** scottda_ has joined #openstack-cinder01:00
*** scottda_ has quit IRC01:04
*** _cjones_ has quit IRC01:05
*** hemna_ has quit IRC01:06
*** hemna_ has joined #openstack-cinder01:07
openstackgerritAnthony Lee proposed openstack/cinder: Add driver filter and evaluator for scheduler  https://review.openstack.org/12998701:18
*** rlucio has quit IRC01:24
*** hemna_ has quit IRC01:24
*** hemna_ has joined #openstack-cinder01:25
*** patrickeast has quit IRC01:27
*** tsekiyam_ has quit IRC01:33
*** nellysmitt has joined #openstack-cinder01:37
*** mtanino has quit IRC01:38
*** kfox1111 has quit IRC01:39
*** nellysmitt has quit IRC01:42
*** kaufer has joined #openstack-cinder01:42
*** leeantho has quit IRC01:44
*** kaufer has quit IRC01:50
*** nosnos has joined #openstack-cinder01:50
*** hemna_ has quit IRC01:54
*** hemna_ has joined #openstack-cinder01:55
*** fandi has quit IRC01:55
*** mriedem1 has joined #openstack-cinder01:56
*** mriedem has quit IRC01:57
*** elazro has quit IRC02:03
*** rwsu has quit IRC02:03
*** elazro has joined #openstack-cinder02:03
*** hemna_ has quit IRC02:06
*** scottda_ has joined #openstack-cinder02:06
*** hemna_ has joined #openstack-cinder02:07
*** thingee has quit IRC02:10
*** ryanpetrello has quit IRC02:14
*** haomaiwa_ has joined #openstack-cinder02:15
*** Mandell has joined #openstack-cinder02:16
openstackgerritAccela Zhao proposed openstack/cinder: Capitalize the first letter in log message.  https://review.openstack.org/14511102:25
*** scottda_ has quit IRC02:27
*** JoeGTN1 has quit IRC02:32
*** annashen has joined #openstack-cinder02:33
openstackgerritAccela Zhao proposed openstack/cinder: Correct import order  https://review.openstack.org/14511202:36
openstackgerritAccela Zhao proposed openstack/cinder: Correct import order  https://review.openstack.org/14511202:38
*** thelo has joined #openstack-cinder02:41
*** thelo has quit IRC02:41
*** thelo has joined #openstack-cinder02:42
openstackgerritLi Min Liu proposed openstack/cinder: Add secondary sshpool for san storage drivers  https://review.openstack.org/14511302:43
*** kaisers1 has joined #openstack-cinder02:44
*** mberlin1 has joined #openstack-cinder02:45
*** kaisers has quit IRC02:45
*** mberlin has quit IRC02:46
*** Mandell has quit IRC02:54
*** takedakn has joined #openstack-cinder02:55
*** Mandell has joined #openstack-cinder02:58
*** scottda_ has joined #openstack-cinder03:00
openstackgerritAccela Zhao proposed openstack/cinder: Fix argument order in assertEqual  https://review.openstack.org/14511803:03
*** scottda_ has quit IRC03:06
*** scottda_ has joined #openstack-cinder03:10
*** scottda_ has quit IRC03:14
*** hemna_ has quit IRC03:15
*** nosnos has quit IRC03:34
*** bkopilov has quit IRC03:37
*** nellysmitt has joined #openstack-cinder03:38
*** ryanpetrello has joined #openstack-cinder03:38
*** takedakn has quit IRC03:39
*** nellysmitt has quit IRC03:42
*** david-lyle has joined #openstack-cinder03:48
*** ebalduf has joined #openstack-cinder03:52
*** ryanpetrello has quit IRC03:55
*** Longgeek has joined #openstack-cinder03:56
*** Longgeek has quit IRC03:57
*** dannywilson has joined #openstack-cinder03:58
*** dannywilson has quit IRC04:02
*** Longgeek has joined #openstack-cinder04:03
*** mriedem1 has quit IRC04:04
*** ho__ has joined #openstack-cinder04:06
*** ho has quit IRC04:09
*** abhijeetm has joined #openstack-cinder04:23
*** annashen has quit IRC04:24
*** david-lyle is now known as david-lyle_afk04:25
*** Mandell has quit IRC04:28
*** nosnos has joined #openstack-cinder04:29
*** Mandell has joined #openstack-cinder04:29
*** avishay has joined #openstack-cinder04:29
*** mogami has joined #openstack-cinder04:38
*** mudassirlatif has joined #openstack-cinder04:42
*** annashen has joined #openstack-cinder04:51
*** anshul has joined #openstack-cinder05:04
*** e0ne has joined #openstack-cinder05:09
*** bkopilov has joined #openstack-cinder05:11
*** e0ne has quit IRC05:11
*** ebalduf has quit IRC05:11
*** BharatK has joined #openstack-cinder05:14
*** k4n0 has joined #openstack-cinder05:24
*** k4n0 has quit IRC05:25
*** annashen has quit IRC05:28
*** pradipta_away is now known as pradipta05:29
*** mogami has quit IRC05:29
*** deepakcs has joined #openstack-cinder05:33
openstackgerritAccela Zhao proposed openstack/cinder: Fix the continuation line indent  https://review.openstack.org/14513105:38
*** nellysmitt has joined #openstack-cinder05:38
*** annashen has joined #openstack-cinder05:40
openstackgerritAccela Zhao proposed openstack/cinder: Fix the continuation line indent  https://review.openstack.org/14513105:40
openstackgerritxing-yang proposed openstack/cinder: Support over subscription in thin provisioning  https://review.openstack.org/14217105:41
*** nellysmitt has quit IRC05:43
*** annashen has quit IRC05:45
*** PaulCuzner has joined #openstack-cinder05:46
*** nshaikh has joined #openstack-cinder05:47
openstackgerritBharat Kumar Kobagana proposed openstack/cinder: Fix argument order in assertEqual: tests/test_glusterfs.py  https://review.openstack.org/14513305:49
*** Longgeek has quit IRC05:51
*** sandywalsh has quit IRC05:55
*** Mandell has quit IRC05:55
*** Mandell has joined #openstack-cinder05:55
*** sandywalsh has joined #openstack-cinder05:57
*** Mandell has quit IRC05:57
*** Mandell has joined #openstack-cinder05:58
*** annashen has joined #openstack-cinder06:01
*** deepakcs has quit IRC06:03
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex  https://review.openstack.org/14493306:06
*** Longgeek has joined #openstack-cinder06:09
*** ho__ has quit IRC06:14
*** mudassirlatif has quit IRC06:21
*** Mandell has quit IRC06:26
*** mudassirlatif has joined #openstack-cinder06:26
*** mudassirlatif has quit IRC06:32
openstackgerritAbhijeet Malawade proposed openstack/cinder: Get volume from db again before updating it's status  https://review.openstack.org/14514306:43
*** annashen has quit IRC06:46
*** nlevinki has joined #openstack-cinder06:49
*** ho has joined #openstack-cinder06:52
*** Mandell has joined #openstack-cinder06:55
*** anshul has quit IRC07:02
*** e0ne has joined #openstack-cinder07:02
*** jamielennox is now known as jamielennox|away07:03
openstackgerritAccela Zhao proposed openstack/cinder: Fix assertEqual argument order in tests/ root dir  https://review.openstack.org/14511807:03
*** lpetrut has joined #openstack-cinder07:11
openstackgerritAbhijeet Malawade proposed openstack/cinder: Get volume from db again before updating it's status  https://review.openstack.org/14440907:12
openstackgerritAccela Zhao proposed openstack/cinder: Correct import order  https://review.openstack.org/14511207:12
openstackgerritAccela Zhao proposed openstack/cinder: Correct import order in qos_specs_manage.py  https://review.openstack.org/14511207:13
*** e0ne has quit IRC07:18
*** EduardBiceriMate has joined #openstack-cinder07:21
openstackgerritAccela Zhao proposed openstack/cinder: Capitalize the first letter in log message.  https://review.openstack.org/14511107:22
*** deepakcs has joined #openstack-cinder07:24
openstackgerritAccela Zhao proposed openstack/cinder: Capitalize the first letter in log messages.  https://review.openstack.org/14511107:26
openstackgerritAccela Zhao proposed openstack/cinder: Fix the continuation line indent to pass flake8  https://review.openstack.org/14513107:27
*** mudassirlatif has joined #openstack-cinder07:27
*** tshefi has joined #openstack-cinder07:32
*** nellysmitt has joined #openstack-cinder07:39
*** mudassirlatif has quit IRC07:40
*** BharatK_ has joined #openstack-cinder07:41
*** BharatK has quit IRC07:43
*** nellysmitt has quit IRC07:43
*** anshul has joined #openstack-cinder07:45
*** chlong has quit IRC07:49
*** chlong has joined #openstack-cinder07:49
openstackgerritAmitKumarDas proposed openstack/cinder: Adds cinder iscsi driver for CloudByte storage  https://review.openstack.org/10251107:50
*** chlong has quit IRC07:51
*** chlong has joined #openstack-cinder07:53
*** teju has joined #openstack-cinder07:58
*** fandi has joined #openstack-cinder08:08
*** afazekas has joined #openstack-cinder08:14
openstackgerritBharat Kumar Kobagana proposed openstack/cinder: Fix argument order in assertEqual: tests/test_image_utils.py  https://review.openstack.org/14516208:21
*** cnesa has joined #openstack-cinder08:30
*** nellysmitt has joined #openstack-cinder08:33
openstackgerritBharat Kumar Kobagana proposed openstack/cinder: Fix argument order in assertEqual: tests/test_nfs.py  https://review.openstack.org/14516608:39
*** alecv has joined #openstack-cinder08:48
*** EduardBiceriMate has quit IRC08:51
*** lpetrut has quit IRC08:55
openstackgerritBharat Kumar Kobagana proposed openstack/cinder: Fix argument order in assertEqual: tests/test_rbd.py  https://review.openstack.org/14517308:56
*** deepakcs has quit IRC08:58
*** jistr has joined #openstack-cinder08:58
*** jpich has joined #openstack-cinder08:59
*** nshaikh has quit IRC09:01
*** mogami has joined #openstack-cinder09:06
*** jordanP has joined #openstack-cinder09:06
*** nshaikh has joined #openstack-cinder09:06
*** nellysmitt has quit IRC09:08
*** lpetrut has joined #openstack-cinder09:10
*** mogami has quit IRC09:11
*** nellysmitt has joined #openstack-cinder09:12
*** lpetrut has quit IRC09:25
*** Masahiro has quit IRC09:27
*** Masahiro has joined #openstack-cinder09:27
*** Masahiro has quit IRC09:31
*** TobiasE has joined #openstack-cinder09:31
*** Masahiro has joined #openstack-cinder09:37
*** abehl has joined #openstack-cinder09:39
*** Masahiro has quit IRC09:39
*** anshul has quit IRC09:39
*** Mandell has quit IRC09:45
*** cnesa has quit IRC09:48
*** annashen has joined #openstack-cinder09:49
*** Masahiro has joined #openstack-cinder09:50
*** Masahiro has quit IRC09:53
*** Masahiro has joined #openstack-cinder09:57
*** mkoderer_cloud has joined #openstack-cinder10:00
*** Masahiro has quit IRC10:00
*** lpetrut has joined #openstack-cinder10:00
*** alexpilotti has joined #openstack-cinder10:02
*** alonmarx_ has joined #openstack-cinder10:08
*** annashen has quit IRC10:08
*** abehl has quit IRC10:08
*** Masahiro has joined #openstack-cinder10:09
*** alonmarx has quit IRC10:11
*** Masahiro has quit IRC10:14
*** Raj_ has joined #openstack-cinder10:14
*** cnesa1 has joined #openstack-cinder10:15
*** pradipta is now known as pradipta_away10:15
Raj_Hi any one knw10:16
Raj_Failed to run task cinder.scheduler.flows.create_volume.ScheduleCreateVolumeTask;volume:create: No valid host was found. No weighed hosts available10:16
Raj_No valid host was found. No weighed hosts available error out volume10:16
Raj_error while creating volume with10:16
Raj_capabilities:replication in key10:16
Raj_pls any one help10:16
*** timcl has quit IRC10:19
*** cnesa1 has left #openstack-cinder10:19
*** cnesa1 has joined #openstack-cinder10:19
*** cnesa1 has left #openstack-cinder10:20
*** cnesa1 has joined #openstack-cinder10:20
*** cnesa1 has quit IRC10:21
*** cnesa1 has joined #openstack-cinder10:21
*** abehl has joined #openstack-cinder10:22
avishayRaj_: you have no backend available that reports the replication capability10:22
Raj_Changed the code in my driver10:23
Raj_avishay: stats = {'driver_version': VERSION,              'free_capacity_gb': 0,              'reserved_percentage': 0,              'storage_protocol': 'iSCSI',              'total_capacity_gb': 0,              'vendor_name': 'Symantec',              'volume_backend_name': 'SYMC_VxVM',              'replication_support': True}10:24
Raj_avishay : i added it in def _update_volume_stats(self)10:24
Raj_need to add anywhere else ..?10:25
avishayRaj_: https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/ibm/storwize_svc/replication.py#L18410:25
avishaydata['replication'] = True10:25
*** e0ne has joined #openstack-cinder10:25
Raj_avishay : need to change from data['replication_support']=True to data['replication']=True10:26
Raj_avishay but in https://review.openstack.org/#/c/98308/6/specs/juno/volume-replication.rst doc they given to do10:26
Raj_replication support10:26
avishayRaj_: again, there is a difference between a design document and the actual implementation10:27
avishayRaj_: If you code with a design document as a guide, you're gonna have a bad time10:28
Raj_avishay: thanks alot10:29
Raj_avishay : so need to see code only ...10:29
Raj_avishay: u wann say so no any proper guide is there10:30
avishayRaj_: correct10:31
Raj_avishay: can u just tell me10:34
Raj_avishay: the methods that i need to implement10:35
Raj_ie promote replica10:35
Raj_reneeable replica10:35
*** nikesh_vedams has quit IRC10:39
avishayRaj_: https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L73710:39
avishayRaj_: reenable_replication, get_replication_status, promote_replica10:39
Raj_avishay: only three ... if u consider the basic driver ...10:40
Raj_avishay: then this methods will call create_replica delete_replica etc ..??? or this thing is  own driver dependent ..??10:42
Raj_avishay: one more it is must to provide the 2nd storage info .... ie  enable_backends= strg1, strg2 etc ...???10:44
Raj_in cinder.conf file ..?10:44
*** Longgeek has quit IRC10:51
*** Longgeek has joined #openstack-cinder10:51
avishayRaj_: driver dependent10:51
avishayRaj_: I already told you, communication with the second storage should be in the conf file, yes10:52
*** Masahiro has joined #openstack-cinder10:54
Raj_you have any ...?? example for that10:54
avishayRaj_: there was the IBM patch, but they did it wrong10:54
avishayRaj_: if your driver inherits from san.py and uses those config options, add to san.py10:55
Raj_no my driver is not using san.py file10:56
Raj_avishay: is there is any other way for that ..10:56
*** Masahiro has quit IRC10:58
*** Masahiro has joined #openstack-cinder11:00
*** e0ne is now known as e0ne_11:09
*** BharatK_ has quit IRC11:12
*** haomaiwa_ has quit IRC11:14
*** e0ne_ has quit IRC11:20
*** e0ne has joined #openstack-cinder11:30
*** marcusvrn1 has joined #openstack-cinder11:30
*** marcusvrn has quit IRC11:31
*** TobiasE has quit IRC11:31
*** nshaikh has quit IRC11:33
*** nshaikh has joined #openstack-cinder11:38
*** TobiasE has joined #openstack-cinder11:46
*** ho has quit IRC11:48
*** Masahiro has quit IRC11:48
*** nellysmitt has quit IRC11:50
*** jaypipes has joined #openstack-cinder11:51
*** avishay has quit IRC11:52
*** fandi has quit IRC11:56
*** michiel-k has joined #openstack-cinder11:58
michiel-kI've got an issue with uploading a boot-from-volume volume to Glance, where Glance says the uploaded image is 0 bytes, but the data is actually there (checksum is different).12:00
michiel-kDetails: https://ask.openstack.org/en/question/57477/cinder-copy-to-image-does-not-set-glance-image-size/12:00
*** pradipta_away is now known as pradipta12:03
*** nellysmitt has joined #openstack-cinder12:16
*** timcl has joined #openstack-cinder12:29
DuncanTThe checksum being different suggests maybe the upload failed in some way?12:31
DuncanTmichiel-k: Does downloading the image to a new volume actually work?12:32
DuncanTmichiel-k: Also have you tried on devstack with swift rather than ceph? It might be that swift as a glance backend auto-populates that field but not ceph? (I'm guessing here)12:33
*** marcusvrn1 has quit IRC12:42
erlon_eharney: aroud?12:42
*** marcusvrn has joined #openstack-cinder12:43
*** ryanpetrello has joined #openstack-cinder12:46
*** Masahiro has joined #openstack-cinder12:49
michiel-kUpload succeeds, because uploading a volume which has not been attached/modified results in the expected checksum. Also creating a new empty 1GB volume results in the md5 checksum for 1gb of zero data12:53
michiel-kDownloading the image to a new volume (boot from volume for example) does work12:53
*** Masahiro has quit IRC12:54
michiel-kDuncanT: i haven't tested it on devstack yet, but i have been browsing the source code of Cinder, and have found no evidence of setting size either in the abstract VolumeDriver class (cinder/volume/driver.py) or in the driver implementation of lvm or rbd, or anywhere before that (API layer for example). I will see if i can test it on Devstack today12:59
*** teju has left #openstack-cinder12:59
*** marcusvrn has quit IRC13:00
DuncanTOk, it might well be nobody has noticed that the size in glance is wrong, then. If so, good spot; can you raise a bug against tempest to implement a check for it, once the fi is in, please?13:00
*** marcusvrn has joined #openstack-cinder13:01
michiel-kI'm currently installing devstack and will report back here. Haven't reported a bug yet, or implemented a tempest check before, but when i get to that step, i will consult here to report/implement it :)13:02
*** IanGovett has joined #openstack-cinder13:05
DuncanTWelcome to the mad house :-)13:05
e0nehi DuncanT: could you please help me? where i can find some info about state machine implementation? blueprints, specs, review requests, etc13:07
*** takedakn has joined #openstack-cinder13:08
*** fandi has joined #openstack-cinder13:11
*** pradipta is now known as pradipta_away13:16
*** e0ne is now known as e0ne_13:25
openstackgerritYusuke Hayashi proposed openstack/cinder: Move 3 Fujitsu ETERNUS DX related file  https://review.openstack.org/14413113:27
DuncanTe0ne_: https://review.openstack.org/#/c/110434/ is a starting point13:32
DuncanTe0ne_: I don't actually have a current set of links, I've been focusing (and failing at) rpc version clamping recently, and ignoring the state machine a bit since other people seemed to be trying to progress it13:33
DuncanTThat review links to two blueprints13:34
DuncanTAnd two dependant patches13:34
*** bswartz has quit IRC13:34
*** e0ne_ has quit IRC13:35
*** crose has joined #openstack-cinder13:38
*** marcusvrn has quit IRC13:40
*** mwichmann has joined #openstack-cinder13:45
*** Mandell has joined #openstack-cinder13:46
*** lpabon has joined #openstack-cinder13:47
*** Mandell has quit IRC13:50
openstackgerritEduard Biceri-Matei proposed openstack/cinder: New Cinder volume driver for openvstorage  https://review.openstack.org/13073313:51
*** EduardBiceriMate has joined #openstack-cinder13:54
*** e0ne has joined #openstack-cinder13:58
*** scottda_ has joined #openstack-cinder13:58
*** Raj_ has left #openstack-cinder13:58
*** Raj_ has quit IRC13:59
*** patrickeast has joined #openstack-cinder13:59
e0neDuncanT: thanks! i'm looking on issues with '-ing state' and try to find all evailable related info13:59
*** scottda_ has quit IRC13:59
*** Masahiro has joined #openstack-cinder14:00
*** scottda_ has joined #openstack-cinder14:01
*** abhijeetm has quit IRC14:01
*** scottda_ has quit IRC14:01
*** Longgeek has quit IRC14:04
*** nosnos has quit IRC14:04
*** Longgeek has joined #openstack-cinder14:05
*** kaufer has joined #openstack-cinder14:05
*** Masahiro has quit IRC14:05
*** Longgeek has quit IRC14:06
*** Longgeek has joined #openstack-cinder14:07
*** Longgeek has quit IRC14:09
*** Longgeek_ has joined #openstack-cinder14:09
*** Longgeek_ has quit IRC14:11
*** dustins has joined #openstack-cinder14:11
*** bswartz has joined #openstack-cinder14:11
*** Longgeek has joined #openstack-cinder14:12
*** Longgeek has quit IRC14:13
*** Longgeek has joined #openstack-cinder14:14
*** vmtyler has joined #openstack-cinder14:15
*** vmtyler has quit IRC14:17
*** vmtyler has joined #openstack-cinder14:17
*** BharatK has joined #openstack-cinder14:17
*** cnesa1 has quit IRC14:18
*** michiel-k has quit IRC14:20
*** cnesa1 has joined #openstack-cinder14:21
*** kragniz has quit IRC14:22
*** kragniz has joined #openstack-cinder14:22
*** patrickeast has quit IRC14:25
*** Yogi1 has joined #openstack-cinder14:26
openstackgerritYusuke Hayashi proposed openstack/cinder: Move 3 Fujitsu ETERNUS DX related file  https://review.openstack.org/14413114:27
*** mriedem has joined #openstack-cinder14:28
*** cnesa1 has quit IRC14:28
*** michiel-k has joined #openstack-cinder14:33
openstackgerritYusuke Hayashi proposed openstack/cinder: Move 3 Fujitsu ETERNUS DX related file  https://review.openstack.org/14413114:34
*** Longgeek has quit IRC14:36
*** jungleboyj has quit IRC14:37
openstackgerritSteven Kaufer proposed openstack/cinder: GET volumes API sorting REST/volume/DB updates  https://review.openstack.org/14191514:39
openstackgerritSteven Kaufer proposed openstack/cinder: GET volumes API sorting enhancements common utilities  https://review.openstack.org/14191414:39
*** Mandell has joined #openstack-cinder14:46
*** cnesa has joined #openstack-cinder14:49
*** thangp has joined #openstack-cinder14:52
*** nellysmitt has quit IRC14:54
*** crose has quit IRC14:55
*** jistr has quit IRC14:56
*** Longgeek has joined #openstack-cinder14:56
*** jistr has joined #openstack-cinder14:57
*** hypnosb has quit IRC14:59
*** hypnosb has joined #openstack-cinder14:59
*** krtaylor has quit IRC15:03
*** takedakn1 has joined #openstack-cinder15:06
*** BharatK has quit IRC15:06
*** EduardBiceriMate has quit IRC15:07
*** takedakn has quit IRC15:08
*** jcru has joined #openstack-cinder15:10
*** nshaikh has quit IRC15:10
*** scottda_ has joined #openstack-cinder15:11
*** krtaylor has joined #openstack-cinder15:11
*** avishay has joined #openstack-cinder15:12
*** scottda_ has quit IRC15:13
*** changbl has quit IRC15:14
*** mtanino has joined #openstack-cinder15:15
*** annashen has joined #openstack-cinder15:16
*** fischerw has joined #openstack-cinder15:18
*** marcusvrn has joined #openstack-cinder15:19
*** annashen has quit IRC15:20
*** Mandell has quit IRC15:20
*** nlevinki has quit IRC15:26
*** Mandell has joined #openstack-cinder15:26
*** bkopilov has quit IRC15:33
*** takedakn1 has quit IRC15:40
*** nlevinki has joined #openstack-cinder15:41
*** abehl has quit IRC15:41
*** esker has joined #openstack-cinder15:42
*** jungleboyj has joined #openstack-cinder15:45
*** marcusvrn1 has joined #openstack-cinder15:46
*** marcusvrn has quit IRC15:46
*** bkopilov has joined #openstack-cinder15:48
*** rwsu has joined #openstack-cinder15:48
*** alecv has quit IRC15:48
*** Masahiro has joined #openstack-cinder15:49
*** barra204_ has joined #openstack-cinder15:52
*** barra204_ is now known as shakamunyi15:53
*** Masahiro has quit IRC15:54
*** EduardBiceriMate has joined #openstack-cinder15:54
*** Mandell has quit IRC15:56
*** e0ne is now known as e0ne_15:57
*** TobiasE1 has joined #openstack-cinder15:57
*** hemnafk is now known as hemna15:57
*** TobiasE has quit IRC15:57
*** bswartz has quit IRC15:59
*** Yogi11 has joined #openstack-cinder15:59
*** Yogi1 has quit IRC16:02
*** dustins_ has joined #openstack-cinder16:02
*** dustins has quit IRC16:03
*** timcl has quit IRC16:03
*** timcl1 has joined #openstack-cinder16:03
*** BharatK has joined #openstack-cinder16:06
*** e0ne_ is now known as e0ne16:06
*** TobiasE has joined #openstack-cinder16:08
*** TobiasE1 has quit IRC16:09
*** dustins_ has quit IRC16:10
*** dustins has joined #openstack-cinder16:11
*** bswartz has joined #openstack-cinder16:12
*** tsekiyama has joined #openstack-cinder16:13
*** mikedillion has joined #openstack-cinder16:13
*** mikedillion has quit IRC16:14
*** jistr has quit IRC16:15
*** jistr has joined #openstack-cinder16:16
*** jistr has quit IRC16:17
*** jistr has joined #openstack-cinder16:17
*** dannywilson has joined #openstack-cinder16:17
*** dannywilson has quit IRC16:19
*** dannywilson has joined #openstack-cinder16:19
*** mkoderer_cloud has quit IRC16:23
*** Miouge has joined #openstack-cinder16:27
*** xyang has joined #openstack-cinder16:28
*** TobiasE has quit IRC16:29
*** jdurgin1 has joined #openstack-cinder16:30
*** e0ne is now known as e0ne_16:31
*** bkopilov has quit IRC16:34
*** nlevinki has quit IRC16:35
*** tshefi has quit IRC16:36
*** e0ne_ has quit IRC16:41
*** cnesa has quit IRC16:43
*** IanGovett has quit IRC16:43
openstackgerritj_king proposed openstack/cinder: Update eqlx_cli_max_retries help text  https://review.openstack.org/14465616:49
*** nellysmitt has joined #openstack-cinder16:50
*** _cjones_ has joined #openstack-cinder16:50
*** IanGovett has joined #openstack-cinder16:51
*** avishay has quit IRC17:02
*** bswartz has quit IRC17:02
*** jpich has quit IRC17:04
*** dustins has quit IRC17:05
*** timcl1 has quit IRC17:05
openstackgerritWalter A. Boring IV (hemna) proposed openstack/python-cinderclient: WIP Add volume multi attach support  https://review.openstack.org/8585617:06
jungleboyjhemna: We were just talking about that this morning.  :-)17:06
hemnauh oh.17:06
*** e0ne has joined #openstack-cinder17:07
hemnawhat did I do?17:07
*** dustins has joined #openstack-cinder17:07
*** timcl has joined #openstack-cinder17:07
jungleboyjhemna: Internal teams want to take the code and start trying it.  Any reason they can't try to use it?17:07
hemnajungleboyj, there isn't any support in nova for it yet :(17:07
hemnajungleboyj, let me find the nova patch17:07
*** Yogi11 has quit IRC17:08
hemnajungleboyj, but, the multi-attach patch should still work either way.  meaning that it doesn't break cinder :P17:08
jgriffithe0ne: ping17:09
hemnajungleboyj, https://review.openstack.org/#/c/143114/17:09
e0nejgriffith: hi17:09
jgriffithe0ne: howdy!17:09
jgriffithe0ne: re https://review.openstack.org/#/c/144739/2/cinder/api/v2/volumes.py17:09
e0nejgriffith: yep, i've seen DuncanT's comment. i'll need to try to use one db query and remove nested loop17:10
hemnae0ne, what are you working on wrt the states ?17:10
jgriffithe0ne: I wouldn't block on it17:10
e0nejgriffith, hemna: excuse me, i must go home right now. will you be able here in 2 hours?17:11
jgriffithe0ne: and honestly not exactly sure what DuncanT might have in mind17:11
DuncanTe0ne: You can keep the loop maybe, just flatten what is returning into a simple list rather than a query first?17:11
hemnae0ne, yah17:11
jgriffithe0ne: NP, or we can catch up tomorrow morning (I'll be around earlier) :)17:11
jgriffithDuncanT: +117:11
DuncanTe0ne: They are pretty damn unlikely to get big enough to use enough memory to be overly scary17:12
hemnaanyone looking into adding '-ing' checks in the API to prevent actions, so we can remove the volume manager local locks ?17:12
e0nejgriffith: i'll be here tonight. my working day starts at noon and ends late sometimes:)17:12
*** mikedillion has joined #openstack-cinder17:13
jgriffithhemna: sorry, I'm afraid I didn't really follow that17:13
e0nei've got some ideas for my patch. i'll add it today17:13
jgriffithhacking checks in the API to prevent actions?17:13
jgriffithor you "mean" '-ing' as in doing something checks17:13
hemnajgriffith, so we talked about adding some checks in the API to stop actions at the API level if a volume is in an 'ing' state.  so we could remove the volume manager local file locks17:13
e0nehemna: i and team would like to start looking on '-ing' statuses issues17:13
hemnajgriffith, yah basically17:14
jgriffithhaha!  Yes, ok that's much better :)17:14
* jgriffith was like WTF?17:14
* e0ne be back in ~2 hours17:14
hemnait's something I'm interested in for K17:14
jgriffithhemna: so I'm not sure how that plays now with the object stuff and all that's going on17:14
jgriffithhemna: should be complimentary17:14
jgriffithbut don't know17:14
hemnayah I dunno either17:14
hemnais the object stuff being worked on ?17:15
jgriffithhemna: honestly I was hoping we would start with that approach before going full blown objects and conductor17:15
hemnaI'd like to do something for K to remove the volume manager locks17:15
hemnajgriffith, agreed17:15
jgriffithhemna: I think it would "solve" a number of races pretty easily17:15
jgriffithbut oh well17:15
jgriffithlet's try harder first :)17:15
*** nikesh_vedams has joined #openstack-cinder17:15
hemnais someone working on the object stuff ?17:16
jgriffithhemna: thangp is working on it pretty hard17:16
jungleboyjhemna: I was afraid of that ... no Nova changes yet.  Any chance of those progressing in Kilo?17:16
hemnaah ok17:16
thangphemma: i have most of the code up for review17:16
hemnajungleboyj, the nova patch looks pretty sad currently IMHO17:16
jgriffiththangp: it looks pretty good by the way (IMHO)17:16
thangphemna: just working on unit tests right now, should have it for next week17:16
hemnajungleboyj, I just pinged Tobias on his status.  I'd like to see it get finished ASAP.17:16
*** e0ne has quit IRC17:17
thangpjgriffith: thx17:17
jgriffiththangp: I haven't loaded it up and hammered on it, but the code came out cleaner than I had expected17:17
hemnathangp, url ?17:17
*** e0ne has joined #openstack-cinder17:17
thangphemna: https://review.openstack.org/#/c/131873/ and https://review.openstack.org/#/c/133566/17:17
jungleboyjhemna: Ok.  Would be nice if we didn't have to wait another release on that.17:17
*** e0ne has quit IRC17:17
hemnajungleboyj, yes.  I want this one off my back finally.17:17
*** Yogi11 has joined #openstack-cinder17:18
hemnajungleboyj, it might get to the point of us deciding to allow the cinder side changes in w/o nova or not.17:18
hemnajust so we can move on.17:18
jungleboyjhemna: +117:18
hemnajgriffith, when you have time, I'd like your feedback on one of the issues you raised in my multi-attach patch17:18
*** rushil has quit IRC17:19
*** Longgeek has quit IRC17:19
*** jistr has quit IRC17:22
*** marcusvrn1 has quit IRC17:23
*** Longgeek has joined #openstack-cinder17:25
*** jdurgin1 has quit IRC17:27
*** mikedillion has quit IRC17:29
jgriffithhemna: sure17:30
*** thingee has joined #openstack-cinder17:30
thingeeDuncanT: ping17:32
jgriffithhemna: which comments :)17:34
hemnawhat to do when the attachment id isn't passed in at detach time.17:35
hemnayou mentioned allowing and defaulting to detach every volume.17:35
jgriffithhemna: yeah, you don't like my idea?17:35
hemnaI guess I just hadn't thought of that.17:35
jgriffithhemna: so I was just thinking that I liked that behavior in the case of...17:36
hemnabasically what I have in place now is that the code will check to see if the volume is attached more than once.17:36
jgriffith"I'm done with this POS volume, I want to delete it"17:36
hemnaand if the attachment id isn't passed it throws an exception.17:36
jgriffithI just say "detach"... and "delete"17:36
hemnawhich basically protects the other attachments.17:36
*** Yogi11 has quit IRC17:36
hemnayah I get that17:36
hemnaI just want to make sure I do the right thing.17:36
jgriffithhemna: yeah, so I see your check and that's totally cool17:36
hemnaI was just trying to be conservative about it.17:37
jgriffithhemna: I'm just trying to think about the "default" case which I still think should be single attach17:37
hemnaI do see the value in a mass detach though17:37
jgriffithmaking the second part an "optional"17:37
DuncanTthingee: Hi17:37
jgriffithhemna: so that's part of it, the other part was just the "normal" behavior and call17:37
hemnaso I think this check only happens if the volume is shareable17:37
hemnaif it's not shareable, then it won't have more than 1 attachment17:38
hemnaand it should still work as today.17:38
DuncanTthingee: Cooking, so lagged replies, but I'm about17:38
*** Masahiro has joined #openstack-cinder17:38
hemnathe question is, what to do about the shareable volumes that have more than 1 attachment.17:38
jgriffithhemna: yeah, but you MUST pass in the attachment_id though right17:38
jgriffiththat's the part I was thinking of ditching17:38
hemnathe API defaults to None now.17:38
jgriffithlemme look at update :)17:39
*** cl__ has quit IRC17:39
hemnaI guess I could make it more explicit and add a default in the function definitions for the rpcapi as well17:41
*** jungleboyj has quit IRC17:42
hemnaI have that in the volume manager's detach_volume fwiw17:42
jgriffithhemna: sorry... distracted, somebody's at my desk; gimmie a minute17:42
hemnaalso https://review.openstack.org/#/c/85856/5/cinderclient/v2/volumes.py17:42
hemnaI added a None default for the cinderclient as well. fwiw.17:43
*** Masahiro has quit IRC17:43
nikesh_vedamshi i have a doubt,in cinder support matrix,what host assisted means in cinder volume migration?17:43
hemnajgriffith, no worries.  I'm on a conf call as well.17:43
hemnanikesh_vedams, when a driver can do the migration itself.17:43
hemnanikesh_vedams, basically the backend array/storage can do the migration instead of cinder doing it the hard way.17:44
*** changbl has joined #openstack-cinder17:45
*** thangp has quit IRC17:46
*** thangp has joined #openstack-cinder17:46
nikesh_vedamshemna:i checked hp3par code and i understood that it is doing migration under different cpg under same domain and same array so if domain and array is differnt then17:47
nikesh_vedamshow volume migration will take place17:48
hemnanikesh_vedams, yup.  if the volume is going to land on the same host, then the driver gets an chance to do the migration itself.17:49
hemnanikesh_vedams, the cpg, domain tests are just an artifact of the 3PAR itself.17:49
*** cl__ has joined #openstack-cinder17:51
*** leeantho has joined #openstack-cinder17:54
*** marcusvrn has joined #openstack-cinder17:55
*** Longgeek has quit IRC17:56
*** Longgeek has joined #openstack-cinder17:57
nikesh_vedamshemna: thanks,one more thing i have wrote cinder driver for dothill array which is similar to HPMSA array,when i am running "/driver_certs/cinder_driver_cert.sh",all tests are passed,only 2-3 test cases are failing17:57
*** cl__ has quit IRC17:57
nikesh_vedamsand those tests cases are running good individually17:58
nikesh_vedamsbut overall this script is saying driver faield17:58
nikesh_vedamscreated all in one node with tempest environment as suggested by jgriffith earlier17:59
*** jordanP has quit IRC18:00
*** rushil has joined #openstack-cinder18:00
*** jamielennox|away is now known as jamielennox18:01
*** afazekas has quit IRC18:01
openstackgerritj_king proposed openstack/cinder: Update eqlx_cli_max_retries help text  https://review.openstack.org/14465618:01
thingeeDuncanT: I sent you an email earlier about the rpc clamp spec. Are we going to be seeing an update on that soon?18:04
jgriffithnikesh_vedams: results/logs for those failing tests?18:05
jgriffithnikesh_vedams: we can't possibly guess :)18:06
*** _cjones_ has quit IRC18:06
thingeejamielennox: hey so I was looking at adding the hack in the session request method. I don't have a project id to prepend.18:07
thingeejamielennox: should I just add project id to the interface and delete the kwarg before calling session super __init__()18:07
*** e0ne has joined #openstack-cinder18:08
*** tbarron has joined #openstack-cinder18:08
jamielennoxthingee: so i have a review that makes it available: https://review.openstack.org/#/c/118520/18:09
thingeejamielennox: oh sorry, you did mention that yesterday18:09
jamielennoxhowever for the mean time you'll probably need to fetch it yourself18:09
thingeemy bad18:09
thingeejamielennox: got it thanks18:10
jamielennoxis how keystoneclient does it, but looking at it now that assumes self.session.auth where it should be (self.auth or self.session.auth)18:10
nikesh_vedamsok i will provide,one more doubt is that cinder driver can do migration by taking help of array/backend or creating another volume and copy the contents in it.is both way will called host assisted volume migration18:11
*** mudassirlatif has joined #openstack-cinder18:12
jamielennoxthingee: i also don't think you'll need the second case that keystoneclient implements, so just:18:12
jamielennoxauth = self.auth or self.session.auth18:12
jamielennoxif hasattr(auth, 'get_access'):18:12
jamielennox    user_id = auth.get_access(self.session).user_id18:12
*** patrickeast has joined #openstack-cinder18:13
*** _cjones_ has joined #openstack-cinder18:15
hemnaImportError: cannot import name _lazy18:16
thingeejamielennox: looks like tenant_id is an empty string18:16
hemnafrom oslo.i18n import _lazy18:16
hemnapuking in jenkins18:16
jamielennoxthingee: tenant_id coming from where?18:17
hemnaoslo is so much fun18:17
*** annashen has joined #openstack-cinder18:18
jamielennoxthingee: that would be the result of what you provided the plugin when you created it, not the auth that it received18:18
*** afazekas has joined #openstack-cinder18:18
jamielennoxthe get_access(session) will return the current authorization if valid or fetch a new one18:18
thingeejamielennox: ah ha got it working18:19
thingeemy mistake18:19
*** setmason has joined #openstack-cinder18:19
setmasonHas the mid-cycle meetup date/location been planned?18:19
hemnaoslo.i18n moved all of their code into oslo_i18n18:20
hemnabreaking everything18:20
*** thingee has quit IRC18:21
hemnawhere is our oslo rep ? :P18:21
*** e0ne has quit IRC18:21
smcginnissetmason: Here's info: https://etherpad.openstack.org/p/cinder-kilo-midcycle-meetup18:21
DuncanTthingee: Yes. I've some prototype code that helps clear up what needs doing, and I'll try to push a spec update before the meeting tomorrow18:22
*** BharatK has quit IRC18:22
DuncanThema: Ok, so I suggest we tell the oslo team we're keeping our own forks of all their stuff unless they stop pulling this crap18:23
*** thingee has joined #openstack-cinder18:23
*** patrickeast has quit IRC18:23
DuncanT8:22 PM <DuncanT> thingee: Yes. I've some prototype code that helps clear up what needs doing, and I'll try to push a spec update before the meeting tomorrow18:23
*** patrickeast_ has joined #openstack-cinder18:23
*** patrickeast_ is now known as patrickeast18:23
nikesh_vedamsheman: if cinder driver creates another volume and copy contents in it,means doing volume migration in hard way then is it called host assisted volume migration?18:23
*** asselin has quit IRC18:23
nikesh_vedamshemna: if cinder driver creates another volume and copy contents in it,means doing volume migration in hard way then is it called host assisted volume migration?18:24
thingeesetmason: not sure if anyone answered your question since I dropped but midcycle meetup info is here https://etherpad.openstack.org/p/cinder-kilo-midcycle-meetup18:24
thingeeDuncanT: ok thanks18:24
*** bkopilov has joined #openstack-cinder18:25
*** bswartz has joined #openstack-cinder18:25
*** Longgeek_ has joined #openstack-cinder18:27
*** asselin has joined #openstack-cinder18:28
*** Yogi1 has joined #openstack-cinder18:29
*** Longgeek has quit IRC18:30
*** jistr has joined #openstack-cinder18:30
*** setmason has left #openstack-cinder18:30
*** jistr has quit IRC18:31
*** nellysmitt has quit IRC18:31
*** jistr has joined #openstack-cinder18:32
nikesh_vedamsjgriffith: sent you mail having tempest log18:32
*** bswartz has quit IRC18:35
thingeejamielennox: what would be the case auth doesn't have get_access?18:39
jamielennoxso the majority of plugins are IdenttiyPlugins - as in they talk to keystone18:39
*** jungleboyj has joined #openstack-cinder18:40
jamielennoxthingee: there is the provision that they don't have to be - you can use whatever you like as a plugin18:40
jgriffithnikesh_vedams:  Details: (VolumesActionsV1Test:test_volume_force_delete_when_volume_is_attaching) Failed to delete volume c1d8f0f1-6555-4007-91ae-c01afac02014 within the required time (196 s).18:40
jamielennoxthingee: and the one that is most likely is token/endpoint, as in use this existing token with this known endpoint - if you do that then there's really nothing i can do about getting the project_id18:40
jgriffithnikesh_vedams: any chance your driver has locks in int?18:41
*** nellysmitt has joined #openstack-cinder18:42
jgriffithnikesh_vedams: so you actually have one test that fails and takes everything down with it18:43
jgriffithnikesh_vedams: do you have the c-vol logs?18:45
kvidvansAnyone I can talk to regarding the mid-cycle meetup... Oracle may have another person joining, but it looks like the limit of 20 persons has been reached: https://etherpad.openstack.org/p/cinder-kilo-midcycle-meetup18:45
*** nellysmitt has quit IRC18:46
*** Mandell has joined #openstack-cinder18:47
thingeekvidvans: talk to jungleboyj18:47
nikesh_vedamsjgrffith:no i donot have now,but individually these these test cases are passing18:48
kvidvansthingee: thanks18:48
nikesh_vedamsjgriffith:can i increase this 196 s18:49
*** xyang has quit IRC18:50
nikesh_vedamsjgriffith: i am using lock concepts from HPMSA code18:51
*** timcl has quit IRC18:53
*** timcl has joined #openstack-cinder18:54
*** Longgeek_ has quit IRC19:01
thingeejungleboyj: ping19:02
*** Longgeek has joined #openstack-cinder19:04
*** julim has joined #openstack-cinder19:05
*** shakamunyi has quit IRC19:07
jgriffithnikesh_vedams: looks like maybe one of the parallel jobs is locking the driver so you can't perform the delete19:10
jgriffithnikesh_vedams: and thus the timeout19:10
*** dkingshott has joined #openstack-cinder19:10
thingeejungleboyj, jgriffith: http://paste.openstack.org/show/155785/19:11
jgriffithnikesh_vedams: that's why they pass individually19:11
jgriffiththingee: w00t19:11
thingeeall thanks to jamielennox for being patient with me19:11
*** Miouge has quit IRC19:12
jamielennoxthingee: i've been going through heat recently, you'll need to fix something there as it relies upon testing if either volume or voluemv2 is in the catalog for version19:13
thingeejamielennox: yeah and tripleo and nova19:14
jamielennoxok, just thought i'd mention19:15
thingeejamielennox: no thanks for mentioning it. It's not going to be an easy change19:15
*** Miouge has joined #openstack-cinder19:16
jamielennoxwhilst i have attention can we just pass https://review.openstack.org/#/c/131163/ already - it's a fairly obvious fix19:16
thingeejamielennox: ah yes, I just came across that myself, thanks19:16
jamielennoxmaybe it doesn't matter if we are going to fix nova to not retrieve that value from the URL any more19:18
*** e0ne has joined #openstack-cinder19:18
*** e0ne is now known as e0ne_19:19
nikesh_vedamsjgriffith:so this is failing my driver :(19:20
jgriffithnikesh_vedams: as well it should19:20
nikesh_vedamsjgriffith:how can i increase this 196s19:22
nikesh_vedamsand  do you know some one who know HPMSA cinder volume driver testing19:23
nikesh_vedamsmay be he also faced this type of issues19:24
*** ryanpetrello_ has joined #openstack-cinder19:25
*** Masahiro has joined #openstack-cinder19:27
*** ryanpetrello has quit IRC19:27
*** ryanpetrello_ is now known as ryanpetrello19:27
*** bswartz has joined #openstack-cinder19:28
*** e0ne_ has quit IRC19:28
jgriffithnikesh_vedams: are you just copying their work or developing your own?19:29
*** Masahiro has quit IRC19:31
*** xyang has joined #openstack-cinder19:32
thingeejamielennox: is there common code in keystone client for / GET version discovery?19:33
nikesh_vedamsjgriffith:after copying the work, i am adding features whats not provided by it19:34
nikesh_vedamsbecause my array is similar to that19:34
*** e0ne has joined #openstack-cinder19:34
jamielennoxthingee: you can use keystoneclient.discover.Discover19:35
jamielennoxthat gives you the basics19:35
jamielennoxhowever if you already have auth then you can just do19:36
jamielennoxauth.get_endpoint(session, service_type='volume', interface='public', version=(2, 0))19:36
jamielennoxit will return a string if it finds one otherwise None19:36
e0nei'm back19:37
*** david-lyle_afk is now known as david-lyle19:39
e0nejgriffith, hemna: i'm ready to discuss my patch and '-ing status'19:40
* e0ne looking to today's irc logs19:41
*** lpetrut has quit IRC19:44
*** hypnosb has quit IRC19:47
*** hypnosb has joined #openstack-cinder19:48
*** shakamunyi has joined #openstack-cinder19:52
e0nehemna: btw, is any update with brick and agent?19:54
*** barra204_ has joined #openstack-cinder19:55
*** shakamunyi has quit IRC19:58
hemnae0ne, lunch....bbiab20:01
e0nehemna: bon appetit!20:02
* jungleboyj is eating as well and thinking about tiramisu :-)20:03
e0neagain... tiramisu...20:04
*** leeantho has quit IRC20:04
*** sseverson has quit IRC20:04
smcginnisjungleboyj: Always bringing up the good desserts. :)20:04
jungleboyje0ne: That was for you.20:05
*** asselin has quit IRC20:05
*** KurtMartin has quit IRC20:05
*** fischerw has quit IRC20:05
jungleboyjsmcginnis: Of course.20:05
*** sseverson has joined #openstack-cinder20:05
*** leeantho has joined #openstack-cinder20:05
*** asselin has joined #openstack-cinder20:05
*** KurtMartin has joined #openstack-cinder20:05
*** fischerw has joined #openstack-cinder20:05
e0nejungleboyj: :)20:05
jungleboyjI am going to have to settle for Christmas Cookies at the moment though.20:06
thingeejungleboyj: did you see my link earlier20:06
thingeejungleboyj: no more volume and volumev2 service types20:07
jungleboyjNo, I didn't see that earlier.20:08
*** sseverson has quit IRC20:08
*** KurtMartin has quit IRC20:08
*** fischerw has quit IRC20:08
openstackgerritTomoki Sekiyama proposed openstack/cinder: Failover to alternative iSCSI portals on login failure  https://review.openstack.org/14087720:08
*** leeantho has quit IRC20:08
*** asselin has quit IRC20:08
jungleboyjthingee: Where was that?20:08
openstackgerritTomoki Sekiyama proposed openstack/cinder: Enhance iSCSI multipath support  https://review.openstack.org/13468120:08
*** KurtMartin has joined #openstack-cinder20:08
*** sseverson has joined #openstack-cinder20:08
thingeejungleboyj: http://paste.openstack.org/show/155785/20:08
*** leeantho has joined #openstack-cinder20:08
jungleboyjthingee: How does that work?20:09
*** lpetrut has joined #openstack-cinder20:12
thingeejungleboyj: uses keystoneclient's discovery with the specified version from the client20:16
jungleboyjthingee:  Nice.  So, is that an option that is set up with keystone then?20:17
*** jistr has quit IRC20:25
*** _cjones_ has quit IRC20:25
*** Mandell has quit IRC20:26
*** tellesnobrega has quit IRC20:28
ameade_looks like oslo.i18n 1.2.0 is gonna break gate, just a heads up20:36
ameade_cinder unittests barf with "    from oslo.i18n import _lazy20:37
ameade_ImportError: cannot import name _lazy"20:37
ameade_dhellmann: ^^20:37
ameade_thingee: ^^20:37
dhellmannameade_: hmm. I wonder why cinder's tests are importing a private module from oslo.i18n?20:38
dhellmannit's possible those tests could be rewritten using the fixture that provides explicit access to lazy and immediate translation - http://docs.openstack.org/developer/oslo.i18n/api.html#module-oslo_i18n.fixture20:40
thingeejungleboyj: ^20:41
*** tellesnobrega has joined #openstack-cinder20:41
*** akerr has joined #openstack-cinder20:42
*** _cjones_ has joined #openstack-cinder20:42
*** nellysmitt has joined #openstack-cinder20:43
smcginnishemna: ^20:43
smcginnishemna: Weren't you having fun with that earlier?20:43
*** pcaruana is now known as pcaruana|afk|20:45
jgriffithdhellmann: thingee test.py20:45
thingeetest.py fixes all20:45
*** mudassirlatif has quit IRC20:45
dhellmannthe enable_lazy() function is also exposed as oslo.i18n.enable_lazy()20:46
dhellmannbut the flag being kept in that module is not part of its public API, so it is not exposed20:46
jgriffithdhellmann: cool20:47
jgriffiththingee: dhellmann think I've got it fixed20:47
jgriffiththingee: dhellmann lemme get a bug logged and I'll push it20:47
jgriffith(after tests finish)20:47
dhellmannif you really need to turn it on and off globally in a test, a new fixture could be created to do that, too, but that's not thread safe so I'm not sure it's a good idea to be doing20:47
*** vmtyler has quit IRC20:47
dhellmannjgriffith: cool20:47
*** Mandell has joined #openstack-cinder20:47
jgriffithdhellmann: I just removed it from the test completely20:47
jgriffithdhellmann: seems like bad juju to have it there anyway20:48
*** nellysmitt has quit IRC20:48
dhellmanndoes that mean you're not testing the wsgi stack with translatable exceptions? or that you're *always* testing with translatable exceptions?20:48
jgriffithdhellmann: it is, but it's doing it in its own setup (IIRC)20:49
jgriffithdhellmann: should probably make sure :)20:49
jgriffithdhellmann: thingee ummmm... WTF?20:55
*** jcru has quit IRC20:55
jgriffithdhellmann: I think we have a problem here....20:56
*** mudassirlatif has joined #openstack-cinder20:56
jgriffithahhh... wait, I see20:56
*** mudassirlatif has quit IRC20:56
jgriffithanybody know why we do a cinder.i18n.py file?20:57
jgriffithok, now I'm catching up LOL20:57
jgriffithdhellmann: how about disable?20:58
jgriffithor is that default on init I suppose21:00
* jgriffith is talking to himself21:00
jgriffithor talking out loud virtually21:00
*** timcl has quit IRC21:00
*** esker has quit IRC21:01
dhellmannjgriffith: lazy translation is disabled by default21:01
dhellmannan enable_lazy() takes a boolean so it can be turned off explicitly, too21:01
jgriffithdhellmann: yeah, but our stupid wrapper doesn't :(21:02
jgriffithdhellmann: see if what I have now works, else I'll change that up21:02
jgriffithdhellmann: not sure why it failed this last go around, but I'm looking21:02
hemnajgriffith, oslo.i18n moved all of their files into a different dir21:02
dhellmannjgriffith: it might be simplest to add a fixture to oslo.i18n21:02
hemnaI saw it earlier today when some of my patches started puking21:02
*** IanGovett has quit IRC21:03
dhellmannhemna: we provided backwards compatibility shims for all of the public APIs. You guys are messing around with private parts of the library still.21:03
hemnathanks for the notice!21:03
dhellmannhemna: You may want to start following the -dev mailing list. We've been talking about this work there quite a bit.21:03
jgriffithhemna: thanks for fixing it up... oh wait :)21:03
hemnaI think we are all on the dev mailing list, but since it's so full of lots of discussions, it's easy to miss stuff21:04
hemnait would have been nice to be notified in here.21:04
hemnaoh well.21:04
jgriffithhemna: :)21:04
*** _cjones_ has quit IRC21:05
jgriffithhemna: but the point is we shouldn't be trying to pull in those priv modules anyway21:06
thingeejgriffith: +121:06
hemnayah I don't disagree with that21:06
thingeealso we do have some designated to filter throught he noise and let us know when there are changes we should be concerned about21:06
hemnaI'm not sure who did that and for what reason.   maybe it's cruft from a long while ago21:06
hemnaI'm just saying it sucks to find out about it with failing patches in jenkins is all.21:07
thingeejungleboyj: :)21:07
dhellmannI'll remind our liaisons to make sure they communicate our plans with their "home" teams. That's part of why we have designated points of contact.21:07
hemnadhellmann, +121:07
thingeedhellmann: +121:07
hemnadhellmann, thanks man.  I think that will help.  At least then, you can say....see we told you! :P21:08
jgriffithwe have too many unit tests :)21:10
hemnarm -rf cinder/tests21:10
jgriffithWe should delete them all and start over :)21:10
jgriffithhemna: :)21:10
jgriffithOr I need more cores to run them faster21:10
openstackgerritCorey Bryant proposed openstack/cinder: Handle ISCSIConnector.get_initiator() OSError  https://review.openstack.org/14534221:10
jgriffithdown to 221:11
jgriffithDOH!!  wsgi tests LOL21:11
jungleboyjI have a feeling I have missed something here.  Scrolling through the history.21:11
hemnaso it looks like it's isolated to cinder/test.py ?21:11
e0nejgriffith: it won't help you. our tests can't be run in parallel now:(21:11
jgriffithhemna: no, already did that21:12
jgriffithhemna:         back_use_lazy = _lazy.USE_LAZY21:12
hemnajgriffith, oh you have a patch up already ?21:12
*** asselin has joined #openstack-cinder21:12
jgriffithe0ne: you're such a downer!21:12
jgriffithhemna: yes21:12
*** tsekiyama has quit IRC21:12
hemnajgriffith, ok cool.   thanks.  I was going to look into it.21:12
*** tsekiyama has joined #openstack-cinder21:15
jgriffithdhellmann: is there a handy get method?21:15
*** Masahiro has joined #openstack-cinder21:16
*** westmaas has joined #openstack-cinder21:16
* jgriffith could just go look :)21:16
dhellmannjgriffith: get method?21:16
*** westmaas has left #openstack-cinder21:16
jgriffithso there's some places where someobdy did "_lazy.USE_LAZY"21:17
jgriffithand put it in their setup/teardown for checks21:17
jgriffithor, cleanup21:17
jgriffithI should say21:17
jgriffithmore proper would probably be to set it explicitly for each test21:17
dhellmannyeah, that's the part I was suggesting might warrant a new fixture to toggle it on and restore it. The use of that flag is an implementation detail. At some point we're going to just turn on lazy translation and leave it on all the time.21:18
jgriffithdhellmann: yeah, all coming together now21:18
*** _cjones_ has joined #openstack-cinder21:18
*** Longgeek has quit IRC21:18
*** Miouge has quit IRC21:19
*** Masahiro has quit IRC21:20
*** scottda_ has joined #openstack-cinder21:20
*** _cjones_ has quit IRC21:25
*** scottda_ has quit IRC21:27
*** russellb has joined #openstack-cinder21:27
*** scottda_ has joined #openstack-cinder21:27
jungleboyjhemna: Finally caught up on the discussion.  I apologize.  I think it is my bad for not explicitly mentioning some of the changes coming from Oslo.21:28
jungleboyjI have been working on getting things merged bug haven't really discussed what is going on.21:28
jungleboyjhemna: Next will be changes for the change in name space.  I can put some discussion on the calendar in tomorrow's meeting to cover that to make sure everyone knows what is going on.21:29
hemnaok that'd be cool21:29
*** xyang has quit IRC21:29
hemnawas there simply no mechanism in oslo.i18n that required us to put those calls to _lazy.* in the first place ?21:30
*** _cjones_ has joined #openstack-cinder21:31
*** lpabon has quit IRC21:32
jungleboyjSo, the whole enable_lazy stuff is the work I did a release or two ago.  You don't have t explicitly enable it in each module because it is enabled at the top level in the bin/cinder-* files.21:33
jgriffithjungleboyj: well... that's not the problem :(21:33
jungleboyjIn unit test, however, it does need to be explicitly set if you are testing translation is disabled by default.21:34
jgriffithjungleboyj: the problem is it was imported like "import _lazy"21:34
jgriffiththen used directly, "_lazy.enable()"21:34
jgriffithand most of the unit tests that did this and had it didn't need it21:34
jgriffithjungleboyj: the wsgi test however I haven't quite figured out what it breaks, but it's hosed without it21:35
jgriffithjungleboyj: mostly a result of the BACK_LAZY ting that was going on I suspect21:35
*** _cjones_ has quit IRC21:35
jgriffithjungleboyj: ahhh  :)21:36
jgriffithanother no no21:36
jgriffithok fixed, I think21:36
jungleboyjOh, I haven't seen the use of _lazy ... Would need to go look at that.  The wsgi test does weird stuff with enable_lazy21:36
jgriffithjungleboyj: hemna k, gimmie a few while it runs thorugh all tests one last time21:37
jungleboyjOk.  Happy to look once it is out there.21:38
*** barra204_ has quit IRC21:39
*** barra204_ has joined #openstack-cinder21:40
*** lpabon has joined #openstack-cinder21:41
jungleboyjAh ... Jim.21:42
* hemna points finger21:42
jungleboyjI was going to guess it had something to do with what he was working on.21:43
jungleboyjWhat do you know, he isn't surprised there was an issue with the namespace changes.21:43
jgriffithjungleboyj: I'm thinking that folks might be missing the point still :)21:44
*** scottda_ has quit IRC21:44
jungleboyjjgriffith: ?21:44
hemnajgriffith, +121:44
jgriffithjungleboyj: we really "shouldn't" care if the name space for the internals of the lib change21:44
jgriffithwe shouldn't have been poking around there to begin with :)21:44
jgriffithThat's the whole point of using a lib :)21:44
thingeejgriffith: +121:45
jgriffithjungleboyj: hemna and someobdy did it with _message as well21:45
smcginnisBe _lazy.21:45
jgriffithsmcginnis: true-dat21:45
*** mudassirlatif has joined #openstack-cinder21:46
jungleboyjSome of this is due to the process of moving from incubator to library though, correct?  We are finding issues as we go.21:47
*** PaulCuzner has quit IRC21:47
jgriffithjungleboyj: honestly... why are we even testing translations in cinder anyway?21:47
jgriffithie in tests/api/middleware/test_faults21:48
jungleboyjjgriffith: That is a good question.21:48
jungleboyjOh yuck, I see why this is a problem.21:49
jungleboyjShouldn't be using anything from oslo.i18n anymore.21:50
jgriffithjungleboyj: no, that's not really it either21:50
jgriffithjungleboyj: but you shouldn't be using i18n._*21:50
jgriffiththe *_* being the point21:51
hemnayah just the public apis that i18n supplies is all we should be using21:51
jgriffithprivate means there's no contractual guarantee in the interface21:51
jgriffithit's just that, private/internal... may be gone tomorrow21:51
jgriffithand today is tomorrow :)21:51
*** _cjones_ has joined #openstack-cinder21:52
*** ryanpetrello_ has joined #openstack-cinder21:55
*** ryanpetrello has quit IRC21:56
*** ryanpetrello_ is now known as ryanpetrello21:56
*** IanGovett has joined #openstack-cinder21:56
thingeejgriffith: thanks for looking into this21:57
thingeejgriffith: honestly I would be fine with just ripping out the tests21:58
jungleboyjthingee: +222:00
jungleboyjTo the thanks for looking into this.22:00
jgriffiththingee: I'm adding skips to the last few that I couldn't get figured out22:00
jgriffithrunning unit tests and pep8 again, then pushing it22:00
jungleboyjjgriffith: I will look.  Jim and I can probably get the other test cases fixed once I see you patch.22:01
jgriffithjungleboyj: okie-dokie22:01
*** e0ne has quit IRC22:02
thingeejungleboyj: Reevaluate if we want to keep 'em22:02
jungleboyjthingee: Can do.22:03
jungleboyjback in a bit.  Need to get Logan from Daycare.22:03
*** jecarey has joined #openstack-cinder22:03
*** dustins has quit IRC22:05
*** rushil has quit IRC22:05
*** kmartin has joined #openstack-cinder22:06
jgriffithdam hacking rules!!!22:06
thingeenot dot in the title of a commit message22:06
jgriffiththingee: lmao22:07
jgriffiththingee: you'r killin me 'smalls'22:07
*** KurtMartin has quit IRC22:08
*** bswartz has quit IRC22:09
openstackgerritJohn Griffith proposed openstack/cinder: Remove import of private _lazy module  https://review.openstack.org/14535922:09
*** barra204_ has quit IRC22:12
hemnaonly a partial fix for 1408099 ?22:12
thingeehemna: we're skipping tests22:13
*** barra204 has joined #openstack-cinder22:13
thingeeonce those are fixed, the bug will be completed22:13
hemnaI see, chicken/egg22:13
*** Yogi1 has quit IRC22:13
thingeenot exactly. jgriffith just couldn't figure out why they were still failing. jungleboyj is going to take a look at them and reevaluate if we're going to be testing translations.22:15
thingeehemna: ^22:15
hemnaah ok22:15
*** Mandell has quit IRC22:16
*** tries__ has quit IRC22:18
*** tbarron has quit IRC22:22
*** annashen has quit IRC22:24
dhellmannjgriffith: now that I'm done with meetings, I had time to put together https://review.openstack.org/14536422:31
jgriffithdhellmann: nice!22:32
dhellmannthat may make it easier to unskip those remaining tests22:32
jgriffithdhellmann: that's perfect22:32
jgriffithdhellmann: yeah, but it turns out there were some other private methods being called in those ones I skipped22:32
dhellmannit's EOD here, so I'll leave it up for review and we'll see if we can get it merged tomorrow22:33
dhellmannjgriffith: oh?22:33
jgriffithdhellmann: but regardless, we'll sort that out and use this fixture.22:33
jgriffithdhellmann: _message.gettext.translation22:34
jgriffithdhellmann: that's actually the one that caused me to add the skips22:34
dhellmannwow, that's calling the stdlib module translation function directly22:34
dhellmannwhat on earth?22:34
jgriffithdhellmann: indeed.. but your words are much kinder and appropriate than mine were22:35
dhellmannif it's just testing that the translation is returning the expected value, you can probably remove the test, but if it's trying to do something else we should talk about the details22:35
jgriffithdhellmann: yeah, first glance seemed just testing the translation which led to my 3'rd 'Whiskey Tango Foxtrot' of the afternoon22:36
jgriffithI'll likely just remove them but wanted to get the gate going again22:36
jgriffithwill let jungleboyj and Jim (original authors) sort it out22:37
dhellmannjgriffith: sounds good22:37
jecareydhellmann, jgriffith I was going to work with jungleboyj on fixing it.   I just took what was there and made it work.22:37
jgriffithdhellmann: thanks for the help, and the super speedy turn on that fixture22:37
dhellmannjungleboyj and jecarey: we can add more tests to oslo.i18n if you think there's a gap22:37
dhellmannjecarey: yeah, this looked like an evolved situation :-)22:38
jgriffithjecarey: good point... likely legacy, you're just hosed cuz you touched it last :)22:38
*** emagana has joined #openstack-cinder22:38
*** Mandell has joined #openstack-cinder22:38
*** thangp has quit IRC22:38
jecareyjgriffith, that will teach me to help out on cinder ;)22:40
jgriffithjecarey: no please!22:42
jgriffithjecarey: I'll work on it if you like22:42
jgriffithdon't go!!!!22:42
jecareyjgriffith, lol :)22:42
jecareyjgriffith, I'm happy to work on it.   Looking at your patch, I wonder if you should just turn lazy off and skip anything that fails.22:44
jecareyYou're turning it on and since it is global anything run after that would run with it on.22:44
jungleboyjI am back.22:49
*** kaufer has quit IRC22:50
jgriffithjecarey: yeah, that's what *most* of them do anyway I think22:51
jgriffithjecarey: just the test_faults one is diff22:51
jgriffithand wsgi22:51
jgriffithwsgi needs to do some testing with it on me thinks22:51
jecareyIjgriffith I wonder if we should just change it to use the new innards of oslo_i18n and then when the fixture is available fix this right.22:55
*** lcurtis has joined #openstack-cinder22:56
*** ryanpetrello has quit IRC22:56
jecareyjgriffith, ^^ + that way we won't run into problems because we change the global and didn't change it back.22:56
*** Masahiro has joined #openstack-cinder23:04
openstackgerritJohn Griffith proposed openstack/cinder: Implement clone_image caching on SolidFire  https://review.openstack.org/14285923:05
*** KurtMartin has joined #openstack-cinder23:07
*** annashen has joined #openstack-cinder23:07
*** KurtMartin has quit IRC23:09
*** Masahiro has quit IRC23:09
*** kmartin has quit IRC23:10
*** ebalduf has joined #openstack-cinder23:12
*** alexpilotti has quit IRC23:12
*** annashen has quit IRC23:14
openstackgerritJohn Griffith proposed openstack/cinder: Fix order of assertEqual in test_solidfire  https://review.openstack.org/14537323:14
jgriffithjecarey: you mean make the same mistake again?23:15
*** annashen has joined #openstack-cinder23:15
jgriffithjecarey: so absolutely don't want to see use of private members again if that's what you mean23:15
jecareyjgriffith, I meant only to get the gate going again.  We have to fix it.23:16
jecareyjgriffith, I'm just concerned because the global isn't getting restored.   Might be better to just skip anything that requires lazy on for now.23:18
jecareyan remove messing with the global at all.23:18
*** emagana has quit IRC23:20
*** hypnosb has quit IRC23:20
*** julim has quit IRC23:20
*** marcusvrn has quit IRC23:20
*** changbl has quit IRC23:20
*** kaisers1 has quit IRC23:20
*** markstur has quit IRC23:20
*** saltsa has quit IRC23:21
*** git-harry has quit IRC23:21
*** frakt_ has quit IRC23:21
*** wolsen has quit IRC23:21
*** dosaboy has quit IRC23:21
*** leseb has quit IRC23:21
*** mkoderer has quit IRC23:21
*** patrickeast has quit IRC23:21
*** afazekas has quit IRC23:21
*** mtanino has quit IRC23:21
*** sgotliv has quit IRC23:21
*** med_ has quit IRC23:21
*** bnemec has quit IRC23:21
*** vukcrni has quit IRC23:21
*** gpocentek has quit IRC23:21
*** SergeyLukjanov has quit IRC23:21
*** flip214 has quit IRC23:21
*** ekarlso- has quit IRC23:21
*** cburgess_ has quit IRC23:21
*** winston-d has quit IRC23:21
*** Anticimex has quit IRC23:21
*** netapp has quit IRC23:21
*** git-harry has joined #openstack-cinder23:21
*** markstur has joined #openstack-cinder23:21
jgriffithjecarey: looking, may not even need that there; might be cruft from when I was messing with other things23:21
*** kaisers has joined #openstack-cinder23:21
jgriffithstand by23:21
*** julim has joined #openstack-cinder23:21
*** changbl has joined #openstack-cinder23:21
*** emagana has joined #openstack-cinder23:21
*** wolsen has joined #openstack-cinder23:21
*** frakt has joined #openstack-cinder23:21
*** marcusvrn has joined #openstack-cinder23:22
*** mkoderer has joined #openstack-cinder23:22
*** mriedem has quit IRC23:22
*** patrickeast has joined #openstack-cinder23:22
*** afazekas has joined #openstack-cinder23:22
*** mtanino has joined #openstack-cinder23:22
*** sgotliv has joined #openstack-cinder23:22
*** med_ has joined #openstack-cinder23:22
*** bnemec has joined #openstack-cinder23:22
*** vukcrni has joined #openstack-cinder23:22
*** gpocentek has joined #openstack-cinder23:22
*** SergeyLukjanov has joined #openstack-cinder23:22
*** flip214 has joined #openstack-cinder23:22
*** ekarlso- has joined #openstack-cinder23:22
*** cburgess_ has joined #openstack-cinder23:22
*** winston-d has joined #openstack-cinder23:22
*** Anticimex has joined #openstack-cinder23:22
*** netapp has joined #openstack-cinder23:22
*** leseb has joined #openstack-cinder23:24
*** boris-42 has quit IRC23:24
*** vukcrni has quit IRC23:24
*** lpetrut has quit IRC23:25
*** vukcrni has joined #openstack-cinder23:25
*** boris-42 has joined #openstack-cinder23:26
*** dosaboy has joined #openstack-cinder23:26
openstackgerritJohn Griffith proposed openstack/cinder: Remove import of private _lazy module  https://review.openstack.org/14535923:28
jungleboyjI am not sure about the patch you pushed up.  I am trying something else real quick.23:28
openstackgerritAnthony Lee proposed openstack/cinder: Add driver filter and evaluator for scheduler  https://review.openstack.org/12998723:28
jgriffithjungleboyj: I'm really over the bike-shedding on this at this point TBH23:29
*** akerr has quit IRC23:29
jgriffithjungleboyj: you guys want to dig in and offer something better have at it23:29
jgriffithjungleboyj: and updating to call the private methods in the libs is NOT acceptable23:29
jgriffiththose tests aren't all that useful IMO anyway23:30
jgriffithif the i18n translation layers are broken and not being tested we have bigger problems23:30
*** saltsa has joined #openstack-cinder23:31
*** jecarey has quit IRC23:33
jungleboyjjgriffith: Give me a minute.  If I can't make progress in a few minutes, then lets push a patch that disables the failing tests.  Then we can get the gate unblocked and I will work on fixing the test cases.23:33
jungleboyjNo, wasn't going to go down that route.23:34
jgriffithjungleboyj: umm... that's what i just did isn't it?23:34
jgriffithjungleboyj: whatever... do your thing23:34
* jgriffith out23:34
jgriffithsomebody can always do it better :)23:35
jungleboyjjgriffith: In the second patch?23:35
jgriffithjungleboyj: yes..... ?23:35
jungleboyjOk, yes.  I will merge that one if I don't figure something out here shortly.23:35
jgriffithjungleboyj: what are you "trying to figure out"?23:36
jgriffithjungleboyj: you can't import something that doesn't exist23:36
*** annashen has quit IRC23:36
jgriffithjungleboyj: what is there to figure out exactly?23:36
jgriffithjungleboyj: I'm just curious... and you've now pulled me back in :)23:36
jungleboyjjgriffith: Well, I am thinking that the test cases should work if we just enable lazy in setup and disable.23:36
jgriffithjungleboyj: you would think that, but you would likely be wrong :)23:37
jungleboyjAll the other stuff in there was trying to save the state.23:37
jungleboyjjgriffith: Did you try that?23:37
jgriffithjungleboyj: yes I did23:37
* jungleboyj sighs.23:37
jgriffithjungleboyj: but you should go for it23:38
jgriffithmaybe you'll do something different than I did23:38
jgriffithjungleboyj: the only file that's really changed is test_faults23:38
jgriffithjungleboyj: everything else is just modified to use the "correct" method instead of going direct into the library guts23:38
jgriffithjungleboyj: I'm really not sure why this is a big deal?23:39
thingeejungleboyj: what are you trying to do?23:39
jungleboyjjgriffith: Ok. That is good.  I will merge what you have then.23:39
jungleboyjthingee: Trying to understand a way to get the test cases to work again, but maybe that isn't necessary.23:40
openstackgerritMitsuhiro Tanino proposed openstack/cinder: Remove unused variables from ensure_export()  https://review.openstack.org/14538123:40
jgriffithjungleboyj: honestly I'm suspicious that these tests are like MANY other tests that actually don't really test *anything* except some clever hackiness that's been written in a test23:42
jgriffithjust sayin :)23:42
thingeejgriffith: +123:42
thingeejungleboyj: this is why I was asking for these to be reevaluated before actually trying to fix them23:43
jgriffithharlowja_away: I would if I could :)23:43
*** barra204 has quit IRC23:43
jungleboyjjgriffith: thingee Ok.  Lets merge John's patch and I will work with Jim to understand what the test cases do and send a follow up patch accordingly.  Either removing the test cases or fixing.23:44
jungleboyjjgriffith: thingee Sound like a plan?23:44
thingeejungleboyj: that's what I thought the plan was originally. I would like the gate unblocked. :)23:44
jungleboyjthingee: Why?23:45
*** kumartin has joined #openstack-cinder23:52
*** kumartin is now known as kmartin23:52
*** ho has joined #openstack-cinder23:53
*** hypnosb has joined #openstack-cinder23:55
*** ryanpetrello has joined #openstack-cinder23:57
*** dkingshott has quit IRC23:58
hemnathe patch is still puking in dsvm-tempest-full :(23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!