Monday, 2015-01-12

*** _cjones_ has quit IRC00:06
*** scottda_ has quit IRC00:07
*** scottda_ has joined #openstack-cinder00:09
*** jaypipes has joined #openstack-cinder00:30
*** rushil has quit IRC00:33
*** rushil has joined #openstack-cinder00:34
*** david-lyle has joined #openstack-cinder00:35
*** Masahiro has joined #openstack-cinder00:35
*** Mandell has quit IRC00:37
*** ebalduf has joined #openstack-cinder00:37
*** rushil has quit IRC00:38
*** ryanpetrello has joined #openstack-cinder00:39
*** Yogi1 has joined #openstack-cinder00:39
*** Masahiro has quit IRC00:40
*** ebalduf has quit IRC00:42
*** scottda_ has quit IRC00:48
*** scottda_ has joined #openstack-cinder00:58
*** ryanpetrello has quit IRC00:58
*** ryanpetrello has joined #openstack-cinder01:17
*** scottda_ has quit IRC01:17
*** david-lyle has quit IRC01:18
*** david-lyle has joined #openstack-cinder01:25
*** david-lyle has quit IRC01:27
*** david-lyle has joined #openstack-cinder01:28
*** diegows has joined #openstack-cinder01:32
*** ebalduf has joined #openstack-cinder01:38
*** lpetrut has quit IRC01:40
openstackgerritLi Min Liu proposed openstack/cinder: Add secondary sshpool for san storage drivers
*** ebalduf has quit IRC01:43
*** ryanpetrello has quit IRC01:48
*** Masahiro has joined #openstack-cinder01:51
*** Mandell has joined #openstack-cinder01:53
*** Masahiro has quit IRC01:56
*** david-lyle has quit IRC01:59
*** diegows has quit IRC02:01
openstackgerritVincent Hou proposed openstack/cinder: Remove the useless next link for volumes, transfers and backups
*** ling-yun has joined #openstack-cinder02:19
*** kaufer has joined #openstack-cinder02:19
*** Longgeek has joined #openstack-cinder02:21
*** ling-yun-1 has quit IRC02:22
*** ling-yun-1 has joined #openstack-cinder02:23
*** annashen has joined #openstack-cinder02:24
*** ling-yun has quit IRC02:25
*** mberlin1 has joined #openstack-cinder02:37
*** mberlin has quit IRC02:37
*** kaisers has joined #openstack-cinder02:38
*** kaisers1 has quit IRC02:38
*** ebalduf has joined #openstack-cinder02:39
*** BharatK has joined #openstack-cinder02:40
*** ling-yun has joined #openstack-cinder02:41
*** r-daneel has joined #openstack-cinder02:42
*** ebalduf has quit IRC02:43
*** ling-yun-1 has quit IRC02:45
*** ling-yun-1 has joined #openstack-cinder02:45
*** ling-yun has quit IRC02:49
*** zengyunling__ has joined #openstack-cinder02:50
*** Mandell has quit IRC02:50
*** Mandell has joined #openstack-cinder02:51
*** ling-yun-1 has quit IRC02:53
*** ling-yun has joined #openstack-cinder02:53
*** zengyunling__ has quit IRC02:56
*** ling-yun-1 has joined #openstack-cinder02:56
*** lcurtis has joined #openstack-cinder02:57
*** ling-yun has quit IRC02:59
*** zengyunling__ has joined #openstack-cinder03:03
*** ling-yun-1 has quit IRC03:06
*** lcurtis has quit IRC03:08
openstackgerritLi Min Liu proposed openstack/cinder: Add secondary sshpool for san storage drivers
*** ling-yun-1 has joined #openstack-cinder03:16
*** zengyunling__ has quit IRC03:19
*** r-daneel has quit IRC03:22
*** r-daneel has joined #openstack-cinder03:23
*** julim has quit IRC03:24
*** julim has joined #openstack-cinder03:25
*** julim has quit IRC03:25
*** Yogi11 has joined #openstack-cinder03:31
*** annashen has quit IRC03:33
*** Yogi11 has quit IRC03:34
*** ebalduf has joined #openstack-cinder03:40
*** Masahiro has joined #openstack-cinder03:40
*** zengyunling__ has joined #openstack-cinder03:41
*** annashen has joined #openstack-cinder03:42
*** ling-yun-1 has quit IRC03:43
*** david-lyle has joined #openstack-cinder03:44
*** ebalduf has quit IRC03:45
*** Masahiro has quit IRC03:45
*** annashen has quit IRC03:52
*** haomaiwang has joined #openstack-cinder04:02
*** Longgeek has quit IRC04:14
*** Longgeek has joined #openstack-cinder04:21
*** hemna has joined #openstack-cinder04:23
*** coolsvap|afk is now known as coolsvap04:31
*** ebalduf has joined #openstack-cinder04:41
*** ebalduf has quit IRC04:45
*** david-lyle has quit IRC04:50
*** david-lyle has joined #openstack-cinder04:50
*** lpetrut has joined #openstack-cinder04:50
*** fischerw has quit IRC04:51
*** hemna has quit IRC05:06
*** david-lyle has quit IRC05:06
*** zengyunling__ has quit IRC05:06
*** ling-yun has joined #openstack-cinder05:08
*** ling-yun-1 has joined #openstack-cinder05:09
*** ling-yun has quit IRC05:12
*** avishay has joined #openstack-cinder05:15
*** teju has joined #openstack-cinder05:22
*** Longgeek has quit IRC05:24
*** hemna has joined #openstack-cinder05:28
openstackgerritTaoBai proposed openstack/cinder: IBM Storwize driver Consistency Group Implementation
*** Masahiro has joined #openstack-cinder05:29
*** Longgeek has joined #openstack-cinder05:32
thingeejgriffith: seems to make sense to me, re: your thoughts on the volume to image issue :)05:32
thingeejgriffith: I definitely missed that in everything else I was looking at05:32
*** dulek has joined #openstack-cinder05:33
*** Masahiro has quit IRC05:33
*** lpetrut has quit IRC05:35
*** dulek_ has joined #openstack-cinder05:37
*** dulek has quit IRC05:37
*** RJ_ has joined #openstack-cinder05:37
*** pradipta_away has quit IRC05:39
openstackgerritHuang Zhiteng proposed openstack/cinder: Raise correct exception when validate_connector failed
*** annashen has joined #openstack-cinder05:44
*** zengyunling__ has joined #openstack-cinder05:48
*** ling-yun-1 has quit IRC05:48
*** kaufer has quit IRC05:49
*** dulek_ has quit IRC05:51
*** Mandell has quit IRC05:58
*** rushil has joined #openstack-cinder06:00
*** pradipta has joined #openstack-cinder06:01
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex
*** zengyunling__ has quit IRC06:10
*** ling-yun-1 has joined #openstack-cinder06:12
*** anshul has joined #openstack-cinder06:13
*** nikesh_vedams has joined #openstack-cinder06:13
*** hemna has quit IRC06:15
*** annashen has quit IRC06:16
RJ_hey guys having some doubts ...06:17
RJ_1. it necessry to have the backend names differnt for both nodes ..??06:17
RJ_2. it is reuired to enable_backend in cinder.conf file ..??06:17
RJ_ 3. need to have Replication relationship db table: ..?06:17
RJ_hey this is my code for driver06:17
RJ_all in one file06:17
RJ_can you ponit out mistakes and sugestions ...06:18
RJ_please help ...?06:18
*** zengyunling__ has joined #openstack-cinder06:18
*** ling-yun-1 has quit IRC06:19
*** r-daneel has quit IRC06:25
*** nlevinki has joined #openstack-cinder06:26
*** ling-yun-1 has joined #openstack-cinder06:28
*** Masahiro has joined #openstack-cinder06:30
RJ_Error logs :06:30
*** Mandell has joined #openstack-cinder06:31
anishjgriffith: hemnafk can I get some feedback on this code ?
*** zengyunling__ has quit IRC06:32
*** Masahiro has quit IRC06:34
*** annashen has joined #openstack-cinder06:35
*** nshaikh has joined #openstack-cinder06:35
*** BharatK has quit IRC06:36
*** ling-yun-1 has quit IRC06:37
*** nshaikh has quit IRC06:39
*** ebalduf has joined #openstack-cinder06:42
*** fandi has joined #openstack-cinder06:44
*** fandi has quit IRC06:46
*** fandi has joined #openstack-cinder06:47
*** rushil has quit IRC06:47
*** ebalduf has quit IRC06:47
*** rushil has joined #openstack-cinder06:48
*** rushil has quit IRC06:48
*** BharatK has joined #openstack-cinder06:50
*** annashen has quit IRC06:55
*** nshaikh has joined #openstack-cinder06:56
nikesh_vedamsi m trying to create CI for cinder driver testing06:57
nikesh_vedamsi deployed a kilo devstack on ubuntu 14.04 server. i launched a instance from dashboard,successfully launched but i am unable to open console from dashboard for instance Also instacne is unable to get ip06:57
*** rushiagr_away is now known as rushiagr06:58
*** Longgeek has quit IRC06:59
*** fandi has quit IRC07:01
*** cdelatte has joined #openstack-cinder07:01
*** cdelatte has quit IRC07:02
thingeenikesh_vedams: I recommend asking #openstack. This is not a support channel for openstack.07:02
openstackgerritJohnson koil raj proposed openstack/cinder: VMware: driver not handling port other than 443
*** paul-- has quit IRC07:08
*** Longgeek has joined #openstack-cinder07:08
*** paul-- has joined #openstack-cinder07:09
openstackgerritHuang Zhiteng proposed openstack/cinder: Raise correct exception when validate_connector failed
openstackgerritTaoBai proposed openstack/cinder: IBM Storwize driver Consistency Group Implementation
*** avishay has quit IRC07:14
*** avishay_ has joined #openstack-cinder07:14
*** rakesh___510 has joined #openstack-cinder07:15
*** sgotliv has quit IRC07:18
*** coolsvap is now known as coolsvap|afk07:20
*** fandi has joined #openstack-cinder07:24
*** thingee has quit IRC07:25
*** coolsvap has joined #openstack-cinder07:29
openstackgerritChangBo Guo(gcb) proposed openstack/cinder: Use dict comprehensions instead of dict constructor
*** Miouge has joined #openstack-cinder07:35
*** coolsvap has quit IRC07:38
*** ebalduf has joined #openstack-cinder07:43
*** ebalduf has quit IRC07:48
*** jamielennox is now known as jamielennox|away07:56
*** avishay_ has quit IRC07:56
*** paul-- has quit IRC08:00
*** paul-- has joined #openstack-cinder08:01
openstackgerritChangBo Guo(gcb) proposed openstack/cinder: Use dict comprehensions instead of dict constructor
*** e0ne has joined #openstack-cinder08:07
*** e0ne has quit IRC08:10
*** chlong has quit IRC08:10
*** skraynev has joined #openstack-cinder08:16
openstackgerritVincent Hou proposed openstack/cinder: Remove the useless next link for volumes, transfers and backups
openstackgerritJohnson koil raj proposed openstack/cinder: VMware: driver not handling port other than 443
*** pwehrle has joined #openstack-cinder08:18
*** Masahiro has joined #openstack-cinder08:18
*** Masahiro has quit IRC08:23
*** fandi has quit IRC08:23
*** skraynev_ has joined #openstack-cinder08:28
*** skraynev_ has quit IRC08:28
*** nkrinner has joined #openstack-cinder08:32
*** tshefi has joined #openstack-cinder08:32
*** Miouge has quit IRC08:35
*** jkraj has joined #openstack-cinder08:39
*** afazekas has joined #openstack-cinder08:39
openstackgerritChangBo Guo(gcb) proposed openstack/cinder: Use dict comprehensions instead of dict constructor
*** coolsvap|afk is now known as coolsvap08:42
*** jordanP has joined #openstack-cinder08:44
*** ebalduf has joined #openstack-cinder08:44
*** ebalduf has quit IRC08:49
*** annashen has joined #openstack-cinder08:55
*** annashen has quit IRC09:00
*** Mandell has quit IRC09:00
*** nlevinki has quit IRC09:01
*** Mandell has joined #openstack-cinder09:02
*** jpich has joined #openstack-cinder09:02
*** teju has quit IRC09:02
git-harryCan some cores take a look at this devstack patch - a devstack core has asked for some cinder +1s09:04
*** Mandell has quit IRC09:07
openstackgerritTrung Trinh proposed openstack/cinder: Delete volume attached to already-deleted VM
*** nlevinki has joined #openstack-cinder09:17
*** aviramb has joined #openstack-cinder09:21
*** ndipanov has joined #openstack-cinder09:22
openstackgerritVincent Hou proposed openstack/cinder: Remove the useless next link for volumes, transfers and backups
*** karimb has joined #openstack-cinder09:29
*** RJ_ has quit IRC09:37
openstackgerritPh. Marek proposed openstack/cinder: Give a meaningful error message if some library couldn't be loaded.
*** RJ_ has joined #openstack-cinder09:39
flip214jgriffith: please look at ^^09:41
*** ebalduf has joined #openstack-cinder09:45
RJ_can any one look at09:45
RJ_volume driver for cinder09:46
RJ_i trying to add replication support ..??09:46
RJ_can any one point mistakes or suggesstions09:46
RJ_these logs for errors .09:47
*** ebalduf has quit IRC09:49
DuncanTRJ_: Add some log messages to the capabilities scheduler to figure out what is going on09:50
*** dalgaaf has joined #openstack-cinder09:54
*** jistr has joined #openstack-cinder09:58
RJ_DuncanT: capabilities scheduler is not there09:59
RJ_in the code09:59
DuncanTI haven't got it in my checkout either. That log message is coming from somewhere though. Do you have a different version of the code running?10:00
RJ_DuncanT: can you suggest me the file10:00
RJ_I have juno  lates10:00
RJ_this link i follwed for installation10:01
*** nlevinki has quit IRC10:01
DuncanTJuno? That's old. You want to be developing against head of trunk10:01
RJ_DuncanT: can you check that10:01
RJ_which one you have links of that ...??10:01
DuncanTIf you just install devstack, that will be trunk by default. That is what most people use for dev work10:02
RJ_DuncanT: ohk10:02
RJ_i have not installled that ..?10:02
RJ_so ineed to install that ..??10:03
DuncanTGoogle 'devstack howto' - there are loads of tutorials10:03
DuncanTIt will clone the git trees of all of devstack in /opt/stack so you'll have the latest version of everything10:03
RJ_DuncanT : these barnch also10:04
RJ_not having capablities schedule10:04
*** nshaikh has left #openstack-cinder10:05
DuncanTYes, I think the capabilities scheduler got renamed, maybe moved into the main scheduler code - I really don't remember.10:05
DuncanTI haven't looked at the scheduler in a while10:05
DuncanTIf you port your code to devstack, I'll be more able to help10:06
*** nshaikh has joined #openstack-cinder10:06
RJ_DuncanT: ohk so need to remove all the installed part10:06
RJ_of junoi10:06
RJ_DuncanT: is it possible to merge juno with devstack10:07
*** Masahiro has joined #openstack-cinder10:07
DuncanTThat is probably easiest to remove juno. Many people run devstack in a VM so that they can blow it away and start again easily, or have several different streams of development10:07
RJ_DuncanT: then it is going to work with storage nodes ..?10:09
RJ_comupute nodes ../10:09
RJ_DuncanT: or need to again install the all storage and compute nodes ..?10:10
DuncanTFor test purposes, you can run compute and storage on the same node. Google 'multinode devstack' for getting it working with the two services on separate nodes10:10
*** Masahiro has quit IRC10:11
RJ_what devstack having extra part ..??10:13
RJ_in that ../10:13
RJ_from juno ../10:13
DuncanTForget juno, juno is old. You should develop new patches against trunk10:17
*** deepakcs has joined #openstack-cinder10:18
RJ_DuncanT: you have any links for follow that ..?10:20
RJ_DuncanT: devstack ..10:21
openstackgerritBob proposed openstack/cinder: Add loopingcalls for Huawei storage system driver
DuncanTRJ_: (top hit on a google search for "devstack multinode howto") seems like the logical place to start10:26
*** e0ne has joined #openstack-cinder10:27
RJ_DuncanT: ohk10:30
RJ_but avishay talking me that10:30
RJ_DuncanT: this errors may be due to data[replication]= true10:31
openstackgerritustcdylan proposed openstack/cinder: Fix bug in sheepdog driver: the wrong volume size
RJ_is not set ../10:31
*** marcusvrn has joined #openstack-cinder10:32
DuncanTRJ_: I have no idea, which is why I suggested adding extra LOG lines to be sure. Given that you're using old code, you won't be able to submit your work for merging anyway - you need to rebase on top of trunk and test it on that code base10:33
RJ_ohk ..10:33
RJ_you seen the code of driver ..?10:34
DuncanTI don't understand the question10:34
RJ_DuncanT: what you feel about this code ..?10:35
DuncanTIt doesn't look terrible, and when it is working and tested I'm happy to review it10:35
*** BharatK has quit IRC10:36
DuncanTUntil it is rebased on trunk though, I've really very little interest in it10:36
RJ_DuncanT: me too will be happy10:38
RJ_DuncanT: buut not getting the exact knwldg regarding the replication10:38
RJ_therse is no doc related for replication10:38
RJ_DuncanT: what is pre required changes etc10:39
DuncanTGet your driver working on devstack. Add log lines to the scheduler until you understand what is going on. Write some docs on what you found. Currently we only have example code for replication, not good docs10:39
RJ_DuncanT: what changes in cinder.conf or how to and second node etc ...??10:40
DuncanTRJ_: Nobody has written those docs that I'm aware of. I'm not aware of anybody specifically working on those docs. You are very welcome to figure out how to do it and document it. As I've said, repeatedly, your first step should probably to get devstack set up rather than trying to base your work on juno, since the replication work was barely started by the10:41
DuncanTend of juno.10:41
*** ebalduf has joined #openstack-cinder10:46
*** nlevinki has joined #openstack-cinder10:47
*** BharatK has joined #openstack-cinder10:49
*** nellysmitt has joined #openstack-cinder10:49
*** ebalduf has quit IRC10:50
flip214DuncanT: thanks a lot for the quick feedback, will redo.10:56
*** annashen has joined #openstack-cinder10:56
openstackgerritVincent Hou proposed openstack/cinder: Remove the useless next link for volumes, transfers and backups
*** pcaruana has joined #openstack-cinder10:59
*** annashen has quit IRC11:01
*** pradipta has quit IRC11:05
RJ_DuncanT: hey one more11:08
*** pradipta has joined #openstack-cinder11:08
*** Masahiro has joined #openstack-cinder11:08
RJ_DuncanT: replication relation table required in the db for replication suppport ..??11:08
DuncanTI believe that is used by the manager to handle promote etc, so yes. I haven't looked at the code in a while though11:09
DuncanTIt should all be taken care of for you, the driver shouldn't need to touch it11:09
*** nshaikh has quit IRC11:12
*** Masahiro has quit IRC11:13
*** pradipta is now known as pradipta_away11:21
*** haomaiwang has quit IRC11:22
*** triggerz_ has quit IRC11:28
*** david-lyle has joined #openstack-cinder11:32
*** chlong has joined #openstack-cinder11:41
*** nshaikh has joined #openstack-cinder11:41
*** Miouge has joined #openstack-cinder11:43
*** chlong has quit IRC11:47
*** chlong has joined #openstack-cinder11:48
*** Miouge has quit IRC11:51
*** e0ne is now known as e0ne_11:56
*** Miouge has joined #openstack-cinder11:58
*** lpabon has joined #openstack-cinder12:02
*** e0ne_ is now known as e0ne12:04
*** EmilienM|afk is now known as EmilienM12:10
erlonDuncanT: hi Duncan, who is the guys/team responsible for backporting changes to stable/master?12:15
*** rakesh___510 has quit IRC12:19
*** rakesh___510 has joined #openstack-cinder12:19
nikesh_vedamswe are trying to use sos_ci12:25
nikesh_vedamsCI setup in cinder12:25
nikesh_vedamswe delpoyed a openstack kilo cloud for this12:25
nikesh_vedamswe updated  sos-ci/sos-ci/ansible/vars.yml12:26
nikesh_vedamswith our cloud credentials12:26
nikesh_vedamsnow what to run12:26
nikesh_vedamsnot getting12:26
nikesh_vedamscan any one help please12:26
*** rakesh___510 has quit IRC12:27
DuncanTerlon: Anybody can submit backport reviews12:28
*** sgotliv has joined #openstack-cinder12:30
*** jkraj has quit IRC12:31
DuncanTnikesh_vedams: Not claiming any expertise, but "python" by the looks of it. You might want to look at first, it looks like it does a one-shot test of your config12:31
*** IanGovett has joined #openstack-cinder12:33
*** diegows has joined #openstack-cinder12:39
*** alexpilotti has joined #openstack-cinder12:39
*** Longgeek has quit IRC12:39
erlonDuncanT: my question is, who are the people that approve what changes will or won't be backported12:40
DuncanTAh, jungleboyj, jgriffith  and thingee are the people I know are active on that - there are probably others, check who voted on the last few stable reviews to be sure12:41
*** alexpilotti has quit IRC12:44
*** ebalduf has joined #openstack-cinder12:48
nikesh_vedamsDuncanT:have you used sos-ci ?12:49
nikesh_vedamsDuncanT:whatever readme suggested we provided but still i doubt some things missing12:50
*** ebalduf has quit IRC12:52
*** RJ_ has quit IRC12:53
*** deepakcs has quit IRC12:54
*** alexpilotti has joined #openstack-cinder12:55
*** chlong has quit IRC12:55
*** rushiagr is now known as rushiagr_away12:56
*** Masahiro has joined #openstack-cinder12:57
*** annashen has joined #openstack-cinder12:57
DuncanTnikesh_vedams: I've not used John's version, no. I've a hacked together (unpublished) thing of my own. I'm sure John would accept patches to improve the docs of sos-ci12:57
*** Miouge has quit IRC12:58
nikesh_vedamsDuncanT:can you suggest how to easily setup CI?13:00
nikesh_vedamsDuncanT: we have a patch ""13:01
nikesh_vedamsDuncanT: we want to set up a CI for it13:01
*** annashen has quit IRC13:01
*** Masahiro has quit IRC13:01
DuncanTnikesh_vedams: Most people see to have gone the jenkins/nodepool route, which is supported by #openstack-infra13:02
*** Longgeek has joined #openstack-cinder13:02
*** Mandell has joined #openstack-cinder13:02
DuncanTnikesh_vedams: sos-ci and similar are a lighter weight approach but assume a certain degree of understanding of the problem space currently13:02
*** Miouge has joined #openstack-cinder13:02
openstackgerritMarc Koderer proposed openstack/cinder: Update README.rst to current state
DuncanTnikesh_vedams: If you want to go the sos-ci route then I suggest you'll need to go through the code for it (there isn't much) and test the bits13:03
DuncanTnikesh_vedams: If you want to go the officially recommended route (jenkins) then #openstack-infra have people with more experience of helping13:04
DuncanTnikesh_vedams: There's a series of blog posts by Jaya Pipes that might be a good starting point to the jenkins approach13:05
*** jinhui has joined #openstack-cinder13:06
*** Mandell has quit IRC13:06
*** e0ne is now known as e0ne_13:11
nikesh_vedamswhy no one replies in #openstack-infra :(13:12
*** bswartz has quit IRC13:14
*** ryanpetrello has joined #openstack-cinder13:17
*** sandywalsh has joined #openstack-cinder13:23
*** jkraj has joined #openstack-cinder13:25
*** rushiagr_away is now known as rushiagr13:33
*** kalango has joined #openstack-cinder13:35
DuncanTnikesh_vedams: Timezones, I expect. Be patient13:45
*** e0ne_ is now known as e0ne13:45
*** ebalduf has joined #openstack-cinder13:48
*** rakesh___510 has joined #openstack-cinder13:49
*** ebalduf has quit IRC13:53
*** alonmarx_ has joined #openstack-cinder13:53
*** alonmarx has quit IRC13:56
*** bswartz has joined #openstack-cinder13:57
*** akerr has joined #openstack-cinder13:57
*** sgotliv has quit IRC13:57
*** Miouge has quit IRC14:01
*** Miouge has joined #openstack-cinder14:02
*** e0ne is now known as e0ne_14:03
*** rushil has joined #openstack-cinder14:04
*** kalango has left #openstack-cinder14:05
*** rakesh___510_ has joined #openstack-cinder14:06
*** rakesh___510 has quit IRC14:09
*** Yogi1 has joined #openstack-cinder14:09
*** dustins has joined #openstack-cinder14:10
*** e0ne_ is now known as e0ne14:11
*** sgotliv has joined #openstack-cinder14:13
*** jinhui has quit IRC14:13
*** julim has joined #openstack-cinder14:15
*** jcru has joined #openstack-cinder14:17
*** kaufer has joined #openstack-cinder14:18
*** rakesh___510_ has quit IRC14:21
*** mwichmann has joined #openstack-cinder14:22
*** anshul has quit IRC14:23
*** Miouge has quit IRC14:27
*** BharatK has quit IRC14:30
*** Miouge has joined #openstack-cinder14:30
openstackgerritVincent Hou proposed openstack/cinder: Remove the useless next link for volumes, transfers and backups
*** eharney has joined #openstack-cinder14:32
*** mriedem has joined #openstack-cinder14:36
*** anshul has joined #openstack-cinder14:36
*** Longgeek has quit IRC14:37
*** nshaikh has left #openstack-cinder14:37
*** e0ne is now known as e0ne_14:39
*** tbarron has joined #openstack-cinder14:40
*** e0ne_ is now known as e0ne14:42
*** Longgeek has joined #openstack-cinder14:42
*** jwang__ has joined #openstack-cinder14:42
*** jwang_ has quit IRC14:43
*** Masahiro has joined #openstack-cinder14:45
*** EduardBiceriMate has joined #openstack-cinder14:48
*** jecarey has quit IRC14:49
*** ebalduf has joined #openstack-cinder14:49
*** Masahiro has quit IRC14:50
*** jkraj has quit IRC14:51
*** ebalduf has quit IRC14:54
*** thangp has joined #openstack-cinder14:55
*** annashen has joined #openstack-cinder14:58
*** ndipanov has quit IRC14:58
*** fifieldt__ has joined #openstack-cinder15:00
*** tbarron has quit IRC15:00
*** asselin_ has joined #openstack-cinder15:01
*** Yogi11 has joined #openstack-cinder15:01
*** annashen has quit IRC15:02
*** ndipanov has joined #openstack-cinder15:02
*** fifieldt_ has quit IRC15:02
*** nlevinki has quit IRC15:02
*** tbarron has joined #openstack-cinder15:03
*** dustins_ has joined #openstack-cinder15:03
*** julim_ has joined #openstack-cinder15:04
*** dustins has quit IRC15:04
*** Yogi1 has quit IRC15:04
*** jungleboyj has joined #openstack-cinder15:04
*** julim has quit IRC15:05
*** lcurtis has joined #openstack-cinder15:05
git-harryCan some cores take a look at this devstack patch - a devstack core has asked for some cinder +1s15:06
*** mtanino has joined #openstack-cinder15:07
*** juzuluag has joined #openstack-cinder15:10
*** EduardBiceriMate has quit IRC15:12
*** superdan is now known as dansmith15:15
openstackgerritVincent Hou proposed openstack/cinder: Remove the useless next link for volumes, transfers and backups
*** fischerw has joined #openstack-cinder15:15
*** beekneemech is now known as bnemec15:16
jgriffithgit-harry: thanks for putting that together15:16
jgriffithgit-harry: I'd like to make sure thingee looks at it when he gets in15:17
*** jecarey has joined #openstack-cinder15:17
*** nlevinki has joined #openstack-cinder15:17
git-harryjgriffith: okay, sure. Thanks for looking.15:17
*** ebalduf has joined #openstack-cinder15:19
*** Yogi11 has quit IRC15:21
*** rmesta has joined #openstack-cinder15:24
*** dustins_ has quit IRC15:26
nikesh_vedamsjgriffith:we are trying to create a CI with sos-ci,we deployed kilo devstack for sos-ci and we changed sos-ci/sos-ci/ansible/vars.yml15:26
nikesh_vedamsjgriffith: we configured CI account too15:26
jgriffithnikesh_vedams: cool15:27
nikesh_vedamsjgriffith:but seems like many hard-coding is in sos-ci with solidfire and local directories15:27
nikesh_vedamsso need some help15:28
jgriffithnikesh_vedams: just the local.conf.template file15:28
jgriffithnikesh_vedams: and then variables in your ansible dir15:28
jgriffithnikesh_vedams: as far as directories, yes... I think you'll need to work that out15:29
jgriffithnikesh_vedams: thought I converted it to use relative paths but probably not15:29
*** e0ne is now known as e0ne_15:30
*** ndipanov has quit IRC15:31
*** kaisers has quit IRC15:31
nikesh_vedamsdo we have to  run to start the CI setup and also this script is taking CI environment variables15:31
nikesh_vedamsjgriffith: do we have to  run to start the CI setup and also this script is taking CI environment variables15:32
nikesh_vedamsjgriffith: so i hope we have to set it explicitly right15:32
jgriffithnikesh_vedams: yes15:33
*** tr4sh_heap has joined #openstack-cinder15:33
*** nlevinki has quit IRC15:35
nikesh_vedamsjgriffith: CINDER_BRANCH=master in local.conf.base but we want devstack setup with our scst changes so shall we give CINDER_BRANCH=refs/changes/78/145778/115:40
*** e0ne_ has quit IRC15:41
*** ndipanov has joined #openstack-cinder15:44
*** aarefiev_ has joined #openstack-cinder15:46
*** Miouge has quit IRC15:47
*** kaisers has joined #openstack-cinder15:48
*** e0ne has joined #openstack-cinder15:51
*** EduardBiceriMate has joined #openstack-cinder15:54
*** tbarron has quit IRC15:55
*** ebalduf has quit IRC15:56
*** e0ne_ has joined #openstack-cinder15:59
*** tshefi has quit IRC15:59
*** tbarron has joined #openstack-cinder16:00
e0ne_hi cinder-devs!16:00
*** ndipanov has quit IRC16:00
e0ne_i'm looking on cinderclient.. it's still uses v1 as default. should we change it to v2 or it v1 will be dropped in Kilo?16:01
*** e0ne has quit IRC16:02
*** tbarron has quit IRC16:02
*** aarefiev_ has quit IRC16:03
*** aarefiev has quit IRC16:03
*** ndipanov has joined #openstack-cinder16:03
*** kaisers has quit IRC16:04
*** ebalduf has joined #openstack-cinder16:05
*** kaisers has joined #openstack-cinder16:05
*** Miouge has joined #openstack-cinder16:05
*** lcurtis has quit IRC16:05
*** rhagarty has quit IRC16:06
openstackgerritIvan Kolodyazhny proposed openstack/python-cinderclient: Set default OS_VOLUME_API_VERSION to '2'
*** rhagarty has joined #openstack-cinder16:06
*** dustins has joined #openstack-cinder16:07
*** MIDENN_ has joined #openstack-cinder16:08
*** ebalduf has quit IRC16:09
*** dustins has quit IRC16:09
*** tbarron has joined #openstack-cinder16:10
*** MIDENN_ has quit IRC16:10
*** hemnafk is now known as hemna16:11
*** dustins has joined #openstack-cinder16:12
*** e0ne_ is now known as e0ne16:12
*** tbarron1 has joined #openstack-cinder16:12
*** tbarron has quit IRC16:13
*** dustins has quit IRC16:13
*** dustins has joined #openstack-cinder16:14
*** asselin_ has quit IRC16:14
*** Yogi1 has joined #openstack-cinder16:17
*** tsekiyama has joined #openstack-cinder16:21
*** coolsvap is now known as coolsvap|afk16:25
*** TobiasE has joined #openstack-cinder16:26
*** ebalduf has joined #openstack-cinder16:26
*** Longgeek_ has joined #openstack-cinder16:29
*** rushiagr is now known as rushiagr_away16:29
*** Longgeek has quit IRC16:30
*** nkrinner has quit IRC16:30
*** jdurgin has joined #openstack-cinder16:30
smcginnisjungleboyj: Morning Jay! What's the oslo patch related to dropping _lazy()? Your comment actually referred to the patch you said you would drop.16:31
*** nkrinner has joined #openstack-cinder16:31
jungleboyjOye vey.16:31
smcginnisjungleboyj: Oh, nevermind. I found it.16:32
jungleboyjJust udpated.  Sorry about that.16:33
e0nejungleboyj: hi! could you please take a look on again? i'm be happy to get all migration-related tests merged:)16:33
jungleboyje0ne: Sure.  Have a coupel things goin on.16:34
e0nejungleboyj: thanks, Jay16:34
*** Masahiro has joined #openstack-cinder16:34
smcginnisjungleboyj: Shoot. Requirement conflict with openstack/requirements. :[16:35
smcginnisjungleboyj: Welcome to Monday morning. :)16:36
*** e0ne_ has joined #openstack-cinder16:37
*** Masahiro has quit IRC16:39
hemnaheh yah16:39
hemnacan I buy a /j please ?16:39
*** e0ne has quit IRC16:40
*** lcurtis has joined #openstack-cinder16:40
smcginnishemna: Depends what state you live in. (JK)16:41
*** dhellmann has quit IRC16:42
*** dhellmann has joined #openstack-cinder16:42
*** coolsvap|afk has quit IRC16:42
*** akerr is now known as akerr_away16:44
*** ndipanov has quit IRC16:44
*** lpabon has quit IRC16:45
*** coolsvap has joined #openstack-cinder16:47
*** btran has quit IRC16:48
*** btran has joined #openstack-cinder16:49
*** ebalduf has quit IRC16:49
jungleboyjsmcginnis: Where did you see that?16:52
*** r-daneel has joined #openstack-cinder16:52
jungleboyjsmcginnis: Ok, I see it now.16:53
*** _cjones_ has joined #openstack-cinder16:53
jungleboyjOh crap, so I would have to make the same change to openstack/requirements for stable/juno.  I am guessing I can't do that.16:53
smcginnisProbably more difficult.16:54
smcginnisMight be easier sticking with your first approach.16:54
*** dannywilson has joined #openstack-cinder16:54
* jungleboyj sighs.16:54
*** ebalduf has joined #openstack-cinder16:55
*** ndipanov has joined #openstack-cinder16:57
*** lcurtis has quit IRC16:58
*** vozcelik has joined #openstack-cinder16:58
*** sgotliv has quit IRC16:58
jungleboyjsmcginnis: I am getting the expert over here.17:01
*** mikedillion has joined #openstack-cinder17:02
*** Miouge has quit IRC17:02
*** jdurgin has quit IRC17:04
*** pwehrle has left #openstack-cinder17:05
*** dannywilson has quit IRC17:06
*** mikedillion has quit IRC17:06
*** dannywilson has joined #openstack-cinder17:06
*** rwsu has joined #openstack-cinder17:09
*** rwsu has quit IRC17:09
*** MIDENN_ has joined #openstack-cinder17:09
*** akerr_away is now known as akerr17:10
*** vozcelik has left #openstack-cinder17:10
*** MIDENN_ has quit IRC17:10
nikesh_vedamsjgriffith: there?17:14
*** tellesnobrega has quit IRC17:15
*** lcurtis has joined #openstack-cinder17:18
*** Yogi1 has quit IRC17:19
*** emagana has joined #openstack-cinder17:21
*** jpich has quit IRC17:25
*** Yogi1 has joined #openstack-cinder17:25
*** pcaruana is now known as pcaruana|off|17:27
*** nkrinner has quit IRC17:27
*** rwsu has joined #openstack-cinder17:27
nikesh_vedamsjgriifith:hi we are getting below output after running
*** afazekas has quit IRC17:35
*** e0ne_ has quit IRC17:36
*** dannywilson has quit IRC17:38
*** jecarey has quit IRC17:38
*** aarefiev has joined #openstack-cinder17:40
*** Longgeek_ has quit IRC17:42
*** juzuluag has quit IRC17:48
*** juzuluag has joined #openstack-cinder17:48
*** alonmarx_ has quit IRC17:49
*** alonmarx has joined #openstack-cinder17:50
*** patrickeast has joined #openstack-cinder17:54
*** xmltok has left #openstack-cinder17:59
*** jordanP has quit IRC17:59
*** tellesnobrega has joined #openstack-cinder18:00
*** sgotliv has joined #openstack-cinder18:01
*** leeantho has joined #openstack-cinder18:03
*** jistr has quit IRC18:03
jgriffithnikesh_vedams: for starters you might want to install ansible :)18:04
*** leeantho_ has joined #openstack-cinder18:04
jgriffithnikesh_vedams: hard to run ansible playbooks without it18:04
*** ebalduf has quit IRC18:05
jgriffithnikesh_vedams: not sure what's up with the paramiko trace you're seeing there18:05
nikesh_vedamsjgriffith:actuallly we installed ansible earlier with apt-get,so things went under /usr/bin18:06
nikesh_vedamsjgriffith:after apt-get purge ansible and installing ansible and other things with pip,that error gone18:07
jgriffithyeah, pip is better18:07
jgriffithnikesh_vedams: pip and apt install in different locations IIRC18:07
*** leeantho has quit IRC18:08
*** bswartz has quit IRC18:08
*** crose has joined #openstack-cinder18:08
nikesh_vedamsjgriffith: yes apt install in /usr/bin and pip install in /usr/local/bin18:09
nikesh_vedamsthat why error18:09
nikesh_vedamsnow we are continuosly getting "loop...debug"18:09
nikesh_vedamshow can we know it is working or not18:10
*** bswartz has joined #openstack-cinder18:12
*** annashen has joined #openstack-cinder18:15
*** Mandell has joined #openstack-cinder18:22
*** dannywilson has joined #openstack-cinder18:23
*** dannywilson has quit IRC18:23
*** Masahiro has joined #openstack-cinder18:23
*** dannywilson has joined #openstack-cinder18:23
jgriffithnikesh_vedams: you should read the code :)18:25
jgriffithnikesh_vedams: loop...debug mean it's listening waiting for commits18:26
jgriffithnikesh_vedams: when  commit comes in and gets processed you'll see it logged18:26
nikesh_vedamsone more thing, CINDER_BRANCH=master in local.conf.base but we want devstack setup with our scst changes so we are giving CINDER_BRANCH=refs/changes/78/145778/118:28
*** Masahiro has quit IRC18:28
nikesh_vedamsis it ok18:28
jgriffiththe ansible scripts should set that for you based on the commit that is picked up by the listener18:29
nikesh_vedamsok so master is enough18:29
nikesh_vedamsand one more thing we have to install scst packages,so we have to update  " sos-ci/sos-ci/ansible/tasks/install_devstack.yml" right18:30
jgriffithnikesh_vedams: yes, or better yet write a new ansible task and insert it18:31
*** jdurgin has joined #openstack-cinder18:34
*** Mandell has quit IRC18:38
openstackgerritWalter A. Boring IV (hemna) proposed openstack/python-cinderclient: WIP Add volume multi attach support
*** harlowja_away is now known as harlowja18:39
openstackgerritWalter A. Boring IV (hemna) proposed openstack/python-cinderclient: Add volume multi attach support
*** Mandell has joined #openstack-cinder18:42
*** anshul has quit IRC18:50
*** jecarey has joined #openstack-cinder18:51
*** dannywilson has quit IRC18:52
*** mudassirlatif has joined #openstack-cinder18:53
*** e0ne has joined #openstack-cinder18:54
*** harlowja has quit IRC19:00
*** harlowja has joined #openstack-cinder19:00
*** harlowja has quit IRC19:00
nikesh_vedamsjgriffith:i am new to yaml,do you any good link to understand yaml syntax19:00
jgriffithnikesh_vedams: nope, but that syntax is ansible yaml so you should consult the ansible docs19:02
*** crose has quit IRC19:06
openstackgerritJohn Griffith proposed openstack/cinder: Implement clone_image caching on SolidFire
*** e0ne is now known as e0ne_19:09
openstackgerritAnthony Lee proposed openstack/cinder: Remove locks from LeftHand driver
openstackgerritThang Pham proposed openstack/cinder: WIP: Snapshot object
openstackgerritThang Pham proposed openstack/cinder: WIP: Cinder objects base
*** corvus is now known as jeblair19:13
*** dannywilson has joined #openstack-cinder19:13
*** alecv has joined #openstack-cinder19:14
*** e0ne_ has quit IRC19:15
*** dalgaaf has quit IRC19:17
*** karimb has quit IRC19:19
*** e0ne has joined #openstack-cinder19:20
openstackgerritxing-yang proposed openstack/cinder: Add support to differential backups in cinder
*** marcusvrn has quit IRC19:21
*** Mandell has quit IRC19:25
*** anshul has joined #openstack-cinder19:26
*** anshul has quit IRC19:26
*** Mandell has joined #openstack-cinder19:31
openstackgerritScott DAngelo proposed openstack/cinder: Proof of concept for reset-state-with-driver
jgriffithDuncanT: around?19:35
*** sgotliv has quit IRC19:37
openstackgerritScott DAngelo proposed openstack/cinder: Proof of concept for reset-state-with-driver
*** ebalduf has joined #openstack-cinder19:40
*** EduardBiceriMate has quit IRC19:42
*** _cjones_ has quit IRC19:44
*** _cjones_ has joined #openstack-cinder19:44
anishjgriffith: hemna can I get some feedback on this WIP code ?
hemnaanish, sure19:47
anishspecifically, it also happens to implement code that was supposed to be done by someone else's bp19:49
anishso I'm not sure how to proceed with that19:49
*** jnrao has joined #openstack-cinder19:50
*** harlowja has joined #openstack-cinder19:52
*** thingee has joined #openstack-cinder19:54
jgriffithharlowja: ping :)19:55
harlowjajgriffith pong19:56
jgriffithharlowja: hey ya... got a second?19:56
jgriffithharlowja: or a few hundred :)19:56
jgriffithharlowja: ok, so the concept I was looking at of putting that update in the run block won't work19:57
harlowjawhat about a new task then?19:57
jgriffithharlowja: becuase the flow actually calls the volume/ create method each time / retry19:57
harlowjashove it at the end of the workflow?19:57
jgriffithharlowja: yeah, that's what I think has to be done19:57
thingeegit-harry, jgriffith: responded to
jgriffithharlowja: but I'm trying to better understand how this works19:57
harlowjak, which part confusing u19:58
jgriffithharlowja: so what I've gathered is....19:58
jgriffithharlowja: once the command goes to the cinder.scheduler;19:58
jgriffithharlowja: the retrys are actually handled by the taskflow lib19:58
jgriffithharlowja: and sent *directly* to the host manager19:58
jgriffithharlowja: ie they don't go back through the cinder filter scheduler as new rpc calls?19:58
harlowjaafaik they should be19:59
jgriffithbut I'm uncertain...19:59
harlowjaafaik u guys aren't using the taskflow retry stuffs19:59
jgriffithharlowja: we sure are19:59
harlowjawell its sorta via that damn external loop that exists from nova days19:59
jgriffithharlowja: Ok, so tell me if this sounds right....19:59
jgriffithstupid nova days20:00
*** e0ne has quit IRC20:00
*** akerr has quit IRC20:00
harlowjawe are all young once20:00
harlowjadidn't mean to inhale...20:00
harlowja*except its ok in colorado20:00
*** akerr has joined #openstack-cinder20:00
jgriffithWe're even more liberal that CA now LOL20:00
jgriffithOk... so the call to create....20:00
jgriffithgoes from cinder.volume.api --> cinder.volume.flows.api.create_volume20:01
anishcinder sort means burnt wood yes ? a specific type of tree even. very apt20:01
*** david-lyle has quit IRC20:02
jgriffithwhich hits up cinder.volume.flows.manager.create_volume20:02
harlowjak, so right, thats the api stuffs, ya20:02
jgriffithand issues the call out to cinder.scheduler.****20:02
*** juzuluag has quit IRC20:02
jgriffithand there it bounces around between filter rpc module, taskflow module that's inside the scheduler etc20:02
harlowja (all that stuffs)20:02
*** e0ne has joined #openstack-cinder20:03
harlowjaok, ya, so that bouncing is sorta not in taskflow, but external (from the nova retry days)20:03
harlowjathat loop is not so easy to know about, ha20:03
jgriffithharlowja: hmmm20:03
jgriffithharlowja: why the hell do we need that if we have the retry loop in tflow?20:03
thingeee0ne: with regards to your question about cinderclient defaulting to v2. have you seen
thingeee0ne: whoops20:03
harlowjajgriffith young days20:03
harlowjacinder inhaled....20:03
thingeee0ne: this one
jgriffithharlowja: haha20:03
harlowjajgriffith so that gets bounced via
jgriffithharlowja: so the problem with just adding a new task...20:04
jgriffithharlowja: I actually need to break the update piece out of that method in the volume manager20:04
jgriffithmake it its own independent method20:04
jgriffithand call it on completion20:05
e0nethingee: thanks. i've seen your request20:05
jgriffiththat's not a terribly big deal I suppose20:05
harlowja (is where this gets sent back to the scheduler; and repeat...)20:05
jgriffithOh... yay!!!  that helps :)20:05
harlowjaright, jgriffith so should be a place u can add a new task20:06
jgriffithharlowja: the OnFailureReschedule class no?20:06
harlowjathats the thing that gets triggered when a failure happens; that causes the loop to go back to the scheduler20:06
harlowjawhich the filter scheduler then interprets (and thats why this loop hard to understand)20:06
jgriffithharlowja: that's where I was at, but honestly got a bit concerned when I see the taskflow.create_volume versions EVERYWHERE20:07
harlowjaya, perhaps that could be better named module20:07
jgriffithin scheduler, as well as volume/flows/manager and API20:07
harlowjasince its really 'create_volume_api'20:07
harlowjaor create_volume_scheduler20:07
harlowjaor create_volume_manager20:07
harlowjaworkflows for each piece20:07
jgriffithharlowja: yeah, as it stands it's sort of hard to figure out by code inspection IMHO20:07
jgriffithharlowja: especially since EVERYTHING has the same module name20:08
jgriffithjust diff locations20:08
jgriffithand they all have pretty common method names :(20:08
harlowjaat least we are consistent ;)20:08
jgriffithharlowja: that is true!20:08
jgriffithharlowja: so if I add this calss to volume/flows/manager20:08
harlowjadrop it in at the end of volume_flow.add(ExtractVolumeSpecTask(db),20:09
harlowjaNotifyVolumeActionTask(db, "create.start"),20:09
harlowjaCreateVolumeFromSpecTask(db, driver),20:09
harlowjaCreateVolumeOnFinishTask(db, "create.end"))20:09
jgriffithharlowja: I will also need an rpc call back out to cinder.volume.manager no?20:09
harlowjavolume flows manager is running in the manager afaik20:09
jgriffithharlowja: because keep in mind, this is an internal class variable that we're trying to update20:09
jgriffithharlowja: Ahhhh!!!!20:10
jgriffithharlowja: so I'm already across the boundary at this point!20:10
jgriffithharlowja: rpc boundary that is20:10
harlowjajust inhale dude20:10
harlowjathat boundary20:10
e0nethingee: i've got some interesting issue from out support guys. here is steps to reproduce20:10
jgriffithharlowja: see what I mean?  I don't think it's that trivial20:10
jgriffithharlowja: because it needs to update the host the volume was scheduled to20:11
*** tbarron1 has quit IRC20:11
git-harrythingee: regarding - it's not for cinder endpoints20:11
*** tbarron has joined #openstack-cinder20:11
e0nethingee: i should to create a launchpad bug before submitting
jgriffithharlowja: and we want to update it regardelss if it's created in error or available20:11
git-harrythingee: it so that cinder properly references nova's20:12
jgriffithharlowja: but obviously only increment it once :)20:12
*** Masahiro has joined #openstack-cinder20:12
jgriffithharlowja: the other thing I thought of was some way of checking the exception to see if it's the "last" attempt20:12
harlowjaok, so then u almost need to know if the rescheduling got triggered right20:12
jgriffithand just simply be done20:12
harlowjaan idear20:12
jgriffithI need to know if it was rescheduled (that is what led to the call I'm looking at)20:13
harlowjau can plug-in notification to an engine in taskflow; to get notified of all tasks running20:13
jgriffiththe other way around know that the exception is the last time I'll see it ;)20:13
harlowjaand u can then handle if OnFailureRescheduleTask got triggered or if it didn't20:13
jgriffithharlowja: easy for you to say :)20:13
jgriffithharlowja: so that sounds like an elegant solution20:13
jgriffithharlowja: but I would have no idea how to go about that20:14
*** Mandell has quit IRC20:14
harlowjawellll thats ok20:14
jgriffithharlowja: :)20:14
harlowja is one such example20:15
jgriffithharlowja: mmm20:15
harlowjaengine.task_notifier.register('*', task_watch) (basically registering a function that will get triggered on all state changes)20:16
harlowjathen if 'OnFailureRescheduleTask' runs; don't do whatever u wanted to20:16
harlowjabut if it doesn't; then run special update code20:16
*** Masahiro has quit IRC20:16
*** ryanpetrello has quit IRC20:17
jgriffithharlowja: hurumph20:17
*** juzuluag has joined #openstack-cinder20:17
harlowjaan idear20:17
*** ryanpetrello has joined #openstack-cinder20:17
harlowja are states u should get notified about20:18
jgriffithharlowja: maybe I'll just scrap this approach.... don't increment on failed create20:18
jgriffithharlowja: and add a flag somewhere that indicates as such20:18
jgriffithand never decrement if it's not toggled20:18
jgriffithat this point it seems like that might be *easier*20:18
jgriffithharlowja: looking at your last link...20:19
harlowjaagreed, then u can just add a 'finish' adjustment that does that increment20:19
harlowjaor  finish on error (but not rescheduled)20:19
harlowjastupid rescheduling loop20:19
harlowjaimho that needs to die (to confusing and funky)20:19
jgriffithharlowja: FWIW, I think the rescheduling part is cool20:19
jgriffithharlowja: just in the wrong place ;)20:19
harlowjabut u almost need a conductor (that does the rescheduling in 1 place) to fix it better20:20
jgriffithharlowja: yeah20:20
jgriffithharlowja: I think so20:20
harlowjainstead of being across 2 places in bounce<->bounce loop20:20
harlowjabut we were all young once, ha20:20
jgriffithharlowja: yeah, it's kind of a big problem IMO20:20
jgriffithharlowja: haha20:21
jgriffithharlowja: well, who would've thought :)20:21
harlowjai sorta came out of my mom full grown so i didn't think it20:21
harlowja*poor mom*20:21
jgriffithharlowja: indeed!!!20:21
*** alonmarx has quit IRC20:21
*** alonmarx has joined #openstack-cinder20:22
harlowjait'd be nice to just start figuring out a path to some type of conductor imho (not neccasrily a remoting/objects conductor; but one that manages the lifecycle after API)20:22
jgriffithharlowja: well that's "in progress"20:22
harlowjabasically API -> conductor (conductor then talks with volume manager, scheduler, blah blah; manages rest of lifecycle)20:22
jgriffithharlowja: thangp is working on Cinder objects and conductor I believe20:22
harlowjaya, but thats the remoting/objects part of the conductor20:23
jgriffithharlowja: but that doesn't help with "fixing" bugs :(20:23
harlowjawhich imho is nice; but meh20:23
*** jamielennox|away has quit IRC20:23
*** sweston has quit IRC20:23
harlowjalifecycle conductor management imho is nicer20:23
jgriffithharlowja: ahhhhh.... your talking manager of managers sor to fthing20:23
jgriffithharlowja: oh... interesting20:23
jgriffithharlowja: well that would sure make this code a bit "simpler" to understand and work on I think20:23
harlowjabasically other managers are 'dumb20:23
harlowjaconductor/lifecycle manager is smart20:23
jgriffithharlowja: which as you know has been my only real complaint20:24
jgriffithharlowja: but I seem to be the only one having issues :(20:24
*** dannywilson has quit IRC20:24
harlowjaconductor/lifecycle manager is the only thing that uses taskflow (possible)20:24
jgriffithharlowja: maybe what I should do is punt and let the smarter people fix the bug20:24
harlowjaother managers just take orders20:24
jgriffithharlowja: wonder how long it will sit in LP20:24
jgriffithharlowja: I like the idea *I think*20:25
harlowjaconductor/lifecycle manager then can use state-tracking of taskflow; to be able to crash and recover20:25
harlowjaannnnd profit :-P20:25
jgriffithif I understand what your proposing correctly20:25
*** DuncanT has quit IRC20:25
harlowjamaybe, whats your interpretation :)20:25
*** krtaylor has quit IRC20:25
*** boris-42 has quit IRC20:25
*** russellb has quit IRC20:25
jgriffithharlowja: and if you get that it eliminates the need for the other work being proposed quite honestly20:25
*** vishy has quit IRC20:26
*** jbernard has quit IRC20:26
jgriffithharlowja: a "true" manager or conductor to deal with "object" or "tasks"20:26
jgriffithso you have a central manager that rules the create flow for example20:26
jgriffithand includes allowing/disallowing state transistions within that task20:26
harlowjaya (everything after APi stuff); it uses simple RPC to talk to other20:26
harlowjadumb managers20:26
*** Guest58319 has quit IRC20:27
jgriffithso when you run into things like I'm running into now... you have a very easy API to just say "add this thing"20:27
*** sweston has joined #openstack-cinder20:27
jgriffithor include this additional info in the response/exception20:27
jgriffithwell code that shit up :)20:27
harlowjai think nova will get to this someday to20:27
jgriffithYou have until Friday20:27
jgriffithhey... actually, that's another idea20:27
*** DuncanT has joined #openstack-cinder20:28
jgriffithis there a way for me to modify the exception and include "retry attempt of 'n' allowed"20:28
harlowjamake HA conductor/lifecycle manager; scale that out as needed (sharding, each lifecycle manager/group owns certain buckets...)20:28
*** barra204 has joined #openstack-cinder20:28
harlowjajgriffith i think it has that info; thought it did20:28
jgriffithharlowja: ok, now you're talking crazy20:28
jgriffithharlowja: I don't think so.... but lemme check20:29
harlowjaoh, u have num_attempts; but not max20:29
*** mgagne has joined #openstack-cinder20:29
*** jbernard has joined #openstack-cinder20:29
*** russellb has joined #openstack-cinder20:29
harlowja has this number though20:30
harlowjaso if its passed along i guess it could get used?20:30
*** mgagne is now known as Guest3658020:30
*** boris-42 has joined #openstack-cinder20:30
harlowjaboris-42 i think wants to refactor nova to a simple 'lifecycle conductor' and dumb managers20:30
harlowjaso he'll have that done by friday20:30
jgriffithharlowja: so the problem is that just bubbles up the original exception :(20:30
*** krtaylor has joined #openstack-cinder20:31
jgriffithharlowja: no info regarding taskflow20:31
harlowjahmmm; ya; u get a log message though
boris-42harlowja: ?)20:31
boris-42harlowja: me?20:31
harlowjaboris-42 no questions; just do it20:31
*** jamielennox|away has joined #openstack-cinder20:32
boris-42harlowja: okay20:32
*** annashen has quit IRC20:32
*** barra204_ has joined #openstack-cinder20:32
*** barra204 has quit IRC20:32
harlowjaboris-42 we are talking about how cinder could change to have a 'smart conductor that does all the smart workflow stuff' that then is made HA; it talks to dumb other managers/drivers over RPC20:32
*** jamielennox|away is now known as jamielennox20:32
harlowjasimilar to that conversation we had way back when about nova (which they might get to eventually)20:32
boris-42harlowja: hehe20:33
thingeegit-harry: that is correct. However, in the future, nova would just need to know the service_type name 'volume' and that could be used for v1 or v2 in older systems.20:33
harlowjajgriffith sooo u want to almost modify the exception that is propgating in taskflow?20:33
harlowjai wonder if this is easier than it seems; one sec20:33
thingeegit-harry: now that I think about it though, this might be useful for the stable versions of devstack20:33
jgriffithharlowja: bet it is for you :)20:33
thingeejust not master of the projects20:34
harlowjawell u'll see def revert(self, context, result, flow_failures, **kwargs): gets flow_failures20:34
harlowjaflow_failures does contain the propagating exception20:34
harlowjabut i don't think its mutaable20:34
*** Mandell has joined #openstack-cinder20:34
jgriffithharlowja: where are you looking at?20:34
jgriffithharlowja: ie where does the actual try/except and retry occur20:34
*** vishy has joined #openstack-cinder20:34
harlowjajgriffith that's deep in taskflow where that happens20:35
*** _cjones_ has quit IRC20:35
jgriffithharlowja: that's what I thought20:35
harlowja if u really want to know20:35
jgriffithharlowja: so *where* in flows/manager/create_volume can I intercept?20:35
*** elazro has quit IRC20:36
jgriffithharlowja: because from what I can tell... I can't20:36
*** elazro has joined #openstack-cinder20:36
anishjgriffith: thingee is IET support removed now ?20:36
harlowjawell if u could alter the message to include more data at revert() time would that be ok20:37
anishthingee: whoops, not you. sorry20:37
jgriffithanish: I never implemented it but will probably need to20:37
jgriffithanish: we never had a formal deprecation so it probably has to be there20:37
thingeegit-harry: Oh I see, this is cinder to nova. my bad20:38
jgriffithharlowja: you know what would be "smart"....20:38
jgriffithharlowja: so currently if you're a single host, and create fails20:38
jgriffithharlowja: we just keep retrying on that same host20:39
jgriffithharlowja: maybe we should only call self.reschedule_context if you have more than one host20:39
harlowjathat'd safe people some sanity20:39
harlowjalifecycle conductor with all this logic :-P20:39
harlowjaget yer done20:39
jungleboyjsmcginnis: Been working on the issue and now understand it.  The problem is that lazy is getting enabled in test cases and not turned off.  Trying to figure out the right way to fix that.20:40
harlowja is what comes in that 'flow_failure' stuff that gets into task revert methods20:40
jgriffithalright, I'm going to punt on this bug and let somebody like thingee or DuncanT that fully understand taskflow take it20:40
harlowjabut u sorta just want to modify the contained exceptions in that and add a message addition20:40
harlowja*except those are immutable currently, lol20:41
jgriffithharlowja: well that won't work then :)20:41
*** alexpilotti has quit IRC20:41
harlowjaperhaps u could munge with but i'm not sure that would work20:42
harlowja*thats the raw (exc_type, exception, backtrace) tuple20:42
harlowjabut u'd need to modify that [1] member there; and do things to it20:43
anishjgriffith: I was referring to
harlowjawhich might be possible, depending on the type20:43
jgriffithharlowja: yeah but all of this means modifying the lib :(20:43
harlowjajgriffith i don't think so20:43
anishmaybe I am following the code wrong, but looks like all references to ietadm were removed20:43
harlowjalet me see20:43
jgriffithanish: yeah, so was I :)20:43
jgriffithanish: I modified that code and did not implement the iet portion20:43
anishaah good, then I am following it correctly20:43
jgriffithanish: referenced as such in the commit messages somewhere along the way20:44
jgriffithanish: any interest in doing the iet work? :)20:44
thingeejgriffith: yeah that's fine, sorry to hear it's making things difficult for this problem.20:44
jgriffiththingee: what's that?20:44
thingeejgriffith: with regards to you saying punting the bug to DuncanT or I.20:44
jgriffiththingee: oh20:45
jgriffiththingee: ok... sold20:45
anishjgriffith: I have two k2 specs to implement, but sure20:45
thingeejgriffith: I know you have other things on your plate. I'll have to catch up on your convo with harlowja though.20:45
jgriffithanish: I was kinda joking, sounds like you have a full plate right now20:45
jgriffithanish: I'll see if I can gte it coded up this week20:46
jgriffithI think it should be pretty straight forward20:46
anishI was implementing an iscsi helper based on the old iet code, so I'm kinda in the middle of that code anyways :)20:46
anishbut yes, a reference IET implementation would be 100% useful20:46
jgriffithanish: alright, I'll carve out some time for it this week then20:46
anishawesome, thanks20:47
jgriffithanish: sorry I yanked that out from under you20:47
anishno worries ! I started following tgt/lio instead. just a bit more complicated20:47
thingeegit-harry: ok sorry for my mistake. gave it a +120:49
thingeee0ne: thanks, looks like tests pass20:50
thingeeharlowja: I'll ping ya later about what jgriffith was working on.20:50
e0nethingee: np. i'll try to don't be such lazy and file a bugs20:51
harlowjathingee k20:51
*** nellysmitt has quit IRC20:51
harlowjajgriffith ya, to mutate the exception like in this would need to get rid of the immutablity of that object in the failure class20:51
harlowjawhich needs at least20:51
harlowjaso its not impossible20:52
harlowjaand might just be a useful addition20:52
*** nellysmitt has joined #openstack-cinder20:54
thingeee0ne: I'm not sure what you're talking about with regards to bug here20:55
e0nethingee: are you talking about my patch to cinderclient?20:56
*** lpabon has joined #openstack-cinder20:56
thingeee0ne: you keep talking about bugs. I'm not sure what you're talking about20:56
*** _cjones_ has joined #openstack-cinder20:57
e0nethingee: i'm sorry, i confused you. i mean that it would be nice to have a bug fot such patches as my one20:57
jgriffithharlowja: nice20:57
*** david-lyle has joined #openstack-cinder20:57
jgriffithharlowja: for now I'm just doing it another way20:59
jgriffithharlowja: thingee adding an "allocated" column to DB object, and a call out to the driver to check if it was allocated or not20:59
jgriffithharlowja: thingee then check that field on delete... done21:00
*** Guest36580 is now known as mgagne21:04
*** mgagne has joined #openstack-cinder21:04
thingeejgriffith: do you know why project clients in devstack aren't being shown in /opt/stack anymore?21:04
jgriffiththingee: there was a change a while back to add that21:05
e0nethingee: because of it setuped from pypi, not sources21:05
jgriffiththingee: they're now all pip installed21:05
thingeemriedem: ^21:05
jgriffiththingee: LIBS_FROM_GIT=python-cinderclient21:05
thingeemriedem: would it be possible that glance fix is not released?21:05
jgriffithadd that to your local.conf and you're good21:05
e0nei've got the similar problem with clients last week21:06
thingeejgriffith: good to know, thanks21:06
jgriffiththingee: ahhh... nice!!!21:06
mriedemthingee: is there a specific fix on glanceclient? scrollback is failing me21:06
thingeemriedem: I might've misinterpreted what you were saying in #openstack-infra about this being an old issue in glanceclient21:07
mriedemthingee: i know swiftclient had a similar problem21:07
mriedemthingee: i'll try to dig up the bug i know about21:07
thingeemriedem: thanks21:07
mriedemsomething about the move to requests lib and blobs in the request21:07
mriedemkilling the pools and kaboom21:07
mriedemha, top bug
*** bswartz has quit IRC21:08
jgriffithmriedem: thingee which is EXACTLY what's in the cinder logs :)21:09
thingeejgriffith: yup!21:09
mriedemyeah, i mean
mriedem20+K hits in 7 days21:09
mriedemthis isn't old21:09
mriedemif you check the glance logs i think you see the same for swiftclient21:09
harlowjajgriffith should help here21:09
mriedemwhich is this bug
harlowjamake that kind of mutation easier (where its desired to use it)21:10
jgriffithharlowja: looking21:10
jgriffithharlowja: hmm21:11
jgriffithharlowja: what about just raising a taskflow exception?21:11
thingeemriedem: ok thanks for the information21:11
harlowjajgriffith replace it is basically equivalent21:11
jgriffithharlowja: and part of that exception class is "original exception name and message"21:11
jgriffithharlowja: similar to how we do putils exceptions21:12
jgriffithharlowja: and include by default things like tf retry counters etc21:12
jgriffithharlowja: which... is pretty close to what you have anyway I think21:13
jgriffithharlowja: although.....21:13
jgriffithharlowja: hmmm21:13
harlowjawell this would be a task controlled mechanism21:13
jgriffithharlowja: I do kinda like the idea of the replace on revert21:13
*** git-harry has quit IRC21:14
harlowjawell its either that or revert throws a new different exceptoion21:14
harlowjawhich it can21:14
*** git-harry has joined #openstack-cinder21:14
*** bswartz has joined #openstack-cinder21:15
*** e0ne has quit IRC21:15
harlowjaalthough thats sorta more for catastrophic things, ha21:15
*** git-harry has left #openstack-cinder21:15
*** david-lyle has quit IRC21:16
*** david-ly_ has joined #openstack-cinder21:16
harlowjajgriffith replace on revert would basically allow u to shove whatever information u want in to a new exception (that will then bubble up); throwing from revert sorta stops other reverting of predeccessors (so thats not going to end well)21:19
jgriffithharlowja: true21:19
anishnikesh_vedams: you pinged ?21:20
harlowjaso this is more of a useful function for those that really know what they are doing and can safely do it21:20
jgriffithharlowja: which means I'm out :)21:20
nikesh_vedamsanish: hi small doubt,we reviewed your patch,how will it deal with multiple-cards21:22
anishas in multiple transports all connected to the same remote target ?21:23
anishthe current implementation as I have done it does not support multiple cards21:24
*** git-harry has joined #openstack-cinder21:24
anishthe chief reason being with routing information you cannot figure out which transport would connect to which remote target21:25
anishso all you can do is a mix of tcp + iser/hardware21:25
anish*without routing information21:26
jgriffiththingee: if you target this to K2 I'm signed up to do it21:26
anish** tcp + 1 iser/hardware, which is provided by the config file21:26
*** julim_ has quit IRC21:26
*** bswartz has quit IRC21:30
thingeejgriffith: ok. I need to do the LIO portion too21:31
jgriffiththingee: ?21:31
jgriffiththingee: lio is there?21:31
thingeeenable iser with LIO, yea21:31
jgriffiththingee: not following?  Did I miss something?21:31
thingeejgriffith: not sure. I do know that I want to allow enabling iser if LIO is the target helper21:32
*** xyang1 has joined #openstack-cinder21:33
jgriffiththingee: oh, use LIO for iser instead of defaulting to Tgt?21:33
*** akerr has quit IRC21:34
thingeeyeah LIO can enable iser on the network portal. it's a simple bit switch. "simple" :)21:34
*** mriedem has left #openstack-cinder21:34
thingeejgriffith: I started on some clean up work in rtstool to switch to argparser and then I stopped, heh21:34
jgriffiththingee: distractions distractions :)21:35
thingeejgriffith: indeed. makes me wonder what I'm actually getting done21:35
nikesh_vedamsanish: tcp + iser/hardware ?  if CONF.libvirt.iscsi_transport=be2iscsi ,then how can i use tcp transport21:35
anishtransport is not used for discovery21:36
anishif you obtain targets via discovery, then the transport used will be tcp21:36
*** jungleboyj has quit IRC21:37
anishI'm also planning to add a fallback case for login over transport, retry with tcp if login does not succeed21:38
nikesh_vedamsanish: in our case,we have to use both software and hardware transport  and multi-path too21:39
anishyes, I am handling that as well. code is still WIP21:40
*** _cjones_ has quit IRC21:40
nikesh_vedamsanish: if we are using multi-path then it will do discovery with transport i guess21:40
anishhowever, there is no way to do multiple hardware transports21:40
*** david-ly_ has quit IRC21:40
*** david-lyle has joined #openstack-cinder21:41
*** annashen has joined #openstack-cinder21:41
anishI'm not sure about be2iscsi, but bnx2i,cxgbNi,qla4xxx are all iface bound, and iser/tcp are not bound21:42
anishso I will be adding iser to the discovery command in follow up code21:42
anishhowever there is no way to automatically handle multiple hardware transports, unless you have the target explicitly telling you which transport to pick21:43
anishinformation which again cannot automatically computed21:43
*** Mandell has quit IRC21:48
*** david-lyle has quit IRC21:49
*** david-lyle has joined #openstack-cinder21:50
openstackgerritWalter A. Boring IV (hemna) proposed openstack/python-cinderclient: Add volume multi attach support
*** Mandell has joined #openstack-cinder21:58
*** Masahiro has joined #openstack-cinder22:01
*** dustins has quit IRC22:05
*** ebalduf has quit IRC22:05
*** Masahiro has quit IRC22:05
nikesh_vedamsanish: so i think even if we use hardware transport,then multi=path will not work with your patch22:07
nikesh_vedamsonly hardware transport22:07
*** Yogi1 has quit IRC22:08
*** ebalduf has joined #openstack-cinder22:08
nikesh_vedamsanish: am i right22:08
*** bkopilov has quit IRC22:08
anishmulti path will work fine22:09
anishmultipath uses discovery to get targets. discovery does not use transports22:09
*** ebalduf has quit IRC22:10
anishwhat will not work is trying to use multiple transports at once, as there is no way to specify this22:10
*** mriedem has joined #openstack-cinder22:10
anishthough even this you can get around by manually creating nodes with the iface parameter specified22:10
*** _cjones_ has joined #openstack-cinder22:11
*** rushil_ has joined #openstack-cinder22:12
*** Mandell has quit IRC22:12
*** thangp has quit IRC22:12
*** rushil has quit IRC22:14
*** ebalduf has joined #openstack-cinder22:14
*** e0ne has joined #openstack-cinder22:17
*** bkopilov has joined #openstack-cinder22:18
*** lpabon has quit IRC22:19
*** juzuluag has quit IRC22:20
*** jungleboyj has joined #openstack-cinder22:21
nikesh_vedamsanish: ok22:21
harlowjajgriffith soon enough we'll make a TF expert out of u ;)22:22
jgriffithharlowja: haha22:23
*** r-daneel has quit IRC22:23
jungleboyjjgriffith: If you have a chance can you take a look at the results of my investigation here:
harlowjajgriffith why u laughing22:23
jgriffithharlowja: my understanding after the summit is that we already had several22:23
jgriffithharlowja: I'm game, but you're going to have to set aside a couple hours in Vancouver to educate me22:24
anishwhat pray tell is TF ?22:24
jgriffithharlowja: last few days has def helped22:24
harlowjateam fortress22:24
anishup your skills to TF2 at the very least22:24
harlowjai'm game for TF session in vancouver22:27
harlowjato 'educate'22:27
openstackgerritRushil Chugh proposed openstack/cinder: Garbage Remains when Attached Volume is Migrated with NFS Driver
*** nellysmitt has quit IRC22:28
nikesh_vedamsjgriffith:hi our CI is running for more than 1hr,i saw some patched uploaded in this channel but still loop...debug22:32
nikesh_vedamsjgriffith: latest commited22:32
jgriffithnikesh_vedams: well then your listener isn't working it would appear22:33
jgriffithnikesh_vedams: add a logger in on the even listener22:34
jgriffithnikesh_vedams: you have your openstack CI account and ssh keys?22:34
jgriffithnikesh_vedams: write a little test and make sure you're receiving notifications22:34
nikesh_vedamsjust now its worked22:35
jgriffithnikesh_vedams: :)22:35
nikesh_vedamsAdding review id 85856 to job queue... Adding event to queue...22:35
jgriffithnikesh_vedams: note that the version on my github has a filter22:36
jgriffithnikesh_vedams: HOPEFULLY you at least looked at the code before kicking this off22:36
jgriffithnikesh_vedams: it should be VERY OBVIOUS that the filter is set to only pass on events submitted by Jenkins that include a "verified +1"22:36
*** Mandell has joined #openstack-cinder22:37
nikesh_vedamsjgriffith:in which file is that filter22:38
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Add migration tests for PostgreSQL
nikesh_vedamsjgriffith:ERROR: the playbook: ./ansible/sites.yml could not be found ERROR: the playbook: ./ansible/publish.yml could not be found ERROR: the playbook: ./ansible/teardown.yml could not be found Completed VEDAMS SCST CI-dsvm-full22:40
jungleboyje0ne: Do you sleep?22:41
e0nejungleboyj: it's difficult question22:41
e0nejungleboyj: thanks for quick review22:42
jungleboyje0ne: :-)  You are welcome.  Thanks for fixing.22:42
jgriffithhe's views are a bit nikesh_vedams those errors seem pretty clear to me22:44
jgriffithnikesh_vedams: you might have to actually open the code in and editor and try to understand it a bit on your own22:45
openstackgerritThang Pham proposed openstack/cinder: WIP: Snapshot object
*** mriedem has quit IRC22:45
jgriffithnikesh_vedams: you should be able to explain to me how it works22:45
jgriffithnikesh_vedams: it's about as simple as it gets22:45
jgriffithnikesh_vedams: thus the name "sort of simple"22:45
nikesh_vedamsjgriffith:ok actually its 4.15 am for me22:46
nikesh_vedamsyes i will understand it22:46
*** dannywilson has joined #openstack-cinder22:47
*** _cjones_ has quit IRC22:48
*** _cjones_ has joined #openstack-cinder22:48
anishjgriffith: review or a at least a quick set of eyes please :)
*** e0ne has quit IRC22:54
*** kaufer has quit IRC22:54
*** annashen has quit IRC22:55
jgriffithanish: oh... I didn't realize "_get_all_block_devices" returned the full path22:55
*** ryanpetrello_ has joined #openstack-cinder22:56
jgriffithanish: seems pretty solid to me22:57
*** annashen has joined #openstack-cinder22:57
anishawesome !22:57
openstackgerritAaron Rosen proposed openstack/python-cinderclient: Leverage openstack.common.importutils import_class
anishthere is still the issue that nikesh_vedams mentioned, however there is no good way around that as of now22:58
*** ryanpetrello has quit IRC22:59
*** ryanpetrello_ is now known as ryanpetrello22:59
anishviz. for a multipath device you could have ever single path over a different hardware transport, but this cannot be automated in any reasonable way22:59
anishunless I get the target to request a transport22:59
anishwhich I am really not sure is even doable, without extensive knowledge of network topography23:00
*** barra204__ has joined #openstack-cinder23:02
*** barra204_ has quit IRC23:02
*** tbarron has quit IRC23:03
jgriffithif anybody has any silly nits or bike-shedding related requests for
jgriffithplease speak now or forever hold your peace23:08
openstackgerritJohn Griffith proposed openstack/cinder: Implement clone_image caching on SolidFire
smcginnisjgriffith: Looks like jenkins does. :/23:09
*** barra204__ is now known as shakamunyi23:09
jgriffithsmcginnis: yeah, that pep8 :)23:09
jgriffithsmcginnis: stupid "and vs if:if"23:09
jgriffithsmcginnis: but that's fixed :)23:10
jgriffithsmcginnis: FWIW your comments were all valid23:10
smcginnisjgriffith: It's looked good to me. I think you've been nit picked enough for now. :)23:10
jgriffithsmcginnis: gee thanks :)23:11
*** bswartz has joined #openstack-cinder23:13
*** lcurtis has quit IRC23:15
*** david-lyle has quit IRC23:20
*** rlucio has joined #openstack-cinder23:21
mtaninojgriffith: hi, Could you see this bug fix patch for target again?
mtaninojgriffith: Most fixes are done in your patch. This adds some test codes and minor bug fixes.23:27
*** chlong has joined #openstack-cinder23:29
*** fischerw has quit IRC23:29
jgriffithmtanino: for sure... looking now23:30
mtaninojgriffith: Thank you :)23:30
jgriffithmtanino: ha!!!23:31
jgriffithmtanino: test_create_create_export :)23:31
mtaninojgriffith: yes...23:31
jgriffithmtanino: I actually did that on purpose23:31
jgriffithmtanino: although was supposed to be changed before submitting :)23:31
jgriffithmtanino: LGTM thanks!23:32
mtaninojgriffith: Thank you for the quick review.23:34
openstackgerritNagendra Rao Jaladanki proposed openstack/cinder-specs: Spec for Brocade Zone Driver Virtual Fabrics support
*** shakamunyi has quit IRC23:35
tsekiyamajgriffith: Could you review too...? It fixes another issue in TgtAdm that _get_target_chap_auth() is defined but not used.23:37
tsekiyamajgriffith: This make volume boot instances fail to live-migration.23:38
*** kmartin has quit IRC23:38
*** shakamunyi has joined #openstack-cinder23:38
*** jungleboyj has quit IRC23:40
nikesh_vedamsjgriffith:that error fixed23:42
nikesh_vedamsbut again new error Unable to find an inventory file, specify one with -i ?23:42
*** annashen has quit IRC23:44
nikesh_vedamsjgriffith:Unable to find an inventory file, specify one with -i ?23:46
*** annashen has joined #openstack-cinder23:47
*** Masahiro has joined #openstack-cinder23:49
*** mriedem has joined #openstack-cinder23:52
*** Masahiro has quit IRC23:54
*** scottda_ has joined #openstack-cinder23:55

Generated by 2.14.0 by Marius Gedminas - find it at!