Tuesday, 2015-02-10

*** jordandh has quit IRC00:00
*** bswartz has joined #openstack-cinder00:01
*** jordandh has joined #openstack-cinder00:02
*** lcurtis has quit IRC00:02
*** markstur has quit IRC00:05
*** rmesta has quit IRC00:06
*** markvoelker has quit IRC00:07
*** chlong has joined #openstack-cinder00:08
*** fischerw has quit IRC00:09
*** Lee1092 has joined #openstack-cinder00:10
*** r-daneel has quit IRC00:12
*** scottda_ has joined #openstack-cinder00:19
*** Mandell has quit IRC00:27
*** Mandell has joined #openstack-cinder00:32
*** Guest46399 has quit IRC00:47
*** smoriya has joined #openstack-cinder00:48
*** cppforlife_ has joined #openstack-cinder00:49
*** Longgeek has joined #openstack-cinder00:56
*** scottda_ has quit IRC01:01
*** Longgeek has quit IRC01:15
*** annashen has quit IRC01:18
*** jogo has left #openstack-cinder01:20
*** markstur has joined #openstack-cinder01:22
*** Mandell has quit IRC01:22
*** bill_az_ has quit IRC01:48
*** diegows has quit IRC01:53
openstackgerritQiangGuan proposed openstack/cinder: Remove useless storage_availability_zone import  https://review.openstack.org/15393201:55
*** IanGovett has quit IRC01:56
*** lcurtis has joined #openstack-cinder01:57
*** lcurtis has quit IRC02:02
*** rwsu is now known as rwsu-afk02:02
*** casusbel_ has joined #openstack-cinder02:03
*** mberlin1 has joined #openstack-cinder02:04
*** mberlin has quit IRC02:05
*** casusbelli has quit IRC02:06
*** jnrao has quit IRC02:07
*** leeantho has quit IRC02:11
*** Longgeek has joined #openstack-cinder02:12
openstackgerritGloria Gu proposed openstack/cinder: HP 3par driver filter and evaluator function  https://review.openstack.org/15135302:23
openstackgerritharsh mishra proposed openstack/cinder: Fixing cinder-status value when the service is disabled  https://review.openstack.org/15412402:27
*** ebalduf has quit IRC02:28
openstackgerritTina Tang proposed openstack/cinder: Pool-aware scheduler support in EMC VNX Cinder driver  https://review.openstack.org/14740802:35
*** Longgeek has quit IRC02:37
*** annashen has joined #openstack-cinder02:43
openstackgerritharsh mishra proposed openstack/cinder: Fixing cinder-status value when the service is disabled  https://review.openstack.org/15412402:47
*** markvoelker has joined #openstack-cinder02:47
openstackgerritharsh mishra proposed openstack/cinder: Fixing cinder-status value when the service is disabled  https://review.openstack.org/15412402:48
*** vilobhmm has quit IRC02:55
*** Yogi1 has joined #openstack-cinder03:06
*** jungleboyj has joined #openstack-cinder03:08
*** rushiagr_away is now known as rushiagr03:12
*** scottda_ has joined #openstack-cinder03:15
*** boris-42 has quit IRC03:22
*** davechen__ has quit IRC03:28
*** david-lyle is now known as david-lyle_afk03:29
*** DaveChen has joined #openstack-cinder03:29
*** ebalduf has joined #openstack-cinder03:29
*** BharatK has joined #openstack-cinder03:29
*** ebalduf has quit IRC03:33
*** Longgeek has joined #openstack-cinder03:37
*** Tross has joined #openstack-cinder03:42
*** kaufer has joined #openstack-cinder03:50
*** vilobhmm has joined #openstack-cinder04:06
*** mriedem has quit IRC04:07
*** Longgeek has quit IRC04:14
*** annashen has quit IRC04:16
*** mtanino has quit IRC04:23
*** scottda_ has quit IRC04:24
*** timcl has quit IRC04:24
*** annashen has joined #openstack-cinder04:27
*** ebalduf has joined #openstack-cinder04:30
*** jdg is now known as jgriffith04:34
*** harlowja is now known as harlowja_away04:34
*** jgriffith is now known as Guest328204:34
*** ebalduf has quit IRC04:35
*** Guest3282 is now known as jgriffith04:36
openstackgerritJohn Griffith proposed openstack/cinder: Don't fail target_delete if target doesn't exist  https://review.openstack.org/15424904:38
*** pradipta has joined #openstack-cinder04:38
*** tsekiyama has quit IRC04:38
openstackgerritxing-yang proposed openstack/cinder: Mock out the wait routine in the VMAX driver  https://review.openstack.org/15433504:40
*** Yogi1 has quit IRC04:42
*** Novtopro has joined #openstack-cinder04:46
*** bkopilov has joined #openstack-cinder04:46
*** vilobhmm has quit IRC04:49
*** avishay has joined #openstack-cinder04:50
*** coolsvap_ is now known as coolsvap04:52
*** Mandell has joined #openstack-cinder04:57
*** Novtopro has quit IRC05:00
*** casusbel_ has quit IRC05:12
*** annashen has quit IRC05:13
*** annashen has joined #openstack-cinder05:20
*** junhongl has joined #openstack-cinder05:22
*** Ilja has joined #openstack-cinder05:23
*** harlowja_at_home has joined #openstack-cinder05:25
*** enterprisedc has quit IRC05:26
*** enterprisedc has joined #openstack-cinder05:27
*** Ilja has quit IRC05:28
*** anshul has joined #openstack-cinder05:34
*** Xinxiaohui has joined #openstack-cinder05:34
*** BharatK has quit IRC05:41
*** annashen has quit IRC05:42
*** nkrinner has joined #openstack-cinder05:45
*** oomichi has quit IRC05:50
*** harlowja_at_home has quit IRC05:51
*** annashen has joined #openstack-cinder05:52
*** rushiagr is now known as rushiagr_away05:53
*** BharatK has joined #openstack-cinder05:58
*** avishay_ has joined #openstack-cinder06:00
*** avishay has quit IRC06:00
*** harlowja_away has quit IRC06:01
*** annashen has quit IRC06:08
*** annashen has joined #openstack-cinder06:16
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex  https://review.openstack.org/15240106:17
openstackgerritTina Tang proposed openstack/cinder: Attach/detach batch processing in VNX driver  https://review.openstack.org/15435006:19
*** nshaikh has joined #openstack-cinder06:24
openstackgerritTina Tang proposed openstack/cinder: Attach/detach batch processing in VNX driver  https://review.openstack.org/15435006:28
*** kaufer has quit IRC06:30
*** lpetrut has joined #openstack-cinder06:41
*** nshaikh has quit IRC06:41
*** nshaikh has joined #openstack-cinder06:42
openstackgerritxing-yang proposed openstack/cinder: Kilo Consistency Group API update  https://review.openstack.org/14456107:00
openstackgerritxing-yang proposed openstack/cinder: Mock out the wait routine in the VMAX driver  https://review.openstack.org/15433507:01
*** nshaikh has quit IRC07:09
*** Longgeek has joined #openstack-cinder07:15
*** Longgeek has quit IRC07:16
*** nshaikh has joined #openstack-cinder07:18
*** bkopilov has quit IRC07:21
*** Miouge has joined #openstack-cinder07:23
*** TobiasE has joined #openstack-cinder07:29
*** markvoelker has quit IRC07:33
*** markvoelker has joined #openstack-cinder07:34
*** markvoelker has quit IRC07:38
openstackgerritQiangGuan proposed openstack/cinder: Remove useless storage_availability_zone import  https://review.openstack.org/15393207:40
openstackgerritQiangGuan proposed openstack/cinder: Remove useless storage_availability_zone import  https://review.openstack.org/15393207:42
*** kaisers has joined #openstack-cinder07:52
*** chlong has quit IRC07:54
openstackgerritMarc Koderer proposed openstack/cinder: Adapt volume manager to new driver structure  https://review.openstack.org/13899907:58
openstackgerritMarc Koderer proposed openstack/cinder: Split volume driver into ABC classes  https://review.openstack.org/12745507:58
openstackgerritNilesh Bhosale proposed openstack/cinder: IBM GPFS Consistency Group Implementation  https://review.openstack.org/14398708:00
openstackgerritQiangGuan proposed openstack/cinder: Remove useless storage_availability_zone import  https://review.openstack.org/15393208:03
*** fifieldt has joined #openstack-cinder08:03
*** markvoelker has joined #openstack-cinder08:04
*** annashen has quit IRC08:06
*** aix has joined #openstack-cinder08:07
*** annashen has joined #openstack-cinder08:07
*** markvoelker has quit IRC08:09
*** Raj_ has joined #openstack-cinder08:10
*** Longgeek has joined #openstack-cinder08:14
*** karimb has joined #openstack-cinder08:15
*** ndipanov has joined #openstack-cinder08:15
*** avishay_ has quit IRC08:15
*** annashen has quit IRC08:19
*** oomichi_ has joined #openstack-cinder08:23
*** avishay_ has joined #openstack-cinder08:24
*** avishay_ has quit IRC08:30
openstackgerritTobias Engelbert proposed openstack/python-cinderclient: Recall mechanism for terminate/initialize  https://review.openstack.org/15437608:32
openstackgerritTobias Engelbert proposed openstack/cinder: Recall mechanism for terminate/initialize  https://review.openstack.org/15437708:32
*** Mandell has quit IRC08:34
*** pwehrle has joined #openstack-cinder08:34
*** ronis has joined #openstack-cinder08:35
*** jordanP has joined #openstack-cinder08:36
openstackgerritTobias Engelbert proposed openstack/cinder: Recall mechanism for terminate/initialize  https://review.openstack.org/15437708:39
*** e0ne has joined #openstack-cinder08:43
*** avishay_ has joined #openstack-cinder08:46
*** jistr has joined #openstack-cinder08:47
*** afazekas has joined #openstack-cinder08:52
*** alecv has joined #openstack-cinder08:55
*** ronis has quit IRC08:55
*** ronis has joined #openstack-cinder08:55
*** Xinxiaohui has quit IRC08:57
*** TobiasE1 has joined #openstack-cinder08:59
*** TobiasE has quit IRC08:59
*** jpich has joined #openstack-cinder09:02
*** markvoelker has joined #openstack-cinder09:05
*** lpetrut has quit IRC09:07
*** lpetrut has joined #openstack-cinder09:08
*** nellysmitt has joined #openstack-cinder09:10
*** pradipta has quit IRC09:10
*** markvoelker has quit IRC09:10
openstackgerritPh. Marek proposed openstack/cinder: DRBD: Use correct function object after DBus disconnect.  https://review.openstack.org/15074009:12
*** anshul has quit IRC09:17
*** anshul has joined #openstack-cinder09:17
*** smoriya has quit IRC09:20
*** e0ne is now known as e0ne_09:24
*** e0ne_ has quit IRC09:35
*** sgotliv has joined #openstack-cinder09:37
*** vnagpal has joined #openstack-cinder09:39
*** Ilja has joined #openstack-cinder09:46
*** bkopilov has joined #openstack-cinder09:47
*** nlevinki has joined #openstack-cinder09:50
*** e0ne has joined #openstack-cinder09:52
*** lpetrut has joined #openstack-cinder09:55
*** markvoelker has joined #openstack-cinder10:06
mkodererDuncanT: hi there, I split the ABC patch into two.. this is the fist one: https://review.openstack.org/#/c/127455/10:10
mkodererjohn asked me to do that.. hope it makes the review easier10:10
*** markvoelker has quit IRC10:11
*** anshul has quit IRC10:11
*** anshul has joined #openstack-cinder10:12
DuncanTSorry, I thought I'd +2d the first one earlier, done now10:12
DuncanTI"ll get to the second one after lunch, but it looks fine at a glance10:13
*** primechuck has joined #openstack-cinder10:15
mkodererDuncanT: cool thx :)10:24
*** boris-42 has joined #openstack-cinder10:29
*** Longgeek has quit IRC10:37
*** primechuck has quit IRC10:42
*** Longgeek has joined #openstack-cinder10:45
*** rmstar_ has quit IRC10:50
*** dulek has joined #openstack-cinder10:56
*** sgotliv has quit IRC10:59
*** oomichi_ has left #openstack-cinder11:07
*** markvoelker has joined #openstack-cinder11:07
*** haomaiwang has quit IRC11:11
*** vnagpal has quit IRC11:11
*** vnagpal has joined #openstack-cinder11:12
*** markvoelker has quit IRC11:12
*** lpetrut has quit IRC11:13
*** lpetrut has joined #openstack-cinder11:18
*** EmilienM|afk is now known as EmilienM11:21
openstackgerritKallebe Monteiro proposed openstack/python-cinderclient: Fix volume_transfers import in v2  https://review.openstack.org/15410511:25
*** diegows has joined #openstack-cinder11:26
*** aix has quit IRC11:26
*** diegows has quit IRC11:32
*** aviramb has quit IRC11:36
*** Ilja has quit IRC11:37
*** Ilja has joined #openstack-cinder11:37
openstackgerritTobias Engelbert proposed openstack/cinder: Recall mechanism for terminate/initialize  https://review.openstack.org/15437711:47
*** tbarron has joined #openstack-cinder11:56
*** rushiagr_away is now known as rushiagr11:56
*** ronis has quit IRC11:59
*** chlong has joined #openstack-cinder12:00
*** anshul has quit IRC12:07
*** anshul has joined #openstack-cinder12:07
*** e0ne is now known as e0ne_12:08
*** markvoelker has joined #openstack-cinder12:08
*** Raj_ has quit IRC12:08
*** aix has joined #openstack-cinder12:11
*** markvoelker has quit IRC12:13
*** Longgeek has quit IRC12:13
*** e0ne_ has quit IRC12:18
*** aix has quit IRC12:20
*** changbl has quit IRC12:29
*** timcl has joined #openstack-cinder12:30
*** karimb is now known as karimb|lunch12:32
*** Miouge has quit IRC12:32
*** Miouge has joined #openstack-cinder12:33
*** Mandell has joined #openstack-cinder12:34
*** Mandell has quit IRC12:39
*** sgotliv has joined #openstack-cinder12:41
*** sgotliv has quit IRC12:43
*** sgotliv has joined #openstack-cinder12:44
*** IanGovett has joined #openstack-cinder12:46
erlonDuncanT: ping12:56
*** takedakn has joined #openstack-cinder12:57
openstackgerritErlon R. Cruz proposed openstack/cinder: Adds pool aware scheduling for HNAS drivers  https://review.openstack.org/14213312:58
openstackgerritErlon R. Cruz proposed openstack/cinder: Adds SSH communication to HNAS drivers  https://review.openstack.org/14290412:58
openstackgerritErlon R. Cruz proposed openstack/cinder: Fix HNAS driver parsing errors  https://review.openstack.org/14186812:58
*** takedakn has quit IRC12:59
*** takedakn has joined #openstack-cinder12:59
*** tshefi has joined #openstack-cinder13:02
*** markvoelker has joined #openstack-cinder13:05
*** avishay__ has joined #openstack-cinder13:06
*** avishay_ has quit IRC13:06
*** avishay__ is now known as avishay13:08
*** ronis has joined #openstack-cinder13:13
*** Yogi1 has joined #openstack-cinder13:16
*** rmstar has joined #openstack-cinder13:18
*** BharatK has quit IRC13:20
*** Yogi1 has quit IRC13:21
*** Ilja has quit IRC13:22
*** bswartz has quit IRC13:22
*** e0ne has joined #openstack-cinder13:25
*** karimb|lunch is now known as karim13:39
*** karim is now known as Guest2480913:39
*** Miouge has quit IRC13:40
DuncanTerlon: Hi13:42
*** akerr has joined #openstack-cinder13:47
*** nshaikh has left #openstack-cinder13:54
*** rushiagr is now known as rushiagr_away13:54
dulekGuys, is it possible to inject ipdb to cinder unit tests?13:54
erlonhi, Im noticing there's a lot of reviews only dealing with LOG formatting '%' vs ','  etc, is there any interest in automating this so run_tests -p also check the formating guidelines??13:55
erlonDuncanT: ^ http://docs.openstack.org/developer/oslo.i18n/guidelines.html13:55
DuncanTerlon: Adding something to hacking would be fantastic!13:56
smcginniserlon: I thought about doing that, but there are so many exceptions and format variations.13:56
e0neerlon: we are talking about such check for a while13:56
erlonDuncanT: e0ne: but is run_check -p (PEP) the right place? this is not a PEP rule13:57
DuncanTerlon: I tried to write something that did arg check counting for LOG.foo lines, like python does already for %, but it turned out to be none-trivial13:57
erlonDuncanT: hmm13:57
DuncanTerlon: We have the hacking checks already that enforce style guidelines that are not from PEPs13:57
e0neerlon, DuncanT: 'run_tests.sh -p' runs checks for pep8, pylint and hacking rules13:58
*** emagana has joined #openstack-cinder13:58
DuncanTerlon: Just a simple check for % inside LOG calls would catch a bunch of the things that keep coming up13:58
*** bill_az_ has joined #openstack-cinder13:58
DuncanTerlon: And checking for fixed strings that are untraslated / only translated with _() inside LOG.{warning|info|error} would catch a bunch more13:59
*** xyang has joined #openstack-cinder13:59
erlonDuncanT: mhm, Ill try to dig that and see what exceptions I find13:59
*** Yogi1 has joined #openstack-cinder13:59
DuncanTerlon: If you can get something that works, I think it would definitely be a help14:00
erlonDuncanT: nice14:00
smcginniserlon, DuncanT: Part of the challenge would be being able to detect something like line 256 here:14:01
xyangsmcginnis: yes. the message is used by the caller14:02
*** fifieldt has quit IRC14:02
smcginnisxyang: That's why I think it's pretty much impossible to implement a hacking check for logging.14:02
erlonsmcginnis: hmmm, hard to guess those kind of situations14:03
xyangsmcginnis: even if the same error msg is used by an exception, it is hard to detect as well14:03
smcginniserlon: It might be worth doing one locally and getting a full list that could be manually reviewed and cleaned up.14:04
erlonsmcginnis: any other exception cases I should think about?14:04
smcginniserlon: I just don't think we can make it a standard hacking check.14:04
xyangthe usage  of "%" vs "," is also not easy to differentiate14:05
smcginniserlon: xyang's was the only specific one that came to mind, but I'm sure there's more. :)14:05
smcginnisxyang: So true.14:05
erlonsmcginnis: is it possible to create a 'warning' checher?14:05
smcginnisEven in reviews folks have been leaving conflicting comments.14:05
erlonthat wouldn't vote -1?14:05
smcginniserlon: Cool, if it's just some kind of warning that can be addressed and cleaned up with possible, I'm all for that.14:06
*** tbarron has quit IRC14:06
*** annegentle has joined #openstack-cinder14:06
*** bswartz has joined #openstack-cinder14:06
openstackgerritSasikanth Eda proposed openstack/cinder: Volume Replication support - GPFS Synchronous mirroring  https://review.openstack.org/15391814:07
*** david-lyle_afk is now known as david-lyle14:07
*** Ilja has joined #openstack-cinder14:08
*** primechuck has joined #openstack-cinder14:08
erlonsmcginnis: like the oslo.middleware deprecation warning that is appearing in thoses last weeks14:09
smcginniserlon: My one concern with that is there are cases like the patch I mentioned where it will generate a warning even though it is legitimate. We will be stuck with this warning unless we do something to either flag it as OK in the code or change it so it no longer gets detected as non-compliant.14:10
smcginniserlon: Maybe that's not really an issue though. Just a concern of mine.14:11
*** xyang has quit IRC14:12
nikesh_vedams_smcginnis: hi14:14
*** jasondot_ has joined #openstack-cinder14:14
nikesh_vedams_smcginnis: address your comments on https://review.openstack.org/#/c/145778/14:15
smcginnisnikesh_vedams_: On my list to get to. Might be a little while. Trying to catch up from two back to back weeks of travel.14:15
*** kaufer has joined #openstack-cinder14:16
nikesh_vedams_smcginnis: ok :)14:16
*** xyang has joined #openstack-cinder14:19
xyangDuncanT: can you please review the modify CG patch when you get a chance? https://review.openstack.org/#/c/144561/14:20
*** Miouge has joined #openstack-cinder14:20
*** dustins has joined #openstack-cinder14:21
xyange0ne: This one fixed the hang problem you ran into. give a try: https://review.openstack.org/#/c/154335/14:24
e0nexyang: thanks! i've just cheched out it and verifing14:24
xyange0ne: ok, let me know if it works14:25
e0nexyang: sure, i'll do14:25
*** mriedem has joined #openstack-cinder14:25
e0nexyang: looks like it's working for me:). how did you debug it? i failed with it, adding logs didn't help me14:27
xyange0n0: my coworker nailed it down. we know it must be one of those wait routines.  so just tried to mock out all places where wait routine is used, mainly wait for job complete and wait for sync.  lots of trial and error, because you can only repro with all tests running14:30
*** takedakn has quit IRC14:31
*** jungleboyj has quit IRC14:31
xyange0ne: no problem. maybe now you can use your +2 power to help get it merged:)14:32
e0nexyang: :). it is ok to +2 depended patch when parent it not reviewed?14:33
xyange0ne: yes, it is14:33
e0nei didn't take a look on a parent yet14:33
*** Ilja has quit IRC14:33
xyange0ne: no problem.14:33
xyange0ne: but it won't be merged until parent is merged14:34
e0nethat's why i'm asking about +2 on a child14:34
xyange0ne: you can +2 on a child without reviewing the parent.14:35
xyange0ne: it will just sit there14:35
xyange0ne: actually I saw your name as reviewer on the parent as well.  Seems that you've looked at it at some point14:35
xyange0ne: thanks14:36
e0nexyang: thanks for fix it!14:37
e0nebtw, could you take a look on https://review.openstack.org/#/c/132648/, please? it hase more than 10 +1:)14:37
xyange0ne: sure:)14:37
*** Mandell has joined #openstack-cinder14:38
*** juzuluag has joined #openstack-cinder14:38
DuncanTe0ne: I meant to ask you about that patch actually... it has zero info on what it is doing or why14:39
*** rushiagr_away is now known as rushiagr14:40
xyange0ne: I don't understand it either.  Just started reading...14:41
e0neDuncanT: it removes unused code. i forgot to remove it while migration to oslo.db tools14:42
xyange0ne: no bug number either14:42
DuncanTAh, can you add that and a bug number to the commit message please?14:42
xyangthat will be helpful.14:42
e0neDuncanT: sure, i'll file a bug first14:42
DuncanTe0ne: :-)14:43
DuncanTe0ne: I'm happy to +2 once that is done14:44
xyange0ne: me too. your explanation helps14:44
xyangDuncanT: about incremental backup, I think the parent_id option is still useful14:47
*** aix has joined #openstack-cinder14:48
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Remove custom lazy loading  https://review.openstack.org/13264814:48
DuncanTxyang: While it has uses, is it worth more than the confusion it causes? The last backup taken is just about always the right one to chose14:48
xyangDuncanT: if a volume has 10 full backups and incremental backups on 3 of them, it is hard to choose14:48
xyangDuncanT: I'm not sure if user will always just want the last one14:49
e0nepersonaly, i hate bugs wich takes more time to file it instead of fixing14:49
xyangDuncanT: I can keep the parent_id option, make it optional, but choose the latest backup if parent id not provided?14:49
DuncanTxyang: Under what circumstances is the correct one to choose anything other than the latest one?14:50
xyangDuncanT: I'm just thinking user may want to choose an earlier backup as the base14:50
DuncanTe0ne: Agreed, but we need to keep a minimum level of admin going or history has shown we end up with a mess (quite often a political one at that)14:51
DuncanTxyang: Why would they want to do that? That is what I don't understand14:51
DuncanTxyang: Generally that just means they'll have a bigger set of diffs to backup14:51
xyangDuncanT: if the data on the later one is corrupted?14:52
DuncanTxyang: The backup itself is corrupted? They should do a full backup!14:52
e0neDuncanT: sure. i can say about all project, but while Diablo and Essex development cycles, nova and hodizon(openstack-dashboard) didn't approve patches w/o links to launchpad issues or blueprints14:53
DuncanTxyang: If the contents of volume got corrupted in a previous backup? That is a sufficiently small corner case that the interface complexity of having the option isn't worth it IMO14:54
*** nkrinner has quit IRC14:54
xyangDuncanT: ok, if you don't see a user case for that, I'll just always pick the latest one.14:54
DuncanTe0ne: We should probably look at doing that, particularly later in the cycle14:54
xyangDuncanT: if there are two backups with identical timestamp, I'll just pick any one of them.  sounds good?14:54
DuncanTxyang: Sure, it shouldn't matter14:55
xyangDuncanT: the data could be a little different because one may start a little later but finished quicker14:55
DuncanTxyang: Sure, but that be a tiny difference, and again is really a corner case14:56
xyangDuncanT: sure14:56
mkodererDuncanT: xyang: folks, are you seeing any reason to have pyxattr in cinders requirements.txt?14:57
*** jcru has joined #openstack-cinder14:57
mkodererIt was introduced by https://review.openstack.org/#/c/94186/15 ..14:57
mkodererthe nova ppl rejected that and it was rewritten to use the xattr cli commands for nova volume14:58
DuncanTmkoderer: It looks like that driver imports xattr?14:58
mkodererDuncanT: yeah... but "why"... IMHO the code looks ugly14:58
mkodererDuncanT: so just because one driver need it we put it in global requirements.txt?14:59
DuncanTmkoderer: Ah, I see. I can't say I've looked. Can we ping the maintainer and ask about cleaning it up, see how much effort hey think it would be?14:59
mkodererDuncanT: they already have the code in nova15:00
DuncanTmkoderer: That is the way global requirements work, generally. It is that or a conditional import.15:00
*** r-daneel has joined #openstack-cinder15:00
mkodererDuncanT: ok we will propose a better solution and talk the the driver maintainer15:01
mkodererDuncanT: how do I know who the driver maintainer btw? git blame? ;)15:01
DuncanTmkoderer: Sounds like a good first plan15:01
mkodererdalgaaf: ^^15:02
*** e0ne is now known as e0ne_15:02
*** nikesh_vedams_ has quit IRC15:02
DuncanTmkoderer: Git blame is the most reliable at the moment. I tried to get a maintainers list in the source tree, but it has fallen by the wayside at the moment, until I'm less tied up iwith HP stuff15:02
mkodererDuncanT: are you going to throw out drivers that don't have a maintainer?15:03
DuncanTmkoderer: If they have a third party CI and meet the minimum specs, they probably have somebody who can act as maintainer15:04
DuncanTmkoderer: If they don't have / get 3rd party CI in time, then the plan is to remove them15:04
mkodererDuncanT: yeah +1 ... I see 3rd vendor test as a mandatory barrier for drivers15:05
DuncanTmkoderer: We've made that very clear as a cinder requirement... and the cutoff date is not far away15:05
DuncanTmkoderer: Mike is now doing the comms for that15:06
*** e0ne_ is now known as e0ne15:07
*** emagana has quit IRC15:09
*** tbarron has joined #openstack-cinder15:09
*** emagana has joined #openstack-cinder15:09
e0neDuncanT: according to https://bugs.launchpad.net/cinder/+bug/1409012. looks like we need to get changes in oslo.messaging or implement such behavior as in nove-scheduler to get it works well15:11
openstackLaunchpad bug 1409012 in Cinder "Volume becomes in 'error' state after scheduler starts" [High,In progress] - Assigned to Ivan Kolodyazhny (e0ne)15:11
*** jungleboyj has joined #openstack-cinder15:12
mkodererjgriffith: hey, btw I rebased the ABC patches https://review.openstack.org/#/c/127455/ https://review.openstack.org/#/c/138999/15:12
*** Longgeek has joined #openstack-cinder15:14
*** emagana has quit IRC15:15
*** Mandell has quit IRC15:15
*** Longgeek has quit IRC15:16
*** thangp has joined #openstack-cinder15:16
*** ebalduf has joined #openstack-cinder15:16
*** coolsvap is now known as coolsvap_15:17
*** fischerw has joined #openstack-cinder15:18
*** cnesa has joined #openstack-cinder15:18
*** ebalduf has quit IRC15:21
jgriffithmkoderer: cool15:23
jgriffithchecking it out15:23
*** ebalduf has joined #openstack-cinder15:24
*** thingee has joined #openstack-cinder15:27
*** ebalduf has quit IRC15:28
*** nlevinki has quit IRC15:30
erlonxyang: hi Xyang, you talked about the dependencies on your change (145952 -> 144561), are you working with then in the same local branch?15:32
*** ebalduf has joined #openstack-cinder15:33
*** Yogi11 has joined #openstack-cinder15:34
*** dustins_ has joined #openstack-cinder15:34
*** avishay has quit IRC15:34
erlonxyang:  Im having a problem with that. When I rebase on upstream/master, all patches(changes) on my local branch are updated and trigger a new patchset on gerrit, even if I only change one. does that happent with you??15:35
*** TobiasE1 has quit IRC15:36
*** avishay has joined #openstack-cinder15:36
*** dustins has quit IRC15:37
*** Yogi1 has quit IRC15:37
xyangerlon: yes, it happened to me. you need to do git review -R15:37
erlonxyang: hmm nice, Ill check that15:38
*** thingee has quit IRC15:39
*** TobiasE has joined #openstack-cinder15:44
*** nlevinki has joined #openstack-cinder15:45
*** aviramb has joined #openstack-cinder15:45
erlonxyang: hmm, so basically you do not rebase on gerrit/master. my branch was not automatically rebasing. I usually rebase manually to avoid conflicts15:45
erlonavishay: winston-d : guys, can you revisit this when you have a change? It is blocking 2 changes of HNAS drivers and haven't the comments was addressed quite a while ago15:46
erlonavishay: winston-d: https://review.openstack.org/#/c/141868/15:47
hemnagit pull origin hampster15:47
hemnanot quite the same as master15:47
jgriffithhemna: you should make an alias :)15:50
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: Add volume multi attach support  https://review.openstack.org/8584715:50
openstackgerrithadi esiely proposed openstack/cinder: blueprint volume-encryption-metadata  https://review.openstack.org/15453815:52
*** rwsu-afk is now known as rwsu15:52
*** avishay has quit IRC15:54
*** cnesa has quit IRC15:55
*** kaufer has quit IRC15:57
*** rmesta has joined #openstack-cinder15:57
*** avishay has joined #openstack-cinder15:58
*** jaypipes has quit IRC16:01
*** rajinir_r has quit IRC16:01
*** rajinir_r has joined #openstack-cinder16:02
hemnaTobiasE, ping16:02
*** tbarron has quit IRC16:02
*** rhagarty has quit IRC16:03
*** rhagarty has joined #openstack-cinder16:03
*** tbarron has joined #openstack-cinder16:03
*** tsekiyama has joined #openstack-cinder16:04
*** annashen has joined #openstack-cinder16:04
*** mtanino has joined #openstack-cinder16:04
*** nikesh_vedams has joined #openstack-cinder16:06
*** Mandell has joined #openstack-cinder16:06
openstackgerritDanny Al-Gaaf proposed openstack/cinder: quobyte: remove dependency to xattr  https://review.openstack.org/15454316:08
openstackgerrithadi esiely proposed openstack/cinder: Store volume encryption metadata on each volume  https://review.openstack.org/15228416:08
*** Mandell has quit IRC16:10
*** ndipanov has quit IRC16:10
*** pwehrle has quit IRC16:10
*** jkraj has joined #openstack-cinder16:11
DuncanTmkoderer: I see there's a patch in to get rid of the xattr library usage. Can I ask what your basic objection is to adding a/the dependency is, please? In general I think it is always better to use a well designed library than a shell call16:13
*** Miouge has quit IRC16:14
*** dustins_ has quit IRC16:15
openstackgerrithadi esiely proposed openstack/cinder: Store volume encryption metadata on each volume  https://review.openstack.org/15228416:16
*** Miouge has joined #openstack-cinder16:17
*** annashen has quit IRC16:18
nikesh_vedamsthingee : there ?16:22
*** Yogi11 has quit IRC16:22
*** Miouge has quit IRC16:24
*** kaufer has joined #openstack-cinder16:25
*** ollie1 has quit IRC16:25
*** Miouge has joined #openstack-cinder16:25
*** ebalduf has quit IRC16:27
*** Yogi11 has joined #openstack-cinder16:29
*** chlong has quit IRC16:30
*** jdurgin1 has joined #openstack-cinder16:30
*** ebalduf has joined #openstack-cinder16:35
*** e0ne is now known as e0ne_16:36
*** e0ne_ is now known as e0ne16:39
*** nlevinki has quit IRC16:40
*** bkopilov has quit IRC16:41
e0nehemna: hi16:42
*** lpetrut has quit IRC16:42
e0nehemna: i filed blueprint for https://review.openstack.org/#/c/144739/. looks too late for Kilo. we'll we target bug #1111839 to L too?16:43
openstackbug 1111839 in Cinder "Volume API response should list dependent snapshots" [Medium,In progress] https://launchpad.net/bugs/1111839 - Assigned to Ivan Kolodyazhny (e0ne)16:43
hemnae0ne, I don't see a BP for that review16:48
hemnae0ne, it's not in the commit message FWIW16:48
*** rhagarty has quit IRC16:49
e0nehemna: because it's not implemented yet:(16:49
* hemna is confused16:49
e0nehemna: proposed solution is to add 'child_snapshots' to volume view. it does'nt include '--detiails' param. i just want to clarify on which release this bug and blueprint (https://blueprints.launchpad.net/cinder/+spec/volume-details-views) should be landed16:51
*** Guest24809 has quit IRC16:52
avishayi don't understand why that's a bug - it's a feature request16:52
e0neavishay: agree with you16:52
jgriffithavishay: +116:52
hemnayah that seems like a new feature16:53
hemnanot a bug16:53
e0neok.. if everybody agree with it, lets close bug and i'll continue to work on it in scope of a new bp16:53
*** bswartz has quit IRC16:53
jgriffithe0ne: sounds right to me16:54
hemnae0ne, and since this is a new cinder feature, it needs a spec16:55
e0nehemna: sure. does it have a change to be landed in K?16:55
jgriffithjungleboyj: another one https://bugs.launchpad.net/cinder/+bug/142033516:55
openstackLaunchpad bug 1420335 in Cinder "cinder is testing with non-namespaced oslo_i18n in Juno" [Undecided,New]16:55
hemnae0ne, the deadline for BP's is Feb 15th.16:56
jungleboyjjgriffith: Thanks.  I know Jim is chasing that this morning.16:56
e0nethanks. i'll try to implement it for K16:56
*** afazekas has quit IRC16:56
*** coolsvap_ is now known as coolsvap16:56
e0newhat is the valid status for bug whis moved to blueprints?16:57
*** leeantho has joined #openstack-cinder16:59
jgriffithe0ne: I'd just mark it as invalid and comment that you moved it to a BP (reference the BP)16:59
avishaye0ne: imporance->wishlist, status->invalid IMO16:59
jgriffithavishay: :)16:59
avishayjgriffith: who asked you?16:59
jgriffithavishay: eat me17:00
avishayjgriffith: :)17:00
e0nejgriffith, avishay: thanks for help:). i'll do it later today. need to go offline for a while17:00
avishayi'm off, later all17:00
*** avishay has quit IRC17:00
*** sgotliv has quit IRC17:00
*** bswartz has joined #openstack-cinder17:01
*** sgotliv has joined #openstack-cinder17:01
jgriffithaviramb: night17:01
jgriffithoops... avishay17:01
jgriffithhemna: ok... time for me to look at and test multi-attach17:02
*** e0ne has quit IRC17:06
*** jistr has quit IRC17:07
*** dustins has joined #openstack-cinder17:15
*** jkraj has quit IRC17:15
*** p01s0n has joined #openstack-cinder17:16
jgriffithmtanino: ping17:22
*** jpich has quit IRC17:22
*** coolsvap is now known as coolsvap_17:23
hemnatesting out the ABC patch17:25
*** bswartz has quit IRC17:25
*** anshul has quit IRC17:27
mtaninojgriffith: pong17:28
*** jordanP has quit IRC17:28
jgriffithmtanino: just wanted to apologize for not getting back to you17:28
mtaninojgriffith: oh!! you gave me +2?17:28
jgriffithmtanino: and let you know that the refactor patch looked really good to me17:28
mtaninojgriffith: no problem17:28
jgriffithmtanino: LOL.. yes!17:28
jgriffithmtanino: I realized there is no breaking that up :)17:29
mtaninojgriffith: I think Duncan-T is intrested in this patch, so I will wait his review.17:29
mtaninojgriffith: anyway, thank you for the rewview.17:30
jgriffithmtanino: sounds like he wants to comb through it more closely17:30
jgriffithmtanino: you're welcome, thanks for working on it17:30
jgriffithmtanino: it's def an improvement17:30
mtaninojgriffith: :)17:30
*** jasondot_ has quit IRC17:31
jgriffithhemna: is there any chance that the Nova side of this is going to make it?17:31
hemnajgriffith, jaypipes was working on it17:32
hemnajgriffith, I asked him to get an extension for nova, but hadn't heard back from him yet on it.17:32
*** annegentle has quit IRC17:32
jgriffithhemna: what about the CI failures?17:33
hemnahe's supposed to be working on the tempest tests17:33
jgriffithhemna: no, what I mean is it *breaks* the tests that are there17:33
jgriffithhemna: or are those a *blip*17:33
jgriffithhemna: lemme look closer17:33
openstackgerritThang Pham proposed openstack/cinder-specs: VMware: adapter_type volume type extra spec  https://review.openstack.org/12938917:33
hemnalast I saw, Tobias had the unit tests working, and then it looks like jaypipes took it over17:33
jgriffithhemna: yeah, they break17:33
hemnato work on the nova tempest tests17:33
hemnaand then it broke17:34
jgriffithhemna: indeed17:34
hemnaso I'm waiting to hear from jaypipes about it, but I don't see him online17:34
jgriffithhemna: I would think this could/should be done without breaking compatability?17:34
hemnathe cinder side changes shouldn't break compatibility17:34
jgriffithhemna: haha17:35
hemnaas I made sure the attachment_id on detach is optional17:35
jgriffithhemna: yeah17:35
hemnaand the attachments list in the volume object are the same17:35
jgriffithhemna: but it doesn't do us any good if it breaks Nova17:35
jgriffithhemna: and never merges there :(17:35
hemnaso I'm not sure why the nova side is borked honestly17:35
jgriffithhemna: yeah, I'm looking now17:35
hemnaif you look at my cinder patch, all of the tempest tests work17:36
hemnawhich include nova17:36
hemnaso I think the nova failures are due to changes on their patches17:36
jgriffithhemna: ummmm17:37
jgriffithhemna: http://logs.openstack.org/14/143114/26/check/check-tempest-dsvm-full/27cd93b/logs/screen-n-api.txt.gz#_2015-02-02_19_39_25_40217:37
jgriffithhemna: so wait... you're not working on the Nova patch now?17:37
jgriffithhemna: sorry, maybe I'm confused17:38
hemnaI haven't worked on the nova side for this attempt17:38
hemnaTobias and Jaypipes17:38
jgriffithok, sorry to bug you on that17:38
jgriffithdidn't notice17:38
jgriffithI remember you started it though17:38
hemnaI bet you that error is happening, because that patch hasn't pulled the outstanding cinder patch17:39
hemnawhich has the multiattach attribute in it17:39
*** anshul has joined #openstack-cinder17:39
hemnacinder master doesn't17:39
*** lpetrut has joined #openstack-cinder17:39
hemnaand hence the failure17:39
jgriffithhemna: no, it's the code itself it looks like17:39
hemnavol.multiattach doesn't exist in cinder master17:39
jgriffithhemna: and besides, it should be able to still maintain back compat here IMO17:39
hemnaso that's a failure on their part17:40
hemnato be careful about accessing vol.multiattach17:40
guitarzanchickens and eggs17:40
*** emagana has joined #openstack-cinder17:40
jgriffithhemna: FYI17:41
jgriffithyou need to update your commit message17:41
jgriffithhemna: that patch has split17:41
jgriffithhemna: it's now https://review.openstack.org/#/c/153033/17:41
hemnaoh, to include both urls ?17:41
jgriffithhemna: and https://review.openstack.org/#/c/153038/17:41
hemnaok will do17:41
*** emagana_ has joined #openstack-cinder17:41
jgriffithhemna: well the one you reference is no longer valid it appears17:41
*** bswartz has joined #openstack-cinder17:42
*** TobiasE has quit IRC17:42
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: Add volume multi attach support  https://review.openstack.org/8584717:42
*** emagana has quit IRC17:45
*** aix has quit IRC17:47
nikesh_vedamsjgriffith: morning17:48
*** lcurtis has joined #openstack-cinder17:49
*** annashen has joined #openstack-cinder17:49
*** e0ne has joined #openstack-cinder17:51
nikesh_vedamsjgriffith: your concern is valid but we are consistently active on any reviews given to us and addressed them all till now and we have addressed reviews like db concern etc17:51
*** Mandell has joined #openstack-cinder17:51
*** rhagarty has joined #openstack-cinder17:53
nikesh_vedamsjgriffith: so please help us in making this patch for kilo :)17:53
openstackgerritGloria Gu proposed openstack/cinder: HP 3par driver filter and evaluator function  https://review.openstack.org/15135317:56
nikesh_vedamsjgriffith: we will addressed any new concerns if you have and will not disturb anything in master17:56
nikesh_vedamsjgriffith: just now saw your comment thanks17:57
nikesh_vedamssorry for flooding the channel17:57
jgriffithnikesh_vedams: understood17:57
jgriffithnikesh_vedams: yeah, I think we all agree you've been responsive and started early17:58
jgriffithnikesh_vedams: I'm willing to try and help get this merged for Kilo17:58
*** changbl has joined #openstack-cinder17:58
*** ebalduf has quit IRC18:01
*** dannywilson has joined #openstack-cinder18:01
*** dannywilson has quit IRC18:02
*** dannywilson has joined #openstack-cinder18:02
*** Ilja has joined #openstack-cinder18:02
*** ebalduf has joined #openstack-cinder18:03
*** patrickeast has joined #openstack-cinder18:06
*** sgotliv has quit IRC18:06
nikesh_vedamsjgriffith: thanks john18:06
*** Yogi11 has quit IRC18:07
*** ebalduf has quit IRC18:08
*** nellysmitt has quit IRC18:09
*** harlowja has joined #openstack-cinder18:10
openstackgerritDanny Al-Gaaf proposed openstack/cinder: quobyte: remove dependency to xattr  https://review.openstack.org/15454318:14
*** jaypipes has joined #openstack-cinder18:15
*** vnagpal has quit IRC18:15
openstackgerritDanny Al-Gaaf proposed openstack/cinder: quobyte: remove dependency to xattr  https://review.openstack.org/15454318:15
*** ebalduf has joined #openstack-cinder18:16
*** diegows has joined #openstack-cinder18:16
*** dalgaaf has quit IRC18:17
*** diegows has quit IRC18:18
*** Yogi1 has joined #openstack-cinder18:20
*** vilobhmm has joined #openstack-cinder18:21
*** vilobhmm has quit IRC18:21
*** ebalduf has quit IRC18:22
*** vilobhmm has joined #openstack-cinder18:22
*** openstackgerrit has quit IRC18:22
*** vilobhmm has quit IRC18:22
*** openstackgerrit has joined #openstack-cinder18:23
*** alecv has quit IRC18:24
*** annashen has quit IRC18:26
*** vilobhmm has joined #openstack-cinder18:27
*** Ilja1 has joined #openstack-cinder18:28
*** Ilja has quit IRC18:29
openstackgerritGloria Gu proposed openstack/cinder: Update volume type name for volume type API  https://review.openstack.org/14090618:31
*** Ilja1 has quit IRC18:33
*** Ilja has joined #openstack-cinder18:35
*** vnagpal has joined #openstack-cinder18:38
openstackgerritGloria Gu proposed openstack/python-cinderclient: Update to change name for volume type client  https://review.openstack.org/14118718:39
*** asmith_brcd has joined #openstack-cinder18:43
*** TobiasE has joined #openstack-cinder18:44
*** diemt has joined #openstack-cinder18:47
*** dulek has quit IRC18:47
*** annashen has joined #openstack-cinder18:49
jgriffithjungleboyj: I think again we're not on the same page yet again18:51
jgriffithjungleboyj: What I'm saying is that backporting to use the oslo18n lib should have NEVER been done18:51
jgriffithjungleboyj: capping may have to be the answer now, but the right answer is/was not to allow that backport (assuming it was a backported change)18:52
jgriffithjungleboyj: see what I'm saying here?18:53
jgriffithjungleboyj: the changes Jim made to import oslo.i18n is the problem18:54
jgriffiththat shouldn't be there at all18:54
jgriffithbut I feel I'm not getting through again18:54
jgriffithnot sure how to clarify this18:54
*** bkopilov has joined #openstack-cinder18:55
*** nellysmitt has joined #openstack-cinder18:55
*** p01s0n has quit IRC18:57
*** lpetrut has quit IRC18:58
*** Mandell has quit IRC18:59
*** emagana_ has quit IRC19:00
*** lpetrut has joined #openstack-cinder19:04
*** rushiagr is now known as rushiagr_away19:06
*** Mandell has joined #openstack-cinder19:08
jungleboyjjgriffith: So, I have been trying to make sense of this.  There is a timing window here is the issue.19:10
jungleboyjjgriffith: We can rip out https://github.com/openstack/cinder/commit/3965a5f72984fabfa131ef5359a2959a80787a22#diff-e734ea39ff572cae552bf498a40bb33b but I don't feel that is the right answer.19:11
*** EmilienM is now known as EmilienM|afk19:11
jungleboyjjgriffith: Talking to Jim right now.19:14
*** ebalduf has joined #openstack-cinder19:22
openstackgerritGloria Gu proposed openstack/cinder: HP 3par driver filter and evaluator function  https://review.openstack.org/15135319:25
openstackgerritDanny Wilson proposed openstack/cinder: Enabling volume replication on PureISCSIDriver  https://review.openstack.org/14509019:25
*** kallebe has joined #openstack-cinder19:25
*** ebalduf has quit IRC19:27
openstackgerritGloria Gu proposed openstack/cinder: HP 3par driver filter and evaluator function  https://review.openstack.org/15135319:27
*** vnagpal has quit IRC19:31
*** ronenkat has joined #openstack-cinder19:32
*** Guest92220 has joined #openstack-cinder19:32
*** TobiasE has quit IRC19:33
openstackgerritVilobh Meshram proposed openstack/cinder: Introducing micro_states for create workflow  https://review.openstack.org/12420519:34
jgriffithjungleboyj: no, there's not a timing window either :)19:35
jgriffithjungleboyj: I'll rework my patch and ask that you or Jim don't modify it again19:35
jungleboyjjgriffith: Jim just updated the bugs with an explanation.19:37
jgriffithjungleboyj: and it's still wrong19:38
jgriffithjungleboyj: don't get mad19:38
jungleboyjjgriffith: The proposal from oslo is to ping oslo.i18n at 1.3.1 .  That resolves the bugs that are currently open.  If that isn't satisfactory to you, you can rework your patch.19:39
jgriffithjungleboyj: what I've been saying though and still not sure if we're on the same page19:39
vilobhmmxyang : addressed the comments you posted for https://review.openstack.org/#/c/124205/ please have a look19:39
jgriffithjungleboyj: we didn't have the oslo.i18n library in Juno19:40
jgriffithjungleboyj: and the only place it is now is in that test19:40
jgriffithjungleboyj: my point being that that shouldn't have been introduced in the first place to backport a fix for a unit test19:40
jgriffithjungleboyj: see what I mean?19:40
smcginnisjgriffith, jungleboyj: Not to jump in and cause any confusion, but I was confused as to why that was backported to Juno. Can someone explain that?19:40
jgriffithsmcginnis: +119:40
smcginnisjgriffith: That's what you were question too, right?19:41
jgriffithsmcginnis: Yes and no, that's one point, the other point is that there was an iteration that I provided that did not import the lib19:41
jungleboyjjgriffith: You are right.  dhellmann  agrees.19:41
jungleboyjSo, lets back it out.19:41
jgriffithsmcginnis: so even if it was broken in Juno it should've never introduced a dep on lib that wasn't there19:42
jungleboyj<dhellmann> jecarey: they shouldn't have done that, we'll be capping the libs to versions that don't include those changes.19:42
jgriffithsmcginnis: it should have instead used the hack that I submitted without the fixture19:42
smcginnisjgriffith: Yeah, that's what surprised me about it.19:42
jgriffithsmcginnis: indeed19:42
jgriffithbut now I've made jungleboyj mad again :(19:42
* jgriffith pictures Bruce Banner... "Don't make me angry, you wouldn't like me when I'm angry"19:43
smcginnisjgriffith: Buy him a creme brulee. Or a milk shake. :)19:43
jungleboyjjgriffith: No, I am not angry.19:43
jgriffithMy milk shake, is better than yours....19:43
jungleboyjjgriffith: I am frustrated that I am not able to keep up with all the issues I am trying to tackle right now.19:44
* smcginnis thinks jungleboyj does a lot19:44
jgriffithjungleboyj: it's like plugging a whole in the damn with your thumb19:44
jungleboyjjgriffith: Yep.19:45
jgriffithjungleboyj: the water never stops coming19:45
jgriffithThat's why it takes a whole community19:45
jungleboyjjgriffith: So, you are right.  We should not have backported the change that required namespacing and the fixture.  That was our mistake so lets fix it and hopefully once we get the oslo libraries pinned this will be better.19:46
jgriffithjungleboyj: agreed, question is am I fixing it or is Jim?19:46
jgriffithjungleboyj: whole thing is silly anyway, it's just a unit test19:47
* jungleboyj is laughing19:47
jungleboyjI was trying not to think of that.19:47
jungleboyjYou just want 3965a5f reverted?19:48
jungleboyjjgriffith: ^^19:48
jgriffithjungleboyj: that won't work19:49
jgriffithjungleboyj: but you can try it if you want19:49
jgriffithjungleboyj: the whole problem is the "from oslo.i18n import _lazy" remember19:50
jungleboyjOh yeah, Which we tried to resolve with this patch but we went too far.19:50
jgriffithjungleboyj: exactly19:51
jgriffithjungleboyj: I think the last version I put up that worked was 6 or 7 but not sure19:51
jgriffithjungleboyj: that was without the fixture19:51
jgriffithjungleboyj: if you want me to just do it I will, say the word.  Otherwise I'm moving on to other issues now19:51
jungleboyjjgriffith: If you think you know the way to tackle this, why don't you do that.19:52
*** kallebe has left #openstack-cinder19:53
jungleboyjjgriffith: Then Jim can take a look at it.  We need to make sure that we don't just leave i18n enabled for everything, though maybe that won't matter for Juno at this point.19:55
jgriffithjungleboyj: so that goes back to my original debate here19:55
jgriffithjungleboyj: if the unit tests pass and everything works who cares in this case?19:56
*** nellysmitt has quit IRC19:56
jungleboyjjgriffith: Agreed.19:56
jungleboyjLets remove the dependency on 1.3.1, get the test passing and move on with life.19:57
jgriffithjungleboyj: and if you remember, I proposed adding the enable_lazy(False) and toggling it back off but you and Jim nixed that19:57
openstackgerritDanny Al-Gaaf proposed openstack/cinder: quobyte: remove dependency to xattr  https://review.openstack.org/15454319:58
jungleboyjjgriffith: I don't remember why I said that.19:58
jgriffithjungleboyj: well that's when you overwrote my patch with your own version :)19:58
*** vnagpal has joined #openstack-cinder19:59
* jungleboyj sighs19:59
*** vnagpal has quit IRC20:00
*** vnagpal has joined #openstack-cinder20:00
jgriffithwhere's thingee in all of this?20:00
*** Guest92220 is now known as annegentle20:01
jungleboyjjgriffith: He is hiding like I would like to be doing.20:01
jgriffithjungleboyj: nahh... he's probably traveling20:01
jungleboyjIn patch set six you are adding enable=True for enable_lazy.20:02
jungleboyjYou removed the test cases in test_faults.py that failed.20:02
jungleboyjYou updated test_wsgi to not use _lazy.20:03
jungleboyjSo, depending on where they land the oslo.i18n pin we should be able to just do a revert.  It depends on if they use a version if oslo.i18n that has _lazy in there20:07
jungleboyjtrying to confirm that statement.20:08
*** atmark has quit IRC20:10
*** Miouge has quit IRC20:11
jungleboyjjgriffith: So, I propose this:20:12
hemnajgriffith, ping20:12
jgriffithhemna: pong20:12
hemnaso, do you remember this guy? https://bugs.launchpad.net/cinder/+bug/137548720:13
openstackLaunchpad bug 1375487 in Cinder "qemu-img "-t none" parameter fails image conversion on tmpfs" [High,Fix released] - Assigned to John Griffith (john-griffith)20:13
*** AlkaD has joined #openstack-cinder20:13
jgriffithI do indeed20:13
hemnaheh ok20:13
jungleboyjjgriffith: Lets give dhellmann and jogo time to land on the library levels they want.  Then I can test/propose the revert assuming they land where I think they will.20:13
hemnaso I'm seeing a failure with -t none20:13
jgriffithjungleboyj: ok, I'm relinquishing ownership to you20:13
hemnathe test for odirect works (dd count=0....)20:13
jungleboyjjgriffith: Ok.  I will keep you updated.20:14
hemnathe -t none works with qemu-img version 2.0.020:14
hemnabut fails with version 2.1.320:14
*** bswartz has quit IRC20:14
*** Mandell has quit IRC20:15
hemnaI'm manually building qemu 2.1.3 at the moment to confirm20:15
jgriffithhemna: You'll need to give me something more to go on here I'm afraid20:16
hemnaso ok20:16
hemnawe have a distro here that has qemu 2.1.3 installed20:16
hemnarunning cinder20:16
hemnawhich tries to do copy image to volume20:16
hemnawhich eventually boils down to running the image_utils.py convert_image20:16
hemnawhich now does a test to see if it can do O_DIRECT20:17
hemnawith call to dd count=0 if=image of=device20:17
jgriffithhemna: ok, so this is something in the qemu util in your custom distro for helion20:17
hemnajgriffith, yah20:17
*** cnesa has joined #openstack-cinder20:17
hemnawhich happens to use qemu 2.1.320:17
jgriffithhemna: yes, I know the code path, I meant the failure you're seeing20:17
hemnaubuntu 14.04 uses 2.0.020:17
hemnaso the test succeeds20:17
hemna(dd count=0 if=image of=device)20:17
hemnabut the usage of qemu-img -t none fails20:18
hemnawith qemu-img 2.1.320:18
hemnaI've tested it on ubuntu 14.04 with qemu-img 2.0.0 works fine20:18
jgriffithhemna: what's the error message?20:18
jgriffithhemna: pin your qemu version :)20:18
*** bswartz has joined #openstack-cinder20:18
hemnaso yah, we are telling our folks to pin it20:18
jgriffithhemna: so I was half joking :)20:19
*** annashen has quit IRC20:19
hemnabut I'm concerned about when ubuntu updates qemu-img20:19
jgriffithhemna: I mean short term that may be the answer but20:19
jgriffithagreed, looking at it20:19
jgriffithwhat's the error message?20:19
hemna(getting that sec)20:19
hemnaso in the mean time, I'm manually building qemu 2.1.3 to do a test20:20
kmartinjgriffith, see http://paste.openstack.org/show/170927/20:20
jgriffithkmartin: cool, thanks20:21
*** vnagpal has quit IRC20:21
hemnawe also ran the commands manually20:21
hemnato prove that the -t none causes the failure20:21
jgriffithhemna: oh sure20:21
*** changbl has quit IRC20:21
kmartinjgriffith, running it by hand http://paste.openstack.org/show/170928/20:21
jgriffithkmartin: hemna FWIW, I believe that a qemu bug in that version20:22
hemnaI'm hoping20:22
hemna"Yeah, we should fix that."20:23
jgriffithhemna: there's a patch up for it20:23
jgriffithhemna: try applying this: https://patchwork.ozlabs.org/patch/408683/20:24
*** ebalduf has joined #openstack-cinder20:24
jgriffithhemna: should fix you up20:24
hemnaawesome thanks20:24
hemnaor....maybe update to 2.2.0 or 2.0.020:24
jgriffithhemna: and of course you'll have to figure out how helion wants to handle packaging to fix it until your debian distro updates to a version with a fix20:24
jgriffithhemna: yeah, that's up to you :)20:24
hemnayah....but that's not my problem :P20:24
kmartinjgriffith, perfect thanks20:25
jgriffithhemna: if it were me and I were running helion distro I'd match the most common denominator20:25
hemnayah I'm not sure why they chose 2.1.320:25
jgriffithhemna: well, I think that's what's in 15.04 as well20:25
jgriffithhaven't looked20:25
hemnaanyway, thanks a bunch for the help!20:26
jgriffithhemna: sure20:26
jgriffithhemna: and even 15.04 is 2.2 it looks like FWIW but I could be wrong and dont' feel like digging in to it :)20:26
hemnasmells like 2.1.x20:27
jgriffithhemna: yeah, but there's an update proposal out there20:27
jgriffithhemna: but anyway... not my thing20:28
jgriffithhemna: packaging stuff makes my head hurt20:28
hemnayah same here20:28
hemnait's pain20:28
jgriffithmaybe they rejected 2.2 because of the bug you hit :)20:28
*** ebalduf has quit IRC20:28
btranHi, for the cinder CI requirement, I have my local CI running and was able to pass all tempest volume tests (however, some issues now). My jobs are being triggered by changes in the openstack-dev/sandbox, project.20:31
btranWhat is the next step or process I need to do to have my cinder job be part of the openstack-dev/cinder project? I can't fine any documentation on what to do next. thanks in advance20:31
*** EmilienM|afk is now known as EmilienM20:35
jungleboyjhemna: Yay!  I voted for that.20:35
btrananyone? link me a wiki or doc that would be great20:41
*** nellysmitt has joined #openstack-cinder20:42
jgriffithbtran: looking... you just need to change the project your listening to to be cinder20:43
jgriffithbtran: but I don't use the std Jenkins/Ci method so need to poke around to figure out where that gets flipped20:43
btranjgriffith:  you mean I just need to update Zuul layout.xml file?20:43
jgriffithasselin__: ^^20:43
jgriffithbtran: sure :)20:43
btrani see, that simple huh?  there is no requirement or approval that I need to go through?20:44
jgriffithbtran: so that assumes you have an account and all that stuff20:44
jgriffithbtran: ie submitted a request for a third party ci account and recieved an approval and info back20:45
jgriffithbtran: which means you have ssh keys etc20:45
btranjgriffith:  cool thanks a lot20:45
jgriffithbtran: certainly20:45
*** Ilja has quit IRC20:53
*** AlkaD has quit IRC20:57
*** mriedem has quit IRC20:59
*** Mandell has joined #openstack-cinder21:01
*** mriedem has joined #openstack-cinder21:02
*** anshul has quit IRC21:02
*** ronenkat has quit IRC21:02
*** annashen has joined #openstack-cinder21:02
*** jcru has quit IRC21:03
*** tbarron has quit IRC21:05
*** sgotliv has joined #openstack-cinder21:05
*** ebalduf has joined #openstack-cinder21:05
*** thingee has joined #openstack-cinder21:05
scottdaboris-42: Is there a reason osprofiler/profiler.py:trace() decorator repeats 18 times during this Traceback: http://paste.openstack.org/show/170961/21:09
*** tbarron has joined #openstack-cinder21:09
boris-42scottda: hey there21:18
boris-42scottda: seems like some magic regarding to mocking..21:18
scottdaJust curious. I don't think it's the cause of my issue, but I see it repeated 18X21:19
scottdaOK. makes sense.21:19
boris-42scottda: ya that seems bad21:20
scottdaI've got many layers of badness going on here :)21:21
*** Mandell has quit IRC21:23
*** annashen has quit IRC21:27
*** bswartz has quit IRC21:28
asselin__jgriffith, btran hi21:30
*** Lee1092 has quit IRC21:30
*** Mandell has joined #openstack-cinder21:30
*** theanalyst has quit IRC21:30
asselin__btran, yes, just update the zuul layout.yaml openstack-dev/sandbox to openstack/cinder21:31
*** vnagpal has joined #openstack-cinder21:31
*** timcl has quit IRC21:32
*** emagana has joined #openstack-cinder21:32
asselin__btran, no requirement or approval. however if there are issues with the ci system that don't get resolved then the whole account gets disabled21:32
openstackgerritSteven Kaufer proposed openstack/cinder: Replication status periodic task optimization  https://review.openstack.org/15467321:33
kauferjungleboyj: ^21:33
jungleboyjkaufer: You the man.21:34
*** theanalyst has joined #openstack-cinder21:35
*** atmark has joined #openstack-cinder21:38
*** atmark is now known as Guest1994521:38
openstackgerritabhiram moturi proposed openstack/cinder: Enhance unit tests for zfssa drivers  https://review.openstack.org/15267621:41
*** dannywilson has quit IRC21:44
*** dannywilson has joined #openstack-cinder21:45
*** lpetrut has quit IRC21:49
*** bswartz has joined #openstack-cinder21:49
*** Yogi1 has quit IRC21:51
*** asselin_ has quit IRC21:52
*** dannywilson has quit IRC21:53
*** asselin_ has joined #openstack-cinder21:53
*** asselin_ has quit IRC21:53
*** dannywilson has joined #openstack-cinder21:53
*** annashen has joined #openstack-cinder21:55
*** thingee has quit IRC21:55
*** sgordon_ has joined #openstack-cinder21:55
*** vnagpal has quit IRC21:57
*** thingee has joined #openstack-cinder21:57
*** vilobhmm has quit IRC21:58
*** nellysmitt has quit IRC22:03
*** Mandell has quit IRC22:03
*** e0ne has quit IRC22:05
*** dustins has quit IRC22:08
*** ronis has quit IRC22:08
*** bswartz has quit IRC22:11
*** jungleboyj has quit IRC22:11
*** sgotliv_ has joined #openstack-cinder22:11
*** sgotliv has quit IRC22:14
*** thangp has quit IRC22:15
*** mriedem has quit IRC22:19
*** mriedem has joined #openstack-cinder22:20
*** juzuluag has quit IRC22:26
*** mriedem has quit IRC22:27
*** diemt has quit IRC22:30
*** cnesa has quit IRC22:31
*** diegows has joined #openstack-cinder22:43
*** sgotliv__ has joined #openstack-cinder22:44
*** vilobhmm has joined #openstack-cinder22:47
*** sgotliv_ has quit IRC22:47
*** Mandell has joined #openstack-cinder22:58
*** dannywilson has quit IRC22:59
*** jungleboyj has joined #openstack-cinder22:59
*** dannywilson has joined #openstack-cinder23:01
*** dannywilson has quit IRC23:01
*** patrickeast_ has joined #openstack-cinder23:02
*** patrickeast has quit IRC23:02
*** annashen has quit IRC23:02
*** patrickeast_ is now known as patrickeast23:02
*** dannywil_ has joined #openstack-cinder23:03
*** dannywil_ has quit IRC23:04
*** dannywilson has joined #openstack-cinder23:04
*** thingee has quit IRC23:04
openstackgerritxing-yang proposed openstack/cinder: Add support to differential backups in cinder  https://review.openstack.org/11006823:07
*** xyang has quit IRC23:07
openstackgerritxing-yang proposed openstack/cinder: Add support to incremental backups in cinder  https://review.openstack.org/11006823:08
*** alexpilotti has joined #openstack-cinder23:09
*** alexpilotti has quit IRC23:10
*** alexpilotti has joined #openstack-cinder23:13
*** xyang has joined #openstack-cinder23:15
*** tbarron has quit IRC23:16
*** leeantho has quit IRC23:18
*** leeantho has joined #openstack-cinder23:18
*** fischerw has quit IRC23:20
*** Computer_Czar has joined #openstack-cinder23:24
*** thingee has joined #openstack-cinder23:31
*** annashen has joined #openstack-cinder23:35
*** akerr has quit IRC23:35
*** rmesta has quit IRC23:36
*** chlong has joined #openstack-cinder23:39
*** primechuck has quit IRC23:41
*** emagana has quit IRC23:46
*** bitblt has joined #openstack-cinder23:46
*** emagana has joined #openstack-cinder23:47
bitbltif i only have one nfs mount point, and i decide i want to change it to something else, eg a re-IP, is it right that I'll have to manually change the provider_location in the db, then update the domain xml file to the new location too?23:49
*** bswartz has joined #openstack-cinder23:51
*** emagana has quit IRC23:51
openstackgerritVilobh Meshram proposed openstack/cinder: Introducing micro_states for create workflow  https://review.openstack.org/12420523:54
*** annashen has quit IRC23:56
*** asmith_brcd has quit IRC23:56
*** kaufer has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!