*** marcusvrn has quit IRC | 00:08 | |
*** bswartz has joined #openstack-cinder | 00:10 | |
*** Apoorva_ has quit IRC | 00:17 | |
*** Apoorva has joined #openstack-cinder | 00:17 | |
*** tbarron has joined #openstack-cinder | 00:21 | |
*** tbarron has joined #openstack-cinder | 00:22 | |
*** tsekiyam_ has joined #openstack-cinder | 00:24 | |
*** Apoorva_ has joined #openstack-cinder | 00:25 | |
*** asmith_brcd has quit IRC | 00:26 | |
hemna | http://seravo.fi/2015/10-reasons-to-migrate-to-mariadb-if-still-using-mysql | 00:26 |
---|---|---|
hemna | interesting read | 00:26 |
hemna | fwiw | 00:26 |
*** ebalduf has joined #openstack-cinder | 00:28 | |
*** tsekiyama has quit IRC | 00:28 | |
*** Apoorva has quit IRC | 00:28 | |
*** marcusvrn has joined #openstack-cinder | 00:32 | |
*** ebalduf has quit IRC | 00:32 | |
*** ho has joined #openstack-cinder | 00:38 | |
*** annashen has quit IRC | 00:39 | |
*** Apoorva_ has quit IRC | 00:40 | |
*** erlon has quit IRC | 00:41 | |
*** Apoorva has joined #openstack-cinder | 00:41 | |
*** mtanino has joined #openstack-cinder | 00:42 | |
*** asselin_ has joined #openstack-cinder | 00:43 | |
*** asselin_ has quit IRC | 00:48 | |
*** dannywil_ has quit IRC | 00:57 | |
*** IanGovett has quit IRC | 00:57 | |
*** rmesta has quit IRC | 01:03 | |
*** drjones has quit IRC | 01:06 | |
*** adam_g is now known as adam_g_out | 01:09 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 01:10 | |
*** devlaps has quit IRC | 01:11 | |
*** hemna is now known as hemnafk | 01:17 | |
*** david-lyle is now known as david-lyle_afk | 01:19 | |
*** garthb_ has quit IRC | 01:21 | |
*** garthb has quit IRC | 01:21 | |
*** ebalduf has joined #openstack-cinder | 01:28 | |
*** ebalduf has quit IRC | 01:33 | |
*** bill_az has quit IRC | 01:36 | |
*** Mandell_ has quit IRC | 01:36 | |
*** Mandell has joined #openstack-cinder | 01:43 | |
*** _cjones_ has joined #openstack-cinder | 01:43 | |
*** krtaylor has quit IRC | 01:43 | |
*** jamielennox is now known as jamielennox|away | 01:46 | |
*** Mandell has quit IRC | 01:46 | |
vilobhmm1 | thingee :ping | 01:46 |
*** asselin_ has joined #openstack-cinder | 01:48 | |
*** tsekiyam_ has quit IRC | 01:48 | |
*** asselin_ has quit IRC | 01:49 | |
*** thingee has quit IRC | 01:51 | |
*** krtaylor has joined #openstack-cinder | 01:55 | |
anish | smcginnis: xyang was the final consensus the same as http://paste.openstack.org/show/180819/ ? | 01:58 |
*** xyang has quit IRC | 01:58 | |
openstackgerrit | xing-yang proposed openstack/cinder: Kilo Consistency Group API update https://review.openstack.org/144561 | 01:59 |
*** Thelo has joined #openstack-cinder | 02:00 | |
*** leeantho has quit IRC | 02:05 | |
*** jcru has joined #openstack-cinder | 02:12 | |
*** jamielennox|away is now known as jamielennox | 02:12 | |
*** xyang has joined #openstack-cinder | 02:17 | |
*** lcurtis has joined #openstack-cinder | 02:17 | |
*** markvoelker has quit IRC | 02:25 | |
*** markvoelker has joined #openstack-cinder | 02:26 | |
*** ebalduf has joined #openstack-cinder | 02:29 | |
*** markvoelker has quit IRC | 02:30 | |
*** ebalduf has quit IRC | 02:34 | |
*** vilobhmm1 has quit IRC | 02:36 | |
*** casusbel_ has joined #openstack-cinder | 02:37 | |
*** casusbelli has quit IRC | 02:40 | |
*** kaisers1 has joined #openstack-cinder | 02:45 | |
*** xyang has quit IRC | 02:45 | |
openstackgerrit | xing-yang proposed openstack/cinder: Create Consistency Group from CG Snapshot API https://review.openstack.org/145952 | 02:46 |
*** kaisers has quit IRC | 02:46 | |
*** diegows has quit IRC | 02:47 | |
*** kaufer has joined #openstack-cinder | 02:50 | |
openstackgerrit | Jay Bryant proposed openstack/cinder: Sync scheduler module from oslo-incubator https://review.openstack.org/158534 | 02:53 |
openstackgerrit | Jay Bryant proposed openstack/cinder: Sync scheduler.filters module from oslo-incubator https://review.openstack.org/158535 | 02:55 |
openstackgerrit | Patrick East proposed openstack/cinder: Add CHAP support to PureISCSIDriver https://review.openstack.org/137175 | 03:06 |
openstackgerrit | Patrick East proposed openstack/cinder: Add DB table for driver specific data https://review.openstack.org/151837 | 03:06 |
*** xyang has joined #openstack-cinder | 03:07 | |
*** markvoelker has joined #openstack-cinder | 03:08 | |
*** Apoorva_ has joined #openstack-cinder | 03:08 | |
*** kaufer has quit IRC | 03:10 | |
*** Apoorva has quit IRC | 03:11 | |
*** MasterPiece has quit IRC | 03:11 | |
openstackgerrit | Patrick East proposed openstack/cinder: Add support to PureISCSIDriver for updating consistency groups https://review.openstack.org/157637 | 03:12 |
*** lcurtis has quit IRC | 03:12 | |
*** Apoorva_ has quit IRC | 03:13 | |
*** Thelo has quit IRC | 03:14 | |
*** _cjones_ has quit IRC | 03:14 | |
*** marcusvrn has quit IRC | 03:15 | |
*** lcurtis has joined #openstack-cinder | 03:25 | |
*** patrickeast has quit IRC | 03:27 | |
*** ebalduf has joined #openstack-cinder | 03:30 | |
*** ebalduf has quit IRC | 03:34 | |
*** bkopilov has quit IRC | 03:39 | |
*** tbarron has quit IRC | 03:51 | |
*** tbarron has joined #openstack-cinder | 03:52 | |
*** kaisers1 has quit IRC | 03:52 | |
*** dannywilson has joined #openstack-cinder | 03:53 | |
*** dannywilson has quit IRC | 03:57 | |
*** tbarron has quit IRC | 03:58 | |
*** vilobhmm1 has joined #openstack-cinder | 04:04 | |
*** pdeore_ has joined #openstack-cinder | 04:09 | |
*** Apoorva has joined #openstack-cinder | 04:10 | |
*** annashen has joined #openstack-cinder | 04:12 | |
*** lcurtis has quit IRC | 04:13 | |
*** harlowja is now known as harlowja_away | 04:14 | |
*** harlowja_away is now known as harlowja | 04:15 | |
*** devlaps has joined #openstack-cinder | 04:17 | |
*** lcurtis has joined #openstack-cinder | 04:25 | |
*** Tross has quit IRC | 04:27 | |
*** annashen has quit IRC | 04:28 | |
*** ebalduf has joined #openstack-cinder | 04:31 | |
*** ebalduf has quit IRC | 04:35 | |
*** markvoelker has quit IRC | 04:39 | |
*** markvoelker has joined #openstack-cinder | 04:39 | |
*** jcru has quit IRC | 04:43 | |
*** markvoelker has quit IRC | 04:44 | |
*** lpetrut has joined #openstack-cinder | 04:46 | |
*** lcurtis has quit IRC | 04:49 | |
*** krtaylor has quit IRC | 04:55 | |
*** annashen has joined #openstack-cinder | 04:57 | |
*** annashen has quit IRC | 04:58 | |
*** annashen has joined #openstack-cinder | 05:00 | |
*** bkopilov has joined #openstack-cinder | 05:01 | |
*** krtaylor has joined #openstack-cinder | 05:07 | |
*** annashen has quit IRC | 05:10 | |
*** markvoelker has joined #openstack-cinder | 05:10 | |
*** casusbel_ has quit IRC | 05:11 | |
*** annashen has joined #openstack-cinder | 05:12 | |
*** krtaylor has quit IRC | 05:14 | |
*** devlaps has quit IRC | 05:17 | |
*** markvoelker has quit IRC | 05:17 | |
*** annashen has quit IRC | 05:22 | |
*** Mandell has joined #openstack-cinder | 05:26 | |
*** krtaylor has joined #openstack-cinder | 05:26 | |
*** BharatK has joined #openstack-cinder | 05:30 | |
*** ebalduf has joined #openstack-cinder | 05:31 | |
*** jamielennox is now known as jamielennox|away | 05:33 | |
*** jamielennox|away is now known as jamielennox | 05:34 | |
*** sgotliv has quit IRC | 05:34 | |
*** ebalduf has quit IRC | 05:36 | |
*** lpetrut has quit IRC | 05:43 | |
*** deepakcs has joined #openstack-cinder | 05:48 | |
openstackgerrit | xing-yang proposed openstack/cinder: Modify Consistency Group API https://review.openstack.org/144561 | 05:56 |
*** xyang has quit IRC | 05:56 | |
*** coolsvap_ is now known as coolsvap | 05:57 | |
*** atmark1 is now known as atmark | 06:04 | |
*** atmark has quit IRC | 06:04 | |
*** atmark has joined #openstack-cinder | 06:04 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex https://review.openstack.org/152401 | 06:06 |
*** ho__ has joined #openstack-cinder | 06:09 | |
*** ho has quit IRC | 06:09 | |
*** harlowja is now known as harlowja_away | 06:11 | |
*** markvoelker has joined #openstack-cinder | 06:13 | |
*** _cjones_ has joined #openstack-cinder | 06:14 | |
*** markvoelker has quit IRC | 06:17 | |
*** annashen has joined #openstack-cinder | 06:20 | |
*** _cjones_ has quit IRC | 06:20 | |
*** anshul has joined #openstack-cinder | 06:29 | |
*** thingee has joined #openstack-cinder | 06:31 | |
*** ebalduf has joined #openstack-cinder | 06:32 | |
*** anshul has quit IRC | 06:36 | |
*** anshul has joined #openstack-cinder | 06:36 | |
thingee | wanghao: please push an update for this https://review.openstack.org/#/c/144590/ | 06:36 |
*** ebalduf has quit IRC | 06:37 | |
*** annashen has quit IRC | 06:37 | |
thingee | wanghao: deadline is approach for passing code on march 1st http://lists.openstack.org/pipermail/openstack-dev/2015-February/056964.html | 06:37 |
*** thingee has quit IRC | 06:38 | |
*** Mandell has quit IRC | 06:39 | |
*** BharatK has quit IRC | 06:40 | |
*** aniket has joined #openstack-cinder | 06:40 | |
*** BharatK has joined #openstack-cinder | 06:41 | |
*** pradipta has joined #openstack-cinder | 06:42 | |
aniket | hello all :) , I am working on cinder component. I just want to know that how can we boot an instance from SAN storage? | 06:45 |
*** rushiagr_away is now known as rushiagr | 06:49 | |
*** Apoorva has quit IRC | 07:00 | |
openstackgerrit | Eric Brown proposed openstack/cinder: Use oslo_config choices support https://review.openstack.org/158580 | 07:03 |
aniket | anyone have any idea about this? | 07:09 |
*** nkrinner has joined #openstack-cinder | 07:15 | |
openstackgerrit | Eric Brown proposed openstack/cinder: Password config options should be marked secret https://review.openstack.org/158590 | 07:17 |
*** xyang1 has quit IRC | 07:19 | |
*** sgotliv has joined #openstack-cinder | 07:20 | |
*** sgotliv has quit IRC | 07:26 | |
*** Miouge has joined #openstack-cinder | 07:27 | |
*** ebalduf has joined #openstack-cinder | 07:33 | |
*** chlong has quit IRC | 07:34 | |
*** annashen has joined #openstack-cinder | 07:35 | |
*** TobiasE has joined #openstack-cinder | 07:35 | |
*** kaisers has joined #openstack-cinder | 07:36 | |
*** coolsvap is now known as coolsvap_ | 07:36 | |
*** ebalduf has quit IRC | 07:37 | |
*** vilobhmm1 has quit IRC | 07:38 | |
*** coolsvap_ is now known as coolsvap | 07:39 | |
*** annashen has quit IRC | 07:41 | |
*** rushiagr is now known as rushiagr_away | 07:42 | |
*** sgotliv has joined #openstack-cinder | 07:42 | |
*** annashen has joined #openstack-cinder | 07:46 | |
*** e0ne has joined #openstack-cinder | 07:50 | |
*** nshaikh has joined #openstack-cinder | 07:50 | |
*** vilobhmm has joined #openstack-cinder | 07:51 | |
*** vilobhmm has quit IRC | 07:53 | |
*** dulek has joined #openstack-cinder | 07:59 | |
*** annashen has quit IRC | 08:00 | |
*** aviramb has joined #openstack-cinder | 08:00 | |
*** lpetrut has joined #openstack-cinder | 08:07 | |
*** ndipanov has joined #openstack-cinder | 08:08 | |
openstackgerrit | Li Yingjun proposed openstack/python-cinderclient: Add missing all-tenants option to transfer-list https://review.openstack.org/114176 | 08:12 |
openstackgerrit | Eric Brown proposed openstack/cinder: Use oslo_config choices support https://review.openstack.org/158580 | 08:22 |
openstackgerrit | Eric Brown proposed openstack/cinder: Use oslo_config choices support https://review.openstack.org/158580 | 08:28 |
*** ronis has joined #openstack-cinder | 08:29 | |
*** emaisne has joined #openstack-cinder | 08:29 | |
*** ho__ has quit IRC | 08:31 | |
*** ho has joined #openstack-cinder | 08:31 | |
*** ebalduf has joined #openstack-cinder | 08:34 | |
*** teju has joined #openstack-cinder | 08:37 | |
*** ebalduf has quit IRC | 08:38 | |
*** enterprisedc has quit IRC | 08:39 | |
openstackgerrit | Tobias Engelbert proposed openstack/cinder: Recall mechanism for terminate/initialize https://review.openstack.org/154377 | 08:44 |
openstackgerrit | Tobias Engelbert proposed openstack/python-cinderclient: Recall mechanism for terminate/initialize https://review.openstack.org/154376 | 08:45 |
*** jistr has joined #openstack-cinder | 08:54 | |
*** pradipta has quit IRC | 08:59 | |
*** dalgaaf has joined #openstack-cinder | 08:59 | |
*** jordanP has joined #openstack-cinder | 09:00 | |
*** TobiasE has quit IRC | 09:03 | |
*** vukcrni has quit IRC | 09:04 | |
*** teju has quit IRC | 09:05 | |
*** aviramb has quit IRC | 09:05 | |
*** aniket has quit IRC | 09:05 | |
*** btran has quit IRC | 09:05 | |
*** nikesh_vedams has quit IRC | 09:05 | |
*** nuritv has quit IRC | 09:05 | |
*** ankit_ag has joined #openstack-cinder | 09:09 | |
*** yuriy_n17 has joined #openstack-cinder | 09:13 | |
*** markvoelker has joined #openstack-cinder | 09:17 | |
*** karimb has joined #openstack-cinder | 09:21 | |
*** markvoelker has quit IRC | 09:22 | |
*** karimb has quit IRC | 09:23 | |
*** TobiasE has joined #openstack-cinder | 09:23 | |
*** aix has quit IRC | 09:25 | |
*** karimb has joined #openstack-cinder | 09:27 | |
*** ndipanov has quit IRC | 09:30 | |
*** ndipanov has joined #openstack-cinder | 09:30 | |
dulek | winston-d: Hi, I'm curious about your cleaner fix, can you share the idea? | 09:34 |
*** ebalduf has joined #openstack-cinder | 09:34 | |
dulek | winston-d: I'm talking about https://launchpad.net/bugs/1409012 of course | 09:35 |
openstack | Launchpad bug 1409012 in Cinder "Volume becomes in 'error' state after scheduler starts" [High,In progress] - Assigned to Michal Dulko (michal-dulko-f) | 09:35 |
*** openstackgerrit has quit IRC | 09:36 | |
*** openstackgerrit has joined #openstack-cinder | 09:36 | |
*** ebalduf has quit IRC | 09:39 | |
*** nellysmitt has joined #openstack-cinder | 09:44 | |
*** aix has joined #openstack-cinder | 09:52 | |
*** takedakn has joined #openstack-cinder | 09:59 | |
*** annashen has joined #openstack-cinder | 10:00 | |
openstackgerrit | Ronen Mesonzhnik proposed openstack/cinder: Provide backup service that uses ProtecTIER as the backend https://review.openstack.org/153969 | 10:01 |
*** harlowja_away has quit IRC | 10:04 | |
*** alecv has joined #openstack-cinder | 10:05 | |
*** annashen has quit IRC | 10:05 | |
*** TobiasE1 has joined #openstack-cinder | 10:15 | |
*** TobiasE has quit IRC | 10:16 | |
*** markvoelker has joined #openstack-cinder | 10:18 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Handle incorrect '--config-dir' param https://review.openstack.org/157749 | 10:20 |
*** markvoelker has quit IRC | 10:23 | |
openstackgerrit | Huang Zhiteng proposed openstack/cinder: Allow scheduler to receive volume stats when starting service https://review.openstack.org/158623 | 10:23 |
*** marcusvrn has joined #openstack-cinder | 10:28 | |
smcginnis | anish: Sorry, was away until now and just saw your question. | 10:29 |
smcginnis | anish: Yes, logging is correct in http://paste.openstack.org/show/180819/ | 10:30 |
smcginnis | anish: As long as it's passed in to the logger, the logger will take care of it. | 10:30 |
smcginnis | anish: It's only an issue if you try to format it first and just pass in the string. | 10:30 |
*** aix has quit IRC | 10:30 | |
smcginnis | anish: BAD: LOG.info(_LI('Error: %s') % e), GOOD: LOG.info(_LI('Error: %s'), e) | 10:31 |
smcginnis | anish: Subtle. :) | 10:31 |
smcginnis | anish: More reason to follow the convention of using , instead of % and letting the logger handle things. | 10:31 |
*** ndipanov has quit IRC | 10:32 | |
*** marcusvrn1 has joined #openstack-cinder | 10:32 | |
*** tbarron has joined #openstack-cinder | 10:33 | |
smcginnis | anish: Oh, wait. | 10:33 |
smcginnis | anish: Looking at that paste again, debug is wrong there. No difference if it is debug or info or whatever. | 10:33 |
smcginnis | anish: Point is to pass the exception in to the logger. Then no need to explicitly call six.text_type(). | 10:34 |
*** ebalduf has joined #openstack-cinder | 10:35 | |
*** marcusvrn has quit IRC | 10:35 | |
*** ebalduf has quit IRC | 10:40 | |
*** jamielennox is now known as jamielennox|away | 10:42 | |
*** aix has joined #openstack-cinder | 10:43 | |
*** ndipanov has joined #openstack-cinder | 10:46 | |
*** ho has quit IRC | 10:49 | |
openstackgerrit | nikeshmahalka proposed openstack/cinder: Add CHAP persistence to SCST target helper https://review.openstack.org/157356 | 10:49 |
*** takedakn has quit IRC | 10:57 | |
*** jamielennox|away is now known as jamielennox | 10:58 | |
*** jamielennox is now known as jamielennox|away | 11:01 | |
*** jamielennox|away is now known as jamielennox | 11:02 | |
*** jamielennox is now known as jamielennox|away | 11:08 | |
*** sgotliv has quit IRC | 11:08 | |
*** jamielennox|away is now known as jamielennox | 11:10 | |
*** markvoelker has joined #openstack-cinder | 11:19 | |
*** sgotliv has joined #openstack-cinder | 11:20 | |
*** markvoelker has quit IRC | 11:24 | |
*** takedakn has joined #openstack-cinder | 11:31 | |
*** takedakn has quit IRC | 11:32 | |
*** takedakn has joined #openstack-cinder | 11:32 | |
*** takedakn has quit IRC | 11:36 | |
*** ebalduf has joined #openstack-cinder | 11:36 | |
*** jamielennox is now known as jamielennox|away | 11:38 | |
*** diegows has joined #openstack-cinder | 11:39 | |
*** takedakn has joined #openstack-cinder | 11:40 | |
*** takedakn has quit IRC | 11:40 | |
*** ebalduf has quit IRC | 11:40 | |
*** jamielennox|away is now known as jamielennox | 11:41 | |
*** sgotliv has quit IRC | 11:51 | |
*** sgotliv has joined #openstack-cinder | 11:51 | |
*** tbarron has quit IRC | 11:52 | |
*** enterprisedc has joined #openstack-cinder | 11:56 | |
*** chlong has joined #openstack-cinder | 11:57 | |
*** annashen has joined #openstack-cinder | 12:01 | |
*** markvoelker has joined #openstack-cinder | 12:05 | |
*** annashen has quit IRC | 12:06 | |
*** markvoelker has quit IRC | 12:11 | |
*** IanGovett has joined #openstack-cinder | 12:27 | |
*** ebalduf has joined #openstack-cinder | 12:37 | |
*** sgotliv has quit IRC | 12:37 | |
*** ebalduf has quit IRC | 12:41 | |
*** chlong has quit IRC | 12:44 | |
*** akerr has joined #openstack-cinder | 12:45 | |
*** Miouge has quit IRC | 12:53 | |
*** Miouge has joined #openstack-cinder | 12:54 | |
*** Mandell has joined #openstack-cinder | 12:58 | |
*** Mandell has quit IRC | 13:03 | |
*** bkopilov has quit IRC | 13:04 | |
*** Tross has joined #openstack-cinder | 13:05 | |
*** TobiasE1 has quit IRC | 13:06 | |
*** TobiasE has joined #openstack-cinder | 13:06 | |
*** markvoelker has joined #openstack-cinder | 13:06 | |
*** Yogi1 has joined #openstack-cinder | 13:07 | |
*** nikesh_vedams has joined #openstack-cinder | 13:08 | |
*** markvoelker has quit IRC | 13:11 | |
*** Longgeek has joined #openstack-cinder | 13:12 | |
*** jamielennox is now known as jamielennox|away | 13:18 | |
*** jamielennox|away is now known as jamielennox | 13:20 | |
*** sgotliv has joined #openstack-cinder | 13:27 | |
*** ankit_ag has quit IRC | 13:29 | |
*** deepakcs has quit IRC | 13:30 | |
*** sgotliv has quit IRC | 13:31 | |
*** BharatK has quit IRC | 13:31 | |
*** rcallawa has joined #openstack-cinder | 13:34 | |
*** sgotliv has joined #openstack-cinder | 13:34 | |
*** jaypipes has quit IRC | 13:36 | |
*** ebalduf has joined #openstack-cinder | 13:38 | |
*** xyang has joined #openstack-cinder | 13:40 | |
*** jseiler has joined #openstack-cinder | 13:40 | |
*** xyang1 has joined #openstack-cinder | 13:40 | |
*** ebalduf has quit IRC | 13:42 | |
*** sgotliv has quit IRC | 13:43 | |
*** rushiagr_away is now known as rushiagr | 13:43 | |
*** sgotliv has joined #openstack-cinder | 13:43 | |
*** Yogi1 has quit IRC | 13:46 | |
*** anshul has quit IRC | 13:51 | |
*** ozamiatin has joined #openstack-cinder | 13:54 | |
*** thangp has joined #openstack-cinder | 13:55 | |
*** nlevinki has joined #openstack-cinder | 13:55 | |
*** emagana has joined #openstack-cinder | 13:56 | |
*** Miouge_ has joined #openstack-cinder | 13:57 | |
*** Miouge has quit IRC | 13:58 | |
*** Miouge_ is now known as Miouge | 13:58 | |
*** annashen has joined #openstack-cinder | 14:02 | |
dulek | thangp: Hi! | 14:03 |
dulek | thangp: I have some questions regarding objects patches. You've commented that we should pass objects instead of resource id's in RPC calls. | 14:04 |
thangp | dulek: sure | 14:04 |
dulek | thangp: I wonder if this doesn't introduce races. | 14:05 |
thangp | dulek: why would it? | 14:05 |
thangp | dulek: the purpose of the spec was to pass objects over rpc | 14:05 |
dulek | thangp: As we're passing an object state it can change when Rabbit is doing it's processing. | 14:05 |
dulek | And we're not refreshing the state. | 14:05 |
thangp | dulek: you could implement the check in the save() function to check | 14:06 |
*** Miouge has quit IRC | 14:06 | |
*** Miouge has joined #openstack-cinder | 14:06 | |
thangp | to make sure that the object is in the correct state | 14:06 |
*** kaufer has joined #openstack-cinder | 14:06 | |
dulek | thangp: I'm not opposed to the idea, just thinking of possible problems. | 14:06 |
*** Yogi1 has joined #openstack-cinder | 14:06 | |
thangp | but the existing implementation might have locks in place to stop this | 14:06 |
*** markvoelker has joined #openstack-cinder | 14:07 | |
*** annashen has quit IRC | 14:07 | |
dulek | thangp: By existing implementation you mean current master? | 14:07 |
thangp | e.g. snapshots has a lock decorator to stop multiple deletes IIRC | 14:07 |
thangp | dulek: existing implementation in the current cinder code base (not using objects) | 14:07 |
thangp | dulek: some of them do | 14:08 |
dulek | okay | 14:08 |
thangp | dulek: i havent looked at backups, but it may have them | 14:08 |
dulek | So locks would be the answer here. | 14:08 |
thangp | dulek: in part | 14:08 |
thangp | dulek: for scenarios where races are apparent, we need to check the state before we actually save | 14:08 |
thangp | dulek: and fail is the "state" is old | 14:09 |
dulek | thangp: Yeah, to not mess the DB. | 14:09 |
thangp | dulek: or figure out how to handle it correctly | 14:09 |
thangp | dulek: so...you could add an option (e.g. expected_state) in the save() function | 14:10 |
thangp | dulek: and when you do save, you could check if the backup state is what you expected | 14:10 |
dulek | thangp: Actually I think we may just check if state we have in the object is the same as in the DB. | 14:10 |
thangp | it causes a lookup, but you do it when you know there can be a race | 14:10 |
dulek | thangp: If I understand it correctly. | 14:10 |
thangp | correct, that's what i mean | 14:11 |
thangp | we check the object state vs. the db state | 14:11 |
thangp | and compare | 14:11 |
*** rmesta has joined #openstack-cinder | 14:11 | |
dulek | I cannot see locks in the backups but checks should do it. | 14:12 |
dulek | Okay, great. I'm reworking the backups patch now. | 14:12 |
thangp | dulek: yeah...you could do it either way | 14:13 |
thangp | locks or checks in save() | 14:13 |
thangp | whichever one gives you better performance :) | 14:13 |
thangp | or both | 14:13 |
*** changbl has quit IRC | 14:13 | |
dulek | thangp: Would you mind if I start the discussion on this topic in cinder-meeting tomorrow? Having core team opinion on this will be beneficial. | 14:14 |
thangp | sure go for it | 14:14 |
dulek | thangp: ok, another news - there will be no oslo.versionedobjects release this week | 14:15 |
thangp | dulek: yeah...i didnt expect them to release anything anytime soon | 14:15 |
thangp | dulek: and any release might be potentially buggy | 14:15 |
thangp | until everything is ironed out | 14:15 |
*** rmstar has quit IRC | 14:16 | |
dulek | thangp: The release isn't probably much more than you did with forking the Nova code | 14:16 |
dulek | thangp: So I don't expect it won't be so much difference | 14:17 |
thangp | dulek: there were a few more things that got removed/moved/renamed | 14:17 |
*** navid__ has joined #openstack-cinder | 14:17 | |
thangp | dulek: but it should be ok | 14:17 |
dulek | thangp: anyway - I wanted to start to rewrite the base patch for current state of oslo.versionedobjects | 14:17 |
dulek | thangp: For now - only locally, no commits ;) | 14:18 |
thangp | dulek: thanks for helping me on it! | 14:18 |
*** rmstar has joined #openstack-cinder | 14:18 | |
thangp | dulek: refactoring the unit tests was a pain :P | 14:18 |
dulek | thangp: I saw the changelog, it definitely was ;) | 14:18 |
thangp | dulek: good luck, let me know if you have any questions | 14:19 |
dulek | thangp: so if you have no objections I'll start rewriting the base patch and see if there will be any problems | 14:19 |
thangp | base patch? | 14:19 |
thangp | the nova objects base? | 14:20 |
dulek | thangp: Cinder objects base I mean. | 14:20 |
thangp | for...? | 14:20 |
thangp | the expected_state stuff? | 14:20 |
*** dustins has joined #openstack-cinder | 14:21 | |
dulek | I meant oslo.versionedobjects. I plan to use current state of their repo so transition would be painless once they release. | 14:21 |
thangp | for your backup objects or for everything? | 14:21 |
dulek | I was thinking of everything. | 14:22 |
dulek | Or do you prefer another approach - creating _new_ patch that depends on Backup's patch? | 14:22 |
thangp | err...i really dont know when versionedobjects would be released...and the current patches we have up are ready | 14:22 |
thangp | so rebasing everything to oslo.versionedobjects might delay us getting anything into kilo | 14:23 |
thangp | if oslo.versionedobjects is releases really close to the deadline | 14:23 |
thangp | not opposed to using oslo.versionobjects...but we need some runway to test it out | 14:24 |
dulek | thangp: true, that's why I don't want to commit it to gerrit - just to have patch ready | 14:24 |
thangp | ah ok | 14:24 |
thangp | sure | 14:24 |
thangp | we can still look at it | 14:24 |
dulek | thangp: maybe it'll make into K, maybe in L | 14:24 |
dulek | thangp: but to have it ready would be cool I think | 14:25 |
thangp | maybe have another patch after your backup patch reworking it to oslo.versionedobjects? | 14:25 |
thangp | is that what you mean? | 14:25 |
dulek | thangp: That's another approach. Now as you shared your concerns about getting objects into Kilo I think this will be better approach. | 14:25 |
thangp | dulek: ok cool, so just to confirm...you will create a child patch after your backup objects one that would rebase things to oslo.versionedobjects? | 14:27 |
dulek | thangp: yes, this is how I want to proceed | 14:27 |
thangp | dulek: i good with that, thx | 14:27 |
dulek | thangp: don't worry, I wasn't planning to touch your patches without permission ;) | 14:28 |
thangp | dulek: thx | 14:28 |
*** nellysmitt has quit IRC | 14:28 | |
dulek | thangp: okay, so one last thing - I have one more developer on the team who can work on Cinder objectification | 14:28 |
*** nshaikh has left #openstack-cinder | 14:29 | |
thangp | dulek: sure | 14:29 |
*** bkopilov has joined #openstack-cinder | 14:29 | |
*** nellysmitt has joined #openstack-cinder | 14:29 | |
*** navid__ has left #openstack-cinder | 14:29 | |
*** nellysmitt has quit IRC | 14:29 | |
*** bill_az has joined #openstack-cinder | 14:29 | |
*** timcl has joined #openstack-cinder | 14:29 | |
*** nellysmitt has joined #openstack-cinder | 14:29 | |
dulek | thangp: I wonder if it would be better if he starts to create a new object (Service perhaps) or try to replace rest of Snapshots DB accesses with objects. | 14:29 |
dulek | thangp: (in a dependent patch of course) | 14:30 |
thangp | dulek: anywhere...i guess | 14:30 |
thangp | dulek: service is probably the easiest | 14:30 |
dulek | So right now you're not planning to do the rest of Snapshots? | 14:31 |
thangp | dulek: i'm trying to figure out the snapshots get_all thing | 14:31 |
thangp | dulek: then planning on the rest of volume | 14:31 |
*** pdeore_ has quit IRC | 14:32 | |
thangp | dulek: there are CG groups, service, ... | 14:32 |
*** markvoelker has quit IRC | 14:32 | |
thangp | that need to switch to objects | 14:32 |
*** markvoelker has joined #openstack-cinder | 14:33 | |
dulek | thangp: Okay, I understand that you advise to go on with a new object. | 14:33 |
*** mtanino has quit IRC | 14:34 | |
thangp | dulek: it depends on where he/she wants to work on - service, volume, volume type, snapshot, quota, backup, consistency group and consistency group snapshot objects | 14:34 |
thangp | aside from the ones we already have...service, volume type, quota, and consistency groups are left | 14:35 |
dulek | thangp: I need to step out for a moment, will message you a bit later | 14:36 |
thangp | ok...and then we have to switch the rest of the code to use objects, i.e. drivers and such | 14:36 |
thangp | to use the dot notation | 14:36 |
*** markvoelker has quit IRC | 14:38 | |
*** ebalduf has joined #openstack-cinder | 14:38 | |
*** ebalduf has quit IRC | 14:42 | |
*** mriedem has joined #openstack-cinder | 14:47 | |
openstackgerrit | Huang Zhiteng proposed openstack/cinder: Allow scheduler to receive volume stats when starting service https://review.openstack.org/158623 | 14:49 |
openstackgerrit | Petrut Lucian proposed openstack/cinder: SMBFS: Fix retrieving total allocated size https://review.openstack.org/158713 | 14:49 |
openstackgerrit | Huang Zhiteng proposed openstack/cinder: Allow scheduler to receive volume stats when starting service https://review.openstack.org/158623 | 14:51 |
openstackgerrit | Petrut Lucian proposed openstack/cinder: SMBFS: Fix retrieving total allocated size https://review.openstack.org/158713 | 14:51 |
*** nellysmitt has quit IRC | 14:55 | |
*** Mandell has joined #openstack-cinder | 14:55 | |
*** emagana has quit IRC | 15:04 | |
*** emagana has joined #openstack-cinder | 15:05 | |
*** alexpilotti has quit IRC | 15:07 | |
*** Mandell has quit IRC | 15:09 | |
dulek | thangp: Sorry for that, I've had ad-hoc meeting. | 15:09 |
*** jungleboyj has joined #openstack-cinder | 15:10 | |
thangp | dulek: np | 15:10 |
*** emagana has quit IRC | 15:10 | |
dulek | thangp: I would prefer to complete work on Snapshots first but if you're already working on that there's no need to overlap. | 15:10 |
thangp | dulek: ok | 15:10 |
dulek | thangp: So it's your call I guess if you need any help there? | 15:11 |
thangp | dulek: we can start on the service object | 15:11 |
thangp | that should be simple to implement | 15:11 |
*** amoturi has quit IRC | 15:11 | |
dulek | thangp: OK, understood. :) | 15:11 |
*** amoturi has joined #openstack-cinder | 15:11 | |
thangp | dulek: ok cool, thx | 15:11 |
*** Manshoon has joined #openstack-cinder | 15:12 | |
dulek | thangp: Thanks for syncing up! | 15:12 |
thangp | sure np | 15:12 |
*** nlevinki has quit IRC | 15:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/157642 | 15:14 |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:16 | |
bswartz | thingee: awake yet? | 15:16 |
*** Yogi1 has quit IRC | 15:17 | |
bswartz | I have a question for anyone who was in austin last month | 15:17 |
*** nellysmitt has joined #openstack-cinder | 15:18 | |
jungleboyj | bswartz: Yes sirt? | 15:18 |
bswartz | when we were talking about API versions and extensions, someone mentioned a way to query for the list of enabled extensions | 15:18 |
bswartz | does anyone remember that and remember how to do it? | 15:18 |
jungleboyj | bswartz: Are you talking about querying Keystone? | 15:19 |
smcginnis | bswartz: I remember but do not recall how. I thingee brought that up. | 15:19 |
smcginnis | *think thingee | 15:19 |
bswartz | no I'm referring to all the different APIs implemented in contrib as extensions | 15:19 |
*** Yogi1 has joined #openstack-cinder | 15:19 | |
bswartz | everyone agreed it was a bad idea, but I didn't hear a solution proposed | 15:20 |
jungleboyj | bswartz: Oh, yeah, I vaguely remember that but don't remember how. | 15:20 |
bswartz | k | 15:20 |
jungleboyj | bswartz: Think that was when I was trying to deal with the migration mess. | 15:20 |
smcginnis | If only someone would have taken detailed notes. | 15:20 |
smcginnis | :P | 15:20 |
bswartz | lol | 15:21 |
jungleboyj | smcginnis: :-p | 15:21 |
bswartz | jay takes excellent notes | 15:21 |
smcginnis | bswartz: Totally agree! Way better than I ever do. | 15:21 |
jungleboyj | I ahve to do that or I don't pay attention in long meetings like that. | 15:22 |
jungleboyj | Or IRC meetings. | 15:22 |
smcginnis | jungleboyj: Good strategy. I wander off too often and have to remind myself to pay attention. :) | 15:23 |
*** mtanino has joined #openstack-cinder | 15:23 | |
openstackgerrit | Jay Bryant proposed openstack/cinder: Sync scheduler module from oslo-incubator https://review.openstack.org/158534 | 15:23 |
*** devlaps has joined #openstack-cinder | 15:24 | |
*** devlaps has quit IRC | 15:24 | |
*** deepakcs has joined #openstack-cinder | 15:25 | |
bswartz | in IRC meetings the bot takes notes for you | 15:26 |
akerr | bswartz: sounds like a bad "in communist russia..." joke | 15:26 |
smcginnis | In Soviet Russia the notes take you? :D | 15:26 |
bswartz | I only have problems in teleconferences and face to face meetings remembering what was said | 15:27 |
smcginnis | akerr: :) | 15:27 |
akerr | smcginnis: +1 | 15:27 |
*** primechuck has joined #openstack-cinder | 15:31 | |
*** nellysmitt has quit IRC | 15:32 | |
*** emaisne_ has joined #openstack-cinder | 15:32 | |
*** nellysmitt has joined #openstack-cinder | 15:32 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Remove use of contextlib.nested https://review.openstack.org/158732 | 15:34 |
*** emaisne has quit IRC | 15:36 | |
openstackgerrit | Eric Brown proposed openstack/cinder: Password config options should be marked secret https://review.openstack.org/158590 | 15:36 |
*** emaisne_ has quit IRC | 15:37 | |
*** ebalduf has joined #openstack-cinder | 15:39 | |
*** ebalduf has quit IRC | 15:44 | |
*** aviramb has joined #openstack-cinder | 15:45 | |
*** david-lyle_afk is now known as david-lyle | 15:47 | |
*** markvoelker has joined #openstack-cinder | 15:49 | |
*** rushiagr is now known as rushiagr_away | 15:50 | |
*** lpetrut has quit IRC | 15:54 | |
*** BharatK has joined #openstack-cinder | 15:56 | |
*** vilobhmm has joined #openstack-cinder | 15:57 | |
*** annegent_ has joined #openstack-cinder | 15:58 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Add volume multi attach support https://review.openstack.org/85847 | 15:59 |
*** amoturi1 has joined #openstack-cinder | 16:01 | |
*** coolsvap is now known as coolsvap_ | 16:02 | |
openstackgerrit | Mikhail Khodos proposed openstack/cinder: Nexenta Edge iSCSI backend driver. https://review.openstack.org/158745 | 16:03 |
*** annashen has joined #openstack-cinder | 16:03 | |
*** amoturi1 has quit IRC | 16:04 | |
*** amoturi1 has joined #openstack-cinder | 16:04 | |
*** Mandell has joined #openstack-cinder | 16:06 | |
*** vilobhmm has quit IRC | 16:06 | |
*** lpetrut has joined #openstack-cinder | 16:07 | |
openstackgerrit | Huang Zhiteng proposed openstack/cinder: Allow scheduler to receive volume stats when starting service https://review.openstack.org/158623 | 16:08 |
*** annashen has quit IRC | 16:08 | |
*** hodos has joined #openstack-cinder | 16:08 | |
*** btran has joined #openstack-cinder | 16:10 | |
*** lcurtis has joined #openstack-cinder | 16:10 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Allow archiving deleted rows to shadow tables, for performance https://review.openstack.org/131182 | 16:12 |
*** emagana has joined #openstack-cinder | 16:12 | |
*** mdenny has joined #openstack-cinder | 16:13 | |
*** jamielennox is now known as jamielennox|away | 16:15 | |
*** jamielennox|away is now known as jamielennox | 16:16 | |
*** changbl has joined #openstack-cinder | 16:16 | |
*** ronis has quit IRC | 16:18 | |
*** rhe00 has quit IRC | 16:18 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Allow archiving deleted rows to shadow tables, for performance https://review.openstack.org/131182 | 16:21 |
*** dannywilson has joined #openstack-cinder | 16:23 | |
*** tbarron has joined #openstack-cinder | 16:23 | |
*** tsekiyama has joined #openstack-cinder | 16:25 | |
*** tsekiyama has quit IRC | 16:26 | |
*** tsekiyama has joined #openstack-cinder | 16:26 | |
*** Mandell has quit IRC | 16:27 | |
*** dencaval has joined #openstack-cinder | 16:28 | |
*** jdurgin1 has joined #openstack-cinder | 16:28 | |
*** TobiasE has quit IRC | 16:29 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: FCZM fix reading of cinder config entries https://review.openstack.org/158776 | 16:34 |
*** yatin has joined #openstack-cinder | 16:39 | |
*** deepakcs has quit IRC | 16:40 | |
*** ebalduf has joined #openstack-cinder | 16:40 | |
*** _cjones_ has joined #openstack-cinder | 16:40 | |
*** _cjones_ has quit IRC | 16:41 | |
yatin | how to change owner in git review | 16:41 |
*** _cjones_ has joined #openstack-cinder | 16:42 | |
*** alecv has quit IRC | 16:43 | |
dulek | yatin: It's impossible as far as I know | 16:43 |
yatin | dulek: then how can i submit a patch to a already opened review | 16:44 |
*** ebalduf has quit IRC | 16:44 | |
dulek | yatin: You just amend your changes and do git review. | 16:45 |
yatin | dulek: I did this but the owner remained the same as before | 16:46 |
*** _cjones_ has quit IRC | 16:46 | |
*** jcru has joined #openstack-cinder | 16:46 | |
*** _cjones_ has joined #openstack-cinder | 16:46 | |
*** jcru has quit IRC | 16:47 | |
dulek | yatin: So I don't know how to help you. Downloading the patch, amending my changes and doing git review always worked for me. | 16:47 |
*** lpetrut has quit IRC | 16:48 | |
yatin | dulek: i checked out master, did changes, added changeID(of already submitted patch) in commit message and submitted for review | 16:51 |
smcginnis | yatin: I don't believe that's right. | 16:52 |
smcginnis | You would have had to check out their review, not master. | 16:52 |
smcginnis | Then just update and ammend it. | 16:53 |
yatin | ok | 16:53 |
yatin | thanks | 16:53 |
smcginnis | yatin: I remember seeing a guide somewhere. I'll see if I can track that down. | 16:53 |
yatin | smcginnis: it will be good if you can share | 16:54 |
smcginnis | yatin: It's basically this process: https://wiki.openstack.org/wiki/Documentation/HowTo#How_to_amend_a_review-in-progress | 16:56 |
smcginnis | Though I thought I read something somewhere specifically about updating someone else's commit. | 16:57 |
*** yatin has quit IRC | 16:57 | |
thangp | smcginnis: https://wiki.openstack.org/wiki/Gerrit_Workflow | 16:57 |
thangp | ? | 16:57 |
thangp | there's a section on "Maintaining Dependency Chains" | 16:58 |
*** emagana has quit IRC | 16:58 | |
*** emagana has joined #openstack-cinder | 16:59 | |
smcginnis | thangp: +1 that's good background too yatin if you have not read that. | 17:00 |
*** BaconIsKing has joined #openstack-cinder | 17:02 | |
*** esker has joined #openstack-cinder | 17:03 | |
*** emagana has quit IRC | 17:03 | |
*** emagana has joined #openstack-cinder | 17:05 | |
e0ne | new issues with running unit tests with concurrency>1. :( | 17:06 |
*** amoturi1 has quit IRC | 17:06 | |
*** annegent_ has quit IRC | 17:06 | |
*** Apoorva has joined #openstack-cinder | 17:09 | |
*** annegent_ has joined #openstack-cinder | 17:10 | |
*** amoturi1 has joined #openstack-cinder | 17:11 | |
*** nkrinner has quit IRC | 17:15 | |
*** nellysmitt has quit IRC | 17:17 | |
*** markstur has quit IRC | 17:18 | |
*** jistr has quit IRC | 17:18 | |
*** nellysmitt has joined #openstack-cinder | 17:18 | |
*** rwsu-afk is now known as rwsu | 17:18 | |
*** erlon has joined #openstack-cinder | 17:19 | |
*** emagana has quit IRC | 17:19 | |
*** coolsvap_ is now known as coolsvap | 17:20 | |
openstackgerrit | Shay Halsband proposed openstack/cinder: XtreamIO version 4.0 support https://review.openstack.org/152973 | 17:21 |
*** rhe00_ has joined #openstack-cinder | 17:21 | |
*** jungleboyj has quit IRC | 17:23 | |
*** bill_az has quit IRC | 17:25 | |
*** kallebe has joined #openstack-cinder | 17:25 | |
*** afazekas has quit IRC | 17:26 | |
*** vilobhmm has joined #openstack-cinder | 17:27 | |
*** Ilja has joined #openstack-cinder | 17:27 | |
*** emagana has joined #openstack-cinder | 17:28 | |
*** annashen has joined #openstack-cinder | 17:28 | |
*** afazekas has joined #openstack-cinder | 17:28 | |
kallebe | Hello. Does CI have a SAN storage which I can to test for SAN generic driver? | 17:28 |
Ilja | Hello, is there anyone here from HP/3par driver team? There's a pretty critical bug on cinder for a while that doesn't seem to be addressed. | 17:30 |
*** bill_az has joined #openstack-cinder | 17:30 | |
*** leeantho has joined #openstack-cinder | 17:30 | |
*** ronis has joined #openstack-cinder | 17:30 | |
hemnafk | ? | 17:31 |
*** hemnafk is now known as hemna | 17:31 | |
hemna | Ilja, ? | 17:31 |
*** markstur has joined #openstack-cinder | 17:31 | |
*** _cjones_ has quit IRC | 17:33 | |
hemna | must not be that urgent | 17:35 |
*** _cjones_ has joined #openstack-cinder | 17:36 | |
*** annegent_ has quit IRC | 17:37 | |
*** timcl has quit IRC | 17:39 | |
*** rhe00_ is now known as rhe00 | 17:40 | |
openstackgerrit | Tomoki Sekiyama proposed openstack/cinder: Limit volume copy bandwidth per backend https://review.openstack.org/149446 | 17:40 |
*** ebalduf has joined #openstack-cinder | 17:41 | |
*** lpetrut has joined #openstack-cinder | 17:42 | |
*** ebalduf has quit IRC | 17:45 | |
*** jungleboyj has joined #openstack-cinder | 17:49 | |
*** fischerw has joined #openstack-cinder | 17:55 | |
*** karimb has quit IRC | 17:56 | |
*** rhagarty has quit IRC | 17:56 | |
Ilja | @hemna, sorry, urgent, but irc client is not so stable | 17:57 |
Ilja | I was referring to this one: https://bugs.launchpad.net/cinder/+bug/1416836 | 17:57 |
openstack | Launchpad bug 1416836 in Cinder "Cinder 3PAR driver does not convert volume to base when restoring from snapshot" [Undecided,New] | 17:57 |
hemna | Ilja, yes, that's how it's suppose to work | 17:58 |
hemna | snapshots are not base volumes | 17:59 |
hemna | if you want base volumes, you clone it. | 17:59 |
hemna | otherwise it's not a snapshot | 17:59 |
*** coolsvap is now known as coolsvap_ | 18:00 | |
*** annegent_ has joined #openstack-cinder | 18:01 | |
Ilja | well, the bug is not about that | 18:03 |
Ilja | it's possible to create a volume from snapshot in openstack terms | 18:03 |
Ilja | but volume/snapshot have a bit different meaning in HP 3PAR | 18:03 |
hemna | yes, which is a r/w snapshot | 18:03 |
hemna | it's not a base volume. | 18:03 |
Ilja | right | 18:03 |
hemna | if you want a base volume, you have to clone it. | 18:03 |
hemna | that's how 3PAR works. | 18:03 |
hemna | this is not a driver bug | 18:04 |
hemna | nor a 3PAR bug | 18:04 |
Ilja | not really — it's possible to switch a snapshot volume to a base volume | 18:04 |
hemna | it's a feature. :) | 18:04 |
*** annashen_ has joined #openstack-cinder | 18:04 | |
*** dulek has quit IRC | 18:04 | |
hemna | Ilja, that's a clone | 18:04 |
hemna | you have to clone the volume to get a base volume. | 18:04 |
hemna | which is what I mentioned above. | 18:04 |
Ilja | well, I do feel it's a bug — conversion _does_ happen if the size of a cloned volume is larger. And _doesn't_ if the size is the same | 18:04 |
Ilja | let'me look up code pointers | 18:05 |
*** Mandell has joined #openstack-cinder | 18:06 | |
*** kmartin has quit IRC | 18:06 | |
Ilja | https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/san/hp/hp_3par_common.py#L1354 | 18:07 |
Ilja | now what if https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/san/hp/hp_3par_common.py#L1350 is False? | 18:07 |
*** ndipanov has quit IRC | 18:07 | |
hemna | hrmm | 18:08 |
*** annashen_ has quit IRC | 18:09 | |
hemna | so it looks like we try and comply with the new size, but creating a base volume | 18:09 |
hemna | if the size of the volume from snap is bigger than the original snap | 18:09 |
Ilja | actually, this flow _must_ be creating a base volume in 3PAR terms | 18:10 |
hemna | but if they are the same, then we don't. because it's only a r/w snapshot for a new volume. | 18:10 |
hemna | only to support bigger sizes | 18:10 |
Ilja | r/w is only part of the lifecycle | 18:10 |
hemna | but if it's the same size, you don't want a new base volume | 18:11 |
hemna | because it actually occupies more storage on the array | 18:11 |
hemna | snaps are just diffs | 18:11 |
Ilja | it introduces dependency on 3par level, which is not visible to openstack | 18:11 |
*** devlaps has joined #openstack-cinder | 18:11 | |
hemna | volumes from snaps always have deps | 18:11 |
Ilja | so imagine you are creating a volume with 'snapshot_to_volume' function | 18:11 |
hemna | otherwise it's not a snapshot | 18:11 |
hemna | don't use snapshots if you don't want deps. | 18:11 |
hemna | clone. | 18:11 |
Ilja | eee, what? In my world 'volume' is always a standalone entity I can delete. It can _have_ snapshots, that stop it from deletion, but if it doesn't have snapshots, I should be able to delete it | 18:12 |
hemna | Ilja, no | 18:13 |
hemna | you are wrong | 18:13 |
hemna | volumes from snapshots on 3PAR are not base volumes. | 18:13 |
hemna | if you want a base volume, create a clone. | 18:13 |
hemna | I can only say that so many times. | 18:13 |
hemna | invalid bug. | 18:13 |
Ilja | But look, do you agree that then the following openstack (not 3par!) behaviour is incorrect: | 18:14 |
hemna | no | 18:14 |
Ilja | - I see a volume. It doesn't have any snapshots. I issues a DELETE request. Systems says 202. | 18:14 |
Ilja | - Nothing happens. In logs on debug level I see a message from 3par saying that the volume is in hierarchy (or smth similar, don't remember the exact wording) | 18:14 |
*** lpetrut has quit IRC | 18:15 | |
*** Longgeek has quit IRC | 18:15 | |
Ilja | and I have no means with OpenStack (no metadata, no links) to detect how the deletion of this volume should happen | 18:15 |
*** marcusvrn1 has quit IRC | 18:16 | |
*** ronis has quit IRC | 18:16 | |
*** changbl has quit IRC | 18:17 | |
*** marcusvrn1 has joined #openstack-cinder | 18:18 | |
*** cdelatte has joined #openstack-cinder | 18:19 | |
*** harlowja has joined #openstack-cinder | 18:20 | |
*** patrickeast has joined #openstack-cinder | 18:20 | |
*** annegent_ has quit IRC | 18:22 | |
vilobhmm | thingee : ping | 18:23 |
*** harlowja has quit IRC | 18:24 | |
*** harlowja has joined #openstack-cinder | 18:24 | |
*** changbl has joined #openstack-cinder | 18:27 | |
*** asmith_brcd has joined #openstack-cinder | 18:27 | |
vilobhmm | dulek : ping yt ? | 18:27 |
*** marcusvrn has joined #openstack-cinder | 18:28 | |
*** jordanP has quit IRC | 18:29 | |
*** marcusvrn1 has quit IRC | 18:29 | |
*** aix has quit IRC | 18:29 | |
hemna | hodos, https://wiki.openstack.org/wiki/Cinder/how-to-contribute-a-driver | 18:30 |
*** diegows has quit IRC | 18:30 | |
hodos | hemna: thanks | 18:31 |
*** jungleboyj has quit IRC | 18:31 | |
hemna | np | 18:31 |
hemna | hodos, but please don't stop working on it. Feel free to solicit feedback and reviews, just be aware that drivers are not a priority right now | 18:31 |
hodos | ok | 18:32 |
*** diemt has quit IRC | 18:33 | |
openstackgerrit | Anthony Lee proposed openstack/cinder: HP 3par driver filter and evaluator function https://review.openstack.org/151353 | 18:33 |
*** diemt has joined #openstack-cinder | 18:34 | |
*** ronis has joined #openstack-cinder | 18:34 | |
openstackgerrit | Huang Zhiteng proposed openstack/cinder: Allow scheduler to receive volume stats when starting service https://review.openstack.org/158623 | 18:38 |
Ilja | @hemna - I know I'm being annoying, but could you please comment on the this comment: https://bugs.launchpad.net/cinder/+bug/1416836/comments/5 ? We are running a somewhat big deployment with HP 3par and this issue is hitting us badly. Could you perhaps comment on what could be a correct way of treating of such immortal volumes? | 18:41 |
openstack | Launchpad bug 1416836 in Cinder "Cinder 3PAR driver does not convert volume to base when restoring from snapshot" [Undecided,Invalid] | 18:41 |
*** ebalduf has joined #openstack-cinder | 18:41 | |
*** jdurgin1 has quit IRC | 18:42 | |
*** timcl has joined #openstack-cinder | 18:44 | |
*** ebalduf has quit IRC | 18:46 | |
*** krtaylor has quit IRC | 18:48 | |
*** amoturi1 has quit IRC | 18:50 | |
*** marcusvrn1 has joined #openstack-cinder | 18:52 | |
*** marcusvrn has quit IRC | 18:52 | |
*** jcru has joined #openstack-cinder | 18:52 | |
kallebe | Hello. Does CI(Jenkins) have a SAN storage which I can to test for SAN generic driver? | 18:54 |
*** timcl has quit IRC | 18:54 | |
*** kmartin has joined #openstack-cinder | 18:55 | |
*** timcl has joined #openstack-cinder | 18:55 | |
smcginnis | kallebe: Which CI do you mean? The gate, or a local CI you have set up? | 18:56 |
kallebe | smcginnis the gate | 18:56 |
smcginnis | kallebe: I believe it uses LVM. | 18:57 |
kallebe | smcginnis ok, thanks. | 18:57 |
smcginnis | kallebe: np | 18:57 |
*** changbl has quit IRC | 18:58 | |
*** jungleboyj has joined #openstack-cinder | 18:58 | |
*** amoturi1 has joined #openstack-cinder | 18:58 | |
*** krtaylor has joined #openstack-cinder | 19:00 | |
*** lpetrut has joined #openstack-cinder | 19:01 | |
*** timcl has quit IRC | 19:02 | |
*** emagana has quit IRC | 19:03 | |
*** annegent_ has joined #openstack-cinder | 19:03 | |
*** emagana has joined #openstack-cinder | 19:04 | |
*** bill_az has quit IRC | 19:04 | |
*** hodos has quit IRC | 19:06 | |
*** amoturi1 has quit IRC | 19:06 | |
*** timcl has joined #openstack-cinder | 19:12 | |
*** Longgeek has joined #openstack-cinder | 19:15 | |
* e0ne wants do delete test_huawei_t_dorado :( | 19:16 | |
*** _cjones_ has quit IRC | 19:16 | |
*** jcru has quit IRC | 19:18 | |
*** jcru has joined #openstack-cinder | 19:18 | |
*** _cjones_ has joined #openstack-cinder | 19:21 | |
*** thingee has joined #openstack-cinder | 19:22 | |
*** Mandell has quit IRC | 19:23 | |
*** annegent_ has quit IRC | 19:23 | |
*** eharney has joined #openstack-cinder | 19:24 | |
thingee | eharney: what's up with the blocking bugs on nova side for this https://review.openstack.org/#/c/147186/ | 19:24 |
*** rushil has quit IRC | 19:25 | |
*** avishay has joined #openstack-cinder | 19:25 | |
eharney | thingee: currently i'm the only one working to fix them and haven't gotten too far. Nobody liked my initial "do this as root" patch, looks like some work is needed to have Nova query some volume info in a different way | 19:26 |
thingee | jgriffith: you've been summoned on https://review.openstack.org/#/c/135002/ | 19:26 |
eharney | thingee: (it picks through libvirt info to figure out some things which it should probably calculate via other means) | 19:26 |
thingee | eharney: are we still planning to have this ready for march 1st to land in K? | 19:26 |
smcginnis | thingee: Could you take a look at the response to your concerns in https://review.openstack.org/#/c/155894/ when you get a moment? | 19:26 |
*** annegent_ has joined #openstack-cinder | 19:26 | |
thingee | tbarron: https://review.openstack.org/#/c/149726/ | 19:27 |
eharney | thingee: Hard to say... possible but I don't know that it's too likely. (I've been out of the office for a few days with a move, just diving back in a bit now.) | 19:27 |
thingee | eharney: traveling and a move. fun! | 19:28 |
tbarron | thingee: I need to recheck | 19:28 |
thingee | that's how I felt with atlanta summit =/ | 19:28 |
eharney | thingee: Yes, the fun never ends... I'm hanging out for hours in the airport now with snow delaying my flight. :) | 19:28 |
thingee | smcginnis: I interpret that example as don't do this for LOG.exception... in the case I raised it for it's LOG.error | 19:30 |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Implement IET target driver https://review.openstack.org/158829 | 19:30 |
smcginnis | thingee: My understanding is anything passed in to an exception should not have _Lx(), only _(). | 19:31 |
smcginnis | thingee: Who can confirm (or deny) that? | 19:31 |
thingee | then don't pass the translation into the exception. It's still a log. we should be translating it | 19:31 |
*** marcusvrn has joined #openstack-cinder | 19:32 | |
smcginnis | It will be translated by the _(). Just not put in the LE catalog. | 19:32 |
thingee | smcginnis: http://paste.openstack.org/show/181387/ | 19:33 |
smcginnis | thingee: Aha, here's the relevant bit: "The log marker functions (_LI(), _LW(), _LE(), and _LC()) must only be used when the message is only sent directly to the log. Anytime that the message will be passed outside of the current context (for example as part of an exception) the _() marker function must be used." | 19:33 |
*** devlaps has quit IRC | 19:33 | |
smcginnis | thingee: Make sense to you? | 19:34 |
*** BharatK has quit IRC | 19:34 | |
thingee | smcginnis: not exactly. See my example. | 19:34 |
thingee | I understand msg is being passed around, however, it's directly being translated within the LOG.error | 19:35 |
thingee | the translation never leaves that context | 19:35 |
*** marcusvrn1 has quit IRC | 19:35 | |
smcginnis | thingee: I see what you're saying. But that statement from the i18n guidelines seems to support the way I have it. | 19:35 |
thingee | smcginnis: honestly it's not clear to me with what I just raised. | 19:35 |
smcginnis | thingee: In your example the exception would not be translated. | 19:35 |
thingee | there seems to be a bit of a gap with it's msg = _LE('LOLOLO') or msg = 'LOLOLO' | 19:35 |
thingee | correct | 19:36 |
thingee | so the translation is NOT being passed | 19:36 |
smcginnis | thingee: But it should be. | 19:36 |
thingee | only the message. | 19:36 |
thingee | passed around* | 19:36 |
smcginnis | thingee: The only thing we don't want translated are debug messages, no? | 19:36 |
thingee | as I understood, yes | 19:36 |
smcginnis | So it would need to be translated somehow before being passed to exception.Laugh(). | 19:37 |
smcginnis | thingee: And the guidelines say then to use _(). | 19:37 |
smcginnis | thingee: We could do exception.Laugh(_(msg)), but it says not to do two different translations. | 19:38 |
thingee | smcginnis: this is honestly confusing, and I think we need someone to confirm instead of us attempting to interpret it. The example you linked to shows doing LOG.exception(_LE('There was an error.')) | 19:38 |
thingee | raise LocalExceptionClass(_('An error occured.')) | 19:39 |
smcginnis | thingee: But the statement above says if it's going to a log and an exception then use _(). | 19:39 |
smcginnis | thingee: That part at least seems pretty explicit to me. | 19:39 |
thingee | so do that. I'm now saying making sure the LOG.error has LE() | 19:39 |
thingee | the current patch does not do that | 19:40 |
smcginnis | thingee: That would be against that statement though. | 19:40 |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Clear migration_status from a destination volume if migration fails https://review.openstack.org/154739 | 19:40 |
smcginnis | thingee: _Lx() used if _only_ going to the log, _() used if used multiple places. | 19:40 |
*** emaisne has joined #openstack-cinder | 19:40 | |
hemna | xyang, https://review.openstack.org/#/c/158776 | 19:40 |
thingee | smcginnis: sorry, but the doc still says: | 19:41 |
thingee | # RIGHT | 19:41 |
thingee | LOG.exception(_LE('There was an error.')) | 19:41 |
thingee | raise LocalExceptionClass(_('An error occured.')) | 19:42 |
thingee | so we need clarification | 19:42 |
*** ebalduf has joined #openstack-cinder | 19:42 | |
openstackgerrit | Steven Kaufer proposed openstack/cinder: GET volumes API sorting REST/volume/DB updates https://review.openstack.org/141915 | 19:42 |
openstackgerrit | Steven Kaufer proposed openstack/cinder: GET volumes API sorting enhancements common utilities https://review.openstack.org/141914 | 19:42 |
smcginnis | thingee: In the example. But this is pretty explicit: "Anytime that the message will be passed outside of the current context (for example as part of an exception) the _() marker function must be used" | 19:42 |
thingee | smcginnis: get clarification. | 19:43 |
smcginnis | thingee: Any idea who can clear that up? | 19:43 |
smcginnis | thingee: Not sure where to go for that. | 19:43 |
thingee | dhellmann probably, but he's a busy guy | 19:43 |
*** e0ne has quit IRC | 19:43 | |
smcginnis | thingee: OK. Seems trivial, but we should clear this up. It's used many places. | 19:44 |
*** Miouge has quit IRC | 19:44 | |
smcginnis | dhellmann: Not sure if you're around and available, but if you could comment on above that would be great. | 19:45 |
patrickeast | jgriffith: hey, you around? | 19:46 |
*** eharney has quit IRC | 19:46 | |
*** ebalduf has quit IRC | 19:46 | |
openstackgerrit | Danny Wilson proposed openstack/cinder: Over subscription for Pure Storage iSCSI driver. https://review.openstack.org/157681 | 19:48 |
kaufer | thingee: If you have a minute, can you lok at this review? It hasn't been updated since the mid-cycle meetup: https://review.openstack.org/#/c/148373/ ... anything I should be doing for it? | 19:48 |
*** avishay has quit IRC | 19:48 | |
thingee | smcginnis, dhellmann: I've responded to this review. https://review.openstack.org/#/c/155894/ | 19:50 |
openstackgerrit | Danny Wilson proposed openstack/cinder: Over subscription for Pure Storage iSCSI driver. https://review.openstack.org/157681 | 19:51 |
thingee | smcginnis: if you need someone for clarification, look at git. Whoever worked on the library and or docs | 19:51 |
openstackgerrit | Kallebe Monteiro proposed openstack/cinder: pep8 E251 (keyword arguments and spaces) cleanup https://review.openstack.org/158840 | 19:52 |
*** casusbelli has joined #openstack-cinder | 19:52 | |
smcginnis | thingee: Sorry if I came of too hard. Just trying to understand and make sure we are using this right. | 19:53 |
*** annegent_ has quit IRC | 19:54 | |
xyang | hemna: you fixed it? cool! I'll take a look soon | 19:55 |
*** avishay has joined #openstack-cinder | 19:56 | |
hemna | xyang, yah | 19:58 |
*** jcru has quit IRC | 19:58 | |
casusbelli | jgriffith: Hi! Again lurking for you regarding sos-ci, have a minute? :-) | 19:59 |
*** kallebe has quit IRC | 20:01 | |
*** avishay has quit IRC | 20:01 | |
*** dencaval has quit IRC | 20:04 | |
*** sandywalsh_ is now known as sandywalsh | 20:04 | |
*** annegent_ has joined #openstack-cinder | 20:04 | |
*** amoturi1 has joined #openstack-cinder | 20:05 | |
*** amoturi1 is now known as amoturi_ | 20:05 | |
*** annashen_ has joined #openstack-cinder | 20:05 | |
*** BaconIsKing has quit IRC | 20:05 | |
xyang | thingee: hi, xtremio driver is update: https://review.openstack.org/#/c/152973/8 | 20:09 |
xyang | thingee: I have one question for you | 20:09 |
hemna | thingee, are you in the TC meeting ? os-brick is an agenda item, fwiw. | 20:09 |
*** annashen_ has quit IRC | 20:10 | |
xyang | hemna: isn't os-brick already under cinder? | 20:10 |
hemna | yes | 20:10 |
hemna | it's a governance change | 20:10 |
xyang | hemna: ok | 20:10 |
hemna | not sure what the conversation will be about | 20:10 |
hemna | lurking :P | 20:10 |
xyang | hemna: :) | 20:11 |
*** sigmavirus24 is now known as sigmavirus24_awa | 20:11 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 20:13 | |
*** ronis has quit IRC | 20:14 | |
*** nellysmitt has quit IRC | 20:26 | |
*** lcurtis has quit IRC | 20:26 | |
*** dalgaaf has quit IRC | 20:27 | |
jungleboyj | smcginnis: thingee Sean is right. If you have a message that is going to an exception, _() should be used for translation. | 20:29 |
jungleboyj | I.E. msg = _('My message') | 20:30 |
jungleboyj | LOG.error("Encountered exception: %s", msg) | 20:30 |
jungleboyj | cinder.exception(msg) | 20:31 |
jungleboyj | Or, cinder.exception(_('My error message')) | 20:31 |
jungleboyj | If not going to an exception do LOG.exception(_LE('My message')) | 20:32 |
smcginnis | jungleboyj: Would you mind taking a look at the specific example in question and see if that meets your understanding? | 20:33 |
smcginnis | jungleboyj: https://review.openstack.org/#/c/155894/2/cinder/volume/api.py | 20:33 |
mtanino | jungleboyj: hi, thank you for the review. | 20:34 |
jungleboyj | mtanino: You are welcome. Sorry for having so many comments. | 20:35 |
mtanino | jungleboyj: I saw a discussion about six.text_type about this https://review.openstack.org/#/c/154713/11/cinder/volume/targets/tgt.py yesterday on IRC. | 20:35 |
jungleboyj | mtanino: Ok, hold on. | 20:35 |
mtanino | jungleboyj: sure | 20:35 |
*** kvidvans has joined #openstack-cinder | 20:36 | |
smcginnis | mtanino, jungleboyj: We tried that out. No, you should not need six.text_type here. | 20:36 |
smcginnis | mtanino: It is being passed in to the logger which does handle it correctly. | 20:36 |
smcginnis | mtanino: Only an issue if you format the string first using % then pass just the string in to the logger. | 20:36 |
jungleboyj | smcginnis: Oh, that is right. | 20:37 |
*** asmith_brcd has quit IRC | 20:37 | |
jungleboyj | mtanino: smcginnis is right. | 20:37 |
smcginnis | xyang and I had to do some experimenting to confirm that. | 20:37 |
mtanino | jungleboyj: So, in my case, I don't need use six.text_type. right? | 20:37 |
smcginnis | mtanino: Correct | 20:37 |
jungleboyj | mtanino: Correct. You can disregard those comments. | 20:38 |
mtanino | smcginnis: jungleboyj thanks, I understand. | 20:38 |
jungleboyj | mtanino: Sorry for the confusion. | 20:39 |
mtanino | jungleboyj: logger is confusiong :( | 20:39 |
jungleboyj | mtanino: Tell me about it. | 20:39 |
smcginnis | These dang computer thingamajigs. | 20:40 |
*** dustins has quit IRC | 20:40 | |
jungleboyj | Tell me about it. | 20:41 |
*** asmith_brcd has joined #openstack-cinder | 20:42 | |
jungleboyj | smcginnis: I have Jim looking at that case to weigh in. He is the expert. I think you are correct but I want another opinion. | 20:42 |
*** ebalduf has joined #openstack-cinder | 20:43 | |
*** kaisers1 has joined #openstack-cinder | 20:43 | |
smcginnis | jungleboyj: Perfect, that's all I want. I'd like to make sure we are using this properly as it is all over the place. | 20:43 |
jungleboyj | smcginnis: Agreed. Jim helped write the code so he can give an authoritative answer. | 20:43 |
smcginnis | jungleboyj: Awesome! | 20:44 |
jungleboyj | Now, I need to figure out how to get the new oslo-config-generator to work for us. | 20:45 |
smcginnis | jungleboyj: Bet you didn't know the full extent of what you were signing up for when you became the captian. :) | 20:46 |
jungleboyj | smcginnis: You are right. | 20:46 |
jungleboyj | Don't want to admit how long it took for me to get the scheduler patch put together. | 20:47 |
*** rushil has joined #openstack-cinder | 20:47 | |
*** ebalduf has quit IRC | 20:48 | |
jungleboyj | smcginnis: Oh hey, it worked. I just accidentally put it in the wrong file name. | 20:50 |
jungleboyj | Now to figure out how to get all the right options in there. | 20:50 |
openstackgerrit | Abel Lopez proposed openstack/cinder: cinder-manage man update https://review.openstack.org/158861 | 20:52 |
smcginnis | jungleboyj: :) | 20:52 |
*** Manshoon_ has joined #openstack-cinder | 20:53 | |
*** BaconIsKing has joined #openstack-cinder | 20:54 | |
*** Manshoon has quit IRC | 20:56 | |
*** rushil_ has joined #openstack-cinder | 20:56 | |
*** rushil has quit IRC | 20:56 | |
*** akerr has quit IRC | 20:56 | |
*** akerr has joined #openstack-cinder | 20:57 | |
*** PaulCuzner has joined #openstack-cinder | 20:58 | |
*** Mandell has joined #openstack-cinder | 20:59 | |
thingee | xyang: thanks | 20:59 |
*** BaconIsKing has quit IRC | 20:59 | |
*** Lee1092 has quit IRC | 21:00 | |
thingee | hemna: I was not in the TC meeting. Was at lunch | 21:01 |
openstackgerrit | Bob Callaway proposed openstack/cinder: Add Manage/Unmanage support to NetApp NFS drivers https://review.openstack.org/158864 | 21:03 |
xyang | thingee: hi, so I tried the override option CONF.set_override('some_config_option', myvalue), it will always set some_config_option to myvalue whether it is already set in cinder.conf or not | 21:03 |
*** annegent_ has quit IRC | 21:04 | |
openstackgerrit | Angela Smith proposed openstack/cinder: Fix issue where custom zone name prefix not being used by brcd driver https://review.openstack.org/158866 | 21:04 |
thingee | jungleboyj: did you see my comment in https://review.openstack.org/#/c/155894/2/cinder/volume/api.py ? | 21:05 |
*** Manshoon has joined #openstack-cinder | 21:05 | |
thingee | xyang: can you check if it's set explicitly in the cinder.conf, and if not, override? | 21:07 |
xyang | thingee: sure, that should work, if that is acceptable | 21:07 |
*** Manshoon_ has quit IRC | 21:07 | |
xyang | thingee: so the current xtremio patch still uses its own provisioning_factor, I'll ask him to check cinder.conf and override it if not there | 21:08 |
thingee | xyang: I guess my only worry is you're overriding the default. The default is what's communicated to the user as what it'll be if you don't set it | 21:08 |
jungleboyj | thingee: Yes and just got someone who works on the library to respond. | 21:08 |
*** emaisne has quit IRC | 21:08 | |
xyang | thingee: I start to wonder if we should change the default to a higher number | 21:08 |
thingee | jungleboyj: ok, thank you! | 21:09 |
xyang | thingee: pure also has a much higher default | 21:09 |
thingee | xyang: changing default is fine, just can't backport it to stable. | 21:09 |
thingee | xyang: I think changing the default is fine | 21:09 |
xyang | thingee: it is not released yet | 21:09 |
thingee | xyang: all the better :) | 21:09 |
*** maike has joined #openstack-cinder | 21:09 | |
xyang | thingee: this is the max_over_subscription_ratio we are talking about | 21:09 |
jungleboyj | thingee: Welcome. :-) Glad to help. | 21:10 |
xyang | thingee: jgriffith initially said my default of 1 is too low. it should be at least 2. so I picked 2. maybe I should set it to 20 | 21:10 |
thingee | jungleboyj: I'm still really confused with this documentation though. =/ | 21:10 |
xyang | thingee: agree documentation should have more examples to cover all cases | 21:11 |
thingee | jungleboyj: ah nice james carey commented. :) | 21:12 |
jungleboyj | thingee: Yes, and so he is going to patch the documentation and hopefully remove the confusion. | 21:13 |
thingee | excellent, yes I'll definitely review this | 21:13 |
thingee | yay progress! | 21:13 |
smcginnis | Just saw that. Great to have things clarified. I'd also like to take a look at the documentation update. | 21:13 |
smcginnis | thingee: +1 for progress. Thanks for your time on this. | 21:14 |
thingee | smcginnis: I left a comment for james to add you to the review | 21:14 |
thingee | smcginnis: thank you | 21:14 |
xyang | jungleboyj: one more thing to clarify. I see LOG.debug(ex) in some places. I tried it and it won't cause exception. Is this correct? will ex be translated in this format | 21:14 |
*** changbl has joined #openstack-cinder | 21:14 | |
smcginnis | thingee: Perfect, thanks! | 21:14 |
xyang | jungleboyj: ignore the part about translation | 21:15 |
jungleboyj | xyang: I think that is a bad idea. Let me check. | 21:15 |
xyang | jungleboyj: but if it is LOG.error(ex), I would worry about translation. thanks | 21:16 |
openstackgerrit | Jon Bernard proposed openstack/cinder: RBD: remove non-layering support for antiquated versions https://review.openstack.org/158873 | 21:19 |
openstackgerrit | Jon Bernard proposed openstack/cinder: RBD: Query volume features from ceph.conf https://review.openstack.org/158874 | 21:19 |
*** Manshoon has quit IRC | 21:19 | |
*** Manshoon has joined #openstack-cinder | 21:20 | |
jbernard | the ibm ds8000 ci is either the fastest CI ever, or terribly broken | 21:20 |
jungleboyj | xyang: Do you have a specific example you are asking about? | 21:20 |
xyang | jungleboyj: one sec | 21:20 |
jungleboyj | jbernard: Yeah, I need to ping Eddie about that. I saw that it is doing something weird. | 21:20 |
jungleboyj | jbernard: Which review you looking at? | 21:21 |
jbernard | jungleboyj: this one: https://review.openstack.org/#/c/158873/ and this one: https://review.openstack.org/#/c/158874/ | 21:21 |
*** sandywalsh has quit IRC | 21:22 | |
xyang | jungleboyj: https://review.openstack.org/#/c/155989/19/manila/share/drivers/service_instance.py line 565 | 21:22 |
jungleboyj | jbernard: Thanks. Let me ping Eddie. | 21:23 |
jbernard | jungleboyj: thanks man | 21:23 |
jungleboyj | jbernard: No problem. Thank you. | 21:23 |
*** sandywalsh has joined #openstack-cinder | 21:23 | |
*** diegows has joined #openstack-cinder | 21:23 | |
*** Longgeek has quit IRC | 21:24 | |
*** Manshoon has quit IRC | 21:24 | |
openstackgerrit | Eric Brown proposed openstack/cinder: Use oslo_config choices support https://review.openstack.org/158580 | 21:25 |
dannywilson | xyang: For max_over_subscription_ratio we decided to use 20 in the case of empty array/nothing provisioned | 21:26 |
xyang | dannywilson: perfect. you just confirmed that 20 is a reasonable default | 21:27 |
openstackgerrit | Angela Smith proposed openstack/cinder: Fix issue where custom zone name prefix not being used by brcd driver https://review.openstack.org/158866 | 21:28 |
dannywilson | xyang: I think we just confirmed it together. :) | 21:28 |
xyang | dannywilson: good:) | 21:28 |
jungleboyj | xyang: You shouldn't do LOG.error(ex). Your safest bet is LOG.error(six.text_type(ex)) | 21:28 |
jungleboyj | Otherwise you may blow up with the logger trying to do an str() on the exception. | 21:29 |
jungleboyj | Regardless, sending the exception like that right to the logger is yucky. | 21:29 |
openstackgerrit | Angela Smith proposed openstack/cinder: Custom zone name prefix not being used by brcd driver https://review.openstack.org/158866 | 21:29 |
xyang | jungleboyj: I tested it. it doesn't blow up. LOG.error("%s" % ex) will throw unicodeerror exception, but LOG.error(ex) doesn't | 21:30 |
xyang | LOG.error("%s", ex) also doesn't throw exception | 21:30 |
xyang | the logger is doing six.text_type itself | 21:31 |
smcginnis | jungleboyj: xyang and I had fun trying different permutations of logging unicode. | 21:31 |
smcginnis | jungleboyj: She's the expert now. :) | 21:32 |
xyang | jungleboyj, smcginnis: yes, Sean and I tested it yesterday:) | 21:32 |
jungleboyj | smcginnis: xyang masochists! | 21:32 |
smcginnis | jungleboyj: Just been having fun trying to straighten out different advice. :) | 21:34 |
xyang | jungleboyj: see here: /opt/stack/cinder/cinder/openstack/common/log.py(318)process() | 21:34 |
xyang | msg = six.text_type(msg) | 21:34 |
*** lpetrut has quit IRC | 21:34 | |
xyang | jungleboyj: so as long as the msg reaches here, it will be wrapped with six | 21:35 |
jungleboyj | xyang: Ok, that sounds familiar. | 21:36 |
xyang | if we use LOG.error("%s" % ex) thought, it will throw unicode error at an earlier point | 21:36 |
xyang | because it treats ex as str | 21:36 |
xyang | jungleboyj: exception will be thrown here: /usr/local/lib/python2.7/dist-packages/oslo_i18n/_message.py(160)__str__() | 21:37 |
xyang | from oslo_i18n._i18n import _ | 21:38 |
xyang | msg = _('Message objects do not support str() because they may ' | 21:38 |
jungleboyj | xyang: Ok, so, the answer is LOG.error(ex) is ok, but it is still yucky. | 21:39 |
xyang | raise UnicodeError(msg) | 21:39 |
xyang | jungleboyj: I wouldn't want to use that. just wonder how I should comment on it if someone uses it:) | 21:39 |
*** _cjones_ has quit IRC | 21:39 | |
jungleboyj | I would say it is bad form. | 21:40 |
xyang | ask jungleboyj if you agree :) | 21:40 |
xyang | if you don't agree | 21:40 |
jungleboyj | xyang: :-) | 21:40 |
*** dustins has joined #openstack-cinder | 21:42 | |
*** dustins has quit IRC | 21:42 | |
jungleboyj | xyang: If for no other reason, you are spitting an exception into the logs with no context around it. | 21:43 |
*** ebalduf has joined #openstack-cinder | 21:44 | |
*** scottda has quit IRC | 21:44 | |
xyang | jungleboyj: so you suggest add some text explaining where the exception is coming from, what operation we are trying, etc? | 21:44 |
*** cdelatte has quit IRC | 21:44 | |
mtreinish | jgriffith: if you get a sec: https://review.openstack.org/158020 should be a quick one | 21:45 |
jungleboyj | Right, so you have LOG.error(_LE("Exception encountered: %s", ex)) | 21:45 |
xyang | jungleboyj: ok, thanks | 21:45 |
jungleboyj | That is what is normally done. | 21:45 |
*** diegows has quit IRC | 21:46 | |
jgriffith | mtreinish: lgtm... do I need to test it or am I safe in assuming you've fully vetted it :) | 21:47 |
*** ebalduf has quit IRC | 21:48 | |
anish | mtanino: just in time, I was about to upload the same IET code today :) | 21:48 |
mtreinish | jgriffith: heh, well I never bothered to run run_tests, but the tox output is here: http://logs.openstack.org/20/158020/2/check/gate-cinder-python27/189bd6d/console.html | 21:48 |
jgriffith | mtreinish: hmm... | 21:48 |
jgriffith | mtreinish: may be busted, just s sec | 21:48 |
*** akerr has quit IRC | 21:49 | |
mtreinish | it's also probably worth noting you guys also leak a lot of stdout and stderr during the unit tests | 21:49 |
jgriffith | mtreinish: that all needs squashed, I agree | 21:49 |
*** akerr has joined #openstack-cinder | 21:49 | |
jgriffith | mtreinish: I thought we made some pretty good progress ripping that out, but maybe not | 21:49 |
mtreinish | my favorite one was: http://logs.openstack.org/20/158020/2/check/gate-cinder-python27/189bd6d/console.html#_2015-02-23_16_02_02_442 | 21:49 |
mtreinish | that's a lot of wrapping | 21:49 |
*** _cjones_ has joined #openstack-cinder | 21:50 | |
mtanino | anish: oh really.... | 21:50 |
jgriffith | mtreinish: oh dear :( | 21:50 |
jgriffith | mtreinish: ok.. I'm saving that off, maybe on the plane I'll nuke at least the zfssaapi stuff | 21:50 |
jgriffith | mtreinish: ok... your test change looks good | 21:51 |
jgriffith | mtreinish: just needed some updates on my env | 21:51 |
jgriffith | mtreinish: but I will truly miss my colors :) | 21:51 |
mtanino | anish: Did you create test code? I don't have test code yet :( | 21:51 |
mtreinish | jgriffith: heh, push a tempest-lib patch to add a color mode to subunit-trace :) | 21:51 |
jgriffith | mtreinish: hehe.. don't know if I'll miss is that much :) | 21:52 |
*** karimb has joined #openstack-cinder | 21:52 | |
jgriffith | mtreinish: but that would be kinda fun to work on as a distractor at some point | 21:52 |
jgriffith | mtreinish: oi!! The stdout crap is very annoying isn't it | 21:52 |
jgriffith | mtreinish: ok... thanks sir! | 21:52 |
jgriffith | I'll look at what I can do to eradicate all the leaking output later tonight | 21:53 |
patrickeast | jgriffith: hey, thanks for the reviews on my db table change, is it safe to assume a +2 on the code changes means you would be willing to do the same for the spec too? | 21:53 |
mtreinish | jgriffith: sure, np | 21:53 |
mtreinish | jgriffith: yeah it does get annoying. It's better than nova's problem though. They're leaking stdout outside the fixture so it doesn't get multiplexed properly. Leads to some interesting output in places | 21:54 |
jgriffith | patrickeast: specs! specs! You want specs! You can't handle specs! | 21:54 |
jgriffith | :) | 21:54 |
patrickeast | lol | 21:54 |
thingee | patrickeast, jgriffith: I'll +2 the spec today | 21:55 |
jgriffith | thingee: cool.. I won't have to try and find it :) | 21:55 |
patrickeast | thingee: sweet, thanks | 21:55 |
thingee | jgriffith: :) | 21:55 |
thingee | patrickeast: sorry about that | 21:55 |
jgriffith | Ok... gotta run, next leg of th ehourney is on! | 21:55 |
patrickeast | ^ https://review.openstack.org/#/c/153333/ | 21:55 |
jgriffith | cya all later | 21:55 |
patrickeast | cya | 21:55 |
thingee | jgriffith: good luck! | 21:55 |
*** Yogi1 has quit IRC | 21:56 | |
jgriffith | thingee: left the +A for you :) | 21:56 |
jgriffith | cya | 21:56 |
thingee | patrickeast: was hemna ever going to comment on this? | 21:56 |
hemna | ? | 21:56 |
hemna | which ? | 21:56 |
thingee | think I mentioned I would be comfortable with another vendor who was interested in this | 21:56 |
thingee | hemna: https://review.openstack.org/#/c/153333/ | 21:56 |
hemna | checking | 21:56 |
thingee | hemna: in the midcycle meetup, you mentioned you had to work around this problem | 21:56 |
patrickeast | ah yea, sry i wasn’t too aggresive chasing people down on it | 21:56 |
hemna | thingee, yah we did | 21:57 |
hemna | I had reviewed this one a while back | 21:57 |
anish | mtanino: did not :) I also did the base code first | 21:57 |
hemna | but hadn't kept up on it | 21:57 |
anish | Similarly to yours, except you use cid better | 21:57 |
thingee | hemna: would appreciate a +1 on this so I can +2 to it | 21:57 |
hemna | ok reviewing now | 21:57 |
mtanino | anish: hahaha, same situation.. | 21:57 |
patrickeast | thingee: hemna: thanks for the help pushing it through! | 21:57 |
mtanino | anish: I got that cid idea from guitarzan | 21:58 |
anish | mtanino: whoops, 1 second late | 21:58 |
hemna | thingee, patrickeast question | 21:58 |
hemna | since this DB table is going to have credentials in it | 21:58 |
*** kvidvans_ has joined #openstack-cinder | 21:58 | |
hemna | shouldn't rows be hard deleted? | 21:58 |
hemna | instead of just marked as 'deleted' like all of our other tables do ? | 21:59 |
patrickeast | hemna: i had wondered about that | 21:59 |
hemna | not sure how to enforce that at delete time. | 21:59 |
patrickeast | i opted not to since it isn’t only for credentials | 21:59 |
hemna | I presume there is a way though | 21:59 |
patrickeast | and even then i hope to eventually only store a barbican uuid | 21:59 |
patrickeast | and the actual secret elsewhere | 21:59 |
hemna | so what happens to a row that does have credentials that's soft deleted ? | 21:59 |
hemna | the credentials are left in the db | 21:59 |
hemna | ? | 21:59 |
patrickeast | it sticks around | 21:59 |
patrickeast | yea | 21:59 |
hemna | ick | 21:59 |
patrickeast | not ideal | 21:59 |
patrickeast | its an easy change to hard delete them | 22:00 |
*** kvidvans has quit IRC | 22:00 | |
patrickeast | im cool with it either way | 22:00 |
*** tsekiyama has quit IRC | 22:00 | |
*** tsekiyama has joined #openstack-cinder | 22:00 | |
hemna | well, the reason I bring this is up, is that we also have another review in flight | 22:00 |
hemna | that archives the 'deleted' rows into shadow tables | 22:00 |
mtanino | anish: np. | 22:00 |
hemna | and so this data will be left around forever | 22:00 |
hemna | and migrated to another table eventually | 22:01 |
*** dustins has joined #openstack-cinder | 22:01 | |
hemna | I'm not sure we want that for private credentials | 22:01 |
*** thangp has quit IRC | 22:01 | |
hemna | thingee, ? | 22:01 |
hemna | jungleboyj, ? | 22:01 |
patrickeast | yea i agree with that | 22:01 |
hemna | patrickeast, sorry about this. | 22:01 |
hemna | I just thought of it as I was looking this over again | 22:02 |
hemna | because I'm also reviewing the shadow tables review as well | 22:02 |
patrickeast | hemna: no worries, i’m glad to find this out now instead of later on when its a problem | 22:02 |
anish | mtanino: I did all the cxt tests in mock, can I take a quick shot at getting you started while you concentrate on the main code | 22:03 |
patrickeast | so it sounds to me like the question is whether the table should hard delete all the time, or only some of the time like a delete_now=True kind of deal | 22:03 |
hemna | yah | 22:03 |
hemna | do we do this anywhere else? | 22:03 |
hemna | controlled conditional deletes ? | 22:04 |
jungleboyj | hemna: ? | 22:04 |
hemna | soft/hard | 22:04 |
hemna | jungleboyj, ^^ on the https://review.openstack.org/#/c/153333 review | 22:04 |
*** vilobhmm has quit IRC | 22:04 | |
hemna | jungleboyj, issue with the new db table I'm raising. | 22:04 |
hemna | jungleboyj, the new table will be used to store CHAP creds | 22:05 |
hemna | and deleted rows are soft deletes | 22:05 |
*** vilobhmm1 has joined #openstack-cinder | 22:05 | |
hemna | which is just marking the row as deleted, but all the data is still there. | 22:05 |
*** annashen_ has joined #openstack-cinder | 22:06 | |
patrickeast | i kind of lean towards always hard delete | 22:06 |
mtanino | anish: That's much appreciate | 22:07 |
hemna | patrickeast, yah I think so as well | 22:07 |
*** cdelatte has joined #openstack-cinder | 22:08 | |
hemna | is there any reason why we would need those rows to stay around ? | 22:08 |
*** delattec has joined #openstack-cinder | 22:08 | |
jungleboyj | hemna: Yeah, seems like we would want to hard delete that. | 22:08 |
patrickeast | mm other than convienent debugging tool, no | 22:08 |
patrickeast | even then | 22:08 |
hemna | yah ok | 22:08 |
patrickeast | ok, one sec, i’ll update the spec | 22:08 |
hemna | so I vote for hard delete on that table | 22:08 |
*** tsekiyama has quit IRC | 22:08 | |
hemna | let me add a comment in the review for history | 22:09 |
jungleboyj | +2 | 22:09 |
*** tsekiyama has joined #openstack-cinder | 22:09 | |
*** kvidvans_ has quit IRC | 22:09 | |
*** amoturi_ has quit IRC | 22:09 | |
*** annashen_ has quit IRC | 22:10 | |
hemna | ok added | 22:10 |
*** maike has quit IRC | 22:13 | |
*** maike has joined #openstack-cinder | 22:13 | |
patrickeast | hemna: thanks! i’ll have an update posted in just a min | 22:14 |
hemna | ok cool | 22:14 |
hemna | thingee, | 22:14 |
*** changbl has quit IRC | 22:17 | |
*** timcl has quit IRC | 22:17 | |
*** jungleboyj has quit IRC | 22:19 | |
openstackgerrit | Patrick East proposed openstack/cinder-specs: Add DB table for driver private data https://review.openstack.org/153333 | 22:19 |
patrickeast | made one other little change too, just noticed it was silly to pass a value for removing an entry, we only need the key | 22:19 |
patrickeast | on a somewhat related note, does anyone know if its possible to get an admin auth token for the cinder user in a driver? i was playing around with using the key manager w/ barbican to store secrets but couldn’t figure out a good way to get the right context object | 22:24 |
patrickeast | not sure if thats something we do elsewhere (or at all) anywhere else | 22:25 |
mriedem | is this a known gate bug? http://logs.openstack.org/97/157497/2/check/check-tempest-dsvm-nova-v21-full/3cd8eef/logs/screen-c-api.txt.gz?level=TRACE#_2015-02-24_19_59_10_820 | 22:25 |
mriedem | looks like that started happening around 2/20 | 22:26 |
mriedem | http://goo.gl/gYCVzw | 22:26 |
mriedem | when it shows up though, the job is ultimately successful 93% of the time | 22:27 |
hemna | patrickeast, dunno about that one | 22:28 |
*** diemt has quit IRC | 22:28 | |
mriedem | mtreinish: look at this test which failed with a timeout: http://logs.openstack.org/97/157497/2/check/check-tempest-dsvm-nova-v21-full/3cd8eef/console.html#_2015-02-24_20_12_55_706 | 22:29 |
mriedem | then look at the slowest test in the run above it | 22:29 |
mriedem | mtreinish: wonder if we should make those mutually exclusive? | 22:29 |
mtreinish | mriedem: printing slowest and failures? | 22:30 |
*** erlon has quit IRC | 22:31 | |
mriedem | mtreinish: no, lock fixture on those tests | 22:32 |
mriedem | test_list_get_volume_attachments and test_rescued_vm_detach_volume | 22:33 |
mriedem | maybe that's just papering over an issue | 22:33 |
mtreinish | mriedem: yeah, the operations aren't mutually exclusive so I don't think locking is correct there | 22:33 |
mriedem | k, some of the traceback is confusing here http://logs.openstack.org/97/157497/2/check/check-tempest-dsvm-nova-v21-full/3cd8eef/console.html | 22:34 |
mtreinish | mriedem: fwiw, jgriffith has been looking at test_rescued_vm_detach_volume there are some interesting interactions going on there which is causing lvm to sit in a wait loop | 22:34 |
mriedem | with the order in teardown, so i'm trying to figure out what actually timed out | 22:34 |
mtreinish | so that'll always be slow | 22:34 |
mriedem | alright, there is a gate race there, just not sure if it's a known bug or not | 22:36 |
openstackgerrit | Patrick East proposed openstack/cinder-specs: Add DB table for driver private data https://review.openstack.org/153333 | 22:36 |
mriedem | and my currenty logstash query is too generic probably | 22:36 |
openstackgerrit | Eric Brown proposed openstack/cinder: Use oslo_config choices support https://review.openstack.org/158580 | 22:36 |
*** openstackgerrit has quit IRC | 22:37 | |
*** openstackgerrit has joined #openstack-cinder | 22:37 | |
mtreinish | mriedem: looking through the logs it looks like it never detached | 22:40 |
mtreinish | which was the initial failure, then it also raised an exc when it went to delete the server because there was still a volume attached to it | 22:40 |
jgriffith | mriedem: mtreinish hey.... | 22:42 |
jgriffith | That test sucks :) | 22:42 |
mtreinish | err probably volume delete is what failed actually | 22:42 |
jgriffith | So Nova/KVM do bad things | 22:42 |
jgriffith | makes LVM hang | 22:42 |
jgriffith | but in the past it hasn't caused "failures" | 22:42 |
jgriffith | looking now at the logstash you pasted | 22:43 |
*** dustins has quit IRC | 22:43 | |
mtreinish | mriedem: although the detach succeeded: http://logs.openstack.org/97/157497/2/check/check-tempest-dsvm-nova-v21-full/3cd8eef/logs/screen-c-vol.txt.gz#_2015-02-24_20_00_48_056 | 22:43 |
mriedem | jgriffith: probably more useful: http://logs.openstack.org/97/157497/2/check/check-tempest-dsvm-nova-v21-full/3cd8eef/logs/screen-c-vol.txt.gz#_2015-02-24_19_59_10_603 | 22:43 |
*** Ilja has quit IRC | 22:43 | |
*** dustins has joined #openstack-cinder | 22:43 | |
jgriffith | indeed | 22:43 |
jgriffith | oh.. boy... that's new | 22:43 |
jgriffith | mriedem: 20'th you say? | 22:44 |
*** ebalduf has joined #openstack-cinder | 22:44 | |
mriedem | jgriffith: yeah | 22:44 |
jgriffith | mriedem: ok... two candidates, gimmie a minute | 22:45 |
mtreinish | mriedem: oh ignore me, my link was the forced delete working | 22:45 |
mtreinish | (dunno how I missed all that red) | 22:45 |
mriedem | for some reason i can't get logstash to find the stderr here http://logs.openstack.org/97/157497/2/check/check-tempest-dsvm-nova-v21-full/3cd8eef/logs/screen-c-vol.txt.gz#_2015-02-24_19_59_10_603 | 22:45 |
jgriffith | access control rule failure | 22:46 |
mtreinish | mriedem: is it getting filtered out? | 22:46 |
jgriffith | it's there... | 22:46 |
mriedem | mriedem: idk | 22:46 |
jgriffith | Stderr: u'tgtadm: this access control rule does not exist\n' | 22:46 |
mriedem | ha | 22:46 |
mriedem | mtreinish: got myself that time | 22:46 |
mriedem | mtreinish: i don't know why that wouldn't be indexed | 22:47 |
mtreinish | mriedem: http://goo.gl/aB0OK8 | 22:47 |
jgriffith | mriedem: mtreinish http://goo.gl/8xaf55 | 22:47 |
mtreinish | seems to work | 22:48 |
*** ebalduf has quit IRC | 22:49 | |
mtreinish | jgriffith: that broke things? looks safe to me :) | 22:50 |
mtreinish | mriedem: heh, I just noticed you mixed up our nicks this time :) | 22:50 |
mriedem | ya | 22:51 |
mriedem | time to leave soon | 22:51 |
jgriffith | mriedem: not nice to mess with me like that :) | 22:51 |
mtreinish | mriedem: do you want me to push a query for that error mesage? | 22:51 |
*** kaufer has quit IRC | 22:51 | |
mriedem | sec | 22:52 |
mriedem | it's not 100% failure | 22:52 |
mriedem | of course | 22:52 |
mriedem | but it is newish as of 2/20 | 22:52 |
mriedem | 59% fail when it shows up | 22:52 |
mtreinish | heh, of course it isn't... | 22:52 |
mriedem | mtreinish: jgriffith: bug reported https://bugs.launchpad.net/cinder/+bug/1425310 | 22:53 |
openstack | Launchpad bug 1425310 in Cinder "test_list_get_volume_attachments race fail - timeout waiting for volume to attach (stuck in detach)" [Undecided,New] | 22:53 |
mriedem | mtreinish: go ahead with the e-r query, i have to head out | 22:53 |
mriedem | not sure if it's a dupe of 1421895 or not | 22:53 |
*** Ilja has joined #openstack-cinder | 22:54 | |
*** dustins has quit IRC | 22:55 | |
mtreinish | mriedem: it might be a dup, or at least a partial dup | 22:56 |
mtreinish | bug 1421895 looks like it's just looking at the tempest side | 22:56 |
openstack | bug 1421895 in Cinder "test_encrypted_cinder_volumes_luks fails with "Volume is still attached, detach volume first."" [High,Confirmed] https://launchpad.net/bugs/1421895 | 22:56 |
mriedem | i'm punting | 22:57 |
mriedem | and leaving | 22:57 |
mriedem | ttyl | 22:57 |
mtreinish | tsk, tsk where's the work ethic :) | 22:57 |
*** mriedem has quit IRC | 22:57 | |
jgriffith | mtreinish: Not clear on where that ACL is getting setup or pulled in | 22:59 |
jgriffith | mtreinish: unless my removal of retry_deactivate is doing something "funny" | 23:00 |
jgriffith | mtreinish: but the lvm.conf has that set so it should still behave the same way | 23:01 |
jgriffith | mtreinish: I can surely revert that change and see if our problem goes away | 23:01 |
jgriffith | mtreinish: http://goo.gl/bGa3kT | 23:01 |
*** harlowja is now known as harlowja_away | 23:02 | |
*** harlowja_away is now known as harlowja | 23:05 | |
*** vilobhmm1 has quit IRC | 23:06 | |
*** vilobhmm has joined #openstack-cinder | 23:06 | |
*** emagana has quit IRC | 23:08 | |
*** Longgeek has joined #openstack-cinder | 23:09 | |
*** Yogi1 has joined #openstack-cinder | 23:09 | |
mtreinish | jgriffith: yeah if the lvm.conf has the same options, I'm not sure how that would make a diff | 23:12 |
*** xyang has quit IRC | 23:12 | |
openstackgerrit | xing-yang proposed openstack/cinder: Modify Consistency Group API https://review.openstack.org/144561 | 23:12 |
*** _cjones_ has quit IRC | 23:12 | |
mtreinish | jgriffith: I'm assuming the --config flag doesn't drop all the options from the lvm.conf file (that would be weird) because that's the only thing I could think would be different | 23:12 |
jgriffith | mtreinish: indeed | 23:13 |
jgriffith | mtreinish: which is why I changed it | 23:13 |
jgriffith | mtreinish: I can test that though... if it does drop everything else then that's LAME | 23:13 |
jgriffith | mtreinish: BUT... the thing is we don't set up bind anywhere | 23:13 |
jgriffith | mtreinish: so I don't know where that's coming from | 23:14 |
jgriffith | mtreinish: re the ACL stuff... we use CHAP, no ACL | 23:14 |
*** _cjones_ has joined #openstack-cinder | 23:14 | |
*** tbarron has quit IRC | 23:17 | |
*** tbarron has joined #openstack-cinder | 23:17 | |
*** emagana has joined #openstack-cinder | 23:17 | |
mtreinish | jgriffith: I've never used tgt-admin before (just tgtadm occasionally) but how are you telling it that? Because it loooks like the tgt-admin --force --delete is issuing 'tgtadm -C 0 --op unbind --mode target --tid 1 -I ALL' | 23:17 |
jgriffith | mtreinish: so that's the thing :) | 23:18 |
jgriffith | mtreinish: it is, but we don't use ACL so I don't know why the unbind is being called | 23:18 |
*** amoturi_ has joined #openstack-cinder | 23:18 | |
jgriffith | unless something "else" on the system is setting it in the tgtadm.conf file | 23:18 |
jgriffith | but given the timing, it sure seems like something with my change | 23:19 |
*** maike has quit IRC | 23:19 | |
*** chlong has joined #openstack-cinder | 23:19 | |
*** amoturi_ has quit IRC | 23:20 | |
jgriffith | mtreinish: I'm doing a fresh deploy on my end to see if I can repro and tag it | 23:20 |
mtreinish | ok, cool. fwiw, I'm still not making the jump where tgt-admin gets the config to know which tgtadm calls to make. (but that's just my general lvm ignorance) | 23:22 |
mtreinish | so if you've got a grasp on it that's good enough for me :) | 23:22 |
jgriffith | well... in Cinder we have never paid any attention to the conf | 23:23 |
jgriffith | the only thing we do is persistent tgt files | 23:23 |
jgriffith | but just like most things, there is an /etc/tgt.conf file that can "do stuff" | 23:23 |
*** karimb has quit IRC | 23:25 | |
*** jungleboyj has joined #openstack-cinder | 23:27 | |
mtreinish | jgriffith: ah, ok | 23:27 |
jgriffith | mtreinish: anyway... loading a full stack and I'll see if I can find anything out before resorting to just a blind revert :) | 23:27 |
mtreinish | I think I get it now. Do you think there would be value in also pulling the tgt.conf in the log output? | 23:29 |
jgriffith | mtreinish: depends on if I can find antying locally or not :) | 23:29 |
jgriffith | mtreinish: but honestly... for future anyway it might be a good idea | 23:30 |
*** _cjones_ has quit IRC | 23:30 | |
jgriffith | mtreinish: building wheel is sooooo slooowwwwww | 23:30 |
jgriffith | :( | 23:30 |
mtreinish | jgriffith: heh, yeah it's that numpy install doing the blas lib compliation | 23:31 |
mtreinish | blame nova | 23:31 |
jgriffith | mtreinish: yeah... sighhh | 23:31 |
jgriffith | mtreinish: I did/do | 23:31 |
*** primechuck has quit IRC | 23:32 | |
*** thingee has quit IRC | 23:33 | |
*** primechuck has joined #openstack-cinder | 23:34 | |
*** jungleboyj has quit IRC | 23:34 | |
mtreinish | I should probably look into a way to speed up that compliation (assuming we can't remove it) | 23:34 |
*** rmesta has quit IRC | 23:34 | |
jgriffith | mtreinish: stack.d ? | 23:36 |
*** primechuck has quit IRC | 23:38 | |
*** Longgeek has quit IRC | 23:42 | |
*** _cjones_ has joined #openstack-cinder | 23:43 | |
openstackgerrit | xing-yang proposed openstack/cinder: Create Consistency Group from CG Snapshot API https://review.openstack.org/145952 | 23:43 |
*** ebalduf has joined #openstack-cinder | 23:45 | |
casusbelli | jgriffith: Hoi! Have a minute? | 23:46 |
*** jungleboyj has joined #openstack-cinder | 23:47 | |
*** emagana has quit IRC | 23:47 | |
openstackgerrit | xing-yang proposed openstack/python-cinderclient: Kilo Consistency Group CLI update https://review.openstack.org/144567 | 23:47 |
patrickeast | xyang1: hey, just saw your comment on https://review.openstack.org/#/c/157681/5/cinder/volume/drivers/pure.py for the change dannywilson is working on, just to make sure i understand correctly, in the situation you described the scheduler would see 90GB available and still send volumes our way, right? | 23:48 |
*** amoturi_ has joined #openstack-cinder | 23:48 | |
*** emagana has joined #openstack-cinder | 23:48 | |
patrickeast | xyang1: it wont stop scheduling just because the ratio hits 1.0 | 23:48 |
patrickeast | xyang1: is my current understanding* | 23:48 |
*** ebalduf has quit IRC | 23:49 | |
xyang1 | patrickeast: Can i ping you back in 10 min? | 23:50 |
*** chlong_ has joined #openstack-cinder | 23:50 | |
patrickeast | xyang1: yep | 23:50 |
*** emagana has quit IRC | 23:52 | |
*** mriedem has joined #openstack-cinder | 23:53 | |
jgriffith | mriedem: so again comes back to the server rescue stuff... | 23:54 |
jgriffith | mriedem: so this has been troubling to me | 23:54 |
jgriffith | mriedem: because rescue does some things with LVM, and adding devs | 23:54 |
jgriffith | hehe... mtreinish ^^ | 23:55 |
jgriffith | forgot who left and who stayed :) | 23:55 |
jgriffith | casusbelli: hey... what's up? | 23:55 |
*** Apoorva_ has joined #openstack-cinder | 23:56 | |
mtreinish | jgriffith: oh, fun. I feel like rescue will constantly be a problem | 23:57 |
jgriffith | mtreinish: I'm HAPPY to propose a skip for those tests :) | 23:58 |
*** asmith_brcd has quit IRC | 23:58 | |
jgriffith | mtreinish: it seems to do "weird" things | 23:58 |
*** Apoorva has quit IRC | 23:59 | |
mtreinish | jgriffith: is there a bug for nova? | 23:59 |
jgriffith | mtreinish: Yeah, I logged one... just a sec | 23:59 |
mtreinish | jgriffith: pushing a skip would basically be saying we can't test (or use) rescue reliably w/ cinder lvm | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!