| thingee | hemna: I haven't looked lately. what's up with brick, os-brick, cinder-lib whatever | 00:00 |
|---|---|---|
| thingee | :) | 00:00 |
| anish | mtanino: sure. just a headsup, I'm afk from tomorrow-monday | 00:00 |
| hemna | thanks for asking | 00:00 |
| mtanino | anish: have a nice vacation? | 00:00 |
| hemna | so, there are 2 outstanding patches https://review.openstack.org/#/q/status:open+project:openstack/os-brick,n,z | 00:00 |
| hemna | I'd like other eyes looking at those | 00:01 |
| hemna | I'm in the process of testing it against my WIP for Cinder here: https://review.openstack.org/#/c/155552/ | 00:01 |
| *** annashen has quit IRC | 00:01 | |
| hemna | so basically what needs to happen is this | 00:02 |
| hemna | os-brick patches land. | 00:02 |
| hemna | os-brick release to pypi | 00:02 |
| hemna | cinder Remove Brick from cinder patch lands. | 00:02 |
| hemna | and well prior to step 3, global requirements updates and cinder requirements updates as well. | 00:02 |
| thingee | Ok, I mentioned earlier I'm going to really nervous about this if we can get things landed by this week. | 00:02 |
| thingee | I really want churn in the gate on this | 00:03 |
| thingee | can=cant | 00:03 |
| hemna | yah understandable | 00:03 |
| hemna | either way, we are in decent shape | 00:03 |
| hemna | os-brick exists as a project | 00:03 |
| hemna | if we get cinder using for K great, if not, L | 00:04 |
| *** ebalduf has joined #openstack-cinder | 00:04 | |
| hemna | I just need others to help reviews and test. | 00:04 |
| thingee | speaking of still that needs to land soon... | 00:04 |
| thingee | xyang1: hey | 00:04 |
| hemna | I don't want to be the only one. | 00:04 |
| xyang1 | thingee: Hi | 00:04 |
| thingee | xyang1: have you had a chance to test out https://review.openstack.org/#/c/131873/ and https://review.openstack.org/#/c/133566/ ? | 00:04 |
| thingee | xyang1: DuncanT signed off on it. | 00:05 |
| thingee | hemna: happy to make those first priorities in L, so you can have a better chance in Nova. | 00:05 |
| thingee | those being multi-attach and brick if ends up that way | 00:06 |
| hemna | ok coolio. thanks | 00:06 |
| hemna | I'll keep working towards K for now. | 00:06 |
| thingee | or be loud to whoever the PTL is :) | 00:06 |
| xyang1 | thingee: I did test the patchset two days ago. Worked for me. | 00:07 |
| hemna | thingee, so another question related to brick | 00:07 |
| thingee | xyang1: that's so great to hear | 00:07 |
| thingee | xyang1: can you tell me what exactly you did to test it? | 00:07 |
| *** timcl has joined #openstack-cinder | 00:08 | |
| xyang1 | thingee: I tested migrate down and also add a column to snapshot table. Make sure i can still create snapshot etc and can see the new field | 00:08 |
| *** ebalduf has quit IRC | 00:08 | |
| xyang1 | thingee: Anything specific you are looking for | 00:09 |
| thingee | xyang1: excellent! I don't even think DuncanT covered snapshots, so that's great | 00:09 |
| thingee | xyang1: I think he just covered volumes | 00:09 |
| thingee | xyang1: no that sounds great | 00:09 |
| thingee | hemna: go ahead :) | 00:09 |
| xyang1 | thingee: Great. The patch is about snapshot though | 00:09 |
| hemna | so regarding patches that go against os-brick and cinder, we need to ensure that cinder tests are run for os-brick patches and vice versa | 00:10 |
| hemna | so a change to os-brick doesn't break cinder in check/gate. | 00:10 |
| thingee | xyang1: snapshot and volumes | 00:10 |
| thingee | it says in the title anyways | 00:10 |
| xyang1 | thingee: I think he added volume later. Ok | 00:12 |
| *** nikesh_vedams has quit IRC | 00:12 | |
| thingee | xyang1: https://review.openstack.org/#/c/133566/12/cinder/objects/volume.py | 00:12 |
| *** timcl has quit IRC | 00:12 | |
| thingee | xyang1: looks like backup object is added later | 00:12 |
| anish | mtanino: yep | 00:13 |
| *** nikesh_vedams has joined #openstack-cinder | 00:13 | |
| *** cpallares has quit IRC | 00:13 | |
| *** david-lyle is now known as david-lyle_afk | 00:14 | |
| xyang1 | thingee: Let me go through the code again. Somehow I thought volume is not completely covered. Backup was added by another person | 00:15 |
| *** Manshoon has joined #openstack-cinder | 00:17 | |
| *** Manshoon has quit IRC | 00:18 | |
| *** gary-smith_ has quit IRC | 00:18 | |
| *** gary-smith_ has joined #openstack-cinder | 00:18 | |
| thingee | xyang1: sounds good | 00:20 |
| thingee | hemna: makes sense | 00:21 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Implement IET target driver https://review.openstack.org/158829 | 00:21 |
| thingee | hemna: so a job that installs cinder, deps with the proposed os-brick patch, runs run_test.sh? | 00:23 |
| thingee | including tempest | 00:23 |
| hemna | yah | 00:24 |
| hemna | https://review.openstack.org/#/c/157468/ | 00:24 |
| thingee | on the cinder side, we should already be fine, since we're installing it from pypi each time. | 00:24 |
| thingee | of the version in requirements | 00:24 |
| hemna | right now it's just tox tests pep8 and py27) that are running. | 00:24 |
| thingee | yeah it makes sense to me. | 00:25 |
| hemna | thingee, so what's the process of doing a lib release to pypi? | 00:26 |
| hemna | who kicks that off ? | 00:26 |
| hemna | does thierry have to sign off on doing a release to pypi ? | 00:26 |
| jungleboyj | thingee: Sorry, had to step away. | 00:27 |
| jungleboyj | thingee: As far as what I think looks best, that was why I was leaning towards the options.py file. | 00:27 |
| thingee | hemna: well we now have the PTL kick off things for cinderclient. should probably do the same here too. | 00:28 |
| jungleboyj | We have 70+ files that have config entries. Then we can make a hacking check that cleanly indicates how to do things properly. | 00:28 |
| thingee | if it's under the cinder project | 00:28 |
| hemna | thingee, ok cool | 00:29 |
| thingee | jungleboyj: ok, I would still appreciate the convo in the friday meeting if you can bring that up. | 00:29 |
| thingee | if there really is no consensus or no one really cares, we can just do our own thing | 00:29 |
| *** mdbooth has quit IRC | 00:29 | |
| hemna | thingee, ok so I'll do my best to wrap up my os-brick testing tonight or tomorrow | 00:30 |
| jungleboyj | thingee: Ok, which Friday meeting. I thought oslo meeting was on Mondays. | 00:30 |
| thingee | jungleboyj: shows what I know. yeah the monday one :) | 00:30 |
| jungleboyj | Ok. I can do that. | 00:31 |
| hemna | https://review.openstack.org/#/c/157468/ is small and needs some love. | 00:31 |
| thingee | hemna: +2 | 00:32 |
| hemna | thank you | 00:32 |
| jungleboyj | thingee: I may try to get a patch up to use as an example for the discussion. The bulk of the work will be the same. | 00:32 |
| * jungleboyj is getting my loving rea... Oh | 00:32 | |
| jungleboyj | I was too slow. | 00:32 |
| thingee | jungleboyj, hemna, eharney, DuncanT, winston-d_zZZ: need some help in reviews for k3 targets still https://etherpad.openstack.org/p/cinder-k3-priorities | 00:34 |
| thingee | actually jungleboyj has quite a few merges already :) | 00:35 |
| thingee | according to the list | 00:35 |
| jungleboyj | thingee: :-) I was busy this weekend. | 00:35 |
| *** mdbooth has joined #openstack-cinder | 00:35 | |
| hemna | nice | 00:35 |
| thingee | but xyang1 and I have doing our best with the initial list. | 00:35 |
| thingee | have been doing* | 00:36 |
| thingee | xyang1: thank you | 00:36 |
| xyang1 | thingee: You are welcome:) | 00:36 |
| *** tbarron has quit IRC | 00:36 | |
| thingee | even if a third of them are emc related heh | 00:36 |
| thingee | in the merge list | 00:36 |
| * jungleboyj pats xyang1 on the back | 00:36 | |
| *** tbarron has joined #openstack-cinder | 00:37 | |
| xyang1 | thingee: Cg patch was updated. The 2nd patch was added to the list | 00:37 |
| jungleboyj | thingee: Have a quiet day tomorrow should be able to take another pass at reviews. | 00:37 |
| thingee | xyang1: yeah apologies. These last three weeks I've been doing my best with reviews, and I hope you've all been noticing. This week and the last two weeks have been really difficult for me, personal reasons. | 00:38 |
| hemna | xyang1, I hadn't had time to look at it again | 00:38 |
| hemna | been trying to get my stuff in :( | 00:38 |
| jungleboyj | thingee: Dude, you are apologizing about 128 reviews in the last 30 days? | 00:39 |
| xyang1 | thingee: hemna no problem. | 00:39 |
| * jungleboyj has been trying to catch up. Evening doing reviews while losing blood. :-) | 00:39 | |
| xyang1 | hemna: There is another cg patch added to the list: create cg from cgsnapshot | 00:40 |
| hemna | ok | 00:40 |
| thingee | xyang1: I'm hoping to potential race conditions are taken care of with create cg from cgsnapshot. | 00:40 |
| thingee | to=the | 00:40 |
| *** jaypipes has quit IRC | 00:40 | |
| xyang1 | thingee: I think so. | 00:40 |
| xyang1 | thingee: I am only creating db entry first | 00:41 |
| openstackgerrit | Patrick East proposed openstack/cinder: PureISCSIDriver consistency group updates. https://review.openstack.org/157637 | 00:41 |
| vilobhmm1 | thingee : ping | 00:41 |
| xyang1 | thingee: Pure's patch is not on the list | 00:42 |
| thingee | vilobhmm1: hi | 00:42 |
| vilobhmm1 | thingee : i droped and email regarding the exception request | 00:42 |
| vilobhmm1 | did you get a chance to have a look at it | 00:42 |
| thingee | vilobhmm1: no because I haven't responded to it. ;) | 00:43 |
| vilobhmm1 | can you please have a look :) | 00:43 |
| vilobhmm1 | whenever you get time | 00:43 |
| thingee | patrickeast, xyang1: done | 00:44 |
| thingee | xyang1: if I miss anything, feel free to add it. | 00:44 |
| patrickeast | thingee: thanks | 00:44 |
| thingee | if the bp is already approved and targeted | 00:44 |
| xyang1 | thingee: Ok, thanks | 00:44 |
| vilobhmm1 | myself, dulek and e0ne met last week and thought of coming up a combined approach for using micro-states for validation and taskflow persistence; I am working on the writeup/blueprint for the same can that be done as part of the vancover design summit ? so that we have a conclusion on it so that everyone is there at the same time | 00:44 |
| *** Mandell has quit IRC | 00:44 | |
| vilobhmm1 | thingee : ^^ | 00:44 |
| thingee | vilobhmm1: is there a strong reason this needs to be in K? | 00:44 |
| thingee | vilobhmm1: take a look at https://launchpad.net/cinder/+milestone/kilo-3 | 00:45 |
| thingee | 49 targeted | 00:45 |
| thingee | 18 implemented | 00:45 |
| vilobhmm1 | thingee : it will help for improving state management | 00:45 |
| vilobhmm1 | this is also implemented | 00:46 |
| vilobhmm1 | and ready for review | 00:46 |
| vilobhmm1 | thanks for the link | 00:47 |
| thingee | vilobhmm1: this was sent to the dev ML? | 00:48 |
| thingee | vilobhmm1: implemented in this context means merged | 00:49 |
| vilobhmm1 | thingee : yes on 02/20 | 00:49 |
| *** rmesta has quit IRC | 00:50 | |
| vilobhmm1 | thingee : ok, the prototype for micro-states is ready if i can get 2 reviewers it can be merged in k3 ; | 00:51 |
| vilobhmm1 | you did mention in cinder weekly about addtional test pipeline that the fix needs to go through; if we have steps documented for running addtional functional tests somewhere i can even run them and get the fix up and ready | 00:51 |
| vilobhmm1 | thingee : the email is titled "Exception request : Making "Introducing micro_states for create workflow" part of K-3" | 00:52 |
| thingee | vilobhmm1: is this still use taskflow? | 00:52 |
| thingee | vilobhmm1: I think last we spoke, in the meeting, and midcycle meetup, people are unsure with the usage. | 00:52 |
| thingee | I would like to start with that. | 00:52 |
| thingee | before we dive futher with this | 00:52 |
| thingee | and not ignore what the community has already brought up | 00:53 |
| thingee | I think dulek wrote a "not pretty solution" to an outstanding issue with allocations going wrong. jgriffith was unable to resolve this issue easily because of confusion with taskflow. | 00:53 |
| *** Lee1092 has joined #openstack-cinder | 00:54 | |
| vilobhmm1 | thingee : what do you mean by "I would like to start with that" yes the micro-states approach depends on taskflow and so does the persistence thing | 00:54 |
| thingee | vilobhmm1: I mean what I said. We should discuss if we even want to continue using taskflow. | 00:54 |
| vilobhmm1 | hmmm | 00:55 |
| thingee | I'm getting so annoyed with people ignoring what the community of Cinder has brought up and forcing these patches down and not wanting to discuss those issues. | 00:55 |
| vilobhmm1 | i am ready for discussion | 00:55 |
| vilobhmm1 | and whatever the community agress on we can follow with that | 00:56 |
| vilobhmm1 | so as mentioned above i am working on a writeup/blueprint to combine these 2 approaches do you think a design summit talk will be good for it ; to come to some conclusion ? | 00:56 |
| vilobhmm1 | we can talk about taskflow incluson or not in next cinder weekely if you think its ok | 00:56 |
| thingee | yes. Here's an interesting thing that jgriffith brought up at the midcycle meetup. It seems like ever since we introduced taskflow, everytime we get together, there are people complaining and asking if we should consider using taskflow. | 00:57 |
| thingee | I had to fight for taskflow in the Kilo summit, but the annoyance that people have been raising to me, and the lack of additional flows being implemented in taskflow *much* earlier in the kilo dev cycle has been concerning | 00:58 |
| thingee | I understand stuff has been proposed now, but with the earlier allocation bug, the limitations of taskflow doing persistence with sqlite is not that great. | 00:59 |
| thingee | That buys us a host coming backup and resuming, which is not what we heard initially with taskflow | 00:59 |
| vilobhmm1 | hmm…taskflow has its own benefits though..we can add more flows…once this micr-states infrastructure is in…or i can work on adding more flows | 00:59 |
| vilobhmm1 | ok | 01:00 |
| thingee | vilobhmm1: additional flows have been proposed. They're up for review now. Lazy to dig them up right now. | 01:00 |
| hemna | thingee, I think fwiw, I -1'd the persistence patch due to it's limitation on using local sqllite | 01:00 |
| hemna | thingee, and i believe they fixed that. | 01:00 |
| vilobhmm1 | so when can we expect a decision on taskflow ? | 01:00 |
| hemna | I haven't had time to reup on that review though. | 01:00 |
| thingee | hemna, vilobhmm1: it was some issue with sqlalchemy being mentioned? | 01:01 |
| hemna | thingee, I believe it was related to oslo.db | 01:01 |
| *** mtanino has quit IRC | 01:01 | |
| vilobhmm1 | i think that was resolved in duleks blueprint | 01:01 |
| hemna | and not tying taskflow to oslo.db | 01:01 |
| thingee | I need to look at dulek's solution for the allocation bug still | 01:01 |
| vilobhmm1 | ok | 01:01 |
| vilobhmm1 | will you be interested in this writeup/blueprint on state management with/without taskflow…or otherwise i can spend my cycles on helping for k3 | 01:02 |
| thingee | https://review.openstack.org/#/c/154920/ | 01:02 |
| vilobhmm1 | thingee : ^^ | 01:02 |
| thingee | here's a dumb question, how exactly does data get passed from one task's execute to another? | 01:03 |
| *** ebalduf has joined #openstack-cinder | 01:04 | |
| hemna | I believe the return of execute is the input to the next task | 01:05 |
| vilobhmm1 | every task returns something and that gets passed as input to next task | 01:05 |
| hemna | hence the requires in __init__ and provides | 01:05 |
| vilobhmm1 | thingee : ^^ | 01:05 |
| vilobhmm1 | a (returns)===>B(input)-B(return)===>C(input) | 01:06 |
| hemna | thingee, https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L61-L64 | 01:06 |
| hemna | that defines what that task provides as output | 01:06 |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L460-L463 | 01:07 |
| hemna | that specifies what that task needs | 01:07 |
| thingee | so example, this returns nothing https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L309 | 01:07 |
| thingee | but it expects volume_ref and volume_spec https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L610 | 01:08 |
| hemna | yah that task doesn't provide anything | 01:08 |
| thingee | in the next tasks | 01:08 |
| hemna | thingee, https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L760 | 01:08 |
| hemna | that's where the db comes from | 01:08 |
| *** ebalduf has quit IRC | 01:09 | |
| hemna | db, event_suffix | 01:09 |
| vilobhmm1 | https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L760 is the way the tasks will be executed /scheduled | 01:09 |
| hemna | the flow engine ensures that what the task requires gets injected into the tasks's execute() | 01:09 |
| hemna | depending on what the flow lists as requires in __init__ | 01:09 |
| thingee | hemna: but again it expects a volume_ref and spec https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L610 | 01:09 |
| thingee | what you linked says db, driver | 01:10 |
| thingee | driver != spec | 01:10 |
| vilobhmm1 | thingee, hemna | 01:10 |
| vilobhmm1 | https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L736 | 01:10 |
| hemna | execute != __init__ | 01:10 |
| vilobhmm1 | governs the policy used for the flow | 01:10 |
| vilobhmm1 | thingee : hemna is write execute != __init__ | 01:10 |
| vilobhmm1 | right | 01:11 |
| * thingee can work on a filesystem, but not taskflow | 01:11 | |
| thingee | ok let me try again | 01:12 |
| hemna | crap, I have to run and get my kids | 01:12 |
| hemna | thingee, sorry | 01:12 |
| hemna | harlowja_away, ping | 01:12 |
| *** hemna is now known as hemnafk | 01:12 | |
| *** Mandell has joined #openstack-cinder | 01:13 | |
| vilobhmm1 | harlowja_away : is out today | 01:13 |
| vilobhmm1 | hemna : ^^ | 01:13 |
| vilobhmm1 | thingee : sure | 01:14 |
| thingee | hemnafk, vilobhmm1: I realize __init__ != execute ... hemnafk brought it up :) | 01:14 |
| *** Anticimex has quit IRC | 01:14 | |
| *** Anticimex has joined #openstack-cinder | 01:14 | |
| thingee | my earlier confusion again | 01:14 |
| thingee | https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L309 | 01:14 |
| thingee | returns nothing | 01:14 |
| thingee | so how does https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L610 | 01:15 |
| thingee | get volume_ref and volume_specs | 01:15 |
| vilobhmm1 | because these values are in mem | 01:16 |
| vilobhmm1 | as of now | 01:16 |
| thingee | that does not help me understand how positional arguments get passed in | 01:16 |
| vilobhmm1 | duleks proposal was also to move these values into persistence thing | 01:17 |
| vilobhmm1 | ok | 01:17 |
| *** cpallares has joined #openstack-cinder | 01:17 | |
| thingee | vilobhmm1: please lets talk about persistence right now. I'm trying to understand just this part :) | 01:17 |
| thingee | lets not talk about* | 01:17 |
| vilobhmm1 | afaik | 01:18 |
| vilobhmm1 | the return values are in mem and passed to the next task depeding on the herirarchy proposed | 01:18 |
| vilobhmm1 | so in this case | 01:18 |
| *** patrickeast has quit IRC | 01:22 | |
| *** rwsu is now known as rwsu-afk | 01:27 | |
| *** Mandell has quit IRC | 01:31 | |
| *** _cjones_ has quit IRC | 01:31 | |
| *** Mandell has joined #openstack-cinder | 01:34 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 01:44 | |
| *** Thelo has joined #openstack-cinder | 01:46 | |
| *** IanGovett1 has quit IRC | 01:51 | |
| *** davechen has joined #openstack-cinder | 01:51 | |
| *** jdurgin has quit IRC | 01:53 | |
| openstackgerrit | wanghao proposed openstack/cinder: Implement function of import/export snapshots https://review.openstack.org/144590 | 01:55 |
| *** nikesh_vedams has quit IRC | 01:57 | |
| *** nikesh_vedams has joined #openstack-cinder | 01:57 | |
| *** dannywilson has joined #openstack-cinder | 02:03 | |
| *** ebalduf has joined #openstack-cinder | 02:05 | |
| *** leeantho has quit IRC | 02:05 | |
| *** vilobhmm1 has quit IRC | 02:07 | |
| *** jdurgin has joined #openstack-cinder | 02:07 | |
| *** vilobhmm has joined #openstack-cinder | 02:08 | |
| *** ebalduf has quit IRC | 02:09 | |
| *** Mandell has quit IRC | 02:10 | |
| *** dannywilson has quit IRC | 02:13 | |
| *** dannywilson has joined #openstack-cinder | 02:13 | |
| *** annashen has joined #openstack-cinder | 02:13 | |
| *** bill_az has quit IRC | 02:14 | |
| *** diegows has quit IRC | 02:14 | |
| *** cpallares has quit IRC | 02:16 | |
| *** dannywilson has quit IRC | 02:18 | |
| *** Thelo has quit IRC | 02:18 | |
| *** kvidvans has quit IRC | 02:24 | |
| *** vilobhmm has quit IRC | 02:24 | |
| *** casusbel_ has joined #openstack-cinder | 02:35 | |
| *** dalgaaf has quit IRC | 02:37 | |
| *** Apoorva has quit IRC | 02:38 | |
| *** casusbelli has quit IRC | 02:38 | |
| *** chlong_ has joined #openstack-cinder | 02:43 | |
| *** kaisers has joined #openstack-cinder | 02:43 | |
| *** kaisers1 has joined #openstack-cinder | 02:43 | |
| *** kaisers2 has quit IRC | 02:44 | |
| *** annashen has quit IRC | 02:45 | |
| *** kaisers3 has quit IRC | 02:46 | |
| *** markvoelker has quit IRC | 02:47 | |
| *** markvoelker has joined #openstack-cinder | 02:47 | |
| *** markvoelker has quit IRC | 02:51 | |
| *** takedakn has joined #openstack-cinder | 02:52 | |
| openstackgerrit | wuyuting proposed openstack/python-cinderclient: Make cinderclient support snapshot-force-delete https://review.openstack.org/153148 | 02:56 |
| *** annashen has joined #openstack-cinder | 03:01 | |
| *** Thelo has joined #openstack-cinder | 03:02 | |
| *** takedakn has quit IRC | 03:02 | |
| *** takedakn has joined #openstack-cinder | 03:03 | |
| *** ebalduf has joined #openstack-cinder | 03:06 | |
| *** ebalduf has quit IRC | 03:11 | |
| *** annashen has quit IRC | 03:17 | |
| openstackgerrit | wanghao proposed openstack/cinder: query volume detail support volume_glance_metadata https://review.openstack.org/147738 | 03:18 |
| *** Anticimex has quit IRC | 03:24 | |
| *** Anticimex has joined #openstack-cinder | 03:25 | |
| *** tbarron has quit IRC | 03:29 | |
| *** coolsvap_ is now known as coolsvap | 03:33 | |
| *** bkopilov has quit IRC | 03:36 | |
| *** annashen has joined #openstack-cinder | 03:37 | |
| *** Mandell has joined #openstack-cinder | 03:40 | |
| *** markvoelker has joined #openstack-cinder | 03:43 | |
| *** annashen_ has joined #openstack-cinder | 03:44 | |
| *** annashen has quit IRC | 03:48 | |
| *** takedakn has quit IRC | 03:49 | |
| *** annashen has joined #openstack-cinder | 03:49 | |
| *** cpallares has joined #openstack-cinder | 03:50 | |
| *** annashen has quit IRC | 04:00 | |
| *** scottda has joined #openstack-cinder | 04:00 | |
| *** scottda has quit IRC | 04:01 | |
| *** pdeore_ has joined #openstack-cinder | 04:02 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Change max_over_subscription_ratio default value https://review.openstack.org/159336 | 04:06 |
| *** xyang has quit IRC | 04:06 | |
| *** ebalduf has joined #openstack-cinder | 04:07 | |
| *** annashen_ has quit IRC | 04:07 | |
| openstackgerrit | wanghao proposed openstack/cinder: Implement function of import/export snapshots https://review.openstack.org/144590 | 04:09 |
| *** ebalduf has quit IRC | 04:11 | |
| *** scottda has joined #openstack-cinder | 04:14 | |
| *** scottda has quit IRC | 04:15 | |
| *** kaufer has joined #openstack-cinder | 04:16 | |
| *** kaufer has quit IRC | 04:19 | |
| *** Mandell has quit IRC | 04:31 | |
| *** patrickeast has joined #openstack-cinder | 04:33 | |
| *** Mandell has joined #openstack-cinder | 04:39 | |
| *** annashen has joined #openstack-cinder | 04:41 | |
| *** lpetrut has joined #openstack-cinder | 04:43 | |
| *** markvoelker has quit IRC | 04:44 | |
| *** markvoelker has joined #openstack-cinder | 04:45 | |
| *** deepakcs has joined #openstack-cinder | 04:47 | |
| *** ho has joined #openstack-cinder | 04:48 | |
| *** markvoelker has quit IRC | 04:49 | |
| *** bkopilov has joined #openstack-cinder | 04:56 | |
| *** coolsvap is now known as coolsvap_ | 04:57 | |
| openstackgerrit | Patrick East proposed openstack/cinder: Add CHAP support to PureISCSIDriver https://review.openstack.org/137175 | 04:57 |
| openstackgerrit | Patrick East proposed openstack/cinder: Add DB table for driver specific data https://review.openstack.org/151837 | 04:57 |
| *** patrickeast has quit IRC | 04:58 | |
| *** xyang1 has quit IRC | 05:03 | |
| *** coolsvap_ is now known as coolsvap | 05:04 | |
| *** ebalduf has joined #openstack-cinder | 05:08 | |
| *** asselin_ has quit IRC | 05:11 | |
| *** anuragpalsule has joined #openstack-cinder | 05:11 | |
| *** ebalduf has quit IRC | 05:12 | |
| *** BharatK has joined #openstack-cinder | 05:20 | |
| *** cpallares has quit IRC | 05:24 | |
| *** anshul has joined #openstack-cinder | 05:29 | |
| *** jcru has joined #openstack-cinder | 05:34 | |
| *** lpetrut has quit IRC | 05:41 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Add support to incremental backups in cinder https://review.openstack.org/110068 | 05:45 |
| *** number80 has quit IRC | 05:55 | |
| *** avishay has joined #openstack-cinder | 05:56 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex https://review.openstack.org/152401 | 06:07 |
| *** ebalduf has joined #openstack-cinder | 06:08 | |
| *** ebalduf has quit IRC | 06:12 | |
| *** annashen has quit IRC | 06:15 | |
| openstackgerrit | Liu Xinguo proposed openstack/cinder: Huawei driver check before associating LUN to a LUN group https://review.openstack.org/148144 | 06:18 |
| *** fifieldt has joined #openstack-cinder | 06:26 | |
| *** takedakn has joined #openstack-cinder | 06:27 | |
| *** BharatK has quit IRC | 06:31 | |
| *** Ilja has joined #openstack-cinder | 06:32 | |
| *** thingee has quit IRC | 06:35 | |
| *** pck has quit IRC | 06:37 | |
| *** annashen has joined #openstack-cinder | 06:42 | |
| *** pck has joined #openstack-cinder | 06:42 | |
| openstackgerrit | Liu Xinguo proposed openstack/cinder: Huawei driver fix problems under multipath https://review.openstack.org/150767 | 06:43 |
| *** BharatK has joined #openstack-cinder | 06:44 | |
| *** casusbel_ has quit IRC | 06:47 | |
| *** casusbelli has joined #openstack-cinder | 06:48 | |
| *** cnesa has joined #openstack-cinder | 06:49 | |
| *** avishay has quit IRC | 06:50 | |
| *** annashen has quit IRC | 06:50 | |
| openstackgerrit | Liu Xinguo proposed openstack/cinder: Huawei driver remove LUN controller change https://review.openstack.org/152116 | 06:52 |
| *** nikesh_vedams has quit IRC | 06:57 | |
| *** cnesa has quit IRC | 07:01 | |
| *** nkrinner has joined #openstack-cinder | 07:01 | |
| *** avishay has joined #openstack-cinder | 07:03 | |
| *** takedakn has quit IRC | 07:04 | |
| *** cnesa has joined #openstack-cinder | 07:07 | |
| *** ebalduf has joined #openstack-cinder | 07:09 | |
| *** ebalduf has quit IRC | 07:13 | |
| *** TobiasE has joined #openstack-cinder | 07:17 | |
| openstackgerrit | Abhijeet Malawade proposed openstack/cinder: Get volume from db again before updating it's status https://review.openstack.org/144409 | 07:24 |
| *** jdurgin1 has joined #openstack-cinder | 07:29 | |
| *** cnesa has quit IRC | 07:30 | |
| *** nikesh_vedams has joined #openstack-cinder | 07:33 | |
| *** sgotliv has quit IRC | 07:37 | |
| *** chlong_ has quit IRC | 07:42 | |
| *** Miouge has joined #openstack-cinder | 07:43 | |
| *** chlong has quit IRC | 07:43 | |
| *** markvoelker has joined #openstack-cinder | 07:44 | |
| *** cnesa has joined #openstack-cinder | 07:44 | |
| openstackgerrit | Eric Brown proposed openstack/cinder: Password config options should be marked secret https://review.openstack.org/158590 | 07:46 |
| *** markvoelker has quit IRC | 07:50 | |
| *** afazekas_ has joined #openstack-cinder | 07:50 | |
| *** pradipm has joined #openstack-cinder | 07:56 | |
| *** lpetrut has joined #openstack-cinder | 08:00 | |
| *** e0ne has joined #openstack-cinder | 08:03 | |
| *** 21WABGMI1 has joined #openstack-cinder | 08:05 | |
| *** 21WABGMI1 has quit IRC | 08:05 | |
| *** ebalduf has joined #openstack-cinder | 08:10 | |
| *** ebalduf has quit IRC | 08:14 | |
| *** ronis has joined #openstack-cinder | 08:16 | |
| *** dulek has joined #openstack-cinder | 08:22 | |
| *** nshaikh has joined #openstack-cinder | 08:23 | |
| *** sgotliv has joined #openstack-cinder | 08:29 | |
| *** pradipm has quit IRC | 08:30 | |
| *** pradipm has joined #openstack-cinder | 08:43 | |
| openstackgerrit | rakesh mishra proposed openstack/cinder: Implement making volume snapshots public https://review.openstack.org/159372 | 08:44 |
| *** karimb has joined #openstack-cinder | 08:49 | |
| *** rushiagr_away is now known as rushiagr | 08:49 | |
| *** TobiasE1 has joined #openstack-cinder | 08:53 | |
| *** jistr has joined #openstack-cinder | 08:53 | |
| openstackgerrit | wanghao proposed openstack/cinder: Add config option to override url for versions https://review.openstack.org/159374 | 08:54 |
| *** jordanP has joined #openstack-cinder | 08:54 | |
| *** TobiasE has quit IRC | 08:56 | |
| *** sgotliv_ has joined #openstack-cinder | 08:57 | |
| *** dulek has quit IRC | 08:57 | |
| *** dulek has joined #openstack-cinder | 08:58 | |
| *** ndipanov has joined #openstack-cinder | 09:00 | |
| *** sgotliv has quit IRC | 09:00 | |
| *** dulek_ has joined #openstack-cinder | 09:04 | |
| *** dulek has quit IRC | 09:04 | |
| *** sgotliv has joined #openstack-cinder | 09:05 | |
| *** takedakn has joined #openstack-cinder | 09:05 | |
| *** sgotliv_ has quit IRC | 09:07 | |
| *** PaulCuzner has quit IRC | 09:08 | |
| *** TobiasE1 has quit IRC | 09:09 | |
| *** MasterPiece has quit IRC | 09:10 | |
| *** lpetrut has quit IRC | 09:10 | |
| *** ebalduf has joined #openstack-cinder | 09:11 | |
| *** yuriy_n17 has joined #openstack-cinder | 09:11 | |
| *** ebalduf has quit IRC | 09:15 | |
| *** pschaef has joined #openstack-cinder | 09:23 | |
| *** avishay_ has joined #openstack-cinder | 09:24 | |
| *** avishay has quit IRC | 09:24 | |
| *** abhishek_cb has joined #openstack-cinder | 09:25 | |
| *** bswartz has quit IRC | 09:30 | |
| *** dulek_ has quit IRC | 09:31 | |
| *** pradipm has left #openstack-cinder | 09:36 | |
| *** pradipm has joined #openstack-cinder | 09:44 | |
| *** markvoelker has joined #openstack-cinder | 09:47 | |
| *** davechen has quit IRC | 09:50 | |
| *** markvoelker has quit IRC | 09:52 | |
| *** Mandell has quit IRC | 09:53 | |
| *** EmilienM|afk is now known as EmilienM | 10:11 | |
| *** ebalduf has joined #openstack-cinder | 10:11 | |
| *** lpetrut has joined #openstack-cinder | 10:14 | |
| *** ebalduf has quit IRC | 10:16 | |
| openstackgerrit | wanghao proposed openstack/cinder: Add config option to override url for versions https://review.openstack.org/159374 | 10:19 |
| *** takedakn has quit IRC | 10:20 | |
| *** pradipm has quit IRC | 10:27 | |
| *** pradipm has joined #openstack-cinder | 10:29 | |
| *** TobiasE has joined #openstack-cinder | 10:29 | |
| *** abhishek_cb has quit IRC | 10:33 | |
| openstackgerrit | Shay Halsband proposed openstack/cinder: XtreamIO version 4.0 support https://review.openstack.org/152973 | 10:34 |
| *** TobiasE1 has joined #openstack-cinder | 10:38 | |
| *** nshaikh has quit IRC | 10:38 | |
| *** TobiasE has quit IRC | 10:38 | |
| *** pradipm has quit IRC | 10:41 | |
| openstackgerrit | Shay Halsband proposed openstack/cinder: XtreamIO version 4.0 support https://review.openstack.org/152973 | 10:44 |
| *** eharney has quit IRC | 10:49 | |
| *** tbarron has joined #openstack-cinder | 10:53 | |
| *** eharney has joined #openstack-cinder | 11:02 | |
| *** asselin_ has joined #openstack-cinder | 11:06 | |
| *** nellysmitt has joined #openstack-cinder | 11:10 | |
| *** asselin_ has quit IRC | 11:11 | |
| *** ebalduf has joined #openstack-cinder | 11:12 | |
| *** ebalduf has quit IRC | 11:17 | |
| *** pcaruana has joined #openstack-cinder | 11:19 | |
| *** pradipm has joined #openstack-cinder | 11:27 | |
| *** rushiagr is now known as rushiagr_away | 11:33 | |
| *** abhishek_cb has joined #openstack-cinder | 11:36 | |
| *** sgotliv has quit IRC | 11:38 | |
| *** sgotliv has joined #openstack-cinder | 11:40 | |
| *** kallebe has joined #openstack-cinder | 11:42 | |
| *** chlong has joined #openstack-cinder | 11:51 | |
| *** chlong_ has joined #openstack-cinder | 11:51 | |
| *** bill_az has joined #openstack-cinder | 11:54 | |
| *** abhishek_cb has quit IRC | 11:58 | |
| *** deepakcs has quit IRC | 11:59 | |
| *** timcl has joined #openstack-cinder | 11:59 | |
| *** erlon has joined #openstack-cinder | 12:10 | |
| *** ganso_ has joined #openstack-cinder | 12:11 | |
| *** ebalduf has joined #openstack-cinder | 12:13 | |
| *** ebalduf has quit IRC | 12:18 | |
| *** pradipm has quit IRC | 12:24 | |
| *** pradipm has joined #openstack-cinder | 12:24 | |
| *** pradipm has quit IRC | 12:26 | |
| *** pradipm has joined #openstack-cinder | 12:27 | |
| *** pradipm has quit IRC | 12:28 | |
| *** pradipm has joined #openstack-cinder | 12:29 | |
| *** hodos has joined #openstack-cinder | 12:32 | |
| *** mtanino has joined #openstack-cinder | 12:33 | |
| *** akrog has joined #openstack-cinder | 12:33 | |
| *** annegentle has quit IRC | 12:33 | |
| mtanino | avishay_: ping | 12:34 |
| *** avishay_ has quit IRC | 12:37 | |
| *** akrog is now known as geguileo | 12:37 | |
| *** diegows has joined #openstack-cinder | 12:41 | |
| *** takedakn has joined #openstack-cinder | 12:42 | |
| *** pradipm has quit IRC | 12:43 | |
| *** pradipm has joined #openstack-cinder | 12:43 | |
| *** dulek has joined #openstack-cinder | 12:44 | |
| *** IanGovett has joined #openstack-cinder | 12:44 | |
| *** pradipm has quit IRC | 12:45 | |
| *** pradipm has joined #openstack-cinder | 12:45 | |
| *** avishay_ has joined #openstack-cinder | 12:45 | |
| *** dulek_ has joined #openstack-cinder | 12:46 | |
| *** ho has quit IRC | 12:48 | |
| *** markvoelker has joined #openstack-cinder | 12:50 | |
| *** Ilja has quit IRC | 12:51 | |
| *** markvoelker has quit IRC | 12:56 | |
| *** sgotliv has quit IRC | 12:56 | |
| openstackgerrit | Petrut Lucian proposed openstack/cinder: SMBFS: Fix retrieving total allocated size https://review.openstack.org/158713 | 12:56 |
| *** pradipm has quit IRC | 12:58 | |
| *** jkraj has joined #openstack-cinder | 13:05 | |
| *** afazekas_ has quit IRC | 13:05 | |
| *** avishay_ has quit IRC | 13:06 | |
| *** avishay__ has joined #openstack-cinder | 13:06 | |
| *** esker has joined #openstack-cinder | 13:07 | |
| *** BharatK has quit IRC | 13:09 | |
| *** sgotliv has joined #openstack-cinder | 13:09 | |
| *** lihit has joined #openstack-cinder | 13:13 | |
| *** aix has joined #openstack-cinder | 13:13 | |
| *** ebalduf has joined #openstack-cinder | 13:14 | |
| *** lihit has quit IRC | 13:17 | |
| *** bkopilov has quit IRC | 13:17 | |
| *** primechuck has quit IRC | 13:17 | |
| *** ebalduf has quit IRC | 13:18 | |
| *** akerr has joined #openstack-cinder | 13:20 | |
| *** chlong has quit IRC | 13:20 | |
| *** chlong_ has quit IRC | 13:20 | |
| *** vnagpal has joined #openstack-cinder | 13:22 | |
| *** rushiagr_away is now known as rushiagr | 13:22 | |
| *** vnagpal has quit IRC | 13:23 | |
| *** akerr_ has joined #openstack-cinder | 13:23 | |
| *** akerr has quit IRC | 13:26 | |
| openstackgerrit | Anton Arefiev proposed openstack/cinder: Add entry create and cast tasks to manage workflow https://review.openstack.org/139071 | 13:27 |
| openstackgerrit | Anton Arefiev proposed openstack/cinder: Fix lvm manage existing volume https://review.openstack.org/156939 | 13:27 |
| yuriy_n17 | DuncanT: Hi | 13:28 |
| DuncanT | yuriy_n17: Hi | 13:28 |
| yuriy_n17 | Duncan: I'd like to discuss your comments about https://review.openstack.org/#/c/156552/ | 13:29 |
| yuriy_n17 | Duncan: What do you mean by saying 'It breaks client' yesterday? | 13:30 |
| yuriy_n17 | Duncan: Just remember you it's about time zone in Cinder | 13:32 |
| yuriy_n17 | DuncanT: What do you suggest? | 13:36 |
| *** Yogi1 has joined #openstack-cinder | 13:36 | |
| *** takedakn has quit IRC | 13:37 | |
| DuncanT | yuriy_n17: Clients that parse the time field currently break when extra info (like the timezone) is added | 13:39 |
| DuncanT | yuriy_n17: Depending on how their parser is written | 13:39 |
| yuriy_n17 | DuncanT: Please give me an example to see this situation. | 13:42 |
| *** baffle has quit IRC | 13:42 | |
| *** casusbelli has quit IRC | 13:43 | |
| *** mtanino has quit IRC | 13:44 | |
| DuncanT | yuriy_n17: Do you have a system set up with your patch? I've not currently got one, it will take me a while to spin one up | 13:46 |
| yuriy_n17 | DuncanT: ok | 13:47 |
| DuncanT | Do "cinder --debug show <some volume>" and look for the RESP BODY that comes back, and post up the exact value in the created_at field | 13:49 |
| *** bswartz has joined #openstack-cinder | 13:50 | |
| geguileo | Hi, I'm new to Cinder and I have a quick question, can anybody help me? | 13:52 |
| *** markvoelker has joined #openstack-cinder | 13:53 | |
| e0ne | geguileo: hi. what question do you have? | 13:54 |
| yuriy_n17 | DuncanT: I've got a "created_at" with timezone | 13:54 |
| geguileo | e0ne: It's regarding iscsi_ip_address with tgt and lio helpers | 13:54 |
| *** BharatK has joined #openstack-cinder | 13:54 | |
| geguileo | e0ne: Shouldn't cinder only create a portal for that address instead of 0.0.0.0 as it is doing now? | 13:54 |
| yuriy_n17 | DuncanT: What's a problem? | 13:55 |
| *** kaufer has joined #openstack-cinder | 13:55 | |
| DuncanT | yuriy_n17: So before your patch you get something that looks like "2014-03-05T15:37:06.000000" - any parser written for that format in a client is broken by your patch | 13:55 |
| DuncanT | yuriy_n17: You've changed what the field contains | 13:55 |
| DuncanT | yuriy_n17: So you've broken the API contract cinder provides | 13:56 |
| DuncanT | yuriy_n17: Does that make sense? | 13:58 |
| *** markvoelker has quit IRC | 13:59 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:59 | |
| *** eharney has quit IRC | 14:00 | |
| e0ne | DuncanT: i've got you point. you mean that 3rd party clients won't work with these changes, do you? | 14:00 |
| *** TobiasE has joined #openstack-cinder | 14:00 | |
| DuncanT | e0ne: Exactly | 14:00 |
| DuncanT | e0ne: We can't change the format or semantics of an existing field | 14:01 |
| *** TobiasE1 has quit IRC | 14:01 | |
| DuncanT | e0ne: The easiest fix I can think of is to add new fields to the output for each time field, create_at_tz or whatever, with the new format | 14:02 |
| *** pschaef has quit IRC | 14:02 | |
| *** bswartz has quit IRC | 14:02 | |
| *** annegentle has joined #openstack-cinder | 14:02 | |
| e0ne | DuncanT: oh.. personaly i don't like idea to have several time fields | 14:02 |
| e0ne | DuncanT: but your consern about backward compatibility makes sense for me | 14:03 |
| DuncanT | e0ne: Either that or put just the timezone in the new field. Changing the format of the existing field is not acceptable | 14:03 |
| *** asselin_ has joined #openstack-cinder | 14:03 | |
| *** pradipm has joined #openstack-cinder | 14:05 | |
| *** eharney has joined #openstack-cinder | 14:06 | |
| *** eharney has quit IRC | 14:06 | |
| *** eharney has joined #openstack-cinder | 14:06 | |
| e0ne | DuncanT: so, we have no chanсe to make error during api development | 14:08 |
| DuncanT | e0ne: Not true, we just have to fix and errors in a back compatible way, or leave them broken until the next major API revision | 14:09 |
| e0ne | DuncanT: good point. i should to agree with you | 14:09 |
| *** markvoelker has joined #openstack-cinder | 14:10 | |
| DuncanT | e0ne: Back compatibility is one of those things it is hard to care about until you start to be the guy that customers shout at when it breaks... I have been that guy (and probably still am) | 14:10 |
| smcginnis | DuncanT. e0ne: What about a separate distinct call to get the server's timezone. | 14:11 |
| e0ne | DuncanT: +1 | 14:11 |
| smcginnis | Then the client can determine the difference based off of that. | 14:11 |
| smcginnis | And translate other results if needed. | 14:11 |
| *** anuragpalsule has quit IRC | 14:12 | |
| DuncanT | smcginnis: That would work, yeah, or we can include that as a new field in every response with a time in it | 14:12 |
| DuncanT | smcginnis: Save having to make a distinct call | 14:12 |
| DuncanT | smcginnis: Adding new fields is fine | 14:12 |
| smcginnis | DuncanT: I just worry about having the overhead on every call versus just on one call for those that actually care. | 14:13 |
| smcginnis | DuncanT: Granted small, but still extra data going back and forth. | 14:13 |
| e0ne | smcginnis: separate request for timezone doesn't help us while we parse logs | 14:14 |
| DuncanT | smcginnis: The overhead should be tiny, and the alternative is the client, horizon etc making an extra REST call regularly, which is way worse. We can probably just cache the TZ at startup, and the overhead is too small to measure then | 14:14 |
| smcginnis | e0ne: True | 14:14 |
| e0ne | timezone info should be logged | 14:14 |
| *** xyang has joined #openstack-cinder | 14:14 | |
| *** ebalduf has joined #openstack-cinder | 14:14 | |
| smcginnis | e0ne: OK, I agree. | 14:15 |
| smcginnis | Just thinking of alternatives that won't break anything. | 14:15 |
| DuncanT | yuriy_n17: Does that make sense to you? | 14:15 |
| e0ne | smcginnis: thanks:) | 14:15 |
| smcginnis | e0ne: ;) | 14:15 |
| yuriy_n17 | DuncanT: Thanks for the discussion. Let's see what would be said today in API WG. | 14:16 |
| e0ne | DuncanT, yuriy_n17 what timizone should be there? a sever timezone? | 14:17 |
| *** changbl has quit IRC | 14:17 | |
| *** bswartz has joined #openstack-cinder | 14:17 | |
| DuncanT | e0ne: Whatever timezone is being used in the time/date fields cinder is reporting | 14:17 |
| *** ebalduf has quit IRC | 14:19 | |
| *** asselin_ has quit IRC | 14:19 | |
| e0ne | DuncanT: after going deeper into the sources, i'm not sure about any changes | 14:21 |
| e0ne | DuncanT: by default, utcnow() is used everywhere | 14:21 |
| DuncanT | So all our results are always in UTC? In which case is there any bug, other than a need to document that? | 14:22 |
| e0ne | DuncanT: yep, if i didn't miss anything | 14:23 |
| *** primechuck has joined #openstack-cinder | 14:26 | |
| *** cnesa has quit IRC | 14:27 | |
| DuncanT | e0ne: Oh, hmmm, might just be worth putting that as a comment in the bug then? | 14:29 |
| e0ne | DuncanT: i found datetime.now() usage only in db purge and two migrations | 14:29 |
| DuncanT | e0ne: Those might technically be bugs then | 14:30 |
| *** afazekas_ has joined #openstack-cinder | 14:31 | |
| openstackgerrit | Tom Barron proposed openstack/cinder: NFS backup driver https://review.openstack.org/149726 | 14:31 |
| openstackgerrit | Tom Barron proposed openstack/cinder: Refactor Swift backup driver and introduce chunking driver https://review.openstack.org/149725 | 14:31 |
| *** lcurtis has joined #openstack-cinder | 14:31 | |
| e0ne | DuncanT: agree. i propose to: 1) fix that places to use utc (datetime.now in tests doesn't metter for it), 2) mark bug as invalid with a valid comment and 3) update api docs to notice that all dates are in utc tz | 14:31 |
| e0ne | yuriy_n17: ^^ | 14:32 |
| yuriy_n17 | eOne: I see | 14:32 |
| DuncanT | e0ne: I'd fix the tests too, personally, and add a hacking check for datetime.now to stop it accidentally being added somewhere important... better to go belt-and-braces | 14:32 |
| *** TobiasE has quit IRC | 14:33 | |
| *** TobiasE1 has joined #openstack-cinder | 14:33 | |
| e0ne | DuncanT: i like your opinion about hacking rules :) | 14:33 |
| DuncanT | e0ne: I am an imperfect reviewer. Hacking rules don't get bored | 14:34 |
| openstackgerrit | Steven Kaufer proposed openstack/cinder: Replication status periodic task optimization https://review.openstack.org/154673 | 14:34 |
| e0ne | DuncanT: that's why i'm fixing hacking rules and other checks time to tome | 14:34 |
| DuncanT | e0ne: I should spend more time on it, to be honest, but convincing other people to fix them up is a close second best | 14:35 |
| *** jungleboyj has quit IRC | 14:36 | |
| *** Yogi11 has joined #openstack-cinder | 14:38 | |
| *** xyang1 has joined #openstack-cinder | 14:39 | |
| *** Yogi1 has quit IRC | 14:40 | |
| e0ne | DuncanT: according to automation, how we decide what scanarios to add for rally gate in cinder? afaik, jgriffith was interesting on improvement it | 14:43 |
| e0ne | i mean https://github.com/openstack/cinder/blob/master/rally-jobs/cinder.yaml | 14:43 |
| *** j_king_ is now known as j_king | 14:43 | |
| *** deepakcs has joined #openstack-cinder | 14:44 | |
| DuncanT | e0ne: Anybody can submit scenarios via the usual review process... it is in our repo, we control it | 14:45 |
| *** IanGovett has quit IRC | 14:45 | |
| e0ne | DuncanT: sure. but may be we've got something like wishlist for it | 14:45 |
| lpetrut | Hi, I'd like to deprecate a dependency version, specifically, I'd like the SMB driver to require version 1.7 of qemu-img (having a check, raising an exception otherwise) in order to remove some hacky workarounds, will this require a blueprint? Or is having DocImpact flag enough? | 14:45 |
| *** tbarron has quit IRC | 14:46 | |
| *** kaisers has quit IRC | 14:47 | |
| *** cnesa has joined #openstack-cinder | 14:48 | |
| *** mriedem has joined #openstack-cinder | 14:49 | |
| *** tbarron has joined #openstack-cinder | 14:49 | |
| DuncanT | e0ne: I'm not aware of one. Raising a wish-list / feature request bug, maybe? | 14:50 |
| DuncanT | lpetrut: I've no idea, sorry. Do those same havks apply to the NFS code too? | 14:50 |
| DuncanT | lpetrut: s/havks/hacks/ | 14:52 |
| lpetrut | DuncanT: No, it's mainly targeting vhd/x images because of bugs/missing features on older versions of qemu-img. | 14:52 |
| DuncanT | lpetrut: I think that lowers the impact/risk then... still not sure of the process. I suggest putting a review up with a very clear commit message, and see if anybody complains? | 14:53 |
| *** cnesa1 has joined #openstack-cinder | 14:53 | |
| *** cnesa has quit IRC | 14:53 | |
| lpetrut | DuncanT: sure, thanks! | 14:53 |
| geguileo | e0ne: Do you have time to help me with my question? :) | 14:57 |
| *** markstur_ has joined #openstack-cinder | 14:57 | |
| e0ne | geguileo: i'm sorry, i don't know answer right now | 14:57 |
| geguileo | e0ne: Oh, ok, thanks :) | 14:58 |
| *** markstur_ has left #openstack-cinder | 14:58 | |
| openstackgerrit | Anton Arefiev proposed openstack/cinder: Fix lvm manage existing volume https://review.openstack.org/156939 | 14:58 |
| geguileo | e0ne: I'll try bothering someone else later ;) | 14:58 |
| e0ne | geguileo: afaik, iscsi_ip_address is configurable via cinder.conf | 14:59 |
| *** bswartz has quit IRC | 14:59 | |
| geguileo | e0ne: Yes, the thing is that as far as I can see it is not used for iSCSI with helpers lio and tgt, and it looks like a bug to me | 15:00 |
| geguileo | e0ne: But wanted confirmation | 15:00 |
| *** bswartz has joined #openstack-cinder | 15:00 | |
| *** annashen has joined #openstack-cinder | 15:00 | |
| openstackgerrit | Anton Arefiev proposed openstack/cinder: Fix QoSSpecManageApiTest to work in parallel https://review.openstack.org/159494 | 15:06 |
| *** kvidvans has joined #openstack-cinder | 15:08 | |
| *** e0ne is now known as e0ne_ | 15:09 | |
| *** BharatK has quit IRC | 15:11 | |
| *** annashen has quit IRC | 15:12 | |
| *** bkopilov has joined #openstack-cinder | 15:12 | |
| *** ebalduf has joined #openstack-cinder | 15:15 | |
| *** annegentle has quit IRC | 15:16 | |
| *** nellysmitt has quit IRC | 15:19 | |
| *** e0ne_ has quit IRC | 15:19 | |
| *** ebalduf has quit IRC | 15:20 | |
| *** pradipm has quit IRC | 15:20 | |
| *** Yogi11 has quit IRC | 15:21 | |
| *** markvoelker has quit IRC | 15:21 | |
| *** markvoelker has joined #openstack-cinder | 15:21 | |
| *** markvoelker has quit IRC | 15:26 | |
| *** TobiasE1 has quit IRC | 15:27 | |
| openstackgerrit | abhiram moturi proposed openstack/cinder: Enhance unit tests for zfssa drivers https://review.openstack.org/152676 | 15:27 |
| openstackgerrit | Petrut Lucian proposed openstack/cinder: SMBFS: Fix retrieving total allocated size https://review.openstack.org/158713 | 15:27 |
| *** Mandell has joined #openstack-cinder | 15:28 | |
| *** kallebe has quit IRC | 15:28 | |
| *** pdeore_ has quit IRC | 15:36 | |
| *** jungleboyj has joined #openstack-cinder | 15:37 | |
| *** Yogi1 has joined #openstack-cinder | 15:38 | |
| *** e0ne has joined #openstack-cinder | 15:39 | |
| *** jcru has joined #openstack-cinder | 15:40 | |
| *** scottda has joined #openstack-cinder | 15:42 | |
| *** jcru has quit IRC | 15:45 | |
| *** jcru has joined #openstack-cinder | 15:46 | |
| *** rushil has joined #openstack-cinder | 15:48 | |
| *** Tross has left #openstack-cinder | 15:49 | |
| *** markvoelker has joined #openstack-cinder | 15:51 | |
| jungleboyj | hemnafk: When you have a chance. This had to be rebased: https://review.openstack.org/#/c/154673/ | 15:55 |
| *** kallebe has joined #openstack-cinder | 15:58 | |
| *** ronis has quit IRC | 16:02 | |
| openstackgerrit | Richard Hagarty proposed openstack/cinder: Add flash cache policy to 3PAR driver https://review.openstack.org/157964 | 16:02 |
| *** mikedillion has joined #openstack-cinder | 16:03 | |
| *** anshul has quit IRC | 16:06 | |
| *** timcl has quit IRC | 16:07 | |
| *** sigmavirus24 is now known as Slackwarebot | 16:07 | |
| *** Slackwarebot is now known as sigmavirus24 | 16:07 | |
| *** timcl has joined #openstack-cinder | 16:08 | |
| *** changbl has joined #openstack-cinder | 16:09 | |
| *** nkrinner has quit IRC | 16:10 | |
| *** mikedillion has quit IRC | 16:11 | |
| *** timcl1 has joined #openstack-cinder | 16:11 | |
| *** timcl has quit IRC | 16:12 | |
| *** ebalduf has joined #openstack-cinder | 16:16 | |
| *** annegentle has joined #openstack-cinder | 16:16 | |
| *** TobiasE has joined #openstack-cinder | 16:17 | |
| openstackgerrit | Petrut Lucian proposed openstack/cinder: Fix retrieving the volume path and format when using SMBFS drivers https://review.openstack.org/159528 | 16:18 |
| *** ebalduf has quit IRC | 16:20 | |
| *** rmesta has joined #openstack-cinder | 16:21 | |
| *** sparr has quit IRC | 16:21 | |
| *** sparr has joined #openstack-cinder | 16:21 | |
| *** annegentle has quit IRC | 16:22 | |
| *** avishay__ has quit IRC | 16:22 | |
| *** avishay has joined #openstack-cinder | 16:22 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Retry requests in scheduler to wait for metrics https://review.openstack.org/156219 | 16:22 |
| *** crose has joined #openstack-cinder | 16:24 | |
| dulek_ | DuncanT, winston-d_zZZ: Finally I've updated patch for bug 1409012 to implement DuncanT's idea of retrying. | 16:24 |
| openstack | bug 1409012 in Cinder "Volume becomes in 'error' state after scheduler starts" [High,In progress] https://launchpad.net/bugs/1409012 - Assigned to Michal Dulko (michal-dulko-f) | 16:24 |
| dulek_ | I've had multiple problems with test_pure globally monkey-patching retry decorator. | 16:24 |
| *** dannywilson has joined #openstack-cinder | 16:25 | |
| *** ronis has joined #openstack-cinder | 16:26 | |
| *** deepakcs has quit IRC | 16:27 | |
| *** thangp has joined #openstack-cinder | 16:27 | |
| *** bill_az has quit IRC | 16:28 | |
| *** tsekiyama has joined #openstack-cinder | 16:28 | |
| *** TobiasE has quit IRC | 16:28 | |
| *** IanGovett has joined #openstack-cinder | 16:29 | |
| *** Mandell has quit IRC | 16:33 | |
| *** jdurgin1 has quit IRC | 16:34 | |
| *** david-lyle_afk is now known as david-lyle | 16:36 | |
| nikesh_vedams | Hi | 16:36 |
| nikesh_vedams | i have a couple of questions | 16:36 |
| nikesh_vedams | http://paste.openstack.org/show/182555/ | 16:37 |
| *** timcl1 has quit IRC | 16:37 | |
| *** IanGovett has quit IRC | 16:38 | |
| *** gary-smith_ has quit IRC | 16:39 | |
| *** gary-smith_ has joined #openstack-cinder | 16:40 | |
| *** rushiagr is now known as rushiagr_away | 16:40 | |
| *** IanGovett has joined #openstack-cinder | 16:41 | |
| dannywilson | nikesh_vedams: Good question. I don't know the answer but someone over in openstack-infra channel might be able to help | 16:42 |
| *** Apoorva has joined #openstack-cinder | 16:44 | |
| *** hemnafk is now known as hemna | 16:45 | |
| *** sgotliv has quit IRC | 16:46 | |
| *** rushiagr_away is now known as rushiagr | 16:47 | |
| *** pcaruana has quit IRC | 16:50 | |
| *** rwsu-afk is now known as rwsu | 16:50 | |
| hemna | winston-d_zZZ, DuncanT https://gist.github.com/WaltHP/583e6d937f8a15cf4433 | 16:53 |
| *** takedakn has joined #openstack-cinder | 16:53 | |
| *** annashen has joined #openstack-cinder | 16:55 | |
| *** lpetrut has quit IRC | 16:56 | |
| *** ronis has quit IRC | 16:59 | |
| *** afazekas_ is now known as afazekas | 17:00 | |
| *** jistr has quit IRC | 17:02 | |
| DuncanT | @hemna Looks like it does what I want... I can test it in the morning | 17:06 |
| openstackgerrit | Bob Callaway proposed openstack/cinder: NetApp eseries implementation for manage/unmanage https://review.openstack.org/138093 | 17:07 |
| *** Ilja has joined #openstack-cinder | 17:08 | |
| *** dulek has quit IRC | 17:10 | |
| *** dulek_ has quit IRC | 17:10 | |
| openstackgerrit | Bob Callaway proposed openstack/cinder: Add Manage/Unmanage support to NetApp NFS drivers https://review.openstack.org/158864 | 17:10 |
| *** IanGovett has quit IRC | 17:10 | |
| hemna | DuncanT, ok cool. | 17:11 |
| hemna | DuncanT, I tested it against LVM prior to adding the capability to LVM | 17:11 |
| hemna | and the scheduler said "no hosts found" | 17:11 |
| hemna | which was correct | 17:11 |
| hemna | then added the capability to the lvm stats, and the scheduler found the lvm host. | 17:11 |
| hemna | so I think it does what you wanted. | 17:12 |
| hemna | so the question is, do we just not update any drivers for K to add the multiattach capability in their stats? this would prevent all creates with --allow-multiattach from finding a host | 17:12 |
| *** timcl has joined #openstack-cinder | 17:12 | |
| hemna | the other way to look at it is, we could still add multiattach=True to a few drivers | 17:13 |
| hemna | creates would work | 17:13 |
| hemna | and a single attach would work | 17:13 |
| hemna | then when L ships, those volumes can attach a second time, once the nova code lands. | 17:13 |
| openstackgerrit | xing-yang proposed openstack/cinder: Fixed a concurrency issue in VMAX driver https://review.openstack.org/157683 | 17:14 |
| *** xyang has quit IRC | 17:14 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Fixed a concurrency issue in VMAX driver https://review.openstack.org/157683 | 17:16 |
| *** annashen has quit IRC | 17:16 | |
| *** ebalduf has joined #openstack-cinder | 17:17 | |
| *** timcl has quit IRC | 17:17 | |
| *** annashen has joined #openstack-cinder | 17:17 | |
| *** avishay has quit IRC | 17:17 | |
| *** annegentle has joined #openstack-cinder | 17:18 | |
| *** nellysmitt has joined #openstack-cinder | 17:20 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Fixed a problem in recreating masking view in VMAX https://review.openstack.org/157684 | 17:20 |
| jungleboyj | hemna: xyang1 If you two are doing reviews here are two that should be ready to go in: https://review.openstack.org/#/c/141914/ | 17:21 |
| jungleboyj | https://review.openstack.org/#/c/141915/ | 17:21 |
| *** ebalduf has quit IRC | 17:21 | |
| hemna | ok just a sec | 17:21 |
| jungleboyj | Part of the priority list for K-3. | 17:21 |
| *** _cjones_ has joined #openstack-cinder | 17:21 | |
| xyang1 | jungleboyj: Will take a look | 17:21 |
| jungleboyj | xyang1: Thank you. | 17:22 |
| *** annegentle has quit IRC | 17:23 | |
| *** nellysmitt has quit IRC | 17:25 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Fixed errors in docstrings in the VMAX driver https://review.openstack.org/157922 | 17:25 |
| hemna | DuncanT, would you like me to add that gist as a follow up patch to my existing? | 17:26 |
| hemna | DuncanT, it might make it easier to review. | 17:26 |
| hemna | or I can add it to my existing patch. | 17:26 |
| DuncanT | hemna: Followup is fine by me, whatever is easier for you. I'm happy enough with most of the code | 17:27 |
| openstackgerrit | xing-yang proposed openstack/cinder: Check license before clone in VMAX driver https://review.openstack.org/159553 | 17:29 |
| *** leeantho has joined #openstack-cinder | 17:30 | |
| xyang1 | jungleboyj: Why are V1 changes needed? | 17:32 |
| *** mriedem is now known as mriedem_away | 17:34 | |
| hemna | DuncanT, ok | 17:35 |
| hemna | I'll post a follow up | 17:35 |
| jungleboyj | xyang1: | 17:35 |
| *** Yogi1 has quit IRC | 17:35 | |
| jungleboyj | xyang1: Hold on. | 17:35 |
| xyang1 | Ok | 17:35 |
| *** IanGovett has joined #openstack-cinder | 17:36 | |
| jungleboyj | I know I asked Steve that before. | 17:36 |
| *** tries__ has joined #openstack-cinder | 17:36 | |
| *** tries__ has joined #openstack-cinder | 17:36 | |
| hemna | jungleboyj, we are seeing some odd behavior with one of our drivers after an oslo update | 17:37 |
| jungleboyj | xyang1: Because the function signature changed sort_key vs. sort_keys | 17:37 |
| jungleboyj | hemna: Ruh roh. | 17:38 |
| *** karimb has quit IRC | 17:39 | |
| jungleboyj | hemna: I need to run. Back shortly and we can chat. | 17:39 |
| hemna | jungleboyj, ok, I'm going to test something locally | 17:39 |
| hemna | CI is now failing on every patch for lefthand | 17:39 |
| kaufer | xyang1: The function used to only accept a single sort key, now it's a list so I changed to sort_keys | 17:39 |
| hemna | and we haven't changed the lefthand driver, nor the client it uses. | 17:40 |
| *** hodos|2 has joined #openstack-cinder | 17:41 | |
| *** nellysmitt has joined #openstack-cinder | 17:41 | |
| xyang1 | kaufer: So that is a common function used by both v1 and v2? | 17:41 |
| kaufer | xyang1: correct, both v1 and v2 invoke the volume api get_all() function | 17:42 |
| *** karimb has joined #openstack-cinder | 17:43 | |
| *** yuriy_n17 has quit IRC | 17:43 | |
| kaufer | xyang1: And that is were the kwarg in the signature changed | 17:43 |
| xyang1 | kaufer: Ok | 17:43 |
| *** karimb has quit IRC | 17:43 | |
| *** hodos has quit IRC | 17:44 | |
| *** sseverson has joined #openstack-cinder | 17:49 | |
| *** lpetrut has joined #openstack-cinder | 17:50 | |
| *** sgotliv has joined #openstack-cinder | 17:51 | |
| xyang1 | kaufer: jungleboyj is the v1 change backward compatible? | 17:54 |
| kmartin | hemna, https://review.openstack.org/#/c/145780/ | 17:54 |
| kaufer | xyang1: Yes, it does not change the API contract, sorting is not supported in v1 | 17:55 |
| kaufer | xyang1: The sort key/direction is still created_at/desc and that is now passed to the volume API as a list instead of a string | 17:56 |
| xyang1 | kaufer: ok | 17:56 |
| *** cpallares has joined #openstack-cinder | 17:57 | |
| *** jordanP has quit IRC | 18:01 | |
| *** kbyrne has quit IRC | 18:03 | |
| *** xyang has joined #openstack-cinder | 18:03 | |
| *** emagana has joined #openstack-cinder | 18:03 | |
| *** hodos|2 has quit IRC | 18:03 | |
| *** Mandell has joined #openstack-cinder | 18:04 | |
| e0ne | xyang1, kaufer: just 2c from mi side. i've tested it with cinder client and it works for me | 18:05 |
| *** kbyrne has joined #openstack-cinder | 18:05 | |
| *** emagana has quit IRC | 18:07 | |
| xyang1 | e0ne: Great! Thanks | 18:09 |
| *** vilobhmm has joined #openstack-cinder | 18:13 | |
| e0ne | xyang1: np. i had to verify that it not breaks api v1 | 18:13 |
| *** vilobhmm1 has joined #openstack-cinder | 18:14 | |
| *** afazekas has quit IRC | 18:16 | |
| *** ebalduf has joined #openstack-cinder | 18:17 | |
| *** vilobhmm has quit IRC | 18:18 | |
| *** ronis has joined #openstack-cinder | 18:19 | |
| *** annegentle has joined #openstack-cinder | 18:19 | |
| *** ebalduf has quit IRC | 18:22 | |
| *** annegentle has quit IRC | 18:24 | |
| *** bswartz has quit IRC | 18:26 | |
| *** patrickeast has joined #openstack-cinder | 18:29 | |
| jungleboyj | hemna: I am back. What did you break? | 18:35 |
| hemna | getting very odd behavior with imports | 18:35 |
| hemna | I can't explain it | 18:36 |
| jungleboyj | hemna: Not what I was expecting you to say. | 18:37 |
| *** Miouge has quit IRC | 18:39 | |
| *** mtanino has joined #openstack-cinder | 18:40 | |
| *** cpallares has quit IRC | 18:42 | |
| *** bswartz has joined #openstack-cinder | 18:43 | |
| *** jgravel has quit IRC | 18:43 | |
| *** Miouge has joined #openstack-cinder | 18:45 | |
| jungleboyj | hemna: Anything I can do to help right now? | 18:47 |
| hemna | jungleboyj, have a magic wand? | 18:47 |
| jungleboyj | hemna: He he he. | 18:48 |
| jungleboyj | hemna: You really want me to answer that? | 18:48 |
| hemna | hey now | 18:48 |
| *** avishay has joined #openstack-cinder | 18:48 | |
| jungleboyj | :-) | 18:48 |
| *** coolsvap is now known as coolsvap_ | 18:48 | |
| *** bswartz1 has joined #openstack-cinder | 18:48 | |
| jungleboyj | hemna: I don't think there was anything that got pulled in by the oslo changes that should cause weird import behavior. | 18:49 |
| *** bswartz has quit IRC | 18:49 | |
| *** bswartz1 is now known as bswartz | 18:49 | |
| *** Mandell has quit IRC | 18:51 | |
| * jungleboyj gets out my red marker for tbarron 's NFS patch. :-) | 18:53 | |
| tbarron | Wooho! | 18:53 |
| tbarron | ?? Woohoo! | 18:53 |
| * jungleboyj knew thtat would make tbarron Happy. | 18:53 | |
| *** tries__ has quit IRC | 18:54 | |
| * tbarron wasn't calling jungleboyj names. | 18:54 | |
| *** Thelo has quit IRC | 18:54 | |
| jungleboyj | Oh, it starts with most of this code can be removed in the commit message. Uh oh. | 18:54 |
| tbarron | jungleboyj: The eventual plan is to put a posix filesystem driver between the chunked driver and the nfs driver. | 18:55 |
| tbarron | But I am not, for obscure NetApp legal reasons, allowed to write posix driver code. | 18:56 |
| jungleboyj | tbarron: I know, the commit message explains. I was just giving you a hard time. | 18:56 |
| tbarron | So I am posting an NFS driver that inherits directly from posix. | 18:56 |
| tbarron | jungleboyj: kk | 18:56 |
| jungleboyj | I remember talking about that at the meet-up and everyone was onboard with the plan. | 18:56 |
| tbarron | jungleboyj: cool | 18:57 |
| jungleboyj | Just thought it was funny as I get ready to review seeing that. | 18:57 |
| *** Mandell has joined #openstack-cinder | 18:57 | |
| *** IanGovett has quit IRC | 18:58 | |
| *** avishay has quit IRC | 18:59 | |
| *** Mandell has quit IRC | 18:59 | |
| *** jgravel has joined #openstack-cinder | 18:59 | |
| *** e0ne is now known as e0ne_ | 19:00 | |
| jungleboyj | hemna: You talking about this: | 19:00 |
| jungleboyj | ./cinder/volume/drivers/san/hp/hp_3par_common.py:49:5: H302 import only modules.'from hp3parclient import client' does not import a module | 19:00 |
| hemna | jungleboyj, so kinda yah, we are looking at the lefthand driver | 19:01 |
| smcginnis | jungleboyj: That looks like the pep8 patch that just went in. | 19:01 |
| jungleboyj | Yeah. Ok, that wasn't me! | 19:01 |
| jungleboyj | ;-) | 19:01 |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/san/hp/hp_lefthand_rest_proxy.py#L123-L124 | 19:02 |
| smcginnis | jungleboyj: Get out of jail free card. :) | 19:02 |
| hemna | they changed the imports | 19:02 |
| hemna | and removed the from hplefthandclient import client as hp_lh_client | 19:02 |
| hemna | and are trying to access the package's module w/o importing it | 19:02 |
| hemna | the CI for the patch FAILED | 19:02 |
| *** Mandell has joined #openstack-cinder | 19:02 | |
| hemna | as it should | 19:02 |
| hemna | https://review.openstack.org/#/c/145780/15/cinder/volume/drivers/san/hp/hp_lefthand_rest_proxy.py,cm | 19:03 |
| smcginnis | hemna: Odd that wasn't caught by Jenkins... | 19:03 |
| hemna | smcginnis, so in jenkins the import fails and falls back to the except | 19:04 |
| hemna | and uses the fake | 19:04 |
| hemna | which causes the access to hplefthandclient.client to work, because hplefthandclient is a mock | 19:04 |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/san/hp/hp_lefthand_rest_proxy.py#L35 | 19:04 |
| smcginnis | hemna: Oh, duh. I see. | 19:04 |
| hemna | so I'll revert this patch for the lefthand driver | 19:05 |
| smcginnis | hemna: Yeah, that could be a problem. :] | 19:05 |
| hemna | so | 19:05 |
| hemna | so the lefthand 3rd party CI correctly fails on that patch | 19:05 |
| hemna | http://15.126.198.151/80/145780/15/check/lefthand-iscsi-driver-master-client-pip-dsvm/3927e3d/logs/screen-c-vol.txt.gz?level=ERROR | 19:05 |
| hemna | pewp! | 19:05 |
| hemna | and it was ignored. | 19:06 |
| hemna | *sigh* | 19:06 |
| hemna | so everything worked as it should | 19:06 |
| hemna | and we still missed it | 19:06 |
| hemna | :( | 19:06 |
| *** timcl has joined #openstack-cinder | 19:06 | |
| hemna | 'worked as it should' meaning the 3rd party CI failed correctly | 19:06 |
| *** tries__ has joined #openstack-cinder | 19:06 | |
| *** tries__ has joined #openstack-cinder | 19:06 | |
| smcginnis | hemna: I think right now CI failures are so unreliable. | 19:06 |
| smcginnis | hemna: It will be nice when they are. | 19:07 |
| hemna | smcginnis, yah that's the other side of it | 19:07 |
| hemna | since CI isn't really reliable, we don't vote | 19:07 |
| smcginnis | hemna: Kind of crying wolf too much right now. | 19:07 |
| *** jungleboyj has quit IRC | 19:07 | |
| hemna | but it does raise the issue | 19:07 |
| smcginnis | hemna: And to be clear, I'm not referring to HP's CI but all. | 19:07 |
| smcginnis | hemna: I agree, it's a problem. | 19:07 |
| hemna | if folks aren't even looking at the 3rd party CI failures when they touch other people's drivers, then why are we doing 3rd party CI at all ? | 19:08 |
| hemna | !! | 19:08 |
| openstack | hemna: Error: "!" is not a valid command. | 19:08 |
| hemna | heh | 19:08 |
| smcginnis | LOL | 19:08 |
| smcginnis | That is a really good point. | 19:08 |
| *** jungleboyj has joined #openstack-cinder | 19:08 | |
| smcginnis | If someone touches someone elses driver, really they should investigate any third party CI failures. | 19:08 |
| smcginnis | I know I will from now on. | 19:08 |
| akerr_ | ci is the bane of my life right now | 19:09 |
| smcginnis | akerr_: You aren't the only one. :) | 19:09 |
| *** bswartz has quit IRC | 19:09 | |
| sigmavirus24 | akerr_: take that up with Ra's al Ghul | 19:09 |
| sigmavirus24 | (bane... batman... nevermind) | 19:09 |
| jungleboyj | phew, so it wasn't me that broke things? | 19:09 |
| hemna | smcginnis, yah, especially since they aren't voting | 19:09 |
| smcginnis | I completely agree with the need for CI (and the lefthand issue reinforces that) but it's a huge PITA until things mature. | 19:09 |
| *** bswartz has joined #openstack-cinder | 19:09 | |
| hemna | jungleboyj, yah it's not oslo | 19:10 |
| smcginnis | jungleboyj: We'll still blame you. :) | 19:10 |
| hemna | we thought it might have been because of the timing of the failures | 19:10 |
| hemna | wrt another oslo review | 19:10 |
| jungleboyj | hemna: Yay! Back to my regularly scheduled programming. | 19:10 |
| hemna | :) | 19:10 |
| * jungleboyj would only touch HPs drivers with the greatest care and respet. | 19:10 | |
| jungleboyj | *respect | 19:10 |
| smcginnis | hemna: I did review that patch, so for my part I apologize for not catching that. | 19:11 |
| *** jdurgin has quit IRC | 19:13 | |
| *** tries__ has quit IRC | 19:14 | |
| *** timcl1 has joined #openstack-cinder | 19:15 | |
| *** timcl has quit IRC | 19:16 | |
| *** ebalduf has joined #openstack-cinder | 19:18 | |
| jungleboyj | tbarron: What is 0o770 for a file permissions setting? | 19:20 |
| hemna | smcginnis, no worries. the author should have looked at the 3rd party CI failures | 19:20 |
| hemna | but yah, reviewers should take note: | 19:20 |
| jungleboyj | tbarron: Never seen an 'o' in there before. | 19:21 |
| hemna | if a patch touches a driver, check the 3rd party CI for those drivers. | 19:21 |
| smcginnis | hemna: agreed | 19:21 |
| *** coolsvap_ is now known as coolsvap | 19:21 | |
| jungleboyj | hemna: +1 | 19:21 |
| hemna | no thingee today ? | 19:21 |
| jungleboyj | hemna: Haven't seen him around. He has had some personal stuff going on. | 19:22 |
| *** Mandell has quit IRC | 19:22 | |
| *** ebalduf has quit IRC | 19:23 | |
| smcginnis | Speaking of CIs... | 19:24 |
| smcginnis | I'm trying to get our FC tests going. | 19:24 |
| smcginnis | I'm getting random test failures that time out. | 19:25 |
| smcginnis | I'm tracing one | 19:25 |
| hemna | ew | 19:25 |
| smcginnis | And all within the same second a volume creation request is initiated, it runs, everything looks good. | 19:25 |
| smcginnis | I trace through the req ID and it goes along for a few milliseconds, then nothing. | 19:25 |
| smcginnis | And the test shows it timed out. | 19:26 |
| smcginnis | Any tips on how to triage something like this? | 19:26 |
| *** Mandell has joined #openstack-cinder | 19:26 | |
| *** Mandell has quit IRC | 19:26 | |
| *** Mandell has joined #openstack-cinder | 19:27 | |
| patrickeast | does it only repo on the CI? | 19:27 |
| smcginnis | patrickeast: Yeah. :[ | 19:27 |
| smcginnis | We can run through the tests all day long on our development machines and it's fine. | 19:27 |
| smcginnis | patrickeast: At least so far. | 19:27 |
| hemna | so it's getting lost in the queue ? | 19:28 |
| tbarron | jungleboyj: you're talking chmod, I guess. | 19:28 |
| jungleboyj | tbarron: Yes. | 19:28 |
| smcginnis | Just inconsistently consistent enough to drive me crazy. | 19:28 |
| tbarron | it's reportedly the way to make sure you are using octal and be python3 compatible | 19:28 |
| *** anshul has joined #openstack-cinder | 19:29 | |
| smcginnis | Or consistently inconsistent. One of the two. :) | 19:29 |
| *** tries__ has joined #openstack-cinder | 19:29 | |
| *** tries__ has joined #openstack-cinder | 19:29 | |
| *** asmith_brcd has joined #openstack-cinder | 19:29 | |
| jungleboyj | tbarron: Ok, so 0o660 == 0660 | 19:29 |
| patrickeast | smcginnis: we ran into some random failures like that (still hvae them on our backlog of mysteries to look into) but they don’t repro if you run the tests with concurrency=1 | 19:29 |
| patrickeast | we looked into it and were unable to figure out yet if the issue was cinder, our driver, our backend, or something in tempest | 19:30 |
| smcginnis | patrickeast: I have seen that help other weird issues. | 19:30 |
| tbarron | jungleboyj: right, if you want to put a placeholder remark I'll chase down the link that documents this. | 19:30 |
| tbarron | that way if I've misinterpreted or something we can fix it. | 19:30 |
| *** jdurgin has joined #openstack-cinder | 19:30 | |
| smcginnis | patrickeast: Seems like over 4 and you're asking for trouble, but even 2-4 have possible issues. | 19:30 |
| patrickeast | yea | 19:30 |
| smcginnis | patrickeast: Really would hate to limit to one on the CI. | 19:30 |
| jungleboyj | tbarron: No, all good,. I googled and found plenty of examples of it being used. Just no explanation as to why. | 19:30 |
| tbarron | I'd definitely appreciate more than my own two eyes on that | 19:30 |
| smcginnis | Might be a good test though. | 19:30 |
| patrickeast | i saw with 2-4 workers it was like 90% success rate | 19:30 |
| patrickeast | maybe more | 19:30 |
| jungleboyj | patrickeast: Do you have the latest comments from you spec integrated here: https://review.openstack.org/#/c/151837/ | 19:31 |
| smcginnis | patrickeast: That's what I'm seeing with our iSCSI (which is odd that there's a difference). | 19:31 |
| patrickeast | jungleboyj: yep, its all up to date | 19:31 |
| * jungleboyj takes my red pen over to patrickeast 's patch. :-) | 19:31 | |
| patrickeast | smcginnis: i’ve noticed issues with timing with udev stuff in the past, i suspect there might be more of them | 19:31 |
| *** sgotliv has quit IRC | 19:31 | |
| patrickeast | smcginnis: with iscsi* | 19:31 |
| smcginnis | patrickeast: Guess I'll keep digging. But thanks for the concurrency = 1 suggestion. I think I'll try that once. | 19:33 |
| smcginnis | patrickeast: Do you have the syntax off hand? I think I always mess it up and have to dig for it. :) | 19:33 |
| *** Yogi1 has joined #openstack-cinder | 19:33 | |
| patrickeast | funny enough i also found if we run with less resources (4 cores instead of 8, 8gb ram instead of 16) it fails less frequenty per test too… which kind of points to concurrency issues | 19:33 |
| patrickeast | for tox i think its —CONCURRENCY=1 | 19:33 |
| patrickeast | iirc | 19:33 |
| smcginnis | patrickeast: I think unless you specify it will be concurrency=[# of cores] | 19:33 |
| patrickeast | maybe not all caps | 19:33 |
| *** Yogi11 has joined #openstack-cinder | 19:33 | |
| patrickeast | i forget | 19:33 |
| smcginnis | patrickeast: Cool, thanks. | 19:34 |
| smcginnis | patrickeast: That's OK, I want to yell at it anyway so I'll try caps. ;) | 19:34 |
| *** diemt has joined #openstack-cinder | 19:36 | |
| openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Adds pool aware scheduling for HNAS drivers https://review.openstack.org/142133 | 19:36 |
| openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Adds SSH communication to HNAS drivers https://review.openstack.org/142904 | 19:36 |
| openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Fix HNAS driver parsing errors https://review.openstack.org/141868 | 19:36 |
| *** Yogi1 has quit IRC | 19:37 | |
| *** crose has quit IRC | 19:38 | |
| *** jgravel has quit IRC | 19:38 | |
| *** geguileo has quit IRC | 19:39 | |
| *** crose has joined #openstack-cinder | 19:40 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Fixes the import for Lefthand driver https://review.openstack.org/159586 | 19:43 |
| *** anshul has quit IRC | 19:46 | |
| jungleboyj | hemna: Typo in the commit message ^^ | 19:46 |
| hemna | k | 19:47 |
| openstackgerrit | Jay Bryant proposed openstack/cinder: Sync middleware module from oslo-incubator https://review.openstack.org/156455 | 19:47 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Fixes the import for Lefthand driver https://review.openstack.org/159586 | 19:47 |
| *** asmith_brcd has quit IRC | 19:50 | |
| *** e0ne_ is now known as e0ne | 19:52 | |
| *** jkraj has quit IRC | 19:55 | |
| *** sgotliv has joined #openstack-cinder | 19:56 | |
| *** Saba has joined #openstack-cinder | 19:56 | |
| *** kallebe has left #openstack-cinder | 19:56 | |
| Saba | Hi, how to get volume usage ?? | 19:56 |
| *** Saba is now known as Guest78621 | 19:57 | |
| kaufer | jungleboyj: For my sort reviews do we need to ensure that the delta to the spec is merged? One of the reviews is +A but my delta to the spec (for the new sorting syntax) is not: https://review.openstack.org/#/c/153061/ | 20:01 |
| *** jungleboyj_ has joined #openstack-cinder | 20:01 | |
| jungleboyj_ | hemna: Want me to nija merge 159586 ? | 20:02 |
| *** jungleboyj has quit IRC | 20:03 | |
| hemna | yes please | 20:05 |
| hemna | once jenkins +1 | 20:05 |
| jungleboyj_ | hemna: Will do | 20:05 |
| hemna | thanks | 20:05 |
| hemna | I'm writing up a ML post about this. | 20:06 |
| patrickeast | jenkins and the hp ci, right? :p | 20:06 |
| hemna | heh yah | 20:06 |
| *** vilobhmm1 has quit IRC | 20:07 | |
| *** vilobhmm has joined #openstack-cinder | 20:07 | |
| kaufer | jungleboyj_: For my sort reviews do we need to ensure that the delta to the spec is merged? One of the reviews is +A but my delta to the spec (for the new sorting syntax) is not: https://review.openstack.org/#/c/153061/ | 20:09 |
| *** nellysmitt has quit IRC | 20:09 | |
| *** rlucio has joined #openstack-cinder | 20:10 | |
| jungleboyj_ | kaufer: So, it is updated to match the code but hasn't merged yet? | 20:11 |
| openstackgerrit | Mike Perez proposed openstack/cinder: Update v1 deprecation warnings https://review.openstack.org/159596 | 20:11 |
| kaufer | jungleboyj_: Yeah, once all of the cross project and API WG sorting stuff was mereged then the spec was out of date, so I submitted a delta to the spec | 20:12 |
| *** Mandell has quit IRC | 20:12 | |
| kaufer | jungleboyj_: the code reflects the updated spec | 20:12 |
| jungleboyj_ | kaufer: Ok, it has a +2 from Mike. I would just ping jgriffith and DuncanT and see if you can get one of them to merge https://review.openstack.org/#/c/153061/ . | 20:13 |
| Guest78621 | Hi, Does anyone know how to compute volume usage in cinder ? | 20:14 |
| kaufer | jungleboyj_: Thx | 20:14 |
| jungleboyj_ | kaufer: Welcome. | 20:15 |
| guitarzan | Guest78621: cinder quota-usage-show will show you I think | 20:17 |
| *** ebalduf has joined #openstack-cinder | 20:19 | |
| *** aix has quit IRC | 20:22 | |
| *** ebalduf has quit IRC | 20:23 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 20:32 | |
| Guest78621 | cinder quota-usage-show doesnt show the usage of volume | 20:33 |
| *** tbarron has quit IRC | 20:33 | |
| *** tbarron has joined #openstack-cinder | 20:33 | |
| guitarzan | Guest78621: I guess I don't understand what you're after | 20:35 |
| guitarzan | what is "usage of volume" | 20:35 |
| Guest78621 | My aim is to get real usage of the Storage (not allocated) | 20:36 |
| guitarzan | ah, that's been discussed, but I don't know where it ended up | 20:36 |
| guitarzan | the easy answer is "ask your storage device" :) | 20:37 |
| *** bill_az has joined #openstack-cinder | 20:38 | |
| Guest78621 | I want to read via meter for our monitoring software | 20:39 |
| *** Mandell has joined #openstack-cinder | 20:40 | |
| *** mriedem_away is now known as mriedem | 20:47 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Allow archiving deleted rows to shadow tables, for performance https://review.openstack.org/131182 | 20:49 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Allow archiving deleted rows to shadow tables, for performance https://review.openstack.org/131182 | 20:50 |
| openstackgerrit | Sean McGinnis proposed openstack/cinder: Remove use of contextlib.nested https://review.openstack.org/158732 | 20:50 |
| *** asmith_brcd has joined #openstack-cinder | 20:50 | |
| *** dustins has joined #openstack-cinder | 20:54 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder: Remove use of contextlib.nested https://review.openstack.org/158732 | 20:54 |
| *** tbarron1 has joined #openstack-cinder | 20:56 | |
| *** morganfainberg is now known as needscoffee | 20:57 | |
| *** tbarron has quit IRC | 20:59 | |
| e0ne | jungleboyj_: hi! do you think that we need new oslo.middleware from incubator? | 21:00 |
| e0ne | hemna: i'm sorry that we broke you driver:( | 21:01 |
| *** lcurtis has quit IRC | 21:05 | |
| *** rushiagr is now known as rushiagr_away | 21:06 | |
| jungleboyj_ | e0ne: Yes, so that we can stop getting the oslo.middleware warning every time flake8 is run. | 21:09 |
| smcginnis | +1 | 21:09 |
| jungleboyj_ | It is a small change and as Mike pointed out it is good to pull in the library requirement. | 21:09 |
| e0ne | jungleboyj_: but it will be replaced with oslo_middleware soon | 21:10 |
| jgriffith | hemna: that's a bummer on that hacking change | 21:11 |
| *** jgravel has joined #openstack-cinder | 21:11 | |
| jgriffith | hemna: but honestly, kinda cool that the issue was found and fixed in less than a day no? | 21:11 |
| jungleboyj_ | e0ne: Ok, so do you think we should just remove oslo.middleware from incubator for this change? | 21:12 |
| hemna | jgriffith, yah it's all good. | 21:12 |
| jgriffith | hemna: uh oh... the sounds like "it's all good, but it's not" response | 21:13 |
| e0ne | jungleboyj_: yes. we need to force moving to a stand-alone libs instead of incubator | 21:13 |
| jungleboyj_ | jgriffith: Good point. CI working. | 21:13 |
| jungleboyj_ | Ok, let me try making that change. | 21:13 |
| jungleboyj_ | Go ahead and -1 that. | 21:13 |
| *** cnesa1 has quit IRC | 21:13 | |
| e0ne | jungleboyj_: now you are trying to do the change what will be removed with a next commit | 21:13 |
| hemna | honestly, I just waited to raise the issue on the ML | 21:14 |
| hemna | to get folks thinking about it | 21:14 |
| hemna | we aren't upset at all | 21:14 |
| jungleboyj_ | e0ne: Good point. I will push a new patch up. | 21:14 |
| jgriffith | hemna: ok, cool. and yeah, it's a super valid point | 21:14 |
| hemna | and in fact are happy that the CI did bring it to light and we were able to fix it. | 21:14 |
| e0ne | jungleboyj_: did you see my comment there? | 21:14 |
| jgriffith | hemna: I just don't know about the voiting thing at least yet. | 21:15 |
| *** coolsvap is now known as coolsvap_ | 21:15 | |
| jgriffith | Surely could/should be better about at least "looking" though | 21:15 |
| hemna | yah I don't think voting makes sense right now either | 21:15 |
| jgriffith | hemna: don't disagree there | 21:15 |
| hemna | I was chatting with asselin at lunch about a health dashboard | 21:15 |
| *** lpetrut has quit IRC | 21:16 | |
| hemna | it would be nice to gauge the health of individual CI over time | 21:16 |
| jgriffith | hemna: I keep wanting that too | 21:16 |
| patrickeast | there was something in the works for that | 21:16 |
| jgriffith | I know anteaya has referenced a project under way multiple times since FTC meetup | 21:16 |
| patrickeast | not sure what happened to it | 21:16 |
| jgriffith | patrickeast: +1 | 21:16 |
| erlon | e0ne: Hi Ivan, not sure what you mean in HNAS ssh change | 21:16 |
| anteaya | hi | 21:16 |
| e0ne | jungleboyj_: and this request https://review.openstack.org/#/c/134759/ | 21:16 |
| anteaya | what did I do? | 21:16 |
| jgriffith | anteaya: it's all your fault :) | 21:16 |
| anteaya | of course it is | 21:16 |
| * anteaya dons her armour | 21:16 | |
| jgriffith | anteaya: the topic of the third party CI health/dashboard came up again | 21:17 |
| jgriffith | anteaya: and no, nothing is your fault (this time) :) | 21:17 |
| anteaya | oh whew | 21:17 |
| patrickeast | https://review.openstack.org/#/c/135170/ | 21:17 |
| patrickeast | ^ this thing | 21:17 |
| anteaya | radar | 21:17 |
| hemna | anteaya, fwiw, I posted on the cinder ML about a 3rd party CI issue. | 21:17 |
| e0ne | erlon: as i anderstand your code, you try to re-raise exception, do you? | 21:18 |
| anteaya | hemna: I read with interest, good post | 21:18 |
| anteaya | jgriffith: and nice reply | 21:18 |
| hemna | anteaya, in the end as jgriffith commented, worked out well. | 21:18 |
| anteaya | it did | 21:18 |
| anteaya | and was good to let folks know what is happening | 21:18 |
| anteaya | so thank you | 21:18 |
| erlon | e0ne: yes, I just catch it, so I can log, and then I have to re-raise it so cinder can catch | 21:19 |
| e0ne | erlon: from the python docs "If no expressions are present, raise re-raises the last exception that was active in the current scope. I" | 21:19 |
| jungleboyj_ | e0ne: Oh, didn't know we had a patch for that out there. | 21:19 |
| e0ne | erlon: so you need only 'raise' statement | 21:19 |
| erlon | e0ne: do know why the change lost all reviews? it had a +2 IIRC | 21:19 |
| mtanino | jungleboyj_: Hi, Can I get your red pen for this? https://review.openstack.org/#/c/154739/6 | 21:19 |
| jungleboyj_ | I need to drop off for a bit. I will look at the patch you sent and mine. | 21:19 |
| jungleboyj_ | e0ne: ^^ | 21:20 |
| jungleboyj_ | mtanino: Sure. | 21:20 |
| mtanino | jungleboyj_: I got an agreement from Avishay. | 21:20 |
| *** ebalduf has joined #openstack-cinder | 21:20 | |
| smcginnis | e0ne, erlon: One other data point, if you don't just "raise" you lose the original traceback. | 21:20 |
| jgriffith | patrickeast: anteaya oh dear, that's a victim of scope creep isn't it | 21:20 |
| mtanino | jungleboyj_: thank you :) | 21:20 |
| smcginnis | So could make troubleshooting a little harder. | 21:20 |
| jgriffith | I would just like a simple dashboard showing, total-runs, passed, failed | 21:21 |
| anteaya | jgriffith: yes, would be good to have some feedback on how to get it to a managble size | 21:21 |
| jgriffith | that alone would be aweomse | 21:21 |
| anteaya | jgriffith: and might possibly be small enough to exist | 21:21 |
| smcginnis | anteaya: +1 | 21:21 |
| anteaya | jgriffith: do share your thoughts to that effect on the spec | 21:21 |
| *** lcurtis has joined #openstack-cinder | 21:21 | |
| anteaya | so weigh in | 21:21 |
| e0ne | erlon: what change did lost them? | 21:21 |
| anteaya | since i don't know anyone who doesn't want a dashboard | 21:21 |
| *** changbl has quit IRC | 21:21 | |
| erlon | e0ne: so, using only one exception I would have to Log inside the exeption | 21:21 |
| anteaya | we just have to have enough behind something to get something up | 21:22 |
| smcginnis | erlon: No, you can still log. Then just "raise" alone reraises it. | 21:22 |
| erlon | e0ne: https://review.openstack.org/#/c/142904/ | 21:22 |
| erlon | e0ne: the othere ones (in the dependencies) ware also rebased and keep the reviews | 21:23 |
| e0ne | erlon: i'm talking about such case: http://paste.openstack.org/show/182677/ | 21:24 |
| *** ebalduf has quit IRC | 21:24 | |
| smcginnis | e0ne, erlon: Just commented. | 21:25 |
| *** tsekiyama has quit IRC | 21:26 | |
| smcginnis | erlon: Oh, also forgot to point out six.text_type(e) is not necessary there. | 21:26 |
| *** tsekiyama has joined #openstack-cinder | 21:26 | |
| smcginnis | The logger handles that correctly. | 21:26 |
| e0ne | smcginnis: thanks! | 21:26 |
| smcginnis | e0ne: np :) | 21:26 |
| *** jungleboyj_ has quit IRC | 21:27 | |
| erlon | e0ne: smcginnis: o_O, it wasn't that 3 PS ago, someone asked to use | 21:27 |
| xyang | jgriffith: can you take a look of this small change? https://review.openstack.org/#/c/159336/ | 21:27 |
| smcginnis | erlon: Yeah, sorry, there was some confusion about that. We did some testing to validate and six is not needed. | 21:28 |
| e0ne | erlon, smcginnis: maybe it was me:(, it's not required there but it makes this more excplicit. i won't -1 for six.text_type(exception) | 21:28 |
| smcginnis | e0ne: I agree. But it is redundant because the logger ultimately ends up doing it too. | 21:29 |
| erlon | e0ne: thanks for the paste, I was trying to understand the raise re-raise thing | 21:29 |
| *** timcl1 has quit IRC | 21:30 | |
| erlon | e0ne: IIUC, just calling raise, will throw the last exeception | 21:30 |
| e0ne | erlon: you're welcome! here the python docs: https://docs.python.org/2/reference/simple_stmts.html#raise | 21:30 |
| e0ne | erlon: yes, it will | 21:30 |
| erlon | e0ne: good, Ill fix that | 21:31 |
| jgriffith | xyang: way too much code there, I can't possibly review that today :) | 21:34 |
| *** timcl has joined #openstack-cinder | 21:34 | |
| xyang | jgriffith: ok, add to your review list then:) | 21:35 |
| jgriffith | xyang: LOL | 21:35 |
| jgriffith | xyang: approved... I am surprised though, I would've never thought that thin would gak over it only being 2 | 21:35 |
| jgriffith | xyang: in fact I would've thought you could set it to 1 | 21:35 |
| jgriffith | xyang: or is that specific to some "other" driver? | 21:36 |
| xyang | jgriffith: 1.0 was what I had originally. you said it should be at least 2.0?:) | 21:36 |
| jgriffith | xyang: sounds like me :) | 21:36 |
| *** jcru has quit IRC | 21:36 | |
| xyang | jgriffith: so I changed to 2.0 | 21:36 |
| jgriffith | xyang: what i mean is your description says "that value is too low" | 21:36 |
| xyang | jgrffith: now everyone else told me 2 is too low | 21:36 |
| jgriffith | xyang: OHHH | 21:36 |
| jgriffith | this is feedback/bike-shedding change, not a technical change | 21:37 |
| jgriffith | fair enough | 21:37 |
| xyang | jgriffith: so xtremio driver tried to use a different default value of 20. pure also starts the default as 20 | 21:37 |
| jgriffith | xyang: I was under the impression that you meant 2 was too small and the driver would reject it | 21:37 |
| xyang | jgriffith: that's why I thought may be 2 doesn't make sense in the real world | 21:37 |
| jgriffith | xyang: that's what I thought was weird and why I mentioned I thought even 1 should work | 21:38 |
| *** timcl1 has joined #openstack-cinder | 21:38 | |
| jgriffith | xyang: not that I think 1 should be the default (that's NO overprov) | 21:38 |
| xyang | jgriffith: it should work. it is just that no one likes 2.0 as the default | 21:38 |
| jgriffith | xyang: I don't agree with people about 20 but I don't care either :) | 21:38 |
| jgriffith | xyang: it's a completely arbitrary "thing" if you ask me | 21:38 |
| xyang | jgriffith: you can change it in cinder.conf any way | 21:38 |
| jgriffith | xyang: yeah.. I follow ya now | 21:38 |
| jgriffith | xyang: right :) | 21:39 |
| jgriffith | xyang: thus my "bike-shedding" comment :) | 21:39 |
| xyang | jgriffith: it turns out you can use CONF.override to set the value, not it can't change the default | 21:39 |
| *** timcl has quit IRC | 21:39 | |
| patrickeast | fwiw the 20 for us isn’t a default per-say, it is only set to that when we would otherwise calculate it to NaN or infinite | 21:39 |
| patrickeast | it is only set when the array is otherwise empty | 21:39 |
| jgriffith | OHHHH... it's patrickeast 's fault!!!! | 21:40 |
| * patrickeast hides | 21:40 | |
| jgriffith | I should have known!! Dang you!!! | 21:40 |
| xyang | jgriffith: right:) | 21:40 |
| jgriffith | :) | 21:40 |
| mtanino | jgriffith: quick question. After refactoring SCSI target, anyone doesn't use "iscsi_num_targets" config option now. | 21:40 |
| openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Adds pool aware scheduling for HNAS drivers https://review.openstack.org/142133 | 21:41 |
| openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Adds SSH communication to HNAS drivers https://review.openstack.org/142904 | 21:41 |
| mtanino | jgriffith: should we deprecate this option or should we add some logic to use this? | 21:41 |
| jgriffith | mtanino: if it wasn't put back in IET I don't know of anyplace it's being used | 21:41 |
| jgriffith | mtanino: but lemme look | 21:41 |
| *** SamYaple is now known as I-Am-Sam | 21:41 | |
| rhagarty | xyang, question regarding your review of my patchset - https://review.openstack.org/#/c/157964 | 21:41 |
| mtanino | jgriffith: my proposed IET doesn't use the config | 21:41 |
| *** I-Am-Sam is now known as SamYaple | 21:42 | |
| mtanino | parameter | 21:42 |
| jgriffith | mtanino: should be cool then | 21:42 |
| xyang | rhagarty: sure. | 21:42 |
| jgriffith | mtanino: honestly I barely even remember why/when we added that | 21:42 |
| rhagarty | you suggest I get rid of continuation line '\' by using '()' instead. so just to be sure I'm doing it right, here are the lines in question - | 21:42 |
| rhagarty | mock_client.getWsApiVersion.return_value = \ | 21:42 |
| rhagarty | wsapi_version | 21:42 |
| rhagarty | I should instead do this? | 21:42 |
| rhagarty | mock_client.getWsApiVersion.return_value = ( | 21:42 |
| rhagarty | wsapi_version) | 21:42 |
| xyang | yes | 21:42 |
| mtanino | jgriffith: me too. | 21:43 |
| rhagarty | ok - just wanted to verify. Thanks | 21:43 |
| xyang | np | 21:43 |
| jgriffith | mtanino: actually looks like cxt is using it | 21:43 |
| *** lcurtis has quit IRC | 21:44 | |
| mtanino | jgriffith: That method does not use anywhere. just copied from tgt | 21:44 |
| jgriffith | mtanino: ohh.. that's just lovely! | 21:45 |
| jgriffith | LOL | 21:45 |
| jgriffith | dead method | 21:45 |
| mtanino | jgriffith: yes!!! | 21:45 |
| mtanino | dead. | 21:45 |
| jgriffith | mtanino: yeah, let's deprecate it and remove that dead code from teh cxt code | 21:45 |
| *** takedakn has quit IRC | 21:45 | |
| mtanino | jgriffith: I got it. | 21:45 |
| jgriffith | mtanino: awesome, thanks! | 21:45 |
| *** enterprisedc has quit IRC | 21:45 | |
| mtanino | will propose a patch. | 21:45 |
| jgriffith | mtanino: you want to do both or you want me to take one of them? | 21:46 |
| mtanino | jgriffith: np. I'll take both of them. | 21:46 |
| jgriffith | mtanino: okie dokie | 21:46 |
| jgriffith | mtanino: thanks | 21:46 |
| *** Miouge has quit IRC | 21:46 | |
| *** enterprisedc has joined #openstack-cinder | 21:47 | |
| tsekiyama | jgriffith: hemna: xyang: I've unified the data structure for alternative iSCSI targets with multipath. Could you check it if you have a chance? https://review.openstack.org/#/c/140877/ The functional code is now just 2 lines in iscsi.py/driver.py ... | 21:47 |
| jgriffith | tsekiyama: nice! | 21:47 |
| jgriffith | tsekiyama: I'm confused though | 21:49 |
| jgriffith | tsekiyama: you still have to different DS's (line 1323 of driver.py) | 21:49 |
| jgriffith | tsekiyama: s/to/two/ | 21:49 |
| *** tries__ has quit IRC | 21:50 | |
| jgriffith | tsekiyama: I thought we talked about something like "additional-xxx": [] | 21:50 |
| jgriffith | tsekiyama: maybe I'm on the wrong page | 21:50 |
| *** markvoelker has quit IRC | 21:51 | |
| jgriffith | tsekiyama: you're commit message is kind of along those lines | 21:51 |
| *** markvoelker has joined #openstack-cinder | 21:51 | |
| jgriffith | tsekiyama: but the comment in the code doesn't match | 21:51 |
| openstackgerrit | Richard Hagarty proposed openstack/cinder: Add flash cache policy to 3PAR driver https://review.openstack.org/157964 | 21:52 |
| tsekiyama | jgriffith: ah, based on last IRC discussion, "target_portals" can be used to both multiatth and failover | 21:52 |
| erlon | e0ne: smcginnis: done, can you review when you have a chance? | 21:52 |
| patrickeast | oh nice, i like it a lot more now that it matches the multipath changes… i was playing around with that patch and having a big if/else to fill in the same stuff was kind of weird | 21:52 |
| jgriffith | tsekiyama: sure... | 21:52 |
| tsekiyama | jgriffith: but for old nova, it should return both single and multiple keys | 21:53 |
| smcginnis | erlon: I have it up right now. :) | 21:53 |
| jgriffith | tsekiyama: what I am getting at is in your commit message | 21:53 |
| e0ne | erlon: i'll try do it today after CI passed | 21:53 |
| jgriffith | tsekiyama: you ahve connection_info:{data:'target_portal'...., 'target_portals":[].... | 21:53 |
| erlon | smcginnis: thanks! :) | 21:53 |
| jgriffith | which is cool by me | 21:53 |
| jgriffith | but in the comment section of driver.py there's two different data structures called out? | 21:54 |
| erlon | e0ne: ok | 21:54 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Allow archiving deleted rows to shadow tables, for performance https://review.openstack.org/131182 | 21:54 |
| *** e0ne has quit IRC | 21:54 | |
| tsekiyama | jgriffith: when multipath=True is specified, it means that nova / brick is new and can understand 'target_portals' | 21:54 |
| tsekiyama | jgriffith: so we can omit 'target_portal' | 21:55 |
| jgriffith | tsekiyama: so check out my comment in the patch | 21:56 |
| jgriffith | see if that makes any sense at all | 21:56 |
| tsekiyama | jgriffith: but multipath=False, we should contain both of them for old and new | 21:56 |
| *** markvoelker has quit IRC | 21:56 | |
| erlon | smcginnis: I have a patch with 3 -1 and one 2+, what happens? | 21:56 |
| jgriffith | tsekiyama: I'm proposing we just always contain both | 21:56 |
| jgriffith | tsekiyama: so we work no matter what version/capability nova or cinder backend has | 21:56 |
| erlon | smcginnis: I read somewhere that a patch can not have any -1 | 21:56 |
| *** markvoelker has joined #openstack-cinder | 21:57 | |
| jgriffith | tsekiyama: and use the secondary/list entries to denote mutlipath or multi-attach etc | 21:57 |
| jgriffith | tsekiyama: don't know if that actually makes any sense or not | 21:57 |
| tsekiyama | jgriffith: Ah, ok | 21:57 |
| openstackgerrit | Thang Pham proposed openstack/cinder: VMware: Add vmware:adapter_type extra spec https://review.openstack.org/159260 | 21:57 |
| jgriffith | tsekiyama: but it solves the ugliness I hated in the nova patch of "if this DS, else that" | 21:57 |
| jgriffith | tsekiyama: I'm of course assuming others think that's a good idea and works | 21:58 |
| *** karimb has joined #openstack-cinder | 21:58 | |
| guitarzan | erlon: -1 patches can get merged | 21:58 |
| smcginnis | erlon: You can have a -1 on a patch. It's just less likely that you'll get two +2's. :) | 21:58 |
| guitarzan | I don't know how often it happens | 21:58 |
| * jgriffith merges his -1 patches all the time ;) | 21:58 | |
| guitarzan | haha! | 21:59 |
| tsekiyama | jgriffith: I believe it works if both keys always contained. | 21:59 |
| erlon | https://review.openstack.org/#/c/141868/ | 21:59 |
| jgriffith | tsekiyama: so I think that is "cleaner" | 21:59 |
| jgriffith | tsekiyama: but I'm curious if you agree or not? | 21:59 |
| erlon | hummm | 21:59 |
| guitarzan | erlon: I think that -2 is not actually there | 21:59 |
| guitarzan | er, +2 | 21:59 |
| guitarzan | oh, maybe it is | 22:00 |
| guitarzan | I see the checkmark now | 22:00 |
| tsekiyama | jgriffith: I just tried to not affecting drivers already implementing the new 'target_portals' etc. | 22:00 |
| smcginnis | erlon: Interesting. Not sure why those -1's didn't get cleared on new patchsets... | 22:00 |
| erlon | smcginnis: I havent seen taobai, for weeks and winston-d_zZZ and avishay keeps ignoring me :) | 22:01 |
| jgriffith | tsekiyama: right, and that's awesome! | 22:01 |
| smcginnis | erlon: Just looking now, but were their concerns addressed? Or not actually valid? | 22:01 |
| jgriffith | tsekiyama: we can do a if key exists until things catch up too | 22:01 |
| guitarzan | erlon: they're just asking you to write unit tests, right? | 22:01 |
| jgriffith | but once we go that route maybe my idea just doesn't matter | 22:02 |
| *** Yogi11 has quit IRC | 22:02 | |
| *** takedakn has joined #openstack-cinder | 22:02 | |
| erlon | guitarzan: smcginnis: yes, they concern was about unit tests, I implemented then in another patch, which where merged already, BTW | 22:02 |
| guitarzan | erlon: how does your other unit test pass for code that isn't merged? | 22:03 |
| smcginnis | erlon: Can you put in a comment with a link to the patch that added the unit tests? | 22:03 |
| erlon | https://review.openstack.org/#/c/146930/ | 22:03 |
| guitarzan | erlon: ah, there were no tests at all for that driver | 22:04 |
| erlon | guitarzan: actually the code passsed with out unit tests | 22:04 |
| *** rushil has quit IRC | 22:04 | |
| erlon | guitarzan: just this class | 22:04 |
| smcginnis | erlon: Can you put that in this review so others can see there are now tests. :) | 22:04 |
| tsekiyama | jgriffith: ok i'll revise the patch so it always returns both 'target_portal' and 'target_portals'. | 22:04 |
| guitarzan | erlon: so it seems like you should be able to rebase and add a unit test for the code you changed | 22:04 |
| erlon | smcginnis: is there already | 22:04 |
| jgriffith | tsekiyama: let's get other input | 22:04 |
| smcginnis | erlon: Emmm... I would use "the code passes without unit tests" as an argument. | 22:04 |
| guitarzan | smcginnis: haha, good luck :) | 22:05 |
| jgriffith | tsekiyama: maybe I'm wrong on this | 22:05 |
| guitarzan | I do like that line though | 22:05 |
| smcginnis | :) | 22:05 |
| *** e0ne has joined #openstack-cinder | 22:05 | |
| smcginnis | erlon: I'm looking through the comments right now. I don't see that link there. | 22:05 |
| *** rwsu has quit IRC | 22:06 | |
| smcginnis | erlon: Oh, nm. I see it now. | 22:06 |
| erlon | smcginnis: guitarzan the new code I added was just small changes, covered by the added tests, so no need to new tests in the changes | 22:06 |
| guitarzan | erlon: that's not possible right? | 22:06 |
| guitarzan | your tests *can't* cover the small change you added | 22:07 |
| guitarzan | since that small change isn't merged yet | 22:07 |
| * erlon thinking | 22:07 | |
| smcginnis | erlon, guitarzan: I think I see what you mean. | 22:07 |
| smcginnis | erlon: There are tests for these specific method calls. | 22:08 |
| erlon | guitarzan: is a parser error, so yes | 22:08 |
| smcginnis | erlon: I don't see tests that would specifically cause it to follow the code path to exercise your changes. | 22:08 |
| guitarzan | right, what smcginnis said :) | 22:08 |
| guitarzan | you introduced an if check | 22:09 |
| smcginnis | erlon: But that said, I don't think we can say that every code path in the rest of the code base has coverage either. | 22:09 |
| guitarzan | add a test that follows the new path | 22:09 |
| guitarzan | smcginnis: true | 22:09 |
| smcginnis | guitarzan: But no reason to not try to get more coverage, right? | 22:09 |
| guitarzan | certainly not | 22:09 |
| guitarzan | especially if it's easy | 22:09 |
| guitarzan | then winston and avishay would have no reason at all for a -1 | 22:09 |
| *** takedakn has quit IRC | 22:11 | |
| erlon | guitarzan: smcginnis: not all path of code are covered anyway(is that feasible? I have jgriffith discussing about unit tests coverage somewhere), but Ill add that tests to this path too | 22:11 |
| *** akerr_ has quit IRC | 22:12 | |
| guitarzan | erlon: I don't think anyone is saying that | 22:12 |
| guitarzan | erlon: I'm saying that if you want to address winston and avishay's -1, you could add a test that exercises the path you added | 22:12 |
| guitarzan | obviously thingee thinks it's ok now | 22:12 |
| *** needscoffee is now known as needsmostcoffee | 22:12 | |
| smcginnis | erlon: I think if you can just add at least one more test that would cover the single_evs = True and single_EVS = False then coverage would be pretty good IMO. | 22:12 |
| jgriffith | erlon: what did I do? | 22:13 |
| smcginnis | jgriffith: It's all your fault. | 22:13 |
| smcginnis | :) | 22:13 |
| erlon | guitarzan: hmmm, I tried to reach wiston to get feedback | 22:13 |
| *** needsmostcoffee is now known as morganfainberg | 22:13 | |
| erlon | jgriffith: :) | 22:13 |
| smcginnis | jgriffith: Nothing to worry about. Just the recurring unit test coverage discussion. | 22:13 |
| jgriffith | smcginnis: ahh | 22:14 |
| erlon | jgriffith: once you opened a bug to discuss a acceptable coverage of unit tests | 22:14 |
| smcginnis | jgriffith: Or the "unit testing is crap" discussion. Take your pick. ;) | 22:14 |
| jgriffith | erlon: oh, I think that was Winston | 22:14 |
| jgriffith | the "crap" one was mine :) | 22:14 |
| smcginnis | hah | 22:15 |
| *** jungleboyj_ has joined #openstack-cinder | 22:16 | |
| erlon | jgriffith: https://bugs.launchpad.net/cinder/+bug/1404339 | 22:16 |
| openstack | Launchpad bug 1404339 in Cinder "Unit tests for zfssa driver don't actually check anything" [Undecided,In progress] - Assigned to abhiram moturi (abhiram-moturi) | 22:16 |
| erlon | jgriffith: see, your faultt :) | 22:16 |
| *** timcl1 has left #openstack-cinder | 22:19 | |
| *** takedakn has joined #openstack-cinder | 22:19 | |
| *** Mandell has quit IRC | 22:20 | |
| *** erlon is now known as erlon_away | 22:21 | |
| *** ebalduf has joined #openstack-cinder | 22:21 | |
| *** vilobhmm has quit IRC | 22:22 | |
| *** ebalduf has quit IRC | 22:25 | |
| jungleboyj_ | mtanino: Patch looks good. Thanks. xyang Can you take a look as well? | 22:27 |
| jungleboyj_ | +A if you have no concerns. | 22:28 |
| *** ronis has quit IRC | 22:28 | |
| mtanino | jungleboyj_: thank you for the review. | 22:28 |
| jungleboyj_ | mtanino: Thank you for working up a patch for that! | 22:28 |
| mtanino | jungleboyj_: do we need backpot it for juno-stable? | 22:29 |
| mtanino | cherrypickup? | 22:29 |
| *** rwsu has joined #openstack-cinder | 22:30 | |
| jungleboyj_ | mtanino: That is a good idea. You know how to do that? | 22:30 |
| mtanino | jungleboyj_: I haven't do it. are there good wiki page for it? | 22:30 |
| xyang | jungleboyj_: in a meeting now. which one is this? I'll take a look later | 22:30 |
| smcginnis | jungleboyj_: Isn't Juno security only now? | 22:31 |
| mtanino | smcginnis: oh really? | 22:31 |
| smcginnis | mtanino: I thought so. | 22:31 |
| jungleboyj_ | smcginnis: No, I said that earlier, but that was a mistake. | 22:32 |
| smcginnis | mtanino: I think we had a bug in one of our drivers that we wanted to backport but it was rejected because it wasn't a security issue. | 22:32 |
| *** vilobhmm has joined #openstack-cinder | 22:32 | |
| *** vilobhmm has quit IRC | 22:32 | |
| jungleboyj_ | We shouldn't be shoving everything back, but this would be good. | 22:32 |
| smcginnis | jungleboyj_: I heard it from someone else I thought. | 22:32 |
| jungleboyj_ | smcginnis: Yeah, that was my bad. I corrected that. | 22:32 |
| *** vilobhmm has joined #openstack-cinder | 22:33 | |
| jungleboyj_ | mtanino: Basically all you need to do is a 'git cherrypick -X <commit hash> into stable/juno' | 22:33 |
| smcginnis | jungleboyj_: Oh, I see your last comment now. | 22:34 |
| jungleboyj_ | xyang: That is the change to deal with the migration_status if migration fails. | 22:34 |
| mtanino | jungleboyj_: I see. let me try after the patch will be merged. | 22:34 |
| jungleboyj_ | xyang: Avishay and I have +2 on it, want someone more detached from the issue to look as well. | 22:34 |
| smcginnis | thingee: You're not online now, but if you see this can you take a look at https://review.openstack.org/#/c/154123/ | 22:34 |
| jungleboyj_ | mtanino: +2 I can help you through it if there are issues. | 22:34 |
| xyang | jungleboyj_: a link will help:) | 22:35 |
| mtanino | xyang: sure. https://review.openstack.org/#/c/154739/6 | 22:35 |
| *** takedakn has quit IRC | 22:36 | |
| *** takedakn has joined #openstack-cinder | 22:36 | |
| xyang | mtanino: ok, thanks. | 22:36 |
| jungleboyj_ | xyang: Sorry, thought I sent that. :-p | 22:38 |
| jgriffith | mtanino: http://goo.gl/trZv2P | 22:38 |
| *** Guest78621 has quit IRC | 22:39 | |
| jgriffith | mtanino: there maybe be an updated version of that around somewhere but that's what I use | 22:39 |
| *** thangp has quit IRC | 22:40 | |
| mtanino | jgriffith: oh, nice! script for making a backport patch | 22:40 |
| mtanino | bookmark, | 22:40 |
| *** takedakn has quit IRC | 22:43 | |
| *** Mandell has joined #openstack-cinder | 22:44 | |
| *** ganso_ has quit IRC | 22:47 | |
| *** annashen has quit IRC | 22:54 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Add volume multi attach support https://review.openstack.org/85847 | 23:02 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Add multiattach capabilities injection https://review.openstack.org/159650 | 23:02 |
| openstackgerrit | Jay Bryant proposed openstack/cinder: Use oslo.middleware https://review.openstack.org/134759 | 23:02 |
| *** cnesa has joined #openstack-cinder | 23:02 | |
| *** Apoorva_ has joined #openstack-cinder | 23:03 | |
| *** primechuck has quit IRC | 23:03 | |
| *** vilobhmm has quit IRC | 23:04 | |
| *** vilobhmm has joined #openstack-cinder | 23:05 | |
| *** vilobhmm has quit IRC | 23:05 | |
| *** vilobhmm has joined #openstack-cinder | 23:06 | |
| *** Apoorva has quit IRC | 23:07 | |
| *** primechuck has joined #openstack-cinder | 23:09 | |
| *** takedakn has joined #openstack-cinder | 23:10 | |
| *** jdurgin has quit IRC | 23:11 | |
| *** kaufer has quit IRC | 23:20 | |
| *** diemt has quit IRC | 23:21 | |
| *** ebalduf has joined #openstack-cinder | 23:21 | |
| *** Ilja has quit IRC | 23:24 | |
| *** jdurgin has joined #openstack-cinder | 23:25 | |
| *** ebalduf has quit IRC | 23:26 | |
| jungleboyj_ | smcginnis: You still around? | 23:30 |
| *** mriedem has quit IRC | 23:36 | |
| *** jungleboyj_ has quit IRC | 23:47 | |
| *** EmilienM is now known as EmilienM|afk | 23:49 | |
| *** Mandell has quit IRC | 23:53 | |
| *** jungleboyj_ has joined #openstack-cinder | 23:53 | |
| *** chlong has joined #openstack-cinder | 23:53 | |
| *** asmith_brcd has quit IRC | 23:55 | |
| *** jdurgin has quit IRC | 23:55 | |
| *** jdurgin has joined #openstack-cinder | 23:55 | |
| *** IanGovett has joined #openstack-cinder | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!