*** theanalyst has joined #openstack-cinder | 00:00 | |
*** tbarron has quit IRC | 00:02 | |
*** tsekiyam_ has joined #openstack-cinder | 00:08 | |
*** tsekiyama has quit IRC | 00:11 | |
*** mtanino has quit IRC | 00:12 | |
*** tsekiyam_ has quit IRC | 00:12 | |
*** tbarron has joined #openstack-cinder | 00:16 | |
*** tbarron has quit IRC | 00:16 | |
*** rushiagr_away has joined #openstack-cinder | 00:16 | |
*** tbarron has joined #openstack-cinder | 00:17 | |
*** annashen has quit IRC | 00:27 | |
*** Apoorva has quit IRC | 00:28 | |
*** ho has joined #openstack-cinder | 00:28 | |
openstackgerrit | Anish Bhatt proposed openstack/cinder: Improve error handling in refactored Tgt driver https://review.openstack.org/154713 | 00:29 |
---|---|---|
anish | hemnafk: done ^ | 00:29 |
*** [1]Thelo has joined #openstack-cinder | 00:30 | |
*** Thelo has quit IRC | 00:33 | |
*** [1]Thelo is now known as Thelo | 00:33 | |
openstackgerrit | John Griffith proposed openstack/python-cinderclient: Move unit tests into test directory https://review.openstack.org/162230 | 00:35 |
*** dannywil_ has quit IRC | 00:37 | |
*** _cjones_ has quit IRC | 00:46 | |
*** r-daneel has quit IRC | 00:49 | |
*** Mandell has quit IRC | 00:52 | |
*** leeantho_ has quit IRC | 00:56 | |
*** Lee1092 has joined #openstack-cinder | 01:00 | |
*** Mandell has joined #openstack-cinder | 01:01 | |
*** Mandell has quit IRC | 01:17 | |
*** asselin_ has joined #openstack-cinder | 01:19 | |
*** asselin_ has quit IRC | 01:19 | |
*** vilobhmm1 has quit IRC | 01:20 | |
*** Mandell has joined #openstack-cinder | 01:22 | |
*** akerr has joined #openstack-cinder | 01:23 | |
*** bkopilov has joined #openstack-cinder | 01:24 | |
*** annashen has joined #openstack-cinder | 01:27 | |
*** annashen has quit IRC | 01:32 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Delete the temporary volume if migration fails https://review.openstack.org/160682 | 01:34 |
*** scottda_ has joined #openstack-cinder | 01:36 | |
*** scottda_ has quit IRC | 01:43 | |
*** Mandell has quit IRC | 01:47 | |
*** rwsu has quit IRC | 01:47 | |
openstackgerrit | wanghao proposed openstack/cinder: Fix response when query host detail by host name https://review.openstack.org/162601 | 01:50 |
*** _cjones_ has joined #openstack-cinder | 01:56 | |
*** esker has joined #openstack-cinder | 02:00 | |
*** esker has quit IRC | 02:00 | |
*** esker has joined #openstack-cinder | 02:01 | |
*** diegows has quit IRC | 02:02 | |
*** yamada-h has joined #openstack-cinder | 02:02 | |
*** mriedem has quit IRC | 02:03 | |
*** Guest82873 has joined #openstack-cinder | 02:10 | |
*** tellesnobrega_ has joined #openstack-cinder | 02:14 | |
*** jungleboyj has joined #openstack-cinder | 02:14 | |
*** tellesnobrega_ has quit IRC | 02:14 | |
openstackgerrit | Peter Wang proposed openstack/cinder: Fixes VNX NotImplementedError of unmanage https://review.openstack.org/162532 | 02:15 |
*** kaisers1 has joined #openstack-cinder | 02:18 | |
*** kaisers has quit IRC | 02:20 | |
*** anki80 has quit IRC | 02:24 | |
*** coolsvap has joined #openstack-cinder | 02:33 | |
*** patrickeast has quit IRC | 02:35 | |
*** scottda_ has joined #openstack-cinder | 02:35 | |
openstackgerrit | Sam Morrison proposed openstack/cinder: Set attach_status to detached when resetting status to available https://review.openstack.org/162845 | 02:38 |
*** scottda_ has quit IRC | 02:39 | |
*** Anticimex has quit IRC | 02:43 | |
*** coolsvap has quit IRC | 02:45 | |
*** coolsvap has joined #openstack-cinder | 02:46 | |
*** coolsvap has quit IRC | 02:46 | |
*** coolsvap has joined #openstack-cinder | 02:46 | |
*** markvoelker has joined #openstack-cinder | 02:51 | |
*** ho has quit IRC | 02:55 | |
*** ho has joined #openstack-cinder | 02:55 | |
*** _cjones_ has quit IRC | 03:00 | |
*** _cjones_ has joined #openstack-cinder | 03:00 | |
*** akerr has quit IRC | 03:03 | |
*** akerr has joined #openstack-cinder | 03:10 | |
*** akerr has quit IRC | 03:11 | |
*** yamada-h has quit IRC | 03:18 | |
*** haomaiwang has joined #openstack-cinder | 03:19 | |
*** bkopilov has quit IRC | 03:30 | |
*** esker has quit IRC | 03:33 | |
*** theanalyst has quit IRC | 03:48 | |
*** rushiagr_away has quit IRC | 03:49 | |
*** jcru has joined #openstack-cinder | 03:52 | |
*** markvoelker has quit IRC | 03:53 | |
*** markvoelker has joined #openstack-cinder | 03:53 | |
*** jcru has quit IRC | 03:54 | |
openstackgerrit | wanghao proposed openstack/cinder: Implement function of import/export snapshots https://review.openstack.org/144590 | 03:57 |
*** markvoelker has quit IRC | 03:57 | |
*** Longgeek has joined #openstack-cinder | 03:59 | |
*** Ilja has quit IRC | 03:59 | |
*** vilobhmm has joined #openstack-cinder | 04:00 | |
*** yamada-h has joined #openstack-cinder | 04:04 | |
openstackgerrit | rajiv proposed openstack/python-cinderclient: cinderclient accepts arguments after metadata without -- separator https://review.openstack.org/156499 | 04:15 |
*** theanalyst has joined #openstack-cinder | 04:20 | |
*** rushiagr_away has joined #openstack-cinder | 04:22 | |
*** markvoelker has joined #openstack-cinder | 04:24 | |
*** pradipta has joined #openstack-cinder | 04:26 | |
*** pradip_vedams has quit IRC | 04:31 | |
*** BharatK has joined #openstack-cinder | 04:33 | |
*** pradip_vedams has joined #openstack-cinder | 04:34 | |
*** Mandell has joined #openstack-cinder | 04:37 | |
openstackgerrit | Mike Perez proposed openstack/cinder: Update Datera's export to avoid deprecated keys https://review.openstack.org/162774 | 04:39 |
*** markvoelker has quit IRC | 04:41 | |
*** alexpilotti has joined #openstack-cinder | 04:48 | |
*** pradipta has quit IRC | 04:49 | |
*** lpetrut has joined #openstack-cinder | 05:00 | |
*** Ilja has joined #openstack-cinder | 05:05 | |
*** pradipta has joined #openstack-cinder | 05:06 | |
*** topshare has joined #openstack-cinder | 05:12 | |
*** bkopilov has joined #openstack-cinder | 05:16 | |
*** _cjones_ has quit IRC | 05:29 | |
openstackgerrit | yogeshprasad proposed openstack/cinder: Added provider_id to volume and snapshot object https://review.openstack.org/162611 | 05:29 |
*** yamada-h has quit IRC | 05:34 | |
*** Tross1 has joined #openstack-cinder | 05:35 | |
*** Tross has quit IRC | 05:36 | |
*** markvoelker has joined #openstack-cinder | 05:38 | |
openstackgerrit | Sam Morrison proposed openstack/cinder: Set attach_status to detached when resetting status to available https://review.openstack.org/162845 | 05:44 |
*** Mandell has quit IRC | 05:53 | |
*** Mandell has joined #openstack-cinder | 05:55 | |
*** yamada-h has joined #openstack-cinder | 05:56 | |
*** ho__ has joined #openstack-cinder | 05:56 | |
*** harlowja_ is now known as harlowja_away | 05:57 | |
*** lpetrut has quit IRC | 05:57 | |
*** ho has quit IRC | 05:58 | |
*** Longgeek has quit IRC | 06:04 | |
*** BharatK has quit IRC | 06:06 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex https://review.openstack.org/152401 | 06:09 |
*** yamada-h has quit IRC | 06:20 | |
*** BharatK has joined #openstack-cinder | 06:20 | |
*** vilobhmm1 has joined #openstack-cinder | 06:22 | |
*** yamada-h has joined #openstack-cinder | 06:22 | |
*** Longgeek has joined #openstack-cinder | 06:23 | |
*** vilobhmm has quit IRC | 06:23 | |
*** david-lyle has quit IRC | 06:30 | |
*** _cjones_ has joined #openstack-cinder | 06:31 | |
*** rushiagr_away is now known as rushiagr | 06:37 | |
*** david-lyle has joined #openstack-cinder | 06:39 | |
*** ankit_ag has joined #openstack-cinder | 06:45 | |
*** coolsvap is now known as coolsvap|afk | 06:47 | |
*** rj_ has joined #openstack-cinder | 06:50 | |
*** sgotliv has quit IRC | 06:53 | |
*** vilobhmm1 has quit IRC | 06:53 | |
*** vilobhmm has joined #openstack-cinder | 06:54 | |
*** anshul has joined #openstack-cinder | 06:54 | |
*** coolsvap|afk is now known as coolsvap | 06:58 | |
*** _cjones_ has quit IRC | 07:02 | |
*** _cjones_ has joined #openstack-cinder | 07:03 | |
*** _cjones_ has quit IRC | 07:03 | |
*** Ilja has quit IRC | 07:05 | |
*** bkopilov has quit IRC | 07:07 | |
*** david-lyle is now known as david-lyle_afk | 07:11 | |
*** chlong has quit IRC | 07:21 | |
*** bkopilov has joined #openstack-cinder | 07:22 | |
*** nshaikh has joined #openstack-cinder | 07:26 | |
*** Ilja has joined #openstack-cinder | 07:31 | |
*** jistr has joined #openstack-cinder | 07:31 | |
*** openstackgerrit has quit IRC | 07:35 | |
*** TobiasE has joined #openstack-cinder | 07:35 | |
*** openstackgerrit has joined #openstack-cinder | 07:36 | |
*** BharatK has quit IRC | 07:39 | |
*** ronis has joined #openstack-cinder | 07:45 | |
*** lpetrut has joined #openstack-cinder | 07:47 | |
*** BharatK has joined #openstack-cinder | 07:52 | |
*** coolsvap is now known as coolsvap|afk | 07:53 | |
*** rj_ has quit IRC | 07:57 | |
*** alecv has joined #openstack-cinder | 07:58 | |
*** coolsvap|afk is now known as coolsvap | 08:00 | |
*** markus_z has joined #openstack-cinder | 08:03 | |
openstackgerrit | wanghao proposed openstack/cinder: Implement function of import/export snapshots https://review.openstack.org/144590 | 08:13 |
*** liusheng has joined #openstack-cinder | 08:14 | |
*** sgotliv has joined #openstack-cinder | 08:15 | |
*** Anticimex has joined #openstack-cinder | 08:20 | |
*** sgotliv has quit IRC | 08:20 | |
*** ronis has quit IRC | 08:24 | |
*** [1]Thelo has joined #openstack-cinder | 08:25 | |
*** ho__ has quit IRC | 08:27 | |
*** Mandell has quit IRC | 08:27 | |
*** Thelo has quit IRC | 08:27 | |
*** [1]Thelo is now known as Thelo | 08:27 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/os-brick: Adjust os-brick to support FCP on System z systems https://review.openstack.org/162678 | 08:28 |
*** dulek has joined #openstack-cinder | 08:30 | |
*** haomaiwang has quit IRC | 08:32 | |
*** sgotliv has joined #openstack-cinder | 08:33 | |
openstackgerrit | Grzegorz Grasza (xek) proposed openstack/cinder: Service object https://review.openstack.org/160417 | 08:33 |
*** haomaiwang has joined #openstack-cinder | 08:37 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/os-brick: Adjust os-brick to support FCP on System z systems https://review.openstack.org/162678 | 08:46 |
*** topshare_ has joined #openstack-cinder | 08:51 | |
*** topshare_ has quit IRC | 08:51 | |
*** alexpilotti_ has joined #openstack-cinder | 08:52 | |
*** topshare_ has joined #openstack-cinder | 08:52 | |
*** topshare has quit IRC | 08:53 | |
*** alexpilotti has quit IRC | 08:54 | |
*** alexpilotti_ is now known as alexpilotti | 08:54 | |
*** ho has joined #openstack-cinder | 09:01 | |
*** pradipta has quit IRC | 09:06 | |
*** nellysmitt has joined #openstack-cinder | 09:06 | |
*** dulek has quit IRC | 09:09 | |
flip214 | DuncanT: do you have 10 minutes for me, please? | 09:10 |
*** aix has joined #openstack-cinder | 09:19 | |
*** nshaikh has quit IRC | 09:20 | |
*** markvoelker has quit IRC | 09:22 | |
*** yuriy_n17 has joined #openstack-cinder | 09:25 | |
openstackgerrit | YAMADA Hideki proposed openstack/cinder: Add missing backup/restore methods to Sheepdog driver https://review.openstack.org/162927 | 09:27 |
*** david-lyle_afk has quit IRC | 09:30 | |
*** david-lyle_afk has joined #openstack-cinder | 09:30 | |
*** Ilja has quit IRC | 09:32 | |
*** dulek has joined #openstack-cinder | 09:33 | |
*** jistr has quit IRC | 09:34 | |
*** Ilja has joined #openstack-cinder | 09:41 | |
*** jistr has joined #openstack-cinder | 09:46 | |
*** vilobhmm has quit IRC | 09:48 | |
*** Ilja has quit IRC | 09:50 | |
*** afazekas has joined #openstack-cinder | 09:52 | |
*** Ilja has joined #openstack-cinder | 09:57 | |
*** _cjones_ has joined #openstack-cinder | 10:03 | |
*** _cjones_ has quit IRC | 10:04 | |
*** _cjones_ has joined #openstack-cinder | 10:05 | |
*** sgotliv has quit IRC | 10:07 | |
*** p01s0n has joined #openstack-cinder | 10:08 | |
*** yamada-h has quit IRC | 10:08 | |
*** _cjones_ has quit IRC | 10:09 | |
*** ronis has joined #openstack-cinder | 10:11 | |
*** bkopilov has quit IRC | 10:15 | |
*** e0ne has joined #openstack-cinder | 10:15 | |
*** chlong has joined #openstack-cinder | 10:18 | |
*** sgotliv has joined #openstack-cinder | 10:20 | |
*** topshare_ has quit IRC | 10:25 | |
*** topshare has joined #openstack-cinder | 10:26 | |
*** topshare has quit IRC | 10:28 | |
*** aix has quit IRC | 10:32 | |
DuncanT | flip214: Sure | 10:33 |
DuncanT | flip214: Sorry, only just got in from yet more time in the dentist chair | 10:33 |
*** coolsvap is now known as coolsvap|afk | 10:33 | |
flip214 | Hi DuncanT, thank for answering! | 10:33 |
flip214 | I hope it'll be a long-term advantage to you, at least, even if harmful in the short-time scale. | 10:34 |
flip214 | please imagine a cinder controller node (c-sch, c-vol, ...) that uses DRBDmanage, with a few more storage nodes. | 10:34 |
flip214 | now, when cinder asks drbd to allocate storage, this can be done on _any_ of the nodes.... | 10:35 |
*** tshefi has joined #openstack-cinder | 10:35 | |
flip214 | so it's possible that the allocated storage in not on the c-vol host. | 10:35 |
flip214 | so there couldn't be an iscsi export of the data. | 10:35 |
*** annashen has joined #openstack-cinder | 10:36 | |
DuncanT | ok... | 10:36 |
*** pradip_vedams has quit IRC | 10:36 | |
flip214 | 1) force allocation on the c-vol host, or at least make a drbd-client available there to export via iscsi? | 10:36 |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Fix Cinder logs to show authentication error in RBD driver https://review.openstack.org/162947 | 10:36 |
flip214 | 2) put c-vol (or whatever service is necessary) on _all_ drbd storage hosts? | 10:36 |
flip214 | 3) can c-vol tell cinder to create the iscsi export on "that node over there"? which services would need to be installed then? | 10:37 |
flip214 | 4) any other ideas? | 10:37 |
flip214 | -- that's the short version, I'm happy to answer any questions, of course. | 10:37 |
*** annashen has quit IRC | 10:40 | |
*** nellysmitt has quit IRC | 10:41 | |
*** pradipta has joined #openstack-cinder | 10:48 | |
*** chlong has quit IRC | 10:51 | |
*** ho has quit IRC | 10:52 | |
*** haomaiwang has quit IRC | 10:53 | |
*** markvoelker has joined #openstack-cinder | 10:53 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Allow archiving deleted rows to shadow tables, for performance https://review.openstack.org/131182 | 10:56 |
flip214 | sorry, gotta go... I'll be back in ~1h. | 10:56 |
*** aix has joined #openstack-cinder | 10:57 | |
*** alexpilotti_ has joined #openstack-cinder | 11:08 | |
DuncanT | flip214: c-vol can certainly create an export on a remote host, just ssh over to it and run the iscsi export stuff | 11:09 |
*** e0ne is now known as e0ne_ | 11:09 | |
*** e0ne_ is now known as e0ne | 11:09 | |
*** nellysmitt has joined #openstack-cinder | 11:09 | |
*** Krast has quit IRC | 11:09 | |
*** yamada-h has joined #openstack-cinder | 11:10 | |
*** alexpilotti has quit IRC | 11:10 | |
*** alexpilotti_ is now known as alexpilotti | 11:10 | |
*** Longgeek has quit IRC | 11:14 | |
*** yamada-h has quit IRC | 11:14 | |
eikke | our CI just finished job # 1000 ^_^ | 11:15 |
e0ne | eikke: waiting for 1024 :) | 11:15 |
eikke | haha | 11:15 |
DuncanT | eikke: Time to crack open a beer in celibration? | 11:15 |
eikke | DuncanT: that's planned for later today :) | 11:15 |
eikke | must say, the success rate is higher than I'd have expected, so Cinder proposed patches must be of high quality from the start in general | 11:16 |
eikke | most 'failures' are jobs cancelled because of a new patchset being pushed | 11:16 |
*** diegows has joined #openstack-cinder | 11:20 | |
*** alexpilotti has quit IRC | 11:21 | |
openstackgerrit | Bharat Kumar Kobagana proposed openstack/cinder: GlusterFS: Support over subscription in thin provisioning https://review.openstack.org/162718 | 11:21 |
openstackgerrit | Kallebe Monteiro proposed openstack/cinder: Replace assertEqual(True, *) -> assertTrue(*) https://review.openstack.org/162725 | 11:23 |
*** bkopilov has joined #openstack-cinder | 11:25 | |
*** IanGovett has joined #openstack-cinder | 11:27 | |
*** pradipta has quit IRC | 11:29 | |
openstackgerrit | Lena Novokshonova proposed openstack/cinder: Add notifications about snapshot.update.* https://review.openstack.org/133041 | 11:34 |
*** kallebe has joined #openstack-cinder | 11:35 | |
*** Longgeek has joined #openstack-cinder | 11:36 | |
openstackgerrit | Lena Novokshonova proposed openstack/cinder: Add notifications about snapshot.update.* https://review.openstack.org/133041 | 11:37 |
openstackgerrit | Lena Novokshonova proposed openstack/cinder: Add notifications about snapshot.update.* https://review.openstack.org/133041 | 11:40 |
flip214 | DuncanT: thank you... | 11:42 |
flip214 | do I understand correctly that it already does that? | 11:42 |
flip214 | so, from which function would I need to return the remote host to use for exporting via iscsi? | 11:43 |
nikesh_vedams | is this approach correct for retype http://paste.openstack.org/show/191256/ | 11:52 |
*** coolsvap|afk is now known as coolsvap | 11:54 | |
*** shyama has joined #openstack-cinder | 11:56 | |
*** TobiasE1 has joined #openstack-cinder | 11:57 | |
*** TobiasE has quit IRC | 11:58 | |
nikesh_vedams | http://paste.openstack.org/show/191258/ | 11:59 |
*** karimb has joined #openstack-cinder | 12:01 | |
e0ne | DuncanT: hi! i'll ask other cores tonight too. could you please take a look on my patch for devtack https://review.openstack.org/#/c/162488/? | 12:03 |
e0ne | i'm not sure how much space we need there | 12:04 |
openstackgerrit | Bharat Kumar Kobagana proposed openstack/cinder: GlusterFS: Support over subscription in thin provisioning https://review.openstack.org/162718 | 12:10 |
*** nlevinki has joined #openstack-cinder | 12:13 | |
*** BharatK has quit IRC | 12:14 | |
*** bswartz has quit IRC | 12:15 | |
*** p01s0n has quit IRC | 12:15 | |
*** sgotliv has quit IRC | 12:16 | |
*** kaisers has joined #openstack-cinder | 12:26 | |
*** kaisers1 has quit IRC | 12:27 | |
*** Mandell has joined #openstack-cinder | 12:28 | |
*** sgotliv has joined #openstack-cinder | 12:29 | |
*** victorfeitosa has joined #openstack-cinder | 12:32 | |
*** Mandell has quit IRC | 12:32 | |
openstackgerrit | wanghao proposed openstack/cinder: Implement function of import/export snapshots https://review.openstack.org/144590 | 12:33 |
*** Ilja has quit IRC | 12:34 | |
DuncanT | nikesh_vedams: No, that is not the right approach | 12:37 |
DuncanT | nikesh_vedams: Your driver needs to looks at the difference between the types, and arrange for any significant parts to be applied | 12:37 |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Fix Cinder logs to show authentication error in RBD driver https://review.openstack.org/162947 | 12:38 |
*** markvoelker has quit IRC | 12:38 | |
*** markvoelker has joined #openstack-cinder | 12:39 | |
*** markvoelker has quit IRC | 12:43 | |
DuncanT | flip214: In the end, initialise_connection needs to return the right info to enable nova to connect | 12:44 |
DuncanT | flip214: Where it gets that from is totally up to your driver | 12:45 |
flip214 | ah, thanks. | 12:45 |
flip214 | I'll take a look at that. | 12:46 |
*** TobiasE1 has quit IRC | 12:47 | |
*** jistr has quit IRC | 12:47 | |
*** jistr has joined #openstack-cinder | 12:48 | |
*** nellysmitt has quit IRC | 12:49 | |
*** TobiasE1 has joined #openstack-cinder | 12:50 | |
*** annegentle has joined #openstack-cinder | 12:51 | |
openstackgerrit | rakesh mishra proposed openstack/cinder: Implement making volume snapshots public https://review.openstack.org/159372 | 12:51 |
*** cdelatte has quit IRC | 12:55 | |
*** cdelatte has joined #openstack-cinder | 12:56 | |
*** xyang1 has joined #openstack-cinder | 12:56 | |
*** geguileo has joined #openstack-cinder | 12:57 | |
*** cdelatte has quit IRC | 13:01 | |
*** cdelatte has joined #openstack-cinder | 13:01 | |
*** bkopilov has quit IRC | 13:04 | |
*** jistr has quit IRC | 13:04 | |
*** emagana has joined #openstack-cinder | 13:05 | |
*** jistr has joined #openstack-cinder | 13:05 | |
*** coolsvap is now known as coolsvap|afk | 13:06 | |
*** nlevinki has quit IRC | 13:08 | |
*** tbarron has quit IRC | 13:08 | |
openstackgerrit | harsh mishra proposed openstack/cinder: Fix for inconsistent cinder-services state change https://review.openstack.org/160104 | 13:09 |
*** Yogi1 has joined #openstack-cinder | 13:12 | |
*** markvoelker has joined #openstack-cinder | 13:13 | |
*** bkopilov has joined #openstack-cinder | 13:18 | |
*** kaufer has joined #openstack-cinder | 13:18 | |
*** rushiagr is now known as rushiagr_away | 13:20 | |
*** nlevinki has joined #openstack-cinder | 13:21 | |
*** dustins has joined #openstack-cinder | 13:22 | |
openstackgerrit | John Griffith proposed openstack/python-cinderclient: Move unit tests into test directory https://review.openstack.org/162230 | 13:23 |
*** changbl has quit IRC | 13:26 | |
*** topshare has joined #openstack-cinder | 13:31 | |
*** tbarron has joined #openstack-cinder | 13:31 | |
*** jungleboyj has quit IRC | 13:33 | |
*** tbarron has quit IRC | 13:33 | |
*** thangp has joined #openstack-cinder | 13:33 | |
*** tbarron has joined #openstack-cinder | 13:33 | |
*** topshare has quit IRC | 13:35 | |
*** anuragpalsule has joined #openstack-cinder | 13:36 | |
*** zhipeng has joined #openstack-cinder | 13:41 | |
*** tbarron has quit IRC | 13:43 | |
*** tbarron has joined #openstack-cinder | 13:44 | |
*** tbarron has quit IRC | 13:44 | |
*** amoturi_ has joined #openstack-cinder | 13:46 | |
*** jcru has joined #openstack-cinder | 13:47 | |
*** mriedem has joined #openstack-cinder | 13:48 | |
*** jcru has quit IRC | 13:48 | |
*** jcru has joined #openstack-cinder | 13:48 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/os-brick: Adjust os-brick to support FCP on System z systems https://review.openstack.org/162678 | 13:48 |
amoturi_ | Hi, Could someone take a look at review https://review.openstack.org/#/c/152676/ . Has been in waiting for a while now. thanks | 13:49 |
*** annegentle has quit IRC | 13:51 | |
*** mriedem has quit IRC | 13:52 | |
*** mtanino has joined #openstack-cinder | 13:54 | |
*** mriedem has joined #openstack-cinder | 13:56 | |
*** lcurtis has joined #openstack-cinder | 13:57 | |
jgriffith | xyang1: DuncanT thougths: https://review.openstack.org/#/c/162532/4//COMMIT_MSG | 13:57 |
jgriffith | xyang1: DuncanT did something change, or did I miss something? | 13:57 |
jgriffith | seems like an awful paradigm to me | 13:57 |
xyang1 | jgriffith: I'll take a look, not sure what this is | 13:57 |
jgriffith | xyang1: heeh... so | 13:57 |
*** r-daneel has joined #openstack-cinder | 13:58 | |
*** bswartz has joined #openstack-cinder | 13:58 | |
jgriffith | xyang1: the commit message and bug states: "when deleting an imported volume, cinder calls unmanage" | 13:58 |
jgriffith | xyang1: if we're doing that it's "wrong" IMO | 13:58 |
jgriffith | xyang1: it should in fact delete the volume, not unmanage. If a user wants to unmanage then call unmanage | 13:58 |
xyang1 | jgriffith: Seems like it should be the other way around | 13:58 |
jgriffith | xyang1: yeah, that's what I thought too. | 13:59 |
jgriffith | xyang1: so the patch itself is fine as it really has nothing to do with that | 13:59 |
xyang1 | jgriffith: Could be just wrong description | 13:59 |
jgriffith | xyang1: but I flagged it for the commit message, and also becasue if we're doing what is described there it's wrong | 13:59 |
*** thingee has joined #openstack-cinder | 13:59 | |
jgriffith | xyang1: that's what I'm hoping yes :) | 13:59 |
xyang1 | jgriffith: Let me check what it is doing | 14:00 |
*** anuragpalsule has quit IRC | 14:00 | |
jgriffith | xyang1: awesome, thanks | 14:00 |
*** timcl has quit IRC | 14:00 | |
*** tbarron has joined #openstack-cinder | 14:00 | |
*** rushil has joined #openstack-cinder | 14:01 | |
*** nshaikh has joined #openstack-cinder | 14:03 | |
xyang1 | jgriffith: I added comment there | 14:05 |
*** akerr has joined #openstack-cinder | 14:07 | |
*** timcl has joined #openstack-cinder | 14:07 | |
DuncanT | jgriffith: That looks totally wrong | 14:07 |
xyang1 | jgriffith: I think he just need to say: implement unmanage | 14:07 |
DuncanT | jgriffith: If we're calling unmanage in delete then we have a problem | 14:08 |
*** annegentle has joined #openstack-cinder | 14:08 | |
jgriffith | DuncanT: yeah, that was my point too | 14:08 |
*** zhipeng_ has joined #openstack-cinder | 14:08 | |
DuncanT | jgriffith: The stack trace in the bug is not exactly helpful | 14:09 |
xyang1 | DuncanT: jgriffith so when api does unmanage, it calls delete volume in manager. Then the manager calls driver's unmanage. | 14:09 |
xyang1 | In this case, unmanage was not implemented | 14:10 |
*** zhipeng has quit IRC | 14:10 | |
*** lpetrut has quit IRC | 14:11 | |
*** annegentle has quit IRC | 14:11 | |
*** lpetrut has joined #openstack-cinder | 14:12 | |
*** lpetrut has quit IRC | 14:12 | |
*** rushiagr_away is now known as rushiagr | 14:13 | |
DuncanT | xyang1: Yeah, got that. It looks like just an unclear/misleading bug report, which is fine | 14:14 |
jgriffith | xyang1: yeah, it's misleading because it sets the unmanage_only flag | 14:15 |
jgriffith | DuncanT: +1 | 14:15 |
jgriffith | so I'd just like to see the bug description cleared up and the commit message more accurate | 14:15 |
jgriffith | and then I'm happy to +2/A the patch | 14:15 |
jgriffith | DuncanT: xyang1 it may seem silly, but I worry that what's there is going to introduce confusion and misunderstanding | 14:16 |
xyang1 | DuncanT: jgriffith I asked him to clarify how delete volume ended up doing unmanage | 14:16 |
jgriffith | xyang1: great, thanks! | 14:16 |
DuncanT | jgriffith: +1. I marked the bug as invalid/needs more info | 14:16 |
jgriffith | that'll work :) | 14:16 |
jgriffith | xyang1: DuncanT thanks to both of you for the help | 14:17 |
xyang1 | jgriffith: DuncanT delete imported volume should be no difference from delete regular volume | 14:17 |
jgriffith | xyang1: correct | 14:17 |
DuncanT | xyang1: +1 | 14:17 |
jgriffith | xyang1: I think the confusion was just because we "use" delete for unmanage | 14:17 |
jgriffith | which is probably a really bad idea | 14:17 |
xyang1 | jgriffith: That is probably it | 14:18 |
* DuncanT hasn't done any bug triage for a while | 14:18 | |
*** BharatK has joined #openstack-cinder | 14:18 | |
DuncanT | Probably time to go spend an hour going through some | 14:18 |
jgriffith | DuncanT: you do an hour now, and I'll do an hour later today | 14:18 |
jgriffith | :) | 14:18 |
jgriffith | DuncanT: that way we don't overlap and knock some stuff out | 14:19 |
DuncanT | jgriffith: Excellent, I'll hopefully have taken care of the easy ones by then ;-) | 14:19 |
jgriffith | DuncanT: hey wait.... I'll go first, then you go tomorrow :) | 14:19 |
*** eharney has joined #openstack-cinder | 14:21 | |
*** topshare has joined #openstack-cinder | 14:21 | |
*** topshare has quit IRC | 14:21 | |
*** topshare has joined #openstack-cinder | 14:22 | |
*** topshare has quit IRC | 14:22 | |
*** topshare has joined #openstack-cinder | 14:23 | |
dulek | thangp: Hi! | 14:24 |
*** Mandell has joined #openstack-cinder | 14:25 | |
dulek | thangp: I'm just curious - why you're manually tracking changes in metadata field (which is DictOfStringsField) in Snapshot object | 14:25 |
*** jungleboyj has joined #openstack-cinder | 14:25 | |
thangp | dulek: you have to so that when you save, it gets saved in the db table | 14:27 |
thangp | dulek: snapshot_metadata is in a separate table | 14:27 |
dulek | thangp: So versionedobjects doesn't take care of it out of the box? | 14:28 |
thangp | dulek: nope | 14:28 |
*** lpetrut has joined #openstack-cinder | 14:28 | |
dulek | thangp: I thought otherwise from the quick glance into the code. Okay, thanks! | 14:29 |
thangp | dulek: managing mutliple db tables is up to the implementer of the versionedobjects | 14:29 |
*** IanGovett has quit IRC | 14:30 | |
*** Guest75125 has joined #openstack-cinder | 14:30 | |
*** emagana has quit IRC | 14:31 | |
*** zhithuang has joined #openstack-cinder | 14:32 | |
*** yuriy_n17 has quit IRC | 14:33 | |
*** timcl1 has joined #openstack-cinder | 14:33 | |
*** zhithuang is now known as winston-d_ | 14:34 | |
winston-d_ | dulek: ping | 14:34 |
*** timcl has quit IRC | 14:34 | |
winston-d_ | dulek: ping | 14:34 |
dulek | winston-d_: hi! | 14:34 |
winston-d_ | dulek: hey, want to check with you about the comment related to 'error out' | 14:35 |
winston-d_ | dulek: due to my ignorance about taskflow, i need some education here. | 14:35 |
dulek | winston-d_: sure, it would be definitely easier to discuss here :) | 14:36 |
*** kaufer has left #openstack-cinder | 14:36 | |
*** markvoelker has quit IRC | 14:37 | |
*** markvoelker has joined #openstack-cinder | 14:37 | |
*** ankit_ag has quit IRC | 14:39 | |
winston-d_ | dulek: yes | 14:39 |
dulek | winston-d_: So any specific questions or you want me to try to explain it in details? | 14:40 |
winston-d_ | dulek: so by moving the retry out of taskflow, error_out_volume() doesn't work anymore? | 14:40 |
*** IanGovett has joined #openstack-cinder | 14:41 | |
dulek | winston-d_: Point is - volume is errored-out inside the flow in case of NoValidHost. | 14:41 |
dulek | winston-d_: So when I have NoValidHost in manager volume is already updated in the DB and notification on the error send. | 14:41 |
*** markvoelker has quit IRC | 14:42 | |
dulek | winston-d_: So I shouldn't retry whole flow, because we don't want multiple notifications. | 14:42 |
winston-d_ | dulek: yes, that sounds reasonable. | 14:42 |
dulek | winston-d_: So the correct approach would be to get error_out_volume execution out of TaskFlow. | 14:42 |
dulek | winston-d_: But this breaks the point of using TaskFlow. | 14:43 |
winston-d_ | dulek: ah, i see your point. | 14:43 |
*** Guest75125 is now known as notsogentle | 14:43 | |
dulek | winston-d_: Because in the end we start to take out more parts and then whole flow can be moved back to manager | 14:43 |
*** notsogentle is now known as agentle_ | 14:43 | |
*** rwsu has joined #openstack-cinder | 14:44 | |
*** nshaikh has quit IRC | 14:44 | |
dulek | winston-d_: I'm not TaskFlow evangelist, it has it flaws, but such big change for a simple bug fix sounds too overwhelming | 14:44 |
winston-d_ | dulek: i'd agree with that. | 14:44 |
openstackgerrit | harsh mishra proposed openstack/cinder: Fix for inconsistent cinder-services state change https://review.openstack.org/160104 | 14:45 |
dulek | winston-d_: Your point is correct - we need a generic solution, but simply using jgriffith's decorator for retries will work in cases of operations that are running inside the manager. | 14:45 |
dulek | winston-d_: I'm glad we can agree on that. :) | 14:46 |
winston-d_ | dulek: well, my first thought was we don't retry but wait, but then DuncanT suggest using retry until successful or timeout to shorten the delay. | 14:46 |
winston-d_ | dulek: that's probably best we can do, without modification to scheduler. | 14:47 |
dulek | winston-d_: Yes. I've tested it and normally just one retry is required (after your change with init_host_with_rpc), so this is nice. | 14:47 |
winston-d_ | dulek: but the thing is, or invalid request, we end up wasting resource doing useless retries. | 14:48 |
dulek | winston-d_: True, I agree. | 14:48 |
dulek | winston-d_: Do you have a plan how to cleanly implement raising NoValidHostNotComplete? Current way of returning two variables from a method doesn't seem appealing. | 14:48 |
jgriffith | winston-d_: +100000 | 14:48 |
*** markvoelker has joined #openstack-cinder | 14:49 | |
winston-d_ | dulek: another idea that I have is, do not even start trying, if schedule hasn't reached the state where it can consider itself has the so-called 'complete' view of all backends. | 14:50 |
*** hemnafk is now known as hemna | 14:50 | |
jgriffith | winston-d_: how would you define that? | 14:51 |
winston-d_ | dulek: that requires some other changes to scheduler though, at least one additional DB query is needed. | 14:51 |
dulek | winston-d_: Can you explain it in more details? | 14:52 |
winston-d_ | jgriffith: query DB for all active c-vol services; and check if scheduler itself has the up-to-date stats from all of them, here up-to-date means stats['timestamp'] - now < CONF.service_down_time | 14:53 |
jgriffith | winston-d_: hmmm | 14:53 |
*** jaypipes has quit IRC | 14:53 | |
*** e0ne is now known as e0ne_ | 14:54 | |
*** eharney has quit IRC | 14:54 | |
jgriffith | winston-d_: so that would be a one time query on startup of the scheduler | 14:54 |
jgriffith | winston-d_: not terrible; and you'd still easily pick up "new" services from rabbit if/when they come online? | 14:55 |
openstackgerrit | Rushil Chugh proposed openstack/cinder: Fixing mount when state_path is configured with a final '/' https://review.openstack.org/163032 | 14:55 |
dulek | jgriffith: I think this query should be run at each request in this 60-seconds time window at scheduler start | 14:55 |
winston-d_ | dulek: this scheduler-complete-view logic is already in my PoC scheduler change, but only used for return a set of out-of-date c-vols, then scheduler raises NoVolidNotComplete when out-of-date set isn't empty. | 14:55 |
winston-d_ | dulek: no, just one time | 14:56 |
winston-d_ | dulek: it's about scheduler's view, not related to any specific request | 14:56 |
dulek | winston-d_: Ah, and then scheduler can update it's view when receiving updates from c-volume | 14:57 |
*** anshul has quit IRC | 14:57 | |
*** e0ne has joined #openstack-cinder | 14:57 | |
winston-d_ | jgriffith: unless we plan to do more stuff about scheduler not having 'complete' view situation in normal cinder request processing, we don't care if scheduler has complete view or not, for most of the time. | 14:58 |
winston-d_ | dulek: yes | 14:58 |
*** eharney has joined #openstack-cinder | 14:58 | |
dulek | So it would be your PoC + doing _update_host_state_map on scheduler start | 14:59 |
openstackgerrit | Peter Wang proposed openstack/cinder: Fixes VNX NotImplementedError of unmanage https://review.openstack.org/162532 | 14:59 |
openstackgerrit | Peter Wang proposed openstack/cinder: Fixes VNX NotImplementedError of unmanage https://review.openstack.org/162532 | 15:00 |
DuncanT | winston-d_: With your patch to get the updates faster in the normal case, just waiting isn't such a problem, there are not normally any long stalls, so I'm not as bothered as I was | 15:00 |
winston-d_ | dulek: yes. | 15:00 |
rhagarty | hemna, https://blueprints.launchpad.net/python-cinderclient/+spec/volume-type-description | 15:01 |
*** TobiasE has joined #openstack-cinder | 15:02 | |
dulek | winston-d_, DuncanT, jgriffith: So how should I proceed with the patch now? | 15:03 |
winston-d_ | DuncanT: but we still need to figure a way to be able to dynamically alter 'scheduler_delay', otherwise, the 'just wait' solution will have a bunch of request waiting for 'scheduler_delay' | 15:03 |
winston-d_ | DuncanT: or, the simplest solution is, just wait, but change 'scheduler_deplay' to a much shorter duration, say, 5 sec? | 15:04 |
jgriffith | dulek: I'm going to defer to winston-d_ and DuncanT as they've been more involved with this than myself as of late | 15:04 |
e0ne | rhagarty: hi. is bp for cinder approved? for patch https://review.openstack.org/#/c/140906/ you provided link for cinderclient bp | 15:04 |
*** TobiasE1 has quit IRC | 15:04 | |
DuncanT | winston-d_: 5 seconds might well not be enough with a large, busy system though | 15:04 |
winston-d_ | DuncanT: that's true. | 15:04 |
*** agentle_ has quit IRC | 15:05 | |
DuncanT | winston-d_: I prefer retrying again now - we aren't contacting a backend in the case of failure, just doing some internal work, so it isn't a cost | 15:05 |
dulek | DuncanT, winston-d_: We can increase the backoff in retries. | 15:05 |
*** yuriy_n17 has joined #openstack-cinder | 15:05 | |
DuncanT | dulek: Optimally we should retry after each status comes in | 15:06 |
*** lpetrut has quit IRC | 15:06 | |
dulek | DuncanT: This increases complexity of the patch as we're unable to use utils.retry decorator. | 15:06 |
rhagarty | eOne: taking a look now. Originally there was one blueprint to handle both vol type description and name change, but we split up the patches - one for description (already merged), and one for name change | 15:07 |
DuncanT | dulek: Backing off doesn't buy us much, the retry is only an internal datastructure lookup, it really doesn't matter if we retry a thousand times, it costs us nothing since the process can't do anything useful anyway | 15:07 |
winston-d_ | DuncanT: not easy to get notified for that stats coming-in event though. | 15:07 |
*** vilobhmm has joined #openstack-cinder | 15:08 | |
dulek | winston-d_: It's possible to notify TaskFlow's flow from the outside. | 15:08 |
dulek | winston-d_: But it would get code more complicated which when TaskFlow is involved I would prefer to avoid | 15:08 |
winston-d_ | DuncanT: yeah, worst case, one bad request (e.g. with wrong scheduler hint) comes in, and scheduler process eats one processor core. :) | 15:08 |
winston-d_ | DuncanT: that was my motivation of scheduler raising new exception to let caller knows if scheduler has all stats it needs. | 15:11 |
dulek | winston-d_: This won't fix blocking the thread tough. | 15:12 |
*** vilobhmm has left #openstack-cinder | 15:12 | |
winston-d_ | dulek: what blocking thread? | 15:12 |
winston-d_ | dulek, DuncanT: if scheduler is able to adjust 'schedule_delay' based on stats it received, i think it's better to just wait and check (and don't start taskflow). | 15:13 |
dulek | winston-d_: Maybe I've misunderstood DuncanT, [16:07:04] | 15:13 |
rhagarty | hemmna, eOne: here is the Cinder blueprint which is approved for kilo - https://blueprints.launchpad.net/cinder/+spec/volume-type-description | 15:14 |
dulek | winston-d_:Is it? You mean with your PoC patch? | 15:15 |
rhagarty | hemna, e0ne: should I add additional blueprint tag in all of the patches? | 15:17 |
winston-d_ | dulek: no, my PoC doesn't do that, but I can change that if that's desired. | 15:18 |
openstackgerrit | Brianna Poulos proposed openstack/cinder: Add project_id to barbican keymgr wrapper https://review.openstack.org/155875 | 15:19 |
rhagarty | hemna, e0ne: unfortunately, both the cinder and python-cinderclient BPs have the same name | 15:19 |
dulek | winston-d_: So host_manager and scheduler_driver would report when all the stats are received? | 15:19 |
hemna | rhagarty, yes, please add the bp info in the commit message | 15:19 |
*** topshare has quit IRC | 15:20 | |
*** dannywilson has joined #openstack-cinder | 15:20 | |
e0ne | i've asked Duncun earlier, now i would ask other cores to review https://review.openstack.org/162488. it's a patch for openstack-dev | 15:21 |
*** dannywilson has quit IRC | 15:21 | |
e0ne | i mean for devstack | 15:21 |
winston-d_ | dulek: not report, but flip a switch, like changing a flag 'open_to_business' once host manager has got all stats. | 15:21 |
*** dannywilson has joined #openstack-cinder | 15:21 | |
*** boris-42 has quit IRC | 15:22 | |
*** Mandell has quit IRC | 15:22 | |
winston-d_ | dulek: scheduler manager can sleep and check for self.host_manager.open_for_business flag to come true and then start feeding requests to driver. | 15:22 |
*** david-lyle_afk is now known as david-lyle | 15:23 | |
openstackgerrit | Brianna Poulos proposed openstack/cinder: Add project_id to barbican keymgr wrapper https://review.openstack.org/155875 | 15:23 |
hemna | e0ne, so the volume type description/name change is all good. the confusion is that the link in the commit message is pointing to the cinderclient BP | 15:23 |
hemna | e0ne, the real BP for cinder is all good. | 15:23 |
winston-d_ | well, in that sense, 'schedule_delay' is redundent. | 15:23 |
dulek | winston-d_: True. | 15:23 |
e0ne | hemna: thanks for clarification of it! now i can +2/+A for it | 15:23 |
dulek | winston-d_: manager doesn't have access to host_manager I think, so this would need to be reported trough the driver also. | 15:24 |
hemna | e0ne, thanks | 15:24 |
dulek | winston-d_: I mean scheduler_driver. | 15:24 |
winston-d_ | dulek: correct | 15:24 |
rhagarty | hemna, e0ne: thanks! | 15:24 |
dulek | winston-d_: This is still doable from what I see. | 15:25 |
winston-d_ | dulek: yes, it is. | 15:26 |
e0ne | rhagarty, hemna: where is link for bp in cinder? i can't find it:( | 15:27 |
*** lpetrut has joined #openstack-cinder | 15:27 | |
*** zhipeng_ has quit IRC | 15:27 | |
rhagarty | e0ne: https://blueprints.launchpad.net/cinder/+spec/volume-type-description | 15:27 |
dulek | winston-d_: So in that case we're getting rid of retries but we stop sleeping just once we have the stats so long delay shouldn't be a problem. | 15:28 |
e0ne | rhagarty: thanks! | 15:28 |
dulek | winston-d_: This seems fine, I'll start reworking the patch. | 15:28 |
*** pradipm has joined #openstack-cinder | 15:28 | |
*** emagana has joined #openstack-cinder | 15:28 | |
winston-d_ | dulek: yes | 15:29 |
*** nlevinki has quit IRC | 15:29 | |
winston-d_ | dulek: please split the change into two parts: 1st one for scheduler change; 2nd one is to address the bug | 15:29 |
dulek | Okay, I'll try to do that. And of course these should depend on your change. | 15:30 |
e0ne | hemna: i've rebased your patch on my with shadow tables: https://github.com/e0ne/cinder/commit/8ae973852fdf11b7c01f9e268361fa1d319846d4. sqlite downgrade looks a bit ugly :( | 15:31 |
hemna | e0ne, I'm about to push a new patchset up for it. covering the comments | 15:31 |
winston-d_ | dulek: yes, the init_host_after_rpc is still very important fix to shorten the time for scheduler to gather all stats. | 15:32 |
hemna | e0ne, ouch yah, the shadow tables makes a mess of migrations. :( I really don't like it. | 15:32 |
*** kallebe has quit IRC | 15:32 | |
e0ne | hemna: yep:( | 15:32 |
*** shyama has quit IRC | 15:33 | |
e0ne | i'm thinking how can we move it to oslo.db | 15:33 |
*** tsekiyama has joined #openstack-cinder | 15:34 | |
winston-d_ | dulek: ok, it's close to midnight, i need to drop off now. looking forward to your new change(s). ttyl. | 15:35 |
dulek | winston-d_: Thank you! | 15:35 |
*** winston-d_ has quit IRC | 15:35 | |
*** changbl has joined #openstack-cinder | 15:35 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Add volume multi attach support https://review.openstack.org/85847 | 15:37 |
*** delattec has joined #openstack-cinder | 15:37 | |
*** cdelatte has quit IRC | 15:39 | |
*** boris-42 has joined #openstack-cinder | 15:39 | |
*** annashen has joined #openstack-cinder | 15:40 | |
*** esker has joined #openstack-cinder | 15:42 | |
*** nlevinki has joined #openstack-cinder | 15:44 | |
*** annashen has quit IRC | 15:44 | |
katco | is the size specified in a create volume request in GB or GiB? | 15:45 |
*** Apoorva has joined #openstack-cinder | 15:46 | |
*** changbl has quit IRC | 15:47 | |
e0ne | katco: do you mean GB or MB? | 15:48 |
e0ne | katco: oh.. i've got your question | 15:50 |
katco | :) | 15:50 |
katco | e0ne: the documentation states GB, but i wanted to double check what the actual implementation is | 15:51 |
DuncanT | katco: 1024 * 1024 * 1024 bytes | 15:57 |
pradipm | DuncanT:hi | 15:58 |
katco | DuncanT: so it looks like that's a GiB | 15:58 |
DuncanT | katco: Pass, sorry, I never figured those units out | 15:58 |
DuncanT | pradipm: Hi | 15:58 |
katco | DuncanT: hehe | 15:58 |
katco | DuncanT: tyvm for the answer | 15:59 |
*** crose has joined #openstack-cinder | 15:59 | |
*** markvoelker has quit IRC | 15:59 | |
pradipm | DuncanT: I was looking into the 'get_pools', where intent is to add a volume-type parameter to retrieve all the pools matching the extra-specs present in the vol-type | 15:59 |
*** markvoelker has joined #openstack-cinder | 16:00 | |
*** kallebe has joined #openstack-cinder | 16:00 | |
*** bill_az has joined #openstack-cinder | 16:01 | |
DuncanT | pradipm: Seems useful | 16:01 |
*** bkopilov has quit IRC | 16:02 | |
pradipm | DuncanT:I can pass another parameter as voltype(default to None). But we have already one parameter (most likely unused), called filters. Which is most likely not used/supported. | 16:03 |
*** changbl has joined #openstack-cinder | 16:03 | |
*** nlevinki has quit IRC | 16:03 | |
*** emagana has quit IRC | 16:04 | |
*** markvoelker has quit IRC | 16:05 | |
*** rmesta has joined #openstack-cinder | 16:06 | |
DuncanT | pradipm: I don't know that code well enough to comment without spending some time reading it | 16:06 |
*** rmesta has left #openstack-cinder | 16:07 | |
pradipm | DuncanT:sure. thanks. sorry to disturb you. | 16:08 |
*** emagana_ has joined #openstack-cinder | 16:08 | |
DuncanT | pradipm: No problem. I'll get back to you when I've looked at the code | 16:09 |
pradipm | DuncanT:I shall ping you after 19th. | 16:09 |
*** agentle_ has joined #openstack-cinder | 16:10 | |
*** delatte has joined #openstack-cinder | 16:10 | |
*** esker has quit IRC | 16:12 | |
*** TobiasE has quit IRC | 16:13 | |
*** delattec has quit IRC | 16:13 | |
*** changbl has quit IRC | 16:13 | |
*** tsekiyama has quit IRC | 16:14 | |
*** emagana_ has quit IRC | 16:16 | |
*** tsekiyama has joined #openstack-cinder | 16:17 | |
*** emagana has joined #openstack-cinder | 16:17 | |
*** ronis has quit IRC | 16:19 | |
*** vilobhmm1 has joined #openstack-cinder | 16:20 | |
*** emagana has quit IRC | 16:21 | |
vilobhmm1 | thangp : ping | 16:21 |
*** thingee has quit IRC | 16:23 | |
*** leeantho has joined #openstack-cinder | 16:24 | |
*** hodos has joined #openstack-cinder | 16:24 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Dell FC driver inheritance order causing failures https://review.openstack.org/163075 | 16:25 |
smcginnis | Any cores ^^ | 16:25 |
smcginnis | Critical bug for us with trivial fix. | 16:25 |
openstackgerrit | harsh mishra proposed openstack/cinder: Fix for inconsistent cinder-services state change https://review.openstack.org/160104 | 16:27 |
hemna | smcginnis, as soon as jenkins +1's I'll push it through | 16:28 |
*** stefan_amann has joined #openstack-cinder | 16:28 | |
smcginnis | hemna: Thank you sir! | 16:28 |
*** e0ne is now known as e0ne_ | 16:29 | |
*** e0ne_ is now known as e0ne | 16:31 | |
smcginnis | hemna, jgriffith: Appreciate the help! | 16:31 |
smcginnis | +1 for third party CI as well. :) | 16:32 |
openstackgerrit | Bob Callaway proposed openstack/cinder: Fix LUN misalignment issue with NetApp iSCSI drivers https://review.openstack.org/162376 | 16:32 |
*** alecv has quit IRC | 16:34 | |
*** delattec has joined #openstack-cinder | 16:35 | |
*** delatte has quit IRC | 16:38 | |
*** _cjones_ has joined #openstack-cinder | 16:39 | |
hemna | smcginnis, jdg beat me to it. :P | 16:39 |
smcginnis | hemna: :) | 16:40 |
*** jaypipes has joined #openstack-cinder | 16:40 | |
*** harlowja_away is now known as harlowja_ | 16:44 | |
*** pradipm has quit IRC | 16:48 | |
*** delatte has joined #openstack-cinder | 16:51 | |
*** delattec has quit IRC | 16:51 | |
*** markstur has quit IRC | 16:52 | |
*** esker has joined #openstack-cinder | 16:56 | |
*** lpetrut has quit IRC | 16:57 | |
*** agentle_ has quit IRC | 16:58 | |
*** timcl has joined #openstack-cinder | 16:58 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Namespace updates for _i18n and imageutils & fileutils https://review.openstack.org/157956 | 16:58 |
*** timcl1 has quit IRC | 16:58 | |
*** markstur has joined #openstack-cinder | 16:58 | |
*** timcl has quit IRC | 16:59 | |
*** timcl has joined #openstack-cinder | 16:59 | |
*** timcl has quit IRC | 17:00 | |
*** timcl has joined #openstack-cinder | 17:00 | |
*** timcl has quit IRC | 17:01 | |
*** jistr has quit IRC | 17:01 | |
*** timcl has joined #openstack-cinder | 17:01 | |
*** timcl has quit IRC | 17:02 | |
*** sbadia has quit IRC | 17:04 | |
*** _cjones_ has quit IRC | 17:05 | |
*** changbl has joined #openstack-cinder | 17:06 | |
*** Mandell has joined #openstack-cinder | 17:06 | |
*** Longgeek has quit IRC | 17:06 | |
*** sbadia has joined #openstack-cinder | 17:07 | |
*** jaypipes has quit IRC | 17:07 | |
*** markvoelker has joined #openstack-cinder | 17:09 | |
*** _cjones_ has joined #openstack-cinder | 17:09 | |
*** annashen has joined #openstack-cinder | 17:09 | |
*** krtaylor has quit IRC | 17:14 | |
openstackgerrit | Tom Barron proposed openstack/cinder: Refactor Swift backup driver and introduce chunking driver https://review.openstack.org/149725 | 17:17 |
stefan_amann | hemna: on the cinder changes for System z: the cert results show two failures because our images are 3GB. Some of the test cases have fixed values for quotas. We're trying to figure out these places. I'm still working on a clean run. But can't promise we will achieve that in the next hours. Is a clean run a requirement to get our changes merged? | 17:18 |
hemna | yah i would say so. | 17:19 |
*** markvoelker has quit IRC | 17:19 | |
*** markvoelker has joined #openstack-cinder | 17:19 | |
*** emagana has joined #openstack-cinder | 17:21 | |
*** changbl has quit IRC | 17:21 | |
*** markvoelker_ has joined #openstack-cinder | 17:21 | |
stefan_amann | ok | 17:22 |
*** patrickeast has joined #openstack-cinder | 17:22 | |
jungleboyj | stefan_amann: That was able to be worked around with the first run. | 17:23 |
*** markvoelker has quit IRC | 17:24 | |
stefan_amann | the first run was on Intel. We are using different images there. The current run is on System z and our images are roughly 3 GB. And some of the test cases don't deal with it | 17:24 |
*** changbl has joined #openstack-cinder | 17:24 | |
jungleboyj | Doh! Ok. | 17:25 |
*** krtaylor has joined #openstack-cinder | 17:27 | |
*** timcl has joined #openstack-cinder | 17:27 | |
openstackgerrit | Michal Dulko proposed openstack/cinder: Allow scheduler to receive volume stats when starting service https://review.openstack.org/158623 | 17:31 |
openstackgerrit | Michal Dulko proposed openstack/cinder: Add is_ready method to scheduler driver https://review.openstack.org/163098 | 17:31 |
openstackgerrit | Michal Dulko proposed openstack/cinder: Add waiting for the driver to SchedulerManager https://review.openstack.org/163099 | 17:31 |
*** lpetrut has joined #openstack-cinder | 17:31 | |
*** stefan_amann has quit IRC | 17:32 | |
*** coolsvap|afk is now known as coolsvap | 17:32 | |
*** changbl has quit IRC | 17:33 | |
*** dulek has quit IRC | 17:34 | |
*** thingee has joined #openstack-cinder | 17:34 | |
*** _cjones_ has quit IRC | 17:36 | |
*** _cjones_ has joined #openstack-cinder | 17:37 | |
*** esker has quit IRC | 17:40 | |
*** changbl has joined #openstack-cinder | 17:41 | |
*** e0ne has quit IRC | 17:42 | |
openstackgerrit | Tom Barron proposed openstack/cinder: Refactor Swift backup driver and introduce chunking driver https://review.openstack.org/149725 | 17:43 |
*** timcl has quit IRC | 17:49 | |
*** rhagarty has quit IRC | 17:49 | |
*** esker has joined #openstack-cinder | 17:51 | |
thingee | hemna: wrt https://review.openstack.org/#/c/85847/46/cinder/api/contrib/volume_actions.py | 17:53 |
thingee | hemna: can you pass an instance_uuid or host and it'll just work? | 17:53 |
hemna | no | 17:54 |
hemna | the current api is just detach w/o any params | 17:54 |
thingee | why? | 17:54 |
hemna | because it's only allowed to be attached to 1 thing | 17:54 |
thingee | right, so take the instance uuid or host in the body | 17:54 |
hemna | w/ multiattach it's attachment_id | 17:54 |
thingee | instead of attach id | 17:54 |
hemna | because we don't know if it's a host or instance_uuid | 17:54 |
*** resker has joined #openstack-cinder | 17:54 | |
thingee | I've talked to some of the ops folks here on the current idea and people agree it's a bit cumbersome. | 17:55 |
hemna | and the attachment_id is a unique identifier for that specific attachment. | 17:55 |
thingee | 1) look up the instance or host identifier | 17:55 |
thingee | 2) look up all attach ids and match it | 17:55 |
thingee | 3) give the attach id | 17:55 |
hemna | the attachment id comes with the attachments list on a volume | 17:55 |
hemna | you fetch the volume | 17:55 |
hemna | it has all of the attachments | 17:55 |
hemna | find the one you want to detach, and pass it. | 17:55 |
thingee | I think you should just be able to pass what you want that volume to detach or attach from | 17:55 |
hemna | I disagree | 17:56 |
*** markus_z has quit IRC | 17:56 | |
hemna | this is how it was designed from the get go | 17:56 |
thingee | well I got users here who disagree :) | 17:56 |
hemna | we churned on this for a long time. | 17:56 |
thingee | it's too bad the input is coming now, but they will ultimately be using it | 17:56 |
*** jdurgin has joined #openstack-cinder | 17:56 | |
hemna | the host, or instance uuid isn't enough | 17:56 |
hemna | because it's not guaranteed to be unique | 17:56 |
hemna | to find that specific attachment. | 17:57 |
thingee | why? if you have the volume and host/instance, look it up. what else is there going to be? | 17:57 |
hemna | only the attachment id is unique for each individual attachment. | 17:57 |
*** esker has quit IRC | 17:57 | |
*** ronis has joined #openstack-cinder | 17:57 | |
hemna | it can be attached multiple times. | 17:57 |
hemna | which one do you get? | 17:57 |
hemna | there are 4 of them | 17:57 |
hemna | doesn't work. | 17:57 |
thingee | right but a volume is only going to be attach to one specific vm and another specific vm right? | 17:57 |
thingee | or host | 17:58 |
hemna | not on a vmware clustered system | 17:58 |
hemna | where the volume looks like it's attached to the same thing multiple times. | 17:58 |
thingee | there are cases where you want a vm attached to the same exact vm? | 17:58 |
hemna | yes | 17:58 |
thingee | twice | 17:58 |
thingee | why? | 17:58 |
hemna | that's the vmware clustering model works. | 17:58 |
hemna | it looks like it's attached to the same thing multiple times. | 17:59 |
*** stefan_amann has joined #openstack-cinder | 17:59 | |
hemna | this is the only way it will always work, regardless. | 17:59 |
*** kallebe has quit IRC | 17:59 | |
*** rhagarty has joined #openstack-cinder | 17:59 | |
thingee | but why? | 17:59 |
*** victorfeitosa has quit IRC | 17:59 | |
thingee | just because a company does it mean it's right for openstack. | 17:59 |
hemna | I just explained why | 17:59 |
thingee | you said because vmware does it | 17:59 |
thingee | that's not a reason why they do it | 17:59 |
*** asselin_ has joined #openstack-cinder | 18:00 | |
hemna | we want to be able to support vmware as the hypervisor for openstack. | 18:01 |
hemna | I'm not sure why shooting ourselves in the foot makes sense. | 18:01 |
hemna | when it's a clean/simple api. | 18:01 |
thingee | Anyways, speaking for ops here. | 18:01 |
hemna | would have been nice if you asked these questions a year ago, when this was discussed then. | 18:02 |
thingee | I know this patch has been dragging, but I feel like you're letting your frustration get in the way of wanting to let people give you feedback, even if it is late. | 18:02 |
hemna | yes, I'm frustrated | 18:03 |
*** victorfeitosa has joined #openstack-cinder | 18:03 | |
hemna | because it's awesome that folks ignore this work for over a year and now just dump on it. | 18:03 |
hemna | it's not like this has been a surprise | 18:03 |
hemna | we even talked about it at the Paris summit | 18:03 |
thingee | have you ever solicited the ops list? | 18:03 |
hemna | where were the reviews and discussions about it ? | 18:03 |
hemna | why is this just happening now? | 18:03 |
*** Mandell has quit IRC | 18:04 | |
hemna | that's not the point. | 18:04 |
*** jaypipes has joined #openstack-cinder | 18:04 | |
thingee | well if you want feedback, the list might be a good place to start. | 18:04 |
*** bkopilov has joined #openstack-cinder | 18:05 | |
*** changbl has quit IRC | 18:05 | |
*** mathrock has joined #openstack-cinder | 18:05 | |
hemna | at this point, I'm just ready to abandon the effort all together. it's pointless. | 18:05 |
*** sgotliv has quit IRC | 18:06 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Implement IET target driver https://review.openstack.org/158829 | 18:06 |
thingee | I'm really sorry you're frustrated and I know I wasn't involved with it this release, because it wasn't my particular focus that I told people I would do initially. I wasn't involved with the earlier releases either because initially we just gave up after the nova side wouldn't get merged. | 18:07 |
thingee | But I've been trying to tell you that I want to work with you on this and make sure we merge it first thing when L starts after the version change merges. | 18:07 |
*** yuriy_n17 has quit IRC | 18:08 | |
thingee | but I'll help ask people on feedback with the implementation. I also have interest in helping to test it with the concerns I had in the patch. | 18:09 |
*** IanGovett has quit IRC | 18:10 | |
hemna | and you haven't been involved in this review the entire K release until now, just to prevent this from landing. | 18:11 |
hemna | that's fine, it's your job as PTL to say no. | 18:11 |
hemna | I get it. | 18:11 |
hemna | I'm over it. | 18:11 |
*** timcl has joined #openstack-cinder | 18:12 | |
*** stefan_amann has quit IRC | 18:12 | |
thingee | I would rather think it's my job to help you be successful. I think making sure you have priority in early L for landing to get sufficient gate testing and help encouraging the nova side is a good solution. But people want to rush this in K because they have no faith in my word on that. | 18:14 |
thingee | look at k-3. its been pretty successful in my opinion. I think we can do this for multi-attach too. I'll help do the rebase for you too. | 18:14 |
*** IanGovett has joined #openstack-cinder | 18:15 | |
*** Mandell has joined #openstack-cinder | 18:15 | |
*** victorfeitosa has quit IRC | 18:17 | |
*** karimb has quit IRC | 18:24 | |
*** takedakn has joined #openstack-cinder | 18:26 | |
*** [1]Thelo has joined #openstack-cinder | 18:26 | |
*** dulek has joined #openstack-cinder | 18:26 | |
*** takedakn has quit IRC | 18:27 | |
*** resker has quit IRC | 18:27 | |
*** Thelo has quit IRC | 18:28 | |
*** [1]Thelo is now known as Thelo | 18:28 | |
*** annashen has quit IRC | 18:34 | |
*** e0ne has joined #openstack-cinder | 18:37 | |
*** _cjones_ has quit IRC | 18:38 | |
*** changbl has joined #openstack-cinder | 18:44 | |
*** agentle_ has joined #openstack-cinder | 18:50 | |
*** _cjones_ has joined #openstack-cinder | 18:54 | |
*** agentle_ has quit IRC | 18:55 | |
*** agentle_ has joined #openstack-cinder | 18:55 | |
*** sgotliv has joined #openstack-cinder | 19:00 | |
*** markvoelker_ has quit IRC | 19:01 | |
*** emagana has quit IRC | 19:01 | |
*** Mandell has quit IRC | 19:01 | |
*** emagana has joined #openstack-cinder | 19:02 | |
e0ne | jungleboyj: hi Jay! do we still plan make oslo.middleware landed in Kilo? | 19:05 |
*** emagana has quit IRC | 19:06 | |
*** rushiagr is now known as rushiagr_away | 19:07 | |
*** Mandell has joined #openstack-cinder | 19:07 | |
*** jaypipes is now known as jay-afk | 19:09 | |
*** jay-afk is now known as jaypipes-afk | 19:10 | |
*** angela-s has joined #openstack-cinder | 19:10 | |
*** BharatK has left #openstack-cinder | 19:13 | |
vilobhmm1 | thangp : ping | 19:14 |
vilobhmm1 | dulek : ping | 19:14 |
thangp | vilobhmm1: hey | 19:14 |
vilobhmm1 | thangp : was working on quota objects | 19:15 |
*** rushiagr_away is now known as rushiagr | 19:15 | |
dulek | vilobhmm1: Hi | 19:15 |
vilobhmm1 | the way def quota_update(context, project_id, resource, limit): or quota_create is defined | 19:16 |
vilobhmm1 | which doesn't take "values" (dict) as an input in the create and save methods for the Quota class the method obj_get_changes | 19:16 |
vilobhmm1 | won't be applicable | 19:16 |
vilobhmm1 | so i will keep it simple | 19:17 |
vilobhmm1 | to accept project_id, resource, limit as input | 19:17 |
vilobhmm1 | or just to be in sync do you prefer changing the quota* api at the db/sqlalchemy layer to the way snapshot/volume/backup have theres | 19:17 |
vilobhmm1 | dulek : hi…please see above que ^^ | 19:18 |
*** ndipanov has quit IRC | 19:18 | |
vilobhmm1 | which doesn't take "values" (dict) as an input ; so in the create and save methods for the Quota class the method | 19:18 |
dulek | vilobhmm1: Oh, I get it. I would prefer not to change existing DB API. | 19:19 |
vilobhmm1 | ok | 19:20 |
thangp | vilobhmm1: I suggest you look at https://github.com/openstack/nova/blob/master/nova/objects/quotas.py | 19:20 |
vilobhmm1 | sure thangp | 19:20 |
*** coolsvap is now known as coolsvap|afk | 19:20 | |
vilobhmm1 | thanks thangp, dulek | 19:20 |
*** BharatK has joined #openstack-cinder | 19:20 | |
thangp | vilobhmm1: nova uses the same constructs was we do: quota_create(context, project_id, resource, limit) | 19:21 |
vilobhmm1 | thangp : or vice versa :) since we were intially part of nova :P thanks btwn | 19:22 |
*** erlon has joined #openstack-cinder | 19:22 | |
*** Mandell has quit IRC | 19:23 | |
*** bill_az has quit IRC | 19:24 | |
openstackgerrit | Michal Dulko proposed openstack/cinder: Add is_ready method to scheduler driver https://review.openstack.org/163098 | 19:26 |
openstackgerrit | Michal Dulko proposed openstack/cinder: Add waiting for the driver to SchedulerManager https://review.openstack.org/163099 | 19:26 |
*** annashen has joined #openstack-cinder | 19:27 | |
*** stefan_amann has joined #openstack-cinder | 19:30 | |
*** emagana has joined #openstack-cinder | 19:31 | |
openstackgerrit | Michal Dulko proposed openstack/cinder: Add is_ready method to scheduler driver https://review.openstack.org/163098 | 19:31 |
openstackgerrit | Michal Dulko proposed openstack/cinder: Add waiting for the driver to SchedulerManager https://review.openstack.org/163099 | 19:32 |
*** mathrock has quit IRC | 19:32 | |
*** timcl has quit IRC | 19:35 | |
*** hodos has quit IRC | 19:36 | |
*** rushiagr is now known as rushiagr_away | 19:36 | |
*** vishy has joined #openstack-cinder | 19:38 | |
*** asselin_ has quit IRC | 19:38 | |
jungleboyj | e0ne: Would be nice if we could. Any progress with the change to Grenade? | 19:40 |
e0ne | jungleboyj: it was proposed to not make such changes in Kilo there | 19:41 |
jungleboyj | e0ne: Still hoping to get my changes for config-generator in but that isn't going to happen until tomorrow at the earliest. Busy with meetings, code reviews, etc. | 19:41 |
e0ne | jungleboyj: but i don't know how could we deprecate middleware from oslo-incubator | 19:41 |
jungleboyj | e0ne: If they won't take the Grenade change, I guess we won't be able to do that until L. | 19:42 |
e0ne | jungleboyj: yes. did you see their comments? | 19:42 |
openstackgerrit | Tom Barron proposed openstack/cinder: Refactor Swift backup driver and introduce chunking driver https://review.openstack.org/149725 | 19:42 |
jungleboyj | No, let me looking. | 19:43 |
*** Yogi11 has joined #openstack-cinder | 19:43 | |
jungleboyj | e0ne: Oh, I did see that. Ok, I guess we will need to take that approach instead. | 19:44 |
*** Mandell has joined #openstack-cinder | 19:44 | |
*** Yogi1 has quit IRC | 19:47 | |
*** dulek has quit IRC | 19:56 | |
e0ne | jungleboyj: ok. what is the correct way to deprecate such things? | 19:57 |
*** aix has quit IRC | 19:57 | |
jungleboyj | e0ne: Good question. Guessing we need to Log a deprecation message when oslo.middleware is used. | 19:58 |
e0ne | jungleboyj: but we won't use it in Kilo | 19:58 |
e0ne | and we can't change code in incubator | 19:58 |
jungleboyj | e0ne: Doh. | 19:58 |
jungleboyj | Sorry, I meant openstack.common.middleware . | 19:59 |
jungleboyj | Yeah, we can't change that. | 19:59 |
jungleboyj | Hold on. | 19:59 |
jungleboyj | tbarron: You there? | 19:59 |
tbarron | jungleboyj: yup | 19:59 |
jungleboyj | You able to fix up a couple of comments on : https://review.openstack.org/#/c/149725 | 20:00 |
e0ne | jungleboyj: it's not such easy as i think:( | 20:00 |
*** bswartz has quit IRC | 20:01 | |
jungleboyj | e0ne: Going to go chat with my friends in the oslo channel. | 20:01 |
e0ne | :) | 20:01 |
openstackgerrit | Tom Barron proposed openstack/cinder: Refactor Swift backup driver and introduce chunking driver https://review.openstack.org/149725 | 20:15 |
*** annashen has quit IRC | 20:15 | |
*** takedakn has joined #openstack-cinder | 20:16 | |
*** delatte has quit IRC | 20:19 | |
*** angela-s has quit IRC | 20:21 | |
*** casusbelli has joined #openstack-cinder | 20:25 | |
*** akerr has quit IRC | 20:32 | |
*** jungleboyj has quit IRC | 20:33 | |
*** annashen has joined #openstack-cinder | 20:34 | |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Fail immediately for images in a container https://review.openstack.org/163170 | 20:37 |
*** emagana has quit IRC | 20:41 | |
*** cdelatte has joined #openstack-cinder | 20:41 | |
*** boris-42 has quit IRC | 20:42 | |
*** tshefi has quit IRC | 20:42 | |
*** tbarron has quit IRC | 20:44 | |
*** esker has joined #openstack-cinder | 20:46 | |
*** tbarron has joined #openstack-cinder | 20:47 | |
*** tbarron1 has joined #openstack-cinder | 20:47 | |
mtanino | e0ne: Thank you for the review :) https://review.openstack.org/#/c/161036/5 | 20:49 |
stefan_amann | hemna: the cinder certification now runs successfully on System z. I had to install fixes for a new bug we opened. The fix reolves the issue that some of the tests implement a fix value for quotas and/or image file sizes. I hope the cinder changes for System z are now ready to be merged. Thanks for reviewing! | 20:49 |
*** ronis has quit IRC | 20:50 | |
*** tbarron has quit IRC | 20:51 | |
*** changbl has quit IRC | 20:58 | |
*** vilobhmm1 has quit IRC | 21:03 | |
*** vilobhmm1 has joined #openstack-cinder | 21:03 | |
*** jungleboyj has joined #openstack-cinder | 21:07 | |
*** thingee has quit IRC | 21:07 | |
hemna | stefan_amann, ok let me check :) | 21:12 |
stefan_amann | thanks much! | 21:12 |
hemna | Failed: 0 | 21:13 |
hemna | w00t! | 21:13 |
*** angela-s has joined #openstack-cinder | 21:14 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Adjust Cinder to support FCP on System z systems https://review.openstack.org/149256 | 21:14 |
*** emagana has joined #openstack-cinder | 21:14 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Tests: Harden fake_notifier asserts https://review.openstack.org/163191 | 21:18 |
*** kaisers1 has joined #openstack-cinder | 21:19 | |
*** boris-42 has joined #openstack-cinder | 21:22 | |
*** rhagarty_ has joined #openstack-cinder | 21:26 | |
*** dannywilson has quit IRC | 21:30 | |
*** stefan_amann has quit IRC | 21:30 | |
*** stefan_amann has joined #openstack-cinder | 21:30 | |
*** Yogi11 has quit IRC | 21:31 | |
*** dustins has quit IRC | 21:31 | |
*** jcru has quit IRC | 21:40 | |
*** chlong has joined #openstack-cinder | 21:40 | |
*** crose has quit IRC | 21:43 | |
*** mriedem has quit IRC | 21:44 | |
*** stefan_amann has quit IRC | 21:45 | |
*** casusbelli has quit IRC | 21:46 | |
*** dflorea has joined #openstack-cinder | 21:47 | |
*** vilobhmm1 has quit IRC | 21:49 | |
*** jcru has joined #openstack-cinder | 21:49 | |
*** vilobhmm1 has joined #openstack-cinder | 21:49 | |
*** vilobhmm1 has quit IRC | 21:49 | |
*** vilobhmm1 has joined #openstack-cinder | 21:50 | |
*** lpetrut has quit IRC | 21:50 | |
jungleboyj | hemna: They got it!?! | 21:51 |
hemna | yah | 21:51 |
hemna | looks like they fixed it | 21:51 |
hemna | just waiting on jenkins | 21:51 |
jungleboyj | Yay! | 21:52 |
*** thangp has quit IRC | 21:52 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/python-cinderclient: Update to change name for volume type client https://review.openstack.org/141187 | 21:52 |
*** jcru has quit IRC | 21:53 | |
jungleboyj | hemna: Thanks for bearing with us while we got everything worked out. | 21:53 |
hemna | jungleboyj, np | 21:53 |
*** nikesh_vedams has quit IRC | 21:54 | |
jungleboyj | hemna: Looks like e0ne pushed up another patch for shadow tables. https://review.openstack.org/#/c/131182/ | 21:56 |
jungleboyj | Thought we were going to do what was discussed at the end of the day yesterday. | 21:56 |
e0ne | jungleboyj, hemna: i just rebased it. I'll set WIP status | 21:57 |
jungleboyj | e0ne: Ok. Thanks. Just wanted to make sure I hadn't missed something. | 21:57 |
*** vilobhmm1 has quit IRC | 21:57 | |
*** vilobhmm1 has joined #openstack-cinder | 21:57 | |
jungleboyj | hemna: Looks like I still need to look through your latest multi-attach patch. | 21:59 |
*** jaypipes-afk is now known as JAYPIPES | 21:59 | |
*** JAYPIPES is now known as jaypipes | 21:59 | |
hemna | jungleboyj, ok that'd be great thanks. though, I think thingee is dead set against it. | 21:59 |
hemna | fwiw | 21:59 |
jungleboyj | hemna: Understood, many others aren't though. | 22:00 |
jungleboyj | Don't know what to say there. | 22:00 |
*** takedakn has quit IRC | 22:00 | |
hemna | yah, it is what it is. | 22:00 |
hemna | so, separate topic | 22:00 |
hemna | are we -2'd new feature patches now? | 22:00 |
*** takedakn has joined #openstack-cinder | 22:00 | |
hemna | since the "deadline" has passed? | 22:00 |
e0ne | hemna: i'm sorry, didn't have a time to test your patch:(. i looked only on db-related code | 22:01 |
jungleboyj | Not only are we before the real deadline but we have time to test and stabilize. | 22:01 |
jungleboyj | hemna: I am not going to do that right now. Lets talkt about that in tomorrow's meeting. | 22:02 |
hemna | ok sounds good. | 22:02 |
hemna | yah I just wasn't sure what to do about in flight patches now. | 22:02 |
*** takedakn has quit IRC | 22:02 | |
hemna | guess we also hold off on +3 ? | 22:03 |
*** coolsvap|afk has quit IRC | 22:03 | |
jungleboyj | Well, I think the System Z one is fine if you are good with it and the Swift recactor. Those that are in the pipline right now that we ahve been watching. | 22:03 |
jungleboyj | The others on the list aren't ready to go and won't be by EOD. | 22:04 |
*** dflorea has quit IRC | 22:05 | |
jungleboyj | I need to drop off for a bit to drive home. Back online shortly. | 22:05 |
hemna | ok l8s | 22:05 |
mtanino | hemna: I'm sorry I can't join tomorrow's meeting(you proposed CI topic for target object) | 22:05 |
hemna | mtanino, it's ok, the topic is more of a general purpose discussion | 22:05 |
hemna | about CI and target objects | 22:05 |
mtanino | hemna: I got it. instead of me, anish will be join I think :) | 22:06 |
*** jungleboyj has quit IRC | 22:06 | |
hemna | ok sounds good | 22:06 |
*** chlong has quit IRC | 22:07 | |
anish | yep, I shall represent | 22:07 |
mtanino | hehe | 22:07 |
*** agentle_ has quit IRC | 22:07 | |
*** annashen has quit IRC | 22:20 | |
*** Lee1092 has quit IRC | 22:20 | |
anish | hemna: answered | 22:20 |
hemna | so...it's not needed? :P | 22:21 |
anish | well it's strictly "code cleanup" | 22:23 |
*** bswartz has joined #openstack-cinder | 22:23 | |
anish | but I do think that many mocks in a test case is not good | 22:23 |
hemna | well it depends on what you are trying to test really. | 22:23 |
*** agentle_ has joined #openstack-cinder | 22:25 | |
anish | possibly | 22:25 |
openstackgerrit | Julie Gravel proposed openstack/cinder: Validate volume type extra specs https://review.openstack.org/161480 | 22:31 |
*** rushil has quit IRC | 22:36 | |
*** jungleboyj has joined #openstack-cinder | 22:46 | |
*** agentle_ has quit IRC | 22:47 | |
*** etta_ has joined #openstack-cinder | 22:49 | |
*** jcru has joined #openstack-cinder | 22:51 | |
*** jcru has quit IRC | 22:51 | |
*** lcurtis has quit IRC | 22:52 | |
*** eharney has quit IRC | 22:55 | |
*** tbarron1 has quit IRC | 23:03 | |
*** _cjones_ has quit IRC | 23:05 | |
jgriffith | anybody around that uses the initiator list method for sec? | 23:06 |
jgriffith | xyang1: ping | 23:08 |
*** hemna is now known as hemnafk | 23:08 | |
*** esker has quit IRC | 23:08 | |
*** esker has joined #openstack-cinder | 23:09 | |
xyang1 | jgriffith: Hi | 23:10 |
jgriffith | xyang1: hi ya | 23:10 |
*** angela-s has quit IRC | 23:10 | |
jgriffith | xyang1: wondered if I could pick your brain on your use of iniitator mappings | 23:10 |
xyang1 | jgriffith: Sure | 23:11 |
jgriffith | xyang1: so the idea is like an access group no? | 23:11 |
*** erlon has quit IRC | 23:11 | |
jgriffith | xyang1: so you can say "these hosts/initiators" have access and use that instead of chap | 23:11 |
jgriffith | xyang1: and the auto-add thing just looks at connect info and sets up the access group automagically | 23:11 |
xyang1 | jgriffith: You'll have to add them on array in our case | 23:12 |
xyang1 | jgriffith: It is not automatic | 23:12 |
jgriffith | ahh... ok but other than that the basic principal is the same? | 23:12 |
jgriffith | so admin setup up the groups on the array | 23:12 |
*** annashen has joined #openstack-cinder | 23:13 | |
xyang1 | jgriffith: Ya, something like that | 23:13 |
jgriffith | xyang1: so what i was wondering is..... a number of products have this sort of thing I think | 23:13 |
jgriffith | LIO, zfs etc | 23:13 |
jgriffith | and I noticed yours is a nice generic term | 23:13 |
jgriffith | was thinking of using it rather than introducing yet another one | 23:14 |
*** BharatK has quit IRC | 23:14 | |
jgriffith | but I just realized it's explicitly in the emc section | 23:14 |
xyang1 | jgriffith: Oh, you are talking about anto zoning | 23:14 |
jgriffith | yeah | 23:14 |
jgriffith | :) | 23:14 |
jgriffith | sorry | 23:14 |
xyang1 | jgriffith: Np:) | 23:15 |
xyang1 | jgriffith: So this is for your FC driver? | 23:15 |
jgriffith | xyang1: well, it can work for FC or iSCSI | 23:15 |
*** _cjones_ has joined #openstack-cinder | 23:15 | |
jgriffith | so the idea is instead of chap you can add a list of initiator IQN's or WWNN's | 23:16 |
xyang1 | jgriffith: ok | 23:16 |
jgriffith | we call it an access group | 23:16 |
xyang1 | jgriffith: So you want to combine them into one | 23:16 |
jgriffith | then you can add volumes to that access group and those initiators will be able to "see" the volumes in that group | 23:16 |
patrickeast | interesting, we have kind of the same concept but still do chap for the “host” that may have iqn’s/wwn’s on it | 23:16 |
jgriffith | xyang1: well I was thinking about it... but I'm not sure it matters | 23:16 |
jgriffith | xyang1: patrickeast yeah, I think there are similar concepts among a few of us | 23:17 |
patrickeast | i setup our driver to create them automatically though | 23:17 |
jgriffith | I hate to introduce sf specific conf options | 23:17 |
patrickeast | i think the juno release they had to be setup beforehand on the array | 23:17 |
xyang1 | jgriffith: So the FC one goes thru lookup service | 23:17 |
jgriffith | patrickeast: yeah, I was thinking about doing that as well, but then I thought... maybe someobdy would want this for tenant isolation across compute nodes? | 23:18 |
xyang1 | jgriffith: That is specific to FC though | 23:18 |
jgriffith | I dunno | 23:18 |
jgriffith | xyang1: yeah, looking at that code now.... seems like it is a bit different than I thought | 23:18 |
jgriffith | or at least than what I'm doing | 23:18 |
xyang1 | jgriffith: patrickeast only has iscsi | 23:18 |
jgriffith | maybe the config option thing is just a pet peave of mine and isn't a big deal | 23:18 |
patrickeast | the biggest reason we went for auto creation was the immediate complaints about adding dozens of iqn’s wwn’s manually | 23:19 |
jgriffith | it's almost worse I guess to have a bilion options in the base driver :) | 23:19 |
patrickeast | i’ll be adding FC in L | 23:19 |
jgriffith | patrickeast: yeah, I could see the objection to overhead you mention above | 23:19 |
xyang1 | jgriffith: I haven't looked at that in pure driver | 23:19 |
jgriffith | xyang1: patrickeast ok, maybe I'll just mess with a few things first | 23:20 |
xyang1 | jgriffith: patrickeast will be intreresting to see how pure implement FC | 23:20 |
jgriffith | then figure out if there's value in common config options | 23:20 |
jgriffith | xyang1: patrickeast thanks for the info | 23:20 |
xyang1 | jgriffith: Sure, common config options are good | 23:20 |
jgriffith | xyang1: yeah... our list is growing :) | 23:20 |
xyang1 | jgriffith: Yes:) | 23:21 |
patrickeast | xyang1: hehe yea i haven’t really looked into it yet… need to figure out how to do it | 23:21 |
patrickeast | jgriffith: np | 23:21 |
jungleboyj | Anyone know why grenade is failing for Kilo right now? | 23:29 |
*** Apoorva has quit IRC | 23:30 | |
*** david-lyle is now known as david-lyle_afk | 23:33 | |
jgriffith | jungleboyj: got a recent fail log handy? | 23:37 |
jgriffith | jungleboyj: not seeing anything in gerrit the past day or so | 23:37 |
jgriffith | jungleboyj: guess not | 23:48 |
*** chlong has joined #openstack-cinder | 23:55 | |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Fix exception logging https://review.openstack.org/163231 | 23:58 |
openstackgerrit | Vilobh Meshram proposed openstack/cinder: Quota Objects https://review.openstack.org/163232 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!