| *** dims has quit IRC | 00:00 | |
| *** markvoelker has joined #openstack-cinder | 00:02 | |
| *** jcru has joined #openstack-cinder | 00:04 | |
| *** jcru has quit IRC | 00:04 | |
| *** _cjones_ has quit IRC | 00:07 | |
| *** thingee has joined #openstack-cinder | 00:08 | |
| *** annashen has quit IRC | 00:13 | |
| *** annegentle has quit IRC | 00:14 | |
| *** emagana has quit IRC | 00:14 | |
| *** _cjones_ has joined #openstack-cinder | 00:17 | |
| *** ho has joined #openstack-cinder | 00:19 | |
| *** melwitt has quit IRC | 00:19 | |
| *** e0ne has quit IRC | 00:23 | |
| *** thingee has quit IRC | 00:31 | |
| *** _cjones_ has quit IRC | 00:31 | |
| *** tsekiyama has joined #openstack-cinder | 00:32 | |
| *** asselin_ has quit IRC | 00:36 | |
| *** Mandell has quit IRC | 00:37 | |
| openstackgerrit | Vilobh Meshram proposed openstack/cinder: WIP - ConsistencyGroup Object https://review.openstack.org/163641 | 00:43 |
|---|---|---|
| *** appsdesh has quit IRC | 00:43 | |
| *** dflorea has quit IRC | 00:44 | |
| *** dflorea has joined #openstack-cinder | 00:45 | |
| *** lpetrut has joined #openstack-cinder | 00:46 | |
| *** dflorea has quit IRC | 00:49 | |
| *** lpetrut has quit IRC | 00:50 | |
| *** coolsvap|afk is now known as coolsvap | 00:50 | |
| *** Longgeek has joined #openstack-cinder | 00:51 | |
| *** asselin_ has joined #openstack-cinder | 00:53 | |
| *** tsekiyam_ has joined #openstack-cinder | 00:56 | |
| *** tsekiyama has quit IRC | 00:57 | |
| *** leeantho has quit IRC | 00:59 | |
| *** vilobhmm1 has quit IRC | 01:01 | |
| *** topshare has joined #openstack-cinder | 01:02 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/cinder: Use oslo_context's overwrite capability for better logs https://review.openstack.org/167064 | 01:02 |
| *** akerr has joined #openstack-cinder | 01:03 | |
| *** jwang_ has joined #openstack-cinder | 01:06 | |
| *** akerr has quit IRC | 01:07 | |
| *** jwang__ has quit IRC | 01:09 | |
| *** mtanino has joined #openstack-cinder | 01:09 | |
| *** emagana has joined #openstack-cinder | 01:11 | |
| *** dannywilson has quit IRC | 01:12 | |
| *** annashen has joined #openstack-cinder | 01:13 | |
| *** annegentle has joined #openstack-cinder | 01:14 | |
| *** marcusvrn has joined #openstack-cinder | 01:15 | |
| *** liusheng has quit IRC | 01:16 | |
| *** emagana has quit IRC | 01:17 | |
| *** emagana has joined #openstack-cinder | 01:18 | |
| *** annashen has quit IRC | 01:19 | |
| *** akerr has joined #openstack-cinder | 01:20 | |
| *** annegentle has quit IRC | 01:20 | |
| *** emagana has quit IRC | 01:23 | |
| *** topshare_ has joined #openstack-cinder | 01:24 | |
| *** junhongl has joined #openstack-cinder | 01:24 | |
| *** Lee1092 has joined #openstack-cinder | 01:26 | |
| *** topshare has quit IRC | 01:26 | |
| *** junhongl has quit IRC | 01:30 | |
| *** tsekiyam_ has quit IRC | 01:30 | |
| *** mtanino has quit IRC | 01:32 | |
| *** junhongl has joined #openstack-cinder | 01:32 | |
| *** gary-smith__ has quit IRC | 01:37 | |
| *** junhongl has quit IRC | 01:38 | |
| *** marcusvrn has quit IRC | 01:40 | |
| *** marcusvrn has joined #openstack-cinder | 01:40 | |
| *** dims has joined #openstack-cinder | 01:44 | |
| *** dims_ has quit IRC | 01:46 | |
| *** akerr has quit IRC | 01:47 | |
| *** marcusvrn has quit IRC | 01:50 | |
| *** jcru has joined #openstack-cinder | 01:50 | |
| *** jcru has quit IRC | 01:51 | |
| *** mriedem1 has quit IRC | 01:51 | |
| *** marcusvrn1 has joined #openstack-cinder | 01:51 | |
| *** vilobhmm1 has joined #openstack-cinder | 01:53 | |
| *** marcusvrn1 has quit IRC | 01:56 | |
| *** jcru has joined #openstack-cinder | 01:56 | |
| *** hflai_ has quit IRC | 01:59 | |
| *** takedakn has joined #openstack-cinder | 01:59 | |
| *** marcusvrn has joined #openstack-cinder | 01:59 | |
| *** r-daneel has quit IRC | 02:02 | |
| *** _cjones_ has joined #openstack-cinder | 02:04 | |
| *** _cjones_ has joined #openstack-cinder | 02:05 | |
| *** marcusvrn1 has joined #openstack-cinder | 02:06 | |
| *** marcusvrn has quit IRC | 02:08 | |
| *** takedakn has quit IRC | 02:11 | |
| *** marcusvrn1 has quit IRC | 02:11 | |
| *** annegentle has joined #openstack-cinder | 02:16 | |
| *** junhongl has joined #openstack-cinder | 02:21 | |
| *** annegentle has quit IRC | 02:21 | |
| *** scottda has joined #openstack-cinder | 02:23 | |
| *** topshare_ has quit IRC | 02:25 | |
| *** kaisers1 has joined #openstack-cinder | 02:26 | |
| *** topshare has joined #openstack-cinder | 02:27 | |
| *** kaisers has quit IRC | 02:28 | |
| *** haomaiwang has joined #openstack-cinder | 02:28 | |
| *** IanGovett has quit IRC | 02:29 | |
| *** junhongl has quit IRC | 02:29 | |
| *** Maike has quit IRC | 02:33 | |
| *** Maike has joined #openstack-cinder | 02:33 | |
| *** topshare has quit IRC | 02:38 | |
| *** topshare has joined #openstack-cinder | 02:41 | |
| *** topshare has quit IRC | 02:43 | |
| *** hemna has joined #openstack-cinder | 02:43 | |
| *** scottda has quit IRC | 02:46 | |
| *** dims has quit IRC | 02:51 | |
| *** patrickeast has quit IRC | 02:56 | |
| *** junhongl has joined #openstack-cinder | 03:07 | |
| anish | hemna: are you still -1 on this ? https://review.openstack.org/#/c/158926/ | 03:08 |
| hemna | let me check | 03:08 |
| hemna | I dunno man | 03:09 |
| hemna | maybe I'm too hard on the milestones and such | 03:09 |
| hemna | it's not a bug | 03:10 |
| hemna | it's just a nice to have | 03:10 |
| anish | yes. hence code_cleanup_batching | 03:10 |
| hemna | I'd rather not see a lot of churn now unless it's fixing a problem | 03:10 |
| anish | unless code_cleanup is not meant for k3 | 03:10 |
| hemna | I think we are in bugs only at this point | 03:10 |
| openstackgerrit | John Griffith proposed openstack/cinder: Enable request-id in cinder API logs https://review.openstack.org/167080 | 03:10 |
| hemna | if you can get thingee to +2 it, then I'll +A it | 03:11 |
| hemna | but at this point I have to defer to thingee | 03:11 |
| anish | aite. this should fun | 03:11 |
| hemna | it looks minor | 03:11 |
| *** junhongl has quit IRC | 03:11 | |
| *** jcru has quit IRC | 03:13 | |
| *** marcusvrn has joined #openstack-cinder | 03:13 | |
| asselin_ | jgriffith, sorry, just saw your ping now (home computer). Officially infra wants to run all all rechecks, so they want to run on all rechecks. | 03:15 |
| asselin_ | jgriffith, so recheck should recheck everything, and that's ok. recheck <vendor> is only really used for those with limited resources | 03:16 |
| asselin_ | but infra runs on that query as well (and any other ci with enough resources) | 03:17 |
| asselin_ | jgriffith, it's a topic of big debate as you can imagine. I'll have to find some links with discussion on this topic. | 03:17 |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient: Move unit tests into test directory https://review.openstack.org/162230 | 03:20 |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient: Add ability to specify path var to testr https://review.openstack.org/162262 | 03:20 |
| *** Longgeek_ has joined #openstack-cinder | 03:22 | |
| *** jcru has joined #openstack-cinder | 03:24 | |
| *** Longgeek has quit IRC | 03:25 | |
| *** _cjones_ has quit IRC | 03:26 | |
| *** bkopilov has quit IRC | 03:29 | |
| *** _cjones_ has joined #openstack-cinder | 03:30 | |
| *** hemna has quit IRC | 03:37 | |
| *** topshare has joined #openstack-cinder | 03:39 | |
| *** jcru has quit IRC | 03:42 | |
| *** topshare has quit IRC | 03:43 | |
| *** jcru has joined #openstack-cinder | 03:43 | |
| *** _cjones_ has quit IRC | 03:44 | |
| *** _cjones_ has joined #openstack-cinder | 03:45 | |
| *** _cjones_ has quit IRC | 03:45 | |
| *** topshare has joined #openstack-cinder | 03:48 | |
| *** jcru has quit IRC | 03:48 | |
| openstackgerrit | Ankit Agrawal proposed openstack/cinder: Fix missing translations for log messages https://review.openstack.org/164697 | 03:50 |
| *** topshare has quit IRC | 03:50 | |
| *** Mandell has joined #openstack-cinder | 03:55 | |
| *** _cjones_ has joined #openstack-cinder | 03:58 | |
| *** dims has joined #openstack-cinder | 04:12 | |
| *** dannywilson has joined #openstack-cinder | 04:12 | |
| *** dannywilson has quit IRC | 04:17 | |
| *** annegentle has joined #openstack-cinder | 04:18 | |
| *** dims has quit IRC | 04:19 | |
| *** annegentle has quit IRC | 04:23 | |
| *** primechuck has joined #openstack-cinder | 04:26 | |
| *** primechuck has quit IRC | 04:31 | |
| *** primechuck has joined #openstack-cinder | 04:31 | |
| *** xyang1 has quit IRC | 04:35 | |
| *** junhongl has joined #openstack-cinder | 04:39 | |
| *** xyang1 has joined #openstack-cinder | 04:41 | |
| *** xyang1 has quit IRC | 04:43 | |
| *** coolsvap is now known as coolsvap|afk | 04:44 | |
| *** junhongl has quit IRC | 04:44 | |
| *** avishay has joined #openstack-cinder | 04:47 | |
| *** ishant has joined #openstack-cinder | 04:48 | |
| *** bkopilov has joined #openstack-cinder | 04:57 | |
| *** hflai_ has joined #openstack-cinder | 05:02 | |
| *** hflai_ has quit IRC | 05:02 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Delete the temporary volume if migration fails https://review.openstack.org/160682 | 05:12 |
| *** junhongl has joined #openstack-cinder | 05:18 | |
| *** annegentle has joined #openstack-cinder | 05:19 | |
| *** shilpa_ has joined #openstack-cinder | 05:19 | |
| *** harlowja is now known as harlowja_away | 05:22 | |
| *** anshul has joined #openstack-cinder | 05:23 | |
| *** annegentle has quit IRC | 05:23 | |
| *** junhongl has quit IRC | 05:23 | |
| *** reed has quit IRC | 05:26 | |
| *** boris-42 has quit IRC | 05:28 | |
| *** BharatK has joined #openstack-cinder | 05:32 | |
| *** junhongl has joined #openstack-cinder | 05:36 | |
| *** junhongl has quit IRC | 05:41 | |
| *** primechuck has quit IRC | 05:43 | |
| *** emagana has joined #openstack-cinder | 05:45 | |
| *** jcru has joined #openstack-cinder | 05:45 | |
| *** jcru has quit IRC | 05:50 | |
| *** nshaikh has joined #openstack-cinder | 05:58 | |
| *** Maike has quit IRC | 06:03 | |
| *** dims has joined #openstack-cinder | 06:04 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex https://review.openstack.org/152401 | 06:07 |
| *** dims has quit IRC | 06:10 | |
| *** annashen has joined #openstack-cinder | 06:18 | |
| *** _cjones_ has quit IRC | 06:20 | |
| *** annashen has quit IRC | 06:24 | |
| *** ankit_ag has joined #openstack-cinder | 06:27 | |
| *** junhongl has joined #openstack-cinder | 06:33 | |
| *** vilobhmm1 has quit IRC | 06:34 | |
| *** nkrinner has joined #openstack-cinder | 06:35 | |
| *** deepakcs has joined #openstack-cinder | 06:36 | |
| *** pcaruana has quit IRC | 06:41 | |
| *** chlong has quit IRC | 06:42 | |
| *** anuragpalsule has joined #openstack-cinder | 06:46 | |
| *** _cjones_ has joined #openstack-cinder | 06:47 | |
| *** dulek_ has joined #openstack-cinder | 06:55 | |
| *** dulek_ is now known as dulek | 06:55 | |
| *** Bsony has joined #openstack-cinder | 06:57 | |
| *** dulek_ has joined #openstack-cinder | 07:01 | |
| *** chlong has joined #openstack-cinder | 07:03 | |
| *** dulek has quit IRC | 07:04 | |
| *** _cjones_ has quit IRC | 07:13 | |
| *** _cjones_ has joined #openstack-cinder | 07:18 | |
| *** annegentle has joined #openstack-cinder | 07:20 | |
| *** emagana has quit IRC | 07:22 | |
| *** emagana has joined #openstack-cinder | 07:22 | |
| *** annegentle has quit IRC | 07:25 | |
| *** emagana has quit IRC | 07:27 | |
| flip214 | asselin: ping? | 07:27 |
| *** navid__ has joined #openstack-cinder | 07:38 | |
| *** dulek_ has quit IRC | 07:43 | |
| *** dulek has joined #openstack-cinder | 07:43 | |
| *** ronis has joined #openstack-cinder | 07:48 | |
| *** alecv has joined #openstack-cinder | 07:49 | |
| *** dims has joined #openstack-cinder | 07:55 | |
| *** markus_z has joined #openstack-cinder | 07:56 | |
| *** TobiasE has joined #openstack-cinder | 07:57 | |
| *** Longgeek_ has quit IRC | 07:58 | |
| *** nshaikh has quit IRC | 07:59 | |
| *** navid__ has quit IRC | 07:59 | |
| *** nshaikh has joined #openstack-cinder | 08:00 | |
| *** dims has quit IRC | 08:02 | |
| *** jordanP has joined #openstack-cinder | 08:07 | |
| *** liusheng has joined #openstack-cinder | 08:10 | |
| *** chlong has quit IRC | 08:12 | |
| *** _cjones_ has quit IRC | 08:15 | |
| *** annegentle has joined #openstack-cinder | 08:21 | |
| *** annegentle has quit IRC | 08:26 | |
| *** ndipanov has joined #openstack-cinder | 08:28 | |
| *** tellesnobrega has quit IRC | 08:28 | |
| *** nlevinki has joined #openstack-cinder | 08:35 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Set volume_attachment to [] for the temporary volume creation https://review.openstack.org/167134 | 08:39 |
| *** tellesnobrega has joined #openstack-cinder | 08:40 | |
| *** Bsony has quit IRC | 08:41 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Set volume_attachment to [] for the temporary volume creation https://review.openstack.org/167134 | 08:44 |
| *** liusheng has quit IRC | 08:52 | |
| *** avishay_ has joined #openstack-cinder | 09:01 | |
| *** sgotliv has joined #openstack-cinder | 09:01 | |
| *** avishay has quit IRC | 09:02 | |
| *** jistr has joined #openstack-cinder | 09:04 | |
| *** dims has joined #openstack-cinder | 09:15 | |
| *** _cjones_ has joined #openstack-cinder | 09:16 | |
| *** dims has quit IRC | 09:20 | |
| *** _cjones_ has quit IRC | 09:20 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Set volume_attachment to [] for the temporary volume creation https://review.openstack.org/167134 | 09:21 |
| openstackgerrit | Ankit Agrawal proposed openstack/cinder: Fix missing translations for log messages https://review.openstack.org/164697 | 09:21 |
| *** e0ne has joined #openstack-cinder | 09:31 | |
| *** nshaikh has quit IRC | 09:31 | |
| *** yuriy_n17 has joined #openstack-cinder | 09:32 | |
| *** jcru has joined #openstack-cinder | 09:37 | |
| *** Bsony has joined #openstack-cinder | 09:38 | |
| *** jcru has quit IRC | 09:38 | |
| *** e0ne has quit IRC | 09:40 | |
| *** lpetrut has joined #openstack-cinder | 09:40 | |
| *** TobiasE has quit IRC | 09:59 | |
| *** nshaikh has joined #openstack-cinder | 09:59 | |
| *** nshaikh has quit IRC | 09:59 | |
| openstackgerrit | Martin Kletzander proposed openstack/cinder: Fix common misspellings https://review.openstack.org/166823 | 10:01 |
| *** marcusvrn has quit IRC | 10:01 | |
| *** nshaikh has joined #openstack-cinder | 10:10 | |
| *** _cjones_ has joined #openstack-cinder | 10:17 | |
| *** btran has quit IRC | 10:19 | |
| *** dims has joined #openstack-cinder | 10:19 | |
| *** haomaiwang has quit IRC | 10:21 | |
| *** _cjones_ has quit IRC | 10:22 | |
| *** markvoelker has quit IRC | 10:26 | |
| *** e0ne has joined #openstack-cinder | 10:29 | |
| *** Bsony_ has joined #openstack-cinder | 10:34 | |
| *** Bsony has quit IRC | 10:35 | |
| *** Bsony has joined #openstack-cinder | 10:46 | |
| *** Bsony has quit IRC | 10:47 | |
| *** Bsony_ has quit IRC | 10:48 | |
| *** Bsony has joined #openstack-cinder | 10:52 | |
| *** ho has quit IRC | 10:57 | |
| *** Bsony_ has joined #openstack-cinder | 10:57 | |
| *** TobiasE has joined #openstack-cinder | 10:58 | |
| *** Bsony has quit IRC | 10:59 | |
| *** timcl has joined #openstack-cinder | 11:00 | |
| *** Bsony_ has quit IRC | 11:02 | |
| *** Bsony has joined #openstack-cinder | 11:05 | |
| *** e0ne is now known as e0ne_ | 11:09 | |
| *** Bsony_ has joined #openstack-cinder | 11:13 | |
| *** Bsony has quit IRC | 11:16 | |
| *** Bsony_ has quit IRC | 11:18 | |
| *** _cjones_ has joined #openstack-cinder | 11:18 | |
| *** e0ne_ has quit IRC | 11:19 | |
| *** e0ne has joined #openstack-cinder | 11:20 | |
| *** _cjones_ has quit IRC | 11:23 | |
| *** annashen has joined #openstack-cinder | 11:23 | |
| *** IanGovett has joined #openstack-cinder | 11:24 | |
| *** markvoelker has joined #openstack-cinder | 11:26 | |
| *** delattec has quit IRC | 11:28 | |
| *** cdelatte has quit IRC | 11:28 | |
| *** annashen has quit IRC | 11:28 | |
| *** Bsony has joined #openstack-cinder | 11:31 | |
| *** markvoelker has quit IRC | 11:31 | |
| *** Bsony has quit IRC | 11:36 | |
| *** e0ne is now known as e0ne_ | 11:36 | |
| *** jamielennox is now known as jamielennox|away | 11:45 | |
| *** e0ne_ has quit IRC | 11:46 | |
| *** ociuhandu has joined #openstack-cinder | 11:47 | |
| openstackgerrit | Yasuaki Nagata proposed openstack/cinder: Do 'detach' if a timeout happened in the process of attach_volume https://review.openstack.org/167185 | 11:48 |
| *** e0ne has joined #openstack-cinder | 11:53 | |
| *** dulek_ has joined #openstack-cinder | 11:55 | |
| *** ronis has quit IRC | 11:55 | |
| *** ronis has joined #openstack-cinder | 11:55 | |
| *** dalgaaf has quit IRC | 11:57 | |
| *** dulek has quit IRC | 11:58 | |
| *** markvoelker has joined #openstack-cinder | 11:58 | |
| *** cdelatte has joined #openstack-cinder | 12:03 | |
| *** dulek_ has quit IRC | 12:04 | |
| *** jaypipes has quit IRC | 12:06 | |
| dims | jgriffith: ping looks like i ended up dup'ing what you had https://review.openstack.org/#/c/167064/ https://review.openstack.org/#/c/167080/ - so with either of those changes, is logging any better? (cc jogo) | 12:06 |
| *** jaypipes has joined #openstack-cinder | 12:07 | |
| *** boris-42 has joined #openstack-cinder | 12:07 | |
| *** Bsony has joined #openstack-cinder | 12:09 | |
| *** chlong has joined #openstack-cinder | 12:12 | |
| *** akerr has joined #openstack-cinder | 12:14 | |
| *** BharatK has quit IRC | 12:14 | |
| *** chlong has quit IRC | 12:15 | |
| *** dims has quit IRC | 12:15 | |
| *** dims has joined #openstack-cinder | 12:16 | |
| *** _cjones_ has joined #openstack-cinder | 12:19 | |
| *** Bsony has quit IRC | 12:20 | |
| *** _cjones_ has quit IRC | 12:23 | |
| *** shilpa_ has quit IRC | 12:25 | |
| *** deepakcs has quit IRC | 12:26 | |
| *** dulek has joined #openstack-cinder | 12:30 | |
| *** jistr is now known as jistr|class | 12:30 | |
| *** chlong has joined #openstack-cinder | 12:32 | |
| *** chlong has quit IRC | 12:35 | |
| *** ishant has quit IRC | 12:36 | |
| *** chlong has joined #openstack-cinder | 12:36 | |
| *** rushiagr_away is now known as rushiagr | 12:37 | |
| *** chlong has quit IRC | 12:39 | |
| *** Miouge has joined #openstack-cinder | 12:44 | |
| *** chlong has joined #openstack-cinder | 12:56 | |
| *** rushiagr is now known as rushiagr_away | 13:00 | |
| *** scottda has joined #openstack-cinder | 13:01 | |
| *** julim has joined #openstack-cinder | 13:01 | |
| *** scottda has quit IRC | 13:02 | |
| *** scottda has joined #openstack-cinder | 13:03 | |
| *** Miouge has quit IRC | 13:04 | |
| *** Miouge has joined #openstack-cinder | 13:05 | |
| *** Miouge has quit IRC | 13:05 | |
| *** changbl has quit IRC | 13:06 | |
| jgriffith | dims: haven't looked at yours yet, but the change I pused last nigt fixed it up | 13:12 |
| dims | jgriffith: i had the same thing as yours :) | 13:12 |
| jgriffith | dims: haha, I see | 13:12 |
| jgriffith | dims: and it looks like Angus did the same ting in Heat | 13:13 |
| jgriffith | dims: We must be on to something :) | 13:13 |
| *** diegows has joined #openstack-cinder | 13:13 | |
| dims | we should write this down :) | 13:13 |
| jgriffith | dims: probably | 13:13 |
| jgriffith | dims: it's things like this that I find so annoying | 13:13 |
| jgriffith | e0ne: I'm confused by your comment... I did remove cinder/openstack/common/local ? | 13:14 |
| jgriffith | e0ne: OH you mean the conf entry | 13:15 |
| e0ne | jgriffith: hi! | 13:15 |
| e0ne | jgriffith: yes, it should be removed from openstack-common.conf too | 13:15 |
| e0ne | i'm almost ready with patch | 13:15 |
| *** dustins has joined #openstack-cinder | 13:16 | |
| *** eharney has quit IRC | 13:16 | |
| e0ne | jgriffith: i can update yours patch in 3minutes | 13:16 |
| jgriffith | e0ne: why not, everyone else does | 13:17 |
| *** Yogi1 has joined #openstack-cinder | 13:18 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Enable request-id in cinder API logs https://review.openstack.org/167080 | 13:20 |
| *** _cjones_ has joined #openstack-cinder | 13:20 | |
| e0ne | done | 13:20 |
| avishay_ | jgriffith: what's your address? i want to send you a box of these: http://www.photo4design.com/files/165/82494-tilted-keyboard-key-letter-h.jpg | 13:23 |
| *** avishay_ is now known as avishay | 13:23 | |
| e0ne | :) | 13:23 |
| *** _cjones_ has quit IRC | 13:25 | |
| dims | jgriffith: does this sound about right? https://etherpad.openstack.org/p/help-cant-find-request-id-in-my-logs | 13:26 |
| *** lpetrut has quit IRC | 13:26 | |
| dims | haha "everyone else does" | 13:26 |
| * dims rushes to find one of john's patches | 13:26 | |
| e0ne | dims: need to add notes about openstack/common/local.py | 13:27 |
| dims | e0ne: go for it? :) | 13:27 |
| *** timcl has quit IRC | 13:27 | |
| *** lpetrut has joined #openstack-cinder | 13:27 | |
| e0ne | dims: done | 13:28 |
| e0ne | dims: may be it's a good idea to move #10 to the first place? :) | 13:29 |
| dims | e0ne: haha | 13:29 |
| jgriffith | dims: nice! | 13:32 |
| jgriffith | avishay: LOL!! | 13:32 |
| jgriffith | avishay: ya know I still haven't replaced this sucker! | 13:32 |
| *** timcl has joined #openstack-cinder | 13:33 | |
| *** rushiagr_away is now known as rushiagr | 13:33 | |
| *** Bsony has joined #openstack-cinder | 13:35 | |
| ankit_ag | Hi all, can someone please review https://review.openstack.org/#/c/165057/ | 13:38 |
| *** primechuck has joined #openstack-cinder | 13:39 | |
| openstackgerrit | wuyuting proposed openstack/cinder: Make backup-list support all-tenants options https://review.openstack.org/166727 | 13:41 |
| *** mriedem has joined #openstack-cinder | 13:44 | |
| *** r-daneel has joined #openstack-cinder | 13:44 | |
| *** mtanino has joined #openstack-cinder | 13:46 | |
| *** jcru has joined #openstack-cinder | 13:47 | |
| *** anuragpalsule has left #openstack-cinder | 13:48 | |
| *** nshaikh has quit IRC | 13:48 | |
| *** jcru has quit IRC | 13:49 | |
| *** jcru has joined #openstack-cinder | 13:50 | |
| *** jistr|class is now known as jistr | 13:53 | |
| openstackgerrit | Tushar Patil proposed openstack/python-cinderclient: Allow cinderclient to handle exception response https://review.openstack.org/166351 | 13:53 |
| openstackgerrit | Petrut Lucian proposed openstack/cinder: Windows iSCSI: fix volume clone https://review.openstack.org/167228 | 13:54 |
| *** thangp has joined #openstack-cinder | 13:59 | |
| *** obutenko has quit IRC | 13:59 | |
| *** Adriano_ has joined #openstack-cinder | 14:00 | |
| *** obutenko has joined #openstack-cinder | 14:02 | |
| openstackgerrit | wuyuting proposed openstack/cinder: Add filtering snapshots by tenant ID https://review.openstack.org/166689 | 14:03 |
| *** mriedem has quit IRC | 14:03 | |
| *** mriedem has joined #openstack-cinder | 14:03 | |
| *** julim has quit IRC | 14:03 | |
| *** eharney has joined #openstack-cinder | 14:03 | |
| *** lpetrut has quit IRC | 14:03 | |
| *** obutenko has quit IRC | 14:05 | |
| *** porrua has joined #openstack-cinder | 14:06 | |
| *** julim has joined #openstack-cinder | 14:06 | |
| *** timcl has quit IRC | 14:07 | |
| *** zhipeng has joined #openstack-cinder | 14:07 | |
| *** tshefi has joined #openstack-cinder | 14:12 | |
| *** ank2090 has quit IRC | 14:13 | |
| *** Yogi11 has joined #openstack-cinder | 14:13 | |
| *** dustins_ has joined #openstack-cinder | 14:13 | |
| *** thingee has joined #openstack-cinder | 14:14 | |
| *** dustins has quit IRC | 14:16 | |
| *** Yogi1 has quit IRC | 14:16 | |
| *** git-harry has quit IRC | 14:21 | |
| *** esker has joined #openstack-cinder | 14:21 | |
| *** git-harry has joined #openstack-cinder | 14:21 | |
| *** _cjones_ has joined #openstack-cinder | 14:21 | |
| *** esker has quit IRC | 14:22 | |
| *** lpetrut has joined #openstack-cinder | 14:24 | |
| *** _cjones_ has quit IRC | 14:25 | |
| *** annashen has joined #openstack-cinder | 14:26 | |
| *** liu has joined #openstack-cinder | 14:26 | |
| *** Mandell has quit IRC | 14:30 | |
| *** annashen has quit IRC | 14:30 | |
| *** e0ne is now known as e0ne_ | 14:31 | |
| *** git-harry has quit IRC | 14:31 | |
| kaisers1 | Q: Is there a defined process how bugfixes are prioritized currently? My CI found a bug in our driver and I've a (small and easy) fix for this. Since the CI keeps on reporting false negatives because of the bug, how can i bring this forward? Or simply shut up & wait? :-D | 14:36 |
| *** e0ne_ has quit IRC | 14:36 | |
| thingee | kaisers1: feel free to ping me with the bug and I can target it to the RC | 14:37 |
| thingee | I need to hop off, but still post it and I'll pick it up in the logs later. | 14:37 |
| kaisers1 | thingee: ok, thanks! | 14:37 |
| thingee | you're welcome | 14:37 |
| *** thingee has quit IRC | 14:37 | |
| kaisers1 | thingee: ping https://review.openstack.org/#/c/166224/ :) | 14:37 |
| *** git-harry has joined #openstack-cinder | 14:38 | |
| *** e0ne has joined #openstack-cinder | 14:38 | |
| *** crose has joined #openstack-cinder | 14:38 | |
| *** lpetrut has quit IRC | 14:38 | |
| openstackgerrit | Richard Hedlind proposed openstack/cinder: Properly remove host object from ISE https://review.openstack.org/166079 | 14:41 |
| *** reed has joined #openstack-cinder | 14:42 | |
| *** lpetrut has joined #openstack-cinder | 14:45 | |
| *** git-harry has quit IRC | 14:47 | |
| *** tsekiyama has joined #openstack-cinder | 14:47 | |
| *** git-harry has joined #openstack-cinder | 14:47 | |
| *** timcl has joined #openstack-cinder | 14:50 | |
| *** git-harry has quit IRC | 14:50 | |
| *** git-harry has joined #openstack-cinder | 14:50 | |
| *** EmilienM|PTO is now known as EmilienM | 14:51 | |
| *** annegentle has joined #openstack-cinder | 14:51 | |
| *** ankit_ag has quit IRC | 14:52 | |
| *** Yogi11 has quit IRC | 14:53 | |
| *** lpetrut has quit IRC | 14:54 | |
| *** hemnafk is now known as hemna | 14:55 | |
| DuncanT | kaisers1: Always worth pinging the channel (not just Mike) for such bugs, since any two cores can merge the fix | 14:57 |
| *** timcl has left #openstack-cinder | 15:00 | |
| *** git-harry has quit IRC | 15:00 | |
| *** git-harry has joined #openstack-cinder | 15:01 | |
| *** Yogi1 has joined #openstack-cinder | 15:01 | |
| kaisers1 | DuncanT: Yep. I asked in general and he told me to ping him in reply, that's why i addressed him. Will ping more general next time! :) | 15:02 |
| *** thingee has joined #openstack-cinder | 15:02 | |
| thingee | kaisers1: targeted | 15:03 |
| *** mriedem has quit IRC | 15:03 | |
| kaisers1 | thingee: yeeha! | 15:03 |
| *** mriedem has joined #openstack-cinder | 15:04 | |
| *** jaypipes has quit IRC | 15:05 | |
| thingee | and you're right DuncanT. I was just saying if I know what is a priority to people at some point I'm going to have an etherpad to help reviewers focus, just like I've done with the milestone bps | 15:05 |
| *** sgotliv has quit IRC | 15:06 | |
| DuncanT | kaisers1: Many of us nose at reviews pinged to specific people anyway, so as long as it happens on the channel you're probably ok. | 15:06 |
| kaisers1 | DuncanT: ok | 15:07 |
| thingee | DuncanT: what I love about kaisers1's review is a CI telling me that this patch works. :) | 15:10 |
| thingee | this is a beautiful thing | 15:10 |
| hemna | :) | 15:11 |
| avishay | CI is nice... i can go to a customer site and be rather sure that the driver works without having the storage to test against, rather than being ready to debug some random vendor driver | 15:11 |
| hemna | avishay, we'll just debug a random oslo bug instead. | 15:13 |
| avishay | hemna: when i have a product based on kilo in my hand, i know that everything will work on all drivers (well at least what's covered in the tests) | 15:14 |
| avishay | hemna: that's pretty friggin good | 15:14 |
| hemna | yah | 15:14 |
| *** lpetrut has joined #openstack-cinder | 15:19 | |
| *** wN has joined #openstack-cinder | 15:20 | |
| *** thingee has quit IRC | 15:20 | |
| *** nlevinki has quit IRC | 15:26 | |
| *** emagana has joined #openstack-cinder | 15:28 | |
| *** bkopilov has quit IRC | 15:31 | |
| *** jproulx has joined #openstack-cinder | 15:31 | |
| *** rushil_ has quit IRC | 15:32 | |
| jproulx | Hate to ask a usage question in a dev channel, but coming up empty elsewhere | 15:32 |
| jproulx | How do you apply a quota_class to a project? defining them is easy but can't find how to actually use them... | 15:32 |
| *** harlowja_at_home has joined #openstack-cinder | 15:32 | |
| *** annegentle has quit IRC | 15:33 | |
| *** dannywilson has joined #openstack-cinder | 15:35 | |
| *** markstur has quit IRC | 15:35 | |
| hemna | avishay, if you are still around, can you take a look at this one for me? https://review.openstack.org/#/c/167045/ | 15:36 |
| hemna | I'd like to get that in | 15:36 |
| *** nlevinki has joined #openstack-cinder | 15:41 | |
| avishay | hemna: how do we get to the point where detach is called on a volume with no attachments? | 15:42 |
| *** _cjones_ has joined #openstack-cinder | 15:42 | |
| hemna | avishay, tempest doing bad things | 15:42 |
| *** ronis has quit IRC | 15:42 | |
| avishay | is that something a user can do? | 15:43 |
| hemna | we had a tempest test yesterday that was calling detach on a volume it had already detached. | 15:43 |
| avishay | hemna: tempest calls manager directly, and not cinder-api? | 15:43 |
| hemna | there is nothing that prevents folks from calling the detach API in dumb ways | 15:43 |
| hemna | avishay, nah it goes through the API | 15:43 |
| *** annegentle has joined #openstack-cinder | 15:43 | |
| avishay | hemna: so there is a race and this makes the race smaller? | 15:44 |
| *** anshul has quit IRC | 15:44 | |
| hemna | not sure there is a race really | 15:44 |
| hemna | just being safe in the volume manager. | 15:44 |
| *** _cjones_ has quit IRC | 15:44 | |
| *** _cjones_ has joined #openstack-cinder | 15:44 | |
| avishay | hemna: don't we switch to detaching state, and not allow detach while in that state? | 15:44 |
| hemna | because someone can call the detach API multiple times for no reason. | 15:44 |
| hemna | this is way after the volume has been detached | 15:45 |
| hemna | and it's available again | 15:45 |
| avishay | hemna: this should all be checked atomically in the API, this patch is wrong IMO | 15:45 |
| avishay | sorry | 15:45 |
| hemna | well I can add that as well | 15:46 |
| *** changbl has joined #openstack-cinder | 15:46 | |
| hemna | I still think it's better to be safe here | 15:46 |
| *** asselin_ has quit IRC | 15:46 | |
| hemna | the API does no checks really. | 15:46 |
| avishay | so here still if two instances get to "elif len(attachments) == 1" at the same time, they will both try to detach the same attachment | 15:47 |
| hemna | other than if the volume exists. | 15:47 |
| avishay | hemna: that's the point of states, to avoid these things | 15:47 |
| hemna | that race can happen in the API as well though | 15:47 |
| avishay | hemna: otherwise we would have to double and triple check everything everywhere, and still have races, like we do here | 15:47 |
| *** appsdesh has joined #openstack-cinder | 15:47 | |
| avishay | hemna: not if you atomically update the state | 15:48 |
| avishay | hemna: if it atomically updates from 'in-use' to 'detaching', then it should be safe | 15:48 |
| hemna | there is no state checking in the API currently | 15:48 |
| hemna | that's a much bigger change | 15:48 |
| hemna | and kinda out of the scope of this small fix | 15:48 |
| avishay | hemna: don't you regret asking for my review? :) | 15:49 |
| hemna | hehe no | 15:49 |
| hemna | :P | 15:49 |
| *** bkopilov has joined #openstack-cinder | 15:49 | |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_actions.py#L122-L135 | 15:49 |
| hemna | that's the current API entry point for detach | 15:49 |
| hemna | no state checks at all. | 15:49 |
| avishay | hemna: https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L515 | 15:49 |
| hemna | only a simple, does the volume even exist | 15:50 |
| hemna | no | 15:50 |
| hemna | this is outside of that | 15:50 |
| *** lpetrut has quit IRC | 15:50 | |
| hemna | this is a direct call to detach | 15:50 |
| *** annegentle has quit IRC | 15:50 | |
| hemna | w/o calling begin detaching | 15:50 |
| avishay | hemna: well calling detach without begin_detaching is wrong i think | 15:50 |
| hemna | the touches on the PAIN of the Nova -> cinder coordination | 15:51 |
| hemna | which completely sucks IMHO | 15:51 |
| avishay | hemna: the test should model how nova attaches/detaches | 15:51 |
| hemna | this is true, but | 15:51 |
| hemna | we still need to be safe in cinder | 15:51 |
| hemna | because people do dumb things | 15:51 |
| hemna | anyway, I still think this patch is good as it is. | 15:51 |
| hemna | the bigger problem is 2 things really | 15:51 |
| avishay | the patch just turns a problem into a race | 15:52 |
| hemna | 1) the nova -> cinder API (Which we are going to talk about in Vancouver) | 15:52 |
| hemna | 2) the state management of volumes, which has been a topic forever :( | 15:52 |
| avishay | it will fail sporadically instead of consistently | 15:52 |
| *** lpetrut has joined #openstack-cinder | 15:52 | |
| *** Miouge has joined #openstack-cinder | 15:53 | |
| *** wN has left #openstack-cinder | 15:53 | |
| hemna | the only way to really fix that though | 15:53 |
| hemna | is to collapse begin_detaching and detach_volume into 1 | 15:54 |
| hemna | atomic action. | 15:54 |
| hemna | basically fixing part 1) of the issues I listed above | 15:54 |
| hemna | which isn't going to happen for K. | 15:54 |
| avishay | hemna: well that's a good thing to do for liberty, but for now, i would say fix the test | 15:54 |
| *** markus_z has quit IRC | 15:55 | |
| hemna | what do you suggest ? | 15:55 |
| avishay | hemna: have the test call the proper APIs | 15:57 |
| hemna | I already got the tempest test updated | 15:57 |
| hemna | to stop calling detach twice. | 15:57 |
| avishay | hemna: and maybe assert in the 'detach' API that we are in 'detaching' state | 15:57 |
| hemna | but the volume manager still needs to be safe in trying to pull the attachment out of the list. | 15:58 |
| *** rushiagr is now known as rushiagr_away | 15:58 | |
| hemna | https://review.openstack.org/#/c/165616 | 15:58 |
| hemna | that was the offending tempest test | 15:58 |
| hemna | it was shutting down the VMs (boot from cinder volume), and then calling detach directly after. | 15:59 |
| hemna | bleh | 15:59 |
| avishay | hemna: it's redundant. the fact that the volume was 'in-use' and went to 'detaching' must ensure that there is an attachment there waiting to be attached. | 15:59 |
| hemna | it was long after that was over though | 16:00 |
| hemna | it was available | 16:00 |
| hemna | and they called detach | 16:00 |
| avishay | hemna: are you going to check in every manager call that assumes 'available' that it has no attachments? | 16:00 |
| *** emagana has quit IRC | 16:00 | |
| avishay | the test is wrong, and i don't agree with adding code to the product to make tests run, it should be the other way around | 16:00 |
| hemna | no | 16:01 |
| hemna | the tests were wrong | 16:01 |
| hemna | and I had them fixed | 16:01 |
| hemna | I thought I covered that ? | 16:01 |
| *** jdurgin1 has joined #openstack-cinder | 16:01 | |
| hemna | all this does is ensure that if someone calls us incorrectly, that we give a meaningful error instead of raising an invalid index exception. | 16:01 |
| hemna | it doesn't solve anything else. | 16:02 |
| hemna | it isn't meant to. | 16:02 |
| *** dflorea has joined #openstack-cinder | 16:02 | |
| hemna | this patch can't fix the nova -> cinder api issues. | 16:02 |
| avishay | hemna: no, if they are calling detach without begin_detaching, it is wrong | 16:02 |
| hemna | *sigh* | 16:02 |
| hemna | ok nevermind. | 16:02 |
| hemna | I give up. | 16:02 |
| *** EmilienM is now known as EmilienM|PTO | 16:02 | |
| *** emagana has joined #openstack-cinder | 16:03 | |
| avishay | hemna: sorry, i just don't think it's right. others can override my decision of course. | 16:03 |
| hemna | I'm just not sure how many times I need to state the same thing. | 16:03 |
| hemna | <hemna> the tests were wrong | 16:03 |
| hemna | <hemna> and I had them fixed | 16:03 |
| hemna | <hemna> I thought I covered that ? | 16:03 |
| avishay | hemna: no, the tests were wrong and are still wrong | 16:04 |
| *** melwitt has joined #openstack-cinder | 16:04 | |
| smcginnis | hemna: I agree the change is a good protection. | 16:04 |
| * smcginnis dons flak jacket | 16:05 | |
| avishay | hemna: they need to call detach after begin_detaching | 16:05 |
| hemna | smcginnis, +1 | 16:05 |
| *** zhipeng has quit IRC | 16:05 | |
| avishay | hemna: otherwise, add checks in manager.py for everything that the API should check for | 16:05 |
| *** jistr has quit IRC | 16:05 | |
| avishay | hemna: you can't rely on state anymore. want to extend a volume? check that there are no attachments. want to attach with no multi-attach? check no attachments. | 16:06 |
| avishay | hemna: it will never end | 16:06 |
| *** markstur has joined #openstack-cinder | 16:06 | |
| avishay | hemna: that's why the API does checks and puts the volume into a state that says "the volume is in state foo, you can rely on that" | 16:06 |
| avishay | hemna: otherwise just reimplement all the checks in API in the manager | 16:07 |
| *** btran has joined #openstack-cinder | 16:08 | |
| avishay | hemna: all of those detach and attach APIs are a protocol with Nova and must be followed for correct behavior. if not, the test is wrong. | 16:08 |
| hemna | avishay, the API doesn't do checks. | 16:08 |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_actions.py#L122-L135 | 16:08 |
| hemna | there are no checks, other than the volume exists. | 16:08 |
| hemna | hence back to my original issue of 1) the nova -> cinder API is broken. | 16:09 |
| avishay | hemna: if the test would call the correct APIs (begin_detaching), checks would be called | 16:09 |
| hemna | and is out of the scope of this fix. | 16:09 |
| hemna | *sigh* | 16:09 |
| hemna | <hemna> <hemna> the tests were wrong | 16:09 |
| hemna | <hemna> <hemna> and I had them fixed | 16:09 |
| asselin | flip214, hi | 16:09 |
| avishay | hemna: dude do whatever you want, there is no way you can convince me that this fix is the correct solution | 16:09 |
| *** leeantho has joined #openstack-cinder | 16:09 | |
| eharney | if Cinder is throwing IndexError, i think we need to check enough to not do that regardless of what is supposed to happen... | 16:09 |
| avishay | hemna: it's just a hack to fix a bad test | 16:09 |
| hemna | it's not a solution, it's a messaging fix really. | 16:10 |
| hemna | the entire point of this patch is to raise a meaningful message | 16:10 |
| hemna | instead of throwing an invalid index error | 16:10 |
| hemna | which is completely useles. | 16:10 |
| hemna | even useless. | 16:10 |
| hemna | :P | 16:10 |
| avishay | we should never ever ever get to this point | 16:10 |
| hemna | correct | 16:10 |
| hemna | back to 1) | 16:10 |
| hemna | the nova -> cinder api is broken. | 16:10 |
| hemna | has been for ages | 16:10 |
| hemna | and is outside the scope of this patch. | 16:11 |
| *** harlowja_at_home has quit IRC | 16:11 | |
| hemna | there is a lot of cleanup I'd like to see happen for L | 16:12 |
| hemna | but I'm afraid that we won't get it done in time for the Nova feature freeze cutoff | 16:12 |
| hemna | and it probably breaks backwards compatibility. | 16:12 |
| hemna | Nova(Kilo) -> Cinder(Liberty) | 16:12 |
| hemna | bleh | 16:12 |
| *** jungleboyj has quit IRC | 16:13 | |
| avishay | hemna: OK, fine with me. Please just change the message to error instead of warning. | 16:13 |
| *** e0ne is now known as e0ne_ | 16:13 | |
| avishay | hemna: what a mess | 16:13 |
| hemna | yup | 16:13 |
| hemna | total mess | 16:13 |
| hemna | has been for a long time, which is why I've wanted to raise the subject of the nova -> cinder api | 16:13 |
| hemna | I'll update the warning -> error | 16:14 |
| avishay | hemna: the test is broken, but users can still call this directly i guess | 16:14 |
| *** kallebe has joined #openstack-cinder | 16:14 | |
| hemna | <hemna> <hemna> <hemna> the tests were wrong | 16:14 |
| hemna | <hemna> <hemna> <hemna> and I had them fixed | 16:14 |
| hemna | but yes, users can be dumb | 16:14 |
| avishay | hemna: thanks, please do it soon so i can +2 | 16:14 |
| jgriffith | hemna: I'm still kinda confused on this... sorry | 16:14 |
| hemna | ok, lets party | 16:14 |
| hemna | :P | 16:15 |
| avishay | hemna: again, i know you fixed the test to not call it twice, but any code that calls detach without begin_detach is wrong | 16:15 |
| jgriffith | hemna: I explicitly stated in the code you merged that this needed to handle the existing case | 16:15 |
| *** dulek has quit IRC | 16:15 | |
| jgriffith | hemna: also, the manager is the wrong place for this check | 16:15 |
| jgriffith | hemna: there should be an early check in cinder/volume/api | 16:15 |
| hemna | yah, I mentioned that I could add that | 16:15 |
| jgriffith | hemna: check the state of the volume... if it's available noop | 16:15 |
| hemna | the existing API didn't do any of those checks FWIW | 16:15 |
| jgriffith | hemna: it didn't need to | 16:16 |
| hemna | sure it did | 16:16 |
| hemna | for all the same problems | 16:16 |
| *** chlong has quit IRC | 16:16 | |
| hemna | someone could call it directly w/o calling begin_detaching | 16:16 |
| jgriffith | hemna: so I'm not looking to have a big debate here :) | 16:16 |
| jgriffith | hemna: I'm just saying the appropriate place to check this IMO is in the API | 16:16 |
| jgriffith | before you even get here | 16:16 |
| jgriffith | hemna: it's even fine/good to have both | 16:17 |
| hemna | that's fine, like I said I could add that | 16:17 |
| *** shilpa_ has joined #openstack-cinder | 16:17 | |
| jgriffith | hemna: but we shouldn't go past the API layer IMO | 16:17 |
| hemna | yah that's cool | 16:17 |
| hemna | I agree | 16:17 |
| jgriffith | hemna: awesome | 16:17 |
| hemna | I'm sorry | 16:17 |
| jgriffith | hemna: for? | 16:17 |
| hemna | I wasn't trying to argue against it | 16:17 |
| jgriffith | hemna: oh... LOL | 16:17 |
| *** melwitt has quit IRC | 16:17 | |
| jgriffith | no worries | 16:17 |
| jgriffith | hemna: I just know how much you hate that whole mechanism between nova and cinder | 16:18 |
| hemna | I was just trying to relay information about the fact that the API didn't do this already, when in fact it should have been. | 16:18 |
| jgriffith | hemna: you don't need to tell me again :) | 16:18 |
| hemna | hehe | 16:18 |
| hemna | :P | 16:18 |
| jgriffith | hemna: yeah, I thought there were some things in there... you're right they should've been | 16:18 |
| jgriffith | if they weren't... well then they weren't | 16:18 |
| *** thingee has joined #openstack-cinder | 16:18 | |
| jgriffith | we should look at Juno and open a bug if we don't do any checks | 16:19 |
| hemna | yah no big. | 16:19 |
| *** liu has quit IRC | 16:19 | |
| hemna | https://github.com/openstack/cinder/blob/stable/juno/cinder/api/contrib/volume_actions.py#L122-L131 | 16:19 |
| hemna | same thing in Juno | 16:19 |
| hemna | no checks really | 16:19 |
| hemna | other than the volume exists. | 16:19 |
| *** junhongl has quit IRC | 16:20 | |
| *** Miouge has quit IRC | 16:20 | |
| *** melwitt has joined #openstack-cinder | 16:20 | |
| jgriffith | hemna: http://goo.gl/bEk8IW | 16:20 |
| *** Miouge has joined #openstack-cinder | 16:20 | |
| hemna | yah that's assuming you call begin_detaching first | 16:20 |
| jgriffith | and http://goo.gl/DKwjSo | 16:21 |
| jgriffith | hemna: right | 16:21 |
| hemna | the problem is, that there is no guarantee that anyone does | 16:21 |
| jgriffith | hemna: I get ya | 16:21 |
| hemna | which the tempest tests weren't | 16:21 |
| *** Mandell has joined #openstack-cinder | 16:21 | |
| jgriffith | hemna: I'm just saying IMO those are the places we should have the check | 16:21 |
| hemna | agreed | 16:21 |
| jgriffith | hemna: 504 should have the same call | 16:21 |
| jgriffith | hemna: and we shouldn't monkey with extensions going directly to manager or anything goofy like that :) | 16:22 |
| jgriffith | hemna: if we are, we need to fix that up as well | 16:22 |
| hemna | so I was going to add the check in the volume_actions.py _detach | 16:22 |
| *** sgotliv has joined #openstack-cinder | 16:22 | |
| hemna | which is the entry point for detach | 16:22 |
| jgriffith | hemna: I'd prefer it be in volume/api personally | 16:22 |
| jgriffith | hemna: just because it's a more common point | 16:23 |
| avishay | jgriffith: +1 | 16:23 |
| hemna | ok that sounds good. | 16:23 |
| hemna | I'll do that then. | 16:23 |
| jgriffith | hemna: there can be other contrib/extensions etc that call detac | 16:23 |
| jgriffith | hemna: it's more to "manage" that way | 16:23 |
| hemna | ok gotcha | 16:23 |
| jgriffith | hemna: this way you just squash it in one place | 16:23 |
| hemna | yah I keep forgetting that other folks can drop in extensions as well | 16:24 |
| jgriffith | assuming we are sure to enforce that everything goes through api.py as it should | 16:24 |
| hemna | thanks | 16:24 |
| jgriffith | hemna: thank you! | 16:24 |
| hemna | thanks for the help guys | 16:24 |
| hemna | I have to run to a beating.... | 16:24 |
| hemna | I'll post an updated patch in a bit. | 16:24 |
| jgriffith | hemna: FWIW, the only thing that I see things under cinder/api/xxxx should ever go direct to anything is maybe driver extensions | 16:24 |
| *** bkopilov has quit IRC | 16:25 | |
| jgriffith | anyway... thanks for fixing that up | 16:25 |
| *** Miouge has quit IRC | 16:26 | |
| hemna | np | 16:26 |
| hemna | avishay, thanks for the help | 16:26 |
| avishay | hemna: sure, sorry for the "argument". this check should be an assert at best, and the test should call the proper apis, and and and and and and, but that's a lot of ands | 16:27 |
| *** e0ne_ is now known as e0ne | 16:27 | |
| avishay | hemna: so for now, i guess this is as good as it gets :) | 16:27 |
| *** Bsony has quit IRC | 16:30 | |
| *** Miouge has joined #openstack-cinder | 16:32 | |
| *** Adriano_ has quit IRC | 16:36 | |
| *** nkrinner has quit IRC | 16:37 | |
| *** annegentle has joined #openstack-cinder | 16:37 | |
| *** annegent_ has joined #openstack-cinder | 16:38 | |
| *** rushil has joined #openstack-cinder | 16:39 | |
| *** nlevinki has quit IRC | 16:39 | |
| *** jaypipes_ has joined #openstack-cinder | 16:41 | |
| *** junhongl has joined #openstack-cinder | 16:42 | |
| *** annegent_ has quit IRC | 16:42 | |
| *** annegentle has quit IRC | 16:43 | |
| *** leeantho has quit IRC | 16:47 | |
| *** TobiasE has quit IRC | 16:48 | |
| *** alecv has quit IRC | 16:49 | |
| *** shilpa_ has quit IRC | 16:57 | |
| *** dflorea has quit IRC | 16:59 | |
| *** dflorea has joined #openstack-cinder | 16:59 | |
| *** emagana has quit IRC | 17:02 | |
| *** dflorea has quit IRC | 17:04 | |
| *** dflorea has joined #openstack-cinder | 17:05 | |
| *** ronis has joined #openstack-cinder | 17:05 | |
| *** avishay has quit IRC | 17:06 | |
| *** thingee has quit IRC | 17:11 | |
| *** annegentle has joined #openstack-cinder | 17:14 | |
| *** Adriano_ has joined #openstack-cinder | 17:16 | |
| *** harlowja_away is now known as harlowja | 17:18 | |
| *** e0ne is now known as e0ne_ | 17:19 | |
| *** vilobhmm1 has joined #openstack-cinder | 17:20 | |
| *** vilobhmm1 has joined #openstack-cinder | 17:21 | |
| *** e0ne_ is now known as e0ne | 17:22 | |
| *** vilobhmm11 has joined #openstack-cinder | 17:24 | |
| *** vilobhmm1 has quit IRC | 17:25 | |
| *** rushil has quit IRC | 17:28 | |
| *** annashen has joined #openstack-cinder | 17:28 | |
| *** Mandell has quit IRC | 17:28 | |
| *** patrickeast has joined #openstack-cinder | 17:29 | |
| *** dflorea has quit IRC | 17:32 | |
| *** annashen has quit IRC | 17:33 | |
| *** annegentle has quit IRC | 17:34 | |
| *** Mandell has joined #openstack-cinder | 17:35 | |
| *** tbarron has joined #openstack-cinder | 17:35 | |
| *** Bsony has joined #openstack-cinder | 17:36 | |
| *** thingee has joined #openstack-cinder | 17:36 | |
| *** dflorea has joined #openstack-cinder | 17:37 | |
| *** Bsony has quit IRC | 17:41 | |
| *** annegentle has joined #openstack-cinder | 17:43 | |
| *** lpetrut has quit IRC | 17:44 | |
| *** lpetrut has joined #openstack-cinder | 17:44 | |
| *** jdurgin1 has quit IRC | 17:44 | |
| *** jproulx has left #openstack-cinder | 17:46 | |
| *** dflorea has quit IRC | 17:53 | |
| *** dflorea has joined #openstack-cinder | 17:53 | |
| *** dflorea has quit IRC | 17:58 | |
| *** sgotliv has quit IRC | 17:58 | |
| *** emagana has joined #openstack-cinder | 18:03 | |
| *** jamielennox|away is now known as jamielennox | 18:04 | |
| *** tbarron1 has joined #openstack-cinder | 18:06 | |
| *** emagana has quit IRC | 18:08 | |
| *** tbarron has quit IRC | 18:09 | |
| *** jordanP has quit IRC | 18:10 | |
| *** leeantho has joined #openstack-cinder | 18:15 | |
| *** annegentle has quit IRC | 18:16 | |
| *** e0ne has quit IRC | 18:21 | |
| *** yuriy_n17 has quit IRC | 18:23 | |
| *** reed has quit IRC | 18:24 | |
| tbarron1 | hema, tsekiyama: you two know about the status of multiple iscsi portals and nova volume-attach, right? | 18:27 |
| tbarron1 | hemna: ^^ | 18:27 |
| tbarron1 | sp problem today | 18:28 |
| *** emagana has joined #openstack-cinder | 18:29 | |
| tsekiyama | tbarron1: cinder part is in, but nova side is not yet merged | 18:29 |
| tbarron1 | tsekiyama: so will it get merged by nova adopting hemna's brick work? | 18:29 |
| tsekiyama | tbarron1: it'll be after Liberty. maybe by using os-brick. | 18:30 |
| tbarron1 | or by another path? | 18:30 |
| tbarron1 | tsekiyama: when I fail over one array controller to another, nova attaches fail | 18:30 |
| *** annegentle has joined #openstack-cinder | 18:30 | |
| tbarron1 | even though I/O works fine with attaches done prior to the failover | 18:31 |
| tbarron1 | because multipath is working (DM-MPIO) correctly. | 18:31 |
| tbarron1 | tsekiyama: your patch will fix that I think? | 18:31 |
| tsekiyama | tbarron1: Right. | 18:31 |
| tsekiyama | tbarron1: Currently nova needs main path alive to attach volumes. | 18:32 |
| *** lpetrut has quit IRC | 18:32 | |
| *** Maike has joined #openstack-cinder | 18:33 | |
| tbarron1 | tsekiyama: would I also need to make changes in my backend driver to pass connection details to nova differently? | 18:33 |
| *** emagana has quit IRC | 18:33 | |
| tsekiyama | tbarron1: My nova patch is applied, or if nova moves to os-brick, and the cinder backend are configured to provide multiple paths information to nova, it will be succeed to attach. | 18:34 |
| tsekiyama | tbarron1: yeah, backend driver also need to be modified so that it can multiple paths information in new style in "initialize_connection" method. | 18:34 |
| tbarron1 | tsekiyama: I see what you did with LVM, so that's a good model. | 18:35 |
| *** reed has joined #openstack-cinder | 18:35 | |
| tbarron1 | tsekiyama: so on the Nova side, just https://review.openstack.org/#/c/140878/, right? | 18:35 |
| tsekiyama | tbarron1: Right. but it is now conflicting with anish's patch.. | 18:36 |
| tbarron1 | tsekiyama: looking ... | 18:36 |
| tsekiyama | tbarron1: oops sory | 18:36 |
| tsekiyama | tbarron1: that's not right one. it is old | 18:36 |
| tsekiyama | tbarron1: https://review.openstack.org/#/c/134683/ | 18:37 |
| tbarron1 | tsekiyama: yeah, I need to get up to date :-) | 18:37 |
| tbarron1 | tsekiyama: th | 18:37 |
| tbarron1 | ty | 18:37 |
| tsekiyama | tbarron1: ^ is the right one. for multipath enhancement | 18:37 |
| *** anshul has joined #openstack-cinder | 18:37 | |
| tsekiyama | tbarron1: https://review.openstack.org/#/c/140878/ is for single path failover, but data model is changed, so it doesn't work. | 18:38 |
| tbarron1 | tsekiyama: thanks. I am adding myself to the review for https://review.openstack.org/#/c/134683/ so that I can stay up to date. | 18:39 |
| tbarron1 | tsekiyama: is resolving the merge conflict hard? I want to try it end-to-end with your cinder fix and a fix I will do to our drivers. | 18:40 |
| tbarron1 | tsekiyama: I don't mean to be rushing you with that question. I know it can't be targeted till Liberty. | 18:41 |
| tsekiyama | Hmm, i don't believe it's that hard, but I need more look into it.. | 18:41 |
| tbarron1 | tsekiyama: understood. Thank you very much for your help now! | 18:42 |
| *** dannywilson has quit IRC | 18:42 | |
| tsekiyama | tbarron1: no problem | 18:42 |
| *** dannywilson has joined #openstack-cinder | 18:42 | |
| *** annegentle has quit IRC | 18:45 | |
| *** dflorea has joined #openstack-cinder | 18:48 | |
| *** lpabon has joined #openstack-cinder | 18:48 | |
| openstackgerrit | Tom Swanson proposed openstack/cinder: Dell Storage Center API change fails init_conn https://review.openstack.org/167366 | 18:48 |
| *** anshul has quit IRC | 18:52 | |
| *** anshul has joined #openstack-cinder | 18:52 | |
| *** dflorea has quit IRC | 18:53 | |
| *** dflorea has joined #openstack-cinder | 18:55 | |
| *** dflorea has quit IRC | 18:57 | |
| *** vilobhmm11 has quit IRC | 18:59 | |
| *** jistr has joined #openstack-cinder | 19:02 | |
| *** vilobhmm1 has joined #openstack-cinder | 19:02 | |
| *** vilobhmm1 has quit IRC | 19:02 | |
| *** vilobhmm11 has joined #openstack-cinder | 19:02 | |
| *** dflorea has joined #openstack-cinder | 19:03 | |
| *** Rockyg has joined #openstack-cinder | 19:03 | |
| *** e0ne has joined #openstack-cinder | 19:11 | |
| *** eharney has quit IRC | 19:20 | |
| nikesh_vedams | jgriffith : hi yesterday i was trying for this http://docs.openstack.org/admin-guide-cloud/content/volume-migration.html which have a example of migration of attached volume and which is being addressed by https://review.openstack.org/#/c/167134/3/cinder/volume/manager.py | 19:20 |
| *** diemt has joined #openstack-cinder | 19:21 | |
| *** guest1 has joined #openstack-cinder | 19:21 | |
| *** tbarron1 has quit IRC | 19:22 | |
| *** tbarron has joined #openstack-cinder | 19:23 | |
| *** tellesnobrega has quit IRC | 19:29 | |
| *** emagana has joined #openstack-cinder | 19:30 | |
| *** jistr has quit IRC | 19:31 | |
| *** tellesnobrega has joined #openstack-cinder | 19:33 | |
| *** emagana has quit IRC | 19:34 | |
| *** dustins_ is now known as dustins | 19:34 | |
| *** vilobhmm11 has quit IRC | 19:37 | |
| *** emagana has joined #openstack-cinder | 19:37 | |
| *** vilobhmm1 has joined #openstack-cinder | 19:39 | |
| *** vilobhmm1 has quit IRC | 19:39 | |
| *** morganfainberg is now known as needslesscoffee | 19:39 | |
| *** guest1 has quit IRC | 19:43 | |
| *** _cjones_ has quit IRC | 19:45 | |
| *** _cjones_ has joined #openstack-cinder | 19:46 | |
| *** needslesscoffee is now known as morganfainberg | 19:50 | |
| *** _cjones_ has quit IRC | 19:50 | |
| *** _cjones_ has joined #openstack-cinder | 19:52 | |
| e0ne | jgriffith, boris-42: ping. am i right that we don't test cinder api v2 with rally at all? | 19:53 |
| *** eharney has joined #openstack-cinder | 19:53 | |
| *** kallebe has left #openstack-cinder | 19:53 | |
| *** lpabon has quit IRC | 19:56 | |
| boris-42 | e0ne: yep we are not testing it yet | 19:56 |
| e0ne | :( | 19:56 |
| anish | tsekiyama: I'm blanking out on this, where was the conflict ? | 19:56 |
| e0ne | but the good news: no need to investigate performance impact for api v1 | 19:57 |
| Swanson | If any cores are around could you take a peek at https://review.openstack.org/#/c/167366/1 | 19:57 |
| Swanson | Really simple change. | 19:57 |
| anish | e0ne: ping, you wanted this held off till code_cleanup_batching https://review.openstack.org/#/c/158926/ | 19:57 |
| anish | also thingee, if you can take a look. hemna's signoff is contingent on yours | 19:58 |
| e0ne | anish:done | 19:59 |
| *** porrua has quit IRC | 19:59 | |
| boris-42 | e0ne: but tests for v2 api can be done | 20:00 |
| anish | e0ne: no +2 ? :( | 20:00 |
| anish | I just realised I've always assumed core reviewers only do +2, -1 or -2 | 20:01 |
| e0ne | anish: i'm waiting for hemna | 20:01 |
| anish | lol, henma is waiting for thingee | 20:02 |
| e0ne | boris-42: i want try run current scenarios with api v2 | 20:02 |
| anish | slowly turning into #openstack-gentoo | 20:02 |
| *** emagana has quit IRC | 20:04 | |
| *** agentle has joined #openstack-cinder | 20:06 | |
| tsekiyama | anish: ah, don't worry, my nova multipath enhancement patch (which is not targeted to Kilo now) conflicted due to auto-merge failure with your changes (already merged) for --interface option support in iscsiadm. | 20:10 |
| *** xyang1 has joined #openstack-cinder | 20:13 | |
| anish | tsekiyama: please ping me when you retarget it again. I would like to get multipath working simultaneously with interface support at some point, something that can show weird behaviour right now | 20:13 |
| anish | (I really can't think of a good way that these two can co-exist) | 20:14 |
| tsekiyama | anish: It might be nice if you could apply your hardware iscsi transport support into os-brick | 20:15 |
| anish | tsekiyama: https://review.openstack.org/#/c/152740/ | 20:15 |
| anish | I had held that off for liberty specs being open, haven't followed up | 20:16 |
| Swanson | hemna: Thanks for the review. | 20:16 |
| hemna | np | 20:16 |
| *** cdelatte has quit IRC | 20:16 | |
| anish | hemna: was there a final decision on a specs repo for brick btw ? or is it supposed to go under cinder | 20:17 |
| *** vilobhmm1 has joined #openstack-cinder | 20:17 | |
| *** vilobhmm1 has quit IRC | 20:17 | |
| *** anshul has quit IRC | 20:17 | |
| hemna | it's supposed to be under Cinder afaik | 20:17 |
| hemna | we can revisit that in L | 20:17 |
| *** vilobhmm1 has joined #openstack-cinder | 20:17 | |
| anish | cool to remove the WIP from this then, now that specs are open ? https://review.openstack.org/#/c/152740/ | 20:18 |
| hemna | are specs open? | 20:18 |
| hemna | we haven't even finished K yet | 20:18 |
| hemna | anish, have to ask thingee | 20:18 |
| anish | oh my bad. nova/keystone specs are open, I assumed everyone is roughly on the same timeline | 20:19 |
| *** xyang has joined #openstack-cinder | 20:19 | |
| DuncanT | We were planning on not opening specs until RC time or so, to encourage people to work on bug fixes and testing | 20:19 |
| anish | gotcha, misunderstanding on my part | 20:19 |
| *** vilobhmm1 has quit IRC | 20:22 | |
| *** _cjones_ has quit IRC | 20:23 | |
| *** _cjones_ has joined #openstack-cinder | 20:23 | |
| *** vilobhmm1 has joined #openstack-cinder | 20:23 | |
| *** enterprisedc has joined #openstack-cinder | 20:25 | |
| *** dflorea has quit IRC | 20:28 | |
| *** dflorea has joined #openstack-cinder | 20:28 | |
| *** dflorea has quit IRC | 20:33 | |
| *** dflorea has joined #openstack-cinder | 20:34 | |
| thingee | hemna, anish fine with keeping brick related specs under Cinder. As DuncanT mentioned, we talked about opening for L specs after RC focus. http://eavesdrop.openstack.org/meetings/cinder/2015/cinder.2015-03-18-16.00.log.html#l-337 | 20:35 |
| *** jcru has quit IRC | 20:35 | |
| *** rushil has joined #openstack-cinder | 20:35 | |
| *** Adriano_ has quit IRC | 20:36 | |
| hemna | coolio | 20:36 |
| *** reed has quit IRC | 20:42 | |
| boris-42 | e0ne: so we were working on that feature | 20:43 |
| hemna | man this is painful | 20:46 |
| hemna | moving the checks into the rpcapi has turned into a CF | 20:46 |
| e0ne | boris-42: great! are any estimates? | 20:46 |
| *** markstur has left #openstack-cinder | 20:46 | |
| hemna | a CF of unit test changes/failures. | 20:47 |
| hemna | bleh | 20:47 |
| *** nellysmitt has joined #openstack-cinder | 20:47 | |
| *** nellysmitt has quit IRC | 20:47 | |
| smcginnis | hemna: Personally I would be all for your simple protection now, bigger refactoring/protection later. | 20:49 |
| smcginnis | hemna: Just my opinion. | 20:49 |
| hemna | yah, i'm seriously leaning that way | 20:50 |
| hemna | this is requiring me to change the rpcapi | 20:50 |
| smcginnis | hemna: It's still better than it was. No worse. | 20:50 |
| hemna | and a boatload of unit tests | 20:50 |
| hemna | 20+ | 20:50 |
| *** angela-s has quit IRC | 20:51 | |
| boris-42 | e0ne: so for now thre is no estimates | 20:51 |
| e0ne | boris-42: are you going to do it for the next release or next+n? | 20:52 |
| e0ne | thingee: hi! any updates about cinderclient release date? | 20:54 |
| e0ne | thingee: are you going to do it after RC or after Kilo released? | 20:54 |
| boris-42 | e0ne: so not in next 100% | 20:56 |
| boris-42 | e0ne: next release will be on next week | 20:56 |
| *** Maike has quit IRC | 20:56 | |
| *** dflorea has quit IRC | 20:58 | |
| *** dflorea has joined #openstack-cinder | 20:59 | |
| thingee | e0ne: need this to land..but need to do some rework still https://review.openstack.org/#/c/145613/ | 21:00 |
| thingee | but yeah at this point it will be near rc cut | 21:00 |
| thingee | been having operators ask about this on the ops ML | 21:00 |
| *** Yogi1 has quit IRC | 21:00 | |
| e0ne | thingee: agree. it's very important feature. i was asked few times about it from our support | 21:01 |
| anish | thingee: thanks for hte link | 21:02 |
| thingee | e0ne: understood. I will make announcements about it. Need to also see how much trouble I'm going to be for being this late with the release | 21:02 |
| thingee | of the client | 21:02 |
| thingee | anish: np | 21:02 |
| *** tbarron has quit IRC | 21:02 | |
| e0ne | thingee: thank you for update | 21:03 |
| *** dflorea has quit IRC | 21:03 | |
| anish | hemna: I have 2 cores signed off on https://review.openstack.org/#/c/158926/, do you still want thingee to look at it ? | 21:03 |
| *** vilobhmm1 has quit IRC | 21:03 | |
| * thingee looks | 21:04 | |
| hemna | anish, yes | 21:04 |
| hemna | since it's not a bug fix | 21:04 |
| hemna | I don't want to +A it. | 21:04 |
| anish | ko ! | 21:04 |
| hemna | leave it to the boss. | 21:04 |
| *** vilobhmm1 has joined #openstack-cinder | 21:04 | |
| * thingee shakes fist at jungleboy for starting this boss nonsense | 21:04 | |
| *** dflorea has joined #openstack-cinder | 21:04 | |
| hemna | :P | 21:04 |
| thingee | david wang is our boss. end of story | 21:05 |
| *** melwitt has quit IRC | 21:05 | |
| anish | do you prefer "everyone core reviewer is equal, some are just more equal" ? | 21:05 |
| *** melwitt_ has joined #openstack-cinder | 21:05 | |
| * hemna hides. | 21:05 | |
| *** vilobhmm1 has quit IRC | 21:05 | |
| *** vilobhmm11 has joined #openstack-cinder | 21:05 | |
| *** melwitt_ has quit IRC | 21:05 | |
| *** emagana has joined #openstack-cinder | 21:05 | |
| thingee | anish: what? | 21:05 |
| *** melwitt has joined #openstack-cinder | 21:05 | |
| anish | thingee: it's an animal farm reference, ignore me | 21:06 |
| *** tbarron has joined #openstack-cinder | 21:06 | |
| * thingee needs to read that still and ashamed to report that | 21:06 | |
| e0ne | anish, hemna: TBH, i prefer to keep unit tests as simple, as possible and fix them w/o cleanup batch | 21:06 |
| *** openstackgerrit has quit IRC | 21:07 | |
| hemna | it's impossible to do that with what I'm doing on this patch | 21:07 |
| hemna | as it changes the rpcapi | 21:07 |
| anish | thingee: heh, the whole book is like 90 pages long. you could finish it today | 21:07 |
| *** openstackgerrit has joined #openstack-cinder | 21:07 | |
| e0ne | a simple 'equals order' fix could save few hours:) | 21:08 |
| e0ne | hemna: what rpc changes are you talking about? | 21:08 |
| hemna | on this bugfix I'm working on | 21:08 |
| hemna | avishay and jgriffith wanted me to put the attachment checks into the api instead of the manager | 21:08 |
| hemna | since I'm loading the attachment, it doesn't make sense to pass an attachment_id into the manager, when I already have the attachment object | 21:09 |
| hemna | and that causes unit test changes | 21:09 |
| hemna | bleh | 21:09 |
| hemna | more changes than I wanted for this simple fix | 21:09 |
| hemna | honestly, I think this is a bigger problem that's outside of the scope of this issue I'm trying to resolve | 21:09 |
| hemna | e0ne, https://review.openstack.org/#/c/167045/ | 21:10 |
| *** emagana has quit IRC | 21:10 | |
| e0ne | hm... | 21:11 |
| *** jcru has joined #openstack-cinder | 21:13 | |
| e0ne | hemna: i need to go deeper to this bug and patch to be on the same page with you | 21:13 |
| jgriffith | hemna: hate to say it but maybe it is indicatvie that you're model of using attachment ID's is flawed | 21:17 |
| hemna | disagree | 21:17 |
| jgriffith | hemna: :) | 21:17 |
| hemna | moving the checks into the api is a bigger change | 21:17 |
| hemna | it just propogates to unit test changes, etc. | 21:17 |
| hemna | bleh | 21:17 |
| jgriffith | hemna: but that's where they belong | 21:17 |
| * e0ne bb tomorrow (in ~10 hours) | 21:18 | |
| hemna | yah I agree | 21:18 |
| *** e0ne is now known as e0ne_ | 21:18 | |
| jgriffith | hemna: the only change that should be there IMO anyway is "volume['status'] == 'in-use'" | 21:18 |
| *** akerr has quit IRC | 21:18 | |
| jgriffith | hemna: I'll be curious to see why that causes so much problem in tests etc | 21:19 |
| hemna | well | 21:19 |
| hemna | I guess I was going a different route | 21:19 |
| hemna | which is a bit harder I guess | 21:19 |
| jgriffith | hemna: oh? | 21:19 |
| hemna | I was moving the existing checks in the manager | 21:19 |
| hemna | into the API | 21:19 |
| jgriffith | hemna: hmmm... how come? | 21:20 |
| jgriffith | hemna: as opposed to a one line add in volume/api.py "if volume['status'] != 'in-use': return" | 21:20 |
| *** reed has joined #openstack-cinder | 21:20 | |
| *** Lee1092 has quit IRC | 21:20 | |
| jgriffith | hemna: in volume.api:detach_volume() | 21:20 |
| jgriffith | hemna: fixed, done | 21:21 |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L814-L840 | 21:21 |
| hemna | those checks | 21:21 |
| hemna | as I thought that's what you guys wanted | 21:21 |
| jgriffith | hemna: not me | 21:21 |
| jgriffith | in fact I hate those checks anyway, and I certainly wouldn't put those in volume.api | 21:21 |
| hemna | heh man | 21:21 |
| hemna | ok | 21:22 |
| jgriffith | hemna: just add the one liner check and be done | 21:22 |
| hemna | ok | 21:22 |
| jgriffith | hemna: or make your life as difficult as you can... your call | 21:22 |
| *** ndipanov has quit IRC | 21:22 | |
| hemna | I get so many different opinions at times | 21:22 |
| hemna | it's impossible to get this stuff right. | 21:22 |
| hemna | ok I'll scratch my current path | 21:22 |
| jgriffith | hemna: well then ignore me and i'll leave you alone :) | 21:22 |
| jgriffith | hemna: but that's the exact same thing I said this morning | 21:22 |
| hemna | and I'll add your check and be done with it | 21:22 |
| jgriffith | no different | 21:22 |
| hemna | yah I guess I got a different view from avishay, so I was trying to accomodate | 21:23 |
| hemna | ok | 21:23 |
| hemna | bleh, this will be easier | 21:23 |
| jgriffith | Ok, then count me out | 21:23 |
| jgriffith | do what you and Avishay agreed on, I wasn't present for all of that | 21:23 |
| jgriffith | hemna: I guess harder and complex is always better than easy and simple | 21:24 |
| hemna | heh no | 21:24 |
| anish | aww yisss ! my work here is done | 21:24 |
| hemna | that's what I'm abandoning it | 21:24 |
| * anish disappears till RC | 21:24 | |
| jgriffith | hemna: I think it's crazy to have all that logic in api.py personally | 21:25 |
| * hemna hits the reset button | 21:26 | |
| *** julim has quit IRC | 21:26 | |
| hemna | so the api has lots of checks in other methods | 21:28 |
| hemna | such as delete() | 21:28 |
| hemna | so it's kinda confusing really where the checks should live | 21:29 |
| jgriffith | hemna: ok, ignore me then | 21:29 |
| *** emagana has joined #openstack-cinder | 21:29 | |
| hemna | putting them in the api helps prevent rpc calls that will just fail otherwise | 21:29 |
| jgriffith | hemna: I don't understand what's hard or confusing? | 21:30 |
| jgriffith | hemna: we do this for things like delete, delete-snapshot etc etc | 21:30 |
| hemna | going your route, simply adding an check on 'in-use' is easy | 21:30 |
| hemna | I'm just trying to understand in general, where the checks should live. | 21:31 |
| jgriffith | hemna: it should live in volume/api ! | 21:31 |
| jgriffith | hemna: just like "begin_detaching" | 21:31 |
| jgriffith | the fact that it's not there is an oversight/bug | 21:31 |
| hemna | ok, that's what I thought, but was confused by what you said a bit earlier | 21:31 |
| *** annashen has joined #openstack-cinder | 21:32 | |
| jgriffith | hemna: what did I say that was confusing? | 21:32 |
| hemna | "jgriffith> hemna: I think it's crazy to have all that logic in api.py personally" | 21:32 |
| jgriffith | hemna: YES... all the logic that you have for that call in manager! | 21:32 |
| jgriffith | hemna: That would be crazy to put all of those DB calls and checks in volume/api IMO | 21:32 |
| hemna | should be in api.py ? | 21:32 |
| hemna | oh ok, kinda like delete() | 21:32 |
| *** harlowja is now known as harlowja_away | 21:32 | |
| hemna | has lots of db calls :P | 21:33 |
| jgriffith | OMG.... | 21:33 |
| jgriffith | I'm saying that the level of complexity in manager should STAY in manager and NOT be in api.py | 21:33 |
| jgriffith | api.py should be quick/dirty and simple | 21:33 |
| hemna | sure | 21:33 |
| thingee | jgriffith, hemna: I've always said that validation checks should be done in the underlying api.py file. The files in cinder.api should be what's just communicating back. | 21:33 |
| jgriffith | thingee: what? | 21:33 |
| *** emagana has quit IRC | 21:33 | |
| thingee | that way if other methods or modules call that method, they benefit from those validation checks too. | 21:34 |
| jgriffith | thingee: don't start that one again please :) | 21:34 |
| hemna | thingee, I tend to agree. it helps prevent rpc calls that would eventually fail | 21:34 |
| jgriffith | I already did the whole argument on why it should no tbe in cinder.api.contrib.xxxxxx | 21:34 |
| thingee | I want to keep the cinder.api stuff purely for routing and communicating. | 21:34 |
| jgriffith | thingee: that's EXACTLY what I was saying this morning!!! | 21:34 |
| hemna | :) | 21:34 |
| thingee | jgriffith: and I agree | 21:34 |
| hemna | coolsvap|afk, we agree :) | 21:35 |
| hemna | bah | 21:35 |
| thingee | jgriffith: right, just saying my position on the whole thing | 21:35 |
| hemna | smh xchat | 21:35 |
| jgriffith | thingee: got ya | 21:35 |
| hemna | so they should live in cinder.volume.api | 21:35 |
| hemna | right ? | 21:35 |
| jgriffith | thingee: the problem is you're going to confuse hemna again and he'll say I "changed my mind" :( | 21:35 |
| jgriffith | hemna: I'll write the patch | 21:35 |
| thingee | jgriffith: I thought I was agreeing with you. | 21:35 |
| thingee | jgriffith: sorry if it came off as confusing hemna | 21:36 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Be safe with getting attachment https://review.openstack.org/167045 | 21:36 |
| *** IanGovett1 has joined #openstack-cinder | 21:36 | |
| hemna | jgriffith, ^^ | 21:36 |
| *** annashen has quit IRC | 21:36 | |
| * hemna hopes that's what jgriffith meant. | 21:37 | |
| jgriffith | hemna: that's EXACTLY what I meant!!! | 21:39 |
| *** IanGovett has quit IRC | 21:39 | |
| jgriffith | hemna: thank you!!!!! | 21:39 |
| *** thangp has quit IRC | 21:39 | |
| hemna | phew! | 21:39 |
| jgriffith | hemna: tell me about it :) | 21:39 |
| openstackgerrit | Vilobh Meshram proposed openstack/cinder: WIP - ConsistencyGroup Object https://review.openstack.org/163641 | 21:39 |
| jgriffith | on that note, I gotta jet for a bit, catch ya all later | 21:40 |
| thingee | jgriffith: seeya. thanks for the log patch | 21:40 |
| hemna | l8s | 21:40 |
| *** asselin_ has joined #openstack-cinder | 21:42 | |
| *** tbarron has quit IRC | 21:44 | |
| *** asselin_ has quit IRC | 21:47 | |
| *** tbarron has joined #openstack-cinder | 21:47 | |
| *** agentle has quit IRC | 21:48 | |
| *** mdbooth has quit IRC | 21:48 | |
| *** wolsen has quit IRC | 21:48 | |
| *** flip214 has quit IRC | 21:48 | |
| *** tristanC has quit IRC | 21:48 | |
| *** angela-s has joined #openstack-cinder | 21:48 | |
| *** agentle has joined #openstack-cinder | 21:49 | |
| *** mdbooth has joined #openstack-cinder | 21:49 | |
| *** wolsen has joined #openstack-cinder | 21:49 | |
| *** flip214 has joined #openstack-cinder | 21:49 | |
| *** tristanC has joined #openstack-cinder | 21:49 | |
| *** sc has quit IRC | 21:50 | |
| *** agentle has quit IRC | 21:50 | |
| *** sc has joined #openstack-cinder | 21:52 | |
| *** mriedem is now known as mriedem_away | 21:53 | |
| *** emagana has joined #openstack-cinder | 21:53 | |
| *** primechuck has quit IRC | 21:54 | |
| *** dflorea has quit IRC | 21:57 | |
| *** ronis has quit IRC | 21:57 | |
| *** thingee has quit IRC | 22:00 | |
| *** tbarron has quit IRC | 22:00 | |
| *** tbarron has joined #openstack-cinder | 22:00 | |
| *** ronis has joined #openstack-cinder | 22:00 | |
| *** dflorea_ has joined #openstack-cinder | 22:00 | |
| *** akerr has joined #openstack-cinder | 22:03 | |
| *** dflorea_ has quit IRC | 22:05 | |
| *** harlowja_away is now known as harlowja | 22:05 | |
| openstackgerrit | Richard Hedlind proposed openstack/cinder: Properly remove host object from ISE https://review.openstack.org/166079 | 22:06 |
| *** akerr has quit IRC | 22:10 | |
| *** dflorea has joined #openstack-cinder | 22:11 | |
| *** ociuhandu has quit IRC | 22:13 | |
| *** thingee has joined #openstack-cinder | 22:14 | |
| *** changbl has quit IRC | 22:14 | |
| *** vilobhmm11 has quit IRC | 22:15 | |
| *** vilobhmm1 has joined #openstack-cinder | 22:15 | |
| *** ronis has quit IRC | 22:16 | |
| *** vilobhmm1 has quit IRC | 22:20 | |
| *** vilobhmm1 has joined #openstack-cinder | 22:21 | |
| *** tshefi has quit IRC | 22:24 | |
| *** e0ne_ has quit IRC | 22:25 | |
| anish | why does zuul show some tests in red even when they succeed ? is it supposed to indicate slow sections ? | 22:25 |
| Swanson | I've never seen that. | 22:27 |
| anish | http://status.openstack.org/zuul/ 158926/3 in gate | 22:28 |
| *** emagana has quit IRC | 22:29 | |
| *** dflorea has quit IRC | 22:30 | |
| Swanson | That's solid green here. | 22:30 |
| anish | hrm gate-dsvm-neutron-full is seen as red for me even though it says SUCCESS | 22:30 |
| anish | *gate-tempest-dsvm-neutron-full | 22:30 |
| *** dflorea has joined #openstack-cinder | 22:30 | |
| *** Rockyg has quit IRC | 22:30 | |
| Swanson | All green. Unless you clicked that link in which case the link goes red. | 22:32 |
| hemna | Funny for the day -- http://goo.gl/1XtzIS | 22:32 |
| openstackgerrit | Julie Gravel proposed openstack/cinder: Validate volume type extra specs https://review.openstack.org/161480 | 22:33 |
| *** dflorea has quit IRC | 22:35 | |
| *** dflorea has joined #openstack-cinder | 22:37 | |
| vilobhmm1 | thangp : ping | 22:46 |
| openstackgerrit | Julie Gravel proposed openstack/cinder: Add HP3PAR validate volume type extra spec https://review.openstack.org/164238 | 22:50 |
| *** dflorea has quit IRC | 22:51 | |
| *** dflorea has joined #openstack-cinder | 22:51 | |
| *** dustins has quit IRC | 22:54 | |
| *** dflorea has quit IRC | 22:56 | |
| *** rmesta has quit IRC | 22:56 | |
| tbarron | hemna: that's spot on | 22:57 |
| hemna | tbarron, :) | 22:57 |
| *** vilobhmm1 has quit IRC | 22:58 | |
| *** vilobhmm1 has joined #openstack-cinder | 22:58 | |
| *** vilobhmm1 has quit IRC | 22:59 | |
| *** vilobhmm1 has joined #openstack-cinder | 22:59 | |
| *** dannywilson has quit IRC | 22:59 | |
| *** dflorea has joined #openstack-cinder | 23:01 | |
| *** vilobhmm11 has joined #openstack-cinder | 23:02 | |
| *** vilobhmm11 has quit IRC | 23:02 | |
| *** vilobhmm11 has joined #openstack-cinder | 23:02 | |
| *** vilobhmm1 has quit IRC | 23:03 | |
| *** markvoelker has quit IRC | 23:06 | |
| *** dims has quit IRC | 23:14 | |
| openstackgerrit | Joe Gordon proposed openstack/cinder: Move to hacking 0.10 https://review.openstack.org/167438 | 23:16 |
| *** dims has joined #openstack-cinder | 23:16 | |
| *** dims has quit IRC | 23:17 | |
| *** dims has joined #openstack-cinder | 23:17 | |
| *** chlong has joined #openstack-cinder | 23:20 | |
| *** btran has quit IRC | 23:20 | |
| *** vilobhmm11 has quit IRC | 23:21 | |
| *** vilobhmm1 has joined #openstack-cinder | 23:22 | |
| *** vilobhmm1 has quit IRC | 23:22 | |
| *** Mandell has quit IRC | 23:22 | |
| *** vilobhmm1 has joined #openstack-cinder | 23:22 | |
| *** vilobhmm1 has quit IRC | 23:23 | |
| *** vilobhmm1 has joined #openstack-cinder | 23:23 | |
| *** vilobhmm1 has quit IRC | 23:23 | |
| *** vilobhmm1 has joined #openstack-cinder | 23:24 | |
| *** ociuhandu has joined #openstack-cinder | 23:25 | |
| *** vilobhmm11 has joined #openstack-cinder | 23:27 | |
| *** vilobhmm1 has quit IRC | 23:27 | |
| *** dflorea has quit IRC | 23:32 | |
| *** dflorea has joined #openstack-cinder | 23:33 | |
| *** annashen has joined #openstack-cinder | 23:34 | |
| *** chlong has quit IRC | 23:35 | |
| *** chlong has joined #openstack-cinder | 23:35 | |
| *** dflorea has quit IRC | 23:37 | |
| *** dflorea has joined #openstack-cinder | 23:37 | |
| *** annashen has quit IRC | 23:38 | |
| *** markvoelker has joined #openstack-cinder | 23:47 | |
| *** diemt has quit IRC | 23:47 | |
| *** ho has joined #openstack-cinder | 23:49 | |
| *** markvoelker has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
