*** dims has quit IRC | 00:03 | |
*** smoriya has joined #openstack-cinder | 00:03 | |
*** dims has joined #openstack-cinder | 00:03 | |
*** alonmarx_ has quit IRC | 00:07 | |
*** alonmarx has joined #openstack-cinder | 00:07 | |
*** setmason has quit IRC | 00:10 | |
*** vokt has quit IRC | 00:15 | |
*** chlong-zzz has joined #openstack-cinder | 00:18 | |
*** annashen has quit IRC | 00:18 | |
*** tsekiyama has quit IRC | 00:21 | |
*** markvoelker has joined #openstack-cinder | 00:21 | |
*** Rockyg has quit IRC | 00:22 | |
openstackgerrit | Nikesh proposed openstack/cinder: Adds FC and ISCSI Cinder drivers for HPMSA Storage Arrays. https://review.openstack.org/187707 | 00:24 |
---|---|---|
*** marcusvrn has quit IRC | 00:24 | |
*** markvoelker has quit IRC | 00:26 | |
openstackgerrit | Nikesh proposed openstack/cinder: Adds FC and ISCSI Cinder drivers for Lenovo Storage Arrays. https://review.openstack.org/187853 | 00:26 |
*** mtanino has quit IRC | 00:27 | |
*** daneyon_ has quit IRC | 00:30 | |
*** leeantho has quit IRC | 00:37 | |
openstackgerrit | xing-yang proposed openstack/cinder: Support SMI-S provider v8.0.3 in VMAX driver https://review.openstack.org/189517 | 00:41 |
*** heyun has joined #openstack-cinder | 00:47 | |
*** zhenguo has joined #openstack-cinder | 00:47 | |
*** vilobhmm has quit IRC | 00:52 | |
*** simondodsley has joined #openstack-cinder | 00:52 | |
*** simondodsley has quit IRC | 00:56 | |
*** _cjones_ has quit IRC | 00:59 | |
openstackgerrit | xing-yang proposed openstack/cinder: Add multiple pools support to VMAX driver https://review.openstack.org/189990 | 00:59 |
*** raunak has quit IRC | 01:03 | |
*** mdbooth has quit IRC | 01:07 | |
*** lixiaoy1 has joined #openstack-cinder | 01:09 | |
*** patrickeast has quit IRC | 01:13 | |
*** mdbooth has joined #openstack-cinder | 01:13 | |
*** tobe has joined #openstack-cinder | 01:18 | |
*** annashen has joined #openstack-cinder | 01:19 | |
*** davechen_afk is now known as davechen | 01:21 | |
*** Splitpeas has quit IRC | 01:22 | |
*** markvoelker has joined #openstack-cinder | 01:22 | |
*** dims has quit IRC | 01:23 | |
*** akerr has joined #openstack-cinder | 01:24 | |
*** ociuhandu has quit IRC | 01:24 | |
*** annashen has quit IRC | 01:24 | |
*** akerr_ has joined #openstack-cinder | 01:26 | |
*** markvoelker has quit IRC | 01:27 | |
*** Apoorva has quit IRC | 01:27 | |
*** diogogmt has joined #openstack-cinder | 01:28 | |
*** akerr has quit IRC | 01:29 | |
*** Apoorva has joined #openstack-cinder | 01:32 | |
*** Apoorva has quit IRC | 01:36 | |
*** haigang has joined #openstack-cinder | 01:37 | |
*** vincent_hou has joined #openstack-cinder | 01:38 | |
*** gouthamr has joined #openstack-cinder | 01:39 | |
vincent_hou | thingee: Ping. | 01:40 |
vincent_hou | jgriffith: Ping. | 01:40 |
*** vilobhmm has joined #openstack-cinder | 01:45 | |
*** haigang has quit IRC | 01:47 | |
*** marcusvrn has joined #openstack-cinder | 01:48 | |
*** haigang has joined #openstack-cinder | 01:48 | |
*** zhonghua-lee has joined #openstack-cinder | 01:54 | |
*** zhonghua-li has joined #openstack-cinder | 01:54 | |
*** zhonghua-lee has quit IRC | 01:55 | |
*** zhonghua-li has quit IRC | 01:55 | |
*** marcusvrn has quit IRC | 01:56 | |
*** Zhongjun has quit IRC | 01:58 | |
*** patrickeast has joined #openstack-cinder | 02:00 | |
*** zhonghua-lee has joined #openstack-cinder | 02:00 | |
*** asselin_ has joined #openstack-cinder | 02:00 | |
*** vilobhmm has quit IRC | 02:02 | |
*** Lee1092 has joined #openstack-cinder | 02:03 | |
*** rushil has joined #openstack-cinder | 02:09 | |
*** boris-42 has quit IRC | 02:12 | |
*** dims has joined #openstack-cinder | 02:12 | |
*** rongze has joined #openstack-cinder | 02:19 | |
*** dims has quit IRC | 02:23 | |
jgriffith | vincent_hou: yo | 02:25 |
vincent_hou | jgriffith: Buddy, can you help me take a look at the spec I drafted: https://review.openstack.org/#/c/186327/? | 02:27 |
jgriffith | sure | 02:27 |
vincent_hou | Thx. | 02:28 |
jgriffith | vincent_hou: silly question.... | 02:28 |
jgriffith | vincent_hou: I know you worked very hard on the spec, and that's great | 02:28 |
jgriffith | vincent_hou: but why not just fix the issues? | 02:28 |
jgriffith | vincent_hou: or log bugs instead :) | 02:28 |
vincent_hou | I am doing at the same time. | 02:29 |
jgriffith | vincent_hou: smart man!! :) | 02:29 |
vincent_hou | check these up: https://review.openstack.org/189547 https://review.openstack.org/186312 https://review.openstack.org/180873 | 02:30 |
jgriffith | vincent_hou: so I just have a minor nit picky suggestion | 02:30 |
vincent_hou | There are still new ones coming. | 02:30 |
jgriffith | vincent_hou: add some spacing between the line items | 02:30 |
vincent_hou | OK | 02:30 |
jgriffith | vincent_hou: if you do that I'll upvote the spec | 02:30 |
jgriffith | vincent_hou: don't go crazy adding much more | 02:30 |
vincent_hou | Cool. | 02:30 |
jgriffith | vincent_hou: you're going to overload people like me :) | 02:31 |
*** haigang has quit IRC | 02:31 | |
jgriffith | vincent_hou: my little brain can only store, process and keep track of so much at once :) | 02:31 |
vincent_hou | It won't. They are WIP. | 02:31 |
vincent_hou | Just let you know. | 02:31 |
jgriffith | vincent_hou: sounds good... thanks for taking this one | 02:31 |
vincent_hou | Sure. you are welcome. | 02:31 |
*** gouthamr has quit IRC | 02:36 | |
*** gouthamr has joined #openstack-cinder | 02:46 | |
*** gouthamr has quit IRC | 02:52 | |
*** julim has joined #openstack-cinder | 02:54 | |
*** gouthamr has joined #openstack-cinder | 02:56 | |
*** julim has quit IRC | 02:59 | |
*** akerr_ has quit IRC | 03:04 | |
*** rushiagr_away is now known as rushiagr | 03:05 | |
*** rushil has quit IRC | 03:06 | |
*** changbl_ has joined #openstack-cinder | 03:09 | |
*** markvoelker has joined #openstack-cinder | 03:11 | |
openstackgerrit | wanghao proposed openstack/cinder: Fix weird change of volume status in re-scheduling https://review.openstack.org/185545 | 03:13 |
*** markvoelker has quit IRC | 03:16 | |
*** gouthamr has quit IRC | 03:17 | |
openstackgerrit | Dave Chen proposed openstack/cinder: Policies based properties protection https://review.openstack.org/160145 | 03:19 |
*** annashen has joined #openstack-cinder | 03:21 | |
*** rushiagr is now known as rushiagr_away | 03:25 | |
*** annashen has quit IRC | 03:26 | |
*** root has joined #openstack-cinder | 03:31 | |
*** root is now known as Guest50401 | 03:31 | |
nikeshm | is any cinder meeting tomorrow | 03:33 |
nikeshm | no agenda yet | 03:33 |
nikeshm | :) | 03:33 |
*** vilobhmm has joined #openstack-cinder | 03:34 | |
*** avishay_ has joined #openstack-cinder | 03:39 | |
*** Guest50401 has quit IRC | 03:40 | |
*** harlowja_at_home has joined #openstack-cinder | 03:41 | |
*** coolsvap|afk is now known as coolsvap | 03:42 | |
*** diogogmt has quit IRC | 03:45 | |
*** sgotliv has joined #openstack-cinder | 03:59 | |
*** vincent_hou has quit IRC | 04:01 | |
openstackgerrit | wanghao proposed openstack/cinder: Add support for force-delete backups https://review.openstack.org/166127 | 04:02 |
*** sgotliv has quit IRC | 04:03 | |
*** rushiagr_away is now known as rushiagr | 04:05 | |
*** rushiagr is now known as rushiagr_away | 04:05 | |
*** rushiagr_away is now known as rushiagr | 04:06 | |
*** setmason has joined #openstack-cinder | 04:19 | |
*** yamada-h has joined #openstack-cinder | 04:21 | |
*** yamada-h has quit IRC | 04:25 | |
*** heyun has quit IRC | 04:25 | |
openstackgerrit | John Griffith proposed openstack/cinder: Add secondary account capability to SolidFire https://review.openstack.org/187311 | 04:29 |
*** BharatK has joined #openstack-cinder | 04:29 | |
*** BharatK has quit IRC | 04:30 | |
*** BharatK has joined #openstack-cinder | 04:31 | |
*** yamada-h has joined #openstack-cinder | 04:31 | |
*** chlong-zzz is now known as chlong | 04:32 | |
*** setmason has quit IRC | 04:37 | |
*** zhonghua-lee has quit IRC | 04:40 | |
*** patrickeast has quit IRC | 04:52 | |
*** swamireddy1 has joined #openstack-cinder | 04:53 | |
*** setmason has joined #openstack-cinder | 04:54 | |
*** setmason has quit IRC | 04:55 | |
*** rushiagr is now known as rushiagr_away | 04:55 | |
*** markvoelker has joined #openstack-cinder | 05:00 | |
*** swamireddy1 has quit IRC | 05:00 | |
*** deepakcs has joined #openstack-cinder | 05:02 | |
*** markvoelker has quit IRC | 05:04 | |
*** vilobhmm has quit IRC | 05:11 | |
*** setmason has joined #openstack-cinder | 05:17 | |
openstackgerrit | rakesh mishra proposed openstack/cinder: set-size-limit-for-volume https://review.openstack.org/185906 | 05:17 |
*** pradipta has joined #openstack-cinder | 05:23 | |
*** rushiagr_away is now known as rushiagr | 05:25 | |
*** setmason has quit IRC | 05:28 | |
*** setmason has joined #openstack-cinder | 05:30 | |
*** nihilifer_ has joined #openstack-cinder | 05:32 | |
*** nkrinner has joined #openstack-cinder | 05:32 | |
*** bswartz has quit IRC | 05:37 | |
*** nlevinki has joined #openstack-cinder | 05:40 | |
*** earlephilhower has quit IRC | 05:47 | |
*** ankit_ag has joined #openstack-cinder | 05:47 | |
*** yamada-h_ has joined #openstack-cinder | 05:47 | |
*** yamada-h has quit IRC | 05:48 | |
*** zhonghua-lee has joined #openstack-cinder | 05:52 | |
*** haomaiwang has quit IRC | 05:54 | |
*** rongze has quit IRC | 05:54 | |
openstackgerrit | Xi Yang proposed openstack/cinder: Provide snap copy feature in EMC VNX Cinder driver https://review.openstack.org/184733 | 05:56 |
*** belmoreira has joined #openstack-cinder | 06:01 | |
*** setmason has quit IRC | 06:01 | |
*** setmason has joined #openstack-cinder | 06:04 | |
*** yamada-h_ has quit IRC | 06:13 | |
*** setmason has quit IRC | 06:20 | |
*** annashen has joined #openstack-cinder | 06:23 | |
*** anshul has joined #openstack-cinder | 06:25 | |
openstackgerrit | wanghao proposed openstack/cinder: Add support for force-delete backups https://review.openstack.org/166127 | 06:26 |
*** anshul has quit IRC | 06:27 | |
*** anshul has joined #openstack-cinder | 06:27 | |
*** yamada-h has joined #openstack-cinder | 06:28 | |
*** annashen has quit IRC | 06:29 | |
*** zhonghua-lee has quit IRC | 06:29 | |
*** zhonghua-lee has joined #openstack-cinder | 06:32 | |
*** mdbooth has quit IRC | 06:39 | |
*** bswartz has joined #openstack-cinder | 06:40 | |
*** harlowja_at_home has quit IRC | 06:41 | |
*** mdbooth has joined #openstack-cinder | 06:45 | |
*** jwcroppe_ has quit IRC | 06:46 | |
*** markvoelker has joined #openstack-cinder | 06:49 | |
*** markvoelker has quit IRC | 06:53 | |
*** lpetrut has joined #openstack-cinder | 06:58 | |
openstackgerrit | wanghao proposed openstack/cinder-specs: Incremental backup improvements for L https://review.openstack.org/187926 | 07:05 |
*** xiaohui has quit IRC | 07:09 | |
*** jistr has joined #openstack-cinder | 07:37 | |
*** BharatK has quit IRC | 07:38 | |
*** heyun has joined #openstack-cinder | 07:39 | |
openstackgerrit | Zoltan Arnold Nagy proposed openstack/cinder: WIP: encrypted rbd support https://review.openstack.org/190053 | 07:45 |
*** BharatK has joined #openstack-cinder | 07:45 | |
*** angela-s has quit IRC | 07:47 | |
openstackgerrit | wanghao proposed openstack/cinder: Incremental backup improvements for L https://review.openstack.org/188328 | 07:50 |
*** chlong has quit IRC | 07:51 | |
openstackgerrit | chenzongliang proposed openstack/cinder: Refactor Huawei Volume driver https://review.openstack.org/188240 | 07:54 |
*** haomaiwang has joined #openstack-cinder | 07:56 | |
flip214 | Please, give me a second pair of eyes. http://paste.lisp.org/display/149508 | 07:57 |
flip214 | As I read that, it's a volume create with "volume_type": "d0724333-7fef-43da-93bf-f1e8aa4479d4" | 07:58 |
flip214 | but the result says "volume_type": "volume-type-2143297657" | 07:58 |
flip214 | is that okay, resp. expected? | 07:59 |
*** jordanP has joined #openstack-cinder | 07:59 | |
*** leopoldj has joined #openstack-cinder | 08:00 | |
*** nikeshm has quit IRC | 08:00 | |
openstackgerrit | chenzongliang proposed openstack/cinder: Huawei Storage Multiple Pools Support https://review.openstack.org/188251 | 08:04 |
*** nikeshm has joined #openstack-cinder | 08:04 | |
*** markus_z has joined #openstack-cinder | 08:16 | |
*** zhonghua-lee has quit IRC | 08:17 | |
openstackgerrit | wanghao proposed openstack/cinder: Fix weird change of volume status in re-scheduling https://review.openstack.org/185545 | 08:18 |
*** afazekas has joined #openstack-cinder | 08:20 | |
*** smoriya has quit IRC | 08:21 | |
openstackgerrit | chenzongliang proposed openstack/cinder: Add CHAP support for Huawei Storage https://review.openstack.org/188360 | 08:22 |
openstackgerrit | chenzongliang proposed openstack/cinder: Add CHAP support for Huawei Storage https://review.openstack.org/188360 | 08:25 |
*** aarefiev has quit IRC | 08:28 | |
*** aarefiev has joined #openstack-cinder | 08:28 | |
openstackgerrit | chenzongliang proposed openstack/cinder: Huawei Storage iSCSI multipath Support https://review.openstack.org/188365 | 08:35 |
*** markvoelker has joined #openstack-cinder | 08:37 | |
openstackgerrit | Cindy Pallares proposed openstack/cinder: Fix multi-line docstrings to meet hacking rules https://review.openstack.org/184820 | 08:39 |
openstackgerrit | Anton Arefiev proposed openstack/cinder: Fix lvm manage existing volume https://review.openstack.org/156939 | 08:41 |
*** markvoelker has quit IRC | 08:42 | |
*** yamada-h has quit IRC | 08:42 | |
*** lpetrut has quit IRC | 08:43 | |
openstackgerrit | chenzongliang proposed openstack/cinder: Support SmartX for Huawei volume driver https://review.openstack.org/188732 | 08:45 |
*** lixiaoy1 has quit IRC | 08:55 | |
openstackgerrit | Ph. Marek proposed openstack/cinder: Re-add DRBD driver. https://review.openstack.org/178573 | 09:15 |
*** lpetrut has joined #openstack-cinder | 09:18 | |
*** dims has joined #openstack-cinder | 09:27 | |
*** sgotliv has joined #openstack-cinder | 09:27 | |
*** dims has quit IRC | 09:31 | |
*** aix has joined #openstack-cinder | 09:34 | |
*** rakesh_mishra has joined #openstack-cinder | 09:37 | |
*** xek has joined #openstack-cinder | 09:42 | |
*** deepakcs has quit IRC | 09:45 | |
*** rushiagr is now known as rushiagr_away | 09:49 | |
*** dims has joined #openstack-cinder | 09:51 | |
*** dims_ has joined #openstack-cinder | 09:52 | |
*** e0ne has joined #openstack-cinder | 09:55 | |
*** dims has quit IRC | 09:56 | |
*** e0ne is now known as e0ne_ | 10:01 | |
*** fanyaohong has joined #openstack-cinder | 10:01 | |
*** rakesh_mishra has quit IRC | 10:02 | |
*** rakesh_mishra has joined #openstack-cinder | 10:02 | |
openstackgerrit | Zoltan Arnold Nagy proposed openstack/cinder: WIP: encrypted rbd support https://review.openstack.org/190053 | 10:04 |
*** e0ne_ has quit IRC | 10:07 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Use correct rtslib namespace for newer versions https://review.openstack.org/190099 | 10:07 |
*** boris-42 has joined #openstack-cinder | 10:09 | |
*** rakesh_mishra has quit IRC | 10:11 | |
*** Zhongjun has joined #openstack-cinder | 10:13 | |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-cinderclient: Add test for cinder extra-specs-list command output Add test for cinder list-extension command output Fix pep8 issues "E128 continuation line under-indented for visual indent" in other functions Change-Id: I28266af7a6ff23b83899c50cc230f926a44592dc Partial https://review.openstack.org/189311 | 10:15 |
*** markvoelker has joined #openstack-cinder | 10:23 | |
*** rakesh_mishra has joined #openstack-cinder | 10:24 | |
*** annashen has joined #openstack-cinder | 10:27 | |
*** markvoelker has quit IRC | 10:27 | |
*** ociuhandu has joined #openstack-cinder | 10:28 | |
*** avishay__ has joined #openstack-cinder | 10:29 | |
*** avishay_ has quit IRC | 10:29 | |
*** annashen has quit IRC | 10:31 | |
flip214 | hemna: ping? | 10:33 |
*** cbader has quit IRC | 10:34 | |
*** e0ne has joined #openstack-cinder | 10:35 | |
flip214 | I get u'tgtadm: invalid request\\n'" with the DRBD cinder driver; google doesn't really help. do you have an idea for me? | 10:38 |
*** ociuhandu has quit IRC | 10:40 | |
*** heyun has quit IRC | 10:40 | |
*** kmartin has quit IRC | 10:44 | |
*** coolsvap is now known as coolsvap|afk | 10:45 | |
*** asselin has quit IRC | 10:50 | |
flip214 | syslog says "kernel: [ 2135.066375] connection6:0: detected conn error (1020)" | 10:53 |
*** sgotliv_ has joined #openstack-cinder | 10:53 | |
*** sgotliv has quit IRC | 10:54 | |
*** rakesh_mishra has quit IRC | 10:55 | |
BharatK | DuncanT, ping | 11:03 |
DuncanT | Hi | 11:03 |
BharatK | DuncanT, Hi, Regarding the patch https://review.openstack.org/#/c/163647/ | 11:03 |
BharatK | DuncanT, Related to your comment https://review.openstack.org/#/c/163647/11/cinder/backup/drivers/posix.py | 11:04 |
BharatK | DuncanT, Please let me know your thoughts, I will work based on that. | 11:05 |
DuncanT | I can't see my comment there, just Mike's (to which I think your response is correct) | 11:05 |
BharatK | DuncanT, Oh :( I am extremely sorry. Mistaken | 11:05 |
BharatK | DuncanT, Please don't mind | 11:05 |
DuncanT | No probem :-) | 11:05 |
DuncanT | I'll go and add a comment that I agree with you and finish my review | 11:06 |
BharatK | DuncanT, Thanks | 11:06 |
BharatK | DuncanT, My actual query related to the patch https://review.openstack.org/#/c/164527/7/cinder/volume/drivers/glusterfs.py | 11:07 |
*** rakesh_mishra has joined #openstack-cinder | 11:07 | |
BharatK | DuncanT, Regarding your comment "So this is going to print a warning for every create, and there's nothing the admin can/should do to fix it. Probably shouldn't be a warning IMO, unless we add a warn_once construct." | 11:07 |
BharatK | DuncanT, Could you please tell me how can I make as warn_once? | 11:08 |
lifeless | DuncanT: the warnings module does warn only once in a lifetime by default | 11:08 |
*** alexpilotti has joined #openstack-cinder | 11:08 | |
lifeless | DuncanT: IIRC; [but thats scoped - its once per callsite calling into warnings.warn] | 11:09 |
DuncanT | lifeless: that sounds like what we need | 11:09 |
openstackgerrit | Jessy Lee proposed openstack/cinder: Add volume drivers for Infortrend Storage https://review.openstack.org/177113 | 11:09 |
BharatK | lifeless, DuncanT Thanks, is there any similar kind of patch/example? | 11:10 |
lifeless | key = (text, category, lineno) | 11:10 |
lifeless | so a given message in a given category from a given lineno will only warn once | 11:10 |
BharatK | lifeless, Thank you very much will look into this. | 11:11 |
lifeless | weird but there you go | 11:11 |
DuncanT | lifeless: That isn't the default behaviour of log.warning, is it? | 11:11 |
lifeless | DuncanT: warnings.warn | 11:11 |
lifeless | DuncanT: log.warning is every-time-you-call-it-logs | 11:11 |
DuncanT | lifeless: Ah ha, got you, thanks | 11:11 |
lifeless | DuncanT: /totally/ different | 11:11 |
DuncanT | Yup, I understand now | 11:12 |
lifeless | :) | 11:12 |
lifeless | dunno if that helps you | 11:12 |
DuncanT | Python: batteries included, if you can find them down the back of the sofa | 11:12 |
BharatK | DuncanT, lifeless, I will try that. Thanks. | 11:14 |
DuncanT | BharatK: http://pymotw.com/2/warnings/ has some notes on warnings, and how to make them go to the log rather than stderr - we might have that code in cinder already, not sure | 11:17 |
BharatK | DuncanT, Thanks will see. | 11:18 |
*** avishay__ has quit IRC | 11:21 | |
*** Longgeek has joined #openstack-cinder | 11:22 | |
*** rakesh_mishra has quit IRC | 11:22 | |
*** markvoelker has joined #openstack-cinder | 11:24 | |
*** Longgeek_ has joined #openstack-cinder | 11:25 | |
*** markvoelker has quit IRC | 11:28 | |
*** Longgeek has quit IRC | 11:28 | |
*** rakesh_mishra has joined #openstack-cinder | 11:39 | |
*** marcusvrn has joined #openstack-cinder | 11:43 | |
*** marcusvrn1 has joined #openstack-cinder | 11:46 | |
*** marcusvrn has quit IRC | 11:46 | |
*** tobe has quit IRC | 11:47 | |
*** marcusvrn1 has quit IRC | 11:51 | |
*** marcusvrn has joined #openstack-cinder | 11:51 | |
*** julim has joined #openstack-cinder | 11:52 | |
*** markvoelker has joined #openstack-cinder | 11:54 | |
*** timcl has joined #openstack-cinder | 12:01 | |
*** pradipta has quit IRC | 12:02 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/python-cinderclient: cleanup openstack-common.conf and sync updated files https://review.openstack.org/189120 | 12:05 |
*** rushiagr_away is now known as rushiagr | 12:06 | |
*** ganso_ has joined #openstack-cinder | 12:06 | |
*** aix has quit IRC | 12:14 | |
*** fanyaohong has quit IRC | 12:15 | |
*** akerr has joined #openstack-cinder | 12:19 | |
*** rakesh_mishra has quit IRC | 12:19 | |
*** dulek has joined #openstack-cinder | 12:20 | |
*** chlong has joined #openstack-cinder | 12:29 | |
openstackgerrit | Victor Stinner proposed openstack/cinder: Drop L suffix from long integers https://review.openstack.org/190152 | 12:30 |
*** gouthamr has joined #openstack-cinder | 12:33 | |
*** timcl has quit IRC | 12:33 | |
openstackgerrit | Victor Stinner proposed openstack/cinder: Replace basestring with six.string_types https://review.openstack.org/190153 | 12:34 |
*** timcl has joined #openstack-cinder | 12:34 | |
*** gouthamr has quit IRC | 12:36 | |
*** gouthamr has joined #openstack-cinder | 12:36 | |
*** eharney has joined #openstack-cinder | 12:37 | |
openstackgerrit | Victor Stinner proposed openstack/cinder: Replace unicode with six.text_type https://review.openstack.org/190160 | 12:44 |
*** salv-orlando has quit IRC | 12:45 | |
*** timcl has quit IRC | 12:45 | |
*** eantysh9 is now known as eantyshev | 12:46 | |
*** e0ne is now known as e0ne_ | 12:47 | |
openstackgerrit | Victor Stinner proposed openstack/cinder: Replace dict.itervalues() with six.itervalues(dict) https://review.openstack.org/190163 | 12:48 |
*** e0ne_ is now known as e0ne | 12:50 | |
*** aix has joined #openstack-cinder | 12:50 | |
*** ociuhandu has joined #openstack-cinder | 12:53 | |
openstackgerrit | Victor Stinner proposed openstack/cinder: Use six.reraise() for Python 3 compatibility https://review.openstack.org/190169 | 12:54 |
*** ociuhandu has quit IRC | 12:54 | |
openstackgerrit | Victor Stinner proposed openstack/cinder: Replace it.next() with next(it) for py3 compat https://review.openstack.org/190173 | 12:57 |
*** Zhongjun has quit IRC | 12:58 | |
openstackgerrit | Victor Stinner proposed openstack/cinder: Replace unicode with six.text_type https://review.openstack.org/190160 | 13:02 |
*** cbader has joined #openstack-cinder | 13:03 | |
*** nihilifer_ has quit IRC | 13:06 | |
*** mriedem has joined #openstack-cinder | 13:13 | |
*** timcl has joined #openstack-cinder | 13:15 | |
*** Yogi11 has joined #openstack-cinder | 13:16 | |
*** rushiagr is now known as rushiagr_away | 13:20 | |
*** rakesh_mishra has joined #openstack-cinder | 13:22 | |
openstackgerrit | Anton Arefiev proposed openstack/cinder: Add entry create and cast tasks to manage workflow https://review.openstack.org/139071 | 13:23 |
openstackgerrit | Anton Arefiev proposed openstack/cinder: Fix lvm manage existing volume https://review.openstack.org/156939 | 13:23 |
*** ociuhandu has joined #openstack-cinder | 13:25 | |
*** setmason has joined #openstack-cinder | 13:25 | |
mriedem | is anyone aware of any documentation for the various vendor driver's connection_info keys that are returned from the initialize_connection call? | 13:26 |
mriedem | i'm looking to model that with objects in nova and i was going to start with documenting what comes back today | 13:27 |
mriedem | before we can model what the common keys are, like driver_volume_type and data (and all of the gorp that's in the data key) | 13:27 |
*** changbl_ has quit IRC | 13:27 | |
*** dustins has joined #openstack-cinder | 13:28 | |
flip214 | asselin_: If the tempest.api.volume.admin.test_multi_backend.VolumeMultiBackendV2Test isn't skipped but fails, might the reason be the line 'CINDER_ENABLED_BACKENDS=,drbd:drbdmanage'? (the comma) | 13:28 |
asselin_ | flip214, not sure...never looked at that test case since ours skips | 13:29 |
*** annashen has joined #openstack-cinder | 13:30 | |
flip214 | DuncanT: thingee: e0ne: jgriffith: anybody else knows this?? ^^ | 13:30 |
jgriffith | flip214: what's up? | 13:31 |
* jgriffith reading | 13:31 | |
flip214 | jgriffith: hi, thanks for answering! If the tempest.api.volume.admin.test_multi_backend.VolumeMultiBackendV2Test isn't skipped but fails, might the reason be the line 'CINDER_ENABLED_BACKENDS=,drbd:drbdmanage'? (the comma) | 13:31 |
*** ociuhandu has quit IRC | 13:31 | |
jgriffith | flip214: well... did you try it without the comma ? | 13:32 |
e0ne | flip214: it should be 'CINDER_ENABLED_BACKENDS+=,drbd:drbdmanage', shouldn't it? | 13:32 |
*** teju has joined #openstack-cinder | 13:32 | |
jgriffith | flip214: and what did it fail for? | 13:32 |
jgriffith | flip214: did it build a proper config file? | 13:32 |
flip214 | http://logs.openstack.org/68/187568/10/check/check-tempest-dsvm-full-drbd-devstack/235068b/console.html#_2015-06-10_12_13_16_819 | 13:32 |
jgriffith | flip214: did it build the LVM VG's? | 13:32 |
flip214 | this is already via -infra CI. DRBD did run fine (mostly), I'm now fixing the last few bugs. | 13:33 |
jgriffith | flip214: http://logs.openstack.org/68/187568/10/check/check-tempest-dsvm-full-drbd-devstack/235068b/logs/screen-c-vol.txt.gz#_2015-06-10_12_09_08_107 | 13:33 |
flip214 | And I believe that the multi-backend failure is due to that line - some part thinks multiple backends are available, but only one is properly initialized (is my guess). | 13:33 |
e0ne | flip214: accodding to http://logs.openstack.org/68/187568/10/check/check-tempest-dsvm-full-drbd-devstack/235068b/logs/etc/cinder/cinder.conf.txt.gz you hace only one configured backend | 13:33 |
flip214 | jgriffith: that's the TestVolumeBootPatternV2 tests, I think I've fixed these in my local copy. | 13:34 |
*** annashen has quit IRC | 13:35 | |
flip214 | e0ne: but why is the test not skipped, then? | 13:35 |
e0ne | flip214: good question:). actually, i don't know how it works | 13:35 |
jgriffith | flip214: http://logs.openstack.org/68/187568/10/check/check-tempest-dsvm-full-drbd-devstack/235068b/logs/screen-c-vol.txt.gz#_2015-06-10_12_12_29_105 | 13:35 |
jgriffith | That's the TestVolumeBootPattern Vol not found | 13:36 |
flip214 | jgriffith: yes, I believe to have that fixed locally. | 13:36 |
openstackgerrit | Abhishek Lekshmanan proposed openstack/cinder: Backups: add a force flag https://review.openstack.org/189152 | 13:36 |
flip214 | I'd like to know about the multibackend tests... | 13:36 |
*** ankit_ag has quit IRC | 13:36 | |
*** ociuhandu has joined #openstack-cinder | 13:37 | |
*** timcl has quit IRC | 13:37 | |
jgriffith | flip214: I'm looking | 13:43 |
jgriffith | flip214: it may be a problem with the test | 13:45 |
jgriffith | flip214: http://logs.openstack.org/68/187568/10/check/check-tempest-dsvm-full-drbd-devstack/235068b/logs/screen-c-api.txt.gz#_2015-06-10_11_58_00_549 | 13:45 |
jgriffith | flip214: the volume the test fails on is ed860ce3-bdec-4e24-bf7a-021a4fd53b04 | 13:45 |
jgriffith | flip214: you can see the succesful create/delete sequence | 13:45 |
flip214 | okay... so what would you advise? | 13:46 |
jgriffith | flip214: I would advise you dig in and figure it out :) | 13:46 |
*** rushil has joined #openstack-cinder | 13:47 | |
jgriffith | flip214: I can deploy multi-backend and test it on my side later today | 13:47 |
jgriffith | flip214: ummm | 13:48 |
jgriffith | flip214: http://logs.openstack.org/68/187568/10/check/check-tempest-dsvm-full-drbd-devstack/235068b/logs/etc/cinder/cinder.conf.txt.gz | 13:48 |
flip214 | yes? | 13:48 |
jgriffith | to run multi-backend, wouldn't you expect to have multiple backends? | 13:49 |
jgriffith | flip214: also not sure what your syntax is about in that conf file | 13:50 |
jgriffith | flip214: have a look at https://github.com/j-griffith/sos-ci/blob/master/sos-ci/templates/localconf.base | 13:50 |
flip214 | jgriffith: I don't want to run multi-backend. | 13:50 |
jgriffith | flip214: and if you add another, just use ",<backend-name>" | 13:51 |
flip214 | I'd like to know why the multi-backend tests are not skipped | 13:51 |
jgriffith | flip214: because your setup in the local.conf is wrong | 13:51 |
*** setmason has quit IRC | 13:51 | |
*** e0ne is now known as e0ne_ | 13:51 | |
flip214 | default_volume_type = drbdmanage | 13:53 |
flip214 | enabled_backends = drbdmanage | 13:53 |
jgriffith | flip214: your cinder.conf ended up ok, but you have no tempest config | 13:53 |
flip214 | jgriffith: what's wrong there? This is in an -infra CI, so I can only have some small details wrong. | 13:53 |
*** rhagarty has quit IRC | 13:53 | |
jgriffith | flip214: oh... well, maybe I'm completely wrong | 13:53 |
*** rhagarty_ has quit IRC | 13:54 | |
*** rhagarty has joined #openstack-cinder | 13:54 | |
*** rhagarty__ has joined #openstack-cinder | 13:54 | |
flip214 | http://logs.openstack.org/68/187568/10/check/check-tempest-dsvm-full-drbd-devstack/235068b/logs/tempest_conf.txt.gz says | 13:54 |
flip214 | [volume-feature-enabled] | 13:55 |
flip214 | multi_backend = True | 13:55 |
*** setmason has joined #openstack-cinder | 13:55 | |
flip214 | hmmm, where does that come from? asselin_, can you help me here, please? | 13:55 |
jgriffith | flip214: It comes from the local.conf file | 13:55 |
jgriffith | or localrc | 13:55 |
asselin_ | flip214, mtreinish usually helps us out...maybe he's around | 13:56 |
jgriffith | alright... I give up | 13:56 |
flip214 | jgriffith: thanks, anyway! | 13:57 |
*** dustins_ has joined #openstack-cinder | 13:59 | |
*** e0ne_ is now known as e0ne | 13:59 | |
jgriffith | flip214: Ok, I'm going to try ONE more time | 14:00 |
asselin_ | flip214, did you try to see how the other open source cinder backends are passing? | 14:00 |
jgriffith | flip214: please look at your tempest_conf.txt file | 14:00 |
jgriffith | http://logs.openstack.org/68/187568/10/check/check-tempest-dsvm-full-drbd-devstack/235068b/logs/tempest_conf.txt.gz | 14:00 |
flip214 | asselin_: I'm trying to compare, yes. | 14:00 |
jgriffith | flip214: You have multi_backend = True set | 14:00 |
jgriffith | from volume-feature-enabled | 14:00 |
flip214 | jgriffith: just what I pasted 6 mins ago ... ;) | 14:00 |
jgriffith | WTF | 14:00 |
flip214 | where does that come from? I guess the additional comma! | 14:00 |
jgriffith | then WTF is your question! | 14:01 |
jgriffith | yes | 14:01 |
*** Yogi12 has joined #openstack-cinder | 14:01 | |
jgriffith | get rid of the crappy formatting of your enabled-backends line | 14:01 |
*** juzuluag has joined #openstack-cinder | 14:01 | |
jgriffith | which is why I pointed you to a working localrc file | 14:01 |
jgriffith | flip214: I even offered to test it for you later today :) | 14:01 |
flip214 | got it. | 14:02 |
flip214 | if [[ -n "$CINDER_ENABLED_BACKENDS" ]] && [[ $CINDER_ENABLED_BACKENDS =~ .*,.* ]]; then | 14:02 |
flip214 | iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend "True" | 14:02 |
jgriffith | flip214: but honestly you can do this easily yourself | 14:02 |
flip214 | jgriffith: yes, thanks! | 14:02 |
jgriffith | flip214: just deploy devstack with that localrc on your own machine | 14:02 |
*** rushil_ has joined #openstack-cinder | 14:02 | |
*** dustins has quit IRC | 14:02 | |
flip214 | jgriffith: of course I can follow the various links ... | 14:02 |
jgriffith | see what the tempest conf ends up being | 14:02 |
flip214 | and/or deploy it. | 14:02 |
flip214 | but each of that takes quite some time. | 14:02 |
*** breitz has quit IRC | 14:02 | |
jgriffith | flip214: yeah... sorry, I know you can :) | 14:02 |
*** gouthamr has quit IRC | 14:02 | |
flip214 | If I'm lucky, I'Ve got an answer here in 3 mins or so ... at least that's what I hoped! | 14:02 |
*** gouthamr has joined #openstack-cinder | 14:02 | |
flip214 | never mind, thank you all! | 14:03 |
jgriffith | flip214: LOL | 14:03 |
jgriffith | flip214: some mornings you win, some morning I show up :) | 14:03 |
*** breitz has joined #openstack-cinder | 14:03 | |
asselin_ | lol :) | 14:03 |
*** Yogi11 has quit IRC | 14:03 | |
*** rushil has quit IRC | 14:05 | |
jgriffith | flip214: https://github.com/openstack-dev/devstack/blob/master/lib/tempest#L468 | 14:06 |
jgriffith | flip214: ^^ That's the answer you were looking for | 14:06 |
jgriffith | flip214: and yes, back to the beginning, it's the syntax in your enabled_backends line | 14:06 |
*** lcurtis has joined #openstack-cinder | 14:07 | |
*** setmason has quit IRC | 14:09 | |
*** juzuluag has quit IRC | 14:09 | |
*** amoturi has joined #openstack-cinder | 14:11 | |
*** timcl has joined #openstack-cinder | 14:11 | |
*** xyang has joined #openstack-cinder | 14:13 | |
*** rmesta has joined #openstack-cinder | 14:13 | |
flip214 | jgriffith: one more question... the VolumesTypeV1Test uses u'storage_protocol': u'drbd', but I can't see where that comes from. | 14:13 |
flip214 | my driver returns a storage_protocol as "iSCSI" (which isn't that clean, next iteration uses target_driver.protocol), but it's still different... | 14:14 |
*** rmesta has left #openstack-cinder | 14:14 | |
jgriffith | flip214: not sure off the top of my head, but personally I set that in my conf file usually | 14:15 |
jgriffith | flip214: probably what I'd do if I were you | 14:15 |
jgriffith | flip214: make sure you're not reporting it back in cinder stats | 14:16 |
jgriffith | flip214: that's the other place that picks that up | 14:16 |
*** thangp has joined #openstack-cinder | 14:19 | |
*** dguryanov has joined #openstack-cinder | 14:20 | |
*** mtanino has joined #openstack-cinder | 14:21 | |
openstackgerrit | xing-yang proposed openstack/cinder: Add multiple pools support to VMAX driver https://review.openstack.org/189990 | 14:21 |
*** Yogi12 has quit IRC | 14:22 | |
*** zhonghua-lee has joined #openstack-cinder | 14:23 | |
*** Yogi1 has joined #openstack-cinder | 14:26 | |
*** nkrinner has quit IRC | 14:29 | |
*** lpabon has joined #openstack-cinder | 14:31 | |
*** timcl has quit IRC | 14:36 | |
*** Yogi11 has joined #openstack-cinder | 14:36 | |
*** timcl has joined #openstack-cinder | 14:37 | |
*** julim has quit IRC | 14:38 | |
*** simondodsley has joined #openstack-cinder | 14:39 | |
*** Yogi1 has quit IRC | 14:40 | |
*** openstackgerrit has quit IRC | 14:41 | |
*** openstackgerrit has joined #openstack-cinder | 14:41 | |
*** tsekiyama has joined #openstack-cinder | 14:47 | |
*** diogogmt has joined #openstack-cinder | 14:50 | |
*** zhonghua-li has joined #openstack-cinder | 14:50 | |
jgriffith | :resize | 14:51 |
*** nlevinki has quit IRC | 14:51 | |
*** timcl has quit IRC | 14:53 | |
*** zhonghua-lee has quit IRC | 14:53 | |
*** zhipeng has joined #openstack-cinder | 14:55 | |
*** Lee1092 has quit IRC | 14:55 | |
*** belmoreira has quit IRC | 14:57 | |
*** setmason has joined #openstack-cinder | 14:57 | |
*** anshul has quit IRC | 14:57 | |
*** patrickeast has joined #openstack-cinder | 14:58 | |
flip214 | jgriffith: is 80x24 not big enough for you? | 14:58 |
jgriffith | flip214: LOL | 14:58 |
jgriffith | flip214: that's actually the size of this window funny enough :) | 14:59 |
jgriffith | flip214: I was trying to get rid of my markers from another byobu session | 14:59 |
jgriffith | flip214: but was doing it in the wrong window :( | 14:59 |
*** afazekas has quit IRC | 14:59 | |
openstackgerrit | Bharat Kumar Kobagana (BharatK) proposed openstack/cinder: Using 'fallocate' instead of 'dd' to create raw volumes https://review.openstack.org/164527 | 15:03 |
*** dims_ has quit IRC | 15:03 | |
*** timcl has joined #openstack-cinder | 15:03 | |
*** kmartin has joined #openstack-cinder | 15:05 | |
*** crose has joined #openstack-cinder | 15:07 | |
*** dims has joined #openstack-cinder | 15:08 | |
*** dims has quit IRC | 15:08 | |
*** patrickeast has quit IRC | 15:08 | |
*** dims has joined #openstack-cinder | 15:08 | |
*** patrickeast has joined #openstack-cinder | 15:09 | |
*** bill_az has joined #openstack-cinder | 15:09 | |
*** patrickeast has quit IRC | 15:10 | |
*** patrickeast has joined #openstack-cinder | 15:10 | |
*** BharatK has quit IRC | 15:12 | |
jgriffith | e0ne: upated as per your comment https://review.openstack.org/#/c/187311/ | 15:12 |
*** Lee1092 has joined #openstack-cinder | 15:12 | |
*** julim has joined #openstack-cinder | 15:12 | |
e0ne | jgriffith: thanks! | 15:13 |
e0ne | jgriffith: may be I should wait to solidfire ci before +1:) | 15:15 |
*** jdurgin1 has joined #openstack-cinder | 15:15 | |
*** timcl has quit IRC | 15:15 | |
*** lpetrut has quit IRC | 15:15 | |
e0ne | sorry, before +2 | 15:16 |
*** mikedillion has joined #openstack-cinder | 15:16 | |
*** mikedillion has quit IRC | 15:18 | |
e0ne | jgriffith: i answered to your comment for https://review.openstack.org/#/c/156292/. please, review when you'll have a time | 15:20 |
*** leopoldj has quit IRC | 15:26 | |
*** jungleboyj has joined #openstack-cinder | 15:28 | |
thingee | patrickeast: yay internal tenant spec was already approved :) | 15:28 |
patrickeast | thingee: :D yea i saw | 15:29 |
patrickeast | things move fast once you threaten to approve things | 15:29 |
*** vokt has joined #openstack-cinder | 15:30 | |
openstackgerrit | Ph. Marek proposed openstack/cinder: Re-add DRBD driver. https://review.openstack.org/178573 | 15:31 |
thingee | jgriffith: looks like some disagreements here https://review.openstack.org/#/c/155644/ at least feedback is coming in | 15:32 |
jgriffith | e0ne: Is your last comment WRT the show command? | 15:32 |
jgriffith | e0ne: or the list command? | 15:32 |
*** sileht has quit IRC | 15:33 | |
*** pradipta has joined #openstack-cinder | 15:33 | |
jgriffith | e0ne: my point was I don't see value in options to list... if one would like details do a show; and even better make show take a list of ID's :) | 15:33 |
e0ne | jgriffith: it's about both og them | 15:33 |
e0ne | s/og/of | 15:34 |
jgriffith | e0ne: yeah, ok... I know the patch was, just wasn't sure on your comment | 15:34 |
jgriffith | e0ne: so I have my opinon, I'm certainly in the minority | 15:35 |
e0ne | jgriffith: but for now, we've got --details param (at least in REST API side) for list | 15:35 |
jgriffith | e0ne: and it is "me" so take that FWIW :) | 15:35 |
jgriffith | e0ne: yeah.. I hate that I have to say | 15:35 |
e0ne | jgriffith: :) | 15:35 |
jgriffith | e0ne: I'm a firm beliver in simple API's with few options | 15:36 |
jgriffith | e0ne: if you need a bunch of options hanging off of your API call, you likely need a new API call | 15:36 |
*** sileht has joined #openstack-cinder | 15:36 | |
jgriffith | e0ne: I'm not stongly enough opposed to fight about it, or get bummed out when it merges | 15:37 |
e0ne | jgriffith: i'm totally agree with you about simple API. but we need to support current api users:( | 15:37 |
jgriffith | e0ne: at the same time I'm not likely to change my opinion :( | 15:37 |
*** timcl has joined #openstack-cinder | 15:37 | |
jgriffith | e0ne: I don't understand that part (support current users), so maybe I'm missing an important detail? | 15:37 |
thingee | jgriffith: you mind if we throw replication v2 in the agenda for today? | 15:37 |
*** lpetrut has joined #openstack-cinder | 15:38 | |
e0ne | jgriffith: i mean, e.g. we can't remove --details param for list now because it is used by somebody | 15:38 |
*** sileht has quit IRC | 15:39 | |
jgriffith | e0ne: Ahh... got ya | 15:40 |
jgriffith | thingee: sure | 15:40 |
jgriffith | thingee: I mean "no" I don't mind | 15:40 |
jgriffith | e0ne: stupid call should've never been there :( | 15:40 |
*** sileht has joined #openstack-cinder | 15:40 | |
e0ne | jgriffith: agree | 15:40 |
jgriffith | e0ne: wait... | 15:41 |
jgriffith | e0ne: http://paste.openstack.org/show/281596/ | 15:41 |
e0ne | jgriffith: --details is used for list in client by default and we can't change it | 15:42 |
*** dulek has quit IRC | 15:42 | |
thingee | winston-d: you around? | 15:43 |
*** zhipeng has quit IRC | 15:43 | |
e0ne | jgriffith: at lease, for CLI. i'll check how it works in python api | 15:43 |
*** Daviey has quit IRC | 15:44 | |
*** jdurgin1 has quit IRC | 15:44 | |
e0ne | jgriffith: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/volumes.py#L286 - detailed=True by default | 15:45 |
jgriffith | e0ne: yeah, looking at that now | 15:45 |
jgriffith | e0ne: but that's nothing more than a flag for the view builder | 15:45 |
e0ne | jgriffith: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/shell.py#L225 - we don't pass 'detailed' param | 15:45 |
jgriffith | :( | 15:46 |
jgriffith | e0ne: Ok, what if we just updated list to return "more stuff" | 15:46 |
jgriffith | e0ne: make the detailed flag obsolete | 15:46 |
e0ne | jgriffith: sound good for me | 15:47 |
jgriffith | e0ne: either that or I just trust you and everyone else and remove my -1 :) | 15:47 |
jgriffith | e0ne: I need to look at what that does | 15:47 |
jgriffith | e0ne: ie how much more data | 15:47 |
*** garthb_ has joined #openstack-cinder | 15:49 | |
*** garthb has joined #openstack-cinder | 15:49 | |
e0ne | jgriffith: give me 2 mins, i'll find working env with cinder and compare data | 15:49 |
*** Daviey has joined #openstack-cinder | 15:50 | |
e0ne | jgriffith: it's from our docs: http://developer.openstack.org/api-ref-blockstorage-v2.html#getVolumesSimple | 15:50 |
jgriffith | e0ne: hly crap! | 15:51 |
jgriffith | e0ne: not your link | 15:51 |
jgriffith | e0ne: the view builder | 15:51 |
e0ne | jgriffith: :) | 15:51 |
jgriffith | e0ne: so that's what I was afraid of | 15:52 |
*** earlephilhower has joined #openstack-cinder | 15:52 | |
jgriffith | e0ne: it bascily spews out the same info as show | 15:52 |
jgriffith | e0ne: but for *every* volume :( | 15:53 |
e0ne | jgriffith: yes | 15:53 |
jgriffith | e0ne: Well I certainly don't want that to be the default :) | 15:53 |
e0ne | jgriffith: and even if use https://github.com/openstack/cinder/blob/master/cinder/api/v2/views/volumes.py#L44 we get all volumes data from DB | 15:53 |
*** jnicklin has joined #openstack-cinder | 15:54 | |
e0ne | jgriffith: looks lime my spec will be dropped in such case | 15:54 |
*** vokt has quit IRC | 15:54 | |
*** BharatK has joined #openstack-cinder | 15:56 | |
*** avishay has joined #openstack-cinder | 15:56 | |
*** dannywilson has joined #openstack-cinder | 15:56 | |
e0ne | jgriffith: so, we'll leave default list action as is, am I correct? | 15:57 |
e0ne | it returns only id and name | 15:57 |
*** avishay has quit IRC | 15:58 | |
*** lpetrut has quit IRC | 15:59 | |
*** vokt has joined #openstack-cinder | 16:01 | |
*** leeantho has joined #openstack-cinder | 16:01 | |
*** dustins_ is now known as dustins | 16:04 | |
*** adurbin_ has joined #openstack-cinder | 16:05 | |
*** rushiagr_away is now known as rushiagr | 16:06 | |
*** adurbin__ has joined #openstack-cinder | 16:06 | |
*** daneyon has joined #openstack-cinder | 16:06 | |
*** BharatK has quit IRC | 16:09 | |
*** gouthamr has quit IRC | 16:10 | |
*** dustins has quit IRC | 16:10 | |
*** annegentle has joined #openstack-cinder | 16:11 | |
*** gouthamr has joined #openstack-cinder | 16:11 | |
*** Apoorva has joined #openstack-cinder | 16:11 | |
*** _cjones_ has joined #openstack-cinder | 16:13 | |
*** BharatK has joined #openstack-cinder | 16:13 | |
*** gouthamr has quit IRC | 16:14 | |
*** jistr has quit IRC | 16:14 | |
*** rushil_ has quit IRC | 16:18 | |
*** dustins has joined #openstack-cinder | 16:22 | |
*** teju has left #openstack-cinder | 16:24 | |
*** e0ne is now known as e0ne_ | 16:25 | |
*** e0ne_ is now known as e0ne | 16:25 | |
*** vilobhmm has joined #openstack-cinder | 16:25 | |
openstackgerrit | Victor Stinner proposed openstack/cinder: Replace it.next() with next(it) for py3 compat https://review.openstack.org/190173 | 16:27 |
*** rushil has joined #openstack-cinder | 16:30 | |
*** zhonghua-li has quit IRC | 16:31 | |
*** annashen has joined #openstack-cinder | 16:32 | |
*** annashen has quit IRC | 16:37 | |
*** jordanP has quit IRC | 16:39 | |
*** timcl1 has joined #openstack-cinder | 16:39 | |
*** gouthamr has joined #openstack-cinder | 16:41 | |
*** timcl has quit IRC | 16:42 | |
*** amoturi has quit IRC | 16:44 | |
e0ne | jgriffith: need to head to home after the meeting. if you want we could continue to discuss 'detailed views' in ~2 hours | 16:45 |
openstackgerrit | Earle F. Philhower, III proposed openstack/cinder: Implement Cinder Volume driver for HGST Solutions https://review.openstack.org/186580 | 16:48 |
*** rakesh_mishra has quit IRC | 16:52 | |
*** diemt has joined #openstack-cinder | 16:52 | |
dguryanov | When third party CI should run? On every patch to cinder? | 16:53 |
jgriffith | e0ne: sure | 16:53 |
*** dannywilson has quit IRC | 16:53 | |
thingee | dguryanov: yes | 16:53 |
dguryanov | I see | 16:53 |
e0ne | dguryanov: yes | 16:53 |
thingee | dguryanov: make sure to read https://wiki.openstack.org/wiki/Cinder/how-to-contribute-a-driver | 16:53 |
diemt | thingee: I'd really appreciate if you could let me know the soak time before the Oracle iSCSI driver is moved to "ready" section | 16:54 |
thingee | dguryanov: which links to https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers | 16:54 |
thingee | diemt: I've typically done an arbitrary number. I'll take a closer look when I have a chance. | 16:54 |
openstackgerrit | Victor Stinner proposed openstack/cinder: Replace urllib and urllib2 with six.moves.urllib https://review.openstack.org/189724 | 16:55 |
thingee | number of days that is | 16:55 |
diemt | thingee: Thank you!!! I really hope the driver can meet the L1 deadline | 16:56 |
*** annegentle has quit IRC | 16:56 | |
*** gouthamr has quit IRC | 16:56 | |
*** BharatK has quit IRC | 16:56 | |
*** timcl1 has quit IRC | 16:56 | |
*** asselin has joined #openstack-cinder | 16:56 | |
*** sreedharv_ has joined #openstack-cinder | 16:57 | |
*** gouthamr has joined #openstack-cinder | 16:57 | |
vilobhmm | e0ne : regarding https://review.openstack.org/#/c/185704/7 | 16:57 |
e0ne | vilobhmm: hi | 16:59 |
vilobhmm | will remove the 'if' statement in next patch…the motive was to check if the column already exist or not | 16:59 |
vilobhmm | but since we are creating it for first time it should be fine | 16:59 |
*** BharatK has joined #openstack-cinder | 16:59 | |
e0ne | vilobhmm: why it could exist? | 16:59 |
vilobhmm | will it be ok with you if i remove it in next patch | 16:59 |
vilobhmm | not needed to be frank…just defensive prog | 16:59 |
e0ne | :) | 17:00 |
e0ne | vilobhmm: is if it's not needed - we should to remove it from the code | 17:00 |
vilobhmm | yup! | 17:01 |
e0ne | imo, defensive programming is good, but not need to use it everywhere | 17:01 |
e0ne | thanks. | 17:01 |
e0ne | need to go offline. bb in ~2 hours | 17:01 |
vilobhmm | updated the patch | 17:02 |
openstackgerrit | Vilobh Meshram proposed openstack/cinder: Nested Quota : Create allocated column in cinder.quotas https://review.openstack.org/185704 | 17:02 |
vilobhmm | please check when you are back | 17:02 |
vilobhmm | e0ne : ^^ | 17:03 |
*** vokt has quit IRC | 17:03 | |
tbarron | thingee: w.r.t. https://etherpad.openstack.org/p/cinder-log-cleanup, what are the "cleanup" standards? Just the hacking/log guidelines? | 17:03 |
*** amoturi has joined #openstack-cinder | 17:03 | |
*** timcl has joined #openstack-cinder | 17:04 | |
thingee | tbarron: jgriffith asked if we can keep stuff in his original etherpad https://etherpad.openstack.org/p/cinder-code-cleanups ...sorry if I'll correct that. | 17:05 |
*** spradeepv_ has joined #openstack-cinder | 17:07 | |
*** gouthamr has quit IRC | 17:08 | |
tbarron | thingee: thanks. so the work here is to convert codebase to resource-tag style logging then as I understand it | 17:08 |
tbarron | jgriffith: that right? | 17:09 |
tbarron | just need to understand what I would be signing up for :-) | 17:09 |
flip214 | thingee: I'm sorry, my kids kept me away from the meeting. Reading through the logs, do I understand correctly that when I get the CI for DRBD working I may move the block in https://etherpad.openstack.org/p/cinder-liberty-drivers from "Not ready" to "Ready"? | 17:09 |
*** gouthamr has joined #openstack-cinder | 17:11 | |
*** e0ne has quit IRC | 17:11 | |
*** lpetrut has joined #openstack-cinder | 17:11 | |
thingee | yes | 17:12 |
*** timcl has quit IRC | 17:19 | |
*** spradeepv_ has quit IRC | 17:21 | |
*** daneyon has quit IRC | 17:21 | |
*** annashen has joined #openstack-cinder | 17:23 | |
tbarron | jgriffith: OK, I see what to do in the etherpad now. | 17:23 |
tbarron | jgriffith: I'm willing to help ... | 17:23 |
jgriffith | tbarron: sweet | 17:24 |
*** pradipta has quit IRC | 17:24 | |
tbarron | jgriffith: are you going to break out the work into modules that we can sign up for? | 17:25 |
jgriffith | tbarron: nope, you can do that on your own :) | 17:25 |
*** markus_z has quit IRC | 17:25 | |
tbarron | jgriffith: kk :-) | 17:26 |
jgriffith | tbarron: just pick a file and go with it... and mark on the etherpad that you're working on it so somebody else doesn't come along and duplicate your efforts | 17:26 |
flip214 | thingee: thanks. | 17:28 |
openstackgerrit | Earle F. Philhower, III proposed openstack/cinder: Implement Cinder Volume driver for HGST Solutions https://review.openstack.org/186580 | 17:29 |
openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor 5 NFS backend driver. https://review.openstack.org/190273 | 17:30 |
*** belmoreira has joined #openstack-cinder | 17:30 | |
*** aix has quit IRC | 17:33 | |
openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor 5 NFS backend driver. https://review.openstack.org/190273 | 17:33 |
*** krtaylor has quit IRC | 17:37 | |
*** zul has quit IRC | 17:38 | |
*** changbl has joined #openstack-cinder | 17:40 | |
*** daneyon has joined #openstack-cinder | 17:40 | |
*** jdandrea has joined #openstack-cinder | 17:40 | |
*** zul has joined #openstack-cinder | 17:40 | |
*** Yogi11 has quit IRC | 17:41 | |
*** IlyaG has joined #openstack-cinder | 17:41 | |
jdandrea | Given a host with SSDs and HDDs, is there a way for a scheduler plugin to specify which of those types (or even which specific drive) should be used on that host? If this is in the docs, bear with me. Still looking for that info ... | 17:41 |
jdandrea | Rephrasing: Is there a way for a scheduler plugin to specify "Use a SSD on host X" or "Use SSD drive Y on host X." | 17:42 |
*** garthb_ has quit IRC | 17:44 | |
*** garthb has quit IRC | 17:44 | |
*** rushil has quit IRC | 17:45 | |
*** agarciam has joined #openstack-cinder | 17:47 | |
*** sgotliv_ has quit IRC | 17:49 | |
*** dannywilson has joined #openstack-cinder | 17:56 | |
*** annegentle has joined #openstack-cinder | 17:56 | |
*** harlowja has quit IRC | 17:58 | |
*** krtaylor has joined #openstack-cinder | 17:59 | |
*** dannywil_ has joined #openstack-cinder | 18:00 | |
*** dannywilson has quit IRC | 18:00 | |
*** harlowja has joined #openstack-cinder | 18:02 | |
*** bswartz has quit IRC | 18:02 | |
*** bswartz has joined #openstack-cinder | 18:02 | |
*** annegentle has quit IRC | 18:02 | |
*** gouthamr has quit IRC | 18:09 | |
*** annashen has quit IRC | 18:09 | |
*** gouthamr has joined #openstack-cinder | 18:09 | |
*** annegentle has joined #openstack-cinder | 18:12 | |
*** daneyon has quit IRC | 18:14 | |
*** daneyon has joined #openstack-cinder | 18:16 | |
*** annashen has joined #openstack-cinder | 18:17 | |
*** angela-s has joined #openstack-cinder | 18:18 | |
*** rushiagr is now known as rushiagr_away | 18:23 | |
*** timcl has joined #openstack-cinder | 18:26 | |
*** daneyon has quit IRC | 18:26 | |
openstackgerrit | John Griffith proposed openstack/cinder: Add a base FC target driver https://review.openstack.org/190291 | 18:27 |
*** ronenkat_ has joined #openstack-cinder | 18:34 | |
*** agarciam has quit IRC | 18:34 | |
*** gouthamr has quit IRC | 18:38 | |
*** cbader has quit IRC | 18:39 | |
*** gouthamr has joined #openstack-cinder | 18:40 | |
*** dustins has quit IRC | 18:40 | |
*** dustins has joined #openstack-cinder | 18:43 | |
*** gouthamr has quit IRC | 18:46 | |
*** julim has quit IRC | 18:49 | |
*** e0ne has joined #openstack-cinder | 18:52 | |
e0ne | vilobhmm: thanks for fix! let's wait for CI | 18:53 |
*** rhagarty_ has joined #openstack-cinder | 18:53 | |
*** rhagarty_ has quit IRC | 18:54 | |
*** Lee1092 has quit IRC | 18:55 | |
*** gouthamr has joined #openstack-cinder | 18:57 | |
*** e0ne has quit IRC | 18:57 | |
*** zhonghua-lee has joined #openstack-cinder | 19:00 | |
*** e0ne has joined #openstack-cinder | 19:00 | |
*** e0ne has quit IRC | 19:05 | |
vilobhmm | e0ne : thanks for reviewing it :) sure | 19:06 |
*** timcl has quit IRC | 19:11 | |
*** timcl has joined #openstack-cinder | 19:14 | |
*** timcl1 has joined #openstack-cinder | 19:17 | |
*** vokt has joined #openstack-cinder | 19:19 | |
*** Yogi1 has joined #openstack-cinder | 19:19 | |
*** timcl has quit IRC | 19:19 | |
*** zhonghua-lee has quit IRC | 19:20 | |
openstackgerrit | John Griffith proposed openstack/cinder: Add secondary account capability to SolidFire https://review.openstack.org/187311 | 19:24 |
*** gouthamr has quit IRC | 19:31 | |
*** gouthamr has joined #openstack-cinder | 19:39 | |
*** rushil has joined #openstack-cinder | 19:42 | |
*** BharatK has quit IRC | 19:43 | |
*** sreedharv_ has left #openstack-cinder | 19:49 | |
*** rushil has quit IRC | 19:51 | |
*** lpabon has quit IRC | 19:53 | |
*** aix has joined #openstack-cinder | 19:53 | |
hemna | jgriffith, thingee so the os-brick patches now are getting CI'd against cinder. | 19:53 |
hemna | just verified that it's running and is working | 19:53 |
hemna | for example, https://review.openstack.org/#/c/188159/ | 19:54 |
thingee | hemna: excellent! | 19:54 |
hemna | that one is an iSCSI change as well, which would directly affect most of Cinder drivers as well as lvm | 19:54 |
hemna | http://logs.openstack.org/59/188159/4/check/gate-tempest-dsvm-neutron-src-os-brick/08b7c38/logs/devstacklog.txt.gz | 19:54 |
hemna | the logfile from the recheck against that patch that shows devstack pulling os-brick's patch and testing it against cinder, etc. | 19:54 |
thingee | nice | 19:55 |
hemna | asselin_, did all the heavy lifting for us. | 19:55 |
patrickeast | awesome, so it should be ready to point our 3rd party ci’s at os-brick now, right? | 19:56 |
asselin | patrickeast, yes | 19:56 |
asselin | patrickeast, you'll need a slightly different job | 19:56 |
hemna | patrickeast, yah, we are going to do that next....once our network is back up | 19:56 |
asselin | ours is running on silent...but out network is down | 19:57 |
patrickeast | asselin: what needs to change with the job? | 19:58 |
asselin | patrickeast, https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/devstack-gate.yaml#L158 | 19:58 |
asselin | name=os-brick | 19:58 |
*** annashen has quit IRC | 19:59 | |
earlephilhower | thingee: I just added HGST driver discussed at cinder-meeting to the cinder-liberty-drivers etherpad in the Not Ready: section. If I erred, apologies and I'll back it out post-haste. | 19:59 |
*** e0ne has joined #openstack-cinder | 20:00 | |
*** timcl1 has quit IRC | 20:01 | |
*** adurbin__ has quit IRC | 20:01 | |
openstackgerrit | Dmitry Guryanov proposed openstack/cinder: smbfs: fix invalid check for smbfs_user_ratio correctness https://review.openstack.org/190326 | 20:03 |
*** IlyaG has quit IRC | 20:03 | |
*** rushil has joined #openstack-cinder | 20:04 | |
jungleboyj | asselin: There? | 20:04 |
asselin | jungleboyj, i am | 20:04 |
*** julim has joined #openstack-cinder | 20:04 | |
jungleboyj | asselin: Hey man. Have you seen people struggling with this on their CI systems: "sudo: no tty present and no askpass program specified" | 20:05 |
asselin | jungleboyj, yes | 20:05 |
jungleboyj | I know that that can happen if you don't have sudo set up right. Is there anything special needed for it to work with devstack/CI ? | 20:05 |
asselin | asselin, well actually, no, I haven't seen ppl struggling, but yes I know the answer | 20:06 |
asselin | you need to make sure your sudoers file is setup right | 20:06 |
jungleboyj | asselin: Cool. That was what I thought. | 20:06 |
openstackgerrit | Sean Chen proposed openstack/cinder: Tintri driver to manage existing backend storage objects https://review.openstack.org/188535 | 20:08 |
*** rushil has quit IRC | 20:09 | |
jungleboyj | asselin: Looks like it is failing trying to run Debian commands. | 20:10 |
jungleboyj | sudo DEBIAN_FRONTEND=noninteractive | 20:10 |
asselin | jungleboyj, what's failing? whcih user is running the sudo command? | 20:10 |
earlephilhower | jungleboyj: If you're trying to use a static instance for running jobs, the devstack-gate may be eating the sudo permissions as part of its' devstack-gate scripts. For static host I think I had to add stack as sudoer in another file that's not touched by the ansible/puppet stuff. | 20:10 |
*** gouthamr has quit IRC | 20:10 | |
asselin | jungleboyj, what earlephilhower said is true. the tests remove sudo permissions for the stack user | 20:11 |
jgriffith | "HOLY I"m running automated six patching tools"!!!! https://review.openstack.org/#/q/owner:vstinner%2540redhat.com+status:open,n,z | 20:11 |
jgriffith | note.. folks need to NOT just blindly + these | 20:11 |
asselin | jungleboyj, but don't reuse nodes.... | 20:12 |
jgriffith | and frankly we need to decide if this crap is even worthwhile | 20:12 |
*** amoturi has quit IRC | 20:12 | |
smcginnis | jgriffith: DuncanT had challenged an earlier patch. | 20:12 |
smcginnis | He actually does have an overall plan. | 20:12 |
earlephilhower | jungleboyj, asselin: +1 Definitely don't reuse hosts, nothing but pain. I spent 3 days and then gave in and had dynamic spinup running in a few hours... | 20:13 |
jgriffith | smcginnis: sure... that's not my point | 20:13 |
smcginnis | jgriffith: Sure, I get it. | 20:13 |
*** rushil has joined #openstack-cinder | 20:13 | |
jgriffith | https://review.openstack.org/#/c/190163/ | 20:13 |
jungleboyj | asselin: Ok. This was a question from Sasi who is trying to get the CI system reconfigured for GPFS. Going to send a note back to him. | 20:13 |
jgriffith | https://review.openstack.org/#/c/185418/ | 20:13 |
hemna | holy carp | 20:14 |
jgriffith | For examples | 20:14 |
smcginnis | jgriffith: Just wanted to point out it's not the case of someone finding a cool tool and just throwing up the output. :) | 20:14 |
hemna | are we in a rage to move to py3 ? | 20:14 |
jgriffith | personally I think we should avoid the use of six if/when possible | 20:14 |
jgriffith | it just introduces the next compatability thing to go through and scrub some day in the future | 20:14 |
DuncanT | smcginnis: the plan has already grown new legs, and more six... I'm not happy tbh | 20:14 |
jgriffith | Besides... EVERYBODY knows python3 is dead!! :) | 20:14 |
jgriffith | python4 will be out soon and revert everything back :) | 20:15 |
smcginnis | Hah | 20:15 |
DuncanT | smcginnis: I'm back to wanting to see a finished tree tbh | 20:15 |
jgriffith | So I'm fine with most of them, IFF there some testing/gating added | 20:15 |
jgriffith | because a few of these we've already done once :) | 20:15 |
smcginnis | DuncanT: So should we push that all get combined into a megapatch that gets to the end game? | 20:16 |
jgriffith | smcginnis: hush now | 20:16 |
smcginnis | DuncanT: That doesn't seem ideal either. | 20:16 |
hemna | http://opensource.com/life/14/9/why-python-4-wont-be-python-3 | 20:16 |
jgriffith | smcginnis: I just threw up in my mouth a little | 20:16 |
jungleboyj | asselin: earlephilhower Thanks for confirming that it is a sudoers issue. | 20:16 |
jgriffith | hemna: that's what I'm saying :) | 20:16 |
smcginnis | jgriffith: :) | 20:16 |
jgriffith | hemna: but as long as it's taken for py3 adoption I probably won't see py4 in my lifetime anyway | 20:17 |
jgriffith | By then I'll have rewritten all of Cinder in GoLang anyway | 20:17 |
DuncanT | smcginnis: no, a GitHub tree that has all these patches on and works with python 3 | 20:17 |
jgriffith | Or 'C' | 20:17 |
hemna | heh yah, the guy writing that article says py4 in 2023 | 20:17 |
smcginnis | DuncanT: OK, I like. | 20:17 |
smcginnis | DuncanT: That would be nice to see. | 20:18 |
DuncanT | jgriffith: I've got a working cinder-backup in c, much better performance | 20:18 |
smcginnis | He's going to need a lot of help. He's trying to do this for several projects. | 20:18 |
jgriffith | :) | 20:18 |
DuncanT | (For given values of working) | 20:18 |
smcginnis | So... should we block all of these patches and discuss a better plan in the next meeting? | 20:19 |
smcginnis | Seems like a bigger thing to decide openstack-wide "screw py3, wait for py4" :) | 20:20 |
hemna | GoLang....lol. *sigh* | 20:20 |
*** gouthamr has joined #openstack-cinder | 20:21 | |
smcginnis | jgriffith: Just for my education - what's the issue with six.moves.range? | 20:21 |
smcginnis | He does call out in the commit why he's not going with the built in range. | 20:22 |
*** haypo has joined #openstack-cinder | 20:22 | |
smcginnis | Though I could see the argument for not using six.iteritems() applying here as well. | 20:22 |
haypo | jgriffith, hi. i'm the python3 guy :) | 20:22 |
smcginnis | http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html | 20:22 |
jgriffith | haypo: Hi!! :) | 20:22 |
jgriffith | Nice to meet ya | 20:22 |
smcginnis | haypo: Cool! | 20:23 |
haypo | jgriffith, i'm surprised that you approved https://review.openstack.org/#/c/190169/ whereas the patch has no vote yet | 20:23 |
haypo | jgriffith, i described a little bit my plan for py3 in cinder, in the latest comment of https://review.openstack.org/#/c/190160/ | 20:24 |
jgriffith | haypo: I do that a lot :) | 20:24 |
jgriffith | haypo: I trust ya... and I cheated and looked at Zuul | 20:24 |
jgriffith | haypo: notice it's there now :) | 20:24 |
tbarron | So is there a place for oslo_log in unit tests? | 20:24 |
tbarron | not mocked out, but LOG.debug, etc. run from the unit test itself? | 20:25 |
jgriffith | haypo: and I actually only meant to +2, not a +A | 20:25 |
jgriffith | tbarron: yeah, in oslo.log | 20:25 |
jgriffith | where it belongs | 20:25 |
tbarron | I see this e.g. in /cinder/tests/unit/api/contrib/test_backups.py | 20:25 |
tbarron | jgriffith: :-) | 20:25 |
jgriffith | haypo: Ahh... cool | 20:26 |
jgriffith | that's great | 20:26 |
*** annegentle has quit IRC | 20:26 | |
jgriffith | haypo: ^^ | 20:26 |
haypo | jgriffith, that's what i expected (+2, not +A) | 20:26 |
jgriffith | haypo: can I offer some advice? | 20:26 |
jgriffith | haypo: and really.. you can say "no" if you like ;) | 20:26 |
jgriffith | haypo: haha... I'll take silence as a "yes" just because I like to hear what I have to say to myself :) | 20:27 |
jgriffith | haypo: rather than wait and batch the py34 tests until everything is fixed do it in segments | 20:28 |
tbarron | jgriffith: my naive view was that, except for unit testing oslo.log itself, unit tests shouldn't actually be doing logging. | 20:28 |
haypo | jgriffith, i'm not interested to write hacking rules, i'm more interested to see tests which pass | 20:28 |
jgriffith | haypo: and ignore/regex the errors you've fixed | 20:28 |
jgriffith | haypo: I agree with you WRT the hacking rules | 20:28 |
smcginnis | tbarron: +1 | 20:28 |
jgriffith | haypo: that would be my last choice | 20:28 |
tbarron | they should likely be mocking it out, or just letting the code under test log, but should not do logging themselves. | 20:28 |
jgriffith | haypo: I think your plan of a py34 test if fantastic | 20:28 |
smcginnis | haypo: Glad to see the tox -e py34 work. | 20:28 |
jgriffith | and could be done similarly to what was tried with pylint | 20:29 |
tbarron | smcginnis: I'll likely submit some reviews with that cleanup then. | 20:29 |
jgriffith | tbarron: that's not a naive view, that's a TRUE statement of fact!!!! | 20:29 |
smcginnis | tbarron: Cool, thanks Tom. | 20:29 |
*** rushil has quit IRC | 20:29 | |
haypo | jgriffith, what do you mean by "do it in segments"? | 20:30 |
jgriffith | haypo: two options | 20:30 |
tbarron | I know eharney has been looking for weird, unexplained external effects between unit tests | 20:30 |
jgriffith | haypo: run the test before 190160 | 20:30 |
tbarron | and this could be one candidate I guess. | 20:30 |
jgriffith | haypo: then run it after | 20:30 |
jgriffith | have a regex for everything that "still fails between them" | 20:31 |
*** rushil has joined #openstack-cinder | 20:31 | |
tbarron | jgriffith: glad to know the world is round as I thought :-) | 20:31 |
jgriffith | you know... like a white-list/black-list of errors | 20:31 |
jgriffith | haypo: or the other option... | 20:31 |
jgriffith | haypo: run the test against master, compare it to what you get on a patch | 20:31 |
jgriffith | haypo: verify the error count does not increase | 20:31 |
jgriffith | haypo: the second option is heavier but probably MUCH better | 20:32 |
*** lpetrut has quit IRC | 20:32 | |
*** IlyaG has joined #openstack-cinder | 20:32 | |
haypo | jgriffith, for nova, glance_store, neutron, etc. we are using a whitelist of tests which pass | 20:32 |
*** julim has quit IRC | 20:33 | |
jgriffith | haypo: your call | 20:33 |
jgriffith | haypo: I think that's fine as well | 20:33 |
*** gouthamr has quit IRC | 20:33 | |
*** akerr has quit IRC | 20:33 | |
jgriffith | haypo: I was just saying I'd like to see that turned on in conjunction with the patches/fixes you're submitting | 20:33 |
haypo | jgriffith, currently, nova has exactly 1 test running on python 3.4 :-D https://github.com/openstack/nova/blob/master/tox.ini#L44 | 20:34 |
*** dustins has quit IRC | 20:34 | |
jgriffith | haypo: because there are likely patches in the queue that will just introduce the issue you just fixed | 20:34 |
openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor 5 NFS backend driver. https://review.openstack.org/190273 | 20:34 |
jgriffith | haypo: I can prove that by writing a few and submitting them myself | 20:34 |
smcginnis | lol | 20:34 |
jgriffith | haypo: yeah, I'm aware, and that's why I get a bit skeptical of the py3 stuff everytime it comes up (since Portland) | 20:34 |
jgriffith | haypo: but... you're here now :) | 20:35 |
jgriffith | haypo: and you're already off to a much better start than we've had in the past | 20:35 |
*** e0ne has quit IRC | 20:35 | |
haypo | jgriffith, if you review patches, you should now be aware of python3 traps like https://wiki.openstack.org/wiki/Python3#Common_patterns ;-) | 20:36 |
jgriffith | haypo: "should" is the key word there | 20:36 |
haypo | jgriffith, it's not a big deal if python3 compatibility "regressions" are added, it's easy to fix them | 20:36 |
jgriffith | haypo: we're all human | 20:36 |
haypo | i even have a tool for that ;) | 20:36 |
jgriffith | haypo: yes, but my point is that's what we've "been doing" for almost 2 years now | 20:37 |
jgriffith | haypo: your round of py3 patches is not the first | 20:37 |
*** dannywilson has joined #openstack-cinder | 20:37 | |
jgriffith | haypo: and my point is that without something checking/monitoring it won't be the last | 20:37 |
jgriffith | we'll NEVER get there this way | 20:37 |
jgriffith | EVER | 20:37 |
haypo | jgriffith, i'm not sure that it was feasible to port cinder 6 months ago. there were big dependency issues like eventlet which were not compatible with python 3 | 20:37 |
jgriffith | sigh | 20:38 |
jgriffith | ok | 20:38 |
*** hemna is now known as hemnafk | 20:38 | |
jgriffith | So basicly what you're saying to me is "thanks for your opinion, I don't care what you think.. so piss off" | 20:38 |
jgriffith | which is fine | 20:38 |
haypo | jgriffith, the last dep not py3 compatible was rtslib-fb. i ported it, the release 2.1.56 supports python 3 | 20:38 |
*** gouthamr has joined #openstack-cinder | 20:38 | |
haypo | jgriffith, i'm not saying that | 20:39 |
jgriffith | haypo: Oh... ok, wasn't sure | 20:39 |
jgriffith | haypo: like I said, that's "ok too" | 20:39 |
haypo | sorry, i'm doing something else at the same time, i have to reread the discussion | 20:39 |
jgriffith | I wouldn't blame you if you were; it's perfectly legit | 20:39 |
*** dannywil_ has quit IRC | 20:39 | |
haypo | i also helped to port many oslo code. my point is that we are close to being able to have a minimal py34 test which pass | 20:40 |
*** xyang has quit IRC | 20:40 | |
*** IlyaG has quit IRC | 20:40 | |
jgriffith | haypo: understood... and I think that's AWESOME | 20:41 |
jgriffith | haypo: I'm certainly not saying I don't like or appreciate the effort | 20:41 |
jgriffith | haypo: I'm just saying I *personally* would love to see something to keep us from just re-inroducing things you fix as much as possible | 20:41 |
haypo | i'm running tox -e py34 to check :) | 20:41 |
jgriffith | haypo: and I stand by my votes/opinion on things like iter values | 20:41 |
haypo | with https://review.openstack.org/#/c/184369/ you should be able to create the py34 venv | 20:44 |
jgriffith | haypo: Oh, crap! | 20:44 |
jgriffith | I hadn't even seen that! | 20:45 |
haypo | jgriffith, it's the last dep not compatible with py3, mysql-python | 20:45 |
jgriffith | haypo: yeah.. thanks for pointing it out | 20:45 |
jgriffith | thingee: smcginnis DuncanT ^^ | 20:46 |
jgriffith | that's well worth landing IMHO | 20:46 |
*** diemt has quit IRC | 20:47 | |
smcginnis | I'd like to see vincent's question answered. | 20:47 |
smcginnis | I'm assuming there will be some differences. No? | 20:47 |
smcginnis | Or ideally all libraries are available on either and we're good. haypo, do you happen to know? | 20:48 |
*** ganso_ has quit IRC | 20:48 | |
haypo | smcginnis, rtslib-fb was supposed to be the latest dep not compatible with py3, and i just ported it | 20:49 |
haypo | smcginnis, that's why i started to flood you with py3 patches :) | 20:50 |
smcginnis | haypo: Works for me. Thanks! | 20:50 |
jgriffith | haypo: about the use of L | 20:52 |
jgriffith | haypo: does my comment/concern make any sense at all? | 20:52 |
haypo | jgriffith, like 123L? | 20:52 |
jgriffith | xylan_kong: https://review.openstack.org/#/c/190152/ | 20:52 |
jgriffith | hemnafk: ^^ | 20:52 |
jgriffith | haypo: yes | 20:52 |
jgriffith | seems only HP and EMC are using them | 20:53 |
jgriffith | haypo: and honestly the one HP has shouldn't be there anyway | 20:53 |
jgriffith | haypo: they should be using the unit lib | 20:53 |
haypo | jgriffith, "My point is, for systems running on 2.X still, they may have made these Longs for a reason and this patch breaks that." well, i should review my patch, but usually there is no reason for using a long | 20:53 |
*** thangp has quit IRC | 20:54 | |
jgriffith | oops | 20:55 |
jgriffith | haypo: ok.. withdrew that one | 20:56 |
jgriffith | haypo: standing by the other ones still though :) | 20:56 |
haypo | jgriffith, hum, i don't see any modified code which looks to rely on the exact type | 20:56 |
*** daneyon has joined #openstack-cinder | 20:56 | |
jgriffith | haypo: correct, that's why I just went ahead and change from -1 to +1 on that patch | 20:56 |
haypo | jgriffith, the exact type (int or long) matters when the type is used. i saw such code to choose a function depending on the type. i saw that in glance_store and i added a "if six.PY2: test.append(long)" for that (something like that) | 20:57 |
*** annashen has joined #openstack-cinder | 20:57 | |
haypo | jgriffith, maybe i missed something. well, that's the purpose of reviews :) | 20:57 |
patrickeast | asselin: hemnafk: ok, the pure storage ci should be watching brick changes now, i modified the jobs to add the export DEVSTACK_PROJECT_FROM_GIT='os-brick' as needed | 20:57 |
asselin | patrickeast, ok cool | 20:57 |
patrickeast | asselin: hemnafk: i’ll keep an eye on it, but please do let me know if you see it doing something weird | 20:58 |
mriedem | sdague: kind of thinking out loud question, if i want to add objects to os-brick for cinder to use, but need to test it all together, would the Depends-On tag handle that for me? | 20:58 |
mriedem | so the cinder change to use the objects from os-brick would have depends-on the os-brick change that adds the objects | 20:59 |
mriedem | then iterate until it's working, release os-brick with the objects, pin min version of os-brick so cinder can use it and then cash in | 20:59 |
patrickeast | :( now i need to figure out how to get more FC worker nodes | 21:00 |
patrickeast | our FC tests are backed up almost 10 hours | 21:01 |
thingee | patrickeast: whoa | 21:01 |
patrickeast | i’ve only got a single ‘live’ one running at a time | 21:01 |
patrickeast | and like 8 iscsi | 21:01 |
patrickeast | so the test results are all blocked | 21:01 |
*** jdurgin1 has joined #openstack-cinder | 21:01 | |
*** gouthamr has quit IRC | 21:02 | |
smcginnis | patrickeast: Same. | 21:03 |
smcginnis | Waiting for a gate outage so we can catch up. ;) | 21:03 |
haypo | i tried tox -e py34 on cinder. i had to replace mysql-python with pymysql, run sixer.py with operations six_moves,raise,basestring,iteritems,long. with 2 or 3 more changes, i'm able to run cinder.tests.unit.test_quota and only 6 tests failed on a total of 71 tests | 21:03 |
patrickeast | haha | 21:03 |
*** belmoreira has quit IRC | 21:04 | |
patrickeast | i’ve got some more hardware, but am having a hell of a time trying to get the networking correct adding them at my existing openstack installation | 21:04 |
*** jdurgin has quit IRC | 21:04 | |
thingee | patrickeast: ditto | 21:06 |
openstackgerrit | John Griffith proposed openstack/cinder: Add a base FC target driver https://review.openstack.org/190291 | 21:10 |
*** Yogi1 has quit IRC | 21:13 | |
asselin | patrickeast, thingee smcginnis so I though of a way to ease the issue you're having ^^ | 21:13 |
asselin | at least for those using zuul | 21:14 |
asselin | but not 100% kosher | 21:14 |
earlephilhower | patrickeast: "having a hell of a time getting the networking correct"....makes me feel better about spending a XX late nights setting up my own boxen...seems even the experts have trouble w/OS networking. :) | 21:14 |
jgriffith | nova-network FTW!!! | 21:14 |
patrickeast | asselin: sounds perfect | 21:14 |
asselin | earlephilhower, I gave up a long time ago | 21:14 |
patrickeast | jgriffith: i switched to nova-network and am still having problems! | 21:15 |
patrickeast | well | 21:15 |
patrickeast | half switched | 21:15 |
thingee | jgriffith: yeah still running with nova network | 21:15 |
jgriffith | patrickeast: dang! | 21:15 |
patrickeast | i left one by itself, and started a ‘new’ cloud | 21:15 |
*** rushil has quit IRC | 21:15 | |
asselin | earlephilhower, I stil have patrickeast's and jgriffith's suggestions saves somewhere, but cringe to think about it | 21:15 |
jgriffith | Oh... so it's the "other" half you're having trouble with | 21:15 |
patrickeast | that was using nova-network | 21:15 |
patrickeast | no no | 21:15 |
*** ociuhandu has quit IRC | 21:15 | |
patrickeast | both are broken | 21:15 |
jgriffith | patrickeast: you're having "half" the trouble :) | 21:15 |
patrickeast | in their own special ways | 21:15 |
* jgriffith doesn't believe it! | 21:15 | |
*** amoturi has joined #openstack-cinder | 21:15 | |
patrickeast | nova-network got me like 99% of the way there | 21:16 |
asselin | patrickeast, thingee smcginnis the idea is to run a 2nd pipeline like check to post results...similar to how jenkins uses check and gate. | 21:16 |
patrickeast | but the dhcp server refuses to let go of ips sometimes | 21:16 |
jgriffith | nova-net is a champ! As long as you're on Juno or earlier | 21:16 |
patrickeast | :( crap | 21:16 |
patrickeast | i did kilo | 21:16 |
jgriffith | patrickeast: hmm | 21:16 |
jgriffith | patrickeast: yeah, kilo and even Juno has a few "bugs" that are new | 21:16 |
asselin | patrickeast, thingee smcginnis this works since we're not voting, otherwise each pipepline result would overwrite the other | 21:17 |
jgriffith | patrickeast: because everybody "wants" neutron to be the future so bad | 21:17 |
jgriffith | patrickeast: lipstick on a pig IMO | 21:17 |
* asselin is on juno nova-networking | 21:17 | |
patrickeast | jgriffith: lol | 21:17 |
jgriffith | Soon enough NONE of use will be on nova-net | 21:17 |
* jgriffith checks his git repo for that nova-network fork he started | 21:18 | |
patrickeast | the problem i had with neutron is that it doesn’t really work for the model i want | 21:18 |
patrickeast | i dont want to tunnel iscsi networks through my network node | 21:18 |
jgriffith | patrickeast: the problem I have is it's not very frikin helpful :) | 21:18 |
jgriffith | If I were a network guru I wouldn't need/use openstack :) | 21:18 |
jgriffith | patrickeast: yeah! That's one that is CRAZY IMO | 21:19 |
patrickeast | i’ve come to realize that there is a certain level of complexity in your network configuration where neutron probably makes it easier and is the best option | 21:19 |
patrickeast | but my ci system is not that | 21:19 |
jgriffith | patrickeast: I mean.. really? Funnel traffic through a node? Oh... well use lbalancer. | 21:19 |
jgriffith | WTF... I don't want to! Why do I need a bunch of nodes just for networking :) | 21:19 |
jgriffith | crazy crazy | 21:19 |
patrickeast | definitely crazy | 21:19 |
smcginnis | If you're networking needs are simple, your networking management should be able to be simple. | 21:20 |
jgriffith | patrickeast: yeah.. in all seriousness, I know there are people that need/want that | 21:20 |
patrickeast | smcginnis: +1 | 21:20 |
jgriffith | I'm just not one of them :) | 21:20 |
*** anshul has joined #openstack-cinder | 21:20 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/186112 | 21:20 |
jgriffith | smcginnis: well said | 21:20 |
patrickeast | nova network with multi-host and flat dhcp is almost perfect for what i want | 21:20 |
patrickeast | get my vm’s bridged directly to the 10Gb iscsi | 21:20 |
patrickeast | perfect | 21:20 |
jgriffith | smcginnis: patrickeast now that there's big-tent I see no reason not to spend some time making a simple networking project | 21:21 |
jgriffith | with ZERO plugins | 21:21 |
patrickeast | we could call it proton | 21:21 |
jgriffith | oh... nice | 21:21 |
smcginnis | I'm in! :) | 21:21 |
jgriffith | I was thinking SNFSP | 21:22 |
jgriffith | simple-networks-for-simple-people | 21:22 |
patrickeast | haha | 21:22 |
earlephilhower | Proton == positive charge! +1 | 21:22 |
jgriffith | but I like proton.. A LOT | 21:22 |
smcginnis | Or SNFSM | 21:22 |
smcginnis | /people/minds/ :) | 21:22 |
smcginnis | +1 for proton. | 21:22 |
* jgriffith resembles that remark | 21:22 | |
*** jungleboyj has quit IRC | 21:24 | |
patrickeast | so i’ve asked in a bunch of places, but not in here yet, any of you guys know why this might happen? https://ask.openstack.org/en/question/66105/dnsmasq-dhcp-server-doesnt-lease-a-released-ip-address/ | 21:25 |
smcginnis | patrickeast: I had something funky like that. | 21:25 |
smcginnis | Turned out it was servicing external DHCP requests (yikes!) | 21:26 |
patrickeast | smcginnis: :O and were able to fix it?! | 21:26 |
patrickeast | oh interesting | 21:26 |
smcginnis | I never figured out what the root cause/misconfiguration was, but I just used ebtables to block it. | 21:26 |
smcginnis | Not sure if it's all related to this instance. | 21:26 |
haypo | jgriffith, back. i attended a swift meeting to discuss py3 too ;) | 21:27 |
jgriffith | haypo: you're going to be the py3 goto person! | 21:27 |
jgriffith | :) | 21:27 |
jgriffith | patrickeast: interesting... the case smcginnis has come up before | 21:28 |
jgriffith | patrickeast: might be worth trying to find that ID | 21:28 |
jgriffith | smcginnis: I did the same thing... bridged the wrong interface... took down our entire lab | 21:28 |
jgriffith | smcginnis: it was AWESOME!!!!!!!!!!!!!!!!!!!!!!!!!!!! | 21:28 |
patrickeast | lol | 21:28 |
haypo | jgriffith, for me, it's fine if some parts of cinder are not compatible with py3 immediatly, the idea is more to port code files one by one, but always ensure that there is no regression | 21:29 |
smcginnis | jgriffith: Mine just limped along filling the syslog for weeks until I noticed. | 21:29 |
haypo | jgriffith, a whitelist of tests in tox.ini is convenient for that | 21:29 |
smcginnis | jgriffith: But there is a guy here who also took down the lab. | 21:29 |
jgriffith | haypo: I think you and I agree | 21:29 |
haypo | jgriffith, if we compare the number of errors, it may block patches whereas nobody would have to bandwith to take care of py3 on specific parts of the code | 21:30 |
jgriffith | haypo: I know I had mentioned the diff approach, but the more I thought about that the worse it seemed | 21:30 |
jgriffith | haypo: meh... non-voting to start, get some stability; then at some point... that's life | 21:30 |
*** simondodsley has quit IRC | 21:31 | |
*** bnemec has quit IRC | 21:31 | |
*** smcginnis is now known as smcginnisafk | 21:31 | |
haypo | jgriffith, to be more factual, i expect a voting gate in 1 month | 21:32 |
*** jdurgin has joined #openstack-cinder | 21:32 | |
haypo | i don't really care if tox -e py34 only runs a single test | 21:32 |
*** jdurgin1 has quit IRC | 21:32 | |
haypo | the point is just to ensure that we cannot go back (as you wrote, i already happened in cinder) | 21:32 |
jgriffith | haypo: perfect | 21:33 |
jgriffith | haypo: that makes me happy | 21:33 |
haypo | jgriffith, for nova, i wrote a spec. it takes a lot of time to write a spec, so i didn't propose a spec for cinder, ceilometer, glance, swift, etc. (i'm porting all these app to py3) | 21:34 |
*** akerr has joined #openstack-cinder | 21:35 | |
haypo | but i understand that the plan can be non obvious if you don't spend you whole day on python 3 :-D | 21:35 |
haypo | jgriffith, is there something lighter than spec? | 21:35 |
*** vokt has quit IRC | 21:36 | |
*** vokt has joined #openstack-cinder | 21:37 | |
jgriffith | haypo: yeah, blueprint | 21:38 |
jgriffith | haypo: that would be more appropriate IMO, and much lighter weight | 21:38 |
haypo | ok, i may do that | 21:40 |
jgriffith | haypo: cool, let me know if you need help | 21:41 |
*** akerr has quit IRC | 21:44 | |
*** akerr has joined #openstack-cinder | 21:45 | |
openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor 5 NFS backend driver. https://review.openstack.org/190273 | 21:48 |
*** amoturi has quit IRC | 21:51 | |
*** marcusvrn has quit IRC | 21:54 | |
*** mriedem is now known as mriedem_away | 21:54 | |
*** crose has quit IRC | 21:55 | |
haypo | jgriffith, ok. i have to go. i will read comments on my patches tomorrow and try to reply. i hope that you know have a better view of the overall plan for cinder | 21:56 |
jgriffith | haypo: I do thanks | 21:56 |
jgriffith | haypo: have a good evening | 21:56 |
*** anshul has quit IRC | 22:01 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/os-brick: Add HGST Solutions connector https://review.openstack.org/186588 | 22:01 |
*** pschaef has joined #openstack-cinder | 22:03 | |
asselin | patrickeast, https://review.openstack.org/190373 | 22:04 |
*** pschaef has quit IRC | 22:04 | |
*** changbl has quit IRC | 22:05 | |
* patrickeast looking | 22:05 | |
*** __afazekas has quit IRC | 22:05 | |
*** salv-orlando has joined #openstack-cinder | 22:05 | |
patrickeast | asselin: nice, thats a good addition | 22:06 |
*** daneyon has quit IRC | 22:06 | |
patrickeast | asselin: i had been wondering how to segragate some hba’s for dev/playing around with stuff | 22:06 |
patrickeast | now i can just change the variable | 22:06 |
asselin | patrickeast, thanks...really liking having this code shared. big thanks for doing that | 22:06 |
asselin | yup :) | 22:06 |
asselin | was a bit tricky to do it...probably a better way, but this works | 22:07 |
patrickeast | you want i should merge it or wait for other folks? | 22:07 |
patrickeast | im not sure who all is watching/using these scripts right now | 22:07 |
asselin | patrickeast, I have mine setup to use a specific commit, so merging won't break my setup | 22:07 |
patrickeast | same | 22:08 |
patrickeast | merge it is :D | 22:08 |
asselin | yeah...manual testing. will do the official testing after you merge (to save time) | 22:08 |
patrickeast | asselin: hehe yea, speaking which i put some tasks on my backlog to set up some automated tests for these, would be nice to test just doing the FC passthrough and stuff on a VM real quick | 22:10 |
patrickeast | shouldn’t be too hard to set up i don’t think | 22:10 |
patrickeast | but need to get this other hardware online first :) | 22:10 |
asselin | patrickeast, yeah....on the back burner | 22:11 |
asselin | should do it sooner than later.... | 22:11 |
*** alexpilotti has quit IRC | 22:13 | |
*** akl_ has joined #openstack-cinder | 22:15 | |
*** alexpilotti has joined #openstack-cinder | 22:17 | |
*** salv-orlando has quit IRC | 22:18 | |
*** akerr has quit IRC | 22:23 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/cinder: Implement Cinder Volume driver for HGST Solutions https://review.openstack.org/186580 | 22:24 |
*** haypo has left #openstack-cinder | 22:26 | |
*** harlowja has quit IRC | 22:27 | |
*** akerr has joined #openstack-cinder | 22:28 | |
*** harlowja has joined #openstack-cinder | 22:32 | |
*** rushil has joined #openstack-cinder | 22:33 | |
*** jnicklin has quit IRC | 22:34 | |
*** rushil has quit IRC | 22:35 | |
*** salv-orlando has joined #openstack-cinder | 22:36 | |
*** akerr has quit IRC | 22:40 | |
*** leeantho has quit IRC | 22:41 | |
*** setmason has quit IRC | 22:43 | |
*** daneyon has joined #openstack-cinder | 22:44 | |
*** daneyon has quit IRC | 22:45 | |
*** daneyon has joined #openstack-cinder | 22:45 | |
openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor 5 NFS backend driver. https://review.openstack.org/190391 | 22:46 |
*** leeantho has joined #openstack-cinder | 22:52 | |
*** krtaylor has quit IRC | 22:54 | |
*** akl__ has joined #openstack-cinder | 22:58 | |
*** Adriano__ has quit IRC | 23:01 | |
*** Adriano_ has quit IRC | 23:01 | |
*** daneyon has quit IRC | 23:04 | |
*** vokt has quit IRC | 23:06 | |
*** daneyon has joined #openstack-cinder | 23:07 | |
jgriffith | asselin: thingee DuncanT smcginnisafk hemnafk tbarron patrickeast anteaya http://paste.openstack.org/show/282385/ | 23:07 |
jgriffith | ^^ Mabye we should think about getting a collective thing going with a bunch of us in the coming weeks to start hammering this stuff out | 23:08 |
tbarron | jgriffith: agreed. And FWIW I also find it annoying when logs download when clicked when one wants to view them. | 23:09 |
* patrickeast gets his pitchfork | 23:09 | |
patrickeast | jgriffith: yea its gotten pretty bad | 23:09 |
anteaya | well the logs can't download when clicked | 23:09 |
anteaya | so here is my suggestion | 23:10 |
anteaya | take one system on the list | 23:10 |
patrickeast | jgriffith: the number of ci systems that are voting in cinder has gone down by almost half since the deadline in Kilo | 23:10 |
anteaya | and have someone agree to approach the operators | 23:10 |
asselin | anteaya, +1 | 23:10 |
jgriffith | patrickeast: you noticed that as well :) | 23:10 |
jgriffith | anteaya: +1 | 23:10 |
asselin | I did this for 2 operators with positve success | 23:10 |
anteaya | start off by ensuring they know to access the ci.openstack.org third party requirements | 23:10 |
anteaya | it is possible that they want to comply and don't know how | 23:11 |
anteaya | help them find the answer or find someone who knows the answer | 23:11 |
jgriffith | asselin: I'd also like us to at least somewhat standardize on the directory structure and contents of the logs | 23:11 |
asselin | and offered to help, by e.g. linking to FAQ which shows how to make logs downloadable | 23:11 |
anteaya | invite them to attend a third party meeting | 23:11 |
asselin | jgriffith, agree..I vote for ....drum roll please....what jenkins does | 23:11 |
anteaya | if you get no response or a dismissal then note that | 23:11 |
jgriffith | asselin: yeah | 23:11 |
anteaya | I bet at least 50% of these issues will be addressed through a friendly conversation | 23:12 |
anteaya | and clean up is good | 23:12 |
jgriffith | anteaya: hmmm... you sure you wanna do that? | 23:12 |
openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor 5 NFS backend driver. https://review.openstack.org/190273 | 23:12 |
jgriffith | :) | 23:12 |
patrickeast | so, whos going to run point and contact the operators? | 23:12 |
asselin | I would also like ot see everyone use os-loganalyzer to filter log files | 23:12 |
asselin | by log level | 23:12 |
patrickeast | asselin: +1 | 23:12 |
jgriffith | asselin: let's walk before we run :) | 23:12 |
vilobhmm | jgriffith : ping..wheneven you are free | 23:12 |
asselin | jgriffith, yea...add it to the end of the list :) | 23:12 |
jgriffith | :) | 23:12 |
vilobhmm | whenever* | 23:13 |
anteaya | jgriffith: no I won't be approaching operators | 23:13 |
jgriffith | vilobhmm: gimmie just a minute | 23:13 |
anteaya | I suggest everyone take one account and try to talk to them | 23:13 |
vilobhmm | sure sure np | 23:13 |
tbarron | gotta run out but will check the backlog later tonight | 23:13 |
vilobhmm | jgtiffith : ^^ | 23:13 |
jgriffith | anteaya: sounds good, divide it up | 23:13 |
anteaya | I support anyone willing to help another operator | 23:13 |
anteaya | jgriffith: yes | 23:13 |
jgriffith | Ok, thanks everyone | 23:13 |
jgriffith | no need for me to sit here and rant | 23:13 |
asselin | jgriffith, one more thing to add to the list: | 23:13 |
asselin | make sure they're testing cinder patches | 23:14 |
patrickeast | haha yea | 23:14 |
jgriffith | but I do think the whole thing is somewhat broken/flawed and we should fix it | 23:14 |
asselin | I've notified a few who were testing master on every cinder patch set | 23:14 |
jgriffith | asselin: YES!!! | 23:14 |
patrickeast | i think we got all of those fixed by now | 23:14 |
jgriffith | I noticed that too! | 23:14 |
jgriffith | I also found one testing LVM... but I can't find it again | 23:14 |
jgriffith | vilobhmm: what's up? | 23:14 |
anteaya | jgriffith: I agree and am glad you spoke up | 23:15 |
openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor 5 iSCSI backend driver. https://review.openstack.org/190391 | 23:15 |
anteaya | jgriffith: if I can suggest, take you paste and transfer to an etherpad | 23:15 |
anteaya | then everyone assign themselves one ci | 23:15 |
openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor 5 NFS backend driver. https://review.openstack.org/190273 | 23:15 |
vilobhmm | jgriffith : who keeps track of instance snapshot ? | 23:15 |
asselin | anteaya, +1 | 23:16 |
vilobhmm | is it us ? | 23:16 |
anteaya | and try to approach the operators, media of your choice | 23:16 |
anteaya | and post results | 23:16 |
jgriffith | anteaya: Oh...sorry.. yeah, already did | 23:16 |
anteaya | ah okay cool | 23:16 |
jgriffith | https://etherpad.openstack.org/p/cinder-thirdpartyCI-issues | 23:16 |
jgriffith | I had to use paste as a "hop" | 23:16 |
anteaya | awesome | 23:17 |
jgriffith | My \n's in vim won't work direct from vim to ehterpad | 23:17 |
jgriffith | etherpad | 23:17 |
asselin | patrickeast, fc passthrough update passed my ci. I've enabled it for future patches | 23:17 |
anteaya | ha ha ha | 23:17 |
jgriffith | don't know why? | 23:17 |
patrickeast | asselin: awesome | 23:17 |
anteaya | I have no idea | 23:17 |
jgriffith | so I hope... vim --> paste -->etherpad | 23:17 |
anteaya | ah | 23:17 |
jgriffith | stupd VIM | 23:17 |
jgriffith | :) | 23:17 |
anteaya | ha ha ha | 23:17 |
jgriffith | errr... s/hope/hop/ | 23:17 |
patrickeast | jgriffith: so you mention collecting stats on ci systems, if thats something we can automate we could integrate it with my scoreboard thing | 23:18 |
jgriffith | patrickeast: Yes! | 23:18 |
jgriffith | patrickeast: so there's two approaches I've been messing with | 23:18 |
patrickeast | jgriffith: i think it was tenatively decided we are going to try and put that thing up on an infra host | 23:18 |
*** daneyon has quit IRC | 23:19 | |
patrickeast | jgriffith: while the dashboard/radar thing keeps getting worked on | 23:19 |
jgriffith | patrickeast: one uses Joe Gordons last-comment tool (with some mods) and gets data | 23:19 |
*** daneyon has joined #openstack-cinder | 23:19 | |
jgriffith | patrickeast: the other is have everybody implement subunit and db | 23:19 |
jgriffith | patrickeast: I think to start going down the last-comment path is the way to go | 23:19 |
anteaya | patrickeast: my hope is yes, to offer a spec to have it on infra, and then any new features can get added _after_ it has been stood up | 23:19 |
jgriffith | patrickeast: getting everybody to setup db and do everything is going to be near impossible | 23:20 |
vilobhmm | jgriffith : who keeps track of instance snapshot QUOTA ? is it us ? | 23:20 |
anteaya | patrickeast: is anyone willing to write that spec yet? | 23:20 |
jgriffith | lsat-comment just queries gerrit | 23:20 |
patrickeast | anteaya: have you and asselin talked since the ci working group meeting this morning? | 23:20 |
asselin | anteaya, I volunteered | 23:20 |
patrickeast | oh ok | 23:20 |
jgriffith | vilobhmm: yes | 23:20 |
anteaya | asselin: okay good | 23:20 |
jgriffith | vilobhmm: if by "us" you mean Cinder | 23:20 |
anteaya | asselin: do toss up a draft and I can review it | 23:20 |
vilobhmm | us = Cinder | 23:20 |
vilobhmm | yes | 23:20 |
asselin | anteaya, will do | 23:20 |
vilobhmm | jgriffith : ^^ | 23:21 |
jgriffith | vilobhmm: yep, that's us | 23:21 |
vilobhmm | ok | 23:21 |
patrickeast | jgriffith: so the last comment thing sounds pretty cool, i’m not sure i know what you mean by implement subunit and db | 23:21 |
jgriffith | vilobhmm: we track all of our quotas | 23:21 |
anteaya | asselin: thank you | 23:21 |
jgriffith | vilobhmm: it's a bit of a brain bender | 23:21 |
jgriffith | vilobhmm: but you'll see all the reserve/update/commit etc in cinder.volume.api | 23:21 |
jgriffith | and a few other places | 23:21 |
vilobhmm | so the snapshot quota is overloaded with volume-snapshot, instance-snapshot ? | 23:21 |
vilobhmm | jgriffith : ^^ | 23:21 |
jgriffith | and there's some loopie abstractions in quota.py to deal with it all | 23:22 |
vilobhmm | yes i do see that | 23:22 |
jgriffith | no.. we shouldn't have anything like that (instance-snapshot stuff) | 23:22 |
* asselin bookmarks https://etherpad.openstack.org/p/cinder-thirdpartyCI-issues | 23:22 | |
vilobhmm | jgriffith : then how do you distinguish between volume snapshot vs instance snapshot ? because in code it just says *volume snapshot* https://github.com/openstack/cinder/blob/master/cinder/quota.py#L40 | 23:23 |
vilobhmm | could not get this so thought will check with you | 23:24 |
jgriffith | vilobhmm: we don't need to.. all of the quota stuff is done in "Cinder" or "Nova" for each set of resources respectively | 23:24 |
jgriffith | vilobhmm: theyr'e "different" | 23:24 |
jgriffith | vilobhmm: so cinder volume-snapshots for example are ONLY managed in Cinder and kept track of via cinder database | 23:24 |
jgriffith | vilobhmm: same holds true for Nova and compute snapshots | 23:25 |
jgriffith | or.. "instance" snapshots | 23:25 |
*** daneyon has quit IRC | 23:25 | |
vilobhmm | nova just manages these resources no *instance snapshot* quota mentioned http://paste.openstack.org/show/282434/ | 23:25 |
vilobhmm | this is the list of resources that nova manages from nova quota-show —tenant <id> | 23:25 |
jgriffith | well.. so that's one of my faviroite things :) | 23:25 |
jgriffith | That's not necessarily everything | 23:26 |
vilobhmm | oh okay | 23:26 |
jgriffith | just like this http://paste.openstack.org/show/282435/ isn't everything for Cinder | 23:26 |
jgriffith | vilobhmm: but the other thing is I *think* the snapshot quota in Nova is actually an image thing | 23:27 |
*** akl_ has quit IRC | 23:27 | |
jgriffith | vilobhmm: because that's actually what it is | 23:27 |
vilobhmm | yes it should be right but i could not even see it in the code …https://github.com/openstack/nova/blob/master/nova/quota.py | 23:27 |
jgriffith | vilobhmm: and snap of an Instance that's bootfrom voluem is actually a cinder-snapshot | 23:28 |
jgriffith | which I find highly annoying and kinda stupid the way it is now | 23:28 |
jgriffith | vilobhmm: welcome to OpenStack Quota code | 23:28 |
jgriffith | vilobhmm: I spent wayyy too much time on it a long time ago and swore if I ever had to work on it again it would be to rewrite it all | 23:29 |
vilobhmm | yes it is confusing …so finally who owns *instance snapshot quota* becasue i couldn't find relevant code anywhere jgriffith | 23:29 |
jgriffith | vilobhmm: the thing is I don't pretend that I could do better | 23:29 |
jgriffith | vilobhmm: check glance | 23:29 |
jgriffith | vilobhmm: but frankly I'm not sure... I would have to dig in the nova code to try and find that info | 23:29 |
vilobhmm | jgriffith : you can make it better…I m sure abt it…glance doesn not maintain quota jgriffith | 23:30 |
vilobhmm | so the mystery remains a mystery | 23:30 |
jgriffith | vilobhmm: sometimes it's easiest to start at the "end" | 23:30 |
vilobhmm | ok | 23:30 |
jgriffith | vilobhmm: lookin around in nova/nova/api/openstack | 23:30 |
vilobhmm | will trace it | 23:30 |
vilobhmm | thanks for your input | 23:30 |
jgriffith | sure | 23:31 |
vilobhmm | one last thing since we are talking about quotas here | 23:31 |
vilobhmm | jgriffith : for nested quota | 23:31 |
jgriffith | sure | 23:31 |
jgriffith | :) | 23:31 |
jgriffith | vilobhmm: I warned you in Vancouver :) | 23:31 |
jgriffith | vilobhmm: some people think I'm negative, I think I'm realistic :) | 23:31 |
vilobhmm | :P hey but its an interestring topic to work on ; I think you are realistic …So i am adding a new Driver called as NestedQuotaDriver | 23:32 |
vilobhmm | https://github.com/openstack/cinder/blob/master/cinder/quota.py#L78 | 23:32 |
vilobhmm | similar to above : ^^ | 23:32 |
jgriffith | It's an AWESOME topic | 23:32 |
vilobhmm | so i realized that in NestedQuotaDriver except setting quota values everything else will be same | 23:32 |
jgriffith | sure, but that ONLY covers your db interactions | 23:33 |
jgriffith | all the spaghetti and mess is still outside of that | 23:33 |
vilobhmm | so I was thinking either to inherit it from DbQuotaDriver….or have an abstract class called Quota with all common functionality and let DbQuotaDriver and NestedQuotaDriver inherit from it | 23:33 |
jgriffith | vilobhmm: Oh? | 23:33 |
vilobhmm | whats your take on it | 23:33 |
jgriffith | vilobhmm: well... first I didn't think that would work | 23:33 |
vilobhmm | yes spagheti and meat will be in the extension or contrib stuff | 23:34 |
jgriffith | but obviously I must be wrong | 23:34 |
jgriffith | ahh | 23:34 |
vilobhmm | more specifically cinder/api/contrib/quotas.py | 23:34 |
jgriffith | vilobhmm: so I think either of the approaches you mention could be ok | 23:34 |
jgriffith | vilobhmm: it comes down to how much commonality you can extract as to which is better | 23:35 |
vilobhmm | ok…want to minimise code duplication | 23:35 |
vilobhmm | sure | 23:35 |
jgriffith | vilobhmm: yeah, exactly | 23:35 |
jgriffith | vilobhmm: I just don't know what it looks like (code wise) | 23:35 |
*** BharatK has joined #openstack-cinder | 23:35 | |
jgriffith | vilobhmm: if I had to guess I would lean towards a base class with two options under it | 23:35 |
*** mdenny has quit IRC | 23:35 | |
jgriffith | but that's just off of memory of the quota db code | 23:36 |
vilobhmm | i also want to take that route | 23:36 |
jgriffith | I could be completely wrong :) | 23:36 |
jgriffith | vilobhmm: it makes sense, at least in concept | 23:36 |
vilobhmm | reason bein tommorow if we get rid of something X or plan to add something Z we can inherit from the abstract base anyhow | 23:36 |
jgriffith | vilobhmm: but also be warned, I'm of the opinion that inheritance is the most abused concept in software | 23:36 |
jgriffith | :) | 23:36 |
jgriffith | vilobhmm: yep | 23:37 |
vilobhmm | ok… | 23:37 |
vilobhmm | that was helpful | 23:37 |
jgriffith | it's more flexible for sure | 23:37 |
vilobhmm | thanks jgriffith | 23:37 |
vilobhmm | sure | 23:37 |
jgriffith | vilobhmm: you bet, thank you | 23:37 |
vilobhmm | :) | 23:37 |
jgriffith | Looking forward to you having this all finished and working tomorrow :) | 23:37 |
*** krtaylor has joined #openstack-cinder | 23:38 | |
jgriffith | vilobhmm: ^^ that was a joke of course :) | 23:38 |
*** david-lyle has quit IRC | 23:40 | |
vilobhmm | jgriffith : sureeeee :) …but will have it up soon…working on uni test | 23:40 |
jgriffith | vilobhmm: Oh, dang!! :) See.. I try and be funny, but I forget you're an over-achiever! | 23:42 |
jgriffith | Ok... well, I've completely broken the code I was working on :( | 23:42 |
jgriffith | Think I'll take a walk and come back later | 23:42 |
jgriffith | Catch ya all later | 23:42 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/186112 | 23:43 |
vilobhmm | sure :) ..good luck ! | 23:44 |
*** IlyaG has joined #openstack-cinder | 23:53 | |
*** harlowja has quit IRC | 23:54 | |
*** harlowja has joined #openstack-cinder | 23:55 | |
*** setmason has joined #openstack-cinder | 23:55 | |
asselin | patrickeast, hemnafk thingee ok we're posting to os-brick: https://review.openstack.org/#/c/186588/ | 23:56 |
patrickeast | woot | 23:57 |
patrickeast | i’ve got one for that patchset on the way for mine… its #12 in line for FC tests : / | 23:58 |
patrickeast | but in the zuul queue! | 23:59 |
*** IlyaG has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!