*** dannywilson has quit IRC | 00:00 | |
*** haomai___ has joined #openstack-cinder | 00:02 | |
openstackgerrit | Nikesh proposed openstack/cinder: Adds FC and ISCSI Cinder drivers for Lenovo Storage Arrays https://review.openstack.org/187853 | 00:02 |
---|---|---|
*** haomaiwa_ has quit IRC | 00:03 | |
*** rmesta has quit IRC | 00:04 | |
*** takedakn has joined #openstack-cinder | 00:11 | |
*** takedakn has quit IRC | 00:16 | |
*** mtanino has quit IRC | 00:22 | |
*** _cjones_ has quit IRC | 00:23 | |
*** _cjones_ has joined #openstack-cinder | 00:23 | |
diogogmt | i’m trying to do a simple hack to test some changes to my existing cinder installation, i can see that the files are installed in this dir: /usr/lib/python2.7/dist-packages/cinder/api/v1/volumes.py — after i modify the file by adding some log statements i don’t see anything being logged to the log files, /var/log/cinder/api.log/cinder-volumes.log — do i need to recompile cinder or shouldn’t the changes be picked up right way? | 00:23 |
*** _cjones_ has quit IRC | 00:28 | |
*** smoriya has joined #openstack-cinder | 00:31 | |
*** haomai___ has quit IRC | 00:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/192369 | 00:34 |
*** leeantho has quit IRC | 00:36 | |
*** jasondotstar has quit IRC | 00:42 | |
*** chlong has joined #openstack-cinder | 00:42 | |
nikeshm | diogogmt: try to restart cinder services | 00:50 |
diogogmt | nikeshm: why would that make a difference? are the files cached or something? | 00:51 |
nikeshm | diogogmt: not sure,but if yu restart like service cinder-api restart and using LOG.debug in the file,it should work.i think it will update /usr/lib/python2.7/dist-packages/cinder/api/v1/volumes.pyc with your changes | 00:53 |
nikeshm | assuming yu r not using devstack | 00:54 |
*** tobe has joined #openstack-cinder | 01:05 | |
*** jdurgin1 has quit IRC | 01:07 | |
*** diogogmt has quit IRC | 01:07 | |
*** lixiaoy1 has joined #openstack-cinder | 01:11 | |
*** patrickeast has joined #openstack-cinder | 01:12 | |
*** Yogi1 has joined #openstack-cinder | 01:13 | |
*** rakesh_mishra has joined #openstack-cinder | 01:15 | |
*** rakesh_mishra has quit IRC | 01:15 | |
*** rakesh_mishra has joined #openstack-cinder | 01:15 | |
*** patrickeast has left #openstack-cinder | 01:19 | |
*** rakesh_mishra has quit IRC | 01:21 | |
*** rakesh_mishra_ has joined #openstack-cinder | 01:21 | |
*** patrickeast has joined #openstack-cinder | 01:21 | |
*** Yogi1 has quit IRC | 01:24 | |
*** Lee1092 has joined #openstack-cinder | 01:29 | |
openstackgerrit | Dave Chen proposed openstack/cinder-specs: Update of `support-modify-volume-image-metadata.rst` https://review.openstack.org/160147 | 01:30 |
*** patrickeast_ has joined #openstack-cinder | 01:32 | |
*** patrickeast has quit IRC | 01:32 | |
*** patrickeast_ has quit IRC | 01:33 | |
*** patrickeast has joined #openstack-cinder | 01:33 | |
*** mtecer has quit IRC | 01:34 | |
openstackgerrit | Thang Pham proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 01:42 |
openstackgerrit | Thang Pham proposed openstack/cinder: WIP: RPC and object versioning https://review.openstack.org/184404 | 01:42 |
*** Apoorva has quit IRC | 01:43 | |
*** Apoorva has joined #openstack-cinder | 01:45 | |
*** ociuhandu has quit IRC | 01:46 | |
*** diogogmt has joined #openstack-cinder | 01:49 | |
*** pboldin has quit IRC | 01:50 | |
*** Apoorva has quit IRC | 01:55 | |
*** vilobhmm has joined #openstack-cinder | 02:02 | |
*** rakesh_mishra_ has quit IRC | 02:04 | |
*** dims has quit IRC | 02:04 | |
*** vilobhmm has quit IRC | 02:07 | |
*** dims has joined #openstack-cinder | 02:08 | |
*** jasondotstar has joined #openstack-cinder | 02:09 | |
*** jasondotstar has quit IRC | 02:09 | |
*** rhefner has joined #openstack-cinder | 02:10 | |
*** jwcroppe has quit IRC | 02:10 | |
*** garthb_ has joined #openstack-cinder | 02:10 | |
*** garthb has joined #openstack-cinder | 02:10 | |
*** jasondotstar has joined #openstack-cinder | 02:10 | |
*** Yogi1 has joined #openstack-cinder | 02:11 | |
*** davechen is now known as davechen_afk | 02:13 | |
*** dims has quit IRC | 02:19 | |
*** jasondotstar has quit IRC | 02:24 | |
*** Yogi1 has quit IRC | 02:32 | |
*** changbl has joined #openstack-cinder | 02:32 | |
*** haomaiwang has joined #openstack-cinder | 02:38 | |
*** dannywilson has joined #openstack-cinder | 02:39 | |
*** Yogi1 has joined #openstack-cinder | 02:52 | |
*** patrickeast has quit IRC | 02:59 | |
*** sgotliv has joined #openstack-cinder | 03:01 | |
*** heyun has joined #openstack-cinder | 03:01 | |
*** lidan has joined #openstack-cinder | 03:02 | |
*** lidan has left #openstack-cinder | 03:04 | |
*** rushil has joined #openstack-cinder | 03:05 | |
*** lidan has joined #openstack-cinder | 03:05 | |
*** rushil has quit IRC | 03:06 | |
lidan | hi, Does someone meet this problem about "Patch in Merger conflict"? | 03:08 |
*** Yogi1 has quit IRC | 03:12 | |
*** Apoorva has joined #openstack-cinder | 03:15 | |
lidan | Recently when submitting code, I always meet code conflict problem. | 03:20 |
winston-d | who reported that issue? Is it Jenkins or other 3rd party CI? | 03:20 |
lidan | Jekins | 03:20 |
lidan | After Jekins+1 | 03:21 |
lidan | This happened After Jekins+1. | 03:22 |
winston-d | did you rebase your code to tip? | 03:22 |
lidan | What's the tip? | 03:23 |
winston-d | latest change of master branch | 03:24 |
winston-d | or whatever branch you are trying to commit to | 03:24 |
lidan | Yes | 03:25 |
*** yamada-h has joined #openstack-cinder | 03:25 | |
*** yamada-h has quit IRC | 03:29 | |
*** markvoelker has quit IRC | 03:31 | |
*** coolsvap|afk is now known as coolsvap | 03:34 | |
*** aswadr has joined #openstack-cinder | 03:40 | |
*** vilobhmm has joined #openstack-cinder | 03:53 | |
openstackgerrit | Jessy Lee proposed openstack/cinder: Add volume drivers for Infortrend Storage https://review.openstack.org/177113 | 04:00 |
*** rushiagr_away is now known as rushiagr | 04:10 | |
*** patrickeast has joined #openstack-cinder | 04:15 | |
*** patrickeast has quit IRC | 04:23 | |
*** lidan has quit IRC | 04:25 | |
*** markvoelker has joined #openstack-cinder | 04:32 | |
*** markvoelker has quit IRC | 04:37 | |
*** lidan has joined #openstack-cinder | 04:55 | |
*** lidan has quit IRC | 04:56 | |
openstackgerrit | chenzongliang proposed openstack/cinder: Refactor Huawei Volume driver https://review.openstack.org/188240 | 04:58 |
*** Apoorva has quit IRC | 04:59 | |
*** lidan has joined #openstack-cinder | 04:59 | |
*** IlyaG has quit IRC | 05:02 | |
*** fifieldt has joined #openstack-cinder | 05:10 | |
*** IanGovett has joined #openstack-cinder | 05:12 | |
*** nihilifer has joined #openstack-cinder | 05:12 | |
*** shausy has joined #openstack-cinder | 05:14 | |
*** haomaiwang has quit IRC | 05:14 | |
*** dannywilson has quit IRC | 05:14 | |
*** dannywilson has joined #openstack-cinder | 05:15 | |
*** BharatK has joined #openstack-cinder | 05:16 | |
*** Maike has joined #openstack-cinder | 05:18 | |
*** nkrinner has joined #openstack-cinder | 05:31 | |
*** nlevinki has joined #openstack-cinder | 05:32 | |
*** lpetrut has joined #openstack-cinder | 05:33 | |
*** tobe has quit IRC | 05:39 | |
openstackgerrit | Jessy Lee proposed openstack/cinder: Add volume drivers for Infortrend Storage https://review.openstack.org/177113 | 05:42 |
*** sudipto has joined #openstack-cinder | 05:44 | |
*** belmoreira has joined #openstack-cinder | 05:44 | |
*** IanGovett has quit IRC | 05:55 | |
*** markvoelker has joined #openstack-cinder | 05:55 | |
*** garthb_ has quit IRC | 05:56 | |
*** garthb has quit IRC | 05:57 | |
*** haomaiwa_ has joined #openstack-cinder | 05:59 | |
*** markvoelker has quit IRC | 06:00 | |
*** IanGovett has joined #openstack-cinder | 06:05 | |
*** IanGovett has quit IRC | 06:09 | |
*** shausy has quit IRC | 06:09 | |
*** shausy has joined #openstack-cinder | 06:10 | |
*** yamada-h has joined #openstack-cinder | 06:14 | |
*** tobe has joined #openstack-cinder | 06:20 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Add migration progress indication https://review.openstack.org/189614 | 06:20 |
*** abhishekk has joined #openstack-cinder | 06:21 | |
abhishekk | hi all, is there any meeting for cinder nova volume discussion? | 06:22 |
*** dulek has joined #openstack-cinder | 06:22 | |
*** rakesh_mishra has joined #openstack-cinder | 06:23 | |
*** afazekas has joined #openstack-cinder | 06:23 | |
*** dulek has quit IRC | 06:25 | |
*** sgotliv has quit IRC | 06:32 | |
*** sgotliv has joined #openstack-cinder | 06:32 | |
*** ianbrown has quit IRC | 06:39 | |
openstackgerrit | rakesh mishra proposed openstack/cinder: Add config option to set max_volume_size_limit https://review.openstack.org/185906 | 06:41 |
*** salv-orl_ has joined #openstack-cinder | 06:41 | |
*** ronenkat has joined #openstack-cinder | 06:41 | |
*** boris-42 has quit IRC | 06:42 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Add migration progress indication https://review.openstack.org/189614 | 06:44 |
*** salv-orlando has quit IRC | 06:44 | |
*** anshul has joined #openstack-cinder | 06:44 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Add migration progress indication https://review.openstack.org/189614 | 06:48 |
*** dulek has joined #openstack-cinder | 06:49 | |
*** Longgeek has joined #openstack-cinder | 06:49 | |
*** lpetrut has quit IRC | 06:50 | |
*** lixiaoy1 has quit IRC | 06:50 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Add migration progress indication https://review.openstack.org/189614 | 06:51 |
*** Longgeek_ has joined #openstack-cinder | 06:53 | |
*** Longgeek has quit IRC | 06:57 | |
*** vilobhmm has quit IRC | 06:58 | |
*** laughterwym has joined #openstack-cinder | 07:04 | |
lan | hi, do anybody know this option CONF.keymgr.fixed_key , what is it used for ? and what value should I specified (seems that there is no default value for this option)? | 07:05 |
*** laughterwym has quit IRC | 07:10 | |
*** laughterwym has joined #openstack-cinder | 07:10 | |
*** ronis has joined #openstack-cinder | 07:10 | |
*** laughterwym has quit IRC | 07:11 | |
*** laughterwym has joined #openstack-cinder | 07:11 | |
openstackgerrit | chenzongliang proposed openstack/cinder: Refactor Huawei Volume driver https://review.openstack.org/188240 | 07:13 |
lidan | <openstackgerrit> chenzongliang proposed openstack/cinder: Refactor Huawei Volume driver https://review.openstack.org/188240 | 07:14 |
*** lixiaoy11 has joined #openstack-cinder | 07:20 | |
*** Longgeek_ has quit IRC | 07:26 | |
*** lixiaoy1 has joined #openstack-cinder | 07:27 | |
*** dannywilson has quit IRC | 07:28 | |
*** dannywilson has joined #openstack-cinder | 07:30 | |
*** lixiaoy11 has quit IRC | 07:30 | |
*** dannywilson has quit IRC | 07:34 | |
openstackgerrit | Abhijeet Malawade proposed openstack/python-cinderclient: Add support to return request_id of last request https://review.openstack.org/173199 | 07:39 |
*** ociuhandu has joined #openstack-cinder | 07:42 | |
*** markvoelker has joined #openstack-cinder | 07:44 | |
*** ociuhandu has quit IRC | 07:45 | |
*** jordanP has joined #openstack-cinder | 07:46 | |
*** Longgeek has joined #openstack-cinder | 07:47 | |
*** Longgeek has quit IRC | 07:48 | |
*** Longgeek has joined #openstack-cinder | 07:48 | |
*** markvoelker has quit IRC | 07:49 | |
*** markus_z has joined #openstack-cinder | 07:56 | |
*** ociuhandu has joined #openstack-cinder | 08:04 | |
*** ronenkat_ has joined #openstack-cinder | 08:08 | |
*** alonmarx_ has joined #openstack-cinder | 08:08 | |
*** alonmarx has quit IRC | 08:11 | |
*** ronenkat has quit IRC | 08:11 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Add migration progress indication https://review.openstack.org/189614 | 08:17 |
*** chlong has quit IRC | 08:18 | |
*** aswadr has quit IRC | 08:18 | |
*** c0m0 has joined #openstack-cinder | 08:19 | |
*** aswadr has joined #openstack-cinder | 08:19 | |
*** asrangne has joined #openstack-cinder | 08:21 | |
*** yamada-h_ has joined #openstack-cinder | 08:22 | |
*** aswadr has quit IRC | 08:24 | |
*** yamada-h has quit IRC | 08:26 | |
*** ronenkat__ has joined #openstack-cinder | 08:30 | |
*** deepakcs has joined #openstack-cinder | 08:31 | |
*** belmoreira has quit IRC | 08:33 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Add migration progress indication https://review.openstack.org/189614 | 08:33 |
*** belmoreira has joined #openstack-cinder | 08:33 | |
*** ronenkat_ has quit IRC | 08:34 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Add migration progress indication https://review.openstack.org/189614 | 08:34 |
*** laughterwym has quit IRC | 08:41 | |
*** mdbooth has quit IRC | 08:42 | |
*** mdbooth has joined #openstack-cinder | 08:45 | |
openstackgerrit | Abhijeet Malawade proposed openstack/cinder: Remove unused context parameter https://review.openstack.org/185861 | 08:48 |
*** ociuhandu has quit IRC | 08:52 | |
*** coolsvap is now known as coolsvap|afk | 08:52 | |
*** shyama has joined #openstack-cinder | 08:53 | |
DuncanT | Ian: It is the fixed key for encrypted volumes, if you're using encrypted volumes and no key manager | 08:56 |
*** ociuhandu has joined #openstack-cinder | 08:57 | |
lidan | chenzongliang proposed openstack/cinder: Refactor Huawei Volume driver https://review.openstack.org/188240 | 08:57 |
openstackgerrit | Shay Halsband proposed openstack/cinder: XtremIO Volume driver requests, multipath https://review.openstack.org/184596 | 08:57 |
*** tobe has quit IRC | 08:58 | |
*** c0m0 has quit IRC | 08:59 | |
*** tobe has joined #openstack-cinder | 08:59 | |
openstackgerrit | chenzongliang proposed openstack/cinder: Add CHAP support for Huawei Storage https://review.openstack.org/188360 | 09:01 |
*** tobe_ has joined #openstack-cinder | 09:01 | |
*** tobe_ has quit IRC | 09:01 | |
openstackgerrit | chenzongliang proposed openstack/cinder: Huawei Storage iSCSI multipath Support https://review.openstack.org/188365 | 09:03 |
*** coolsvap|afk is now known as coolsvap | 09:03 | |
*** tobe has quit IRC | 09:03 | |
openstackgerrit | chenzongliang proposed openstack/cinder: Support SmartX for Huawei volume driver https://review.openstack.org/188732 | 09:06 |
*** daneyon has joined #openstack-cinder | 09:09 | |
*** daneyon has quit IRC | 09:14 | |
openstackgerrit | Stefan Amann proposed openstack/os-brick: Support host type specific block volume attachment https://review.openstack.org/192558 | 09:17 |
*** ndipanov has joined #openstack-cinder | 09:21 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Add migration progress indication https://review.openstack.org/189614 | 09:23 |
*** tobe has joined #openstack-cinder | 09:23 | |
*** rakesh_mishra has quit IRC | 09:24 | |
*** rakesh_mishra has joined #openstack-cinder | 09:25 | |
openstackgerrit | Deepak C Shetty (deepakcs) proposed openstack/cinder: Cinder part of volume snapshot improvements https://review.openstack.org/172808 | 09:27 |
openstackgerrit | rakesh mishra proposed openstack/cinder: Add config option to set max_volume_size_limit https://review.openstack.org/185906 | 09:30 |
openstackgerrit | Shay Halsband proposed openstack/cinder: XtremIO Volume driver requests, multipath https://review.openstack.org/184596 | 09:31 |
*** markvoelker has joined #openstack-cinder | 09:33 | |
*** e0ne has joined #openstack-cinder | 09:36 | |
*** rakesh_mishra has quit IRC | 09:36 | |
*** rakesh_mishra has joined #openstack-cinder | 09:37 | |
*** markvoelker has quit IRC | 09:37 | |
*** laughterwym has joined #openstack-cinder | 09:38 | |
*** haomaiwa_ has quit IRC | 09:41 | |
*** e0ne is now known as e0ne_ | 09:43 | |
*** rakesh_mishra has quit IRC | 09:46 | |
*** e0ne_ is now known as e0ne | 09:47 | |
*** yamada-h_ has quit IRC | 09:48 | |
*** rakesh_mishra has joined #openstack-cinder | 09:51 | |
*** lixiaoy1 has quit IRC | 09:51 | |
*** sgotliv_ has joined #openstack-cinder | 09:54 | |
openstackgerrit | chenzongliang proposed openstack/cinder: Huawei Storage Multiple Pools Support https://review.openstack.org/188251 | 09:55 |
openstackgerrit | Rajesh Tailor proposed openstack/cinder: Validate bool value using strutils.bool_from_string method https://review.openstack.org/187470 | 09:57 |
*** sgotliv has quit IRC | 09:58 | |
*** sgotliv__ has joined #openstack-cinder | 10:01 | |
*** sgotliv_ has quit IRC | 10:04 | |
*** sgotliv__ has quit IRC | 10:07 | |
*** ianbrown has joined #openstack-cinder | 10:07 | |
*** lpetrut has joined #openstack-cinder | 10:10 | |
*** lpetrut has quit IRC | 10:10 | |
*** heyun has quit IRC | 10:16 | |
*** dims has joined #openstack-cinder | 10:17 | |
*** tobe has quit IRC | 10:17 | |
*** dims has quit IRC | 10:17 | |
*** dims has joined #openstack-cinder | 10:18 | |
*** ianbrown has quit IRC | 10:19 | |
*** cebruns has quit IRC | 10:19 | |
*** sgotliv has joined #openstack-cinder | 10:20 | |
*** cebruns has joined #openstack-cinder | 10:21 | |
*** lpetrut has joined #openstack-cinder | 10:21 | |
*** ianbrown has joined #openstack-cinder | 10:26 | |
*** shyama_ has joined #openstack-cinder | 10:28 | |
*** shyama has quit IRC | 10:28 | |
*** shyama_ is now known as shyama | 10:28 | |
*** haomaiwang has joined #openstack-cinder | 10:28 | |
*** shyama_ has joined #openstack-cinder | 10:33 | |
*** shyama has quit IRC | 10:35 | |
*** shyama_ is now known as shyama | 10:35 | |
*** timcl has joined #openstack-cinder | 10:36 | |
*** jasondotstar has joined #openstack-cinder | 10:41 | |
*** lihit has joined #openstack-cinder | 10:47 | |
*** lihit has quit IRC | 10:47 | |
*** e0ne is now known as e0ne_ | 10:49 | |
*** aix has joined #openstack-cinder | 10:49 | |
*** e0ne_ has quit IRC | 10:54 | |
*** timcl has quit IRC | 10:55 | |
*** e0ne has joined #openstack-cinder | 10:56 | |
*** daneyon has joined #openstack-cinder | 10:58 | |
*** sgotliv_ has joined #openstack-cinder | 10:59 | |
*** daneyon has quit IRC | 11:02 | |
*** sgotliv has quit IRC | 11:02 | |
openstackgerrit | Shay Halsband proposed openstack/cinder: XtremIO Volume driver requests, multipath https://review.openstack.org/184596 | 11:04 |
*** jasondotstar has quit IRC | 11:06 | |
*** sgotliv_ has quit IRC | 11:07 | |
*** sgotliv has joined #openstack-cinder | 11:07 | |
dulek | DuncanT: ping | 11:08 |
dulek | DuncanT: Can you provide an update on work in Nova for c-vol A/A? Is there anything I can help with now? | 11:09 |
*** markvoelker has joined #openstack-cinder | 11:22 | |
*** coolsvap is now known as coolsvap|away | 11:22 | |
*** ianbrown has quit IRC | 11:22 | |
*** rushiagr is now known as rushiagr_away | 11:24 | |
*** markvoelker has quit IRC | 11:27 | |
*** e0ne is now known as e0ne_ | 11:29 | |
*** dannywilson has joined #openstack-cinder | 11:30 | |
openstackgerrit | Alessandro Pilotti proposed openstack/cinder: Update guru meditation reports from oslo.incubator https://review.openstack.org/192616 | 11:31 |
*** shyama has quit IRC | 11:34 | |
*** dannywilson has quit IRC | 11:34 | |
*** e0ne_ has quit IRC | 11:34 | |
*** laughterwym has quit IRC | 11:36 | |
*** laughterwym has joined #openstack-cinder | 11:36 | |
*** marcusvrn has joined #openstack-cinder | 11:39 | |
openstackgerrit | Stefan Amann proposed openstack/os-brick: Support host type specific block volume attachment https://review.openstack.org/192558 | 11:40 |
*** ganso_ has joined #openstack-cinder | 11:45 | |
*** thangp has joined #openstack-cinder | 11:46 | |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: Get updated volume status in begin_detaching https://review.openstack.org/192628 | 11:51 |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: Get updated volume status in begin_detaching https://review.openstack.org/192628 | 11:52 |
*** dulek_ has joined #openstack-cinder | 11:57 | |
*** timcl has joined #openstack-cinder | 11:58 | |
*** dulek has quit IRC | 12:01 | |
*** markvoelker has joined #openstack-cinder | 12:05 | |
*** julim has joined #openstack-cinder | 12:08 | |
*** rushiagr_away is now known as rushiagr | 12:11 | |
*** rakesh_mishra has quit IRC | 12:13 | |
openstackgerrit | Peter Penchev proposed openstack/cinder-specs: Add the StorPool Brick driver specification. https://review.openstack.org/192638 | 12:14 |
openstackgerrit | Peter Penchev proposed openstack/os-brick: Add the StorPool brick connector. https://review.openstack.org/192639 | 12:18 |
*** shausy has quit IRC | 12:18 | |
*** shausy has joined #openstack-cinder | 12:19 | |
*** e0ne has joined #openstack-cinder | 12:19 | |
*** yrabl has quit IRC | 12:20 | |
*** yrabl has joined #openstack-cinder | 12:21 | |
Liu | chenzongliang proposed openstack/cinder: Refactor Huawei Volume driver https://review.openstack.org/188240 | 12:22 |
Liu | chenzongliang proposed openstack/cinder: Refactor Huawei Volume driver https://review.openstack.org/188240 | 12:22 |
*** lpetrut has quit IRC | 12:22 | |
*** lpetrut has joined #openstack-cinder | 12:22 | |
*** akerr has joined #openstack-cinder | 12:23 | |
*** ociuhandu has quit IRC | 12:26 | |
*** dulek_ is now known as dulek | 12:34 | |
*** dims has quit IRC | 12:36 | |
*** dims has joined #openstack-cinder | 12:36 | |
*** kjnelson has joined #openstack-cinder | 12:37 | |
openstackgerrit | Dmitry Guryanov proposed openstack/os-brick: remotefs: add virtuozzo storage support https://review.openstack.org/188805 | 12:38 |
*** dulek has quit IRC | 12:39 | |
*** marcusvrn1 has joined #openstack-cinder | 12:40 | |
*** dulek has joined #openstack-cinder | 12:40 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Ceph driver support retries on rados_connect_timeout https://review.openstack.org/190579 | 12:42 |
openstackgerrit | Jessy Lee proposed openstack/cinder: Add volume drivers for Infortrend Storage https://review.openstack.org/177113 | 12:44 |
*** marcusvrn has quit IRC | 12:44 | |
*** rushil has joined #openstack-cinder | 12:45 | |
*** zhipeng has joined #openstack-cinder | 12:46 | |
*** daneyon has joined #openstack-cinder | 12:46 | |
*** bswartz has quit IRC | 12:49 | |
*** Yogi1 has joined #openstack-cinder | 12:49 | |
*** smoriya has quit IRC | 12:49 | |
*** amoturi has joined #openstack-cinder | 12:50 | |
*** deepakcs has quit IRC | 12:51 | |
*** daneyon has quit IRC | 12:51 | |
*** merooney has joined #openstack-cinder | 12:51 | |
*** Ctina_ has joined #openstack-cinder | 12:52 | |
*** e0ne is now known as e0ne_ | 12:55 | |
*** eharney has joined #openstack-cinder | 12:55 | |
*** IanGovett has joined #openstack-cinder | 12:56 | |
*** e0ne_ is now known as e0ne | 12:57 | |
*** edmondsw has joined #openstack-cinder | 12:57 | |
*** lixiaoy1 has joined #openstack-cinder | 12:59 | |
*** lixiaoy1 has left #openstack-cinder | 13:00 | |
*** julim has quit IRC | 13:01 | |
*** merooney has quit IRC | 13:04 | |
*** julim has joined #openstack-cinder | 13:05 | |
*** sudipto has quit IRC | 13:06 | |
*** diogogmt has quit IRC | 13:07 | |
*** rakesh_mishra has joined #openstack-cinder | 13:08 | |
openstackgerrit | Pranali Deore proposed openstack/cinder: Fix useless-else-on-loop pylint issues https://review.openstack.org/192655 | 13:12 |
*** jamielennox is now known as jamielennox|away | 13:13 | |
*** ociuhandu has joined #openstack-cinder | 13:13 | |
*** nihilifer has quit IRC | 13:14 | |
*** rakesh_mishra has quit IRC | 13:19 | |
*** rakesh_mishra has joined #openstack-cinder | 13:20 | |
*** jamielennox|away is now known as jamielennox | 13:21 | |
*** xyang1 has joined #openstack-cinder | 13:23 | |
*** gouthamr has joined #openstack-cinder | 13:24 | |
*** IanGovett has quit IRC | 13:25 | |
*** timcl has quit IRC | 13:32 | |
*** jamielennox is now known as jamielennox|away | 13:33 | |
*** erlon has joined #openstack-cinder | 13:36 | |
*** jskinner has joined #openstack-cinder | 13:37 | |
*** timcl has joined #openstack-cinder | 13:40 | |
*** jamielennox|away is now known as jamielennox | 13:42 | |
*** mriedem_away is now known as mriedem | 13:42 | |
*** nlevinki has quit IRC | 13:43 | |
*** bswartz has joined #openstack-cinder | 13:45 | |
*** rushil has quit IRC | 13:46 | |
*** Liu has quit IRC | 13:46 | |
*** kbyrne has quit IRC | 13:46 | |
*** Liu has joined #openstack-cinder | 13:47 | |
DuncanT | dulek: I'm in broken-IT hell at the moment, so I've nothing useful to say :-( | 13:47 |
DuncanT | dulek: I'm on a wet string internet connection, and my main workstation is down | 13:47 |
dulek | DuncanT: That's fine, just tell me where I can start helping. :) | 13:48 |
*** Longgeek has quit IRC | 13:48 | |
dulek | DuncanT: I've spent last days in the hell of understanding how Nova actually calls Cinder, and I hope I'm ready to make some changes. | 13:48 |
*** aswadr has joined #openstack-cinder | 13:49 | |
*** Longgeek has joined #openstack-cinder | 13:49 | |
dulek | DuncanT: I just need an information what's the first priority. | 13:49 |
dulek | DuncanT: Not to overlap with others people work. | 13:49 |
*** gouthamr has quit IRC | 13:50 | |
*** asrangne has quit IRC | 13:52 | |
DuncanT | dulek: First priority IMO is to make minimal changes to nova to make it handle errors returned by initialise_connection etc gracefully | 13:52 |
DuncanT | dulek: Easiest thing to do is nobble cinder to always return an error (e.g. volume busy) then make nova handle that | 13:53 |
DuncanT | dulek: We can't fix cinder to return better errors until nova can handle them | 13:53 |
DuncanT | dulek: Once that's done, we can get cinder to return the errors, then remove all/most of the volume state checks in nova | 13:53 |
*** BharatK has quit IRC | 13:54 | |
DuncanT | dulek: I think that workflow gives us our biggest win quickly | 13:54 |
*** rushil has joined #openstack-cinder | 13:57 | |
dulek | DuncanT: Okay, I start that tomorrow morning. vilobhmm has a lot on his plate right now so hopefully he won't mind me helping on that. ;) | 13:58 |
*** gouthamr has joined #openstack-cinder | 13:58 | |
dulek | DuncanT: Thanks for help! | 13:58 |
*** haypo has joined #openstack-cinder | 13:58 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder-specs: Cinder API WSGI application under Apache/Nginx https://review.openstack.org/192683 | 13:59 |
haypo | jgriffith, hi. could you please review https://review.openstack.org/#/c/190153/ "Replace basestring with six.string_types"? it's required by my other my tox -e py34 patch | 13:59 |
haypo | jgriffith, i'm trying to reproduce your tox issue, i installed ubuntu 14.04 in a VM just to reproduce this bug :-p | 13:59 |
*** timcl has quit IRC | 14:00 | |
*** skraynev has quit IRC | 14:02 | |
*** zhipeng has quit IRC | 14:02 | |
*** crose has joined #openstack-cinder | 14:02 | |
*** skraynev has joined #openstack-cinder | 14:02 | |
*** timcl has joined #openstack-cinder | 14:04 | |
*** jdurgin1 has joined #openstack-cinder | 14:05 | |
*** jdandrea has left #openstack-cinder | 14:06 | |
*** jdandrea has joined #openstack-cinder | 14:06 | |
haypo | smcginnis, jgriffith : for https://review.openstack.org/#/c/192118/ "tox: add a basic py34 venv running a single test", Anton Arefiev wrote "looks good, working for me on Ubuntu 14.04.2 LTS with virtualenv (13.0.3)". a colleague just tried on Ubuntu 14.04.2 LTS, it also worked for him | 14:07 |
haypo | did you cherry-picked the basestring patch? | 14:07 |
*** merooney has joined #openstack-cinder | 14:07 | |
smcginnis | haypo: No, I did not. Didn't realize there wasn't an explicit dependency on the patch. | 14:09 |
openstackgerrit | Stefan Amann proposed openstack/os-brick: Support host type specific block volume attachment https://review.openstack.org/192558 | 14:09 |
smcginnis | haypo: Would really rather have it be dependent on any dependent patches, rather than using the Depends-On bit. | 14:10 |
haypo | smcginnis, the missing cherry-pick doesn't explain the "got a ton of errors while it was trying to install requirements" failure | 14:10 |
jgriffith | haypo: if it depends on a patch, that patch needs to be listed as dependent; OR it should be wip til the deps merge | 14:10 |
smcginnis | haypo: Willing to accept it's something wrong in my environment for sure. :) | 14:10 |
jgriffith | haypo: I'm not | 14:11 |
jgriffith | haypo: not at all | 14:11 |
jgriffith | haypo: and frankly I'm not sure how much more clear I need to be | 14:11 |
jgriffith | haypo: fresh ubuntu 14.04, git clone openstack/cinder, cd cinder, git review -d 192118, tox -epy34 | 14:12 |
haypo | jgriffith, "if it depends on a patch, that patch needs to be listed as dependent" it's the case. https://review.openstack.org/#/c/192118/ : "Depends-On: Ie1aedf1cbb9d3e54a996321cd586b875e69ac85a" | 14:12 |
jgriffith | FAIL | 14:12 |
haypo | jgriffith, i'm doing the same (trying to run tox -e py34 on a fresh ubuntu), i'm looking for the ubuntu package for postgresql developement (pg_config) :-p | 14:13 |
jgriffith | haypo: I'm looking right at your patch and the "Depends On" block is empty? | 14:13 |
jgriffith | haypo: Oh | 14:13 |
jgriffith | haypo: yeah... so FYI | 14:13 |
jgriffith | haypo: listing "Depends-On" in the commit message isn't quite enough | 14:14 |
jgriffith | haypo: anywho... I'd recommend either getting all those to merge, or making them all formal dependencies for 192118 | 14:14 |
jgriffith | haypo: that's likely the problem smcginnis and I were having | 14:14 |
*** kbyrne has joined #openstack-cinder | 14:15 | |
jgriffith | haypo: FWIW, it's the same problem Jenkins will have :) | 14:15 |
eharney | doesn't the Jenkins gate respect Depends-On in the commit message? | 14:15 |
jgriffith | eharney: It looks like maybe it will (by not running against it) | 14:16 |
jgriffith | eharney: but I thought typically sort of SOP was adding a dep in Gerrit, so everything gets pulled/tested | 14:16 |
eharney | yeah, the Depends-On bit is mostly for cross-project dependencies i think, using direct git dependencies is simpler when in the same project | 14:17 |
smcginnis | I agree. Within the same project I would rather not see that used much. | 14:17 |
eharney | but it does work because Jenkins passes, so that's kinda neat | 14:17 |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Filter snapshots data on the DB side https://review.openstack.org/184267 | 14:19 |
jgriffith | eharney: it is pretty cool | 14:20 |
smcginnis | I would be fine with it if | 14:21 |
smcginnis | "git review -d [number]" would take care of it for me. :) | 14:21 |
haypo | jgriffith, jenkins understands well depends-on, i used that on other projects | 14:21 |
jgriffith | haypo: indeed | 14:21 |
haypo | jgriffith, it requires manual action if a patch is accepted whereas dependencies are not accepted yet, and other patches are for other projects | 14:21 |
jgriffith | haypo: fine by me now that I realize it's there and works | 14:22 |
haypo | jgriffith, well, please review the dependency :-) https://review.openstack.org/#/c/190153/ | 14:22 |
jgriffith | frankly I don't care that much... but using git dependencies in the project is a bit easier for the masses IMO | 14:22 |
smcginnis | eharney just pushed it along. | 14:22 |
jgriffith | haypo: I've reviewed so many of your patches at this point :) | 14:23 |
*** nkrinner has quit IRC | 14:23 | |
haypo | jgriffith, yeah, by the way thank you for that :) | 14:23 |
haypo | i'm going to add a non voting py34 gate for cinder, so the gate will tell me if my tox patch works or not :) | 14:23 |
*** merooney has quit IRC | 14:24 | |
jgriffith | haypo: yes please :) | 14:24 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Ceph driver support retries on rados_connect_timeout https://review.openstack.org/190579 | 14:24 |
jgriffith | haypo: if you need help or want somebody else to do it let me know | 14:24 |
jgriffith | haypo: but seems like this is a pretty good mission for you | 14:24 |
haypo | jgriffith, my next goal is to have a working tox -e py34 and a voting py34 gate. since this point, following reviews will be simpler because we will be able to rely on the py34 gate | 14:27 |
*** mdbooth has quit IRC | 14:27 | |
eharney | sounds awesome | 14:27 |
*** sudipto has joined #openstack-cinder | 14:28 | |
thingee | jgriffith: you may want to comment on https://review.openstack.org/#/c/174941/4/cinder/db/sqlalchemy/migrate_repo/versions/047_add_default_backup_quota.py,cm | 14:29 |
*** sudipto has quit IRC | 14:30 | |
thingee | jgriffith: since you've been doing some clean ups in this area | 14:30 |
*** xyang1 has quit IRC | 14:31 | |
*** shausy has quit IRC | 14:31 | |
*** merooney has joined #openstack-cinder | 14:32 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder-specs: Cinder API WSGI application under Apache/Nginx https://review.openstack.org/192683 | 14:33 |
haypo | https://review.openstack.org/192702 "Add a non-voting py34 check job to Cinder" here you have ;) | 14:34 |
*** ronenkat__ has quit IRC | 14:34 | |
jgriffith | thingee: good call, thanks | 14:34 |
*** rmesta has joined #openstack-cinder | 14:35 | |
jgriffith | haypo: one problem | 14:35 |
jgriffith | I don't think you want stable branches there | 14:35 |
*** daneyon has joined #openstack-cinder | 14:35 | |
haypo | jgriffith, my patch is only for master: "Only add the check job to the master branch, ignore Kilo branches and older since they will not get Python 3 support." | 14:36 |
haypo | jgriffith, am i wrong? | 14:36 |
jgriffith | haypo: haha... no, I interpretted the inverse of the regex ) | 14:36 |
*** ronis has quit IRC | 14:36 | |
haypo | jgriffith, i didn't write the regex, i copied it from other projects. (?!...) means "Matches if ... *doesn’t* match next." | 14:37 |
haypo | it would be a real issue if the gate becomes voting, tests will obvisouly fail on python 3.4 for stable branches :-) | 14:37 |
jgriffith | :) | 14:38 |
jgriffith | indeed it would | 14:38 |
*** daneyon has quit IRC | 14:40 | |
*** anshul has quit IRC | 14:40 | |
*** gouthamr has quit IRC | 14:43 | |
*** belmoreira has quit IRC | 14:45 | |
thingee | aarefiev, DuncanT: retargeting this for l-2 ... not sure if we can resolve things here https://bugs.launchpad.net/cinder/+bug/1307491 | 14:47 |
openstack | Launchpad bug 1307491 in Cinder "quota-update should error out if input provided is non-existent tenant id" [Medium,In progress] - Assigned to Anton Arefiev (aarefiev) | 14:47 |
*** cdelatte has joined #openstack-cinder | 14:47 | |
haypo | smcginnis, jgriffith : FYI on a fresh ubuntu 14.04.2, tox -e py34 succeded, same result than Cyril Roelandtand Anton Arefiev. i guess that you just missed a dependency and/or had issues with your setup | 14:48 |
*** diogogmt has joined #openstack-cinder | 14:50 | |
lidan | https://review.openstack.org/#/c/188240/ | 14:50 |
*** xylan_kong has left #openstack-cinder | 14:50 | |
*** gouthamr has joined #openstack-cinder | 14:51 | |
lidan | hi all ,can you take some to review our driver,https://review.openstack.org/#/c/188240/ | 14:51 |
aarefiev | thingee: unfortunately, also I think nested quota should touch this since we need info about tenants | 14:51 |
*** xyang has joined #openstack-cinder | 14:51 | |
DuncanT | thingee: I still worry about cross-api chained calls... in the case of keystone though, if keystone is down you don't get any calls anyway, so maybe this is ok? | 14:52 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder-specs: Cinder API WSGI application under Apache/Nginx https://review.openstack.org/192683 | 14:53 |
*** dulek has quit IRC | 14:53 | |
*** sudipto has joined #openstack-cinder | 14:54 | |
e0ne | thingee: hi. i guess you leave +A https://review.openstack.org/#/c/165688/ for Jay? | 14:54 |
thingee | e0ne: yeah, although the last issue was addressed | 14:55 |
e0ne | thingee: ok, thanks for review | 14:55 |
aarefiev | DuncanT: why do you worry about keystone down, if it is so authentication request fail too | 14:58 |
DuncanT | aarefiev: Slow is worse than down | 14:59 |
DuncanT | aarefiev: Though I guess that will also throttle incoming requests too | 15:00 |
DuncanT | aarefiev: keystone might be a special case here, hence the above comment | 15:00 |
*** rakesh_mishra has quit IRC | 15:00 | |
DuncanT | aarefiev: I'll take off the -2 I think, and just leave a comment for others to consider | 15:00 |
*** rhagarty__ has quit IRC | 15:01 | |
*** rhagarty has quit IRC | 15:02 | |
*** rhagarty__ has joined #openstack-cinder | 15:02 | |
*** markstur has quit IRC | 15:02 | |
aarefiev | DuncanT: but we don't have another way to verify tenant | 15:02 |
*** rhagarty has joined #openstack-cinder | 15:02 | |
*** markstur has joined #openstack-cinder | 15:03 | |
DuncanT | aarefiev: There are lots of things we can't verify without cross-proejct calls, and sometimes the cost is too high and it is better not to verify | 15:03 |
DuncanT | aarefiev: There was something added to call glance during a common API call - that was definitely a no-no | 15:04 |
*** xyang1 has joined #openstack-cinder | 15:04 | |
DuncanT | aarefiev: This call is admin-only and not common, and keystone is self-rate-limitting, so maybe it is ok, I haven't made my mind up, thinking about it now though | 15:04 |
*** smoriya has joined #openstack-cinder | 15:05 | |
*** openstackgerrit has quit IRC | 15:05 | |
*** openstackgerrit has joined #openstack-cinder | 15:05 | |
*** zongliang has joined #openstack-cinder | 15:08 | |
*** xyang has quit IRC | 15:08 | |
*** xyang has joined #openstack-cinder | 15:08 | |
zongliang | hi | 15:10 |
*** afazekas has quit IRC | 15:10 | |
*** adurbin__ has joined #openstack-cinder | 15:11 | |
*** jungleboyj has joined #openstack-cinder | 15:12 | |
*** haypo has left #openstack-cinder | 15:12 | |
*** xyang has quit IRC | 15:13 | |
aarefiev | DuncanT: agree, we must be careful with cross project communication, but we can't without it to keep consistency | 15:13 |
*** xyang has joined #openstack-cinder | 15:14 | |
DuncanT | aarefiev: In many cases, I'd rather have loose consistency than tight coupling. I get woken up at 4am when the Cinder API goes down, even if the root cause is some other service. It gives me a certain prospective. | 15:15 |
*** xyang has quit IRC | 15:16 | |
*** xyang has joined #openstack-cinder | 15:16 | |
aarefiev | DuncanT: yea, it ts known problem :) | 15:17 |
*** anshul has joined #openstack-cinder | 15:17 | |
DuncanT | aarefiev: I'll continue to strongly resist anything that makes me more likely to get woken up, just like I try to resist things that break upgrades, since that also comes back to bite my team hard | 15:18 |
*** mtanino has joined #openstack-cinder | 15:18 | |
*** jungleboyj has quit IRC | 15:19 | |
*** xyang has quit IRC | 15:20 | |
*** xyang has joined #openstack-cinder | 15:21 | |
*** afazekas has joined #openstack-cinder | 15:23 | |
*** anshul has quit IRC | 15:24 | |
*** jnicklin has joined #openstack-cinder | 15:25 | |
aarefiev | Duncan: got your point, fair enough | 15:27 |
*** afazekas has quit IRC | 15:28 | |
*** alonmarx has joined #openstack-cinder | 15:31 | |
*** Maike has quit IRC | 15:32 | |
*** alonmarx_ has quit IRC | 15:33 | |
*** timcl has quit IRC | 15:34 | |
*** timcl has joined #openstack-cinder | 15:34 | |
*** patrickeast has joined #openstack-cinder | 15:35 | |
*** timcl has quit IRC | 15:36 | |
*** leeantho has joined #openstack-cinder | 15:36 | |
*** jamielennox is now known as jamielennox|away | 15:38 | |
*** jdurgin1 has quit IRC | 15:39 | |
*** vokt has joined #openstack-cinder | 15:39 | |
*** timcl has joined #openstack-cinder | 15:40 | |
jordanP | eharney, could you re-review https://review.openstack.org/#/c/188442 (Scality SOFS: enhance how the remoteFS mount is detected) plz ? | 15:40 |
*** patrickeast has quit IRC | 15:40 | |
eharney | jordanP: sure | 15:40 |
*** lpetrut has quit IRC | 15:42 | |
*** harlowja_at_home has joined #openstack-cinder | 15:42 | |
*** timcl1 has joined #openstack-cinder | 15:42 | |
*** BharatK has joined #openstack-cinder | 15:43 | |
*** dannywilson has joined #openstack-cinder | 15:44 | |
eharney | jordanP: also, i'm happy to see the blockrebase patch | 15:44 |
*** timcl has quit IRC | 15:44 | |
eharney | jordanP: someone else was just asking about that this week | 15:44 |
jordanP | eharney, I see you follow closely the ML. Yeah, it"s an attempt but it seems to work and it's not that intrusive imo | 15:45 |
*** merooney has quit IRC | 15:45 | |
jordanP | eharney, I need to write some unit tests but I'd like some feedback in the mean time | 15:45 |
*** smoriya has quit IRC | 15:46 | |
thingee | jgriffith: should we revisit this in the meeting https://etherpad.openstack.org/p/cinder-code-cleanups ? | 15:46 |
*** dannywilson has quit IRC | 15:46 | |
*** jungleboyj has joined #openstack-cinder | 15:46 | |
*** garthb has joined #openstack-cinder | 15:46 | |
*** garthb_ has joined #openstack-cinder | 15:46 | |
*** jamielennox|away is now known as jamielennox | 15:47 | |
*** dannywilson has joined #openstack-cinder | 15:47 | |
jordanP | my long term goal is to refactor our driver (Scality) to reuse the remoteFS code but I need the full tempest tests to pass and currently the rewritten version fails the cert test because of the boot_from_volume scenario | 15:47 |
*** hemnafk is now known as hemna | 15:47 | |
flip214 | jgriffith: thingee: duncan: DRBD driver looks fine. I'll keep watching it for a while, but eg. https://review.openstack.org/#/c/187707/ on patch set 11 says SUCCESS | 15:48 |
*** sreedharv has joined #openstack-cinder | 15:48 | |
*** lcurtis has joined #openstack-cinder | 15:49 | |
thingee | flip214: excellent | 15:50 |
*** rakesh_mishra has joined #openstack-cinder | 15:50 | |
*** cs_0x6373 has quit IRC | 15:51 | |
hemna | morning | 15:51 |
e0ne | hemna: evening:) | 15:51 |
smcginnis | hemna: Shouldn't you be fishing? | 15:52 |
hemna | I'd love another few days out there. | 15:52 |
hemna | but today, it's back to the grind | 15:52 |
smcginnis | hemna: The fish probably need the break. ;) | 15:52 |
hemna | I'm good and sunburned | 15:52 |
hemna | :) | 15:52 |
hemna | was about 20 fish a day, so yah, I'm sure they are tired as well | 15:52 |
smcginnis | Dang | 15:53 |
jungleboyj | hemna: Wow, that is impressive. | 15:54 |
xyang | hemna: what do you do with that many fish? Do you put them back or consume them or sell them?:) | 15:54 |
hemna | I ate all of them | 15:54 |
xyang | :) | 15:54 |
hemna | lol, jk | 15:54 |
hemna | catch and release for me | 15:55 |
xyang | ok:) | 15:55 |
xyang | then you should have endless supply | 15:55 |
smcginnis | Same dumb fish over and over. ;) | 15:55 |
hemna | heh yah. it was a good few days. I forgot what a day off work was like | 15:55 |
*** adurbin_ has joined #openstack-cinder | 15:55 | |
kmartin | I only saw a picture of one fish, so this 20 might be one of those fish stories :) | 15:56 |
xyang | :) | 15:56 |
e0ne | :) | 15:56 |
hemna | :) | 15:56 |
*** patrickeast has joined #openstack-cinder | 15:57 | |
*** alau2 has joined #openstack-cinder | 15:57 | |
*** jamielennox is now known as jamielennox|away | 15:58 | |
*** tsekiyama has joined #openstack-cinder | 15:58 | |
e0ne | jungleboyj: hi. we need your final vot for https://review.openstack.org/#/c/165688/, please | 15:58 |
*** cs_0x6373 has joined #openstack-cinder | 15:58 | |
*** krtaylor has quit IRC | 15:59 | |
*** jordanP has quit IRC | 15:59 | |
*** gouthamr has quit IRC | 16:00 | |
*** dulek_home has joined #openstack-cinder | 16:02 | |
*** daneyon has joined #openstack-cinder | 16:04 | |
*** vokt has quit IRC | 16:04 | |
lidan | . | 16:04 |
*** daneyon_ has joined #openstack-cinder | 16:04 | |
*** jamielennox|away is now known as jamielennox | 16:06 | |
*** vilobhmm has joined #openstack-cinder | 16:06 | |
*** BharatK has quit IRC | 16:06 | |
*** gouthamr has joined #openstack-cinder | 16:08 | |
*** daneyon has quit IRC | 16:08 | |
*** Apoorva has joined #openstack-cinder | 16:09 | |
*** Adriano__ has joined #openstack-cinder | 16:11 | |
*** dims_ has joined #openstack-cinder | 16:11 | |
*** krtaylor has joined #openstack-cinder | 16:11 | |
openstackgerrit | Anton Arefiev proposed openstack/cinder: WIP: add driver list generator https://review.openstack.org/192751 | 16:13 |
*** dims has quit IRC | 16:13 | |
*** Yogi1 has quit IRC | 16:14 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: LVM add multiattach flag capability https://review.openstack.org/190725 | 16:16 |
flip214 | hemna: sorry about my (stupid?) questions ... coming from the HA side I'm burned by people running DRBD in Dual-Primary, with GFS2/OCFS2 or even multipoint iSCSI, and as soon as they crush their data they come to us whining... | 16:16 |
hemna | flip214, no worries man. not stupid questions at all. :) | 16:17 |
*** ronis has joined #openstack-cinder | 16:18 | |
*** Yogi1 has joined #openstack-cinder | 16:18 | |
flip214 | hemna: and so I fear that multi-attach against multi-homed storage volumes => one client writes *only* to A, the other *only* to B, and everything goes to hell. | 16:18 |
flip214 | yeah, that didn't match the topic there. Sorry. | 16:18 |
openstackgerrit | Anton Arefiev proposed openstack/cinder: WIP: add driver list generator https://review.openstack.org/192751 | 16:18 |
hemna | no problemo | 16:20 |
*** timcl1 has quit IRC | 16:22 | |
*** harlowja_at_home has quit IRC | 16:22 | |
*** amoturi has quit IRC | 16:22 | |
erlon | guys, is there a way to find old blueprints? Doing a search on launch pad only shows current blueprints. | 16:26 |
*** markus_z has quit IRC | 16:27 | |
*** afazekas has joined #openstack-cinder | 16:28 | |
*** vilobhmm has quit IRC | 16:28 | |
*** cs_0x6373 has quit IRC | 16:29 | |
*** lpetrut has joined #openstack-cinder | 16:30 | |
*** rakesh_mishra has quit IRC | 16:30 | |
*** openstackgerrit has quit IRC | 16:33 | |
*** openstackgerrit has joined #openstack-cinder | 16:34 | |
*** jamielennox is now known as jamielennox|away | 16:35 | |
*** cs_0x6373 has joined #openstack-cinder | 16:35 | |
*** krtaylor has quit IRC | 16:37 | |
*** gouthamr has quit IRC | 16:37 | |
*** sudipto has quit IRC | 16:38 | |
*** gouthamr has joined #openstack-cinder | 16:42 | |
*** Tross1 has joined #openstack-cinder | 16:43 | |
*** thangp_ has joined #openstack-cinder | 16:43 | |
*** rhagarty_ has joined #openstack-cinder | 16:43 | |
*** med_` has joined #openstack-cinder | 16:43 | |
*** Tross has quit IRC | 16:43 | |
*** changbl_ has joined #openstack-cinder | 16:44 | |
*** fifieldt_ has joined #openstack-cinder | 16:44 | |
*** mtanino has quit IRC | 16:45 | |
*** rhagarty has quit IRC | 16:45 | |
*** rhagarty__ has quit IRC | 16:45 | |
*** rushil has quit IRC | 16:45 | |
*** thangp has quit IRC | 16:45 | |
*** fifieldt has quit IRC | 16:45 | |
*** changbl has quit IRC | 16:45 | |
*** med_ has quit IRC | 16:45 | |
*** a| has joined #openstack-cinder | 16:46 | |
*** a| has quit IRC | 16:46 | |
*** timcl has joined #openstack-cinder | 16:47 | |
*** mfisch has quit IRC | 16:47 | |
*** logan2 has joined #openstack-cinder | 16:47 | |
*** krtaylor has joined #openstack-cinder | 16:48 | |
*** mtanino has joined #openstack-cinder | 16:49 | |
*** jamielennox|away is now known as jamielennox | 16:49 | |
*** mfisch has joined #openstack-cinder | 16:49 | |
*** mfisch has quit IRC | 16:50 | |
*** mfisch has joined #openstack-cinder | 16:50 | |
openstackgerrit | Alessandro Pilotti proposed openstack/cinder: Update guru meditation reports from oslo.incubator https://review.openstack.org/192616 | 16:50 |
*** laughterwym has quit IRC | 16:50 | |
*** alexpilotti has joined #openstack-cinder | 16:51 | |
alexpilotti | jgriffith: morning | 16:54 |
alexpilotti | jgriffith: we have a blocking issue with a patch that merged recently and broke all the Windows code: https://review.openstack.org/#/q/f2dc050e4df6ec52a2dad258bb4172ebad47422c,n,z | 16:54 |
alexpilotti | jgriffith: this patch includes some very old oslo code, which is strange since the patch is recent | 16:55 |
*** belmoreira has joined #openstack-cinder | 16:57 | |
*** abhishekk has quit IRC | 16:58 | |
thingee | jungleboyj: was going to ask about these https://bugs.launchpad.net/neutron/+bug/1409733 and https://bugs.launchpad.net/cinder/+bug/1381563 | 16:58 |
openstack | Launchpad bug 1409733 in Cinder "adopt namespace-less oslo imports" [High,In progress] - Assigned to Jay Bryant (jsbryant) | 16:58 |
openstack | Launchpad bug 1381563 in Cinder "cinder using obsolete oslo modules" [Medium,In progress] - Assigned to Jay Bryant (jsbryant) | 16:58 |
*** vilobhmm has joined #openstack-cinder | 16:58 | |
thingee | I think one of them we need to move to L-2 | 16:58 |
erlon | thingee: quick question, is there a way to find old blueprints? | 16:59 |
erlon | thingee: I only can see the new ones | 16:59 |
vilobhmm | DuncanT : ping | 16:59 |
thingee | erlon: yeaaa, I think they get archived into a blackhole after marked for release | 16:59 |
*** _cjones_ has joined #openstack-cinder | 16:59 | |
thingee | erlon: not sure why that happens | 16:59 |
eharney | thingee: could you put the stable branch tasks on this bug into the right state? https://bugs.launchpad.net/cinder/+bug/1415087 (or jgriffith) | 16:59 |
openstack | Launchpad bug 1415087 in OpenStack Compute (nova) "[OSSA 2015-011] Format-guessing and file disclosure in image convert (CVE-2015-1850, CVE-2015-1851)" [High,Triaged] - Assigned to Tony Breeds (o-tony) | 16:59 |
*** dulek_home has quit IRC | 17:00 | |
*** e0ne has quit IRC | 17:00 | |
jungleboyj | thingee: Oh, cool. That is easy to deal with. :-) I know there is other stuff that I need to get merged in. Want to force time on that yet this week. | 17:00 |
erlon | thingee: too bad | 17:00 |
jungleboyj | I can easily get the status on those bugs udpated after I go grab some brain food. | 17:00 |
*** aswadr has quit IRC | 17:02 | |
*** asrangne has joined #openstack-cinder | 17:02 | |
*** dulek_home has joined #openstack-cinder | 17:02 | |
*** dulek_home has quit IRC | 17:03 | |
thingee | eharney: done | 17:03 |
thingee | eharney tristanC and thanks to you both on this work | 17:03 |
xyang | thingee: I finally have some good news to report on EMC XIO CI. It reported success here today: https://review.openstack.org/#/c/184596/ | 17:03 |
eharney | thingee: thanks, i'm not sure why the process of gerrit updating those seems to break down | 17:03 |
*** haomaiw__ has joined #openstack-cinder | 17:04 | |
thingee | xyang: oh good | 17:04 |
thingee | xyang: thanks | 17:04 |
*** rushiagr is now known as rushiagr_away | 17:04 | |
xyang | thingee: sorry it took so long | 17:04 |
*** haomaiwang has quit IRC | 17:04 | |
*** asrangne__ has joined #openstack-cinder | 17:05 | |
thingee | zongliang: I'm definitely not accepting any new patches from Huawei until we can see that changes will pass with your CI. I know you're all working on it though | 17:05 |
zongliang | We have try our best to fix the network problems of the ci,we want to target the Bo to l-2 | 17:08 |
zongliang | no | 17:08 |
*** asrangne has quit IRC | 17:08 | |
zongliang | thingee: 1:08:32 <zongliang> We have try our best to fix the network problems of the ci,we want to target the Bo to l-2 | 17:09 |
*** ronenkat has joined #openstack-cinder | 17:11 | |
DuncanT | vilobhmm: Hi | 17:11 |
*** ndipanov has quit IRC | 17:12 | |
*** jamielennox is now known as jamielennox|away | 17:13 | |
vilobhmm | as part of nested quota driver one of the action item was to Add tracing to include request_id, volume_id for easy tracing the magic performed by quota operation. | 17:15 |
vilobhmm | my approach is to include request_id as a field in cinder.quotas does it sound ok to you | 17:15 |
*** dims_ has quit IRC | 17:16 | |
vilobhmm | DuncanT : ^^ | 17:16 |
*** dims has joined #openstack-cinder | 17:17 | |
*** patrickeast has quit IRC | 17:18 | |
DuncanT | vilobhmm: I think it needed adding to the reservation, it doesn't make sense to add it to the quota object I don't think? | 17:18 |
vilobhmm | sure...cinder.reservations | 17:19 |
vilobhmm | true | 17:20 |
*** BharatK has joined #openstack-cinder | 17:20 | |
*** gouthamr has quit IRC | 17:23 | |
*** gouthamr has joined #openstack-cinder | 17:24 | |
DuncanT | Other than that, yes, seems right | 17:25 |
vilobhmm | sure | 17:32 |
vilobhmm | sorry someone stopped by | 17:32 |
vilobhmm | but i don;t think that we get volume_id details when the reservation_uuid is created or a reference for reservation is created in reservation table….volume_id is created after cinder.volume.flows.api.create_volume.EntryCreateTask is executed…. | 17:32 |
*** hodos has joined #openstack-cinder | 17:32 | |
vilobhmm | so as per the feedback in the summit | 17:32 |
vilobhmm | will add both volume_id as well as the request_id in cinder.reservations table so that we can trace the quota request for a specific volume | 17:33 |
vilobhmm | thanks DuncanT | 17:34 |
*** sreedharv has quit IRC | 17:35 | |
hodos | thingee: hi there, last 24 nexenta ci has about 20 successfull comments, so i think it's getting stable | 17:35 |
*** anshul has joined #openstack-cinder | 17:35 | |
*** belmoreira has quit IRC | 17:38 | |
thingee | hodos: it's not really running that often | 17:38 |
thingee | hodos: http://paste.openstack.org/raw/298977/ | 17:39 |
*** afazekas has quit IRC | 17:41 | |
*** breitz has joined #openstack-cinder | 17:42 | |
hodos | thingee: ok, last 24 hours it 19 from that paste, let's see how it goes from here | 17:42 |
*** aix has quit IRC | 17:42 | |
thingee | hodos: I would like to point out that Nexenta at this point is way past the deadline of having their CI together. http://lists.openstack.org/pipermail/openstack-dev/2015-May/064072.html | 17:43 |
thingee | hodos: so I'm wondering what makes Nexenta special here from the other vendors that have been cut for the same reason | 17:43 |
hodos | thingee: it said 12th for successfull run (a single one) and ci for ns4 was running even before that but not stable | 17:44 |
hodos | thingee: that paper says nothing about stability | 17:45 |
thingee | hodos: if your driver isn't stable, that's no good | 17:45 |
thingee | hodos: same standards we've held other vendors too | 17:45 |
hodos | thingee: i didn't change the driver since then | 17:45 |
*** gouthamr has quit IRC | 17:45 | |
thingee | your backend + openstack is not stable | 17:45 |
thingee | I don't care about the python code. | 17:46 |
*** gouthamr has joined #openstack-cinder | 17:46 | |
hodos | thingee: i didn't change the backend either, just better network in the lab | 17:46 |
hodos | thingee: it was really a bad ci infra | 17:47 |
hodos | thingee: not a backend/driver issue | 17:47 |
thingee | hodos: we have a scheduled time to have things done. That's the point of the deadlines. Nexenta has known about CI's since last year. They were cut in March from Kilo. Having your CI only now to get up to speed on stability is not acceptable | 17:47 |
thingee | hodos: we're not going by a vendor's timeline | 17:47 |
*** Longgeek has quit IRC | 17:48 | |
hodos | thingee: i perfectly understand that, but that deadline didn't say how stable ci must be, that's my only point, and it's pretty good now, i don't see why we can't get our driver back since it was there before; if ci continues to run of course | 17:49 |
thingee | hodos: it's common sense. if we can't see your CI passing, its not stable in an OpenStack environment from our eyes. If you're not ready for us to see things in passing in the time that we allocated to do vendor driver reviews, we can't drop our other priorities because you dropped the ball. | 17:51 |
xyang | thingee: can we merge a patch that uses taskflow? The manage/unmanage snapshot patch uses taskflow: https://review.openstack.org/#/c/144590/59/cinder/volume/flows/manager/manage_existing_snapshot.py I know we haven't made decision on taskflow yet, so the question is do we accept a patch that introduces a new feature but uses taskflow to implement | 17:51 |
xyang | it | 17:51 |
*** e0ne has joined #openstack-cinder | 17:51 | |
*** IlyaG has joined #openstack-cinder | 17:52 | |
*** timcl has quit IRC | 17:56 | |
*** merooney has joined #openstack-cinder | 17:56 | |
thingee | xyang: I'd really like the people who oppose going further with taskflow to sign off on this. (e.g. jgriffith and DuncanT) ... we only today merged the first patch of refactoring | 17:56 |
thingee | xyang: and the additional refactoring work is happening in l-2 | 17:56 |
xyang | thingee: sure. I'll ping jgriffith and DuncanT to look at the patch then | 17:57 |
*** dannywilson has quit IRC | 17:57 | |
e0ne | thingee: fyi, we've got a very big performance impact with persistance taswflow. but may be it's not only taskflow issue | 17:58 |
thingee | e0ne: oh? | 17:59 |
thingee | xyang: I can retarget that to L-2 | 17:59 |
thingee | xyang: I think we need the refactor stuff to land first, which will be in L-2 | 17:59 |
xyang | thingee: sure, that makes sense | 17:59 |
*** gouthamr has quit IRC | 18:00 | |
e0ne | thingee: https://etherpad.openstack.org/p/taskflow_persistence_benchmarking | 18:01 |
e0ne | thingee: but aarefiev found issue in dulek's patch, so performance impact could be not so big. i hope, we'll get results tomorrow | 18:01 |
*** hodos has quit IRC | 18:02 | |
openstackgerrit | Dmitry Guryanov proposed openstack/cinder: Add Virtuozzo Storage Volume Driver https://review.openstack.org/188869 | 18:04 |
*** ociuhandu has quit IRC | 18:06 | |
*** timcl has joined #openstack-cinder | 18:06 | |
vilobhmm | e0ne : nice work ! | 18:06 |
e0ne | vilobhmm: thanks! | 18:07 |
*** annashen has joined #openstack-cinder | 18:07 | |
rlucio | just a general FYI, the VMEM v6000_iscsi CI is going to be disabled temporarily, the iscsi connections are acting up, and going to be replaced | 18:08 |
*** IanGovett has joined #openstack-cinder | 18:11 | |
hemna | earlephilhower, ping | 18:11 |
mtanino | jungleboyj: Hi, | 18:11 |
mtanino | jungleboyj: May I ask a question about your oslo work? | 18:12 |
jungleboyj | mtanino: Sure. | 18:12 |
*** merooney has quit IRC | 18:12 | |
mtanino | jungleboyj: I think oslo.service graduated from oslo-incubator recently. Do you have a plan to import it into Cinder? | 18:13 |
*** annashen has quit IRC | 18:13 | |
jungleboyj | Yep, I saw that bug/patch you had and that was the first Oslo change I was looking at. | 18:13 |
jungleboyj | Hopefully today, don't know how much work it will be. Hopefully not a lot. | 18:13 |
*** amoturi has joined #openstack-cinder | 18:14 | |
mtanino | jungleboyj: OK. I understand. After introducing the oslo.service, I need to more patch to fix a problem of graceful shutdown. | 18:14 |
mtanino | one more patch. | 18:14 |
jungleboyj | mtanino: Right. | 18:14 |
mtanino | jungleboyj: thanks :) | 18:14 |
jungleboyj | mtanino: I will ping you as soon as I have a review up for you to look at. | 18:15 |
*** merooney has joined #openstack-cinder | 18:15 | |
*** annashen has joined #openstack-cinder | 18:15 | |
mtanino | jungleboyj: sure. I understand. | 18:15 |
*** gouthamr has joined #openstack-cinder | 18:16 | |
jungleboyj | Thanks for bringing that up. I caught your comment on that last night and had it as a todo to look at today. | 18:16 |
mtanino | jungleboyj: Also in order to fix stable/kilo, we need to fix openstack/common/** directly, because we don't backport oslo.service for stable branch, right? | 18:18 |
mtanino | you are welcome :) | 18:18 |
* jungleboyj 's mind is blown | 18:18 | |
jungleboyj | mtanino: So, do you have a pointer to what needs to change in openstack/common/** | 18:19 |
hemna | doh | 18:19 |
mtanino | jungleboyj: openstack/common/service.py | 18:19 |
jungleboyj | mtanino: Right, but what is the fix? | 18:19 |
mtanino | jungleboyj: I think we need backport this fix https://review.openstack.org/#/c/190175/ | 18:20 |
mtanino | Am I missing something?... | 18:23 |
jungleboyj | mtanino: Looking. | 18:24 |
*** markvoelker has quit IRC | 18:25 | |
openstackgerrit | Tom Swanson proposed openstack/cinder: Dell SC Removed _find_domain and associated tests https://review.openstack.org/192275 | 18:25 |
*** markvoelker has joined #openstack-cinder | 18:25 | |
jungleboyj | mtanino: So, looking at bug 1464822, that is ugly looking. | 18:26 |
openstack | bug 1464822 in Cinder "Cinder does not shutdown processes gracefully" [Low,In progress] https://launchpad.net/bugs/1464822 - Assigned to Mitsuhiro Tanino (mitsuhiro-tanino) | 18:26 |
jungleboyj | Seems like it would be good to fix that for Kilo. | 18:26 |
*** ericksonsantos has joined #openstack-cinder | 18:26 | |
mtanino | yes. I agree on it. | 18:27 |
mtanino | OK. so I will propose backport patch for stable/kilo. Thanks. | 18:27 |
jungleboyj | Interesting, looks like service.py is actually still in the incubator. | 18:28 |
*** akerr has quit IRC | 18:28 | |
jungleboyj | mtanino: Doing some more looking. | 18:28 |
mtanino | sure. | 18:28 |
*** akerr has joined #openstack-cinder | 18:29 | |
alexpilotti | thingee jgriffith: any chance you could help in getting this patch merged to have the Windows CI resume? https://review.openstack.org/#/c/192616/ | 18:29 |
jungleboyj | mtanino so there is this fix that went in to kilo for service.py: https://bugs.launchpad.net/cinder/+bug/1446583 | 18:31 |
openstack | Launchpad bug 1446583 in Keystone "services no longer reliably stop in stable/kilo" [Critical,Fix committed] - Assigned to Brant Knudson (blk-u) | 18:31 |
jungleboyj | That is not the same thing though. | 18:31 |
jungleboyj | Since service is still in oslo-incubator we should propose the change there first and then pull it back into cinder ... | 18:32 |
mtanino | This 1446583 destroyed graceful shutdown... | 18:32 |
*** mriedem has quit IRC | 18:32 | |
jungleboyj | That is silly though if we are just going to move off of using openstack/common/service.py | 18:33 |
jungleboyj | I am ok with doing an exception to push this back into Kilo given the situation if thingee and jgriffith don't oppose. | 18:33 |
mtanino | jungleboyj: ok. let me try to propose stable/kilo and get feedback from John and Mike. | 18:34 |
jungleboyj | mtanino: Works for me. | 18:35 |
jungleboyj | mtanino: Thanks for your help. Greatly appreciated! | 18:36 |
mtanino | jungleboyj: You too! | 18:37 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Ceph driver support retries on rados_connect_timeout https://review.openstack.org/190579 | 18:37 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Ceph driver support retries on rados_connect_timeout https://review.openstack.org/190579 | 18:37 |
*** afazekas has joined #openstack-cinder | 18:41 | |
e0ne | am i alone not happy with code architecture like https://review.openstack.org/#/c/189920/10/cinder/volume/drivers/violin/v7000_fcp.py? | 18:42 |
e0ne | I mean a lot of drivers have something like "def create_volume(self, volume): self.common._create_volume(volume)" instead of adding 'common' class to parents? | 18:43 |
eharney | e0ne: i actually was a bit puzzled by this same thing... self.common seems wrong | 18:44 |
*** daneyon_ has quit IRC | 18:45 | |
*** daneyon has joined #openstack-cinder | 18:46 | |
e0ne | eharney: i asked this question in review and got answer like 'because we use ABC and need to inherit only from VolumeXXX classes' | 18:46 |
e0ne | sounds wrong | 18:46 |
eharney | e0ne: yes, it does | 18:46 |
earlephilhower | hemna: Pong. Was doing a webinar. Anything I can do for you? | 18:47 |
*** markvoelker_ has joined #openstack-cinder | 18:47 | |
*** markvoelker has quit IRC | 18:47 | |
hemna | earlephilhower, just wanted to see if you can update the HGST connector in os-brick | 18:48 |
hemna | so we can get it to land | 18:48 |
e0ne | eharney: i feel good that not only me is confused... is openstack-dev a good place to start conversation about it? | 18:48 |
*** Longgeek has joined #openstack-cinder | 18:48 | |
* earlephilhower checks the gerrit | 18:49 | |
*** daneyon_ has joined #openstack-cinder | 18:49 | |
eharney | e0ne: i dunno... it seems like basic code review debate to me. The main point of common classes is so you can inherit from them, not instantiate them again... | 18:50 |
earlephilhower | hemna, sure. I always get expected/actual backwards on asserts. | 18:50 |
*** mtecer has joined #openstack-cinder | 18:50 | |
hemna | np | 18:50 |
*** akerr_ has joined #openstack-cinder | 18:50 | |
e0ne | eharney: +1. but we already have a lot of such code | 18:50 |
eharney | e0ne: well, we have a lot of messy code... but we don't need to add more :) | 18:51 |
e0ne | eharney: :) | 18:51 |
*** akerr has quit IRC | 18:51 | |
eharney | e0ne: in this instance it mostly depends on how hard it is to fix imo | 18:51 |
*** daneyon has quit IRC | 18:52 | |
*** Longgeek has quit IRC | 18:53 | |
eharney | e0ne: but looking at what's in the common class, i think it's just structured wrong | 18:53 |
e0ne | eharney: do you mean that one from my link above? | 18:54 |
eharney | e0ne: yes | 18:54 |
*** mriedem has joined #openstack-cinder | 18:54 | |
*** ociuhandu has joined #openstack-cinder | 18:54 | |
*** akerr_ has quit IRC | 18:55 | |
*** krtaylor has quit IRC | 18:57 | |
*** mtecer has quit IRC | 19:02 | |
hemna | thingee, when you have a moment, can you update this guy? https://blueprints.launchpad.net/python-cinderclient/+spec/multi-attach-volume | 19:02 |
hemna | thingee, the cinderclient change has landed for that BP | 19:03 |
mtanino | congratulation! | 19:03 |
*** timcl has quit IRC | 19:04 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/os-brick: Add HGST Solutions connector https://review.openstack.org/186588 | 19:04 |
*** timcl has joined #openstack-cinder | 19:06 | |
jungleboyj | mtanino: You still around? | 19:07 |
mtanino | jungleboyj: yes. | 19:07 |
jungleboyj | hemna: Congrats! | 19:07 |
hemna | jungleboyj, thanks :) | 19:07 |
hemna | Nova has 3 different patches in flight still..... | 19:07 |
jungleboyj | Hey, I was just talking to our Oslo guy about that service change. | 19:07 |
mtanino | jungleboyj: oh, nice! | 19:08 |
mtanino | so the plan is? | 19:08 |
jungleboyj | He wanted to make sure it went through incubator. So, he is going to work on getting it into service.py and backporting to stable so we can just do a sync the way we should. | 19:09 |
jungleboyj | There is another guy on stable that will, most likely, reject what we discussed. :-) | 19:10 |
mtanino | hmmm, | 19:10 |
jungleboyj | So, let me work the process here. | 19:11 |
mtanino | so backporting oslo.service to stable/kilo is a little bit large fix, I think. but they will do it? | 19:11 |
dims | don't think that's a good idea | 19:12 |
jungleboyj | Yes, the risk we run doing it the way you and I talked is that if someone else tries to sync, we lose the patch. | 19:12 |
jungleboyj | dims: Ok. | 19:12 |
dims | we still haven't released or stabilized oslo.service | 19:12 |
mtanino | I understand. | 19:12 |
*** fifieldt_ has quit IRC | 19:12 | |
*** bswartz has quit IRC | 19:12 | |
dims | sorry for jumping in :) | 19:12 |
mtanino | dims: welcome :) | 19:13 |
*** IanGovett has quit IRC | 19:13 | |
*** ronis has quit IRC | 19:14 | |
*** BharatK has quit IRC | 19:14 | |
jungleboyj | dims: No problem. We are just talking about backporting the fix for this: https://launchpad.net/bugs/1464822 | 19:14 |
openstack | Launchpad bug 1464822 in Cinder "Cinder does not shutdown processes gracefully" [Low,In progress] - Assigned to Mitsuhiro Tanino (mitsuhiro-tanino) | 19:14 |
jungleboyj | from oslo.service to oslo-incubator's version of service. | 19:14 |
*** openstackgerrit has quit IRC | 19:16 | |
jungleboyj | dims: You are not ok with that? | 19:16 |
*** openstackgerrit has joined #openstack-cinder | 19:17 | |
*** jecarey has joined #openstack-cinder | 19:20 | |
*** afazekas has quit IRC | 19:21 | |
dims | jungleboyj: when we start cutting releases, we remove the incubated code | 19:22 |
*** zongliang has quit IRC | 19:22 | |
ociuhandu | thingee: can you or anyone else help us with reviews on https://review.openstack.org/#/c/192616/ so we can bring back asap the Microsoft CI? | 19:22 |
dims | let's talk on oslo channel, as we can include dhellmann as well | 19:22 |
jungleboyj | dims: Ok. | 19:24 |
*** mtecer has joined #openstack-cinder | 19:27 | |
*** merooney has quit IRC | 19:28 | |
*** krtaylor has joined #openstack-cinder | 19:29 | |
*** fifieldt_ has joined #openstack-cinder | 19:30 | |
*** merooney has joined #openstack-cinder | 19:32 | |
*** jungleboyj has quit IRC | 19:32 | |
*** ronis has joined #openstack-cinder | 19:38 | |
*** IanGovett has joined #openstack-cinder | 19:42 | |
*** nkrinner has joined #openstack-cinder | 19:46 | |
*** Longgeek has joined #openstack-cinder | 19:49 | |
*** jungleboyj has joined #openstack-cinder | 19:50 | |
*** Yogi1 has quit IRC | 19:51 | |
*** sgordon has joined #openstack-cinder | 19:56 | |
thingee | hemna done | 19:56 |
*** Rockyg has joined #openstack-cinder | 19:57 | |
*** Rockyg has quit IRC | 19:57 | |
*** timcl has quit IRC | 19:58 | |
*** Ctina_ has quit IRC | 19:59 | |
*** Rockyg has joined #openstack-cinder | 19:59 | |
*** Yogi1 has joined #openstack-cinder | 19:59 | |
rlucio | e0ne: the primary issue with the inheriting from common class is that we are arequired to inherit from the driver.ISCSIDriver or driver.FibreChannelDriver | 20:00 |
rlucio | e0ne: I got dinged pretty hard in kilo for that on the other vmem drivers | 20:01 |
jungleboyj | mtanino: Talking over in the oslo channel. Maybe my first idea was right. Will let you kow. | 20:01 |
rlucio | e0ne: so i restructured to use the common class more like a utility library | 20:01 |
e0ne | rlucio: you can inherrit from driver.ISCSIDriver and your DriverNCommonClass | 20:01 |
mtanino | jungleboyj: waiting the discussion result :) | 20:01 |
rlucio | e0ne: is that acceptable for coding standards? | 20:02 |
e0ne | rlucio: why not? we use multiple inheritance in Cinder | 20:02 |
rlucio | e0ne: I personally think it should be OK, but I don't want to restructure everything and then be told NO later | 20:03 |
rlucio | e0ne: cause that sucked last time | 20:04 |
e0ne | rlucio: hm... did somebody told you that you should not inherit from you common class? | 20:05 |
*** kjnelson has quit IRC | 20:05 | |
*** Longgeek has quit IRC | 20:06 | |
rlucio | e0ne: yea, back in kilo when i submitted the v6000_fcp and v6000_iscsi drivers | 20:07 |
*** marcusvrn1 has quit IRC | 20:07 | |
e0ne | rlucio: i'm very surprised | 20:07 |
rlucio | e0ne: i don't recall exactly who it was unfortunately, do we keep reviews that old around? I could try to dig it up | 20:07 |
e0ne | rlucio: is it hard for you to find that review request? | 20:07 |
rlucio | e0ne: gimme a min, i'll try | 20:08 |
e0ne | rlucio: sure, thanks | 20:08 |
hemna | thingee, thank you | 20:08 |
e0ne | rlucio: btw, i found my first commit in gerrit made in Dec, 2011:) | 20:09 |
rlucio | e0one: looks like it was hemna who mentioned it, https://review.openstack.org/#/c/139793/ | 20:10 |
rlucio | e0ne: patch set 5 comments | 20:11 |
*** hodos has joined #openstack-cinder | 20:11 | |
hemna | rlucio, well the driver wasn't extended from the FC parent class | 20:12 |
rlucio | e0ne: here is direct link:https://review.openstack.org/#/c/139793/5/cinder/volume/drivers/violin/v6000_fcp.py | 20:13 |
e0ne | rlucio: i believe, you misunderstood each other | 20:13 |
rlucio | e0ne: how so? | 20:13 |
e0ne | rlucio: 1min, please. trying to draw ascii in paste | 20:14 |
rlucio | e0ne: lol, k | 20:14 |
*** sgotliv_ has joined #openstack-cinder | 20:14 | |
*** Lee1092 has quit IRC | 20:15 | |
e0ne | i failed with ascii:( | 20:15 |
geguileo | Anybody knows how capacity filter works? | 20:16 |
e0ne | hemna: did you mean something like class V6000FCDriver(driver.FibreChannelDriver, v6000_common.V6000CommonDriver)? for rlucio's patch? | 20:16 |
geguileo | I'm trying to figure out a patch and I must be missing something with free_capacity_gb, total_capacity_gb, etc | 20:16 |
geguileo | It's related to thin provisioning | 20:17 |
hemna | e0ne, yes | 20:17 |
e0ne | whew | 20:17 |
*** sgotliv has quit IRC | 20:17 | |
e0ne | rlucio: so, looks like now we understand what we want, do we? | 20:18 |
rlucio | e0ne, hemna: huh. well i did indeed misunderstand him | 20:18 |
rlucio | e0ne: yea | 20:18 |
e0ne | rlucio: great! | 20:18 |
*** amoturi has quit IRC | 20:18 | |
rlucio | e0ne: gonna be a bit of work but i'll fix it up | 20:19 |
e0ne | rlucio: thanks! | 20:19 |
*** dannywilson has joined #openstack-cinder | 20:19 | |
*** dannywilson has quit IRC | 20:19 | |
e0ne | rlucio: i'll review your patch tomorrow morning if new version will be available | 20:19 |
rlucio | e0ne: sounds good, thanks a bunch | 20:19 |
*** dannywilson has joined #openstack-cinder | 20:20 | |
e0ne | rlucio: np | 20:20 |
thingee | ameade: hey question about the eseries FC CI | 20:20 |
ameade | thingee: what's up? | 20:20 |
e0ne | bb in ~12 hours. time to sleep:) | 20:21 |
thingee | ameade: you have zero failures in your last 200 comments. that's impossible | 20:21 |
ameade | thingee: I dont allow failures to post until they are analyzed | 20:22 |
thingee | ameade: uhh ok, we need to change that | 20:22 |
ameade | thingee: I can do that, why exactly though? | 20:23 |
*** merooney has quit IRC | 20:23 | |
thingee | ameade: I highly doubt someone is paid full time by netapp to analyze these failures and give them at a reasonable time for reviewers to make decisions. | 20:23 |
thingee | ameade: and also, there have been valid failures in the last 200 patches. | 20:24 |
*** thangp_ has quit IRC | 20:24 | |
thingee | ameade: so this is not working | 20:24 |
ameade | thingee: I look at them, and they only run on patches that have Jenkins +1 | 20:24 |
ameade | thingee: the alternative is failures posted on patches that could be false failures and nobody looks at them but me anyways | 20:25 |
thingee | ameade: my point is in your last 200 comments, none have been marked as failures for valid reasons of the patch not working. There have been patches that should've been marked as failure by your CI | 20:25 |
thingee | ameade: I will say it again, this is not working | 20:25 |
thingee | ameade: I will post this to third party announce list as no one should be doing this. | 20:25 |
ericksonsantos | vilobhmm, ping | 20:25 |
thingee | ameade: This even comes across shady. You have some vendors who aren't even making it into the release because of the amount of false failures they have been posting | 20:26 |
thingee | ameade: does this make sense? | 20:26 |
*** thangp has joined #openstack-cinder | 20:27 | |
ameade | kind of? I still think it's better that if a CI says failure on a patch that it actually means failure, if it says thumbs up on a patch that it shouldnt then that is a real problem. I will go ahead and tweak it to post no matter what though | 20:28 |
*** lpetrut has quit IRC | 20:29 | |
thingee | ameade: wow, I need someone else at netapp to talk to then. | 20:29 |
thingee | preferably someone who understands the point of the CI's here. | 20:29 |
ameade | thingee: what? i'm trying to discuss what is best here, as a member of the community | 20:29 |
ameade | I am changing the netapp ci right now | 20:30 |
ameade | i am not a vendor, i run a vendors CI | 20:30 |
thingee | ameade: I pointed out shadiness here and you're slapping me in the face here by saying you "kind of" understand? | 20:31 |
hemna | all failures should post | 20:32 |
ameade | thingee: as someone with pure intentions i'm not thinking with shadiness in the forefront of my mind | 20:32 |
hemna | hiding failures is bad mmmkay | 20:32 |
*** e0ne has quit IRC | 20:32 | |
thingee | ameade: I will type it again, you have vendors like Nexenta who are not making it in the release because of their false CI failures. You don't see anything wrong with hiding *all* of your failures here? | 20:32 |
ameade | i'm not hiding failures, i'm just not posting false failures | 20:33 |
thingee | ameade: and what's the point of us automating this if you can't tell me if this patch breaks your integration? | 20:33 |
ameade | nothing i have seen it run against has broken the integration | 20:33 |
thingee | ameade: in the last 200 runs there should be failures being posted, and your CI is claiming 100% passed | 20:33 |
*** e0ne has joined #openstack-cinder | 20:33 | |
*** mtecer has quit IRC | 20:33 | |
thingee | the best part of all of this is it's just the CI with the separate account for the driver that needed to be accepted in liberty according to stats. | 20:35 |
thingee | the other netapp ci's are posting failures | 20:36 |
ameade | it's all the FC drivers | 20:36 |
ameade | they have a seperate account because they are a separate CI system | 20:36 |
ameade | i'm an open book man, ask me anything you want | 20:36 |
ameade | just updated it to post it's failure | 20:36 |
ameade | i'm not trying to be dissenting here | 20:37 |
ameade | it's a little offensive to assume something shady | 20:37 |
hemna | not reporting failures is less than open. | 20:39 |
*** akerr has joined #openstack-cinder | 20:39 | |
hemna | https://review.openstack.org/#/c/186588/ | 20:40 |
hemna | we report failures | 20:40 |
hemna | and those failures on the hp CI are failures of our own doing here. | 20:40 |
hemna | and yet, we are analyzing them here. | 20:40 |
hemna | but still reporting them. | 20:40 |
ameade | hemna: I originally have this system let me review failures before they post so that incase the fabric or something gets out of whack i dont spam a bunch of patches with false negatives | 20:40 |
hemna | (internal network problems) | 20:40 |
*** e0ne has quit IRC | 20:41 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Sync 'report' from oslo-incubator https://review.openstack.org/192883 | 20:41 |
thingee | ameade: I don't expect you to keep up with discussions, but we had a previous vendor take this approach and it was clear that this defeats the purpose of the CI. | 20:41 |
hemna | I guess we are 'spamming' then | 20:41 |
ameade | doesnt that desensitize submitters? | 20:41 |
thingee | ameade: the point is you have pointed *zero*, again *zero* failures. You're system does not work. | 20:41 |
thingee | there are correct times to report failures | 20:42 |
thingee | your* | 20:42 |
openstackgerrit | Eric Harney proposed openstack/cinder: ScaleIO: Fix broken format string https://review.openstack.org/192884 | 20:44 |
openstackgerrit | Victor Stinner proposed openstack/cinder: tox: add a basic py34 venv running a single test https://review.openstack.org/192118 | 20:46 |
*** ronis has quit IRC | 20:46 | |
*** lan has quit IRC | 20:47 | |
hemna | speaking of reporting failures | 20:50 |
jgriffith | hemna: ping | 20:50 |
hemna | even Datera reports failures | 20:50 |
hemna | http://stkci.daterainc.com/refs-changes-69-188869-9/console.log.txt | 20:50 |
hemna | jgriffith, hey | 20:50 |
jgriffith | hemna: thingee Yo.. just reading back the meeting logs | 20:50 |
jgriffith | hemna: thingee so there was some misunderstanding of my comment I think; | 20:50 |
ameade | i've already turned it on and said why i had it that way | 20:50 |
ameade | i can see how that could look shady | 20:50 |
jgriffith | hemna: thingee what I meant was set "multi-attach=True" in the base so it's inherited rathr than chase it through every driver | 20:51 |
jgriffith | hemna: thingee but I'm good either way | 20:51 |
ameade | not sure i agree with the policy of posting false failures though | 20:51 |
hemna | posting of failures in general | 20:51 |
hemna | you don't know they are a false failure until it's analyzed | 20:51 |
hemna | post results first | 20:51 |
asselin | ameade, if your ci posts too many false failures, you need to turn it off altogether | 20:51 |
hemna | analyze next. | 20:51 |
hemna | that's what we do | 20:51 |
*** lan has joined #openstack-cinder | 20:51 | |
*** cknight has joined #openstack-cinder | 20:52 | |
eharney | i would like if people could stop posting false "Merge Conflict" failures... those are just bothersome | 20:52 |
jgriffith | eharney: +1 | 20:52 |
asselin | ameade, otherwise that's something that needs to be fixed through maintenance and robustness | 20:52 |
jgriffith | eharney: and they're not supposed to be reporting any of that anyway :) | 20:52 |
jgriffith | eharney: but that may be just my "interpretation" | 20:52 |
ameade | asselin: I think the problem here is it's too robust | 20:52 |
asselin | lol | 20:53 |
ameade | hemna: yeah that makes sense, i was just doing it in a different order | 20:53 |
eharney | jgriffith: well, merge conflict = i did something messy in my CI (extra patches etc) and broke it | 20:53 |
hemna | ameade, then usually we issue a recheck after we fix the failure on our end. | 20:53 |
*** jskinner has quit IRC | 20:54 | |
jgriffith | eharney: I know what it means, I was just saying third party shouldn't be saying anything about it to begin with. | 20:55 |
akerr | eharney: I'm not so sure they're always false. We wait until after jenkins votes to even start running so in the 40-50 minutes jenkins takes to run its very possible for the code base to change | 20:55 |
jgriffith | eharney: but I guess maybe I'm wrong there | 20:55 |
jgriffith | eharney: and that's what I meant by it's "my interpretatoin" | 20:55 |
jgriffith | eharney: but obviously I must be wrong, so forget I said anything :) | 20:55 |
eharney | akerr: i don't know how you can get a merge conflict... it merged into gerrit... if it can't merge into your CI then something is happening wrong | 20:56 |
akerr | but if the merges happen at different times then the state of the repository is different | 20:56 |
jgriffith | akerr: why are you merging anything? | 20:56 |
akerr | jgriffith: because zuul uses merger | 20:57 |
eharney | it shouldn't be, you should be testing it on top of the same parent it has in gerrit | 20:57 |
jgriffith | for check? | 20:57 |
eharney | i dunno how this makes sense otherwise | 20:57 |
eharney | can't have everyone's CI testing different code for the same patchset | 20:57 |
*** nkrinner has quit IRC | 20:58 | |
*** nikeshm_ has joined #openstack-cinder | 20:58 | |
*** delattec has joined #openstack-cinder | 20:59 | |
*** delatte has joined #openstack-cinder | 20:59 | |
eharney | even scarier what that means for rechecks | 20:59 |
*** gouthamr has quit IRC | 20:59 | |
jgriffith | akerr: I'm still trying to figure out why you care? | 20:59 |
jgriffith | akerr: the check is "supposed" to be: download the patch in gerrit and run it | 20:59 |
jgriffith | akerr: done | 20:59 |
jgriffith | akerr: what's in gerrit is what you get | 20:59 |
*** nikeshm has quit IRC | 21:00 | |
jgriffith | akerr: no merging, no funny business merging change sets etc | 21:00 |
*** dulek_home has joined #openstack-cinder | 21:00 | |
jgriffith | akerr: that's why I'm confused (sorry) | 21:00 |
*** cdelatte has quit IRC | 21:00 | |
jgriffith | akerr: and you're *wrong* WRT the comment about "different states of the repo" | 21:00 |
jgriffith | that has nothing to do with gate checks | 21:00 |
*** nikeshm has joined #openstack-cinder | 21:01 | |
*** dulek_home has quit IRC | 21:01 | |
jgriffith | that's a part of the verify/merge process in the gate, and the gate is the ONLY one that has the ability or intelligence to do that | 21:01 |
akerr | jgriffith: we built our system from the tools infra had out about 1.5 years ago (before all the work was done to try and make it easier to consume). So we are using zuul and the gerrit triggers. Internally zuul then uses merger to put the patch on the latest code in the repo for whichever branch its on. I suppose we could go do surgery to zuul to change that | 21:01 |
jgriffith | akerr: well.. you're using it wrong :) | 21:01 |
*** dulek has joined #openstack-cinder | 21:02 | |
eharney | yeah... that just doesn't make sense conceptually | 21:02 |
eharney | i wonder if others are doing this | 21:02 |
*** jungleboyj has quit IRC | 21:02 | |
asselin | akerr, I think the issue is that the patch is in the pipeline, but there's another patch that causes a merge conflict that merges. | 21:02 |
jgriffith | akerr: sounds like you implemented verify instead of check maybe? | 21:02 |
asselin | akerr, upstream, they -1 the patch and remove it from the queue. | 21:02 |
akerr | check and verify just have different triggers | 21:02 |
jgriffith | asselin: that's the verify stage, check stage doesn't care about that | 21:02 |
asselin | akerr, I think you leave it in the queue, and it fails when it gets there | 21:03 |
eharney | but this scheme means that even "recheck" doesn't recheck the same code, right? | 21:03 |
*** nikeshm_ has quit IRC | 21:03 | |
jgriffith | asselin: akerr please see: http://status.openstack.org/zuul/ | 21:03 |
jgriffith | asselin: akerr notice check VS gate | 21:03 |
asselin | jgriffith, akerr no I'm talking about the "merger-check" pipeline: http://zuul.openstack.org/ | 21:03 |
asselin | "merge-check" | 21:03 |
jgriffith | asselin: akerr of course currently it's kinda quiet so doesn't illustrate the dependencies and merge actions | 21:03 |
akerr | i think what happens is that a patch merges while jenkins is running. we then update our repo to be latest, when jenkins finishes we see the +1 and grab the patch, attempt to put it on a newer version of the repo that it now conflicts with. Jenkins will have the same issue when it runs next | 21:03 |
jgriffith | asselin: I think you and I are mostly on the same page, I'm saying akerr 's system is doing things it shouldn't be doing ;) | 21:04 |
eharney | akerr: but why are you updating the repo to the latest? | 21:04 |
*** annashen has quit IRC | 21:05 | |
akerr | to stay up-to-date | 21:05 |
jgriffith | akerr: why do you update your repo to be the laest though... that's my point. You shouldn't be doing that | 21:05 |
jgriffith | akerr: you don't WANT to be up to date, you want to run the patch under test | 21:05 |
jgriffith | akerr: so all of your testing over the last however long is basically bogus it sounds like | 21:05 |
akerr | i don't see why this is an issue. If it conflicts in our system it will conflict in upstream too, we just catch it first | 21:05 |
ameade | then how do you know it'll work with your drivers when it does merge? | 21:05 |
jgriffith | akerr: cuz you're doing some crazy internal update/merge scheme | 21:06 |
jgriffith | that isn't even testing the submitted patch | 21:06 |
eharney | it's still valid testing, it just means that there's a lot more inconsistency between CIs | 21:06 |
*** sgotliv_ has quit IRC | 21:06 | |
jgriffith | OMG | 21:06 |
ameade | this sounds like bikeshedding to me | 21:06 |
eharney | seems bad | 21:06 |
jgriffith | ameade: it's most certainly not bikeshedding.. .not in the least | 21:06 |
*** edmondsw has quit IRC | 21:06 | |
jgriffith | ameade: it's one system testing something different than what it says it's testing | 21:06 |
jgriffith | ameade: akerr anyway... whatever. Just quit reporting it :) | 21:07 |
ameade | it all depends on what you expect i suppose, if you assume it's not doing merges then yeah its lying to you | 21:07 |
* jgriffith walks away whistling theme to Andy Griffith | 21:07 | |
akerr | jgriffith: fair enough, i'll update the pipeline right now to not report merge conflicts | 21:07 |
ameade | maybe we should make this clear as a req? | 21:07 |
eharney | it could at least report them as "unstable" instead of "failure" if reporting them | 21:08 |
eharney | but i dunno what the best plan is really | 21:08 |
akerr | ugh, can only modify the merge-failure-message, not the actual reporting of the failure | 21:11 |
asselin | sorry...what's the issue with reporting merge failures? | 21:11 |
akerr | asselin: that's my question :) | 21:11 |
ameade | cosmetic :) | 21:12 |
eharney | asselin: they don't make any sense and basically indicate that the CI system is broken (IMO) | 21:12 |
eharney | but apparently there are differing theories on this that i had no idea about | 21:12 |
ameade | or working? if we dont want folks merging we gotta make that a rule | 21:12 |
ameade | i do think there is value to it we are overlooking | 21:12 |
eharney | i never thought that that was what these CIs were supposed to report on though | 21:12 |
eharney | i mean, it sounds useful... but... very different from what jenkins does and what i thought the scheme was | 21:12 |
*** rushil has joined #openstack-cinder | 21:12 | |
akerr | it's exactly what jenkins does, we built it from jenkins | 21:13 |
ameade | the difference is these CIs dont run in the gate | 21:13 |
ameade | so if you are gonna try with the merge you gotta do it on check | 21:13 |
*** haomaiwang has joined #openstack-cinder | 21:13 | |
asselin | many of us are using zuul which is reporting the merge failure. So it's not something specific anyone is doing | 21:13 |
eharney | asselin: maybe i've missed previous discussion on this (i haven't heard any before) | 21:13 |
*** porrua has joined #openstack-cinder | 21:14 | |
asselin | but I think there are ways to work around it | 21:14 |
akerr | the difference between check and gate is that gate is a dependent pipeline, so it merges several patchsets, in order, when it runs. check only merges the one patch onto the latest repo version | 21:14 |
eharney | it seems weird to have everyone's CI running against different code depending on when they start | 21:14 |
asselin | by e.g. look at what infra does in the merge-check pipeline | 21:14 |
*** haomaiw__ has quit IRC | 21:15 | |
eharney | and when you do a recheck, you may recheck against different code? that doesn't seem useful | 21:15 |
jgriffith | akerr: ding ding ding ding :) | 21:15 |
asselin | eharney, that's the case regardless of merge failures, b/c every project is on master and master is constantly changing | 21:15 |
asselin | akerr, no, check doesn't merge | 21:15 |
eharney | asselin: not for the check queue...? | 21:15 |
asselin | akerr, check does the equivalent of checkout in the gerrit UI | 21:16 |
asselin | eharney, it uses the patch as-is for cinder, and master for everything else | 21:16 |
asselin | master for everything else is different b/w different ci runs | 21:16 |
asselin | but cinder should be the same | 21:16 |
asselin | exactly what that patch set says it should be | 21:17 |
eharney | i didn't know that we were special in that regard... why? | 21:17 |
asselin | eharney, in my example, I'm assuming you're testing a cinder patch | 21:17 |
asselin | eharney, if it were a nova patch, then nova is fixed, everything else is master | 21:17 |
eharney | oh, yeah, i get that part | 21:17 |
*** dulek has quit IRC | 21:18 | |
akerr | pretty sure it does the merge. it uses the ZUUL_REF to do the checkout for cinder, which go through zuul-merger | 21:19 |
eharney | i may just have no idea how anything works | 21:19 |
vilobhmm | ericksonsantos : ack | 21:20 |
openstackgerrit | Thang Pham proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 21:20 |
akerr | if it never did the merge, how would a patch EVER be in merge conflict? | 21:21 |
*** haomaiw__ has joined #openstack-cinder | 21:21 | |
eharney | but that's my original point. i'm getting "merge conflict" failures from CI systems when there isn't a conflict in Jenkins upstream (i think... don't have an example at the moment) | 21:21 |
*** haomaiwang has quit IRC | 21:21 | |
*** Yogi1 has quit IRC | 21:22 | |
asselin | eharney, which patch? | 21:23 |
eharney | asselin: well... i was just saying i don't have an example at the moment, but i'm fairly sure i've seen a handful of them | 21:24 |
*** openstackgerrit has quit IRC | 21:24 | |
akerr | eharney: I think that's where my point about the fact that we're waiting until after jenkins votes is coming into play. If the base repo changes while jenkins is running then subsequent CI system runs could hit the merge conflict while jenkins was still able to vote. I'll bet if you try a recheck after you get a merge conflict from a CI (that's not messed up, i'll concede it's possible for the system to also be in error) you'll probably hit a merge | 21:24 |
akerr | conflict in jenkins too | 21:24 |
ameade | heck if anything it's helpful in that case lol | 21:24 |
eharney | yeah, i understand how it can happen now | 21:24 |
Swanson | Is there any reason I want to inherit from one of the san. drivers rather than just driver.iscsiyada and driver.fibrechannelyada? | 21:24 |
*** openstackgerrit has joined #openstack-cinder | 21:24 | |
*** dulek_home has joined #openstack-cinder | 21:25 | |
*** kjnelson has joined #openstack-cinder | 21:25 | |
eharney | this was not included in the "Important CI Details for the Cinder Core Reviewer" Handbook | 21:25 |
*** thangp has quit IRC | 21:25 | |
*** dulek_home has quit IRC | 21:25 | |
akerr | heh, it's taken me a year to finally wrap my head around how this system really works | 21:25 |
eharney | well i thought i had done that, but, apparently not | 21:26 |
*** dulek has joined #openstack-cinder | 21:26 | |
eharney | at any rate, i'll consider that less totally wrong now based on hearing the explanation | 21:28 |
*** erlon has quit IRC | 21:30 | |
*** jungleboyj has joined #openstack-cinder | 21:34 | |
*** Rockyg has quit IRC | 21:38 | |
*** annashen has joined #openstack-cinder | 21:42 | |
*** porrua has quit IRC | 21:45 | |
earlephilhower | asselin, hemna: Should 3rd party CIs fire jobs on simple "recheck" (as opposed to "recheck <vendor-specific-tag>"? The os-ext-testing-data default regex doesn't fire on naked "recheck"s, just "recheck no bug" or "recheck bug ###". | 21:49 |
asselin | earlephilhower, yeah that was the old way | 21:49 |
asselin | earlephilhower, we currently fire off of "recheck" | 21:50 |
asselin | earlephilhower, you can choose your own regex, I'm not familiar with an specifici requirements other than the -infra team perfers 3rd party ci fire off of "recheck .*" | 21:50 |
*** adurbin__ has quit IRC | 21:51 | |
*** rushil has quit IRC | 21:52 | |
earlephilhower | asselin, Thanks. Makes the regex less painful to drop the add'l conditions. | 21:52 |
*** ianbrown has joined #openstack-cinder | 21:53 | |
*** xyang has quit IRC | 21:57 | |
*** mriedem has quit IRC | 21:58 | |
*** kjnelson has quit IRC | 22:03 | |
*** Longgeek has joined #openstack-cinder | 22:03 | |
akerr | asselin: just a suggestion for other CI systems, we take both "recheck netapp" and "run netapp" as valid triggers, since recheck netapp will also trigger jenkins and run will not. Lets us recheck just our own system and not bother upstream's system | 22:03 |
*** bswartz has joined #openstack-cinder | 22:05 | |
*** jungleboyj has quit IRC | 22:09 | |
tbarron | akerr: +1 | 22:10 |
*** delatte has quit IRC | 22:10 | |
*** delattec has quit IRC | 22:10 | |
*** leeantho has quit IRC | 22:13 | |
*** dannywilson has quit IRC | 22:14 | |
*** rmesta has quit IRC | 22:16 | |
*** rmesta has joined #openstack-cinder | 22:16 | |
openstackgerrit | xing-yang proposed openstack/cinder: Add multiple pools support to VMAX driver https://review.openstack.org/189990 | 22:17 |
*** delattec has joined #openstack-cinder | 22:18 | |
*** delatte has joined #openstack-cinder | 22:18 | |
openstackgerrit | Doug Hellmann proposed openstack/cinder: Update version for Liberty https://review.openstack.org/192400 | 22:19 |
*** julim has quit IRC | 22:19 | |
*** dims has quit IRC | 22:26 | |
*** rmesta has quit IRC | 22:29 | |
*** rmesta has joined #openstack-cinder | 22:29 | |
*** cknight has quit IRC | 22:30 | |
*** jecarey has quit IRC | 22:30 | |
*** Longgeek has quit IRC | 22:36 | |
*** lcurtis has quit IRC | 22:39 | |
asselin | akerr, yeah...we might do something like that | 22:42 |
*** alau2 has quit IRC | 22:43 | |
asselin | akerr, was just talking to hemna about it. if we do that, it would be good to standardize it to e.g. check <CI Reviewer Name> | 22:43 |
*** krtaylor has quit IRC | 22:44 | |
*** jasondotstar has joined #openstack-cinder | 22:45 | |
*** IanGovett has quit IRC | 22:45 | |
*** ociuhandu has quit IRC | 22:49 | |
*** IanGovett has joined #openstack-cinder | 22:56 | |
*** ganso_ has quit IRC | 22:58 | |
jgriffith | akerr: IIRC the standard is "recheck-<ciName>" | 22:59 |
jgriffith | akerr: the '-' makes it so the gate won't pick it up | 23:00 |
jgriffith | akerr: it also lets *anybody* trigger a run on any specific system without having to "know* anything about it | 23:00 |
asselin | jgriffith, thanks good to know | 23:02 |
*** IanGovett has quit IRC | 23:06 | |
*** crose has quit IRC | 23:09 | |
*** Adriano__ has quit IRC | 23:11 | |
*** dannywilson has joined #openstack-cinder | 23:16 | |
hemna | problem solved :) | 23:21 |
*** dims has joined #openstack-cinder | 23:24 | |
* tbarron likes having a standard way since lots of CIs don't announce their way to recheck | 23:26 | |
tbarron | jgriffith: I've been thinking a bit about your idea, expressed during the scaling backup services session in vancouver | 23:27 |
tbarron | of using service VMs (dunno if that was your phrase) for running backup services | 23:27 |
tbarron | I like the idea | 23:27 |
tbarron | or even potentially kolla containers | 23:28 |
tbarron | any precedent for this with cinder services? | 23:28 |
*** dims has quit IRC | 23:28 | |
*** dims has joined #openstack-cinder | 23:28 | |
tbarron | or magnum containers, maybe I meant, gotta learn about this stuff. | 23:29 |
*** hodos has quit IRC | 23:29 | |
tbarron | don't tie down physical infra, scale out backup servers on demand | 23:29 |
*** dannywilson has quit IRC | 23:31 | |
*** diemt has quit IRC | 23:31 | |
jgriffith | tbarron: nope, it's brand new concept for cinder | 23:31 |
*** diemt has joined #openstack-cinder | 23:31 | |
*** krtaylor has joined #openstack-cinder | 23:32 | |
*** dims has quit IRC | 23:33 | |
tbarron | jgriffith: that's what I figured | 23:35 |
tbarron | jgriffith: well, we'll start as planned, enabling backup service to run on multiple "nodes", and on separate nodes than the volume services | 23:36 |
*** rmesta has quit IRC | 23:37 | |
tbarron | jgriffith: then we can look at service vms, or container/minions | 23:37 |
tbarron | once things are decoupled | 23:37 |
jgriffith | tbarron: You're call... I don't know how the multiple physical nodes idea would fly | 23:37 |
jgriffith | tbarron: but it's a good way to step through things I suppose | 23:37 |
tbarron | if you think of other cinder services that might fit that model, lemee know | 23:37 |
tbarron | jgriffith: dedicating multiple physical nodes would be bad, but enabling it proves the decoupling | 23:38 |
*** chlong has joined #openstack-cinder | 23:38 | |
tbarron | jgriffith: make sense? | 23:38 |
jgriffith | tbarron: yeah, sure | 23:38 |
tbarron | jgriffith: i'm just setting up multinode devstack for the first time :-) to see what I can figure out on this front | 23:39 |
tbarron | jgriffith: haven't forgotten about helping with the resource-tag logging either, just was away for a few days | 23:39 |
tbarron | kk - i'm AFK for a while, ty for listening | 23:40 |
jgriffith | tbarron: :) NO worries at all | 23:40 |
jgriffith | tbarron: and starting w/ multi-node devstack isn't a bad idea at all | 23:41 |
*** adurbin_ has quit IRC | 23:42 | |
*** mriedem has joined #openstack-cinder | 23:42 | |
*** diogogmt has quit IRC | 23:45 | |
*** mriedem1 has joined #openstack-cinder | 23:45 | |
*** jskinner has joined #openstack-cinder | 23:46 | |
*** mriedem has quit IRC | 23:47 | |
*** earlephilhower has quit IRC | 23:54 | |
*** laughterwym has joined #openstack-cinder | 23:55 | |
*** garthb_ has quit IRC | 23:57 | |
*** garthb has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!