| tbarron | patrickeast: thanks! at least we know we're not alone. | 00:01 |
|---|---|---|
| *** p0rtal has quit IRC | 00:02 | |
| patrickeast | tbarron: my guess is that something is supposed to be mocked out that isn't... but from what i was seeing in the test it should not be actually running real code when it does the 'self._delete_temp_backing(backing)' | 00:02 |
| patrickeast | couldn't really trace through it or test a fix easily since i can't repro it though :( | 00:03 |
| *** p0rtal has joined #openstack-cinder | 00:04 | |
| mtanino_ | tbarron: I see that error several times... | 00:05 |
| *** zhangjn has quit IRC | 00:05 | |
| tbarron | patrickeast: mtanino_: AttributeError: '_SentinelObject' object has no attribute 'readlines' ... | 00:06 |
| mtanino_ | tbarron: yup :( | 00:06 |
| *** r-daneel has joined #openstack-cinder | 00:09 | |
| tbarron | most recent change to that test seems to be: 212aff32 cinder/tests/unit/test_vmware_vmdk.py (Sergey Vilgelm 2015-07-08 15:18:13 +0300 1655) @mock.patch.object(VMDK_DRIVER, '_get_disk_type') | 00:11 |
| tbarron | ^^^ which is a switch to oslo_utils.fileutils from fileutils.file_open() | 00:13 |
| *** mtanino_ has quit IRC | 00:13 | |
| *** tsekiyama has quit IRC | 00:14 | |
| *** edtubill has joined #openstack-cinder | 00:15 | |
| *** bnemec has quit IRC | 00:18 | |
| *** lixiaoy1 has joined #openstack-cinder | 00:19 | |
| jgriffith | tbarron: I have not seen that myself | 00:22 |
| tbarron | jgriffith: well, I hope you remain blessed in that regard :-) | 00:22 |
| jgriffith | haha | 00:22 |
| patrickeast | tbarron: so the part that I don't really get is that it seems to be coming from this code block https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/vmware/vmdk.py#L1677-L1682 | 00:25 |
| patrickeast | its the exit from the exec utils with statement | 00:25 |
| patrickeast | the test doesn't seem to be a negative one though, so i'm not sure why it is even in there in the first place | 00:26 |
| patrickeast | some exception was raised... but it blows up trying to handle it | 00:26 |
| *** esker has quit IRC | 00:27 | |
| *** smoriya has joined #openstack-cinder | 00:27 | |
| tbarron | patrickeast: yeah, that's helpful. Maybe _delete_temp_backing would have had this problem all along (like the readlines failure when printing out exception from a mocked out file object). | 00:30 |
| tbarron | patrickeast: so the question, as you say, is why we now hit the Exception that leads to the _delete_temp_backing() call. | 00:30 |
| patrickeast | tbarron: heh yea, and why only sometimes | 00:31 |
| tbarron | patrickeast: use of tmp files in tests seems more functional than unit to me :-) | 00:31 |
| patrickeast | tbarron: definitely | 00:31 |
| *** xyang1 has quit IRC | 00:31 | |
| tbarron | patrickeast: and an exception will be raised if ``timeout`` is exceeded when running image_transfer.download_stream_optimized_data() | 00:34 |
| tbarron | patrickeast: so there is likely the indeterminacy | 00:35 |
| patrickeast | tbarron: yea maybe, looks like that image_transfer method is supposed to be mocked out though, it should just be returning...I think | 00:36 |
| patrickeast | I guess if it isn't mocked out that could very well be the problem | 00:36 |
| *** edtubill has quit IRC | 00:38 | |
| tbarron | patrickeast: oh, but I think you are right: @mock.patch.object(image_transfer, 'download_stream_optimized_data') | 00:39 |
| *** asd112z has joined #openstack-cinder | 00:41 | |
| *** salv-orlando has quit IRC | 00:43 | |
| *** martyturner1 has joined #openstack-cinder | 00:44 | |
| *** rick_chen has joined #openstack-cinder | 00:45 | |
| *** martyturner has quit IRC | 00:46 | |
| rick_chen | thingee: HI Mike, Do you receive my email about the Prophetstor CI account? | 00:47 |
| *** bnemec has joined #openstack-cinder | 00:47 | |
| rick_chen | thingee: I completed all Ramy's comment. | 00:48 |
| *** zhangjn has joined #openstack-cinder | 00:49 | |
| *** martyturner1 has quit IRC | 00:50 | |
| *** zhangjn has quit IRC | 00:51 | |
| jgriffith | rick_chen: thingee is on vacation for the next week and 1/2 | 00:52 |
| *** zhangjn has joined #openstack-cinder | 00:53 | |
| *** zhangjn has quit IRC | 00:54 | |
| *** sghanekar has joined #openstack-cinder | 00:55 | |
| *** zhangjn has joined #openstack-cinder | 00:55 | |
| *** andreykurilin__ has quit IRC | 00:55 | |
| anteaya | rick_chen: ^^ | 01:00 |
| *** skylerberg has quit IRC | 01:02 | |
| tbarron | patrickeast: well, it looks like everything that could be throwing the exception is mocked out (kinda like you said at the outset). | 01:03 |
| tbarron | patrickeast: I haven't used this mock.sentinel stuff myself though, so may be missing something. | 01:04 |
| *** _cjones_ has quit IRC | 01:05 | |
| *** zhenguo has joined #openstack-cinder | 01:05 | |
| *** garthb_ has quit IRC | 01:07 | |
| *** leeantho has quit IRC | 01:11 | |
| *** rick_chen has quit IRC | 01:12 | |
| *** rick_chen has joined #openstack-cinder | 01:15 | |
| rick_chen | jgriffith: OK, I got. Does my Thrid-party CI account need Mike permission to re-enable until he returns? | 01:17 |
| *** bswartz has joined #openstack-cinder | 01:20 | |
| *** akerr has joined #openstack-cinder | 01:30 | |
| *** dannywilson has quit IRC | 01:31 | |
| *** akerr_ has joined #openstack-cinder | 01:31 | |
| *** dannywilson has joined #openstack-cinder | 01:32 | |
| *** akerr has quit IRC | 01:35 | |
| *** r-daneel has quit IRC | 01:35 | |
| *** gouthamr has quit IRC | 01:36 | |
| *** mudassirlatif has quit IRC | 01:36 | |
| *** dannywilson has quit IRC | 01:36 | |
| *** dannywil_ has joined #openstack-cinder | 01:36 | |
| *** gouthamr has joined #openstack-cinder | 01:36 | |
| openstackgerrit | wanghao proposed openstack/cinder: Add pagination to backups https://review.openstack.org/204493 | 01:40 |
| *** dannywil_ has quit IRC | 01:41 | |
| *** bnemec has quit IRC | 01:41 | |
| *** Lee1092 has joined #openstack-cinder | 01:43 | |
| *** dims has joined #openstack-cinder | 01:43 | |
| *** jdandrea has quit IRC | 01:43 | |
| *** sghanekar has quit IRC | 01:48 | |
| *** p0rtal has quit IRC | 01:48 | |
| *** p0rtal has joined #openstack-cinder | 01:49 | |
| *** p0rtal has quit IRC | 01:54 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 01:59 |
| *** ndipanov has quit IRC | 02:00 | |
| *** rick_chen has quit IRC | 02:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 02:03 | |
| *** jlk has left #openstack-cinder | 02:04 | |
| *** haomaiwa_ has quit IRC | 02:09 | |
| *** haomaiwang has joined #openstack-cinder | 02:10 | |
| *** chenying has joined #openstack-cinder | 02:10 | |
| *** asselin has quit IRC | 02:15 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/cinder: Use version convert methods from oslo.utils https://review.openstack.org/214516 | 02:16 |
| *** Apoorva has quit IRC | 02:21 | |
| *** akerr has joined #openstack-cinder | 02:23 | |
| *** akerr__ has joined #openstack-cinder | 02:24 | |
| *** akerr_ has quit IRC | 02:26 | |
| *** akerr has quit IRC | 02:27 | |
| *** skylerberg has joined #openstack-cinder | 02:29 | |
| openstackgerrit | Michael Price proposed openstack/cinder: NetApp E-Series over-subscription support https://review.openstack.org/215801 | 02:30 |
| *** gouthamr_ has joined #openstack-cinder | 02:33 | |
| *** gouthamr has quit IRC | 02:36 | |
| *** gouthamr_ has quit IRC | 02:37 | |
| *** baojg has joined #openstack-cinder | 02:39 | |
| openstackgerrit | Huang Zhiteng proposed openstack/os-brick: iSCSI Connector: force disconnect iscsi session https://review.openstack.org/217032 | 02:42 |
| *** mriedem has quit IRC | 02:43 | |
| *** salv-orlando has joined #openstack-cinder | 02:44 | |
| *** salv-orlando has quit IRC | 02:48 | |
| *** akerr__ has quit IRC | 02:50 | |
| *** asd112z has quit IRC | 02:50 | |
| *** jlk has joined #openstack-cinder | 02:50 | |
| openstackgerrit | wanghao proposed openstack/cinder: Add UniqueConstraint for quota usages table https://review.openstack.org/217465 | 02:51 |
| *** hakimo_ has joined #openstack-cinder | 02:52 | |
| *** takedakn has joined #openstack-cinder | 02:53 | |
| *** hakimo has quit IRC | 02:55 | |
| *** dims has quit IRC | 02:56 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-cinder | 03:01 | |
| *** EinstCrazy has joined #openstack-cinder | 03:32 | |
| *** hw__chenying has joined #openstack-cinder | 03:35 | |
| *** chenying has quit IRC | 03:38 | |
| *** jgriffith has quit IRC | 03:43 | |
| *** jgriffith has joined #openstack-cinder | 03:44 | |
| *** jgriffith is now known as Guest54162 | 03:45 | |
| *** takedakn has quit IRC | 03:45 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 04:01 | |
| *** jamielennox is now known as jamielennox|away | 04:04 | |
| *** jamielennox|away is now known as jamielennox | 04:05 | |
| *** jlk has left #openstack-cinder | 04:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/215440 | 04:13 |
| *** hw__chenying has quit IRC | 04:31 | |
| *** rushil has joined #openstack-cinder | 04:32 | |
| *** BharatK has quit IRC | 04:33 | |
| *** rushil_ has joined #openstack-cinder | 04:34 | |
| *** asselin has joined #openstack-cinder | 04:34 | |
| *** rushil has quit IRC | 04:37 | |
| *** links has joined #openstack-cinder | 04:38 | |
| *** shyama has joined #openstack-cinder | 04:45 | |
| *** BharatK has joined #openstack-cinder | 04:45 | |
| *** BharatK_ has joined #openstack-cinder | 04:46 | |
| *** changbl has quit IRC | 04:46 | |
| *** dflorea has joined #openstack-cinder | 04:46 | |
| *** BharatK has quit IRC | 04:50 | |
| *** rushil_ has quit IRC | 04:50 | |
| *** p0rtal has joined #openstack-cinder | 04:51 | |
| *** davechen has joined #openstack-cinder | 04:53 | |
| *** haomaiwa_ has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-cinder | 05:01 | |
| *** salv-orlando has joined #openstack-cinder | 05:02 | |
| *** nkrinner has joined #openstack-cinder | 05:02 | |
| *** skylerberg has quit IRC | 05:05 | |
| *** salv-orlando has quit IRC | 05:07 | |
| *** vincent_hou has joined #openstack-cinder | 05:10 | |
| *** openstackgerrit has quit IRC | 05:16 | |
| *** openstackgerrit has joined #openstack-cinder | 05:17 | |
| *** ankit_ag has joined #openstack-cinder | 05:23 | |
| *** zerda has joined #openstack-cinder | 05:28 | |
| *** albertom has quit IRC | 05:29 | |
| openstackgerrit | Peter Wang proposed openstack/cinder: Update name_id and provider_location for migration https://review.openstack.org/217522 | 05:30 |
| *** albertom has joined #openstack-cinder | 05:30 | |
| openstackgerrit | Peter Wang proposed openstack/cinder: Update name_id and provider_location for migration https://review.openstack.org/217522 | 05:33 |
| *** dflorea has quit IRC | 05:36 | |
| *** dflorea has joined #openstack-cinder | 05:38 | |
| *** smoriya has quit IRC | 05:38 | |
| *** vincent_hou has quit IRC | 05:38 | |
| *** dflorea has quit IRC | 05:42 | |
| *** baojg has quit IRC | 05:45 | |
| *** rushiagr_away is now known as rushiagr | 05:45 | |
| *** dims has joined #openstack-cinder | 05:46 | |
| *** agarciam has joined #openstack-cinder | 05:48 | |
| *** p0rtal has quit IRC | 05:48 | |
| *** p0rtal has joined #openstack-cinder | 05:49 | |
| *** EinstCrazy has quit IRC | 05:50 | |
| *** baojg has joined #openstack-cinder | 05:52 | |
| *** dims has quit IRC | 05:52 | |
| *** baojg has quit IRC | 05:52 | |
| *** EinstCrazy has joined #openstack-cinder | 05:53 | |
| *** hw__chenying has joined #openstack-cinder | 06:00 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** 5EXABZ8QP has joined #openstack-cinder | 06:01 | |
| openstackgerrit | Rajesh Tailor proposed openstack/python-cinderclient: Fix help message for reset-state commands https://review.openstack.org/217530 | 06:05 |
| *** afazekas_ has joined #openstack-cinder | 06:06 | |
| *** p0rtal has quit IRC | 06:10 | |
| *** sghanekar has joined #openstack-cinder | 06:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex https://review.openstack.org/214468 | 06:19 |
| *** baojg has joined #openstack-cinder | 06:22 | |
| *** deepakcs has joined #openstack-cinder | 06:22 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Data transformation betweeen encrypted volumes and images https://review.openstack.org/216567 | 06:25 |
| *** sghanekar has quit IRC | 06:27 | |
| nikeshm | LisaLi: hi | 06:29 |
| nikeshm | LisaLi: i missed reviews on https://bugs.launchpad.net/openstack-manuals/+bug/1436031 | 06:30 |
| openstack | Launchpad bug 1436031 in openstack-manuals "Migrate volumes in OpenStack Cloud Administrator Guide - current" [Medium,Fix released] - Assigned to Lisa Li (lisali) | 06:30 |
| nikeshm | nikeshm: i commented on that, if you have time please look once | 06:32 |
| nikeshm | LisaLi: i commented on that, if you have time please look once | 06:32 |
| openstackgerrit | Huang Zhiteng proposed openstack/os-brick: iSCSI Connector: force disconnect iscsi session https://review.openstack.org/217032 | 06:34 |
| *** albertom has quit IRC | 06:34 | |
| *** DTadrzak has quit IRC | 06:35 | |
| *** pots has quit IRC | 06:35 | |
| *** pots has joined #openstack-cinder | 06:36 | |
| *** alexschm has joined #openstack-cinder | 06:38 | |
| *** albertom has joined #openstack-cinder | 06:39 | |
| lixiaoy1 | nikeshm: ok, let me have a look | 06:40 |
| *** salv-orlando has joined #openstack-cinder | 06:47 | |
| *** vlaza has joined #openstack-cinder | 06:48 | |
| *** DTadrzak has joined #openstack-cinder | 06:49 | |
| *** martyturner has joined #openstack-cinder | 06:50 | |
| *** salv-orlando has quit IRC | 06:52 | |
| *** rushiagr is now known as rushiagr_away | 06:53 | |
| *** kaisers has quit IRC | 06:54 | |
| *** martyturner has quit IRC | 06:55 | |
| nikeshm | lixiaoy1: thanks | 06:56 |
| *** anshul has joined #openstack-cinder | 06:57 | |
| *** markus_z has joined #openstack-cinder | 07:00 | |
| *** 5EXABZ8QP has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-cinder | 07:02 | |
| *** theanalyst has quit IRC | 07:03 | |
| *** theanalyst has joined #openstack-cinder | 07:04 | |
| *** salv-orlando has joined #openstack-cinder | 07:06 | |
| *** yrabl has joined #openstack-cinder | 07:07 | |
| *** yrabl has quit IRC | 07:07 | |
| *** markus_z has quit IRC | 07:07 | |
| *** stefan_amann has joined #openstack-cinder | 07:08 | |
| *** ronis has joined #openstack-cinder | 07:08 | |
| *** yrabl has joined #openstack-cinder | 07:09 | |
| *** yrabl_ has joined #openstack-cinder | 07:09 | |
| *** yrabl_ has quit IRC | 07:09 | |
| *** ronis_ has joined #openstack-cinder | 07:09 | |
| *** ronis has quit IRC | 07:13 | |
| *** tobasco_ is now known as tobasco | 07:14 | |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: Sheepdog: Improve snapshot and clone operation https://review.openstack.org/198952 | 07:17 |
| *** e0ne has joined #openstack-cinder | 07:18 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Copy encryptors from Nova to Cinder https://review.openstack.org/217557 | 07:18 |
| nikeshm | lixiaoy1 : hi, did you get chance to look on that? | 07:20 |
| openstackgerrit | LisaLi proposed openstack/cinder: Data transfer between encrypted volumes and images https://review.openstack.org/216567 | 07:28 |
| lixiaoy1 | nikeshm: I am looking it now. I just finish downloading code | 07:29 |
| geguileo | e0ne: Backup metadata fix has +1 from Jenkins ;-) | 07:29 |
| nikeshm | thanks | 07:29 |
| lixiaoy1 | nikeshm: yes, I noticed the problem | 07:31 |
| lixiaoy1 | nikeshm: I will fix it. One question: now the files are changed to *.rst, they are xml fomer | 07:32 |
| nikeshm | lixiaoy1 : sorry, as of now, i am not familiar with this | 07:33 |
| nikeshm | lixiaoy1 : might be some one in openstack-manauls can help | 07:34 |
| lixiaoy1 | nikeshm: no problem. I will look into it. Anyway thank you for finding the problem. | 07:35 |
| lixiaoy1 | geguileo: Congratulations to be cinder core. although late | 07:35 |
| geguileo | lixiaoy1: Thanks :-) | 07:35 |
| *** dims has joined #openstack-cinder | 07:35 | |
| e0ne | geguileo: great! i'll take a look on it a bit later | 07:37 |
| geguileo | e0ne: No hurry, since it cannot merge until Tempest test merges | 07:37 |
| geguileo | e0ne: I mean the patch that temporary disables the test | 07:38 |
| *** DTadrzak has quit IRC | 07:38 | |
| *** DTadrzak has joined #openstack-cinder | 07:39 | |
| *** dims has quit IRC | 07:40 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Data transfer between encrypted volumes and images https://review.openstack.org/216567 | 07:43 |
| *** pots has quit IRC | 07:52 | |
| *** p0rtal has joined #openstack-cinder | 07:53 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Data transfer between encrypted volumes and images https://review.openstack.org/216567 | 07:55 |
| *** IanGovett has joined #openstack-cinder | 07:56 | |
| *** sgotliv has joined #openstack-cinder | 07:56 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-cinder | 08:01 | |
| *** e0ne has quit IRC | 08:01 | |
| *** lpetrut has joined #openstack-cinder | 08:02 | |
| *** lpetrut1 has joined #openstack-cinder | 08:02 | |
| *** baojg has quit IRC | 08:02 | |
| *** lpetrut has left #openstack-cinder | 08:03 | |
| *** lpetrut1 has quit IRC | 08:03 | |
| *** lpetrut1 has joined #openstack-cinder | 08:03 | |
| *** takedakn has joined #openstack-cinder | 08:08 | |
| *** boris-42 has quit IRC | 08:10 | |
| *** kaisers has joined #openstack-cinder | 08:11 | |
| *** kaisers has quit IRC | 08:12 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 08:13 |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: Cleanup for cinder tests with CGSnapshot https://review.openstack.org/207866 | 08:13 |
| *** jordanP has joined #openstack-cinder | 08:14 | |
| *** pots has joined #openstack-cinder | 08:14 | |
| *** kaisers has joined #openstack-cinder | 08:14 | |
| *** jistr has joined #openstack-cinder | 08:15 | |
| *** baojg has joined #openstack-cinder | 08:16 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: Cleanup for SnapshotObject https://review.openstack.org/198341 | 08:20 |
| *** JoeStack has joined #openstack-cinder | 08:27 | |
| *** bluex-pl has joined #openstack-cinder | 08:28 | |
| *** ndipanov has joined #openstack-cinder | 08:30 | |
| dulek | geguileo: Hi. Wanted to ask your opinion. | 08:35 |
| geguileo | dulek: 5 mins, on a call | 08:35 |
| *** yuriy_n17 has joined #openstack-cinder | 08:41 | |
| geguileo | dulek: Hi | 08:41 |
| geguileo | dulek: I'm available now | 08:41 |
| dulek | geguileo: I'm aware of the freeze that was on Sunday, not all of versioned objects compatibility mode patches were ready, so we're unable to merge them. | 08:41 |
| dulek | geguileo: I wonder about the objects patches - CGSnapshots, Services, Volumes. | 08:41 |
| dulek | geguileo: If we would be able to merge them in L and compatibility mode in M, then we'll get no-downtime upgrades from L to M. | 08:41 |
| dulek | geguileo: All of these patches were ready before the deadline, so I feel like freeze may not apply to them. | 08:41 |
| dulek | geguileo: Do you think this is worth pursuing? | 08:42 |
| dulek | geguileo: (I was on vacations last week, so I may be missing something.) | 08:42 |
| geguileo | dulek: If I'm not mistaken if the BP was approved and the patches were passing jenkins they probably are not affected by the merge | 08:42 |
| geguileo | s/merge/freeze | 08:42 |
| dulek | geguileo: Actually the last patch of *compatibility mode* weren't. | 08:43 |
| geguileo | dulek: Although I'm not so sure about the rolling migration (no downtime from L to M) | 08:43 |
| dulek | geguileo: Objects were ready long before. | 08:43 |
| dulek | geguileo: Why? | 08:43 |
| geguileo | dulek: Well, has anybody actually tested that? | 08:44 |
| dulek | geguileo: Ah, right. | 08:44 |
| geguileo | dulek: Have we moved all Volume operations to use Volume Versioned Objects? | 08:44 |
| geguileo | dulek: Has Volume Versioned Object been updated? | 08:44 |
| dulek | geguileo: Let me check again on the thangp's patches. | 08:45 |
| geguileo | dulek: Because as far as I remember, Volume Versioned Object is out of sync with Volume ORM object | 08:45 |
| openstackgerrit | Huang Zhiteng proposed openstack/os-brick: iSCSI Connector: force disconnect iscsi session https://review.openstack.org/217032 | 08:45 |
| dulek | geguileo: https://review.openstack.org/#/c/177054 | 08:49 |
| dulek | geguileo: This patch updates it, I've double checked and it is in sync. | 08:49 |
| geguileo | dulek: That patch is not going to be merged like that, I can guarantee it | 08:50 |
| *** haomaiwang has quit IRC | 08:51 | |
| geguileo | dulek: It will need to be split in 3 or 4 | 08:51 |
| openstackgerrit | wanghao proposed openstack/cinder: Add pagination to backups https://review.openstack.org/204493 | 08:51 |
| dulek | geguileo: It had +2's quite a few times. The problem is it gets into merge conflicts often due to the size. | 08:51 |
| geguileo | dulek: Because it's doing multiple thing in the same patch | 08:51 |
| *** haomaiwang has joined #openstack-cinder | 08:51 | |
| geguileo | dulek: Oh, then I'll give it a -2 right away | 08:52 |
| dulek | geguileo: I don't think thangp can split it more while providing a minimal functionality. | 08:52 |
| geguileo | dulek: Really? | 08:52 |
| geguileo | dulek: He can do Volume object changes in another patch | 08:52 |
| dulek | geguileo: Ah, right, that's different story than other objects, because VolumeObject was there in the first place, even if it wasn't used. | 08:53 |
| geguileo | dulek: He should move the refresh stuff to other patch as well, an probably move it to the base class | 08:54 |
| geguileo | dulek: And that's just from looking at it 3 minutes ;-) | 08:54 |
| *** jistr has quit IRC | 08:54 | |
| geguileo | dulek: I'll comment on the patch | 08:55 |
| dulek | geguileo: Okay, thanks. | 08:55 |
| geguileo | dulek: Thank you for pointing out those patches | 08:55 |
| geguileo | dulek: I've been looking at L3 priority patches lately and missed some other stuff | 08:55 |
| dulek | geguileo: Just FYI - here's follow-up patch: https://review.openstack.org/#/c/201404 | 08:55 |
| *** pots has quit IRC | 08:55 | |
| geguileo | dulek: Thanks | 08:56 |
| *** jistr has joined #openstack-cinder | 08:56 | |
| *** lixiaoy1 has quit IRC | 08:59 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Data transfer between encrypted volumes and images https://review.openstack.org/216567 | 08:59 |
| *** e0ne has joined #openstack-cinder | 08:59 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** davechen has quit IRC | 09:01 | |
| *** jistr has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-cinder | 09:02 | |
| *** jistr has joined #openstack-cinder | 09:05 | |
| nikeshm | e0ne: hi is this patch https://review.openstack.org/#/c/147186/ is not going to be merged as liberty | 09:16 |
| nikeshm | e0ne: its your patch right | 09:16 |
| nikeshm | in liberty | 09:16 |
| e0ne | nikeshm: it's eharney's patch | 09:17 |
| nikeshm | oh sorry | 09:17 |
| nikeshm | thanks i will ask him | 09:18 |
| *** andreykurilin__ has joined #openstack-cinder | 09:20 | |
| jordanP | e0ne, are you, by any chance, core on os-brick ? | 09:33 |
| e0ne | jordanP: yes, all cinder cores are os-brick cores too | 09:34 |
| jordanP | e0ne, excellent. May I bother you a sec to look at https://review.openstack.org/#/c/196631/ (it's needed to unblock a change you +Aed yesterday) | 09:35 |
| jordanP | e0ne, thanks | 09:46 |
| e0ne | jordanP: you're welcome! | 09:46 |
| *** baojg has quit IRC | 09:50 | |
| *** dims has joined #openstack-cinder | 09:50 | |
| openstackgerrit | Huang Zhiteng proposed openstack/os-brick: iSCSI Connector: force disconnect iscsi session https://review.openstack.org/217032 | 09:58 |
| *** haomaiwang has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-cinder | 10:02 | |
| *** jistr has quit IRC | 10:06 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Fix Python 3 issues in wsgi https://review.openstack.org/217417 | 10:10 |
| *** zhenguo has quit IRC | 10:10 | |
| openstackgerrit | Nikesh proposed openstack/cinder: Fix handling of volume copy for 'virtual' volumes https://review.openstack.org/217615 | 10:10 |
| *** EinstCrazy has quit IRC | 10:13 | |
| *** zhangjn has quit IRC | 10:15 | |
| *** jistr has joined #openstack-cinder | 10:18 | |
| *** pots has joined #openstack-cinder | 10:26 | |
| *** ociuhandu has quit IRC | 10:30 | |
| *** pythonguy has joined #openstack-cinder | 10:32 | |
| pythonguy | hello guys | 10:32 |
| *** pythonguy has quit IRC | 10:35 | |
| *** hw__chenying has quit IRC | 10:36 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/cinder: utils.synchronized lock name formatting https://review.openstack.org/217258 | 10:41 |
| *** takedakn1 has joined #openstack-cinder | 10:41 | |
| *** takedakn has quit IRC | 10:42 | |
| dulek | e0ne: Sorry, I've accidentally updated your grenade patch. As I actually did that let me address nits I've found there. | 10:43 |
| *** mewald has joined #openstack-cinder | 10:45 | |
| *** ociuhandu has joined #openstack-cinder | 10:46 | |
| mewald | How do I make cinder-volume redundant? Can I simply run multiple instances configured with the same backends? | 10:46 |
| dulek | mewald: Actually no. C-vol can run active/passive only. | 10:48 |
| dulek | mewald: I mean - you can run multiple instances, but you may run into some race conditions. | 10:48 |
| dulek | mewald: Which backends does you use? | 10:49 |
| mewald | I plan to use CEPH | 10:49 |
| mewald | so I can only have one instance of cinder-volume and cinder-backup as it must run on the same node that runs cinder-volume, right? | 10:50 |
| dulek | mewald: That's right. Mirantis Fuel is however running c-vol in A/A HA mode. So probably problems are very rare - but possible. | 10:51 |
| mewald | are there any plans to make A/A c-vol safe in future releases? | 10:52 |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Add LC_ALL=C to lvcreate, lvextend and pvresize https://review.openstack.org/216675 | 10:52 |
| openstackgerrit | Nikesh proposed openstack/cinder: Fix handling of volume copy for 'virtual' volumes https://review.openstack.org/217615 | 10:52 |
| *** pots has quit IRC | 11:00 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 11:02 | |
| *** aix has quit IRC | 11:02 | |
| e0ne | dulek: please, rebase your patch to the master | 11:05 |
| e0ne | dulek: my patch won't be merged in Liberty | 11:05 |
| e0ne | dulek: and thank you for fixing commit message | 11:06 |
| *** haomaiwa_ has quit IRC | 11:11 | |
| *** bswartz has quit IRC | 11:32 | |
| *** aix has joined #openstack-cinder | 11:33 | |
| nikeshm | smcginnis: hi uploaded one fix for dothill drivers https://review.openstack.org/#/c/217615/ | 11:37 |
| *** e0ne has quit IRC | 11:42 | |
| *** haomaiwang has joined #openstack-cinder | 11:53 | |
| *** deepakcs has quit IRC | 11:54 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** haomaiwang has joined #openstack-cinder | 12:02 | |
| *** dflorea has joined #openstack-cinder | 12:03 | |
| *** dflorea has quit IRC | 12:07 | |
| *** agarciam has quit IRC | 12:09 | |
| *** raildo-afk is now known as raildo | 12:10 | |
| *** dims has quit IRC | 12:14 | |
| *** rushil has joined #openstack-cinder | 12:14 | |
| *** thangp has joined #openstack-cinder | 12:15 | |
| *** rushil_ has joined #openstack-cinder | 12:18 | |
| *** ociuhandu has quit IRC | 12:20 | |
| thangp | geguileo: ping | 12:20 |
| thangp | geguileo: re:177054, i already broke up the changes as much as possible | 12:21 |
| *** anshul has quit IRC | 12:21 | |
| thangp | geguileo: the bulk of it is updating unit tests | 12:21 |
| *** zerda has quit IRC | 12:21 | |
| *** rushil has quit IRC | 12:22 | |
| *** haigang has joined #openstack-cinder | 12:22 | |
| *** mtanino has joined #openstack-cinder | 12:24 | |
| *** ociuhandu has joined #openstack-cinder | 12:26 | |
| *** haigang has quit IRC | 12:26 | |
| *** dims has joined #openstack-cinder | 12:29 | |
| *** BharatK_ has quit IRC | 12:30 | |
| *** annegentle has joined #openstack-cinder | 12:31 | |
| *** openstackgerrit has quit IRC | 12:31 | |
| *** openstackgerrit has joined #openstack-cinder | 12:32 | |
| *** edmondsw has joined #openstack-cinder | 12:32 | |
| *** pots has joined #openstack-cinder | 12:32 | |
| *** timcl has joined #openstack-cinder | 12:34 | |
| tbarron | mewald: for splitting backup/volume services see https://review.openstack.org/#/c/203215/ | 12:34 |
| tbarron | mewald: active/active c-vol will be a journey. First step is https://review.openstack.org/#/c/205834/ | 12:35 |
| *** andreykurilin__ has quit IRC | 12:35 | |
| openstackgerrit | Nikesh proposed openstack/cinder: Fix volume copy for 'virtual' volumes in DotHill https://review.openstack.org/217615 | 12:36 |
| *** anshul has joined #openstack-cinder | 12:38 | |
| *** simondodsley has joined #openstack-cinder | 12:38 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 12:43 |
| *** e0ne has joined #openstack-cinder | 12:44 | |
| *** merooney has joined #openstack-cinder | 12:47 | |
| *** bswartz has joined #openstack-cinder | 12:48 | |
| *** diablo_rojo has joined #openstack-cinder | 12:49 | |
| *** eduardo has joined #openstack-cinder | 12:49 | |
| *** salv-orlando has quit IRC | 12:53 | |
| *** porrua has joined #openstack-cinder | 12:55 | |
| *** rushil_ has quit IRC | 12:58 | |
| *** akerr has joined #openstack-cinder | 12:59 | |
| *** anshul has quit IRC | 12:59 | |
| *** haomaiwang has quit IRC | 13:01 | |
| *** haomaiwang has joined #openstack-cinder | 13:02 | |
| *** martyturner has joined #openstack-cinder | 13:04 | |
| *** dustins has joined #openstack-cinder | 13:06 | |
| *** changbl has joined #openstack-cinder | 13:06 | |
| *** tpsilva has joined #openstack-cinder | 13:06 | |
| *** I has joined #openstack-cinder | 13:06 | |
| *** I is now known as Guest62749 | 13:07 | |
| *** rushil has joined #openstack-cinder | 13:08 | |
| *** diogogmt has joined #openstack-cinder | 13:10 | |
| *** martyturner1 has joined #openstack-cinder | 13:10 | |
| *** mtanino has quit IRC | 13:11 | |
| *** ankit_ag has quit IRC | 13:12 | |
| *** anshul has joined #openstack-cinder | 13:12 | |
| *** martyturner has quit IRC | 13:13 | |
| openstackgerrit | Masaki Kanno proposed openstack/cinder: Prevent that all backup objects are deleted https://review.openstack.org/217702 | 13:15 |
| *** diablo_rojo has quit IRC | 13:16 | |
| *** salv-orlando has joined #openstack-cinder | 13:23 | |
| *** zhenguo has joined #openstack-cinder | 13:25 | |
| *** afazekas_ has quit IRC | 13:26 | |
| *** julim has joined #openstack-cinder | 13:28 | |
| *** Yogi1 has joined #openstack-cinder | 13:30 | |
| *** diablo_rojo has joined #openstack-cinder | 13:30 | |
| *** xyang1 has joined #openstack-cinder | 13:31 | |
| *** mriedem has joined #openstack-cinder | 13:32 | |
| geguileo | thangp: I dissagree | 13:33 |
| thangp | geguileo: ok... | 13:33 |
| geguileo | thangp: Like I said in the comment | 13:34 |
| geguileo | thangp: You can split the Volume versioned object code | 13:34 |
| geguileo | thangp: You can split the refresh code | 13:34 |
| thangp | geguileo: I already replied to it | 13:34 |
| thangp | geguileo: you cant put refresh in base | 13:34 |
| thangp | geguileo: the majority of the patch is unit tests | 13:35 |
| thangp | geguileo: breaking it into these minor pieces seems a lot of work for little gain | 13:35 |
| geguileo | thangp: The "little" gain is good reviews | 13:36 |
| *** gouthamr has joined #openstack-cinder | 13:37 | |
| thangp | geguileo: it increases the number of patches to rebase | 13:37 |
| geguileo | thangp: Because I can assure you there is no good review of a 2200 loc patch | 13:37 |
| thangp | geguileo: i dont disagree, but 2000 of those lines are in unit tests | 13:38 |
| thangp | geguileo: which is the annoyance | 13:38 |
| geguileo | thangp: Why mix test fixing with the other stuff in the patch? | 13:39 |
| *** Guest62749 has quit IRC | 13:39 | |
| geguileo | thangp: Why mix api/rpc/manager changes with changes to the object? | 13:39 |
| thangp | geguileo: because changing it to objects breaks unit tests | 13:39 |
| thangp | geguileo: the whole point of the patch is to send objs over rpc | 13:39 |
| geguileo | thangp: I know the point of the patch, but you have to split it | 13:40 |
| thangp | geguileo: i will look at splitting part of it | 13:41 |
| thangp | geguileo: but you cant put refresh in base, as i said in the patch | 13:41 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Volume status management during migration https://review.openstack.org/186312 | 13:43 |
| geguileo | thangp: You say you can't put it in the Cinder base object, and I think you can | 13:43 |
| thangp | geguileo: each obj has its own get_by_id | 13:43 |
| thangp | geguileo: which calls the db | 13:44 |
| thangp | geguileo: the base cinderobject should not have a get_by_id | 13:44 |
| geguileo | thangp: Well, I think it can | 13:44 |
| openstackgerrit | Nikesh proposed openstack/cinder: Fix volume copy for 'virtual' volumes in DotHill https://review.openstack.org/217615 | 13:44 |
| thangp | geguileo: how could you put refresh in base? | 13:45 |
| geguileo | thangp: You move get_by_id to base and set an attribute in each object to set the model | 13:46 |
| geguileo | thangp: Similar to what I did in conditional updates | 13:46 |
| thangp | geguileo: each get_by_id calls a different db api | 13:46 |
| *** diogogmt has quit IRC | 13:47 | |
| thangp | geguileo: you cant make a db call generic | 13:47 |
| geguileo | thangp: Well, I can, and I did for conditional objects | 13:48 |
| thangp | geguileo: what patch is that? | 13:48 |
| openstackgerrit | Nikesh proposed openstack/cinder: Fix volume copy for 'virtual' volumes in DotHill https://review.openstack.org/217615 | 13:48 |
| geguileo | thangp: https://review.openstack.org/#/c/205834/ | 13:48 |
| thangp | geguileo: i'm not going to disagree that it cant be done, but it looks like something we/i can do outside of this patch | 13:51 |
| geguileo | thangp: That's the whole point, you do the refresh stuff in another patch and you do it as it should be done | 13:52 |
| *** breitz has quit IRC | 13:52 | |
| *** mtanino has joined #openstack-cinder | 13:52 | |
| *** breitz has joined #openstack-cinder | 13:52 | |
| *** BharatK has joined #openstack-cinder | 13:57 | |
| *** haomaiwang has quit IRC | 14:01 | |
| *** 7GHAA12OT has joined #openstack-cinder | 14:02 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: Cleanup for cinder tests with CGSnapshot https://review.openstack.org/207866 | 14:03 |
| *** jwcroppe has joined #openstack-cinder | 14:03 | |
| *** krtaylor has quit IRC | 14:07 | |
| *** asselin__ has joined #openstack-cinder | 14:15 | |
| *** asselin has quit IRC | 14:18 | |
| *** vlaza has left #openstack-cinder | 14:19 | |
| *** diogogmt has joined #openstack-cinder | 14:20 | |
| *** eharney has joined #openstack-cinder | 14:23 | |
| *** IanGovett has quit IRC | 14:24 | |
| *** diogogmt has quit IRC | 14:25 | |
| *** IanGovett has joined #openstack-cinder | 14:25 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Volume status management during migration https://review.openstack.org/186312 | 14:26 |
| *** krtaylor has joined #openstack-cinder | 14:35 | |
| openstackgerrit | Derrick Wippler proposed openstack/python-cinderclient: No longer ignores CINDER_SERVICE_NAME https://review.openstack.org/214802 | 14:35 |
| *** links has quit IRC | 14:37 | |
| *** yrabl has quit IRC | 14:38 | |
| *** salv-orlando has quit IRC | 14:38 | |
| openstackgerrit | Derrick Wippler proposed openstack/python-cinderclient: Fixed test_password_prompted https://review.openstack.org/214704 | 14:40 |
| *** diablo_rojo has quit IRC | 14:42 | |
| *** wilson2 has quit IRC | 14:44 | |
| *** wilson has joined #openstack-cinder | 14:45 | |
| wilson | hemnafk: hi | 14:46 |
| wilson | hemnakf: I have addressed your comments at patch https://review.openstack.org/#/c/201578/ | 14:46 |
| wilson | hemnafk: please check if it's ok, thanks! | 14:48 |
| *** dustins has quit IRC | 14:48 | |
| *** dims has quit IRC | 14:51 | |
| nikeshm | the last item in the dictionary should have a trailing comma, but in many places in cinder code, this rule is not followed | 14:51 |
| nikeshm | http://docs.openstack.org/developer/hacking/#dictionaries-lists | 14:51 |
| *** dims has joined #openstack-cinder | 14:51 | |
| smcginnis | nikeshm: Yeah, I was enforcing that in reviews for a while but decided I didn't really care. :) | 14:52 |
| smcginnis | It's kind of a trivial guideline in my opinion. | 14:52 |
| smcginnis | The only benefit I see (or that's given) is that if you add to a dictionary it will show up in stats as a one line change instead of two. | 14:53 |
| smcginnis | Doesn't seem that compelling to me to enforce. | 14:53 |
| nikeshm | smcginnis: ok thanks | 14:53 |
| smcginnis | That's just my opinion of course. | 14:53 |
| nikeshm | hmm | 14:53 |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Add retries to delete a volume in the RBD driver https://review.openstack.org/217746 | 14:53 |
| *** afazekas_ has joined #openstack-cinder | 14:54 | |
| *** jaypipes has joined #openstack-cinder | 14:55 | |
| *** dustins has joined #openstack-cinder | 14:57 | |
| yuriy_n17 | geguileo: Hi! Please review https://review.openstack.org/#/c/217746/ | 14:58 |
| yuriy_n17 | smcginnis: Hi! Please review https://review.openstack.org/#/c/217746/ | 14:59 |
| *** 7GHAA12OT has quit IRC | 15:01 | |
| *** jdurgin1 has joined #openstack-cinder | 15:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 15:02 | |
| *** krtaylor has quit IRC | 15:02 | |
| *** hemnafk is now known as hemna | 15:03 | |
| *** edtubill has joined #openstack-cinder | 15:03 | |
| *** nkrinner has quit IRC | 15:03 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Validate filters in snapshot*, backup* in db.api https://review.openstack.org/217110 | 15:03 |
| *** xiaohui has quit IRC | 15:03 | |
| *** xiaohui has joined #openstack-cinder | 15:04 | |
| *** martyturner1 has quit IRC | 15:05 | |
| *** ronis_ has quit IRC | 15:08 | |
| smcginnis | yuriy_n17: No need to explicitly add reviewers and ping them on each patch. | 15:10 |
| smcginnis | yuriy_n17: Cores will eventually get to reviewing them. | 15:10 |
| smcginnis | yuriy_n17: Save the pinging for when you have a critical patch you really need attention on. :) | 15:11 |
| yuriy_n17 | smcginnis: Thanks a lot. | 15:12 |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Add retries to delete a volume in the RBD driver https://review.openstack.org/217746 | 15:13 |
| openstackgerrit | Jon Bernard proposed openstack/cinder: Add support for file I/O volume migration https://review.openstack.org/187270 | 15:15 |
| *** wilson has quit IRC | 15:17 | |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: LeftHand: Adding Consistency Group Support https://review.openstack.org/214386 | 15:17 |
| *** lcurtis has joined #openstack-cinder | 15:18 | |
| *** wilson has joined #openstack-cinder | 15:18 | |
| Guest54162 | e0ne: ping | 15:18 |
| Guest54162 | baaahhhhh!!!! | 15:18 |
| *** Guest54162 is now known as jgriffith | 15:18 | |
| *** jgriffith is now known as Guest28159 | 15:19 | |
| Guest28159 | e0ne: You gave this a -1: https://review.openstack.org/#/c/189588/1 | 15:19 |
| Guest28159 | e0ne: but I see no comment as to why? | 15:19 |
| Guest28159 | Ahh... wait, I see it :) | 15:19 |
| Guest28159 | NM | 15:19 |
| dulek | yuriy_n17: Hey, thanks for review, it's quite embarrassing I've left that there. ;) | 15:22 |
| *** links has joined #openstack-cinder | 15:22 | |
| yuriy_n17 | dulek: no problem ;) | 15:24 |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Validate filters in snapshot*, backup* in db.api https://review.openstack.org/217110 | 15:25 |
| *** afazekas_ has quit IRC | 15:27 | |
| *** dustins has quit IRC | 15:28 | |
| hemna | xyang1, ping | 15:28 |
| xyang1 | hemna: Hi | 15:29 |
| hemna | xyang1, mriedem can we get this guy in today? https://review.openstack.org/#/c/207553/ | 15:29 |
| xyang1 | hemna: Looks good to me | 15:30 |
| *** asselin__ has quit IRC | 15:30 | |
| openstackgerrit | Tom Barron proposed openstack/cinder: NetApp DOT block driver over-subscription support https://review.openstack.org/215865 | 15:33 |
| hemna | tbarron, did you need any brick help w/ the backup work you are doing? I know you had mentioned it a bit at the midcycle | 15:33 |
| tbarron | hemna: I will for sure, but that work has slipped to start of M. | 15:34 |
| hemna | tbarron, ok. If you need any help, let me know | 15:34 |
| tbarron | hemna: I got assigned other work for L3 .... | 15:34 |
| tbarron | hemna: I will, and thanks very much for the offer!!! | 15:34 |
| hemna | decoupling from the drivers seems like a really good idea to me. | 15:34 |
| *** afazekas_ has joined #openstack-cinder | 15:35 | |
| *** asselin has joined #openstack-cinder | 15:36 | |
| tbarron | hemna: I appreciate the endorsement of the idea. I think we can do some api-race fixing in backup (for both backup and volume opbjects) as part of this too, using the new compaere-and-swap. | 15:36 |
| *** tsekiyama has joined #openstack-cinder | 15:36 | |
| tbarron | compare | 15:36 |
| *** asselin__ has joined #openstack-cinder | 15:36 | |
| hemna | tbarron, I think it's also worth noting that some of that effort also should be aware of the 'ing' checking effort in the API ? | 15:37 |
| *** changbl has quit IRC | 15:37 | |
| tbarron | hemna: I agree, from what I understand of that. Need to learn more. | 15:37 |
| openstackgerrit | Thang Pham proposed openstack/cinder: Register RPC and object versions https://review.openstack.org/209701 | 15:39 |
| *** mewald has quit IRC | 15:40 | |
| *** asselin has quit IRC | 15:40 | |
| *** skylerberg has joined #openstack-cinder | 15:40 | |
| *** ccesario has quit IRC | 15:41 | |
| *** anshul has quit IRC | 15:41 | |
| *** asselin__ has quit IRC | 15:42 | |
| *** bnemec has joined #openstack-cinder | 15:42 | |
| *** jdurgin has quit IRC | 15:43 | |
| *** changbl has joined #openstack-cinder | 15:44 | |
| *** jdurgin has joined #openstack-cinder | 15:44 | |
| smcginnis | This has become software defined: http://snag.gy/wJjt9jpg | 15:47 |
| smcginnis | Seems like an appropriate picture given the state of some of our code. ;) | 15:47 |
| hemna | the yellow wire is wrong | 15:47 |
| smcginnis | From OpenStackSV | 15:47 |
| *** BharatK has quit IRC | 15:47 | |
| smcginnis | hemna: Yeah, where's the standardization on cable colors?! | 15:48 |
| *** andreykurilin__ has joined #openstack-cinder | 15:48 | |
| *** Apoorva has joined #openstack-cinder | 15:48 | |
| hemna | wire_ v. wire: | 15:48 |
| *** diablo_rojo has joined #openstack-cinder | 15:48 | |
| smcginnis | ;) | 15:48 |
| *** rushil has quit IRC | 15:50 | |
| *** afazekas_ has quit IRC | 15:50 | |
| *** changbl has quit IRC | 15:51 | |
| *** wilson has quit IRC | 15:52 | |
| *** alexschm has quit IRC | 15:52 | |
| *** wilson has joined #openstack-cinder | 15:52 | |
| *** markstur_ has joined #openstack-cinder | 15:53 | |
| *** markstur has quit IRC | 15:54 | |
| *** Guest28159 has quit IRC | 15:54 | |
| *** jgriffit1 has joined #openstack-cinder | 15:55 | |
| *** haomaiwa_ has quit IRC | 16:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 16:02 | |
| *** haomaiwa_ has quit IRC | 16:06 | |
| *** afazekas_ has joined #openstack-cinder | 16:08 | |
| *** ccesario has joined #openstack-cinder | 16:10 | |
| *** changbl has joined #openstack-cinder | 16:10 | |
| *** sgotliv has quit IRC | 16:11 | |
| openstackgerrit | Tom Swanson proposed openstack/cinder: Dell SC: init_volume stale volume info fix https://review.openstack.org/216859 | 16:13 |
| *** timcl has quit IRC | 16:14 | |
| *** jgriffit1 has quit IRC | 16:14 | |
| *** jgriffit1 has joined #openstack-cinder | 16:15 | |
| *** e0ne has quit IRC | 16:18 | |
| *** lpetrut1 has quit IRC | 16:20 | |
| *** jgriffith has joined #openstack-cinder | 16:22 | |
| *** jgriffith is now known as Guest67474 | 16:22 | |
| *** yuriy_n17 has quit IRC | 16:22 | |
| *** jistr has quit IRC | 16:24 | |
| *** dustins has joined #openstack-cinder | 16:24 | |
| *** bluex-pl has quit IRC | 16:24 | |
| *** eharney has quit IRC | 16:26 | |
| *** _cjones_ has joined #openstack-cinder | 16:26 | |
| *** garthb_ has joined #openstack-cinder | 16:26 | |
| *** garthb has joined #openstack-cinder | 16:26 | |
| *** garthb has quit IRC | 16:27 | |
| *** leeantho has joined #openstack-cinder | 16:27 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Enhance FC zone support for Huawei driver https://review.openstack.org/201578 | 16:27 |
| *** afazekas_ has quit IRC | 16:27 | |
| *** sghanekar has joined #openstack-cinder | 16:28 | |
| *** dannywilson has joined #openstack-cinder | 16:29 | |
| *** dannywilson has quit IRC | 16:29 | |
| *** dannywilson has joined #openstack-cinder | 16:29 | |
| *** salv-orlando has joined #openstack-cinder | 16:29 | |
| *** stefan_amann has quit IRC | 16:31 | |
| *** sghanekar has quit IRC | 16:32 | |
| *** annegentle has quit IRC | 16:33 | |
| *** jdurgin1 has quit IRC | 16:34 | |
| *** p0rtal_ has joined #openstack-cinder | 16:35 | |
| *** Guest67474 is now known as jgriffith | 16:38 | |
| *** mdenny has quit IRC | 16:38 | |
| *** mdenny has joined #openstack-cinder | 16:38 | |
| *** p0rtal has quit IRC | 16:39 | |
| *** boris-42 has joined #openstack-cinder | 16:39 | |
| *** p0rtal_ has quit IRC | 16:39 | |
| *** jgriffit1 has quit IRC | 16:39 | |
| *** zhenguo has quit IRC | 16:41 | |
| *** skylerberg has quit IRC | 16:44 | |
| *** jordanP has quit IRC | 16:44 | |
| *** links has quit IRC | 16:45 | |
| *** ndipanov has quit IRC | 16:50 | |
| *** annegentle has joined #openstack-cinder | 16:51 | |
| *** annegentle has quit IRC | 16:51 | |
| *** EinstCrazy has joined #openstack-cinder | 16:51 | |
| *** afazekas_ has joined #openstack-cinder | 16:52 | |
| *** krtaylor has joined #openstack-cinder | 16:52 | |
| *** sghanekar has joined #openstack-cinder | 16:53 | |
| hemna | smcginnis, got a second ? | 16:54 |
| *** annegentle has joined #openstack-cinder | 16:54 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: FC Stop calling multipath command line https://review.openstack.org/213389 | 16:55 |
| *** harlowja has joined #openstack-cinder | 16:55 | |
| *** timcl has joined #openstack-cinder | 16:56 | |
| *** rhe00 has quit IRC | 16:57 | |
| *** aix has quit IRC | 16:58 | |
| *** rhe00 has joined #openstack-cinder | 16:58 | |
| *** mudassirlatif has joined #openstack-cinder | 16:59 | |
| *** jordanP has joined #openstack-cinder | 17:00 | |
| *** jgriffith_ has joined #openstack-cinder | 17:00 | |
| *** yrabl has joined #openstack-cinder | 17:01 | |
| *** rhe00 has quit IRC | 17:03 | |
| *** lpetrut has joined #openstack-cinder | 17:03 | |
| *** lpetrut has quit IRC | 17:03 | |
| *** jgriffith has quit IRC | 17:03 | |
| *** jgriffith_ is now known as jgriffith | 17:03 | |
| *** lpetrut has joined #openstack-cinder | 17:04 | |
| *** sidbhatt13 has joined #openstack-cinder | 17:04 | |
| *** rhe00 has joined #openstack-cinder | 17:04 | |
| *** vilobhmm1 has joined #openstack-cinder | 17:05 | |
| *** lpetrut has left #openstack-cinder | 17:06 | |
| *** afazekas_ has quit IRC | 17:07 | |
| *** diablo_rojo has quit IRC | 17:08 | |
| *** eharney has joined #openstack-cinder | 17:09 | |
| *** afazekas_ has joined #openstack-cinder | 17:09 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: iSCSI fix misleading Log warning on connect fail https://review.openstack.org/217802 | 17:10 |
| *** garthb has joined #openstack-cinder | 17:10 | |
| *** garthb_ has quit IRC | 17:10 | |
| *** crose has joined #openstack-cinder | 17:11 | |
| *** afazekas_ has quit IRC | 17:15 | |
| *** setmason has joined #openstack-cinder | 17:17 | |
| *** ronis_ has joined #openstack-cinder | 17:18 | |
| openstackgerrit | Andrey Pavlov proposed openstack/cinder: test https://review.openstack.org/217809 | 17:19 |
| *** bnemec has quit IRC | 17:21 | |
| jbernard | is anyone working on the vmware backing_from_stream_optimized_file failure? | 17:23 |
| *** afazekas_ has joined #openstack-cinder | 17:27 | |
| jgriffith | jbernard: not that I'm aware of | 17:32 |
| jbernard | jgriffith: ive done a few runs to try to reproduce, but no luck yet | 17:33 |
| jbernard | jgriffith: seems to fail every now and then in the gate | 17:33 |
| *** mriedem1 has joined #openstack-cinder | 17:33 | |
| thrawn01 | hey guys I was looking at taking on, https://bugs.launchpad.net/cinder/+bug/1415241 but I'm not sure what the error is in the example. it's non obvious to me =/ | 17:34 |
| openstack | Launchpad bug 1415241 in Cinder "cinder hacking checks don't cover logging format string arg count" [Undecided,New] - Assigned to Scott DAngelo (scott-dangelo) | 17:34 |
| *** dflorea has joined #openstack-cinder | 17:34 | |
| *** mriedem has quit IRC | 17:36 | |
| *** annegentle has quit IRC | 17:36 | |
| *** dflorea has quit IRC | 17:38 | |
| scottda | thrawn01: the args are in parenthesis, so there is only one arg being passed in, instead of 2 | 17:39 |
| *** dflorea has joined #openstack-cinder | 17:39 | |
| thrawn01 | scottda: I suspected that might be the case, I was just about to test it. thanks! | 17:40 |
| *** e0ne has joined #openstack-cinder | 17:45 | |
| *** dflorea has quit IRC | 17:45 | |
| *** p0rtal has joined #openstack-cinder | 17:47 | |
| *** afazekas_ has quit IRC | 17:48 | |
| *** EinstCrazy has quit IRC | 17:48 | |
| *** dflorea has joined #openstack-cinder | 17:57 | |
| *** dflorea has quit IRC | 18:00 | |
| *** garthb has quit IRC | 18:01 | |
| *** garthb has joined #openstack-cinder | 18:02 | |
| *** merooney has quit IRC | 18:02 | |
| smcginnis | hemna: Still around? | 18:03 |
| hemna | yuh | 18:03 |
| smcginnis | hemna: Just got back from back to back meetings. I'll catch up in a bit. | 18:04 |
| hemna | no worries | 18:04 |
| *** merooney has joined #openstack-cinder | 18:04 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/cinder: Add parameter to filter pools for NetApp driver https://review.openstack.org/210588 | 18:06 |
| *** garthb has quit IRC | 18:09 | |
| *** ociuhandu has quit IRC | 18:11 | |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: LeftHand: Adding Consistency Group Support https://review.openstack.org/214386 | 18:14 |
| *** crose has quit IRC | 18:14 | |
| *** DTadrzak has quit IRC | 18:17 | |
| *** takedakn1 has quit IRC | 18:22 | |
| *** sidbhatt13 has quit IRC | 18:23 | |
| *** annegentle has joined #openstack-cinder | 18:24 | |
| *** annegentle has quit IRC | 18:25 | |
| *** zhonghua-li has joined #openstack-cinder | 18:27 | |
| *** crose has joined #openstack-cinder | 18:27 | |
| *** zhonghua-lee has quit IRC | 18:30 | |
| *** crose has quit IRC | 18:33 | |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: LeftHand: Adding Consistency Group Support https://review.openstack.org/214386 | 18:36 |
| *** zhonghua has joined #openstack-cinder | 18:39 | |
| *** cpallares has quit IRC | 18:40 | |
| *** zhonghua-li has quit IRC | 18:41 | |
| *** zhonghua-lee has joined #openstack-cinder | 18:42 | |
| *** zhonghua has quit IRC | 18:44 | |
| *** cpallares has joined #openstack-cinder | 18:46 | |
| *** annegentle has joined #openstack-cinder | 18:46 | |
| *** shyama has quit IRC | 18:49 | |
| *** crose has joined #openstack-cinder | 18:52 | |
| *** e0ne has quit IRC | 18:53 | |
| *** garthb has joined #openstack-cinder | 18:56 | |
| *** rushil has joined #openstack-cinder | 18:56 | |
| tbarron | jbernard: I've been unable to reproduce it locally. One thing I notice is that there are two such tests, in different classes. | 18:58 |
| tbarron | jbernard: 'open' is mocked differently in the two. In one case, six.moves.open is mocked IIRC; in the other, a vmware.vmdk.open() | 18:59 |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Add retries to delete a volume in the RBD driver https://review.openstack.org/217746 | 18:59 |
| tbarron | jbernard: may not be a clue. I put an assert in both methods to see if somehow the mocked open method wasn't getting called. | 19:00 |
| tbarron | jbernard: but in both cases I saw the mocked open called the expected number of times. | 19:00 |
| tbarron | jbernard: that was all local. Note that the (mocked) delete is called both in the exception path of the first part of the test, and in the second (negative) part of the test. | 19:02 |
| tbarron | jbernard: these are combined positive and negative case tests, which I would have rather seen separated. | 19:03 |
| eharney | tbarron: the error looks to me like something isn't mocked right, and looking at _test_create_backing_from_stream_optimized_file... that wouldn't be too surprising | 19:05 |
| eharney | it looks worryingly complicated | 19:05 |
| tbarron | eharney: yeah, patrickeast and I were looking last night but couldn't figure the mock-out failure. | 19:06 |
| tbarron | eharney: but certainly it must be that. | 19:06 |
| patrickeast | maybe we should just delete the test and file a vmware bug XD | 19:06 |
| * patrickeast is only half joking | 19:06 | |
| tbarron | eharney: this is IMO a way over-complicated unit test. I'd like unit tests to be plain dumb simple, not "clever" | 19:07 |
| eharney | a test with that many mocks and sentinels in it needs to be redone somehow | 19:07 |
| *** merooney has quit IRC | 19:07 | |
| tbarron | eharney: =1000 | 19:07 |
| tbarron | +1000 | 19:07 |
| tbarron | patrickeast: it's not a bad idea given that it's an unproductive time sink. | 19:09 |
| eharney | tbarron: has this hit many times? | 19:11 |
| *** aix has joined #openstack-cinder | 19:11 | |
| tbarron | eharney: mtanino, patrickeast, and my folks have hit it. In the latter case, several times in the last few days. | 19:11 |
| mtanino | yes... | 19:12 |
| tbarron | eharney: I can file a bug whining about hitting the issue intermittently. | 19:12 |
| eharney | i'd lean more toward patrickeast's idea because i don't think anyone is going to look at that and know how to fix it very quickly | 19:13 |
| *** skylerberg has joined #openstack-cinder | 19:14 | |
| *** simondodsley has quit IRC | 19:17 | |
| tbarron | vilobhmm1: are you the person to talk to about vmware.vmdk unit tests? | 19:18 |
| tbarron | vilobhmm1: never mind - I've got the wrong nic!!! sorry. | 19:19 |
| thangp | tbarron: it's vipin | 19:19 |
| thangp | tbarron: but he's in india | 19:20 |
| tbarron | thangp: thanks, don't see him on ... | 19:20 |
| vilobhmm1 | tbarron : I don't think so | 19:20 |
| tbarron | thangp: slacker :-) | 19:20 |
| tbarron | vilobhmm1: sorry about that! | 19:20 |
| vilobhmm1 | tbarron : np :) | 19:20 |
| tbarron | I had too many nicks in my 'v' hash bucket. | 19:20 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Adds framework for get_capabilities() feature https://review.openstack.org/201243 | 19:21 |
| *** JebAka has joined #openstack-cinder | 19:21 | |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Efficient volume copy for generic volume migration https://review.openstack.org/183701 | 19:21 |
| jbernard | eharney: ive hit it 3 or 4 times in the last two days | 19:22 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Allow specified backend capabilities to be retrieved https://review.openstack.org/212861 | 19:22 |
| jbernard | patrickeast: would i be hated if i submitted that patch? :) given the time to recheck and the frequency of failure, it doesn't seem like a bad idea to me | 19:23 |
| patrickeast | jbernard: haha i doubt it, i would give it a +1 | 19:24 |
| tbarron | jbernard: I'll +1. I'd do it myself it wouldn't take a week to show up :-) | 19:25 |
| jbernard | i was thinking just remove the test and file a bug against the driver | 19:26 |
| jbernard | actually, i think there is already a bug for it | 19:26 |
| *** rushil has quit IRC | 19:26 | |
| openstackgerrit | Edmund Rhudy proposed openstack/cinder: Adds allow_availability_zone_fallback option to Cinder https://review.openstack.org/217857 | 19:29 |
| eharney | jordanP: are you sure you don't need a new os-brick release for https://review.openstack.org/#/c/200610/ to move along? | 19:30 |
| jordanP | eharney, for now my CI has been working with the "git" version of os-brick | 19:31 |
| jordanP | so it can wait | 19:31 |
| openstackgerrit | Edmund Rhudy proposed openstack/cinder: Adds allow_availability_zone_fallback option to Cinder https://review.openstack.org/217857 | 19:31 |
| *** esker has joined #openstack-cinder | 19:31 | |
| eharney | jordanP: i'm wondering if that's why it's stuck, though | 19:32 |
| jordanP | eharney, yeah... I wonder myself too... | 19:32 |
| eharney | jordanP: i think that happens when depends-on can't be resolved correctly, which it maybe can't, because i think the gate uses released libs for brick? | 19:32 |
| jordanP | eharney, do you know if there's a difference betweek "recheck" and "reverify" nowadays ? | 19:33 |
| eharney | jordanP: there's not | 19:33 |
| jordanP | ok | 19:33 |
| eharney | jordanP: but yeah, i suspect you'll have to have a release and bump requirements.txt for that to work :/ | 19:33 |
| jordanP | but in the gate, my "code" is actually not executed, only the unit tests | 19:34 |
| eharney | well, it may be possible to land it if you remove the Depends-On | 19:34 |
| *** jungleboyj has joined #openstack-cinder | 19:35 | |
| jordanP | eharney, if I just change the commit message I won't lose my +A right ? | 19:35 |
| jordanP | (fingers crossed...) | 19:36 |
| eharney | jordanP: i think you will, but i'll just re-add it if there aren't code changes | 19:36 |
| *** annegentle has quit IRC | 19:36 | |
| *** annegentle has joined #openstack-cinder | 19:37 | |
| jordanP | eharney, ok, doing that now then | 19:37 |
| *** e0ne has joined #openstack-cinder | 19:37 | |
| eharney | jordanP: the last sofs CI there shows aborted btw | 19:38 |
| jordanP | eharney, yeah, we are discssing this issue right now in #openstack-qa | 19:38 |
| eharney | jordanP: ah, ok | 19:39 |
| jordanP | it's a tempest bug actually | 19:39 |
| openstackgerrit | Jordan Pittier proposed openstack/cinder: Rework Scality SOFS driver to use RemoteFS class https://review.openstack.org/200610 | 19:40 |
| jordanP | eharney, the reason I had to "silent" my CI: https://review.openstack.org/#/c/217804/ fyi | 19:42 |
| eharney | jordanP: well that's fun | 19:44 |
| jordanP | not really :p... | 19:44 |
| *** skylerberg has quit IRC | 19:44 | |
| openstackgerrit | Edmund Rhudy proposed openstack/cinder: Adds allow_availability_zone_fallback option to Cinder https://review.openstack.org/217857 | 19:48 |
| *** IanGovett has quit IRC | 19:51 | |
| *** pots has quit IRC | 19:55 | |
| openstackgerrit | Danny Wilson proposed openstack/cinder: Replication V2 for Pure Storage https://review.openstack.org/214825 | 20:00 |
| openstackgerrit | xing-yang proposed openstack/cinder: Allow CG without snapshot to be deleted https://review.openstack.org/213892 | 20:02 |
| *** merooney has joined #openstack-cinder | 20:02 | |
| *** Lee1092 has quit IRC | 20:03 | |
| *** esker has quit IRC | 20:04 | |
| *** xyang1 has quit IRC | 20:06 | |
| *** esker has joined #openstack-cinder | 20:08 | |
| *** mudassirlatif_ has joined #openstack-cinder | 20:08 | |
| *** rushil has joined #openstack-cinder | 20:09 | |
| *** kvidvans has joined #openstack-cinder | 20:09 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Remove driver.set_execute() https://review.openstack.org/217364 | 20:10 |
| *** mudassirlatif has quit IRC | 20:10 | |
| *** mudassirlatif_ is now known as mudassirlatif | 20:10 | |
| *** martyturner has joined #openstack-cinder | 20:12 | |
| *** esker has quit IRC | 20:13 | |
| *** e0ne has quit IRC | 20:13 | |
| *** sghanekar_ has joined #openstack-cinder | 20:14 | |
| *** ronis_ has quit IRC | 20:14 | |
| *** sghanekar has quit IRC | 20:15 | |
| *** eharney has quit IRC | 20:15 | |
| *** mriedem1 is now known as mriedem | 20:17 | |
| *** p0rtal_ has joined #openstack-cinder | 20:21 | |
| *** rhagarty__ has quit IRC | 20:23 | |
| *** rhagarty_ has quit IRC | 20:23 | |
| *** p0rtal has quit IRC | 20:24 | |
| openstackgerrit | Jon Bernard proposed openstack/cinder: Skip intermittent VMDK tests https://review.openstack.org/217882 | 20:24 |
| jbernard | patrickeast, tbarron ^ | 20:25 |
| tbarron | jbernard: +1 from me. Thanks. | 20:28 |
| *** rhagarty has joined #openstack-cinder | 20:29 | |
| *** rhagarty_ has joined #openstack-cinder | 20:30 | |
| *** JoeStack has quit IRC | 20:30 | |
| *** markvoelker has quit IRC | 20:33 | |
| *** dustins has quit IRC | 20:34 | |
| *** kvidvans has quit IRC | 20:39 | |
| openstackgerrit | Anna Sortland proposed openstack/cinder: Earlier authority check for create volume API https://review.openstack.org/217899 | 20:39 |
| hemna | I thought reverify was for gate jobs only ? | 20:40 |
| *** IlyaG has joined #openstack-cinder | 20:41 | |
| jungleboyj | hemna: ++ | 20:41 |
| *** jlk has joined #openstack-cinder | 20:44 | |
| patrickeast | hemna: its kind of arbitrary, the official jenkins zuul config will do the same thing for recheck/reverify iirc | 20:44 |
| jlk | I'm in need of a clue bat. How does the cinder-volume service accept tasks? (things in volume/manager.py) | 20:44 |
| patrickeast | hemna: and a bunch of other CI systems do the same thing | 20:44 |
| hemna | ugh | 20:44 |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: LeftHand: Adding Consistency Group Support https://review.openstack.org/214386 | 20:45 |
| *** krtaylor has quit IRC | 20:46 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: 3PAR update driver to store stats https://review.openstack.org/216771 | 20:46 |
| *** rushil has quit IRC | 20:50 | |
| *** julim has quit IRC | 20:50 | |
| *** rushil has joined #openstack-cinder | 20:51 | |
| *** rushil_ has joined #openstack-cinder | 20:52 | |
| *** julim has joined #openstack-cinder | 20:54 | |
| *** rushil has quit IRC | 20:56 | |
| *** raildo is now known as raildo-afk | 20:56 | |
| tbarron | jlk: not sure exactly what you are asking, but I think we do a pretty good job in chapter 4 of http://netapp.github.io/openstack-deploy-ops-guide/ explaing workflow from client requests through API over messaging bus to scheduler, cinder-volume, cinder-backup, and back, etc. | 20:58 |
| tbarron | jlk: maybe that will help. | 20:58 |
| *** mudassirlatif has quit IRC | 21:02 | |
| jlk | tbarron: thanks that helps. I'm trying to chase an issue where during volume creation, cinder-scheduler picks a particular volume service, makes a "cast" on the service, and considers the job done. | 21:02 |
| jlk | On the cinder-volume side we're not seeing a response to the request to actually make the volume | 21:02 |
| *** mudassirlatif has joined #openstack-cinder | 21:03 | |
| jlk | it appears to just be running the periodic tasks and publishing info | 21:03 |
| guitarzan | jlk: are you using the same cinder.conf on all your boxes? | 21:04 |
| tbarron | guitarzan: +1 | 21:04 |
| jlk | there is a slight difference, the host that is running cinder-volume service has a defined backend configuration | 21:05 |
| jlk | whereas the host running cinder-api and cinder-scheduler do not | 21:05 |
| *** merooney has quit IRC | 21:05 | |
| jlk | wait a sec. | 21:06 |
| *** julim has quit IRC | 21:07 | |
| guitarzan | jlk: also, does the host/service list look like you expect it to? | 21:07 |
| jlk | yes, the host and service list look right | 21:08 |
| jlk | er host+service | 21:08 |
| guitarzan | can you see what queue c-sched is throwing messages on? | 21:08 |
| jlk | where would that info live? | 21:09 |
| *** gouthamr has quit IRC | 21:09 | |
| tbarron | jlk: you're in good hands, guitarzan may have done this a few times before :-) I'm off to a monthly OpenStack meetup ... | 21:09 |
| *** rushil_ has quit IRC | 21:10 | |
| jlk | there appear to be two queues for each host that's running cinder-scheduler, plus two scheduler_fanout queues. | 21:11 |
| jlk | none of them have any messages in them. | 21:11 |
| guitarzan | hmm, so someone is picking it up? | 21:11 |
| *** Yogi1 has quit IRC | 21:11 | |
| *** IlyaG has quit IRC | 21:11 | |
| jlk | it would appear so | 21:11 |
| *** merooney has joined #openstack-cinder | 21:12 | |
| jlk | scheduler itself is getting the messages and picking a host to build the volume on | 21:12 |
| jlk | it's after that where the messages seem to stop | 21:12 |
| *** jordanP has quit IRC | 21:12 | |
| guitarzan | so it isn't throwing a message out for c-vol? and it isn't complaining with a No hosts found message? | 21:12 |
| jlk | I see a message from scheduler like: | 21:13 |
| jlk | 2015-08-27 21:09:26.575 9048 DEBUG cinder.openstack.common.rpc.amqp [req-144fa1c | 21:13 |
| jlk | 7-7d75-4cf2-a1c4-78e773d4d790 e6fa6803d81749eba1c43a9966bff6b1 c08a60feec12400da | 21:13 |
| jlk | 5badc671038b735] Making asynchronous cast on cinder-volume:ds1421@nimble... cas | 21:13 |
| jlk | t | 21:13 |
| *** gouthamr has joined #openstack-cinder | 21:13 | |
| *** IlyaG_ has joined #openstack-cinder | 21:14 | |
| jlk | after it decides to use the host ds1421@nimble | 21:14 |
| *** timcl has quit IRC | 21:14 | |
| guitarzan | and that queue is empty in rabbit? | 21:16 |
| jlk | yes | 21:16 |
| jlk | cinder-volume.ds1421@nimble0 | 21:17 |
| guitarzan | and that c-vol doesn't look like it's doing anything with that message? | 21:17 |
| jlk | correct | 21:17 |
| jlk | I don't really see anything in the logs having to do with /incoming/ messages, only with running periodic tasks to generate outgoing messages. | 21:17 |
| guitarzan | dare I ask if you have another rogue c-vol running somewhere? :) | 21:17 |
| jlk | I really hope not, I'll hunt around. It would be odd if there was, with the same hostname | 21:18 |
| guitarzan | it doesn't really have to have that hostname, just cinder.conf that thinks it is | 21:18 |
| jlk | true | 21:19 |
| guitarzan | here's a fun test though | 21:20 |
| guitarzan | kill c-vol and try to create one | 21:20 |
| guitarzan | see if it gets thrown in that queue | 21:20 |
| jlk | yeah, I thought I tried this. | 21:20 |
| guitarzan | that's kind of racy though, depending on how fast the scheduler kicks it out | 21:20 |
| jlk | right | 21:20 |
| *** skylerberg has joined #openstack-cinder | 21:20 | |
| jlk | ah too slow | 21:21 |
| jlk | well | 21:22 |
| jlk | nothing showed up in the queue | 21:22 |
| jlk | and the status is creating | 21:23 |
| jlk | so maybe scheduler isn't actually putting the message out? | 21:24 |
| guitarzan | I've never seen anything like that before | 21:25 |
| openstackgerrit | Patrick East proposed openstack/cinder: Generic image-volume cache https://review.openstack.org/195795 | 21:25 |
| guitarzan | I wonder if anyone else has any idea | 21:25 |
| jlk | I'm going to bounce all of rabbit and see what gets re-created | 21:25 |
| guitarzan | one thing I can guarantee... it's some super simple configuration problem :) | 21:27 |
| jlk | hah, ugh. | 21:27 |
| jlk | so queues got recreated, but same behavior | 21:28 |
| *** rushil has joined #openstack-cinder | 21:28 | |
| guitarzan | but you can't catch any messages in the c-vol queue | 21:28 |
| jlk | oh let me stop and try the build again | 21:28 |
| guitarzan | are you running c-vol with debug and verbose on? | 21:29 |
| *** tpsilva has quit IRC | 21:29 | |
| jlk | yeah | 21:29 |
| guitarzan | ok | 21:29 |
| jlk | so with the service stopped, a create call still gets into "creating" status, but no message in the queue | 21:29 |
| guitarzan | what does cinder service-list look like? | 21:31 |
| jlk | well right now https://gist.github.com/j2sol/ee26b1fff48438b813af | 21:32 |
| jlk | because I shut off both schedulers to see if I could catch c-vol putting a message out for scheduler for a capability update | 21:32 |
| jlk | so weird, no message winds up in any of the queues (queue count is 0) with the schedulers turned off | 21:33 |
| jlk | does c-vol put messages in the scheduler queue? | 21:33 |
| guitarzan | "Notifying Schedulers of capabilities" | 21:34 |
| guitarzan | it should | 21:34 |
| guitarzan | and you don't get the "Received volume service update from <blah>" messages in the scheduler log | 21:35 |
| jlk | well schedulers are turned off, so nothing in log yet | 21:36 |
| jlk | 2015-08-27 21:37:07.687 4797 DEBUG cinder.manager [-] Notifying Schedulers of capabilities ... _publish_service_capabilities /usr/local/lib/python2.7/dist-packages/cinder/manager.py:128 | 21:37 |
| jlk | 2015-08-27 21:37:07.688 4797 DEBUG oslo_messaging._drivers.amqp [-] UNIQUE_ID is 39b7043b4eef4d348037a7071fc302be. _add_unique_id /usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/amqp.py:226 | 21:37 |
| jlk | wait... | 21:38 |
| guitarzan | I'd check rabbit config on the schedulers | 21:38 |
| jlk | cinder-volume, does it ever directly write to the database? | 21:38 |
| guitarzan | I think so | 21:38 |
| jlk | because the updated_at line in the database keeps getting updated | 21:38 |
| jlk | I thought only cinder-scheduler and API wrote to the db | 21:39 |
| *** mriedem has quit IRC | 21:39 | |
| guitarzan | if only it was that clean | 21:39 |
| jgriffith | jlk: manager does most of the db access; and there are a number of drivers sadly that have snuck in db access as well | 21:40 |
| jlk | so it'd be driver specific? | 21:40 |
| *** crose has quit IRC | 21:40 | |
| openstackgerrit | Derrick Wippler proposed openstack/python-cinderclient: No longer ignores CINDER_SERVICE_NAME https://review.openstack.org/214802 | 21:40 |
| guitarzan | jlk: the service state stuff is not | 21:40 |
| jgriffith | jlk: so I have no idea what you guys have going on here... haven't been following; I was just answering the question about DB access :) | 21:41 |
| guitarzan | no talking between c-vol and c-sched | 21:41 |
| guitarzan | either direction | 21:41 |
| guitarzan | my guess is sched doesn't talk to rabbit | 21:41 |
| guitarzan | but that's just a guess | 21:41 |
| guitarzan | but he did say the sched log looked like it was doing creates | 21:42 |
| guitarzan | so who knows? | 21:42 |
| *** annegentle has quit IRC | 21:45 | |
| *** krtaylor has joined #openstack-cinder | 21:45 | |
| *** merooney has quit IRC | 21:49 | |
| *** rushil has quit IRC | 21:50 | |
| *** gouthamr has quit IRC | 21:51 | |
| jbernard | jungleboyj: ping re https://review.openstack.org/#/c/187270/21 | 21:53 |
| jbernard | jungleboyj: the rpc version, i assume the race looser would rebase | 21:53 |
| jungleboyj | jbernard: Correct. It was just a stream of consciousness kind of thing. That is where I am at today. | 21:53 |
| jungleboyj | :-) | 21:53 |
| jbernard | jungleboyj: gotcha, im there most days too | 21:54 |
| jungleboyj | :-) | 21:54 |
| jbernard | jungleboyj: gate fails on vmdk, hopefull a recheck will get me past that | 21:54 |
| jbernard | adn i think there's a problem happening with grenade | 21:54 |
| jbernard | im not particularly lucky today | 21:55 |
| jgriffith | guitarzan: but creates are casts no? In other words they just go into a black-hole | 21:55 |
| *** merooney has joined #openstack-cinder | 21:55 | |
| jbernard | jungleboyj: ill address the other suggestions with a patch update, thanks for the comments | 21:55 |
| jgriffith | guitarzan: from the schedulers perspective... although if you were correct then you'd probably see the no-valid hosts if nothing talkie talkie to each other | 21:55 |
| openstackgerrit | Jacob Gregor proposed openstack/cinder: Clean up line continuation in Storwize driver https://review.openstack.org/217933 | 21:56 |
| jgriffith | guitarzan: cuz there woudl be no services checking in with scheduler so he'd be hosed | 21:56 |
| guitarzan | jgriffith: yeah, casts do just disappear when there's no proper queue for them right? | 21:56 |
| *** rushil has joined #openstack-cinder | 21:56 | |
| jungleboyj | jbernard: Thanks for the update. Wasn't clear to me what was going on with the check failure. Thanks for addressing the other items. | 21:56 |
| jgriffith | guitarzan: I'd say yes, except the problem is it should never be cast, because it won't pass the filter to get that far to begin with | 21:56 |
| guitarzan | yeah, I can't see a simple reason it isn't working | 21:57 |
| guitarzan | jlk: do you have the sched logs from a create? | 21:57 |
| *** dflorea has joined #openstack-cinder | 21:57 | |
| jgriffith | guitarzan: so it sounds like the scheduler can "hear" the vol-service, but the vol-service can't hear the scheduler | 21:57 |
| jlk | guitarzan: jgriffith: so i think I might have a clue. It would appear that the host running cinder-volume is running juno code, and the hosts running cinder-api and cinder-scheduler are running havana code. | 21:57 |
| jgriffith | guitarzan: which is ez enough to see in the sched logs (look for updates from c-vol services) | 21:57 |
| jgriffith | jlk: yeah, that will certainly do it | 21:57 |
| *** merooney has quit IRC | 21:57 | |
| guitarzan | it's a little surprising that no errors or anything show up when speaking different languages | 21:58 |
| jlk | yeah it's totes weird | 21:59 |
| guitarzan | but I've never tried that, so I don't really know | 21:59 |
| *** mudassirlatif has quit IRC | 21:59 | |
| *** porrua has quit IRC | 22:00 | |
| *** gouthamr has joined #openstack-cinder | 22:01 | |
| *** gouthamr has quit IRC | 22:01 | |
| *** merooney has joined #openstack-cinder | 22:02 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Tests: Fix open mock in vmdk tests https://review.openstack.org/217936 | 22:02 |
| *** rhe00 has quit IRC | 22:02 | |
| *** merooney has quit IRC | 22:02 | |
| *** rushil has quit IRC | 22:04 | |
| *** IlyaG_ has quit IRC | 22:04 | |
| *** rushil has joined #openstack-cinder | 22:04 | |
| *** rushil_ has joined #openstack-cinder | 22:06 | |
| *** edtubill has left #openstack-cinder | 22:06 | |
| *** annegentle has joined #openstack-cinder | 22:07 | |
| *** IlyaG_ has joined #openstack-cinder | 22:08 | |
| *** IlyaG__ has joined #openstack-cinder | 22:09 | |
| *** rushil has quit IRC | 22:09 | |
| *** IlyaG_ has quit IRC | 22:12 | |
| *** rushil_ has quit IRC | 22:14 | |
| *** gouthamr has joined #openstack-cinder | 22:15 | |
| *** rushil has joined #openstack-cinder | 22:15 | |
| *** merooney has joined #openstack-cinder | 22:15 | |
| openstackgerrit | Danny Wilson proposed openstack/cinder: Fix delete_snapshot error case in Pure driver https://review.openstack.org/217940 | 22:16 |
| *** gouthamr has quit IRC | 22:16 | |
| *** rushil_ has joined #openstack-cinder | 22:16 | |
| *** martyturner has quit IRC | 22:17 | |
| *** mudassirlatif has joined #openstack-cinder | 22:19 | |
| *** rushil has quit IRC | 22:20 | |
| *** annegentle has quit IRC | 22:24 | |
| *** annegentle has joined #openstack-cinder | 22:25 | |
| *** adrianofr has quit IRC | 22:27 | |
| *** IlyaG__ has quit IRC | 22:27 | |
| *** annegentle has quit IRC | 22:29 | |
| *** dflorea has quit IRC | 22:30 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: WIP: Add new Connector APIs for path validation https://review.openstack.org/199764 | 22:30 |
| *** dflorea has joined #openstack-cinder | 22:31 | |
| *** merooney has quit IRC | 22:31 | |
| *** dflorea has quit IRC | 22:32 | |
| *** dflorea has joined #openstack-cinder | 22:33 | |
| *** dflorea has quit IRC | 22:35 | |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder-specs: Fix Get Volume Driver Capabilities Spec https://review.openstack.org/216394 | 22:36 |
| *** jungleboyj has quit IRC | 22:37 | |
| *** annegentle has joined #openstack-cinder | 22:39 | |
| *** dflorea has joined #openstack-cinder | 22:42 | |
| *** esker has joined #openstack-cinder | 22:42 | |
| openstackgerrit | Danny Wilson proposed openstack/cinder: Fix delete_snapshot error case in Pure driver https://review.openstack.org/217940 | 22:47 |
| *** thangp has quit IRC | 22:47 | |
| *** esker has quit IRC | 22:48 | |
| *** lcurtis has quit IRC | 22:49 | |
| *** edmondsw has quit IRC | 22:51 | |
| *** esker has joined #openstack-cinder | 22:51 | |
| *** esker has quit IRC | 22:56 | |
| *** gouthamr has joined #openstack-cinder | 22:58 | |
| *** setmason has quit IRC | 22:59 | |
| *** setmason has joined #openstack-cinder | 23:00 | |
| *** jwcroppe has quit IRC | 23:00 | |
| *** jwcroppe_ has joined #openstack-cinder | 23:03 | |
| *** rushil_ has quit IRC | 23:04 | |
| *** akerr is now known as akerr_away | 23:07 | |
| *** mriedem has joined #openstack-cinder | 23:08 | |
| *** jwcroppe_ has quit IRC | 23:09 | |
| *** jwcroppe has joined #openstack-cinder | 23:10 | |
| *** gouthamr has quit IRC | 23:11 | |
| *** hemna is now known as hemnafk | 23:12 | |
| *** akerr_away is now known as akerr | 23:12 | |
| *** bswartz has quit IRC | 23:13 | |
| *** akerr has quit IRC | 23:13 | |
| *** annegentle has quit IRC | 23:14 | |
| *** jwcroppe has quit IRC | 23:14 | |
| *** dims_ has joined #openstack-cinder | 23:18 | |
| *** takedakn has joined #openstack-cinder | 23:20 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/215440 | 23:21 |
| *** dims has quit IRC | 23:22 | |
| *** takedakn has quit IRC | 23:24 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-cinderclient: Updated from global requirements https://review.openstack.org/210918 | 23:25 |
| jlk | guitarzan: jgriffith: version mismatch between api/scheduler and volume was absolutely what was going on. | 23:27 |
| *** JebAka has quit IRC | 23:28 | |
| *** jaypipes has quit IRC | 23:31 | |
| *** dflorea has quit IRC | 23:33 | |
| *** bnemec has joined #openstack-cinder | 23:35 | |
| *** dims_ has quit IRC | 23:38 | |
| *** vilobhmm1 has quit IRC | 23:39 | |
| *** bill_az has joined #openstack-cinder | 23:39 | |
| *** vilobhmm1 has joined #openstack-cinder | 23:39 | |
| *** gouthamr has joined #openstack-cinder | 23:42 | |
| *** takedakn has joined #openstack-cinder | 23:43 | |
| *** mudassirlatif has quit IRC | 23:44 | |
| *** setmason has quit IRC | 23:44 | |
| *** vilobhmm1 has quit IRC | 23:46 | |
| *** mudassirlatif has joined #openstack-cinder | 23:46 | |
| *** dflorea has joined #openstack-cinder | 23:48 | |
| openstackgerrit | Anthony Lee proposed openstack/os-brick: Adding a tool that allows querying of LUNs https://review.openstack.org/204191 | 23:49 |
| *** setmason has joined #openstack-cinder | 23:52 | |
| *** dflorea has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!