| *** stevemar_ has joined #openstack-cinder | 00:00 | |
| *** EinstCrazy has quit IRC | 00:05 | |
| openstackgerrit | Zhang Jinnan proposed openstack/cinder: Volume extend error does not catch exception https://review.openstack.org/227971 | 00:05 |
|---|---|---|
| *** zhangjn has quit IRC | 00:17 | |
| *** dimsum__ has joined #openstack-cinder | 00:24 | |
| *** haomaiwang has joined #openstack-cinder | 00:31 | |
| *** dimsum__ has quit IRC | 00:31 | |
| *** haomaiwang has quit IRC | 00:35 | |
| *** chlong has joined #openstack-cinder | 00:51 | |
| *** diegows has quit IRC | 00:55 | |
| *** dimsum__ has joined #openstack-cinder | 00:57 | |
| *** mriedem is now known as mriedem_away | 00:59 | |
| *** dimsum__ has quit IRC | 01:00 | |
| *** EinstCrazy has joined #openstack-cinder | 01:03 | |
| *** zhangjn has joined #openstack-cinder | 01:05 | |
| *** gouthamr has quit IRC | 01:14 | |
| openstackgerrit | Zhang Jinnan proposed openstack/cinder: Volume extend error does not catch exception https://review.openstack.org/227971 | 01:16 |
| *** lixiaoy1 has joined #openstack-cinder | 01:17 | |
| *** dimsum__ has joined #openstack-cinder | 01:20 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Add hypermetro support for Huawei driver https://review.openstack.org/202023 | 01:22 |
| *** zhangjn_ has joined #openstack-cinder | 01:25 | |
| *** dimsum__ has quit IRC | 01:27 | |
| *** zhangjn has quit IRC | 01:28 | |
| *** dimsum__ has joined #openstack-cinder | 01:31 | |
| *** Lee1092 has joined #openstack-cinder | 01:35 | |
| *** zhenguo has joined #openstack-cinder | 01:36 | |
| *** ozialien has quit IRC | 01:37 | |
| *** ozialien has joined #openstack-cinder | 01:37 | |
| *** akshai_ has quit IRC | 01:41 | |
| *** changbl has joined #openstack-cinder | 01:46 | |
| *** haomaiwang has joined #openstack-cinder | 01:50 | |
| *** davechen has joined #openstack-cinder | 01:51 | |
| *** davechen1 has joined #openstack-cinder | 01:56 | |
| *** davechen has quit IRC | 01:58 | |
| *** zhangjn has joined #openstack-cinder | 01:59 | |
| *** davechen has joined #openstack-cinder | 02:00 | |
| *** baojg has joined #openstack-cinder | 02:01 | |
| *** akshai has joined #openstack-cinder | 02:02 | |
| *** davechen1 has quit IRC | 02:02 | |
| *** zhangjn_ has quit IRC | 02:02 | |
| *** p0rtal has quit IRC | 02:03 | |
| *** davechen1 has joined #openstack-cinder | 02:07 | |
| *** pots has joined #openstack-cinder | 02:07 | |
| *** davechen has quit IRC | 02:09 | |
| *** zhangjn has quit IRC | 02:10 | |
| *** davechen has joined #openstack-cinder | 02:12 | |
| *** zhangjn has joined #openstack-cinder | 02:13 | |
| *** p0rtal has joined #openstack-cinder | 02:14 | |
| *** vincent_hou has joined #openstack-cinder | 02:14 | |
| *** zhangjn has quit IRC | 02:14 | |
| *** davechen1 has quit IRC | 02:15 | |
| *** p0rtal has quit IRC | 02:15 | |
| *** p0rtal has joined #openstack-cinder | 02:16 | |
| *** chlong has quit IRC | 02:18 | |
| *** zhangjn has joined #openstack-cinder | 02:20 | |
| *** pots has quit IRC | 02:21 | |
| *** akshai has quit IRC | 02:22 | |
| *** pots has joined #openstack-cinder | 02:24 | |
| *** pots has quit IRC | 02:25 | |
| *** david-ly_ has joined #openstack-cinder | 02:31 | |
| *** dimsum__ has quit IRC | 02:32 | |
| *** david-lyle has quit IRC | 02:33 | |
| *** vincent_hou has quit IRC | 02:35 | |
| *** zhangjn has quit IRC | 02:44 | |
| *** zhangjn has joined #openstack-cinder | 02:46 | |
| *** baojg has quit IRC | 02:48 | |
| *** zhangjn has quit IRC | 02:48 | |
| *** baojg has joined #openstack-cinder | 02:51 | |
| *** zhangjn has joined #openstack-cinder | 03:00 | |
| *** tobe has joined #openstack-cinder | 03:04 | |
| *** cvstealth has quit IRC | 03:04 | |
| *** cvstealth has joined #openstack-cinder | 03:04 | |
| *** DericHorn-HP has joined #openstack-cinder | 03:06 | |
| *** julim has joined #openstack-cinder | 03:18 | |
| *** zhangjn has quit IRC | 03:22 | |
| *** zhangjn has joined #openstack-cinder | 03:23 | |
| *** zhangjn has quit IRC | 03:26 | |
| *** DericHorn-HP has quit IRC | 03:29 | |
| *** zhangjn has joined #openstack-cinder | 03:30 | |
| *** zhangjn has quit IRC | 03:32 | |
| *** chlong has joined #openstack-cinder | 03:32 | |
| *** dimsum__ has joined #openstack-cinder | 03:32 | |
| *** david-lyle has joined #openstack-cinder | 03:37 | |
| *** dimsum__ has quit IRC | 03:38 | |
| *** david-ly_ has quit IRC | 03:40 | |
| *** dimsum__ has joined #openstack-cinder | 03:40 | |
| *** dave-mccowan has quit IRC | 03:40 | |
| *** baojg has quit IRC | 03:44 | |
| *** RaySun has joined #openstack-cinder | 03:46 | |
| *** baojg has joined #openstack-cinder | 03:47 | |
| *** dimsum__ has quit IRC | 03:50 | |
| *** sgotliv has joined #openstack-cinder | 03:59 | |
| *** akshai has joined #openstack-cinder | 04:03 | |
| *** akshai has quit IRC | 04:08 | |
| *** zhangjn has joined #openstack-cinder | 04:08 | |
| *** zhangjn has quit IRC | 04:09 | |
| *** zhangjn has joined #openstack-cinder | 04:09 | |
| *** julim has quit IRC | 04:16 | |
| *** vgridnev has joined #openstack-cinder | 04:21 | |
| *** lixiaoy1 has quit IRC | 04:31 | |
| *** yangyapeng has joined #openstack-cinder | 04:34 | |
| *** vgridnev has quit IRC | 04:35 | |
| *** vgridnev has joined #openstack-cinder | 04:37 | |
| *** subscope has joined #openstack-cinder | 04:43 | |
| *** chlong has quit IRC | 04:45 | |
| *** dimsum__ has joined #openstack-cinder | 04:51 | |
| *** dimsum__ has quit IRC | 04:54 | |
| *** chlong has joined #openstack-cinder | 04:57 | |
| *** RaySun has quit IRC | 05:04 | |
| *** RaySun has joined #openstack-cinder | 05:05 | |
| *** lixiaoy1 has joined #openstack-cinder | 05:05 | |
| *** vgridnev has quit IRC | 05:05 | |
| *** RaySun_ has joined #openstack-cinder | 05:06 | |
| *** vgridnev has joined #openstack-cinder | 05:06 | |
| openstackgerrit | Abhishek Shrivastava proposed openstack/cinder: Setup error check & minor bug fix in CloudByte https://review.openstack.org/230068 | 05:06 |
| *** RaySun_ has quit IRC | 05:08 | |
| *** RaySun has quit IRC | 05:09 | |
| *** tsufiev_ has joined #openstack-cinder | 05:13 | |
| *** vgridnev has quit IRC | 05:13 | |
| *** vgridnev has joined #openstack-cinder | 05:17 | |
| *** vgridnev has quit IRC | 05:18 | |
| openstackgerrit | yogeshprasad proposed openstack/cinder: Retype support for CloudByte iSCSI cinder driver https://review.openstack.org/218645 | 05:20 |
| *** nkrinner has joined #openstack-cinder | 05:34 | |
| *** stevemar_ has quit IRC | 05:34 | |
| *** p0rtal has quit IRC | 05:35 | |
| *** deepakcs has joined #openstack-cinder | 05:48 | |
| *** baojg has quit IRC | 05:54 | |
| *** dimsum__ has joined #openstack-cinder | 05:54 | |
| *** stevemar_ has joined #openstack-cinder | 05:54 | |
| *** subscope has quit IRC | 05:54 | |
| *** dimsum__ has quit IRC | 05:59 | |
| *** lixiaoy1 has quit IRC | 06:01 | |
| openstackgerrit | Abhishek Shrivastava proposed openstack/cinder: Setup error check & minor bug fix in CloudByte https://review.openstack.org/230068 | 06:03 |
| *** BharatK has joined #openstack-cinder | 06:10 | |
| *** lixiaoy1 has joined #openstack-cinder | 06:11 | |
| *** shausy has joined #openstack-cinder | 06:14 | |
| *** kjelly has quit IRC | 06:14 | |
| *** kjelly has joined #openstack-cinder | 06:15 | |
| *** lixiaoy11 has joined #openstack-cinder | 06:20 | |
| *** lixiaoy1 has quit IRC | 06:22 | |
| *** ankit_ag has joined #openstack-cinder | 06:24 | |
| *** lixiaoy12 has joined #openstack-cinder | 06:27 | |
| *** lixiaoy11 has quit IRC | 06:27 | |
| *** stevemar_ has quit IRC | 06:27 | |
| *** vlaza has joined #openstack-cinder | 06:28 | |
| *** stevemar_ has joined #openstack-cinder | 06:28 | |
| *** subscope has joined #openstack-cinder | 06:29 | |
| *** stevemar_ has quit IRC | 06:33 | |
| *** lixiaoy1 has joined #openstack-cinder | 06:33 | |
| *** lixiaoy12 has quit IRC | 06:36 | |
| *** nikeshm has joined #openstack-cinder | 06:37 | |
| *** lixiaoy11 has joined #openstack-cinder | 06:38 | |
| *** subscope has quit IRC | 06:38 | |
| *** lixiaoy1 has quit IRC | 06:40 | |
| *** sgotliv has quit IRC | 06:42 | |
| *** chenying has joined #openstack-cinder | 06:51 | |
| *** dimsum__ has joined #openstack-cinder | 06:55 | |
| *** anshul has joined #openstack-cinder | 07:00 | |
| *** dimsum__ has quit IRC | 07:01 | |
| *** haypo has joined #openstack-cinder | 07:02 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API types extra specs to Python 3 https://review.openstack.org/232216 | 07:04 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port WSGI tests to Python 3 https://review.openstack.org/232214 | 07:04 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API to Python 3 https://review.openstack.org/232215 | 07:04 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API admin action tests to Python 3 https://review.openstack.org/232242 | 07:04 |
| *** anshul has quit IRC | 07:08 | |
| *** anshul has joined #openstack-cinder | 07:08 | |
| *** aix has joined #openstack-cinder | 07:10 | |
| *** ronis has joined #openstack-cinder | 07:21 | |
| *** dixiaoli has joined #openstack-cinder | 07:21 | |
| *** dixiaoli has quit IRC | 07:23 | |
| *** ronis has quit IRC | 07:29 | |
| *** ankit_ag has quit IRC | 07:29 | |
| *** ankit_ag has joined #openstack-cinder | 07:29 | |
| *** stevemar_ has joined #openstack-cinder | 07:29 | |
| *** stevemar_ has quit IRC | 07:34 | |
| *** chenying has quit IRC | 07:35 | |
| *** markus_z has joined #openstack-cinder | 07:37 | |
| *** ociuhandu has joined #openstack-cinder | 07:44 | |
| *** vgridnev has joined #openstack-cinder | 07:47 | |
| *** ndipanov has joined #openstack-cinder | 07:48 | |
| *** vincent_hou has joined #openstack-cinder | 07:48 | |
| vincent_hou | geguileo: Ping. | 07:49 |
| *** dimsum__ has joined #openstack-cinder | 07:57 | |
| *** markus_z has quit IRC | 07:58 | |
| *** vgridnev has quit IRC | 08:02 | |
| *** markus_z has joined #openstack-cinder | 08:02 | |
| *** dimsum__ has quit IRC | 08:02 | |
| *** vgridnev has joined #openstack-cinder | 08:03 | |
| *** wenjuan has joined #openstack-cinder | 08:06 | |
| wenjuan | hello,If i want to post code to cinder,should i apply for the authority on groups of review.openstack.org | 08:12 |
| *** vgridnev has quit IRC | 08:13 | |
| *** sgotliv has joined #openstack-cinder | 08:16 | |
| *** vgridnev has joined #openstack-cinder | 08:17 | |
| *** vgridnev has quit IRC | 08:19 | |
| dulek | wenjuan: https://wiki.openstack.org/wiki/How_To_Contribute#If_you.27re_a_developer | 08:20 |
| lixiaoy11 | wenjuan: https://wiki.openstack.org/wiki/How_To_Contribute | 08:20 |
| *** jordanP has joined #openstack-cinder | 08:21 | |
| lixiaoy11 | dulek: :) | 08:21 |
| dulek | lixiaoy11: ha, I was first ;) | 08:21 |
| dulek | lixiaoy11: (or maybe not, is IRC consistent when calculating dates? ;)) | 08:21 |
| *** bluex-pl has joined #openstack-cinder | 08:22 | |
| *** bluex-pl has quit IRC | 08:23 | |
| lixiaoy11 | dulek: in my view, I was first | 08:23 |
| *** bluex-pl has joined #openstack-cinder | 08:23 | |
| lixiaoy11 | (4:20:50 PM) lixiaoy1: wenjuan: https://wiki.openstack.org/wiki/How_To_Contribute | 08:23 |
| lixiaoy11 | (4:20:50 PM) dulek: wenjuan: https://wiki.openstack.org/wiki/How_To_Contribute#If_you.27re_a_developer | 08:23 |
| *** e0ne has joined #openstack-cinder | 08:24 | |
| lixiaoy11 | dulek: different views? :) | 08:24 |
| *** lpetrut has joined #openstack-cinder | 08:27 | |
| haypo | oh :-( cinder.tests.unit.test_misc.ExceptionTestCase.test_exceptions_raise() failed with 'KeyError: 0' on a python34 check job | 08:31 |
| *** ronis has joined #openstack-cinder | 08:31 | |
| haypo | ok, test_misc now fails with WebOb 1.5 :-/ | 08:34 |
| dulek | lixiaoy11: Different, so non-consistent. ;) | 08:35 |
| *** chlong has quit IRC | 08:35 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Fix test_misc for WebOb 1.5 https://review.openstack.org/233528 | 08:39 |
| haypo | please review ^^ https://review.openstack.org/233528 : the WebOb 1.5 release broke all gates using Cinder!! | 08:40 |
| *** shausy has quit IRC | 08:41 | |
| *** shausy has joined #openstack-cinder | 08:41 | |
| *** jistr has joined #openstack-cinder | 08:46 | |
| *** haomaiwang has quit IRC | 08:47 | |
| *** vgridnev has joined #openstack-cinder | 08:47 | |
| *** vgridnev has quit IRC | 08:47 | |
| *** haomaiwang has joined #openstack-cinder | 08:47 | |
| *** vgridnev has joined #openstack-cinder | 08:47 | |
| *** zhangjn has quit IRC | 08:51 | |
| *** zhangjn has joined #openstack-cinder | 08:52 | |
| *** jaypipes has joined #openstack-cinder | 08:52 | |
| *** vgridnev has quit IRC | 08:55 | |
| *** vgridnev has joined #openstack-cinder | 08:57 | |
| *** dimsum__ has joined #openstack-cinder | 08:58 | |
| *** aix has quit IRC | 08:58 | |
| *** BharatK has quit IRC | 08:58 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-cinder | 09:01 | |
| *** vincent_hou has quit IRC | 09:01 | |
| DuncanT | Any core about? Looks like we need to land https://review.openstack.org/233528 to clear up our gate | 09:03 |
| *** bluex-pl has quit IRC | 09:03 | |
| *** dimsum__ has quit IRC | 09:04 | |
| *** wenjuan has quit IRC | 09:04 | |
| *** bluex-pl has joined #openstack-cinder | 09:04 | |
| *** bluex-pl has quit IRC | 09:04 | |
| *** zhenguo has quit IRC | 09:06 | |
| *** bluex-pl has joined #openstack-cinder | 09:09 | |
| *** bluex-pl has quit IRC | 09:10 | |
| *** bluex-pl has joined #openstack-cinder | 09:11 | |
| *** bluex-pl has quit IRC | 09:11 | |
| *** bluex-pl has joined #openstack-cinder | 09:11 | |
| *** bluex-pl has quit IRC | 09:12 | |
| *** aix has joined #openstack-cinder | 09:12 | |
| *** bluex-pl has joined #openstack-cinder | 09:12 | |
| *** BharatK has joined #openstack-cinder | 09:13 | |
| haypo | DuncanT: hi. why do you want me to open a bug to modify a single line? | 09:21 |
| DuncanT | haypo: We try to have bugs or blueprints to track all changes. It makes it far easier to be consistent in applying that than to argue about exceptions | 09:21 |
| DuncanT | haypo: A bug takes two minutes to file, the arguments have been known to go on for days | 09:22 |
| *** vgridnev has quit IRC | 09:24 | |
| *** haypo has quit IRC | 09:25 | |
| *** haypo has joined #openstack-cinder | 09:26 | |
| haypo | DuncanT: hi. why do you want me to open a bug to modify a single line? (oops, i loose my irc connection :-/) | 09:26 |
| DuncanT | haypo: We try to have bugs or blueprints to track all changes. It makes it far easier to be consistent in applying that than to argue about exceptions | 09:26 |
| DuncanT | haypo: A bug takes two minutes to file, the arguments have been known to go on for days | 09:26 |
| e0ne | DuncanT: I'll +2 on it once CI passed | 09:27 |
| *** wilson-1 has joined #openstack-cinder | 09:27 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Fix test_misc for WebOb 1.5 https://review.openstack.org/233528 | 09:30 |
| *** wilson1 has quit IRC | 09:31 | |
| DuncanT | e0ne: It's got my +2 on it now, you can push it through when you're happy | 09:33 |
| DuncanT | haypo: Thanks for the update | 09:33 |
| haypo | e0ne: you can test the patch locally. it's obviosu that test_misc fails without my change. at least on my PC, it pass with the change :) | 09:34 |
| haypo | DuncanT: why not only discussing a change in the change directly? what's the advantage of splitting the discussion between two tools (gerrit and launchpad)? | 09:34 |
| e0ne | haypo: I feel a bit uncomfortable to +A on patch w/o CI | 09:35 |
| haypo | e0ne: a patch cannot be merged if the CI fails | 09:35 |
| e0ne | haypo: Zuul's ETA is 15 minutes | 09:36 |
| haypo | e0ne: the CI must pass twice on a patch to merge the change, no? | 09:36 |
| DuncanT | haypo: At the moment, the only advantage is consistency with every other patch. If there are good reasons to change that, great, but right now we do things to way we do them. One direct answer to your question is that sometimes there is more than one way to fix a bug, so competing patches get posted - having a bug lets us track that | 09:37 |
| DuncanT | haypo: That doesn't stop duplicate bugs, but some people try to stay on top of that | 09:37 |
| haypo | DuncanT: hum ok | 09:37 |
| DuncanT | haypo: There's a Tokyo session for discussing beaurocracy in cinder, contributions and comments welcome | 09:38 |
| haypo | i'm not a fan of meeting about burocracy :) | 09:40 |
| *** zhangjn has quit IRC | 09:40 | |
| *** zhangjn has joined #openstack-cinder | 09:41 | |
| DuncanT | haypo: If you think there's something we can cut down on, comment on the etherpad if you don't want to attend - I'll ensure anything you add gets raised | 09:42 |
| haypo | DuncanT: the rule should be never open a bug, only open a bug when there are multiple changes for the same thing | 09:44 |
| haypo | i want to reduce the burocraty. i don't see how attending a meeting on burocraty would solve the issue | 09:44 |
| DuncanT | haypo: Attending the meeting helps because there are reasons why we have the processes we have, and so getting people together who know those reasons helps up reduce the processes *without* re-introducing the problems that the processes were designed to fix | 09:46 |
| DuncanT | haypo: For example, bugs are used to report a problem, since the person who found the problem very often doesn't have the knowledge to fix it | 09:46 |
| DuncanT | haypo: If we always open bugs then people who find problems (who outnumber, and are usually less technically adept then the bug fixers) only have one place to go | 09:47 |
| haypo | DuncanT: i'm not talking about opening a bug report when you hit a bug. i'm talking about the requirement to open a bug report to fix a bug. the commit message can be long enough to explain the bug, the fix, etc. and gerrit is a nice place for discussion | 09:47 |
| DuncanT | haypo: What happens to the other ten people who find the same problem? We end up with ten gerrit reviews that aren't linked together? | 09:48 |
| DuncanT | haypo: Our current record is four parallel submissions, I think | 09:48 |
| haypo | DuncanT: how does launchpad prevent duplicates? maybe it's an issue in the gerrit tool :-p | 09:49 |
| *** ociuhandu has quit IRC | 09:49 | |
| DuncanT | haypo: And for the people who don't know to search gerrit (which is far from easy, or standard to search), they're stuck not knowing that this is a known issue being worked on | 09:49 |
| *** haomaiwang has quit IRC | 09:50 | |
| haypo | i don't think that it's so common to write a similar patch to fix the same bug | 09:50 |
| *** chlong has joined #openstack-cinder | 09:50 | |
| DuncanT | haypo: It has happened a good few times... search the abandoned patch list | 09:50 |
| *** haomaiwang has joined #openstack-cinder | 09:50 | |
| haypo | ok | 09:51 |
| *** vgridnev has joined #openstack-cinder | 09:52 | |
| *** lixiaoy11 has quit IRC | 09:52 | |
| *** bluex-pl has quit IRC | 09:53 | |
| *** davechen has left #openstack-cinder | 09:54 | |
| haypo | e0ne, DuncanT : FYI my fear is that all gates of all projects are broken by cinder, that's why i consider that my fix must be merged quickly | 09:58 |
| DuncanT | haypo: It will be merged now as soon as it passes CI | 09:58 |
| DuncanT | haypo: We can't go any faster than jenkins. | 09:58 |
| *** marzif has joined #openstack-cinder | 09:58 | |
| haypo | DuncanT: i'm replying to "e0ne> haypo: I feel a bit uncomfortable to +A on patch w/o CI" and "Duncan: Patch Set 1: -Code-Review. Can you file a bug for this please (...)" | 09:59 |
| *** dimsum__ has joined #openstack-cinder | 10:00 | |
| haypo | well, it doesn't matter so much | 10:00 |
| DuncanT | haypo: History has shown us that skipping process for perceived urgency causes us pain | 10:00 |
| *** haomaiwang has quit IRC | 10:01 | |
| *** zhangjn has quit IRC | 10:01 | |
| *** yangyapeng has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-cinder | 10:01 | |
| *** EinstCrazy has quit IRC | 10:01 | |
| *** dimsum__ has quit IRC | 10:06 | |
| *** e0ne_ has joined #openstack-cinder | 10:06 | |
| *** e0ne has quit IRC | 10:09 | |
| *** aarefiev has quit IRC | 10:10 | |
| dulek | haypo: One good thing about using Launchpad is that you can get email notifications on bugs without all the Gerrit's noise (Jenkins, Third Party CIs, nitpicking comments). | 10:11 |
| *** aarefiev has joined #openstack-cinder | 10:14 | |
| *** e0ne_ has quit IRC | 10:14 | |
| *** vgridnev has quit IRC | 10:15 | |
| *** BharatK has quit IRC | 10:17 | |
| *** e0ne has joined #openstack-cinder | 10:19 | |
| *** vgridnev has joined #openstack-cinder | 10:24 | |
| *** BharatK has joined #openstack-cinder | 10:30 | |
| *** takedakn has joined #openstack-cinder | 10:34 | |
| *** zerda has joined #openstack-cinder | 10:37 | |
| *** vgridnev has quit IRC | 10:39 | |
| *** vgridnev has joined #openstack-cinder | 10:40 | |
| *** haomaiwang has quit IRC | 10:46 | |
| *** haomaiwa_ has joined #openstack-cinder | 10:49 | |
| *** vgridnev has quit IRC | 10:55 | |
| *** IanGovett has joined #openstack-cinder | 10:56 | |
| *** ociuhandu has joined #openstack-cinder | 10:56 | |
| *** zhangjn has joined #openstack-cinder | 10:57 | |
| *** EinstCrazy has joined #openstack-cinder | 10:58 | |
| *** vgridnev has joined #openstack-cinder | 10:59 | |
| *** EinstCrazy has quit IRC | 10:59 | |
| *** EinstCrazy has joined #openstack-cinder | 11:00 | |
| *** bluex-pl has joined #openstack-cinder | 11:00 | |
| *** vgridnev has quit IRC | 11:00 | |
| *** vgridnev has joined #openstack-cinder | 11:00 | |
| *** haomaiwa_ has quit IRC | 11:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 11:01 | |
| *** dimsum__ has joined #openstack-cinder | 11:01 | |
| *** tobe has quit IRC | 11:06 | |
| *** tobe has joined #openstack-cinder | 11:06 | |
| *** dimsum__ has quit IRC | 11:07 | |
| *** vgridnev has quit IRC | 11:09 | |
| *** vgridnev has joined #openstack-cinder | 11:14 | |
| *** tobe has quit IRC | 11:15 | |
| *** tobe has joined #openstack-cinder | 11:16 | |
| *** dimsum__ has joined #openstack-cinder | 11:22 | |
| *** haomaiwa_ has quit IRC | 11:28 | |
| *** haomaiwang has joined #openstack-cinder | 11:28 | |
| *** stevemar_ has joined #openstack-cinder | 11:31 | |
| *** e0ne has quit IRC | 11:31 | |
| *** stevemar_ has quit IRC | 11:35 | |
| openstackgerrit | Zhang Jinnan proposed openstack/cinder: Volume extend error does not catch exception https://review.openstack.org/227971 | 11:37 |
| *** dave-mccowan has joined #openstack-cinder | 11:40 | |
| *** haomaiwang has quit IRC | 11:47 | |
| *** haomaiwang has joined #openstack-cinder | 11:48 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Implement snapshots-related features for Block Device Driver https://review.openstack.org/222292 | 11:52 |
| *** vgridnev has quit IRC | 11:56 | |
| *** julim has joined #openstack-cinder | 11:59 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** haomaiwang has joined #openstack-cinder | 12:01 | |
| *** rushil has joined #openstack-cinder | 12:04 | |
| *** e0ne has joined #openstack-cinder | 12:19 | |
| *** zerda has quit IRC | 12:19 | |
| *** vgridnev has joined #openstack-cinder | 12:20 | |
| *** haomaiwang has quit IRC | 12:24 | |
| *** markvoelker has joined #openstack-cinder | 12:26 | |
| *** vgridnev has quit IRC | 12:27 | |
| *** Yogi1 has joined #openstack-cinder | 12:28 | |
| e0ne | DuncanT: hi again. will you have few minutes to chact about brick-client (volume attachment w/o nova)? | 12:32 |
| DuncanT | e0ne: Sure | 12:33 |
| DuncanT | e0ne: Got a meeting in 30 minutes, that will last about 30 minutes. Other than that, any time | 12:33 |
| nikeshm | xyang: hi | 12:35 |
| e0ne | DuncanT: I've got poc for iscsi and rbd attachement. we need to make it pluguble or just add "try-catch ImportError" statements fo attache volumes using different protocols | 12:36 |
| *** vgridnev has joined #openstack-cinder | 12:36 | |
| e0ne | DuncanT: e.g. to attach ceph volume via RBD protocol, user need to have installed ceph-common package and enabled kernel module | 12:36 |
| *** edmondsw has joined #openstack-cinder | 12:36 | |
| *** diablo_rojo has joined #openstack-cinder | 12:37 | |
| *** vgridnev has quit IRC | 12:38 | |
| DuncanT | I'd add try-catch with appropriate errors for things that need to be installed | 12:38 |
| DuncanT | iSCSI needs the appropriate kernel and userspace too | 12:38 |
| *** timcl has joined #openstack-cinder | 12:40 | |
| e0ne | DuncanT: so, will we need to cover iSCSI stuff in try-catch too? | 12:41 |
| nikeshm | xyang: In liberty, for taking a backup of a attached volume, we are either creating a temporary snapshot or temporary volume. What is need of temporary snapshot or volume? | 12:41 |
| DuncanT | e0ne: I don't think there's any harm in it, and it puts RBD and iSCSI on an equal footing - nothing you don't need to operate needs to be installed | 12:42 |
| nikeshm | xyang: is taking backup from a temporary snapshot is application consistent? | 12:42 |
| DuncanT | nikeshm: It is to provide generic support, where the driver hasn't implemented attach_snapshot | 12:42 |
| DuncanT | nikeshm: A snap is needed for live backup for consistency, yes | 12:43 |
| e0ne | DuncanT: agree. I still want to have minimum requirements list. | 12:43 |
| *** deepakcs has quit IRC | 12:43 | |
| DuncanT | e0ne: Whatever makes sense to you - we can tidy it later if needed. Setting a good tone from the beginning is useful though | 12:43 |
| DuncanT | nikeshm: Backing up a live, changing block device is never going to give you anything useful | 12:44 |
| *** gouthamr has joined #openstack-cinder | 12:44 | |
| nikeshm | DuncanT: i have a confusion in crash consistent and application consistent, | 12:44 |
| e0ne | DuncanT: I'm worried how Ironic guys will use it. IMO, we need to tolk about it with them | 12:44 |
| DuncanT | nikeshm: cinder can only do crash consistent by itself | 12:44 |
| DuncanT | e0ne: We definitely need to talk to them, it's easier to do with a PoC though | 12:45 |
| e0ne | DuncanT: I'll cleanup my PoC's code and will bring it to the IRC/ML later this week | 12:47 |
| haypo | ooook, my fix for cinder gates has been merged, cool: https://review.openstack.org/#/c/233528/ "Fix test_misc for WebOb 1.5" | 12:47 |
| DuncanT | Let the rechecks commence | 12:48 |
| nikeshm | DuncanT: is it not possible to call nova apis from cinder which would do fsFreeze before taking a backup of a attached volume | 12:48 |
| DuncanT | e0ne: Sounds like a plan | 12:48 |
| e0ne | thanks | 12:49 |
| *** pots has joined #openstack-cinder | 12:49 | |
| e0ne | DuncanT: after getting some feedback, probably we need to have Cinder-Ironic liaisons. | 12:49 |
| e0ne | smcginnis: ^^ | 12:50 |
| DuncanT | e0ne: I guess so. We should sort basic CI too | 12:52 |
| *** ronis has quit IRC | 12:59 | |
| *** nkrinner is now known as nkrinner_afk | 13:00 | |
| *** cbader has joined #openstack-cinder | 13:00 | |
| *** lpabon has joined #openstack-cinder | 13:01 | |
| *** ronis has joined #openstack-cinder | 13:03 | |
| nikeshm | DuncanT: any thoughts | 13:04 |
| *** mc_nair has joined #openstack-cinder | 13:06 | |
| DuncanT | nikeshm: Do those nova APIs exist? | 13:07 |
| *** breitz has joined #openstack-cinder | 13:07 | |
| *** dustins has joined #openstack-cinder | 13:08 | |
| *** dustins has quit IRC | 13:08 | |
| *** porrua has joined #openstack-cinder | 13:08 | |
| *** xyang1 has joined #openstack-cinder | 13:09 | |
| johnthetubaguy | DuncanT: nikeshm: e0ne: I think I saw a spec to add those APIs, although I am unsure how well exposing those would work in practice (due to timeouts in the underlying calls, etc) | 13:10 |
| DuncanT | johnthetubaguy: Might be best to allow people to try to orchestrate it externally initially, see if there is actually any need for cinder integration | 13:11 |
| *** martyturner has joined #openstack-cinder | 13:14 | |
| nikeshm | live vm snapshot in nova uses fsFreeze https://github.com/openstack/nova/blob/f2e2a5891d5f5ff9346e6dc8e4dd0e994485245c/nova/virt/libvirt/driver.py#L1505 | 13:15 |
| *** mriedem has joined #openstack-cinder | 13:15 | |
| johnthetubaguy | nikeshm: yes, we use fsFreeze, but there is not REST API to call that directly | 13:15 |
| johnthetubaguy | DuncanT: yeah, that makes sense, I think its group of VMs that folks are the most worried about right now | 13:16 |
| nikeshm | johnthetubaguy: you said about a spec, do you have link? | 13:17 |
| *** mriedem_away has quit IRC | 13:17 | |
| *** annasort has joined #openstack-cinder | 13:17 | |
| johnthetubaguy | nikeshm: I looked in my list of specs, and I can't find it right now, sorry | 13:18 |
| nikeshm | johnthetubaguy: ok , if you find please share | 13:19 |
| nikeshm | :) | 13:19 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Fix Status-Line in HTTP response https://review.openstack.org/231438 | 13:19 |
| *** martyturner has quit IRC | 13:20 | |
| *** martyturner has joined #openstack-cinder | 13:22 | |
| *** martyturner has quit IRC | 13:23 | |
| smcginnis | e0ne: Are you volunteering to be an ironic liason? :) | 13:24 |
| smcginnis | DuncanT: Weren't you doing a lot with ironic for a while there/ | 13:24 |
| smcginnis | ? | 13:24 |
| *** martyturner has joined #openstack-cinder | 13:24 | |
| e0ne | smcginnis: we need to discuss it. DuncanT and hemna are good candidates too | 13:25 |
| *** lcurtis has joined #openstack-cinder | 13:25 | |
| smcginnis | e0ne: Good. Want to put something on the meeting agenda to make sure we cover it? | 13:25 |
| smcginnis | https://wiki.openstack.org/wiki/CinderMeetings | 13:25 |
| smcginnis | Or at least start discussing it. | 13:26 |
| *** jungleboyj has joined #openstack-cinder | 13:26 | |
| *** dimsum__ is now known as dims | 13:27 | |
| *** dims is now known as Guest2821 | 13:27 | |
| *** ankit_ag has quit IRC | 13:28 | |
| *** merooney has joined #openstack-cinder | 13:29 | |
| DuncanT | smcginnis: I was for a while, moved on though | 13:30 |
| smcginnis | DuncanT: OK, cool. | 13:30 |
| DuncanT | smcginnis: I think hemna is doing a fair bit right now. I might be again in a few months | 13:30 |
| *** haomaiwang has joined #openstack-cinder | 13:31 | |
| *** stevemar_ has joined #openstack-cinder | 13:32 | |
| *** shausy has quit IRC | 13:34 | |
| *** jgregor has joined #openstack-cinder | 13:34 | |
| *** gouthamr has quit IRC | 13:35 | |
| *** Guest2821 is now known as dims__ | 13:35 | |
| *** gouthamr has joined #openstack-cinder | 13:36 | |
| *** stevemar_ has quit IRC | 13:36 | |
| *** BharatK has quit IRC | 13:36 | |
| *** william has joined #openstack-cinder | 13:39 | |
| *** william is now known as Guest4123 | 13:40 | |
| *** juzuluag has joined #openstack-cinder | 13:42 | |
| *** eharney has joined #openstack-cinder | 13:48 | |
| *** superdan is now known as dansmith | 13:48 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Update config format for replication_devices https://review.openstack.org/233307 | 13:49 |
| *** BharatK has joined #openstack-cinder | 13:51 | |
| *** vgridnev has joined #openstack-cinder | 13:51 | |
| *** brad[] has joined #openstack-cinder | 13:53 | |
| *** diablo_rojo1 has joined #openstack-cinder | 13:56 | |
| *** diablo_rojo has quit IRC | 13:56 | |
| openstackgerrit | Matt Riedemann proposed openstack/cinder: windows: don't use LOG.exception if not logging an exception https://review.openstack.org/233644 | 13:57 |
| *** lprice1 has quit IRC | 13:59 | |
| *** martyturner has quit IRC | 13:59 | |
| *** haomaiwang has quit IRC | 14:01 | |
| *** martyturner has joined #openstack-cinder | 14:01 | |
| *** haomaiwang has joined #openstack-cinder | 14:01 | |
| *** dims__ has quit IRC | 14:01 | |
| *** dims__ has joined #openstack-cinder | 14:02 | |
| *** jungleboyj has quit IRC | 14:04 | |
| *** vgridnev has quit IRC | 14:07 | |
| *** vgridnev has joined #openstack-cinder | 14:07 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Move ssh_utils tests to test_ssh_utils https://review.openstack.org/229947 | 14:08 |
| *** BharatK has quit IRC | 14:12 | |
| *** dustins has joined #openstack-cinder | 14:14 | |
| *** pots has quit IRC | 14:14 | |
| *** krotscheck has joined #openstack-cinder | 14:14 | |
| *** tobe has quit IRC | 14:16 | |
| *** tobe has joined #openstack-cinder | 14:19 | |
| *** nikeshm has quit IRC | 14:22 | |
| smcginnis | mriedem: ping | 14:22 |
| smcginnis | mriedem: Is this a dupe of the new one you filed? | 14:23 |
| smcginnis | mriedem: https://bugs.launchpad.net/cinder/+bug/1504735 | 14:23 |
| openstack | Launchpad bug 1504735 in Cinder "There is no need to use LOG.exception when no exception handler is used" [Undecided,New] - Assigned to chenying (ying-chen) | 14:23 |
| *** ntpttr has joined #openstack-cinder | 14:23 | |
| *** garthb has joined #openstack-cinder | 14:28 | |
| mriedem | looks the same, i didn't find any previous bugs before opening mine | 14:31 |
| *** takedakn has quit IRC | 14:31 | |
| mriedem | smcginnis: different failure points though | 14:31 |
| mriedem | this bug isn't in the windows vhdutils stuff | 14:31 |
| smcginnis | mriedem: True | 14:32 |
| smcginnis | I think I'll do some grepping to see if there's anywhere else we are using LOG.exception we shouldn't be. | 14:32 |
| *** haomaiwang has quit IRC | 14:35 | |
| *** vlaza has quit IRC | 14:35 | |
| *** haomaiwang has joined #openstack-cinder | 14:38 | |
| *** diablo_rojo1 has quit IRC | 14:39 | |
| *** jgregor has quit IRC | 14:40 | |
| *** lprice has joined #openstack-cinder | 14:42 | |
| e0ne | DuncanT, haypo: are we going to backport webob fix to liberty? I've reproduced it locally on the stable/liberty brancj | 14:42 |
| *** asselin_ has joined #openstack-cinder | 14:42 | |
| *** tpeoples has joined #openstack-cinder | 14:42 | |
| DuncanT | e0ne: I think we need to, yes | 14:43 |
| openstackgerrit | oliver-leahy-l proposed openstack/cinder: encryption_api_url requires a version https://review.openstack.org/230031 | 14:44 |
| *** takedakn has joined #openstack-cinder | 14:44 | |
| smcginnis | DuncanT, e0ne, haypo: That only affect unit tests, right? | 14:44 |
| smcginnis | No need to try to quick cut a new RC... | 14:45 |
| e0ne | smcginnis: unit tests and almost each vendor CI | 14:45 |
| *** pots has joined #openstack-cinder | 14:46 | |
| *** edtubill has joined #openstack-cinder | 14:47 | |
| *** takedakn has quit IRC | 14:47 | |
| *** nikeshm has joined #openstack-cinder | 14:48 | |
| smcginnis | e0ne: Thanks | 14:48 |
| e0ne | smcginnis: np | 14:49 |
| *** edmondsw has quit IRC | 14:49 | |
| *** kurtmartin has joined #openstack-cinder | 14:52 | |
| *** edmondsw has joined #openstack-cinder | 14:53 | |
| *** mtanino has joined #openstack-cinder | 14:53 | |
| e0ne | cherry-picked to Liberty https://review.openstack.org/#/c/233668/ | 14:54 |
| *** lpetrut has quit IRC | 14:56 | |
| smcginnis | zigo, eharney: Will this cause packaging issues? https://review.openstack.org/#/c/233668/ | 14:56 |
| *** changbl has quit IRC | 14:56 | |
| smcginnis | zigo, eharney: Only affects unit tests, but I know zigo said that's part of the packaging process. | 14:56 |
| eharney | smcginnis: seems fine to me, just a regular test fix | 14:57 |
| smcginnis | eharney: Cool, thanks. | 14:58 |
| *** daneyon has joined #openstack-cinder | 14:58 | |
| *** haomaiwang has quit IRC | 15:01 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Tox fast8: use pep8 env dir https://review.openstack.org/233673 | 15:01 |
| *** salv-orlando has joined #openstack-cinder | 15:01 | |
| *** haomaiwang has joined #openstack-cinder | 15:01 | |
| *** daneyon_ has joined #openstack-cinder | 15:01 | |
| *** sgundur has joined #openstack-cinder | 15:03 | |
| *** HenryG_ is now known as HenryG | 15:03 | |
| *** daneyon has quit IRC | 15:04 | |
| *** anshul has quit IRC | 15:06 | |
| *** ronis has quit IRC | 15:06 | |
| *** thangp has joined #openstack-cinder | 15:09 | |
| *** aarefiev has quit IRC | 15:10 | |
| *** diablo_rojo has joined #openstack-cinder | 15:13 | |
| *** jungleboyj has joined #openstack-cinder | 15:14 | |
| *** bill_az has joined #openstack-cinder | 15:15 | |
| *** harlowja_at_home has joined #openstack-cinder | 15:19 | |
| *** rhagarty__ has joined #openstack-cinder | 15:20 | |
| *** jdurgin1 has joined #openstack-cinder | 15:21 | |
| *** rhagarty_ has quit IRC | 15:22 | |
| *** markus_z has quit IRC | 15:22 | |
| *** diogogmt has joined #openstack-cinder | 15:24 | |
| *** asselin_ has quit IRC | 15:26 | |
| *** mriedem is now known as mriedem_away | 15:26 | |
| hemna | who ordered a Monday ? | 15:26 |
| *** asselin_ has joined #openstack-cinder | 15:26 | |
| diablo_rojo | hemna: Not me | 15:27 |
| *** rushil has quit IRC | 15:34 | |
| *** nikeshm has quit IRC | 15:36 | |
| jgriffith | DuncanT: curious, do you guys see similar race issues with Nova that you see with Cinder? | 15:39 |
| jgriffith | DuncanT: or do their mechanisms seem to work better | 15:40 |
| *** tobe has quit IRC | 15:40 | |
| johnthetubaguy | jgriffith: which are the race issues that are causing issues? | 15:40 |
| DuncanT | jgriffith: There were races in nova, not looked at them for, erm, a couple of years now I guess | 15:40 |
| jgriffith | johnthetubaguy: quite the opposite :) | 15:40 |
| jgriffith | johnthetubaguy: I'm asking if there "are" issues | 15:40 |
| DuncanT | jgriffith: I'll ask the nova team. It would certainly be interested to see how they fixed them | 15:41 |
| jgriffith | johnthetubaguy: the reason I'm asking... is there's what's turning into a signficiant rewrite of all of the Cinder code to address reaces | 15:41 |
| jgriffith | johnthetubaguy: I've been poking at Nova and it's use of the lock deocrator and instance state object | 15:41 |
| jgriffith | johnthetubaguy: I'm wondering if that would be safer/more effective | 15:42 |
| johnthetubaguy | jgriffith: ah, OK, we got rid of most of them, there are few different strategies depending on the issue | 15:42 |
| *** rushil has joined #openstack-cinder | 15:42 | |
| jgriffith | johnthetubaguy: I'm also wondering why folks on the Cinder side have stated that lock files can't be cleaned/removed | 15:42 |
| jgriffith | johnthetubaguy: I'd be interested in learning more about your experiences | 15:43 |
| jgriffith | johnthetubaguy: I pinged dansmith earlier but he's in meetings most of the morning. Will probably bug him again later :) | 15:43 |
| johnthetubaguy | not sure we use lock files, I think they are greenlet ones by default, using the olso stuff, so I stopped worring how its done | 15:43 |
| johnthetubaguy | so there are lots of things we do in different cases really | 15:44 |
| johnthetubaguy | stuff thats owned by a compute, we can do that local lock, its in memory I believe | 15:44 |
| johnthetubaguy | for some DB stuff, we are moving torwards compare and swap updates with retries | 15:44 |
| jgriffith | johnthetubaguy: ok, so that's the same direction Cinder is on right now | 15:45 |
| jgriffith | johnthetubaguy: I was tracing through this: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1901 | 15:45 |
| jgriffith | johnthetubaguy: in the outer API on through | 15:45 |
| johnthetubaguy | the scheduler and node stuff, its more retries right now, but cooking up some new ways | 15:46 |
| jgriffith | johnthetubaguy: seem effective | 15:46 |
| *** sgotliv has quit IRC | 15:46 | |
| jgriffith | johnthetubaguy: ahh... yeah, different issues like you mentioned | 15:46 |
| johnthetubaguy | jgriffith: it works, its not perfect, you can get issues with long running tasks getting paused | 15:46 |
| jgriffith | johnthetubaguy: makes sense... fortunately those are a bit limited for us | 15:47 |
| jgriffith | johnthetubaguy: backups and copying images/volumes | 15:47 |
| johnthetubaguy | yeah, we do have state based locking in the API too | 15:47 |
| johnthetubaguy | locking is an overly strong word | 15:48 |
| jgriffith | johnthetubaguy: but if yall have the swap/compare approach in progress as well then perhaps I am not *as* concerned | 15:48 |
| jgriffith | johnthetubaguy: weak-locks? | 15:48 |
| johnthetubaguy | well it just checks the current state to make sure its as expected in the DB | 15:48 |
| johnthetubaguy | just a quick check, and then updates it | 15:48 |
| jgriffith | johnthetubaguy: ahh... yeah, that's our current strategy on most things | 15:49 |
| johnthetubaguy | lots of the instance.save() commands take an expected state, to do the same thing | 15:49 |
| johnthetubaguy | yeah, the pattern hasn't changed much | 15:49 |
| jgriffith | johnthetubaguy: yeah, Nova seems to have some nicer helper/wrapper functions around it, but we have the same principal | 15:49 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API types extra specs to Python 3 https://review.openstack.org/232216 | 15:49 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port WSGI tests to Python 3 https://review.openstack.org/232214 | 15:49 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API to Python 3 https://review.openstack.org/232215 | 15:49 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API admin action tests to Python 3 https://review.openstack.org/232242 | 15:49 |
| jgriffith | johnthetubaguy: I think my problem with lockfiles in Cinder is mostly just that they're in the wrong place | 15:50 |
| jgriffith | johnthetubaguy: they're in the manager.. ie on the other side of the RPC call which introduces latencies and more problems | 15:50 |
| jgriffith | johnthetubaguy: although in most cases the db update checks seem "ok" | 15:51 |
| jgriffith | johnthetubaguy: do you folks have somebody actively working on the compare/swap implementations? | 15:51 |
| johnthetubaguy | jgriffith: I think we use both | 15:52 |
| johnthetubaguy | jgriffith: I think jaypipes has the most context on compare and swap, I don't remember where we applied that now | 15:52 |
| jgriffith | johnthetubaguy: yeah.... we use both the db state check and the locks | 15:53 |
| jgriffith | johnthetubaguy: we do db state checks in the cinder/volume/api.py then do locks in a couple places in the manager | 15:53 |
| jgriffith | johnthetubaguy: ahhh http://www.joinfu.com/2015/01/understanding-reservations-concurrency-locking-in-nova/ | 15:54 |
| jgriffith | I'll read a bit :) | 15:54 |
| ntpttr | Hey everyone, I'm running tox on a fresh clone of cinder in devstack, and every test is failing telling me "'str' object has no attribute 'DEALER'". Anyone else run into this problem? | 15:54 |
| jgriffith | johnthetubaguy: thanks for the input! | 15:54 |
| johnthetubaguy | jgriffith: no worries, happy to help | 15:55 |
| johnthetubaguy | jgriffith: finding the race is the hard bit, usually :) | 15:55 |
| jgriffith | johnthetubaguy: yah, not something I claim to be good at | 15:55 |
| *** apoorvad has joined #openstack-cinder | 15:55 | |
| jgriffith | johnthetubaguy: my concern is we seem to be on a path now where we say "every/any" db status update is a race | 15:56 |
| johnthetubaguy | jgriffith: ah, yeah, gotcha | 15:56 |
| jgriffith | ntpttr: werid | 15:57 |
| jgriffith | ntpttr: let me try it in a clean env | 15:58 |
| eharney | ntpttr: i just saw that in some nova tests actually, it's related to oslo_messaging / zeromq imports | 15:58 |
| ntpttr | eharney: Yeah, that what the traceback is showing me too | 15:58 |
| * jgriffith now thinks maybe he shouldn't have updated his env :) | 15:58 | |
| eharney | some new library must have updated and broken something | 15:58 |
| jgriffith | pyinotify ? | 15:59 |
| *** pots3 has joined #openstack-cinder | 15:59 | |
| *** haomaiwang has quit IRC | 16:01 | |
| *** haomaiwang has joined #openstack-cinder | 16:01 | |
| ntpttr | eharney, jgriffith: Here's the traceback from every test: http://paste.openstack.org/show/476035/ | 16:01 |
| *** zhangjn has quit IRC | 16:01 | |
| jgriffith | ntpttr: I can't help right now, I can even build an env with the addition of pyinotify :( | 16:02 |
| *** pots has quit IRC | 16:03 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Remove 'refresh' parameter from driver get_stats https://review.openstack.org/233328 | 16:05 |
| *** haypo has left #openstack-cinder | 16:08 | |
| *** salv-orl_ has joined #openstack-cinder | 16:09 | |
| *** ronis has joined #openstack-cinder | 16:12 | |
| *** salv-orlando has quit IRC | 16:13 | |
| *** IanGovett has quit IRC | 16:13 | |
| DuncanT | jgriffith: A good way to find races is to write client code that doesn't check the status of volumes before doing stuff on them, then add sleeps in random places in API, c-vol and your driver | 16:13 |
| jgriffith | DuncanT: sure | 16:14 |
| *** leeantho has joined #openstack-cinder | 16:15 | |
| ntpttr | Looks like the error is happening in Jenkins as well, its not just local | 16:16 |
| *** timcl has quit IRC | 16:17 | |
| *** haomaiwang has quit IRC | 16:17 | |
| *** haomai___ has joined #openstack-cinder | 16:17 | |
| eharney | ntpttr: can you write a launchpad bug for it? | 16:17 |
| ntpttr | Sure | 16:17 |
| *** sgundur has quit IRC | 16:18 | |
| jgriffith | DuncanT: I keep going back to this though: https://review.openstack.org/#/c/221441/5/cinder/volume/api.py | 16:18 |
| jgriffith | DuncanT: just doesn't "feel" right | 16:19 |
| guitarzan | the "conditional_update" call | 16:19 |
| guitarzan | ? | 16:19 |
| *** jdurgin1 has quit IRC | 16:20 | |
| jgriffith | guitarzan: well, the pattern of implementing a raise_error in every call etc | 16:20 |
| *** p0rtal has joined #openstack-cinder | 16:20 | |
| guitarzan | hmm, definitely clunky | 16:21 |
| jgriffith | guitarzan: it's just kind of a "code smell" thing to me | 16:21 |
| guitarzan | could it just be a generic "You lost a race condition, sorry try again" error? | 16:22 |
| DuncanT | jgriffith: I think you're right, we need a better code pattern for that sort of code, that's pretty unreadable | 16:22 |
| jgriffith | guitarzan: well, that's kind of what i've been wondering on all of this.. why that's so bad | 16:22 |
| jgriffith | guitarzan: or maybe an entry-lock in the actual API layer | 16:23 |
| guitarzan | given the choice, I'd pick "try again" over lock, but that's just me | 16:23 |
| jgriffith | DuncanT: guitarzan my bigger concern is when this ends up duplicated in every API call | 16:23 |
| scottda | jgriffith: +1. It seems that the API checks have races, why not just use locks? | 16:23 |
| jgriffith | guitarzan: yeah, I'm not objecting to either | 16:24 |
| jgriffith | scottda: I honestly don't know one versus the other | 16:24 |
| guitarzan | locks are probably easier | 16:24 |
| DuncanT | jgriffith: Be interesting to make a list of the API calls that can race. | 16:24 |
| DuncanT | guitarzan: 'try again' internally or passed back to the API caller? | 16:24 |
| scottda | The APi checks are a kinda lock, but they don't have to be respected by a given client, as DuncanT pointed out above. | 16:24 |
| jgriffith | scottda: I just know that this patch series is rather hard for me to follow and it does make me concerned as I stated before | 16:24 |
| *** p0rtal has quit IRC | 16:25 | |
| jgriffith | DuncanT: well I think geguileo has done that | 16:25 |
| guitarzan | DuncanT: good question, but I think bailing out completely makes the most sense | 16:25 |
| DuncanT | jgriffith: Where? I guess I missed that | 16:25 |
| jgriffith | DuncanT: perhaps a false assumption on my part | 16:25 |
| jgriffith | DuncanT: I thought that he mentioned that's what he was doing | 16:25 |
| DuncanT | jgriffith: Ah, I've lost track of what people are doing, I'm just reading the output at this point | 16:26 |
| DuncanT | guitarzan: Bailing out is an API change, and we have to support old clients :-( | 16:26 |
| guitarzan | DuncanT: sure, but a call just failing is fine | 16:26 |
| guitarzan | imo | 16:27 |
| DuncanT | guitarzan: Depends if it failed before | 16:27 |
| guitarzan | I think that's an argument that could be had | 16:27 |
| jgriffith | DuncanT: https://review.openstack.org/#/q/status:open+project:openstack/cinder+branch:master+topic:bug/1493476,n,z | 16:27 |
| DuncanT | guitarzan: Failing something that used to queue/block then succeed breaks clients | 16:27 |
| jgriffith | DuncanT: I don't know if there are "more" or if this is the list he has etc | 16:27 |
| guitarzan | DuncanT: true, but we've silently broken that stuff before :) | 16:27 |
| guitarzan | like adding all of the locks in the first place | 16:28 |
| *** porrua has quit IRC | 16:28 | |
| guitarzan | queue/blocking I mean | 16:28 |
| DuncanT | jgriffith: Ah, that isn't a very useable list... but I might be able to extract what I want from it. Thanks | 16:28 |
| jgriffith | guitarzan: yeah, but now that DuncanT pointed it out we're screwed :) | 16:28 |
| guitarzan | haha | 16:28 |
| jgriffith | :) | 16:28 |
| guitarzan | I got bit by the source_volid lock thing | 16:28 |
| DuncanT | guitarzan: We've screwed up a lot of things before. At some point we should at least think carefully before screwing things up again | 16:28 |
| guitarzan | DuncanT: fair enough, no argument | 16:29 |
| *** porrua has joined #openstack-cinder | 16:29 | |
| scottda | Do we expect clients to check state, and set to proper state (i.e. detaching) or are we OK with clients that don't bother? | 16:29 |
| guitarzan | personally I tend to think that fail early and often is a good strategy | 16:29 |
| scottda | and if clients can do whatever they want, what's the sense is all this state management in the first place? | 16:29 |
| guitarzan | scottda: clients don't set state | 16:29 |
| guitarzan | clients perform actions | 16:29 |
| scottda | nova does | 16:30 |
| guitarzan | no it doesn't | 16:30 |
| scottda | ok, well, nova calls begin_detaching which sets the state. | 16:30 |
| guitarzan | correct | 16:30 |
| *** hemna is now known as hemnafk | 16:30 | |
| guitarzan | if you're saying do clients have to use the api "correctly" then sure :) | 16:30 |
| *** aix has quit IRC | 16:31 | |
| *** timcl has joined #openstack-cinder | 16:31 | |
| guitarzan | nova's a good example. it doesn't handle all api call failures correctly either :( | 16:33 |
| guitarzan | there's no way to win, let's go shopping | 16:33 |
| DuncanT | scottda: We have to be resilient to the fact that clients can and will call random shit with no apparent sense at all. It's ok to not give them whatever the hell they thought they wanted, it isn't ok to get things stuck so that the admin needs to get involved. It's also not generally ok to cause a series of calls that worked in the last release to not work | 16:34 |
| DuncanT | now | 16:34 |
| DuncanT | Right, I'm going home, it's getting late to be in the office. Time to raid the biscuit tin then go home | 16:34 |
| jgriffith | DuncanT: guitarzan intersting.... https://review.openstack.org/#/c/143837/9/nova/db/sqlalchemy/api.py | 16:34 |
| scottda | Since the state is checked, i.e. in begin_detaching, and if we eliminate the races with an atomic compare-and-swap, there will be no failure where there used to be success. | 16:35 |
| guitarzan | @retrying.retry! :) | 16:35 |
| jgriffith | guitarzan: LOL | 16:36 |
| scottda | And if clients can call random stuff and not honor the API, we should just implement locks in the API instead of checking state. | 16:36 |
| jgriffith | guitarzan: unfortunate naming of that module | 16:36 |
| *** diogogmt has quit IRC | 16:36 | |
| guitarzan | I don't know how I feel about that either | 16:36 |
| guitarzan | it seems like you wouldn't want that retrying to happen at that low of a level | 16:36 |
| jgriffith | guitarzan: at least it's readable and isolated :) | 16:36 |
| guitarzan | sure | 16:36 |
| jgriffith | guitarzan: well, the loop in the api code is essentialy the same thing | 16:37 |
| guitarzan | I'm talking myself into the lock every action case I think | 16:37 |
| *** wilson1 has joined #openstack-cinder | 16:37 | |
| jgriffith | guitarzan: but it keeps issuing new db calls no? | 16:37 |
| *** willsama has joined #openstack-cinder | 16:37 | |
| guitarzan | jgriffith: yeah, I'm just thinking out loud | 16:38 |
| *** angela-s has joined #openstack-cinder | 16:38 | |
| jgriffith | guitarzan: careful, I have a trademark on that :) | 16:38 |
| guitarzan | do you want an entire api call to be "atomic"? | 16:38 |
| guitarzan | haha | 16:38 |
| DuncanT | jgriffith: I don't find retry decorators very readable, but I didn't find that earlier explict retry code readable either. Maybe I need to upgrade my brain | 16:38 |
| DuncanT | guitarzan: That'd mean I'm nuking Vegas every time I access our public cloud. I'm surprisingly ok with this. | 16:39 |
| *** bluex-pl has quit IRC | 16:39 | |
| jgriffith | LOL | 16:39 |
| guitarzan | haha! | 16:39 |
| *** wilson-1 has quit IRC | 16:40 | |
| *** Guest4123 has quit IRC | 16:40 | |
| *** jordanP has quit IRC | 16:41 | |
| *** jistr has quit IRC | 16:42 | |
| *** diogogmt has joined #openstack-cinder | 16:42 | |
| *** IanGovett has joined #openstack-cinder | 16:43 | |
| *** amit213 has quit IRC | 16:45 | |
| *** amit213 has joined #openstack-cinder | 16:46 | |
| *** ntpttr has quit IRC | 16:47 | |
| *** juzuluag has quit IRC | 16:47 | |
| *** harlowja_at_home has quit IRC | 16:47 | |
| *** ntpttr has joined #openstack-cinder | 16:51 | |
| *** ntpttr has quit IRC | 16:54 | |
| *** ntpttr has joined #openstack-cinder | 16:55 | |
| *** ozialien has quit IRC | 16:56 | |
| *** shausy has joined #openstack-cinder | 16:58 | |
| *** haomai___ has quit IRC | 17:01 | |
| *** haomaiwang has joined #openstack-cinder | 17:01 | |
| *** stevemar_ has joined #openstack-cinder | 17:02 | |
| *** p0rtal has joined #openstack-cinder | 17:03 | |
| *** hemnafk is now known as hemna | 17:03 | |
| *** ntpttr has quit IRC | 17:04 | |
| *** sghanekar_ has joined #openstack-cinder | 17:05 | |
| *** willsama has quit IRC | 17:06 | |
| *** stevemar_ has quit IRC | 17:07 | |
| *** p0rtal has quit IRC | 17:07 | |
| *** ociuhandu has quit IRC | 17:11 | |
| *** mriedem has joined #openstack-cinder | 17:14 | |
| *** mriedem_away has quit IRC | 17:16 | |
| *** daneyon has joined #openstack-cinder | 17:17 | |
| *** daneyon has quit IRC | 17:19 | |
| *** daneyon_ has quit IRC | 17:20 | |
| smcginnis | thingee, jungleboyj, jgriffith: There are a few patches waiting for a second +2 on kilo. | 17:22 |
| smcginnis | thingee, jungleboyj, jgriffith: https://review.openstack.org/#/q/project:openstack/cinder+branch:stable/kilo+status:open,n,z | 17:23 |
| smcginnis | thingee, jungleboyj, jgriffith: Should we get some of those in before kilo goes to security only? | 17:23 |
| jgriffith | smcginnis: indeed! | 17:23 |
| *** IanGovett has quit IRC | 17:24 | |
| jungleboyj | smcginnis: Ok. Will take a look. | 17:26 |
| jgriffith | eharney: ping | 17:27 |
| tbarron | smcginnis: thingee: jungleboyj: jgriffith: kilo also needs backport of fix for https://bugs.launchpad.net/cinder/+bug/1505153 | 17:28 |
| openstack | Launchpad bug 1505153 in Manila "gates broken by WebOb 1.5 release" [Critical,In progress] - Assigned to Gaurang Tapase (gaurang-tapase) | 17:28 |
| *** diogogmt_ has joined #openstack-cinder | 17:29 | |
| *** ronis has quit IRC | 17:29 | |
| tbarron | ^^ in cinder too | 17:29 |
| *** diogogmt has quit IRC | 17:29 | |
| *** diogogmt_ is now known as diogogmt | 17:29 | |
| smcginnis | tbarron: Thanks. I did see you're blocked on that. | 17:29 |
| tbarron | smcginnis: yeah, fixed a commit message and hit it :-) | 17:30 |
| smcginnis | Doh | 17:30 |
| jgriffith | jungleboyj: can you +2/A this one after it passes tests: https://review.openstack.org/#/c/233747/ | 17:33 |
| jgriffith | jungleboyj: get the gate back to healthier state for us | 17:33 |
| *** kevincarr1991 has joined #openstack-cinder | 17:34 | |
| kevincarr1991 | tbarron: Did you have a chance to try and test the nfs setup with cinder? | 17:35 |
| tbarron | kevincarr1991: a bit, did some experiments, need to do more. | 17:35 |
| tbarron | kevincarr1991: I can break the nova compute side by messing with permissions on the mount there. | 17:36 |
| tbarron | kevincarr1991: I want to test in a more production environment than devstack. Are you using a distribution? | 17:36 |
| *** rushil_ has joined #openstack-cinder | 17:39 | |
| *** rushil has quit IRC | 17:39 | |
| kevincarr1991 | tbarron: No i did a manual three node setup | 17:42 |
| *** nkrinner_afk has quit IRC | 17:43 | |
| kevincarr1991 | tbarron: are you using a separate node for the cinder service? | 17:43 |
| tbarron | kevincarr1991: Not yet, looking for gear. | 17:44 |
| aorourke | was there ever a launchpad bug filed for the error ntpttr brought up? "'str' object has no attribute 'DEALER'" | 17:44 |
| eharney | aorourke: https://bugs.launchpad.net/cinder/+bug/1505295 | 17:44 |
| openstack | Launchpad bug 1505295 in openstack-ansible "Tox tests failing with AttributeError" [High,In progress] - Assigned to Jesse Pretorius (jesse-pretorius) | 17:44 |
| aorourke | eharney, thank you | 17:44 |
| tbarron | kevincarr1991: back to our earlier conversation, you wouldn't normally have an fstab entry for the nfs share | 17:44 |
| kevincarr1991 | tbarron: ahh ok. and I will delete it out of the fstab file. | 17:45 |
| tbarron | kevincarr1991: your compute node should automatically do the mount, under a similar path as the cinder node. | 17:45 |
| tbarron | kevincarr1991: it will do the mount when you attach a cinder volume to a compute instance. | 17:46 |
| kevincarr1991 | tbarron: OK, for me it will be the controller node since that is where cinder is running | 17:46 |
| tbarron | kevincarr1991: the controller node is effectively also the block storage node in your case. | 17:46 |
| tbarron | kevincarr1991: I am saying that when you do the attach, the compute node where the vm instance is running should do a similar mount. | 17:47 |
| kevincarr1991 | tbarron: yes, so do i also need to install cinder on the compute nodes so they can attach? | 17:47 |
| tbarron | kevincarr1991: no | 17:47 |
| kevincarr1991 | tbarron: Oh, ok thank you | 17:47 |
| tbarron | kevincarr1991: from your brief log snippet a few days ago, it looked like the mount succeeded there, but that | 17:47 |
| tbarron | kevincarr1991: some subsequent commands failed because the volume being attached wasn't readable. | 17:48 |
| kevincarr1991 | tbarron: yes. I also noticed that the I am getting an error in the volume log that say "NFS driver not initialized" | 17:49 |
| tbarron | kevincarr1991: can you run 'ls -ld' and 'ls -la' on the mount from the cinder node, first, and then on the (similar) mount from the compute node right after attempting an attach? | 17:49 |
| tbarron | kevincarr1991: well, that is a more fundamental problem. | 17:49 |
| tbarron | kevincarr1991: I think you were past that the other day, but who knows. | 17:49 |
| kevincarr1991 | tbarron: I was past that. that just started but I am not sure why. I have to get that fixed before I can run the commands you suggested. | 17:50 |
| tbarron | kevincarr1991: whenever you get 'X driver not initialized' you need to go to the cinder/block node (in your case, the controller) | 17:50 |
| tbarron | kevincarr1991: restart the service, and back up from the end of the volume log to the error initializing right after the service starts. | 17:51 |
| kevincarr1991 | tbarron: I think specifying version 3 for the nfs might be causing the issue | 17:51 |
| tbarron | kevincarr1991: in this case, see if the mount is failing on the cinder node. | 17:51 |
| tbarron | kevincarr1991: nfs v 3 works, but only if the server is supporting that version. | 17:52 |
| *** ronis has joined #openstack-cinder | 17:52 | |
| kevincarr1991 | tbarron: It does support that version | 17:52 |
| tbarron | kevincarr1991: then it *should* work, if the cinder node is set up right. Check if the mount failed. | 17:53 |
| kevincarr1991 | tbarron: restarting the service | 17:53 |
| kevincarr1991 | tbarron: yes the mount failed when I restarted it | 17:54 |
| tbarron | kevincarr1991: so here is where you manually mount the share, just as an experiment, on /mnt or some such, then | 17:55 |
| tbarron | kevincarr1991: when that works, use the same nfs options (if any) in cinder.conf | 17:56 |
| kevincarr1991 | tbarron: just tried that and the mount worked | 17:56 |
| tbarron | kevincarr1991: were you using version 3? | 17:56 |
| kevincarr1991 | tbarron: yes i used the following mount -t nfs -o vers=3 ip:/exports | 17:57 |
| *** martyturner has quit IRC | 17:58 | |
| *** martyturner has joined #openstack-cinder | 17:59 | |
| *** apoorvad_ has joined #openstack-cinder | 18:00 | |
| tbarron | kevincarr1991: so what is the error in the volume log around the mount? | 18:00 |
| *** haomaiwang has quit IRC | 18:01 | |
| kevincarr1991 | tbarron: Unable to update stats, NfsDriver -1.2.0 driver is uninitialized | 18:01 |
| *** haomaiwang has joined #openstack-cinder | 18:01 | |
| tbarron | kevincarr1991: that is a consequence of the driver being unitialized. Go back to where the driver starts up and look | 18:03 |
| tbarron | kevincarr1991: for lines like: CMD "mount" returned: ... | 18:03 |
| *** apoorvad has quit IRC | 18:03 | |
| *** ntpttr has joined #openstack-cinder | 18:08 | |
| *** ntpttr has quit IRC | 18:09 | |
| kevincarr1991 | tbarron: I see now i am getting permission issues but the share has a very open permissions | 18:09 |
| *** haomaiwang has quit IRC | 18:17 | |
| *** vmtrooper has joined #openstack-cinder | 18:19 | |
| tbarron | we're taking this to a side-channel for now ... | 18:19 |
| *** salv-orlando has joined #openstack-cinder | 18:25 | |
| *** salv-orl_ has quit IRC | 18:25 | |
| *** ntpttr has joined #openstack-cinder | 18:30 | |
| jgriffith | smcginnis: I have some concerns about this one: https://review.openstack.org/#/c/189588/ | 18:33 |
| jgriffith | smcginnis: I would have said the right thing to do is "fix the bug" of course | 18:33 |
| jgriffith | smcginnis: but given all the discussion lately around compatible changes etc, I have to pause | 18:34 |
| smcginnis | jgriffith: True | 18:34 |
| smcginnis | e0ne made a good point too. Can we backport with ApiImpact? | 18:34 |
| * smcginnis sees that was addressed in the comments | 18:35 | |
| smcginnis | So it doesn't change what is documented for the API (which apparently was wrong) but it does change behavior. | 18:36 |
| jgriffith | smcginnis: yeah | 18:37 |
| mtanino | smcginnis: yes, I think so. | 18:37 |
| e0ne | smcginnis: some users cant use that "wrong" behavior | 18:37 |
| jgriffith | smcginnis: if it were liberty I would have no concern | 18:37 |
| e0ne | smcginnis: e.g. like they did with AZ issue | 18:37 |
| e0ne | jgriffith: +1 | 18:37 |
| jgriffith | but Kilo... I don't know. I don't want to break existing deployments, even if what theyr'e doing is technically *wrong* | 18:38 |
| jgriffith | e0ne: smcginnis my suggestion in the review was maybe make it configurable so we don't screw people up? | 18:38 |
| smcginnis | jgriffith: Probably just leave that one then. Good fix, but not right for this "old" branch. | 18:38 |
| e0ne | jgriffith: it seams reasonable | 18:38 |
| jgriffith | smcginnis: afraid that may be the case | 18:38 |
| smcginnis | jgriffith: Yeah, but then we're adding a new config option to an old branch. | 18:38 |
| jgriffith | smcginnis: DOH | 18:39 |
| jgriffith | smcginnis: yeah, that's not doable either :( | 18:39 |
| smcginnis | I think unfortunately we should probably leave it as is and move on. :\ | 18:39 |
| eharney | i like that fix, but with how long that was broken, just leaving it as-is in Kilo isn't really unreasonable | 18:39 |
| jgriffith | smcginnis: yeah, sorry | 18:39 |
| smcginnis | Oh well, worth reviewing. | 18:40 |
| jgriffith | eharney: yeah, I like the fix too.... it's a bummer | 18:40 |
| smcginnis | And now if someone wants it, there's a patch out there they can apply to change it. | 18:40 |
| jgriffith | smcginnis: :) | 18:40 |
| jgriffith | smcginnis: you've read some of my comments in backports :) | 18:40 |
| smcginnis | Hah | 18:40 |
| e0ne | smcginnis: cd cinder && make && make install cinder:) | 18:40 |
| jgriffith | smcginnis: even those that I know won't get accepted I like to post them and even -2 them myself | 18:40 |
| smcginnis | e0ne: :) | 18:41 |
| jgriffith | so that deployers have an easy patch/reference if they want to assume the risk | 18:41 |
| smcginnis | jgriffith: Not a bad pattern to follow, IMO. | 18:41 |
| jgriffith | smcginnis: I think people would probably rather a patch attached to the LP bug | 18:41 |
| jgriffith | smcginnis: which I'll try and do instead going forward | 18:41 |
| jgriffith | anyway... | 18:41 |
| smcginnis | jungleboyj: Jenkin's +1'd on this now: https://review.openstack.org/#/c/233747/ | 18:42 |
| jgriffith | smcginnis: man... that took a while | 18:43 |
| smcginnis | Too many rechecks going on or something. | 18:43 |
| hemna | jenkins had been pooh'n out quite a bit over the weekend | 18:43 |
| smcginnis | I do wonder how much longer the way we do things with Jenkins will scale. | 18:43 |
| jgriffith | smcginnis: haha | 18:44 |
| jgriffith | smcginnis: people have been saying that for a LONNNG time | 18:44 |
| *** nikeshm has joined #openstack-cinder | 18:44 | |
| smcginnis | jgriffith: No doubt. | 18:44 |
| jgriffith | smcginnis: every release though it gets better and better | 18:44 |
| smcginnis | I do remember a session in Atlanta from someone pitching moving away from Jenkins. | 18:44 |
| jgriffith | smcginnis: the only downside is it's sort of like being on a treadmill :) | 18:45 |
| smcginnis | I don't think it's a Jenkins issue though. | 18:45 |
| smcginnis | Good analogy. :) | 18:45 |
| jgriffith | smcginnis: nah... it's a dependency problem I think more than anything else | 18:45 |
| *** kevincarr1991 has quit IRC | 18:45 | |
| smcginnis | More and more dependencies. | 18:45 |
| jgriffith | smcginnis: volume gets high, then if you introduce a problem that causes the chain to break you have some aftermath | 18:45 |
| jgriffith | The OpenStack infra is pretty amazing when you start pulling back the covers | 18:46 |
| smcginnis | Like the old credit card commercial where everything is humming along until someone tries to pay with cash. | 18:46 |
| smcginnis | +111 | 18:46 |
| jgriffith | LOL | 18:46 |
| smcginnis | They do awesome things. | 18:46 |
| jgriffith | Yeah... just like that! | 18:46 |
| smcginnis | Wasn't sure if anyone else would actually get that reference. :) | 18:46 |
| jungleboyj | smcginnis: +A. | 18:47 |
| smcginnis | jungleboyj: Thanks! | 18:47 |
| hemna | wasn't there talk of replacing jenkins ? | 18:47 |
| smcginnis | In Atlanta there was. | 18:47 |
| smcginnis | I don't think it really went over well. | 18:47 |
| hemna | asselin, ? | 18:49 |
| * jungleboyj is looking at the other stable/kilo items. | 18:49 | |
| asselin_ | hemna, hi | 18:49 |
| asselin_ | replacing jenkins, yes, it's in zuulv3 | 18:50 |
| hemna | is that happening this century ? | 18:50 |
| hemna | :P | 18:50 |
| asselin_ | hemna, http://specs.openstack.org/openstack-infra/infra-specs/specs/zuulv3.html | 18:51 |
| asselin_ | hemna, It was discussed in vancouver. not sure the status. You can ask jeblair in -infra | 18:51 |
| *** jdandrea has joined #openstack-cinder | 18:53 | |
| *** martyturner has quit IRC | 18:53 | |
| hemna | cool. so yah my guess is not any time soon then | 18:53 |
| hemna | seems like a big hill to climb | 18:53 |
| *** martyturner has joined #openstack-cinder | 18:53 | |
| *** shausy has quit IRC | 18:53 | |
| jdandrea | Can we always count on the scheduler filters to be queried in the order listed in cinder.conf or is that something we should *not* assume will always be the case? | 18:54 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Block oslo.messaging version 2.6.0 https://review.openstack.org/233769 | 18:56 |
| ntpttr | ^^ That patch is a temporary fix for the errors I was talking about earlier | 18:57 |
| ntpttr | It looks like oslo.messaging 2.6.0 is causing the problems | 18:57 |
| jgriffith | ntpttr: see my comments | 19:00 |
| jgriffith | mtanino: we can't actually just update independently like that | 19:01 |
| *** julim has quit IRC | 19:01 | |
| jgriffith | oops | 19:01 |
| mtanino | ooo | 19:01 |
| jgriffith | s/mtanino/ntpttr/ | 19:01 |
| jgriffith | mtanino: sorry about that | 19:01 |
| mtanino | yup | 19:01 |
| jgriffith | ntpttr: https://review.openstack.org/#/c/233724/ | 19:01 |
| jgriffith | ntpttr: once that merges we can get away with your patch, but not until then | 19:01 |
| jgriffith | ntpttr: assuming it matches of course :) | 19:02 |
| ntpttr | jgriffith: All right, thanks wasn't sure how the requirements workflow worked :) | 19:02 |
| jgriffith | ntpttr: so once that merges we can land it | 19:03 |
| jgriffith | ntpttr: int he meantime if you could update the commit message to reference that oslo patch | 19:03 |
| jgriffith | ntpttr: I'll +2/A it as soon as the other one lands | 19:03 |
| jgriffith | ntpttr: make sense/ | 19:03 |
| jgriffith | ? | 19:03 |
| ntpttr | jgriffith: Okay, sounds good - referencing the oslo patch as in including the link to https://review.openstack.org/#/c/233724/? | 19:04 |
| guitarzan | oslo is like the openstack supervillain | 19:04 |
| jgriffith | ntpttr: oops.. I said oslo.. meant requirements | 19:04 |
| dims__ | guitarzan: apologies | 19:04 |
| jgriffith | ntpttr: but *yes* you figured out what I meant :) | 19:04 |
| dims__ | on behalf of oslo folks | 19:04 |
| jgriffith | pissh | 19:04 |
| jgriffith | that's nothing! | 19:04 |
| guitarzan | dims__: haha, no worries, feel free to continue taking over the world | 19:05 |
| *** gouthamr has quit IRC | 19:05 | |
| dims__ | guitarzan: :) | 19:06 |
| dims__ | guitarzan: 23 versions today (http://lists.openstack.org/pipermail/openstack-announce/2015-October/thread.html) found 2 problems and trying to fix 'em | 19:07 |
| guitarzan | that's crazy | 19:07 |
| *** gouthamr has joined #openstack-cinder | 19:07 | |
| *** ociuhandu has joined #openstack-cinder | 19:08 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Block oslo.messaging version 2.6.0 https://review.openstack.org/233769 | 19:09 |
| hemna | doh | 19:09 |
| jgriffith | ntpttr: Excellent! | 19:10 |
| jgriffith | ntpttr: thanks! | 19:10 |
| ntpttr | jgriffith: np! thanks for the advice | 19:10 |
| *** daneyon has joined #openstack-cinder | 19:10 | |
| *** daneyon_ has joined #openstack-cinder | 19:11 | |
| jgriffith | ntpttr: oops | 19:12 |
| jgriffith | ntpttr: you need to match what's in the other patch :) | 19:12 |
| jgriffith | ntpttr: oslo.messaging>=1.16.0,!=1.17.0,!=1.17.1,!=2.6.0 # Apache-2.0 | 19:12 |
| jgriffith | ntpttr: even if the logic is the same :) | 19:13 |
| jgriffith | ntpttr: I know it's extremely picky of me | 19:13 |
| ntpttr | jgriffith: Oops sorry I thought I had because I saw that they just put 2.6.0 at the end! I'll fix that up | 19:14 |
| eharney | i think the reqs job will fail it if doesn't match exactly anyway? | 19:15 |
| ntpttr | eharney, jgriffith: It looks like the cinder one didn't even match before, 1.16.0 wan't at the front | 19:15 |
| *** daneyon has quit IRC | 19:15 | |
| jgriffith | ntpttr: weird, as eharney pointed out we shouldn't be able to get oos like that | 19:16 |
| *** DericHorn-HP has joined #openstack-cinder | 19:16 | |
| eharney | yeah i don't know how that would happen | 19:16 |
| *** timcl has quit IRC | 19:18 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Block oslo.messaging version 2.6.0 https://review.openstack.org/233769 | 19:18 |
| *** asselin_ has quit IRC | 19:22 | |
| *** eharney has quit IRC | 19:24 | |
| jungleboyj | smcginnis: jgriffith I have put my vote in on all the patches in Stable/kilo that have passed jenkins. | 19:27 |
| jgriffith | jungleboyj: thanks! | 19:27 |
| *** asselin_ has joined #openstack-cinder | 19:28 | |
| jgriffith | jungleboyj: BTW, note that some of those not passing jenkins are waiting for ntpttr 's requirements update | 19:28 |
| *** rushil_ has quit IRC | 19:31 | |
| *** lpabon has quit IRC | 19:32 | |
| *** changbl has joined #openstack-cinder | 19:33 | |
| patrickeast | jungleboyj: did you see this one https://review.openstack.org/#/c/232847/ ? | 19:33 |
| *** rushil has joined #openstack-cinder | 19:34 | |
| *** gouthamr has quit IRC | 19:35 | |
| *** rushil has quit IRC | 19:36 | |
| jungleboyj | patrickeast: Oops. Hold on. | 19:37 |
| jungleboyj | patrickeast: Done. | 19:41 |
| jungleboyj | Any other requests? | 19:41 |
| patrickeast | jungleboyj: sweet thanks, i think the only one left in my batch of iscsi junk was https://review.openstack.org/#/c/232846/ which seems to be getting some hate from jenkins | 19:42 |
| patrickeast | was passing, might be the issue jgriffith was talking about (i'm not caught up on the details...) | 19:42 |
| jungleboyj | patrickeast: Ok, let me know if you get it figured out. | 19:43 |
| patrickeast | jungleboyj: will do | 19:43 |
| patrickeast | jungleboyj: thanks | 19:43 |
| *** harlowja has quit IRC | 19:44 | |
| *** apoorvad_ has quit IRC | 19:45 | |
| ntpttr | cd | 19:45 |
| ntpttr | hah oops this is not my terminal | 19:46 |
| *** Yogi11 has joined #openstack-cinder | 19:49 | |
| *** jgregor has joined #openstack-cinder | 19:50 | |
| *** yrabl has quit IRC | 19:51 | |
| *** eharney has joined #openstack-cinder | 19:52 | |
| *** Yogi1 has quit IRC | 19:53 | |
| *** stevemar_ has joined #openstack-cinder | 19:56 | |
| *** stevemar_ has quit IRC | 19:59 | |
| jgriffith | aorourke: ping | 19:59 |
| jgriffith | patrickeast: yes, it's the requirements issue | 20:00 |
| jgriffith | patrickeast: I'll +2/A it after the fix lands | 20:00 |
| patrickeast | jgriffith: ok cool, thanks! | 20:00 |
| aorourke | jgriffith, hey | 20:00 |
| jgriffith | aorourke: howdy | 20:01 |
| jgriffith | aorourke: hey... I actually wanted to get your input on that (https://review.openstack.org/#/c/233307/3/doc/source/devref/replication.rst) | 20:01 |
| *** kurtmartin has quit IRC | 20:01 | |
| *** martyturner has quit IRC | 20:01 | |
| jgriffith | aorourke: I'm open to ideas, but I wanted to ping you and patrickeast and anybody else to pick something universal and that we all agree on | 20:01 |
| aorourke | jgriffith, I looked over that earlier. I was wondering what the difference would be with volume_backend and device_target_id? | 20:02 |
| jgriffith | volume_backend_name seemed good because in the managed case we'll need/want that | 20:02 |
| jgriffith | aorourke: nothing, it's just a name/label :) | 20:02 |
| aorourke | jgriffith, so does this replace device_target_id? | 20:02 |
| jgriffith | aorourke: it just becomes a question of what makes more "sense" and what we want to live with going forward | 20:02 |
| jgriffith | aorourke: yes | 20:02 |
| aorourke | as the new unique id? | 20:02 |
| aorourke | ok | 20:02 |
| jgriffith | aorourke: that way it's clear with the managed case at least to me ;) | 20:03 |
| *** ronis has quit IRC | 20:03 | |
| jgriffith | aorourke: so in the case of managed we have to have that volume_backend_name so it just sort of "made sense" to me | 20:03 |
| aorourke | jgriffith, you have it listed as backend_name at first but then volume_backend_name after in the NOTE section | 20:03 |
| jgriffith | aorourke: yeah... so that's confusing becasue | 20:03 |
| jgriffith | aorourke: I need to fix that | 20:03 |
| jgriffith | aorourke: but wanted to ping you and others before doing anything | 20:04 |
| jgriffith | aorourke: have all of us agree :) | 20:04 |
| *** Lee1092 has quit IRC | 20:04 | |
| jgriffith | aorourke: does that mean you have no preference? :) | 20:05 |
| aorourke | jgriffith, the volume_backend_name might be different than the array identifier is my concern | 20:05 |
| *** sgotliv has joined #openstack-cinder | 20:05 | |
| jgriffith | aorourke: sure, but it's just a label | 20:05 |
| jgriffith | It will most certainly be different, agreed | 20:05 |
| aorourke | jgriffith, I guess i am a little confused, does volume_backend_name represent the *actual* volume_backend_name of the managed device? | 20:06 |
| *** Yogi11 has quit IRC | 20:06 | |
| jgriffith | In the case of managed yes | 20:06 |
| jgriffith | in the case of unmanaged it could be *whatever* | 20:07 |
| jgriffith | So... | 20:07 |
| aorourke | jgriffith, ok, but even with managed the volume_backend_name could still be different than the array id | 20:07 |
| aorourke | it more than likely will | 20:07 |
| jgriffith | managed: volume_backend_name=hostname@backend_name#pool | 20:07 |
| jgriffith | unmanaged: volume_backend_name=my-vendor-required-name-or-id | 20:07 |
| jgriffith | aorourke: That's kinda the point.. in the case of managed we *NEED* the cinder host name (or volume_backend_name) | 20:08 |
| aorourke | jgriffith, so the goal here is to standardize on an ID that will be passed into failover basically? | 20:08 |
| jgriffith | No, standardize on a key | 20:08 |
| jgriffith | We've already standardized on the value in the case of managed | 20:09 |
| aorourke | an identifier key | 20:09 |
| jgriffith | it IS the host | 20:09 |
| jgriffith | of a configured backend | 20:09 |
| aorourke | right | 20:10 |
| jgriffith | aorourke: do you have a suggestion? | 20:11 |
| jgriffith | aorourke: two different labels? | 20:11 |
| jgriffith | aorourke: something completely different? | 20:11 |
| aorourke | jgriffith, i think that might be needed | 20:11 |
| jgriffith | aorourke: can you expand please? | 20:12 |
| * jgriffith feels he's pulling teeth | 20:12 | |
| aorourke | jgriffith, device_target_id should be used as a way to identify the backend array | 20:12 |
| jgriffith | aorourke: in which case? | 20:13 |
| aorourke | jgriffith, even if it is managed, i feel there needs to be a way to 'name' the array | 20:13 |
| jgriffith | aorourke: both? | 20:13 |
| aorourke | to id it | 20:13 |
| jgriffith | sigh... | 20:13 |
| jgriffith | but you're missing the point | 20:13 |
| jgriffith | I think | 20:13 |
| jgriffith | maybe not... what I'm asking you is: what key would you like to use to specify the target hostname (Cinder name) | 20:14 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API types extra specs to Python 3 https://review.openstack.org/232216 | 20:14 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port WSGI tests to Python 3 https://review.openstack.org/232214 | 20:14 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API to Python 3 https://review.openstack.org/232215 | 20:14 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API admin action tests to Python 3 https://review.openstack.org/232242 | 20:14 |
| jgriffith | aorourke: OR, would you rather we modified the "managed_target_device" to NOT be a bool | 20:14 |
| jgriffith | but to be the backend name or None? | 20:14 |
| jgriffith | so if it's None that indicates unmanaged | 20:15 |
| jgriffith | if it's set we assume it's a properly formed backend/host name? | 20:15 |
| aorourke | jgriffith, "managed_target_device" is meant for the primary configuration though | 20:15 |
| aorourke | jgriffith, not the replication_devices | 20:15 |
| jgriffith | Ummm... what? | 20:15 |
| aorourke | managed_replication_target ... True|False | 20:16 |
| jgriffith | aorourke: yes... so change that | 20:16 |
| jgriffith | managed_replication_target = <host>@<backend-name>#<pool> | None | 20:17 |
| *** Yogi1 has joined #openstack-cinder | 20:17 | |
| aorourke | jgriffith, then you are forcing every secondary array to that same host | 20:18 |
| jgriffith | aorourke: how? | 20:18 |
| jgriffith | If I have hosts: sleepy, dopey, goofy | 20:18 |
| jgriffith | I can do: goofy@lvm#lvm | 20:18 |
| jgriffith | or | 20:18 |
| jgriffith | dopey@lvm#lvm | 20:18 |
| jgriffith | or | 20:18 |
| jgriffith | sleepy@lvm#lvm | 20:18 |
| jgriffith | I can make it whatever I want | 20:19 |
| aorourke | managed_replication_target = <host>@<backend-name>#<pool> and replication_device = backend_name:biz,unique_key:val are meant for the main configuration correct? or am i missing something? | 20:19 |
| jgriffith | aorourke: they're meant for the cinder.conf file. | 20:19 |
| aorourke | yes | 20:19 |
| aorourke | of the primary array | 20:19 |
| jgriffith | aorourke: so... if you read the doc info: | 20:19 |
| jgriffith | aorourke: you have a backend named "driver-foo" right? | 20:20 |
| jgriffith | aorourke: see the config section for 'driver-foo' | 20:20 |
| jgriffith | ? | 20:20 |
| aorourke | yes looking at it | 20:20 |
| aorourke | that is the primary right? | 20:20 |
| jgriffith | aorourke: In this case yes | 20:20 |
| aorourke | ok | 20:20 |
| jgriffith | aorourke: so if I want to enable replication to one or more of the other confgured backends... | 20:21 |
| jgriffith | aorourke: I would do: managed_replication_target=drirver-biz,driver-baz | 20:21 |
| aorourke | yep | 20:21 |
| jgriffith | aorourke: that would instruct driver-foo to set up pairing and do it's thing on init to those backends | 20:22 |
| jgriffith | aorourke: so they're now valid/available replication target devices | 20:22 |
| jgriffith | aorourke: I could also make entries for driver-biz to pair with driver-foo etc etc | 20:22 |
| jgriffith | aorourke: does that make sense? | 20:23 |
| aorourke | right, it does make sense | 20:23 |
| aorourke | what i am saying, in this case, if you set managed_replication_target = <host>@<backend-name>#<pool> in driver-foo, all the replication targets off of it will use that entry | 20:23 |
| jgriffith | aorourke: well yeah | 20:23 |
| jgriffith | if you don't want to do that then don't set that in your config | 20:23 |
| jgriffith | what is it that you want? | 20:24 |
| *** harlowja has joined #openstack-cinder | 20:24 | |
| aorourke | jgriffith, to be able to set different hosts for different targets off of the same primary | 20:24 |
| *** apoorvad has joined #openstack-cinder | 20:24 | |
| jgriffith | aorourke: so add more entries | 20:24 |
| jgriffith | aorourke: it's a list | 20:24 |
| jgriffith | as I said earlier: managed_replication_target = driver-biz,driver-baz.... | 20:24 |
| aorourke | yes so then managed_replication_target is a list as well? | 20:25 |
| jgriffith | aorourke: correct | 20:25 |
| aorourke | and they have to be concurrent then. so managed_replication_target[0] goes to replication_devices[0] | 20:25 |
| aorourke | ok | 20:25 |
| jgriffith | aorourke: well, that's up to you and your driver | 20:26 |
| jgriffith | aorourke: some backends can have multiple targets, they may want all of them... but thats the level of detail that IMO can/should go in the type info | 20:26 |
| jgriffith | aorourke: and is going to be vendor-specific | 20:27 |
| jgriffith | and shouldn't be considered in Cinder's core code | 20:27 |
| aorourke | jgriffith, i like the idea of backend_name or volume_backend_name being configurable on the targets, like you have in this patch. but if you think it makes sense another way.. | 20:27 |
| jgriffith | aorourke: just so long as they have the tools/mechanisms to do what they want or need | 20:27 |
| jgriffith | aorourke: Ohhh | 20:28 |
| jgriffith | I see what you were getting at | 20:28 |
| jgriffith | hehe.. sorry | 20:28 |
| jgriffith | you were talking about how to align the managed_replication_target list and the replication_device entries? | 20:28 |
| aorourke | jgriffith, yeah | 20:28 |
| jgriffith | so yeah... that doesn't work :) | 20:28 |
| aorourke | jgriffith, i think it should be kept in each target as it is now | 20:29 |
| jgriffith | Yeah, I think you're right... I think it has to be | 20:29 |
| jgriffith | I think that managed flag is actually useless TBH | 20:29 |
| jgriffith | aorourke: so how about this... there are two required keys in the replication_device entry: | 20:30 |
| aorourke | with this new patch managed and unmanaged is very similar now | 20:30 |
| aorourke | what i was saying earlier, though, is there still should be a key that allows you to ID the array. whether managed or unmanaged, vendors would probably want to name it consistently | 20:30 |
| aorourke | not based off of a host if managed, otherwise something else | 20:30 |
| aorourke | should be consistent | 20:30 |
| aorourke | and backend_name is a host if you are managed | 20:31 |
| hemna | and we still need a key that is consistent for the client list replication targets | 20:31 |
| jgriffith | aorourke: read line 82 :) | 20:31 |
| hemna | so everyone has the same copy/paste column for failover | 20:31 |
| aorourke | hemna, yes, which should remain device_target_id | 20:31 |
| aorourke | jgriffith, yes, but like hemna is saying there needs to be a standardized identifier regardless of if the target is managed or unmanaged | 20:32 |
| aorourke | for list_replication_target | 20:32 |
| hemna | yes | 20:32 |
| aorourke | and to pass it to replication_failover | 20:32 |
| jgriffith | hemna: aorourke I think we're rat holing a bit... yeah, sure | 20:32 |
| aorourke | so each vendor does not have a different key to pass | 20:32 |
| jgriffith | hemna: aorourke but I'm saying that the more I look at this we could put all of that in one entry | 20:32 |
| jgriffith | hemna: aorourke let me propose it and see what you guys think | 20:33 |
| hemna | cool | 20:33 |
| aorourke | jgriffith, ok | 20:33 |
| ntpttr | When any cores have time would you mind giving this patch from last week a quick look? I think I've ironed out the suggestions I've been given on it https://review.openstack.org/#/c/228646/ :) | 20:36 |
| *** dustins has quit IRC | 20:42 | |
| *** sghanekar_ has quit IRC | 20:43 | |
| *** e0ne has quit IRC | 20:48 | |
| *** edtubill has quit IRC | 20:48 | |
| *** ntpttr has quit IRC | 20:50 | |
| *** vgridnev has quit IRC | 20:51 | |
| mc_nair | hemna, leeantho - I'm looking into Live Migration support for some of the IBM drivers to make sure everything cleaning up nicely (based on https://etherpad.openstack.org/p/live-migration-results). I was wondering if you guys used scripts for running the different test scenarios 10+ times? | 20:53 |
| *** pots3 has quit IRC | 20:53 | |
| jdandrea | Can we always count on scheduler filters to be polled in the order listed in cinder.conf or should I *not* assume that will always be true? (Want to ask jecarey but he is not on. Can anyone give insight?) | 20:54 |
| *** abhi has quit IRC | 20:54 | |
| *** porrua has quit IRC | 20:54 | |
| *** abhi has joined #openstack-cinder | 20:55 | |
| hemna | mc_nair, yah leeantho had a script that he ran against an existing multi-node setup | 20:56 |
| *** mriedem has quit IRC | 20:58 | |
| *** edtubill has joined #openstack-cinder | 20:59 | |
| mc_nair | hemna ah, shweet - thanks. Got the a multinode setup for live migration (the instructions you had were great) and tried a few out by hand, but was getting old quickly. | 20:59 |
| hemna | yah it's a pain | 21:00 |
| *** sghanekar_ has joined #openstack-cinder | 21:00 | |
| hemna | leeantho, do you have the etherpad url we had for our live migration setup/testing/scripts ? | 21:00 |
| openstackgerrit | John Griffith proposed openstack/cinder: Update config format for replication_devices https://review.openstack.org/233307 | 21:00 |
| jgriffith | aorourke: hemna see if that makes sense or not ^^ | 21:01 |
| *** edmondsw has quit IRC | 21:01 | |
| hemna | jgriffith, ok thanks...we are off to a beating | 21:02 |
| *** hemna is now known as hemnafk | 21:02 | |
| *** mriedem has joined #openstack-cinder | 21:02 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/232868 | 21:04 |
| *** stevemar_ has joined #openstack-cinder | 21:04 | |
| openstackgerrit | Alon Marx proposed openstack/cinder: Implement changes in the consistency_group handling in the xiv/ds8k driver. https://review.openstack.org/233280 | 21:04 |
| openstackgerrit | Angela Smith proposed openstack/cinder: Adds friendly zone name support https://review.openstack.org/180518 | 21:07 |
| openstackgerrit | Sean McGinnis proposed openstack/cinder: Only use LOG.exception in exception handler https://review.openstack.org/233828 | 21:09 |
| mc_nair | jgriffith: quick question about https://review.openstack.org/#/c/233307 - are "device_target_id" and "managed_backend_name" meant to be used mutually exlusively? I.e. 'device_target_id' is only used for unmanaged, and 'mamanged_backend_name' only used for managed by Cinder? | 21:15 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-cinderclient: Updated from global requirements https://review.openstack.org/232889 | 21:15 |
| *** ntpttr has joined #openstack-cinder | 21:17 | |
| *** ntpttr has quit IRC | 21:19 | |
| *** salv-orlando has quit IRC | 21:20 | |
| *** zhiyan has quit IRC | 21:20 | |
| *** salv-orlando has joined #openstack-cinder | 21:20 | |
| *** serverascode has quit IRC | 21:21 | |
| *** briancurtin has quit IRC | 21:22 | |
| *** ctracey has quit IRC | 21:22 | |
| *** lprice has quit IRC | 21:24 | |
| *** rhefner has quit IRC | 21:25 | |
| *** scottda has quit IRC | 21:26 | |
| *** ameade has quit IRC | 21:26 | |
| mriedem | anyone know if there is a fix up for this yet? https://bugs.launchpad.net/cinder/+bug/1505394 - if not i've got one on the way | 21:28 |
| openstack | Launchpad bug 1505394 in OpenStack Compute (nova) "nova.tests.unit.test_exceptions.test_exceptions_raise fails with webob 1.5.0" [Critical,In progress] - Assigned to Matt Riedemann (mriedem) | 21:28 |
| openstackgerrit | Matt Riedemann proposed openstack/cinder: windows: don't use LOG.exception if not logging an exception https://review.openstack.org/233644 | 21:28 |
| mriedem | lifeless: ^ i see you on the python issue thread related to that so you might want to peek | 21:28 |
| jgriffith | mc_nair: nope, the idea is that you need/want both of them | 21:30 |
| jgriffith | mc_nair: the only key being that if the target is NOT managed then you would set managed_backend_name = None | 21:31 |
| jgriffith | mc_nair: even in the case of a managed rep target, your primary drivers is still going to need some sort of identifying info | 21:31 |
| jgriffith | mc_nair: and we don't have a good way that I can figure out to do things like "read config from XYZ" | 21:32 |
| lifeless | mriedem: huh? thats 3.5+ only, totally unrelated | 21:36 |
| mriedem | lifeless: regressed in 3.5? | 21:37 |
| mriedem | b/c that also fails/shows up in the py34 jobs | 21:37 |
| lifeless | mriedem: no, it was effature work | 21:38 |
| lifeless | bah | 21:38 |
| lifeless | feature work | 21:38 |
| lifeless | so you probably want to look at the neutron patch | 21:38 |
| lifeless | sec while I dig it up | 21:38 |
| mc_nair | jgriffith: thanks for the clarification. So unmanaged doesn't care about the "managed_backend_name" (makes sense because there's no Cinder name to give there). I still don't follow what the "device_target" id will need to get used for in the managed case, but I'm not very familiar with how repl is handled in the drivers so I'll dig into that on my own. | 21:39 |
| lifeless | mriedem: I456b7846b8a53e4d3f8c91583685e0e1eaa84719 | 21:39 |
| lifeless | mriedem: and I58e7e01ed152028ad43bb3ada87d719caa2ab08d | 21:39 |
| jgriffith | mc_nair: so in my case for example.. in order to pair clusters, I need to have some info like "cluster name" | 21:39 |
| jgriffith | mc_nair: which is an internal identifier just for me | 21:40 |
| jgriffith | mc_nair: so I would set that as the identifier in that key | 21:40 |
| jgriffith | mc_nair: for others it may be a UUID | 21:40 |
| jgriffith | mc_nair: or something completely different | 21:40 |
| *** merooney has quit IRC | 21:41 | |
| mriedem | lifeless: ok my change is basically the same | 21:43 |
| mriedem | use LOG.error instead of LOG.exception | 21:43 |
| lifeless | mriedem: yup | 21:43 |
| mc_nair | jgriffith: ok cool, that helps a bit. And you're confident that each driver can use just a single field for a unique target id? The only reason I'm asking is if not it'd be a bit odd if we have this one required field we designate to be vendor specific but we also acknowledge there can be other keys which will be vendor specific | 21:43 |
| lifeless | mriedem: but 17911 has nothing to do with this | 21:43 |
| lifeless | mriedem: how did you find that number ? | 21:43 |
| mriedem | lifeless: ok, i got that from the heat patch that fixed the same issues in heat | 21:44 |
| jgriffith | mc_nair: so the thing is they can add as many keys as the like | 21:44 |
| jgriffith | mc_nair: but that "one" is required | 21:44 |
| lifeless | mriedem: so heat are fundamentally confused | 21:44 |
| jgriffith | mc_nair: because 3Par folks asked for it :) | 21:44 |
| lifeless | mriedem: it was a bug in Python 3.x < 3.5 | 21:44 |
| jgriffith | mc_nair: that's what they want to return in the list_targets call | 21:44 |
| lifeless | mriedem: 17911was a feature request for asyncio for 3.5+ | 21:44 |
| jgriffith | mc_nair: which makes sense kinda | 21:44 |
| jgriffith | have at least *something* consistent | 21:45 |
| lifeless | mriedem: it *may* be that 3.5 is fixed because of my 17911 patch ? | 21:45 |
| lifeless | mriedem: that I could believe, but its totally incidental :) | 21:45 |
| mc_nair | jgriffith: ah got it - that was the missing piece. I get that there can be other vendor specific ones but was wondering why we required a key that was still going to be used in sort of vendor specific ways. | 21:45 |
| mriedem | lifeless: ok, yeah, i was having a hard time making the connection between what was failing in the py34 jobs and that 17911 patch | 21:46 |
| mc_nair | makes sense now though with trying to have at least one consistent-ish thing to queue off of for things like generating target list | 21:46 |
| lifeless | so I think I fixed a regression in my feature work | 21:46 |
| lifeless | where traceback.print_exception() would fail if sys.exc_info() was none | 21:47 |
| lifeless | but we didn't identify it as such | 21:47 |
| *** jaypipes has quit IRC | 21:47 | |
| lifeless | so, saying heat was confused is perhaps unfair | 21:47 |
| lifeless | *I* was confused | 21:47 |
| lifeless | and I think anyone looking at that bug will be to :) | 21:47 |
| *** vmtrooper has quit IRC | 21:48 | |
| lifeless | mriedem: I've suggested a different spelling of the fix that will also work on all Pythons | 21:48 |
| lifeless | mriedem: (and will give the same behaviour that the author had previously) | 21:49 |
| lifeless | mriedem: your one adds a traceback when no exception is present on 3.x | 21:49 |
| mc_nair | jgriffith: thanks for clearing that up. Your reward is one more question :) any reason in the docs for the unmanaged case that you set "managed_backend_name: None" instead of just leaving out that key? You just feel like it's better to be explicit on that one? | 21:50 |
| jgriffith | mc_nair: LOL | 21:50 |
| jgriffith | mc_nair: yeah :) So I want to just grab that key in my driver to know what to init | 21:50 |
| jgriffith | mc_nair: and sure, I could just say "if it's not there" but why be so simple :) | 21:50 |
| jgriffith | mc_nair: honestly it could be either way, but my experience is that if you have too many things "optional" then people forget to enter it | 21:51 |
| jgriffith | mc_nair: bb in a few... gotta run for now | 21:51 |
| *** edtubill has quit IRC | 21:52 | |
| mc_nair | jgriffith: and dictionary.get('nonexistent') defaults to None anyway so in this case it seems like it could be simpler to just leave it out | 21:52 |
| jgriffith | mc_nair: yeah, it might be :( | 21:52 |
| jgriffith | I just hate changing it again :) | 21:53 |
| jgriffith | but I'm certainly fine with it.... | 21:53 |
| mc_nair | jgriffith: not a big deal either way though. Your reward for answering that one is some spelling nit comments in that changeset - then I'm out of "rewards" for the day | 21:53 |
| jgriffith | I'll let everybody else decide | 21:53 |
| jgriffith | lol | 21:53 |
| jgriffith | darn | 21:53 |
| mc_nair | haha yea - I'm sure you'll be ignoring my questions in no time | 21:54 |
| jgriffith | mc_nair: nahh... they're good questions | 21:56 |
| jgriffith | Ok, really going now... going to be late if I don't mozie | 21:56 |
| *** daneyon_ has quit IRC | 21:58 | |
| *** thangp has quit IRC | 21:58 | |
| openstackgerrit | Patrick East proposed openstack/cinder: Add retries for Cisco FCZM client CLI _cfg_save https://review.openstack.org/233846 | 21:58 |
| *** earlephilhower has quit IRC | 21:58 | |
| *** jgregor has quit IRC | 21:59 | |
| mc_nair | sure thing - sorry to hold ya up | 22:00 |
| *** Yogi1 has quit IRC | 22:00 | |
| *** mc_nair has quit IRC | 22:00 | |
| *** jgregor has joined #openstack-cinder | 22:01 | |
| *** lprice has joined #openstack-cinder | 22:02 | |
| mriedem | lifeless: yeah isn't that what stack_info is for though? | 22:03 |
| mriedem | on py >= 3.2 | 22:03 |
| *** dims_ has joined #openstack-cinder | 22:09 | |
| *** salv-orl_ has joined #openstack-cinder | 22:10 | |
| *** 32NAAJR1K has joined #openstack-cinder | 22:10 | |
| *** vmtrooper has joined #openstack-cinder | 22:10 | |
| *** jgregor has quit IRC | 22:11 | |
| *** dims__ has quit IRC | 22:11 | |
| *** ctracey has joined #openstack-cinder | 22:13 | |
| *** salv-orlando has quit IRC | 22:13 | |
| *** jungleboyj has quit IRC | 22:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/cinder: windows: don't use LOG.exception if not logging an exception https://review.openstack.org/233644 | 22:16 |
| patrickeast | uhh ok i'm confused, i just got a merge conflict error from jenkins on https://review.openstack.org/#/c/232845/ but there doesn't appear to be any errors, or any newly merged changes in stable/kilo for that matter | 22:17 |
| patrickeast | anyone know what might have happened? | 22:17 |
| *** asselin__ has joined #openstack-cinder | 22:17 | |
| *** jgregor has joined #openstack-cinder | 22:18 | |
| *** asselin_ has quit IRC | 22:18 | |
| *** serverascode has joined #openstack-cinder | 22:18 | |
| jgriffith | patrickeast: not sure, but try rebasing | 22:19 |
| jgriffith | patrickeast: could be related to the req update | 22:20 |
| patrickeast | jgriffith: i did, there aren't any missing changes :( | 22:20 |
| jgriffith | Oh.. hmm | 22:20 |
| patrickeast | last change on stable/kilo was 10 days ago afaik | 22:20 |
| patrickeast | or as far as https://git.openstack.org/cgit/openstack/cinder/?h=stable%2Fkilo knows about | 22:20 |
| patrickeast | jgriffith: looks like others are complaining about this kind of thing over in -infra | 22:21 |
| patrickeast | might be a more general zuul/jenkins breakage | 22:21 |
| *** ameade has joined #openstack-cinder | 22:21 | |
| *** p0rtal has joined #openstack-cinder | 22:21 | |
| *** stevemar_ has quit IRC | 22:23 | |
| *** daneyon has joined #openstack-cinder | 22:24 | |
| *** zhiyan has joined #openstack-cinder | 22:25 | |
| *** dave-mccowan has quit IRC | 22:26 | |
| *** vmtrooper has quit IRC | 22:27 | |
| *** stevemar_ has joined #openstack-cinder | 22:27 | |
| *** daneyon has quit IRC | 22:28 | |
| *** vmtrooper has joined #openstack-cinder | 22:28 | |
| *** IlyaG has joined #openstack-cinder | 22:29 | |
| *** daneyon has joined #openstack-cinder | 22:30 | |
| *** xyang1 has quit IRC | 22:33 | |
| *** IanGovett has joined #openstack-cinder | 22:34 | |
| *** IanGovett has quit IRC | 22:38 | |
| *** hemnafk is now known as hemna | 22:40 | |
| *** IlyaG has quit IRC | 22:41 | |
| *** briancurtin has joined #openstack-cinder | 22:42 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Add new Connector APIs for path validation https://review.openstack.org/199764 | 22:43 |
| *** stevemar_ has quit IRC | 22:47 | |
| hemna | patrickeast, I just had the same issue on my patch | 22:47 |
| *** stevemar_ has joined #openstack-cinder | 22:47 | |
| hemna | I was confused when I rebased locally and didn't see a conflict. so I just hit the rebase button in gerrit | 22:47 |
| patrickeast | hemna: did that fix it? | 22:50 |
| hemna | yah it seems so | 22:51 |
| patrickeast | hmm i don't seem to even have a rebase button available for this one | 22:51 |
| patrickeast | its not always there... right? or am i blind? | 22:52 |
| hemna | logged in ? | 22:52 |
| hemna | I think it's only there if another patch has landed, and the current patch is behind ? | 22:53 |
| *** rhefner has joined #openstack-cinder | 22:53 | |
| *** IlyaG has joined #openstack-cinder | 22:54 | |
| *** scottda has joined #openstack-cinder | 22:55 | |
| *** IlyaG has quit IRC | 23:00 | |
| *** lpabon has joined #openstack-cinder | 23:01 | |
| *** david-ly_ has joined #openstack-cinder | 23:01 | |
| *** david-lyle has quit IRC | 23:02 | |
| *** daneyon has quit IRC | 23:03 | |
| *** david-lyle has joined #openstack-cinder | 23:04 | |
| *** david-ly_ has quit IRC | 23:04 | |
| *** lpabon has quit IRC | 23:09 | |
| *** diogogmt has quit IRC | 23:13 | |
| thingee | smcginnis: ack wrt kilo | 23:14 |
| *** diogogmt has joined #openstack-cinder | 23:15 | |
| *** zhangjn has joined #openstack-cinder | 23:15 | |
| *** DericHorn-HP has quit IRC | 23:17 | |
| *** dave-mccowan has joined #openstack-cinder | 23:23 | |
| *** IlyaG has joined #openstack-cinder | 23:23 | |
| *** lprice1 has joined #openstack-cinder | 23:24 | |
| *** lprice has quit IRC | 23:26 | |
| *** zhangjn has quit IRC | 23:26 | |
| *** dave-mccowan has quit IRC | 23:27 | |
| *** gouthamr has joined #openstack-cinder | 23:28 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Update config format for replication_devices https://review.openstack.org/233307 | 23:29 |
| *** gouthamr_ has joined #openstack-cinder | 23:29 | |
| jgriffith | patrickeast: which patch was it? | 23:32 |
| *** vilobhmm11 has joined #openstack-cinder | 23:32 | |
| *** ntpttr has joined #openstack-cinder | 23:32 | |
| patrickeast | jgriffith: https://review.openstack.org/#/c/232845/ | 23:32 |
| vilobhmm11 | smcginnis : ping | 23:32 |
| *** dave-mccowan has joined #openstack-cinder | 23:32 | |
| *** gouthamr has quit IRC | 23:32 | |
| *** stevemar_ has quit IRC | 23:33 | |
| vilobhmm11 | smcginnis, jgriffith : is there a limit on the number of volumes that can be attached to a nova instance (VM) | 23:33 |
| patrickeast | jgriffith: oh wait, you mean the one that needed the requirements change? | 23:33 |
| patrickeast | jgriffith: https://review.openstack.org/#/c/232846/ | 23:33 |
| jgriffith | patrickeast: https://review.openstack.org/#/c/232846/ | 23:34 |
| jgriffith | patrickeast: that's going to cause you problems I believe | 23:34 |
| patrickeast | jgriffith: wouldn't it just need a rebase? | 23:35 |
| patrickeast | jgriffith: once the requirements one lands* | 23:35 |
| jgriffith | patrickeast: well, the problem is that the changes haven't landed yet, and your needed-by there is failing | 23:36 |
| jgriffith | patrickeast: I'm not sure about linking deps in stable... I try not to do that :) | 23:36 |
| patrickeast | haha yea in retrospect maybe not the best idea | 23:36 |
| jgriffith | patrickeast: so FWIW, the use of depends on etc is causing all sorts of havoc for me :( | 23:38 |
| jgriffith | patrickeast: I think if we can get the oslo patches to merge somehow then try again we might be good | 23:38 |
| jgriffith | patrickeast: I wouldn't bother rechecking for now though | 23:38 |
| jgriffith | patrickeast: although I'm not entirely clear on what the "conflict" is in this case | 23:39 |
| patrickeast | jgriffith: afaik the conflict error on the first one in the batch was from zuul breaking, in theory it should go away now that they restarted the troublesome zuul node | 23:40 |
| jgriffith | ahh | 23:40 |
| patrickeast | jgriffith: what i'm not sure on though is how exactly to recheck a merge conflict | 23:40 |
| jgriffith | wonder why eharney 's patch is puking.... looks | 23:41 |
| openstackgerrit | Angela Smith proposed openstack/cinder: Adds friendly zone name support https://review.openstack.org/180518 | 23:41 |
| jgriffith | OH>.. DERP | 23:41 |
| jgriffith | The zmq issue | 23:41 |
| jgriffith | So something that would be helpful if everyone focused on helping to get the requirements updates landed :) | 23:42 |
| jgriffith | then come back to these | 23:42 |
| *** angela-s has quit IRC | 23:42 | |
| jgriffith | we don't want anything else going in to verify until those land | 23:42 |
| jgriffith | or it just gums up the works again | 23:42 |
| patrickeast | makes sense | 23:43 |
| *** IlyaG has quit IRC | 23:43 | |
| jgriffith | patrickeast: granted I'm the one who +2/A'd that patch but it was like 4 hours ago before I really knew we had the issue :) | 23:43 |
| patrickeast | lol | 23:43 |
| dims_ | jgriffith: lol :) | 23:44 |
| jgriffith | :) | 23:44 |
| patrickeast | jgriffith: looks like https://review.openstack.org/#/c/233747/ probably got hit by the merge failure stuff too | 23:45 |
| jgriffith | patrickeast: well.. that's expected :) | 23:45 |
| jgriffith | patrickeast: it's parent hasn't merged | 23:45 |
| jgriffith | patrickeast: so now things are all messed up there | 23:45 |
| jgriffith | patrickeast: if you click on the cherry picked link you can see what I'm talking about | 23:46 |
| patrickeast | jgriffith: its parent? i don't see any dependency on it | 23:46 |
| jgriffith | patrickeast: it's a cherry pick from https://review.openstack.org/#/c/233528/, which hasn't merged | 23:46 |
| jgriffith | :( | 23:46 |
| jgriffith | and it appears that mriedem pointed out that maybe that should be changed anyway | 23:47 |
| patrickeast | oh what, cherry-pick makes it wait until the first one merges? | 23:47 |
| jgriffith | patrickeast: it has to | 23:47 |
| patrickeast | i thought it was just a documentation thing | 23:47 |
| patrickeast | why? they are on separate branches | 23:47 |
| jgriffith | patrickeast: if you cherry pick and it doesn't align with master then the world bursts into a huge atomic fireball | 23:47 |
| patrickeast | lol | 23:48 |
| *** vmtrooper has quit IRC | 23:48 | |
| jgriffith | patrickeast: so if you think about it... the way we manage stable is backporting fixes that land in master right? | 23:48 |
| patrickeast | yea | 23:48 |
| jgriffith | patrickeast: so we don't want to backport something that hasn't landed... because, well who knows. Maybe that change will never land, maybe it's borked... maybe it needs to be changed from a 400 to a 500 :) | 23:49 |
| patrickeast | but there isn't (afaik) anything that forces it to be in master first other than convention | 23:49 |
| jgriffith | patrickeast: and then your backport is wrong and you introduced a new bug to stable :( | 23:49 |
| patrickeast | yea totally on board there | 23:49 |
| jgriffith | patrickeast: gerrit forces it as you can see by the conflict :) | 23:49 |
| jgriffith | patrickeast: or something we run in the gate at any rate | 23:49 |
| jgriffith | patrickeast: because it's going to try and pull that change id from master, but it's not there so it barfs | 23:50 |
| patrickeast | jgriffith: im not sure of that actually... i think we might have just gotten lucky with zuul breaking | 23:50 |
| jgriffith | patrickeast: see what I mean? | 23:50 |
| patrickeast | jgriffith: yea it would make sense | 23:50 |
| *** zhangjn has joined #openstack-cinder | 23:50 | |
| jgriffith | patrickeast: pretty sure that's how it works... because if you look at the merging process it's pulling commit ID's from master | 23:50 |
| jgriffith | patrickeast: NOT pulling reviews from gerrit (I think that would end badly) | 23:51 |
| patrickeast | jgriffith: how would that work with conflicts requiring changes to port stuff? | 23:51 |
| patrickeast | jgriffith: it seems like it would have to pull the patch up for review and merge it | 23:51 |
| *** vilobhmm11 has left #openstack-cinder | 23:51 | |
| jgriffith | patrickeast: not following? | 23:51 |
| patrickeast | not automate the cherry-pick | 23:51 |
| jgriffith | ahhh | 23:51 |
| jgriffith | patrickeast: it doesn't automate that stuff anyway | 23:52 |
| jgriffith | patrickeast: so it pulls your patch, and tries to apply it to master | 23:52 |
| jgriffith | patrickeast: if the stuff you need to make it work isn't in master it's not going to work | 23:52 |
| jgriffith | patrickeast: see what I mean? | 23:52 |
| jgriffith | patrickeast: err.. not master | 23:52 |
| jgriffith | patrickeast: now look what you've done | 23:52 |
| jgriffith | patrickeast: you've got me all confused with words :) | 23:53 |
| patrickeast | haha | 23:53 |
| jgriffith | patrickeast: so how about this... I'll be you a beer in Tokyo; that if you wait for those things to all land correctly then reverify your patch in stable/kilo it'll land :) | 23:53 |
| patrickeast | jgriffith: so i think we're on the same page, it merges whatever is in review onto the target branch, right? | 23:53 |
| patrickeast | jgriffith: hah deal | 23:53 |
| jgriffith | patrickeast: I'll leave it as an exercise for you to dig into the depths of our systems to figure out how/why :) | 23:54 |
| *** aorourke is now known as aorourke_afk | 23:54 | |
| jgriffith | sighh | 23:55 |
| jgriffith | but we're never going to get that silly patch to land anyway so none of this matters :( | 23:55 |
| *** stevemar_ has joined #openstack-cinder | 23:56 | |
| jgriffith | patrickeast: https://jenkins07.openstack.org/job/gate-cinder-python34/1421/console | 23:56 |
| patrickeast | is there anything we can do to help it along? | 23:56 |
| jgriffith | :( | 23:56 |
| *** smoriya has joined #openstack-cinder | 23:57 | |
| *** diogogmt has quit IRC | 23:57 | |
| jgriffith | patrickeast: wait and recheck... or find/fix this: https://bugs.launchpad.net/cinder/+bug/1501838 | 23:58 |
| openstack | Launchpad bug 1501838 in Cinder "Tests: lazy load operation of attribute 'snapshot_metadata' cannot proceed" [Undecided,New] | 23:58 |
| *** diogogmt has joined #openstack-cinder | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!