| *** yhayashi has joined #openstack-cinder | 00:00 | |
| sgundur | jgriffith: thanks for your comments | 00:01 |
|---|---|---|
| sgundur | jgriffith: I need to go through your comments and will get back to you tomoro | 00:02 |
| *** zhangjn has joined #openstack-cinder | 00:02 | |
| *** apoorvad has quit IRC | 00:03 | |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: 3PAR: Implement v2 replication (managed) https://review.openstack.org/231201 | 00:06 |
| *** niknakpaddywak has quit IRC | 00:06 | |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: 3PAR: Implement v2 replication (unmanaged) https://review.openstack.org/231245 | 00:06 |
| *** sgundur has quit IRC | 00:07 | |
| *** apoorvad has joined #openstack-cinder | 00:08 | |
| *** akshai has quit IRC | 00:08 | |
| *** EinstCrazy has joined #openstack-cinder | 00:09 | |
| *** gouthamr has quit IRC | 00:09 | |
| *** boris-42 has joined #openstack-cinder | 00:09 | |
| *** davechen has quit IRC | 00:10 | |
| *** mdenny has quit IRC | 00:11 | |
| *** sgotliv_ has joined #openstack-cinder | 00:11 | |
| boris-42 | thingee: jgriffith_away hi there | 00:14 |
| *** sgotliv has quit IRC | 00:14 | |
| boris-42 | thingee: jgriffith_away could you please take a look at OSprofiler spec: https://review.openstack.org/#/c/103825/ I refactored it and make it overall simpler | 00:14 |
| *** openstackgerrit has quit IRC | 00:16 | |
| *** openstackgerrit has joined #openstack-cinder | 00:17 | |
| boris-42 | DuncanT: ^ | 00:17 |
| *** zhangjn has quit IRC | 00:19 | |
| *** EinstCrazy has quit IRC | 00:19 | |
| *** diegows has quit IRC | 00:22 | |
| *** sgotliv_ has quit IRC | 00:22 | |
| openstackgerrit | Merged openstack/cinder: Add guidelines for release notes to devref https://review.openstack.org/248701 | 00:24 |
| *** niknakpaddywak has joined #openstack-cinder | 00:24 | |
| *** pots has joined #openstack-cinder | 00:27 | |
| *** jordant1 has quit IRC | 00:28 | |
| *** pots2 has quit IRC | 00:29 | |
| bardia | I try to run 'tox -e py34' but get this error: http://paste.openstack.org/show/479806/ | 00:31 |
| bardia | am i missing a lib or something? shouldn't the test-requirements.txt include that? | 00:32 |
| bardia | base os: Ubuntu 14.04 | 00:32 |
| kmartin | bardia, "sudo apt-get install python-dev" | 00:37 |
| bardia | already have that. I think it needs python3-dev. Installed that right now and running it. I will update if that was the requirement | 00:37 |
| kmartin | yep, that should fix it | 00:39 |
| *** rebase has quit IRC | 00:39 | |
| bardia | kmartin: thanks | 00:39 |
| *** jwcroppe has joined #openstack-cinder | 00:40 | |
| *** salv-orlando has quit IRC | 00:43 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: Proper error handling for invalid SLO/Workload combination https://review.openstack.org/243837 | 00:44 |
| *** JoseMello has quit IRC | 00:44 | |
| *** r-daneel has quit IRC | 00:55 | |
| *** xyang1 has quit IRC | 00:58 | |
| *** zhangjn has joined #openstack-cinder | 01:00 | |
| *** zhangjn has quit IRC | 01:00 | |
| *** EinstCrazy has joined #openstack-cinder | 01:00 | |
| *** rushil has joined #openstack-cinder | 01:01 | |
| *** zhangjn has joined #openstack-cinder | 01:01 | |
| *** EinstCra_ has joined #openstack-cinder | 01:02 | |
| *** EinstCrazy has quit IRC | 01:06 | |
| *** jerrygb has quit IRC | 01:09 | |
| *** mc_nair has quit IRC | 01:09 | |
| *** jerrygb has joined #openstack-cinder | 01:10 | |
| *** zhangjn has quit IRC | 01:12 | |
| *** jerrygb has quit IRC | 01:14 | |
| *** rebase has joined #openstack-cinder | 01:15 | |
| *** apoorvad has quit IRC | 01:17 | |
| *** zhangjn has joined #openstack-cinder | 01:20 | |
| *** mc_nair has joined #openstack-cinder | 01:22 | |
| *** zhangjn_ has joined #openstack-cinder | 01:27 | |
| *** zhangjn has quit IRC | 01:29 | |
| *** jgriffith_away is now known as jgriffith | 01:30 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - Extend Volume for VMAX3 https://review.openstack.org/248941 | 01:33 |
| *** Lee1092 has joined #openstack-cinder | 01:36 | |
| *** zhenguo has joined #openstack-cinder | 01:38 | |
| *** leeantho_ has quit IRC | 01:43 | |
| *** julim has joined #openstack-cinder | 01:43 | |
| *** edtubill has joined #openstack-cinder | 01:49 | |
| *** bswartz has joined #openstack-cinder | 01:52 | |
| bardia | tox -epy34 -- -n cinder.tests.unit.test_mydriver doesn't work it still runs all the tests. Anyone faced this before? | 01:52 |
| patrickeast | bardia: i vaguely recall seeing something where the py34 ones just look at a text file and don't pass through the additional command line args | 01:59 |
| patrickeast | not 100% sure though | 02:00 |
| *** 17SAD4YI2 has joined #openstack-cinder | 02:00 | |
| *** 17SAD4YI2 has quit IRC | 02:01 | |
| patrickeast | bardia: so like: https://github.com/openstack/cinder/blob/master/tox.ini#L25 for the py27 vs https://github.com/openstack/cinder/blob/master/tox.ini#L41 | 02:01 |
| *** haomaiwa_ has joined #openstack-cinder | 02:01 | |
| bardia | patrickeast: thanks I will just override it | 02:01 |
| *** niknakpaddywak has quit IRC | 02:05 | |
| *** gcb has joined #openstack-cinder | 02:18 | |
| *** apoorvad has joined #openstack-cinder | 02:23 | |
| *** gouthamr has joined #openstack-cinder | 02:34 | |
| openstackgerrit | LisaLi proposed openstack/cinder-specs: Scaling backup service blueprint spec https://review.openstack.org/240978 | 02:34 |
| *** david-ly_ has quit IRC | 02:36 | |
| *** houming has joined #openstack-cinder | 02:39 | |
| *** dims has joined #openstack-cinder | 02:40 | |
| *** jerrygb has joined #openstack-cinder | 02:44 | |
| *** sghanekar__ has quit IRC | 02:44 | |
| *** salv-orlando has joined #openstack-cinder | 02:47 | |
| *** mc_nair has quit IRC | 02:49 | |
| *** smoriya_afk has joined #openstack-cinder | 02:55 | |
| *** smoriya_afk is now known as smoriya | 02:55 | |
| *** rebase has quit IRC | 02:56 | |
| *** salv-orlando has quit IRC | 02:59 | |
| *** bardia has quit IRC | 03:00 | |
| *** haomaiwa_ has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-cinder | 03:01 | |
| *** smoriya has quit IRC | 03:03 | |
| *** jwcroppe has quit IRC | 03:05 | |
| *** smoriya_afk has joined #openstack-cinder | 03:05 | |
| *** smoriya_afk is now known as smoriya | 03:06 | |
| *** jwcroppe has joined #openstack-cinder | 03:06 | |
| *** jwcroppe has quit IRC | 03:11 | |
| *** jerrygb has quit IRC | 03:11 | |
| *** jerrygb has joined #openstack-cinder | 03:13 | |
| *** diablo_rojo has joined #openstack-cinder | 03:15 | |
| *** dims has quit IRC | 03:17 | |
| *** dims has joined #openstack-cinder | 03:22 | |
| *** diablo_rojo has quit IRC | 03:24 | |
| *** pcaruana has quit IRC | 03:27 | |
| *** apoorvad has quit IRC | 03:27 | |
| *** sghanekar__ has joined #openstack-cinder | 03:32 | |
| *** dims has quit IRC | 03:35 | |
| *** smoriya has quit IRC | 03:38 | |
| *** smoriya_afk has joined #openstack-cinder | 03:39 | |
| *** smoriya_afk is now known as smoriya | 03:39 | |
| *** asselin has joined #openstack-cinder | 03:51 | |
| *** asselin_ has joined #openstack-cinder | 03:52 | |
| *** sgundur has joined #openstack-cinder | 03:57 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 04:01 | |
| *** zhangjn_ has quit IRC | 04:02 | |
| *** smoriya has quit IRC | 04:03 | |
| *** smoriya_afk has joined #openstack-cinder | 04:04 | |
| *** smoriya_afk is now known as smoriya | 04:04 | |
| *** asselin_ has quit IRC | 04:05 | |
| *** asselin has quit IRC | 04:05 | |
| *** jwcroppe has joined #openstack-cinder | 04:08 | |
| *** david-lyle has joined #openstack-cinder | 04:08 | |
| *** akshai has joined #openstack-cinder | 04:10 | |
| *** akshai_ has joined #openstack-cinder | 04:11 | |
| *** akshai has quit IRC | 04:15 | |
| *** sgundur has quit IRC | 04:17 | |
| *** zhangjn has joined #openstack-cinder | 04:22 | |
| *** edtubill has quit IRC | 04:22 | |
| *** jerrygb has quit IRC | 04:24 | |
| *** edtubill has joined #openstack-cinder | 04:24 | |
| *** jwcroppe has quit IRC | 04:27 | |
| *** edtubill has quit IRC | 04:29 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Implement refresh() for cinder objects https://review.openstack.org/248998 | 04:30 |
| *** anish_ is now known as anish | 04:40 | |
| *** zhangjn has quit IRC | 04:44 | |
| *** akshai_ has quit IRC | 05:00 | |
| openstackgerrit | Merged openstack/cinder: Retry on database deadlock on service_update method https://review.openstack.org/245299 | 05:00 |
| *** haomaiwa_ has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-cinder | 05:01 | |
| *** jwcroppe has joined #openstack-cinder | 05:04 | |
| *** rcernin has joined #openstack-cinder | 05:16 | |
| *** sghanekar__ has quit IRC | 05:17 | |
| *** haomaiwang has quit IRC | 05:19 | |
| *** deepakcs has joined #openstack-cinder | 05:21 | |
| *** zhangjn has joined #openstack-cinder | 05:23 | |
| *** gcb has quit IRC | 05:24 | |
| jgriffith | patrickeast: bardia: FYI, it's because py34 uses a whitelist argument | 05:24 |
| jgriffith | patrickeast: the tox invocation of ostestr doesn't provide the same options | 05:24 |
| patrickeast | jgriffith: yea, once i looked at the tox.ini file it makes sense | 05:27 |
| *** haomaiwa_ has joined #openstack-cinder | 05:27 | |
| *** smoriya has quit IRC | 05:29 | |
| jgriffith | patrickeast: :) | 05:29 |
| *** deepakcs has quit IRC | 05:32 | |
| *** rcernin has quit IRC | 05:34 | |
| lixiaoy1 | jgriffith: Hi John, may I talk to you about https://review.openstack.org/#/c/244964/? | 05:35 |
| jgriffith | lixiaoy1: sure... BTW I removed my -1 incase you didn't see | 05:35 |
| lixiaoy1 | I see. I am just concerned about your comments. | 05:36 |
| jgriffith | lixiaoy1: which ones? The part about somewhat useless types being created/used? | 05:36 |
| jgriffith | lixiaoy1: your change doesn't really hurt anything, I am curious if maybe there's a special case that I'm not thinking of though | 05:37 |
| lixiaoy1 | that I think doing this in a driver that doesn't use extra-specs for anything is kinda wrong. There. if two types, type A has volume_backend_name specified, and type B has nothing, when retyping a volume from type A to type B | 05:37 |
| *** EinstCra_ has quit IRC | 05:37 | |
| *** EinstCrazy has joined #openstack-cinder | 05:37 | |
| lixiaoy1 | the scheduler will select the original host, and then retype | 05:37 |
| lixiaoy1 | as a result, it leads that retype a volume in a same host | 05:38 |
| jgriffith | lixiaoy1: so step back, and think of it as a system with only a single volum-service/backend configured | 05:38 |
| lixiaoy1 | may the two types have different front-end QoS, volume in available status | 05:39 |
| jgriffith | lixiaoy1: well, my point was in LVM's case any extra-specs (QoS or otherwise) don't do anything at all | 05:40 |
| jgriffith | lixiaoy1: I think I figured out the case you and tbarron mentioned about it kicking off migration though | 05:40 |
| lixiaoy1 | ooh, you mean may something lost for extra_specs in lvm, need to do | 05:41 |
| lixiaoy1 | ? | 05:41 |
| jgriffith | lixiaoy1: but last I looked we don't do migration by default, you have to specify that you want to allow it | 05:41 |
| *** shausy has joined #openstack-cinder | 05:41 | |
| *** gcb has joined #openstack-cinder | 05:41 | |
| jgriffith | lixiaoy1: so what I mean is; if you're setting up extra-specs for an LVM volume (other than encryption I think) it's pointless and does nothing | 05:41 |
| jgriffith | lixiaoy1: so in a way, I'm not sure if that should be valid or not | 05:42 |
| jgriffith | lixiaoy1: in other words I don't know which is right/wrong... reporting success and saying you did something that you really didn't, or since it's a noop just saying "ok, done" | 05:42 |
| jgriffith | lixiaoy1: I was also confused because I was unable to produce a failure case | 05:43 |
| *** deepakcs has joined #openstack-cinder | 05:43 | |
| jgriffith | lixiaoy1: so it's kind of a gray area for me, but your patch is probably the more correct thing to do at this point | 05:46 |
| lixiaoy1 | oh, I see. but extra_specs is valid or not, this should be checked when type is created? | 05:48 |
| *** harlowja_at_home has joined #openstack-cinder | 05:48 | |
| lixiaoy1 | I mean when extra_specs is set for a type? | 05:49 |
| jgriffith | lixiaoy1: possibly | 05:49 |
| jgriffith | lixiaoy1: honestly it probably adds more confusion than it's worth :( | 05:49 |
| *** pcaruana has joined #openstack-cinder | 05:49 | |
| lixiaoy1 | like I create a extra_specs for a type, "pool=test", but without backend specified | 05:49 |
| jgriffith | lixiaoy1: but what I was thinking was for example, if you had type:foo {key1=V1} | 05:49 |
| jgriffith | and you try and retype that to a specific backend | 05:50 |
| jgriffith | if that backend doesn't know what key "key1" is for, or what it does I'm not sure it should say "ok" | 05:50 |
| jgriffith | lixiaoy1: does that make sense? | 05:50 |
| lixiaoy1 | oh, no. when driver. retype is called, they are same host | 05:51 |
| jgriffith | right | 05:51 |
| jgriffith | lixiaoy1: but my point was that if I say retype and it's same host and it goes to the driver... should the driver be checking what we're feeding it | 05:51 |
| jgriffith | lixiaoy1: or should it just blindly say "ok, pass" | 05:51 |
| *** wilson-liu has quit IRC | 05:53 | |
| jgriffith | lixiaoy1: honestly this is something I don't do in my driver either and have always thought I should go back and fix up | 05:53 |
| *** deepakcs has quit IRC | 05:53 | |
| *** wilson-liu has joined #openstack-cinder | 05:54 | |
| *** salv-orlando has joined #openstack-cinder | 05:56 | |
| lixiaoy1 | "checking what we're feeding it.", you mean to check everything about extra_specs? It seems that in kinds of drivers, it just checks it concens. | 06:00 |
| *** lpetrut has joined #openstack-cinder | 06:00 | |
| *** salv-orlando has quit IRC | 06:01 | |
| *** haomaiwa_ has quit IRC | 06:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 06:02 | |
| jgriffith | lixiaoy1: right, my point was that if I send something to the driver that it doesn't understand or know what to do with it... maybe it should report an error | 06:06 |
| jgriffith | lixiaoy1: instead of pretending that everything worked out and is ok | 06:07 |
| *** gouthamr has quit IRC | 06:09 | |
| lixiaoy1 | jgriffith: I see. It is not just problem of retype, it is related to extra_spec of a volume type. Like setting extra_specs, check the validation. | 06:10 |
| *** gouthamr has joined #openstack-cinder | 06:10 | |
| jgriffith | lixiaoy1: yeah, kinda | 06:10 |
| jgriffith | lixiaoy1: your patch just reminded me of it :( | 06:10 |
| jgriffith | lixiaoy1: lucky you :) | 06:10 |
| lixiaoy1 | jgriffith: seems that we need to split the extra_specs to common and specified for backend | 06:10 |
| *** sghanekar__ has joined #openstack-cinder | 06:11 | |
| jgriffith | lixiaoy1: hehe.. we've tried that | 06:11 |
| *** smoriya_afk has joined #openstack-cinder | 06:11 | |
| lixiaoy1 | jgriffith: any bp? | 06:11 |
| *** smoriya_afk is now known as smoriya | 06:11 | |
| jgriffith | lixiaoy1: somewhere... | 06:11 |
| jgriffith | lixiaoy1: but it's a much more convoluted problem | 06:12 |
| jgriffith | lixiaoy1: keep in mind we have things like scoped keys already | 06:12 |
| lixiaoy1 | jgriffith: this may call historical problem | 06:12 |
| jgriffith | lixiaoy1: :) | 06:12 |
| jgriffith | lixiaoy1: it is indeed | 06:12 |
| jgriffith | lixiaoy1: which is why we should probably just move forward with the work you've already submitted and let sleeping dogs lie :) | 06:13 |
| lixiaoy1 | jgriffith: :) | 06:13 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Storwize: Implement v2 replication (split IO) https://review.openstack.org/237387 | 06:15 |
| lixiaoy1 | jgriffith: oh, may I ask you whether we will have cinder meeting this Wednesday? as thanks giving | 06:15 |
| jgriffith | lixiaoy1: ya know, that's a great question | 06:15 |
| jgriffith | lixiaoy1: seems a number of people are off perhaps | 06:15 |
| * jgriffith checks wiki page | 06:15 | |
| jgriffith | lixiaoy1: I suspect there are a lot of folks in the states that will be offline that day | 06:16 |
| jgriffith | lixiaoy1: and there's nothing on the schedule as of yet | 06:16 |
| lixiaoy1 | yeah | 06:17 |
| lixiaoy1 | so I asked the questions. In fact, I have a patch about moving volume/encryptors to os-brick. And now is under discusion in Nova and Cinder | 06:17 |
| jgriffith | lixiaoy1: yes, I read the ML posting this morning | 06:18 |
| jgriffith | lixiaoy1: you've been busy :) | 06:18 |
| *** arnewiebalck__ has joined #openstack-cinder | 06:18 | |
| lixiaoy1 | no, I just have this thing | 06:18 |
| lixiaoy1 | this is fundation of my later work | 06:18 |
| jgriffith | ahhh... got ya | 06:18 |
| lixiaoy1 | any suggestions? | 06:19 |
| *** rcernin has joined #openstack-cinder | 06:19 | |
| lixiaoy1 | Nova people Daniel said Cinder not trusted, :( | 06:19 |
| *** liverpooler has joined #openstack-cinder | 06:19 | |
| jgriffith | lixiaoy1: well... I refrained from inserting my opinion :) | 06:19 |
| jgriffith | lixiaoy1: I kind of agree with his viewpoint | 06:19 |
| *** sgotliv has joined #openstack-cinder | 06:19 | |
| jgriffith | lixiaoy1: I was less concerned about the whole who is/isn't trusted thing | 06:20 |
| lixiaoy1 | but if we don't attach, we can't do a lot of things | 06:20 |
| jgriffith | lixiaoy1: but.. IMHO decrypting and backing up, then restoring unencrypted, and copying to glance etc | 06:20 |
| *** arnewiebalck_ has quit IRC | 06:20 | |
| jgriffith | lixiaoy1: sort of defeats the purpose of a user choosing to encrypt their data doesn't it? | 06:20 |
| lixiaoy1 | backing up/restore are not related to encryption/decryption | 06:21 |
| jgriffith | lixiaoy1: it sort of seems to me that encrypted volumes are a special case and it is probably "ok" for them to not be able to do all things a regular volume can | 06:21 |
| lixiaoy1 | jgriffith: the most important case I am concerned is that I create an encypted volume from image | 06:21 |
| jgriffith | lixiaoy1: well... backup was mentioned by somebody in the posting | 06:21 |
| lixiaoy1 | I think that 's not correct | 06:21 |
| jgriffith | lixiaoy1: yes.. that is the single case that I can agree with | 06:22 |
| lixiaoy1 | second one is that users want to retype a non-encrypted volume to encrypted | 06:22 |
| jgriffith | lixiaoy1: yeah, that's an interesting one too | 06:22 |
| jgriffith | I hadn't thought of that case.. | 06:22 |
| lixiaoy1 | these are two items I think we need to add | 06:22 |
| jgriffith | lixiaoy1: I certainly wouldn't argue against your first case | 06:23 |
| jgriffith | BTW.. DuncanT also mentions encryption at rest in the thread which confused me | 06:23 |
| lixiaoy1 | you mean that uploading encrypted volumes to image? | 06:24 |
| *** chirag has joined #openstack-cinder | 06:25 | |
| jgriffith | lixiaoy1: here's a list of cases that hemna called out: http://lists.openstack.org/pipermail/openstack-dev/2015-November/080072.html | 06:25 |
| jgriffith | lixiaoy1: backup is indeed on that list | 06:26 |
| jgriffith | lixiaoy1: as well as copy volume->image | 06:26 |
| jgriffith | lixiaoy1: I don't think either of those cases are valid | 06:26 |
| jgriffith | lixiaoy1: I would agree with you WRT image->volume however | 06:26 |
| jgriffith | lixiaoy1: also the idea of retyping to encrypted | 06:27 |
| jgriffith | lixiaoy1: my recommendation was going to be use nova to do those things | 06:27 |
| jgriffith | lixiaoy1: it's ugly... but it keeps the data secure | 06:27 |
| jgriffith | lixiaoy1: in other words we'd have a dependency on Nova for those special cases | 06:28 |
| lixiaoy1 | how to use nova to create a bootable encrypted volume? | 06:28 |
| jgriffith | lixiaoy1: :) | 06:28 |
| jgriffith | lixiaoy1: like we used to do in the old days :) | 06:28 |
| jgriffith | boot an instance, attach a volume and dd | 06:28 |
| lixiaoy1 | no, we gave wrong data in the old days | 06:28 |
| *** pcaruana has quit IRC | 06:28 | |
| jgriffith | lixiaoy1: back in nova-volume days? | 06:28 |
| lixiaoy1 | Please forget my last words. | 06:29 |
| chirag | Hello Everyone, I am facing a problem in cinder backup. Any help would be great. I am using kilo release and have integrated swift for cinder volume backup. During a backup I restarted cinder backup-service and now my volume status is stuck at "backing-up". I am not able to use that volume now. anyone any idea? | 06:29 |
| lixiaoy1 | dd? is that too argly? | 06:29 |
| lixiaoy1 | sorry | 06:29 |
| jgriffith | chirag: is there a reset state for backups in Kilo? | 06:30 |
| lixiaoy1 | chirag: do you restart cinder backup service in same host? | 06:30 |
| chirag | @jgriffith I am not sure of that | 06:31 |
| jgriffith | chirag: you can try reset state... if that doesn't work you may have to update the column in the db by hand :( | 06:31 |
| jgriffith | chirag: assuming you have admin priveleges | 06:31 |
| *** rushil has quit IRC | 06:32 | |
| jgriffith | chirag: you should be able to reset state to available | 06:32 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Zanata https://review.openstack.org/249029 | 06:32 |
| chirag | @lixiaoy1 no swift and cinder are on differnt host | 06:32 |
| chirag | would try using reset | 06:32 |
| jgriffith | chirag: I think lixiaoy1 means the cinder-backup service | 06:32 |
| lixiaoy1 | yes | 06:33 |
| lixiaoy1 | @chirag: current it will clean the backing backup to error state | 06:33 |
| chirag | sorry . . Yes I restarted on same host | 06:33 |
| chirag | ok would try reset | 06:33 |
| lixiaoy1 | jgriffith: I think dd is too trouble. If a lot vm to start from encrypted volumes, do users need to dd one by one? as they need different keys | 06:35 |
| lixiaoy1 | jgriffith: key I mean encryption key | 06:35 |
| chirag | thanks it worked :) | 06:38 |
| jgriffith | chirag: cool! | 06:38 |
| jgriffith | lixiaoy1: well actually that's how we do it in cinder anyway :) | 06:38 |
| jgriffith | qemu-convert --> dd > block-device | 06:38 |
| lixiaoy1 | jgriffith: but not manual. | 06:39 |
| *** e0ne has joined #openstack-cinder | 06:40 | |
| lixiaoy1 | jgriffith: I think this is collide with our future goal, independent SDS | 06:41 |
| *** chirag has quit IRC | 06:41 | |
| jgriffith | lixiaoy1: haha.. you've got me there! | 06:42 |
| lixiaoy1 | jgriffith: yeah. | 06:42 |
| *** deepakcs has joined #openstack-cinder | 06:43 | |
| lixiaoy1 | jgriffith: thank you John. Glad to talk with you. nice day | 06:44 |
| jgriffith | lixiaoy1: you as well! | 06:44 |
| jgriffith | lixiaoy1: I'll think about that encryption stuff a bit more | 06:44 |
| jgriffith | lixiaoy1: don't know that I'll offer any valuable input or not | 06:45 |
| lixiaoy1 | jgriffith: yes | 06:45 |
| *** sghanekar__ has quit IRC | 06:45 | |
| *** EinstCrazy has quit IRC | 06:45 | |
| lixiaoy1 | jgriffith: yes is to "think about encryption more" | 06:46 |
| lixiaoy1 | jgriffith: of course valuable, at least I know how to answer why not call nova to do encryption | 06:46 |
| jgriffith | :) | 06:46 |
| lixiaoy1 | cinder people is first I have to persuade | 06:47 |
| *** lpetrut has quit IRC | 06:47 | |
| e0ne | jgriffith: hi. did you change timezone? :) | 06:47 |
| jgriffith | e0ne: LOL.. nope | 06:48 |
| jgriffith | e0ne: oh dear.. it's late :) | 06:48 |
| e0ne | jgriffith: oh.. good. I'll ping you in ~10-12 hours later:) | 06:48 |
| lixiaoy1 | sorry John, take you too much time | 06:48 |
| jgriffith | e0ne: haha!! Ok, sounds good | 06:48 |
| jgriffith | lixiaoy1: nahh.. not at all | 06:48 |
| *** ankit_ag has joined #openstack-cinder | 06:48 | |
| *** boris-42 has quit IRC | 06:48 | |
| e0ne | jgriffith: I was a bit surprised to see you here at 9am | 06:49 |
| *** EinstCrazy has joined #openstack-cinder | 06:49 | |
| jgriffith | lixiaoy1: I'm catching up on podcasts and reading :) | 06:49 |
| e0ne | (9am in UTC+3 TZ) | 06:49 |
| jgriffith | e0ne: I'm usually around til about now.. just quiet :) | 06:49 |
| jgriffith | e0ne: incognito :) | 06:49 |
| e0ne | oh... so looks like I'm here too early | 06:49 |
| jgriffith | hehe! | 06:50 |
| jgriffith | e0ne: you're pretty much always here aren't you? | 06:50 |
| lixiaoy1 | eOne: welcome early! you know in | 06:50 |
| e0ne | jgriffith: usually, I'm here since 11-12 am im my tz | 06:50 |
| lixiaoy1 | eOne: we may have a lot of questions or requirements to talk with you. | 06:50 |
| e0ne | lixiaoy1: sure. will you be available here in 3 hours? or at least I need to make my morning coffe | 06:51 |
| lixiaoy1 | eOne: OK | 06:52 |
| e0ne | lixiaoy1: what timezone are you in? | 06:52 |
| lixiaoy1 | eOne: 3 hours is ok | 06:52 |
| lixiaoy1 | 3 hours later | 06:52 |
| lixiaoy1 | eOne:utc+8, Iam in China | 06:52 |
| e0ne | good. I'll finish my morning busineses and head to office | 06:53 |
| e0ne | lixiaoy1: ok, I'll be there next week:) | 06:53 |
| e0ne | lixiaoy1: I'll ping you here later today | 06:53 |
| lixiaoy1 | eOne: oh, which city are you coming? | 06:53 |
| *** amrith is now known as _amrith_ | 06:54 | |
| e0ne | lixiaoy1: Nanjing | 06:54 |
| wanghao | jgriffith: hi, John, nice to see you here. | 06:54 |
| e0ne | lixiaoy1: hit: my nickname contains 'zero' symbol: | 06:54 |
| e0ne | :) | 06:54 |
| lixiaoy1 | 0: like this? | 06:54 |
| e0ne | yep | 06:54 |
| lixiaoy1 | e0ne: oh, sorry | 06:55 |
| e0ne | np. It's not a big deal. it's just enable or disable notifications | 06:55 |
| lixiaoy1 | e0ne: I am in Shanghai, welcome to China | 06:56 |
| lixiaoy1 | wanghao: It is too late for John. Seems he has gone | 06:56 |
| wanghao | lixiaoy1: Ops, bad luck... | 06:56 |
| wanghao | lixaoy1: What's John's TZ? | 06:57 |
| wanghao | lixiaoy1: Maybe I need to ping him early. | 06:58 |
| *** haomaiwa_ has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-cinder | 07:01 | |
| wanghao | e0ne: Hi , lucky you're here. I update the use case about this bp:https://review.openstack.org/#/c/182150/. Would you like to review this again if you have free time. | 07:03 |
| wanghao | lixiaoy1: Will you attend the next Hackthon in china? | 07:06 |
| wanghao | lixiaoy1: It will be in Chengdu I think. | 07:06 |
| *** e0ne has quit IRC | 07:08 | |
| *** lpetrut has joined #openstack-cinder | 07:08 | |
| lixiaoy1 | wanghao: not sure:) | 07:08 |
| lixiaoy1 | wanghao: hope I can. you will join, yes? | 07:08 |
| lixiaoy1 | wanghao: e0ne will be back in 3 hours | 07:09 |
| wanghao | lixiaoy1: Yes, I think I will go there. | 07:09 |
| wanghao | lixiaoy1: Got it. | 07:09 |
| wanghao | lixiaoy1: It's will great if you can join. | 07:10 |
| *** nkrinner has joined #openstack-cinder | 07:10 | |
| openstackgerrit | Deepti Ramakrishna proposed openstack/cinder: CG API should return volume type IDs https://review.openstack.org/245624 | 07:10 |
| lixiaoy1 | wanghao: I will try | 07:10 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Storwize: Implement v2 replication (global) https://review.openstack.org/249042 | 07:11 |
| wanghao | lixiaoy1: :) | 07:11 |
| jgriffith | night all | 07:14 |
| *** jgriffith is now known as jgriffith_away | 07:15 | |
| *** harlowja_at_home has quit IRC | 07:23 | |
| *** lpetrut has quit IRC | 07:27 | |
| *** jerrygb has joined #openstack-cinder | 07:37 | |
| openstackgerrit | Bardia Keyoumarsi proposed openstack/cinder: Volume driver for Coho Data storage solutions https://review.openstack.org/246690 | 07:41 |
| *** jerrygb has quit IRC | 07:42 | |
| *** smoriya has quit IRC | 07:44 | |
| *** smoriya_afk has joined #openstack-cinder | 07:46 | |
| *** smoriya_afk is now known as smoriya | 07:46 | |
| openstackgerrit | Shay Halsband proposed openstack/cinder: XtremIO: fix iscsi chap discovery bug https://review.openstack.org/249051 | 07:50 |
| *** anshul has joined #openstack-cinder | 07:58 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 08:02 | |
| openstackgerrit | Shay Halsband proposed openstack/cinder: XtremIO fix attach readonly bug https://review.openstack.org/245527 | 08:02 |
| *** [1]Thelo has joined #openstack-cinder | 08:04 | |
| *** Thelo has quit IRC | 08:06 | |
| *** [1]Thelo is now known as Thelo | 08:06 | |
| *** lpetrut has joined #openstack-cinder | 08:10 | |
| *** jerrygb has joined #openstack-cinder | 08:12 | |
| *** salv-orlando has joined #openstack-cinder | 08:13 | |
| *** jerrygb has quit IRC | 08:17 | |
| *** arnewiebalck_ has joined #openstack-cinder | 08:19 | |
| *** salv-orlando has quit IRC | 08:21 | |
| *** arnewiebalck___ has joined #openstack-cinder | 08:22 | |
| *** arnewiebalck__ has quit IRC | 08:22 | |
| *** arnewiebalck_ has quit IRC | 08:25 | |
| *** salv-orlando has joined #openstack-cinder | 08:29 | |
| *** salv-orlando has quit IRC | 08:33 | |
| *** subscope has joined #openstack-cinder | 08:36 | |
| *** arnewiebalck___ has quit IRC | 08:39 | |
| *** arnewiebalck_ has joined #openstack-cinder | 08:40 | |
| *** markus_z has joined #openstack-cinder | 08:45 | |
| *** subscope has quit IRC | 08:48 | |
| *** e0ne has joined #openstack-cinder | 08:49 | |
| *** subscope has joined #openstack-cinder | 08:52 | |
| *** jordanP has joined #openstack-cinder | 08:59 | |
| *** haomaiwa_ has quit IRC | 09:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 09:01 | |
| e0ne | lixiaoy1: I'm back. dou you still have any questions to me? | 09:03 |
| openstackgerrit | wuyuting proposed openstack/cinder: Declare multiattach is True in RBD driver https://review.openstack.org/249080 | 09:05 |
| *** subscope has quit IRC | 09:09 | |
| *** subscope has joined #openstack-cinder | 09:10 | |
| *** vgridnev has joined #openstack-cinder | 09:15 | |
| *** openstackgerrit has quit IRC | 09:16 | |
| *** openstackgerrit has joined #openstack-cinder | 09:17 | |
| openstackgerrit | wuyuting proposed openstack/cinder: Declare multiattach is True in RBD driver https://review.openstack.org/249080 | 09:20 |
| *** pschaef has joined #openstack-cinder | 09:21 | |
| *** ndipanov has quit IRC | 09:25 | |
| *** ndipanov has joined #openstack-cinder | 09:26 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Implement snapshots-related features for Block Device Driver https://review.openstack.org/222292 | 09:26 |
| *** mdbooth has joined #openstack-cinder | 09:27 | |
| openstackgerrit | wanghao proposed openstack/python-cinderclient: support for snapshot management https://review.openstack.org/249090 | 09:28 |
| *** arnewiebalck__ has joined #openstack-cinder | 09:33 | |
| *** arnewiebalck_ has quit IRC | 09:33 | |
| *** subscope has quit IRC | 09:37 | |
| *** ociuhandu has quit IRC | 09:42 | |
| *** jistr has joined #openstack-cinder | 09:44 | |
| yuriy_n17 | Duncan: Hi | 09:48 |
| *** zhangjn has quit IRC | 09:48 | |
| *** EinstCrazy has quit IRC | 09:48 | |
| yuriy_n17 | DuncanT: Hi | 09:49 |
| *** arnewiebalck_ has joined #openstack-cinder | 09:53 | |
| *** arnewiebalck__ has quit IRC | 09:53 | |
| *** andymaier has joined #openstack-cinder | 09:54 | |
| *** alexschm has joined #openstack-cinder | 09:55 | |
| *** haomaiwa_ has quit IRC | 10:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 10:02 | |
| *** zhenguo has quit IRC | 10:02 | |
| e0ne | DuncanT: hi. one proposal about imageutils from oslo-incubator. seems to be better to move it to oslo.utils. it's used by nova and ironic too | 10:04 |
| *** aix has joined #openstack-cinder | 10:05 | |
| e0ne | dulek: ^^ | 10:08 |
| *** gcb has quit IRC | 10:11 | |
| *** pschaef has quit IRC | 10:18 | |
| *** houming has quit IRC | 10:21 | |
| *** arnewiebalck_ has quit IRC | 10:23 | |
| *** arnewiebalck_ has joined #openstack-cinder | 10:23 | |
| *** arnewiebalck__ has joined #openstack-cinder | 10:30 | |
| *** arnewiebalck_ has quit IRC | 10:30 | |
| *** subscope has joined #openstack-cinder | 10:30 | |
| *** lixiaoy1 has quit IRC | 10:30 | |
| *** andymaier has left #openstack-cinder | 10:31 | |
| *** andymaier has joined #openstack-cinder | 10:31 | |
| *** lixiaoy1 has joined #openstack-cinder | 10:31 | |
| lixiaoy1 | DuncanT: e0ne: I hope I can get suggestions about "copy encryptors from nova to os-brick" | 10:33 |
| lixiaoy1 | https://review.openstack.org/#/c/247372/ | 10:33 |
| *** arnewiebalck_ has joined #openstack-cinder | 10:33 | |
| *** arnewiebalck__ has quit IRC | 10:35 | |
| *** salv-orlando has joined #openstack-cinder | 10:38 | |
| *** subscope has quit IRC | 10:41 | |
| *** salv-orlando has quit IRC | 10:42 | |
| *** markus_z has quit IRC | 10:47 | |
| *** lprice1 has joined #openstack-cinder | 10:55 | |
| *** lprice has quit IRC | 10:55 | |
| *** bswartz has quit IRC | 10:56 | |
| *** lixiaoy1 has left #openstack-cinder | 10:57 | |
| *** lixiaoy1_ has joined #openstack-cinder | 10:58 | |
| geguileo | Anybody else getting 503 errors from review.openstack.org? | 10:59 |
| *** lixiaoy1_ is now known as lixiaoy1 | 10:59 | |
| *** bswartz has joined #openstack-cinder | 11:00 | |
| *** haomaiwa_ has quit IRC | 11:01 | |
| *** haomaiwang has joined #openstack-cinder | 11:01 | |
| geguileo | Ok, working again | 11:02 |
| *** dims has joined #openstack-cinder | 11:06 | |
| *** _amrith_ is now known as amrith | 11:06 | |
| *** houming has joined #openstack-cinder | 11:08 | |
| *** EinstCrazy has joined #openstack-cinder | 11:08 | |
| *** EinstCrazy has quit IRC | 11:09 | |
| *** EinstCrazy has joined #openstack-cinder | 11:09 | |
| *** rcernin is now known as rcernin|lunch | 11:13 | |
| *** aix has quit IRC | 11:14 | |
| *** aix has joined #openstack-cinder | 11:15 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port IBM storewize_svc driver to Python 3 https://review.openstack.org/242878 | 11:18 |
| lixiaoy1 | geguileo:Hi Gorka, with your spec "remove cinder api races", can c-api run A-A? | 11:18 |
| openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Add some missing fields to Volume object https://review.openstack.org/240847 | 11:19 |
| *** ociuhandu has joined #openstack-cinder | 11:21 | |
| *** jwcroppe has quit IRC | 11:29 | |
| nikeshm | hi | 11:31 |
| *** jwcroppe has joined #openstack-cinder | 11:32 | |
| dulek | lixiaoy1: Nope, there's a lot of other problems. Take a look at https://review.openstack.org/#/c/232599/ | 11:35 |
| *** jwcroppe has quit IRC | 11:36 | |
| dulek | lixiaoy1: Ah, you've meant c-api. I believe we're having problems with race conditions even with single API service (we have multiple workers). | 11:36 |
| dulek | lixiaoy1: So running multiple c-api may make these cases more visible. But I believe people run multiple c-api's. | 11:37 |
| *** amrith is now known as _amrith_ | 11:37 | |
| openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Skip unsupported datastore types https://review.openstack.org/249150 | 11:41 |
| *** markus_z has joined #openstack-cinder | 11:43 | |
| DuncanT | lixiaoy1: My only suggestion at this point is to let the discussion run for a while, it will take time for people to come to an agreement | 11:48 |
| nikeshm | DuncanT: any idea about ATC coupons, i have contributed in liberty release so will i get coupon for mitaka ? | 11:52 |
| DuncanT | e0ne: Moving it to oslo.utils seems entirely reasonable | 11:52 |
| DuncanT | nikeshm: I've no idea, sorry. I suggest you keep contributing just to be sure ;-) | 11:53 |
| *** gcb has joined #openstack-cinder | 11:53 | |
| e0ne | DuncanT: thanks. I just wanted to confirm it. patch is already proposed: https://review.openstack.org/#/c/249107/ | 11:53 |
| nikeshm | DuncanT: thanks | 11:53 |
| *** Rekha has quit IRC | 11:54 | |
| dulek | nikeshm: The policy is getting less-inclusive each release. For Liberty summit only contributors to Liberty release were given ATC status (and coupons). I would expect it to be similar for Mitaka. | 11:55 |
| *** markus_z is now known as markus_z_meeting | 11:59 | |
| *** subscope has joined #openstack-cinder | 12:00 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 12:02 | |
| *** alexschm has quit IRC | 12:04 | |
| *** alexschm has joined #openstack-cinder | 12:05 | |
| nikeshm | dulex: thanks | 12:09 |
| *** subscope has quit IRC | 12:13 | |
| *** subscope has joined #openstack-cinder | 12:14 | |
| *** salv-orlando has joined #openstack-cinder | 12:17 | |
| *** zhangjn has joined #openstack-cinder | 12:18 | |
| *** zhangjn has quit IRC | 12:18 | |
| *** zhangjn has joined #openstack-cinder | 12:19 | |
| *** zhangjn has quit IRC | 12:20 | |
| *** zhangjn has joined #openstack-cinder | 12:20 | |
| *** zhangjn has quit IRC | 12:20 | |
| *** zhangjn has joined #openstack-cinder | 12:21 | |
| *** zhangjn has quit IRC | 12:22 | |
| *** salv-orlando has quit IRC | 12:22 | |
| *** zhangjn has joined #openstack-cinder | 12:22 | |
| *** zhangjn has quit IRC | 12:23 | |
| *** EinstCrazy has quit IRC | 12:26 | |
| *** EinstCrazy has joined #openstack-cinder | 12:28 | |
| *** zhangjn has joined #openstack-cinder | 12:29 | |
| *** deepakcs has quit IRC | 12:31 | |
| *** jwcroppe has joined #openstack-cinder | 12:33 | |
| *** zhangjn has quit IRC | 12:33 | |
| *** zhangjn has joined #openstack-cinder | 12:34 | |
| openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Unit test refactoring https://review.openstack.org/249174 | 12:34 |
| *** alejandrito has joined #openstack-cinder | 12:34 | |
| *** EinstCra_ has joined #openstack-cinder | 12:35 | |
| *** EinstCrazy has quit IRC | 12:35 | |
| openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Unit test refactoring https://review.openstack.org/249175 | 12:36 |
| *** rcernin|lunch is now known as rcernin | 12:36 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Block subtractive operations in DB migrations https://review.openstack.org/248768 | 12:39 |
| openstackgerrit | Ronen Mesonzhnik proposed openstack/cinder-specs: Support backup import on another Storage database https://review.openstack.org/249176 | 12:39 |
| *** diegows has joined #openstack-cinder | 12:40 | |
| *** wolsen has quit IRC | 12:41 | |
| *** zhipeng has joined #openstack-cinder | 12:42 | |
| *** yhayashi has quit IRC | 12:43 | |
| *** subscope has quit IRC | 12:44 | |
| *** isaacb has joined #openstack-cinder | 12:45 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Implement snapshots-related features for Block Device Driver https://review.openstack.org/222292 | 12:45 |
| openstackgerrit | Ronen Mesonzhnik proposed openstack/cinder-specs: Support backup import on another Storage database https://review.openstack.org/249176 | 12:46 |
| *** subscope has joined #openstack-cinder | 12:46 | |
| *** jwcroppe has quit IRC | 12:50 | |
| *** gcb has quit IRC | 12:51 | |
| *** andymaier has quit IRC | 12:59 | |
| *** haomaiwa_ has quit IRC | 13:01 | |
| *** markus_z_meeting is now known as markus_z | 13:01 | |
| *** haomaiwang has joined #openstack-cinder | 13:01 | |
| *** zhenguo has joined #openstack-cinder | 13:01 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Implement snapshots-related features for Block Device Driver https://review.openstack.org/222292 | 13:01 |
| *** gcb has joined #openstack-cinder | 13:04 | |
| *** houming has quit IRC | 13:04 | |
| *** salv-orl_ has joined #openstack-cinder | 13:05 | |
| *** marcusvrn_ has quit IRC | 13:05 | |
| tbarron | smcginnis: We now have a registration link for the hotel for the mid-cycle meetup: http://hiltongardeninn.hilton.com/en/gi/groups/personalized/R/RDUSPGI-NET-20160125/index.jhtml | 13:06 |
| tbarron | smcginnis: please take a look and make sure it looks sane | 13:06 |
| tbarron | smcginnis: if so, I'll update the etherpad accordingly and you can send a followup announcement to the list | 13:07 |
| openstackgerrit | Ronen Mesonzhnik proposed openstack/cinder: Add get_extra_metadata to nfs backup driver https://review.openstack.org/153969 | 13:11 |
| *** akerr has joined #openstack-cinder | 13:11 | |
| *** haomaiwang has quit IRC | 13:11 | |
| openstackgerrit | Ronen Mesonzhnik proposed openstack/cinder: Add get_extra_metadata to nfs backup driver https://review.openstack.org/153969 | 13:12 |
| *** bluex has joined #openstack-cinder | 13:12 | |
| *** bluex has quit IRC | 13:12 | |
| *** bluex has joined #openstack-cinder | 13:13 | |
| *** wolsen has joined #openstack-cinder | 13:14 | |
| openstackgerrit | Merged openstack/cinder: XtremIO fix attach readonly bug https://review.openstack.org/245527 | 13:16 |
| *** shausy has quit IRC | 13:23 | |
| openstackgerrit | Ronen Mesonzhnik proposed openstack/cinder: Support backup import on another Storage database https://review.openstack.org/153969 | 13:25 |
| *** markvoelker has quit IRC | 13:35 | |
| *** diablo_rojo has joined #openstack-cinder | 13:42 | |
| *** martyturner has joined #openstack-cinder | 13:46 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Remove stubs and add resource cleanup https://review.openstack.org/249218 | 13:46 |
| *** haomaiwang has joined #openstack-cinder | 13:49 | |
| *** markvoelker has joined #openstack-cinder | 13:53 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Remove stubs and add resource cleanup https://review.openstack.org/249218 | 13:57 |
| *** houming has joined #openstack-cinder | 13:57 | |
| *** salv-orl_ has quit IRC | 14:00 | |
| *** zhangjn has quit IRC | 14:00 | |
| *** subscope has quit IRC | 14:00 | |
| *** haomaiwang has quit IRC | 14:01 | |
| smcginnis | tbarron: That looks good, thanks! | 14:01 |
| smcginnis | tbarron: You were able to get them to change the restruction of NetApp paying for any unused rooms, right? | 14:01 |
| *** haomaiwa_ has joined #openstack-cinder | 14:01 | |
| tbarron | smcginnis: yes | 14:01 |
| smcginnis | tbarron: Awesome. Thanks for taking care of that. | 14:02 |
| tbarron | smcginnis: gotta drive to work, will update the etherpad when I get there | 14:02 |
| *** gouthamr_ has joined #openstack-cinder | 14:03 | |
| *** rcernin has quit IRC | 14:03 | |
| *** subscope has joined #openstack-cinder | 14:04 | |
| *** zhipeng has quit IRC | 14:04 | |
| smcginnis | tbarron: Thanks! | 14:05 |
| openstackgerrit | Peter Wang proposed openstack/cinder: VNX: Fix failure in SnapCopy feature https://review.openstack.org/243017 | 14:05 |
| *** dustins has joined #openstack-cinder | 14:06 | |
| *** gouthamr has quit IRC | 14:06 | |
| openstackgerrit | Felix Ma proposed openstack/os-brick: Raise exception in find_multipath_device https://review.openstack.org/249231 | 14:08 |
| *** subscope has quit IRC | 14:10 | |
| *** subscope has joined #openstack-cinder | 14:11 | |
| nikeshm | smcginnis: whats up | 14:11 |
| nikeshm | smcginnis: hope you enjoyed the anniversary in parris | 14:12 |
| *** ankit_ag has quit IRC | 14:12 | |
| nikeshm | smcginnis: but really attacks in parris was very sad | 14:13 |
| *** subscope has quit IRC | 14:13 | |
| *** subscope has joined #openstack-cinder | 14:13 | |
| *** merooney has joined #openstack-cinder | 14:13 | |
| *** subscope has quit IRC | 14:16 | |
| *** subscope has joined #openstack-cinder | 14:17 | |
| smcginnis | nikeshm: Hey! | 14:19 |
| smcginnis | nikeshm: Yes, it was a very good weekend. | 14:19 |
| *** eharney has joined #openstack-cinder | 14:19 | |
| smcginnis | nikeshm: Very sad, but it was good to see that the city is still going and isn't going to let those events destroy everything. | 14:20 |
| *** diablo_rojo has quit IRC | 14:21 | |
| *** jgregor has joined #openstack-cinder | 14:22 | |
| nikeshm | smcginnis: congrats for the anniversary, BTW, my marriage is fixed on 29th january 2016 | 14:23 |
| *** jerrygb has joined #openstack-cinder | 14:23 | |
| nikeshm | :) | 14:23 |
| smcginnis | nikeshm: Wow, that's coming up quick! Congrats! | 14:27 |
| *** baumann has joined #openstack-cinder | 14:28 | |
| *** mc_nair has joined #openstack-cinder | 14:32 | |
| *** akshai has joined #openstack-cinder | 14:32 | |
| *** mriedem_away is now known as mriedem | 14:33 | |
| *** baumann has quit IRC | 14:35 | |
| *** ntpttr has joined #openstack-cinder | 14:35 | |
| *** willsama has joined #openstack-cinder | 14:36 | |
| *** mtanino has joined #openstack-cinder | 14:37 | |
| *** arnewiebalck_ has quit IRC | 14:37 | |
| *** arnewiebalck_ has joined #openstack-cinder | 14:38 | |
| *** goodygum_ is now known as noqa_v_qoovnie | 14:44 | |
| *** jwcroppe has joined #openstack-cinder | 14:47 | |
| *** jgriffith_away is now known as jgriffith | 14:47 | |
| dulek | DuncanT, e0ne: I'm not sure why this wasn't catched by IRC bot, but: https://review.openstack.org/#/c/249255/ | 14:54 |
| *** jungleboyj has joined #openstack-cinder | 14:55 | |
| *** jerrygb has quit IRC | 14:56 | |
| *** jerrygb has joined #openstack-cinder | 14:57 | |
| *** houming has quit IRC | 14:58 | |
| *** diablo_rojo has joined #openstack-cinder | 14:58 | |
| *** akshai has quit IRC | 14:59 | |
| *** jwcroppe has quit IRC | 14:59 | |
| *** akshai has joined #openstack-cinder | 15:00 | |
| *** davechen has joined #openstack-cinder | 15:00 | |
| *** haomaiwa_ has quit IRC | 15:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 15:01 | |
| *** boris-42 has joined #openstack-cinder | 15:02 | |
| *** akshai has quit IRC | 15:02 | |
| *** salv-orlando has joined #openstack-cinder | 15:04 | |
| *** houming has joined #openstack-cinder | 15:05 | |
| DuncanT | Dulek: Thanks, I'll take a look | 15:06 |
| *** breitz has quit IRC | 15:08 | |
| *** breitz has joined #openstack-cinder | 15:08 | |
| *** dims_ has joined #openstack-cinder | 15:08 | |
| *** dims has quit IRC | 15:09 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Tooz locks https://review.openstack.org/183537 | 15:11 |
| openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Support locking Versioned Objects https://review.openstack.org/246352 | 15:11 |
| *** leo___ has joined #openstack-cinder | 15:14 | |
| *** jerrygb has quit IRC | 15:15 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Support locking Versioned Objects https://review.openstack.org/246352 | 15:15 |
| *** jerrygb has joined #openstack-cinder | 15:16 | |
| *** gcb has quit IRC | 15:17 | |
| *** thangp has joined #openstack-cinder | 15:18 | |
| *** markvoelker has quit IRC | 15:18 | |
| *** markvoelker has joined #openstack-cinder | 15:18 | |
| *** sgundur has joined #openstack-cinder | 15:18 | |
| *** vgridnev has quit IRC | 15:19 | |
| e0ne | Dulek: thanks for the update | 15:21 |
| *** wN has quit IRC | 15:23 | |
| *** crose has joined #openstack-cinder | 15:25 | |
| tbarron | smcginnis: I updated https://wiki.openstack.org/wiki/Sprints/CinderMitakaSprint and the accompanying etherpad with the lodging reservations link. | 15:26 |
| *** subscope has quit IRC | 15:26 | |
| *** wN has joined #openstack-cinder | 15:28 | |
| *** wN has joined #openstack-cinder | 15:28 | |
| *** xyang has joined #openstack-cinder | 15:30 | |
| *** jerrygb has quit IRC | 15:33 | |
| *** salv-orlando has quit IRC | 15:36 | |
| *** subscope has joined #openstack-cinder | 15:36 | |
| *** akshai has joined #openstack-cinder | 15:36 | |
| *** asselin_ has joined #openstack-cinder | 15:36 | |
| *** asselin has joined #openstack-cinder | 15:36 | |
| *** subscope has quit IRC | 15:40 | |
| *** salv-orlando has joined #openstack-cinder | 15:40 | |
| *** asselin_ has left #openstack-cinder | 15:40 | |
| *** baumann has joined #openstack-cinder | 15:41 | |
| smcginnis | rhedlind: ping | 15:41 |
| smcginnis | rhedlind: Can we get a recheck on this: https://review.openstack.org/#/c/242139/ | 15:41 |
| *** asselin has left #openstack-cinder | 15:41 | |
| *** asselin has quit IRC | 15:41 | |
| *** asselin has joined #openstack-cinder | 15:42 | |
| *** houming has quit IRC | 15:44 | |
| *** houming has joined #openstack-cinder | 15:45 | |
| sgundur | jgriffith: thanks for initiating this discussion , at this point I am going to un-assign myself from the bug | 15:46 |
| sgundur | jgriffith: thanks :) | 15:46 |
| jgriffith | sgundur: :( sorry | 15:46 |
| jgriffith | sgundur: I still say it's broken, but I'm not arguing | 15:47 |
| e0ne | jgriffith: morning, John | 15:49 |
| *** haomaiwa_ has quit IRC | 15:49 | |
| smcginnis | jgriffith: Do you sleep? :) | 15:49 |
| jgriffith | e0ne: hola | 15:49 |
| smcginnis | e0ne: You too. | 15:49 |
| *** crose has quit IRC | 15:49 | |
| jgriffith | smcginnis: yes... 15 minutes every 2 hours | 15:49 |
| smcginnis | jgriffith: Hah! | 15:50 |
| e0ne | smcginnis: what are you talking about? | 15:50 |
| jgriffith | smcginnis: I learned it from Kramer on Seinfeld LOL | 15:50 |
| smcginnis | e0ne: Thought I saw you on at all hours too. | 15:50 |
| smcginnis | jgriffith: :) | 15:50 |
| jgriffith | e0ne: yeah... sort of the pot calling the kettle black eh? | 15:50 |
| jgriffith | :) | 15:50 |
| diablo_rojo | jgriffith: So you sleep the uberman schedule? | 15:51 |
| diablo_rojo | http://chamilton.wdfiles.com/local--files/polyphasic-sleeping/chaseSleep.jpg | 15:51 |
| *** EinstCra_ has quit IRC | 15:51 | |
| e0ne | jgriffith: em... I failed to translate what you mean:( | 15:51 |
| *** salv-orlando has quit IRC | 15:51 | |
| jgriffith | diablo_rojo: LOL... that's awesome! | 15:51 |
| smcginnis | diablo_rojo: You calling jgriffith and uberman? :) | 15:51 |
| jgriffith | smcginnis: meh.. it happens | 15:52 |
| jgriffith | LOL | 15:52 |
| smcginnis | :D | 15:52 |
| diablo_rojo | jgriffith: Have you never heard of that before? | 15:52 |
| diablo_rojo | smcginnis: Maybe? | 15:52 |
| jgriffith | diablo_rojo: no, I have not.. but I'm reading about it right now | 15:52 |
| jgriffith | diablo_rojo: very interesting | 15:53 |
| jgriffith | diablo_rojo: are you a polyphasic sleeper? | 15:53 |
| diablo_rojo | jgriffith: I tried to do some of the other ones. I pretty consistently did the Everyman during college. Sometimes the chase. | 15:53 |
| e0ne | jgriffith: will you have a time to discuss cinder w/o nova? I would like to make a desision how will we implement it: cinderclient or not | 15:53 |
| nikeshm | smcginnis: thanks | 15:53 |
| jgriffith | e0ne: certainly... let's talk about it | 15:53 |
| jungleboyj | diablo_rojo: Likes to sleep whenever she can. | 15:54 |
| jgriffith | diablo_rojo: BTW, I was kidding.. I don't really sleep like that. Although there have been periods in my past when I did | 15:54 |
| e0ne | jgriffith: you was against to make it inside cinderclient at the begining.. | 15:54 |
| diablo_rojo | jgriffith: I figured :) I just cant resist the oppoortunity for a good infographic. | 15:55 |
| e0ne | jgriffith: IMO, if our client will deal not only with API, it will be more confusing | 15:55 |
| jgriffith | diablo_rojo: when I finished my 6 year sleep depravation experiment (Militairy) I like deep sleep :) | 15:55 |
| smcginnis | jungleboyj: ohayo gozaimasu | 15:55 |
| jgriffith | e0ne: so I'm not sure why? | 15:55 |
| jungleboyj | smcginnis: Ohayo gozimasu . | 15:55 |
| jgriffith | e0ne: so if I say "cinder get-connection-info" | 15:55 |
| * jungleboyj is fighting the worst jet lag ever. | 15:56 | |
| e0ne | jgriffith: ok. what about 'attach'? | 15:56 |
| jgriffith | e0ne: and an IQN comes back... that I can do whatever I want with, how is that "confusing"? | 15:56 |
| jungleboyj | smcginnis: Feel like I should be saying kunbunwa | 15:56 |
| diablo_rojo | jgriffith: Ha ha sounds painful. Then again, so was my high school sleep schedule (max of 5.5 hours, average of 4). | 15:56 |
| jgriffith | good times! :) | 15:56 |
| smcginnis | jungleboyj: ;) | 15:57 |
| *** leo___ has quit IRC | 15:57 | |
| e0ne | jgriffith: 'connection info' is pretty simple | 15:57 |
| *** subscope has joined #openstack-cinder | 15:57 | |
| jgriffith | e0ne: so what's the confusing part? | 15:57 |
| e0ne | jgriffith: but adding new(second) 'attach' method doesn't sounds good | 15:57 |
| jgriffith | e0ne: why not? | 15:57 |
| smcginnis | jgriffith, e0ne: IIRC, part of the reason for a new client would be there will be similar but differnt calls. | 15:58 |
| e0ne | jgriffith: we've already have 'attach' | 15:58 |
| jgriffith | e0ne: "cinder set-status-attached xxxxxxx" | 15:58 |
| smcginnis | That we don't want to confuse "normal" end users with. | 15:58 |
| jgriffith | e0ne: "cinder mark-as-in-use xxxxx" | 15:58 |
| smcginnis | So making it a separate client makes it clear and separate. | 15:58 |
| *** bluex has quit IRC | 15:59 | |
| jgriffith | smcginnis: sure, but there's all sorts of duplication of code there | 15:59 |
| jgriffith | smcginnis: and some confusion IMO when you throw in things like OSC | 15:59 |
| *** subscope has quit IRC | 15:59 | |
| e0ne | jgriffith: we have to move all duplicates code to something like oslo.client | 15:59 |
| smcginnis | jgriffith: The duplication of code is a big concern for me. | 15:59 |
| jgriffith | smcginnis: e0ne and BTW, there is NO attach command exposed to users currently | 15:59 |
| sgundur | jgriffith:I agree with you that it can be done better, no arguments there :) | 16:00 |
| sgundur | jgriffith:just that I am not sure how we could make all calls to go through scheduler | 16:00 |
| *** salv-orlando has joined #openstack-cinder | 16:00 | |
| jgriffith | sgundur: yeah... I don't even know if that's necessary | 16:00 |
| smcginnis | jgriffith, e0ne: So maybe we should try sticking with one client. Implement the changes and see where the nasty parts really are. | 16:00 |
| jgriffith | sgundur: my argument was (and still is) that most of those calls are pointless, and even the ones that aren't are only there to handle drivers that don't handle errors themeselves | 16:00 |
| *** isaacb has quit IRC | 16:01 | |
| e0ne | jgriffith: sure. and we don't need to expoxe 'set-status-attached' to CLI | 16:01 |
| smcginnis | jgriffith, e0ne: And if it ends up not being a big deal - great. | 16:01 |
| *** zhipeng has joined #openstack-cinder | 16:01 | |
| jgriffith | smcginnis: e0ne so I think we'd be better off... but I could be wrong. One thing to remember is you can hide the command | 16:01 |
| sgundur | jgriffith: yep , I see your point | 16:01 |
| smcginnis | jgriffith, e0ne: If we find some legitimate (and concrete) examples where it could be an issue, should be as bad to refactor out into a different client. | 16:01 |
| jgriffith | smcginnis: e0ne so it only shows up if the admin turns it on via policy | 16:01 |
| jgriffith | smcginnis: sounds like a pragmatic way to approach it | 16:02 |
| e0ne | jgriffith, smcginnis: cinderclient doesn't know anything about policies | 16:02 |
| jgriffith | e0ne: no, but the API's on the receiving/Cinder side do :) | 16:02 |
| e0ne | jgriffith: it's still unclear for me: how to hide a command on the client-side before connection to API | 16:03 |
| jgriffith | e0ne: and if I'm a user that doesn't have the correct credentials I never even see the command when I do for example a "cinder help" | 16:03 |
| jgriffith | e0ne: the other option/idea is just make it a special extension | 16:04 |
| smcginnis | Maybe we don't need to hide them. Just name them something useful. | 16:04 |
| jgriffith | e0ne: and introduce a mechanism to enable/disable it | 16:04 |
| *** salv-orlando has quit IRC | 16:04 | |
| jgriffith | smcginnis: yeah... that may work too | 16:04 |
| e0ne | jgriffith: I like it. we can make it as a separate binary | 16:05 |
| jgriffith | smcginnis: e0ne so you know we could do things like set and env var that says "show external device methods" | 16:05 |
| jgriffith | e0ne: or yes, an external binary maybe | 16:05 |
| e0ne | jgriffith: got you idea with hiding commands:) | 16:05 |
| e0ne | jgriffith: I'll try it | 16:06 |
| jgriffith | e0ne: excellent! | 16:06 |
| e0ne | jgriffith: external binary - it could raise a code duplication too:(. Not sure for now, I need to check it | 16:06 |
| *** ericksonsantos has joined #openstack-cinder | 16:07 | |
| thingee | whew back from the honeymoon :) Hi everyone! | 16:08 |
| smcginnis | thingee: Welcome back! | 16:08 |
| jgriffith | welcome back thingee | 16:08 |
| thingee | that vacation was more needed than I thought! | 16:08 |
| e0ne | jgriffith: one more concern about "hiding commands": do we to add os-brick as soft-dependency? from the packagers perspective, it's not a big deal | 16:08 |
| e0ne | jgriffith: but from the cloud providers - does they want to have potential issues when user find "hidden command"? | 16:09 |
| e0ne | thingee: welcome back! | 16:09 |
| jgriffith | e0ne: I honestly don't understand the whole brick relationship here to be honest | 16:10 |
| e0ne | jgriffith: I need to call connect_volume/disconnect_volume os-brick's methods during attach/detach procedure | 16:11 |
| e0ne | jgriffith: e.g.: https://github.com/e0ne/python-brickclient/blob/master/brickclient/client.py#L88 | 16:11 |
| *** vgridnev has joined #openstack-cinder | 16:11 | |
| *** nkrinner has quit IRC | 16:12 | |
| *** anshul has quit IRC | 16:15 | |
| *** rcernin has joined #openstack-cinder | 16:16 | |
| *** alexschm has quit IRC | 16:20 | |
| *** aviramb has quit IRC | 16:23 | |
| jgriffith | "honestly to be honest" ... just call me Abe :) | 16:23 |
| e0ne | jgriffith: I'm going to expose not only 'get-connector' info (brick provides it too) but full cycle of attach/detach to any host | 16:23 |
| jgriffith | e0ne: yeah :( | 16:24 |
| e0ne | jgriffith: that's why you proposed to move it in a saparate client a while ago | 16:25 |
| jgriffith | e0ne: I proposed moving what to a separate client? | 16:25 |
| *** _amrith_ is now known as amrith | 16:26 | |
| openstackgerrit | zhangsong proposed openstack/os-brick: Improve the remove_multipath_device() method for linuxscsi https://review.openstack.org/249308 | 16:26 |
| jgriffith | e0ne: brick? Not hardly, that is no longer anything remotely like what I initially talked about. It's good... it's just not what we initially set out on | 16:26 |
| jgriffith | e0ne: it sounds like you have a good plan; you should just run with it | 16:27 |
| e0ne | jgriffith: if i remember it right. I could be wrong | 16:27 |
| jgriffith | e0ne: yeah... pretty sure there's a misunderstanding there :) | 16:27 |
| e0ne | jgriffith: that's why we are duscissing about it now | 16:27 |
| jgriffith | true | 16:28 |
| jgriffith | e0ne: here's my only concern | 16:28 |
| jgriffith | e0ne: well... concerns: | 16:28 |
| e0ne | and IMO it's not bad - we as community can find a better solution in such discussions | 16:28 |
| jgriffith | 1. We actually get something that works this release | 16:28 |
| openstackgerrit | Merged openstack/cinder: Fix the bug of OSError when convert image https://review.openstack.org/243152 | 16:29 |
| jgriffith | 2. We work it out iteratively (we don't need to boil the ocean), just come up with a plan and start executing it in phases | 16:29 |
| *** zhenguo has quit IRC | 16:29 | |
| jgriffith | 3. I don't think Brick and a new client should be a requirement, but may be a nice to have | 16:29 |
| *** xiaohui_ has joined #openstack-cinder | 16:29 | |
| *** rebase has joined #openstack-cinder | 16:30 | |
| *** dims_ has quit IRC | 16:30 | |
| jgriffith | 4. We shouldn't get wrapped around the axle and not have anything useful because we have too many dependencies floating around with external libs, clients etc | 16:30 |
| jgriffith | I think that's it... | 16:30 |
| jgriffith | So I would propose you start with just the cinder and cinderclient pieces... with the design for other components being kept in mind | 16:31 |
| e0ne | I'm 100% agree with you for #1,2,4 | 16:31 |
| jgriffith | Provide a way for a caller to get tgt-iqn info and a way to set the status of the volume | 16:31 |
| jgriffith | that's a great start... and then build and refine on top of that | 16:31 |
| e0ne | got your point, sounds absolutely reasonable | 16:32 |
| jgriffith | you can automate the *world* as we go along but at least there's an intermediate point where people can consume the service | 16:32 |
| jgriffith | in any way they choose | 16:32 |
| *** jdurgin1 has joined #openstack-cinder | 16:32 | |
| e0ne | one a little coment from me: to get iqn I need brick, so it will be a requirement | 16:32 |
| *** sgundur has quit IRC | 16:32 | |
| jgriffith | e0ne: I realize it's not perfect, and there are gaps/holes (RBD, FC etc), but might be better to fill those as we go and learn more | 16:33 |
| * jgriffith is not very good at predicting the future | 16:33 | |
| e0ne | jgriffith: it's a good plan, John | 16:33 |
| jgriffith | e0ne: cool | 16:33 |
| jgriffith | e0ne: I'm excited about the whole thing | 16:34 |
| xiaohui_ | geguileo: are you available now? | 16:34 |
| e0ne | jgriffith: now I know in a what way I should to go! it was the main question for me:) | 16:34 |
| geguileo | xiaohui_: On a meeting, sorry | 16:34 |
| jgriffith | e0ne: and you know if there's something you don't have time to work on or would like help... just let me know | 16:34 |
| *** rebase has quit IRC | 16:34 | |
| *** simondodsley has joined #openstack-cinder | 16:34 | |
| e0ne | jgriffith: sure, I'll do:) | 16:34 |
| e0ne | thanks for the help | 16:35 |
| e0ne | now, it's a good time to take a break and head to home | 16:35 |
| xiaohui_ | geguileo: ok, so reply on your comments about your concerns is ok for you then? | 16:35 |
| geguileo | xiaohui_: Yes, please :-) | 16:35 |
| xiaohui_ | geguileo: ok, thanks! | 16:36 |
| *** sgundur has joined #openstack-cinder | 16:36 | |
| jgriffith | mtanino: minor question regarding https://review.openstack.org/#/c/247886/ | 16:38 |
| mtanino | jgriffith: sure | 16:39 |
| jgriffith | mtanino: the persistence files are specific for tgt driver | 16:39 |
| jgriffith | mtanino: so shouldn't we move that write_configfile to the tgt class? | 16:39 |
| mtanino | jgriffith: I think tgt and cxt | 16:39 |
| mtanino | hmm | 16:39 |
| jgriffith | mtanino: I guess it doesn't matter | 16:40 |
| mtanino | jgriffith: ah, let me check a little | 16:40 |
| jgriffith | mtanino: as it's called by the inherited classes.... | 16:40 |
| mtanino | I guestt so | 16:40 |
| *** aix has quit IRC | 16:40 | |
| *** salv-orlando has joined #openstack-cinder | 16:41 | |
| *** salv-orlando has quit IRC | 16:41 | |
| jgriffith | mtanino: it's technically just fine, I'm trying to figure out however if there's a way to keep those driver classes somewhat self-descriptive | 16:41 |
| jgriffith | mtanino: maybe silly.... | 16:41 |
| *** salv-orlando has joined #openstack-cinder | 16:41 | |
| jgriffith | mtanino: but even consider just making that write_configfile a part of a utils file and set it as a static method? | 16:41 |
| jgriffith | mtanino: it doesn't appear to rely on any object members | 16:41 |
| jgriffith | mtanino: because you're correct, there are others using it now | 16:42 |
| mtanino | jgriffith: correct, so which one is good place to move it? tgt class or under utils? | 16:43 |
| jgriffith | mtanino: well, tgt class doesn't make as much sense as I thought it did :( | 16:43 |
| mtanino | jgriffith: hmm | 16:44 |
| jgriffith | mtanino: I suppose there's no harm in having it in iscsi.py | 16:44 |
| jgriffith | mtanino: I wonder if it's worth defining it as a static method? | 16:44 |
| mtanino | jgriffith: Ah, ok! | 16:44 |
| jgriffith | mtanino: that makes it clear I think | 16:45 |
| jgriffith | mtanino: and then anybody can use it | 16:45 |
| jgriffith | mtanino: if there's ever another case of somebody wanting to use it then maybe we move it to utils | 16:45 |
| mtanino | jgriffith: ok. make sense. | 16:46 |
| *** dims has joined #openstack-cinder | 16:46 | |
| jgriffith | mtanino: ok, if you're sure that seems right. I could be completely off my rocker ya know :) | 16:46 |
| jgriffith | mtanino: if you think it's overly picky don't be afraid to say so | 16:46 |
| mtanino | jgriffith: I originally thought we can use this method for iet, lio, etc but currently only cxt and tgt are needed this method. | 16:46 |
| jgriffith | mtanino: yeah... and it's not a terribly big deal since those that need it just call in their respective sub-classes | 16:47 |
| jgriffith | mtanino: but my concern would be somebody sees this at some point in the future and says "oh, I should call this from the manager" | 16:47 |
| mtanino | jgriffith: In that case, we should move this as a more generic method. | 16:48 |
| jgriffith | mtanino: also I just sort of think we have a little too much indirection going on | 16:48 |
| jgriffith | mtanino: that's what I think... make it a true helper method independent of iscsi and targets | 16:48 |
| *** jdurgin1 has quit IRC | 16:48 | |
| *** zhipeng has quit IRC | 16:48 | |
| jgriffith | mtanino: because frankly I think there are some other places where we could benefit from this hardening of writing out to files | 16:49 |
| openstackgerrit | Merged openstack/cinder: CG API should return volume type IDs https://review.openstack.org/245624 | 16:49 |
| ntpttr | qqc | 16:49 |
| ntpttr | oops wrong window had focus | 16:49 |
| mtanino | jgriffith: ah, If there are some places which we have to cover to atomic file writing, we might be implement this method more generic? | 16:51 |
| jgriffith | mtanino: :) | 16:51 |
| mtanino | now? | 16:51 |
| *** EinstCrazy has joined #openstack-cinder | 16:51 | |
| jgriffith | mtanino: exactly | 16:51 |
| jgriffith | mtanino: we don't have to fully genericise it now, but maybe put a TODO pointing out to folks it's there and we may want to use it for such purposes | 16:52 |
| mtanino | jgriffith: OK. let me think again this method for more generic purpose. | 16:53 |
| jgriffith | mtanino: great, thank you as always mtanino ! | 16:53 |
| *** kbyrne has quit IRC | 16:53 | |
| anish | oh great, mtanino already gave the explanation :) | 16:54 |
| mtanino | anish: hi :) | 16:54 |
| * anish waves | 16:54 | |
| ntpttr | If I have the 'self.client.can_send_version' method called twice in an rpcapi function, how can I mock that in tests? Right now the mock only seems to acknowledge one of the two values I pass into that method, and it makes the test fail | 16:54 |
| *** jwcroppe has joined #openstack-cinder | 16:55 | |
| jgriffith | ntpttr: hmm... your mock should cover the object itself and work no matter how many times it's called | 16:55 |
| *** markstur has quit IRC | 16:56 | |
| jgriffith | ntpttr: are you using "with mock.object......" ? | 16:56 |
| *** EinstCrazy has quit IRC | 16:56 | |
| *** gouthamr_ has quit IRC | 16:57 | |
| ntpttr | yes, here I'll pastebin the test and rpc function | 16:57 |
| *** e0ne has quit IRC | 16:58 | |
| ntpttr | Here is the current not working version I've got http://paste.openstack.org/show/479892/ | 16:59 |
| ntpttr | it recognizes being called with version 1.33, but not with version 1.36, it's the 1.36 call that's failing | 16:59 |
| jgriffith | ntpttr: ahh... yeah, that won't work that way | 17:00 |
| *** diegows has quit IRC | 17:00 | |
| jgriffith | ntpttr: because you use a mock with return value for both | 17:01 |
| jgriffith | and it apparantly just uses the last one (1.33) | 17:01 |
| ntpttr | jgriffith: I figured that would cause an issue, but it didn't work with one mock call either | 17:01 |
| dulek | ntpttr: use mock.size_effect = [val1, val2, val3] | 17:01 |
| jgriffith | ntpttr: If it were me I'd try using a single mock with a side-effect that calls a method and returns false | 17:01 |
| ntpttr | dulek jgriffith: ah okay, hadn't heard of that, thank you | 17:02 |
| jgriffith | ntpttr: also, I personally find using the form "with mock.patch.object xxxxx"{ } easier to deal with | 17:02 |
| dulek | ntpttr: I believe you're working on the quotas patch. Right now we're testing only the lowest and newest versions of the calls, no intermediate ones. | 17:02 |
| ntpttr | dulek: Yes, I'll add more tests for intermediate as well | 17:02 |
| dulek | ntpttr: Our RPC clients unit tests need solid refactoring, so I wouldn't mind if you won't - it's really painful to work with them. | 17:03 |
| jgriffith | ntpttr: take a look at something like this: https://github.com/openstack/cinder/blob/master/cinder/tests/unit/test_solidfire.py#L281 | 17:03 |
| jgriffith | ntpttr: or just about any unit test that eharney has submitted over the last year is IMO a great template to follow | 17:03 |
| *** jwcroppe has quit IRC | 17:03 | |
| ntpttr | dulek: do you mean it wouldn't be a big deal if I don't, or that you would prefer that I don't? It wouldn't be too much trouble if it would be helpful | 17:04 |
| ntpttr | jgriffith: thank you, I'll check that out | 17:04 |
| *** chenying has quit IRC | 17:05 | |
| *** chenying has joined #openstack-cinder | 17:05 | |
| openstackgerrit | Ryan McNair proposed openstack/python-cinderclient: Fix v2 qos-key command https://review.openstack.org/248944 | 17:08 |
| *** leeantho has joined #openstack-cinder | 17:09 | |
| *** markstur has joined #openstack-cinder | 17:11 | |
| *** jccnd has joined #openstack-cinder | 17:11 | |
| openstackgerrit | Merged openstack/cinder: Port IBM storewize_svc driver to Python 3 https://review.openstack.org/242878 | 17:14 |
| ntpttr | jgriffith: could you clarify one more thing for me? If I change the format of the test would it look like mock.patch.object(oslo_messaging.RPCClient, 'can_send_version', side_effect=?', and then would the assert_called_with statements still be necessary? Sorry, I'm still getting used to the mock framework, I haven't had a lot of experience with it yet | 17:16 |
| *** jwcroppe has joined #openstack-cinder | 17:17 | |
| *** dustins has quit IRC | 17:17 | |
| jgriffith | ntpttr: yes, that's how it would look, that's just a suggestion of course, you can use the syntax/format you have but change it to a side-effect | 17:17 |
| jgriffith | ntpttr: as far as the assert_called... I think that still works but honestly I don't usually use those :) | 17:18 |
| *** kfarr has joined #openstack-cinder | 17:18 | |
| jgriffith | ntpttr: I cheat and do things like add a counter in the method and assert it's incremented to what I expected :) | 17:18 |
| *** dims has quit IRC | 17:18 | |
| jgriffith | ntpttr: it's stupid I know | 17:18 |
| *** dims_ has joined #openstack-cinder | 17:18 | |
| ntpttr | jgriffith: Gotcha, I guess my issue was more like since I'm getting rid of the can_send_version parameters in the method itself, how could I even call assert_called_with since those variables don't exist? | 17:19 |
| *** david-ly_ has joined #openstack-cinder | 17:19 | |
| ntpttr | jgriffith: do I put that logic inside of the side effect somehow? | 17:20 |
| jgriffith | ntpttr: that's what I do, but it's probably not the best answer :) | 17:20 |
| jgriffith | ntpttr: I've never been good with the mock assert called stuff AT ALL | 17:20 |
| jgriffith | You'll have to play with it or see if somebody else here has better ideas/input for you | 17:21 |
| jgriffith | ntpttr: but what I've done in the past is in the test_xxxxx() | 17:21 |
| jgriffith | Set a variable "called_count = 0" | 17:21 |
| jgriffith | Then in my side effect (defined in the method), increment called_count | 17:21 |
| ntpttr | jgriffith: hah it does seem to be a bit to get my head around, I'll try experimenting with it some more | 17:21 |
| jgriffith | then do a poor mans assert :) | 17:21 |
| *** lpetrut has quit IRC | 17:21 | |
| ntpttr | jgriffith: yeah, that counter makes sense, but then I don't think that would also maintain that the function was called with the specific parameters | 17:22 |
| jgriffith | has the same result without the mind bending of mock :) | 17:22 |
| mtanino | [Question] If we have multi-hypervisor(KVM, VMware, etc) and multi cinder backends(LVM, VMDK, etc), can we control of target cinder backend when we boot an instance from volume? | 17:22 |
| jgriffith | ntpttr: well... you need to define your side-effect with the same params as the method your faking out | 17:22 |
| jgriffith | ntpttr: so you can read them and do whatever you want with the arguments inside of it | 17:22 |
| jgriffith | ntpttr: so multiple counters, sentinel vars whatever | 17:22 |
| jgriffith | ntpttr: you have complete creative control :) | 17:23 |
| ntpttr | jgriffith: oh okay, so the side effect can really be like a multi line bit of code | 17:23 |
| dulek | ntpttr: Ah, sorry. If you do that then great, if not - I don't care too much. :) | 17:23 |
| *** david-l__ has joined #openstack-cinder | 17:23 | |
| *** david-ly_ has quit IRC | 17:23 | |
| jgriffith | ntpttr: oh.. YES | 17:23 |
| *** david-lyle has quit IRC | 17:23 | |
| ntpttr | jgriffith: I'll go look at some more side effect examples to figure out how they work, thanks for the help! | 17:23 |
| jgriffith | ntpttr: so side-effect is a method you define | 17:23 |
| jgriffith | ntpttr: as opposed to return_value where you just say "return this" | 17:24 |
| dulek | jgriffith: Not only. ;) side_effect can be an exception - call will throw an exception. | 17:24 |
| jgriffith | dulek: yeah... I'm a big fan of side-effect | 17:24 |
| dulek | jgriffith: It can also be a list - then the mock calls will return next value per call | 17:24 |
| jgriffith | dulek: I can do whatever I want and base that decision on the parameters to the method | 17:25 |
| ntpttr | jgriffith dulek: okay cool, that makes sense. Learn something new every day, thank you guys | 17:25 |
| jgriffith | dulek: Ahh... the list iteration thing is a clever idea!! :) | 17:25 |
| jgriffith | I like that | 17:25 |
| jgriffith | dulek: just pop things off and roll... nice! | 17:27 |
| jgriffith | dulek: I'll use that instead of saying "if arg == "blah blah blah"" etc | 17:27 |
| jgriffith | dulek: also adds some checking of expected order of calls | 17:27 |
| dulek | jgriffith: Yup, it's nice if you don't have too much logic in mocked method. | 17:29 |
| *** david-l__ has quit IRC | 17:30 | |
| *** yumapath has joined #openstack-cinder | 17:34 | |
| *** houming has quit IRC | 17:34 | |
| *** xiaohui_ has quit IRC | 17:37 | |
| *** jordanP has quit IRC | 17:38 | |
| Swanson | asselin, I think I see a partial problem. I have no keys registered for the ci account. | 17:41 |
| asselin | Swanson, yeah, you'll need that.....but that would be a failure that occurs have the host key is verified... | 17:42 |
| hemna | doink | 17:42 |
| Swanson | asselin, Warning: /Apt_key[Add key: D50582E6 from Apt::Source jenkins]: The id should be a full fingerprint (40 characters), see README. | 17:43 |
| asselin | Swanson, that one's ok | 17:43 |
| *** david-lyle has joined #openstack-cinder | 17:44 | |
| *** sghanekar__ has joined #openstack-cinder | 17:45 | |
| Swanson | asselin, launchpad id is my gerrit user, right? | 17:49 |
| asselin | Swanson, you should have a separate id for your ci system | 17:49 |
| Swanson | asselin, yeah but I think I have the wrong id in part of this... | 17:50 |
| asselin | Swanson, you should login to gerrit using your ci-account. You can get the name from there | 17:50 |
| *** aix has joined #openstack-cinder | 17:57 | |
| openstackgerrit | Merged openstack/cinder: Move oslo-incubator's scheduler module to cinder https://review.openstack.org/249255 | 18:00 |
| *** e0ne has joined #openstack-cinder | 18:01 | |
| *** yumapath has quit IRC | 18:02 | |
| *** merooney has quit IRC | 18:03 | |
| asselin | Swanson, you should have this line if you delete the known host file: Notice: /Stage[main]/Zuul::Known_hosts/File[/home/zuul/.ssh/known_hosts]/ensure: created | 18:03 |
| *** david-lyle has quit IRC | 18:03 | |
| asselin | and rerun puppet | 18:03 |
| Swanson | re-running puppet. | 18:04 |
| *** [1]Thelo has joined #openstack-cinder | 18:04 | |
| *** jistr has quit IRC | 18:04 | |
| *** pdardeau has joined #openstack-cinder | 18:06 | |
| *** Thelo has quit IRC | 18:06 | |
| *** [1]Thelo is now known as Thelo | 18:06 | |
| *** pdardeau has quit IRC | 18:06 | |
| Swanson | That creates a known_hosts file wildly different than what I get if I just try to clone and have it save the rsa fingerprint then. | 18:07 |
| Swanson | And if I try to clone with that known_hosts file I still have to save my rsa fingerprint. | 18:08 |
| asselin | Swanson, yeah, I think that's b/c it's hashed when you do it manually | 18:08 |
| *** markus_z has quit IRC | 18:08 | |
| asselin | Swanson, try adding the one you get manually to your hiera common.yaml...let me look up the var name | 18:09 |
| asselin | https://git.openstack.org/cgit/openstack-infra/puppet-openstackci/tree/contrib/single_node_ci_site.pp#n43 | 18:10 |
| asselin | gerrit_ssh_host_key | 18:10 |
| *** david-lyle has joined #openstack-cinder | 18:11 | |
| *** martyturner has quit IRC | 18:12 | |
| *** hemna has quit IRC | 18:12 | |
| *** martyturner has joined #openstack-cinder | 18:14 | |
| *** merooney has joined #openstack-cinder | 18:15 | |
| *** mriedem has quit IRC | 18:17 | |
| openstackgerrit | Merged openstack/cinder: VMware: Skip unsupported datastore types https://review.openstack.org/249150 | 18:21 |
| *** mriedem has joined #openstack-cinder | 18:21 | |
| *** dustins has joined #openstack-cinder | 18:24 | |
| *** liverpooler has quit IRC | 18:27 | |
| Swanson | asselin, If you pick the right key from your list of server keys it works peachy. At least I can run puppet and then su - zuul and actually clone successfully. | 18:33 |
| asselin | Swanson, what exactly? | 18:34 |
| *** lprice has joined #openstack-cinder | 18:34 | |
| Swanson | I just pulled one of the keys listed under ssh public keys for server host key and put that in the site.pp file. Re-puppetted and ssh seems to be setup. | 18:35 |
| *** pots2 has joined #openstack-cinder | 18:36 | |
| asselin | Swanson, I'm confused, can you paste it ? | 18:37 |
| *** lprice1 has quit IRC | 18:37 | |
| Swanson | I just grabbed one of the keys under https://review.openstack.org/#/settings/ssh-keys | 18:38 |
| *** sgundur has quit IRC | 18:38 | |
| *** pots has quit IRC | 18:39 | |
| *** pdardeau has joined #openstack-cinder | 18:42 | |
| *** bardia has joined #openstack-cinder | 18:43 | |
| *** mtanino has quit IRC | 18:47 | |
| *** apoorvad has joined #openstack-cinder | 18:52 | |
| *** pdardeau has quit IRC | 18:52 | |
| *** pdardeau has joined #openstack-cinder | 18:54 | |
| *** pdardeau has quit IRC | 18:55 | |
| *** sghanekar__ has quit IRC | 18:56 | |
| *** merooney has quit IRC | 18:58 | |
| *** martyturner has quit IRC | 18:58 | |
| *** pots has joined #openstack-cinder | 18:58 | |
| *** bardia has quit IRC | 19:00 | |
| *** martyturner has joined #openstack-cinder | 19:00 | |
| *** pots2 has quit IRC | 19:00 | |
| *** jerrygb has joined #openstack-cinder | 19:01 | |
| *** sghanekar__ has joined #openstack-cinder | 19:02 | |
| *** hemna has joined #openstack-cinder | 19:03 | |
| *** pdardeau1 has joined #openstack-cinder | 19:04 | |
| *** pdardeau1 has quit IRC | 19:04 | |
| *** Lee1092 has quit IRC | 19:09 | |
| *** martyturner has quit IRC | 19:09 | |
| openstackgerrit | Merged openstack/cinder: Fix metadata retrieval in GPFS driver https://review.openstack.org/246861 | 19:10 |
| *** alejandrito has quit IRC | 19:10 | |
| openstackgerrit | Merged openstack/cinder: Add check_uptodate.sh --checkopts to "pep8" https://review.openstack.org/247796 | 19:10 |
| openstackgerrit | Merged openstack/cinder: Don't build two tox envs for pep8(-constraints) https://review.openstack.org/247806 | 19:10 |
| *** martyturner has joined #openstack-cinder | 19:14 | |
| angela-s | hemna: CI is passing now. https://review.openstack.org/#/c/180518/ | 19:15 |
| hemna | angela-s, nice! | 19:15 |
| angela-s | hemna: can you review again when you have a chance? thanks! | 19:16 |
| *** merooney has joined #openstack-cinder | 19:16 | |
| hemna | angela-s, ok I'll add it to my queue today | 19:16 |
| *** mtanino has joined #openstack-cinder | 19:18 | |
| *** sgundur has joined #openstack-cinder | 19:20 | |
| *** anshul has joined #openstack-cinder | 19:20 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Move quota checks from manager to API https://review.openstack.org/249388 | 19:26 |
| *** pots has quit IRC | 19:28 | |
| *** IlyaG has joined #openstack-cinder | 19:31 | |
| jgriffith | smcginnis: is the bug here that the user wants more info in the Error message: https://bugs.launchpad.net/cinder/+bug/1388714 ? | 19:38 |
| openstack | Launchpad bug 1388714 in Cinder "cinder api don't throw out appropriate exception when deleting volume detached or with snapshot " [Undecided,Triaged] | 19:38 |
| smcginnis | jgriffith: Just had to reread that first sentence 5 times. This might take a little. ;) | 19:39 |
| jgriffith | LOL | 19:39 |
| jgriffith | Ok, it's not just me then :) | 19:39 |
| jgriffith | that's all I needed to know :) | 19:39 |
| smcginnis | jgriffith: Yeah, that's my interpretation too. I think they are saying it should give more of a reason or better message. | 19:39 |
| hemna | whoa | 19:40 |
| smcginnis | jgriffith: Actually looks like a patch merged for that one. | 19:40 |
| smcginnis | But state of bug never got updated. | 19:41 |
| *** salv-orlando has quit IRC | 19:41 | |
| smcginnis | Oh, because patch was for oslo. | 19:41 |
| *** chenying_ has joined #openstack-cinder | 19:41 | |
| openstackgerrit | Kendall Nelson proposed openstack/cinder: Hacking Checks for assertTrue/IsNone() https://review.openstack.org/246554 | 19:42 |
| *** chenying has quit IRC | 19:43 | |
| *** baumann1 has joined #openstack-cinder | 19:44 | |
| *** baumann has quit IRC | 19:44 | |
| smcginnis | jgriffith, hemna: While you guys are here - thinking of getting a 1.5.0 release of python-cinderclient once this lands: https://review.openstack.org/#/c/231708/ | 19:45 |
| smcginnis | Make sense? | 19:45 |
| smcginnis | Or is there anything else we should wait for. | 19:45 |
| smcginnis | Seems like a useful thing to get out there now that we have a few drivers implementing it. | 19:45 |
| hemna | heh yah we need that guy out there if anyone is going to do some work against it | 19:45 |
| hemna | I haven't been able to test it just yet though | 19:46 |
| hemna | so I'm not sure how the replication targets list looks | 19:46 |
| openstackgerrit | Bardia Keyoumarsi proposed openstack/cinder: Volume driver for Coho Data storage solutions https://review.openstack.org/246690 | 19:47 |
| smcginnis | hemna: I just figure we have enough time that if we want to improve it before the end of M we can. | 19:47 |
| jgriffith | hemna: this doesn't help you? https://github.com/openstack/cinder/blob/master/doc/source/devref/replication.rst | 19:49 |
| hemna | kinda | 19:51 |
| hemna | was hoping to see the exact output of the list replication targets command | 19:52 |
| jgriffith | hemna: ok, I'll post it tomorrow | 19:52 |
| hemna | aorourke, has an example on our internal wiki | 19:52 |
| jgriffith | hemna: with some other examples to try and help | 19:52 |
| hemna | was hoping it would have been public.... | 19:52 |
| jgriffith | Oh yeah.. an internal HP wiki | 19:52 |
| jgriffith | sign me up :) | 19:52 |
| hemna | hehe | 19:52 |
| smcginnis | hemna: Don't suppose you could copy from there and comment in the patch? | 19:53 |
| hemna | smcginnis, yah, just making sure what he has is up to date/correct in sync w/ his patch | 19:53 |
| *** dims has joined #openstack-cinder | 19:53 | |
| smcginnis | Cool | 19:53 |
| *** pots has joined #openstack-cinder | 19:53 | |
| *** dims_ has quit IRC | 19:56 | |
| *** martyturner has quit IRC | 19:56 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port key manager to Python 3 https://review.openstack.org/249397 | 19:59 |
| hemna | smcginnis, jgriffith ok I'm having him rework his example output. | 20:00 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Move quota checks from manager to API https://review.openstack.org/249388 | 20:00 |
| hemna | using 2 different drivers | 20:00 |
| *** pots2 has joined #openstack-cinder | 20:00 | |
| *** anshul has quit IRC | 20:01 | |
| jgriffith | hemna: smcginnis I posted a few comments in that review | 20:01 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Move quota checks from manager to API https://review.openstack.org/249388 | 20:01 |
| hemna | aorourke, ping | 20:02 |
| *** pots has quit IRC | 20:02 | |
| aorourke | hemna, hey | 20:02 |
| hemna | jgriffith, cool. just saw your comments and I agree w/ em. | 20:03 |
| openstackgerrit | Merged openstack/cinder: Declare multiattach is True in RBD driver https://review.openstack.org/249080 | 20:03 |
| *** sgundur has left #openstack-cinder | 20:03 | |
| hemna | aorourke, you have some more feedback on the client review | 20:03 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port zonemanager to Python 3 https://review.openstack.org/249398 | 20:03 |
| hemna | ok lunch..... | 20:04 |
| aorourke | hemna, going over that right now | 20:04 |
| *** martyturner has joined #openstack-cinder | 20:04 | |
| *** sgundur has joined #openstack-cinder | 20:06 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Test middleware test_faults to Python 3 https://review.openstack.org/249399 | 20:06 |
| aorourke | jgriffith, I addressed your comments. | 20:08 |
| jgriffith | aorourke: oh.. well that sounds inviting | 20:08 |
| aorourke | jgriffith, no I agree with them | 20:08 |
| jgriffith | aorourke: :) | 20:08 |
| aorourke | jgriffith, just looking to see how we want to move forward | 20:08 |
| jgriffith | aorourke: so your responses look fine to me | 20:09 |
| jgriffith | aorourke: I would love to do something like "rep-enable" | 20:10 |
| aorourke | jgriffith, great, I will make the changes | 20:10 |
| jgriffith | keep it easy to type :) | 20:10 |
| jgriffith | but certainly up to you | 20:10 |
| jgriffith | wait... one thing | 20:10 |
| aorourke | jgriffith, what's up? | 20:10 |
| jgriffith | I seem to recall there's a replication term being used somewhere | 20:10 |
| jgriffith | in OpenStack | 20:10 |
| jgriffith | NM, that's an internal construct | 20:11 |
| dulek | ntpttr: I've commented on https://review.openstack.org/#/c/243673/ - pinging you to make sure you'll notice even after abandoning it. :) | 20:11 |
| *** changbl has quit IRC | 20:11 | |
| aorourke | jgriffith, ok. I will make these changes as discussed | 20:11 |
| jgriffith | aorourke: awesome, thanks! | 20:12 |
| dulek | ntpttr: BTW - you can add me as reviewer on your series of smaller patches. | 20:12 |
| *** martyturner has quit IRC | 20:13 | |
| *** ociuhandu has quit IRC | 20:13 | |
| *** amrith is now known as _amrith_ | 20:16 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Add replicate by volume-type to SolidFire driver https://review.openstack.org/238276 | 20:16 |
| openstackgerrit | John Griffith proposed openstack/cinder: Add cluster Pairing setup to SolidFire driver https://review.openstack.org/238235 | 20:16 |
| *** thangp has quit IRC | 20:19 | |
| *** apoorvad has quit IRC | 20:21 | |
| erlon | jgriffith: ping | 20:23 |
| *** thangp has joined #openstack-cinder | 20:24 | |
| *** IlyaG has quit IRC | 20:25 | |
| *** sghanekar__ has quit IRC | 20:26 | |
| *** lprice1 has joined #openstack-cinder | 20:28 | |
| *** lprice has quit IRC | 20:30 | |
| *** lprice has joined #openstack-cinder | 20:31 | |
| *** changbl has joined #openstack-cinder | 20:31 | |
| *** lprice1 has quit IRC | 20:33 | |
| *** edtubill has joined #openstack-cinder | 20:34 | |
| openstackgerrit | Alex O'Rourke proposed openstack/python-cinderclient: Adds v2 replication support https://review.openstack.org/231708 | 20:34 |
| jgriffith | mc_nair: BTW... BIG THANK you to the thorough review on this: https://review.openstack.org/#/c/238276/4..5/cinder/volume/drivers/solidfire.py | 20:34 |
| jgriffith | mc_nair: I'm implementing your suggestions now, appreciate the thorough feedback | 20:34 |
| *** ociuhandu has joined #openstack-cinder | 20:35 | |
| mc_nair | jgriffith: anytime :) will look over both those again whenever they're ready | 20:37 |
| jgriffith | mc_nair: cool... should be just a few minutes, trying to figure out my mess with repdata and build_endpoint that you pointed out | 20:38 |
| *** e0ne has quit IRC | 20:38 | |
| aorourke | jgriffith, smcginnis, hemna I added a comment with the link showing what listing replication targets looks like. I have two targets in this example | 20:38 |
| aorourke | here it is if you dont want to open the patch :) http://paste.openstack.org/show/479916/ | 20:39 |
| *** lprice has quit IRC | 20:39 | |
| *** lprice has joined #openstack-cinder | 20:39 | |
| smcginnis | aorourke: Thanks! | 20:44 |
| *** baumann1 has left #openstack-cinder | 20:45 | |
| smcginnis | aorourke: I'm assuming unmanaged will just have no value in the last column? | 20:45 |
| aorourke | smcginnis, correct. | 20:45 |
| aorourke | smcginnis, or None | 20:45 |
| *** sghanekar__ has joined #openstack-cinder | 20:48 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Add replicate by volume-type to SolidFire driver https://review.openstack.org/238276 | 20:54 |
| jgriffith | aorourke: so I thought we agreed that a device_identifier was required | 20:55 |
| jgriffith | aorourke: regardless of managed/unmanaged | 20:55 |
| jgriffith | aorourke: in which case, I'd suggest we just use that | 20:55 |
| jgriffith | The Admin should know what they configured, and if they don't "cat /etc/cinder/cinder.conf" :) | 20:56 |
| *** IlyaG has joined #openstack-cinder | 20:56 | |
| jgriffith | Also this way you're not leaking any abstraction info to the end-user if you ever make "rep-target-list" publicly viewable | 20:56 |
| smcginnis | jgriffith: device_identifier is different than remote_device_id? | 20:56 |
| jgriffith | smcginnis: same thing :) | 20:56 |
| jgriffith | smcginnis: I just make up words as I go along :) | 20:56 |
| smcginnis | :) | 20:57 |
| smcginnis | jgriffith: Just trying to understand what you're saying. That the list should only show that id? | 20:57 |
| jgriffith | smcginnis: if we wanted to go crazy in the future we could actually assign a UUID and create a DB entry | 20:57 |
| jgriffith | smcginnis: yes, correct | 20:57 |
| jgriffith | smcginnis: because that's a required field in the config now | 20:57 |
| smcginnis | No managed/unmanaged. no managed backend name, just a list of ids, right? | 20:57 |
| jgriffith | so it will be there in all cases | 20:57 |
| jgriffith | smcginnis: exact-u-mundo | 20:58 |
| smcginnis | jgriffith: Got it. I guess that makes sense. The rest is based on however they've configured it, so I guess that's all they really need. | 20:58 |
| jgriffith | smcginnis: that's my opinion | 20:58 |
| smcginnis | jgriffith: OK, devil's advocate, what if the client user is not the admin of the host and does not have ready access to the cinder.conf file? | 20:59 |
| jgriffith | smcginnis: then they're not supposed to know those details anyway :) | 21:00 |
| smcginnis | Not likely, but just sayin'. | 21:00 |
| *** salv-orlando has joined #openstack-cinder | 21:00 | |
| smcginnis | Fair enough. :) | 21:00 |
| jgriffith | smcginnis: even backend-name, host-name etc is all supposed to be hidden from them :) | 21:00 |
| *** salv-orl_ has joined #openstack-cinder | 21:01 | |
| *** dustins has quit IRC | 21:01 | |
| *** raildo is now known as raildo-afk | 21:01 | |
| smcginnis | I do agree it's best to start with a minimal usable feature and make it more complicated only after it's been shown to need it. So in that respect, I agree. | 21:01 |
| jgriffith | smcginnis: I wonder if we should change that though: s/device_target_id/target_device_id/ | 21:03 |
| jgriffith | ? | 21:03 |
| jgriffith | smcginnis: aorourke mc_nair thoughts? | 21:03 |
| smcginnis | jgriffith: I do like the second better. | 21:03 |
| smcginnis | The first sounds like a device's ID. | 21:03 |
| jgriffith | or even "rep_device_id" | 21:03 |
| smcginnis | The second sounds more like the ID of the target. | 21:03 |
| jgriffith | smcginnis: yeah... the first one is confusing I think | 21:03 |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - Extend Volume for VMAX3 https://review.openstack.org/248941 | 21:04 |
| smcginnis | Subtle but that does sound clearer to me. | 21:04 |
| jgriffith | smcginnis: ok, last question.... | 21:04 |
| jgriffith | Do you prefer "target_device_id" or "replication_device_id" | 21:04 |
| *** salv-orlando has quit IRC | 21:05 | |
| smcginnis | Hmmm... target I think. | 21:05 |
| jgriffith | smcginnis: sold! | 21:05 |
| smcginnis | :) | 21:05 |
| *** EinstCrazy has joined #openstack-cinder | 21:06 | |
| aorourke | smcginnis, jgriffith ok, sorry stepped away for a bit. It sounds like we are leaning towards "replication_device_id" and ONLY showing a list of IDs? No managed/unmanaged? No backend name? | 21:07 |
| aorourke | my only concern is the people who have patches in progress for replication...I have been correcting everyone to use remote_device_id. We can always go back and change all this obviously... | 21:07 |
| jgriffith | aorourke: yes to showing only the ID's | 21:08 |
| smcginnis | aorourke: Yes. Though I was thinking target_device_id makes more sense (at least to me) but really either target or replication work fine. | 21:08 |
| jgriffith | aorourke: jury is out on name... smcginnis is leaning towards target_device_id | 21:08 |
| jgriffith | I'm indiffernt | 21:08 |
| jgriffith | Just need to know so I can finish this patch :) | 21:08 |
| smcginnis | I don't have a strong enough opinion really. | 21:08 |
| aorourke | ok that works for me as well. I will make it "target_device_id" | 21:08 |
| aorourke | and remove the other keys | 21:08 |
| aorourke | one sec | 21:08 |
| smcginnis | +1 | 21:08 |
| smcginnis | Times up. | 21:08 |
| jgriffith | excellent | 21:09 |
| mc_nair | just caught up but looks like you guys got it all under control.... that was easy :) | 21:09 |
| smcginnis | ;) | 21:09 |
| openstackgerrit | Bardia Keyoumarsi proposed openstack/cinder: Volume driver for Coho Data storage solutions https://review.openstack.org/246690 | 21:09 |
| openstackgerrit | Alex O'Rourke proposed openstack/python-cinderclient: Adds v2 replication support https://review.openstack.org/231708 | 21:12 |
| *** EinstCrazy has quit IRC | 21:12 | |
| aorourke | hope that settles it :) | 21:16 |
| smcginnis | aorourke: I hope so too. ;) | 21:16 |
| smcginnis | aorourke: Thanks for working on it. | 21:16 |
| *** akshai has quit IRC | 21:22 | |
| *** akshai has joined #openstack-cinder | 21:23 | |
| *** jgregor has quit IRC | 21:24 | |
| *** jgregor has joined #openstack-cinder | 21:24 | |
| *** lpetrut has joined #openstack-cinder | 21:26 | |
| mc_nair | aorourke: looking at that v2 patch - is there a reason the replication_list_targets is using a POST? | 21:29 |
| *** akerr has quit IRC | 21:29 | |
| aorourke | mc_nair, I am pretty sure that is how it is designed. I have to have post the volume_id to it. I may be wrong though....was a while since I last looked at these | 21:31 |
| jgriffith | anybody else seeing something like this: https://gist.github.com/b3652ee25df4aa74aaa5 | 21:33 |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: 3PAR: Implement v2 replication (managed) https://review.openstack.org/231201 | 21:34 |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: 3PAR: Implement v2 replication (unmanaged) https://review.openstack.org/231245 | 21:34 |
| smcginnis | jgriffith: git status show anything? | 21:34 |
| jgriffith | nope, it just boots my changes back out to uncomitted | 21:34 |
| jgriffith | weird | 21:34 |
| jgriffith | I've never seen this before | 21:35 |
| jgriffith | even tried a fresh repo | 21:35 |
| jgriffith | err... fresh clone | 21:35 |
| smcginnis | git stash your changes to get them out of the way, pull, then apply the stashed changes? | 21:35 |
| jgriffith | tried that.. just did the same goofy thing :( | 21:35 |
| smcginnis | That is really odd. | 21:36 |
| *** aorourke is now known as aorourke-afk | 21:36 | |
| smcginnis | jgriffith: You're just trying to rebase on master, right? | 21:36 |
| jgriffith | smcginnis: well, that's what is weird | 21:36 |
| jgriffith | smcginnis: I just did "git commit -a" typed in my fancy commit mesg (sans spelling errors) and said "git review" | 21:37 |
| jgriffith | smcginnis: and it vomitted on me | 21:37 |
| *** dims has quit IRC | 21:37 | |
| smcginnis | jgriffith: Oh, I have seen that. | 21:38 |
| jgriffith | oh? | 21:38 |
| jgriffith | do tell | 21:38 |
| smcginnis | git review does a rebase first to make sure you are on the latest and no conflicts before pushing up. | 21:38 |
| *** dims has joined #openstack-cinder | 21:38 | |
| smcginnis | jgriffith: Can you manually: git checkout master; git pull; git checkout yourbranch; git rebase master | 21:39 |
| jgriffith | smcginnis: hmm... think I just found the problem | 21:39 |
| smcginnis | jgriffith: Yah? | 21:39 |
| jgriffith | smcginnis: I have an RBD WIP change in my tree | 21:39 |
| *** merooney has quit IRC | 21:39 | |
| jgriffith | although... that still seems odd | 21:39 |
| smcginnis | jgriffith: Doh! :) | 21:39 |
| jgriffith | let me try starting over | 21:39 |
| openstackgerrit | Kaitlin Farr proposed openstack/cinder-specs: Integrate Castellan for Key Management https://review.openstack.org/247577 | 21:40 |
| *** jaypipes has quit IRC | 21:47 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Update list_replication_targets https://review.openstack.org/249439 | 21:47 |
| jgriffith | geesh! That was painful | 21:47 |
| mc_nair | jgriffith, smcginnis - do you know if / why need to do a POST for os-list_replication_targets to get the targets? This is regarding the v2 replication client patch | 21:48 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Move quota checks from manager to API https://review.openstack.org/249441 | 21:48 |
| *** boris-42 has quit IRC | 21:48 | |
| jgriffith | mc_nair: link to your patch? | 21:49 |
| *** bardia has joined #openstack-cinder | 21:49 | |
| jgriffith | mc_nair: IIRC you don't | 21:49 |
| mc_nair | jgriffith: sorry - this one: https://review.openstack.org/#/c/231708 | 21:50 |
| jgriffith | mc_nair: It's ok, I'm just too lazy to look :) | 21:50 |
| jgriffith | mc_nair: ok, sorry... not following wht you mean. I had assumed you meant a self.post statement | 21:51 |
| mc_nair | jgriffith: me speak bad | 21:52 |
| jgriffith | LOL | 21:52 |
| mc_nair | jgriffith: added a comment to that patch trying to clarifying the question I'm trying to ask - lemme know if I'm just totally missing something / still totally unintelligible | 21:53 |
| jgriffith | ohhhh | 21:54 |
| jgriffith | huh | 21:54 |
| jgriffith | mc_nair: I don't know why you would need anything different than what you have | 21:56 |
| jgriffith | mc_nair: self._action is a post | 21:57 |
| jgriffith | I'm rather confused | 21:57 |
| jgriffith | sorry :( | 21:58 |
| mc_nair | jgriffith: think we are still missing each other :) this is aorourke-afk's patch. It was just odd to me when looking at it that in order to *list* the replication targets that we have to do a POST call. So I'm trying to figure out if in fact we need a POST call or if we could just be doing a GET (since it is just listing) | 21:58 |
| jgriffith | IIRC we use that on all of the contrib modules | 21:58 |
| jgriffith | mc_nair: OHHHH | 21:58 |
| jgriffith | :) | 21:58 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Move quota checks from manager to API https://review.openstack.org/249388 | 21:59 |
| *** akshai has quit IRC | 21:59 | |
| jgriffith | mc_nair: honestly, that's a common thing to swap around | 22:00 |
| jgriffith | mc_nair: BUT | 22:00 |
| jgriffith | in the case of admin-actions/ contrib items... we consider this possibly sensitive data | 22:00 |
| jgriffith | in which case the RFC recommends POST | 22:00 |
| jgriffith | and well... since we use it everywhere else, I see no reason to use something different :) | 22:01 |
| *** akshai has joined #openstack-cinder | 22:01 | |
| jgriffith | mc_nair: does that make it about as clear as mud :) | 22:01 |
| mc_nair | jgriffith: ah - gotcha. Ok that makes sense. Thanks for the explanation... figured I was missing something | 22:01 |
| mc_nair | thanks for fighting through the missed communications :) | 22:01 |
| *** sgotliv has quit IRC | 22:02 | |
| jgriffith | haha... I'm the one who should say thanks, it happens with me a lot | 22:02 |
| jgriffith | I'm good at figuring it out in my head... but I sadly tend to assume others know what I'm thinking and have the exact same background thought/process | 22:02 |
| jgriffith | mc_nair: and honestly... well; they should damn it! | 22:02 |
| *** _amrith_ is now known as amrith | 22:03 | |
| mc_nair | jgriffith: but then we don't get to play IRC charades and where's the fun in that? | 22:03 |
| jgriffith | mc_nair: good point! | 22:04 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Move quota checks from manager to API https://review.openstack.org/249441 | 22:04 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Move quota checks from manager to API https://review.openstack.org/249441 | 22:04 |
| *** lpetrut has quit IRC | 22:07 | |
| *** apoorvad has joined #openstack-cinder | 22:08 | |
| hemna | angela-s, ping | 22:10 |
| *** xyang has quit IRC | 22:10 | |
| *** edtubill has quit IRC | 22:13 | |
| *** jerrygb has quit IRC | 22:14 | |
| *** jerrygb has joined #openstack-cinder | 22:15 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - Changing PercentSynced to CopyState in isSynched https://review.openstack.org/246992 | 22:20 |
| *** kfarr has quit IRC | 22:22 | |
| angela-s | hemna: hey | 22:22 |
| *** vgridnev has quit IRC | 22:24 | |
| hemna | angela-s, hey, question for you about this | 22:24 |
| hemna | angela-s, https://review.openstack.org/#/c/180518/21/cinder/zonemanager/utils.py | 22:24 |
| hemna | does it ever make sense that an FCZM vendor would want it's own algorithm for generating a friendly name ? | 22:24 |
| hemna | as certain backends would have different size limitations and/or character limitations on the switch itself, depending on version, firmware, etc. ? | 22:25 |
| angela-s | i don't think so. the only difference i know of is character set | 22:26 |
| hemna | because otherwise that method belongs on the FCZM API itself | 22:27 |
| hemna | not in utils.py | 22:27 |
| *** diablo_rojo has quit IRC | 22:28 | |
| *** diablo_rojo has joined #openstack-cinder | 22:29 | |
| angela-s | hemna: ok, i see your point. i could put it in FCCommon | 22:30 |
| hemna | angela-s, I think it probably belongs there | 22:30 |
| hemna | angela-s, at least it gives the vendors a chance to change it, if it doesn't work on their backend in the future, for whatever reason | 22:31 |
| *** thangp has quit IRC | 22:31 | |
| angela-s | hemna: ok, ok. any other nitpicks? :) | 22:31 |
| hemna | I just started :P | 22:32 |
| hemna | I wasn't sure if I was just way off base or not | 22:32 |
| *** diablo_rojo has quit IRC | 22:36 | |
| *** IlyaG has quit IRC | 22:36 | |
| *** davechen has left #openstack-cinder | 22:37 | |
| *** IlyaG has joined #openstack-cinder | 22:38 | |
| *** mriedem has quit IRC | 22:38 | |
| *** IlyaG has quit IRC | 22:39 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - Replacing depreciated API EMCGetTargetEndpoints https://review.openstack.org/244328 | 22:43 |
| *** mc_nair has quit IRC | 22:46 | |
| *** mc_nair has joined #openstack-cinder | 22:51 | |
| *** mc_nair has quit IRC | 22:53 | |
| *** hemna is now known as hemnafk | 22:55 | |
| *** ntpttr has left #openstack-cinder | 22:57 | |
| *** jungleboyj has quit IRC | 22:58 | |
| *** simondodsley has quit IRC | 22:58 | |
| *** jgregor has quit IRC | 22:59 | |
| *** jgregor has joined #openstack-cinder | 22:59 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Move quota checks from manager to API Part 2 https://review.openstack.org/249441 | 22:59 |
| *** jgregor has quit IRC | 23:00 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Move quota checks from manager to API Part 1 https://review.openstack.org/249388 | 23:00 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Move quota checks from manager to API Part 2 https://review.openstack.org/249441 | 23:01 |
| *** sgundur has quit IRC | 23:02 | |
| Swanson | asselin, around? | 23:04 |
| asselin | Swanson, I am | 23:04 |
| Swanson | asselin, my Jenkins jobs are largely the samples. They refer to a d-p-c node. Jenkins knows nothing of a d-p-c node. What step did I miss? | 23:05 |
| asselin | did you build your nodepool image? | 23:05 |
| asselin | and start nodepool? | 23:05 |
| Swanson | I did. | 23:05 |
| Swanson | On my cloud I have a couple template-dpc-number images. | 23:06 |
| asselin | Swanson, does nodepool show any nodes built? | 23:06 |
| asselin | sudo nodepool list | 23:06 |
| asselin | any vms based off those templates in your cloud? | 23:06 |
| *** jccnd has quit IRC | 23:06 | |
| Swanson | I keep seeing an instance appear and then go away. And nodepool list shows building. | 23:07 |
| Swanson | Sounds like nodepool is choking | 23:07 |
| Swanson | ssh fail... | 23:08 |
| *** boris-42 has joined #openstack-cinder | 23:10 | |
| *** jwcroppe has quit IRC | 23:11 | |
| *** jwcroppe has joined #openstack-cinder | 23:13 | |
| asselin | Swanson, why does ssh fail? authentication? | 23:17 |
| *** jwcroppe has quit IRC | 23:17 | |
| *** jwcroppe has joined #openstack-cinder | 23:18 | |
| Swanson | asselin, Not sure yet. I'm thinking I must have another setup error with my cloud. | 23:18 |
| asselin | ok, you know where the nodepool log files are? | 23:18 |
| Swanson | asselin, Yep. Just needed to be poked in the right direction. Thanks! | 23:19 |
| asselin | cool | 23:19 |
| Swanson | I hope I remember what I was doing when I'm back in the office next week. | 23:20 |
| *** jwcroppe has quit IRC | 23:22 | |
| *** apoorvad has quit IRC | 23:25 | |
| asselin | yeah :) | 23:27 |
| *** dims_ has joined #openstack-cinder | 23:28 | |
| *** dims has quit IRC | 23:29 | |
| *** IlyaG has joined #openstack-cinder | 23:31 | |
| *** willsama has quit IRC | 23:31 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - Replacing depreciated API EMCGetTargetEndpoints https://review.openstack.org/244328 | 23:38 |
| *** akshai has quit IRC | 23:39 | |
| *** akshai has joined #openstack-cinder | 23:40 | |
| *** rcernin has quit IRC | 23:42 | |
| *** akshai_ has joined #openstack-cinder | 23:45 | |
| *** akshai has quit IRC | 23:46 | |
| *** dustins has joined #openstack-cinder | 23:46 | |
| *** yhayashi has joined #openstack-cinder | 23:47 | |
| Swanson | asselin, Dumb question. where do I define the password for the nodepool image I created. Trying to log into a copy and see if it is functional.... | 23:51 |
| *** apoorvad has joined #openstack-cinder | 23:51 | |
| asselin | Swanson, no password. use the ssh private key | 23:52 |
| asselin | with 'jenkins' user | 23:52 |
| Swanson | asselin, ah. Was thinking that might be the case. Not so great from the console. | 23:53 |
| *** jwcroppe has joined #openstack-cinder | 23:53 | |
| *** EinstCrazy has joined #openstack-cinder | 23:56 | |
| *** angela-s has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
