| *** crose has quit IRC | 00:00 | |
| *** haomaiwang has quit IRC | 00:01 | |
| *** haomaiwang has joined #openstack-cinder | 00:01 | |
| *** martyturner has quit IRC | 00:01 | |
| *** angela-s has quit IRC | 00:04 | |
| *** daneyon_ has joined #openstack-cinder | 00:06 | |
| *** daneyon has quit IRC | 00:09 | |
| *** markvoelker has quit IRC | 00:11 | |
| *** daneyon_ has quit IRC | 00:11 | |
| *** laughterwym has joined #openstack-cinder | 00:12 | |
| *** alonma has joined #openstack-cinder | 00:13 | |
| *** laughter_ has joined #openstack-cinder | 00:16 | |
| *** zhangjn has joined #openstack-cinder | 00:17 | |
| *** laughterwym has quit IRC | 00:17 | |
| *** laughter_ has quit IRC | 00:18 | |
| *** markvoelker has joined #openstack-cinder | 00:18 | |
| *** alonma has quit IRC | 00:18 | |
| *** laughterwym has joined #openstack-cinder | 00:18 | |
| *** alonma has joined #openstack-cinder | 00:19 | |
| *** sombrafam has quit IRC | 00:19 | |
| *** sombrafam has joined #openstack-cinder | 00:20 | |
| *** alonma has quit IRC | 00:24 | |
| *** merooney has quit IRC | 00:24 | |
| *** laughterwym has quit IRC | 00:24 | |
| *** laughterwym has joined #openstack-cinder | 00:28 | |
| *** sombrafam has quit IRC | 00:30 | |
| *** sombrafam has joined #openstack-cinder | 00:31 | |
| openstackgerrit | Merged openstack/os-brick: Add reno for release notes management https://review.openstack.org/253207 | 00:31 |
|---|---|---|
| *** zhangjn has quit IRC | 00:39 | |
| openstackgerrit | XinXiaohui proposed openstack/cinder: Calculate virtual free capacity and notify https://review.openstack.org/206923 | 00:40 |
| *** zhangjn has joined #openstack-cinder | 00:41 | |
| *** zhangjn has quit IRC | 00:41 | |
| *** qeelee has joined #openstack-cinder | 00:43 | |
| *** salv-orlando has quit IRC | 00:43 | |
| *** Julien-zte has joined #openstack-cinder | 00:52 | |
| *** lixiaoy1 has joined #openstack-cinder | 00:54 | |
| *** winston-1 has quit IRC | 00:58 | |
| *** akerr has joined #openstack-cinder | 00:59 | |
| *** jidar has quit IRC | 01:00 | |
| *** qeelee has left #openstack-cinder | 01:00 | |
| *** haomaiwang has quit IRC | 01:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 01:01 | |
| *** akerr_ has joined #openstack-cinder | 01:02 | |
| *** yhayashi has quit IRC | 01:02 | |
| *** daneyon has joined #openstack-cinder | 01:02 | |
| *** jidar has joined #openstack-cinder | 01:04 | |
| *** salv-orlando has joined #openstack-cinder | 01:04 | |
| *** akerr has quit IRC | 01:05 | |
| *** winston-d has joined #openstack-cinder | 01:06 | |
| *** cheneydc has joined #openstack-cinder | 01:06 | |
| *** akerr has joined #openstack-cinder | 01:06 | |
| *** akerr__ has joined #openstack-cinder | 01:08 | |
| *** markvoelker has quit IRC | 01:09 | |
| *** davechen has joined #openstack-cinder | 01:09 | |
| *** salv-orlando has quit IRC | 01:09 | |
| *** akerr_ has quit IRC | 01:09 | |
| *** yhayashi has joined #openstack-cinder | 01:10 | |
| *** leeantho has quit IRC | 01:10 | |
| *** mriedem has joined #openstack-cinder | 01:11 | |
| *** akerr has quit IRC | 01:11 | |
| *** pratap has quit IRC | 01:11 | |
| *** pratap__ has quit IRC | 01:11 | |
| *** wilson has joined #openstack-cinder | 01:16 | |
| *** wilson is now known as Guest40918 | 01:16 | |
| *** challenge has joined #openstack-cinder | 01:16 | |
| challenge | Hi guys | 01:16 |
| *** haomaiwa_ has quit IRC | 01:17 | |
| challenge | I would like to cinder an NFS backend to store my vm | 01:17 |
| *** Guest40918 has quit IRC | 01:17 | |
| challenge | I'm having this message Failed to created Cinder secure environment indicator file: [Errno 13] Permission denied: '/var/lib/cinder/mnt/2ef7a6e750a5e5ba5a3aa6623bc8a01f/.cinderSecureEnvIndicator'" | 01:17 |
| challenge | Failed to created Cinder secure environment indicator file: [Errno 13] Permission denied: '/var/lib/cinder/mnt/2ef7a6e750a5e5ba5a3aa6623bc8a01f/.cinderSecureEnvIndicator' | 01:18 |
| *** alonma has joined #openstack-cinder | 01:20 | |
| *** wilson-liu has joined #openstack-cinder | 01:21 | |
| wilson-liu | hi | 01:22 |
| wilson-liu | The jenkins gate always fails | 01:22 |
| wilson-liu | My patch fails the the gate twice | 01:22 |
| wilson-liu | I have checked that the failure has no relation with my patch | 01:23 |
| wilson-liu | Should I just 'recheck no bug' again? | 01:23 |
| *** alonma has quit IRC | 01:24 | |
| *** cheneydc has quit IRC | 01:25 | |
| *** Lee1092 has joined #openstack-cinder | 01:25 | |
| *** cheneydc has joined #openstack-cinder | 01:25 | |
| *** davechen1 has joined #openstack-cinder | 01:28 | |
| *** davechen has quit IRC | 01:30 | |
| *** dslev has joined #openstack-cinder | 01:30 | |
| *** zhonghua-lee has joined #openstack-cinder | 01:30 | |
| lixiaoy1 | challenge: the nfs authority is not set correctly | 01:30 |
| *** dslev_ has joined #openstack-cinder | 01:32 | |
| *** cheneydc has quit IRC | 01:34 | |
| *** hunters1094 has joined #openstack-cinder | 01:35 | |
| *** dslev has quit IRC | 01:35 | |
| lixiaoy1 | challenge: in test env, you can set nas_secure_file_permissions as false, and nas_secure_file_operations as false | 01:38 |
| *** apoorvad has quit IRC | 01:46 | |
| challenge | lixiaoy1, thanks you | 01:49 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Support cinder_img_volume_type in image metadata https://review.openstack.org/258649 | 01:55 |
| *** dslev_ has quit IRC | 01:55 | |
| *** chhavi has quit IRC | 01:59 | |
| *** dims__ has joined #openstack-cinder | 02:04 | |
| *** haomaiwang has joined #openstack-cinder | 02:05 | |
| *** dims_ has quit IRC | 02:06 | |
| *** mtanino has quit IRC | 02:07 | |
| *** mriedem has quit IRC | 02:12 | |
| *** cheneydc has joined #openstack-cinder | 02:15 | |
| *** alonma has joined #openstack-cinder | 02:20 | |
| *** davechen1 has quit IRC | 02:23 | |
| *** alonma has quit IRC | 02:24 | |
| *** alonma has joined #openstack-cinder | 02:26 | |
| *** laughterwym has quit IRC | 02:29 | |
| *** laughterwym has joined #openstack-cinder | 02:30 | |
| *** alonma has quit IRC | 02:30 | |
| *** laughter_ has joined #openstack-cinder | 02:31 | |
| *** alonma has joined #openstack-cinder | 02:34 | |
| *** [1]Thelo has joined #openstack-cinder | 02:34 | |
| *** laughterwym has quit IRC | 02:34 | |
| *** laughterwym has joined #openstack-cinder | 02:36 | |
| *** Thelo has quit IRC | 02:36 | |
| *** [1]Thelo is now known as Thelo | 02:36 | |
| *** alonma has quit IRC | 02:38 | |
| openstackgerrit | XinXiaohui proposed openstack/cinder: Calculate virtual free capacity and notify https://review.openstack.org/206923 | 02:39 |
| *** laughter_ has quit IRC | 02:39 | |
| *** alonma has joined #openstack-cinder | 02:41 | |
| *** sombrafam has quit IRC | 02:41 | |
| *** sombrafam has joined #openstack-cinder | 02:42 | |
| *** alonma has quit IRC | 02:46 | |
| openstackgerrit | Ryan McNair proposed openstack/cinder: Rework Storwize/SVC protocol to fix add_vdisk_copy https://review.openstack.org/269895 | 02:46 |
| *** sombrafam has quit IRC | 02:47 | |
| *** sombrafam has joined #openstack-cinder | 02:48 | |
| *** alonma has joined #openstack-cinder | 02:49 | |
| *** sheel has joined #openstack-cinder | 02:51 | |
| *** mudassirlatif has quit IRC | 02:51 | |
| *** sheel has quit IRC | 02:51 | |
| *** gcb has quit IRC | 02:53 | |
| *** alonma has quit IRC | 02:53 | |
| *** alonma has joined #openstack-cinder | 02:56 | |
| *** except has joined #openstack-cinder | 02:59 | |
| *** laughterwym has quit IRC | 02:59 | |
| *** except is now known as Guest3765 | 03:00 | |
| *** laughterwym has joined #openstack-cinder | 03:00 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** laughterwym has quit IRC | 03:01 | |
| *** alonma has quit IRC | 03:01 | |
| *** 77CAAARUP has joined #openstack-cinder | 03:01 | |
| *** laughterwym has joined #openstack-cinder | 03:01 | |
| *** challenge has quit IRC | 03:02 | |
| *** laughter_ has joined #openstack-cinder | 03:02 | |
| *** bardia has quit IRC | 03:03 | |
| *** laughterwym has quit IRC | 03:06 | |
| *** gcb has joined #openstack-cinder | 03:07 | |
| *** cknight has joined #openstack-cinder | 03:14 | |
| *** gcb has quit IRC | 03:18 | |
| *** links has joined #openstack-cinder | 03:26 | |
| *** wN has quit IRC | 03:40 | |
| *** alonma has joined #openstack-cinder | 03:40 | |
| *** links has quit IRC | 03:40 | |
| *** gcb has joined #openstack-cinder | 03:42 | |
| *** wN has joined #openstack-cinder | 03:44 | |
| *** wN has joined #openstack-cinder | 03:44 | |
| *** alonma has quit IRC | 03:45 | |
| *** bill_az has quit IRC | 03:46 | |
| *** Guest3765 has quit IRC | 03:46 | |
| *** alonma has joined #openstack-cinder | 03:47 | |
| *** links has joined #openstack-cinder | 03:48 | |
| *** alonma has quit IRC | 03:51 | |
| *** alonma has joined #openstack-cinder | 03:54 | |
| *** alonma has quit IRC | 03:59 | |
| *** cknight has quit IRC | 03:59 | |
| *** 77CAAARUP has quit IRC | 04:01 | |
| *** daneyon has quit IRC | 04:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 04:01 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/269316 | 04:02 |
| *** links has quit IRC | 04:04 | |
| *** bardia has joined #openstack-cinder | 04:04 | |
| *** huanan_L has quit IRC | 04:05 | |
| *** laughterwym has joined #openstack-cinder | 04:06 | |
| *** dims__ has quit IRC | 04:08 | |
| *** vgridnev has joined #openstack-cinder | 04:08 | |
| *** bardia has quit IRC | 04:08 | |
| *** laughter_ has quit IRC | 04:10 | |
| *** shyama has joined #openstack-cinder | 04:13 | |
| *** akshai has joined #openstack-cinder | 04:13 | |
| *** links has joined #openstack-cinder | 04:16 | |
| *** laughterwym has quit IRC | 04:16 | |
| *** laughterwym has joined #openstack-cinder | 04:17 | |
| *** laughterwym has quit IRC | 04:18 | |
| *** gouthamr has joined #openstack-cinder | 04:18 | |
| *** laughterwym has joined #openstack-cinder | 04:18 | |
| *** akshai has quit IRC | 04:18 | |
| *** laughterwym has quit IRC | 04:18 | |
| *** gouthamr_ has joined #openstack-cinder | 04:19 | |
| *** coolsvap|away has joined #openstack-cinder | 04:21 | |
| *** coolsvap|away is now known as coolsvap | 04:22 | |
| *** gouthamr has quit IRC | 04:22 | |
| *** links has quit IRC | 04:27 | |
| *** links has joined #openstack-cinder | 04:28 | |
| *** bardia has joined #openstack-cinder | 04:39 | |
| *** links has quit IRC | 04:50 | |
| *** alonma has joined #openstack-cinder | 04:55 | |
| *** links has joined #openstack-cinder | 04:57 | |
| *** alonma has quit IRC | 04:59 | |
| *** haomaiwa_ has quit IRC | 05:01 | |
| *** hunters1094 has quit IRC | 05:01 | |
| *** esker has joined #openstack-cinder | 05:01 | |
| *** haomaiwang has joined #openstack-cinder | 05:01 | |
| *** alonma has joined #openstack-cinder | 05:02 | |
| *** alonma has quit IRC | 05:07 | |
| *** alonma has joined #openstack-cinder | 05:10 | |
| *** links has quit IRC | 05:13 | |
| *** haomaiwang has quit IRC | 05:13 | |
| *** akshai has joined #openstack-cinder | 05:14 | |
| *** alonma has quit IRC | 05:14 | |
| *** akshai has quit IRC | 05:19 | |
| *** links has joined #openstack-cinder | 05:21 | |
| *** sgotliv has joined #openstack-cinder | 05:23 | |
| *** vgridnev has quit IRC | 05:24 | |
| *** zhangjn has joined #openstack-cinder | 05:27 | |
| *** zhangjn has quit IRC | 05:28 | |
| *** chhavi has joined #openstack-cinder | 05:31 | |
| *** esker has quit IRC | 05:32 | |
| *** winston-d_ has joined #openstack-cinder | 05:34 | |
| *** alonma has joined #openstack-cinder | 05:35 | |
| *** links has quit IRC | 05:36 | |
| openstackgerrit | Peter Wang proposed openstack/cinder: Enhance migration start verification https://review.openstack.org/271143 | 05:37 |
| *** links has joined #openstack-cinder | 05:37 | |
| *** gouthamr_ has quit IRC | 05:40 | |
| *** markvoelker has joined #openstack-cinder | 05:44 | |
| *** vgridnev has joined #openstack-cinder | 05:47 | |
| openstackgerrit | Merged openstack/cinder: Check min config requirements for rbd driver https://review.openstack.org/258910 | 05:47 |
| *** alonma has quit IRC | 05:56 | |
| *** alonma has joined #openstack-cinder | 05:57 | |
| *** links has quit IRC | 05:59 | |
| *** links has joined #openstack-cinder | 06:01 | |
| *** alonma has quit IRC | 06:01 | |
| *** markvoelker_ has joined #openstack-cinder | 06:04 | |
| *** alonma has joined #openstack-cinder | 06:05 | |
| *** markvoelker has quit IRC | 06:07 | |
| *** alonma has quit IRC | 06:10 | |
| *** alonma has joined #openstack-cinder | 06:11 | |
| *** bardia has quit IRC | 06:14 | |
| *** akshai has joined #openstack-cinder | 06:15 | |
| *** alonma has quit IRC | 06:16 | |
| *** erez has joined #openstack-cinder | 06:16 | |
| *** akshai has quit IRC | 06:20 | |
| *** links has quit IRC | 06:22 | |
| *** alonma has joined #openstack-cinder | 06:22 | |
| *** links has joined #openstack-cinder | 06:23 | |
| *** erez has quit IRC | 06:25 | |
| *** ChubYann has quit IRC | 06:26 | |
| *** coolsvap is now known as coolsvap|away | 06:26 | |
| *** alonma has quit IRC | 06:27 | |
| *** alonma has joined #openstack-cinder | 06:29 | |
| *** alonma has quit IRC | 06:33 | |
| *** vgridnev has quit IRC | 06:33 | |
| *** bardia has joined #openstack-cinder | 06:33 | |
| *** hunters1094 has joined #openstack-cinder | 06:33 | |
| *** alonma has joined #openstack-cinder | 06:36 | |
| chhavi | ildikov:Please review this and provide comments if any v | 06:38 |
| chhavi | https://review.openstack.org/#/c/255595 | 06:38 |
| *** akerr__ is now known as akerr_away | 06:38 | |
| *** nkrinner has joined #openstack-cinder | 06:38 | |
| chhavi | this is with respect to the issue faced during shared volume | 06:38 |
| *** alonma has quit IRC | 06:40 | |
| *** salv-orlando has joined #openstack-cinder | 06:44 | |
| *** links has quit IRC | 06:46 | |
| openstackgerrit | Chhavi Agarwal proposed openstack/cinder: Don't call remove_export with attachments left https://review.openstack.org/255595 | 06:49 |
| *** links has joined #openstack-cinder | 06:50 | |
| *** bardia has quit IRC | 06:51 | |
| *** vgridnev has joined #openstack-cinder | 06:54 | |
| *** anshul has joined #openstack-cinder | 06:58 | |
| *** links has quit IRC | 07:09 | |
| *** links has joined #openstack-cinder | 07:09 | |
| *** salv-orlando has quit IRC | 07:09 | |
| *** lpetrut has joined #openstack-cinder | 07:16 | |
| *** akshai has joined #openstack-cinder | 07:16 | |
| *** akshai has quit IRC | 07:21 | |
| *** EinstCrazy has quit IRC | 07:21 | |
| openstackgerrit | yifan403 proposed openstack/cinder: Add ZTE Block Storage Driver https://review.openstack.org/258880 | 07:22 |
| *** links has quit IRC | 07:31 | |
| *** rcernin has joined #openstack-cinder | 07:31 | |
| *** belmoreira has joined #openstack-cinder | 07:34 | |
| *** alonma has joined #openstack-cinder | 07:36 | |
| *** sombrafam has quit IRC | 07:39 | |
| *** sombrafam has joined #openstack-cinder | 07:40 | |
| *** alonma has quit IRC | 07:41 | |
| *** houming has joined #openstack-cinder | 07:42 | |
| *** ociuhandu has joined #openstack-cinder | 07:43 | |
| *** tpatzig has joined #openstack-cinder | 07:43 | |
| *** links has joined #openstack-cinder | 07:48 | |
| *** sombrafam has quit IRC | 07:48 | |
| *** sombrafam has joined #openstack-cinder | 07:48 | |
| openstackgerrit | XinXiaohui proposed openstack/cinder: Calculate virtual free capacity and notify https://review.openstack.org/206923 | 07:50 |
| *** links has quit IRC | 07:54 | |
| *** lpetrut has quit IRC | 07:55 | |
| *** markus_z has joined #openstack-cinder | 08:04 | |
| *** alonma has joined #openstack-cinder | 08:06 | |
| *** alonma has quit IRC | 08:10 | |
| *** alonma has joined #openstack-cinder | 08:12 | |
| *** boris-42 has quit IRC | 08:13 | |
| *** alonma has quit IRC | 08:16 | |
| *** akshai has joined #openstack-cinder | 08:17 | |
| *** andymaier has joined #openstack-cinder | 08:19 | |
| *** vgridnev has quit IRC | 08:20 | |
| *** akshai has quit IRC | 08:22 | |
| *** links has joined #openstack-cinder | 08:22 | |
| *** laughterwym has joined #openstack-cinder | 08:23 | |
| *** davechen has joined #openstack-cinder | 08:26 | |
| *** laughterwym has quit IRC | 08:27 | |
| *** alonma has joined #openstack-cinder | 08:28 | |
| *** alonma has quit IRC | 08:32 | |
| *** alonma has joined #openstack-cinder | 08:35 | |
| *** links has quit IRC | 08:35 | |
| *** markvoelker_ has quit IRC | 08:38 | |
| *** alonma has quit IRC | 08:39 | |
| *** alonma has joined #openstack-cinder | 08:41 | |
| *** hunters1094 has quit IRC | 08:43 | |
| *** baojg has joined #openstack-cinder | 08:44 | |
| *** laughterwym has joined #openstack-cinder | 08:45 | |
| *** alonma has quit IRC | 08:45 | |
| *** alonma has joined #openstack-cinder | 08:47 | |
| *** suresh has joined #openstack-cinder | 08:48 | |
| suresh | hii I want scaleio driver for openstack kilo version please someone help | 08:51 |
| *** alonma has quit IRC | 08:51 | |
| *** alonma has joined #openstack-cinder | 08:53 | |
| *** alonma has quit IRC | 08:57 | |
| *** gcb has quit IRC | 08:59 | |
| *** alonma has joined #openstack-cinder | 09:00 | |
| *** ndipanov has joined #openstack-cinder | 09:00 | |
| *** jordanP has joined #openstack-cinder | 09:04 | |
| *** alonma has quit IRC | 09:05 | |
| *** yhayashi has quit IRC | 09:05 | |
| *** sahu has joined #openstack-cinder | 09:07 | |
| *** alonma has joined #openstack-cinder | 09:07 | |
| sahu | Hi all... How can I get scaleio driver of openstack kilo version on ubuntu, Please someone help... | 09:08 |
| dulek | suresh, sahu: ScaleIO driver got merged in Liberty, so there's no Kilo version I'm aware of. You can try to backport it on your own. | 09:11 |
| dulek | suresh, sahu: https://wiki.openstack.org/wiki/CinderSupportMatrix | 09:11 |
| *** alonma has quit IRC | 09:12 | |
| suresh | dulek: Please tell me how to backport | 09:12 |
| *** gcb has joined #openstack-cinder | 09:13 | |
| *** alonma has joined #openstack-cinder | 09:14 | |
| *** jistr has joined #openstack-cinder | 09:15 | |
| dulek | suresh: You take the driver patch and apply it to the stable/kilo. git blame to find out the patch. Same goes for Nova connector. But that's probably not a trivial task, so if you don't have someone experienced in Cinder you may have a hard time doing that. | 09:16 |
| *** akshai has joined #openstack-cinder | 09:18 | |
| *** laughterwym has quit IRC | 09:18 | |
| *** alonma has quit IRC | 09:19 | |
| suresh | dulek: please explian elobrately about this issue | 09:23 |
| *** akshai has quit IRC | 09:23 | |
| *** chhavi has quit IRC | 09:23 | |
| *** alonma has joined #openstack-cinder | 09:23 | |
| openstackgerrit | Liucheng Jiang proposed openstack/cinder: Correct capabilities match method '<is>' https://review.openstack.org/271197 | 09:24 |
| *** e0ne has joined #openstack-cinder | 09:24 | |
| *** vgridnev has joined #openstack-cinder | 09:25 | |
| dulek | suresh: You need to identify the patch that added the driver to Liberty release. Then you need to try to apply it to stable/kilo git branch and work out any merge conflict that will arise. | 09:25 |
| dulek | suresh: Same goes for Nova patch adding scaleio connector. | 09:26 |
| *** e0ne has quit IRC | 09:27 | |
| dulek | suresh: Sorry, but if I need to get into deeper details I would be elaborating on how to use git. | 09:27 |
| *** alonma has quit IRC | 09:27 | |
| suresh | dulek: Thank you | 09:28 |
| dulek | suresh: But had you tried to google "scaleio openstack kilo"? | 09:28 |
| dulek | suresh: Seems like EMC provided patches in their git repo. | 09:29 |
| dulek | suresh: https://community.emc.com/community/connect/everything-openstack/blog/2015/10/23/scaleio-and-openstack | 09:29 |
| dulek | suresh: I guess for more details you need to contact EMC. | 09:29 |
| *** alonma has joined #openstack-cinder | 09:29 | |
| suresh | dulek: I googled it but i didn't find patch for scaleio driver kilo version | 09:30 |
| *** Julien-zte has quit IRC | 09:30 | |
| dulek | suresh: Sure, the site doesn't seem to provide a link. I guess your best shot is contact someone from EMC. xyang is normally in this channel around 18:00 UTC (she's in one of US timezones). | 09:32 |
| *** boris-42 has joined #openstack-cinder | 09:33 | |
| *** markvoelker has joined #openstack-cinder | 09:34 | |
| *** alonma has quit IRC | 09:34 | |
| *** chhavi has joined #openstack-cinder | 09:35 | |
| *** markvoelker has quit IRC | 09:39 | |
| *** markvoelker has joined #openstack-cinder | 09:39 | |
| *** smoriya_ has quit IRC | 09:40 | |
| suresh | dulek: Thank you for your answers and your patience....!!!!!!! | 09:43 |
| *** tpsilva has joined #openstack-cinder | 09:44 | |
| *** markvoelker has quit IRC | 09:44 | |
| *** markvoelker has joined #openstack-cinder | 09:45 | |
| *** markvoelker has quit IRC | 09:50 | |
| *** baojg has quit IRC | 09:52 | |
| *** baojg has joined #openstack-cinder | 09:54 | |
| *** Fdaisuke has quit IRC | 09:58 | |
| *** hyakuhei_ has joined #openstack-cinder | 09:58 | |
| *** haomaiwang has joined #openstack-cinder | 09:59 | |
| *** haomaiwang has quit IRC | 10:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 10:01 | |
| *** cheneydc has quit IRC | 10:01 | |
| *** zhonghua-lee has quit IRC | 10:02 | |
| openstackgerrit | Szymon Borkowski proposed openstack/cinder: Update create_snapshot to use volume object https://review.openstack.org/260618 | 10:03 |
| *** Julien-zte has joined #openstack-cinder | 10:16 | |
| *** akshai has joined #openstack-cinder | 10:18 | |
| *** akshai has quit IRC | 10:23 | |
| *** aix has joined #openstack-cinder | 10:23 | |
| *** alonma has joined #openstack-cinder | 10:30 | |
| *** haomaiwa_ has quit IRC | 10:32 | |
| *** esker has joined #openstack-cinder | 10:33 | |
| *** sombrafam has quit IRC | 10:34 | |
| *** alonma has quit IRC | 10:35 | |
| *** sombrafam has joined #openstack-cinder | 10:35 | |
| *** markvoelker has joined #openstack-cinder | 10:35 | |
| *** sgotliv has quit IRC | 10:37 | |
| *** alonma has joined #openstack-cinder | 10:37 | |
| *** lpetrut has joined #openstack-cinder | 10:38 | |
| *** esker has quit IRC | 10:38 | |
| *** markvoelker has quit IRC | 10:39 | |
| *** lpetrut has quit IRC | 10:40 | |
| *** e0ne has joined #openstack-cinder | 10:40 | |
| *** lpetrut has joined #openstack-cinder | 10:40 | |
| openstackgerrit | Merged openstack/cinder: NexentaStor 5 NFS backend driver. https://review.openstack.org/190273 | 10:40 |
| *** sombrafam has quit IRC | 10:40 | |
| *** winston-d_ has quit IRC | 10:42 | |
| *** alonma has quit IRC | 10:42 | |
| *** sombrafam has joined #openstack-cinder | 10:42 | |
| *** hyakuhei_ has quit IRC | 10:44 | |
| *** vgridnev has quit IRC | 10:44 | |
| *** vgridnev has joined #openstack-cinder | 10:48 | |
| *** baojg has quit IRC | 10:58 | |
| *** dims has joined #openstack-cinder | 11:00 | |
| dulek | geguileo: Hi, I was looking through create volume and manage existing stuff to identify API race conditions. | 11:07 |
| dulek | geguileo: Aaaand… I wasn't able to find one. Looks like the volume is created more or less unconditionally. | 11:07 |
| dulek | geguileo: At least besides quotas it's created unconditionally to the DB state. | 11:08 |
| geguileo | dulek: I'm on a meeting | 11:08 |
| geguileo | dulek: I'll ping you in 10-20 mins | 11:08 |
| dulek | geguileo: Great! | 11:08 |
| openstackgerrit | Szymon Borkowski proposed openstack/cinder: Update restore_backup to use volume object https://review.openstack.org/262024 | 11:12 |
| *** markvoelker has joined #openstack-cinder | 11:12 | |
| *** markvoelker has quit IRC | 11:18 | |
| openstackgerrit | Merged openstack/cinder: Replace assertEqual(*, None) with assertIsNone in tests https://review.openstack.org/263997 | 11:19 |
| openstackgerrit | Merged openstack/cinder: EMC VMAX - Incorrect SG selected on an VMAX3 attach https://review.openstack.org/250443 | 11:19 |
| *** sombrafam has quit IRC | 11:21 | |
| *** sborkows has joined #openstack-cinder | 11:21 | |
| *** aix has quit IRC | 11:23 | |
| *** ociuhandu has quit IRC | 11:25 | |
| *** fthiagogv has joined #openstack-cinder | 11:26 | |
| openstackgerrit | Tom Barron proposed openstack/cinder: Fix xtremio slow unit tests https://review.openstack.org/271036 | 11:30 |
| openstackgerrit | Tom Barron proposed openstack/cinder: Fix torpid coordinator unit tests https://review.openstack.org/270967 | 11:33 |
| *** sombrafam has joined #openstack-cinder | 11:35 | |
| *** houming has quit IRC | 11:36 | |
| *** ndipanov has quit IRC | 11:36 | |
| openstackgerrit | Tom Barron proposed openstack/cinder: Fix sluggish rbd unit tests https://review.openstack.org/270925 | 11:36 |
| *** aix has joined #openstack-cinder | 11:37 | |
| *** alonma has joined #openstack-cinder | 11:37 | |
| *** alonma has quit IRC | 11:42 | |
| *** andymaier has quit IRC | 11:43 | |
| *** alonma has joined #openstack-cinder | 11:44 | |
| openstackgerrit | Tom Barron proposed openstack/cinder: Fix laggard cisco FC zone client unit tests https://review.openstack.org/270589 | 11:46 |
| *** openstackgerrit has quit IRC | 11:47 | |
| *** timcl has joined #openstack-cinder | 11:48 | |
| *** openstackgerrit has joined #openstack-cinder | 11:48 | |
| *** alonma has quit IRC | 11:49 | |
| *** lprice has joined #openstack-cinder | 11:51 | |
| *** lprice1 has quit IRC | 11:51 | |
| *** timcl1 has joined #openstack-cinder | 11:52 | |
| *** alonma has joined #openstack-cinder | 11:52 | |
| *** timcl has quit IRC | 11:52 | |
| *** boris-42 has quit IRC | 11:53 | |
| *** haomaiwang has joined #openstack-cinder | 11:54 | |
| *** alonma has quit IRC | 11:57 | |
| *** wanghao has quit IRC | 11:57 | |
| *** haomaiwang has quit IRC | 11:58 | |
| geguileo | dulek: I'm back | 11:59 |
| *** alonma has joined #openstack-cinder | 11:59 | |
| *** ociuhandu has joined #openstack-cinder | 12:02 | |
| *** alonma has quit IRC | 12:04 | |
| dulek | geguileo: So I was looking through how create volume and manage existing works with sborkows. We weren't able to find any place where conditional update is needed. | 12:06 |
| dulek | geguileo: What are we missing? ;> | 12:06 |
| geguileo | dulek: Maybe nothing | 12:06 |
| geguileo | dulek: Because when the creation fails the DB entry is still created and then changed to Error, right? | 12:07 |
| *** alonma has joined #openstack-cinder | 12:07 | |
| dulek | geguileo: Yup, entry is in "creating" state until the c-vol succeeds. | 12:07 |
| *** markvoelker has joined #openstack-cinder | 12:07 | |
| geguileo | dulek: And changed to error if it fails, right? | 12:08 |
| dulek | geguileo: That's right. | 12:08 |
| geguileo | dulek: Maybe in the API it could make the conditional update | 12:08 |
| geguileo | So it isn't created if the source is not available | 12:08 |
| geguileo | And just returns the error | 12:08 |
| geguileo | So first you acquire the lock | 12:09 |
| geguileo | Oh, no, the lock is acquired in c-vol | 12:09 |
| dulek | geguileo: That's right! ;) | 12:09 |
| geguileo | dulek: So the problem is basically that we don't have any way of locking the source in the API | 12:09 |
| dulek | geguileo: We're not changing state of source resources. | 12:10 |
| dulek | So create is just inserting a resource into the DB in "creating" state. | 12:10 |
| geguileo | And it can be removed/changed when we start working on it in c-vol | 12:10 |
| *** andymaier has joined #openstack-cinder | 12:10 | |
| geguileo | But I think we were checking in the API and the c-vol that the source exists | 12:10 |
| dulek | geguileo: Ah, yeah, this is true. | 12:10 |
| *** erlon has joined #openstack-cinder | 12:10 | |
| *** JoseMello has joined #openstack-cinder | 12:11 | |
| geguileo | But there's no possibility of conditional inserts (not supported by all DBs) | 12:11 |
| *** alonma has quit IRC | 12:11 | |
| geguileo | So we would need to use a transaction for the checks and the insertion | 12:11 |
| geguileo | That's how I would do it | 12:11 |
| geguileo | if it isn't being done like that already | 12:11 |
| dulek | geguileo: It isn't. A possible race condition is for example - create a volume from a volume type, volume type get's removed before we add entry to the DB. | 12:12 |
| dulek | s/get's/gets | 12:12 |
| *** markvoelker has quit IRC | 12:12 | |
| geguileo | dulek: It won't if you set the right transaction isolation | 12:13 |
| dulek | geguileo: Yeah, same with sources. | 12:13 |
| geguileo | level | 12:13 |
| dulek | geguileo: Yes, yes. | 12:13 |
| dulek | geguileo: But right now we fetch vol_type in api.v2.volumes | 12:13 |
| dulek | But create the volume waaaay after inside create_volume flow. | 12:13 |
| geguileo | That's not a problem | 12:13 |
| geguileo | You just need to check that the type still exists when you are doing the create flow | 12:14 |
| geguileo | With a check query in the conditional update | 12:14 |
| geguileo | Sorry, it's insert | 12:14 |
| *** alonma has joined #openstack-cinder | 12:14 | |
| geguileo | So doing a transaction that checks it again | 12:14 |
| dulek | geguileo: That would work. But should we remove the checks from api.v2.volumes then? | 12:15 |
| geguileo | Or just move it to the flow | 12:15 |
| geguileo | Yes, I think that would be the best thing to do | 12:15 |
| geguileo | Or use a transaction in the api.v2.volumes | 12:15 |
| geguileo | And store it in the context | 12:15 |
| geguileo | And then use it in the flow with subtransaction=True | 12:15 |
| geguileo | But I wouldn't do that | 12:16 |
| dulek | geguileo: Yeah, this would also work, but I would prefer to move checks. | 12:16 |
| geguileo | Because the transaction would be longer than needed | 12:16 |
| geguileo | dulek: I agree, it's better to move the check | 12:16 |
| dulek | geguileo: Okay, we'll look into that | 12:18 |
| geguileo | dulek: Thanks! | 12:18 |
| dulek | geguileo: Is this blocking c-vol A/A actually? I think we can go forward with that in parallel. | 12:18 |
| geguileo | dulek: No, it's not blocking it | 12:19 |
| *** alonma has quit IRC | 12:19 | |
| geguileo | I'm currently working on the job distribution patches | 12:19 |
| *** hyakuhei_ has joined #openstack-cinder | 12:19 | |
| dulek | Hurray! :) | 12:19 |
| geguileo | dulek: And I've decided not to rename host to cluster, like you suggested ;-) | 12:19 |
| dulek | Do you plan to join the mid-cycle hangout and talk a little on the status? | 12:19 |
| *** akshai has joined #openstack-cinder | 12:20 | |
| geguileo | dulek: I have updated the specs, just need to push them for review | 12:20 |
| dulek | geguileo: So what's the new name for host-member. | 12:20 |
| dulek | ? | 12:20 |
| geguileo | node | 12:20 |
| geguileo | XD XD | 12:20 |
| dulek | So host consists of several nodes. We'll need to document it to be clear, but I think it's fine. | 12:21 |
| geguileo | I added a little more detail to the host configuration option to explain it, but indeed this needs proper documentation | 12:22 |
| dulek | (like everything :D) | 12:22 |
| dulek | So about the mid-cycle? | 12:22 |
| geguileo | I'll try to join to as much meetings as I can | 12:22 |
| geguileo | A good time for me to give the status report would be Mon-Wed | 12:23 |
| dulek | We can try to schedule something on A/A on Tuesday's or Wednesday's morning. | 12:23 |
| dulek | That would be ~15 your time. | 12:24 |
| dulek | 3 PM I mean. ;) | 12:24 |
| *** akshai has quit IRC | 12:24 | |
| dulek | Okay, at Wednesday morning were talking with Nova's meetup, so maybe Tuesday just after the start of the meetup? | 12:25 |
| * dulek going to grab lunch, I'll be there in an hour or so | 12:27 | |
| geguileo | dulek: Sounds good to me | 12:27 |
| geguileo | dulek: Enjoy lunch | 12:27 |
| *** openstackgerrit has quit IRC | 12:33 | |
| *** openstackgerrit has joined #openstack-cinder | 12:34 | |
| *** [1]Thelo has joined #openstack-cinder | 12:34 | |
| *** Thelo has quit IRC | 12:36 | |
| *** [1]Thelo is now known as Thelo | 12:36 | |
| *** ildikov has quit IRC | 12:37 | |
| *** jordanP has quit IRC | 12:40 | |
| *** markvoelker has joined #openstack-cinder | 12:42 | |
| chhavi | hemna,johnthetubaguy: Please review: https://review.openstack.org/#/c/255595/ | 12:43 |
| *** ildikov has joined #openstack-cinder | 12:49 | |
| *** markvoelker has quit IRC | 12:54 | |
| *** haomaiwang has joined #openstack-cinder | 12:55 | |
| *** bill_az has joined #openstack-cinder | 12:59 | |
| *** haomaiwang has quit IRC | 13:00 | |
| *** dims is now known as dimsum__ | 13:00 | |
| *** vgridnev has quit IRC | 13:01 | |
| *** julim has joined #openstack-cinder | 13:08 | |
| *** suresh has quit IRC | 13:12 | |
| *** timcl1 has quit IRC | 13:12 | |
| *** esker has joined #openstack-cinder | 13:15 | |
| *** alonma has joined #openstack-cinder | 13:15 | |
| *** sahu has quit IRC | 13:16 | |
| *** vgridnev has joined #openstack-cinder | 13:16 | |
| *** e0ne has quit IRC | 13:16 | |
| *** hyakuhei_ has quit IRC | 13:16 | |
| *** e0ne has joined #openstack-cinder | 13:17 | |
| *** vgridnev has quit IRC | 13:19 | |
| *** alonma has quit IRC | 13:20 | |
| *** edmondsw has joined #openstack-cinder | 13:20 | |
| *** esker has quit IRC | 13:20 | |
| *** laughterwym has joined #openstack-cinder | 13:21 | |
| openstackgerrit | Merged openstack/cinder: Return BadRequest for invalid Unicode names https://review.openstack.org/266036 | 13:23 |
| *** vgridnev has joined #openstack-cinder | 13:23 | |
| *** timcl has joined #openstack-cinder | 13:32 | |
| *** diogogmt has quit IRC | 13:35 | |
| *** jordanP has joined #openstack-cinder | 13:35 | |
| *** diogogmt has joined #openstack-cinder | 13:36 | |
| *** akerr_away is now known as akerr__ | 13:37 | |
| *** markvoelker has joined #openstack-cinder | 13:38 | |
| *** akerr__ is now known as akerr | 13:39 | |
| *** markvoelker has quit IRC | 13:43 | |
| *** ildikov has quit IRC | 13:44 | |
| *** diogogmt has quit IRC | 13:47 | |
| *** rlrossit has joined #openstack-cinder | 13:52 | |
| *** rlrossit_ has joined #openstack-cinder | 13:56 | |
| *** esker has joined #openstack-cinder | 13:56 | |
| *** diablo_rojo has joined #openstack-cinder | 13:57 | |
| *** sombrafam has quit IRC | 13:58 | |
| *** markvoelker has joined #openstack-cinder | 13:59 | |
| *** rlrossit has quit IRC | 13:59 | |
| *** belmoreira has quit IRC | 14:00 | |
| *** winston-d_ has joined #openstack-cinder | 14:01 | |
| *** markvoelker_ has joined #openstack-cinder | 14:01 | |
| *** anshul has quit IRC | 14:01 | |
| *** nkrinner has quit IRC | 14:01 | |
| *** crose has joined #openstack-cinder | 14:02 | |
| *** esker has quit IRC | 14:03 | |
| *** markvoelker has quit IRC | 14:04 | |
| *** esker has joined #openstack-cinder | 14:06 | |
| *** dslev_ has joined #openstack-cinder | 14:06 | |
| *** hyakuhei_ has joined #openstack-cinder | 14:12 | |
| *** haomaiwang has joined #openstack-cinder | 14:14 | |
| *** alonma has joined #openstack-cinder | 14:15 | |
| *** porrua has joined #openstack-cinder | 14:17 | |
| *** haomaiwang has quit IRC | 14:18 | |
| *** alonma has quit IRC | 14:20 | |
| *** akshai has joined #openstack-cinder | 14:21 | |
| *** Julien-zte has quit IRC | 14:22 | |
| *** mriedem has joined #openstack-cinder | 14:22 | |
| *** porrua has quit IRC | 14:22 | |
| *** shyama_ has joined #openstack-cinder | 14:23 | |
| *** gouthamr has joined #openstack-cinder | 14:24 | |
| *** shyama has quit IRC | 14:24 | |
| *** shyama_ is now known as shyama | 14:24 | |
| *** gouthamr_ has joined #openstack-cinder | 14:25 | |
| *** porrua has joined #openstack-cinder | 14:25 | |
| *** kaisers1 has quit IRC | 14:27 | |
| *** kaisers has joined #openstack-cinder | 14:27 | |
| *** gouthamr has quit IRC | 14:28 | |
| *** esker has quit IRC | 14:31 | |
| *** akshai has quit IRC | 14:31 | |
| *** cknight has joined #openstack-cinder | 14:33 | |
| *** jgregor has joined #openstack-cinder | 14:34 | |
| *** haomaiwang has joined #openstack-cinder | 14:35 | |
| *** xyang1 has joined #openstack-cinder | 14:35 | |
| *** dustins has joined #openstack-cinder | 14:35 | |
| *** lcurtis has joined #openstack-cinder | 14:38 | |
| *** dslev_ has quit IRC | 14:39 | |
| *** haomaiwang has quit IRC | 14:39 | |
| *** jungleboyj has joined #openstack-cinder | 14:39 | |
| *** xyang has joined #openstack-cinder | 14:41 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Duplicate code in volume manager and base driver https://review.openstack.org/271331 | 14:43 |
| openstackgerrit | xiaoqin proposed openstack/cinder: Clone volume between different volume size https://review.openstack.org/266743 | 14:44 |
| *** gcb has quit IRC | 14:45 | |
| *** gcb has joined #openstack-cinder | 14:46 | |
| *** davechen has left #openstack-cinder | 14:46 | |
| *** ildikov has joined #openstack-cinder | 14:47 | |
| *** rlrossit_ has quit IRC | 14:52 | |
| *** dslev_ has joined #openstack-cinder | 14:52 | |
| *** obutenko has quit IRC | 14:55 | |
| *** haomaiwang has joined #openstack-cinder | 14:56 | |
| *** markvoelker has joined #openstack-cinder | 14:57 | |
| bswartz | smcginnis: ping | 14:57 |
| smcginnis | bswartz: Morning! | 14:57 |
| bswartz | good morning! | 14:57 |
| *** erhudy has joined #openstack-cinder | 14:57 | |
| bswartz | I wanted to make sure you knew that the projectors in the netapp conference rooms only take VGA inputs | 14:58 |
| bswartz | so people who plan to present on their notebooks next week need to make sure they have VGA outputs | 14:58 |
| smcginnis | bswartz: Ah, thanks for the heads up! | 14:58 |
| smcginnis | I have adapters so I should be good. | 14:58 |
| smcginnis | Hopefully we have enough for whoever needs to presetn. | 14:59 |
| smcginnis | bswartz: Thanks for the warning. | 14:59 |
| bswartz | I know there was a conversation about the wireless too | 14:59 |
| bswartz | some outgoing ports, including IRC, are blocked | 14:59 |
| bswartz | but it's easy to route IRC through an SSH tunnel or other form of VPN | 15:00 |
| *** haomaiwang has quit IRC | 15:00 | |
| smcginnis | bswartz: Ruh roh. IRC could be a bigger issue. | 15:00 |
| akerr | bswartz: ssl port 7070 to freenode isn't blocked | 15:00 |
| smcginnis | I SSH to a host I always have up, but I know not everyone can do that. | 15:01 |
| bswartz | akerr: really? on the netapp SSID? | 15:01 |
| akerr | bswartz: yes, it's what i use | 15:01 |
| *** markvoelker_ has quit IRC | 15:01 | |
| smcginnis | Whew | 15:01 |
| bswartz | akerr: you should be using corp ssid! | 15:01 |
| akerr | bswartz: oh right, not sure about netapp ssid, but why would it have more blocked ports? | 15:02 |
| *** amoturi has joined #openstack-cinder | 15:02 | |
| bswartz | akerr: because it's open to the whole world | 15:02 |
| bswartz | corp ssid requires a password to login so they trust it more | 15:02 |
| bswartz | I'm not claiming it makes sense, but the security guys have their rules | 15:02 |
| smcginnis | ;) | 15:02 |
| *** timcl has quit IRC | 15:03 | |
| smcginnis | bswartz: How did things go with the manila midcycle? Were there issues from this? | 15:03 |
| bswartz | it would not surprise me if the netapp ssid blocked all ports related to IRC -- but you can still SSH out, VPN out, and access the web so a variety of workarounds are possible | 15:03 |
| bswartz | smcginnis: it was pretty good -- the audio in the room was fantastic compared to other midcycles | 15:04 |
| bswartz | people on the phone could actually hear us and vice versa | 15:04 |
| *** esker has joined #openstack-cinder | 15:04 | |
| bswartz | the projector situation was a little less great, because the presenter has to sit over in the corner | 15:04 |
| bswartz | and use VGA | 15:04 |
| bswartz | but it's not a big deal | 15:04 |
| akerr | tbarron: did you have issues with irc on the netapp ssid? | 15:04 |
| akerr | dustins: ^ | 15:05 |
| dustins | akerr: Yeah, I couldn't connect to freenode from that ssid | 15:06 |
| tbarron | akerr: I couldn't connect to freenode directly at whatever port I normally use. | 15:06 |
| dustins | I had to use the webclient/ssh to an internal server to use Freenode | 15:06 |
| tbarron | akerr: dustins: so I did ssh to a machine that could. | 15:06 |
| akerr | dustins: so the webclient worked? | 15:07 |
| dustins | akerr: It did for me, but I was connected to my VPN as well, so YMMV | 15:07 |
| dustins | Might want to do a quick test | 15:07 |
| tbarron | akerr: you can do http direct to freenode http service, I just don't like using a web client | 15:08 |
| akerr | dustins: well i would, but there's ice on the road | 15:08 |
| *** edtubill has joined #openstack-cinder | 15:08 | |
| *** timcl1 has joined #openstack-cinder | 15:08 | |
| tbarron | akerr: i'm pretty sure i did freenode webclient without tunneling through vpn | 15:08 |
| smcginnis | I'm sure we'll figure it out and get by. | 15:08 |
| dustins | akerr: Yeah, same reason why I'm operating from the apartment office today :D | 15:08 |
| tbarron | akerr: guest network has to allow http | 15:09 |
| smcginnis | There's always jungleboyj's cell phone. :P | 15:09 |
| tbarron | smcginnis: I think the workarounds are pretty straightforward. | 15:09 |
| akerr | smcginnis: if it comes to that we can use mine as a hotspot :) | 15:09 |
| dustins | smcginnis: I'm sure he won't mind :P | 15:09 |
| timcl1 | akerr: bswartz: port 7070 works fine even with corp SSID | 15:10 |
| jungleboyj | smcginnis: Yeah, I have 15 Gig left for the month and I roll into a new month, while there so we will be good. | 15:10 |
| *** cknight has quit IRC | 15:10 | |
| smcginnis | haha, we're golden then. :) | 15:10 |
| timcl1 | bottom line is 7070 should work for everyone without issue | 15:11 |
| smcginnis | OK, timcl1 just signed up to use his cellphone if that doesn't work. :D | 15:11 |
| timcl1 | smcginnis: sure no worries, have hotspot and unlimited data so we should be good :) | 15:12 |
| *** diogogmt has joined #openstack-cinder | 15:12 | |
| *** markvoelker has quit IRC | 15:12 | |
| bswartz | timcl1: guests can't use corp ssid -- they have to use netapp | 15:12 |
| smcginnis | timcl1: Hah, thanks. I'm sure we'll work things out. | 15:12 |
| *** rlrossit has joined #openstack-cinder | 15:13 | |
| *** cknight has joined #openstack-cinder | 15:13 | |
| timcl1 | bswartz: that is true but the ports for IRC will still work | 15:14 |
| *** alonma has joined #openstack-cinder | 15:16 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Duplicate code in volume manager and base driver https://review.openstack.org/271331 | 15:16 |
| e0ne | erlon: hi! how can I start your CI for my patch ^^? | 15:16 |
| *** haomaiwang has joined #openstack-cinder | 15:17 | |
| *** crose has quit IRC | 15:18 | |
| *** jistr has quit IRC | 15:18 | |
| *** alonma has quit IRC | 15:20 | |
| *** haomaiwang has quit IRC | 15:22 | |
| *** diablo_rojo has quit IRC | 15:30 | |
| *** mragupat has joined #openstack-cinder | 15:30 | |
| *** arch-nemesis has joined #openstack-cinder | 15:31 | |
| *** cebruns_ has quit IRC | 15:32 | |
| *** baumann has joined #openstack-cinder | 15:33 | |
| *** cebruns has joined #openstack-cinder | 15:33 | |
| *** jgregor has quit IRC | 15:34 | |
| *** kfarr has joined #openstack-cinder | 15:34 | |
| *** jgregor has joined #openstack-cinder | 15:35 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Replace locks in volume manager https://review.openstack.org/185646 | 15:35 |
| *** shyama has quit IRC | 15:37 | |
| *** haomaiwang has joined #openstack-cinder | 15:38 | |
| *** haomaiwang has quit IRC | 15:43 | |
| *** markvoelker has joined #openstack-cinder | 15:44 | |
| cfriesen | when using lvm/iscsi, if I set lvm_type=thin should that change cinder accounting at all? The reason I ask is that I have a 105GB thin pool, and cinder let me create 20 1G volumes, a 100GB volume, and a snapshot of the 100GB volume. shouldn't it have cut me off due to lack of space? | 15:47 |
| cfriesen | (this is on stable/kilo) | 15:47 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Duplicate code in volume manager and base driver https://review.openstack.org/271331 | 15:49 |
| *** laughterwym has quit IRC | 15:50 | |
| guitarzan | cfriesen: thin lets you overprovision, is that what you're asking? | 15:51 |
| *** e0ne has quit IRC | 15:52 | |
| *** e0ne has joined #openstack-cinder | 15:53 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Tests: Strengthen assertFalse assertions https://review.openstack.org/263404 | 15:54 |
| *** dslev_ has quit IRC | 15:57 | |
| *** haomaiwang has joined #openstack-cinder | 15:58 | |
| *** timcl1 has quit IRC | 15:59 | |
| *** sombrafam has joined #openstack-cinder | 15:59 | |
| *** lprice1 has joined #openstack-cinder | 15:59 | |
| *** haomaiwang has quit IRC | 16:01 | |
| *** crose has joined #openstack-cinder | 16:01 | |
| *** lprice has quit IRC | 16:02 | |
| *** thangp has joined #openstack-cinder | 16:03 | |
| *** sborkows has quit IRC | 16:04 | |
| *** timcl has joined #openstack-cinder | 16:06 | |
| *** vgridnev has quit IRC | 16:07 | |
| *** crose has quit IRC | 16:07 | |
| *** salv-orlando has joined #openstack-cinder | 16:08 | |
| openstackgerrit | Dmitry Guryanov proposed openstack/os-brick: Add vzstorage protocol for remotefs connections https://review.openstack.org/271411 | 16:08 |
| *** cknight1 has joined #openstack-cinder | 16:11 | |
| *** salv-orlando has quit IRC | 16:12 | |
| *** mragupat has quit IRC | 16:12 | |
| *** cknight has quit IRC | 16:14 | |
| *** mragupat has joined #openstack-cinder | 16:15 | |
| *** pratap has joined #openstack-cinder | 16:15 | |
| *** rcernin has quit IRC | 16:15 | |
| *** wilson-1 has joined #openstack-cinder | 16:16 | |
| *** ociuhandu has quit IRC | 16:19 | |
| *** wilson-liu has quit IRC | 16:20 | |
| *** diablo_rojo has joined #openstack-cinder | 16:20 | |
| *** alonma has joined #openstack-cinder | 16:21 | |
| *** sheel has joined #openstack-cinder | 16:21 | |
| *** pratap_ has joined #openstack-cinder | 16:25 | |
| *** alonma has quit IRC | 16:26 | |
| kmartin_ | heck, if we can run a midcycle with no wifi we can run one without IRC, google hangout? | 16:27 |
| kmartin_ | jungleboyj, ^^ :) | 16:27 |
| *** diablo_rojo has quit IRC | 16:28 | |
| *** alonma has joined #openstack-cinder | 16:28 | |
| Swanson | kmartin_, don't try to go under that bar. This isn't limbo. | 16:28 |
| jungleboyj | kmartin_: :-) We can do anything! | 16:28 |
| *** pratap has quit IRC | 16:28 | |
| *** alonma has quit IRC | 16:32 | |
| *** yuriy_n17 has quit IRC | 16:33 | |
| *** daneyon has joined #openstack-cinder | 16:38 | |
| *** simondodsley has joined #openstack-cinder | 16:39 | |
| hemna | mornin | 16:39 |
| *** arch-nemesis has quit IRC | 16:40 | |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: WIP:Support restore target configration during driver initialization https://review.openstack.org/271424 | 16:41 |
| simondodsley | Question regarding QoS. If we attach a volume that has a QoS association to a running instance, is the QoS meant to apply dynamically, or is a hard reboot of the instance required to update the libvirt.xml? Looks like it need a reboot at the moment - not optimal if that is the case. Also if we change a QoS spec will that get dynamically applied to the | 16:41 |
| simondodsley | volume, or will too need a hard reboot? | 16:41 |
| *** jdurgin1 has joined #openstack-cinder | 16:41 | |
| simondodsley | to clarify - I'm talking front-end QoS here... | 16:42 |
| *** jistr has joined #openstack-cinder | 16:43 | |
| *** arch-nemesis has joined #openstack-cinder | 16:43 | |
| *** mtanino has joined #openstack-cinder | 16:43 | |
| *** timcl has quit IRC | 16:45 | |
| hemna | https://www.united.com/CMS/en-US/travel/news/Pages/travelnotices.aspx | 16:46 |
| tbarron | simondodsley: front-end-QoS is a question for #openstack-nova, no? Though I'm also curious what the answer will be here :-) | 16:46 |
| *** salv-orlando has joined #openstack-cinder | 16:47 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Remove access_mode 'rw' setting in drivers https://review.openstack.org/265443 | 16:48 |
| kmartin_ | simondodsley, I haven't tested it but I believe it applied by the hypervisor when the volume is attached, as tbarron mention it's really a nova question | 16:49 |
| cfriesen | guitarzan: sorry, got pulled away. yeah, I was wondering about overprovisioning. I have max_over_subscription_ratio=1.0 in cinder.conf, but the cinder-volume startup logs show lvm.max_over_subscription_ratio = 20.0. I guess I need to set the ratio for the lvm backend separately? | 16:50 |
| kmartin_ | and the different hypervisors may act differently | 16:50 |
| simondodsley | ok - i'll go ask nova - i thought I would ask here first | 16:50 |
| simondodsley | i know it it only applies to KVM at the moment | 16:51 |
| *** laughterwym has joined #openstack-cinder | 16:51 | |
| simondodsley | tbarron: I'll let you know what they say | 16:53 |
| tbarron | simondodsley: ty! | 16:53 |
| *** rcernin has joined #openstack-cinder | 16:55 | |
| *** e0ne has quit IRC | 16:55 | |
| *** dslevin has joined #openstack-cinder | 16:57 | |
| *** esker has quit IRC | 16:59 | |
| cfriesen | okay, I've specified lvm.max_over_subscription_ratio = 1 and max_over_subscription_ratio = 1 and restarted cinder-volume and cinder-scheduler, but it's still letting me create cinder volumes totalling more space than the size of my thin pool. Any ideas? | 16:59 |
| *** hyakuhei_ has quit IRC | 17:00 | |
| eharney | cfriesen: can you find the debug line in the scheduler that shows the free_capacity_gb and max_over_subscription_ratio reported for that backend? | 17:02 |
| simondodsley | tbarron: Is the mid-cycle still going ahead? Should have cleared up in RTP by Monday. | 17:02 |
| cfriesen | eharney: free_capacity_gb is showing the currently free space (ie amount of unused space in the thin pool). max_over_subscription_ratio is 1. | 17:03 |
| cfriesen | eharney: the capacity filter only looks at max_over_subscription_ratio if it's > 1 | 17:04 |
| *** bardia has joined #openstack-cinder | 17:04 | |
| *** ildikov has quit IRC | 17:04 | |
| cfriesen | eharney: so as long as I ask to create a new volume that is smaller than the remaining space in the thin pool it'll let me, even though allocated_capacity_gb ends up way bigger than total_capacity_gb | 17:06 |
| kmartin_ | simondodsley, yeah it's still on...just bring your ice skates, Sunday and Monday look clear. | 17:06 |
| simondodsley | cool - let's hope LGA has recovered - assuming its as epic as they say...unlike last time when it was a complete bust :) | 17:07 |
| *** crose has joined #openstack-cinder | 17:07 | |
| tbarron | kmartin_: we should have a cinder hockey game, or kickball at least :-) | 17:08 |
| *** jistr has quit IRC | 17:08 | |
| *** laughterwym has quit IRC | 17:09 | |
| kmartin_ | yep, just make sure you have rental car insurance | 17:09 |
| *** jistr has joined #openstack-cinder | 17:09 | |
| *** jdurgin1 has quit IRC | 17:10 | |
| hemna | tbarron, I'll bring my skates | 17:11 |
| *** markus_z has quit IRC | 17:13 | |
| *** jistr has quit IRC | 17:14 | |
| cfriesen | In the capacity filter, why do we only consider max_over_subscription_ratio if it's greater than 1? Looks like that logic should work fine for less than 1 as well. | 17:14 |
| bswartz | DuncanT: ping | 17:17 |
| *** jistr has joined #openstack-cinder | 17:17 | |
| bswartz | DuncanT: do you know how much longer HP cloud will continue to donate resources to openstack-infra for zuul job nodes? | 17:17 |
| hemna | bswartz, I'm guessing not very much longer | 17:20 |
| *** timcl has joined #openstack-cinder | 17:21 | |
| *** haomaiwa_ has joined #openstack-cinder | 17:21 | |
| xyang | cfriesen: if the ratio < 1, you can't provision more than the physical capacity, so it does not really allow over subscription | 17:23 |
| cfriesen | xyang: my ratio is 1 exactly, so it fails the "host_state.max_over_subscription_ratio > 1" check in the capacity filter, and falls through to the "if free < volume_size" check | 17:24 |
| bswartz | hemna: well what will happen to the node pool? right now it seems to have a capacity of 1000 jobs | 17:24 |
| hemna | I really have no idea :( | 17:24 |
| bswartz | if that number goes down then the will go from bad to worse... | 17:24 |
| cfriesen | xyang: however "free" is the currently free value, which doesn't factor in the provisioned size | 17:25 |
| bswartz | the gate* will go from bad to worse | 17:25 |
| *** timcl has left #openstack-cinder | 17:25 | |
| *** leeantho has joined #openstack-cinder | 17:25 | |
| xyang | cfriesen: 1 means you can only provision exactly the same amount of capacity as the physical capacity. | 17:25 |
| cfriesen | xyang: yes | 17:25 |
| cfriesen | xyang: that is my intent | 17:25 |
| xyang | cfriesen: that's why it goes the other path | 17:25 |
| cfriesen | xyang: but the "free" value is reporting the actual free amount, which in the thin-provisioned case doesn't account for provisioned-but-not-yet-allocated space | 17:26 |
| *** haomaiwa_ has quit IRC | 17:26 | |
| cfriesen | xyang: so it lets you massively overcommit | 17:26 |
| *** rlrossit has quit IRC | 17:26 | |
| cfriesen | xyang: at a minimum, the check should be | 17:26 |
| cfriesen | if (host_state.thin_provisioning_support and | 17:27 |
| cfriesen | host_state.max_over_subscription_ratio > 1): | 17:27 |
| cfriesen | bah, it should be host_state.max_over_subscription_ratio >= 1 | 17:27 |
| hemna | bswartz, yup. You can thank Meg for that :( | 17:27 |
| xyang | cfriesen: isn't that not there? let me check | 17:27 |
| *** esker has joined #openstack-cinder | 17:27 | |
| eharney | cfriesen: so it's sounding like the issue is that the LVM driver reports usage differently depending on whether you are using thin or thick LVM | 17:27 |
| *** timcl1 has joined #openstack-cinder | 17:27 | |
| cfriesen | eharney: yes, but also that the filter behaves differently depending on whether the allocation ratio is greater than 1 or not | 17:28 |
| eharney | which made sense before we introduced this ratio, now, maybe not so much | 17:28 |
| tbarron | hemna: w.r.t https://review.openstack.org/271331 it looks like the driver method copy_volume_data is no longer called from anywhere but test code. | 17:29 |
| tbarron | hemna: prove us wrong :-) ^^ | 17:29 |
| xyang | cfriesen: There were feedback on >1 vs >=1 and going back and forth. I have to check exactly what we have changed. | 17:30 |
| cfriesen | eharney: xyang: I don't see any reason why we couldn't use a common capacity filter code path for "if (host_state.thin_provisioning_support)" regardless of what the over subscription ratio is. A ratio less than 1 would just be equivalent to reserving some space. | 17:30 |
| xyang | cfriesen: I can consider 1 a valid ratio, but <1 is misconfiguration | 17:31 |
| xyang | cfriesen: that's why it is not considered correct ratio | 17:31 |
| hemna | tbarron, that seems 'scary' because of those 2 drivers needing those calls to be made | 17:31 |
| hemna | not sure who approved that | 17:32 |
| tbarron | cfriesen: i'm with xyang on this one, <1 could work but lead to having to explain too much too often | 17:32 |
| cfriesen | eharney: xyang: on a slightly different note, in volume/driver.py the help text for max_over_subscription_ratio says "A ratio lower than 1.0 will be ignored and the default value will be used instead", but I don't see the default value of 20 being used. | 17:32 |
| cfriesen | tbarron: okay, fair enough | 17:32 |
| tbarron | hemna: don't disagree, but I think they are never called | 17:32 |
| tbarron | hemna: presumably they used to be | 17:32 |
| hemna | :( | 17:32 |
| hemna | that feels bad mmmkay | 17:32 |
| *** mudassirlatif has joined #openstack-cinder | 17:33 | |
| *** fthiagogv has quit IRC | 17:33 | |
| hemna | not sure the XP CI is up at the moment | 17:33 |
| hemna | it might be failing already due to this | 17:33 |
| xyang | cfriesen: automatically change something < 1 to 20 will be too dramatic | 17:33 |
| hemna | :( | 17:33 |
| xyang | cfriesen: I'll take a look of the text | 17:33 |
| cfriesen | xyang: agreed, but we should then update the help text to reflect reality | 17:33 |
| xyang | cfriesen: sure | 17:33 |
| eharney | xyang: on a related note, i have this patch up: https://review.openstack.org/#/c/266986/ | 17:34 |
| xyang | eharney: Ok, I'll take a look of that | 17:34 |
| cfriesen | eharney: I like it | 17:35 |
| eharney | i don't really like it, but it's all i could get folks to agree to :) | 17:35 |
| sheel | smcginnis: hi there | 17:37 |
| xyang | eharney: right. patch on this subject tend to get stuck with controversies:) | 17:37 |
| openstackgerrit | xiaoqin proposed openstack/cinder: Clone volume between different size for Storwize https://review.openstack.org/266743 | 17:38 |
| *** sombrafam has quit IRC | 17:39 | |
| *** andymaier has quit IRC | 17:39 | |
| *** haomaiwang has joined #openstack-cinder | 17:42 | |
| *** jordanP has quit IRC | 17:42 | |
| *** hyakuhei_ has joined #openstack-cinder | 17:42 | |
| cfriesen | xyang: looks like your commit 7595375 changed it to " > 1", but the commit message talks about allowing oversubscription if the ratio is "greater than or equal to 1", which doesn't seem to match the code. | 17:44 |
| *** esker has quit IRC | 17:44 | |
| xyang | cfriesen: I'll take a look. as I said, we went back and forth on this one | 17:46 |
| *** baumann has quit IRC | 17:46 | |
| *** asselin has quit IRC | 17:46 | |
| *** baumann has joined #openstack-cinder | 17:46 | |
| *** haomaiwang has quit IRC | 17:47 | |
| cfriesen | xyang: well, if we don't change it to >=1 then we need to change how lvm reports free space when the ratio is 1.0 | 17:49 |
| -openstackstatus- NOTICE: Restarting zuul due to a memory leak | 17:49 | |
| eharney | i'm inclined to think we need to change the LVM behavior anyway, but i need to look closer | 17:50 |
| *** mdavidson has quit IRC | 17:50 | |
| xyang | cfriesen: I changed from >=1 to >1 based on review comments on that patch. So I don't want to keep changing back and forth | 17:50 |
| erlon | e0ne: hey, I will | 17:52 |
| *** esker has joined #openstack-cinder | 17:52 | |
| eharney | xyang: i didn't review that one, so i reserve the right to have new comments :) | 17:52 |
| *** asselin has joined #openstack-cinder | 17:53 | |
| eharney | i am curious of the reasoning though | 17:53 |
| erlon | e0ne: do you know if the migration tests Vincent did are approved? | 17:53 |
| xyang | eharney: I know you didn't:) | 17:53 |
| cfriesen | eharney: https://review.openstack.org/#/c/185764/ at the bottom of the page | 17:54 |
| xyang | eharney: I actually made some adjustments to the similar logic in Manila. I'll see if I can bring some back to here | 17:54 |
| eharney | xyang: i suspect that if we fixed the LVM driver (and any other drivers doing odd things with these stats), it shouldn't matter much | 17:54 |
| xyang | eharney: I hope so:) | 17:55 |
| cfriesen | can I leave this in your hands, or did you want a bug report for tracking? | 17:55 |
| *** alonma has joined #openstack-cinder | 17:56 | |
| *** jistr has quit IRC | 17:57 | |
| xyang | cfriesen: feel free to open a bug so we can keep track of it | 17:57 |
| sheel | cfriesen: I think its better to raise bug, if not ok we can claim it invalid later on.. | 17:57 |
| *** ildikov has joined #openstack-cinder | 17:58 | |
| *** mragupat has quit IRC | 17:58 | |
| *** sombrafam has joined #openstack-cinder | 18:00 | |
| *** alonma has quit IRC | 18:00 | |
| *** mudassirlatif has quit IRC | 18:00 | |
| *** apoorvad has joined #openstack-cinder | 18:02 | |
| *** 14WAAR75L has joined #openstack-cinder | 18:03 | |
| *** leeantho has quit IRC | 18:04 | |
| *** esker has quit IRC | 18:05 | |
| cfriesen | bug opened, https://bugs.launchpad.net/cinder/+bug/1537162 | 18:06 |
| openstack | Launchpad bug 1537162 in Cinder "accounting bug for lvm with thin provisioning and max_over_subscription_ratio=1" [Undecided,New] | 18:06 |
| *** boris-42 has joined #openstack-cinder | 18:07 | |
| *** 14WAAR75L has quit IRC | 18:08 | |
| cfriesen | xyang: eharney: on a related note, it seems like I'm allowed to create a snapshot of a very large volume when there is very little actual space remaining (once accouting for the over subscription ratio). Shouldn't we only allow snapshotting if there is enough room for the snapshot? | 18:08 |
| xyang | cfriesen: creating snapshot does not go thru the scheduler | 18:09 |
| xyang | cfriesen: so that is a different issue | 18:09 |
| xyang | cfriesen: if host is known, a request such as snapshot or clone will be sent to manager directly | 18:09 |
| cfriesen | xyang: shouldn't we do a size check though? otherwise we run the risk of filling up the LVM thin pool and causing major problems | 18:10 |
| sheel | cfriesen xyang : sorry to cut into | 18:10 |
| sheel | cfriesen xyang: we can implement this kind of check in driver itself | 18:10 |
| *** hyakuhei_ has quit IRC | 18:11 | |
| xyang | cfriesen, sheel: there should be such checks. if not, it can be added | 18:11 |
| sheel | cfriesen xyang: I saw sometime ago in lvm that we are directly running snapshot create without checking size of available backend | 18:11 |
| eharney | how are you going to decide how much space you need for an LVM snapshot? | 18:11 |
| cfriesen | eharney: worst case, full size of the original volume | 18:11 |
| sheel | cfriesen xyang eharney: it used to be equivivalent to size of volume | 18:11 |
| *** Lee1092 has quit IRC | 18:12 | |
| sheel | in lvm | 18:12 |
| cfriesen | I actually don't care about overcommit at all, I'm using thin provisioning to avoid the need to zero out the cinder volumes on deletion. | 18:12 |
| eharney | sheel: not in thin lvm | 18:12 |
| eharney | cfriesen: yeah, snapshots perform much better in thin lvm, which is why we're aiming to move away from thick altogether | 18:13 |
| cfriesen | so I'd rather have an operation be rejected than risk filling up the thin pool | 18:13 |
| sheel | eharney: oks | 18:13 |
| eharney | cfriesen: in theory we have a snapshot_gb_quota, but i've never heard of anyone using it | 18:14 |
| cfriesen | I'm not worried about the quota, I just want to make sure that if someone does a snapshot and then completely rewrites the original disk with new data that we don't fill up the thin pool | 18:14 |
| eharney | cfriesen: makes sense | 18:15 |
| *** mudassirlatif has joined #openstack-cinder | 18:16 | |
| *** angela-s has joined #openstack-cinder | 18:16 | |
| sheel | cfriesen: are you raising bug for same, please share id if so.. | 18:17 |
| cfriesen | so are we looking at a check in volume.drivers.lvm.LVMVolumeDriver.create_snapshot()? | 18:17 |
| cfriesen | sheel: yeah, I'll raise a bug, one sec | 18:17 |
| *** mudassirlatif has quit IRC | 18:17 | |
| *** martyturner has joined #openstack-cinder | 18:17 | |
| *** mudassirlatif has joined #openstack-cinder | 18:18 | |
| sheel | cfriensen: I think yes...just before self.vg.create_lv_snapshot(... | 18:20 |
| cfriesen | do we check free size in general before making a snapshot? is this something that should be done for other backends too? | 18:20 |
| sheel | cfriensen: actually this kind of things are checked in scheduling tasks | 18:21 |
| sheel | in scheduler | 18:21 |
| sheel | cfriensen:either we should include scheduler in between to check gb_quota only for host where volume exists | 18:21 |
| *** alonma has joined #openstack-cinder | 18:22 | |
| sheel | this may not require checking same in backends | 18:22 |
| sheel | but if we are thinking about adding same at driver level, then yes we have to handle in all backends if not handled already | 18:22 |
| *** haomaiwang has joined #openstack-cinder | 18:24 | |
| sheel | eharney: what you think about it? | 18:25 |
| sheel | eharney: just as an expert advice.. | 18:25 |
| eharney | the check probably shouldn't be in the driver | 18:25 |
| eharney | the driver should gather enough info about space left in the VG for it to be determined by the scheduler, right? | 18:25 |
| cfriesen | bug created: https://bugs.launchpad.net/cinder/+bug/1537166 | 18:25 |
| openstack | Launchpad bug 1537166 in Cinder "snapshot of volume should check free space first" [Undecided,New] | 18:25 |
| eharney | also, does it not do that now? | 18:25 |
| *** diablo_rojo has joined #openstack-cinder | 18:26 | |
| cfriesen | couldn't we call the existing scheduler code, just on the known host and with the size of the volume being snapshotted? | 18:26 |
| *** alonma has quit IRC | 18:26 | |
| cfriesen | that'd automatically take into account the overcommit ration | 18:26 |
| eharney | the problem is, on some backends, snapshots are probably considered "free", and the scheduler isn't going to know how to calculate differently for different backends | 18:27 |
| *** porrua has quit IRC | 18:27 | |
| eharney | so i'm not sure there's a very straightforward remedy | 18:27 |
| openstackgerrit | Kedar Vidvans proposed openstack/cinder: Volume manage/unmanage support to ZFSSA drivers https://review.openstack.org/271462 | 18:27 |
| *** haomaiwang has quit IRC | 18:29 | |
| *** chhavi has quit IRC | 18:29 | |
| cfriesen | eharney: add a per-backend function to query the snapshot overcommit ratio? | 18:30 |
| cfriesen | or report it the same way as the normal overcommit ratio | 18:30 |
| eharney | i'm not sure | 18:31 |
| *** leeantho has joined #openstack-cinder | 18:31 | |
| ildikov | hemna: hi | 18:32 |
| hemna | ildikov, hey | 18:32 |
| hemna | what's up | 18:32 |
| *** crose has quit IRC | 18:33 | |
| ildikov | I'm just checking mriedem's tempest test for multiattach | 18:33 |
| ildikov | we have a detach failure | 18:34 |
| ildikov | I assume that's because of the lvm driver, but I don't really know how to confirm the real cause of the problem :) | 18:34 |
| ildikov | log: http://logs.openstack.org/33/266633/2/check/gate-tempest-dsvm-full/93b2e47/logs/screen-c-api.txt.gz#_2016-01-22_01_01_51_904 | 18:35 |
| *** jordanP has joined #openstack-cinder | 18:36 | |
| mriedem | ildikov: so i'm wondering if the problem is we're doing 2 detaches right in a row | 18:37 |
| mriedem | if ^ is the 2nd attachment, then that could be coming in while the first detach is still happening, and i'm assuming the volume status would be something like 'detaching'? | 18:38 |
| ildikov | mriedem: I think it's the lvm driver | 18:38 |
| ildikov | mriedem: it's the flow here: http://logs.openstack.org/33/266633/2/check/gate-tempest-dsvm-full/93b2e47/logs/screen-c-vol.txt.gz#_2016-01-22_01_01_49_780 | 18:38 |
| ildikov | you have the attach, then the first detach and then there's no iscsi target anymore | 18:39 |
| mriedem | b/c of the bug ndipanov was talking about? | 18:39 |
| ildikov | http://logs.openstack.org/33/266633/2/check/gate-tempest-dsvm-full/93b2e47/logs/screen-c-vol.txt.gz#_2016-01-22_01_01_59_416 | 18:39 |
| ildikov | http://logs.openstack.org/33/266633/2/check/gate-tempest-dsvm-full/93b2e47/logs/screen-c-vol.txt.gz#_2016-01-22_01_01_59_574 | 18:40 |
| ildikov | that I'm not 100% sure about | 18:40 |
| ildikov | I don;t know where os-brick and Cinder detach meet, if you know how I mean | 18:40 |
| openstackgerrit | Alex Meade proposed openstack/cinder: WIP: user notifications with zaqar https://review.openstack.org/271475 | 18:42 |
| sheel | cfriesen: there is some handling present for volume resize in volume/api.py for checking quota atleast in db | 18:43 |
| sheel | def extend(self, context, volume, new_size) raise exception.VolumeSizeExceedsAvailableQuota( | 18:43 |
| ildikov | mriedem: BTW there's also a log in Nova that there's no attachment_id: http://logs.openstack.org/33/266633/2/check/gate-tempest-dsvm-full/93b2e47/logs/screen-n-cpu.txt.gz?level=WARNING#_2016-01-22_01_01_58_917 | 18:44 |
| sheel | atleast this kind of check must be there for snapshot to confirm quota for snapshot...in case there is some snapshot gb quota available in db | 18:44 |
| *** haomaiwang has joined #openstack-cinder | 18:45 | |
| cfriesen | sheel: yes, I see the quota checking. but that doesn't really help if the user is within their quota but ends up being the straw that breaks the camel's back | 18:45 |
| *** harlowja has quit IRC | 18:46 | |
| *** jordanP has quit IRC | 18:46 | |
| *** harlowja has joined #openstack-cinder | 18:46 | |
| sheel | cfriensen: yup... :) you can't gurantee backend availability from db quota ... :) | 18:46 |
| ildikov | mriedem: what I don't know thoough is that what happens when the two detach requests are close, I mean the volume might still be in detaching state, which I guess could block detaching the second attachment | 18:46 |
| sheel | but atleast first level of check must be added to reduce this issue up to some extent... | 18:47 |
| cfriesen | sheel: it'd be nice if these "you don't have space" errors would cause the request to be rejected back to the client rather than accepting the request and creating a volume in the error state. | 18:49 |
| *** martyturner has quit IRC | 18:49 | |
| sheel | cfriesen : yes, exactly | 18:49 |
| *** haomaiwang has quit IRC | 18:49 | |
| *** sombrafam has quit IRC | 18:51 | |
| ildikov | hemna: does a detach request fail when the volume is in detaching state? | 18:51 |
| eharney | cfriesen: we need to implement async error reporting to be able to report back that kind of error | 18:52 |
| cfriesen | eharney: no, you could just do the request to the scheduler as an RPC call rather than cast | 18:52 |
| *** e0ne has joined #openstack-cinder | 18:52 | |
| *** sombrafam has joined #openstack-cinder | 18:53 | |
| hemna | back sorry | 18:53 |
| *** ChubYann has joined #openstack-cinder | 18:54 | |
| *** alonma has joined #openstack-cinder | 18:55 | |
| ildikov | hemna: np :) | 18:56 |
| hemna | ildikov, so you are talking about os-detach right ? | 18:57 |
| *** cfriesen is now known as cfriesen_away | 18:57 | |
| ildikov | hemna: I assume yes :) | 18:57 |
| ildikov | hemna: the tempest test we have is failing, which can have multiple reasons right now | 18:58 |
| *** sombrafam has quit IRC | 18:59 | |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L598 | 18:59 |
| hemna | so begin_detaching is what's raising that | 18:59 |
| hemna | not os-detach | 18:59 |
| hemna | FYI | 18:59 |
| *** sombrafam has joined #openstack-cinder | 19:00 | |
| hemna | so the volume must be 'in-use' | 19:00 |
| ildikov | a-ha, ok | 19:00 |
| hemna | and attach_status must be 'attached' | 19:00 |
| hemna | otherwise begin_detaching will bail | 19:00 |
| *** alonma has quit IRC | 19:00 | |
| ildikov | is that attach_status that goes to detaching? | 19:00 |
| *** PsionTheory has joined #openstack-cinder | 19:01 | |
| hemna | status will go to detaching | 19:01 |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L595 | 19:01 |
| sheel | cfriesen, eharney: I agree with eharney on this... but if solution is possible than "going through last stage and then reporting error", it would be better to report error to user on early hand...(but not recommended by converting cast to call) | 19:02 |
| ildikov | hemna: a-ha, ok | 19:02 |
| eharney | sheel: cfriesen: the answer for reporting the error to the user is to have the client poll for the error after the failure, not change the call to synchronous | 19:02 |
| ildikov | hemna: so in tempest even if we have the happy scenario working, if we have the two detach requests too close to each other, that will fail | 19:02 |
| hemna | yah most likely | 19:03 |
| *** alonma has joined #openstack-cinder | 19:03 | |
| ildikov | ok, cool | 19:03 |
| ildikov | then mriedem is right | 19:03 |
| sheel | eharney, cgriesen:right | 19:03 |
| hemna | that could happen even w/o multiattach | 19:03 |
| *** lpetrut has quit IRC | 19:04 | |
| ildikov | but then the error is valid as someone tries to detach the volume twice | 19:04 |
| ildikov | ... I would assume | 19:04 |
| mriedem | ildikov: so what do we have to wait for? | 19:04 |
| mriedem | in tempest i mean | 19:05 |
| hemna | ildikov, correct | 19:05 |
| hemna | it's really the same problem that exists today | 19:05 |
| ildikov | mriedem: I assume the volume status should go back to attached, when the detach request is finished | 19:05 |
| hemna | if you try and call begin_detaching when it's already detaching | 19:05 |
| *** laughterwym has joined #openstack-cinder | 19:05 | |
| hemna | don't do that | 19:05 |
| hemna | :P | 19:05 |
| mriedem | ildikov: you mean in-use? | 19:05 |
| hemna | it's a valid error | 19:05 |
| mriedem | hemna: it's == the volume? | 19:05 |
| ildikov | mriedem: bah, too many options..., yeah, I meant that | 19:05 |
| hemna | the exception the API is raising is valid | 19:06 |
| hemna | because the volume isn't 'in-use' | 19:06 |
| hemna | it's in some other state. | 19:06 |
| mriedem | so detaching is like a task_state right? | 19:06 |
| *** haomaiwang has joined #openstack-cinder | 19:06 | |
| ildikov | hemna: but in multiattach case the volume still can be in-use | 19:06 |
| hemna | like if you happen to issue begin_detaching for the same volume back to back | 19:06 |
| hemna | ildikov, in the multi-attach case | 19:06 |
| hemna | the volume will still get put into detaching | 19:06 |
| ildikov | but for multiattach it should be same attachment as opposed to same volume | 19:06 |
| hemna | until that detach is complete | 19:07 |
| hemna | then it will go back to 'in-use' if there is an attachment for that volume still outstanding. | 19:07 |
| hemna | or 'available' if that detach was the last one. | 19:07 |
| *** alonma has quit IRC | 19:07 | |
| hemna | this gates actions on the volumes basically | 19:07 |
| hemna | to 1 at a time. | 19:07 |
| ildikov | ok, makes sense, so we will need to check when it gets back to in-use | 19:08 |
| mriedem | yeah so in _detach here https://review.openstack.org/#/c/266605/4/tempest/api/compute/volumes/test_attach_volume.py | 19:08 |
| mriedem | on the first detach i'm not waiting for a state change | 19:08 |
| mriedem | only the last one | 19:08 |
| mriedem | where is the 'attach_status'? | 19:09 |
| mriedem | is that on the volume? | 19:09 |
| *** laughterwym has quit IRC | 19:10 | |
| mriedem | basically i'm not seeing anything in the rest api logs in that tempest failure that indicates a volume status change while it's detaching the first attachment | 19:10 |
| ildikov | I see only status: http://developer.openstack.org/api-ref-blockstorage-v2.html | 19:10 |
| mriedem | maybe i need to query the volume until it's (1) in-use and (2) it's number of attachments has decremented | 19:10 |
| *** haomaiwang has quit IRC | 19:11 | |
| hemna | yes attach_status is on the volume | 19:11 |
| ildikov | in Nova we set the attach_status by ourselves, it does not come from Cinder | 19:11 |
| hemna | as is status | 19:11 |
| ildikov | it's sooo confusing | 19:12 |
| hemna | attach_status is just attached or not basically | 19:12 |
| hemna | status has many states for different workflows | 19:12 |
| *** rcernin has quit IRC | 19:12 | |
| hemna | fwiw | 19:12 |
| mriedem | blarg | 19:12 |
| mriedem | nova has vm_state and task_state | 19:13 |
| hemna | you can be attached and do things to a volume that has nothing to do with attaching or detaching | 19:13 |
| *** esker has joined #openstack-cinder | 19:13 | |
| ildikov | ok, this is what I remembered | 19:13 |
| ildikov | mriedem: those are more readable | 19:13 |
| mriedem | https://github.com/openstack/cinder/blob/master/cinder/api/v2/views/volumes.py#L56 | 19:13 |
| mriedem | so yeah, i guess status is the only thing available there | 19:14 |
| mriedem | there is no 'attach_status' field in the response | 19:14 |
| mriedem | it must be on the volume in the cinder db though b/c | 19:14 |
| mriedem | https://github.com/openstack/cinder/blob/master/cinder/api/v2/views/volumes.py#L95 | 19:14 |
| mriedem | it's just not available in the API | 19:14 |
| mriedem | :( | 19:14 |
| mriedem | so tempest can't use it | 19:14 |
| ildikov | no, it's returned under the name 'status' | 19:14 |
| mriedem | but status is 'in-use' | 19:15 |
| mriedem | look here http://logs.openstack.org/33/266633/2/check/gate-tempest-dsvm-full/93b2e47//console.html | 19:15 |
| *** IlyaG has joined #openstack-cinder | 19:15 | |
| *** IlyaG has quit IRC | 19:15 | |
| mriedem | there is no volume status of 'attaching' or 'detaching' | 19:15 |
| ildikov | <hemna> yes attach_status is on the volume | 19:15 |
| ildikov | <hemna> as is status | 19:15 |
| mriedem | yeah, in the DB | 19:15 |
| mriedem | not in the API response of the volume | 19:15 |
| ameade | sheel, eharney, smcginnis: https://etherpad.openstack.org/p/mitaka-cinder-midcycle-user-notifications | 19:15 |
| mriedem | this is what the client sees https://github.com/openstack/cinder/blob/master/cinder/api/v2/views/volumes.py#L58-L79 | 19:16 |
| ameade | and i pushed up some working code that pushes said messages to the user | 19:16 |
| ameade | on a zaqar queue | 19:16 |
| ildikov | mriedem: I saw detaching somewhere | 19:16 |
| mriedem | ildikov: the db has this https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/models.py#L147 | 19:16 |
| hemna | mriedem, which API call ? | 19:16 |
| hemna | get volume ? | 19:16 |
| mriedem | yeah | 19:16 |
| hemna | wtf | 19:16 |
| ildikov | mriedem: in the logs I mean, although that might have been log and not API response though | 19:16 |
| ameade | i dont think implementation is hard for this at all, but the defining common message format across projects and the message content is key | 19:17 |
| hemna | those have to be there, or there would be much bigger problems | 19:17 |
| ameade | parallels with standard notifications | 19:17 |
| mriedem | ildikov: hemna: this is the volume response we have http://logs.openstack.org/33/266633/2/check/gate-tempest-dsvm-full/93b2e47//console.html#_2016-01-22_01_08_51_815 | 19:17 |
| e0ne | hemna: hi. I've got few questions according your comment to my patch | 19:17 |
| hemna | "status": "in-use" | 19:17 |
| *** xyang has quit IRC | 19:17 | |
| mriedem | hemna: yeah, right :) | 19:17 |
| mriedem | but | 19:17 |
| * hemna is confused | 19:18 | |
| mriedem | it's always in-use as long as you have an attachment | 19:18 |
| mriedem | but you're not allowed to make a 2nd detach request while a first attachment is being detached | 19:18 |
| eharney | ameade: i'm still of the opinion that this should be handled in Cinder and its API interface | 19:18 |
| mriedem | Invalid input received: Invalid volume: Unable to detach volume. Volume status must be 'in-use' and attach_status must be 'attached' to detach. (HTTP 400) (Request-ID: req-989e9a96-cdab-4b90-94dd-85db1f714e7c)" | 19:18 |
| hemna | mriedem, well it should get set to detaching if begin_detaching is called and it's 'in-use' | 19:18 |
| mriedem | specifically | 19:18 |
| mriedem | "and attach_status must be 'attached' to detach. " | 19:18 |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L595 | 19:18 |
| sheel | ameade: yes i was looking into https://review.openstack.org/#/c/169591/2/specs/liberty/messaging-the-user.rst | 19:18 |
| smcginnis | sheel: Hey, saw your ping from earlier. Still need something? | 19:19 |
| ameade | eharney: i think that's a valid option | 19:19 |
| mriedem | hemna: ok, and we hit https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L598 | 19:19 |
| *** mragupat has joined #openstack-cinder | 19:19 | |
| mriedem | b/c attach_status is already 'detaching' | 19:19 |
| mriedem | b/c of the first detach request that's still going on | 19:20 |
| mriedem | when the 2nd detach request happens | 19:20 |
| sheel | smcginnis: i raised one BP : https://blueprints.launchpad.net/cinder/+spec/serviceerrorreporting | 19:20 |
| ildikov | mriedem: yeah, it was the cinder api log I saw: http://logs.openstack.org/33/266633/2/check/gate-tempest-dsvm-full/93b2e47/logs/screen-c-api.txt.gz#_2016-01-22_01_01_51_900 | 19:20 |
| sheel | smcginnis: please have a look | 19:20 |
| ameade | eharney, sheel: Heat has been spinning wheels with me from the beginning of this discussion. One thing I was to avoid is users having to hit every single endpoint to see all of their messages | 19:20 |
| hemna | yah, you can't do 2 simultaneous | 19:20 |
| ameade | want* | 19:20 |
| mriedem | gah, i really just with attach_status was in the volume get response | 19:20 |
| mriedem | *wish | 19:20 |
| smcginnis | sheel: Will do, thanks. | 19:21 |
| eharney | ameade: i dunno, i think if you want a message for why a Cinder operation failed, Cinder would be the right place to ask | 19:21 |
| sheel | ameade: hey please have a look at my BP - https://blueprints.launchpad.net/cinder/+spec/summarymessage | 19:21 |
| sheel | ameade: just refer html tagging | 19:21 |
| mriedem | b/c right now, as far as i understand, tempest will need to (1) make the detach request on the first attachment, (2) wait for the volume status to go to 'detaching', then (3) wait for it to go back to in-use (if there is another pending attachment) | 19:21 |
| mriedem | there is a race in (2) ^ | 19:21 |
| sheel | smcginnis: thank you | 19:21 |
| eharney | ameade: but i was also thinking of a pull model rather than push | 19:21 |
| ameade | sheel: will do | 19:21 |
| sheel | ameade, eharney : we can have combination of both | 19:21 |
| sheel | push and pull | 19:22 |
| sheel | just notifications can be stored and when user requests show accordingly | 19:22 |
| mriedem | ildikov: hemna: it seems like the best thing tempest can do is check (1) volume status is 'available' or (2) volume status is in-use and the attachment that we just detached is no longer part of the volume's 'attachments' list in the response | 19:22 |
| hemna | mriedem, hrmm attach_status is on the volume table | 19:22 |
| ildikov | mriedem: we can check the status + the number of attachments | 19:22 |
| mriedem | hemna: right, but it's not in the api response | 19:22 |
| sheel | ameade, eharney: I was thinking of implementing things like ceilometer | 19:22 |
| ildikov | that's stable | 19:22 |
| hemna | why isn't that in the get_volume call | 19:22 |
| mriedem | ildikov: yeah | 19:22 |
| hemna | wtf | 19:22 |
| mriedem | hemna: it's not in the view | 19:22 |
| eharney | sheel: i was thinking of something rather different | 19:23 |
| mriedem | hemna: https://github.com/openstack/cinder/blob/master/cinder/api/v2/views/volumes.py#L56 | 19:23 |
| hemna | well the status should be correct | 19:23 |
| mriedem | tempest can't rely on the status | 19:23 |
| mriedem | it's too racy | 19:23 |
| mriedem | the client will have to rely on the volume status + the attachments list | 19:23 |
| hemna | wait | 19:23 |
| hemna | status can't be racy | 19:23 |
| hemna | or cinder itself wouldn't work | 19:23 |
| sheel | ameade, eharney: notifications-> notificationAgent->collector->db(mongo)->api to fetch details to show to user | 19:23 |
| mriedem | hemna: no cinder | 19:23 |
| mriedem | the client that's polling cinder | 19:24 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Support cinder_img_volume_type in image metadata https://review.openstack.org/258649 | 19:24 |
| sheel | ameade, eharney: this way we can let user decide if he/she wants to see some status explicitely thorugh some horizon tab | 19:24 |
| mriedem | anyway, as ildikov said, i think tempest - and any client - is going to have to check the volume status + the attachments list to know when the detach is really done | 19:24 |
| eharney | sheel: that also means that the user can't get messages unless they can access services other than cinder | 19:24 |
| hemna | mriedem, correct | 19:24 |
| ildikov | yeah, the status itself is not enough here :( | 19:24 |
| mriedem | hemna: at some point cinder should add the attach_status to the volume response in a microversion | 19:24 |
| sheel | ameade, eharney: this will be easy to have for all projects | 19:24 |
| hemna | end users will have to try again | 19:25 |
| sheel | ameade, eharney: no, i am thinking of writing one seperate service | 19:25 |
| hemna | as the error is correct | 19:25 |
| sheel | ameade, eharney: which will be accessible to all components | 19:25 |
| sheel | ameade, eharney: only notification part will be lying in cinder | 19:25 |
| sheel | ameade, eharney: everything else will be in seperate service handling | 19:25 |
| eharney | sheel: i really do not like that model | 19:25 |
| ameade | sheel: that's what i'm thinking with zaqar | 19:25 |
| ameade | eharney: yeah i do want the capability with cinder as stand alone as well | 19:26 |
| sheel | ameade, eharney: I am just drafting BP, may be you get idea about what exactly i am thinking | 19:26 |
| bswartz | sheel: s/lying/laying/ | 19:26 |
| ameade | i was thinking that there would be the ability to dump these messages to different/many different places | 19:26 |
| hemna | mriedem, yah that can't hurt I suppose | 19:26 |
| eharney | ameade: yeah, there's no reason not to keep it in a Cinder database table w/ a reference you can ID it by, and then we can shove it out to zaqar or whatever after that part | 19:26 |
| ildikov | hemna: yeah, the error itself is fine, but the client cannot reliably follow the flow here without checking the number of attachments | 19:26 |
| ameade | like zaqar + db table | 19:26 |
| hemna | although 'in-use' is the same thing as attached. | 19:26 |
| hemna | in this case | 19:26 |
| ameade | eharney: yeah, they are just two different places to shove to | 19:26 |
| eharney | ameade: but if we can't just query Cinder to get the info in the simple case then things are being made too complicated imo | 19:27 |
| eharney | ameade: right | 19:27 |
| hemna | ildikov, the client needs to make sure the status is 'in-use' | 19:27 |
| ildikov | hemna: is attach_status 'attached' -> 'detaching' -> 'attached' if there are multiple attachments? | 19:27 |
| hemna | or cope with the exception and then wait | 19:27 |
| *** haomaiwang has joined #openstack-cinder | 19:27 | |
| sheel | ameade, eharney: actually we can query specific service/node to get specific details | 19:27 |
| hemna | ildikov, correct | 19:27 |
| *** markvoelker has quit IRC | 19:27 | |
| sheel | ameade, eharney: it wont be like fetching all details to know details of one component | 19:27 |
| hemna | or status 'in-use' -> 'detaching' -> 'in-use' | 19:27 |
| ildikov | hemna: than adding that to the response does not help either | 19:27 |
| sheel | ameade, eharney: we will be having filters to select messages specific to single coomponent, all or some | 19:27 |
| eharney | sheel: i want to query the service that i called 2 seconds earlier w/ the API that generated the results i'm interested in | 19:28 |
| mriedem | hemna: sure, but "status 'in-use' -> 'detaching' -> 'in-use'" is not exposed to the user | 19:28 |
| hemna | the status field values of 'in-use' and 'available' are the same as attach_status 'attached' and 'detached' | 19:28 |
| *** lpetrut has joined #openstack-cinder | 19:28 | |
| ildikov | mriedem: I think checking the attachments or retrying what we can do currently | 19:28 |
| mriedem | b/c the user doesn't have the attach-status in the response | 19:28 |
| ameade | sheel: you coming to the midcycle? | 19:28 |
| hemna | mriedem, not true | 19:28 |
| ildikov | mriedem: obviously in tempest checking the attachments would be better | 19:28 |
| mriedem | "the status field values of 'in-use' and 'available' are the same as attach_status 'attached' and 'detached'" | 19:28 |
| hemna | if you call get volume at the right time | 19:28 |
| sheel | ameade: sorry, i wont be able to join | 19:28 |
| hemna | the api response will show 'detaching' | 19:28 |
| hemna | if you get it at the right time | 19:28 |
| mriedem | hemna: oh right, yeah, 'at the right time' | 19:29 |
| mriedem | == race | 19:29 |
| hemna | no | 19:29 |
| hemna | that's not a race | 19:29 |
| hemna | that's a valid condition for the volume to be in | 19:29 |
| ameade | sheel, eharney: the last day is basically a hackathon right? | 19:29 |
| hemna | the volume is in the process of detaching | 19:29 |
| eharney | ameade: i think so | 19:29 |
| mriedem | hemna: i know, but the client could totally miss the time that the volume is in 'detaching' state if it's fast | 19:29 |
| ameade | sheel: maybe you could virtually join us for some time then to discuss? | 19:29 |
| mriedem | it could go from in-use > detaching > in-use while the client is polling | 19:29 |
| mriedem | and if the client misses the 'detaching' status, they could wait indefinitely | 19:30 |
| sheel | ameade, eharney: sure, I will try to join | 19:30 |
| mriedem | b/c they are waiting for something that already happened and they missed it | 19:30 |
| sheel | when ? | 19:30 |
| mriedem | which was the 'right time' | 19:30 |
| sheel | means date? | 19:30 |
| ameade | sheel: what is your timezone? | 19:30 |
| sheel | UTC+5:30 | 19:30 |
| hemna | I suppose if you called get volume and got 'in-use' | 19:30 |
| ildikov | mriedem: yeah, checking only status is not reliable | 19:30 |
| ameade | sheel: Jan 29th is the hackday for the midcycle | 19:31 |
| mriedem | i've seen exactly these types of races in the gate before | 19:31 |
| hemna | and then the volume went 'detaching' from someone else | 19:31 |
| hemna | and then called begin_detaching | 19:31 |
| hemna | it will fail | 19:31 |
| hemna | but that's still valid | 19:31 |
| mriedem | b/c computers are fast | 19:31 |
| ameade | sheel: i am sure other folks will want to discuss earlier in the week, perhaps you could be virtual then as well? | 19:31 |
| mriedem | anyway, i've updated https://review.openstack.org/#/c/266605/4/tempest/api/compute/volumes/test_attach_volume.py with comments | 19:31 |
| mriedem | just needs code | 19:31 |
| sheel | ameade: give me some time to draft the BP...by 27th...may be we wil be quite in sync after that... | 19:31 |
| sheel | ameade: then it will be quite easy to explain | 19:31 |
| ildikov | hemna: I think we all agree that the error is correct | 19:32 |
| sheel | ameade: so its ok to discuss after that as you suggested | 19:32 |
| ameade | sheel: sounds good, feel free to ping me anytime | 19:32 |
| *** haomaiwang has quit IRC | 19:32 | |
| ameade | we definitely need to understand all approaches and lay out the pros and cons of each | 19:32 |
| ildikov | hemna: we just try to figure out how to do sequential detaching of attachments odf the same volume without hitting the error | 19:32 |
| sheel | ameade: sure, thanks | 19:32 |
| ameade | sometimes i feel we don't do that explicitly enough as a community | 19:32 |
| mriedem | ildikov: hemna: yup, all on the same team still :) <3 | 19:33 |
| mriedem | bff's and all | 19:33 |
| sheel | ameade, eharney: i would need some help of you guys during design | 19:33 |
| ildikov | hemna: I mean we were investigating the possibility of checking status as opposed to retry | 19:33 |
| sheel | eharney, ameade: so i am quite inclined to discuss at every step | 19:33 |
| ildikov | mriedem: hemna: BFFs lol <3 :) | 19:34 |
| ameade | sheel: yeah definitely | 19:34 |
| sheel | ameade : will try to share implementation items and plan as well...with BP draft | 19:35 |
| sheel | ameade: will also require 2 more BPs to implement along with this | 19:35 |
| *** bardia has quit IRC | 19:35 | |
| sheel | ameade: please ping me time of discussion for 29th | 19:36 |
| sheel | so that i could plan accordingly | 19:36 |
| ildikov | hemna: I think it will worth a line of docco somewhere that if the volume has multiple attachments the user can detach only one at a time still | 19:36 |
| ameade | sheel, eharney: lets nail that down now | 19:36 |
| *** lpetrut has quit IRC | 19:37 | |
| ildikov | hemna: it is the same for attaching too, right? | 19:37 |
| sheel | ameade, eharney: yes sure, share your availibility | 19:37 |
| ildikov | hemna: I mean a volume can be attached when it's 'available' or 'in-use' but not in 'attaching' | 19:38 |
| sheel | ameade, eharney: I am quite eager to discuss this, so ok with any time.. | 19:38 |
| ameade | sheel, eharney: 1500 UTC on the 29th sound good? Thats 10am EST and 8:30pm your time sheel | 19:38 |
| sheel | sheel, eharney: I am ok | 19:38 |
| ameade | sheel: if we nail down time before then to discuss during the midcycle sessions I will let you know | 19:38 |
| eharney | ameade: sheel: works for me but we'll have to make sure we don't have things from the week overflowing into that time | 19:38 |
| ameade | eharney: true, lets just say that time is tentative | 19:39 |
| sheel | ameade, eharney: ok, either on 29th or later as per availibilty | 19:39 |
| *** krtaylor has quit IRC | 19:41 | |
| ameade | sheel, eharney : i see 4 Pieces of a solution: | 19:41 |
| ameade | 1. Format of messages the user sees | 19:41 |
| ameade | 2. How to create the content of said messages | 19:41 |
| ameade | 3. Where to put messages | 19:41 |
| ameade | 4. How to expose them to users | 19:41 |
| ameade | really 4 different problems | 19:42 |
| sheel | ameade, eharney: all are mentioned in BP implicitely | 19:42 |
| sheel | ameade, eharney: let me answer as per current thinking | 19:42 |
| sheel | 1. format of message - TenantEventIDNodeName NodeIPOperationMessageLevelEventTime Details | 19:43 |
| ildikov | mriedem: I've just realized that we're using to gerrit topics for the BP... :) | 19:43 |
| *** xyang has joined #openstack-cinder | 19:43 | |
| sheel | 2. How to create the content of said messages : through notifications... may be i am missing question here | 19:44 |
| mriedem | ildikov: i noticed that over a week ago | 19:44 |
| mriedem | ildikov: i adjusted my tempest and devstach patches to use the same topic as your nova seriees | 19:44 |
| ildikov | mriedem: I didn't understand first why I don't see both of your patches for tempest | 19:44 |
| sheel | 3. Where to put messages : In database or zaqar - will discuss on this | 19:44 |
| ameade | sheel: yeah 2 i really about how do we keep out sensitive information | 19:44 |
| mriedem | https://review.openstack.org/#/q/topic:bp/volume-multi-attach | 19:44 |
| ildikov | mriedem: thanks :) | 19:44 |
| sheel | 4. How to expose them to users : through API on horizon tab | 19:44 |
| eharney | sheel: ameade: i think 2 is, manually, by constructing them in the code where they are needed, as far as i've been thinking | 19:44 |
| ildikov | mriedem: your devstack patch has the other topic | 19:45 |
| eharney | sheel: ameade: #4 needs something more low level -- like, i sent a request with req-id abcd-efgh, and want to look up an error that was associated with that request | 19:45 |
| ameade | eharney: i have an idea there, because we dont want any mistakes, we construct all message content as constants in a single file so it's easy to see them all | 19:45 |
| sheel | ameade : same as eharney mentioned for #2 | 19:45 |
| mriedem | ildikov: so it does | 19:45 |
| mriedem | ildikov: i couldn't update that one w/o changes | 19:45 |
| mriedem | ildikov: and it was perfect so no changes :) | 19:46 |
| ildikov | mriedem: doon't bother yourself with it | 19:46 |
| *** martyturner has joined #openstack-cinder | 19:46 | |
| ildikov | mriedem: lol :) | 19:46 |
| ameade | eharney, sheel: for #2 the messages also have to be well formed and make sense to a user, so a single place of definition makes it easier to review | 19:46 |
| ildikov | mriedem: I'm sorry, it's my bad ;) | 19:46 |
| openstackgerrit | Kendall Nelson proposed openstack/os-brick: Remove multipath -l logic from ISCSI connector https://review.openstack.org/267085 | 19:46 |
| sheel | ameade, eharney: yup we will have event categorizations | 19:46 |
| sheel | ameade, eharney: for each type of events | 19:46 |
| sheel | ameade, eharney: volume, snapshot, qos | 19:46 |
| ameade | sheel, eharney: for my etherpad, i will change it to break it into these 4 problems and we can document the options for each one | 19:47 |
| ameade | sheel: agreed | 19:47 |
| openstackgerrit | Kendall Nelson proposed openstack/os-brick: Remove multipath -l logic from ISCSI connector https://review.openstack.org/267085 | 19:47 |
| sheel | ameade: thank you | 19:47 |
| eharney | ameade: sheel: makes sense but i think i'm more concerned at this point about building the infrastructure for this than what the messages actually look like exactly | 19:47 |
| ameade | eharney: sure | 19:48 |
| openstackgerrit | Kendall Nelson proposed openstack/os-brick: Remove multipath -l logic from ISCSI connector https://review.openstack.org/267085 | 19:48 |
| *** haomaiwang has joined #openstack-cinder | 19:48 | |
| hemna | sorry guys, I have 2 other fires going on ... | 19:48 |
| hemna | <ildikov> hemna: I mean a volume can be attached when it's 'available' or 'in-use' but not in 'attaching' | 19:48 |
| hemna | no | 19:48 |
| sheel | eharney: I am sorry to ask again, but could you please refer html tagging by opening in browser ..it will give some more details of my views | 19:48 |
| hemna | the volume can't be in attached mode if the status is 'available' | 19:48 |
| sheel | ameade, eharney: specifically about how message will look like | 19:49 |
| eharney | sheel: not sure i follow, Cinder can't generate HTML for this stuff | 19:51 |
| ameade | sheel: yeah i like the idea | 19:51 |
| ameade | eharney: just a mockup to imagine what it could look like in horizon | 19:51 |
| sheel | eharney: in horizon | 19:51 |
| sheel | eharny: its just a depiction of what i want to use to show message to user | 19:51 |
| sheel | eharney: its just a depiction of what i want to use to show message to user | 19:52 |
| eharney | sheel: ameade: ok but that's probably outside of the scope of Cinder's part, since this has to be usable from a REST interface, CLIs, etc | 19:52 |
| sheel | ameade, eharney: notifications-> notificationAgent->collector->db(mongo)->api to fetch details to show to user | 19:53 |
| *** haomaiwang has quit IRC | 19:53 | |
| sheel | ameade, eharney : this will be usable from cli as well | 19:53 |
| ildikov | hemna: sorry, so I meant that the attach request will go through if the volume is 'available' or if it's multiattach then it can be 'in-use' too | 19:54 |
| hemna | yes | 19:54 |
| ildikov | mriedem: in the tests basically the cleanup that fails, right? | 19:54 |
| ildikov | hemna: and if it's 'attaching' the request will fail | 19:54 |
| hemna | correct | 19:54 |
| sheel | ameade, ehareny : I will discuss this in horizon meeting as well | 19:54 |
| hemna | just as it would w/o multiattach | 19:54 |
| hemna | and even for other volume related workflows | 19:55 |
| sheel | ameade, eharney: just after our discussion get finalized | 19:55 |
| hemna | can't call delete volume on a volume where status isn't available | 19:55 |
| hemna | etc | 19:55 |
| *** sombrafam has quit IRC | 19:55 | |
| ildikov | hemna: cool, I got a question on my Nova patch why I don't allow attaching state and I wrote the guy the exact same thing that we should not allow parrallel attaching for the same volume | 19:55 |
| ildikov | *parallel | 19:56 |
| sheel | ameade, eharney: notifications-> notificationAgent->collector->db(mongo)->api to fetch details to show to user -> through CLI or Horizon tab | 19:56 |
| ildikov | hemna: all good, thanks | 19:57 |
| *** dims has joined #openstack-cinder | 19:57 | |
| *** dimsum__ has quit IRC | 19:57 | |
| eharney | sheel: ameade: i'm much more interested in the part before the notifications | 19:58 |
| eharney | sheel: ameade: for now anyway | 19:58 |
| *** geguileo has quit IRC | 19:58 | |
| mriedem | ildikov: yeah | 20:00 |
| ameade | we'll figure this out, i've seen contention at all 4 points so it'll be tough to find consensus without compromise | 20:00 |
| ameade | (reasons it's not done yet) lol | 20:00 |
| sheel | eharney: please refer my other BP as well which will cater to your interest "before notification" part upto some extent | 20:01 |
| sheel | https://blueprints.launchpad.net/cinder/+spec/serviceerrorreporting- where i am planning for reporting service errors if they stopped abnormally | 20:01 |
| sheel | I will be taking care of one more point- call cast combination in cinder operations for bette error tracking - going to raise seperate BP for that | 20:02 |
| *** raildo is now known as raildo-afk | 20:02 | |
| eharney | sheel: i don't think the call/cast thing is going to fly | 20:03 |
| *** alonma has joined #openstack-cinder | 20:03 | |
| sheel | eharney: I will give details, I think this will interest you | 20:03 |
| sheel | this will be of your interest | 20:03 |
| hemna | ildikov, ok sounds good | 20:04 |
| hemna | phew | 20:04 |
| sheel | eharney: It will server a lot of purposes, | 20:04 |
| sheel | eharney: without performance issues | 20:04 |
| *** hyakuhei_ has joined #openstack-cinder | 20:04 | |
| *** lpetrut has joined #openstack-cinder | 20:05 | |
| *** mudassirlatif has quit IRC | 20:05 | |
| sheel | eharney: we will discuss this part later .. | 20:06 |
| sheel | otherwise this is going to be huge to discuss all things at once | 20:06 |
| ildikov | mriedem: ok, then I understand the flow correctly | 20:06 |
| ildikov | hemna: :) | 20:06 |
| sheel | :) | 20:06 |
| eharney | ok | 20:06 |
| sheel | eharney: please keep on giving your views, i am more interested in taking constructive inputs | 20:07 |
| sheel | eharney: thank you!! | 20:07 |
| *** e0ne has quit IRC | 20:08 | |
| *** alonma has quit IRC | 20:08 | |
| *** haomaiwang has joined #openstack-cinder | 20:09 | |
| sheel | smcginnis: for "https://blueprints.launchpad.net/cinder/+spec/serviceerrorreporting" -> I think "Definition" field is updated instead of "Direction:" field | 20:11 |
| sheel | :) | 20:11 |
| *** alonma has joined #openstack-cinder | 20:12 | |
| smcginnis | sheel: For now... :) | 20:12 |
| sheel | smcginnis: ohk, i though its just becuase of human err... | 20:13 |
| smcginnis | ;) | 20:13 |
| sheel | :) | 20:13 |
| *** haomaiwang has quit IRC | 20:13 | |
| *** martyturner has quit IRC | 20:16 | |
| *** alonma has quit IRC | 20:16 | |
| *** martyturner has joined #openstack-cinder | 20:16 | |
| *** esker has quit IRC | 20:16 | |
| *** esker has joined #openstack-cinder | 20:17 | |
| *** alonma has joined #openstack-cinder | 20:18 | |
| sheel | ameade: Thanks for creating "https://etherpad.openstack.org/p/mitaka-cinder-midcycle-user-notifications" - I have updated it with some points.. | 20:19 |
| *** timcl1 has quit IRC | 20:20 | |
| ameade | sheel: awesome | 20:21 |
| sheel | ameade: :) | 20:21 |
| *** alonma has quit IRC | 20:23 | |
| *** e0ne has joined #openstack-cinder | 20:24 | |
| *** alonma has joined #openstack-cinder | 20:24 | |
| *** timcl1 has joined #openstack-cinder | 20:25 | |
| *** apoorvad has quit IRC | 20:28 | |
| *** alonma has quit IRC | 20:29 | |
| *** salv-orlando has quit IRC | 20:29 | |
| *** haomaiwang has joined #openstack-cinder | 20:30 | |
| *** martyturner has quit IRC | 20:32 | |
| *** haomaiwang has quit IRC | 20:34 | |
| Swanson | asselin, CI question. I can't seem to build a node today as nodepool chokes on vahana with a "fatal: Couldn't find remote ref master". I'm trying to figure out where this is referenced so I can remove it. | 20:41 |
| asselin | Swanson, this is a job or image build? linki to logs? | 20:42 |
| Swanson | asselin, image build. | 20:43 |
| asselin | the full command used should be logged...try it again to make sure it's not intermittent | 20:44 |
| Swanson | asselin, I've tried it twice. I've also tried it by hand. | 20:44 |
| Swanson | asselin, git --git-dir=/opt/dib_cache/source-repositories/vahana_16d63c569d46b7301825deb73789dae51c725c69/.git fetch --prune --update-head-ok git://git.openstack.org/openstack/vahana.git +master:master | 20:45 |
| Swanson | asselin, runing a git clone of git://git.openstack.org/openstack/vahana.git seems to clone an empty repo. | 20:46 |
| *** hyakuhei_ has quit IRC | 20:46 | |
| asselin | Swanson, there's a file somewhere that defines all the projects...but you might want to ask in openstack-infra in case they can fix it on the backend | 20:47 |
| mriedem | ildikov: hemna: i took the easy route for now on checking the status https://review.openstack.org/266605 | 20:48 |
| mriedem | if that doesn't work, i'll switch to checking the volume attachments | 20:48 |
| *** pratap_ has quit IRC | 20:49 | |
| asselin | Swanson, I just ran into it now...will ask | 20:49 |
| Swanson | asselin, Thanks! It comes about 4GB in so it kinda sucks. | 20:50 |
| ildikov | mriedem: I don't know how long the volume is in 'detaching' state, but it looks good for now, from the logs I believe it should work | 20:50 |
| *** pratap has joined #openstack-cinder | 20:51 | |
| ildikov | mriedem: for attach it works fine to wait for 'in-use' | 20:52 |
| ildikov | mriedem: and after the first attachment it's the same situation as detach | 20:52 |
| *** lpetrut has quit IRC | 20:53 | |
| *** mtanino has quit IRC | 20:55 | |
| hemna | mriedem, so servers_client.detach_volume, calls begin_detaching, then detach ? | 20:58 |
| hemna | is that the novaclient object ? | 20:58 |
| hemna | sorry trying to follow | 20:58 |
| *** e0ne has quit IRC | 20:58 | |
| *** timcl1 has left #openstack-cinder | 20:59 | |
| *** edtubill has quit IRC | 21:01 | |
| *** edtubill has joined #openstack-cinder | 21:01 | |
| mriedem | hemna: the compute API calls cinderclient.begin_detaching before casting off to the compute service | 21:03 |
| mriedem | at which point the REST API response with the 202 to the client | 21:03 |
| mriedem | *responds | 21:03 |
| hemna | ok, so it's safe to wait for detaching then | 21:05 |
| jgriffith | hemna: it's just like attach, just for detach | 21:07 |
| jgriffith | hemna: there's an analogous call on either side. | 21:07 |
| jgriffith | hemna: it's *just* a db state update | 21:08 |
| hemna | I just wanted to make sure that it was safe to wait for the detaching state | 21:08 |
| *** thangp has left #openstack-cinder | 21:08 | |
| hemna | otherwise it sit waiting and fail | 21:08 |
| jgriffith | hemna: yeah.. in that call you best not be waiting long :) | 21:08 |
| hemna | :) | 21:08 |
| *** akerr_ has joined #openstack-cinder | 21:09 | |
| jgriffith | not avishay did throw a new case in to that logic with migration though :( | 21:09 |
| jgriffith | err... s/not/note/ | 21:09 |
| mriedem | patrickeast: heh https://review.openstack.org/#/c/229152/ | 21:09 |
| mriedem | softlayer is thanking you for that | 21:09 |
| mriedem | they have cinder liberty + nova kilo | 21:09 |
| mriedem | and iscsi multipath isn't cleaning up after itself... | 21:09 |
| openstackgerrit | Kendall Nelson proposed openstack/os-brick: Remove multipath -l logic from ISCSI connector https://review.openstack.org/267085 | 21:10 |
| jgriffith | mriedem: multi-path is broken anyway | 21:10 |
| mriedem | jgriffith: woot! | 21:10 |
| jgriffith | mriedem: or more correclty, on Nova it breaks everybody else :( | 21:10 |
| mriedem | jgriffith: in general? in kilo? in liberty? | 21:10 |
| *** apoorvad has joined #openstack-cinder | 21:10 | |
| mriedem | alright, well, idk? i know nova has a buttload of volume + multipath open bugs | 21:11 |
| jgriffith | mriedem: I'm being dramatic :) But... I'm annoyed because the multi-path flag setting in nova.conf is global. So it breaks devices that don't use multi-path | 21:11 |
| mriedem | that probably no one is working on fixing | 21:11 |
| jgriffith | mriedem: I'm working on it on and off :) | 21:11 |
| *** akerr has quit IRC | 21:11 | |
| jgriffith | anywho... | 21:12 |
| patrickeast | mriedem: haha nice, glad others are getting some use from those | 21:12 |
| * patrickeast still has to apply them for manually on top of Kilo deployments :( | 21:12 | |
| openstackgerrit | Kendall Nelson proposed openstack/os-brick: Remove multipath -l logic from ISCSI connector https://review.openstack.org/267085 | 21:13 |
| *** sheel has quit IRC | 21:14 | |
| mriedem | patrickeast: yeah someone told me they had everything on liberty, i guess not | 21:15 |
| mriedem | so i'm just pushing them to upgrade | 21:15 |
| mriedem | i mean, it's just upgrading nova, how hard could it be? | 21:15 |
| patrickeast | mriedem: definitely the best approach... stuff works much better on liberty | 21:15 |
| patrickeast | lol | 21:15 |
| patrickeast | easy as pie | 21:15 |
| mriedem | hence http://www.danplanet.com/blog/2015/10/05/upgrades-in-nova-the-details/ | 21:15 |
| *** marcusvrn_ has quit IRC | 21:17 | |
| *** salv-orlando has joined #openstack-cinder | 21:18 | |
| openstackgerrit | Kendall Nelson proposed openstack/os-brick: Remove multipath -l logic from ISCSI connector https://review.openstack.org/267085 | 21:20 |
| *** alonma has joined #openstack-cinder | 21:25 | |
| *** jungleboyj has quit IRC | 21:25 | |
| *** jwcroppe has quit IRC | 21:27 | |
| *** salv-orlando has quit IRC | 21:28 | |
| *** alonma has quit IRC | 21:29 | |
| openstackgerrit | Kendall Nelson proposed openstack/os-brick: Remove multipath -l logic from ISCSI connector https://review.openstack.org/267085 | 21:29 |
| hemna | mmm pie | 21:30 |
| *** winston-d_ has quit IRC | 21:32 | |
| *** alonma has joined #openstack-cinder | 21:32 | |
| *** eharney has quit IRC | 21:33 | |
| *** eharney has joined #openstack-cinder | 21:35 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - VMAX driver failing to remove zones https://review.openstack.org/244933 | 21:35 |
| *** alonma has quit IRC | 21:36 | |
| *** eharney_ has joined #openstack-cinder | 21:38 | |
| *** markvoelker has joined #openstack-cinder | 21:40 | |
| *** markvoelker has quit IRC | 21:40 | |
| *** markvoelker has joined #openstack-cinder | 21:41 | |
| *** eharney has quit IRC | 21:42 | |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: 3PAR: Add volume fail-back capabilities https://review.openstack.org/265399 | 21:43 |
| *** mtanino has joined #openstack-cinder | 21:43 | |
| *** cebruns has quit IRC | 21:44 | |
| *** cebruns has joined #openstack-cinder | 21:46 | |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: LeftHand: Add volume fail-back capabilities https://review.openstack.org/271534 | 21:47 |
| *** mriedem has quit IRC | 21:51 | |
| *** baumann has left #openstack-cinder | 21:52 | |
| *** rcernin has joined #openstack-cinder | 21:53 | |
| *** cebruns has quit IRC | 21:53 | |
| *** haomaiwang has joined #openstack-cinder | 21:53 | |
| *** cebruns has joined #openstack-cinder | 21:55 | |
| openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor5 iSCSI driver unit tests https://review.openstack.org/271537 | 21:56 |
| *** haomaiwang has quit IRC | 21:57 | |
| alkhodos | tbarron: Hi Tom, you might want to take a look :) https://review.openstack.org/271537 | 21:58 |
| tbarron | alkhodos: looking ... | 21:58 |
| *** mragupat has quit IRC | 21:59 | |
| *** jgregor has quit IRC | 21:59 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - Changing PercentSynced to CopyState in isSynched https://review.openstack.org/246992 | 22:01 |
| *** hyakuhei_ has joined #openstack-cinder | 22:01 | |
| *** diablo_rojo has left #openstack-cinder | 22:02 | |
| *** eharney_ has quit IRC | 22:05 | |
| *** erlon has quit IRC | 22:06 | |
| *** salv-orlando has joined #openstack-cinder | 22:10 | |
| *** tpatzig has left #openstack-cinder | 22:12 | |
| *** dustins has quit IRC | 22:14 | |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: LeftHand: Add volume fail-back capabilities https://review.openstack.org/271534 | 22:16 |
| *** amoturi has left #openstack-cinder | 22:16 | |
| *** tpsilva has quit IRC | 22:16 | |
| *** xyang has quit IRC | 22:17 | |
| *** eharney_ has joined #openstack-cinder | 22:18 | |
| *** JoseMello has quit IRC | 22:18 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - get iscsi ip from port in existing MV https://review.openstack.org/245997 | 22:20 |
| *** xyang1 has quit IRC | 22:21 | |
| *** bardia has joined #openstack-cinder | 22:29 | |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: LeftHand: Implement un/manage snapshot support https://review.openstack.org/255015 | 22:30 |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: LeftHand: Implement v2 replication (unmanaged) https://review.openstack.org/255544 | 22:30 |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: LeftHand: Add volume fail-back capabilities https://review.openstack.org/271534 | 22:30 |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: LeftHand: Updating minimum client version https://review.openstack.org/267780 | 22:30 |
| tbarron | alkhodos: your coverage *for ns5* looks good now! | 22:30 |
| angela-s | smcginnis: could you have a look at this review when you have a chance? this is for friendly zone names changes. https://review.openstack.org/#/c/180518/ | 22:31 |
| *** alonma has joined #openstack-cinder | 22:32 | |
| *** markvoelker has quit IRC | 22:32 | |
| alkhodos | tbarron: glad to hear! | 22:33 |
| *** haomaiwang has joined #openstack-cinder | 22:33 | |
| tbarron | alkhodos: I think it's nice to have a separate test case for each assertRaises, with that as the final line. | 22:34 |
| tbarron | alkhodos: but some people think I'm pedantic on that, so not an issue for this review | 22:34 |
| tbarron | alkhodos: I like the ddt module for being able to do that with lots of different input data and expected results. | 22:35 |
| tbarron | alkhodos: so that you don't have to write a million test cases | 22:35 |
| *** [1]Thelo has joined #openstack-cinder | 22:35 | |
| tbarron | alkhodos: might be giving the impression that I think I'm an expert on this stuff, but far from it. | 22:35 |
| tbarron | alkhodos: just sharing some observations from fumbling around with unit tests over the last year or so | 22:36 |
| *** alonma has quit IRC | 22:37 | |
| *** haomaiwang has quit IRC | 22:38 | |
| *** PsionTheory has quit IRC | 22:38 | |
| *** Thelo has quit IRC | 22:38 | |
| *** [1]Thelo is now known as Thelo | 22:38 | |
| jgriffith | anybody else seeing this mess on volume attach today: http://paste.openstack.org/show/484748/ | 22:45 |
| hemna | ew | 22:46 |
| *** hyakuhei_ has quit IRC | 22:46 | |
| hemna | jgriffith, so a few things | 22:46 |
| hemna | there was a recent cinder patch that allows passing in instance_uuid and host at the same time | 22:47 |
| hemna | and Nova added host passing to os-attach | 22:47 |
| hemna | https://review.openstack.org/#/c/256273/ | 22:47 |
| jgriffith | hemna: sigh | 22:47 |
| jgriffith | hemna: i saw the aio patch, but hadn't come across the others yet | 22:47 |
| hemna | https://review.openstack.org/#/c/266006/ | 22:48 |
| *** rajinir has joined #openstack-cinder | 22:50 | |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: WIP:Support restore target configration during driver initialization https://review.openstack.org/271424 | 22:50 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: WIP:[LVM] Restore target config during driver initialization https://review.openstack.org/271424 | 22:51 |
| *** alonma has joined #openstack-cinder | 22:51 | |
| jgriffith | hemna: confusing, because the error is thrown by the client it would appear | 22:52 |
| jgriffith | hemna: the call never even seems to go to Cinder... and making me unclear why this isn't hitting in other drivers/CI's | 22:52 |
| hemna | hrmm | 22:53 |
| openstackgerrit | Merged openstack/cinder: Huawei: Refactor driver for the second time https://review.openstack.org/256920 | 22:53 |
| jgriffith | hemna: unless I just haven't found it on the other side yet :) | 22:53 |
| hemna | raise exceptions.from_response(resp, body) | 22:53 |
| hemna | that smells like it's processing the response from the API though | 22:53 |
| *** rcernin has quit IRC | 22:53 | |
| hemna | it's probably buried in your API log somewhere | 22:54 |
| jgriffith | hemna: well... looking at c-api and so far searching on that volume-id I don't see an attach request for it at all | 22:54 |
| *** krtaylor has joined #openstack-cinder | 22:54 | |
| jgriffith | hemna: I see create get and delete and that's it | 22:54 |
| jgriffith | hemna: http://54.164.167.86/solidfire-ci-logs/refs-changes-43-266743-4/logs/c-api.log.txt | 22:55 |
| hemna | hrmm | 22:55 |
| *** dims_ has joined #openstack-cinder | 22:56 | |
| openstackgerrit | Mark Sturdevant proposed openstack/cinder: W-I-P Fix 3PAR to work with nova evacuate https://review.openstack.org/266098 | 22:56 |
| *** alonma has quit IRC | 22:56 | |
| jgriffith | hemna: hmm... maybe it is burried in there deeper | 22:57 |
| jgriffith | sigh | 22:57 |
| hemna | I'm searching for 400 | 22:57 |
| hemna | .... | 22:57 |
| hemna | lots of em though... | 22:57 |
| jgriffith | hemna: stupid negative tests! | 22:57 |
| hemna | heh yah | 22:58 |
| hemna | create a volume with -1Gb size..... | 22:58 |
| *** dims has quit IRC | 22:58 | |
| jgriffith | hemna: ok, found it | 22:59 |
| hemna | 2016-01-22 22:11:37.802 | 22:59 |
| jgriffith | hemna: 2016-01-22 22:11:34.279 | 22:59 |
| hemna | :P | 22:59 |
| jgriffith | 802? | 22:59 |
| *** alonma has joined #openstack-cinder | 22:59 | |
| hemna | ah yours is first | 22:59 |
| hemna | but yah | 23:00 |
| hemna | another one at :37.802 | 23:00 |
| jgriffith | hemna: I LOOOOVE the fact that we log that as Info and not Error | 23:00 |
| smcginnis | hemna: REgarding testing -1Gb: https://twitter.com/sempf/status/514473420277694465?lang=en | 23:00 |
| jgriffith | hemna: so that confirms my concern though... | 23:00 |
| jgriffith | hemna: this appears to fail at the API layer, nothing to do with the driver that I can see here? | 23:01 |
| smcginnis | jgriffith: Are there unintended consequences of the instance_id/host_name patch? | 23:01 |
| jgriffith | smcginnis: yeah, from my view it breaks shit :) | 23:01 |
| *** edtubill has quit IRC | 23:01 | |
| hemna | so, I just did a grep on master for "Invalid request to attach volume to an instance" | 23:01 |
| hemna | and it's not there | 23:01 |
| hemna | so I'm confused | 23:01 |
| smcginnis | I wonder why my CI is fine. | 23:02 |
| jgriffith | hemna: api/contrib/volume_actions.py | 23:02 |
| hemna | https://review.openstack.org/#/c/266006/1/cinder/api/contrib/volume_actions.py | 23:02 |
| hemna | that patch has landed | 23:02 |
| smcginnis | BTW, here is a better thread of the good negative tests I linked to: https://www.sempf.net/post/On-Testing1.aspx | 23:02 |
| hemna | that check and message are gone | 23:02 |
| jgriffith | oh... wait | 23:02 |
| smcginnis | Of completely no importance or relevant to the current conversation. | 23:03 |
| jgriffith | smcginnis: sure it is... proves my point that negative tests are stooopid :) | 23:03 |
| smcginnis | jgriffith: But much more funny in a bar! :) | 23:03 |
| jgriffith | smcginnis: yes indeed!!! | 23:03 |
| *** alonma has quit IRC | 23:04 | |
| *** akerr_ is now known as akerr_away | 23:04 | |
| jgriffith | smcginnis: hemna hmmmm.... https://github.com/openstack-dev/devstack/commit/b9a33191bbeec118a6643961278dfba73a38911c | 23:05 |
| jgriffith | smcginnis: hemna looks like I may have been bit by another devstack change again ? | 23:05 |
| jgriffith | wait.... | 23:06 |
| hemna | uhh wtf is that | 23:06 |
| jgriffith | hell if I know... jus the usual churn of crap | 23:06 |
| hemna | is this testing a latest nova with liberty ? | 23:06 |
| *** akerr_away is now known as akerr_ | 23:06 | |
| *** akerr_ is now known as akerr_away | 23:06 | |
| *** akerr_away is now known as akerr_ | 23:06 | |
| jgriffith | hemna: but it seems related to your host info changes | 23:06 |
| jgriffith | hemna: err s/your/the/ | 23:06 |
| hemna | yah it sure seems like it | 23:06 |
| *** akerr_ is now known as akerr_away | 23:06 | |
| smcginnis | I don't get what that's doing, but oh well. | 23:06 |
| *** laughterwym has joined #openstack-cinder | 23:07 | |
| hemna | nothing like breaking the world | 23:07 |
| *** akerr_away is now known as akerr_ | 23:07 | |
| * hemna hides under a rock | 23:07 | |
| *** salv-orlando has quit IRC | 23:07 | |
| smcginnis | I've been trying to get through a change that just updates a text file for 4 days now. World == broken | 23:08 |
| *** akerr_ is now known as akerr_away | 23:08 | |
| *** akerr_away is now known as akerr_ | 23:08 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: VMAX-Replacing deprecated API EMCGetTargetEndpoints https://review.openstack.org/244328 | 23:08 |
| hemna | https://review.openstack.org/#/c/264223/ | 23:08 |
| *** akerr_ is now known as akerr_away | 23:08 | |
| *** akerr_away is now known as akerr_ | 23:08 | |
| smcginnis | Hmm | 23:09 |
| hemna | not sure that's related | 23:09 |
| hemna | dunno though | 23:09 |
| jgriffith | hemna: yeah, so it looks like the change breaks stable | 23:09 |
| *** akerr_ is now known as akerr_away | 23:09 | |
| jgriffith | hemna: so they put this in to make sure it's not checked/tested on stable I'm thinking | 23:09 |
| jgriffith | but not sure | 23:09 |
| hemna | hrmm | 23:09 |
| hemna | so Nova(master) -> stable/* ? | 23:10 |
| jgriffith | I dunno.. the bug doesn't align with that | 23:10 |
| hemna | so Nova(master) -> Cinder(stable/*) ? | 23:10 |
| jgriffith | I think that context is infact different | 23:10 |
| smcginnis | That makes it sound like it was disabled in master (and stable/*) up until now. | 23:11 |
| *** laughterwym has quit IRC | 23:11 | |
| *** wN has quit IRC | 23:13 | |
| jgriffith | it sure would be nice to know where that exception is coming from exactly :) | 23:13 |
| jgriffith | Ohhh | 23:13 |
| jgriffith | tempest directly perhaps | 23:13 |
| hemna | that has to be from Cinder !master | 23:13 |
| *** dims_ has quit IRC | 23:13 | |
| jgriffith | hemna: oh? Ya think so? | 23:14 |
| hemna | or my grep isn't correct | 23:14 |
| hemna | ack-grep "Invalid request to attach volume to an instance" | 23:14 |
| jgriffith | hemna: oh.. yeah, I hear ya... same here | 23:14 |
| hemna | that returned nothing (from Master) | 23:14 |
| *** salv-orlando has joined #openstack-cinder | 23:14 | |
| *** eharney_ is now known as eharney | 23:15 | |
| *** jamielennox is now known as jamielennox|away | 23:15 | |
| jgriffith | hemna: well this is the change that if failed on, which certainly appears to be master :) | 23:16 |
| jgriffith | oops | 23:17 |
| jgriffith | https://review.openstack.org/#/c/264223/ | 23:17 |
| jgriffith | bahh | 23:17 |
| jgriffith | this one | 23:17 |
| *** akerr_away is now known as akerr_ | 23:18 | |
| jgriffith | smcginnis: BTW, you fail too :) | 23:18 |
| *** wN has joined #openstack-cinder | 23:19 | |
| *** wN has joined #openstack-cinder | 23:19 | |
| jgriffith | smcginnis: looks like the same errors | 23:19 |
| jgriffith | My guess is that once all the node-pool systems get an update they're going to start failing | 23:19 |
| hemna | :( | 23:19 |
| smcginnis | jgriffith: Bah! | 23:20 |
| jgriffith | one thing that's nice about sos is we've seen that a few times now... canary in the coal mine | 23:20 |
| smcginnis | Yeah, lucky us. | 23:20 |
| *** shakamunyi has quit IRC | 23:22 | |
| smcginnis | Of course this started failing right as I left the office. | 23:23 |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - Fix for last volume in VMAX3 storage group https://review.openstack.org/244331 | 23:24 |
| hemna | smcginnis, perfect timing on a Friday | 23:24 |
| hemna | beer o'clock! | 23:24 |
| hemna | wait...... | 23:24 |
| *** xyang has joined #openstack-cinder | 23:24 | |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: 3PAR: Add volume fail-back capabilities https://review.openstack.org/265399 | 23:25 |
| smcginnis | hemna: On the plus side, looks like infra servers are updated now, so the os-brick 0.8.0 patch finally passed again. | 23:26 |
| hemna | phew! | 23:27 |
| hemna | man that took for-freaking-ever | 23:27 |
| smcginnis | No kidding. Should have been a pretty trivial thing. | 23:27 |
| smcginnis | Bad timing for sure. | 23:27 |
| smcginnis | Now to get a +A again... | 23:27 |
| angela-s | +A, what's that? endangered species i think | 23:29 |
| smcginnis | angela-s: Workflow+1 :) | 23:30 |
| smcginnis | +A == "Approved" | 23:31 |
| angela-s | smcginnis: i know, was being sarcastic. :) | 23:31 |
| jgriffith | angela-s: I got it, and I personally thought it was kinda funny :) | 23:32 |
| smcginnis | angela-s: Ah, now I get you. Sorry, brain is half turned off. | 23:32 |
| smcginnis | angela-s: It was funny. :] | 23:32 |
| angela-s | jgriffith, smcginnis: Friday humor, is it time to go home yet? | 23:32 |
| hemna | +A everything...it's Friday. | 23:33 |
| angela-s | i'm done... | 23:33 |
| hemna | what could go wrong.... | 23:33 |
| angela-s | hell ya | 23:33 |
| angela-s | sounds good | 23:33 |
| *** bill_az has quit IRC | 23:34 | |
| smcginnis | Then we can just spend the rest of the cycle fixing bugs. Pretty simple plan. :D | 23:35 |
| jgriffith | angela-s: I'm +A on that patch when it passes | 23:36 |
| smcginnis | hemna: 32 and sunny in Chicago tomorrow. You'll have a good day to see all the sights. ;) | 23:37 |
| hemna | :) | 23:37 |
| hemna | I'll make it to Chi town | 23:37 |
| hemna | and then sleep in the terminal | 23:37 |
| hemna | wah wah wahhh | 23:37 |
| angela-s | jgriffith: which one? | 23:40 |
| jgriffith | angela-s: https://review.openstack.org/#/c/245364/ | 23:40 |
| jgriffith | just updated | 23:40 |
| jgriffith | it failed again :( | 23:40 |
| smcginnis | angela-s: You are already running a stack.sh session. << Something went wrong. | 23:41 |
| *** edmondsw has quit IRC | 23:41 | |
| angela-s | argh! | 23:42 |
| smcginnis | Call me caption obvious. :) | 23:42 |
| *** daneyon has quit IRC | 23:43 | |
| smcginnis | jgriffith: Where were you seeing those failure messages again? They were info and not error? | 23:43 |
| *** akerr_ has quit IRC | 23:44 | |
| jgriffith | smcginnis: correct | 23:45 |
| jgriffith | but your CI failed for the same tests as mine on that patch | 23:45 |
| *** lcurtis has quit IRC | 23:45 | |
| smcginnis | jgriffith: Yeah, trying to find it now. | 23:46 |
| jgriffith | smcginnis: https://review.openstack.org/#/c/266743/ | 23:46 |
| *** simondodsley has quit IRC | 23:48 | |
| *** akerr has joined #openstack-cinder | 23:50 | |
| smcginnis | hemna: Did you say "Invalid request to attach volume to an instance" is coming from Cinder? | 23:54 |
| smcginnis | hemna: Wasn't that what you removed/ | 23:54 |
| *** edmondsw has joined #openstack-cinder | 23:54 | |
| *** pratap has quit IRC | 23:55 | |
| *** pratap has joined #openstack-cinder | 23:56 | |
| *** dims has joined #openstack-cinder | 23:56 | |
| *** martyturner has joined #openstack-cinder | 23:58 | |
| smcginnis | Oh, these are just older patches that need to be rebased on master it looks like. | 23:59 |
| smcginnis | So the patch to allow host and instance_id went through. | 23:59 |
| smcginnis | And nova started sending both. | 23:59 |
| *** alonma has joined #openstack-cinder | 23:59 | |
| jgriffith | smcginnis: +1 | 23:59 |
| jgriffith | smcginnis: so they just need rebased | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!