| *** haomaiwang has quit IRC | 00:01 | |
| *** haomaiwang has joined #openstack-cinder | 00:01 | |
| *** alonma has quit IRC | 00:03 | |
| *** salv-orl_ has quit IRC | 00:19 | |
| *** chlong has joined #openstack-cinder | 00:26 | |
| *** mylu has quit IRC | 00:31 | |
| *** haomaiwang has quit IRC | 01:01 | |
| *** dims has quit IRC | 01:01 | |
| *** haomaiwang has joined #openstack-cinder | 01:01 | |
| *** pots has joined #openstack-cinder | 01:01 | |
| *** chlong has quit IRC | 01:03 | |
| *** mylu has joined #openstack-cinder | 01:05 | |
| *** haomaiw__ has joined #openstack-cinder | 01:06 | |
| *** haomaiwang has quit IRC | 01:07 | |
| *** salv-orlando has joined #openstack-cinder | 01:19 | |
| *** dims has joined #openstack-cinder | 01:24 | |
| *** gouthamr has joined #openstack-cinder | 01:27 | |
| *** gouthamr has quit IRC | 01:39 | |
| openstackgerrit | Angus Lees proposed openstack/os-brick: Trivial rootwrap -> privsep replacement https://review.openstack.org/277224 | 01:41 |
|---|---|---|
| *** thurloat_isgone is now known as thurloat | 01:45 | |
| *** dims has quit IRC | 01:46 | |
| *** alonma has joined #openstack-cinder | 01:47 | |
| *** EinstCrazy has joined #openstack-cinder | 01:50 | |
| *** salv-orlando has quit IRC | 01:50 | |
| *** alonma has quit IRC | 01:51 | |
| *** alonma has joined #openstack-cinder | 01:53 | |
| *** EinstCrazy has quit IRC | 01:54 | |
| *** mylu has quit IRC | 01:57 | |
| *** alonma has quit IRC | 01:58 | |
| *** mylu has joined #openstack-cinder | 01:58 | |
| *** haomaiw__ has quit IRC | 02:01 | |
| *** haomaiwang has joined #openstack-cinder | 02:01 | |
| *** gouthamr has joined #openstack-cinder | 02:03 | |
| *** gouthamr has quit IRC | 02:05 | |
| *** chlong has joined #openstack-cinder | 02:06 | |
| openstackgerrit | Chuck Fouts proposed openstack/cinder: Support for iSCSI CHAP Uni-directional Auth https://review.openstack.org/251925 | 02:29 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/277228 | 02:38 |
| *** changbl has quit IRC | 02:42 | |
| *** changbl has joined #openstack-cinder | 02:42 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-cinderclient: Updated from global requirements https://review.openstack.org/266163 | 02:43 |
| *** akshai has joined #openstack-cinder | 02:48 | |
| *** alonma has joined #openstack-cinder | 02:53 | |
| *** akshai has quit IRC | 02:54 | |
| *** mragupat has joined #openstack-cinder | 02:55 | |
| *** alonma has quit IRC | 02:58 | |
| *** pots1 has joined #openstack-cinder | 02:59 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-cinder | 03:01 | |
| *** pots has quit IRC | 03:03 | |
| *** mragupat has quit IRC | 03:09 | |
| *** mragupat has joined #openstack-cinder | 03:10 | |
| *** salv-orlando has joined #openstack-cinder | 03:10 | |
| *** jwcroppe has joined #openstack-cinder | 03:11 | |
| *** jwcroppe has quit IRC | 03:11 | |
| *** jwcroppe has joined #openstack-cinder | 03:12 | |
| *** salv-orlando has quit IRC | 03:13 | |
| *** dims has joined #openstack-cinder | 03:13 | |
| *** thurloat is now known as thurloat_isgone | 03:17 | |
| *** mylu has quit IRC | 03:17 | |
| *** mylu has joined #openstack-cinder | 03:17 | |
| *** pots has joined #openstack-cinder | 03:18 | |
| *** pots1 has quit IRC | 03:21 | |
| *** mylu has quit IRC | 03:27 | |
| *** mylu has joined #openstack-cinder | 03:28 | |
| *** mylu has quit IRC | 03:29 | |
| *** mylu has joined #openstack-cinder | 03:31 | |
| *** mylu has quit IRC | 03:32 | |
| *** mylu has joined #openstack-cinder | 03:34 | |
| *** mylu has quit IRC | 03:35 | |
| *** dims has quit IRC | 03:35 | |
| *** IlyaG has quit IRC | 03:35 | |
| *** mylu has joined #openstack-cinder | 03:36 | |
| *** dims has joined #openstack-cinder | 03:42 | |
| *** IlyaG has joined #openstack-cinder | 03:45 | |
| *** EinstCrazy has joined #openstack-cinder | 03:46 | |
| *** EinstCrazy has quit IRC | 03:51 | |
| *** alonma has joined #openstack-cinder | 03:54 | |
| *** alonma has quit IRC | 03:58 | |
| *** cknight has joined #openstack-cinder | 03:59 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** alonma has joined #openstack-cinder | 04:01 | |
| *** haomaiwang has joined #openstack-cinder | 04:01 | |
| *** alonma has quit IRC | 04:05 | |
| *** alonma has joined #openstack-cinder | 04:07 | |
| *** dims has quit IRC | 04:08 | |
| *** itzdilip has joined #openstack-cinder | 04:09 | |
| *** alonma has quit IRC | 04:12 | |
| *** links has joined #openstack-cinder | 04:14 | |
| *** mylu has quit IRC | 04:15 | |
| *** mylu has joined #openstack-cinder | 04:16 | |
| *** mragupat has quit IRC | 04:22 | |
| *** david-lyle has quit IRC | 04:30 | |
| *** sheel_ has joined #openstack-cinder | 04:33 | |
| *** sheel_ is now known as sheel | 04:34 | |
| *** ByPasS has quit IRC | 04:35 | |
| *** winston-1 has joined #openstack-cinder | 04:36 | |
| *** jidar_ has joined #openstack-cinder | 04:38 | |
| *** ByPasS has joined #openstack-cinder | 04:38 | |
| *** winston-d has quit IRC | 04:38 | |
| *** jidar has quit IRC | 04:38 | |
| *** lennyb_ has quit IRC | 04:38 | |
| *** lennyb_ has joined #openstack-cinder | 04:38 | |
| *** jidar_ is now known as jidar | 04:38 | |
| openstackgerrit | Anthony Lee proposed openstack/cinder: LeftHand: Updating minimum client version https://review.openstack.org/267780 | 04:40 |
| *** salv-orlando has joined #openstack-cinder | 04:44 | |
| *** david-lyle has joined #openstack-cinder | 04:45 | |
| *** akerr is now known as akerr_away | 04:46 | |
| sheel | sheel: | 04:53 |
| sheel | oops...why m talking to my self... | 04:53 |
| *** shyama has joined #openstack-cinder | 04:55 | |
| *** salv-orlando has quit IRC | 04:56 | |
| *** mudassirlatif has joined #openstack-cinder | 04:58 | |
| *** sgotliv has joined #openstack-cinder | 05:00 | |
| *** haomaiwang has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-cinder | 05:01 | |
| *** bkumar has joined #openstack-cinder | 05:03 | |
| *** mudassirlatif has quit IRC | 05:07 | |
| *** mudassirlatif has joined #openstack-cinder | 05:08 | |
| *** alonma has joined #openstack-cinder | 05:08 | |
| *** chhavi has joined #openstack-cinder | 05:11 | |
| *** alonma has quit IRC | 05:13 | |
| *** alonma has joined #openstack-cinder | 05:15 | |
| *** alonma has quit IRC | 05:19 | |
| *** ankit_ag has joined #openstack-cinder | 05:21 | |
| *** alonma has joined #openstack-cinder | 05:24 | |
| *** mudassirlatif has quit IRC | 05:28 | |
| *** alonma has quit IRC | 05:28 | |
| *** alonma has joined #openstack-cinder | 05:30 | |
| *** alonma has quit IRC | 05:35 | |
| *** alonma has joined #openstack-cinder | 05:37 | |
| openstackgerrit | Ankit Agrawal proposed openstack/cinder: NFS snapshots https://review.openstack.org/147186 | 05:39 |
| *** alonma has quit IRC | 05:41 | |
| *** cknight has quit IRC | 05:42 | |
| *** alonma has joined #openstack-cinder | 05:43 | |
| ankit_ag | Hi all, can someone please help reviewing few of cinderclient patches https://review.openstack.org/#/q/topic:bp/return-request-id-to-caller | 05:47 |
| *** alonma has quit IRC | 05:47 | |
| *** IlyaG has quit IRC | 05:48 | |
| *** alonma has joined #openstack-cinder | 05:50 | |
| *** alonma has quit IRC | 05:54 | |
| bkumar | Hi all, anyone here using hpe 3par as a cinder backend ? | 05:54 |
| *** alonma has joined #openstack-cinder | 05:57 | |
| *** mylu has quit IRC | 05:58 | |
| *** mudassirlatif has joined #openstack-cinder | 05:58 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 06:01 | |
| *** alonma has quit IRC | 06:02 | |
| *** alonma has joined #openstack-cinder | 06:08 | |
| *** alonma has quit IRC | 06:13 | |
| *** mudassirlatif has quit IRC | 06:19 | |
| *** mudassirlatif has joined #openstack-cinder | 06:20 | |
| *** sgotliv has quit IRC | 06:28 | |
| *** mudassirlatif has quit IRC | 06:40 | |
| *** salv-orlando has joined #openstack-cinder | 06:48 | |
| *** IlyaG has joined #openstack-cinder | 06:49 | |
| *** savihou has joined #openstack-cinder | 06:50 | |
| *** IlyaG has quit IRC | 06:54 | |
| *** salv-orlando has quit IRC | 06:55 | |
| *** EinstCrazy has joined #openstack-cinder | 06:56 | |
| *** haomaiwa_ has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-cinder | 07:01 | |
| *** EinstCrazy has quit IRC | 07:02 | |
| *** chlong has quit IRC | 07:03 | |
| *** anshul has joined #openstack-cinder | 07:03 | |
| *** arecknag has joined #openstack-cinder | 07:04 | |
| *** smoriya has quit IRC | 07:07 | |
| *** alonma has joined #openstack-cinder | 07:09 | |
| openstackgerrit | Angus Lees proposed openstack/os-brick: Trivial rootwrap -> privsep replacement https://review.openstack.org/277224 | 07:12 |
| *** alonma has quit IRC | 07:14 | |
| *** belmoreira has joined #openstack-cinder | 07:14 | |
| *** alonma has joined #openstack-cinder | 07:15 | |
| openstackgerrit | Ankit Agrawal proposed openstack/cinder: NFS snapshots https://review.openstack.org/147186 | 07:15 |
| *** alonma has quit IRC | 07:20 | |
| *** alonma has joined #openstack-cinder | 07:21 | |
| *** alonma has quit IRC | 07:25 | |
| *** alonma has joined #openstack-cinder | 07:27 | |
| *** alonma has quit IRC | 07:32 | |
| *** alonma has joined #openstack-cinder | 07:33 | |
| *** alonma has quit IRC | 07:38 | |
| *** alonma has joined #openstack-cinder | 07:39 | |
| *** mudassirlatif has joined #openstack-cinder | 07:40 | |
| *** alonma has quit IRC | 07:44 | |
| *** alonma has joined #openstack-cinder | 07:46 | |
| *** alonma has quit IRC | 07:50 | |
| *** alonma has joined #openstack-cinder | 07:52 | |
| *** smoriya_afk has joined #openstack-cinder | 07:53 | |
| *** smoriya_afk is now known as smoriya | 07:53 | |
| *** alonma has quit IRC | 07:56 | |
| *** alonma has joined #openstack-cinder | 07:58 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-cinder | 08:01 | |
| *** alonma has quit IRC | 08:02 | |
| *** sinese has joined #openstack-cinder | 08:04 | |
| *** salv-orlando has joined #openstack-cinder | 08:07 | |
| *** rcernin has joined #openstack-cinder | 08:09 | |
| *** haomaiwang has quit IRC | 08:10 | |
| *** haomaiwa_ has joined #openstack-cinder | 08:11 | |
| *** salv-orlando has quit IRC | 08:12 | |
| *** dulek has joined #openstack-cinder | 08:15 | |
| *** alonma has joined #openstack-cinder | 08:20 | |
| *** alonma has quit IRC | 08:25 | |
| *** alonma has joined #openstack-cinder | 08:31 | |
| *** jistr has joined #openstack-cinder | 08:33 | |
| *** jistr is now known as jistr|sick | 08:33 | |
| *** alonma has quit IRC | 08:35 | |
| *** alonma has joined #openstack-cinder | 08:37 | |
| openstackgerrit | Philipp Marek proposed openstack/cinder: DRBD: Fix arguments for resize_volume DBus API call. https://review.openstack.org/277314 | 08:39 |
| *** alonma has quit IRC | 08:42 | |
| *** liverpooler has joined #openstack-cinder | 08:43 | |
| *** alonma has joined #openstack-cinder | 08:44 | |
| *** chlong has joined #openstack-cinder | 08:48 | |
| *** alonma has quit IRC | 08:49 | |
| *** alonma has joined #openstack-cinder | 08:52 | |
| *** nkrinner has joined #openstack-cinder | 08:53 | |
| *** bvivek has joined #openstack-cinder | 08:56 | |
| *** bvivek_ has joined #openstack-cinder | 08:56 | |
| *** alonma has quit IRC | 08:56 | |
| *** alonma has joined #openstack-cinder | 08:58 | |
| *** haomaiwa_ has quit IRC | 09:01 | |
| *** EinstCrazy has joined #openstack-cinder | 09:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 09:01 | |
| *** openstackgerrit has quit IRC | 09:02 | |
| *** openstackgerrit has joined #openstack-cinder | 09:03 | |
| openstackgerrit | Matan Sabag proposed openstack/cinder: Manage/unmanage volume in ScaleIO driver https://review.openstack.org/268344 | 09:03 |
| *** alonma has quit IRC | 09:03 | |
| *** EinstCrazy has quit IRC | 09:06 | |
| *** alonma has joined #openstack-cinder | 09:09 | |
| *** alonma has quit IRC | 09:14 | |
| *** lpetrut has joined #openstack-cinder | 09:14 | |
| *** alonma has joined #openstack-cinder | 09:15 | |
| *** alonma has quit IRC | 09:20 | |
| *** alonma has joined #openstack-cinder | 09:22 | |
| *** alonma has quit IRC | 09:26 | |
| *** isaacb has joined #openstack-cinder | 09:28 | |
| *** alonma has joined #openstack-cinder | 09:28 | |
| *** salv-orlando has joined #openstack-cinder | 09:31 | |
| *** aarefiev_ has quit IRC | 09:31 | |
| openstackgerrit | Ankit Agrawal proposed openstack/cinder: NFS snapshots https://review.openstack.org/147186 | 09:32 |
| *** aarefiev has joined #openstack-cinder | 09:32 | |
| *** alonma has quit IRC | 09:33 | |
| *** alonma has joined #openstack-cinder | 09:34 | |
| *** ildikov has quit IRC | 09:37 | |
| *** alonma has quit IRC | 09:38 | |
| *** alonma has joined #openstack-cinder | 09:49 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port objects unit tests to Python 3 https://review.openstack.org/272576 | 09:50 |
| *** mvk has joined #openstack-cinder | 09:50 | |
| *** alonma has quit IRC | 09:53 | |
| *** haomaiwa_ has quit IRC | 10:01 | |
| *** alonma has joined #openstack-cinder | 10:01 | |
| *** haomaiwang has joined #openstack-cinder | 10:01 | |
| *** alonma has quit IRC | 10:05 | |
| *** bvivek_ has quit IRC | 10:07 | |
| *** bvivek has quit IRC | 10:07 | |
| *** ildikov has joined #openstack-cinder | 10:10 | |
| *** alonma has joined #openstack-cinder | 10:10 | |
| *** alonma has quit IRC | 10:15 | |
| *** alonma has joined #openstack-cinder | 10:16 | |
| *** alonma has quit IRC | 10:20 | |
| *** alonma has joined #openstack-cinder | 10:23 | |
| openstackgerrit | Matan Sabag proposed openstack/cinder: Manage/unmanage volume in ScaleIO driver https://review.openstack.org/268344 | 10:23 |
| *** isaacb has quit IRC | 10:24 | |
| *** alonma has quit IRC | 10:27 | |
| *** ildikov has quit IRC | 10:28 | |
| *** ociuhandu has quit IRC | 10:30 | |
| *** alonma has joined #openstack-cinder | 10:36 | |
| *** ildikov has joined #openstack-cinder | 10:36 | |
| openstackgerrit | Philipp Marek proposed openstack/cinder: DRBD: Fix arguments for resize_volume DBus API call. https://review.openstack.org/277314 | 10:40 |
| *** salv-orl_ has joined #openstack-cinder | 10:40 | |
| *** alonma has quit IRC | 10:41 | |
| *** alonma has joined #openstack-cinder | 10:43 | |
| *** salv-orlando has quit IRC | 10:43 | |
| *** alonma has quit IRC | 10:47 | |
| *** tpsilva has joined #openstack-cinder | 10:49 | |
| *** alonma has joined #openstack-cinder | 10:49 | |
| *** e0ne has joined #openstack-cinder | 10:53 | |
| *** alonma has quit IRC | 10:54 | |
| openstackgerrit | Liucheng Jiang proposed openstack/cinder: Huawei: Implement v2 replication (managed) https://review.openstack.org/261246 | 10:55 |
| *** alonma has joined #openstack-cinder | 10:55 | |
| *** alonma has quit IRC | 10:59 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** 21WAA0U3N has joined #openstack-cinder | 11:01 | |
| *** alonma has joined #openstack-cinder | 11:01 | |
| *** alonma has quit IRC | 11:06 | |
| *** alonma has joined #openstack-cinder | 11:11 | |
| *** alonma has quit IRC | 11:15 | |
| *** akerr has joined #openstack-cinder | 11:17 | |
| *** alonma has joined #openstack-cinder | 11:17 | |
| *** akerr_away has quit IRC | 11:18 | |
| *** rcernin has quit IRC | 11:19 | |
| *** alonma has quit IRC | 11:21 | |
| *** rcernin has joined #openstack-cinder | 11:22 | |
| *** zhonghua has quit IRC | 11:22 | |
| *** zhonghua-lee has joined #openstack-cinder | 11:23 | |
| *** alonma has joined #openstack-cinder | 11:24 | |
| *** rcernin has quit IRC | 11:25 | |
| *** rcernin has joined #openstack-cinder | 11:26 | |
| *** alonma has quit IRC | 11:31 | |
| *** anshul has quit IRC | 11:32 | |
| *** alonma has joined #openstack-cinder | 11:32 | |
| *** jistr|sick has quit IRC | 11:37 | |
| *** alonma has quit IRC | 11:39 | |
| *** alonma has joined #openstack-cinder | 11:41 | |
| *** alonma has quit IRC | 11:45 | |
| *** alonma has joined #openstack-cinder | 11:47 | |
| *** anshul has joined #openstack-cinder | 11:47 | |
| *** alonma has quit IRC | 11:51 | |
| *** alonma has joined #openstack-cinder | 11:53 | |
| *** liverpooler has quit IRC | 11:53 | |
| *** vgridnev has joined #openstack-cinder | 11:55 | |
| *** alonma has quit IRC | 11:57 | |
| *** thurloat_isgone is now known as thurloat | 11:58 | |
| *** alonma has joined #openstack-cinder | 11:59 | |
| *** mvk has quit IRC | 12:00 | |
| *** 21WAA0U3N has quit IRC | 12:01 | |
| *** erlon has joined #openstack-cinder | 12:01 | |
| *** haomaiwang has joined #openstack-cinder | 12:01 | |
| *** liverpooler has joined #openstack-cinder | 12:02 | |
| *** vgridnev has quit IRC | 12:07 | |
| *** dims has joined #openstack-cinder | 12:07 | |
| *** alyson_ has joined #openstack-cinder | 12:09 | |
| *** vgridnev has joined #openstack-cinder | 12:13 | |
| *** liverpooler has quit IRC | 12:13 | |
| *** liverpooler has joined #openstack-cinder | 12:15 | |
| *** salv-orl_ has quit IRC | 12:18 | |
| *** isaacb has joined #openstack-cinder | 12:18 | |
| *** adrianofr has joined #openstack-cinder | 12:20 | |
| *** dims has quit IRC | 12:20 | |
| *** dims has joined #openstack-cinder | 12:22 | |
| *** timcl has joined #openstack-cinder | 12:23 | |
| *** ociuhandu has joined #openstack-cinder | 12:25 | |
| *** mvk has joined #openstack-cinder | 12:33 | |
| *** akerr has quit IRC | 12:34 | |
| *** smoriya has quit IRC | 12:36 | |
| *** smoriya_afk has joined #openstack-cinder | 12:37 | |
| *** smoriya_afk is now known as smoriya | 12:38 | |
| *** yhayashi has quit IRC | 12:39 | |
| *** krotscheck_dcm is now known as krotscheck | 12:39 | |
| *** smoriya has quit IRC | 12:41 | |
| *** nikeshm has joined #openstack-cinder | 12:41 | |
| nikeshm | i am back from marriage leaves :) | 12:41 |
| nikeshm | feel free to ping me if any need | 12:42 |
| *** salv-orlando has joined #openstack-cinder | 12:42 | |
| *** smoriya_afk has joined #openstack-cinder | 12:42 | |
| *** smoriya_afk is now known as smoriya | 12:42 | |
| *** mdavidson has joined #openstack-cinder | 12:43 | |
| *** bkumar has quit IRC | 12:45 | |
| *** alonma has quit IRC | 12:52 | |
| openstackgerrit | Petrut Lucian proposed openstack/os-brick: [WIP] Add Windows connectors https://review.openstack.org/272522 | 12:53 |
| openstackgerrit | Petrut Lucian proposed openstack/os-brick: WIP os-brick refactor get_connector_properties https://review.openstack.org/275943 | 12:53 |
| openstackgerrit | Ronen Mesonzhnik proposed openstack/cinder: Support backup import on another Storage database https://review.openstack.org/153969 | 12:55 |
| *** haomaiwang has quit IRC | 13:01 | |
| *** haomaiwang has joined #openstack-cinder | 13:01 | |
| *** EinstCrazy has joined #openstack-cinder | 13:05 | |
| *** krotscheck has quit IRC | 13:06 | |
| *** EinstCrazy has quit IRC | 13:09 | |
| *** xyang1 has joined #openstack-cinder | 13:16 | |
| *** krotscheck has joined #openstack-cinder | 13:18 | |
| *** links has quit IRC | 13:20 | |
| *** smoriya has quit IRC | 13:23 | |
| *** smoriya_afk has joined #openstack-cinder | 13:24 | |
| *** smoriya_afk is now known as smoriya | 13:24 | |
| *** laughterwym has joined #openstack-cinder | 13:25 | |
| *** smoriya has quit IRC | 13:28 | |
| scottda | e0ne: If you are around, the microversion patches are passing Jenkins now: https://review.openstack.org/#/c/224910 | 13:29 |
| scottda | e0ne: Thanks for all your help on that. | 13:29 |
| *** smoriya_afk has joined #openstack-cinder | 13:30 | |
| scottda | I'm going to address Patrick's comments later this morning. | 13:30 |
| *** smoriya_afk is now known as smoriya | 13:30 | |
| *** sgotliv has joined #openstack-cinder | 13:30 | |
| e0ne | scottda: hi. thanks for the update | 13:30 |
| scottda | Sure. I'll keep working on this. I'm optimistic that we can still get this in in Mitaka. | 13:31 |
| *** smoriya has quit IRC | 13:31 | |
| *** edmondsw has joined #openstack-cinder | 13:32 | |
| ankit_ag | Hi all, can someone please help reviewing few of cinderclient patches https://review.openstack.org/#/q/topic:bp/return-request-id-to-caller | 13:32 |
| *** smoriya_afk has joined #openstack-cinder | 13:33 | |
| *** smoriya_afk is now known as smoriya | 13:33 | |
| *** smoriya has quit IRC | 13:33 | |
| *** smoriya_afk has joined #openstack-cinder | 13:34 | |
| *** ygl has joined #openstack-cinder | 13:35 | |
| *** smoriya_afk is now known as smoriya | 13:35 | |
| ygl | Hi ALl | 13:35 |
| ygl | Hi All | 13:35 |
| scottda | e0ne: If you have time to look, please tell me what you think of Patrick's comments in / cinder/api/v3/router.py | 13:35 |
| ygl | i am having issues while creating bootable volumes | 13:35 |
| ygl | can anyone help me please | 13:35 |
| scottda | e0ne: It would be great to avoid copying all the v2 code to v3/ and the tests as well. I'm wondering if you or anyone knows of any issues with that . | 13:36 |
| *** smoriya has quit IRC | 13:36 | |
| ygl | can anyone help me please | 13:37 |
| *** smoriya_afk has joined #openstack-cinder | 13:37 | |
| *** smoriya_afk is now known as smoriya | 13:37 | |
| *** tongli has joined #openstack-cinder | 13:38 | |
| e0ne | scottda: I'll take a look later today | 13:38 |
| *** smoriya has quit IRC | 13:38 | |
| e0ne | scottda: added 'recheck' to run rally again. | 13:38 |
| ygl | can anyone help me please | 13:39 |
| scottda | ygl: Please be patient. We see your message, and more people will come online as the day goes on. Sorry, I cannot help at the moment. | 13:39 |
| *** smoriya_afk has joined #openstack-cinder | 13:39 | |
| *** smoriya_afk is now known as smoriya | 13:39 | |
| *** smoriya has quit IRC | 13:40 | |
| e0ne | scottda: did you see error in apache job? http://logs.openstack.org/10/224910/20/check/gate-cinder-dsvm-apache/de61521/logs/apache/c-api.txt.gz | 13:40 |
| scottda | e0ne: Nope. Looking now... | 13:40 |
| *** smoriya_afk has joined #openstack-cinder | 13:40 | |
| e0ne | scottda: I don't know if it is related or not | 13:41 |
| *** smoriya_afk is now known as smoriya | 13:41 | |
| *** smoriya has quit IRC | 13:42 | |
| *** ygl has quit IRC | 13:42 | |
| scottda | Looks likely to be related: | 13:42 |
| scottda | https://www.irccloud.com/pastebin/JcrDUzW5/ | 13:42 |
| *** smoriya_afk has joined #openstack-cinder | 13:42 | |
| *** smoriya_afk is now known as smoriya | 13:43 | |
| *** permalac has joined #openstack-cinder | 13:44 | |
| *** sgotliv has quit IRC | 13:45 | |
| openstackgerrit | Szymon Borkowski proposed openstack/cinder: Fix for glance_metadata during volume migration https://review.openstack.org/276747 | 13:49 |
| *** porrua has joined #openstack-cinder | 13:50 | |
| openstackgerrit | Petrut Lucian proposed openstack/os-brick: [WIP] Add Windows connectors https://review.openstack.org/272522 | 13:52 |
| *** akerr has joined #openstack-cinder | 13:52 | |
| openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor5 iSCSI driver unit tests https://review.openstack.org/271537 | 13:54 |
| *** sheel has quit IRC | 13:57 | |
| *** baumann has joined #openstack-cinder | 14:00 | |
| *** haomaiwang has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-cinder | 14:01 | |
| *** boichev has joined #openstack-cinder | 14:02 | |
| *** ankit_ag has quit IRC | 14:05 | |
| *** gouthamr has joined #openstack-cinder | 14:05 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Check for service existance in capabilities API https://review.openstack.org/271696 | 14:06 |
| *** rlrossit has joined #openstack-cinder | 14:06 | |
| *** baumann has quit IRC | 14:07 | |
| *** baumann has joined #openstack-cinder | 14:08 | |
| *** merooney has joined #openstack-cinder | 14:20 | |
| *** cfriesen has joined #openstack-cinder | 14:20 | |
| *** edtubill has joined #openstack-cinder | 14:23 | |
| *** anshul has quit IRC | 14:27 | |
| *** cknight has joined #openstack-cinder | 14:31 | |
| *** jungleboyj has joined #openstack-cinder | 14:31 | |
| *** esker has quit IRC | 14:31 | |
| *** knikolla has joined #openstack-cinder | 14:32 | |
| openstackgerrit | Szymon Borkowski proposed openstack/cinder: Fix for glance_metadata during volume migration https://review.openstack.org/276747 | 14:37 |
| *** diablo_rojo has joined #openstack-cinder | 14:37 | |
| *** laughterwym has quit IRC | 14:37 | |
| *** jgregor has joined #openstack-cinder | 14:38 | |
| *** salv-orlando has quit IRC | 14:41 | |
| *** superdan is now known as dansmith | 14:45 | |
| *** anshul has joined #openstack-cinder | 14:47 | |
| *** dustins has joined #openstack-cinder | 14:49 | |
| *** lprice1 has joined #openstack-cinder | 14:50 | |
| *** lprice has quit IRC | 14:51 | |
| smcginnis | nikeshm: Welcome back and congratulations! | 14:54 |
| *** salv-orlando has joined #openstack-cinder | 14:55 | |
| *** cknight has quit IRC | 14:55 | |
| *** pots is now known as Guest2836 | 14:56 | |
| *** pots2 is now known as pots | 14:56 | |
| *** EinstCrazy has joined #openstack-cinder | 14:57 | |
| *** pots1 has joined #openstack-cinder | 14:57 | |
| *** vgridnev has quit IRC | 14:59 | |
| *** haomaiwang has quit IRC | 15:01 | |
| *** krtaylor has joined #openstack-cinder | 15:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 15:01 | |
| *** EinstCrazy has quit IRC | 15:04 | |
| *** lcurtis has joined #openstack-cinder | 15:05 | |
| *** Sunkum has joined #openstack-cinder | 15:10 | |
| *** laughterwym has joined #openstack-cinder | 15:11 | |
| *** eharney has joined #openstack-cinder | 15:13 | |
| *** baumann has quit IRC | 15:15 | |
| *** ildikov has quit IRC | 15:16 | |
| *** mragupat has joined #openstack-cinder | 15:21 | |
| *** cknight has joined #openstack-cinder | 15:21 | |
| *** sgotliv has joined #openstack-cinder | 15:22 | |
| *** vgridnev has joined #openstack-cinder | 15:22 | |
| *** anshul has quit IRC | 15:26 | |
| *** baumann has joined #openstack-cinder | 15:27 | |
| *** laughterwym has quit IRC | 15:29 | |
| *** dulek has quit IRC | 15:31 | |
| *** sheel has joined #openstack-cinder | 15:35 | |
| *** mtanino has joined #openstack-cinder | 15:37 | |
| *** esker has joined #openstack-cinder | 15:38 | |
| *** esker has quit IRC | 15:39 | |
| openstackgerrit | Alex Meade proposed openstack/cinder-specs: User facing error messages https://review.openstack.org/274958 | 15:39 |
| *** esker has joined #openstack-cinder | 15:39 | |
| *** adrianofr has quit IRC | 15:40 | |
| *** rcernin has quit IRC | 15:42 | |
| sheel | e0ne:hi there | 15:43 |
| e0ne | sheel: hi | 15:43 |
| sheel | could you please review https://review.openstack.org/#/c/272232/ - needs final +2...in cinderclient | 15:43 |
| sheel | e0ne: its cinder counterpart is already released | 15:44 |
| *** arecknag has quit IRC | 15:44 | |
| diablo_rojo | patrickeast: A while back you offered to test this patch ( https://review.openstack.org/#/c/267085/ ) on Pure's stuff, is that still an option ? :) | 15:45 |
| *** arch-nemesis has joined #openstack-cinder | 15:46 | |
| patrickeast | diablo_rojo: yea I can test it out this afternoon | 15:46 |
| *** adrianofr has joined #openstack-cinder | 15:48 | |
| *** vincent_hou has joined #openstack-cinder | 15:48 | |
| sheel | e0ne:Thank you :) | 15:48 |
| e0ne | sheel: np | 15:49 |
| *** ildikov has joined #openstack-cinder | 15:49 | |
| diablo_rojo | patrickeast: Cool! that would be incredibly helpful. | 15:49 |
| *** links has joined #openstack-cinder | 15:49 | |
| *** crose has joined #openstack-cinder | 15:50 | |
| sheel | scottda: hi | 15:50 |
| scottda | sheel: Hi | 15:50 |
| sheel | scottda: I was looking at cli counterpart of microversioning.. | 15:51 |
| sheel | scottda: are you done with the implementation or need some help in it? | 15:51 |
| scottda | I have a patch up for the cinderclient: | 15:51 |
| *** lprice1 has quit IRC | 15:51 | |
| scottda | https://review.openstack.org/#/c/248163/ | 15:52 |
| *** lprice has joined #openstack-cinder | 15:52 | |
| scottda | But I need to update it for the new /v3 endpoint. I might not get to that until tomorrow. | 15:52 |
| *** lprice1 has joined #openstack-cinder | 15:55 | |
| *** lprice has quit IRC | 15:56 | |
| *** links has quit IRC | 15:57 | |
| sheel | ok | 15:57 |
| *** vgridnev has quit IRC | 15:59 | |
| *** haomaiwa_ has quit IRC | 16:01 | |
| *** haomaiwang has joined #openstack-cinder | 16:01 | |
| ildikov | scottda: hi | 16:01 |
| scottda | ildikov: Hi | 16:02 |
| ildikov | scottda: I just wanted to continue the discussion we started about the detach issue with multiattach | 16:02 |
| *** vgridnev has joined #openstack-cinder | 16:03 | |
| ildikov | scottda: I basicly wonder whether the db direction is viable or not | 16:03 |
| scottda | OK, can we wait for hemna to come online? | 16:03 |
| diablo_rojo | DuncanT: smcginnis: When you get a sec I know you mentioned in the Cinder meeting having opinions about this cross project spec :) https://review.openstack.org/#/c/226157/ | 16:04 |
| smcginnis | diablo_rojo: Thanks, I haven't looked at it in a while. I probably should. | 16:05 |
| smcginnis | I initially liked the idea of it, but I would be surprised if we were ever able to actually accomplish the goal. | 16:05 |
| openstackgerrit | Eric Harney proposed openstack/cinder: Improve logging to debug invalid "extra_specs" entries https://review.openstack.org/275909 | 16:06 |
| *** IlyaG has joined #openstack-cinder | 16:06 | |
| diablo_rojo | smcginnis: No problem :) it does seem like a lofty idea, but a good one if it could actually get accomplished. | 16:06 |
| ildikov | scottda: sure | 16:06 |
| smcginnis | Yeah, I think so too. I'm behind the idea, just have a lot of concern about how we would actually do it. | 16:07 |
| openstackgerrit | Petrut Lucian proposed openstack/os-brick: [WIP] Add Windows connectors https://review.openstack.org/272522 | 16:07 |
| ildikov | scottda: I just thought to understand what you were suggesting before discussing whether we actually do this or not, but I think you're right it's better to have hemna from the beginning :) | 16:08 |
| *** Sunkum has quit IRC | 16:08 | |
| jungleboyj | diablo_rojo: Just a heads up that there is an oslo.config release coming out with a fix for options being out of order. | 16:08 |
| jungleboyj | diablo_rojo: Not sure that that will impact any of your code but wanted to let you know. | 16:09 |
| scottda | ildikov: Yes, and I'll have to remember what I was suggesting :) | 16:09 |
| smcginnis | jungleboyj: Speaking of oslo... | 16:09 |
| scottda | ildikov: and jgriffith was in on that conversation IIRC | 16:09 |
| smcginnis | jungleboyj: Just a reminder I think you were going to look in to what the plan is for common. | 16:09 |
| jungleboyj | smcginnis: Yes. You are correct sir. | 16:09 |
| diablo_rojo | jungleboyj: It shouldn't since the list is just presorted by the script that generates the opts.py file and that gets sent to oslo config to do its thing with. | 16:10 |
| smcginnis | jungleboyj: :) | 16:10 |
| diablo_rojo | jungleboyj: Can you link me the review though? | 16:10 |
| jungleboyj | diablo_rojo: They are actually talking about all the different ways that the configs are handled. | 16:10 |
| ildikov | scottda: jgriffith_away had the suggestion earlier to try to export a target per attachment IIRC | 16:10 |
| jungleboyj | You could stop in openstack-meeting-alt and pimp your topic proposal. | 16:10 |
| *** IlyaG has quit IRC | 16:10 | |
| scottda | ildikov: Yes, but I don't think every driver can do that. | 16:11 |
| ildikov | scottda: yeap, I'm afraid so too | 16:11 |
| ildikov | this is why I wanted to see what other options we have | 16:11 |
| diablo_rojo | jungleboyj: Interesting. My topic proposal? | 16:11 |
| *** gouthamr has quit IRC | 16:11 | |
| scottda | ildikov: I think it's worth another discussion, here in IRC, with whomever is interested. Then we probably should capture all the ideas with pros and cons and sent it out to the ML, or some other way to carry the design forward. | 16:12 |
| jungleboyj | diablo_rojo: Not specifically, if you come over to that meeting you could mention it though. | 16:12 |
| *** sinese has quit IRC | 16:12 | |
| *** belmoreira has quit IRC | 16:12 | |
| diablo_rojo | jungleboyj: Thanks for the heads up. | 16:12 |
| jungleboyj | diablo_rojo: Of course. | 16:13 |
| *** isaacb has quit IRC | 16:15 | |
| ildikov | scottda: yeah, we really need to figure out something and I don't think pushing everything to Nova will work out | 16:15 |
| ildikov | scottda: so it would be great if we could elaborate all the options we have | 16:15 |
| scottda | ildikov: Yes, I think that's the way to go. Gather what we can in IRC, put them in a ML post and ask for any other ideas and feedback. Mabye that will help us get to consensus. | 16:16 |
| scottda | s/Mabye/Maybe | 16:16 |
| ildikov | scottda: hopefully | 16:16 |
| ildikov | scottda: I also think we need to disable multiattach support on the LVM driver until we don't have a solution implemented | 16:17 |
| scottda | ildikov: Yes, we need to figure out all the logistics and timing/release issues as well. | 16:18 |
| ildikov | scottda: yes, we need to be smart now otherwise we will not have this in Newton either | 16:18 |
| *** gouthamr has joined #openstack-cinder | 16:20 | |
| hemna | mornin | 16:24 |
| scottda | morning | 16:25 |
| hemna | sup | 16:26 |
| ildikov | hemna: hi :) | 16:27 |
| hemna | ildikov, heyas. how goes it ? | 16:27 |
| ildikov | hemna: with scottda we are about to discuss the detach issue with multiattach | 16:27 |
| hemna | ok | 16:27 |
| ildikov | hemna: what to solve where and how we are just waiting for everyone to gather :) | 16:28 |
| openstackgerrit | Matan Sabag proposed openstack/cinder: Support for consistency groups in ScaleIO driver https://review.openstack.org/269624 | 16:28 |
| hemna | so, the volume itself has a list of attachments | 16:28 |
| hemna | with instance_uuids | 16:29 |
| hemna | nova can go through those instance_uuids and find out if there are >1 on the same host where the detach is happening. | 16:29 |
| smcginnis | scottda: Go Broncos. | 16:29 |
| scottda | smcginnis: Thanks! | 16:29 |
| eharney | booo | 16:29 |
| hemna | if so, then don't call os-brick disconnect_volume ? | 16:29 |
| smcginnis | :) | 16:29 |
| hemna | eharney, :) | 16:29 |
| hemna | ildikov, that should work even w/o the host being set in the attachment | 16:30 |
| *** esp has joined #openstack-cinder | 16:30 | |
| hemna | the problem is | 16:30 |
| hemna | some Cinder drivers create a new target for every attach | 16:30 |
| scottda | hemna: But doesn't that depend on the driver? On whether or not the driver creates 1 export for each attach to the same host, or multiplexes them and keeps the same 1 export even if a new attach is created on that host? | 16:30 |
| ildikov | hemna: the two attachments on the same host is the problem | 16:30 |
| hemna | in which case you want to call os-brick's disconnect_volume. | 16:30 |
| scottda | hemna: Yeah, what you said! | 16:30 |
| hemna | scottda, correct. | 16:30 |
| *** vgridnev has quit IRC | 16:31 | |
| hemna | some create new targets | 16:31 |
| hemna | others don't | 16:31 |
| *** vgridnev has joined #openstack-cinder | 16:31 | |
| *** vgridnev has quit IRC | 16:31 | |
| scottda | It seems there is a basic question: Who (Nova or Cinder) should do the accounting and figure out when to disconnect the volume? | 16:31 |
| hemna | the connection_info for the volume might enable us to figure that out though | 16:31 |
| *** mragupat has quit IRC | 16:32 | |
| hemna | that's the information that comes back from initialize_connection. | 16:32 |
| *** bvivek_ has joined #openstack-cinder | 16:32 | |
| *** bvivek has joined #openstack-cinder | 16:32 | |
| hemna | (thinking out loud here) | 16:32 |
| *** mragupat has joined #openstack-cinder | 16:32 | |
| hemna | I think brick can give you a list of volume paths for the connection_info | 16:32 |
| hemna | as well as the wwn of the volume (for SCSI based volumes, iSCSI, FC, ?) | 16:33 |
| *** gouthamr has quit IRC | 16:33 | |
| scottda | I guess I could have included brick in the possibilities of whom does the accounting... | 16:33 |
| hemna | https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L367 | 16:34 |
| ildikov | I wanted to ask about that exactly whether we can figure out from os-brick who's connected to what | 16:34 |
| *** garthb has joined #openstack-cinder | 16:34 | |
| hemna | well all brick can do is give you a list of paths for a given connection_info | 16:34 |
| *** gouthamr has joined #openstack-cinder | 16:34 | |
| hemna | it can't do 'accounting' | 16:34 |
| hemna | I'm not sure this helps | 16:35 |
| hemna | dunno, just trying to chew through it | 16:35 |
| scottda | Maybe accounting is the wrong word. Perhaps it just takes logic to determine "Is this the last connection using this target" | 16:35 |
| hemna | hrmm | 16:36 |
| *** esp has quit IRC | 16:37 | |
| hemna | is it true that if the connection_info for each attachment is the same, then that the target is always the same? | 16:37 |
| hemna | I think so | 16:37 |
| scottda | It might help to think about these questions: 1) What is the best place to determine when to disconnect the volume from an architectural POV? 2) What's the best place from the POV of landing code (i.e. it might be 10x as hard in Nova)? 3) What's the best place given current implementation (Can we do this now?) | 16:37 |
| ildikov | basicly the question is that how we can check how many attchments are using the same target | 16:37 |
| hemna | in the case of 3PAR, we'd have a different LUN id for each target | 16:37 |
| hemna | target portal + iqn + LUN ID | 16:38 |
| hemna | is basically the iSCSI target | 16:38 |
| scottda | hemna: and 3par has a different export for each target, so that makes sense. | 16:38 |
| hemna | if those are all the same, then it's the same target | 16:38 |
| *** savihou has quit IRC | 16:38 | |
| hemna | FC is even simpler, I believe | 16:38 |
| hemna | so, I wonder if nova could get all the attachments on a given host | 16:39 |
| hemna | then loop through those and call cinder's initialize_connection | 16:39 |
| hemna | and compare those | 16:39 |
| hemna | if there is > 1 that's equal, then it's a shared target. | 16:39 |
| hemna | else, it's a unique target | 16:39 |
| hemna | I'm not sure how else to track it | 16:39 |
| hemna | especially when live migration comes into play | 16:40 |
| *** salv-orl_ has joined #openstack-cinder | 16:40 | |
| ildikov | hmm, it does not good to call out to Cinder that much | 16:40 |
| hemna | it would only have to be done in the multi-attach enabled case. | 16:40 |
| hemna | and only where you have more than 1 attachment on the same host. | 16:41 |
| hemna | I'd guess it would only take 2 calls to find out | 16:41 |
| ildikov | you mean to check on Nova side how many attachments we have on that host and then call out to Cinder? | 16:41 |
| hemna | as a Cinder driver will either export the same target N times, or 1 times. | 16:41 |
| hemna | it wouldn't be a mix | 16:41 |
| hemna | so I think it's safe to say that you would only have to call initialize_connection twice | 16:42 |
| hemna | even if there are 10 attachments on that same host | 16:42 |
| hemna | ildikov, yes | 16:42 |
| hemna | am I making any sense? | 16:42 |
| hemna | let me back up | 16:42 |
| scottda | OK, so we should determine if nova can get all the attachements on a given host, and then capture this as Possibility #1 | 16:42 |
| ildikov | twice you mean we would need to store what driver the volume is on? | 16:42 |
| hemna | say we have a volume that's attached 10 times to nova instances. | 16:43 |
| *** salv-orlando has quit IRC | 16:43 | |
| hemna | 4 of those attachments are on the host we are currently trying to detach. | 16:43 |
| hemna | nova loops through the attachments on the volume. | 16:43 |
| *** bill_az has joined #openstack-cinder | 16:43 | |
| hemna | finds those 4 attachments on the host it cares about | 16:43 |
| hemna | then for each of those, it calls Cinder's initialize_connection | 16:43 |
| hemna | to fetch the connection_info | 16:43 |
| hemna | each loop it compares the connection_info with the last target | 16:44 |
| *** mudassirlatif has quit IRC | 16:44 | |
| hemna | if they are equal, you know it's a shared target, and you are done. | 16:44 |
| hemna | if it's not a shared target, then you are done. | 16:44 |
| hemna | I don't think we have cinder drivers that do a mixed mode for every attachment | 16:44 |
| hemna | make sense ? | 16:44 |
| scottda | hemna: That makes sense | 16:44 |
| hemna | it's either a shared target, or it's not | 16:45 |
| hemna | and comparing the connection_info should tell you. | 16:45 |
| *** jgriffith_away is now known as jgriffith | 16:45 | |
| smcginnis | Reminder that we have through the end of next week for os-brick changes: http://releases.openstack.org/mitaka/schedule.html | 16:45 |
| hemna | as the target_portal(s), iqn, LUN id uniquely identify it. | 16:45 |
| hemna | heh | 16:45 |
| hemna | yah :(! | 16:45 |
| *** IlyaG has joined #openstack-cinder | 16:45 | |
| hemna | I'm not sure how else we can do this | 16:45 |
| hemna | without creating a new Cinder API | 16:46 |
| hemna | :( | 16:46 |
| scottda | hemna: What about the possibility of Cinder storing the connection_info when it is originally called with initialize_connection at first attach time? | 16:47 |
| hemna | that information will change during live migration. | 16:47 |
| hemna | and it would need to get updated | 16:47 |
| scottda | Yes, but we need a Cinder API to change that info during live migration anyway. | 16:47 |
| *** chris_morrell has quit IRC | 16:47 | |
| scottda | I think we decided that at the mid-cycle? To add that API to fix live migration? | 16:48 |
| hemna | we covered so many things, I can't keep it straight now | 16:48 |
| *** vivekd has joined #openstack-cinder | 16:48 | |
| hemna | I remember talking about storing the initiator info | 16:49 |
| hemna | but not the target info | 16:49 |
| openstackgerrit | Merged openstack/python-cinderclient: Bootable filter for listening volumes from CLI https://review.openstack.org/272232 | 16:49 |
| johnthetubaguy | scottda: storing the connection_info makes good sense to me, making sure you know whats needed on the backend if the compute is dead, etc | 16:49 |
| hemna | johnthetubaguy, yah I think we need that in the case of force detach | 16:50 |
| scottda | johnthetubaguy: Yes, we wanted that for a 'cinder force-detach' in case the Nova host disappears | 16:50 |
| hemna | where nova is dead and/or nova doesn't know anything about the attachment or the instance anymore. | 16:50 |
| johnthetubaguy | yeah, it feels the best way to go | 16:51 |
| scottda | So, given that we could make changes for Cinder to store more info, i.e. intiator, target, everything, it is possible for Cinder to have enough knowledge to make the decision as to when to detach. Could be done in Nova, or in Cinder | 16:51 |
| *** mragupat_ has joined #openstack-cinder | 16:51 | |
| *** jdurgin1 has joined #openstack-cinder | 16:52 | |
| hemna | scottda, in the case of multiattach detach | 16:52 |
| hemna | nova has to decide up front to call disconnect_volume | 16:52 |
| johnthetubaguy | think two nova's sharing a single cinder | 16:52 |
| hemna | Cinder's terminate_connection is always after that. | 16:52 |
| hemna | nova needs to decide to call it or not. | 16:52 |
| hemna | and I think the only way for Nova to determine that is my algorithm described above. | 16:53 |
| johnthetubaguy | hemna: we can call it, and it be a no op though, right? | 16:53 |
| scottda | hemna: For certain? I'm just thinking of the possibilities here, not trying to make a decsion. | 16:53 |
| hemna | johnthetubaguy, what specifically do you mean by 'it' in that case ? | 16:53 |
| hemna | I just want to be clear. | 16:53 |
| *** sinese has joined #openstack-cinder | 16:54 | |
| *** mragupat has quit IRC | 16:54 | |
| johnthetubaguy | hemna: I guess I mean terminate_connection? | 16:55 |
| *** bvivek_ has quit IRC | 16:55 | |
| *** bvivek has quit IRC | 16:55 | |
| hemna | yah that depends on the driver. | 16:55 |
| hemna | the important part is to call disconnect_volume or not. | 16:55 |
| johnthetubaguy | hemna: thats fine, if we know it might be needed, cinder can deal with the if anything needs to happen, I think? | 16:55 |
| johnthetubaguy | it feels bad that the API user needs to know what driver is being used, in general | 16:56 |
| *** xyang1 has quit IRC | 16:57 | |
| hemna | I think it's safe for nova to call terminate_connection | 16:57 |
| hemna | the cinder driver will have to cope with it. | 16:58 |
| hemna | but if the target is gone from the host (disconnect_volume), there isn't really a way to recover that. | 16:58 |
| hemna | a scsi rescan might recover an iSCSI/FC volume | 16:58 |
| ildikov | I would leave it on Cinder side to decide about detach if possible | 16:58 |
| hemna | but by then, it's too late, as i/o will have been borked. | 16:58 |
| ildikov | otherwise we need to store too much info in Nova to decide | 16:59 |
| ildikov | hemna: disconnect_volume removes the initiator, right? | 17:00 |
| hemna | is there a BDM/DB API in nova to find out which hosts instances are on ? | 17:00 |
| scottda | hemna: I think the idea we're trying to flesh out is, could Cinder store enough info to choose when to remove the target, regardless of when/how_many_times Nova calls disconnect_volume ? | 17:00 |
| hemna | I could probably throw together a WIP on nova to hack this | 17:00 |
| hemna | this = my algorithm I just came up with. | 17:00 |
| johnthetubaguy | I don't getting nova to store more data is a good idea | 17:00 |
| *** jgriffith is now known as jgriffith_away | 17:00 | |
| *** haomaiwang has quit IRC | 17:01 | |
| hemna | scottda, well, if we had the host in the attachment on cinder, Cinder has what it needs. | 17:01 |
| hemna | johnthetubaguy, I'm not asking nova to store any more than it already has | 17:01 |
| *** haomaiwang has joined #openstack-cinder | 17:01 | |
| scottda | I think we should list the possible solutions, pros and cons, and then start an ML list to try to get some consensus. It seems we can easily get stuck on "Nova should figure it out" vs. "Cinder should figure it out" | 17:01 |
| ildikov | johnthetubaguy: I'm on the same page as you, I wouldn't want to put this on Nova either | 17:02 |
| johnthetubaguy | scottda: yeah, I can't see the full picture, thats the issue here | 17:02 |
| *** permalac has quit IRC | 17:02 | |
| hemna | I'm pretty sure what I have in mind would work | 17:02 |
| ildikov | scottda: +1 | 17:02 |
| scottda | hemna: I believe it will work. But there are other possibilities. | 17:02 |
| johnthetubaguy | its not about it working right, its about having something thats going to be easy to maintain over time, across upgrades, etc | 17:02 |
| ildikov | hemna: it's not a question we can hack this out :) | 17:02 |
| scottda | And if we don't discuss all the possibilities, they will come up in review. | 17:03 |
| ildikov | hemna: but it would be good to find something let's say future proof, where Im not saying that this algorithm you're describing is not that, but at least myself I cannot decide at this point | 17:03 |
| hemna | ildikov, sure. I'm not sure this wouldn't be | 17:03 |
| hemna | but without trying it, I'm not sure what else to do. | 17:04 |
| *** jgriffith_away is now known as jgriffith | 17:04 | |
| *** apoorvad has joined #openstack-cinder | 17:04 | |
| *** salv-orl_ has quit IRC | 17:05 | |
| johnthetubaguy | for me, with a nova hat on, and also with my operator hat, I want simple interfaces that generally don't change much, between the components, that are easy to debug, i.e. no matter what the driver is, I really want the same set of API calls made. | 17:05 |
| *** salv-orlando has joined #openstack-cinder | 17:05 | |
| hemna | yah, agreed | 17:05 |
| ildikov | hemna: isn't there any way to figure out how many attachments are using the same target? | 17:05 |
| openstackgerrit | Adriano Freires Rosso proposed openstack/cinder: HNAS driver: Fix SSH and cluster_admin_ip0 bug https://review.openstack.org/277495 | 17:06 |
| hemna | I think what I have in mind provides that | 17:06 |
| ildikov | hemna: same for initiators I guess | 17:06 |
| hemna | it's just a matter of hacking it out and seeing what you guys think. | 17:06 |
| scottda | So, are 2 of the possibilities that we have now: #1 hemna idea #2 Change Nova to pass host + attachement to Cinder (recently backed out and needs fixing) and have Cinder make the decision | 17:06 |
| hemna | ildikov, that's exactly what my algorithm will do (pretty sure) | 17:06 |
| scottda | ? | 17:06 |
| hemna | ildikov, it compares the connection_info between 2 attaches | 17:06 |
| hemna | if they are the same, then it's a shared target | 17:06 |
| ildikov | but his happens on Nova side, or? | 17:07 |
| hemna | scottda, I don't think #2 helps multiattach detach case | 17:07 |
| hemna | it helps other things | 17:07 |
| hemna | and is still needed. | 17:07 |
| ildikov | scottda: when we were talking about storing target/attachment info in the db was that #2? | 17:07 |
| scottda | ildikov: No, I think that was some additional info that Cinder would need to start keeping. | 17:08 |
| ildikov | hemna: so when you say this compare it is Nova, who would do this, right? | 17:08 |
| hemna | nova would do: | 17:08 |
| hemna | 1) if multiattach volume | 17:08 |
| hemna | 2) get list of attachments on current host | 17:08 |
| hemna | 3) call cinder's initialize_connection on each of those | 17:08 |
| ildikov | scottda: so if that's possible that would be option #3, where we still need to figure out how not to remove the initiator from the host | 17:09 |
| hemna | 4) compare connection_info | 17:09 |
| hemna | if connection_info is same, then it's a shared target. | 17:09 |
| hemna | else, unique target | 17:09 |
| ildikov | what is initialize_connection for exactly? | 17:09 |
| hemna | if it's a shared target, don't call disconnect_volume. | 17:09 |
| hemna | if it's unique, call disconnect_volume | 17:09 |
| hemna | ildikov, initialize_connection returns the target information from a cinder backend | 17:10 |
| ildikov | as reading this list if I wouldn't be in context it would be pretty much misleading why we call initialize_connection for a detach | 17:10 |
| hemna | the target portal, iqn, LUN id of a target (for iSCSI) | 17:10 |
| ildikov | yeah, got it | 17:10 |
| hemna | those 3 things make up the unique target | 17:10 |
| ildikov | although the name is misleading in this case | 17:10 |
| hemna | ildikov, we call initialize_connection in detach for live migration :) | 17:10 |
| hemna | we = nova | 17:10 |
| hemna | to make sure we have the correct information to detach on the source side, after the volume has been attached on the destination host. | 17:11 |
| ildikov | Nova manages the volume attachment stuff in a pre_live_migration function and it is exactly what I had in mind | 17:11 |
| *** esker has quit IRC | 17:11 | |
| ildikov | hemna: remember when we were wondering how Nova manages live_migration? | 17:12 |
| hemna | yup | 17:12 |
| ildikov | hemna: if not necessary I wouldn't want to make anyone having the same circles :) | 17:12 |
| hemna | this is similar | 17:12 |
| hemna | it's just a decision nova has to make to call disconnect_volume or not. | 17:12 |
| ildikov | yeah, but when someone tries to figure out the code and change something things are getting messy :( | 17:13 |
| scottda | It seems the sticky issue is that Nova host needs to remove the initiator, and only Nova can do that. So Nova will have to figure out when this needs to be done, right? | 17:14 |
| *** dims has quit IRC | 17:14 | |
| hemna | ildikov, comments ? | 17:14 |
| scottda | ildikov: johnthetubaguy ^^^ | 17:14 |
| hemna | # we do this in the case of multiattach to make sure we don't remove a volume that's being used by other instances. | 17:14 |
| *** edtubill has quit IRC | 17:14 | |
| *** asselin has joined #openstack-cinder | 17:14 | |
| hemna | # change this or die. | 17:15 |
| ildikov | scottda: for the initiator that's unfortunately right :( | 17:15 |
| hemna | :P | 17:15 |
| johnthetubaguy | scottda: cinder could tell us if that initiator is needed, if we tell you which host the volume is on, I guess? | 17:15 |
| *** asselin__ has joined #openstack-cinder | 17:15 | |
| hemna | scottda, not the initiator, but the attached volume devices. | 17:15 |
| scottda | johnthetubaguy: That is possible, but currently volume_api.detach and volume_api.terminate_connection are asynchronouss | 17:15 |
| ildikov | johnthetubaguy: would that work with the order of the calls? | 17:15 |
| ildikov | scottda: we have a disconnect_volume call that goes to os-brick | 17:16 |
| *** xyang1 has joined #openstack-cinder | 17:16 | |
| ildikov | scottda: IIRC that's actually a third call here | 17:16 |
| scottda | ildikov: Yes, but Nova calls disconnect_volume. hemna Could Cinder call Brick.disconnect_volume? | 17:17 |
| scottda | johnthetubaguy: I guess we could add a Cinder API that could tell whether an initiator is needed, given the proper info.... | 17:18 |
| hemna | scottda, no | 17:18 |
| hemna | ildikov, that call to disconnect_volume is the main problem, of which I think I have a solution. | 17:18 |
| *** csky has joined #openstack-cinder | 17:18 | |
| ildikov | scottda: yeah, I meant that way that Nova calls it, but I'm not sure it calls it late enough to wait for Cinder to confirm it can be called | 17:18 |
| hemna | ildikov, nova calls disconnect_volume first | 17:19 |
| hemna | then calls terminate_connection, and detach | 17:19 |
| scottda | hemna: I think we can agree that you have a solution. I think it does not hurt to take some time to consider the alternatives, if there are any. | 17:19 |
| hemna | dutr | 17:19 |
| hemna | heh sure | 17:19 |
| scottda | I don't believe any Nova changes can land in Mitaka at this point. Am I right, ildikov ? | 17:19 |
| ildikov | scottda: no more code in Nova for Mitaka | 17:20 |
| *** leeantho has joined #openstack-cinder | 17:20 | |
| johnthetubaguy | bug fixes are fine | 17:20 |
| johnthetubaguy | but thats a fine line | 17:21 |
| ildikov | johnthetubaguy: pre-bug fixes also? :) | 17:21 |
| hemna | :P | 17:21 |
| scottda | Well, since multi-attach won't be turned on in the Nova API until Newton, there is need to think about any of this for Mitaka, bug fix or not. | 17:21 |
| hemna | isn't multi-attach disable though in Nova for M? | 17:21 |
| ildikov | it is not enable in Nova yet | 17:23 |
| scottda | The only reason to have any haste is if there were some changes on Cinder that were simple and safe, such as storing more info in the DB. Not possible if there's an API change (such as the reverted patch to pass host+instance_id) but if Cinder already has some important info, like connector info during initialize_connection call... | 17:23 |
| openstackgerrit | Petrut Lucian proposed openstack/os-brick: [WIP] Add Windows connectors https://review.openstack.org/272522 | 17:23 |
| ildikov | the question is what need to do on Cinder side to fix detach and will need to be done on Nova side now or at the beginning of Newton | 17:23 |
| *** mudassirlatif has joined #openstack-cinder | 17:24 | |
| ildikov | scottda: right and even the host info if we can have microversion support for it | 17:24 |
| hemna | scottda, I think the stumbling block I had with storing the connector was finding the right attachment at initialize_connection time. we don't have the instance_uuid at initialize_connection time. | 17:24 |
| *** sinese has quit IRC | 17:24 | |
| hemna | and also there is no cinder API for updating the attachment, which is needed due to live migration. | 17:25 |
| hemna | this is what prevented me from adding this at the start of M | 17:25 |
| hemna | :( | 17:25 |
| openstackgerrit | Cory Stone proposed openstack/cinder: Fix dynamic import of CONF.volume_api_class https://review.openstack.org/277504 | 17:25 |
| scottda | OK, so we need that update_attachment API and it's almost certainly not going to get in until Newton, yes? | 17:26 |
| hemna | yah | 17:26 |
| scottda | What's the next step? We've hemna proposal (which sounds viable and may be the right solution). We could stand to list alternatives, pros and cons, etc. Are we ready to take this to the ML, or should we find a time and venue to discuss further? | 17:27 |
| *** lpetrut has quit IRC | 17:28 | |
| hemna | I can write up a ML post about my proposal for nova trying to figure out if it should call disconnect_volume | 17:28 |
| hemna | I think that's 1 issue to hash out. | 17:28 |
| ildikov | yeah, that's definitely half of the issues | 17:29 |
| scottda | OK, thanks. We can add any other options to the post. Sound good ildikov ? | 17:29 |
| ildikov | I'm not sure how hard that is to figure out the attachments on the same host though... | 17:30 |
| *** sinese has joined #openstack-cinder | 17:30 | |
| hemna | ildikov, on the surface I don't think it's difficult | 17:30 |
| ildikov | scottda: if hemna writes up his either of us can chime in to cover the whole chain | 17:30 |
| *** mylu has joined #openstack-cinder | 17:30 | |
| hemna | I need a way to find out if an instance is on a host. | 17:30 |
| hemna | in nova | 17:31 |
| ildikov | yeah, so we need to go through the list of attachments the volume has in the volume info and check | 17:31 |
| hemna | that's the only piece i don't know how to do in nova | 17:31 |
| hemna | I'll have an instance_uuid | 17:31 |
| ildikov | I don't know how much this will be racy or not | 17:31 |
| hemna | is that on this host or not. | 17:31 |
| *** dims has joined #openstack-cinder | 17:32 | |
| ildikov | hemna: I don't know that either | 17:32 |
| hemna | hehe | 17:32 |
| hemna | ok off to a beating....bbiab. | 17:32 |
| ildikov | johnthetubaguy: we have a basic question ^^ :) | 17:32 |
| johnthetubaguy | it could be very racey I suspect | 17:33 |
| johnthetubaguy | but not 100% sure | 17:33 |
| ildikov | johnthetubaguy: you mean the process to identify whether we have two attachments from a list on the same host, right? | 17:33 |
| *** dulek has joined #openstack-cinder | 17:34 | |
| johnthetubaguy | ildikov: yeah, not sure there is a good non-racey way of getting that our side | 17:34 |
| ildikov | johnthetubaguy: yeah, seems tricky | 17:35 |
| *** vgridnev has joined #openstack-cinder | 17:35 | |
| ildikov | johnthetubaguy: although waiting for info from Cinder regarding call disconnect_volume or not does not seem any better either | 17:35 |
| *** porrua has quit IRC | 17:38 | |
| sheel | Dear All, | 17:39 |
| sheel | Please find some time to review https://review.openstack.org/#/c/274589/ | 17:39 |
| *** mvk has quit IRC | 17:39 | |
| jgriffith | patrickeast: ping | 17:39 |
| patrickeast | jgriffith: hey | 17:40 |
| jgriffith | patrickeast: hey | 17:40 |
| *** IlyaG has quit IRC | 17:40 | |
| jgriffith | patrickeast: so wanted to talk through some of the comments on the rep patch if you have a minute? | 17:40 |
| patrickeast | jgriffith: sounds good, I've got time but am on mobile so slow to type responses ;) | 17:41 |
| jgriffith | patrickeast: ahh... wait, I think I just found the answer to my own question :) | 17:41 |
| *** sgotliv has quit IRC | 17:41 | |
| jgriffith | patrickeast: haha | 17:41 |
| jgriffith | patrickeast: don't torture yourself :) I think I found my answer in your response to jungleboyj 's comment anyway | 17:41 |
| jgriffith | patrickeast: I'll get another (maybe final) patch up today and we'll go from there | 17:41 |
| jgriffith | Swanson: You on the other hand :) | 17:42 |
| Swanson | jgriffith, Me? | 17:42 |
| jgriffith | Swanson: yes.. *you* | 17:42 |
| jgriffith | :) | 17:42 |
| jgriffith | Swanson: To answer your question, *yes* the failover will need to return the backend-id we failed over to in the case of the driver picking | 17:42 |
| jgriffith | Swanson: I just hadn't gotten that far yet | 17:43 |
| jgriffith | :) | 17:43 |
| Swanson | jgriffith, does that come back to the driver? (And I just coded that moments ago.) | 17:43 |
| jgriffith | Swanson: so we want the driver to return that info... because then the manager will need to update that DB record | 17:43 |
| *** boris-42 has quit IRC | 17:43 | |
| jgriffith | Swanson: I'll get that code updated today | 17:44 |
| Swanson | jgriffith, Yep. So after I've failed over (which is just me going "Is that one alive? Yep, return that id.") I need that ID back. Do I have to poke the DB or is that available on init or something? | 17:44 |
| Swanson | jgriffith, and once I recognized this is post meteor failover this became way way simpler. :) | 17:45 |
| *** e0ne has quit IRC | 17:46 | |
| patrickeast | Swanson: you may wanna look at the wip change I put up for pures driver.. I took some guesses on those based on speculation | 17:46 |
| patrickeast | Like assuming on init we get the reply status and I'd for the backend | 17:46 |
| Swanson | patrickeast, oh, I see that up at the top of the review. | 17:47 |
| patrickeast | Some of that stuff we talked about at the mid cycle, but it wasn't implemted yet in the code | 17:47 |
| *** edtubill has joined #openstack-cinder | 17:47 | |
| akerr | smcginnis: when you get a free moment could you take a look at https://review.openstack.org/#/c/274741? | 17:47 |
| Swanson | patrickeast, Looks like you implemented what I was expecting. So, cool. Works for me. | 17:48 |
| patrickeast | Haha, just noticed android helped "correct" repl to reply and id to I'd | 17:50 |
| *** vincent_hou has quit IRC | 17:51 | |
| Swanson | patrickeast, I saw that. I'm not sure we need the status. If an ID is set I would assume a failover has occurred. | 17:51 |
| patrickeast | Yea, I use it to know if I should try to setup replication on init, if its failed over I won't try since the primary is assumed borked | 17:53 |
| hemna | back | 17:53 |
| patrickeast | Not 100% sure if we need to though | 17:53 |
| *** asselin__ has left #openstack-cinder | 17:56 | |
| *** IlyaG has joined #openstack-cinder | 17:58 | |
| *** haomaiwang has quit IRC | 18:01 | |
| *** haomaiwang has joined #openstack-cinder | 18:01 | |
| *** vivekd_ has joined #openstack-cinder | 18:03 | |
| *** chhavi has quit IRC | 18:04 | |
| *** vivekd has quit IRC | 18:05 | |
| *** jwcroppe has quit IRC | 18:05 | |
| *** vivekd_ is now known as vivekd | 18:05 | |
| *** dulek has quit IRC | 18:07 | |
| jgriffith | patrickeast: so you're assumption WRT return from replication_failover was 100% correct, Swanson see driver.py in the doc-string the returns param | 18:07 |
| jgriffith | patrickeast: also, YES we need to have the backend_id passed in to the driver on init. | 18:07 |
| jgriffith | patrickeast: otherwise driver won't know "what" to do | 18:07 |
| *** funeutron has joined #openstack-cinder | 18:08 | |
| *** shyama has quit IRC | 18:08 | |
| *** krtaylor has quit IRC | 18:08 | |
| *** jdurgin1 has quit IRC | 18:12 | |
| *** porrua has joined #openstack-cinder | 18:13 | |
| openstackgerrit | Anthony Lee proposed openstack/os-brick: Fix output returned from get_all_available_volumes https://review.openstack.org/276876 | 18:14 |
| *** ociuhandu has quit IRC | 18:16 | |
| *** ircuser-1 has joined #openstack-cinder | 18:16 | |
| *** ociuhandu has joined #openstack-cinder | 18:17 | |
| *** jwang_ has quit IRC | 18:17 | |
| *** jwang has joined #openstack-cinder | 18:18 | |
| *** krtaylor has joined #openstack-cinder | 18:20 | |
| *** diablo_rojo has quit IRC | 18:21 | |
| sheel | jungleboyj: hi there... | 18:23 |
| sheel | jungleboyj: need some eyes on https://review.openstack.org/#/c/274589/ for workflow | 18:23 |
| *** mylu has quit IRC | 18:24 | |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: 3PAR: Create consistency group from source CG https://review.openstack.org/274908 | 18:25 |
| *** vincent_hou has joined #openstack-cinder | 18:26 | |
| *** vincent_hou has quit IRC | 18:26 | |
| *** liverpooler has quit IRC | 18:28 | |
| openstackgerrit | Vivek Dhayaal proposed openstack/cinder: Support ZeroMQ messaging in cinder multibackend https://review.openstack.org/277113 | 18:29 |
| jungleboyj | sheel: Ok, will take a look. | 18:29 |
| sheel | jungleboyj: thank you .. | 18:30 |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: Remove old client version checks from 3PAR driver https://review.openstack.org/268346 | 18:30 |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: 3PAR: Create consistency group from source CG https://review.openstack.org/274908 | 18:31 |
| jungleboyj | sheel: Welcome. | 18:31 |
| sheel | jungleboyj:) | 18:32 |
| *** mylu has joined #openstack-cinder | 18:32 | |
| *** mylu has quit IRC | 18:33 | |
| *** savihou has joined #openstack-cinder | 18:34 | |
| *** diablo_rojo has joined #openstack-cinder | 18:39 | |
| *** bardia has joined #openstack-cinder | 18:39 | |
| krotscheck | Anyone around to refresh a +A on https://review.openstack.org/#/c/265409/ ? | 18:42 |
| krotscheck | smcginnis ^^ ? :) | 18:42 |
| smcginnis | krotscheck: Got it. | 18:43 |
| krotscheck | smcginnis: Awesome, thanks! | 18:43 |
| *** e0ne has joined #openstack-cinder | 18:44 | |
| e0ne | hemna: hi. are you around? | 18:47 |
| hemna | no | 18:47 |
| hemna | :P | 18:47 |
| *** daneyon has joined #openstack-cinder | 18:47 | |
| hemna | what's up | 18:47 |
| e0ne | :) | 18:47 |
| openstackgerrit | Adriano Freires Rosso proposed openstack/cinder: HNAS driver: Fix SSH and cluster_admin_ip0 bug https://review.openstack.org/277495 | 18:48 |
| e0ne | hemna: few questions according to https://review.openstack.org/#/c/271331/3/cinder/volume/drivers/hpe/hpe_xp_fc.py | 18:48 |
| hemna | ok | 18:48 |
| e0ne | hemna: I'm agree that your comments are reasonable | 18:48 |
| hemna | hrmm, that crap | 18:48 |
| mtanino | jgriffith: Hi, | 18:48 |
| *** lpetrut has joined #openstack-cinder | 18:48 | |
| *** mylu has joined #openstack-cinder | 18:48 | |
| hemna | so, I don't know why they need to do that TBH | 18:48 |
| e0ne | so, we've got 2 options (at least) | 18:48 |
| jgriffith | mtanino: hey ya | 18:48 |
| hemna | I'm not an XP expert | 18:48 |
| mtanino | jgriffith: I got a feedback from Gorka for this. https://review.openstack.org/#/c/271424/ | 18:49 |
| e0ne | hemna: erlon confirmed that they are not needed for his driver too | 18:49 |
| e0ne | but | 18:49 |
| e0ne | if we want to leave these methods, we need to: | 18:50 |
| e0ne | a) move code back from manager to driver:( | 18:50 |
| jgriffith | mtanino: yeah, so the only problem I have with Gorka's approach is the backport problem | 18:50 |
| mtanino | jgriffith: use DB data or use external saved data. Which one do you recommend? | 18:50 |
| e0ne | or b) create something like def _before_data_copy and def _after_data_copy in drivers | 18:50 |
| hemna | ugh | 18:51 |
| mtanino | jgriffith: I think so, and from my glance of the code, we need to fix for Nova side to store initiator on DB. | 18:51 |
| hemna | e0ne, both of those kinda suck | 18:51 |
| erlon | e0ne: are those the only drivers with the code left? | 18:51 |
| hemna | but I tend to like b) better. | 18:51 |
| e0ne | hemna: +1 | 18:51 |
| e0ne | erlon: yes, only 2 drivers are affected | 18:52 |
| jgriffith | mtanino: not sure I follow the problem on the initiator side of it? | 18:52 |
| openstackgerrit | Adriano Freires Rosso proposed openstack/cinder: HNAS driver: Fix SSH and cluster_admin_ip0 bug https://review.openstack.org/277495 | 18:52 |
| erlon | e0ne: for the Hitachi drivers I have double checked and the code is not touched. CI was passed as well | 18:52 |
| e0ne | the same for HP - this code is not executed at all | 18:53 |
| jgriffith | mtanino: so the most correct answer WRT targets is IMO to use the DB | 18:53 |
| jgriffith | mtanino: and then just do ensure_exports | 18:54 |
| e0ne | the questio is: is that code needed? | 18:54 |
| jgriffith | mtanino: BUT | 18:54 |
| e0ne | s/questio/question | 18:54 |
| jgriffith | I hate trying to backport db updates :) | 18:54 |
| mtanino | jgriffith: ok, so you recommend to use DB data to recreate iSCSI target. | 18:54 |
| mtanino | jgriffith: but? | 18:54 |
| jgriffith | mtanino: I'm looking... :) | 18:54 |
| jgriffith | Need to refresh my memory a bit here :) | 18:54 |
| mtanino | jgriffith: sure. my concern is how to store initiator info to DB... | 18:55 |
| erlon | e0ne: though CI results are not relevant in these patches, IIRC, the copy_volume_data was used during migration, which does not have tests in tempest | 18:55 |
| e0ne | :( | 18:55 |
| jgriffith | mtanino: well, right now we can't :) | 18:55 |
| *** daneyon_ has joined #openstack-cinder | 18:55 | |
| mtanino | jgriffith: It's passed from Nova's attach call. | 18:55 |
| e0ne | erlon, hemna: ok, let's try "option b" | 18:56 |
| jgriffith | mtanino: unless there's a hook in LIO that does it that I don't remember/know about | 18:56 |
| *** chris_morrell has joined #openstack-cinder | 18:56 | |
| jgriffith | mtanino: in "older" versions as well? | 18:56 |
| jgriffith | Ohhh | 18:56 |
| jgriffith | yes, that's right... that was a requirement for LIO | 18:56 |
| erlon | e0ne: I didnt get the point of this option | 18:56 |
| jgriffith | in order to build the access list | 18:57 |
| mtanino | jgriffith: I think so. | 18:57 |
| jgriffith | mtanino: yes, you're correct. | 18:57 |
| e0ne | erlon: make this code executable again | 18:57 |
| jgriffith | mtanino: so I'm not familiar with rtstool's "restore" command | 18:58 |
| jgriffith | mtanino: how does that work exactly? | 18:58 |
| mtanino | jgriffith: That's option restore iSCSI target from saved file. | 18:58 |
| *** daneyon has quit IRC | 18:58 | |
| *** salv-orl_ has joined #openstack-cinder | 18:58 | |
| jgriffith | mtanino: ok, so just like tgtadm... it has it's own persistence file? | 18:59 |
| erlon | e0ne: hmm, that looks bad, you have a code that for some reason, stopped being called, the driver keeps, without anyone noticing that, for 1/2 releases, then you start calling that again | 18:59 |
| mtanino | jgriffith: Current LIO target save current configuration to persistenfile when we change someting to target configuration. | 18:59 |
| mtanino | jgriffith: yes, I think it's same as current tgtd behaviour. | 19:00 |
| jgriffith | I think that's fine to be honest | 19:00 |
| *** haomaiwang has quit IRC | 19:01 | |
| erlon | e0ne: the code lost the meaning after the changes | 19:01 |
| mtanino | jgriffith: like this. https://github.com/openstack/cinder/blob/master/cinder/volume/targets/lio.py#L127 | 19:01 |
| *** nkrinner has quit IRC | 19:01 | |
| jgriffith | mtanino: yeah, so that seems fine to me | 19:01 |
| erlon | e0ne: hemna: i think vincent_hou did that in the migration refactor patches | 19:01 |
| *** haomaiwa_ has joined #openstack-cinder | 19:01 | |
| *** salv-orlando has quit IRC | 19:01 | |
| jgriffith | mtanino: I'm not completely clear why Gorka prefers a DB entry on this one | 19:01 |
| e0ne | erlon, hemna: ok. now I see only one solution: get CI working to test my patch | 19:02 |
| erlon | e0ne: hemna: may be he could better explay why he did so | 19:02 |
| e0ne | it was jbernard's patch: https://review.openstack.org/#/c/187270/24 | 19:02 |
| mtanino | jgriffith: So I guess there is a concern that someone changes the external saved file or the file is not correctly saved or etc? | 19:03 |
| eharney | the external LIO configuration being saved or not depends on how target.service is setup on the system... it may reload things at reboot or may not | 19:03 |
| *** EinstCrazy has joined #openstack-cinder | 19:04 | |
| jgriffith | eharney: ok, that's fair.. but that sort of thing seems like a problem with "any" config :) | 19:04 |
| jgriffith | eharney: mtanino My vote was that the patch proposed is fine IMO, and good for backports, with the caveat that there might be a better long-term fix by adding the db entry | 19:05 |
| jgriffith | eharney: mtanino I updated in gerritt | 19:06 |
| mtanino | jgriffith: Thank you. I am going to talk Gorka again. | 19:06 |
| jgriffith | Maybe I'm completely wrong, but seems reasonable to make fwd progress | 19:06 |
| *** EinstCrazy has quit IRC | 19:09 | |
| e0ne | hemna, smcginnis: who is maintainer of HPE XP driver? | 19:10 |
| e0ne | DuncanT: ^^ | 19:10 |
| e0ne | I didn' see CI for it and it looks broken | 19:10 |
| smcginnis | Vedams? | 19:10 |
| *** dramakri has joined #openstack-cinder | 19:10 | |
| erlon | e0ne: hard to know if that (jbernard) broke migration on those drivers or others. We needed migration tests running. | 19:10 |
| smcginnis | https://wiki.openstack.org/wiki/ThirdPartySystems/XP_Storage_CI | 19:11 |
| smcginnis | ^^ That says asselin_ | 19:11 |
| asselin | what's up? | 19:12 |
| erlon | smcginnis: the CI is running, but there's no migration tests | 19:12 |
| e0ne | smcginnis: thanks | 19:12 |
| * asselin updates | 19:12 | |
| smcginnis | asselin: Questions on the XP CI. Are you still maintaining that? | 19:12 |
| erlon | smcginnis: the migration tests are -2, becouse tempest guys want to see that running in CIs before they approve | 19:12 |
| e0ne | asselin: IMO, HPEXPFCDriver is broken and CI is not reporting:( | 19:13 |
| asselin | no | 19:13 |
| smcginnis | asselin: This needs to be updated then: https://wiki.openstack.org/wiki/ThirdPartySystems/XP_Storage_CI | 19:13 |
| asselin | yup updating now | 19:13 |
| jbernard | e0ne: eh? | 19:13 |
| smcginnis | erlon: We've had tempest issues like that before. | 19:13 |
| e0ne | https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/hpe/hpe_xp_fc.py#L38 - it imports class which is not exists | 19:14 |
| hemna | e0ne, nestor fernandez is the mx for the XP driver | 19:15 |
| hemna | e0ne, I emailed him earlier asking him to join the cinder channel | 19:15 |
| hemna | he's supposed to be in here daily.....fwiw. | 19:15 |
| e0ne | hemna: thanks | 19:15 |
| erlon | smcginnis: you mean tests that tempest team does not approve? | 19:15 |
| smcginnis | erlon: Yeah. | 19:15 |
| asselin | yeah, you should be able to contact him via that e-mail address | 19:16 |
| smcginnis | erlon: After discussion at the midcycle I started looking into adding in-tree tempest tests to get around this. | 19:16 |
| erlon | smcginnis: it looks like the chicken/egg problem :/ | 19:16 |
| smcginnis | erlon: But they have been even less supportive on that as well. | 19:16 |
| e0ne | fernnest: hi | 19:16 |
| *** jgriffith is now known as jgriffith_away | 19:16 | |
| fernnest | e0ne, hi | 19:17 |
| e0ne | I've got a question about xp-cinder-ci | 19:17 |
| erlon | jbernard: do you recall this patch? https://review.openstack.org/#/c/187270/24/cinder/volume/manager.py | 19:17 |
| fernnest | e0ne, yes? | 19:17 |
| asselin | fernnest, hi, please add your irc handle here in Contact Information: https://wiki.openstack.org/wiki/ThirdPartySystems/XP_Storage_CI | 19:17 |
| erlon | jbernard: do you remember what backends you have tested the migration? | 19:17 |
| jbernard | of course, i wrote it | 19:18 |
| e0ne | fernnest: I didn't see any results from that CI | 19:18 |
| e0ne | fernnest: and driver seems to be broken | 19:18 |
| jbernard | e0ne: hmm, give me a sec | 19:18 |
| fernnest | asselin, will do | 19:18 |
| jbernard | erlon: i made notes at some point | 19:18 |
| jbernard | erlon: ah yes, i put those notes in the commit message | 19:19 |
| jbernard | erlon: what is the problem? | 19:20 |
| erlon | jbernard: hmm, ok, the problem is that you remove the call for driver.copy_volume_data(), but, today still are some drivers that uses that | 19:21 |
| erlon | jbernard: https://review.openstack.org/#/c/271331/ | 19:21 |
| e0ne | fernnest: I don't understan how it https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/hpe/hpe_xp_fc.py#L38 can work | 19:21 |
| jbernard | oh, we should discuss this | 19:22 |
| *** mylu has quit IRC | 19:22 | |
| fernnest__ | e0ne, lemme look | 19:22 |
| e0ne | ok, waiting | 19:22 |
| openstackgerrit | xing-yang proposed openstack/cinder: Update db in CGSnapshot create https://review.openstack.org/271054 | 19:23 |
| erlon | jbernard: what seems to me is that, your code does the same thing, copy the volume data, but it removes the ability of a driver to do any optiomization | 19:24 |
| jbernard | erlon: how so exactly?" | 19:24 |
| erlon | jbernard: ?? | 19:25 |
| fernnest__ | e0ne, there are files that are pulled from github that implement that module. | 19:26 |
| jbernard | the patch is not particularly intrusive, the existing flow of execution remains for existing driver, and drivers the return an file object fall over to file-based copy | 19:26 |
| e0ne | fernnest__: could you please give me a link? | 19:26 |
| fernnest__ | sure | 19:26 |
| jbernard | driver-optimized migration is untouched | 19:26 |
| fernnest__ | e0ne, one sec | 19:26 |
| erlon | jbernard: which is not done in case of Hitachi driver, it only calls, the default function defined in baseVD driver | 19:27 |
| hemna | damn | 19:27 |
| hemna | Pure FC CI failed in 7 seconds | 19:27 |
| e0ne | faill fast:) | 19:27 |
| hemna | fail fast, and fail often. | 19:27 |
| fernnest__ | e0ne, git clone https://github.com/hpxp/hpxpclient | 19:27 |
| hemna | patrickeast, ping | 19:28 |
| hemna | :( | 19:28 |
| hemna | patrickeast, error: internal error: unable to execute QEMU command 'device_add': Device initialization failed. | 19:28 |
| hemna | pewp | 19:28 |
| patrickeast | Lame | 19:28 |
| hemna | HBA is probably Offline is my guess | 19:29 |
| hemna | http://openstack-logs.purestorage.com/76/276876/2/check/PureFCDriver-tempest-dsvm-volume-multipath-brick/7e0a7be/console.html | 19:29 |
| patrickeast | Try a recheck, I'll take a look in a bit | 19:29 |
| hemna | ok | 19:29 |
| e0ne | fernnest__: why it is not in cinder tree or at least in pypi? | 19:29 |
| hemna | I'm just baby sitting a bunch of os-brick stuff right now to try and get them to land this week | 19:29 |
| fernnest__ | e0ne, the developer for this is Hitachi, I've been trying to get them to submit the hidden files into the cinder tree since day 1. | 19:31 |
| erlon | fernnest__: you mean the code in github? | 19:32 |
| *** akshai has joined #openstack-cinder | 19:32 | |
| e0ne | fernnest__: it's crazy | 19:35 |
| *** esker has joined #openstack-cinder | 19:37 | |
| e0ne | fernnest__, smcginnis: in such case, we've got a driver in cinder which has not stable ci and kind of "hidden" code | 19:37 |
| *** esker has quit IRC | 19:37 | |
| e0ne | fernnest__: how can I find that github repo? where is it documented? | 19:37 |
| *** esker has joined #openstack-cinder | 19:38 | |
| fernnest__ | e0ne, agreed...so here's the story, XP is OEM'ed Hitachi array. Hitachi provides the driver. We asked them to get all the files in the cinder tree. They are doing first the HSBD versions https://review.openstack.org/#/c/271763/ and then copy the files to the HPE_XP dir | 19:39 |
| *** mylu has joined #openstack-cinder | 19:39 | |
| smcginnis | e0ne, fernnest__: The code issue isn't ideal, but the biggest thing is CI. | 19:41 |
| e0ne | agree | 19:41 |
| smcginnis | e0ne, fernnest__: Is we don't have a good CI reporting results, we will need to pull the driver. | 19:41 |
| smcginnis | *If we | 19:41 |
| fernnest__ | smcginnis,e0ne: I see the CI running correctly | 19:41 |
| *** mylu_ has joined #openstack-cinder | 19:41 | |
| fernnest__ | smcginnis,e0ne: wheree are you looking for failed CI? | 19:42 |
| smcginnis | Oh, that "refactor" patch. :| | 19:42 |
| fernnest__ | smcginnis,e0ne: yup | 19:42 |
| *** mylu has quit IRC | 19:42 | |
| e0ne | fernnest__: I've found you CI results now | 19:42 |
| fernnest__ | smcginnis,e0ne: they want to get that in so that they can then turn around and do another submit of *nearly* identical changes | 19:43 |
| fernnest__ | smcginnis,e0ne: the only changes would be the parameter names and file names. | 19:43 |
| fernnest__ | e0ne, where are you looking? | 19:43 |
| e0ne | http://ci-watch.tintri.com/project?project=cinder&time=7+days | 19:43 |
| smcginnis | fernnest__: If they are just wholesale copying the code and changing names, I would recommend doing what dothill did. | 19:43 |
| fernnest__ | smcginnis:I'm all ears! | 19:44 |
| * smcginnis looks for links... | 19:44 | |
| e0ne | http://ci-watch.tintri.com/project?project=cinder - only 5 results for the last 24 hours | 19:44 |
| smcginnis | fernnest__: They have a few different OEMs. | 19:45 |
| smcginnis | fernnest__: So there is one full "real" driver. | 19:45 |
| smcginnis | fernnest__: Then a OEMd versions that inherit from the base one. | 19:45 |
| smcginnis | fernnest__: Makes the additional drivers really small: https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/lenovo/lenovo_fc.py | 19:45 |
| fernnest__ | e0ne: it is slow | 19:45 |
| smcginnis | fernnest__: https://github.com/openstack/cinder/tree/master/cinder/volume/drivers/dothill | 19:45 |
| e0ne | fernnest__: does it support migration tests? | 19:46 |
| fernnest__ | e0ne: I'm working on a fix to CI env to speed things up. | 19:46 |
| smcginnis | https://github.com/openstack/cinder/tree/master/cinder/volume/drivers/lenovo | 19:46 |
| *** ociuhandu has quit IRC | 19:46 | |
| smcginnis | fernnest__: The OEM thing caused some discussion in channel and during a meeting as to whether to allow that. | 19:46 |
| smcginnis | fernnest__: But in the end, the one common code base is better than a bunch of copy/pasted code. | 19:47 |
| e0ne | smcginnis: +1 | 19:47 |
| fernnest__ | smcginnis: code shared by two drivers but not generic enough for all/most drivers would go where? | 19:47 |
| smcginnis | fernnest__: In this case I would probably have the "base" code in the hitachi folder, then have the XP driver just inherit from that driver. | 19:48 |
| smcginnis | fernnest__: Then override or add hooks for "branding" or any version specific changes for the HPE XP driver. | 19:48 |
| smcginnis | fernnest__: With the example above, DotHill is the base driver that has all functionality. | 19:49 |
| smcginnis | fernnest__: Then the Lenovo and other OEM'd versions of it just are very small ones that inherit from it. | 19:50 |
| smcginnis | fernnest__: So Lenovo and HP MSA are just OEMs of DotHill it appears: https://github.com/openstack/cinder/tree/master/cinder/volume/drivers/san/hp | 19:51 |
| fernnest__ | smcginnis: so HPE driver would import from HBSD directory the lower levels of the code. Then just override whatever needs to be overridden (config parms, that sort of thing) | 19:51 |
| smcginnis | fernnest__: Yep, basically at a high level that should be it. | 19:51 |
| smcginnis | fernnest__: Always some finer details to work through, but then at least it's not just a full copy of all the code. | 19:52 |
| smcginnis | fernnest__: With the need to know to fix in one place if you fix in the other. | 19:52 |
| smcginnis | *With avoiding the need | 19:52 |
| fernnest__ | smcginnis: big difference ;) | 19:52 |
| *** sinese has quit IRC | 19:53 | |
| *** sinese_ has joined #openstack-cinder | 19:53 | |
| jbernard | e0ne: pre/post routines would work | 19:53 |
| *** salv-orl_ has quit IRC | 19:53 | |
| e0ne | jbernard: I'll try it in a next patch | 19:53 |
| openstackgerrit | abhiram moturi proposed openstack/cinder: Zfssaiscsi driver should not use 'default' initiator group https://review.openstack.org/238635 | 19:53 |
| fernnest__ | smcginnis: let me study the MSA/OEM/Lenovo code and convince Hitachi...Can I get back to you if/when I have more questions? | 19:53 |
| *** kfarr has joined #openstack-cinder | 19:54 | |
| jbernard | e0ne: it looks like hitachi needs only discard, so just post might be enough | 19:54 |
| smcginnis | fernnest__: Definitely! | 19:54 |
| smcginnis | fernnest__: Thanks for looking into it. | 19:54 |
| fernnest__ | smcginnis: thanks, really appreciated. Can we make the review of that patch incumbent on what we've discussed? I need the leverage. | 19:54 |
| smcginnis | fernnest__: Whatever I can do to help, just let me know. | 19:55 |
| smcginnis | fernnest__: I'm behind anything to get rid of code duplication. | 19:55 |
| fernnest__ | smcginnis: Concur, I'll go get busy then. | 19:55 |
| smcginnis | fernnest__: Awesome, thanks! | 19:56 |
| *** tongli has quit IRC | 19:57 | |
| *** akshai has quit IRC | 19:57 | |
| *** haomaiwa_ has quit IRC | 20:01 | |
| *** haomaiwang has joined #openstack-cinder | 20:01 | |
| *** mylu_ has quit IRC | 20:02 | |
| *** akshai has joined #openstack-cinder | 20:02 | |
| *** vgridnev has quit IRC | 20:05 | |
| *** ociuhandu has joined #openstack-cinder | 20:05 | |
| *** jgriffith_away is now known as jgriffith | 20:13 | |
| *** cknight has quit IRC | 20:13 | |
| *** esp has joined #openstack-cinder | 20:14 | |
| *** cknight has joined #openstack-cinder | 20:15 | |
| *** mylu has joined #openstack-cinder | 20:20 | |
| jgriffith | bswartz: ping | 20:21 |
| *** esp has quit IRC | 20:21 | |
| *** akshai has quit IRC | 20:24 | |
| *** mylu has quit IRC | 20:26 | |
| *** salv-orlando has joined #openstack-cinder | 20:27 | |
| *** edtubill_ has joined #openstack-cinder | 20:28 | |
| mtanino | smcginnis: sorry for several times, could you revisit this metadata support? https://review.openstack.org/#/c/258649/ | 20:28 |
| smcginnis | mtanino: Sure, should be able to in a few. | 20:28 |
| *** mylu has joined #openstack-cinder | 20:28 | |
| mtanino | smcginnis: I'd appreciate it. | 20:28 |
| *** edtubill has quit IRC | 20:30 | |
| *** dramakri has quit IRC | 20:34 | |
| *** salv-orlando has quit IRC | 20:36 | |
| *** akshai has joined #openstack-cinder | 20:36 | |
| *** vivekd_ has joined #openstack-cinder | 20:37 | |
| *** mylu has quit IRC | 20:38 | |
| mtanino | smcginnis: Thank you. I am going to talk with DuncanT too, but usually I can't find him... | 20:38 |
| mtanino | time zone ;) | 20:39 |
| DuncanT | mtanino: I'm here now for a short while, as it happens :-) | 20:39 |
| mtanino | DuncanT: oh, you there! | 20:39 |
| *** vivekd has quit IRC | 20:40 | |
| mtanino | DuncanT: so about a glance metadata support patch for Cinder,https://review.openstack.org/#/c/258649/ | 20:40 |
| *** vivekd_ is now known as vivekd | 20:40 | |
| mtanino | DuncanT: I approached all comments from you and other reviewers, so please revisit if you have a time. | 20:41 |
| *** leeantho has quit IRC | 20:42 | |
| mtanino | DuncanT: And then, I'll push glance side patch | 20:43 |
| *** leeantho has joined #openstack-cinder | 20:43 | |
| DuncanT | mtanino: Sure, looking now | 20:43 |
| DuncanT | mtanino: I was rather worried that most of the CIs failed | 20:44 |
| *** leeantho has quit IRC | 20:44 | |
| *** leeantho_ has joined #openstack-cinder | 20:44 | |
| mtanino | DuncanT: I see. Let me recheck vendor CIs | 20:45 |
| *** lpetrut has quit IRC | 20:46 | |
| DuncanT | mtanino: Lots seem to fail with "aborted: Block Device Mapping is Invalid" which looks suspicious | 20:46 |
| mtanino | DuncanT: Which one are you reffering now? | 20:47 |
| DuncanT | solidfire and two others at random | 20:49 |
| *** leeantho_ has quit IRC | 20:49 | |
| DuncanT | Some failed to build with mirror problems though, so it might be unrelated | 20:49 |
| *** chris_morrell has quit IRC | 20:49 | |
| DuncanT | Solidfire is usually pretty good though | 20:49 |
| *** chris_morrell has joined #openstack-cinder | 20:49 | |
| DuncanT | I'll leave the review window open anyway, and check again in the morning, see how the rechecks have gone | 20:50 |
| jgriffith | DuncanT: mtanino I just hit recheck on SF; there were some issues with boot from volume that week | 20:50 |
| jgriffith | DuncanT: mtanino in general | 20:50 |
| *** dims_ has joined #openstack-cinder | 20:51 | |
| mtanino | DuncanT: I pushed rechck. I'm going to check CIs result again too. Thank you for the advice. | 20:51 |
| mtanino | jgriffith: thank you. | 20:51 |
| DuncanT | mtanino: If there's a reasonable number of passes in the morning, the patch itself looks good | 20:51 |
| jgriffith | DuncanT: mtanino You'll note if you look at the SF logs under n-cpu.... | 20:52 |
| jgriffith | DuncanT: mtanino it's the problem with that incompatable change that was merged to Cinder and Nova for multi-attach | 20:52 |
| *** dims has quit IRC | 20:52 | |
| jgriffith | DuncanT: mtanino it's possible that you will need to rebase the cinder patch though | 20:52 |
| mtanino | DuncanT: jgriffith Was the patch reverted? | 20:53 |
| jgriffith | DuncanT: mtanino BTW, here's the signature for that in the n-cpu logs: http://goo.gl/VrURw6 | 20:53 |
| DuncanT | jgriffith: thanks. I didn't investigate beyond the console log | 20:54 |
| mtanino | jgriffith: ok Thank you | 20:54 |
| *** leeantho has joined #openstack-cinder | 20:54 | |
| jgriffith | mtanino: yeah... sadly some CI's are running a rebase during check phase, while others (sos-ci) are not | 20:54 |
| *** dramakri has joined #openstack-cinder | 20:54 | |
| jgriffith | mtanino: so those that do a rebase will pass, and don't actually test compatability of things | 20:55 |
| jgriffith | mtanino: I don't know which is better or worse... but at least this pointed out that we were breaking compatbility for old-cinders and new Nova's | 20:55 |
| mtanino | jgriffith: DuncanT I see. If my patch still have some CIs issue, I'm gotin to rebase and try again. | 20:56 |
| jgriffith | mtanino: sounds good | 20:56 |
| mtanino | jgriffith: hmm, I'm not sure to.. which one is good.. | 20:56 |
| jgriffith | mtanino: :) | 20:56 |
| patrickeast | jgriffith: isn't it only compatability between those tip of tree points as opposed to the whole version though? the one that does a merge is closer to what would actually be released... i think | 20:56 |
| jgriffith | mtanino: so I think it's good that it failed personally. but bad that we allowed a change like that :) | 20:57 |
| jgriffith | patrickeast: no, so that's the problem. | 20:57 |
| jgriffith | patrickeast: if you have an "old" Cinder it will flat out fail | 20:57 |
| jgriffith | patrickeast: this is the danger of the cross-project dependency model IMO | 20:57 |
| openstackgerrit | Matan Sabag proposed openstack/cinder: Support for consistency groups in ScaleIO driver https://review.openstack.org/269624 | 20:57 |
| patrickeast | jgriffith: oh, like *any* old cinder and a M or newer nova | 20:57 |
| patrickeast | jgriffith: i see | 20:57 |
| jgriffith | patrickeast: exactly | 20:57 |
| jgriffith | patrickeast: so like, lord help you if you're upgrading in stages :) | 20:58 |
| smcginnis | PITA | 20:58 |
| patrickeast | jgriffith: stages? psh, who does that ;) | 20:58 |
| jgriffith | :) | 20:58 |
| DuncanT | Upgrades? The old stuff works, nobody touch a thing! | 20:59 |
| patrickeast | seems like something we should have in our ci testing | 21:00 |
| jgriffith | patrickeast: so that's the thing | 21:00 |
| jgriffith | patrickeast: we used to NOT rebase in check I don't think | 21:00 |
| *** haomaiwang has quit IRC | 21:01 | |
| patrickeast | jgriffith: yea i think a while ago zuul didn't do it | 21:01 |
| *** salv-orlando has joined #openstack-cinder | 21:01 | |
| patrickeast | jgriffith: back when like recheck vs reverify was a thing, iiuc | 21:01 |
| *** haomaiwang has joined #openstack-cinder | 21:01 | |
| openstackgerrit | abhiram moturi proposed openstack/cinder: Zfssaiscsi driver should not use 'default' initiator group https://review.openstack.org/238635 | 21:02 |
| patrickeast | we kinda want both i guess | 21:02 |
| jgriffith | patrickeast: exactly | 21:02 |
| jgriffith | patrickeast: IMHO no rebase on check, and rebase of course on verify | 21:02 |
| jgriffith | but whatever | 21:02 |
| patrickeast | yea, but thats a pain to find out that you would be blocked in gate so late | 21:03 |
| jgriffith | even the guy who manages the "common CI" code doesn't know how it works :) | 21:03 |
| patrickeast | makes sense why it does it ne check now | 21:03 |
| patrickeast | in* | 21:03 |
| *** mylu has joined #openstack-cinder | 21:03 | |
| patrickeast | we kind of want both in check and then merge on verify | 21:03 |
| jgriffith | patrickeast: I'll stick with my SOS thank you very much :) | 21:03 |
| patrickeast | haha | 21:03 |
| *** mylu has quit IRC | 21:03 | |
| jgriffith | patrickeast: I can continue to be the canary in the coal mine :) | 21:04 |
| patrickeast | i dunno, the zuul code isn't too bad | 21:04 |
| *** pots1 has quit IRC | 21:04 | |
| patrickeast | its just the insane way things get configured that makes things mysterious | 21:04 |
| jgriffith | patrickeast: nahh... I agree with you | 21:04 |
| smcginnis | jgriffith: Yeah, we've been trying to get common going here. | 21:04 |
| smcginnis | I'm happy with my scripts for now. :) | 21:04 |
| jgriffith | patrickeast: the config and puppet sides are what drive me to drink | 21:04 |
| patrickeast | jgriffith: ditto | 21:04 |
| openstackgerrit | Merged openstack/cinder: Allow for eradicating Pure volumes on Cinder delete https://review.openstack.org/275919 | 21:08 |
| *** savihou has quit IRC | 21:09 | |
| *** jgregor has quit IRC | 21:10 | |
| *** pots has quit IRC | 21:11 | |
| *** angela-s has joined #openstack-cinder | 21:13 | |
| *** jgregor has joined #openstack-cinder | 21:13 | |
| openstackgerrit | Scott DAngelo proposed openstack/cinder: cinder-api-microversions code https://review.openstack.org/224910 | 21:13 |
| *** merooney has quit IRC | 21:13 | |
| openstackgerrit | Matan Sabag proposed openstack/cinder: Manage/unmanage volume in ScaleIO driver https://review.openstack.org/268344 | 21:16 |
| *** sheel has quit IRC | 21:17 | |
| *** jgregor has quit IRC | 21:18 | |
| *** lpetrut has joined #openstack-cinder | 21:22 | |
| openstackgerrit | Matan Sabag proposed openstack/cinder: ScaleIO QoS Support https://review.openstack.org/260719 | 21:22 |
| *** akerr has quit IRC | 21:23 | |
| *** jgregor has joined #openstack-cinder | 21:23 | |
| *** dramakri has quit IRC | 21:24 | |
| openstackgerrit | Ryan McNair proposed openstack/cinder: WIP Fixup nested quotas to enforce child defaults https://review.openstack.org/274825 | 21:24 |
| *** dustins has quit IRC | 21:24 | |
| *** jgregor has left #openstack-cinder | 21:25 | |
| *** jgregor has joined #openstack-cinder | 21:25 | |
| *** dims has joined #openstack-cinder | 21:26 | |
| *** dims_ has quit IRC | 21:29 | |
| *** dustins has joined #openstack-cinder | 21:30 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: VMAX-Replacing deprecated API EMCGetTargetEndpoints https://review.openstack.org/244328 | 21:30 |
| angela-s | smcginnis, jgriffith: could you please take a look at this review? https://review.openstack.org/#/c/275407/ | 21:31 |
| angela-s | smcginnis, jgriffith: i had to abandon the original review as i could not resolve the conflicts after the parent review was merged | 21:32 |
| smcginnis | angela-s: Sure, I'll take a look. | 21:32 |
| angela-s | thank you! | 21:32 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Storwize: Implement v2 replication https://review.openstack.org/237387 | 21:34 |
| *** mtanino has quit IRC | 21:34 | |
| *** baumann has left #openstack-cinder | 21:40 | |
| *** porrua has quit IRC | 21:46 | |
| openstackgerrit | Angela Smith proposed openstack/cinder: Adds support for configuring zoning in a virtual fabric https://review.openstack.org/275407 | 21:49 |
| angela-s | smcginnis: thanks for catching that, argh! | 21:49 |
| smcginnis | angela-s: ;) | 21:49 |
| *** sinese_ has quit IRC | 21:51 | |
| *** dustins has quit IRC | 21:53 | |
| *** krtaylor has quit IRC | 21:55 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Storwize: Implement v2 replication https://review.openstack.org/237387 | 21:55 |
| *** dulek has joined #openstack-cinder | 21:55 | |
| *** boris-42 has joined #openstack-cinder | 21:58 | |
| *** haomaiwang has quit IRC | 22:01 | |
| *** haomaiwang has joined #openstack-cinder | 22:01 | |
| *** dramakri has joined #openstack-cinder | 22:02 | |
| *** timcl has quit IRC | 22:03 | |
| *** e0ne has quit IRC | 22:03 | |
| *** knikolla has quit IRC | 22:04 | |
| *** akshai has quit IRC | 22:05 | |
| *** krtaylor has joined #openstack-cinder | 22:07 | |
| *** cknight has quit IRC | 22:08 | |
| *** jgriffith is now known as jgriffith_away | 22:10 | |
| openstackgerrit | Vivek Dhayaal proposed openstack/cinder: Removed potential races from volume update method https://review.openstack.org/277588 | 22:11 |
| *** cknight has joined #openstack-cinder | 22:12 | |
| *** akshai has joined #openstack-cinder | 22:13 | |
| Swanson | cgsnapshot question for anyone. xyang1 maybe. I'm calling objects.SnapshotList().get_all_for_cgsnapshot(context, snapshotid). It looks like I no longer need to do this as those snapshots appear to be on the parameter list. Correct? | 22:14 |
| *** jgriffith_away is now known as jgriffith | 22:17 | |
| *** mylu has joined #openstack-cinder | 22:19 | |
| aorourke | Swanson, that is correct. The driver should not need to access the db at all now. Snapshots and volumes are passed into to cg functions as parameters now | 22:20 |
| Swanson | Nevermind. Actual docstrings farther down in driver.py. | 22:20 |
| Swanson | aorourke, Thanks for the confirmation. | 22:21 |
| *** mylu has quit IRC | 22:21 | |
| *** esker has quit IRC | 22:22 | |
| *** diablo_rojo has quit IRC | 22:23 | |
| *** esker has joined #openstack-cinder | 22:23 | |
| *** krtaylor has quit IRC | 22:24 | |
| xyang1 | Swanson: all set? | 22:24 |
| *** chris_morrell has quit IRC | 22:25 | |
| Swanson | xyang1, yep! | 22:25 |
| *** esp has joined #openstack-cinder | 22:25 | |
| xyang1 | great | 22:25 |
| *** dulek has quit IRC | 22:26 | |
| *** jungleboyj has quit IRC | 22:29 | |
| *** dims has quit IRC | 22:31 | |
| *** esp has quit IRC | 22:32 | |
| *** mylu has joined #openstack-cinder | 22:34 | |
| *** krtaylor has joined #openstack-cinder | 22:36 | |
| *** edtubill_ has quit IRC | 22:39 | |
| *** crose has quit IRC | 22:40 | |
| Swanson | jgriffith, What exception for a replication_failover fail? | 22:40 |
| jgriffith | Swanson: depends :) | 22:40 |
| jgriffith | Swanson: so for the case of "replicaton not configured" I'm raising "invalidInput" | 22:41 |
| jgriffith | Swanson: in the case of the driver being hosed, it should return a "backenddriverexception" | 22:41 |
| jgriffith | with an appropriate message | 22:41 |
| Swanson | jgriffith, I can roll with that. Thanks! | 22:42 |
| *** mylu has quit IRC | 22:42 | |
| *** mylu has joined #openstack-cinder | 22:44 | |
| *** jgregor has quit IRC | 22:46 | |
| *** dulek has joined #openstack-cinder | 22:48 | |
| *** rlrossit has quit IRC | 22:49 | |
| *** dulek has quit IRC | 22:49 | |
| *** merooney has joined #openstack-cinder | 22:49 | |
| angela-s | who runs EMC XIO CI? It's posted 'merge failed' comment 5 times in last 1 1/2 hrs to this review https://review.openstack.org/#/c/275407/ | 22:49 |
| *** merooney has quit IRC | 22:50 | |
| *** dims_ has joined #openstack-cinder | 22:51 | |
| aorourke | angela-s, it has also done this on https://review.openstack.org/#/c/274908/ and https://review.openstack.org/#/c/268346/ | 22:52 |
| eharney | angela-s: it did that on https://review.openstack.org/#/c/275909/ too. not very useful. | 22:52 |
| angela-s | ok, so it's gone crazy. anyone know who the owner is? | 22:53 |
| *** kfarr has quit IRC | 22:53 | |
| angela-s | eharney: yeah, seems like a bogus failure message to me | 22:53 |
| aorourke | https://wiki.openstack.org/wiki/ThirdPartySystems/emc-xio-ci | 22:54 |
| eharney | IMO (again) CIs that post this are just making noise and should stop posting these results. | 22:54 |
| eharney | but i've brought this up a few times and nobody seems to have a good idea for what to do about it | 22:54 |
| xyang1 | angela-s: that's me | 22:54 |
| xyang1 | angela-s: could be caused by log server full | 22:54 |
| *** funeutron has quit IRC | 22:54 | |
| xyang1 | angela-s: we'll take a look | 22:55 |
| eharney | xyang1: the problem is, the message it posts implies there's something wrong with the patchset | 22:55 |
| angela-s | xyang1: thanks for speaking up. | 22:55 |
| eharney | or, not implies, but actually tells you to fix it | 22:55 |
| xyang1 | eharney: I'll take a look | 22:55 |
| eharney | xyang1: can you take a look at just not reporting when it hits that state? | 22:56 |
| angela-s | xyang1: and why does it keep posting? is it doing automatic recheck? | 22:56 |
| xyang1 | eharney: sure | 22:56 |
| *** EinstCrazy has joined #openstack-cinder | 22:58 | |
| *** diablo_rojo has joined #openstack-cinder | 22:59 | |
| *** haomaiwang has quit IRC | 23:01 | |
| *** haomaiwang has joined #openstack-cinder | 23:01 | |
| *** mragupat_ has quit IRC | 23:02 | |
| *** esp has joined #openstack-cinder | 23:03 | |
| *** eharney has quit IRC | 23:04 | |
| patrickeast | eharney: unfortunately I don't think zuul has that as an option (zuul-merger being the culpret behind those errors), although could probably be extended to do it | 23:04 |
| jgriffith | patrickeast: you could use sos :) | 23:05 |
| * patrickeast goes digging in https://github.com/openstack-infra/zuul | 23:05 | |
| *** EinstCrazy has quit IRC | 23:05 | |
| jgriffith | patrickeast: seriously though, I can't imagine that not being configurable | 23:05 |
| patrickeast | jgriffith: nah, i'm way to committed to the infra tools | 23:05 |
| jgriffith | patrickeast: seems that the CI's are maybe running the wrong config ? | 23:05 |
| jgriffith | patrickeast: hehe... I hear ya | 23:06 |
| patrickeast | jgriffith: gotta keep driving business for my blossoming CI consulting | 23:06 |
| *** mtanino has joined #openstack-cinder | 23:06 | |
| jgriffith | LOL | 23:06 |
| *** dan_nguyen has joined #openstack-cinder | 23:06 | |
| jgriffith | rule #1 in OpenStack... "don't make it too easy, that's how you make money" :) | 23:06 |
| patrickeast | jgriffith: so the problem is that for regular jenkins, a merge failing is like a real problem | 23:06 |
| patrickeast | jgriffith: since it means the patchset would not be able to get committed and what not | 23:06 |
| jgriffith | patrickeast: hmmm... I guess my issue is that it shouldn't be trying to merge anyway | 23:06 |
| patrickeast | jgriffith: haha yea | 23:07 |
| patrickeast | jgriffith: that may or may not be configurable | 23:07 |
| jgriffith | patrickeast: in other words, that's a job for the gate-verify NOT the ci/check | 23:07 |
| *** esp has quit IRC | 23:07 | |
| *** lpetrut has quit IRC | 23:08 | |
| xyang1 | patrickeast: how much are you charging for CI consulting?:) | 23:10 |
| patrickeast | haha | 23:10 |
| patrickeast | xyang1: nothing yet | 23:10 |
| *** vivekd has quit IRC | 23:12 | |
| openstackgerrit | Kendall Nelson proposed openstack/os-brick: WIP: Lun id's > 255 should be converted to hex https://review.openstack.org/277606 | 23:14 |
| *** dims_ has quit IRC | 23:14 | |
| *** salv-orlando has quit IRC | 23:14 | |
| *** gouthamr has quit IRC | 23:15 | |
| *** gouthamr has joined #openstack-cinder | 23:15 | |
| *** gouthamr has quit IRC | 23:15 | |
| *** salv-orlando has joined #openstack-cinder | 23:15 | |
| *** dramakri has quit IRC | 23:15 | |
| *** dims_ has joined #openstack-cinder | 23:19 | |
| *** diablo_rojo has quit IRC | 23:26 | |
| *** IlyaG has quit IRC | 23:27 | |
| *** dramakri has joined #openstack-cinder | 23:27 | |
| *** IlyaG has joined #openstack-cinder | 23:28 | |
| *** can8dnSix has joined #openstack-cinder | 23:36 | |
| *** liewegas has quit IRC | 23:39 | |
| *** lcurtis has quit IRC | 23:39 | |
| *** liewegas has joined #openstack-cinder | 23:40 | |
| *** smoriya_ has joined #openstack-cinder | 23:43 | |
| *** esker has quit IRC | 23:43 | |
| *** yhayashi has joined #openstack-cinder | 23:48 | |
| *** can8dnSix has quit IRC | 23:48 | |
| *** akshai has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!