*** amitkar has joined #openstack-cinder | 00:00 | |
*** rdx_matt has joined #openstack-cinder | 00:04 | |
*** yangyapeng has quit IRC | 00:05 | |
*** rdx_matt has quit IRC | 00:09 | |
*** mriedem has joined #openstack-cinder | 00:11 | |
*** vmtrooper has joined #openstack-cinder | 00:15 | |
*** amitkar has quit IRC | 00:18 | |
*** amitkar has joined #openstack-cinder | 00:20 | |
*** laughterwym has joined #openstack-cinder | 00:20 | |
*** laughterwym has joined #openstack-cinder | 00:21 | |
*** garthb_ has joined #openstack-cinder | 00:23 | |
*** amitkar has quit IRC | 00:24 | |
*** gouthamr has joined #openstack-cinder | 00:27 | |
*** garthb_ has quit IRC | 00:27 | |
*** garthb has quit IRC | 00:27 | |
*** bardia has quit IRC | 00:29 | |
mriedem | scottda: it's d'angelo for your last name right? | 00:33 |
---|---|---|
mriedem | yes! https://openstacksummitoctober2015tokyo.sched.org/event/49x1/contributing-to-openstack-201-a-primer-for-the-not-so-new-contributor | 00:34 |
*** karthikp has quit IRC | 00:36 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: WIP: Add image_conversion_cache_mode config for qemu-img https://review.openstack.org/312797 | 00:41 |
*** amit213 has quit IRC | 00:42 | |
*** arch-nemesis has quit IRC | 00:46 | |
*** amitkar has joined #openstack-cinder | 00:46 | |
*** suyash has quit IRC | 00:49 | |
*** esker has joined #openstack-cinder | 00:52 | |
*** J has joined #openstack-cinder | 00:53 | |
*** J is now known as Guest2249 | 00:54 | |
*** cheneydc has joined #openstack-cinder | 00:54 | |
*** amitkar has quit IRC | 00:55 | |
*** esker has quit IRC | 00:57 | |
*** mtanino has quit IRC | 01:05 | |
*** rdx_matt has joined #openstack-cinder | 01:05 | |
*** rdx_matt has quit IRC | 01:10 | |
*** ozialien10 has quit IRC | 01:12 | |
jgriffith | smcginnis: care to help me figure something out? | 01:13 |
*** yangyapeng has joined #openstack-cinder | 01:13 | |
*** amit213 has joined #openstack-cinder | 01:13 | |
*** mriedem has quit IRC | 01:14 | |
*** yangyapeng has quit IRC | 01:15 | |
*** amit213 has quit IRC | 01:16 | |
*** daneyon has joined #openstack-cinder | 01:19 | |
*** sdake has joined #openstack-cinder | 01:22 | |
*** daneyon_ has joined #openstack-cinder | 01:25 | |
*** EinstCrazy has joined #openstack-cinder | 01:27 | |
*** yangxi has joined #openstack-cinder | 01:27 | |
*** daneyon has quit IRC | 01:28 | |
*** esker has joined #openstack-cinder | 01:28 | |
*** raunak has quit IRC | 01:28 | |
*** Lee1092 has joined #openstack-cinder | 01:28 | |
*** dims has quit IRC | 01:30 | |
*** Julien-zte has joined #openstack-cinder | 01:31 | |
*** esker has quit IRC | 01:33 | |
*** dims has joined #openstack-cinder | 01:35 | |
*** daneyon_ has quit IRC | 01:36 | |
*** vmtrooper has quit IRC | 01:37 | |
*** julim has joined #openstack-cinder | 01:45 | |
*** laughterwym has quit IRC | 01:52 | |
openstackgerrit | Merged openstack/cinder: Pass default executor to os-brick https://review.openstack.org/312681 | 01:53 |
*** gouthamr has quit IRC | 01:53 | |
*** amitkar has joined #openstack-cinder | 01:54 | |
*** amitkar has quit IRC | 01:57 | |
*** yangxi has quit IRC | 01:59 | |
*** htaccess has joined #openstack-cinder | 02:01 | |
htaccess | when attachinga vloume to an instances using nova volume-attach should i expect to see something in dmesg on the instance about the device? | 02:02 |
htaccess | im doing this on a 16.04 instance and i don't see anything | 02:02 |
htaccess | sudo fdisk -l shows the device | 02:02 |
*** laughterwym has joined #openstack-cinder | 02:02 | |
htaccess | and i get dmesg output after creating a partition and mounting but nothing from the volume-attach action | 02:03 |
*** savihou has quit IRC | 02:04 | |
*** esker has joined #openstack-cinder | 02:04 | |
*** savihou has joined #openstack-cinder | 02:04 | |
*** rdx_matt has joined #openstack-cinder | 02:06 | |
*** salv-orlando has joined #openstack-cinder | 02:08 | |
*** sdake_ has joined #openstack-cinder | 02:08 | |
*** esker has quit IRC | 02:09 | |
*** rdx_matt has quit IRC | 02:10 | |
*** sdake has quit IRC | 02:11 | |
*** salv-orlando has quit IRC | 02:17 | |
openstackgerrit | Peter Wang proposed openstack/cinder: VNX: New Cinder driver in Newton https://review.openstack.org/312427 | 02:23 |
*** raunak has joined #openstack-cinder | 02:25 | |
*** sdake_ has quit IRC | 02:27 | |
*** apoorvad has quit IRC | 02:30 | |
*** salv-orlando has joined #openstack-cinder | 02:30 | |
*** salv-orlando has quit IRC | 02:31 | |
*** salv-orlando has joined #openstack-cinder | 02:31 | |
*** yangxi has joined #openstack-cinder | 02:32 | |
openstackgerrit | LisaLi proposed openstack/os-brick: Copy encryptors from Nova to os-brick https://review.openstack.org/247372 | 02:33 |
*** laughterwym has quit IRC | 02:39 | |
*** esker has joined #openstack-cinder | 02:40 | |
*** laughterwym has joined #openstack-cinder | 02:40 | |
*** laughterwym has quit IRC | 02:44 | |
*** esker has quit IRC | 02:44 | |
*** salv-orlando has quit IRC | 02:45 | |
*** raunak has quit IRC | 02:46 | |
*** raunak has joined #openstack-cinder | 02:55 | |
*** yangxi has quit IRC | 02:56 | |
*** laughterwym has joined #openstack-cinder | 02:56 | |
openstackgerrit | Cao ShuFeng proposed openstack/cinder: Allow API user to update multiattach attr of volume https://review.openstack.org/309674 | 02:57 |
*** laughterwym has quit IRC | 03:01 | |
*** yangxi has joined #openstack-cinder | 03:01 | |
*** cdelatte has quit IRC | 03:03 | |
*** zhongjun_ has quit IRC | 03:03 | |
*** zhongjun_ has joined #openstack-cinder | 03:04 | |
*** rdx_matt has joined #openstack-cinder | 03:07 | |
openstackgerrit | Cao ShuFeng proposed openstack/cinder: remove extra quota commit of manage snapshot https://review.openstack.org/298522 | 03:09 |
*** laughterwym has joined #openstack-cinder | 03:10 | |
*** rdx_matt has quit IRC | 03:12 | |
*** laughterwym has quit IRC | 03:14 | |
*** esker has joined #openstack-cinder | 03:15 | |
*** jdurgin1 has joined #openstack-cinder | 03:17 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/cinder: Let method CONF.set_override with enfore_type=true by default https://review.openstack.org/253328 | 03:18 |
*** gcb has joined #openstack-cinder | 03:18 | |
*** nnex has joined #openstack-cinder | 03:18 | |
*** esker has quit IRC | 03:20 | |
*** garthb has joined #openstack-cinder | 03:20 | |
*** salv-orlando has joined #openstack-cinder | 03:20 | |
*** laughterwym has joined #openstack-cinder | 03:21 | |
*** Julien-zte has quit IRC | 03:23 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: WIP: Add image_conversion_cache_mode config for qemu-img https://review.openstack.org/312797 | 03:24 |
*** laughterwym has quit IRC | 03:25 | |
*** laughterwym has joined #openstack-cinder | 03:37 | |
*** laughterwym has quit IRC | 03:38 | |
*** laughterwym has joined #openstack-cinder | 03:38 | |
openstackgerrit | KongWei proposed openstack/cinder: Add ZTE Block Storage Driver https://review.openstack.org/312355 | 03:39 |
*** salv-orlando has quit IRC | 03:42 | |
*** laughterwym has quit IRC | 03:44 | |
*** lamt has quit IRC | 03:45 | |
*** jungleboyj has joined #openstack-cinder | 03:46 | |
*** laughterwym has joined #openstack-cinder | 03:49 | |
*** pleia2 has quit IRC | 03:51 | |
*** esker has joined #openstack-cinder | 03:51 | |
*** laughterwym has quit IRC | 03:54 | |
*** esker has quit IRC | 03:57 | |
*** laughterwym has joined #openstack-cinder | 03:57 | |
*** ircuser-1 has quit IRC | 04:00 | |
*** rdx_matt has joined #openstack-cinder | 04:08 | |
*** rdx_matt has quit IRC | 04:13 | |
*** yangxi has quit IRC | 04:15 | |
*** sdake has joined #openstack-cinder | 04:18 | |
*** yangxi has joined #openstack-cinder | 04:18 | |
*** liverpooler has quit IRC | 04:19 | |
*** esker has joined #openstack-cinder | 04:27 | |
*** esker has quit IRC | 04:32 | |
*** Poornima has joined #openstack-cinder | 04:34 | |
*** dave-mccowan has quit IRC | 04:45 | |
*** sdake has quit IRC | 04:47 | |
*** sdake has joined #openstack-cinder | 04:48 | |
*** raunak has quit IRC | 04:52 | |
*** htaccess has left #openstack-cinder | 04:56 | |
*** jungleboyj has quit IRC | 05:01 | |
*** esker has joined #openstack-cinder | 05:03 | |
*** yangxi has quit IRC | 05:07 | |
*** esker has quit IRC | 05:08 | |
*** rdx_matt has joined #openstack-cinder | 05:08 | |
*** laughterwym has quit IRC | 05:08 | |
*** iceyao has joined #openstack-cinder | 05:09 | |
*** yangxi has joined #openstack-cinder | 05:10 | |
*** laughterwym has joined #openstack-cinder | 05:12 | |
*** iceyao_ has joined #openstack-cinder | 05:13 | |
openstackgerrit | Merged openstack/cinder: Huawei: Do not do split if replication pair abnormal https://review.openstack.org/299780 | 05:14 |
*** iceyao has quit IRC | 05:16 | |
*** laughterwym has quit IRC | 05:17 | |
*** harlowja_at_home has joined #openstack-cinder | 05:20 | |
*** laughterwym has joined #openstack-cinder | 05:21 | |
*** laughterwym has quit IRC | 05:23 | |
*** laughterwym has joined #openstack-cinder | 05:24 | |
*** laughter_ has joined #openstack-cinder | 05:26 | |
*** harlowja_at_home has quit IRC | 05:26 | |
*** laughterwym has quit IRC | 05:29 | |
*** iceyao_ has quit IRC | 05:34 | |
openstackgerrit | Cao ShuFeng proposed openstack/cinder: enhanche error message [1/5] https://review.openstack.org/296304 | 05:35 |
openstackgerrit | Cao ShuFeng proposed openstack/cinder: remove extra quota commit of manage snapshot https://review.openstack.org/298522 | 05:43 |
*** laughterwym has joined #openstack-cinder | 05:44 | |
*** iceyao has joined #openstack-cinder | 05:47 | |
*** laughter_ has quit IRC | 05:49 | |
*** bigdogstl has joined #openstack-cinder | 05:51 | |
*** bigdogstl has quit IRC | 05:56 | |
*** openstackgerrit has quit IRC | 06:03 | |
*** openstackgerrit has joined #openstack-cinder | 06:04 | |
*** liverpooler has joined #openstack-cinder | 06:05 | |
*** vgridnev has joined #openstack-cinder | 06:07 | |
*** daneyon has joined #openstack-cinder | 06:08 | |
*** daneyon_ has joined #openstack-cinder | 06:09 | |
openstackgerrit | Cao ShuFeng proposed openstack/cinder: enhanche error message [1/5] https://review.openstack.org/296304 | 06:09 |
*** garthb has quit IRC | 06:12 | |
*** daneyon has quit IRC | 06:13 | |
*** iceyao_ has joined #openstack-cinder | 06:16 | |
*** iceyao has quit IRC | 06:20 | |
*** daneyon_ has quit IRC | 06:24 | |
*** daneyon has joined #openstack-cinder | 06:24 | |
*** yangyapeng has joined #openstack-cinder | 06:31 | |
*** e0ne has joined #openstack-cinder | 06:32 | |
*** sdake has quit IRC | 06:32 | |
*** daneyon has quit IRC | 06:37 | |
*** e0ne has quit IRC | 06:43 | |
*** tesseract has joined #openstack-cinder | 06:44 | |
*** yangxi has quit IRC | 06:45 | |
*** tesseract is now known as Guest21288 | 06:45 | |
*** EinstCrazy has quit IRC | 06:46 | |
*** EinstCrazy has joined #openstack-cinder | 06:46 | |
*** yangxi has joined #openstack-cinder | 06:49 | |
openstackgerrit | Cao ShuFeng proposed openstack/cinder: Allow API user to update multiattach attr of volume https://review.openstack.org/309674 | 06:57 |
*** jdurgin1 has quit IRC | 07:01 | |
*** cheneydc has quit IRC | 07:34 | |
*** cheneydc has joined #openstack-cinder | 07:34 | |
*** mvk_ has quit IRC | 07:44 | |
*** sasukeh has joined #openstack-cinder | 07:52 | |
*** lpetrut has joined #openstack-cinder | 07:54 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-cinder | 08:04 | |
*** e0ne has joined #openstack-cinder | 08:06 | |
openstackgerrit | Wilson Liu proposed openstack/cinder-specs: Migrate volume between backends in an async way https://review.openstack.org/312853 | 08:08 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/cinder: [WIP] Testing latest u-c https://review.openstack.org/303766 | 08:10 |
openstackgerrit | Wilson Liu proposed openstack/cinder-specs: Migrate volume between backends in an async way https://review.openstack.org/312853 | 08:27 |
*** gcb has quit IRC | 08:30 | |
openstackgerrit | Wilson Liu proposed openstack/cinder-specs: Migrate volume between backends in an async way https://review.openstack.org/312853 | 08:31 |
*** jistr has joined #openstack-cinder | 08:34 | |
*** mvk_ has joined #openstack-cinder | 08:39 | |
*** gcb has joined #openstack-cinder | 08:42 | |
*** laughterwym has quit IRC | 08:42 | |
openstackgerrit | Wilson Liu proposed openstack/cinder-specs: Migrate volume between backends in an async way https://review.openstack.org/312853 | 08:42 |
*** laughterwym has joined #openstack-cinder | 08:43 | |
*** e0ne has quit IRC | 08:46 | |
*** laughterwym has quit IRC | 08:48 | |
*** e0ne has joined #openstack-cinder | 08:49 | |
*** theanalyst has joined #openstack-cinder | 08:50 | |
*** ircuser-1 has joined #openstack-cinder | 08:53 | |
openstackgerrit | Wilson Liu proposed openstack/cinder-specs: Migrate volume between backends in an async way https://review.openstack.org/312853 | 08:54 |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Add unmanage volume for RBD driver https://review.openstack.org/307342 | 08:57 |
*** ankit_ag has joined #openstack-cinder | 09:00 | |
*** sasukeh has quit IRC | 09:06 | |
openstackgerrit | Wilson Liu proposed openstack/cinder-specs: Migrate volume between backends in an async way https://review.openstack.org/312853 | 09:07 |
*** lpetrut has quit IRC | 09:07 | |
*** lpetrut has joined #openstack-cinder | 09:08 | |
*** lpetrut has quit IRC | 09:14 | |
openstackgerrit | Wilson Liu proposed openstack/cinder-specs: Migrate volume between backends in an async way https://review.openstack.org/312853 | 09:14 |
*** yangxi has quit IRC | 09:15 | |
*** vgridnev has quit IRC | 09:18 | |
*** laughterwym has joined #openstack-cinder | 09:18 | |
*** yangxi has joined #openstack-cinder | 09:20 | |
*** laughterwym has quit IRC | 09:23 | |
*** sdake has joined #openstack-cinder | 09:24 | |
openstackgerrit | Merged openstack/cinder: Add provider_location to cloned volume https://review.openstack.org/309086 | 09:28 |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Image virtual size doesn't fit to volume size https://review.openstack.org/311152 | 09:29 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Fix gate-cinder-tox-db-functional job https://review.openstack.org/312875 | 09:36 |
*** laughterwym has joined #openstack-cinder | 09:47 | |
*** lpetrut has joined #openstack-cinder | 09:47 | |
*** e0ne has quit IRC | 09:48 | |
*** e0ne has joined #openstack-cinder | 09:49 | |
*** yangxi has quit IRC | 09:51 | |
*** yangxi has joined #openstack-cinder | 09:55 | |
*** cheneydc has quit IRC | 10:01 | |
*** e0ne has quit IRC | 10:05 | |
*** sdague has joined #openstack-cinder | 10:06 | |
*** vgridnev has joined #openstack-cinder | 10:09 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/cinder: [WIP] Testing latest u-c https://review.openstack.org/303766 | 10:10 |
*** iceyao_ has quit IRC | 10:15 | |
*** rushiagr has joined #openstack-cinder | 10:19 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Image virtual size doesn't fit to volume size https://review.openstack.org/311152 | 10:26 |
*** kmartin has quit IRC | 10:28 | |
*** sdake has quit IRC | 10:29 | |
*** EinstCrazy has quit IRC | 10:41 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Handle SSL termination proxies for version list https://review.openstack.org/305152 | 10:42 |
*** yuriy_n17 has quit IRC | 10:43 | |
*** yangxi has quit IRC | 10:43 | |
*** yuriy_n17 has joined #openstack-cinder | 10:44 | |
*** yangxi has joined #openstack-cinder | 10:44 | |
*** yangyapeng has quit IRC | 10:46 | |
openstackgerrit | Peter Wang proposed openstack/cinder: VNX: New Cinder driver in Newton https://review.openstack.org/312427 | 10:51 |
*** e0ne has joined #openstack-cinder | 10:51 | |
*** yangxi has quit IRC | 11:03 | |
*** links has joined #openstack-cinder | 11:05 | |
*** nnex has quit IRC | 11:06 | |
openstackgerrit | Peter Wang proposed openstack/cinder: VNX: New Cinder driver in Newton https://review.openstack.org/312427 | 11:08 |
*** nnex has joined #openstack-cinder | 11:10 | |
*** lprice1 has quit IRC | 11:16 | |
*** lprice has joined #openstack-cinder | 11:16 | |
openstackgerrit | Wilson Liu proposed openstack/cinder-specs: Migrate volume between backends in an async way https://review.openstack.org/312853 | 11:18 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Remove API races on extend and volume_upload_image https://review.openstack.org/216378 | 11:26 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Remove API races from consistency groups https://review.openstack.org/259429 | 11:26 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Remove API races from migrate and retype https://review.openstack.org/221442 | 11:26 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Add ordering possibilities to conditional update https://review.openstack.org/231936 | 11:26 |
openstackgerrit | Wilson Liu proposed openstack/cinder-specs: Migrate volume between backends in an async way https://review.openstack.org/312853 | 11:38 |
*** rdx_matt has quit IRC | 11:41 | |
*** rdx_matt has joined #openstack-cinder | 11:41 | |
*** gcb has quit IRC | 11:42 | |
*** rdx_matt has quit IRC | 11:46 | |
*** links has quit IRC | 11:53 | |
*** dave-mccowan has joined #openstack-cinder | 11:53 | |
*** gcb has joined #openstack-cinder | 11:55 | |
*** tpsilva has joined #openstack-cinder | 11:55 | |
*** dave-mcc_ has joined #openstack-cinder | 11:56 | |
*** akerr has joined #openstack-cinder | 11:57 | |
*** dave-mccowan has quit IRC | 11:58 | |
openstackgerrit | huanan proposed openstack/cinder: Huawei: Fixed problems caused by password expires https://review.openstack.org/305633 | 12:04 |
*** ekarlso has quit IRC | 12:06 | |
*** ekarlso has joined #openstack-cinder | 12:06 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Handle SSL termination proxies for version list https://review.openstack.org/305152 | 12:10 |
*** iceyao has joined #openstack-cinder | 12:16 | |
*** krtaylor has quit IRC | 12:20 | |
*** rdx_matt has joined #openstack-cinder | 12:21 | |
*** akerr_ has joined #openstack-cinder | 12:30 | |
*** timcl has joined #openstack-cinder | 12:32 | |
*** akerr has quit IRC | 12:33 | |
openstackgerrit | Tomaz Vieira proposed openstack/cinder: Improve hitachi hnas volume drivers log messages https://review.openstack.org/310785 | 12:36 |
openstackgerrit | Clinton Knight proposed openstack/cinder: NetApp: Decouple capacity volume stats collection https://review.openstack.org/312927 | 12:42 |
openstackgerrit | Wilson Liu proposed openstack/cinder: Huawei: Continue to deal with other port groups https://review.openstack.org/312928 | 12:44 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Fix gate-cinder-tox-db-functional job https://review.openstack.org/312875 | 12:51 |
*** bapalm has joined #openstack-cinder | 12:54 | |
*** xyang1 has joined #openstack-cinder | 12:58 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Add auto relationship mappings to VOs https://review.openstack.org/307075 | 12:58 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Link VOs with their list counterparts https://review.openstack.org/307074 | 12:58 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Remove remotable from OVOs https://review.openstack.org/312929 | 12:58 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Move OVO methods from CinderObject to Persistent https://review.openstack.org/312930 | 12:58 |
*** yangyapeng has joined #openstack-cinder | 12:59 | |
geguileo | dulek: ^ I owed you the last 2 ;-) | 12:59 |
*** akerr_ is now known as akerr | 12:59 | |
*** rlrossit has joined #openstack-cinder | 13:00 | |
*** gouthamr has joined #openstack-cinder | 13:03 | |
*** eharney has joined #openstack-cinder | 13:04 | |
*** nnex has quit IRC | 13:09 | |
*** raunak has joined #openstack-cinder | 13:10 | |
*** yangyapeng has quit IRC | 13:14 | |
*** nnex has joined #openstack-cinder | 13:14 | |
*** skraynev has quit IRC | 13:15 | |
*** nnex has quit IRC | 13:15 | |
*** esker has joined #openstack-cinder | 13:17 | |
*** raunak_ has joined #openstack-cinder | 13:18 | |
eharney | e0ne: do you think this is the patch that broke the functional job? https://review.openstack.org/#/c/300189/ | 13:18 |
*** raunak has quit IRC | 13:18 | |
*** raunak_ is now known as raunak | 13:18 | |
eharney | e0ne: because it looks related, but the functional job didn't run against that patch... | 13:19 |
e0ne | eharney: looing on it | 13:19 |
e0ne | *looking | 13:19 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/cinder: Implement CHAP Authentication for E-Series Driver https://review.openstack.org/246990 | 13:20 |
*** Poornima has quit IRC | 13:20 | |
*** rdx_matt has quit IRC | 13:21 | |
*** rdx_matt has joined #openstack-cinder | 13:21 | |
eharney | e0ne: oh, i was wrong, the job did run against it | 13:21 |
e0ne | eharney: yes, looks like your patch broke it | 13:22 |
eharney | e0ne: indeed | 13:23 |
*** Poornima has joined #openstack-cinder | 13:23 | |
e0ne | eharney: so, I'm wrong with commit message:( | 13:23 |
eharney | e0ne: yeah, oslo.versionedobjects doesn't enforce this yet | 13:23 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Fix gate-cinder-tox-db-functional job https://review.openstack.org/312875 | 13:24 |
e0ne | eharney: thanks for the help | 13:24 |
e0ne | scottda: could you please take a look on my comment for https://review.openstack.org/#/c/309674/? | 13:26 |
scottda | e0ne: sure | 13:26 |
*** esker has quit IRC | 13:27 | |
*** raunak has quit IRC | 13:28 | |
*** esker has joined #openstack-cinder | 13:28 | |
e0ne | scottda: thanks! I still feel a bit uncomfortable with microversions. I have to implement one to get more practice | 13:29 |
*** krtaylor has joined #openstack-cinder | 13:30 | |
*** mriedem has joined #openstack-cinder | 13:31 | |
*** akshai has joined #openstack-cinder | 13:31 | |
*** Julien-zte has joined #openstack-cinder | 13:32 | |
*** rdx_matt has quit IRC | 13:33 | |
*** rdx_matt has joined #openstack-cinder | 13:34 | |
*** lprice has quit IRC | 13:34 | |
*** yangyapeng has joined #openstack-cinder | 13:35 | |
*** ankit_ag has quit IRC | 13:35 | |
*** lpetrut has quit IRC | 13:37 | |
*** rdx_matt has quit IRC | 13:38 | |
*** raildo has left #openstack-cinder | 13:40 | |
*** porrua has joined #openstack-cinder | 13:40 | |
*** mtanino has joined #openstack-cinder | 13:41 | |
*** skraynev has joined #openstack-cinder | 13:41 | |
*** openstackgerrit has quit IRC | 13:47 | |
*** akapil has joined #openstack-cinder | 13:48 | |
*** openstackgerrit has joined #openstack-cinder | 13:48 | |
*** jgregor has joined #openstack-cinder | 13:49 | |
*** EinstCrazy has joined #openstack-cinder | 13:49 | |
*** lpetrut has joined #openstack-cinder | 13:50 | |
*** ametts has joined #openstack-cinder | 13:55 | |
*** dustins has joined #openstack-cinder | 13:55 | |
*** martyturner has joined #openstack-cinder | 13:56 | |
*** garthb has joined #openstack-cinder | 14:00 | |
*** baumann has joined #openstack-cinder | 14:05 | |
*** baumann has left #openstack-cinder | 14:05 | |
*** cknight has joined #openstack-cinder | 14:07 | |
*** links has joined #openstack-cinder | 14:08 | |
*** lprice has joined #openstack-cinder | 14:10 | |
*** xinli has joined #openstack-cinder | 14:10 | |
*** links has quit IRC | 14:16 | |
*** sdague has quit IRC | 14:21 | |
*** sdague has joined #openstack-cinder | 14:22 | |
*** liverpooler has quit IRC | 14:25 | |
*** krotscheck has quit IRC | 14:27 | |
*** Poornima has quit IRC | 14:29 | |
*** jistr has quit IRC | 14:29 | |
*** Poornima has joined #openstack-cinder | 14:29 | |
*** igornsa has quit IRC | 14:30 | |
openstackgerrit | Petrut Lucian proposed openstack/os-brick: Add Windows connectors https://review.openstack.org/272522 | 14:32 |
openstackgerrit | Petrut Lucian proposed openstack/os-brick: Ensure that the base connector is platform independent https://review.openstack.org/312999 | 14:32 |
*** krotscheck has joined #openstack-cinder | 14:33 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/cinder: Implement CHAP Authentication for E-Series Driver https://review.openstack.org/246990 | 14:34 |
*** jkraj has joined #openstack-cinder | 14:37 | |
*** akapil has quit IRC | 14:41 | |
*** akapil has joined #openstack-cinder | 14:45 | |
*** jungleboyj has joined #openstack-cinder | 14:45 | |
*** cdelatte has joined #openstack-cinder | 14:48 | |
*** bhbhavsa_ has joined #openstack-cinder | 14:48 | |
*** sdake has joined #openstack-cinder | 14:50 | |
*** jistr has joined #openstack-cinder | 14:51 | |
*** bhbhavsa has quit IRC | 14:51 | |
*** arch-nemesis has joined #openstack-cinder | 14:52 | |
*** garthb has quit IRC | 14:54 | |
*** garthb has joined #openstack-cinder | 14:54 | |
*** markstur_ has joined #openstack-cinder | 14:54 | |
*** iceyao has quit IRC | 14:54 | |
*** markstur_ has left #openstack-cinder | 14:54 | |
*** Poornima has quit IRC | 14:55 | |
*** lpetrut has quit IRC | 14:57 | |
*** karthikp has joined #openstack-cinder | 15:02 | |
*** baumann has joined #openstack-cinder | 15:03 | |
*** esker has quit IRC | 15:05 | |
*** Poornima has joined #openstack-cinder | 15:08 | |
*** daneyon has joined #openstack-cinder | 15:09 | |
*** karthikp has quit IRC | 15:09 | |
*** crose has joined #openstack-cinder | 15:14 | |
*** pleia2 has joined #openstack-cinder | 15:15 | |
*** lprice has quit IRC | 15:17 | |
*** lprice has joined #openstack-cinder | 15:17 | |
*** lpetrut has joined #openstack-cinder | 15:21 | |
*** julim has quit IRC | 15:22 | |
hemna | mornin | 15:22 |
hemna | ildikov, scottda, https://review.openstack.org/#/c/312773/ | 15:22 |
scottda | hemna: I'll have a look ... | 15:22 |
*** Lickitysplitted_ has quit IRC | 15:22 | |
*** Lickitysplitted has joined #openstack-cinder | 15:22 | |
Swanson | mornin | 15:23 |
*** lcurtis has joined #openstack-cinder | 15:23 | |
*** med_ has quit IRC | 15:23 | |
*** kmartin has joined #openstack-cinder | 15:23 | |
*** med_ has joined #openstack-cinder | 15:24 | |
*** julim has joined #openstack-cinder | 15:24 | |
*** med_ is now known as Guest82506 | 15:24 | |
*** Poornima has quit IRC | 15:24 | |
*** Guest82506 is now known as medberry | 15:25 | |
*** medberry has quit IRC | 15:25 | |
*** medberry has joined #openstack-cinder | 15:25 | |
*** plastikman has quit IRC | 15:28 | |
*** garthb has quit IRC | 15:33 | |
*** leeantho has joined #openstack-cinder | 15:33 | |
ildikov | hemna: coolio | 15:34 |
smcginnis | hemna: Jenkins passed. Ship it. | 15:34 |
hemna | heh | 15:35 |
hemna | I really think we need a new API in cinder | 15:35 |
*** lpetrut has quit IRC | 15:35 | |
hemna | for fetching target connection_info | 15:35 |
smcginnis | yep | 15:35 |
*** lpetrut has joined #openstack-cinder | 15:35 | |
hemna | everything that initialize_connection returns, just without the semantics of creating a new export/target | 15:35 |
hemna | then nova can call that as much as it wants/needs | 15:35 |
ildikov | hemna: +1 | 15:36 |
ildikov | long term that sounds way better and a simpler interaction between the two modules IMHO | 15:36 |
hemna | I think most drivers would simply refactor their existing initialize_connection | 15:37 |
hemna | with a simple if then | 15:37 |
hemna | and it'd just work | 15:37 |
smcginnis | hemna: Yeah, should be really minor. | 15:37 |
smcginnis | And until we get all drivers updated, probably not any worse to just route it to initialize_connection. | 15:37 |
smcginnis | Though only as a temporary thing. | 15:37 |
hemna | os-connection_info | 15:37 |
hemna | should I just code this shit up? | 15:39 |
hemna | I guess I can make a spec for it as well. | 15:39 |
*** plastikman has joined #openstack-cinder | 15:39 | |
hemna | we have our multi-attach meeting at 9? | 15:39 |
openstackgerrit | Petrut Lucian proposed openstack/os-brick: Add Windows connectors https://review.openstack.org/272522 | 15:40 |
openstackgerrit | Petrut Lucian proposed openstack/os-brick: Ensure that the base connector is platform independent https://review.openstack.org/312999 | 15:40 |
*** akapil has quit IRC | 15:40 | |
*** laughterwym has quit IRC | 15:40 | |
openstackgerrit | Sheel Rana proposed openstack/cinder: WADL to RST migration https://review.openstack.org/312113 | 15:41 |
*** adrianofr has quit IRC | 15:42 | |
ildikov | hemna: I hope so, most people accepted the invite | 15:43 |
scottda | hemna: Yes to meeting at 9:00 PDT; yes to code "shit" up (please watch potty language); Yes, probably needs spec to be pedantic, so we can bikeshed over the naming , etc. | 15:43 |
scottda | We can discuss at meeting, but it would certainly be more clear if the API was something like : get_new_connector(), update_connector(), get_connector_info() | 15:45 |
ildikov | hemna: BTW, did you manage to play with deleting check_attach from Nova? | 15:46 |
jgriffith | smcginnis: hemna ummmm | 15:46 |
*** Guest21288 has quit IRC | 15:46 | |
hemna | ildikov, I pulled the check_attach out but didn't get to test it much | 15:47 |
jgriffith | I'm already working on that as I pointed out yesterday | 15:47 |
jgriffith | Ok... I guess we can all just work in parallel | 15:47 |
jgriffith | submit and let people review/merge or whatever they want to do | 15:47 |
* jgriffith is so frustrated | 15:47 | |
scottda | jgriffith: Will you be at the hangout in 12 minutes (10:00 MDT)? | 15:48 |
hemna | jgriffith, sorry man I didn't know you were working on it. | 15:48 |
jgriffith | yes | 15:48 |
jgriffith | I'll be on the hangout | 15:48 |
hemna | I just threw that together yesterday simply to try it out and see what would happen. | 15:48 |
jgriffith | hey.. one thing I wanted to clairfy by the way | 15:48 |
jgriffith | currently multi-attach is a non-existent thing for all purposes | 15:48 |
jgriffith | there's no way to "use it" so it's sort of like non existent | 15:49 |
hemna | for Nova yah. | 15:49 |
jgriffith | even though it's been in Cinder's code base with a bunch of logic for 2 years :( | 15:49 |
smcginnis | If a tree falls in a forest and no one is there to hear it... | 15:49 |
*** salv-orlando has joined #openstack-cinder | 15:49 | |
jgriffith | LOL | 15:49 |
hemna | yah we all get that, that's why we've been working on the Nova side of things and seeing out to get it done. | 15:49 |
ildikov | smcginnis: lol, that's a good one :) | 15:49 |
Swanson | Can I get a map for the create_export, initialize_connection, hemna_initialize_connection_info and jg_initialize_connection_info? | 15:50 |
smcginnis | jgriffith: So your point is we can change things without being concerned about backward compat? | 15:50 |
jgriffith | hemna: well... it's a lot easier to fix this stuff if we just ignore that for now and fix things on the Cinder side | 15:50 |
jgriffith | smcginnis: yes, exactly | 15:50 |
smcginnis | +1 | 15:50 |
*** earlephilhower has joined #openstack-cinder | 15:50 | |
ildikov | for the API we have microversioning as well, which is also good so we will not break things like last time | 15:51 |
jgriffith | ildikov: hehe :) | 15:51 |
jgriffith | ildikov: so just FYI, what i'm doing now is just trying to clean up attach/detach on the Cinder side and keeping it compatible | 15:52 |
* ildikov does not like breaking things that much, especially within Nova :) | 15:52 | |
jgriffith | ildikov: then follow up is the multi-attach additions | 15:52 |
ildikov | jgriffith: sounds cool | 15:52 |
jgriffith | ildikov: awww... come on where's the fun in not breaking things! | 15:52 |
*** apoorvad has joined #openstack-cinder | 15:53 | |
* jgriffith has been breaking things since he was a kid | 15:53 | |
ildikov | jgriffith: I think with scottda and hemna we touched on check_attach a few times as we hope it can be removed from Nova | 15:53 |
jgriffith | like the time I wanted to see how my dads stereo worked, so I took it all apart in the living room one day | 15:53 |
*** ircuser-1 has quit IRC | 15:53 | |
ildikov | jgriffith: just to try to simplify things | 15:53 |
ildikov | no code yet, just checking the diagrams and the code in Nova | 15:54 |
jgriffith | ildikov: got ya | 15:54 |
smcginnis | I can picture little Johnny getting into a lot of trouble. :)( | 15:54 |
openstackgerrit | Merged openstack/cinder: ibm flashsystem: Fixing hardcoded attribute https://review.openstack.org/309208 | 15:54 |
jgriffith | smcginnis: yes... LOTS | 15:54 |
jgriffith | smcginnis: 7 year old with a screw driver and a BUNCH of discrete components laying on the floor | 15:54 |
jgriffith | smcginnis: never could get that thing back together :) | 15:54 |
ildikov | jgriffith: I'm an only child and happened to be a girl, so all eyes were on me constantly without breaking anything | 15:54 |
jgriffith | ildikov: LOL | 15:55 |
ildikov | jgriffith: so I didn't need it ;) | 15:55 |
johnthetubaguy | just curious, why do we want to drop check attach? | 15:55 |
jgriffith | johnthetubaguy: you'll have to ask hemna and scottda | 15:55 |
jgriffith | and ildikov | 15:55 |
jgriffith | I missed that conversation | 15:55 |
scottda | johnthetubaguy: Because it's racy and superfluous | 15:55 |
ildikov | johnthetubaguy: it seems that we have the logic in reserve_volume on Cinder side | 15:55 |
jgriffith | scottda: that's not a real explanation/reason... can you elaborate? | 15:55 |
johnthetubaguy | OK, so you want cinder to "own" if the attach is allowed? | 15:56 |
ildikov | and what scottda says :) | 15:56 |
scottda | We check attach, then when we call reserve_volume(), the state may have changes and cinder checks the attach state again. | 15:56 |
hemna | johnthetubaguy, it's racy and contains checks against the 'state' of the volume | 15:56 |
*** arch-nemesis has quit IRC | 15:56 | |
hemna | it's one of the major complaints that was raised in Friday's meeting | 15:56 |
ildikov | johnthetubaguy: it would be good to have only component responsible for it and Cinder looks like a logical choice | 15:56 |
ildikov | *one | 15:56 |
hemna | is that nova shouldn't care about the state management of cinder volumes. | 15:56 |
hemna | nova should simply call reserve | 15:56 |
johnthetubaguy | yep, I like the "let cinder" worry about it approach | 15:57 |
hemna | cinder does all of those checks already in reserve | 15:57 |
hemna | minus the availability zone check | 15:57 |
johnthetubaguy | the follow question is on error handling, do we understand the errors properly on the nova size | 15:57 |
johnthetubaguy | side | 15:57 |
scottda | I think we can discuss this at the design-of-cinder level at the meeting: Should Nova care about Cinder state? Should Cinder care about what Nova(or Ironic, etc) does with an attachment? | 15:57 |
hemna | nova shouldn't have to understand the internal states of cinder volumes. | 15:58 |
*** akshai has quit IRC | 15:58 | |
ildikov | if we can agree on these points we can then move forward and see the impacts | 15:58 |
ildikov | hemna: +1 | 15:58 |
johnthetubaguy | I am all for making the interface between nova and cinder much cleaner and less racy | 15:58 |
*** akshai has joined #openstack-cinder | 15:59 | |
hemna | johnthetubaguy, that's all part of this IMHO. | 15:59 |
johnthetubaguy | totally | 15:59 |
ildikov | johnthetubaguy: that's what motivated us to think about this as well | 15:59 |
hemna | it's kinda what the whole virtual volume idea was trying to accomplish from nova's perspective. | 16:00 |
johnthetubaguy | stepping back and deciding how you want Nova to interact with you is a good idea | 16:00 |
smcginnis | Meeting time? | 16:00 |
*** martyturner has quit IRC | 16:00 | |
*** lpetrut has quit IRC | 16:01 | |
smcginnis | Shoot, can't find the hangout link. Can someone DM it to me? | 16:01 |
scottda | smcginnis: johnthetubaguy Are you joining? | 16:01 |
hemna | smcginnis, https://hangouts.google.com/hangouts/_/z4ulm6fupfezlgixwv6uugkx3ue | 16:01 |
smcginnis | hemna: Thanks | 16:01 |
johnthetubaguy | yeah, I forgot it was a hangout | 16:02 |
ildikov | johnthetubaguy: we hoped we can be more productive this way for now | 16:02 |
johnthetubaguy | its a good idea | 16:02 |
*** ivase has joined #openstack-cinder | 16:03 | |
*** jwcroppe has joined #openstack-cinder | 16:04 | |
*** martyturner has joined #openstack-cinder | 16:04 | |
*** Julien-zte has quit IRC | 16:05 | |
*** raunak has joined #openstack-cinder | 16:05 | |
*** jwcroppe_ has joined #openstack-cinder | 16:05 | |
hemna | my mic lights are working | 16:06 |
*** garthb has joined #openstack-cinder | 16:08 | |
*** yangyapeng has quit IRC | 16:08 | |
*** yangyape_ has joined #openstack-cinder | 16:08 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Add devref for conditional updates https://review.openstack.org/313040 | 16:08 |
*** nnex has joined #openstack-cinder | 16:09 | |
*** jwcroppe has quit IRC | 16:09 | |
*** akapil has joined #openstack-cinder | 16:10 | |
*** raunak has quit IRC | 16:10 | |
*** raunak has joined #openstack-cinder | 16:12 | |
*** medberry is now known as med_ | 16:14 | |
*** akapil has quit IRC | 16:14 | |
*** vgridnev has quit IRC | 16:15 | |
ameade | hey sheel, have you started on the pagination stuff yet? | 16:18 |
sheel | yes, half way to it | 16:19 |
ameade | i wouldn't mind knocking that out today | 16:19 |
ameade | kk | 16:19 |
sheel | ameade: testing is left for same...else things are almost complete.. | 16:19 |
sheel | ameade: most probabely will push today | 16:19 |
ameade | k cool :) | 16:19 |
openstackgerrit | Rajini Ram proposed openstack/cinder: Dell Eqlx: Volume from snapshot now honors resize https://review.openstack.org/312160 | 16:20 |
*** vgridnev has joined #openstack-cinder | 16:20 | |
*** vgridnev has quit IRC | 16:21 | |
openstackgerrit | Xinli Guan proposed openstack/cinder: Make IBM drivers return snapshot object for cg ops https://review.openstack.org/268283 | 16:21 |
*** salv-orlando has quit IRC | 16:23 | |
*** igornsa has joined #openstack-cinder | 16:24 | |
*** kmartin has quit IRC | 16:27 | |
*** nnex has quit IRC | 16:28 | |
*** sdake_ has joined #openstack-cinder | 16:29 | |
*** nnex has joined #openstack-cinder | 16:29 | |
hemna | johnthetubaguy, https://review.openstack.org/#/c/312773/ | 16:30 |
*** daneyon has quit IRC | 16:30 | |
*** sdake has quit IRC | 16:31 | |
*** dustins has quit IRC | 16:31 | |
*** dustins has joined #openstack-cinder | 16:32 | |
*** salv-orlando has joined #openstack-cinder | 16:35 | |
*** dustins has quit IRC | 16:36 | |
*** jwcroppe_ has quit IRC | 16:37 | |
*** crose has quit IRC | 16:39 | |
*** jwcroppe has joined #openstack-cinder | 16:39 | |
*** kmartin has joined #openstack-cinder | 16:40 | |
*** akshai has quit IRC | 16:44 | |
johnthetubaguy | https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L273 | 16:45 |
ildikov | johnthetubaguy: https://review.openstack.org/#/c/267587/22/nova/virt/block_device.py | 16:45 |
*** akshai has joined #openstack-cinder | 16:47 | |
openstackgerrit | Merged openstack/cinder: Add ordering possibilities to conditional update https://review.openstack.org/231936 | 16:48 |
*** akshai has quit IRC | 16:52 | |
ameade | smcginnis: DuncanT: whoever else: the messages client patch should be gtg https://review.openstack.org/#/c/299052/ | 16:52 |
*** crinkle has joined #openstack-cinder | 16:52 | |
*** martyturner has quit IRC | 16:52 | |
*** martyturner has joined #openstack-cinder | 16:52 | |
smcginnis | ameade: Thanks, I'll add it to my list. | 16:52 |
ameade | smcginnis: do it now! | 16:53 |
ameade | lol | 16:53 |
smcginnis | ameade: ;) | 16:53 |
*** jwcroppe has quit IRC | 16:53 | |
*** akshai has joined #openstack-cinder | 16:54 | |
*** daneyon has joined #openstack-cinder | 16:54 | |
*** jwcroppe_ has joined #openstack-cinder | 16:55 | |
*** martyturner has quit IRC | 16:57 | |
*** adrianofr has joined #openstack-cinder | 16:57 | |
*** lpetrut has joined #openstack-cinder | 16:58 | |
*** daneyon has quit IRC | 17:00 | |
*** cknight has quit IRC | 17:00 | |
*** sdake_ has quit IRC | 17:00 | |
*** cknight has joined #openstack-cinder | 17:01 | |
* scottda adds to his list and hopes not to incur the wrath of ameade | 17:03 | |
*** rlrossit has quit IRC | 17:03 | |
*** martyturner has joined #openstack-cinder | 17:03 | |
*** daneyon has joined #openstack-cinder | 17:05 | |
*** jwcroppe_ has quit IRC | 17:07 | |
*** igornsa has quit IRC | 17:07 | |
*** jwcroppe has joined #openstack-cinder | 17:08 | |
*** daneyon_ has joined #openstack-cinder | 17:09 | |
*** akapil has joined #openstack-cinder | 17:11 | |
*** daneyon has quit IRC | 17:13 | |
*** jistr has quit IRC | 17:17 | |
openstackgerrit | Merged openstack/cinder: Updated from global requirements https://review.openstack.org/310827 | 17:21 |
*** suyash has joined #openstack-cinder | 17:21 | |
openstackgerrit | Merged openstack/cinder: NetApp: Use Local Cache to Copy an Available Image https://review.openstack.org/309202 | 17:21 |
Swanson | The new pycharm is slower than a 1 legged ant carrying a slug carrying a sloth. | 17:21 |
openstackgerrit | Merged openstack/cinder: Fix gate-cinder-tox-db-functional job https://review.openstack.org/312875 | 17:22 |
Swanson | (cue banjo solo.) | 17:22 |
smcginnis | Swanson: Nice visualization. | 17:22 |
Swanson | smcginnis, it might be underselling how slow it is. Tempted to go back a rev. | 17:24 |
*** fedruantine has quit IRC | 17:24 | |
*** rlrossit has joined #openstack-cinder | 17:25 | |
*** dustins has joined #openstack-cinder | 17:27 | |
patrickeast | Swanson: its sooo bad, i went back to 5.0.4 (the january release) | 17:30 |
*** jwcroppe_ has joined #openstack-cinder | 17:32 | |
Swanson | patrickeast, The intelligent paste bit doesn't comprehend mock syntax and the ctrl-alt-shift-v requires finger physical therapy every third time I hit it. | 17:32 |
*** jwcroppe has quit IRC | 17:34 | |
*** bardia has joined #openstack-cinder | 17:46 | |
*** itlinux has joined #openstack-cinder | 17:52 | |
*** akapil has quit IRC | 17:54 | |
*** jwcroppe has joined #openstack-cinder | 17:55 | |
cFouts | e0ne: thanks for the review on 309202 | 17:57 |
*** arch-nemesis has joined #openstack-cinder | 17:57 | |
*** jwcroppe_ has quit IRC | 17:58 | |
*** ivase has quit IRC | 17:58 | |
*** cknight has quit IRC | 18:03 | |
*** cknight has joined #openstack-cinder | 18:04 | |
*** akapil has joined #openstack-cinder | 18:04 | |
*** martyturner has quit IRC | 18:07 | |
xinli | patrickeast: I fixed two test cases regarding the invalid UUIDs, and submit the patch, but Jenkins failed in gate-tempest-dsvm-neutron-full, I reviewed the log, it seems nothing to do with my code, does anyone in cinder community hits the issue? https://review.openstack.org/#/c/268283/ | 18:10 |
*** salv-orlando has quit IRC | 18:11 | |
*** martyturner has joined #openstack-cinder | 18:11 | |
xinli | patrickeast: the root cause is the system timeout issue: failed. Error: Connection to the 172.24.5.120 via SSH timed out. | 18:13 |
*** lpetrut has quit IRC | 18:15 | |
smcginnis | xinli: Sounds like it's not related to your patch. | 18:16 |
smcginnis | xinli: Leave a comment of "recheck" and it will trigger jenkins to run the tests again. | 18:17 |
jgriffith | xinli: smcginnis net timeout looks like http://logs.openstack.org/83/268283/3/check/gate-tempest-dsvm-neutron-full/4ec56c1/console.html#_2016-05-05_17_20_13_227 | 18:17 |
*** nnex has quit IRC | 18:17 | |
smcginnis | Interestingly enough, I've been hitting that in my ci. | 18:17 |
jgriffith | haven't seen those for a while, thought they might be gone :( | 18:17 |
smcginnis | I wonder if something up with that. | 18:17 |
*** jwcroppe has quit IRC | 18:18 | |
jgriffith | smcginnis: you running neutron full tests? | 18:18 |
smcginnis | jgriffith: No, not even neutron at all. But getting connection timeouts similar to that. | 18:18 |
*** nnex has joined #openstack-cinder | 18:19 | |
xinli | @smcginnis: I reviewed the log, the root cause is Connetion issue: tempest.lib.exceptions.SSHTimeout: Connection to the 172.24.5.120 via SSH timed out. | 18:19 |
xinli | 2016-05-05 17:20:13.140 | User: cirros, Password: None | 18:19 |
*** Nakato has quit IRC | 18:19 | |
jgriffith | smcginnis: :( | 18:20 |
jgriffith | xinli: it is almost definitely not related to your patch | 18:21 |
jgriffith | xinli: best thing is wait a while and run "recheck" | 18:21 |
smcginnis | jgriffith: Yeah, my CI hasn't been happy for over a week now. I might have to revert my driver soon if I don't get this figured out. ;) | 18:21 |
patrickeast | lol | 18:21 |
jgriffith | LOL | 18:21 |
smcginnis | And it had been running so good for a long stretch there! | 18:22 |
jgriffith | seems like we've all been there at some point or another | 18:22 |
*** Nakato has joined #openstack-cinder | 18:22 | |
patrickeast | xinli: yea i agree with jgriffith and smcginnis, more than likely not anything to do with your change | 18:22 |
jgriffith | smcginnis: I know.. I get soooo mad when something goes goofy after a couple hundred succesful runs in a row | 18:22 |
xinli | jgriffith: thanks | 18:22 |
patrickeast | my ci is still being racked up at its new home | 18:22 |
* patrickeast hopes no one notices how long its been mia | 18:22 | |
jgriffith | patrickeast: you guys move your labs? | 18:22 |
* jgriffith warms up the revert button | 18:22 | |
smcginnis | patrickeast: Does its new home have a nice shiny Cisco switch in it? :) | 18:22 |
patrickeast | jgriffith: yea we switched to a new colo for our engineering hardware | 18:22 |
*** nnex has quit IRC | 18:23 | |
jgriffith | patrickeast: ahh... good times!! | 18:23 |
patrickeast | smcginnis: haha, yea the same ones as before... but now actually connected to things | 18:23 |
*** dustins has quit IRC | 18:24 | |
*** akapil has quit IRC | 18:25 | |
*** lpetrut has joined #openstack-cinder | 18:26 | |
*** akapil has joined #openstack-cinder | 18:26 | |
thingee | smcginnis: I thought the midcycle was july 19-21 according to http://eavesdrop.openstack.org/meetings/cinder/2016/cinder.2016-05-04-16.00.html - but your tweet says july 19-22 https://twitter.com/SeanTMcGinnis/status/727912062161018880 | 18:28 |
smcginnis | thingee: Yep: "Cinder midcycle July 19-21, hackday July 22. (FOR REAL)" | 18:29 |
smcginnis | So the 22nd is just an optional day for those that want to work on things. | 18:29 |
thingee | ah ha got it | 18:29 |
*** e0ne has quit IRC | 18:32 | |
scottda | Has anyone seen Vincent Hou lately? | 18:34 |
smcginnis | scottda: I heard he was moving to another group. | 18:35 |
smcginnis | scottda: I spoke with him briefly a couple weeks ago, but haven't seen him around much. | 18:35 |
scottda | eharney: Did you have info on how to CI Tempest tests (using the community CI) prior to merge (as needed by https://review.openstack.org/#/c/195443/ ) | 18:35 |
scottda | smcginnis: Thanks. He was/is at IBM? | 18:36 |
smcginnis | scottda: Yes, still there, but not going to be working on Cinder apparently. | 18:37 |
*** dustins has joined #openstack-cinder | 18:37 | |
eharney | scottda: i can probably help sort that out, what do you need to know? | 18:38 |
eharney | scottda: ohh, right, how to execute them etc before merge | 18:38 |
scottda | eharney: I want to get CI running on that patch ^^^ to get it into Tempest | 18:38 |
eharney | scottda: i can show you how i was doing this for volume manage/unmanage | 18:39 |
scottda | eharney: That'd be great. | 18:39 |
patrickeast | scottda: i think you would need to have a patch up that configures jenkins w/ cinder jobs to do multi-backend first as a dependency (otherwise you aren't able to migrate anywhere, right?) | 18:39 |
patrickeast | scottda: then you can show it running on cinder gate to show the tests being run and passing | 18:40 |
*** esker has joined #openstack-cinder | 18:40 | |
*** esker has quit IRC | 18:40 | |
scottda | patrickeast: Right. And we were going to work on that. Will you have time to discuss this at some point? | 18:41 |
patrickeast | scottda: yep, just let me know when | 18:42 |
patrickeast | scottda: i'll be out of town most of next week though | 18:42 |
eharney | scottda: so looking at my patches, i don't think i ever got it wired up all the way to really work (and it's moving around a bit now since i'm adding the test to Cinder instead of tempest) | 18:42 |
scottda | eharney: OK. I'll work with patrickeast on getting stuff in place first, then ping you if needed. | 18:43 |
eharney | scottda: https://review.openstack.org/#/c/223188/ is the top of the chain | 18:43 |
patrickeast | eharney: scottda: that brings up a good point, should those migrate tests even go into tempest? or just into cinders tempest plugin? | 18:43 |
scottda | patrickeast: Migrate calls Nova swap_volume, so should be in Tempest I think. | 18:44 |
patrickeast | scottda: oh, its doing live volume migrates? | 18:44 |
* patrickeast should probably read through the patch | 18:44 | |
patrickeast | scottda: in that case, yea tempest it is | 18:45 |
scottda | patrickeast: I need to read through it myself, but if it does not test this, I'll add something that does. | 18:45 |
*** esker has joined #openstack-cinder | 18:45 | |
patrickeast | scottda: yea def, we need both scenarios covered | 18:45 |
eharney | patrickeast: btw, i looked more into adding new methods to tempest.lib's volumes client, it got confusing quite quickly. did you have code where you've done that? | 18:46 |
patrickeast | eharney: all the ones i did were extending the class... lemmie see if i can just dump it on github, one sec | 18:47 |
*** sdake has joined #openstack-cinder | 18:48 | |
patrickeast | eharney: heres a gist of some of that stuff https://gist.github.com/patrick-east/e6b4d0dc69ae357c00bcfe802dc1cc81 | 18:50 |
patrickeast | eharney: shows a couple of the clients, and how they are created/used in tests | 18:50 |
patrickeast | eharney: i didn't modify the existing ones directly though, so these ones all end up with their own credentials/project/etc | 18:51 |
thingee | all booked for the midcycle | 18:51 |
eharney | patrickeast: cool... one thing i wasn't sure about was whether it was reasonable to directly import the clients from tempest or not | 18:51 |
thingee | \o/ | 18:51 |
smcginnis | thingee: Glad we were able to work out a time that allowed that. :) | 18:52 |
patrickeast | eharney: the docs i read made it seem like using the python-*client modules was a no-no, but i'm not sure how hard a rule it is | 18:52 |
patrickeast | eharney: everywhere else in there they are rolling the requests by hand in the tempest clients | 18:52 |
eharney | patrickeast: i mean the tempest.services.volume.base etc | 18:52 |
smcginnis | patrickeast: Maybe less of a restriction with having our plugin model? | 18:52 |
patrickeast | eharney: ohh yea, i dunno | 18:52 |
eharney | patrickeast: the reason that tempest says don't do that is because they're specifically trying to be an independent client | 18:53 |
patrickeast | eharney: i took some liberties there, it was also unclear | 18:53 |
patrickeast | eharney: i followed what manilla did as best i could | 18:53 |
eharney | patrickeast: looks good to me :) | 18:53 |
patrickeast | https://github.com/openstack/manila/tree/master/manila_tempest_tests | 18:53 |
eharney | yeah, i studied theirs a bit too | 18:53 |
*** mvk_ has quit IRC | 18:54 | |
*** sdake_ has joined #openstack-cinder | 18:55 | |
*** martyturner has quit IRC | 18:55 | |
*** sdake has quit IRC | 18:57 | |
*** xinli has quit IRC | 18:57 | |
sheel | ameade: hey | 18:57 |
sheel | ameade: WIP for pagination : https://review.openstack.org/#/c/313113/ | 18:57 |
ameade | ty will have a look | 18:58 |
sheel | ameade: I could not test it so kept it WIP for now.. | 18:58 |
sheel | ok | 18:58 |
*** martyturner has joined #openstack-cinder | 18:58 | |
*** timcl1 has joined #openstack-cinder | 19:00 | |
*** akapil has quit IRC | 19:00 | |
*** timcl has quit IRC | 19:03 | |
*** ducttape_ has joined #openstack-cinder | 19:03 | |
*** haplo37 has joined #openstack-cinder | 19:04 | |
ducttape_ | I'm a lost horizon person that has a cinder related change, which might be of interest to cinder team. Anyone interested ? | 19:04 |
ducttape_ | (it's a horizon change in how cinder quotas / usage works) | 19:05 |
patrickeast | oh man, i was with you right up until quotas | 19:05 |
* patrickeast runs away | 19:05 | |
ducttape_ | don't worry, it's not that turrible | 19:05 |
patrickeast | do you have a patch or bug or something for it? | 19:06 |
ducttape_ | https://review.openstack.org/#/c/309204/ is the change, but essentially we have a problem when we have multiple storage backends | 19:06 |
smcginnis | ducttape_: Cool, what are you changing? | 19:06 |
ducttape_ | the problem being, our users access horizon and say "cool - I have 500 GB left to use".... but what they do not see is that they have 0 GB of SSD left, but like 500GB of HDD left | 19:07 |
ducttape_ | something like that at least | 19:07 |
patrickeast | ahh yea, that sounds like a good change | 19:07 |
ducttape_ | so the change is on the horizon over page to have the pie charts display to users "you have 50% left of SSD, 20% left of HDD" etc | 19:08 |
ducttape_ | there would be a follow on change for admins to be able to change per backend quotas too, but that is a follow on | 19:08 |
ducttape_ | right now we are having quota issues and it's not very apparent what is going on, this is just to provide better insight | 19:08 |
*** akapil has joined #openstack-cinder | 19:09 | |
*** akapil has quit IRC | 19:09 | |
ducttape_ | I bring this, so maybe this team / group can chime in with horizon cores as to the usefulness etc of this change | 19:09 |
ducttape_ | to coordinate, and make openstack great again™® | 19:09 |
* ducttape_ hopes he does not troll too hard | 19:10 | |
patrickeast | haha | 19:10 |
patrickeast | i'll take a look at it this afternoon, but i'm on board with it... seems like a pretty solid improvement | 19:10 |
ducttape_ | anyway, you might have horizon developers local to you, could pull down the patch above... and see what you think etc | 19:10 |
*** akapil has joined #openstack-cinder | 19:11 | |
*** akapil has quit IRC | 19:11 | |
ducttape_ | thanks for any input / feedback / spoiled fruit thrown | 19:11 |
*** akapil has joined #openstack-cinder | 19:11 | |
eharney | any taskflow wizards around that could help me debug a MissingDependencies issue? http://paste.openstack.org/raw/496261/ | 19:13 |
*** jwcroppe has joined #openstack-cinder | 19:13 | |
eharney | harlowja: ^ | 19:13 |
* ducttape_ lurks back into horizon room | 19:13 | |
*** ducttape_ has left #openstack-cinder | 19:13 | |
*** akshai has quit IRC | 19:14 | |
*** akshai has joined #openstack-cinder | 19:14 | |
*** akapil has quit IRC | 19:14 | |
openstackgerrit | Merged openstack/cinder: VMware: Support for paraVirtual image adapter type https://review.openstack.org/312761 | 19:18 |
scottda | Has anyone ever tried to add CONF for multi-backend in tempest? We're just wondering why it's not in there....for tempest/api/volume/test_multi_backend.py | 19:19 |
patrickeast | eharney: i vaguely recall hitting stuff like that from working on the image cache in the volume flow, somewhere in the flow you define what things are inputs and outputs of each task and they need to match up or you get errors like that | 19:19 |
eharney | patrickeast: well, this is just on a straight mitaka deployment, i'm not even trying to work on any code :/ | 19:20 |
-openstackstatus- NOTICE: Gerrit is restarting to address performance issues related to a suspected memory leak | 19:20 | |
patrickeast | eharney: oh, thats not good | 19:20 |
*** jwcroppe has quit IRC | 19:21 | |
*** xinli has joined #openstack-cinder | 19:21 | |
patrickeast | eharney: so like, https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L237 defines what is required... and I think if those haven't been put into the tasks like context or whatever you get failures https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L924 | 19:22 |
mtanino | umm, Tons of merge failed.... | 19:22 |
patrickeast | eharney: in that case the create_what has the variables its looking for in the requires thingy | 19:22 |
patrickeast | eharney: i'm sure theres more to it though | 19:22 |
eharney | patrickeast: yeah, i see the basic pieces there that are supposed to link together, i just don't know the code well enough yet to see why they aren't | 19:22 |
ildikov | scottda: jgriffith hemna mriedem johnthetubaguy: I sent out the minutes of meeting as a response to Matt's recap on Cinder/Nova from last week | 19:24 |
ildikov | please take a look if you have time and add/correct if needed | 19:24 |
mriedem | thanks | 19:24 |
* mriedem has to leave now | 19:24 | |
*** mriedem has quit IRC | 19:25 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Add Cheesecake APIs to policy.json file https://review.openstack.org/313124 | 19:26 |
*** akapil has joined #openstack-cinder | 19:26 | |
mtanino | jgriffith: hi, | 19:27 |
*** e0ne has joined #openstack-cinder | 19:27 | |
ameade | hey, i want to alter a column in a db migration, tests blow up saying thats not allowed | 19:27 |
ameade | what are my options? | 19:28 |
*** jwcroppe has joined #openstack-cinder | 19:28 | |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Use _in_use() to check for in-use volumes https://review.openstack.org/289878 | 19:28 |
*** akshai has quit IRC | 19:29 | |
*** akshai has joined #openstack-cinder | 19:30 | |
openstackgerrit | Tom Swanson proposed openstack/cinder: Dell SC: Added support for failover_host failback https://review.openstack.org/310064 | 19:30 |
*** raunak has quit IRC | 19:31 | |
openstackgerrit | Rajini Ram proposed openstack/cinder: Dell Eqlx: Volume from snapshot now honors resize https://review.openstack.org/312160 | 19:31 |
openstackgerrit | Clinton Knight proposed openstack/cinder: NetApp: Managing cDOT LUN by UUID fails https://review.openstack.org/312684 | 19:32 |
*** mvk_ has joined #openstack-cinder | 19:32 | |
openstackgerrit | Clinton Knight proposed openstack/cinder: NetApp: Decouple capacity volume stats collection https://review.openstack.org/312927 | 19:33 |
ameade | just adding an exception | 19:35 |
scottda | ildikov: Looks good. Thanks for doing that. | 19:35 |
patrickeast | eharney: looking at https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L595-L601 if you got an exception there it wouldn't be putting 'reservations' into the flows store or whatever | 19:35 |
ildikov | scottda: cool, thanks for checking | 19:36 |
patrickeast | eharney: which is probably why that next create entry one got upset | 19:36 |
eharney | patrickeast: yeah, i'm suspecting there's an earlier failure here that isn't getting logged | 19:36 |
*** chris_morrell has joined #openstack-cinder | 19:39 | |
*** jwcroppe has quit IRC | 19:39 | |
eharney | patrickeast: i downgraded to an older taskflow package and it went away.... hmmmmm | 19:41 |
patrickeast | ruh oh | 19:41 |
patrickeast | well... at least its relatively easy to fix then, unless someone else has a dependency on the newer taskflow | 19:42 |
eharney | like cinder-scheduler, which is now broken in a different way :) | 19:42 |
patrickeast | haha | 19:42 |
eharney | but... useful data point | 19:42 |
openstackgerrit | Tom Swanson proposed openstack/cinder: Dell SC: Added support for failover_host failback https://review.openstack.org/310064 | 19:44 |
*** jwcroppe has joined #openstack-cinder | 19:44 | |
openstackgerrit | Gyorgy Szombathelyi proposed openstack/cinder: Improve readabilty of CA verifying code https://review.openstack.org/299361 | 19:49 |
openstackgerrit | Nate Potter proposed openstack/cinder: Implement backend usage reporting https://review.openstack.org/301444 | 19:52 |
*** gouthamr has quit IRC | 19:53 | |
*** e0ne has quit IRC | 19:55 | |
*** gouthamr has joined #openstack-cinder | 19:56 | |
*** akapil has quit IRC | 19:56 | |
*** martyturner has quit IRC | 19:56 | |
*** gouthamr has quit IRC | 19:56 | |
openstackgerrit | Alex O'Rourke proposed openstack/cinder: Fix 3PAR cg display name issues https://review.openstack.org/309443 | 19:57 |
*** jwcroppe_ has joined #openstack-cinder | 19:57 | |
openstackgerrit | Eric Harney proposed openstack/cinder: tempest: Add Unicode volume name test https://review.openstack.org/310925 | 19:58 |
*** martyturner has joined #openstack-cinder | 19:59 | |
*** akapil has joined #openstack-cinder | 20:00 | |
*** jwcroppe has quit IRC | 20:01 | |
*** timcl has joined #openstack-cinder | 20:01 | |
*** akapil has quit IRC | 20:01 | |
*** timcl1 has quit IRC | 20:03 | |
*** martyturner has quit IRC | 20:03 | |
*** raunak has joined #openstack-cinder | 20:05 | |
sheel | ameade: your option is to distribute this change in 3 releases | 20:06 |
sheel | If i remeber correctly, its like | 20:06 |
sheel | 1. add new column | 20:06 |
sheel | 2. copy data | 20:06 |
sheel | 3. rename column | 20:06 |
sheel | Live migration prohibit additive changes | 20:06 |
ameade | sheel: ah i see | 20:07 |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: WIP: Add image_conversion_cache_mode config for qemu-img https://review.openstack.org/312797 | 20:07 |
ameade | it looks like just setting a column to nullable is ok, dulek added an exception for mig 66 when he had to do the same | 20:07 |
sheel | yes | 20:07 |
sheel | its in 66 | 20:08 |
sheel | though you can add your script as exception for test | 20:08 |
sheel | :) | 20:08 |
*** jwcroppe_ has quit IRC | 20:09 | |
ameade | i got lucky | 20:09 |
sheel | hah! | 20:09 |
openstackgerrit | Alex Meade proposed openstack/cinder: Add prefix to user message event ids https://review.openstack.org/313140 | 20:10 |
ameade | sheel: ^ | 20:10 |
*** jkraj has quit IRC | 20:11 | |
sheel | so finally we are adding volume to event id | 20:12 |
sheel | I m happy | 20:12 |
patrickeast | jgriffith: hey, just saw your bug about initialize_connection https://bugs.launchpad.net/cinder/+bug/1578801 | 20:12 |
openstack | Launchpad bug 1578801 in Cinder "Inconsistent method signatures for initialize_connection in drivers" [Undecided,New] | 20:12 |
sheel | ameade: i ll look into it | 20:12 |
sheel | thnx for this change | 20:13 |
*** vgridnev has joined #openstack-cinder | 20:13 | |
patrickeast | jgriffith: i've actually been thinking about the whole initiator_data thing and how we are doing that... i'm a little concerned about it being racy, thinking towards A-A deployments | 20:13 |
patrickeast | jgriffith: and there not being a good way to lock around getting/setting the data for it, or having a clean way to do the conditional updates | 20:13 |
patrickeast | jgriffith: i guess the tl:dr; is that i might try and kill off that third parameter in favor of a helper method or something | 20:14 |
*** jwcroppe has joined #openstack-cinder | 20:17 | |
-openstackstatus- NOTICE: Gerrit is restarting to revert incorrect changes to test result displays | 20:28 | |
*** lpetrut has quit IRC | 20:32 | |
*** jungleboyj has quit IRC | 20:33 | |
*** cdelatte has quit IRC | 20:34 | |
*** crose has joined #openstack-cinder | 20:34 | |
*** sdake has joined #openstack-cinder | 20:35 | |
*** sdake_ has quit IRC | 20:36 | |
*** sdague has quit IRC | 20:37 | |
openstackgerrit | Nate Potter proposed openstack/cinder: Implement backend usage reporting https://review.openstack.org/301444 | 20:40 |
openstackgerrit | Tin Lam proposed openstack/cinder: Added 'volume:get_transfer' to policy.json file https://review.openstack.org/306856 | 20:40 |
openstackgerrit | Nate Potter proposed openstack/python-cinderclient: Implement cinder backend-usage command https://review.openstack.org/301445 | 20:40 |
openstackgerrit | Nate Potter proposed openstack/python-cinderclient: Implement cinder backend-usage command https://review.openstack.org/301445 | 20:43 |
mtanino | hemna: Thank you for the invitation :) | 20:43 |
openstackgerrit | Nate Potter proposed openstack/cinder: Implement backend usage reporting https://review.openstack.org/301444 | 20:43 |
openstackgerrit | Nate Potter proposed openstack/cinder: Implement backend usage reporting https://review.openstack.org/301444 | 20:46 |
*** akapil has joined #openstack-cinder | 20:47 | |
*** daneyon_ has quit IRC | 20:47 | |
*** jgregor has quit IRC | 20:49 | |
*** amit213 has joined #openstack-cinder | 20:50 | |
*** enriquetaso has joined #openstack-cinder | 20:50 | |
hemna | mtanino, :) | 20:50 |
*** dustins has quit IRC | 20:51 | |
openstackgerrit | John Griffith proposed openstack/cinder: Fix initialize_connection method signatures https://review.openstack.org/313154 | 20:51 |
*** akapil has quit IRC | 20:51 | |
*** jwcroppe has quit IRC | 20:52 | |
*** esker has quit IRC | 20:52 | |
*** jwcroppe has joined #openstack-cinder | 20:52 | |
*** vmtrooper has joined #openstack-cinder | 20:53 | |
openstackgerrit | Jay Mehta proposed openstack/cinder: 3PAR driver failure SR License missing in array https://review.openstack.org/304914 | 20:54 |
*** neophy has joined #openstack-cinder | 20:55 | |
*** porrua has quit IRC | 20:56 | |
jgriffith | tbarron: I was going to follow your lead an modify those files one at a time | 20:56 |
jgriffith | :) | 20:56 |
*** haplo37 has quit IRC | 20:57 | |
tbarron | jgriffith: i know you are kidding, but in general they were nothing like one file at a time. one directory often, or one driver | 20:57 |
*** esker has joined #openstack-cinder | 20:57 | |
xinli | @smcginnis: Jenkins shows my patch has a merge conflict, si there any tool to show me how to resolve the issue? or I need to manually git rebase by my self? https://review.openstack.org/#/c/307451/ | 20:58 |
hemna | jgriffith, should we just +A that patch before jenkins responds? | 20:58 |
*** rlrossit has quit IRC | 20:58 | |
hemna | :P | 20:58 |
tbarron | jgriffith: i did all api/contrib as one patch, but was told to break it up b/c it wa too big to review and had merge conflicts with tons of other patches | 20:59 |
openstackgerrit | Jay Mehta proposed openstack/cinder: Fix Lun ID 0 in HPE 3PAR driver https://review.openstack.org/309213 | 20:59 |
jgriffith | tbarron: I know.. I'm just messing with you. Sorry | 20:59 |
tbarron | jgriffith: oh, I see! :-) yours is +64/-63 !!! | 20:59 |
jgriffith | It's probably not funny like I think it is | 21:00 |
tbarron | jgriffith: i'm just tired and tired of uuids :-) | 21:00 |
jgriffith | tbarron: I know!!! I tried so hard to get it even, but stupid pep8 thwarted my efforts | 21:00 |
jgriffith | tbarron: LOL... I don't blame you | 21:00 |
*** baumann has quit IRC | 21:00 | |
Swanson | did someone remove volume_id from fake? | 21:00 |
jgriffith | tbarron: but I'm sure glad that you did it | 21:00 |
Swanson | Looking at you tbarron. | 21:00 |
tbarron | jgriffith: sorry to be dumb about taking the bait | 21:00 |
*** akapil has joined #openstack-cinder | 21:00 | |
jgriffith | tbarron: I for one would not have wanted to do that | 21:00 |
jgriffith | tbarron: that's alright, I'll stop making bad jokes | 21:01 |
jgriffith | tbarron: well.. I'll try | 21:01 |
tbarron | jgriffith: well, I won't stop. I've got to keep up with swansoon | 21:01 |
tbarron | swanson | 21:01 |
tbarron | soon | 21:01 |
smcginnis | swan song | 21:01 |
Swanson | xinli, probably manually git rebase. | 21:02 |
*** Lee1092 has quit IRC | 21:02 | |
*** lpetrut has joined #openstack-cinder | 21:03 | |
xinli | swanson: 1) git pull 2) git checkout myPatch 3) git rebase -i master? | 21:03 |
jgriffith | tbarron: oh.. you're on a slippery slope there | 21:03 |
tbarron | jgriffith: :-) | 21:03 |
*** rlrossit has joined #openstack-cinder | 21:04 | |
*** rcernin has joined #openstack-cinder | 21:05 | |
patrickeast | jgriffith: hey, you see my comment about the intiator_data stuff a little bit ago? | 21:06 |
patrickeast | jgriffith: was hoping to catch you before you went and added the param to all the drivers :( | 21:07 |
Swanson | xinli, yeah that looks right to me. | 21:07 |
*** lpetrut has quit IRC | 21:08 | |
*** akapil has quit IRC | 21:09 | |
harlowja | eharney u figure it out? | 21:09 |
harlowja | if not let me know | 21:09 |
*** dustins has joined #openstack-cinder | 21:11 | |
eharney | harlowja: no, i didn't | 21:11 |
harlowja | ya, some prior task not creating 'reservations' | 21:11 |
harlowja | eharney can u do pip freeze | grep networkx | 21:12 |
harlowja | i want to make sure u got the right version | 21:12 |
eharney | harlowja: well, this is a packaged deployment, it's got python-networkx-core-1.8.1-13.el7ost.noarch | 21:13 |
harlowja | ya, thats the issue i think | 21:13 |
openstackgerrit | Nate Potter proposed openstack/cinder: Implement backend usage reporting https://review.openstack.org/301444 | 21:13 |
harlowja | what version of taskflow eharney ? | 21:13 |
eharney | harlowja: 1.30 | 21:13 |
harlowja | eharney https://github.com/openstack/taskflow/blob/1.30.0/requirements.txt#L22 | 21:13 |
jgriffith | patrickeast: LOL | 21:13 |
jgriffith | patrickeast: so FYI I'm fine with that | 21:14 |
harlowja | so ya, networkx updated with ordered graphs, which taskflow uses, and that needs networkx >= 1.10 | 21:14 |
eharney | harlowja: ahh, great, that should be easy to sort out | 21:14 |
harlowja | 1.8 not new enough, so my guess packaged deployments of taskflow aren't right | 21:14 |
jgriffith | in fact I can stuff it into the attachment data, but that means an awful lot of churn in the drivers | 21:14 |
eharney | right | 21:14 |
patrickeast | jgriffith: stuff the initiator_data in there? | 21:15 |
harlowja | eharney so my guess is that if u run with 1.10 (via pip install) it will all work out, then i guess a package needs to be updated somewhere | 21:15 |
jgriffith | patrickeast: yeah | 21:15 |
patrickeast | jgriffith: my first question was to see if anyone other than pure ever used it for anything... | 21:15 |
jgriffith | don't know if that's good, bad or indifferent | 21:15 |
eharney | harlowja: will give it a shot, thanks a lot for the tip | 21:15 |
jgriffith | patrickeast: yeah... I don't know | 21:15 |
*** gouthamr has joined #openstack-cinder | 21:15 | |
harlowja | eharney np | 21:15 |
harlowja | whoever making those packages needs to check deps better :-P | 21:15 |
jgriffith | There's a descent number of folks that updated their methods, but not many actually usin git | 21:15 |
hemna | patrickeast, at one point we could have used it, but found a hack for it on our array | 21:15 |
jgriffith | using | 21:15 |
patrickeast | the biggest problem is that we cant lock around it, or do the fancy conditional db updates | 21:15 |
*** jgregor has joined #openstack-cinder | 21:16 | |
patrickeast | so like A-A c-vols both might try to set it | 21:16 |
patrickeast | and then things just break :( | 21:16 |
patrickeast | we can lock around the initialize_connection, but the get/set for the db are outside of it | 21:16 |
patrickeast | which would mean locks in the manager... | 21:16 |
jgriffith | patrickeast: not sure I follow the problem, but I'm not using that data so :) | 21:16 |
patrickeast | jgriffith: heh yea, its kind of a silly problem | 21:17 |
guitarzan | patrickeast: how do two managers get the same call? | 21:17 |
jgriffith | patrickeast: ok, oh well | 21:17 |
guitarzan | I'm not following either :) | 21:17 |
hemna | why do you need locks around initialize_connection ? | 21:17 |
jgriffith | sed is an easy tool, no big loss there | 21:17 |
hemna | I don't understand | 21:17 |
patrickeast | so like, if you have two c-vol nodes handling the same backend ala A-A HA to attach a volume to a host, both volumes going to the same compute node | 21:17 |
patrickeast | you can get concurrent initialize_connections | 21:18 |
patrickeast | for the same initator | 21:18 |
jgriffith | I'll wip that patch and ya'll can figure out if you want to use it or not | 21:18 |
patrickeast | but different volumes | 21:18 |
guitarzan | patrickeast: ah, different volumes | 21:18 |
guitarzan | got it | 21:18 |
hemna | hrmm, that seems like a failure up higher | 21:18 |
patrickeast | but we don't have a way to lock or synchronize the intiator data | 21:18 |
jgriffith | patrickeast: ummm... then something's wrong with our HA strategy IMO :) | 21:18 |
patrickeast | well yea | 21:18 |
patrickeast | thats what i want to fix | 21:18 |
hemna | why are we getting 2 simulataneous calls to the same target to initialize_connection ? | 21:18 |
jgriffith | patrickeast: once it gets to the manager we shouldn't have it go to another one I don't hink | 21:18 |
hemna | jgriffith, +1 | 21:18 |
guitarzan | two volumes, same target? | 21:19 |
patrickeast | well we do things on a volume granularity | 21:19 |
patrickeast | so like | 21:19 |
guitarzan | same initiator | 21:19 |
patrickeast | two volumes, one cinder backend | 21:19 |
patrickeast | same initiator | 21:19 |
jgriffith | guitarzan: ewww... you can't do that can you? | 21:19 |
guitarzan | jgriffith: no idea, but that's what he's saying :) | 21:19 |
hemna | oh wait | 21:19 |
patrickeast | yea so like volume A and volume B are on the same pure flash array | 21:19 |
*** jwcroppe has quit IRC | 21:19 | |
patrickeast | and you get requests to connect them to some instances | 21:19 |
patrickeast | both instances happen to be on the same compute node | 21:20 |
jgriffith | Ohhh... yeah, you have that requirement that eveyrthing has to be the same right? | 21:20 |
*** jwcroppe has joined #openstack-cinder | 21:20 | |
jgriffith | Ok | 21:20 |
patrickeast | yea since we are stashing CHAP info in there, its bad if one overwrites the others | 21:20 |
guitarzan | they multiplex different volumes on the same target? that's pretty wild :) | 21:20 |
jgriffith | well, another abandoned patch for me :) | 21:20 |
patrickeast | conditional updates totally fix it | 21:20 |
hemna | wouldn't you get a different target for different volumes ? | 21:21 |
hemna | I'm confused | 21:21 |
patrickeast | but we can't pass it in and pull it out of the return dictionary | 21:21 |
* patrickeast needs a whiteboard | 21:21 | |
*** timcl has quit IRC | 21:21 | |
hemna | heh | 21:21 |
openstackgerrit | Colleen Murphy proposed openstack/cinder: Mark the v1 API as deprecated https://review.openstack.org/309652 | 21:21 |
jgriffith | patrickeast: all I ask is that you do something "soon" | 21:22 |
hemna | patrickeast, along the same vein though, I don't think anything prevents 2 simultaneous initialize_connection calls for the same volume. | 21:22 |
jgriffith | patrickeast: I'm highly annoyed that we have the inconsistent method impl's that we have now | 21:22 |
patrickeast | hemna: in theory the *ing states and stuff geguileo is working on prevents that sort of thing... i hope | 21:22 |
guitarzan | hemna: true, for the silly migration case where it doesn't really follow the state workflow | 21:22 |
patrickeast | jgriffith: yea agreed | 21:22 |
hemna | patrickeast, I don't think there is anything in the api for initialize_connection to prevent it | 21:23 |
hemna | other than a check on status == maintenance | 21:24 |
patrickeast | hemna: huh, guess we should be checking for attaching status, right? | 21:24 |
hemna | yah | 21:24 |
*** jwcroppe has quit IRC | 21:24 | |
scottda | But, aside from live migration, you go through the nova api and check attaching status, and again in reserve_volume.. | 21:24 |
*** cdelatte has joined #openstack-cinder | 21:24 | |
hemna | but in the case of A-A HA, how do we prevent the same thing from happening against 2 c-vol nodes ? | 21:25 |
* hemna has a sad | 21:25 | |
*** andymaier has joined #openstack-cinder | 21:25 | |
scottda | How could you call initialize_connection 2x on the same volume, it's in "attaching" after the first one.. | 21:25 |
hemna | you really only want 1 of them to get the request (for the same volume) | 21:25 |
patrickeast | yea, they should sync up with the status checks using the db | 21:25 |
hemna | scottda, I'm not sure, but the cinder API doesn't prevent it at all | 21:26 |
patrickeast | the first one to have successfully changed status to attaching wins and gets to continue | 21:26 |
patrickeast | if we don't have code for it already we probably need to add that | 21:26 |
scottda | We expect a well-behaved client to go through reserve_volume(), which prevents this.... | 21:27 |
*** crose has quit IRC | 21:27 | |
hemna | well it prevents other type of actions | 21:27 |
scottda | But we could change the code to not expect a well-behaved client, and check state again in initialize_connection... | 21:27 |
*** crose has joined #openstack-cinder | 21:27 | |
hemna | but it doesn't prevent simultaneous initialize_connection calls on the same volume. | 21:27 |
scottda | But then, why not just have one call: reserve_and_initialize ? | 21:27 |
hemna | being handled by 2 different c-vol hosts | 21:27 |
*** crose has quit IRC | 21:27 | |
*** crose has joined #openstack-cinder | 21:28 | |
hemna | if all we do is check against the volume in 'attaching', both calls will go through | 21:28 |
hemna | maybe I'm paranoid | 21:28 |
hemna | nothing to see here....move along.... | 21:28 |
scottda | How? Gorka's patches make the checking and setting of "attaching" atomic | 21:28 |
scottda | Yes, you can call initialize_connection regardless of state. You are correct about that. | 21:29 |
hemna | sure, you get the volume into attaching state | 21:29 |
*** vgridnev has quit IRC | 21:29 | |
hemna | but you can still call initialize_connection | 21:29 |
hemna | even if we put a check on attaching state | 21:29 |
scottda | I agree. | 21:29 |
hemna | yup, the volume is in attaching | 21:29 |
hemna | here is another request for init_connection | 21:29 |
hemna | works | 21:29 |
scottda | Sure, we trust our callers (nova) | 21:30 |
hemna | and then you could have 2 c-vol instances (for the same backend/volume) handling the initalize_connection call | 21:30 |
hemna | :( | 21:30 |
scottda | So, we could modify the API to have one call: get_connector() which will not succeed in attaching. It sets to attaching (atomically), calls initialize_connection, returns a connector, and then set's to in-use. | 21:31 |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Add snapshot_metadata operations to policy.json https://review.openstack.org/313163 | 21:31 |
*** andymaier has quit IRC | 21:31 | |
scottda | Instead of NOva managing Cinder state, and hoping Ironic does the same, and future non-openStack user does the same, etc... | 21:31 |
hemna | oh well, I hate raising issues | 21:32 |
scottda | Raising issues is good. | 21:32 |
scottda | But it doesn't require HA and 2 c-vol nodes. You can call initialize_connection 100 times simultaneously for a single volume today, right? | 21:33 |
hemna | especially when jgriffith is working so hard to help shore this stuff up. | 21:33 |
hemna | scottda, yah | 21:33 |
hemna | you can | 21:33 |
*** rlrossit has quit IRC | 21:34 | |
scottda | So, we sketched out a new & improved API in Fort Collins last year...I think this is part of it. Just one call to Cinder to get the connector, without all the state management, and solve this problem at the same time....Might not happen soon, but it might be what we want. | 21:34 |
*** ametts has quit IRC | 21:34 | |
scottda | And of course deprecate and remove the old way...never. | 21:35 |
openstackgerrit | Tom Swanson proposed openstack/cinder: Dell SC: Added support for failover_host failback https://review.openstack.org/310064 | 21:35 |
*** vmtrooper has quit IRC | 21:36 | |
openstackgerrit | Alex Meade proposed openstack/python-cinderclient: Add v3 user messages https://review.openstack.org/299052 | 21:39 |
*** Guest2249 has quit IRC | 21:40 | |
jgriffith | Ya'll know what's funny.... | 21:41 |
Swanson | Shecky Green? | 21:41 |
jgriffith | Here's the original Cinder initialize_connection code in Cinder's manager: | 21:41 |
jgriffith | volume_ref = self.db.volume_get(context, volume_id) | 21:41 |
jgriffith | return self.driver.initialize_connection(volume_ref, connector) | 21:41 |
jgriffith | That's it | 21:42 |
guitarzan | heck ya | 21:42 |
jgriffith | just those two lines | 21:42 |
patrickeast | haha, wow | 21:42 |
*** jay-mehta has joined #openstack-cinder | 21:43 | |
jgriffith | oh, and by the way... all the other attach/detach related calls; pretty much the same thing | 21:43 |
jgriffith | manager.py was only 449 lines | 21:43 |
jgriffith | including blank lines, comments etc | 21:43 |
jgriffith | currently it's 3,710 | 21:43 |
guitarzan | wow, 320 | 21:43 |
guitarzan | 3200 | 21:43 |
guitarzan | oh 3700? sheesh | 21:43 |
* guitarzan looks again | 21:43 | |
guitarzan | ahh, liberty vs master | 21:44 |
jgriffith | guitarzan: I'm just looking at my vim status bar, +/- 10% I suppose :) | 21:44 |
patrickeast | maybe we should throw it all away and rewrite it in go ;) | 21:44 |
jgriffith | patrickeast: ha | 21:44 |
jgriffith | patrickeast: or maybe we should write better code :P | 21:44 |
scottda | Or at least remove every other line | 21:44 |
jgriffith | just saying | 21:44 |
patrickeast | haha | 21:44 |
Swanson | hemna put in 3261 or those lines? | 21:45 |
jgriffith | Swanson: I'm pretty sure it was a group effort :) | 21:45 |
guitarzan | haha | 21:45 |
*** jgregor has quit IRC | 21:45 | |
*** arch-nemesis has quit IRC | 21:45 | |
*** jwcroppe has joined #openstack-cinder | 21:45 | |
Swanson | My driver exploded by like 20% just adding failover-host failback to it. So these things happen. | 21:46 |
jgriffith | Swanson: indeed they do | 21:46 |
*** vmtrooper has joined #openstack-cinder | 21:46 | |
jgriffith | Swanson: but I don't know that our current architecture is going to take another two years of this sort of growth | 21:46 |
guitarzan | git can take it! | 21:47 |
jgriffith | guitarzan: true-dat... I guess as long as you can stuff it in git it must be OK :) | 21:47 |
jgriffith | anyway, just thought that was kind of an interesting historical data point | 21:48 |
jgriffith | I always remember guitarzan saying "the manager doesn't really do anything anyway" | 21:48 |
guitarzan | jgriffith: that might not be true anymore :) | 21:48 |
Swanson | Most of that is probably logging. | 21:48 |
jgriffith | guitarzan: :) | 21:48 |
jgriffith | Swanson: yeah, I'm sure you're right, at least 3,101 lines of it | 21:49 |
openstackgerrit | aimee.ukasick proposed openstack/cinder: Add missing SnapshotUnavailable to cinder/exception.py https://review.openstack.org/313166 | 21:49 |
*** sdake has quit IRC | 21:50 | |
*** sdake has joined #openstack-cinder | 21:51 | |
*** sdake has quit IRC | 21:56 | |
*** ametts has joined #openstack-cinder | 21:56 | |
hemna | hemna put in 3261 or those lines? | 21:56 |
hemna | shit | 21:56 |
hemna | really? | 21:56 |
hemna | lolz | 21:56 |
* hemna hides | 21:56 | |
*** crose has quit IRC | 22:10 | |
*** akshai has quit IRC | 22:12 | |
*** jwcroppe has quit IRC | 22:13 | |
*** eharney has quit IRC | 22:15 | |
*** Julien-zte has joined #openstack-cinder | 22:21 | |
*** cknight has quit IRC | 22:22 | |
*** cdelatte has quit IRC | 22:22 | |
*** apoorvad has quit IRC | 22:27 | |
openstackgerrit | Jay Mehta proposed openstack/cinder: Implement match-set type 3PAR FC VLUN creation https://review.openstack.org/309613 | 22:27 |
*** rcernin has quit IRC | 22:29 | |
openstackgerrit | Karthik Prabhu Vinod proposed openstack/cinder: Add ServiceTopic & ServiceDisabledReason Enum https://review.openstack.org/313179 | 22:30 |
*** hemna is now known as hemnafk | 22:30 | |
*** karthikp has joined #openstack-cinder | 22:31 | |
*** ametts has quit IRC | 22:35 | |
*** akerr has quit IRC | 22:37 | |
*** lprice has quit IRC | 22:39 | |
*** daneyon has joined #openstack-cinder | 22:40 | |
*** dustins has quit IRC | 22:42 | |
*** dustins has joined #openstack-cinder | 22:43 | |
*** karthikp has quit IRC | 22:44 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Make mountpoint parameter as an optional https://review.openstack.org/313180 | 22:44 |
*** garthb has quit IRC | 22:47 | |
*** garthb_ has joined #openstack-cinder | 22:47 | |
*** prometheanfire has joined #openstack-cinder | 22:48 | |
prometheanfire | mitaka suposed to work with python3.4 right? | 22:49 |
prometheanfire | if so, found a bug | 22:49 |
*** neophy has quit IRC | 22:50 | |
patrickeast | not sure cinder is supposed to be fully ready or still a WIP, either way bug reports are welcome | 22:50 |
*** cdelatte has joined #openstack-cinder | 22:51 | |
prometheanfire | https://gist.github.com/prometheanfire/ae1f0f128408e5f030b900d38fa108c3 | 22:51 |
patrickeast | looks like it is supposed to be according to https://wiki.openstack.org/wiki/Python3 | 22:51 |
prometheanfire | ya, that's what I get in 3.4 | 22:51 |
prometheanfire | I assumed it was based on that page | 22:51 |
*** david-lyle has quit IRC | 22:51 | |
prometheanfire | https://bugs.launchpad.net/cinder/+bug/1550951 | 22:52 |
openstack | Launchpad bug 1550951 in cinder (Gentoo Linux) "http header value must be a string" [Undecided,New] | 22:52 |
*** zzelle has joined #openstack-cinder | 22:52 | |
prometheanfire | lol, I already reported it | 22:52 |
*** apoorvad has joined #openstack-cinder | 22:53 | |
prometheanfire | wonder why this is happening again | 22:53 |
*** david-lyle has joined #openstack-cinder | 22:53 | |
*** salv-orlando has joined #openstack-cinder | 22:53 | |
*** salv-orlando has quit IRC | 22:54 | |
*** ducttape_ has joined #openstack-cinder | 22:54 | |
zzelle | Hi everyone | 22:54 |
*** salv-orlando has joined #openstack-cinder | 22:54 | |
prometheanfire | might need to be a change that needs backporting to mitaka | 22:55 |
zzelle | Some cores can look at https://review.openstack.org/300243, it's waiting for cores since a month? | 22:55 |
prometheanfire | checking now | 22:55 |
openstackgerrit | Xinli Guan proposed openstack/cinder: IBM FlashSystem: Cleanup host resource leaking https://review.openstack.org/307451 | 22:56 |
prometheanfire | ya, needs backporting | 22:57 |
*** david-lyle has quit IRC | 22:58 | |
scottda | patrickeast: prometheanfire We discussed the wiki page for python3 support, it seems to be a bit misleading... | 22:59 |
prometheanfire | ? | 22:59 |
scottda | I says "unit tests pass on python3" which is true... | 22:59 |
scottda | But it is not tested, except by prometheanfire | 22:59 |
scottda | BTW, if you are testing, can you look at this patch: https://review.openstack.org/#/c/304462 | 23:00 |
*** xinli has quit IRC | 23:01 | |
prometheanfire | sure | 23:01 |
prometheanfire | I just submitted the backport though | 23:01 |
* prometheanfire waits for it | 23:01 | |
prometheanfire | guess the bot is slow | 23:03 |
scottda | Well, if we're going to change that code, I just as soon change it, and then backport the change instead. | 23:03 |
prometheanfire | https://review.openstack.org/313183 | 23:03 |
prometheanfire | scottda: ya, just crossing the streams is all | 23:03 |
prometheanfire | scottda: seems to work | 23:03 |
scottda | sure. Sorry I didn't flag that for backport candidate. | 23:03 |
scottda | OK, cool. patrickeast You or anyone else interested in reviewing this: https://review.openstack.org/#/c/304462/1 | 23:04 |
prometheanfire | reviewed | 23:04 |
* prometheanfire shrugs | 23:04 | |
*** tpsilva has quit IRC | 23:07 | |
scottda | prometheanfire: Thanks for testing. I'll keep on people to get this new patch merged and backported. | 23:08 |
prometheanfire | thanks | 23:08 |
scottda | np, thanks for living on the cutting edge. | 23:08 |
prometheanfire | now that I'm cc'd I'll bug people too :P | 23:08 |
prometheanfire | I tend to do things slightly odd to find bugs | 23:08 |
prometheanfire | postgres and keystone for instance... | 23:09 |
*** daneyon has quit IRC | 23:11 | |
*** zzelle has quit IRC | 23:19 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Add upload_image API role-based access policy https://review.openstack.org/313186 | 23:21 |
*** sgotliv has quit IRC | 23:21 | |
*** lprice has joined #openstack-cinder | 23:23 | |
*** lcurtis has quit IRC | 23:24 | |
jgriffith | prometheanfire: hey there... are you still working on the Gentoo code for OpenStack? Or have I got the wrong person | 23:25 |
*** salv-orlando has quit IRC | 23:26 | |
jgriffith | prometheanfire: I've been working on trying to get a running version on Gentoo, kinda stuck on some things | 23:27 |
prometheanfire | it's me | 23:27 |
jgriffith | prometheanfire: oh... it's my lucky day :) | 23:27 |
prometheanfire | just submitted the stable req bug for mitaka | 23:27 |
jgriffith | prometheanfire: oh, nice! | 23:27 |
jgriffith | prometheanfire: ahh.. reading scroll-back now | 23:27 |
prometheanfire | it's been a month :P | 23:27 |
jgriffith | most excellent | 23:27 |
prometheanfire | I and the other users are in #gentoo-virtualization | 23:28 |
jgriffith | prometheanfire: and there's the answer to my next question | 23:28 |
jgriffith | fantastic | 23:28 |
prometheanfire | :P | 23:28 |
prometheanfire | I'm working on getting openstack-ansible working on gentoo | 23:28 |
*** mtanino has quit IRC | 23:30 | |
*** mtanino has joined #openstack-cinder | 23:30 | |
*** krotscheck has quit IRC | 23:31 | |
*** krotscheck has joined #openstack-cinder | 23:31 | |
*** gouthamr_ has joined #openstack-cinder | 23:31 | |
patrickeast | jgriffith: hey so how would something like https://gist.github.com/patrick-east/afed6c0e68da1a11f1ab85f19a46cb34 sit with you for that initiator_data thing | 23:32 |
*** skraynev has quit IRC | 23:32 | |
patrickeast | that code probably doesnt work.. but figured i should check before i spend too much time on it | 23:32 |
patrickeast | jgriffith: gets a few wins; less stuff in manager, unified method sig, ability for drivers to synchronize accessing the initator_data | 23:33 |
patrickeast | jgriffith: downside being that it kinda sorta lets drivers access the db | 23:33 |
*** mriedem has joined #openstack-cinder | 23:34 | |
*** cdelatte has quit IRC | 23:34 | |
*** gouthamr has quit IRC | 23:36 | |
*** Julien-zte has quit IRC | 23:41 | |
*** EinstCrazy has quit IRC | 23:48 | |
*** jbernard has quit IRC | 23:48 | |
*** jbernard has joined #openstack-cinder | 23:49 | |
*** enriquetaso has quit IRC | 23:51 | |
jgriffith | patrickeast: looking | 23:51 |
*** enriquetaso has joined #openstack-cinder | 23:52 | |
jgriffith | BTW.. funny ABC doesn't puke when your signature is different there :) | 23:52 |
patrickeast | haha yea | 23:53 |
jgriffith | patrickeast: so interestingly enough I just started a sort of driver_utils file | 23:54 |
jgriffith | patrickeast: so I think that must mean we "need" something like that :) | 23:54 |
patrickeast | jgriffith: oh nice, yea i'm happy to toss that stuff wherever | 23:54 |
patrickeast | jgriffith: yea i maybe *could* go into the driver base class | 23:54 |
patrickeast | s/i/it/ | 23:54 |
jgriffith | My only concern is that same I've had in the past about db access in the driver | 23:54 |
jgriffith | and that's just about races | 23:54 |
patrickeast | heh yea | 23:55 |
patrickeast | so step one is moving to these helpers | 23:55 |
jgriffith | Reads only are fine | 23:55 |
patrickeast | step two is changing it to do the conditional updates | 23:55 |
jgriffith | I don't care about that... something fails it fails but at least it doesn't clobber everyone | 23:55 |
patrickeast | and having the helper do something smart so drivers can do something about it | 23:55 |
jgriffith | patrickeast: ahh | 23:55 |
patrickeast | for my use-case i'm totally happy to try and set, catch an exception, query it again and use what was there | 23:56 |
patrickeast | but having races on the set is what we are exposed to now :( | 23:56 |
jgriffith | patrickeast: the only other concern I'd have is the driver updates | 23:56 |
patrickeast | which ones? | 23:56 |
jgriffith | patrickeast: after trying to update things in drivers a couple times today it's very NOT pretty | 23:56 |
jgriffith | patrickeast: so any of them that use the initiator_data | 23:57 |
patrickeast | jgriffith: oh, yea luckily this only affects mine afaik | 23:57 |
patrickeast | i saw solidfire has the param | 23:57 |
jgriffith | patrickeast: granted even out of the ones that implement it I don't know that anybody actually does anything with it | 23:57 |
jgriffith | except maybe EMC | 23:57 |
patrickeast | but didn't look like you did anything with it | 23:57 |
jgriffith | yeah, I follow driver.py :) | 23:57 |
jgriffith | even if I don't need it | 23:57 |
patrickeast | my suspicion is i'm the only one using it | 23:58 |
patrickeast | i'll check more... but if it is in-use its a very small number | 23:58 |
jgriffith | patrickeast: you're right it is | 23:58 |
jgriffith | patrickeast: so I think I like the way you're heading with this if I follow correctly | 23:59 |
jgriffith | I don't know if it should be it's own class or utils file or not etc | 23:59 |
jgriffith | but I do kinda like a driver_utils | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!