*** bardia has quit IRC | 00:01 | |
*** yangyapeng has quit IRC | 00:06 | |
*** Suyash has quit IRC | 00:19 | |
*** laughterwym has joined #openstack-cinder | 00:20 | |
*** laughterwym has quit IRC | 00:21 | |
*** laughterwym has joined #openstack-cinder | 00:21 | |
*** daneyon_ has quit IRC | 00:25 | |
*** Apoorva has joined #openstack-cinder | 00:26 | |
*** Apoorva has quit IRC | 00:31 | |
*** jiaohaolin has quit IRC | 00:33 | |
*** ducttape_ has joined #openstack-cinder | 00:42 | |
*** faiz891 has joined #openstack-cinder | 00:49 | |
*** faiz89 has quit IRC | 00:51 | |
*** faiz89 has joined #openstack-cinder | 00:52 | |
*** julim has quit IRC | 00:52 | |
*** faiz892 has joined #openstack-cinder | 00:53 | |
*** faiz893 has joined #openstack-cinder | 00:53 | |
*** faiz894 has joined #openstack-cinder | 00:54 | |
*** faiz891 has quit IRC | 00:55 | |
*** faiz89 has quit IRC | 00:56 | |
*** faiz892 has quit IRC | 00:57 | |
*** links has joined #openstack-cinder | 00:57 | |
*** faiz893 has quit IRC | 00:58 | |
*** julim has joined #openstack-cinder | 00:58 | |
openstackgerrit | Wilson Liu proposed openstack/cinder: Huawei: Use versionedObject https://review.openstack.org/335028 | 00:59 |
---|---|---|
*** Suyash has joined #openstack-cinder | 00:59 | |
*** iceyao_ has joined #openstack-cinder | 01:05 | |
*** itzdilip has joined #openstack-cinder | 01:06 | |
*** iceyao_ has quit IRC | 01:06 | |
*** iceyao_ has joined #openstack-cinder | 01:06 | |
*** iceyao_ has quit IRC | 01:07 | |
*** iceyao_ has joined #openstack-cinder | 01:08 | |
*** iceyao_ has quit IRC | 01:10 | |
*** iceyao has joined #openstack-cinder | 01:10 | |
*** cknight1 has joined #openstack-cinder | 01:11 | |
*** faiz894 has quit IRC | 01:13 | |
*** cknight has quit IRC | 01:14 | |
*** yangyapeng has joined #openstack-cinder | 01:15 | |
*** ducttape_ has quit IRC | 01:19 | |
*** iceyao has quit IRC | 01:20 | |
*** iceyao has joined #openstack-cinder | 01:20 | |
*** ducttape_ has joined #openstack-cinder | 01:24 | |
openstackgerrit | Jack Lu proposed openstack/cinder: Use elevated context to query DB in VolumeNumberWeigher https://review.openstack.org/331967 | 01:26 |
*** cheneydc has joined #openstack-cinder | 01:27 | |
openstackgerrit | Jack Lu proposed openstack/cinder: Use elevated context to query DB in VolumeNumberWeigher https://review.openstack.org/331967 | 01:29 |
*** faiz89 has joined #openstack-cinder | 01:29 | |
*** faiz891 has joined #openstack-cinder | 01:30 | |
*** faiz892 has joined #openstack-cinder | 01:30 | |
*** faiz893 has joined #openstack-cinder | 01:31 | |
*** faiz894 has joined #openstack-cinder | 01:31 | |
*** faiz895 has joined #openstack-cinder | 01:32 | |
*** faiz896 has joined #openstack-cinder | 01:32 | |
*** faiz89 has quit IRC | 01:34 | |
*** ducttape_ has quit IRC | 01:34 | |
*** faiz891 has quit IRC | 01:34 | |
*** Apoorva has joined #openstack-cinder | 01:34 | |
*** faiz892 has quit IRC | 01:34 | |
*** faiz89 has joined #openstack-cinder | 01:35 | |
*** faiz893 has quit IRC | 01:35 | |
*** faiz894 has quit IRC | 01:36 | |
*** Apoorva has quit IRC | 01:36 | |
*** faiz895 has quit IRC | 01:36 | |
*** faiz891 has joined #openstack-cinder | 01:37 | |
*** faiz891 has quit IRC | 01:38 | |
*** Lee1092 has joined #openstack-cinder | 01:39 | |
*** faiz896 has quit IRC | 01:39 | |
*** faiz89 has quit IRC | 01:40 | |
*** julim has quit IRC | 01:41 | |
*** EinstCrazy has joined #openstack-cinder | 01:41 | |
*** julim has joined #openstack-cinder | 01:41 | |
openstackgerrit | Rui Chen proposed openstack/python-cinderclient: Fix batch deleting issue in volume_type.unset_keys() https://review.openstack.org/335327 | 01:42 |
*** xyang has joined #openstack-cinder | 01:51 | |
*** xyang has quit IRC | 01:52 | |
*** sdake has joined #openstack-cinder | 01:54 | |
*** rajinir has quit IRC | 01:54 | |
*** houming has joined #openstack-cinder | 01:59 | |
*** sdake has quit IRC | 02:04 | |
*** Suyash has quit IRC | 02:04 | |
*** markvoelker has quit IRC | 02:06 | |
*** ducttape_ has joined #openstack-cinder | 02:07 | |
*** cheneydc has quit IRC | 02:08 | |
*** Apoorva has joined #openstack-cinder | 02:08 | |
*** _ducttape_ has joined #openstack-cinder | 02:09 | |
*** ducttape_ has quit IRC | 02:11 | |
*** xyang has joined #openstack-cinder | 02:15 | |
*** xyang has quit IRC | 02:19 | |
openstackgerrit | Weiwei Gu proposed openstack/cinder: LVM+tgt:iscsi target deleted after VM live migrate https://review.openstack.org/314559 | 02:24 |
*** baojg has joined #openstack-cinder | 02:32 | |
*** crose has joined #openstack-cinder | 02:32 | |
*** _ducttape_ has quit IRC | 02:32 | |
*** jbernard has quit IRC | 02:33 | |
*** jraju has joined #openstack-cinder | 02:34 | |
*** merooney has quit IRC | 02:34 | |
*** links has quit IRC | 02:36 | |
*** ducttape_ has joined #openstack-cinder | 02:37 | |
*** julim has quit IRC | 02:37 | |
*** winston-d has quit IRC | 02:47 | |
*** karthikp has joined #openstack-cinder | 02:53 | |
*** baojg has quit IRC | 02:54 | |
*** crose has quit IRC | 02:54 | |
*** karthikp_ has joined #openstack-cinder | 02:55 | |
*** ducttape_ has quit IRC | 02:59 | |
*** laughterwym has quit IRC | 02:59 | |
*** harlowja_at_home has joined #openstack-cinder | 03:00 | |
*** laughterwym has joined #openstack-cinder | 03:00 | |
openstackgerrit | Nate Potter proposed openstack/cinder: Allow admin project to operate on all quotas https://review.openstack.org/335634 | 03:00 |
*** laughter_ has joined #openstack-cinder | 03:01 | |
*** jraju has quit IRC | 03:03 | |
*** laughterwym has quit IRC | 03:04 | |
*** markvoelker has joined #openstack-cinder | 03:06 | |
openstackgerrit | yuyafei proposed openstack/os-brick: Add NoFibreChannelHBAsFound to express accurately https://review.openstack.org/335778 | 03:09 |
*** markvoelker has quit IRC | 03:11 | |
*** cknight1 has quit IRC | 03:15 | |
*** karthikp_ has quit IRC | 03:18 | |
openstackgerrit | Bin Zhou proposed openstack/cinder-specs: HealthCheck Middleware https://review.openstack.org/325829 | 03:20 |
*** winston-d has joined #openstack-cinder | 03:20 | |
*** harlowja_at_home has quit IRC | 03:20 | |
*** baojg has joined #openstack-cinder | 03:21 | |
*** harlowja_at_home has joined #openstack-cinder | 03:22 | |
*** Apoorva has quit IRC | 03:23 | |
*** fredli has joined #openstack-cinder | 03:23 | |
*** ducttape_ has joined #openstack-cinder | 03:28 | |
*** sheel has joined #openstack-cinder | 03:28 | |
*** jwcroppe has quit IRC | 03:30 | |
*** laughter_ has quit IRC | 03:34 | |
*** laughterwym has joined #openstack-cinder | 03:35 | |
*** laughterwym has quit IRC | 03:35 | |
*** laughterwym has joined #openstack-cinder | 03:35 | |
*** karthikp_ has joined #openstack-cinder | 03:38 | |
*** laughterwym has quit IRC | 03:39 | |
*** laughterwym has joined #openstack-cinder | 03:39 | |
openstackgerrit | JiWei proposed openstack/cinder: Make divisible py3 compatible in nfs driver https://review.openstack.org/335781 | 03:39 |
*** laughterwym has joined #openstack-cinder | 03:39 | |
*** daneyon has joined #openstack-cinder | 03:40 | |
*** baojg has quit IRC | 03:40 | |
*** karthikp_ has quit IRC | 03:48 | |
*** mriedem has quit IRC | 03:50 | |
*** Apoorva has joined #openstack-cinder | 03:51 | |
*** zhangjn has quit IRC | 03:51 | |
openstackgerrit | Bin Zhou proposed openstack/cinder-specs: HealthCheck Middleware https://review.openstack.org/325829 | 03:53 |
*** karthikp_ has joined #openstack-cinder | 03:56 | |
*** darosale has joined #openstack-cinder | 03:56 | |
*** zhangjn has joined #openstack-cinder | 03:59 | |
*** zhangjn has quit IRC | 04:05 | |
openstackgerrit | Merged openstack/cinder: Add strict Boolean checking for quota show https://review.openstack.org/331529 | 04:05 |
*** markvoelker has joined #openstack-cinder | 04:07 | |
*** zhangjn has joined #openstack-cinder | 04:11 | |
*** darosale has quit IRC | 04:11 | |
*** markvoelker has quit IRC | 04:12 | |
*** ducttape_ has quit IRC | 04:16 | |
*** karthik__ has joined #openstack-cinder | 04:18 | |
*** karthikp_ has quit IRC | 04:20 | |
*** Apoorva has quit IRC | 04:26 | |
*** jwcroppe has joined #openstack-cinder | 04:28 | |
*** laughter_ has joined #openstack-cinder | 04:29 | |
*** jwcroppe has quit IRC | 04:30 | |
*** harlowja_at_home has quit IRC | 04:30 | |
*** jwcroppe has joined #openstack-cinder | 04:33 | |
*** laughterwym has quit IRC | 04:33 | |
*** ManishD has joined #openstack-cinder | 04:41 | |
*** jwcroppe has quit IRC | 04:44 | |
*** sdake has joined #openstack-cinder | 04:49 | |
*** karthik__ has quit IRC | 04:49 | |
*** karthikp_ has joined #openstack-cinder | 04:50 | |
*** sdake_ has joined #openstack-cinder | 04:51 | |
*** sdake_ has quit IRC | 04:53 | |
*** sdake has quit IRC | 04:54 | |
*** salv-orlando has joined #openstack-cinder | 05:00 | |
*** jwcroppe has joined #openstack-cinder | 05:01 | |
*** salv-orl_ has quit IRC | 05:03 | |
openstackgerrit | Merged openstack/cinder: Use True instead of 1 in while loop https://review.openstack.org/334864 | 05:04 |
*** jwcroppe has quit IRC | 05:05 | |
*** itzdilip has quit IRC | 05:06 | |
openstackgerrit | huanan proposed openstack/cinder: Huawei: Support huawei consistency group https://review.openstack.org/260930 | 05:06 |
*** GB21 has joined #openstack-cinder | 05:06 | |
*** karthikp_ has quit IRC | 05:06 | |
*** yangyape_ has joined #openstack-cinder | 05:07 | |
*** yangyapeng has quit IRC | 05:07 | |
*** yangyapeng has joined #openstack-cinder | 05:08 | |
*** yangyape_ has quit IRC | 05:09 | |
openstackgerrit | huanan proposed openstack/cinder: Huawei: Support huawei consistency group https://review.openstack.org/260930 | 05:14 |
*** bbhavsar_ has joined #openstack-cinder | 05:16 | |
*** lpetrut has joined #openstack-cinder | 05:18 | |
*** karthikp_ has joined #openstack-cinder | 05:19 | |
*** savihou has quit IRC | 05:24 | |
*** sdake has joined #openstack-cinder | 05:24 | |
*** karthikp_ has quit IRC | 05:25 | |
*** karthikp_ has joined #openstack-cinder | 05:25 | |
*** karthikp_ has quit IRC | 05:26 | |
*** karthikp_ has joined #openstack-cinder | 05:27 | |
*** rcernin has joined #openstack-cinder | 05:27 | |
*** karthikp_ has quit IRC | 05:27 | |
*** karthikp_ has joined #openstack-cinder | 05:30 | |
*** jwcroppe has joined #openstack-cinder | 05:30 | |
*** karthikp_ has quit IRC | 05:30 | |
*** pgadiya has joined #openstack-cinder | 05:33 | |
*** liverpooler has joined #openstack-cinder | 05:33 | |
*** rcernin has quit IRC | 05:34 | |
*** Poornima has joined #openstack-cinder | 05:35 | |
*** sdake_ has joined #openstack-cinder | 05:36 | |
*** laughter_ has quit IRC | 05:36 | |
*** laughterwym has joined #openstack-cinder | 05:37 | |
*** sdake has quit IRC | 05:37 | |
*** sandanar has joined #openstack-cinder | 05:39 | |
*** ChubYann has quit IRC | 05:40 | |
openstackgerrit | Parashuram Hallur proposed openstack/cinder: Implementation for CoprHD Cinder Drivers https://review.openstack.org/317643 | 05:43 |
*** reduxio has joined #openstack-cinder | 05:45 | |
reduxio | Hello. I'm at the final stages of setting up openstack CI for testing the cinder driver we are developing. I see that there are 2 jobs in the CI jenkins setup - do i need to run both? or is the 'my-cinder-driver' test sufficient? | 05:46 |
*** ducttape_ has joined #openstack-cinder | 05:46 | |
*** sgotliv__ has joined #openstack-cinder | 05:47 | |
*** yangyapeng has quit IRC | 05:47 | |
*** bswartz has quit IRC | 05:47 | |
*** yangyapeng has joined #openstack-cinder | 05:49 | |
*** nkrinner_afk is now known as nkrinner | 05:50 | |
*** karthikp_ has joined #openstack-cinder | 05:52 | |
*** ducttape_ has quit IRC | 05:52 | |
reduxio | Anyone here? | 05:53 |
*** sandanar has quit IRC | 05:56 | |
*** karthikp_ has quit IRC | 05:59 | |
*** pbandark has joined #openstack-cinder | 06:01 | |
*** baojg has joined #openstack-cinder | 06:04 | |
openstackgerrit | Jack Lu proposed openstack/cinder: Use elevated context to query DB in VolumeNumberWeigher https://review.openstack.org/331967 | 06:05 |
*** itzdilip has joined #openstack-cinder | 06:07 | |
*** eantyshev has left #openstack-cinder | 06:08 | |
*** harlowja_at_home has joined #openstack-cinder | 06:08 | |
*** savihou has joined #openstack-cinder | 06:09 | |
*** markvoelker has joined #openstack-cinder | 06:09 | |
*** rcernin has joined #openstack-cinder | 06:09 | |
DuncanT | _alastor__: Hi. Sorry, time zone challenges - you were pinging me at 1:20 am my time and I was actually asleep for a change | 06:11 |
*** jiaohaolin has joined #openstack-cinder | 06:12 | |
*** markvoelker has quit IRC | 06:13 | |
jiaohaolin | What is the replication.py of volume driver use for? | 06:13 |
*** karthikp_ has joined #openstack-cinder | 06:14 | |
jiaohaolin | I'm just start to learn about cinder driver. Is there anybody can help me please? | 06:15 |
openstackgerrit | KongWei proposed openstack/cinder: Add ZTE Block Storage Driver https://review.openstack.org/312355 | 06:18 |
*** karthikp_ has quit IRC | 06:18 | |
*** liverpooler has quit IRC | 06:24 | |
*** liverpooler has joined #openstack-cinder | 06:24 | |
*** sgotliv__ has quit IRC | 06:27 | |
*** sdake_ has quit IRC | 06:30 | |
*** reduxio has quit IRC | 06:31 | |
*** karthikp_ has joined #openstack-cinder | 06:34 | |
*** baojg_ has joined #openstack-cinder | 06:34 | |
*** baojg has quit IRC | 06:35 | |
*** arecknag has joined #openstack-cinder | 06:35 | |
*** shyh has joined #openstack-cinder | 06:37 | |
*** ManishD has quit IRC | 06:37 | |
*** ManishD has joined #openstack-cinder | 06:37 | |
*** baojg has joined #openstack-cinder | 06:38 | |
*** baojg_ has quit IRC | 06:38 | |
*** karthikp_ has quit IRC | 06:39 | |
*** harlowja_at_home has quit IRC | 06:39 | |
DuncanT | jiaohaolin: The replication part is optional, and is to provide data copying to a second array for disaster recovery purposes. doc/source/devref/replication.rst and https://specs.openstack.org/openstack/cinder-specs/specs/mitaka/cheesecake.html will hopefully help | 06:40 |
*** belmoreira has joined #openstack-cinder | 06:40 | |
*** reduxio has joined #openstack-cinder | 06:41 | |
*** baojg has quit IRC | 06:42 | |
*** lixiaoy11 has joined #openstack-cinder | 06:43 | |
*** lixiaoy11 has left #openstack-cinder | 06:43 | |
*** lixiaoy11 has joined #openstack-cinder | 06:43 | |
*** karthikp_ has joined #openstack-cinder | 06:46 | |
*** ducttape_ has joined #openstack-cinder | 06:48 | |
*** rdx_matt has joined #openstack-cinder | 06:53 | |
openstackgerrit | Pablo Iranzo Gómez proposed openstack/cinder: Fix some typos https://review.openstack.org/335478 | 06:53 |
*** ducttape_ has quit IRC | 06:53 | |
*** rdx_matt has quit IRC | 06:54 | |
*** rdx_matt has joined #openstack-cinder | 06:55 | |
*** shyh has quit IRC | 06:59 | |
*** jwcroppe has quit IRC | 06:59 | |
*** karthik__ has joined #openstack-cinder | 07:04 | |
*** karthik__ has quit IRC | 07:04 | |
jiaohaolin | DuncanT 3q | 07:04 |
*** karthikp_ has quit IRC | 07:05 | |
*** akapil has joined #openstack-cinder | 07:09 | |
*** markvoelker has joined #openstack-cinder | 07:10 | |
*** vbala has joined #openstack-cinder | 07:10 | |
*** karthikp_ has joined #openstack-cinder | 07:11 | |
*** huanan has joined #openstack-cinder | 07:11 | |
*** markvoelker has quit IRC | 07:14 | |
*** tesseract- has joined #openstack-cinder | 07:15 | |
openstackgerrit | Pablo Iranzo Gómez proposed openstack/cinder: Fix some typos https://review.openstack.org/335478 | 07:20 |
*** itzdilip has quit IRC | 07:21 | |
*** GB21 has quit IRC | 07:25 | |
*** baojg has joined #openstack-cinder | 07:29 | |
openstackgerrit | LisaLi proposed openstack/cinder: Add backup update function (microversion) https://review.openstack.org/263179 | 07:31 |
*** asselin has quit IRC | 07:32 | |
*** baojg has quit IRC | 07:35 | |
*** sandanar has joined #openstack-cinder | 07:35 | |
lixiaoy11 | geguileor: ping. | 07:36 |
lixiaoy11 | geguileo: https://github.com/openstack/cinder/blob/master/cinder/api/openstack/wsgi.py#L1160 may I talk to you about the decorator wsgi.api_version ? | 07:36 |
*** baojg has joined #openstack-cinder | 07:36 | |
geguileo | lixiaoy11: Sure | 07:37 |
*** laughterwym has quit IRC | 07:38 | |
*** adisky has joined #openstack-cinder | 07:38 | |
lixiaoy11 | geguileo: I think the decorator is not correct. Currently when creating a new interface, we use it to set the min_ver and max_ver. | 07:38 |
*** laughterwym has joined #openstack-cinder | 07:38 | |
lixiaoy11 | geguileo: the problem is that when calling the decorator, I checked the paramter "cls", every time it is the base class "wsgi.Controller" | 07:39 |
*** baojg has quit IRC | 07:39 | |
lixiaoy11 | geguileo: that means we store all the version_methods into wsgi.Controller, not specified derived class. | 07:39 |
*** laughterwym has quit IRC | 07:39 | |
*** laughterwym has joined #openstack-cinder | 07:40 | |
*** liverpooler has quit IRC | 07:43 | |
*** liverpooler has joined #openstack-cinder | 07:43 | |
geguileo | lixiaoy11: Yes, that's correct | 07:45 |
flip214 | The cinder volume drivers' create_export() get a connector object passed in... why is there a hostname in the "ip" attribute? | 07:46 |
*** GB21 has joined #openstack-cinder | 07:46 | |
lixiaoy11 | geguileo: so when I inherit a backup controller from v2.backupcontroller, I notice the wrong version test can't be passed. As a result, I called v2.BackupController.api_version which fixed the problem: https://review.openstack.org/#/c/263179/12/cinder/api/v3/backups.py | 07:48 |
*** jwcroppe has joined #openstack-cinder | 07:48 | |
lixiaoy11 | geguileo: @backups_v2.BackupsController.api_version(BACKUP_UPDATE_MICRO_VERSION) , but I think it is ugly. | 07:49 |
*** ducttape_ has joined #openstack-cinder | 07:50 | |
geguileo | lixiaoy11: What happened if you used the wsgi.Controller decorator instead? | 07:50 |
lixiaoy11 | geguileo: the test case test_wrong_version fails. https://review.openstack.org/#/c/263179/12/cinder/tests/unit/api/v3/test_backups.py . | 07:51 |
*** sgotliv__ has joined #openstack-cinder | 07:53 | |
*** yangyapeng has quit IRC | 07:53 | |
lixiaoy11 | geguileo: when I set request version to lower version, it can't raise VersionNotFoundForAPIMethod error | 07:53 |
*** yangyapeng has joined #openstack-cinder | 07:54 | |
*** ducttape_ has quit IRC | 07:54 | |
*** baojg has joined #openstack-cinder | 07:55 | |
openstackgerrit | KongWei proposed openstack/cinder: Add ZTE Block Storage Driver https://review.openstack.org/312355 | 07:58 |
*** rdx_matt has quit IRC | 07:58 | |
*** yangyape_ has joined #openstack-cinder | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-cinder | 08:00 | |
*** yangyapeng has quit IRC | 08:02 | |
*** RuiChen has joined #openstack-cinder | 08:06 | |
*** yangyapeng has joined #openstack-cinder | 08:09 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/cinder: [WIP] Testing latest u-c https://review.openstack.org/303766 | 08:10 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/cinder: [WIP] Testing latest u-c https://review.openstack.org/303766 | 08:10 |
*** mjura has quit IRC | 08:10 | |
*** yangyape_ has quit IRC | 08:10 | |
*** mjura has joined #openstack-cinder | 08:10 | |
*** markvoelker has joined #openstack-cinder | 08:11 | |
*** laughterwym has quit IRC | 08:11 | |
*** iceyao has quit IRC | 08:15 | |
*** markvoelker has quit IRC | 08:15 | |
*** iceyao has joined #openstack-cinder | 08:16 | |
*** jamielennox is now known as jamielennox|away | 08:16 | |
*** laughterwym has joined #openstack-cinder | 08:16 | |
openstackgerrit | Helen Walsh proposed openstack/cinder: VMAX Driver - Live Migration for VMAX3 https://review.openstack.org/330778 | 08:19 |
*** laughter_ has joined #openstack-cinder | 08:28 | |
*** laughterwym has quit IRC | 08:28 | |
*** jwcroppe has quit IRC | 08:32 | |
*** baojg has quit IRC | 08:34 | |
*** baojg has joined #openstack-cinder | 08:37 | |
*** laughter_ has quit IRC | 08:38 | |
*** baojg has quit IRC | 08:41 | |
*** baojg has joined #openstack-cinder | 08:43 | |
openstackgerrit | liuke proposed openstack/cinder: Huawei: Support reporting disk type of pool https://review.openstack.org/324163 | 08:45 |
*** sheel has quit IRC | 08:45 | |
*** itzdilip has joined #openstack-cinder | 08:46 | |
*** sborkows has joined #openstack-cinder | 08:49 | |
*** fredli has quit IRC | 08:50 | |
*** ducttape_ has joined #openstack-cinder | 08:50 | |
openstackgerrit | LisaLi proposed openstack/python-cinderclient: Add backup-rename https://review.openstack.org/263184 | 08:52 |
geguileo | lixiaoy11: Ok, I think I have located the source of the problem | 08:52 |
geguileo | lixiaoy11: I'll try to fix it now :-( | 08:52 |
*** ducttape_ has quit IRC | 08:55 | |
lixiaoy1 | geguileo: thank you! | 08:56 |
*** jwcroppe has joined #openstack-cinder | 08:56 | |
lixiaoy1 | geguileo: I tried to fix it, but I failed | 08:56 |
lixiaoy1 | geguileo: the same problem also exists in Nova I think | 08:57 |
geguileo | lixiaoy1: It wasn't an easy thing to figure out | 08:57 |
*** bapalm has quit IRC | 08:57 | |
lixiaoy1 | geguileo: ok, your words make me comfortable :) | 08:58 |
openstackgerrit | Bin Zhou proposed openstack/cinder: remove redundant image fetch https://review.openstack.org/331598 | 08:58 |
*** TaylorHuang has joined #openstack-cinder | 08:58 | |
*** wilson_liu has joined #openstack-cinder | 08:58 | |
*** lixiaoy11 has quit IRC | 08:59 | |
*** ildikov_ has joined #openstack-cinder | 08:59 | |
*** bapalm has joined #openstack-cinder | 09:00 | |
*** jwcroppe has quit IRC | 09:01 | |
*** markstur_ has joined #openstack-cinder | 09:02 | |
openstackgerrit | Arsen Chen proposed openstack/cinder: Add Synology DiskStation storage driver https://review.openstack.org/335870 | 09:04 |
*** baojg has quit IRC | 09:04 | |
*** bluex_ has joined #openstack-cinder | 09:05 | |
*** gnarld_ has joined #openstack-cinder | 09:07 | |
*** afazekas_ has joined #openstack-cinder | 09:07 | |
*** diogogmt has quit IRC | 09:08 | |
*** Guest51069 has quit IRC | 09:08 | |
*** ericksonsantos has quit IRC | 09:08 | |
*** bluex has quit IRC | 09:08 | |
*** TaylorH has quit IRC | 09:08 | |
*** afazekas has quit IRC | 09:08 | |
*** partner_ has quit IRC | 09:08 | |
*** cFouts has quit IRC | 09:08 | |
*** j_king has quit IRC | 09:08 | |
*** markstur has quit IRC | 09:08 | |
*** mordred has quit IRC | 09:08 | |
*** ildikov has quit IRC | 09:08 | |
*** rmk has quit IRC | 09:08 | |
*** bluex_ is now known as bluex | 09:08 | |
*** rmk has joined #openstack-cinder | 09:09 | |
*** j_king has joined #openstack-cinder | 09:09 | |
*** ildikov_ is now known as ildikov | 09:09 | |
*** caoshufeng has joined #openstack-cinder | 09:11 | |
*** mordred has joined #openstack-cinder | 09:13 | |
*** rdx_matt has joined #openstack-cinder | 09:13 | |
*** ericksonsantos has joined #openstack-cinder | 09:14 | |
*** baojg has joined #openstack-cinder | 09:16 | |
openstackgerrit | Silvan Kaiser proposed openstack/cinder: Ensure reading default group nas_secure_file_* settings in Quobyte https://review.openstack.org/335873 | 09:17 |
*** partner has joined #openstack-cinder | 09:21 | |
openstackgerrit | xiexs proposed openstack/cinder: Let /types API list all volume types by default https://review.openstack.org/335880 | 09:28 |
openstackgerrit | xiexs proposed openstack/python-cinderclient: Add --is-public option to type-list https://review.openstack.org/335881 | 09:28 |
*** GB21 has quit IRC | 09:29 | |
*** sandanar_ has joined #openstack-cinder | 09:32 | |
*** baojg has quit IRC | 09:33 | |
*** sandanar has quit IRC | 09:33 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Fix quota-usage list information with invalid tenant-id https://review.openstack.org/315673 | 09:35 |
*** shyama has joined #openstack-cinder | 09:35 | |
*** partner has quit IRC | 09:37 | |
openstackgerrit | yuyafei proposed openstack/cinder: EMC ScaleIO should return ceiling of volume size https://review.openstack.org/335887 | 09:37 |
*** baojg has joined #openstack-cinder | 09:38 | |
*** kwathore_ has quit IRC | 09:56 | |
*** kwathore_ has joined #openstack-cinder | 09:56 | |
*** GB21 has joined #openstack-cinder | 09:58 | |
*** baojg has quit IRC | 10:04 | |
*** baojg has joined #openstack-cinder | 10:06 | |
openstackgerrit | liuke proposed openstack/cinder: Huawei: Support reporting disk type of pool https://review.openstack.org/324163 | 10:08 |
*** david-lyle has quit IRC | 10:09 | |
*** david-lyle_ has joined #openstack-cinder | 10:09 | |
*** rdx_matt_ has joined #openstack-cinder | 10:13 | |
*** rdx_matt has quit IRC | 10:16 | |
*** baojg has quit IRC | 10:18 | |
*** shyama has quit IRC | 10:18 | |
*** rdx_matt_ has quit IRC | 10:29 | |
*** rdx_matt has joined #openstack-cinder | 10:29 | |
*** lprice1 has quit IRC | 10:32 | |
*** lprice has joined #openstack-cinder | 10:33 | |
*** mdavidson has quit IRC | 10:33 | |
*** akapil has quit IRC | 10:41 | |
*** vbala has quit IRC | 10:43 | |
*** akapil has joined #openstack-cinder | 10:43 | |
*** iceyao has quit IRC | 10:43 | |
*** _fortis has quit IRC | 10:43 | |
openstackgerrit | yuyafei proposed openstack/cinder: Replace int with float to bring math.ceil into effect https://review.openstack.org/335924 | 10:46 |
openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - locking SG for concurrent threads https://review.openstack.org/317057 | 10:49 |
*** partner has joined #openstack-cinder | 10:54 | |
*** _fortis has joined #openstack-cinder | 10:55 | |
openstackgerrit | JiWei proposed openstack/cinder: Implement Remotefs copy volume from snapshot https://review.openstack.org/335445 | 10:58 |
*** sandanar_ has quit IRC | 10:59 | |
*** salv-orl_ has joined #openstack-cinder | 11:00 | |
*** shyama has joined #openstack-cinder | 11:01 | |
*** itzdilip has quit IRC | 11:02 | |
*** salv-orlando has quit IRC | 11:03 | |
*** salv-orl_ has quit IRC | 11:05 | |
yuriy_n17 | geguileo: Hi. Very sorry for disturbing. Please take a look at https://review.openstack.org/#/c/332848/ whenever you have free time. Thanks. | 11:05 |
geguileo | yuriy_n17: Free time??? What's that? ;-) | 11:05 |
yuriy_n17 | geguileo: No free time? Sorry for disturbing. | 11:07 |
nikeshm | geguileo : very busy, i saw 7-8 patches at a time in cinder channel from you :) | 11:07 |
geguileo | yuriy_n17: It was a joke | 11:07 |
geguileo | yuriy_n17: Thus the smiley face at the end | 11:07 |
geguileo | yuriy_n17: I meant that we are all very busy and we don't have free time | 11:07 |
geguileo | yuriy_n17: I'm looking at it right now | 11:08 |
yuriy_n17 | geguileo: Ok | 11:08 |
huanan | haha ;) | 11:08 |
openstackgerrit | liuke proposed openstack/cinder: Huawei: Support reporting disk type of pool https://review.openstack.org/324163 | 11:11 |
*** EinstCrazy has quit IRC | 11:13 | |
*** yangyapeng has quit IRC | 11:15 | |
*** jseiler has quit IRC | 11:16 | |
openstackgerrit | Arsen Chen proposed openstack/cinder: Add Synology DiskStation storage driver https://review.openstack.org/335870 | 11:16 |
*** caoshufeng has quit IRC | 11:16 | |
*** jseiler has joined #openstack-cinder | 11:16 | |
*** shyama has quit IRC | 11:21 | |
*** rdx_matt has quit IRC | 11:21 | |
*** Swanson has quit IRC | 11:21 | |
*** Swanson has joined #openstack-cinder | 11:21 | |
*** asselin has joined #openstack-cinder | 11:23 | |
*** itzdilip has joined #openstack-cinder | 11:26 | |
*** ducttape_ has joined #openstack-cinder | 11:29 | |
*** mvk has quit IRC | 11:29 | |
*** smcginnis has quit IRC | 11:30 | |
*** smcginnis has joined #openstack-cinder | 11:30 | |
*** ericksonsantos has quit IRC | 11:38 | |
yuriy_n17 | geguileo: Thanks a lot. | 11:42 |
geguileo | yuriy_n17: np | 11:42 |
*** ManishD has quit IRC | 11:42 | |
*** itzdilip has quit IRC | 11:44 | |
*** GB21 has quit IRC | 11:47 | |
*** links has joined #openstack-cinder | 11:48 | |
*** links has quit IRC | 11:48 | |
*** laughterwym has joined #openstack-cinder | 11:51 | |
*** itzdilip has joined #openstack-cinder | 11:52 | |
*** itzdilip has quit IRC | 11:53 | |
*** GB21 has joined #openstack-cinder | 11:54 | |
*** sdake has joined #openstack-cinder | 11:55 | |
*** ducttape_ has quit IRC | 11:57 | |
*** sdake_ has joined #openstack-cinder | 11:57 | |
*** mvk has joined #openstack-cinder | 11:57 | |
*** eharney has quit IRC | 11:58 | |
*** sdake has quit IRC | 12:01 | |
*** jwcroppe has joined #openstack-cinder | 12:03 | |
*** salv-orlando has joined #openstack-cinder | 12:06 | |
*** Fdaisuke has quit IRC | 12:07 | |
*** Fdaisuke has joined #openstack-cinder | 12:07 | |
*** raildo-afk is now known as raildo | 12:13 | |
*** markvoelker has joined #openstack-cinder | 12:13 | |
*** salv-orlando has quit IRC | 12:14 | |
*** markvoelker has quit IRC | 12:14 | |
*** markvoelker has joined #openstack-cinder | 12:15 | |
*** eharney has joined #openstack-cinder | 12:15 | |
*** ociuhandu has joined #openstack-cinder | 12:20 | |
*** Poornima has quit IRC | 12:23 | |
*** xyang has joined #openstack-cinder | 12:23 | |
*** ericksonsantos has joined #openstack-cinder | 12:23 | |
*** Fdaisuke has quit IRC | 12:24 | |
*** Fdaisuke has joined #openstack-cinder | 12:24 | |
*** edmondsw has joined #openstack-cinder | 12:25 | |
*** xyang has quit IRC | 12:25 | |
*** ericksonsantos has quit IRC | 12:26 | |
*** bswartz has joined #openstack-cinder | 12:26 | |
*** rlrossit has joined #openstack-cinder | 12:30 | |
*** adisky has quit IRC | 12:30 | |
*** timcl has joined #openstack-cinder | 12:31 | |
*** dustins has joined #openstack-cinder | 12:32 | |
*** rdx_matt has joined #openstack-cinder | 12:35 | |
*** ericksonsantos has joined #openstack-cinder | 12:37 | |
*** ChanServ sets mode: +o smcginnis | 12:38 | |
*** salv-orlando has joined #openstack-cinder | 12:43 | |
*** GB21 has quit IRC | 12:44 | |
*** jiaohaolin has quit IRC | 12:44 | |
*** jiaohaolin has joined #openstack-cinder | 12:44 | |
*** iceyao has joined #openstack-cinder | 12:45 | |
*** bbhavsar_ has quit IRC | 12:46 | |
*** xyang1 has joined #openstack-cinder | 12:47 | |
*** mdavidson has joined #openstack-cinder | 12:49 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Correct reraising of exception https://review.openstack.org/335991 | 12:53 |
*** ducttape_ has joined #openstack-cinder | 12:58 | |
*** bbhavsar_ has joined #openstack-cinder | 13:00 | |
*** andymaier has joined #openstack-cinder | 13:00 | |
*** ducttape_ has quit IRC | 13:02 | |
openstackgerrit | Merged openstack/cinder: Replace use of mox with mock in test_brick_lvm https://review.openstack.org/335522 | 13:03 |
*** tpsilva has joined #openstack-cinder | 13:03 | |
*** xyang has joined #openstack-cinder | 13:03 | |
*** xyang has quit IRC | 13:07 | |
*** shyama has joined #openstack-cinder | 13:08 | |
*** akerr has joined #openstack-cinder | 13:09 | |
*** sdake has joined #openstack-cinder | 13:10 | |
*** houming has quit IRC | 13:11 | |
*** sgotliv__ has quit IRC | 13:12 | |
*** pgadiya has quit IRC | 13:12 | |
*** rdx_matt has quit IRC | 13:13 | |
*** sdake_ has quit IRC | 13:13 | |
*** rdx_matt has joined #openstack-cinder | 13:13 | |
*** rlrossit has quit IRC | 13:14 | |
*** arecknag has quit IRC | 13:14 | |
*** merooney has joined #openstack-cinder | 13:15 | |
*** erlon has joined #openstack-cinder | 13:18 | |
*** porrua has joined #openstack-cinder | 13:18 | |
*** akapil has quit IRC | 13:20 | |
*** mriedem has joined #openstack-cinder | 13:21 | |
*** ametts has joined #openstack-cinder | 13:21 | |
*** akapil has joined #openstack-cinder | 13:23 | |
*** rdx_matt has quit IRC | 13:27 | |
*** yangyapeng has joined #openstack-cinder | 13:27 | |
*** rdx_matt has joined #openstack-cinder | 13:28 | |
*** jbernard has joined #openstack-cinder | 13:30 | |
*** rlrossit has joined #openstack-cinder | 13:32 | |
*** akapil_ has joined #openstack-cinder | 13:34 | |
*** akapil has quit IRC | 13:34 | |
*** akapil has joined #openstack-cinder | 13:35 | |
*** shyama has quit IRC | 13:38 | |
*** akapil_ has quit IRC | 13:39 | |
geguileo | lixiaoy1: ping - did you create a BZ for that issue? | 13:40 |
*** andymaier has quit IRC | 13:43 | |
*** sheel has joined #openstack-cinder | 13:44 | |
*** edmondsw has quit IRC | 13:44 | |
*** reduxio has quit IRC | 13:46 | |
*** rdx_matt has quit IRC | 13:48 | |
*** rdx_matt has joined #openstack-cinder | 13:49 | |
*** rlrossit has quit IRC | 13:50 | |
*** krtaylor has joined #openstack-cinder | 13:52 | |
*** Lee1092 has quit IRC | 13:53 | |
*** rdx_matt has quit IRC | 13:53 | |
*** diogogmt has joined #openstack-cinder | 13:54 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Remove translation from config options https://review.openstack.org/336027 | 13:55 |
*** laughterwym has quit IRC | 13:55 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/python-cinderclient: Cinder client should retry with Retry-After value https://review.openstack.org/332848 | 13:55 |
*** laughterwym has joined #openstack-cinder | 13:55 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Support microversions on inherited Controllers https://review.openstack.org/336030 | 13:56 |
geguileo | lixiaoy1: ^^ That's the fix | 13:56 |
*** rlrossit has joined #openstack-cinder | 13:56 | |
*** akshai has joined #openstack-cinder | 13:57 | |
*** ducttape_ has joined #openstack-cinder | 13:59 | |
*** diablo_rojo has joined #openstack-cinder | 14:00 | |
*** bhagyashri has quit IRC | 14:01 | |
*** ducttape_ has quit IRC | 14:03 | |
*** shyh has joined #openstack-cinder | 14:04 | |
*** jgregor has joined #openstack-cinder | 14:05 | |
shyh | smcginnis: can you please help me with this review https://review.openstack.org/#/c/334799/ , it fixes xtremio test suit as we agreed last time we chat and closes this bug https://launchpad.net/bugs/1561600 | 14:07 |
openstack | Launchpad bug 1561600 in Cinder "XtremIO test suit redesign" [Low,In progress] - Assigned to Shay Halsband (shay-halsband) | 14:07 |
*** sdake_ has joined #openstack-cinder | 14:07 | |
*** wilson_liu has quit IRC | 14:07 | |
*** wilson has joined #openstack-cinder | 14:08 | |
*** wilson is now known as Guest85887 | 14:09 | |
*** EinstCrazy has joined #openstack-cinder | 14:09 | |
*** sdake has quit IRC | 14:11 | |
*** GB21 has joined #openstack-cinder | 14:13 | |
*** diogogmt has quit IRC | 14:14 | |
*** rcernin has quit IRC | 14:14 | |
*** jungleboyj has joined #openstack-cinder | 14:20 | |
*** sdake_ is now known as sdake | 14:20 | |
*** enriquetaso has joined #openstack-cinder | 14:20 | |
*** mjura has quit IRC | 14:23 | |
*** nkrinner has quit IRC | 14:23 | |
*** gouthamr has joined #openstack-cinder | 14:24 | |
*** gouthamr_ has joined #openstack-cinder | 14:26 | |
*** edmondsw has joined #openstack-cinder | 14:26 | |
*** belmoreira has quit IRC | 14:28 | |
*** gouthamr has quit IRC | 14:29 | |
*** lprice has quit IRC | 14:29 | |
smcginnis | shyh: Sure, I'll take a look | 14:29 |
*** crose has joined #openstack-cinder | 14:29 | |
*** rcernin has joined #openstack-cinder | 14:30 | |
smcginnis | shyh: BTW, you don't need to open a bug for something like that really. Just make the changes and submit them. | 14:30 |
*** jistr is now known as jistr|mtg | 14:31 | |
shyh | smcginnis: thanks | 14:31 |
smcginnis | shyh: No problem. | 14:32 |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Replace use of mox with mock in test_ibm_xiv_ds8k https://review.openstack.org/335589 | 14:32 |
*** krtaylor has quit IRC | 14:34 | |
*** ducttape_ has joined #openstack-cinder | 14:38 | |
*** gcb has quit IRC | 14:38 | |
*** ducttape_ has quit IRC | 14:39 | |
*** Suyash has joined #openstack-cinder | 14:40 | |
openstackgerrit | Shlomi Avihou proposed openstack/cinder: Add backend driver for Zadara Storage VPSA https://review.openstack.org/263026 | 14:41 |
*** Yogi1 has joined #openstack-cinder | 14:41 | |
*** gcb has joined #openstack-cinder | 14:41 | |
*** bbhavsar_ has quit IRC | 14:41 | |
*** cknight has joined #openstack-cinder | 14:43 | |
*** cdelatte has joined #openstack-cinder | 14:43 | |
*** bardia has joined #openstack-cinder | 14:45 | |
*** rcernin has quit IRC | 14:46 | |
openstackgerrit | Merged openstack/cinder: Huawei: Support huawei consistency group https://review.openstack.org/260930 | 14:47 |
*** karthik__ has joined #openstack-cinder | 14:50 | |
*** david-lyle_ is now known as david-lyle | 14:51 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/python-cinderclient: Cinder client should retry with Retry-After value https://review.openstack.org/332848 | 14:51 |
*** rdx_matt has joined #openstack-cinder | 14:52 | |
*** bbhavsar_ has joined #openstack-cinder | 14:53 | |
*** shyh has quit IRC | 14:55 | |
*** sdake_ has joined #openstack-cinder | 14:56 | |
*** sdake has quit IRC | 14:59 | |
*** karthik__ has quit IRC | 14:59 | |
*** rcernin has joined #openstack-cinder | 14:59 | |
*** akshai has quit IRC | 14:59 | |
*** darosale has joined #openstack-cinder | 14:59 | |
*** akshai has joined #openstack-cinder | 15:00 | |
*** gouthamr_ is now known as gouthamr | 15:01 | |
*** krtaylor has joined #openstack-cinder | 15:02 | |
*** ducttape_ has joined #openstack-cinder | 15:05 | |
*** lprice has joined #openstack-cinder | 15:08 | |
*** ducttape_ has quit IRC | 15:09 | |
*** sdake has joined #openstack-cinder | 15:10 | |
*** sborkows has quit IRC | 15:11 | |
*** ducttape_ has joined #openstack-cinder | 15:11 | |
*** diogogmt has joined #openstack-cinder | 15:12 | |
*** sdake_ has quit IRC | 15:13 | |
*** crose has quit IRC | 15:13 | |
*** bbhavsar_ has quit IRC | 15:15 | |
*** pots1 has joined #openstack-cinder | 15:16 | |
*** pots2 has joined #openstack-cinder | 15:17 | |
scottda | There are iscsi failues in nova live-migration tests. Anyone with ideas please look: https://bugs.launchpad.net/nova/+bug/1524898 | 15:19 |
openstack | Launchpad bug 1524898 in OpenStack Compute (nova) "Volume based live migration aborted unexpectedly" [High,Confirmed] | 15:19 |
*** rcernin has quit IRC | 15:19 | |
scottda | Looks like errors coming from the kernel right at the end of the source instance I/O flush, before the switch-over to the new Nova destination instance: http://logs.openstack.org/03/335903/1/check/gate-tempest-dsvm-multinode-live-migration/5bae103/logs/subnode-2/syslog.txt.gz#_Jun_30_14_28_12 | 15:20 |
*** pots1 has quit IRC | 15:21 | |
*** bbhavsar_ has joined #openstack-cinder | 15:21 | |
*** pots1 has joined #openstack-cinder | 15:22 | |
*** pots3 has joined #openstack-cinder | 15:22 | |
*** pots3 has quit IRC | 15:23 | |
*** jistr|mtg is now known as jistr | 15:23 | |
*** gb21_ has joined #openstack-cinder | 15:24 | |
*** pots2 has quit IRC | 15:24 | |
*** GB21 has quit IRC | 15:25 | |
*** gb21_ is now known as GB21 | 15:25 | |
*** iceyao has quit IRC | 15:25 | |
*** pots1 has quit IRC | 15:26 | |
*** karthik__ has joined #openstack-cinder | 15:27 | |
*** tesseract- has quit IRC | 15:27 | |
*** shyama has joined #openstack-cinder | 15:28 | |
*** kaisers has quit IRC | 15:29 | |
smcginnis | scottda: I wonder if the session got yanked too early? | 15:29 |
*** savihou has quit IRC | 15:30 | |
scottda | Yeah, but there's nothing in the code that would do that. | 15:31 |
smcginnis | scottda: Yeah, and it doesn't look like there was anything in the Cinder logs at that time showing anything was done. | 15:31 |
smcginnis | Unless something happened earlier. | 15:31 |
scottda | smcginnis: It happens just as it's finishing the I/O flush on the source. Never earlier. | 15:32 |
*** rlrossit has quit IRC | 15:42 | |
openstackgerrit | Merged openstack/cinder: XtremIO: fix test suite https://review.openstack.org/334799 | 15:42 |
*** kaisers has joined #openstack-cinder | 15:44 | |
*** karthik__ has quit IRC | 15:46 | |
*** rlrossit has joined #openstack-cinder | 15:46 | |
*** shyama has quit IRC | 15:46 | |
*** harlowja_at_home has joined #openstack-cinder | 15:48 | |
*** harlowja_at_home has quit IRC | 15:49 | |
*** jordanP has joined #openstack-cinder | 15:50 | |
*** salv-orlando has quit IRC | 15:50 | |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Fix 'driver does not honor clone/snapshot' bugs https://review.openstack.org/336092 | 15:51 |
erlon | jgriffith: hi John, can you have a look on this when you have a change? | 15:53 |
erlon | jgriffith: https://review.openstack.org/#/c/336092/ | 15:53 |
*** EinstCrazy has quit IRC | 15:55 | |
*** pbandark has quit IRC | 15:55 | |
erlon | jgriffith: I quickly fixed the drivers unit tests, so, don't mind looking at then | 15:55 |
*** karthik__ has joined #openstack-cinder | 15:56 | |
erlon | smcginnis: Hi Sean, how do you do with the commit message in this case? ^ | 15:57 |
karthik__ | scottda: Hi..got a quick question for you | 15:57 |
scottda | karthik__: ?? | 15:57 |
erlon | smcginnis: I tried not to create a 50 lines commit, but I think LP is not linking the bugs listed | 15:57 |
karthik__ | scottda: https://review.openstack.org/#/c/327619/3/features.yaml@115 ... any idea why we did this? | 15:59 |
smcginnis | erlon: Wow, that's a lot of bugs. :) | 16:00 |
smcginnis | erlon: I think you actually would need to do one line per bug for it to properly link them. | 16:00 |
erlon | smcginnis: haha | 16:00 |
*** dims has quit IRC | 16:00 | |
scottda | karthik__: No, no idea. I think it's just an attempt to figure out how to get the job rolling. Probably something that could be changed, but I'm not well-versed enough to really know for sure. | 16:00 |
*** jordanP has quit IRC | 16:00 | |
smcginnis | erlon: The commit could end up more lines than the code change. :) | 16:00 |
erlon | hmm, ill try to add the Closes-bug inline to see if it works | 16:01 |
erlon | smcginnis: lol | 16:01 |
*** bjornar_ has joined #openstack-cinder | 16:01 | |
erlon | smcginnis: I actually had to parse those bugs from LP to avoid having to copying manually | 16:02 |
*** karthik__ has quit IRC | 16:04 | |
_alastor_ | smcginnis: what exactly constitutes a 3rd-party CI disagreement with jenkins? Is it only considered a disagreement if Jenkins gives a +1 and the CI adds a FAILURE comment? | 16:04 |
*** karthik__ has joined #openstack-cinder | 16:04 | |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Fix 'driver does not honor clone/snapshot' bugs https://review.openstack.org/336092 | 16:04 |
karthik__ | scottda: Oh I see | 16:04 |
_alastor_ | smcginnis: Or do we consider the opposite, where Jenkins gives -1 and the CI passes a disagreement as well? | 16:05 |
erlon | smcginnis: it worked | 16:05 |
_alastor_ | smcginnis: This is for that tool I'm working on. I'm adding a Jenkins disagreement percentage for third-party CIs | 16:05 |
*** dims has joined #openstack-cinder | 16:06 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Support microversions on inherited Controllers https://review.openstack.org/336030 | 16:07 |
erlon | _alastor_: yes, if jenkins gives -1 and the CI also give -1, that should not be taken in account | 16:07 |
smcginnis | _alastor_: I guess both to some degree. | 16:07 |
smcginnis | _alastor_: The more interesting ones to me are where Jenkins gives -1 but a CI passes. | 16:08 |
erlon | _alastor_: the opposite is ok, if jenkins fails, and the CI pass, it cannot count as a CI failure | 16:08 |
_alastor_ | smcginnis: most CIs are set to run only on a Verified+1 from Jenkins usually | 16:09 |
erlon | smcginnis: wouldnt be the opposite? I think that what is important to know, whether the CI should work, ie, if jenkins was able to pass, the CI should also be, | 16:09 |
smcginnis | _alastor_: Yeah, usually. There are some that run immediately, but not many. | 16:09 |
smcginnis | erlon: Right, if Jenkins passes the CI should pass. Unless it actually broke something with the driver. | 16:10 |
smcginnis | erlon: But if Jenkins fails, in most cases any third party CI should also fail. Unless the Jenkins failure was specific to the LVM driver. | 16:10 |
erlon | smcginnis: hmm, I think that happens usually when theres is problems on infra | 16:11 |
_alastor_ | smcginnis: what about pep8/style checks? I don't think most drivers are running those | 16:11 |
smcginnis | erlon: Sometimes. | 16:12 |
smcginnis | That's why it's hard to be too strict about those kinds of metrics. There are too many variables involved. | 16:12 |
smcginnis | _alastor_: Right, Jenkins could fail a pep8 check but the code itself could be functionally fine. | 16:12 |
smcginnis | I think these are the kinds of issues I ran in to last time I was looking at scripting things. | 16:13 |
_alastor_ | Well, I could make the check specifically one that grep's for Tempest related success rather than checking Verified+! | 16:13 |
*** shyama has joined #openstack-cinder | 16:13 | |
smcginnis | It's useful to know when there are disagreements (either way) but it's not necessarily a sign that there's really something wrong with the CI setup. | 16:13 |
_alastor_ | A little more fiddly to implement, but it might be more enlightening | 16:13 |
_alastor_ | Ideally, the Jenkins checks would be divided between functionality and style/unit. Functionality wouldn't get run until style/unit passes :) | 16:14 |
_alastor_ | Would probably speed up the zuul queue | 16:15 |
*** sdake_ has joined #openstack-cinder | 16:15 | |
*** cdelatte has quit IRC | 16:16 | |
*** bbhavsar_ has quit IRC | 16:16 | |
_alastor_ | But in terms of things I can control, I can write up some fancy regex to match just voting non-style/unit gate checks | 16:16 |
*** karthik__ has quit IRC | 16:17 | |
*** seldenr has joined #openstack-cinder | 16:18 | |
*** karthik__ has joined #openstack-cinder | 16:18 | |
_alastor_ | smcginnis: Do we have a wiki page I could scrape for currently voting tests? | 16:18 |
*** sdake has quit IRC | 16:18 | |
*** leeantho has joined #openstack-cinder | 16:20 | |
*** zhangjn has quit IRC | 16:20 | |
smcginnis | _alastor_: You mean Jenkins voting tests? | 16:22 |
*** sdake_ is now known as sdake | 16:23 | |
_alastor_ | smcginnis: yeah | 16:23 |
smcginnis | _alastor_: Even better than a wiki page... | 16:23 |
smcginnis | _alastor_: Everything here that doesn't end in -nv: https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L5092 | 16:24 |
*** laughterwym has quit IRC | 16:25 | |
*** zhangjn has joined #openstack-cinder | 16:25 | |
_alastor_ | awesome, way easier to parse than an html tree | 16:25 |
smcginnis | _alastor_: Definitely! :) | 16:25 |
*** laughterwym has joined #openstack-cinder | 16:26 | |
*** karthik__ has quit IRC | 16:26 | |
*** karthik__ has joined #openstack-cinder | 16:26 | |
openstackgerrit | Tom Swanson proposed openstack/cinder: Dell SC: Do not set High Availability in async mode. https://review.openstack.org/336110 | 16:30 |
*** laughterwym has quit IRC | 16:31 | |
openstackgerrit | Merged openstack/cinder: Replace use of mox with mock in test_ibm_xiv_ds8k https://review.openstack.org/335589 | 16:33 |
*** akapil has quit IRC | 16:36 | |
*** kaisers has quit IRC | 16:37 | |
openstackgerrit | Tom Swanson proposed openstack/cinder: Dell SC: Use Live Volume for replication https://review.openstack.org/329531 | 16:38 |
*** shyama has quit IRC | 16:38 | |
*** bjornar_ has quit IRC | 16:41 | |
*** karthik__ has quit IRC | 16:41 | |
*** dustins has quit IRC | 16:41 | |
*** cdelatte has joined #openstack-cinder | 16:41 | |
*** karthik__ has joined #openstack-cinder | 16:41 | |
*** jgregor has quit IRC | 16:51 | |
*** salv-orlando has joined #openstack-cinder | 16:51 | |
*** jgregor has joined #openstack-cinder | 16:52 | |
*** julim has joined #openstack-cinder | 16:52 | |
*** jgregor has quit IRC | 16:54 | |
*** RuiChen has quit IRC | 16:56 | |
*** salv-orl_ has joined #openstack-cinder | 16:57 | |
*** salv-orlando has quit IRC | 16:58 | |
*** _ducttape_ has joined #openstack-cinder | 16:58 | |
*** salv-orl_ has quit IRC | 17:02 | |
*** ducttape_ has quit IRC | 17:03 | |
*** _ducttape_ has quit IRC | 17:03 | |
*** Suyash has quit IRC | 17:06 | |
*** mvk has quit IRC | 17:06 | |
openstackgerrit | Parashuram Hallur proposed openstack/cinder: Implementation for CoprHD Cinder Drivers https://review.openstack.org/317643 | 17:12 |
*** ducttape_ has joined #openstack-cinder | 17:13 | |
*** ducttape_ has quit IRC | 17:13 | |
*** ducttape_ has joined #openstack-cinder | 17:15 | |
*** kaisers has joined #openstack-cinder | 17:17 | |
*** Suyash has joined #openstack-cinder | 17:21 | |
*** julim has quit IRC | 17:21 | |
*** _ducttape_ has joined #openstack-cinder | 17:24 | |
*** ducttape_ has quit IRC | 17:25 | |
*** savihou has joined #openstack-cinder | 17:26 | |
*** karthik__ has quit IRC | 17:26 | |
*** rdx_matt has quit IRC | 17:26 | |
*** rdx_matt has joined #openstack-cinder | 17:27 | |
*** kaisers has quit IRC | 17:27 | |
*** cdelatte has quit IRC | 17:27 | |
*** salv-orlando has joined #openstack-cinder | 17:29 | |
*** rdx_matt has quit IRC | 17:32 | |
*** salv-orlando has quit IRC | 17:34 | |
*** kaisers has joined #openstack-cinder | 17:43 | |
*** ChubYann has joined #openstack-cinder | 17:45 | |
*** sdake has quit IRC | 17:45 | |
*** sgotliv__ has joined #openstack-cinder | 17:48 | |
*** Lee1092 has joined #openstack-cinder | 17:49 | |
*** jgregor has joined #openstack-cinder | 17:55 | |
openstackgerrit | Ryan Selden proposed openstack/python-cinderclient: Clean up `cinder show` when volume is attached https://review.openstack.org/336142 | 17:56 |
*** xinli has joined #openstack-cinder | 17:57 | |
*** salv-orlando has joined #openstack-cinder | 17:57 | |
xinli | dulek: could you please help to review the code for patch 251989, I think all the comments have been addressed, please let me know if I missed anyone: https://review.openstack.org/#/c/251989/ | 17:59 |
*** rdx_matt has joined #openstack-cinder | 18:01 | |
_alastor_ | smcginnis: Hey, here's an example of the tool output when you get results for all the CIs currently listed in the Wiki: http://pastebin.com/raw/cV5PLKze | 18:02 |
_alastor_ | smcginnis: Currently jenkins disagreements only go one way. Tempest fails in jenkins, but the CI passes | 18:04 |
*** xyang has joined #openstack-cinder | 18:04 | |
*** salv-orlando has quit IRC | 18:05 | |
smcginnis | _alastor_: Nice! | 18:05 |
*** salv-orlando has joined #openstack-cinder | 18:05 | |
erlon | _alastor_: ping | 18:05 |
_alastor_ | erlon: what's up | 18:05 |
*** rdx_matt has quit IRC | 18:06 | |
erlon | _alastor_: hmm, you might know this as you are working with the CIs | 18:07 |
erlon | _alastor_: there's an option on apache I think that changes the behavior of the browser when we click the tar.gz files | 18:07 |
erlon | _alastor_: http://210.51.195.55:5922/55/312355/30/gate_cinder/zte-cinder-tempest/1ffdf7b/logs/ | 18:07 |
erlon | _alastor_: in this CI they dont open in the browser | 18:08 |
smcginnis | erlon: That's in the third party CI documentation somewhere. | 18:08 |
erlon | _alastor_: hmmm | 18:08 |
smcginnis | http://docs.openstack.org/infra/system-config/third_party.html#faq-frequently-asked-questions | 18:08 |
_alastor_ | erlon: Unfortunately I know next to nothing about the Apache setup. I wrote my own custom CI runner :) | 18:08 |
*** mvk has joined #openstack-cinder | 18:09 | |
*** xyang has quit IRC | 18:09 | |
erlon | _alastor_: wrote a web server as well? lol | 18:09 |
_alastor_ | erlon: We just use S3 | 18:09 |
_alastor_ | erlon: With index files | 18:09 |
erlon | _alastor_: hmm, what is your CI? | 18:09 |
_alastor_ | datera-ci | 18:10 |
_alastor_ | I don't think I compress any of the files. My IT folks haven't yelled at me....yet | 18:10 |
erlon | _alastor_: mhm, I think the compression is part of the devstack-gate scripts, the data consumed is not too much actually | 18:11 |
*** dustins has joined #openstack-cinder | 18:11 | |
erlon | _alastor_: after 30 days you can delete it | 18:11 |
*** lpetrut has quit IRC | 18:12 | |
_alastor_ | erlon: Yeah, I need to get on that housekeeping task | 18:12 |
*** e0ne has joined #openstack-cinder | 18:13 | |
*** kwathore__ has joined #openstack-cinder | 18:21 | |
*** asselin_ has joined #openstack-cinder | 18:21 | |
*** kwathore_ has quit IRC | 18:24 | |
*** asselin_ has quit IRC | 18:24 | |
*** thumpba has joined #openstack-cinder | 18:29 | |
*** karthik__ has joined #openstack-cinder | 18:30 | |
*** sgotliv__ has quit IRC | 18:32 | |
*** e0ne has quit IRC | 18:33 | |
*** GB21 has quit IRC | 18:33 | |
*** thumpba has quit IRC | 18:34 | |
*** thumpba has joined #openstack-cinder | 18:35 | |
*** thumpba has quit IRC | 18:35 | |
*** thumpba has joined #openstack-cinder | 18:36 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/336168 | 18:41 |
*** karthik__ has quit IRC | 18:42 | |
*** e0ne has joined #openstack-cinder | 18:44 | |
*** abhi has quit IRC | 18:47 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-brick: Updated from global requirements https://review.openstack.org/333693 | 18:47 |
*** ociuhandu has quit IRC | 18:48 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-cinderclient: Updated from global requirements https://review.openstack.org/332361 | 18:48 |
*** e0ne has quit IRC | 18:54 | |
*** e0ne_ has joined #openstack-cinder | 18:54 | |
*** xinli has quit IRC | 18:54 | |
*** ccesario has quit IRC | 18:56 | |
*** karthik__ has joined #openstack-cinder | 18:57 | |
*** bjornar_ has joined #openstack-cinder | 18:58 | |
*** rdx_matt has joined #openstack-cinder | 19:03 | |
*** rdx_matt has quit IRC | 19:07 | |
*** kwathore__ has quit IRC | 19:11 | |
*** lpetrut has joined #openstack-cinder | 19:16 | |
*** darosale has quit IRC | 19:25 | |
*** e0ne_ has quit IRC | 19:30 | |
*** xinli has joined #openstack-cinder | 19:32 | |
*** darosale has joined #openstack-cinder | 19:34 | |
*** sheel has quit IRC | 19:35 | |
*** akerr has quit IRC | 19:36 | |
xinli | dulek: do you have time to review the patch 251989? https://review.openstack.org/#/c/251989/ | 19:37 |
*** gnarld_ is now known as cFouts | 19:40 | |
*** hoonetorg has quit IRC | 19:40 | |
openstackgerrit | Vasanthi Thirumalai proposed openstack/cinder: Violin Memory iSCSI storage for 7000 series AFA https://review.openstack.org/269796 | 19:41 |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Fix 'driver does not honor clone/snapshot' bugs https://review.openstack.org/336092 | 19:46 |
*** hoonetorg has joined #openstack-cinder | 19:52 | |
*** Lee1092 has quit IRC | 19:53 | |
*** merooney has quit IRC | 19:57 | |
jungleboyj | smcginnis: Ping | 19:57 |
karthik__ | scottda: Do you know what exactly was discussed here Grenade L63-64 in https://etherpad.openstack.org/p/Cinder-testing | 19:58 |
openstackgerrit | Patrick East proposed openstack/cinder: Add support for shared "backend_defaults" config https://review.openstack.org/335299 | 19:58 |
openstackgerrit | Patrick East proposed openstack/cinder: Deprecate defining c-vol backends in DEFAULT https://review.openstack.org/335135 | 19:58 |
openstackgerrit | Patrick East proposed openstack/cinder: Don't merge - demo showing DEFAULT as a shared conf https://review.openstack.org/335672 | 19:58 |
*** dansmith is now known as unicorn_slayer | 19:59 | |
karthik__ | patrickeast: Forgot to add you.. Do you know what exactly was discussed here Grenade L63-64 in https://etherpad.openstack.org/p/Cinder-testing | 20:01 |
*** lprice1 has joined #openstack-cinder | 20:01 | |
xinli | @smcginnis: my devstack enviornment messed, any idea to fix the issue? http://paste.openstack.org/show/524323/ | 20:01 |
*** asselin_ has joined #openstack-cinder | 20:02 | |
*** lprice has quit IRC | 20:03 | |
scottda | karthik__: I don't think we had much discussion, Michel just put the items on the list of things to test. | 20:05 |
*** xyang has joined #openstack-cinder | 20:05 | |
scottda | I know we want to use multinode to test rolling upgrades using Grenade. | 20:06 |
*** asselin has quit IRC | 20:06 | |
*** _ducttape_ has quit IRC | 20:07 | |
scottda | xinli: You need to resolve the merge conflicts in those 2 files. Open them up, look at the conflicts (between <<<< and >>>>), do 'git add <file>', then 'git rebase --continue'. For more info, google 'git resolve merge conflict' | 20:08 |
*** ducttape_ has joined #openstack-cinder | 20:09 | |
xinli | scodda: thanks | 20:09 |
*** satya_ has joined #openstack-cinder | 20:09 | |
*** xyang has quit IRC | 20:10 | |
*** faiz89 has joined #openstack-cinder | 20:13 | |
*** unicorn_slayer is now known as dansmith | 20:15 | |
xinli | scodda: After I fix both conflict files and using "git rebase --continue" it shows this: http://paste.openstack.org/show/524328/ | 20:21 |
scottda | xinli: So, are you trying to submit a patch to upstream gerrit? | 20:25 |
scottda | xinli: It is OK to submit on master, but you can also do 'git checkout -b <some_branch_name>' | 20:25 |
xinli | scottda: thx | 20:26 |
scottda | xinli: I usually choose some_branch_name to be 'bug/<bug_number>' or 'blueprint_name' | 20:26 |
scottda | That will populate the "topic" in gerrit | 20:27 |
xinli | scottda: agree, but I accidently removed the bug branck, now If I complet the git rebase --continue, it won't impact the cinder source code in jit, I just verify it. | 20:28 |
scottda | xinli: Well, even if you submit something that is defective or breaks stuff, it has to be approved to get merged. | 20:29 |
*** faiz89 has quit IRC | 20:29 | |
scottda | xinli: You can also use 'git reflog' to go back to a previous state in git. Google it for more info, it's pretty handy when you get into a bad state with git | 20:29 |
*** cdelatte has joined #openstack-cinder | 20:30 | |
xinli | scottda: thx | 20:31 |
*** cdelatte has quit IRC | 20:34 | |
*** cdelatte has joined #openstack-cinder | 20:39 | |
*** thumpba has quit IRC | 20:40 | |
*** rcernin has joined #openstack-cinder | 20:42 | |
jgriffith | ildikov: you still awake :) | 20:45 |
karthik__ | scottda: any idea what primary or sub means there ? | 20:46 |
scottda | karthik__: I think those are the 2 nodes in the multinode setup | 20:47 |
jungleboyj | jgriffith: Quick question. | 20:56 |
jungleboyj | or scottda | 20:56 |
jungleboyj | Either of you know how to set up a type key that will match a list of backends? | 20:57 |
jungleboyj | I.E. volume_backend_name = backend1 or backend2 | 20:57 |
jgriffith | jungleboyj: you can't :( | 20:58 |
jgriffith | jungleboyj: you have to key on something else if you want to do that | 20:58 |
jgriffith | jungleboyj: FWIW, that was my motivation for type groupings back in HongKong | 20:58 |
jungleboyj | jgriffith: *Sadness* Guess that is why I couldn't find anything. | 20:58 |
jgriffith | jungleboyj: there are ways to cheat it into submission | 20:59 |
jgriffith | jungleboyj: easy hack, add a capability to the drivers you want to be available, and put that in your extra-spec | 20:59 |
jungleboyj | jgregor: :-) Ok. | 20:59 |
jgriffith | jungleboyj: if there's another way to make it work I'm unaware | 20:59 |
jungleboyj | jgriffith: Ok, thanks for the info. | 20:59 |
jgriffith | jungleboyj: certainly | 20:59 |
* jungleboyj is learning so much as an admin | 21:00 | |
jgriffith | jungleboyj: every openstack developer/contributor should be required to deploy and maintain an in-use cloud (used by non-openstack people) | 21:00 |
*** merooney has joined #openstack-cinder | 21:01 | |
jgriffith | it certainly changes perspectives | 21:01 |
jungleboyj | jgriffith: I soon will meet that requirement. | 21:01 |
jgriffith | jungleboyj: lucky you :) | 21:01 |
*** eharney has quit IRC | 21:01 | |
*** lpetrut has quit IRC | 21:02 | |
jungleboyj | :-) I have already found a bug, so maybe it will be good for me. | 21:02 |
*** raildo is now known as raildo-afk | 21:02 | |
*** rdx_matt has joined #openstack-cinder | 21:05 | |
smcginnis | I wonder if we need some kind of backend tagging. | 21:05 |
*** diablo_rojo has quit IRC | 21:06 | |
smcginnis | Like in Jenkins you can set tags on slave nodes, then the master will only send jobs to slaves with that tag. | 21:06 |
smcginnis | jgriffith: What was your proposal in Hong Kong? | 21:06 |
jgriffith | smcginnis: that's sort of the work around I did | 21:06 |
jgriffith | smcginnis: I just added an extra-spec filter on vendor_name | 21:07 |
jgriffith | smcginnis: but of course that doesn't work in all cases | 21:07 |
jgriffith | smcginnis: proposal in HK was to be able to add various disparit types to a group | 21:07 |
smcginnis | Hmm, I suppose based on your criteria, grouping on vendor_name or similar works just fine. | 21:07 |
jgriffith | smcginnis: and then filter on that group | 21:07 |
jgriffith | smcginnis: implementation wise it might just look like the tag you mention | 21:08 |
smcginnis | jgriffith: Yeah, maybe same thing but we have different wording. | 21:08 |
jgriffith | smcginnis: would be interesting to just see if we can do a list of backend_names... that might even work already... not sure | 21:08 |
jgriffith | smcginnis: I seem to recal winston-d looking at that at one point | 21:09 |
*** cdelatte has quit IRC | 21:09 | |
smcginnis | jgriffith: You mean like what jungleboyj was asking? volume_backend_name=A,B,C | 21:09 |
jgriffith | smcginnis: yes | 21:09 |
*** dustins has quit IRC | 21:09 | |
jgriffith | smcginnis: that would serve the exact same purpose... grouping without a bunch of extra/confusing code :) | 21:09 |
smcginnis | jgriffith: That would be simple. | 21:10 |
jgriffith | smcginnis: jungleboyj also.. BTW, you can give multiple backends the same name if you want :) | 21:10 |
smcginnis | But if we do, it's un undocumented feature for sure. | 21:10 |
jgriffith | smcginnis: jungleboyj that works for some people | 21:10 |
smcginnis | Oh? Didn't realize that. | 21:10 |
jgriffith | smcginnis: yeah.... so as long as you don't need/want to truly work on a specific back end that works well | 21:10 |
smcginnis | [a1] volume_backend_name = a [a2] volume_backend_name = a < like that? | 21:11 |
jgriffith | then the scheduler just uses weighing | 21:11 |
jgriffith | smcginnis: yup | 21:11 |
jgriffith | exactly | 21:11 |
jgriffith | smcginnis: we initially did that to pool LVM backends | 21:11 |
smcginnis | jgriffith: Huh, I would never have tried that. I actually would have thought it would puke. :) | 21:11 |
jgriffith | smcginnis: it used to work :) | 21:11 |
jgriffith | smcginnis: should still | 21:12 |
smcginnis | Good pro tip. ;) | 21:12 |
jgriffith | should've thought of / mentioned that to jungleboyj... depending on what he's trying to set up | 21:12 |
jgriffith | like I said, the down side is if you do have a case were you specifically want to specify a host/backend you don't have that any more | 21:13 |
smcginnis | Wouldn't that screw up our retype with migration_policy = Never though? We key on name to decide whether it needs to migrate, right? | 21:13 |
*** rdx_matt has quit IRC | 21:13 | |
*** ametts has quit IRC | 21:13 | |
*** asselin__ has joined #openstack-cinder | 21:13 | |
* jgriffith whistles and looks the other direction | 21:13 | |
smcginnis | Hehe | 21:13 |
jgriffith | smcginnis: I'm of the opinion that retype with migration is evil anyway... so... ya know :) | 21:14 |
jgriffith | smcginnis: we should've probably made it migration with retype instead and just been completely explicit | 21:14 |
smcginnis | jgriffith: Hah! Well, if that's not a concern anyway, that's a pretty slick way to accomplish that grouping. | 21:14 |
jgriffith | smcginnis: yeah, there's all kinds of ways to *fool* filters :) | 21:15 |
smcginnis | jgriffith: My overview presentations I talk about retype vs migration just because that seems to be a common point of confusion. | 21:15 |
jgriffith | smcginnis: yeah... and rightfully so | 21:15 |
Swanson | Quick fix to a quick fix... https://review.openstack.org/#/c/336110/1 | 21:15 |
jgriffith | smcginnis: there's a lot going on there | 21:16 |
*** akshai has quit IRC | 21:16 | |
smcginnis | jgriffith: And just conceptually confusing! | 21:16 |
jgriffith | Swanson: you need to quit fixing things :) | 21:16 |
jgriffith | smcginnis: indeed... very much so | 21:16 |
*** asselin_ has quit IRC | 21:18 | |
Swanson | jgriffith, I need to test more than one path. Thanks for the +2! | 21:18 |
*** edmondsw has quit IRC | 21:24 | |
ildikov | jgriffith: hi :) | 21:25 |
*** Yogi1 has quit IRC | 21:27 | |
*** akapil has joined #openstack-cinder | 21:27 | |
*** porrua has quit IRC | 21:30 | |
*** porrua has joined #openstack-cinder | 21:31 | |
*** lprice has joined #openstack-cinder | 21:31 | |
*** lprice1 has quit IRC | 21:32 | |
*** diogogmt has quit IRC | 21:36 | |
*** bardia has quit IRC | 21:38 | |
*** rlrossit has quit IRC | 21:39 | |
jgriffith | ildikov: howdy | 21:40 |
jgriffith | ildikov: hey, I was looking at those unit tests last night and I remember why I never added them :) | 21:40 |
jgriffith | ildikov: they don't do anything :) | 21:40 |
*** jgregor1 has joined #openstack-cinder | 21:40 | |
jgriffith | ildikov: given that the new methods I introduced are just simple wrappers around the existing methods there wasn't much there | 21:41 |
*** HenryG_ has joined #openstack-cinder | 21:41 | |
ildikov | jgriffith: for the remove_attachment one there is some very small logic | 21:41 |
ildikov | jgriffith: as for create_attachment I was wondering the same :) | 21:42 |
jgriffith | :) | 21:42 |
*** jgregor1 has quit IRC | 21:42 | |
*** lprice has quit IRC | 21:42 | |
ildikov | jgriffith: although from test coverage point of view at least the positive test would still be good :) | 21:42 |
jgriffith | ildikov: yeah, might as well... plus it will enforce adding tests as we migrate that over to more sophisticated code right :) | 21:43 |
*** jroll|dupe has joined #openstack-cinder | 21:44 | |
*** jroll|dupe has quit IRC | 21:44 | |
*** jroll|dupe has joined #openstack-cinder | 21:44 | |
ildikov | jgriffith: haha, right :) | 21:44 |
ildikov | jgriffith: is this only me or the unit tests are not that well structured? | 21:44 |
jgriffith | ildikov: it's not just you | 21:44 |
jgriffith | :) | 21:44 |
jgriffith | ildikov: just a sec... | 21:45 |
*** hoonetorg has quit IRC | 21:45 | |
*** jgregor has quit IRC | 21:45 | |
*** mordred has quit IRC | 21:45 | |
*** HenryG has quit IRC | 21:45 | |
*** dulek has quit IRC | 21:45 | |
*** mkoderer__ has quit IRC | 21:45 | |
*** jroll has quit IRC | 21:45 | |
*** huyang has quit IRC | 21:45 | |
*** hogepodge has quit IRC | 21:45 | |
*** mkoderer has quit IRC | 21:45 | |
*** jroll|dupe is now known as jroll | 21:45 | |
jgriffith | ildikov: so I added "cinder/tests/unit/test_attach_detach_vol_apis.py" | 21:46 |
jgriffith | ildikov: I used a "with mock.patch.object " on manager.initiatlize_connection and manager.attach | 21:49 |
jgriffith | ildikov: then thought.. huh, I'm not testing anything :) | 21:49 |
*** porrua has quit IRC | 21:49 | |
jgriffith | ildikov: and calling either of those is sort of redundant as they're already tested elsewhere | 21:49 |
jgriffith | ildikov: or at least they should be :) | 21:49 |
ildikov | jgriffith: theoretically we would need to test all levels, I mean api and manager, etc. | 21:49 |
ildikov | jgriffith: I got to the same point a bit as well as you mock everything in create_attachment | 21:50 |
ildikov | :) | 21:50 |
*** cdelatte has joined #openstack-cinder | 21:51 | |
ildikov | jgriffith: but testing is for the future as well, I mean someone will modify that code once | 21:51 |
ildikov | jgriffith: what about adding functional test? | 21:51 |
*** HenryG_ is now known as HenryG | 21:52 | |
*** sdake_ has joined #openstack-cinder | 21:53 | |
*** sdake_ has quit IRC | 21:53 | |
*** sdake_ has joined #openstack-cinder | 21:53 | |
jgriffith | ildikov: sure, that would be good | 21:54 |
openstackgerrit | Ryan Selden proposed openstack/python-cinderclient: Clean up `cinder show` when volume is attached https://review.openstack.org/336142 | 21:54 |
jgriffith | ildikov: I'm supposed to pick scottda 's brain at some point on setting up a job for that | 21:55 |
scottda | yeah, we need to figure that out.... | 21:55 |
scottda | I'm not sure how much functional testing we can do around attach and detach, since we need Nova...unless Ivan has started down that path for his attach-without-nova code. | 21:56 |
jgriffith | scottda: fake nova | 21:57 |
jgriffith | scottda: which honestly we should NOT be putting real nova in our branch functional tests to begin with | 21:57 |
jgriffith | scottda: IMHO | 21:57 |
jgriffith | scottda: idea I thought was to just deploy Cinder and call it | 21:57 |
scottda | yeah, I agree | 21:58 |
jgriffith | scottda: and you most certainly can call attach/detach etc and inspect results | 21:58 |
jgriffith | scottda: cool | 21:58 |
scottda | jgriffith: that's true. I don't see fake nova. Does this exist yet? | 21:59 |
ildikov | yeap, I thought to use only Cinder | 21:59 |
ildikov | it should be Tempest where we have Nova as well | 22:00 |
jgriffith | scottda: no, I don't mean a *real* fake nova | 22:00 |
jgriffith | scottda: I just mean code that calls cinder api's and expects *things* | 22:00 |
*** aleksey2 has joined #openstack-cinder | 22:01 | |
*** aleksey2 is now known as alekseyruban | 22:01 | |
openstackgerrit | Ryan Selden proposed openstack/python-cinderclient: Clean up `cinder show` when volume is attached https://review.openstack.org/336142 | 22:02 |
scottda | jgriffith: Sure, get a connector and stuff like that. But, I think Ivan has already started on functional tests for attach-without-nova...not sure, but I thought I saw that somewhere... | 22:02 |
*** catintheroof has joined #openstack-cinder | 22:03 | |
*** xyang has joined #openstack-cinder | 22:06 | |
*** mriedem has quit IRC | 22:07 | |
jgriffith | scottda: cool | 22:07 |
scottda | This: https://review.openstack.org/#/c/265811/ | 22:08 |
*** cdelatte has quit IRC | 22:09 | |
scottda | jgriffith: ^^^ | 22:10 |
jgriffith | scottda: oh, yeah.... you shouldn't remind me of that one :( | 22:10 |
*** xyang has quit IRC | 22:11 | |
jgriffith | scottda: it makes me cry a little | 22:12 |
scottda | jgriffith: I have a hard time visualizing that. | 22:12 |
jgriffith | scottda: http://louderwithcrowder.com/wp-content/uploads/2016/02/DumbandDumberCryThrowUp.gif | 22:14 |
*** akapil has quit IRC | 22:14 | |
jgriffith | scottda: or sometimes it looks like this: http://louderwithcrowder.com/wp-content/uploads/2015/09/Dawson.gif | 22:14 |
scottda | jgriffith: Your hair was longer in that picture. | 22:15 |
jgriffith | haha | 22:15 |
* ildikov wonders what's much if the first one was the little... :) | 22:15 | |
*** julim has joined #openstack-cinder | 22:16 | |
*** tpsilva has quit IRC | 22:18 | |
smcginnis | Nice imagery! :) | 22:18 |
*** mordred has joined #openstack-cinder | 22:22 | |
*** cdelatte has joined #openstack-cinder | 22:27 | |
*** ntpttr has quit IRC | 22:31 | |
*** ntpttr has joined #openstack-cinder | 22:31 | |
openstackgerrit | Ryan Selden proposed openstack/python-cinderclient: Clean up `cinder show` when volume is attached https://review.openstack.org/336142 | 22:31 |
*** sdake_ has quit IRC | 22:33 | |
*** salv-orl_ has joined #openstack-cinder | 22:34 | |
*** salv-orlando has quit IRC | 22:35 | |
*** asselin__ has quit IRC | 22:37 | |
*** jamielennox|away is now known as jamielennox | 22:37 | |
*** karthik__ has quit IRC | 22:41 | |
*** ducttape_ has quit IRC | 22:49 | |
*** cdelatte has quit IRC | 22:52 | |
*** enriquetaso has quit IRC | 22:53 | |
patrickeast | jgriffith: jungleboyj: just saw the conversation earlier about multiple backends in a single type, can't you just use the <in> keyword for the spec definition? | 23:00 |
patrickeast | always forget which way the in works... like an array in the definition side or in the thing its trying to match | 23:00 |
*** leeantho has quit IRC | 23:03 | |
*** darosale has quit IRC | 23:05 | |
openstackgerrit | Merged openstack/cinder: Dell SC: Do not set High Availability in async mode. https://review.openstack.org/336110 | 23:08 |
*** sdake has joined #openstack-cinder | 23:11 | |
*** sdake has quit IRC | 23:11 | |
*** karthik__ has joined #openstack-cinder | 23:11 | |
*** catintheroof has quit IRC | 23:18 | |
*** mriedem has joined #openstack-cinder | 23:18 | |
*** markvoelker has quit IRC | 23:21 | |
*** seldenr has quit IRC | 23:25 | |
*** EinstCrazy has joined #openstack-cinder | 23:28 | |
*** EinstCrazy has quit IRC | 23:33 | |
*** enriquetaso has joined #openstack-cinder | 23:37 | |
*** faiz89 has joined #openstack-cinder | 23:42 | |
*** faiz891 has joined #openstack-cinder | 23:43 | |
*** cdelatte has joined #openstack-cinder | 23:44 | |
*** erlon has quit IRC | 23:46 | |
*** faiz89 has quit IRC | 23:47 | |
*** faiz89 has joined #openstack-cinder | 23:48 | |
*** faiz891 has quit IRC | 23:48 | |
*** faiz891 has joined #openstack-cinder | 23:48 | |
*** bjornar_ has quit IRC | 23:49 | |
*** faiz891 has quit IRC | 23:50 | |
*** satya_ has quit IRC | 23:51 | |
*** faiz892 has joined #openstack-cinder | 23:51 | |
*** satya_ has joined #openstack-cinder | 23:52 | |
*** faiz89 has quit IRC | 23:52 | |
*** enriquetaso has quit IRC | 23:52 | |
*** IlyaG has joined #openstack-cinder | 23:53 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/336168 | 23:56 |
*** satya_ has quit IRC | 23:58 | |
*** hogepodge has joined #openstack-cinder | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!