| *** ducttape_ has quit IRC | 00:00 | |
| *** yangyapeng has quit IRC | 00:02 | |
| *** raunak has quit IRC | 00:03 | |
| *** raunak has joined #openstack-cinder | 00:05 | |
| *** jiaohaolin has quit IRC | 00:07 | |
| *** alonma has joined #openstack-cinder | 00:17 | |
| *** alonma has quit IRC | 00:22 | |
| *** jwcroppe has joined #openstack-cinder | 00:23 | |
| *** jwcroppe has quit IRC | 00:28 | |
| *** raunak has quit IRC | 00:37 | |
| *** mriedem has quit IRC | 00:58 | |
| *** cheneydc has joined #openstack-cinder | 00:59 | |
| *** ducttape_ has joined #openstack-cinder | 01:01 | |
| *** bswartz has joined #openstack-cinder | 01:02 | |
| *** cheneydc has quit IRC | 01:05 | |
| *** ducttape_ has quit IRC | 01:05 | |
| *** lixiaoy1 has quit IRC | 01:10 | |
| *** lixiaoy1 has joined #openstack-cinder | 01:11 | |
| lixiaoy1 | jgriffith: Hi John, may I talk to you about your concerns about these two patches: https://review.openstack.org/#/c/268608/ and https://review.openstack.org/#/c/268609/ ? | 01:12 |
|---|---|---|
| *** bswartz has quit IRC | 01:13 | |
| *** TaylorHuang has joined #openstack-cinder | 01:14 | |
| *** TaylorH has quit IRC | 01:17 | |
| *** yangyapeng has joined #openstack-cinder | 01:17 | |
| openstackgerrit | Patrick East proposed openstack/cinder: Add tempest tests for Consistency Groups https://review.openstack.org/355271 | 01:18 |
| *** EinstCrazy has joined #openstack-cinder | 01:23 | |
| *** June has quit IRC | 01:30 | |
| *** laughterwym has joined #openstack-cinder | 01:32 | |
| *** Lee1092 has joined #openstack-cinder | 01:35 | |
| *** laughterwym has quit IRC | 01:40 | |
| *** laughterwym has joined #openstack-cinder | 01:40 | |
| *** laughterwym has quit IRC | 01:45 | |
| *** cknight has left #openstack-cinder | 01:46 | |
| *** ducttape_ has joined #openstack-cinder | 01:46 | |
| *** ducttape_ has quit IRC | 01:56 | |
| openstackgerrit | yangweiwei proposed openstack/cinder: Update db operation of cinder in "extra_specs" https://review.openstack.org/345119 | 01:58 |
| *** jamielennox is now known as jamielennox|away | 02:10 | |
| *** yangyape_ has joined #openstack-cinder | 02:11 | |
| *** yangyapeng has quit IRC | 02:14 | |
| *** yangyape_ has quit IRC | 02:23 | |
| *** yangyapeng has joined #openstack-cinder | 02:24 | |
| *** yangyape_ has joined #openstack-cinder | 02:24 | |
| *** jwcroppe has joined #openstack-cinder | 02:26 | |
| *** yangyapeng has quit IRC | 02:29 | |
| *** jamielennox|away is now known as jamielennox | 02:30 | |
| *** jwcroppe has quit IRC | 02:31 | |
| *** ducttape_ has joined #openstack-cinder | 02:32 | |
| *** lixiaoy1 has quit IRC | 02:40 | |
| *** lickitysplitted has left #openstack-cinder | 02:42 | |
| openstackgerrit | xiexs proposed openstack/cinder: Refactor the usage of save_and_reraise_exception https://review.openstack.org/355279 | 02:45 |
| *** ducttape_ has quit IRC | 03:02 | |
| *** gcb has joined #openstack-cinder | 03:02 | |
| openstackgerrit | Arsen Chen proposed openstack/cinder: Revise Synology DSM storage driver https://review.openstack.org/341345 | 03:27 |
| *** laughterwym has joined #openstack-cinder | 03:31 | |
| *** laughterwym has quit IRC | 03:36 | |
| *** laughterwym has joined #openstack-cinder | 03:37 | |
| *** laughterwym has quit IRC | 03:41 | |
| *** Lee1092 has quit IRC | 03:43 | |
| *** laughterwym has joined #openstack-cinder | 03:47 | |
| *** laughterwym has quit IRC | 03:50 | |
| *** laughterwym has joined #openstack-cinder | 03:50 | |
| *** EinstCrazy has quit IRC | 03:53 | |
| *** laughterwym has quit IRC | 03:55 | |
| *** ducttape_ has joined #openstack-cinder | 04:02 | |
| *** Asaithambi has joined #openstack-cinder | 04:07 | |
| *** ducttape_ has quit IRC | 04:07 | |
| *** alonma has joined #openstack-cinder | 04:19 | |
| *** chlong has joined #openstack-cinder | 04:21 | |
| *** alonma has quit IRC | 04:23 | |
| *** jwcroppe has joined #openstack-cinder | 04:29 | |
| *** alonma has joined #openstack-cinder | 04:31 | |
| *** gouthamr has quit IRC | 04:33 | |
| *** EinstCrazy has joined #openstack-cinder | 04:33 | |
| *** jwcroppe has quit IRC | 04:33 | |
| *** alonma has quit IRC | 04:36 | |
| *** alonma has joined #openstack-cinder | 04:38 | |
| *** alonma has quit IRC | 04:43 | |
| openstackgerrit | xiexs proposed openstack/cinder: Remove the using of dict.get() in assertIsNone https://review.openstack.org/355295 | 04:43 |
| *** Asaithambi has quit IRC | 04:44 | |
| *** alonma has joined #openstack-cinder | 04:46 | |
| *** laughterwym has joined #openstack-cinder | 04:47 | |
| *** laughterwym has quit IRC | 04:50 | |
| *** alonma has quit IRC | 04:50 | |
| *** laughterwym has joined #openstack-cinder | 04:51 | |
| *** alonma has joined #openstack-cinder | 04:53 | |
| *** EinstCrazy has quit IRC | 04:54 | |
| *** EinstCrazy has joined #openstack-cinder | 04:55 | |
| *** laughterwym has quit IRC | 04:55 | |
| *** alonma has quit IRC | 04:57 | |
| *** EinstCrazy has quit IRC | 04:59 | |
| *** EinstCrazy has joined #openstack-cinder | 05:00 | |
| *** ducttape_ has joined #openstack-cinder | 05:04 | |
| *** alonma has joined #openstack-cinder | 05:06 | |
| *** bswartz has joined #openstack-cinder | 05:07 | |
| *** ducttape_ has quit IRC | 05:08 | |
| *** lkuchlan has joined #openstack-cinder | 05:09 | |
| *** alonma has quit IRC | 05:11 | |
| *** pbandark has joined #openstack-cinder | 05:14 | |
| *** crose has quit IRC | 05:15 | |
| *** crose has joined #openstack-cinder | 05:18 | |
| *** GB21 has joined #openstack-cinder | 05:21 | |
| *** rcernin has joined #openstack-cinder | 05:25 | |
| *** EinstCrazy has quit IRC | 05:26 | |
| *** EinstCrazy has joined #openstack-cinder | 05:27 | |
| *** EinstCra_ has joined #openstack-cinder | 05:30 | |
| *** EinstCrazy has quit IRC | 05:31 | |
| *** lixiaoy1 has joined #openstack-cinder | 05:38 | |
| *** ebalduf has quit IRC | 05:44 | |
| *** rkrum has joined #openstack-cinder | 05:47 | |
| *** liverpooler has joined #openstack-cinder | 05:59 | |
| *** lkuchlan has quit IRC | 06:02 | |
| *** ducttape_ has joined #openstack-cinder | 06:04 | |
| *** alonma has joined #openstack-cinder | 06:06 | |
| *** ducttape_ has quit IRC | 06:09 | |
| *** alonma has quit IRC | 06:10 | |
| *** jmccrory is now known as jmccrory_away | 06:12 | |
| *** alonma has joined #openstack-cinder | 06:13 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Zanata https://review.openstack.org/355314 | 06:16 |
| *** alonma has quit IRC | 06:18 | |
| *** alonma has joined #openstack-cinder | 06:20 | |
| *** jwcroppe has joined #openstack-cinder | 06:23 | |
| *** alonma has quit IRC | 06:24 | |
| *** alonma has joined #openstack-cinder | 06:27 | |
| *** jwcroppe has quit IRC | 06:28 | |
| *** lixiaoy1 has quit IRC | 06:29 | |
| *** lixiaoy1 has joined #openstack-cinder | 06:30 | |
| *** alonma has quit IRC | 06:31 | |
| openstackgerrit | xiexs proposed openstack/cinder: Refactor the using of dict.get() in the test assertion https://review.openstack.org/355323 | 06:33 |
| *** alonma has joined #openstack-cinder | 06:35 | |
| *** david-lyle has joined #openstack-cinder | 06:36 | |
| *** pcaruana has joined #openstack-cinder | 06:36 | |
| *** houming has joined #openstack-cinder | 06:38 | |
| *** david-lyle_ has quit IRC | 06:39 | |
| *** alonma has quit IRC | 06:39 | |
| *** alonma has joined #openstack-cinder | 06:42 | |
| *** alonma has quit IRC | 06:46 | |
| *** belmoreira has joined #openstack-cinder | 06:48 | |
| *** alonma has joined #openstack-cinder | 06:49 | |
| *** alonma has quit IRC | 06:53 | |
| *** gcb has quit IRC | 06:56 | |
| *** alonma has joined #openstack-cinder | 06:56 | |
| *** alonma has quit IRC | 07:00 | |
| *** Thelo has joined #openstack-cinder | 07:02 | |
| *** lkuchlan has joined #openstack-cinder | 07:03 | |
| *** alonma has joined #openstack-cinder | 07:03 | |
| *** ducttape_ has joined #openstack-cinder | 07:05 | |
| *** rkrum has quit IRC | 07:07 | |
| *** alonma has quit IRC | 07:07 | |
| *** alonma has joined #openstack-cinder | 07:08 | |
| *** chlong has quit IRC | 07:08 | |
| *** ducttape_ has quit IRC | 07:09 | |
| *** Thelo has quit IRC | 07:10 | |
| *** Thelo has joined #openstack-cinder | 07:12 | |
| openstackgerrit | Matan Sabag proposed openstack/cinder: Sending ScaleIO volume id in attach and detach volume https://review.openstack.org/355231 | 07:16 |
| *** arecknag has joined #openstack-cinder | 07:16 | |
| *** Thelo has left #openstack-cinder | 07:17 | |
| *** savihou has joined #openstack-cinder | 07:21 | |
| *** chlong has joined #openstack-cinder | 07:25 | |
| *** lpetrut has joined #openstack-cinder | 07:34 | |
| *** GB21 has quit IRC | 07:38 | |
| *** Lee1092 has joined #openstack-cinder | 07:40 | |
| *** v12aml has joined #openstack-cinder | 07:41 | |
| *** alonma has quit IRC | 07:45 | |
| *** alonma has joined #openstack-cinder | 07:50 | |
| *** GB21 has joined #openstack-cinder | 07:53 | |
| *** yangyape_ has quit IRC | 07:54 | |
| *** yangyapeng has joined #openstack-cinder | 07:57 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** lixiaoy1 has quit IRC | 08:01 | |
| *** sdake has joined #openstack-cinder | 08:01 | |
| *** zzzeek has joined #openstack-cinder | 08:02 | |
| *** savihou has quit IRC | 08:04 | |
| *** yangyapeng has quit IRC | 08:06 | |
| *** yangyapeng has joined #openstack-cinder | 08:06 | |
| *** ducttape_ has joined #openstack-cinder | 08:06 | |
| *** chlong has quit IRC | 08:07 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/cinder: [WIP] Testing latest u-c https://review.openstack.org/303766 | 08:10 |
| *** ducttape_ has quit IRC | 08:11 | |
| *** e0ne has joined #openstack-cinder | 08:15 | |
| *** sdake has quit IRC | 08:15 | |
| *** alonma has quit IRC | 08:21 | |
| *** alonma has joined #openstack-cinder | 08:22 | |
| *** houming has quit IRC | 08:30 | |
| *** Thelo has joined #openstack-cinder | 08:34 | |
| *** e0ne has quit IRC | 08:35 | |
| *** sdake has joined #openstack-cinder | 08:35 | |
| *** e0ne has joined #openstack-cinder | 08:37 | |
| *** houming has joined #openstack-cinder | 08:40 | |
| *** markvoelker has joined #openstack-cinder | 08:41 | |
| *** lixiaoy1 has joined #openstack-cinder | 08:41 | |
| *** sdake has quit IRC | 08:43 | |
| *** markvoelker has quit IRC | 08:45 | |
| *** lpetrut has quit IRC | 08:47 | |
| *** laughterwym has joined #openstack-cinder | 08:50 | |
| *** houming has quit IRC | 08:50 | |
| *** alonma has quit IRC | 08:51 | |
| *** alonma has joined #openstack-cinder | 08:51 | |
| *** Thelo has quit IRC | 08:52 | |
| *** mvk has joined #openstack-cinder | 08:56 | |
| *** houming has joined #openstack-cinder | 08:57 | |
| *** lpetrut has joined #openstack-cinder | 08:58 | |
| guy | DuncanT: Hi DuncanT, are you here? | 09:00 |
| *** ducttape_ has joined #openstack-cinder | 09:07 | |
| *** ducttape_ has quit IRC | 09:11 | |
| *** lixiaoy1 has quit IRC | 09:12 | |
| *** lixiaoy1 has joined #openstack-cinder | 09:12 | |
| nikeshm | DuncanT: hi, can you give +2 on https://review.openstack.org/#/c/354703 | 09:18 |
| *** avishay has joined #openstack-cinder | 09:19 | |
| DuncanT | guy: Yes, briefly at least | 09:20 |
| DuncanT | nikeshm: I'll take a look | 09:20 |
| avishay | Hi all, in cinder/brick/local_dev/lvm.py, we use self._execute() for everything except in method get_all_volume_groups where we use putils.execute(). Is this on purpose? | 09:20 |
| guy | DuncanT: ok. I took a look at chunked driver | 09:20 |
| DuncanT | nikeshm: What CI covers the K2 array? | 09:21 |
| DuncanT | guy: Great. Does it look useful? | 09:21 |
| guy | DuncanT: I think that we cannot use it for disco storage system. Because it needs to create a container to store the metadata file inside. By the way, Ceph doesn't use the chunked driver. Google does. | 09:21 |
| DuncanT | Hmmm, I'll look at updating the ceph driver then, thanks for the heads up | 09:22 |
| nikeshm | DuncanT: run-Kaminario K2 CI | 09:22 |
| DuncanT | guy: 'container' in this case means 'anywhere you can storage a metadata file' which isn't necessarily a container in the object store sense | 09:23 |
| DuncanT | nikeshm: Ok, it passed. Thanks | 09:24 |
| DuncanT | nikeshm: In future, mentioning the full array name, rather than just 'K2' int he commit message would generally help those of use with 80 drivers to keep track of | 09:24 |
| *** savihou has joined #openstack-cinder | 09:24 | |
| nikeshm | DuncanT: sure | 09:25 |
| DuncanT | nikeshm: This one is +2 though | 09:25 |
| nikeshm | thanks | 09:26 |
| DuncanT | I've got to step out for lunch, will see messages on my return | 09:28 |
| guy | DuncanT: ah ok, I thought it was the container in the object store | 09:28 |
| guy | DuncanT: Thank you DuncanT | 09:28 |
| *** lpetrut has quit IRC | 09:30 | |
| DuncanT | guy: The method names are that way because it was written for an object store, but really, it just needs somewhere to store the json blob where it can be got back. You could even write it to the end of the volume and put the offset in a binary header, I guess... | 09:30 |
| guy | DuncanT: Ok thanks I will think about it. | 09:32 |
| *** lixiaoy1 has quit IRC | 09:39 | |
| *** lixiaoy1_ has joined #openstack-cinder | 09:39 | |
| *** asselin has joined #openstack-cinder | 09:45 | |
| *** sdake has joined #openstack-cinder | 09:46 | |
| *** asselin_ has quit IRC | 09:48 | |
| *** Asaithambi has joined #openstack-cinder | 09:50 | |
| *** alonma has quit IRC | 09:51 | |
| *** alonma has joined #openstack-cinder | 09:51 | |
| *** laughterwym has quit IRC | 09:55 | |
| *** alonma has quit IRC | 09:56 | |
| *** avishay has quit IRC | 09:58 | |
| *** alonma has joined #openstack-cinder | 09:59 | |
| *** Lallana has quit IRC | 10:01 | |
| *** alonma has quit IRC | 10:03 | |
| *** alonma has joined #openstack-cinder | 10:06 | |
| *** ducttape_ has joined #openstack-cinder | 10:08 | |
| *** alonma has quit IRC | 10:10 | |
| *** ducttape_ has quit IRC | 10:12 | |
| *** alonma has joined #openstack-cinder | 10:13 | |
| *** avishay has joined #openstack-cinder | 10:14 | |
| *** alonma has quit IRC | 10:14 | |
| *** alonma has joined #openstack-cinder | 10:14 | |
| *** EinstCra_ has quit IRC | 10:20 | |
| *** jwcroppe has joined #openstack-cinder | 10:20 | |
| *** yangyapeng has quit IRC | 10:20 | |
| *** jwcroppe has quit IRC | 10:27 | |
| *** sdague has joined #openstack-cinder | 10:31 | |
| *** alonma has quit IRC | 10:40 | |
| *** alonma has joined #openstack-cinder | 10:41 | |
| *** markvoelker has joined #openstack-cinder | 10:42 | |
| *** alonma has quit IRC | 10:44 | |
| *** alonma has joined #openstack-cinder | 10:44 | |
| *** lpetrut has joined #openstack-cinder | 10:45 | |
| *** markvoelker has quit IRC | 10:47 | |
| *** lpetrut has quit IRC | 11:06 | |
| *** ducttape_ has joined #openstack-cinder | 11:08 | |
| jgriffith | avishay: yes, not there actually a few uses in there and they are all static methods | 11:09 |
| jgriffith | s/not/note/ | 11:09 |
| jgriffith | avishay: that's to say "yes, it's inentional" and that it is because those are static methods (get_all_volume_groups, get_lvm_version, get_lv_info and get all physcial_volumes) | 11:11 |
| jgriffith | lixiaoy1_: pong | 11:11 |
| *** alonma has quit IRC | 11:12 | |
| *** ducttape_ has quit IRC | 11:13 | |
| avishay | jgriffith: gotcha, ok thank you | 11:13 |
| *** alonma has joined #openstack-cinder | 11:13 | |
| *** yangyapeng has joined #openstack-cinder | 11:23 | |
| *** xiexs has joined #openstack-cinder | 11:42 | |
| *** gcb has joined #openstack-cinder | 11:45 | |
| nikeshm | DuncanT: jenkins gave -2 on https://review.openstack.org/#/c/354703 | 11:48 |
| nikeshm | shall i do reverify | 11:49 |
| *** sdake has quit IRC | 12:02 | |
| xiexs | sounds now it's just recheck | 12:02 |
| xiexs | http://docs.openstack.org/infra/manual/developers.html#automated-testing | 12:02 |
| jgriffith | xiexs: you're correct | 12:03 |
| jgriffith | there's no distinction any longer | 12:03 |
| *** edmondsw has joined #openstack-cinder | 12:04 | |
| openstackgerrit | Wenjun Wang proposed openstack/cinder-specs: Make quota-class working better https://review.openstack.org/355430 | 12:06 |
| *** sdake has joined #openstack-cinder | 12:06 | |
| *** JoseMello has joined #openstack-cinder | 12:09 | |
| *** ducttape_ has joined #openstack-cinder | 12:09 | |
| *** gouthamr has joined #openstack-cinder | 12:10 | |
| *** gcb has quit IRC | 12:12 | |
| *** ducttape_ has quit IRC | 12:12 | |
| *** gcb has joined #openstack-cinder | 12:13 | |
| *** ducttape_ has joined #openstack-cinder | 12:13 | |
| *** jwcroppe has joined #openstack-cinder | 12:15 | |
| xiexs | Hi, all, do we have a plan for the "centralize-config-options"? Just like nova does. | 12:15 |
| nikeshm | xiexs jgriffith : ok thanks | 12:16 |
| xiexs | I submitted a bp for it, please give me some advice if you have time. Thanks in advance. | 12:16 |
| xiexs | The URL is https://blueprints.launchpad.net/cinder/+spec/centralize-config-options | 12:17 |
| xiexs | nikeshm: you're welcome:) | 12:17 |
| *** avishay has quit IRC | 12:19 | |
| *** jwcroppe has quit IRC | 12:26 | |
| *** markvoelker has joined #openstack-cinder | 12:30 | |
| *** GB21 has quit IRC | 12:35 | |
| *** mtanino has joined #openstack-cinder | 12:35 | |
| *** ducttape_ has quit IRC | 12:35 | |
| *** sdake has quit IRC | 12:38 | |
| *** alonma has quit IRC | 12:41 | |
| *** alonma has joined #openstack-cinder | 12:42 | |
| *** alonma has quit IRC | 12:43 | |
| *** alonma has joined #openstack-cinder | 12:43 | |
| *** julim has joined #openstack-cinder | 12:44 | |
| *** rkrum has joined #openstack-cinder | 12:47 | |
| *** rlrossit has joined #openstack-cinder | 12:49 | |
| *** laughterwym has joined #openstack-cinder | 12:50 | |
| *** pauloewerton has joined #openstack-cinder | 12:50 | |
| *** amoralej|off has quit IRC | 12:50 | |
| *** amoralej has joined #openstack-cinder | 12:53 | |
| *** avishay has joined #openstack-cinder | 12:54 | |
| *** gcb has quit IRC | 12:55 | |
| DuncanT | xiexs: Funny you should mention that, I was just reading cinder/opts.py and now want to sit and gibber for a while. We've definitely lost the plot entirely on that one | 12:55 |
| *** xyang1 has joined #openstack-cinder | 12:56 | |
| *** alonma has quit IRC | 13:00 | |
| *** julim has quit IRC | 13:01 | |
| *** alonma has joined #openstack-cinder | 13:03 | |
| *** alonma has joined #openstack-cinder | 13:03 | |
| *** houming has quit IRC | 13:04 | |
| *** julim has joined #openstack-cinder | 13:05 | |
| *** avishay has quit IRC | 13:05 | |
| *** rkrum has quit IRC | 13:10 | |
| *** rkrum has joined #openstack-cinder | 13:11 | |
| *** ducttape_ has joined #openstack-cinder | 13:14 | |
| *** rkrum has quit IRC | 13:16 | |
| *** jwcroppe has joined #openstack-cinder | 13:19 | |
| *** lkuchlan has quit IRC | 13:19 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Differentiate thick and thin provisioning https://review.openstack.org/315352 | 13:22 |
| *** dustins has joined #openstack-cinder | 13:23 | |
| *** GB21 has joined #openstack-cinder | 13:24 | |
| openstackgerrit | Merged openstack/cinder: Make the volume-manage doc be more general https://review.openstack.org/341302 | 13:25 |
| *** porrua has joined #openstack-cinder | 13:27 | |
| *** belmoreira has quit IRC | 13:31 | |
| *** ducttape_ has quit IRC | 13:33 | |
| *** mriedem has joined #openstack-cinder | 13:34 | |
| *** akerr has joined #openstack-cinder | 13:37 | |
| *** jwcroppe has quit IRC | 13:37 | |
| *** Asaithambi has quit IRC | 13:37 | |
| *** GB21 has quit IRC | 13:41 | |
| *** rlrossit has quit IRC | 13:48 | |
| *** belmoreira has joined #openstack-cinder | 13:50 | |
| *** rlrossit_ has joined #openstack-cinder | 13:52 | |
| *** chlong has joined #openstack-cinder | 13:52 | |
| *** diablo_rojo has joined #openstack-cinder | 13:56 | |
| ildikov | jgriffith: hi | 13:57 |
| jgriffith | ildikov: morning | 13:57 |
| jgriffith | ildikov: or evening :) | 13:57 |
| ildikov | jgriffith: afternoon :) | 13:57 |
| ildikov | jgriffith: there's a meeting popped up in parallel with hours | 13:57 |
| jgriffith | It was bound to be one of those | 13:57 |
| ildikov | s/hours/ours/ | 13:58 |
| * ildikov needs more coffee... | 13:58 | |
| *** dims has quit IRC | 13:59 | |
| ildikov | haha, no worries I usually talk to people, who start with good morning in my afternoon time, so I tend to believe by now that it's still morning :) | 13:59 |
| jgriffith | ildikov: ha | 14:00 |
| jgriffith | ildikov: so do you want to reschedule? | 14:00 |
| ildikov | jgriffith: I can start our meeting today and try to follow, I was wondering of you could facilitate? | 14:00 |
| jgriffith | I might be able to do that | 14:01 |
| ildikov | s/of/if | 14:01 |
| ildikov | if the time slot is not comfortable for you either we can try a reschedule | 14:01 |
| *** Asaithambi has joined #openstack-cinder | 14:01 | |
| ildikov | it's just never easy to find time | 14:01 |
| jgriffith | very true | 14:01 |
| ildikov | that fits for everyone... :S | 14:01 |
| jgriffith | what time are we set for now again? | 14:02 |
| ildikov | 1700UTC | 14:02 |
| jgriffith | Ok, sure | 14:02 |
| ildikov | BTW, I'll be at OpenStackEast next week | 14:03 |
| smcginnis | ildikov: Will you also be at the operators midcycle? | 14:04 |
| ildikov | I saw you on the schedule, so I hoped we can catch up | 14:04 |
| ildikov | smcginnis: I registered, so that's the plan, yes | 14:04 |
| *** ducttape_ has joined #openstack-cinder | 14:04 | |
| smcginnis | ildikov: Cool. I couldn't make it to OpenStackEast, but I'll be at the midcycle Thurs/Fri. | 14:04 |
| ildikov | smcginnis: cool! we could almost have a small Cinder gathering there it seems :) | 14:05 |
| *** dims has joined #openstack-cinder | 14:05 | |
| smcginnis | Great! It will be good to see everyone there. | 14:07 |
| *** GB21 has joined #openstack-cinder | 14:07 | |
| *** Julien-zte has joined #openstack-cinder | 14:08 | |
| openstackgerrit | Merged openstack/cinder: Imported Translations from Zanata https://review.openstack.org/355314 | 14:08 |
| *** ebalduf has joined #openstack-cinder | 14:09 | |
| openstackgerrit | Merged openstack/cinder: Add CI wiki page to driver listing https://review.openstack.org/353965 | 14:09 |
| openstackgerrit | Merged openstack/cinder: Remove the using of dict.get() in assertIsNone https://review.openstack.org/355295 | 14:09 |
| *** mtanino has quit IRC | 14:09 | |
| ildikov | jgriffith: are you there Thurs/Fri as well? | 14:09 |
| *** sdake has joined #openstack-cinder | 14:10 | |
| openstackgerrit | Arnon Yaari proposed openstack/cinder: New cinder driver to support INFINIDAT InfiniBox https://review.openstack.org/355241 | 14:13 |
| *** savihou has quit IRC | 14:15 | |
| jgriffith | ildikov: no.. unfortunately I have to head out on Thursday | 14:17 |
| ildikov | jgriffith: ok, never mind, I was just curious | 14:20 |
| *** jungleboyj has joined #openstack-cinder | 14:21 | |
| *** lpetrut has joined #openstack-cinder | 14:24 | |
| *** Asaithambi has quit IRC | 14:25 | |
| *** ametts has joined #openstack-cinder | 14:26 | |
| *** pcaruana has quit IRC | 14:30 | |
| *** Asaithambi has joined #openstack-cinder | 14:31 | |
| *** jdurgin1 has joined #openstack-cinder | 14:39 | |
| *** Julien-zte has quit IRC | 14:40 | |
| *** JoseMello has quit IRC | 14:40 | |
| *** krtaylor has quit IRC | 14:42 | |
| *** ducttape_ has quit IRC | 14:44 | |
| *** baumann has joined #openstack-cinder | 14:45 | |
| *** charlesr has joined #openstack-cinder | 14:47 | |
| *** sdake has quit IRC | 14:48 | |
| openstackgerrit | Merged openstack/os-brick: Add connector for vmdk volumes https://review.openstack.org/341513 | 14:49 |
| *** jbernard1 has joined #openstack-cinder | 14:52 | |
| *** xinli has joined #openstack-cinder | 14:54 | |
| *** ociuhandu has joined #openstack-cinder | 14:55 | |
| *** Julien-zte has joined #openstack-cinder | 14:58 | |
| *** akerr is now known as akerr_away | 15:00 | |
| *** akerr_away is now known as akerr | 15:00 | |
| *** lpetrut has quit IRC | 15:06 | |
| *** rcernin has quit IRC | 15:06 | |
| *** mvk has quit IRC | 15:10 | |
| *** Yogi1 has joined #openstack-cinder | 15:10 | |
| *** leeantho has joined #openstack-cinder | 15:12 | |
| *** karthik__ has joined #openstack-cinder | 15:12 | |
| *** Asaithambi has quit IRC | 15:19 | |
| hemna | morning | 15:23 |
| Swanson | mornin | 15:23 |
| jgriffith | hemna: patrickeast smcginnis can any of you give me some more insight to what we're even trying to solve with the locks in os-brick attach/detach and extend? | 15:26 |
| jgriffith | I'm having difficulty justifying their existence :) | 15:26 |
| nikeshm | https://review.openstack.org/#/c/355241 : on this new driver patch, owner of patch is showing "Infinidat Cinder CI", is it OK? | 15:27 |
| hemna | well, I haven't done a lot of testing w/o them and from what I've seen it's just safer | 15:28 |
| jgriffith | hemna: *safer* for what? | 15:28 |
| hemna | to not remove things we shouldn't be re: iscsi sessions, volume paths, etc. | 15:28 |
| hemna | it shouldn't happen either way | 15:28 |
| hemna | another thing is running some of the multipath commands to detect multipath devices is slow | 15:29 |
| smcginnis | I thought we actually ran into an issue and that's how we realized the two services were using different locking dirs when we needed some shared ones. | 15:29 |
| hemna | and running multiples of that at the same time would be bad | 15:29 |
| hemna | smcginnis, well if we got rid of the locks we wouldn't need the shared lock setting between cinder and nova | 15:30 |
| hemna | I rewrote the multipath discovery stuff a release or so ago | 15:30 |
| hemna | so it could relieve some of the concurrency issues | 15:30 |
| smcginnis | hemna: But I thought there was a real legitimate case where we needed those locks. | 15:30 |
| jgriffith | hemna: so I think I can solve the removal thing without locks (I don't really see how they solve that anyway)... and as far as multipath discovery being slow... meh | 15:30 |
| jgriffith | hemna: how slow is "slow" | 15:31 |
| hemna | but what I saw, when you have 100+ multipath volumes on the same host, running multipath takes sometimes upwards of 5 minutes | 15:31 |
| sdague | hemna: right, so the issue as we dug through it is that shared locks between cinder/nova require a *ton* of work by deployment tools to make it work, which is probably not realistic | 15:31 |
| *** raj_singh has joined #openstack-cinder | 15:31 | |
| hemna | it gets unusable after a certain number of volumes attached to a host | 15:31 |
| jgriffith | hemna: and locks fix that how? | 15:31 |
| hemna | well, it prevents you from running multiples of that :) | 15:31 |
| hemna | the new discover code I put helps prevent brick from even calling multipath though | 15:32 |
| hemna | so, it could not be an issue now | 15:32 |
| jgriffith | hemna: ok, so it's a problem with efficient use of our API's, not really a locking or consistency problem? | 15:32 |
| *** charlesr has quit IRC | 15:32 | |
| hemna | It simply hasn't been tested really | 15:33 |
| *** diogogmt has joined #openstack-cinder | 15:33 | |
| hemna | what needs to happen is some rally tests with hundreds of volumes attached and see how it goes | 15:33 |
| hemna | it *should* be ok | 15:33 |
| smcginnis | So if there's not a real legitimate failure that is protected against by locking, let's take out the locks. | 15:33 |
| *** Julien-zte has quit IRC | 15:33 | |
| smcginnis | Is there ever a case where Cinder is doing something while Nova could come in and do something conflicting and vice versa? | 15:33 |
| jgriffith | smcginnis: that's what I'm saying :) | 15:33 |
| jgriffith | smcginnis: sdague hemna and I can look at adding my 'safe-to-remove' call if we want | 15:34 |
| smcginnis | jgriffith: Yeah, you're right. :) | 15:34 |
| hemna | smcginnis, well at the brick level I don't think it matters as much | 15:34 |
| hemna | nova can try and detach while cinder is attaching and doing some actions | 15:34 |
| jgriffith | hemna: not if they use the api's correctly (ie reserve/unreserve) | 15:34 |
| jgriffith | hemna: that's why those calls exist | 15:35 |
| smcginnis | Would we ever have a case where one thing is logging out a session while another one is trying to log in? | 15:35 |
| hemna | jgriffith, yah that's what I'm thinking as well | 15:35 |
| hemna | smcginnis, yah that can happen | 15:35 |
| smcginnis | jgriffith: The issue may be backends that don't have separate iSCSI target logins per volume. | 15:35 |
| hemna | if nova is detaching the last volume from a target portal, while you are attaching a new one | 15:35 |
| hemna | brick would do a logout | 15:35 |
| jgriffith | smcginnis: ok, but again I don't know how locks solve any of this? | 15:36 |
| hemna | in that case you wouldn't even start the attachment process until after the removal is done | 15:36 |
| smcginnis | jgriffith: I think just an attach and a detach to a backend that has shared iSCSI logins. | 15:36 |
| hemna | instead of getting half way through the attach process and then get logged out | 15:36 |
| hemna | the lock would prevent that | 15:37 |
| *** kfarr has joined #openstack-cinder | 15:37 | |
| jgriffith | smcginnis: ok, so drivers that do that should have a mechanism to inform a caller that they have that scenario no? | 15:37 |
| hemna | well it's shared iscsi sessions to the same portal | 15:37 |
| jgriffith | hemna: ok, I get that.... | 15:37 |
| smcginnis | Or back to connection tracking and seeing there are other volumes using that session so don't log out of it. | 15:37 |
| jgriffith | smcginnis: +1000 | 15:38 |
| hemna | brick has no mechanism for connection tracking though | 15:38 |
| smcginnis | And probably shouldn't... | 15:38 |
| jgriffith | smcginnis: I'm more than happy to try and propose that part of the changes I have up | 15:38 |
| hemna | yah I don't think it should | 15:38 |
| *** belmoreira has quit IRC | 15:38 | |
| jgriffith | I just didn't think there'd be much hope for something like that going in after the first 8 weeks of the release | 15:38 |
| jgriffith | smcginnis: in fact, I probably have an abandoned patch somewhere that has a chunk of that done already | 15:39 |
| *** baumann has quit IRC | 15:39 | |
| smcginnis | So when does Nova handling login/logout and when does Cinder? Seems like it should always be one side. | 15:39 |
| *** laughterwym has quit IRC | 15:39 | |
| jgriffith | smcginnis: either that or Nova should always "ask" cinder if it's ok IMO | 15:39 |
| openstackgerrit | TommyLike proposed openstack/python-cinderclient: fix when restore a backup specified by name https://review.openstack.org/355532 | 15:39 |
| *** baumann has joined #openstack-cinder | 15:39 | |
| jgriffith | Ok, I gotta run for a bit. I'm happy to dig into this a bit but I'll probably need some input from hemna and smcginnis to make sure I'm covering the cases you're talking about | 15:40 |
| *** harlowja_at_home has joined #openstack-cinder | 15:40 | |
| hemna | ok | 15:40 |
| johnthetubaguy | I am getting confused about the current state, didn't we say nova doing an attach and a detach at the same time, different volumes, but same attachment, would race without that lock? | 15:40 |
| hemna | johnthetubaguy, I think it would yes | 15:41 |
| smcginnis | johnthetubaguy: Yeah | 15:41 |
| johnthetubaguy | agreed, long term, we should just ask cinder | 15:41 |
| *** haplo37__ has joined #openstack-cinder | 15:41 | |
| hemna | you'd see iscsi sessions vanish | 15:41 |
| johnthetubaguy | hemna: yeah, that makes sense | 15:41 |
| johnthetubaguy | feels like that the thing we need to keep working in newton | 15:41 |
| hemna | fwiw, FC wouldn't have this problem :P | 15:41 |
| hemna | heh | 15:41 |
| smcginnis | I agree it should always only be nova or only be Cinder. The only problem is if one is logging in while the other is logging out. | 15:41 |
| sdague | this is because iscsiadm is storing state locally that gets run over? | 15:41 |
| dansmith | sdague: a large part of iscsiadm's job is state | 15:42 |
| hemna | sdague, it's because when we detach the last iscsi volume from a target portal on a host, we do an iscsi logout | 15:42 |
| dansmith | sdague: but I think it's knowing when we should tell iscsiadm to log out after the last LUN is removed | 15:42 |
| johnthetubaguy | dansmith: +1 | 15:42 |
| sdague | hemna: ok, so what goes wrong if we don't do the logout? | 15:42 |
| hemna | dansmith, that's what it does today | 15:42 |
| dansmith | sdague: we leak connections | 15:42 |
| hemna | we'll have sessions stuck around that might cause issues later on | 15:43 |
| dansmith | sdague: i.e. we maintain a session connected to the target | 15:43 |
| hemna | yah | 15:43 |
| dansmith | something needs to know that nothing else is coming down the pipe, | 15:43 |
| smcginnis | Would we ever have enough iSCSI sessions that would cause problems really? | 15:43 |
| dansmith | either because we lock, | 15:43 |
| dansmith | or because we are the only one that could be doing a thing | 15:44 |
| dansmith | smcginnis: I think it comes down to iscsi requirements for sessions, right? | 15:44 |
| sdague | dansmith: can we leak more than one connection per host, or is this just that every host will always ahve a connection whether or not we need it? | 15:44 |
| hemna | https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/iscsi.py#L531-L532 | 15:44 |
| *** rlrossit_ has quit IRC | 15:44 | |
| dansmith | sdague: I think it's that you generally login once, separate from actually connecting to targets, and probably some backends won't let you do things until everyone logs out | 15:45 |
| hemna | if there aren't any paths left from a target portal, we do iscsi logout and flush the state | 15:45 |
| smcginnis | Just speaking for my companies storage, we could have 1 to maybe 5 tops sessions per storage array. | 15:45 |
| hemna | sdague, for multipath, you'd have multiple iscsi sessions (1 per target portal) | 15:45 |
| dansmith | especially storage stuff like this should *really* be one of those "only one entity should ever be bring up and down sessions" | 15:45 |
| smcginnis | hemna: Not always. | 15:45 |
| smcginnis | dansmith: +1 | 15:46 |
| hemna | well, you'd have a session per target_portal. maybe dell's is different. | 15:46 |
| smcginnis | hemna: We'll, multiple initiator ports on the compute host to one on the array, but that's just being pedantic so ignore me. :) | 15:47 |
| hemna | so anyway, at this point I think it's risky as hell to remove the locks without a lot of testing | 15:48 |
| smcginnis | So I'm still not clear (need to look through the code), when does Cinder manage the sessions and when does nova? | 15:48 |
| hemna | rally tests with hundreds of volumes | 15:48 |
| hemna | cinder and nova don't manage sessions | 15:49 |
| sdague | hemna: ok, but the locks aren't going to cooperate between cinder / nova | 15:49 |
| hemna | brick does only based on what it sees on the host | 15:49 |
| hemna | sdague, not unless the lock dir is the same yah | 15:49 |
| sdague | hemna: no, not even if that | 15:49 |
| hemna | the iscsi sessions are managed based upon what brick sees on the host. | 15:50 |
| hemna | what's left, etc. | 15:50 |
| dansmith | hemna: in the real world nova and cinder can't share locks | 15:50 |
| hemna | ^^ above url | 15:50 |
| *** pbandark has quit IRC | 15:50 | |
| dansmith | for permissions and selinux reasons | 15:50 |
| dansmith | shared directory aside | 15:50 |
| smcginnis | hemna: Well, brick is a library for the two projects. So when does brick get triggered to do it by Cinder and when does it get triggered to do it by nova is my question. | 15:50 |
| hemna | cinder triggers it when it does the copy volume <---> image operations and backup | 15:50 |
| sdague | so we should just assume as a design point sharing locks between projects using the filesystem is not possible | 15:50 |
| dansmith | sdague: +2 | 15:51 |
| sdague | so, given that, what's going to go wrong, and what's the mitigation | 15:51 |
| dansmith | it's also fairly counter to "shared nothing" :P | 15:51 |
| hemna | sdague, sure that's probably a safe bet | 15:51 |
| johnthetubaguy | sdague: +1 that | 15:51 |
| *** Apoorva has joined #openstack-cinder | 15:51 | |
| hemna | well, at most you'd get 1 nova attach/detach going at the same time with 1 cinder attach/detach | 15:51 |
| sdague | and, as a noob, I think I'm hearing that we could get logged out when trying to do an attach | 15:52 |
| dansmith | hemna: you can't logout/disconnect the session if the actual local block device has been opened, right? | 15:52 |
| hemna | but I think patrickeast has seen problems with that in his CI runs where we get iscsi session failures because of it. | 15:52 |
| jgriffith | maybe shared target drivers should use a cinder target as a proxy per volume :) | 15:52 |
| johnthetubaguy | hemna: but when they share a single ISCSI target for two connections its worse right? | 15:52 |
| sdague | so, could we mitigate that with a retry block around attach? | 15:52 |
| hemna | dansmith, it only calls logout if there are no more /dev/disk/by-path/* entries on the same target portal | 15:52 |
| dansmith | right, so there's no data loss problem ehre, | 15:53 |
| smcginnis | sdague: Hmm, maybe | 15:53 |
| hemna | but there is a race between looking for the last device and doing logout | 15:53 |
| dansmith | it's merely a failed boot that thinks it has attached something and then suddenly it's gone, right? | 15:53 |
| dansmith | or a leaked connecton | 15:53 |
| openstackgerrit | Jon Bernard proposed openstack/cinder: RBD: postpone snapshot removal until final volume deleted https://review.openstack.org/281550 | 15:53 |
| smcginnis | sdague: It's a fresh attach, so it's not like we'd be yanking the device away while IO is going. | 15:53 |
| dansmith | smcginnis: right, that's my point | 15:53 |
| smcginnis | dansmith: +1 | 15:54 |
| sdague | dansmith: so, what you are saying is that we can't actually corrupt anything, we'll just have the possibility for more failed attaches? | 15:55 |
| dansmith | sdague: right | 15:55 |
| sdague | ok | 15:55 |
| dansmith | sdague: or some potentially confused state | 15:55 |
| smcginnis | patrickeast: ping | 15:55 |
| dansmith | but nothing disastrous, AFAICT | 15:55 |
| dansmith | which is why I think we should document and fix properly | 15:56 |
| hemna | patrickeast, ping | 15:56 |
| smcginnis | hemna: ;) | 15:56 |
| hemna | patrickeast, he saw some failed CI runs due to the non shared lock | 15:56 |
| dansmith | I'm sure | 15:56 |
| sdague | dansmith: in the real world, yeh. It might take our gate runs a bit too unreliable with the fast attach/detach at times | 15:56 |
| smcginnis | But if we add retries around that attach... | 15:56 |
| * patrickeast yawns | 15:56 | |
| hemna | smcginnis, I'm not sure retries would help here | 15:56 |
| dansmith | sdague: yeah, we could probably retry in the test though right? | 15:57 |
| patrickeast | What's up? | 15:57 |
| hemna | because the race is in between testing for the last volume and logout | 15:57 |
| dansmith | unless we wedge state | 15:57 |
| sdague | dansmith: in all volumes tests? | 15:57 |
| hemna | we could get a volume showing up and passed on to nova between there | 15:57 |
| *** Apoorva has quit IRC | 15:57 | |
| dansmith | sdague: well, write a wrapper, but ... | 15:57 |
| *** mtanino has joined #openstack-cinder | 15:57 | |
| smcginnis | patrickeast: Did you have issues in your CI with attach and detach collisions? | 15:57 |
| dansmith | sdague: either way, some gate-specific fix instead of something that impacts the real world would be more ideal I think | 15:57 |
| hemna | patrickeast, do you have an examples of the failed CI runs when nova and cinder brick calls collided ? | 15:58 |
| patrickeast | smcginnis: hemna yea I ran into problems when cranking up tempest concurrency | 15:58 |
| sdague | dansmith: maybe, we're definitely making volume attach less reliable here, if there was a safe way to reacquire the session if we lost it in the middle of attach that would be nice | 15:58 |
| hemna | which is what I'd expect | 15:58 |
| patrickeast | I can see if the links are still alive, they are only archived for like 30 days or something | 15:59 |
| dansmith | sdague: the whole point of this is that there isn't without a lock or a single thread | 15:59 |
| dansmith | sdague: what is the thing that is causing this in the gate that isn't there now? maybe I'm missing that | 15:59 |
| * smcginnis jumps on a call and will be half paying attention | 15:59 | |
| patrickeast | But yea, reading scrollback, it's just failed attachments | 15:59 |
| dansmith | sdague: sounds like you mean something new is being added | 15:59 |
| sdague | dansmith: so if you run iscsiadm after the session logout happened, will we get a distinctive error | 16:00 |
| hemna | maybe if we added a retry into the brick connect_volume call | 16:00 |
| dansmith | sdague: I dunno, maybe.. at least on stderr | 16:00 |
| hemna | bbias | 16:01 |
| sdague | I wonder if we could treat this like keystone expired tokens | 16:01 |
| sdague | if you run a command, get a "no session" error, just force creating a new session and try that command again | 16:01 |
| dansmith | there's a bunch of detailed error codes for iscsiadm, so probably | 16:01 |
| sdague | but, I'm a noob in this space, so I don't know if that would work or be a thing | 16:01 |
| dansmith | sdague: the question is whether we have the login information at the point at which we need to re-login to a thing we're just connecting | 16:01 |
| dansmith | probably this for a situation where we've already logged out: ISCSI_ERR_NO_OBJS_FOUND | 16:02 |
| patrickeast | Yea something like that seems like it would probably be ok | 16:02 |
| * patrickeast wanders off to start getting ready for work | 16:03 | |
| *** GB21 has quit IRC | 16:05 | |
| openstackgerrit | Merged openstack/cinder: Remove unused context parameter https://review.openstack.org/352236 | 16:05 |
| openstackgerrit | Justin A Wilson proposed openstack/cinder: Added config option to enable SSL https://review.openstack.org/352958 | 16:09 |
| sdague | ok... so where do we stand? do we think making attach more robust to the logging out behind the scenes is the right path? And if so, who's got the expertise and time to do that thing before freeze? | 16:09 |
| *** dims has quit IRC | 16:10 | |
| dansmith | smcginnis: hemna: looking at iscsi.py I don't see why you couldn't make that code retry and relogin if we failed to attach because something else logged us out | 16:11 |
| smcginnis | Sorry, too distracted, but I think you're probably right dansmith. | 16:12 |
| smcginnis | We can look at doing that. | 16:12 |
| dansmith | okay | 16:12 |
| hemna | back | 16:12 |
| hemna | well the race could happen if a connect_volume call is returning and we are also doing an iscsi logout | 16:14 |
| hemna | it's pretty much too late then w/o retrying connect_volume again | 16:14 |
| dansmith | hemna: you said that the logout code wouldn't run if /dev/disk/by-id/$foo exists, right? | 16:14 |
| dansmith | hemna: so by the time connect_volume returns, you know that it's locked in place, yes? | 16:14 |
| hemna | yah, but we could test for the paths and get none, and then have a login happen before logout gets called | 16:15 |
| hemna | creating the race | 16:15 |
| hemna | nova would get a volume path that's broken at that point | 16:15 |
| sdague | hemna: how long is that window? | 16:15 |
| hemna | it's short | 16:15 |
| hemna | very short | 16:15 |
| hemna | but possible on a busy host | 16:15 |
| dansmith | shorter than the already short one | 16:16 |
| openstackgerrit | Merged openstack/cinder: [doc] Fix a non-alphabetical order bug https://review.openstack.org/341487 | 16:16 |
| openstackgerrit | Merged openstack/cinder: Remove deprecaterd mapping in manager.py https://review.openstack.org/333083 | 16:16 |
| sdague | I think we just document that as a known issue | 16:16 |
| hemna | I think this one would just be a retry | 16:16 |
| hemna | and could even be user driven | 16:16 |
| dansmith | sdague: it's really the same as today I think | 16:17 |
| *** e0ne has quit IRC | 16:17 | |
| dansmith | sdague: a retry closes the window a little, but it's still the same user experience, AFAIK | 16:17 |
| hemna | w/o the shared lock dir, today the window is between 2 concurrent attach/detach calls (1 for nova and 1 for cinder) | 16:17 |
| hemna | without any locks, that window is N | 16:17 |
| *** ducttape_ has joined #openstack-cinder | 16:18 | |
| hemna | I could put up a patch removing the locks and we could see how it goes in CI :P | 16:18 |
| hemna | crank up the concurrency in the 3prd party CI runs | 16:18 |
| sdague | dansmith: well, any mitigation would be good | 16:18 |
| hemna | also sounds like we could use a rally test for brick too | 16:19 |
| sdague | and maybe there would be a way to reorder the code to get past that some other way | 16:19 |
| dansmith | sdague: I don't see any ordering fix.. I was thinking about that.. I think because of the way iscsiadm is | 16:19 |
| *** karthik__ has quit IRC | 16:19 | |
| *** Suyi has joined #openstack-cinder | 16:22 | |
| sdague | dansmith: ok, so even if in here you did another device check before the logout, and one after (and if the device check after failed, you recreate the session?) - https://github.com/openstack/os-brick/blob/5b2030e2b27689916e73237d7d2285fe0f0a7655/os_brick/initiator/connectors/iscsi.py#L746-L753 | 16:25 |
| sdague | anyway, any ways we can narrow this window would be good, and if testing becomes too unreliable, we look into other mitigations | 16:25 |
| dansmith | sdague: the problem is you still can have some process somewhere blocked on running iscsiadm --logout, and if it runs after you, you're toast | 16:26 |
| sdague | dansmith: sure | 16:26 |
| dansmith | so my point earlier was narrow the window, but can't close it without more work | 16:26 |
| hemna | I'll put up a WIP that removes the locks and we can see how the runs go | 16:27 |
| hemna | the only problem is that the traffic is really light in terms of the number of volumes at attach/detach work | 16:27 |
| hemna | a rally test would be more suited for it | 16:28 |
| *** harlowja_at_home has quit IRC | 16:28 | |
| *** ametts_ has joined #openstack-cinder | 16:28 | |
| sdague | hemna: ok, though, that is going to potentially allow n-cpu to race with itself | 16:30 |
| *** ametts has quit IRC | 16:30 | |
| hemna | well n-cpu with c-vol | 16:30 |
| *** yangyapeng has quit IRC | 16:31 | |
| *** dkehn_ has quit IRC | 16:31 | |
| sdague | no, n-cpu with itself right, because we're in eventlet, and if we switch up greenthreads here by doing io we could be processing an attach and detach at the same time, right? | 16:31 |
| hemna | that's one case yah | 16:31 |
| *** Apoorva has joined #openstack-cinder | 16:31 | |
| *** xinli has quit IRC | 16:31 | |
| sdague | hemna: so I don't think that's a useful exercise | 16:32 |
| hemna | the real issue though is the iscsi sessions | 16:32 |
| sdague | I think narrowing the race window as much as possible for newton is the thing to do | 16:32 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Mask out passwords when tracing https://review.openstack.org/354370 | 16:33 |
| hemna | scrum...bbiab | 16:33 |
| *** bwallis has quit IRC | 16:36 | |
| *** cknight has joined #openstack-cinder | 16:36 | |
| *** daneyon_ has joined #openstack-cinder | 16:38 | |
| *** baumann_ has joined #openstack-cinder | 16:38 | |
| *** daneyon has quit IRC | 16:40 | |
| *** diablo_rojo has quit IRC | 16:41 | |
| *** baumann has quit IRC | 16:41 | |
| *** dims has joined #openstack-cinder | 16:42 | |
| _alastor_ | If anyone has a moment, I'd appreciate some eyes on an update for my driver: https://review.openstack.org/#/c/352533/ | 16:46 |
| *** dims has quit IRC | 16:47 | |
| *** dkehn has joined #openstack-cinder | 16:48 | |
| *** alonma has quit IRC | 16:51 | |
| *** alonma has joined #openstack-cinder | 16:51 | |
| *** dims has joined #openstack-cinder | 16:53 | |
| *** GB21 has joined #openstack-cinder | 16:55 | |
| *** alonma has quit IRC | 16:56 | |
| openstackgerrit | Merged openstack/cinder: Replication, hard-coding and dict.name issues in K2 https://review.openstack.org/354703 | 16:56 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/354293 | 16:58 |
| *** alonma has joined #openstack-cinder | 16:59 | |
| *** sdake has joined #openstack-cinder | 17:00 | |
| *** jungleboyj has quit IRC | 17:00 | |
| *** bwallis has joined #openstack-cinder | 17:02 | |
| *** daneyon has joined #openstack-cinder | 17:03 | |
| *** alonma has quit IRC | 17:03 | |
| *** alonma has joined #openstack-cinder | 17:06 | |
| *** alonma has quit IRC | 17:06 | |
| *** daneyon_ has quit IRC | 17:06 | |
| *** alonma has joined #openstack-cinder | 17:06 | |
| *** daneyon_ has joined #openstack-cinder | 17:07 | |
| *** harlowja has joined #openstack-cinder | 17:08 | |
| *** daneyon has quit IRC | 17:09 | |
| *** rajinir has joined #openstack-cinder | 17:12 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: WIP remove iscsi and fibre channel locks https://review.openstack.org/355573 | 17:13 |
| *** jungleboyj has joined #openstack-cinder | 17:13 | |
| openstackgerrit | Arnon Yaari proposed openstack/cinder: New cinder driver to support INFINIDAT InfiniBox https://review.openstack.org/355241 | 17:17 |
| *** yuelongguang has quit IRC | 17:21 | |
| *** krtaylor has joined #openstack-cinder | 17:22 | |
| *** daneyon has joined #openstack-cinder | 17:22 | |
| *** Lee1092 has quit IRC | 17:23 | |
| *** yuelongguang has joined #openstack-cinder | 17:23 | |
| *** johnplanow has joined #openstack-cinder | 17:24 | |
| *** daneyon_ has quit IRC | 17:26 | |
| *** bardia has joined #openstack-cinder | 17:29 | |
| *** bardia has quit IRC | 17:32 | |
| *** bardia has joined #openstack-cinder | 17:32 | |
| *** rcernin has joined #openstack-cinder | 17:37 | |
| *** kfarr has quit IRC | 17:37 | |
| *** e0ne has joined #openstack-cinder | 17:38 | |
| *** diablo_rojo has joined #openstack-cinder | 17:42 | |
| *** JoseMello has joined #openstack-cinder | 17:47 | |
| openstackgerrit | Alon Marx proposed openstack/cinder: Fix invalid services caused by enabled_backends https://review.openstack.org/353697 | 17:47 |
| *** raunak has joined #openstack-cinder | 17:48 | |
| *** xinli has joined #openstack-cinder | 17:49 | |
| *** raj_singh has left #openstack-cinder | 17:50 | |
| openstackgerrit | Matt Smith (_alastor_) proposed openstack/cinder: Datera driver 2.2 update https://review.openstack.org/352533 | 17:51 |
| openstackgerrit | xing-yang proposed openstack/cinder: WIP: Migrate consistency groups to groups https://review.openstack.org/350350 | 17:51 |
| *** GB21 has quit IRC | 17:56 | |
| *** jsheeren has joined #openstack-cinder | 18:02 | |
| *** ankur-gupta-f has joined #openstack-cinder | 18:06 | |
| ankur-gupta-f | thrawn01: https://review.openstack.org/#/c/324048/ https://review.openstack.org/#/c/318192/ fyi | 18:07 |
| *** e0ne has quit IRC | 18:15 | |
| *** e0ne has joined #openstack-cinder | 18:17 | |
| *** Apoorva_ has joined #openstack-cinder | 18:20 | |
| *** xyang1 has quit IRC | 18:22 | |
| *** Apoorva has quit IRC | 18:24 | |
| *** xyang1 has joined #openstack-cinder | 18:26 | |
| *** raj_singh has joined #openstack-cinder | 18:29 | |
| *** neophy has joined #openstack-cinder | 18:33 | |
| *** rcernin has quit IRC | 18:42 | |
| *** Apoorva_ has quit IRC | 18:46 | |
| *** karthik__ has joined #openstack-cinder | 18:46 | |
| *** Apoorva has joined #openstack-cinder | 18:47 | |
| *** jsheeren has quit IRC | 18:48 | |
| patrickeast | scottda: ping | 18:49 |
| *** haplo37__ has quit IRC | 18:50 | |
| *** e0ne has quit IRC | 18:59 | |
| scottda | patrickeast: Hi | 19:00 |
| hemna | so much pain | 19:01 |
| hemna | drivers that don't extend the BaseVD or VolumeDriver | 19:01 |
| patrickeast | scottda: hey, so i saw https://review.openstack.org/#/c/325895 merge, was that the last blocker before we can push on the tempest tests for retype/migration? | 19:01 |
| hemna | P A I N | 19:01 |
| hemna | shoot me | 19:01 |
| patrickeast | hemna: lol | 19:01 |
| patrickeast | scottda: or i guess https://review.openstack.org/#/c/330678/ first? | 19:01 |
| * patrickeast doesn't know what order things need to go in | 19:01 | |
| patrickeast | scottda: some context for why i ask, I'm trying to decide if I just wait for things upstream or if I pull the tests and stuff into my internal fork and spend time to try and get it working earlier | 19:03 |
| scottda | patrickeast: Cool, that's good news...Yeah, that ^^^ needs a rebase and then I'll ping QA to re-apply the +A they already gave... | 19:03 |
| scottda | Well, I'm rebasing now, so hopefully that ^^ patch get's in pretty quickly... | 19:04 |
| patrickeast | sweet | 19:04 |
| scottda | already reviewed and approved and all.. | 19:04 |
| *** haplo37__ has joined #openstack-cinder | 19:04 | |
| patrickeast | then https://review.openstack.org/#/c/326681/ and https://review.openstack.org/#/c/195443/61 should be good to go, right? | 19:04 |
| * hemna wonders how many drivers he's going to break today........ | 19:05 | |
| patrickeast | hemna: are you changing base classes for drivers? | 19:05 |
| scottda | patrickeast: Yes, although I'm pushing first on https://review.openstack.org/#/c/326681/ (retype with volume attached).. | 19:05 |
| * hemna hides | 19:06 | |
| patrickeast | scottda: sounds good | 19:06 |
| nikeshm | hi what is the command to check python3 compatabilty for our cinder driver files | 19:06 |
| hemna | rm -rf | 19:06 |
| scottda | patrickeast: Did gate-grenade-dsvm-cinder-multinode-nv get merged in? That'd be cool... | 19:06 |
| patrickeast | scottda: uhh i think so | 19:07 |
| nikeshm | also this cinder driver patch owner name is CI name ---https://review.openstack.org/#/c/355241 -- is it OK? | 19:07 |
| *** fifieldt has quit IRC | 19:07 | |
| patrickeast | scottda: although i dunno where the link is to check, lol | 19:07 |
| scottda | patrickeast: Yeah, sorry, it looks like it did from the merge conflict. That was less a question and more of a way-of-speaking thing... | 19:07 |
| nikeshm | some command was : tox -............... | 19:08 |
| *** asselin_ has joined #openstack-cinder | 19:08 | |
| patrickeast | nikeshm: just run tox -epy34 | 19:08 |
| nikeshm | thanks.....this cinder driver patch owner name is CI name ---https://review.openstack.org/#/c/355241 -- is it OK? | 19:09 |
| scottda | patrickeast: OK, rebase of 330678 is up. When it passes jenkins, I'll see if I can get it re-reviewed... | 19:10 |
| *** haplo37__ has quit IRC | 19:10 | |
| patrickeast | scottda: sweet | 19:10 |
| *** asselin has quit IRC | 19:10 | |
| *** kfarr has joined #openstack-cinder | 19:10 | |
| smcginnis | nikeshm: Thanks for pointing that out. | 19:10 |
| patrickeast | nikeshm: i don't think it really matters who the patch owner is | 19:10 |
| scottda | patrickeast: BTW, have you had a chance to try Gorka's manual tests for HA? They worked for me, using cleanup and job distribution. | 19:11 |
| patrickeast | scottda: not yet :( one of these days I'll get around to it | 19:11 |
| *** ametts_ has quit IRC | 19:13 | |
| nikeshm | patrickeast: had concern from this http://docs.openstack.org/infra/system-config/third_party.html#creating-a-service-account | 19:14 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: WIP Add new supported driver checks https://review.openstack.org/355608 | 19:14 |
| patrickeast | hemna: ouch | 19:15 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: WIP Add new supported driver checks https://review.openstack.org/355608 | 19:16 |
| hemna | patrickeast, yup | 19:16 |
| * hemna runs! | 19:16 | |
| *** ametts_ has joined #openstack-cinder | 19:18 | |
| smcginnis | hemna: I'd rather just set the default that everything is supported. Then if we have a non-compliant driver we can just put up a patch to have a one line change in that driver saying supported=False. | 19:18 |
| *** ametts_ has quit IRC | 19:18 | |
| patrickeast | smcginnis: +1 | 19:19 |
| *** fifieldt has joined #openstack-cinder | 19:19 | |
| hemna | heh ok | 19:19 |
| *** ametts has joined #openstack-cinder | 19:19 | |
| smcginnis | hemna: Now that you've done all that typing. :P | 19:19 |
| hemna | my hands hurt too much to update it right now....I need fewd. | 19:19 |
| smcginnis | hehe | 19:19 |
| jungleboyj | Mmmm, fewd. | 19:20 |
| smcginnis | fewd es gud | 19:20 |
| jungleboyj | I luv fewd. | 19:21 |
| scottda | Did somebody need me? Oh, just my automatic Food ping.... | 19:21 |
| *** haplo37__ has joined #openstack-cinder | 19:22 | |
| *** asselin__ has joined #openstack-cinder | 19:25 | |
| *** asselin_ has quit IRC | 19:28 | |
| *** baumann_ has quit IRC | 19:41 | |
| *** baumann has joined #openstack-cinder | 19:42 | |
| *** daneyon_ has joined #openstack-cinder | 19:55 | |
| *** daneyon has quit IRC | 19:58 | |
| *** alonma has quit IRC | 20:00 | |
| *** Apoorva has quit IRC | 20:06 | |
| *** liverpooler has quit IRC | 20:07 | |
| *** alonma has joined #openstack-cinder | 20:08 | |
| *** ankur-gupta-f has left #openstack-cinder | 20:12 | |
| *** enriquetaso has joined #openstack-cinder | 20:12 | |
| *** alonma has quit IRC | 20:13 | |
| *** neophy has quit IRC | 20:14 | |
| hemna | scottda, damn I don't have an automatic feeder..... | 20:15 |
| *** alonma has joined #openstack-cinder | 20:16 | |
| *** porrua has quit IRC | 20:16 | |
| *** Apoorva has joined #openstack-cinder | 20:17 | |
| smcginnis | hemna: goo.gl/o9dd55 | 20:18 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: WIP Add new supported driver checks https://review.openstack.org/355608 | 20:18 |
| *** Yogi1 has quit IRC | 20:19 | |
| *** enriquetaso has quit IRC | 20:19 | |
| hemna | oooh....can I fill that with burritos? | 20:20 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: WIP Add new supported driver checks https://review.openstack.org/355608 | 20:20 |
| *** alonma has quit IRC | 20:20 | |
| jungleboyj | smcginnis: Nice, I could have used one of those for our cat. | 20:20 |
| smcginnis | :) | 20:21 |
| *** karthik__ has quit IRC | 20:21 | |
| Swanson | The comments "can I fill that with burritos?" and "I could have used one of those for our cat" do not appear to refer to a common starting point. | 20:21 |
| hemna | Swanson, I'm always trying to stuff a square peg into a round hole | 20:22 |
| jungleboyj | Swanson: Yeah, I don't think hemna has/had a cat. | 20:22 |
| hemna | traumatized as a child | 20:22 |
| * jungleboyj pictures a feeder shooting burritos as hemna | 20:22 | |
| *** akerr has quit IRC | 20:23 | |
| *** cargonza has joined #openstack-cinder | 20:23 | |
| patrickeast | wait, you guys saying I can't feed a cat burritos? | 20:23 |
| *** baumann_ has joined #openstack-cinder | 20:23 | |
| jungleboyj | patrickeast: Only if you want to clean up the resulting mess. | 20:23 |
| patrickeast | lol | 20:23 |
| Swanson | My cats are 15 yo. They shoot burritos no matter what you feed them. | 20:24 |
| jungleboyj | Oy vey | 20:24 |
| Swanson | The things they did to their litter box when I went on vacation was diabolical. | 20:26 |
| *** baumann has quit IRC | 20:26 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: WIP remove iscsi and fibre channel locks https://review.openstack.org/355573 | 20:27 |
| Swanson | Easier pets to deal with -- http://www.carolina.com/arachnids/cellar-spiders-living-pack-of-12/143255.pr | 20:28 |
| *** asselin__ has quit IRC | 20:28 | |
| smcginnis | w. t. f! | 20:29 |
| *** asselin has joined #openstack-cinder | 20:29 | |
| *** xyang1 has quit IRC | 20:29 | |
| jungleboyj | I don't need to buy those. They are all over my house .... hmmm, can I just make a living selling those? | 20:29 |
| *** xyang1 has joined #openstack-cinder | 20:29 | |
| Swanson | They're the perfect gift. | 20:29 |
| smcginnis | At $37.95 for 12, you might have a good side business there. ;) | 20:29 |
| smcginnis | "Not sexed" Imagine having the job of checking and sorting the spiders. | 20:30 |
| hemna | price is a little high | 20:30 |
| hemna | might be able to find them cheaper on eBay from China | 20:30 |
| hemna | free shipping too. | 20:30 |
| *** ociuhandu has quit IRC | 20:31 | |
| smcginnis | This site is crazy! I should have known there was somewhere inline to buy a batch of pill bugs, but man! | 20:31 |
| *** sdake has quit IRC | 20:32 | |
| *** asselin_ has joined #openstack-cinder | 20:32 | |
| smcginnis | Ooh, virus kits. | 20:32 |
| jungleboyj | *smh* | 20:32 |
| *** xyang has joined #openstack-cinder | 20:32 | |
| *** yangyapeng has joined #openstack-cinder | 20:33 | |
| hemna | ooh, and I'm fresh out of e-coli | 20:34 |
| *** asselin has quit IRC | 20:35 | |
| *** alonma has joined #openstack-cinder | 20:39 | |
| * jungleboyj wonders why Swanson knew about that site. | 20:41 | |
| smcginnis | jungleboyj: I've found it's better not to ask. | 20:42 |
| *** alonma has quit IRC | 20:44 | |
| * jungleboyj looks the other direction. | 20:44 | |
| Swanson | It was in my twitter feed next to this ... https://twitter.com/JhonRules/status/764934078021836801 | 20:47 |
| *** alonma has joined #openstack-cinder | 20:47 | |
| jungleboyj | I almost lost my lunch there. Thanks Swanson. | 20:48 |
| Swanson | Oh, don't scroll down. | 20:48 |
| hemna | Lolz | 20:49 |
| jungleboyj | Oh jeez. | 20:50 |
| *** gouthamr has quit IRC | 20:51 | |
| *** alonma has quit IRC | 20:52 | |
| Swanson | jungleboyj, was that the lunch? | 20:54 |
| *** alonma has joined #openstack-cinder | 20:54 | |
| jungleboyj | Swanson: Thankfully I am good at controlling my stomach. | 20:54 |
| johnplanow | The time I've spent in openstack-cinder channel recently? It just paid off. ;) | 20:55 |
| hemna | johnplanow, it's all about the diversity. | 20:55 |
| jungleboyj | johnplanow: Always some ROI here. | 20:55 |
| johnplanow | I've learned more in the past 30 mins.. | 20:56 |
| *** sdake has joined #openstack-cinder | 20:57 | |
| *** alonma has quit IRC | 20:59 | |
| Swanson | I try to give back. | 20:59 |
| xyang | patrickeast: ping | 21:00 |
| patrickeast | xyang: yo | 21:00 |
| *** JoseMello has quit IRC | 21:00 | |
| xyang | patrickeast: thanks for submitting the CG tempest tests | 21:00 |
| xyang | patrickeast: they were not run by your CI, is that dependent on the devstack patch | 21:00 |
| patrickeast | xyang: yea, there isn't a good way to update policy.json right now | 21:01 |
| xyang | patrickeast: ok, have you tried it on your setup manually | 21:01 |
| patrickeast | xyang: yep, works fine as long as the cg api's are available | 21:02 |
| xyang | patrickeast: so we need to wait for the devstack patch to get in first? that will take a while, right | 21:02 |
| patrickeast | xyang: why? | 21:02 |
| patrickeast | xyang: need that in for CI systems to use it... but anyone can run tempest with the cinder plugin before then | 21:03 |
| *** lpetrut has joined #openstack-cinder | 21:03 | |
| *** haplo37__ has quit IRC | 21:03 | |
| *** alonma has joined #openstack-cinder | 21:03 | |
| *** julim has quit IRC | 21:03 | |
| xyang | patrickeast: ok, I don't have a problem to get it in first | 21:03 |
| patrickeast | xyang: yay :D | 21:04 |
| xyang | patrickeast: it's just that I can only do a +1 now since my name is also on it:) | 21:06 |
| patrickeast | haha | 21:06 |
| *** alonma has quit IRC | 21:08 | |
| *** sdake has quit IRC | 21:08 | |
| *** alonma has joined #openstack-cinder | 21:10 | |
| *** lpetrut has quit IRC | 21:12 | |
| *** alonma has quit IRC | 21:15 | |
| *** dustins has quit IRC | 21:15 | |
| *** sdake has joined #openstack-cinder | 21:17 | |
| *** pauloewerton has quit IRC | 21:18 | |
| *** alonma has joined #openstack-cinder | 21:18 | |
| *** haplo37__ has joined #openstack-cinder | 21:18 | |
| patrickeast | ugh release notes | 21:19 |
| *** mvk has joined #openstack-cinder | 21:19 | |
| hemna | shite | 21:20 |
| *** alonma has quit IRC | 21:22 | |
| *** xinli has quit IRC | 21:22 | |
| *** lpetrut has joined #openstack-cinder | 21:23 | |
| *** alonma has joined #openstack-cinder | 21:25 | |
| openstackgerrit | Patrick East proposed openstack/cinder: Add get_manageable_* methods to Pure drivers https://review.openstack.org/351944 | 21:25 |
| openstackgerrit | Tom Barron proposed openstack/cinder: Use constraints for all tox environments https://review.openstack.org/355646 | 21:26 |
| *** ametts has quit IRC | 21:28 | |
| *** alonma has quit IRC | 21:30 | |
| *** baumann_ has quit IRC | 21:30 | |
| *** alonma has joined #openstack-cinder | 21:32 | |
| *** diablo_rojo has quit IRC | 21:34 | |
| *** jungleboyj has quit IRC | 21:34 | |
| *** alonma has quit IRC | 21:37 | |
| *** xinli has joined #openstack-cinder | 21:38 | |
| *** sdake has quit IRC | 21:39 | |
| *** alonma has joined #openstack-cinder | 21:40 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: WIP Add new supported driver checks https://review.openstack.org/355608 | 21:42 |
| *** alonma has quit IRC | 21:44 | |
| *** alonma has joined #openstack-cinder | 21:47 | |
| *** raj_singh has left #openstack-cinder | 21:47 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Add generic volume groups https://review.openstack.org/322459 | 21:52 |
| *** alonma has quit IRC | 21:52 | |
| *** sdake has joined #openstack-cinder | 21:54 | |
| *** alonma has joined #openstack-cinder | 21:54 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Add group snapshots https://review.openstack.org/328052 | 21:55 |
| *** harlowja has quit IRC | 21:55 | |
| *** alonma has quit IRC | 21:59 | |
| *** johnplanow has quit IRC | 22:00 | |
| *** alonma has joined #openstack-cinder | 22:02 | |
| *** mtanino has quit IRC | 22:03 | |
| *** xyang has quit IRC | 22:06 | |
| *** xyang has joined #openstack-cinder | 22:07 | |
| *** alonma has quit IRC | 22:07 | |
| *** mriedem has quit IRC | 22:09 | |
| *** alonma has joined #openstack-cinder | 22:10 | |
| *** kfarr has quit IRC | 22:10 | |
| *** lpetrut has quit IRC | 22:11 | |
| jamielennox | hey cinder, i've had https://review.openstack.org/#/c/340194/ up for a while reworking how you load context objects. can i get some eyes please? | 22:13 |
| *** alonma has quit IRC | 22:14 | |
| *** cknight has quit IRC | 22:14 | |
| *** xinli has quit IRC | 22:14 | |
| *** haplo37__ has quit IRC | 22:15 | |
| *** bswartz has quit IRC | 22:15 | |
| jgriffith | jamielennox: love to help, but man that patch is kinda huge | 22:17 |
| *** jistr has quit IRC | 22:18 | |
| *** xyang has quit IRC | 22:18 | |
| jamielennox | i had to double check there i had the right patch linked before realizing the sarcasm | 22:19 |
| jgriffith | jamielennox: :) | 22:19 |
| jgriffith | jamielennox: happy Monday! | 22:19 |
| *** jistr has joined #openstack-cinder | 22:19 | |
| smcginnis | jamielennox: I like that - +23, -41 | 22:20 |
| *** sdake has quit IRC | 22:20 | |
| jgriffith | jamielennox: You may notice that any patch that has an overall reduction in LOC I tend to review more happily | 22:21 |
| jamielennox | actually looking at it that patch was a while ago and i should probably be able to get another -5 out with recent release, but we can start with that | 22:21 |
| jamielennox | jgriffith: yep, also hopefully anything that removes oslo boilerplate code | 22:21 |
| jgriffith | jamielennox: I should make that a filter... some just look for the opportunity to add the final +2/A... me, I'll just look for code reduction | 22:21 |
| *** xyang has joined #openstack-cinder | 22:21 | |
| smcginnis | Not a bad plan. | 22:22 |
| *** xyang has quit IRC | 22:22 | |
| *** xyang has joined #openstack-cinder | 22:22 | |
| *** jamespd has joined #openstack-cinder | 22:25 | |
| jamespd | If I am seeing "Deadlock detected when running 'quota_reserve'" in nova-volume/8.0.0, should I be submitting that as a bug? | 22:26 |
| jamespd | when users delete a bunch of volumes at once, cinder-volume hits the deadlocks and everything is sad. | 22:27 |
| * jamespd would love some advice. | 22:27 | |
| jgriffith | jamespd: certainly sounds like a bug to me. Would be great if you posted it with some log files if you could and detail on how to repro | 22:28 |
| *** xyang has quit IRC | 22:28 | |
| *** sdake has joined #openstack-cinder | 22:35 | |
| openstackgerrit | Abhilash Divakaran proposed openstack/cinder: Add CI_WIKI_NAME to Tegile volume driver https://review.openstack.org/353886 | 22:36 |
| jamespd | jgriffith: thanks! | 22:36 |
| jamespd | s/nova-volume/cinder-volume/, obviously. | 22:36 |
| openstackgerrit | Abhilash Divakaran proposed openstack/cinder: Add CI_WIKI_NAME to Tegile volume driver https://review.openstack.org/353886 | 22:36 |
| openstackgerrit | Abhilash Divakaran proposed openstack/cinder: Add CI_WIKI_NAME to Tegile volume driver https://review.openstack.org/353886 | 22:37 |
| *** krtaylor has quit IRC | 22:38 | |
| *** ducttape_ has quit IRC | 22:40 | |
| openstackgerrit | Matt Smith (_alastor_) proposed openstack/cinder: Datera driver 2.2 update https://review.openstack.org/352533 | 22:45 |
| scottda | smcginnis: IIRC, we're not ready to deprecate anything in the cinderclient (in favor of openstack client), so we don't want this, right? https://review.openstack.org/#/c/349602/1/cinderclient/v3/shell.py Wanted to check before -1'ing...or -2'ing.. | 22:45 |
| *** edmondsw has quit IRC | 22:51 | |
| *** bardia has quit IRC | 22:53 | |
| *** bardia has joined #openstack-cinder | 22:53 | |
| *** sdake has quit IRC | 22:57 | |
| *** mriedem has joined #openstack-cinder | 22:57 | |
| *** markvoelker has quit IRC | 23:06 | |
| *** xyang1 has quit IRC | 23:08 | |
| *** sticker has joined #openstack-cinder | 23:08 | |
| *** asselin has joined #openstack-cinder | 23:14 | |
| *** asselin_ has quit IRC | 23:15 | |
| *** asselin_ has joined #openstack-cinder | 23:15 | |
| *** asselin has quit IRC | 23:19 | |
| *** alonma has joined #openstack-cinder | 23:31 | |
| *** diogogmt has quit IRC | 23:31 | |
| *** bwallis has quit IRC | 23:33 | |
| *** alonma has quit IRC | 23:35 | |
| *** harlowja has joined #openstack-cinder | 23:36 | |
| *** alonma has joined #openstack-cinder | 23:41 | |
| *** sdague has quit IRC | 23:44 | |
| *** alonma has quit IRC | 23:45 | |
| *** alonma has joined #openstack-cinder | 23:48 | |
| *** leeantho has quit IRC | 23:52 | |
| *** alonma has quit IRC | 23:53 | |
| *** bwallis has joined #openstack-cinder | 23:55 | |
| *** asselin_ has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!