*** Suyi has quit IRC | 00:00 | |
*** mtanino has quit IRC | 00:00 | |
*** leeantho has quit IRC | 00:01 | |
*** Julien-zte has quit IRC | 00:02 | |
openstackgerrit | Merged openstack/cinder: Datera driver 2.2 update https://review.openstack.org/352533 | 00:04 |
---|---|---|
*** lprice has joined #openstack-cinder | 00:04 | |
*** bwallis has quit IRC | 00:05 | |
openstackgerrit | Merged openstack/cinder: Group specs: Fix exception name https://review.openstack.org/358829 | 00:05 |
*** cknight1 has quit IRC | 00:06 | |
*** cknight has joined #openstack-cinder | 00:07 | |
*** david-lyle has quit IRC | 00:08 | |
*** lprice has quit IRC | 00:11 | |
*** yangyapeng has quit IRC | 00:12 | |
*** chlong has quit IRC | 00:13 | |
*** gouthamr_ has joined #openstack-cinder | 00:13 | |
*** qeelee has joined #openstack-cinder | 00:14 | |
*** gouthamr has quit IRC | 00:16 | |
*** ducttape_ has quit IRC | 00:21 | |
*** sdague has joined #openstack-cinder | 00:22 | |
openstackgerrit | Merged openstack/os-brick: Fix iSCSI multipath cleanup https://review.openstack.org/231134 | 00:22 |
*** chlong has joined #openstack-cinder | 00:26 | |
*** faiz89 has quit IRC | 00:28 | |
*** laughterwym has joined #openstack-cinder | 00:30 | |
*** laughterwym has quit IRC | 00:30 | |
*** laughterwym has joined #openstack-cinder | 00:31 | |
*** rmcall has quit IRC | 00:31 | |
*** rmcall has joined #openstack-cinder | 00:33 | |
*** ducttape_ has joined #openstack-cinder | 00:35 | |
*** ducttape_ has quit IRC | 00:40 | |
*** bardia has quit IRC | 00:40 | |
*** Julien-zte has joined #openstack-cinder | 00:42 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/359508 | 00:43 |
*** raunak has quit IRC | 00:44 | |
openstackgerrit | Merged openstack/cinder: Use original volume OVO instance in create flow https://review.openstack.org/344224 | 00:48 |
openstackgerrit | Merged openstack/cinder: Use OVOs to set errors in manage volume/snapshot https://review.openstack.org/353068 | 00:48 |
*** ducttape_ has joined #openstack-cinder | 00:50 | |
*** ducttape_ has quit IRC | 00:51 | |
*** markvoelker has joined #openstack-cinder | 00:55 | |
*** alonma has joined #openstack-cinder | 00:56 | |
*** Julien-zte has quit IRC | 00:59 | |
*** alonma has quit IRC | 01:01 | |
*** tommylikehu has joined #openstack-cinder | 01:02 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/359508 | 01:04 |
*** Julien-zte has joined #openstack-cinder | 01:04 | |
*** tommylikehu has quit IRC | 01:06 | |
*** sdake has quit IRC | 01:06 | |
*** cknight has quit IRC | 01:07 | |
*** lixiaoy1 has quit IRC | 01:07 | |
*** lixiaoy1 has joined #openstack-cinder | 01:07 | |
*** cknight has joined #openstack-cinder | 01:07 | |
*** jamielennox is now known as jamielennox|away | 01:11 | |
*** jamielennox|away is now known as jamielennox | 01:11 | |
openstackgerrit | Merged openstack/cinder: TrivialFix: Remove logging import unused https://review.openstack.org/359733 | 01:13 |
*** raunak has joined #openstack-cinder | 01:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/359508 | 01:14 |
*** yangyapeng has joined #openstack-cinder | 01:18 | |
*** ebalduf has quit IRC | 01:22 | |
openstackgerrit | Dao Cong Tien proposed openstack/cinder: Stop using mox from unit/image/*.py https://review.openstack.org/355721 | 01:25 |
*** cknight1 has joined #openstack-cinder | 01:25 | |
*** cknight has quit IRC | 01:25 | |
*** Apoorva has quit IRC | 01:29 | |
*** faiz89 has joined #openstack-cinder | 01:29 | |
*** faiz89 has quit IRC | 01:34 | |
*** raunak has quit IRC | 01:35 | |
*** markvoelker has quit IRC | 01:36 | |
*** sdake has joined #openstack-cinder | 01:36 | |
openstackgerrit | Cao Xuan Hoang proposed openstack/cinder: TrivialFix: Remove cfg import unused https://review.openstack.org/360167 | 01:36 |
*** yangyape_ has joined #openstack-cinder | 01:36 | |
*** yangyapeng has quit IRC | 01:38 | |
*** sdague has quit IRC | 01:38 | |
*** Lee1092 has joined #openstack-cinder | 01:39 | |
*** sdake_ has joined #openstack-cinder | 01:39 | |
openstackgerrit | Merged openstack/os-brick: Mask out passwords when tracing https://review.openstack.org/354370 | 01:41 |
*** sdake has quit IRC | 01:42 | |
*** yangyapeng has joined #openstack-cinder | 01:47 | |
*** yangyape_ has quit IRC | 01:47 | |
*** ducttape_ has joined #openstack-cinder | 01:52 | |
*** sdake_ has quit IRC | 01:54 | |
*** ducttape_ has quit IRC | 01:57 | |
*** mtanino has joined #openstack-cinder | 01:58 | |
*** zhangguoqing has joined #openstack-cinder | 01:58 | |
*** yangyape_ has joined #openstack-cinder | 01:59 | |
openstackgerrit | Rui Chen proposed openstack/python-cinderclient: Fix NoneType error for cinderclient v1 https://review.openstack.org/359563 | 01:59 |
*** yangyapeng has quit IRC | 02:01 | |
*** xianghui has quit IRC | 02:03 | |
*** xianghui has joined #openstack-cinder | 02:03 | |
*** xianghui has quit IRC | 02:04 | |
*** sdake has joined #openstack-cinder | 02:04 | |
*** xianghui has joined #openstack-cinder | 02:04 | |
*** xianghui has quit IRC | 02:04 | |
*** gouthamr_ is now known as gouthamr | 02:05 | |
*** xianghui has joined #openstack-cinder | 02:11 | |
*** bigdogstl has joined #openstack-cinder | 02:12 | |
*** ducttape_ has joined #openstack-cinder | 02:15 | |
*** raunak has joined #openstack-cinder | 02:20 | |
*** laughterwym has quit IRC | 02:20 | |
*** laughterwym has joined #openstack-cinder | 02:21 | |
*** thiagolib has quit IRC | 02:27 | |
*** thiagolib has joined #openstack-cinder | 02:28 | |
*** serverascode has quit IRC | 02:28 | |
*** mtanino has quit IRC | 02:31 | |
*** serverascode has joined #openstack-cinder | 02:31 | |
*** yangyapeng has joined #openstack-cinder | 02:32 | |
openstackgerrit | xianming.mao proposed openstack/python-cinderclient: Update flake https://review.openstack.org/359584 | 02:34 |
*** sdake has quit IRC | 02:34 | |
*** sdake has joined #openstack-cinder | 02:35 | |
*** yangyape_ has quit IRC | 02:35 | |
*** julim has quit IRC | 02:35 | |
*** zhangguoqing has quit IRC | 02:38 | |
*** bswartz has quit IRC | 02:38 | |
openstackgerrit | lijunli proposed openstack/cinder: When only .pyc left, the extended API cannot be used. https://review.openstack.org/360186 | 02:39 |
*** sdake has quit IRC | 02:45 | |
*** alonma has joined #openstack-cinder | 02:46 | |
*** ducttape_ has quit IRC | 02:46 | |
*** sdake has joined #openstack-cinder | 02:47 | |
*** alonma has quit IRC | 02:50 | |
*** raunak has quit IRC | 02:51 | |
*** cknight has joined #openstack-cinder | 02:53 | |
*** ducttape_ has joined #openstack-cinder | 02:53 | |
*** cknight1 has quit IRC | 02:54 | |
*** cknight1 has joined #openstack-cinder | 02:59 | |
*** smile-luobin has quit IRC | 02:59 | |
*** cknight has quit IRC | 03:00 | |
*** smile-luobin has joined #openstack-cinder | 03:00 | |
*** cknight1 has quit IRC | 03:06 | |
*** cknight has joined #openstack-cinder | 03:07 | |
*** raunak has joined #openstack-cinder | 03:09 | |
*** jamielennox is now known as jamielennox|away | 03:09 | |
*** bardia has joined #openstack-cinder | 03:10 | |
*** sdake has quit IRC | 03:12 | |
*** gcb_ has joined #openstack-cinder | 03:16 | |
*** ducttape_ has quit IRC | 03:16 | |
*** alonma has joined #openstack-cinder | 03:17 | |
*** salv-orlando has joined #openstack-cinder | 03:17 | |
*** salv-orl_ has quit IRC | 03:20 | |
*** alonma has quit IRC | 03:22 | |
*** ducttape_ has joined #openstack-cinder | 03:22 | |
*** chlong has quit IRC | 03:23 | |
*** cknight has quit IRC | 03:23 | |
*** jamielennox|away is now known as jamielennox | 03:23 | |
*** ducttape_ has quit IRC | 03:26 | |
*** bigdogstl has quit IRC | 03:27 | |
*** yangyapeng has quit IRC | 03:29 | |
openstackgerrit | avnish proposed openstack/cinder: Use upper constraints for all jobs in tox.ini https://review.openstack.org/359640 | 03:30 |
*** dkehn_ has quit IRC | 03:31 | |
*** bigdogstl has joined #openstack-cinder | 03:31 | |
*** Julien-zte has quit IRC | 03:32 | |
*** rmcall has quit IRC | 03:33 | |
*** rmcall has joined #openstack-cinder | 03:33 | |
*** yangyapeng has joined #openstack-cinder | 03:35 | |
*** bigdogstl has quit IRC | 03:35 | |
*** chlong has joined #openstack-cinder | 03:35 | |
*** ManishD has joined #openstack-cinder | 03:36 | |
*** yangyapeng has quit IRC | 03:38 | |
*** chlong has quit IRC | 03:38 | |
*** yangyapeng has joined #openstack-cinder | 03:38 | |
*** chlong has joined #openstack-cinder | 03:38 | |
*** gcb_ has quit IRC | 03:39 | |
*** bigdogstl has joined #openstack-cinder | 03:40 | |
*** yangyapeng has quit IRC | 03:40 | |
*** yangyapeng has joined #openstack-cinder | 03:41 | |
*** EinstCrazy has joined #openstack-cinder | 03:41 | |
*** Julien-zte has joined #openstack-cinder | 03:41 | |
ManishD | hello Guys, please can you review my patch: https://review.openstack.org/#/c/357131/ | 03:42 |
*** raunak has quit IRC | 03:42 | |
*** dkehn_ has joined #openstack-cinder | 03:43 | |
*** zhangguoqing has joined #openstack-cinder | 03:45 | |
*** raunak has joined #openstack-cinder | 03:46 | |
*** bigdogstl has quit IRC | 03:47 | |
*** alonma has joined #openstack-cinder | 03:49 | |
*** bigdogstl has joined #openstack-cinder | 03:49 | |
*** yangyape_ has joined #openstack-cinder | 03:49 | |
*** coolsvap_ has joined #openstack-cinder | 03:50 | |
*** bigdogstl has quit IRC | 03:51 | |
*** yangyapeng has quit IRC | 03:52 | |
*** alonma has quit IRC | 03:54 | |
*** bigdogstl has joined #openstack-cinder | 03:54 | |
*** bardia has quit IRC | 03:56 | |
openstackgerrit | xing-yang proposed openstack/cinder: Add group snapshots https://review.openstack.org/328052 | 03:56 |
*** raunak has quit IRC | 03:57 | |
*** raunak has joined #openstack-cinder | 03:58 | |
openstackgerrit | xing-yang proposed openstack/cinder: Add group snapshots https://review.openstack.org/328052 | 04:00 |
openstackgerrit | LisaLi proposed openstack/cinder: Recover volume status after remove_export https://review.openstack.org/360211 | 04:03 |
*** mtanino has joined #openstack-cinder | 04:08 | |
*** raunak has quit IRC | 04:12 | |
*** gaurangt has joined #openstack-cinder | 04:12 | |
*** bswartz has joined #openstack-cinder | 04:13 | |
*** rmcall has quit IRC | 04:13 | |
openstackgerrit | lijunli proposed openstack/cinder: When only .pyc left, the extended API cannot be used. https://review.openstack.org/360186 | 04:15 |
*** alonma has joined #openstack-cinder | 04:20 | |
*** ducttape_ has joined #openstack-cinder | 04:23 | |
*** EinstCrazy has quit IRC | 04:24 | |
*** alonma has quit IRC | 04:25 | |
openstackgerrit | Merged openstack/cinder: Dell SC: Live Volume Autofailover https://review.openstack.org/350782 | 04:25 |
*** ducttape_ has quit IRC | 04:28 | |
*** raunak has joined #openstack-cinder | 04:29 | |
*** bigdogstl has quit IRC | 04:30 | |
*** gaurangt has left #openstack-cinder | 04:32 | |
*** bardia has joined #openstack-cinder | 04:33 | |
*** laughter_ has joined #openstack-cinder | 04:36 | |
*** links has joined #openstack-cinder | 04:37 | |
*** gouthamr has quit IRC | 04:39 | |
*** laughterwym has quit IRC | 04:39 | |
*** alonma has joined #openstack-cinder | 04:39 | |
*** aswadr_ has joined #openstack-cinder | 04:41 | |
*** alonma has quit IRC | 04:44 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/359508 | 04:47 |
*** ManishD has quit IRC | 04:52 | |
*** ManishD has joined #openstack-cinder | 04:52 | |
*** mtanino has quit IRC | 04:53 | |
openstackgerrit | xianming.mao proposed openstack/cinder: Drop unused logging import https://review.openstack.org/360225 | 04:54 |
*** Poornima has joined #openstack-cinder | 04:55 | |
*** shausy has joined #openstack-cinder | 04:56 | |
*** lkuchlan has joined #openstack-cinder | 04:57 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/359508 | 04:57 |
*** raunak has quit IRC | 04:59 | |
*** raunak has joined #openstack-cinder | 05:00 | |
openstackgerrit | xianming.mao proposed openstack/cinder: Drop unused logging import https://review.openstack.org/358366 | 05:02 |
*** pdeore has joined #openstack-cinder | 05:06 | |
*** scottda has quit IRC | 05:06 | |
*** sumit has joined #openstack-cinder | 05:08 | |
*** EinstCrazy has joined #openstack-cinder | 05:09 | |
*** alonma has joined #openstack-cinder | 05:11 | |
*** EinstCrazy has quit IRC | 05:11 | |
*** alonma has quit IRC | 05:15 | |
*** raunak has quit IRC | 05:17 | |
*** nkrinner_afk is now known as nkrinner | 05:22 | |
*** bardia has quit IRC | 05:22 | |
*** lixiaoy1 has quit IRC | 05:23 | |
*** akerr_ is now known as akerr_away | 05:23 | |
*** ducttape_ has joined #openstack-cinder | 05:25 | |
*** harlowja_at_home has joined #openstack-cinder | 05:25 | |
*** lixiaoy1 has joined #openstack-cinder | 05:27 | |
*** lpetrut has joined #openstack-cinder | 05:29 | |
*** ducttape_ has quit IRC | 05:29 | |
*** kaisers_ has joined #openstack-cinder | 05:32 | |
*** shausy has quit IRC | 05:33 | |
*** lkuchlan has quit IRC | 05:33 | |
*** shausy has joined #openstack-cinder | 05:33 | |
*** Poornima has quit IRC | 05:39 | |
*** laughter_ has quit IRC | 05:41 | |
*** laughterwym has joined #openstack-cinder | 05:41 | |
*** alonma has joined #openstack-cinder | 05:42 | |
*** david-lyle has joined #openstack-cinder | 05:43 | |
*** Poornima has joined #openstack-cinder | 05:44 | |
*** harlowja_at_home has quit IRC | 05:45 | |
*** alonma has quit IRC | 05:47 | |
openstackgerrit | Avishay Traeger proposed openstack/python-cinderclient: List manageable volumes and snapshots https://review.openstack.org/351275 | 05:52 |
*** pbandark has joined #openstack-cinder | 05:52 | |
openstackgerrit | xianming.mao proposed openstack/cinder-specs: Update homepage with developer documentation page https://review.openstack.org/357003 | 05:52 |
openstackgerrit | xianming.mao proposed openstack/python-cinderclient: Update flake https://review.openstack.org/359584 | 05:53 |
openstackgerrit | xianming.mao proposed openstack/cinder-specs: Update flake8 https://review.openstack.org/359555 | 05:53 |
*** lkuchlan has joined #openstack-cinder | 05:54 | |
*** Poornima has quit IRC | 05:56 | |
*** e0ne has joined #openstack-cinder | 05:57 | |
*** Poornima has joined #openstack-cinder | 05:58 | |
*** sandanar has joined #openstack-cinder | 05:58 | |
openstackgerrit | Merged openstack/cinder: Fix incorrect parameter in create_key https://review.openstack.org/358670 | 06:04 |
*** zhangguoqing has quit IRC | 06:05 | |
*** rajinir has quit IRC | 06:05 | |
*** zhangguoqing has joined #openstack-cinder | 06:05 | |
*** Poornima has quit IRC | 06:08 | |
*** david-lyle has quit IRC | 06:09 | |
*** alonma has joined #openstack-cinder | 06:14 | |
*** alonma has quit IRC | 06:18 | |
*** Poornima has joined #openstack-cinder | 06:23 | |
*** shausy has quit IRC | 06:24 | |
*** shausy has joined #openstack-cinder | 06:24 | |
*** ducttape_ has joined #openstack-cinder | 06:26 | |
*** rcernin has joined #openstack-cinder | 06:28 | |
*** ducttape_ has quit IRC | 06:30 | |
*** lpetrut has quit IRC | 06:31 | |
*** lixiaoy1 has quit IRC | 06:33 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Zanata https://review.openstack.org/357623 | 06:34 |
openstackgerrit | xianming.mao proposed openstack/cinder: Drop unused logging import https://review.openstack.org/358366 | 06:36 |
*** Poornima has quit IRC | 06:36 | |
*** Poornima has joined #openstack-cinder | 06:38 | |
*** lixiaoy1 has joined #openstack-cinder | 06:38 | |
*** lkuchlan has quit IRC | 06:41 | |
*** arecknag has joined #openstack-cinder | 06:45 | |
*** alonma has joined #openstack-cinder | 06:45 | |
*** zhangguoqing has quit IRC | 06:46 | |
*** zhangguoqing has joined #openstack-cinder | 06:47 | |
*** yangyapeng has joined #openstack-cinder | 06:48 | |
*** lpetrut has joined #openstack-cinder | 06:48 | |
*** alonma has quit IRC | 06:49 | |
*** yangyape_ has quit IRC | 06:50 | |
*** salv-orlando has quit IRC | 06:51 | |
*** yangyape_ has joined #openstack-cinder | 06:53 | |
*** yangyapeng has quit IRC | 06:53 | |
*** yangyapeng has joined #openstack-cinder | 06:55 | |
*** yangyape_ has quit IRC | 06:58 | |
*** laughterwym has quit IRC | 06:59 | |
*** laughterwym has joined #openstack-cinder | 07:01 | |
*** tesseract- has joined #openstack-cinder | 07:08 | |
nikeshm_ | DuncanT: hi | 07:14 |
DuncanT | Hi | 07:14 |
nikeshm_ | DuncanT: small fix https://review.openstack.org/#/c/359758, if you get time please look | 07:14 |
nikeshm_ | for kaminario | 07:14 |
nikeshm_ | 1 2 line change | 07:15 |
nikeshm_ | 1-2 line change | 07:15 |
nikeshm_ | drivers | 07:15 |
nikeshm_ | CI and jenkins happy | 07:15 |
nikeshm_ | xyang also gave +2 | 07:15 |
nikeshm_ | DuncanT: thanks | 07:16 |
DuncanT | nikeshm_: Done. Great commit message, makes it nice and easy to review :-) | 07:16 |
nikeshm_ | :) | 07:17 |
*** alonma has joined #openstack-cinder | 07:17 | |
*** lpetrut has quit IRC | 07:19 | |
*** alonma has quit IRC | 07:21 | |
swamireddy | DuncanT: Hi ... | 07:22 |
DuncanT | swamireddy: Hi. I've got your patch on my screen right now. Just wondering if I care about the two stype nits :-) | 07:22 |
DuncanT | *style | 07:22 |
DuncanT | swamireddy: Approved. Details like that should be covered by an automatic tool I think | 07:24 |
*** ducttape_ has joined #openstack-cinder | 07:26 | |
swamireddy | DuncanT: Thanks... | 07:26 |
swamireddy | DuncanT: please let me know, if need to fix the nits here? | 07:28 |
DuncanT | swamireddy: A cleanup patch would be nice. Doesn't need a bug or anything, just put "Cleanup of minor code style nits from review XXXXX" in the commit message | 07:29 |
*** AndyWojo has quit IRC | 07:29 | |
swamireddy | DuncanT: Got it... | 07:30 |
DuncanT | Thanks. No mad rush on it | 07:31 |
*** ducttape_ has quit IRC | 07:31 | |
*** e0ne has quit IRC | 07:32 | |
swamireddy | DuncanT: sure will take care of this... Thank you very much | 07:32 |
*** AndyWojo has joined #openstack-cinder | 07:32 | |
*** e0ne has joined #openstack-cinder | 07:33 | |
swamireddy | DuncanT: I will be submitting the patches for backup and snapshot summary also... (similar to volume summary and will take care these nits) | 07:34 |
DuncanT | swamireddy: Perfect | 07:34 |
openstackgerrit | Cao ShuFeng proposed openstack/python-cinderclient: Enhance help message of upload_to_image https://review.openstack.org/359678 | 07:35 |
*** sheel has joined #openstack-cinder | 07:37 | |
*** alonma has joined #openstack-cinder | 07:48 | |
*** alonma has quit IRC | 07:53 | |
*** salv-orl_ has joined #openstack-cinder | 07:59 | |
*** salv-orl_ has quit IRC | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** salv-orl_ has joined #openstack-cinder | 08:00 | |
*** zzzeek has joined #openstack-cinder | 08:00 | |
openstackgerrit | lijunli proposed openstack/cinder: When only .pyc left, the extended API can not be used. https://review.openstack.org/360186 | 08:05 |
*** laughterwym has quit IRC | 08:06 | |
*** laughterwym has joined #openstack-cinder | 08:09 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/cinder: [WIP] Testing latest u-c https://review.openstack.org/303766 | 08:10 |
*** alonma has joined #openstack-cinder | 08:11 | |
*** yuriy_n17 has quit IRC | 08:11 | |
*** alonma has quit IRC | 08:15 | |
*** zhangguoqing has quit IRC | 08:16 | |
*** laughterwym has quit IRC | 08:19 | |
*** pgadiya has joined #openstack-cinder | 08:23 | |
*** ducttape_ has joined #openstack-cinder | 08:27 | |
openstackgerrit | Merged openstack/cinder: Retype issue in Kaminario Cinder drivers https://review.openstack.org/359758 | 08:27 |
openstackgerrit | Michal Dulko proposed openstack/cinder: OVO request_spec in migrate/manage/retype calls https://review.openstack.org/252458 | 08:29 |
openstackgerrit | Michal Dulko proposed openstack/cinder: Switch request_spec_list in create CG to OVO https://review.openstack.org/253033 | 08:29 |
openstackgerrit | Michal Dulko proposed openstack/cinder: Convert filter_properties to OVO (create, retype) https://review.openstack.org/257305 | 08:29 |
*** laughterwym has joined #openstack-cinder | 08:30 | |
openstackgerrit | Merged openstack/cinder: Add volumes/summary API support https://review.openstack.org/335067 | 08:30 |
*** ducttape_ has quit IRC | 08:32 | |
*** jordanP has joined #openstack-cinder | 08:32 | |
*** andymaier has joined #openstack-cinder | 08:34 | |
*** laughterwym has quit IRC | 08:35 | |
*** lkuchlan has joined #openstack-cinder | 08:35 | |
*** sborkows has joined #openstack-cinder | 08:36 | |
*** Julien-zte has quit IRC | 08:41 | |
*** alonma has joined #openstack-cinder | 08:43 | |
*** aarefiev_ has joined #openstack-cinder | 08:43 | |
*** zul has joined #openstack-cinder | 08:46 | |
*** alonma has quit IRC | 08:47 | |
*** aarefiev has quit IRC | 08:47 | |
*** openstackgerrit has quit IRC | 08:48 | |
*** openstackgerrit has joined #openstack-cinder | 08:49 | |
*** aarefiev_ is now known as aarefiev | 08:50 | |
*** jordanP has quit IRC | 08:56 | |
*** jordanP has joined #openstack-cinder | 08:57 | |
*** yuriy_n17 has joined #openstack-cinder | 08:57 | |
dulek | #success multinode grenade job is testing rolling upgrades on every Cinder patch (non-voting for now)! :) | 08:58 |
openstackstatus | dulek: Added success to Success page | 08:58 |
*** lixiaoy1 has quit IRC | 09:08 | |
*** lixiaoy1 has joined #openstack-cinder | 09:09 | |
*** alonma has joined #openstack-cinder | 09:14 | |
*** salv-orlando has joined #openstack-cinder | 09:18 | |
*** e0ne has quit IRC | 09:18 | |
*** sayalilunkad has quit IRC | 09:18 | |
*** alonma has quit IRC | 09:18 | |
*** lixiaoy1 has quit IRC | 09:18 | |
*** sayalilunkad has joined #openstack-cinder | 09:20 | |
*** salv-orl_ has quit IRC | 09:20 | |
*** dkehn_ has quit IRC | 09:22 | |
*** kaisers_ has quit IRC | 09:23 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/359508 | 09:23 |
*** yuriy_n17 has quit IRC | 09:26 | |
*** Poornima has quit IRC | 09:27 | |
*** ducttape_ has joined #openstack-cinder | 09:28 | |
*** e0ne has joined #openstack-cinder | 09:31 | |
*** Poornima has joined #openstack-cinder | 09:31 | |
*** ducttape_ has quit IRC | 09:33 | |
*** zul has quit IRC | 09:33 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Deleting volume metadata keys with a single request https://review.openstack.org/328399 | 09:36 |
e0ne | dulek: good news! | 09:36 |
*** kaisers_ has joined #openstack-cinder | 09:37 | |
*** zul has joined #openstack-cinder | 09:38 | |
*** dkehn_ has joined #openstack-cinder | 09:39 | |
dulek | e0ne: I hoped Cinder would achieve assert:support-rolling-upgrades tag in Newton, but this would require a voting job running and this will take some time to make sure the job is stable. But well - it's still cool. :) | 09:40 |
*** pbandark has quit IRC | 09:41 | |
openstackgerrit | Michal Dulko proposed openstack/cinder: Pin RPC server's serializer to min obj version https://review.openstack.org/350534 | 09:42 |
*** alonma has joined #openstack-cinder | 09:45 | |
openstackgerrit | Nguyen Phuong An proposed openstack/cinder: Replace 'self' by 'cls' in classmethod https://review.openstack.org/360382 | 09:46 |
*** pbandark has joined #openstack-cinder | 09:48 | |
*** mkoderer__ has joined #openstack-cinder | 09:48 | |
*** Poornima has quit IRC | 09:50 | |
*** alonma has quit IRC | 09:50 | |
openstackgerrit | Cao ShuFeng proposed openstack/python-cinderclient: Enhance help message of upload_to_image https://review.openstack.org/359678 | 10:02 |
openstackgerrit | xiaoqin proposed openstack/cinder: Storwize: remove SCSI LUN ID during volume attaching https://review.openstack.org/360394 | 10:04 |
*** e0ne has quit IRC | 10:09 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/cinder: [WIP] Testing latest u-c https://review.openstack.org/303766 | 10:10 |
*** alonma has joined #openstack-cinder | 10:17 | |
*** lpetrut has joined #openstack-cinder | 10:17 | |
*** alonma has quit IRC | 10:21 | |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: Driver documentation cleanup https://review.openstack.org/357671 | 10:28 |
*** ducttape_ has joined #openstack-cinder | 10:29 | |
*** ducttape_ has quit IRC | 10:34 | |
*** newcomer25 has joined #openstack-cinder | 10:34 | |
openstackgerrit | lijunli proposed openstack/cinder: When only .pyc left, the extended API can not be used. https://review.openstack.org/360186 | 10:34 |
*** newcomer25 has left #openstack-cinder | 10:36 | |
flip214 | how can I tell "openstack image create" which cinder backend to use? | 10:37 |
jgriffith | flip214: same as any other time... it's just a special create | 10:42 |
jgriffith | flip214: the "openstack image create" is actually the equiv glance call I believe? | 10:43 |
flip214 | possibly, yes. | 10:44 |
jgriffith | flip214: that wasn't really a question :) | 10:44 |
jgriffith | flip214: it was a statement :) | 10:44 |
*** Digvijay has joined #openstack-cinder | 10:44 | |
flip214 | and on "nova boot --block-device source=image,..."? | 10:44 |
*** alonma has joined #openstack-cinder | 10:45 | |
flip214 | is the volume always in the same backend as the image? | 10:45 |
jgriffith | flip214: no | 10:45 |
eantyshev | Hello! Can I ask for reviews in https://review.openstack.org/276465, please? | 10:46 |
jgriffith | flip214: and typically images aren't on a Cinder backend unless you set that up | 10:46 |
*** gaurangt has joined #openstack-cinder | 10:47 | |
*** gaurangt has left #openstack-cinder | 10:48 | |
flip214 | jgriffith: yeah, that's what we want to do, so that image cloning is only a thin snapshot... | 10:49 |
flip214 | thank you very much for the quick answers, BTW | 10:49 |
*** alonma has quit IRC | 10:49 | |
*** sdague has joined #openstack-cinder | 10:51 | |
*** yangyapeng has quit IRC | 10:57 | |
flip214 | "glance image-upload" can't pass a cinder backend in, too | 10:57 |
*** vbala has joined #openstack-cinder | 10:58 | |
sdague | fyi - that cinder unit test oom is the #1 tracked gate fail right now - http://status.openstack.org/elastic-recheck/gate.html#1616561 | 10:58 |
*** alyson_ has joined #openstack-cinder | 11:03 | |
*** alonma has joined #openstack-cinder | 11:03 | |
*** akerr_away is now known as akerr_ | 11:03 | |
*** timcl has joined #openstack-cinder | 11:05 | |
*** sandanar_ has joined #openstack-cinder | 11:07 | |
*** alonma has quit IRC | 11:07 | |
*** sandanar_ has quit IRC | 11:09 | |
*** sandanar__ has joined #openstack-cinder | 11:09 | |
*** sdague has quit IRC | 11:10 | |
*** sandanar has quit IRC | 11:10 | |
*** gaurangt has joined #openstack-cinder | 11:12 | |
*** gaurangt has left #openstack-cinder | 11:16 | |
*** sdague has joined #openstack-cinder | 11:24 | |
*** sheel has quit IRC | 11:26 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: DB: Optimize update methods https://review.openstack.org/332944 | 11:27 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: DB: Optimize volume_update method https://review.openstack.org/332943 | 11:27 |
*** sdague has quit IRC | 11:31 | |
openstackgerrit | Michal Dulko proposed openstack/cinder: Pin RPC server's serializer to min obj version https://review.openstack.org/350534 | 11:31 |
*** sandanar__ has quit IRC | 11:35 | |
*** sandanar__ has joined #openstack-cinder | 11:36 | |
*** ManishD has quit IRC | 11:36 | |
*** campee has quit IRC | 11:44 | |
*** vbala_ has joined #openstack-cinder | 11:45 | |
*** vbala has quit IRC | 11:46 | |
*** dansmith has quit IRC | 11:49 | |
*** campee has joined #openstack-cinder | 11:49 | |
*** dansmith has joined #openstack-cinder | 11:49 | |
*** Digvijay has quit IRC | 11:50 | |
*** akerr_ has quit IRC | 11:54 | |
*** yuriy_n17 has joined #openstack-cinder | 11:56 | |
yuriy_n17 | dulek: Hi! Very sorry for disturbing. Please take a look at https://review.openstack.org/#/c/359070/ whenever you have free time. | 11:59 |
*** ducttape_ has joined #openstack-cinder | 12:11 | |
*** gouthamr has joined #openstack-cinder | 12:11 | |
dulek | yuriy_n17: Oh, I've looked at this one and I'm not sure what to do about it. There's clearly something strange in these tests as geguileo pointed out. | 12:14 |
dulek | yuriy_n17: Can we get driver maintainer to look at the issue? | 12:14 |
geguileo | I spent over half an hour trying to figure out what was going on with that test | 12:15 |
*** sandanar_ has joined #openstack-cinder | 12:15 | |
*** zul has quit IRC | 12:15 | |
geguileo | Then I gave up since it wasn't my patch :-( | 12:15 |
*** salv-orlando has quit IRC | 12:15 | |
*** alonma has joined #openstack-cinder | 12:17 | |
*** mpjetta has quit IRC | 12:18 | |
*** tpsilva has joined #openstack-cinder | 12:18 | |
*** mpjetta has joined #openstack-cinder | 12:18 | |
*** sandanar__ has quit IRC | 12:18 | |
*** diablo_rojo_ has quit IRC | 12:19 | |
*** rhefner has quit IRC | 12:19 | |
*** akerr has joined #openstack-cinder | 12:20 | |
*** diablo_rojo_ has joined #openstack-cinder | 12:20 | |
*** mfisch has quit IRC | 12:21 | |
*** sage_ has joined #openstack-cinder | 12:21 | |
*** sage has quit IRC | 12:21 | |
*** sandanar_ has quit IRC | 12:21 | |
*** bradjones has quit IRC | 12:21 | |
*** alonma has quit IRC | 12:21 | |
*** briancurtin has quit IRC | 12:23 | |
*** vern has quit IRC | 12:23 | |
*** vern has joined #openstack-cinder | 12:24 | |
*** thurloat has quit IRC | 12:25 | |
*** mfisch has joined #openstack-cinder | 12:25 | |
*** mfisch has quit IRC | 12:25 | |
*** mfisch has joined #openstack-cinder | 12:25 | |
*** thurloat has joined #openstack-cinder | 12:25 | |
*** briancurtin has joined #openstack-cinder | 12:26 | |
*** bradjones has joined #openstack-cinder | 12:27 | |
*** bradjones has quit IRC | 12:27 | |
*** bradjones has joined #openstack-cinder | 12:27 | |
*** pdeore has quit IRC | 12:27 | |
*** mtreinish has quit IRC | 12:27 | |
yuriy_n17 | dulek: I see, that question to IBM... | 12:27 |
*** uberjay has quit IRC | 12:28 | |
*** ducttape_ has quit IRC | 12:28 | |
dulek | Hey, jungleboyj, help us! :) | 12:29 |
* dulek knows he isn't here yet. | 12:30 | |
*** mtreinish has joined #openstack-cinder | 12:30 | |
*** uberjay has joined #openstack-cinder | 12:30 | |
*** edmondsw has joined #openstack-cinder | 12:34 | |
*** yangyapeng has joined #openstack-cinder | 12:34 | |
*** JoseMello has joined #openstack-cinder | 12:35 | |
*** scottda has joined #openstack-cinder | 12:36 | |
*** sbezverk_ has joined #openstack-cinder | 12:37 | |
openstackgerrit | Merged openstack/python-cinderclient: Enhance help message of upload_to_image https://review.openstack.org/359678 | 12:38 |
*** sbezverk has quit IRC | 12:39 | |
*** cdelatte has joined #openstack-cinder | 12:42 | |
*** pauloewerton has joined #openstack-cinder | 12:43 | |
*** xyang1 has joined #openstack-cinder | 12:45 | |
*** xyang has joined #openstack-cinder | 12:46 | |
*** cdelatte has quit IRC | 12:46 | |
*** frakt_ has quit IRC | 12:46 | |
*** laughterwym has joined #openstack-cinder | 12:47 | |
*** markvoelker has joined #openstack-cinder | 12:48 | |
*** frakt has joined #openstack-cinder | 12:48 | |
*** eharney has quit IRC | 12:53 | |
*** mgagne_ is now known as mgagne | 12:54 | |
*** lkuchlan has quit IRC | 12:56 | |
*** gaurangt has joined #openstack-cinder | 12:56 | |
*** salv-orlando has joined #openstack-cinder | 12:58 | |
*** zhangguoqing has joined #openstack-cinder | 12:59 | |
*** rlrossit has joined #openstack-cinder | 13:00 | |
*** lkuchlan has joined #openstack-cinder | 13:00 | |
*** zhangguoqing has quit IRC | 13:03 | |
*** alee has quit IRC | 13:07 | |
*** porrua has joined #openstack-cinder | 13:08 | |
*** julim_ has joined #openstack-cinder | 13:09 | |
*** julim_ has quit IRC | 13:15 | |
*** julim_ has joined #openstack-cinder | 13:17 | |
openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor5: add extend method to NFS driver https://review.openstack.org/297880 | 13:18 |
*** jordanP has quit IRC | 13:20 | |
*** ducttape_ has joined #openstack-cinder | 13:22 | |
*** links has quit IRC | 13:22 | |
*** rooneym has joined #openstack-cinder | 13:23 | |
openstackgerrit | Alexey Yelistratov proposed openstack/cinder: Support new osprofiler API https://review.openstack.org/315676 | 13:24 |
*** eantyshev has left #openstack-cinder | 13:24 | |
rooneym | Could I get a little attention on this tiny patch of mine contained to the NetApp drivers? https://review.openstack.org/#/c/356635/ | 13:25 |
*** dustins has joined #openstack-cinder | 13:26 | |
*** xyang has quit IRC | 13:27 | |
openstackgerrit | timgclark proposed openstack/cinder: Pure - warn when deleting destroyed snapshot https://review.openstack.org/359930 | 13:27 |
*** xyang has joined #openstack-cinder | 13:29 | |
openstackgerrit | xing-yang proposed openstack/cinder: Add generic volume groups https://review.openstack.org/322459 | 13:30 |
*** zul has joined #openstack-cinder | 13:31 | |
*** ehrhardt has joined #openstack-cinder | 13:31 | |
*** eharney has joined #openstack-cinder | 13:31 | |
*** ducttape_ has quit IRC | 13:33 | |
*** salv-orlando has quit IRC | 13:35 | |
*** ehrhardt has quit IRC | 13:39 | |
*** ehrhardt has joined #openstack-cinder | 13:39 | |
*** ehrhardt has quit IRC | 13:41 | |
*** sdague has joined #openstack-cinder | 13:41 | |
*** ehrhardt has joined #openstack-cinder | 13:41 | |
*** laughterwym has quit IRC | 13:42 | |
*** laughterwym has joined #openstack-cinder | 13:43 | |
*** Lee1092 has quit IRC | 13:44 | |
openstackgerrit | Vivek Dhayaal proposed openstack/cinder: Support ZeroMQ messaging in cinder multibackend https://review.openstack.org/277113 | 13:45 |
*** eharney_ has joined #openstack-cinder | 13:46 | |
*** eharney has quit IRC | 13:47 | |
*** laughter_ has joined #openstack-cinder | 13:48 | |
smcginnis | scottda: ping | 13:48 |
scottda | smcginnis: hola | 13:49 |
smcginnis | scottda: Hey, were you able to spend any more time tracking down that oom failure? | 13:49 |
scottda | smcginnis: Yes, I updated the bug report. 6/7 runs the failure was during VolumeMigrationTestCase, but that's not necessarily where the problem lies.... | 13:50 |
scottda | smcginnis: It does look like issues are in tests/unit/test_volume.py...which sucks since that file is huge. | 13:51 |
*** laughterwym has quit IRC | 13:51 | |
scottda | smcginnis: I looked at recent commits and tried to skip some of those tests, but that didn't make the problem go away. | 13:51 |
smcginnis | scottda: Well, at least that narrows it down I guess. | 13:51 |
*** Yogi1 has joined #openstack-cinder | 13:51 | |
eharney_ | there are numerous issues in that file :) | 13:51 |
smcginnis | :) | 13:51 |
*** eharney_ is now known as eharney | 13:51 | |
smcginnis | eharney: Good thing you moves at least some of it out. | 13:51 |
*** alee has joined #openstack-cinder | 13:52 | |
*** kaisers_ has quit IRC | 13:52 | |
scottda | smcginnis: Next, I was going to go back in time and see if I can do a binary search to reproduce in an attempt to narrow down to the problematic commit , assuming it is a single commit. | 13:52 |
smcginnis | *moved | 13:53 |
geguileo | scottda: It's usually easier to see if testr can find the conflicting tests automatically | 13:53 |
scottda | smcginnis: But I probably won't have time again until tomorrow. Or maybe I'd better wait until next week, and review for FF instead. | 13:53 |
scottda | geguileo: How? | 13:54 |
geguileo | scottda: I don't remember from the top of my head | 13:54 |
geguileo | scottda: Give me a minute to see if I can find my notes or a link to a post or something | 13:54 |
*** jgregor has joined #openstack-cinder | 13:55 | |
* geguileo does it once every 2 or 3 months so doesn't remember | 13:55 | |
geguileo | scottda: https://rbtcollins.wordpress.com/2015/12/02/diagnosing-flaky-tests/ | 13:55 |
scottda | geguileo: OK. I looked at various things during the runs like 'dstat --top-oom' and various proc files in an attempt to catch the problematic tests... | 13:55 |
geguileo | scottda: I have my own notes, but they are soooo brief, that it's probably best you have a look there | 13:56 |
geguileo | scottda: I don't remember if it was up to date, but I'll certainly point you in the right direction | 13:56 |
scottda | geguileo: Thnx. I'll have a look. | 13:56 |
*** cknight has joined #openstack-cinder | 13:56 | |
*** ebalduf has joined #openstack-cinder | 13:57 | |
*** ociuhandu has joined #openstack-cinder | 13:57 | |
*** yangyape_ has joined #openstack-cinder | 13:58 | |
eharney | scottda: did the log say how much memory was used when the process was killed? (i think it should) | 13:59 |
*** e0ne has joined #openstack-cinder | 14:00 | |
scottda | eharney: Yes, on my 2GB VM: | 14:01 |
scottda | Aug 24 17:18:13 dev2gb kernel: [20319.182011] Killed process 26775 (python) total-vm:747216kB, anon-rss:632412kB, file-rss:2556kB | 14:01 |
*** yangyapeng has quit IRC | 14:02 | |
*** wxy__ has quit IRC | 14:02 | |
*** wxy__ has joined #openstack-cinder | 14:03 | |
*** yangyape_ has quit IRC | 14:03 | |
*** yangyapeng has joined #openstack-cinder | 14:04 | |
*** zul has quit IRC | 14:04 | |
*** qeelee has quit IRC | 14:05 | |
smcginnis | Would be nice if ostestr had memory_profiler integration or something like that. Some debug mode to track memory usage per test. | 14:05 |
*** zul has joined #openstack-cinder | 14:06 | |
*** Julien-zte has joined #openstack-cinder | 14:07 | |
*** laughter_ has quit IRC | 14:08 | |
*** laughterwym has joined #openstack-cinder | 14:08 | |
eharney | i was thinking of just setting a low ulimit and running tox to see if it fails | 14:08 |
akerr | smcginnis: hah, we've been working on trying to do something like that as well. We keep having to increase the size of the nodes that run the unittests due to segfaults and wanted to know if there were any obvious offenders | 14:08 |
dulek | smcginnis: Spec tracking etherpad is almost empty now - are there any reviews I should focus on now? | 14:09 |
dulek | smcginnis: I'm going through my queue, but I know we're close to N-3 now. | 14:09 |
smcginnis | akerr: Might be a good area to spend some time investigating. Probably find a few things to fix. | 14:09 |
smcginnis | dulek: Good question. | 14:09 |
*** laughter_ has joined #openstack-cinder | 14:09 | |
*** lkuchlan has quit IRC | 14:09 | |
dulek | smcginnis: I can join you with solving UT memory issues, but looks like you've got it covered. ;) | 14:10 |
smcginnis | dulek: I think our major focuses we identified in Austin are mostly good. Or at least as good as they'll get for O. | 14:10 |
openstackgerrit | xing-yang proposed openstack/cinder: Add group snapshots https://review.openstack.org/328052 | 14:10 |
*** laughte__ has joined #openstack-cinder | 14:10 | |
*** laughte__ has quit IRC | 14:10 | |
smcginnis | dulek: Some more eyes on jgriffith's patch wouldn't hurt: https://review.openstack.org/#/c/327408/ | 14:11 |
*** laughte__ has joined #openstack-cinder | 14:11 | |
openstackgerrit | xing-yang proposed openstack/cinder: Add group snapshots https://review.openstack.org/328052 | 14:11 |
smcginnis | Wrapping up python-cinderclient and python-brick-cinderclient-ext patches would be good since that's the next deadline. | 14:11 |
dulek | smcginnis: What's happening with group stuff xyang is working on? Ocata? | 14:12 |
*** ducttape_ has joined #openstack-cinder | 14:12 | |
*** laught___ has joined #openstack-cinder | 14:12 | |
smcginnis | dulek: That would be another good one. | 14:12 |
*** laught___ has quit IRC | 14:12 | |
smcginnis | dulek: I think there's just the generic groups patch outstanding yet. | 14:12 |
*** laught___ has joined #openstack-cinder | 14:13 | |
smcginnis | https://review.openstack.org/#/c/322459/ | 14:13 |
*** esker has joined #openstack-cinder | 14:13 | |
*** laughterwym has quit IRC | 14:13 | |
dulek | smcginnis: Oh, cool! | 14:14 |
scottda | Take some Ritalin before starting to review that one... | 14:14 |
*** laughterwym has joined #openstack-cinder | 14:14 | |
smcginnis | Hah! :) | 14:14 |
*** laughter_ has quit IRC | 14:14 | |
* dulek googles "ritalin". | 14:15 | |
smcginnis | :D | 14:15 |
*** laughte__ has quit IRC | 14:15 | |
dulek | Oh, I'll just use cola to brew my coffee. It should have similar effect. ;) | 14:16 |
smcginnis | There you go! :) | 14:16 |
*** mtanino has joined #openstack-cinder | 14:16 | |
*** laughter_ has joined #openstack-cinder | 14:16 | |
akerr | smcginnis: I think merooney actually did profile all the tests and didn't find any outliers, but I'll double check with him once he gets in | 14:16 |
*** laughterwym has quit IRC | 14:16 | |
smcginnis | akerr: Oh cool. Would be good to hear any findings. | 14:17 |
*** pgadiya has quit IRC | 14:17 | |
*** laught___ has quit IRC | 14:18 | |
*** shausy has quit IRC | 14:21 | |
*** sborkows has quit IRC | 14:22 | |
*** lkuchlan has joined #openstack-cinder | 14:24 | |
*** esker_ has joined #openstack-cinder | 14:25 | |
*** e0ne has quit IRC | 14:29 | |
*** esker has quit IRC | 14:32 | |
*** rajinir has joined #openstack-cinder | 14:32 | |
*** lixiaoy1 has joined #openstack-cinder | 14:34 | |
*** e0ne has joined #openstack-cinder | 14:34 | |
gaurangt | hemna: ping | 14:35 |
*** esker has joined #openstack-cinder | 14:35 | |
*** esker has quit IRC | 14:36 | |
xyang1 | scottda: :) | 14:37 |
*** ociuhandu has quit IRC | 14:38 | |
*** esker has joined #openstack-cinder | 14:38 | |
*** esker has quit IRC | 14:38 | |
*** alonma has joined #openstack-cinder | 14:39 | |
*** enriquetaso has joined #openstack-cinder | 14:39 | |
*** esker_ has quit IRC | 14:40 | |
jgriffith | the entering/exiting Kamaniro driver might very well make my head explode | 14:40 |
*** esker has joined #openstack-cinder | 14:41 | |
*** sdake has joined #openstack-cinder | 14:42 | |
smcginnis | jgriffith: I haven't looked in to that, but why isn't that getting suppressed like the other logs? | 14:42 |
*** zul has quit IRC | 14:42 | |
jgriffith | smcginnis: That's going to be what I play with on the plane this morning I think :) | 14:43 |
jgriffith | and maybe the oom thing unless somebody found it | 14:43 |
smcginnis | jgriffith: Not yet. | 14:43 |
*** wN has quit IRC | 14:43 | |
*** alonma has quit IRC | 14:43 | |
jgriffith | I think it's dell SC's fault :) | 14:43 |
smcginnis | jgriffith: scottda narrowed it down to test_volumes but we're still not sure what in there is the root cause. | 14:44 |
smcginnis | jgriffith: Hah! | 14:44 |
jgriffith | smcginnis: oh? | 14:44 |
jgriffith | hmmm | 14:44 |
*** e0ne has quit IRC | 14:45 | |
jgriffith | smcginnis: "rm -rf cinder/volume/tests/unit/test_volume.py; git rm -rf cinder/volume/tests/unit/test_volume.py; git commit -m "Because it sucks"; git review | 14:45 |
smcginnis | ;) | 14:45 |
jgriffith | smcginnis: it's even kind of a one-liner for you to use :) | 14:45 |
smcginnis | jgriffith: Probably it's uncovering an actual issue in the code somewhere though. Unless we're doing something stupid in a fake or something. | 14:46 |
openstackgerrit | xing-yang proposed openstack/cinder: Add group snapshots https://review.openstack.org/328052 | 14:46 |
openstackgerrit | LisaLi proposed openstack/cinder: Recover volume status after remove_export https://review.openstack.org/360211 | 14:46 |
lixiaoy1 | jgriffith: Hey, may I take you some time to discuss your comments about my patches? | 14:47 |
jgriffith | smcginnis: scottda odd though, the only thing added to test_volume in that time frame is this one: https://github.com/openstack/cinder/commit/f5634ea3c12e037959d5561f4363c8ede7724de6#diff-748a8d2544303f66f74c67983c0fce9a | 14:47 |
jgriffith | lixiaoy1: for sure | 14:47 |
*** timcl has quit IRC | 14:47 | |
jgriffith | lixiaoy1: we never seem to be able to connect here the past few days :) | 14:48 |
lixiaoy1 | jgriffith: yes. seems today you are earlier. | 14:48 |
lixiaoy1 | jgriffith: first it is about the patch https://review.openstack.org/#/c/319078/ , retype encrypted volume | 14:48 |
*** openstackgerrit has quit IRC | 14:48 | |
*** lprice has joined #openstack-cinder | 14:48 | |
jgriffith | smcginnis: scottda I don't have a setup handy but can try and deploy one... maybe just try a local revert of that to start if you have a repro of it | 14:48 |
scottda | jgriffith: Yeah. And I posted in the bug that oom_killer kicks in during test_volume. I don' think that's conclusive that the issue is there, just strong evidence. | 14:49 |
scottda | jgriffith: And my setup is a 2GB VM, btw | 14:49 |
*** timcl has joined #openstack-cinder | 14:49 | |
lixiaoy1 | jgriffith: you mentioned about your new attach flow. do you have concerns? | 14:49 |
scottda | jgriffith: With devstack running | 14:49 |
scottda | Anyway, I gotta run. I'll work on the oom issue later today... | 14:49 |
*** openstackgerrit has joined #openstack-cinder | 14:49 | |
jgriffith | lixiaoy1: some... but the specifics around that aren't worth going in to | 14:50 |
jgriffith | lixiaoy1: I have problems with how encryption works though | 14:51 |
lixiaoy1 | jgriffith: what are the problems? | 14:51 |
jgriffith | lixiaoy1: and I was (am) concerned with adding the additional if detection in random places during the attach flow | 14:51 |
jgriffith | lixiaoy1: ummm... it sucks | 14:51 |
jgriffith | lixiaoy1: I think we need to come up with a way to make it more passive and pluggable | 14:52 |
*** esker has quit IRC | 14:52 | |
jgriffith | lixiaoy1: currently it's sprinkled all around here and there introducing various code path checks and changes | 14:53 |
jgriffith | lixiaoy1: which in my experience results in a brittle architecture going forward | 14:53 |
*** david-lyle has joined #openstack-cinder | 14:53 | |
jgriffith | lixiaoy1: I also have issues with it in terms of the resource usage, performance hit that's incurred when using and the fact that anybody that does compression, dedupe etc is kinda screwed | 14:54 |
lixiaoy1 | jgriffith: it uses linux kernel dmcrypt to encrypt/decrypt, so after we attach the encrypted volume to host, that is encrypted device. the data read from it is encrypted. so if we want to read unencrypted volume, we need to attach encryptors. | 14:54 |
jgriffith | lixiaoy1: but none of that has anything to do with your patch, or probably with what you're asking :) | 14:54 |
jgriffith | lixiaoy1: yes | 14:54 |
lixiaoy1 | jgriffith: I understand your concerns. it is sprinkled all round | 14:55 |
jgriffith | lixiaoy1: that's really my biggest issue | 14:55 |
jgriffith | lixiaoy1: but I'm certainly not saying your patch shouldn't merge because of that | 14:55 |
jgriffith | lixiaoy1: note that I just commented, I didn't down vote | 14:56 |
lixiaoy1 | jgriffith: that's also where some bugs are caused. some places which need to attach encryptor don't | 14:56 |
jgriffith | lixiaoy1: because forward progress on something that exists is good... but it would be great if we were initerested in optimizing it in the future | 14:56 |
jgriffith | lixiaoy1: EXACTLY!!! YES, thank you! You get it!!! | 14:57 |
lixiaoy1 | jgriffith: yeah, I saw your idea about not down voting | 14:57 |
lixiaoy1 | jgriffith: let me investigate more in future release about the encryption | 14:58 |
jgriffith | lixiaoy1: that's fine... I'll take a closer look at that patch today as well and give you a definitive vote on it | 14:59 |
jgriffith | rather than just a comment | 14:59 |
lixiaoy1 | jgriffith: so could you kindly help to continue reviewing this patch? | 14:59 |
jgriffith | lixiaoy1: :) | 14:59 |
lixiaoy1 | jgriffith: thank you | 14:59 |
jgriffith | lixiaoy1: You're welcome | 14:59 |
*** david-lyle has quit IRC | 14:59 | |
*** markstur has joined #openstack-cinder | 14:59 | |
*** JoseMello has quit IRC | 15:00 | |
lixiaoy1 | jgriffith: ok, let's go to next two patches: ok, let's go to next two patches: https://review.openstack.org/#/c/268609/ and https://review.openstack.org/#/c/268608/ , there are ovo about attach_volume and detach_volume | 15:00 |
jgriffith | yes, I figured I'd be hearing about these sooner or later | 15:01 |
*** markstur has left #openstack-cinder | 15:01 | |
*** zul has joined #openstack-cinder | 15:01 | |
openstackgerrit | xing-yang proposed openstack/python-cinderclient: Add support for group snapshots https://review.openstack.org/329770 | 15:02 |
lixiaoy1 | jgriffith: about whether need to version and objectify *everything | 15:02 |
*** Suyi_ has joined #openstack-cinder | 15:02 | |
*** alonma has joined #openstack-cinder | 15:04 | |
*** yangyape_ has joined #openstack-cinder | 15:04 | |
*** chris_morrell has joined #openstack-cinder | 15:04 | |
jgriffith | lixiaoy1: yeah? | 15:05 |
lixiaoy1 | jgriffith: I thought you were looking at the two patches :) | 15:05 |
*** yangyapeng has quit IRC | 15:05 | |
jgriffith | lixiaoy1: I still stand by that, I've failed to see what this is buying us yet, and until we get even one resource completely *done* I don't see any value or need to move on to internal "things" | 15:05 |
jgriffith | lixiaoy1: haha... sorry | 15:06 |
jgriffith | lixiaoy1: I thought you were typing something :) | 15:06 |
jgriffith | lixiaoy1: Turns out we're both just staring at each other in awkward silence :) | 15:06 |
lixiaoy1 | jgriffith: yes :) | 15:06 |
lixiaoy1 | jgriffith: 1. Decrease the times to access db. For example, we need to refresh volume object when we use db to update it. | 15:07 |
lixiaoy1 | 2. Decrease the complexity for future development. As if both db and volume functions are called, devs need to be very carefully about when needs to refresh, and which object needs to refresh. | 15:07 |
lixiaoy1 | 3. Access the resource through unified object interfaces. Let object handle the interactions with db. | 15:07 |
lixiaoy1 | jgriffith: I think these are benefit we do things through object | 15:07 |
jgriffith | lixiaoy1: ok... how come? | 15:08 |
*** alonma has quit IRC | 15:08 | |
lixiaoy1 | jgriffith:for example, if we update volume in db, and then we need to refresh the volume object to keep it consistent with db date | 15:08 |
lixiaoy1 | jgriffith: let me give you the code, wait a moment | 15:09 |
jgriffith | lixiaoy1: let's use the volume_attachment object for the discussion, because that's the one I'm questioning | 15:11 |
*** zul has quit IRC | 15:11 | |
*** wN has joined #openstack-cinder | 15:11 | |
*** wN has quit IRC | 15:11 | |
*** wN has joined #openstack-cinder | 15:11 | |
lixiaoy1 | jgriffith: ol | 15:11 |
lixiaoy1 | ok | 15:12 |
*** salv-orlando has joined #openstack-cinder | 15:12 | |
*** pbandark has quit IRC | 15:12 | |
*** ociuhandu has joined #openstack-cinder | 15:12 | |
lixiaoy1 | jgriffith: https://review.openstack.org/#/c/268608/12/cinder/volume/manager.py line 973 | 15:14 |
lixiaoy1 | jgriffith: line 937 at right panel. if we update attachement through db operations, and then for volume object, we need to refresh it | 15:16 |
*** lkuchlan has quit IRC | 15:16 | |
*** alonma has joined #openstack-cinder | 15:16 | |
lixiaoy1 | jgriffith: also if we update volume_admin_metadata through db, and then for volume object, we also need to refresh this data, or else the value in volume object is not consitent with data in db | 15:17 |
jgriffith | lixiaoy1: which file? | 15:17 |
*** nkrinner is now known as nkrinner_afk | 15:17 | |
*** salv-orl_ has joined #openstack-cinder | 15:18 | |
lixiaoy1 | jgriffith: https://review.openstack.org/#/c/268608/12/cinder/volume/manager.py | 15:18 |
jgriffith | lixiaoy1: so how often do you think we should encounter those cases? And why shouldn't we actually be explicit rather than implicit and fetch/update when we KNOW that we should? | 15:18 |
jgriffith | lixiaoy1: how about this as a proposal.... | 15:20 |
lixiaoy1 | jgriffith: if we use both db operation and object together ,it is probably that some data are not consistent. we need to refresh object. | 15:20 |
jgriffith | lixiaoy1: geguileo dulek smcginnis we don't continue doing the internal resources until we're completely finished with the xternal resources like "volume" and we've erradicated the use of dict access completely? | 15:20 |
*** salv-orlando has quit IRC | 15:20 | |
jgriffith | In other words we finish at least one of the conversions completely 100% through before we start another one? | 15:21 |
*** alonma has quit IRC | 15:21 | |
*** links has joined #openstack-cinder | 15:21 | |
jgriffith | and if it ends up like many Cinder things where we never finish ... at least we didn't create another bunch of half done changes | 15:21 |
jgriffith | interestingly it would've been easier to start with something like these and going the other way now that I think about it :) | 15:22 |
openstackgerrit | Kaitlin Farr proposed openstack/cinder: Replace key manager with Castellan https://review.openstack.org/280492 | 15:22 |
*** sdague has quit IRC | 15:22 | |
jgriffith | lixiaoy1: my problem is that the object conversion so far brings me little value, it adds significantly MORE code, introduces some complexity | 15:22 |
jgriffith | lixiaoy1: the only real advantage at this point is well-defined states, but I'd argue there are much simpler ways to do that | 15:23 |
jgriffith | lixiaoy1: just so you understand, my problem isn't the direction or the future plans for it etc | 15:24 |
lixiaoy1 | jgriffith: maybe I didn't describe it clearly. :( at least it can decrease the times to access db | 15:24 |
jgriffith | lixiaoy1: my problem is that we have a tendency to go down these paths and end up being half in/ half out on this sort of thing | 15:24 |
jgriffith | forever | 15:24 |
jgriffith | lixiaoy1: I don't think I believe that's true | 15:24 |
dulek | jgriffith: I hope Ocata will bring stabilization when we'll not be working on a lot of new stuff. | 15:25 |
jgriffith | You're just moving the call to the db... wrapping the wrapped db call in another wrapper | 15:25 |
lixiaoy1 | jgriffith: https://review.openstack.org/#/c/268608/19/cinder/objects/volume_attachment.py | 15:25 |
jgriffith | dulek: I would love to have that be the case | 15:25 |
lixiaoy1 | jgriffith: from here it may be clearer. | 15:25 |
jgriffith | looking | 15:25 |
jgriffith | lixiaoy1: no... sorry, I don't see at all how that makes it more "efficient" | 15:26 |
*** zul has joined #openstack-cinder | 15:26 | |
lixiaoy1 | jgriffith: please look at finish_attach method | 15:26 |
jgriffith | lixiaoy1: maybe I'm just not consdering something correctly? | 15:27 |
jgriffith | Yes, I'm looking there | 15:27 |
lixiaoy1 | jgriffith: if we don't do it through object method, we need to call db.volume_attach at first, and then call volume.refresh to reload volume | 15:27 |
jgriffith | lixiaoy1: we still send the exact same ol "volume_attached" call to the db like we did before | 15:27 |
lixiaoy1 | jgriffith: but we returned updated_values for this object, and update it | 15:28 |
jgriffith | lixiaoy1: sure... but so? | 15:28 |
jgriffith | lixiaoy1: the object code just calls it for us | 15:28 |
lixiaoy1 | jgriffith: so that we don't need to call volume.refresh to reload data | 15:28 |
*** jungleboyj has joined #openstack-cinder | 15:28 | |
jgriffith | lixiaoy1: so all we did was introduce an additional layer/wrapper | 15:28 |
jgriffith | lixiaoy1: one more level of indirection | 15:28 |
jgriffith | lixiaoy1: but we didn't actually eliminate any work | 15:29 |
lixiaoy1 | jgriffith: with this method, only one time to access db | 15:29 |
lixiaoy1 | jgriffith: without this wrapper, needs two times to access db | 15:29 |
jgriffith | lixiaoy1: I don't think that's true | 15:29 |
jgriffith | lixiaoy1: if you measure/count from entry to return... the count would be the same | 15:30 |
openstackgerrit | Matan Sabag proposed openstack/cinder: ScaleIO over subscription support https://review.openstack.org/356547 | 15:30 |
*** sdague has joined #openstack-cinder | 15:30 | |
jgriffith | lixiaoy1: just becasue you moved it out of the method and have it embedded in the object the call is still being made. It's just being made from somewhere else no? | 15:30 |
lixiaoy1 | jgriffith: not same :) | 15:30 |
*** akerr has quit IRC | 15:32 | |
lixiaoy1 | jgriffith: ok, if we let db.volume_attach returns updated_values of volume, and updates it for volume object, the counts are same. | 15:32 |
*** sandanar has joined #openstack-cinder | 15:32 | |
lixiaoy1 | jgriffith: may be we can start from beginning? one step by step. It is late in my time, I am a little dizzy | 15:33 |
lixiaoy1 | jgriffith: at first, look into this solution: if we keep the original db.volume_attach method https://review.openstack.org/#/c/268608/19/cinder/db/sqlalchemy/api.py (left) | 15:35 |
jgriffith | lixiaoy1: ok | 15:35 |
jgriffith | lixiaoy1: sorry.. plane wifi is spotty | 15:35 |
*** esker has joined #openstack-cinder | 15:36 | |
lixiaoy1 | jgriffith: in this function it returns volume db object. | 15:37 |
*** gouthamr is now known as gouthamr|afk | 15:38 | |
jgriffith | lixiaoy1: ok | 15:39 |
lixiaoy1 | jgriffith: let me go through it by myself at first. wait a moment please | 15:39 |
jgriffith | sure | 15:39 |
*** kaisers_ has joined #openstack-cinder | 15:40 | |
*** alonma has joined #openstack-cinder | 15:41 | |
*** xinli has joined #openstack-cinder | 15:42 | |
*** kaisers_ has quit IRC | 15:44 | |
*** leeantho has joined #openstack-cinder | 15:45 | |
*** alonma has quit IRC | 15:46 | |
*** andymaier has quit IRC | 15:46 | |
*** diablo_rojo has joined #openstack-cinder | 15:48 | |
*** esker has quit IRC | 15:49 | |
*** esker has joined #openstack-cinder | 15:50 | |
jgriffith | lixiaoy1: honestly I pretty much defer to geguileo and dulek on those efforts, if they're happy with them then they should merge them IMO | 15:50 |
jgriffith | lixiaoy1: I did vote with a -1, but I full admit that geguileo and dulek are much more well versed in the object efforts and advantages than I am | 15:51 |
geguileo | jgriffith: What patches are we talking about? | 15:51 |
jgriffith | lixiaoy1: I'm just a grumpy old man yelling at kids to get off my lawn :) | 15:51 |
geguileo | lol | 15:51 |
smcginnis | jbernard1, eharney: Didn't we have something in the works to do with ceph and snapshots? | 15:52 |
jgriffith | not really... but trying to lighten things up a bit | 15:52 |
lixiaoy1 | jgriffith: geguileo: https://review.openstack.org/#/c/268608/19 | 15:52 |
smcginnis | jbernard1, eharney: It's supported, right? | 15:52 |
*** jungleboyj has quit IRC | 15:53 | |
smcginnis | Found it: https://review.openstack.org/#/c/281550/ | 15:53 |
geguileo | jgriffith: Oh yes, we should port to versioned objects all ORM instances we are sending over RPC as dictionaries | 15:53 |
geguileo | jgriffith: But I agree with you we shouldn't move EVERYTHING to versioned objects | 15:54 |
geguileo | If it's not being passed in an RPC message it shouldn't have a versioned object | 15:54 |
lixiaoy1 | jgriffith: maybe we can look into detach patch, as it is clearer. https://review.openstack.org/#/c/268609/28/cinder/volume/manager.py Line 1074, at the original codes we detach volume, and then gets volume from db | 15:55 |
*** esker has quit IRC | 15:56 | |
lixiaoy1 | jgriffith: but with object method, we no need to refresh volume object | 15:56 |
*** esker has joined #openstack-cinder | 15:57 | |
lixiaoy1 | geguileo: if we intersect ovo objects and db object, we need to keep carefully when it needs to refresh ovo object when should not | 15:58 |
geguileo | lixiaoy1: That's why we should be using DB objects | 15:58 |
geguileo | lixiaoy1: 2 of my patches fixing that just got merged | 15:58 |
geguileo | https://review.openstack.org/#/c/353068/ | 15:59 |
lixiaoy1 | lixiaoy1: which two patches? | 15:59 |
geguileo | https://review.openstack.org/#/c/344224/ | 15:59 |
geguileo | Those 2 | 15:59 |
geguileo | Because we were updating the DB without updating the OVO instances in memory | 15:59 |
*** links has quit IRC | 16:00 | |
*** guitarza1 is now known as guitarzan | 16:02 | |
*** aleksey1 has joined #openstack-cinder | 16:03 | |
*** aleksey1 is now known as alekseyruban | 16:03 | |
lixiaoy1 | geguileo: so you mean we'd better use DB objects internal, just use volume object during rpc call | 16:03 |
lixiaoy1 | geguileo: after manager gets ovo object, we transfer it to DB objects, and use it inside? | 16:04 |
*** esker has quit IRC | 16:04 | |
geguileo | lixiaoy1: No, no | 16:04 |
geguileo | lixiaoy1: We should use OVOs when we have them | 16:04 |
geguileo | lixiaoy1: And not use DB calls | 16:04 |
geguileo | lixiaoy1: What I'm saying is that we don't have to move every ORM class to an OVO class | 16:04 |
lixiaoy1 | geguileo: that's also what I think. | 16:04 |
geguileo | lixiaoy1: Only those that go over RPC | 16:05 |
geguileo | lixiaoy1: In my HA A/A work I have created the workers table with Worker ORM class | 16:05 |
geguileo | lixiaoy1: But since I won't be passing that over RPC there is no OVO counterpart | 16:05 |
geguileo | and there shouldn't be one | 16:05 |
lixiaoy1 | geguileo: but if we don't move ORM to ovo. we need to pay more attention about when needs to refresh ovo object after db operations | 16:05 |
geguileo | lixiaoy1: No | 16:05 |
lixiaoy1 | geguileo: why | 16:06 |
geguileo | lixiaoy1: Because if we don't move ORM to OVO it's because it's not linked to an OVO | 16:06 |
geguileo | lixiaoy1: And we only work with ORM instances and dictionaries | 16:06 |
*** zul has quit IRC | 16:07 | |
lixiaoy1 | geguileo: yes, your Worker DB class no needs to pass over RPC. But for volume objects, such objects need to pass over RPC | 16:07 |
geguileo | lixiaoy1: What are we discussing then? | 16:07 |
lixiaoy1 | geguileo: jgriffith has concerns about my two patch attach_volume and detach_volume, | 16:08 |
geguileo | lixiaoy1: I know, and I explained why I'm ok with them | 16:08 |
geguileo | lixiaoy1: So, what are we discussing? | 16:08 |
*** diablo_rojo has quit IRC | 16:09 | |
*** diablo_rojo_ is now known as diablo_rojo | 16:09 | |
lixiaoy1 | geguileo: are you ok with the patches? or are you ok with John's comments that we no need to create volume method finish_attach to do things | 16:09 |
geguileo | lixiaoy1: At least one of those patches has a +2 from me and I haven't removed it | 16:10 |
geguileo | lixiaoy1: So I'm ok with the patch | 16:10 |
lixiaoy1 | jgriffith: I see. But John give -1, and I am discussing with him why I think the changes are reasonable | 16:11 |
lixiaoy1 | sorry, last words to you geguileo | 16:11 |
*** xinli has quit IRC | 16:13 | |
*** xinli has joined #openstack-cinder | 16:13 | |
*** arecknag has quit IRC | 16:15 | |
*** timcl has quit IRC | 16:19 | |
*** chris_morrell has quit IRC | 16:20 | |
*** pdeore has joined #openstack-cinder | 16:20 | |
*** lixiaoy1 has quit IRC | 16:21 | |
*** lixiaoy1 has joined #openstack-cinder | 16:22 | |
*** sdague has quit IRC | 16:23 | |
karthikp_ | eharney: Hi | 16:23 |
*** raunak has joined #openstack-cinder | 16:24 | |
*** zul has joined #openstack-cinder | 16:25 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Fix cmd execution stderr, stdout unicode errors https://review.openstack.org/341085 | 16:34 |
*** porrua has quit IRC | 16:34 | |
*** laughter_ has quit IRC | 16:35 | |
*** baumann has joined #openstack-cinder | 16:35 | |
*** e0ne has joined #openstack-cinder | 16:39 | |
karthikp_ | Hi All, I have an change which increases the size of database column... but i see that alter column length is banned operation unless i put it into a exception | 16:39 |
karthikp_ | Is this fine or frowned upon | 16:39 |
*** Apoorva has joined #openstack-cinder | 16:40 | |
*** Apoorva has quit IRC | 16:40 | |
*** baumann_ has joined #openstack-cinder | 16:40 | |
*** abalfour has joined #openstack-cinder | 16:41 | |
*** Apoorva has joined #openstack-cinder | 16:42 | |
*** e0ne has quit IRC | 16:43 | |
*** baumann has quit IRC | 16:43 | |
*** xyang has quit IRC | 16:44 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: 3PAR use OSLO versioned Object for volume https://review.openstack.org/339147 | 16:45 |
*** rcernin has quit IRC | 16:45 | |
*** xyang has joined #openstack-cinder | 16:46 | |
*** timcl has joined #openstack-cinder | 16:46 | |
*** gouthamr|afk is now known as gouthamr | 16:46 | |
abalfour | I have a (probably dumb) question about Gerrit and the CI systems... | 16:46 |
*** alonma has joined #openstack-cinder | 16:46 | |
abalfour | If someone stucks a "run-VendorX CI" in a review, and nothing happens, how would one follow up and figure out if the request made it out, if the Vendor CI dropped the ball, etc? | 16:47 |
abalfour | sigh. s/stucks/stuck/ | 16:49 |
*** david-lyle has joined #openstack-cinder | 16:50 | |
alekseyruban | Hi everybody. Can anybody take a look at my patch sets please? https://review.openstack.org/#/c/356142/6 https://review.openstack.org/#/c/358474/3 | 16:51 |
*** alonma has quit IRC | 16:51 | |
*** Suyi_ has quit IRC | 16:52 | |
*** tesseract- has quit IRC | 16:56 | |
*** _ducttape_ has joined #openstack-cinder | 16:57 | |
*** ducttape_ has quit IRC | 17:01 | |
*** zul has quit IRC | 17:04 | |
*** pdeore has quit IRC | 17:05 | |
*** porrua has joined #openstack-cinder | 17:05 | |
*** jgregor has quit IRC | 17:06 | |
*** e0ne has joined #openstack-cinder | 17:07 | |
erlon | eharney: ping | 17:09 |
openstackgerrit | Anthony Lee proposed openstack/cinder: Disabling online volume copy in HPE 3PAR drivers https://review.openstack.org/348060 | 17:09 |
*** ebalduf has quit IRC | 17:12 | |
*** dfisher has joined #openstack-cinder | 17:16 | |
*** Suyi_ has joined #openstack-cinder | 17:17 | |
*** baumann_ has quit IRC | 17:17 | |
*** lpetrut has quit IRC | 17:19 | |
*** bwallis has joined #openstack-cinder | 17:19 | |
*** xinli has quit IRC | 17:21 | |
*** zul has joined #openstack-cinder | 17:24 | |
openstackgerrit | Merged openstack/os-brick: Add connector for GPFS volumes https://review.openstack.org/354576 | 17:25 |
*** _ducttape_ has quit IRC | 17:25 | |
*** gaurangt has left #openstack-cinder | 17:26 | |
*** kaisers_ has joined #openstack-cinder | 17:29 | |
eharney | erlon: hi | 17:31 |
erlon | eharney: hey Eric | 17:31 |
*** xinli has joined #openstack-cinder | 17:32 | |
*** zul has quit IRC | 17:32 | |
erlon | eharney: so, I have reach a point that have solved the underlying problems behind the NFS snapshots/attachment | 17:34 |
eharney | erlon: ok. which problems are those? | 17:34 |
*** kaisers_ has quit IRC | 17:34 | |
erlon | eharney: there is a bug indeed in libvirt, that does not allow the attachment of a volume with external snapshot if apparmor is enabled | 17:35 |
erlon | eharney: https://bugzilla.redhat.com/show_bug.cgi?id=1361592 | 17:35 |
openstack | bugzilla.redhat.com bug 1361592 in libvirt "image backing file cannot be accessed when adding device to running domain due to incomplete apparmor profile" [Unspecified,New] - Assigned to libvirt-maint | 17:35 |
erlon | eharney: someone has already hit it | 17:35 |
eharney | erlon: that sounds like misconfiguration of apparmor profiles to me | 17:36 |
erlon | eharney: no is not, libvirt adds the files to the profile 'on the fly' | 17:36 |
erlon | eharney: so, for example, if you attach a volume, it will add the volume path to the profile | 17:37 |
erlon | eharney: that why, attaching volumes without snapshot works | 17:37 |
erlon | eharney: but, if the volume has snapshots, libvirt does not add the backing files to the profiles, only the top most files | 17:38 |
erlon | eharney: and then QEMU can't open the backing files | 17:38 |
erlon | eharney: I did the following tests: | 17:38 |
eharney | ok, makes sense after reading https://libvirt.org/drvqemu.html#securitysvirtaa | 17:39 |
erlon | 1 - tried to attach a snapshot to the instance, and then looked at the kernel audit logs, there you can see that QEMU tried to make access to the backing files and were blocked | 17:39 |
erlon | 2 - looped over, the profile file in this same operation, and I could see that libvirt add the snapshots file, and right after (the operation failed) it removes the file | 17:41 |
eharney | ok | 17:42 |
erlon | eharney: so, do you think its ok to implement the feature know this limitation? | 17:43 |
*** bardia has joined #openstack-cinder | 17:43 | |
smcginnis | erlon: It would need to be very well documented. | 17:43 |
eharney | erlon: yes, because that isn't going to be fixed properly without an update to ubuntu's libvirt package, and we can document how to make it work until that happens, and it works fine on other distros | 17:44 |
erlon | eharney: we could implement it with the limitation and it would only work with apparmor disable | 17:44 |
eharney | holding up the feature because apparmor policies need an update is not really sensible, we just need to document it properly | 17:44 |
erlon | eharney: ok then, Ill keep the work I started in Cinder and Nova | 17:45 |
erlon | eharney: my idea now is to send all backing chain to Nova, so it can build an XML file and send it to libvirt: http://paste.openstack.org/show/556064/ | 17:46 |
openstackgerrit | Merged openstack/cinder: Fix password masking result https://review.openstack.org/359988 | 17:47 |
erlon | eharney: later on, when they they fixed, they can get the backing files from the XML | 17:47 |
*** eharney_ has joined #openstack-cinder | 17:47 | |
eharney_ | sorry, dropped off... my laptop is not currently very stable | 17:47 |
*** Lee1092 has joined #openstack-cinder | 17:47 | |
erlon | eharney: no problem, got the last message? | 17:48 |
*** sdague has joined #openstack-cinder | 17:48 | |
*** baumann has joined #openstack-cinder | 17:48 | |
ntpttr___ | hi, is there a reason that commands like backup-restore will only take an ID and not a name, but for volume operations a volume name works? | 17:48 |
erlon | eharney: later on, when they they fixed, they can get the backing files from the XML | 17:48 |
eharney_ | no, i missed it | 17:49 |
erlon | smcginnis: +1, yes, there are several tricks to make it work the way it is today | 17:49 |
eharney_ | and eavesdrop takes a few minutes to catch up | 17:49 |
*** eharney has quit IRC | 17:49 | |
*** eharney_ is now known as eharney | 17:50 | |
*** jgregor has joined #openstack-cinder | 17:50 | |
*** alonma has joined #openstack-cinder | 17:50 | |
erlon | eharney: if you want just say where you were dropped and I paste it | 17:50 |
eharney | i didn't see anything after i typed about "holding up the feature" | 17:51 |
*** ducttape_ has joined #openstack-cinder | 17:51 | |
erlon | eharney: ok then, Ill keep the work I started in Cinder and Nova | 17:51 |
erlon | eharney: my idea now is to send all backing chain to Nova, so it can build an XML file and send it to libvirt: http://paste.openstack.org/show/556064/ | 17:52 |
erlon | eharney: later on, when they they fixed, they can get the backing files from the XML | 17:52 |
eharney | erlon: i'm not sure that will help, do you know how that is going to translate to libvirt writing a new apparmor profile at the right time? | 17:53 |
*** sandanar has quit IRC | 17:53 | |
*** rcernin has joined #openstack-cinder | 17:53 | |
*** alonma has quit IRC | 17:54 | |
erlon | eharney: no, but its somehow retrieved from the XML sent from Nova, because it works with a volume without snapshots | 17:54 |
erlon | eharney: the libvirt expected format is the one I sent in the link | 17:55 |
eharney | erlon: isn't that because libvirt writes a profile for the base volume file? | 17:55 |
erlon | eharney: no, the current NFS Cinder code only sends the base file | 17:56 |
erlon | eharney: so Nova uses it | 17:56 |
eharney | erlon: right, and libvirt can update apparmor for that because it knows that filename | 17:56 |
*** akerr has joined #openstack-cinder | 17:57 | |
erlon | eharney: the first thing I tried was to send the snapshot | 17:57 |
erlon | eharney: yes | 17:57 |
eharney | erlon: i think trying to fix apparmor by sending more information to Nova's API is probably the wrong place to address it | 17:57 |
*** akerr_ has joined #openstack-cinder | 17:58 | |
erlon | eharney: I don't think so, if you are adding a disk to libvirt, and the disk has snapshots, you should tell it | 17:59 |
erlon | eharney: the way libvirt accepts that is using the <backingStore> tags | 17:59 |
eharney | erlon: i disagree, it's a MAC system, the whole point is that applications don't have to do that, you configure it on the system correctly. If anything, libvirt can do it (which it apparently does), but I don't think Nova/Cinder needs to | 17:59 |
*** david-lyle has quit IRC | 18:00 | |
*** alonma has joined #openstack-cinder | 18:00 | |
erlon | eharney: the other way was to tell only the snapshot file, and let libvirt findout about the backing chain | 18:00 |
eharney | erlon: that's what's supposed to happen | 18:01 |
erlon | eharney: MAC? | 18:01 |
openstackgerrit | xing-yang proposed openstack/python-cinderclient: Add generic volume groups https://review.openstack.org/322627 | 18:01 |
eharney | erlon: apparmor is mandatory access control | 18:01 |
*** akerr has quit IRC | 18:02 | |
*** sdake has quit IRC | 18:03 | |
*** david-lyle has joined #openstack-cinder | 18:04 | |
erlon | eharney: ok, if I send the XML with backingStore tags its not guaranteed that they will fix libvirt using that | 18:04 |
*** sdake has joined #openstack-cinder | 18:04 | |
*** alonma has quit IRC | 18:05 | |
eharney | erlon: which distro version are you on? | 18:05 |
erlon | ubuntu 16.04 | 18:05 |
erlon | eharney: ^ | 18:07 |
eharney | ok | 18:07 |
*** ociuhandu has quit IRC | 18:09 | |
*** david-lyle has quit IRC | 18:11 | |
*** david-lyle has joined #openstack-cinder | 18:12 | |
eharney | erlon: it seems like we could have devstack add the right path to /etc/apparmor.d/libvirt/TEMPLATE for the NFS mount paths for Nova and Cinder | 18:13 |
*** lpetrut has joined #openstack-cinder | 18:13 | |
*** zul has joined #openstack-cinder | 18:14 | |
erlon | eharney: hmmm, that would be nice, so we don't have to disable apparmor | 18:14 |
*** david-lyle_ has joined #openstack-cinder | 18:15 | |
*** julim_ has quit IRC | 18:15 | |
erlon | eharney: I mean, the admin trying to use | 18:15 |
*** david-lyle_ has quit IRC | 18:15 | |
bswartz | smcginnis: ping | 18:15 |
smcginnis | bswartz: Hey | 18:15 |
erlon | eharney: that will be very useful to configure the testing jobs | 18:15 |
* smcginnis has spotty wifi so may drop out from time to time | 18:15 | |
*** diablo_rojo_ has joined #openstack-cinder | 18:16 | |
openstackgerrit | Merged openstack/cinder: Fix mysql binary comparison https://review.openstack.org/355837 | 18:17 |
*** alonma has joined #openstack-cinder | 18:21 | |
*** ManishD has joined #openstack-cinder | 18:21 | |
*** aswadr_ has quit IRC | 18:21 | |
*** rlrossit has quit IRC | 18:22 | |
* hemna refrains from wifi comment.........almost. | 18:23 | |
*** lpetrut has quit IRC | 18:24 | |
*** e0ne has quit IRC | 18:24 | |
*** alonma has quit IRC | 18:25 | |
smcginnis | hemna: I'm not at a three letter company. ;) | 18:25 |
*** timcl has quit IRC | 18:25 | |
*** rlrossit_ has joined #openstack-cinder | 18:26 | |
*** alonma has joined #openstack-cinder | 18:31 | |
*** zul has quit IRC | 18:34 | |
*** alonma has quit IRC | 18:35 | |
*** jgregor has quit IRC | 18:36 | |
*** xyang has quit IRC | 18:36 | |
*** salv-orl_ has quit IRC | 18:37 | |
*** timcl has joined #openstack-cinder | 18:40 | |
*** marcusvrn_ has joined #openstack-cinder | 18:41 | |
*** lkuchlan has joined #openstack-cinder | 18:42 | |
*** kaisers_ has joined #openstack-cinder | 18:43 | |
*** baumann has quit IRC | 18:43 | |
*** baumann has joined #openstack-cinder | 18:44 | |
*** jgregor has joined #openstack-cinder | 18:48 | |
*** kfarr has joined #openstack-cinder | 18:49 | |
*** xyang has joined #openstack-cinder | 18:50 | |
*** salv-orlando has joined #openstack-cinder | 18:51 | |
*** krotscheck has left #openstack-cinder | 18:51 | |
*** alonma has joined #openstack-cinder | 18:51 | |
hemna | :P | 18:53 |
*** diablo_rojo_ has quit IRC | 18:53 | |
*** akerr_ is now known as akerr_away | 18:54 | |
*** alonma has quit IRC | 18:56 | |
*** sdague has quit IRC | 18:58 | |
*** akerr_away has quit IRC | 18:59 | |
*** akerr has joined #openstack-cinder | 19:00 | |
*** ccesario has joined #openstack-cinder | 19:03 | |
*** ManishD has quit IRC | 19:03 | |
*** xyang has quit IRC | 19:07 | |
*** xyang has joined #openstack-cinder | 19:07 | |
*** diablo_rojo_ has joined #openstack-cinder | 19:08 | |
*** david-lyle has quit IRC | 19:10 | |
*** zul has joined #openstack-cinder | 19:11 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/359508 | 19:12 |
*** raunak has quit IRC | 19:18 | |
*** vbala_ has quit IRC | 19:19 | |
*** Apoorva has quit IRC | 19:20 | |
*** e0ne has joined #openstack-cinder | 19:21 | |
*** salv-orlando has quit IRC | 19:21 | |
*** e0ne has quit IRC | 19:23 | |
Swanson | Gerrit is nice and breaky today. | 19:25 |
*** timcl has quit IRC | 19:25 | |
*** sdague has joined #openstack-cinder | 19:26 | |
*** xyang has quit IRC | 19:27 | |
*** xyang has joined #openstack-cinder | 19:28 | |
*** timcl has joined #openstack-cinder | 19:32 | |
*** bwallis has quit IRC | 19:34 | |
openstackgerrit | Karthik Prabhu Vinod proposed openstack/cinder: Fixes the length of resource field in database for quota tables https://review.openstack.org/355214 | 19:35 |
*** esker has joined #openstack-cinder | 19:39 | |
*** sdague has quit IRC | 19:39 | |
*** sdague has joined #openstack-cinder | 19:39 | |
*** baumann_ has joined #openstack-cinder | 19:39 | |
*** zul has quit IRC | 19:41 | |
*** alekseyruban has quit IRC | 19:41 | |
*** baumann has quit IRC | 19:43 | |
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is restarting to implement some performance tuning adjustments, and should return to working order momentarily. | 19:45 | |
*** lkuchlan has quit IRC | 19:46 | |
*** lkuchlan has joined #openstack-cinder | 19:48 | |
*** dfisher has left #openstack-cinder | 19:48 | |
*** raunak has joined #openstack-cinder | 19:54 | |
smcginnis | "performance tuning adjustments" :D | 19:54 |
*** zul has joined #openstack-cinder | 19:54 | |
*** Apoorva has joined #openstack-cinder | 19:56 | |
openstackgerrit | Merged openstack/cinder: Add support for force backup for Nimble Storage https://review.openstack.org/349086 | 19:57 |
xyang | :) | 20:00 |
xyang | @smcginnis: let's see how much it will speed things up | 20:01 |
*** sdake has quit IRC | 20:03 | |
*** bardia_ has joined #openstack-cinder | 20:03 | |
*** sdake has joined #openstack-cinder | 20:04 | |
*** bardia__ has joined #openstack-cinder | 20:04 | |
*** bardia has quit IRC | 20:05 | |
rooneym | If I could get another +2 for this driver contained 9-line defect patch I'd be super appreciative :) https://review.openstack.org/#/c/356635/ | 20:05 |
jgriffith | rooneym: done... | 20:07 |
jgriffith | rooneym: curious, have you guys ever considered consolidating all of those structures? | 20:07 |
*** esker has quit IRC | 20:07 | |
smcginnis | +1 :) | 20:07 |
*** bardia_ has quit IRC | 20:08 | |
*** ducttape_ has quit IRC | 20:11 | |
rooneym | jgriffith: a good point, I'll write a story for someone to do so haha | 20:11 |
*** abalfour has left #openstack-cinder | 20:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/359508 | 20:13 |
*** ducttape_ has joined #openstack-cinder | 20:14 | |
*** alee has quit IRC | 20:18 | |
*** timcl has quit IRC | 20:19 | |
*** Yogi1 has quit IRC | 20:21 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Multipath device keeps old size when extending volume https://review.openstack.org/353325 | 20:21 |
*** sdake has quit IRC | 20:29 | |
*** sdake has joined #openstack-cinder | 20:35 | |
openstackgerrit | xing-yang proposed openstack/python-cinderclient: Add support for group snapshots https://review.openstack.org/329770 | 20:36 |
*** lkuchlan has quit IRC | 20:38 | |
*** JoseMello has joined #openstack-cinder | 20:38 | |
*** zul has quit IRC | 20:38 | |
*** baumann_ has quit IRC | 20:39 | |
*** bardia__ has quit IRC | 20:41 | |
*** ehrhardt has left #openstack-cinder | 20:43 | |
*** akerr has quit IRC | 20:44 | |
*** akerr has joined #openstack-cinder | 20:45 | |
*** diablo_rojo_ has quit IRC | 20:45 | |
*** salv-orlando has joined #openstack-cinder | 20:46 | |
*** xyang has quit IRC | 20:47 | |
*** eharney has quit IRC | 20:49 | |
porrua | [ | 20:49 |
porrua | [ | 20:49 |
*** akerr has quit IRC | 20:52 | |
*** xyang has joined #openstack-cinder | 20:52 | |
*** alonma has joined #openstack-cinder | 20:52 | |
*** akerr has joined #openstack-cinder | 20:53 | |
*** Lee1092 has quit IRC | 20:54 | |
*** kfarr has quit IRC | 20:54 | |
*** akerr has quit IRC | 20:54 | |
*** eharney has joined #openstack-cinder | 20:57 | |
*** alonma has quit IRC | 20:57 | |
*** rlrossit_ has quit IRC | 20:57 | |
hemna | ] | 21:00 |
hemna | ] | 21:00 |
hemna | we can't have open ended discussions in here...... | 21:00 |
smcginnis | hemna: Oh man, I was so resisting closing the brackets. :D | 21:02 |
hemna | I tried...but failed to resist | 21:03 |
*** enriquetaso has quit IRC | 21:03 | |
smcginnis | hehe | 21:03 |
*** sdake_ has joined #openstack-cinder | 21:05 | |
*** sdake has quit IRC | 21:08 | |
*** alonma has joined #openstack-cinder | 21:13 | |
*** salv-orl_ has joined #openstack-cinder | 21:17 | |
openstackgerrit | Merged openstack/cinder: NetApp: Report multiattach as enabled https://review.openstack.org/356635 | 21:17 |
*** alonma has quit IRC | 21:17 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/359508 | 21:18 |
*** sdague has quit IRC | 21:18 | |
*** salv-orlando has quit IRC | 21:19 | |
*** sdake_ has quit IRC | 21:20 | |
*** jgregor has quit IRC | 21:20 | |
*** sdake has joined #openstack-cinder | 21:22 | |
scottda | Is it worth a re-check of HPE storage CI for https://review.openstack.org/#/c/322459/66 ? Or does that need investigating? | 21:22 |
hemna | scottda, so I just did a recheck against a brick patch for the same basic failures | 21:23 |
hemna | failing quickly like that means that the CI env is effed | 21:23 |
hemna | but I would like that to pass on that patch if possible | 21:23 |
hemna | that patch is huge | 21:24 |
hemna | :( | 21:24 |
scottda | Yeah, I agree it should pass | 21:24 |
hemna | https://github.com/tj/git-extras | 21:25 |
hemna | found that today | 21:25 |
hemna | kinda handy stuffs | 21:25 |
*** david-lyle has joined #openstack-cinder | 21:26 | |
scottda | cool | 21:26 |
hemna | git summary is cool | 21:27 |
*** smile-luobin has quit IRC | 21:28 | |
*** smile-luobin has joined #openstack-cinder | 21:28 | |
hemna | http://paste.openstack.org/show/563682/ | 21:31 |
hemna | for Cinder | 21:31 |
*** david-lyle has quit IRC | 21:31 | |
*** dustins has quit IRC | 21:32 | |
*** eharney has quit IRC | 21:32 | |
*** pauloewerton has quit IRC | 21:35 | |
openstackgerrit | Raunak Kumar proposed openstack/cinder: Add Fibre Channel support for Nimble Storage https://review.openstack.org/359448 | 21:36 |
*** xyang has quit IRC | 21:43 | |
*** xyang has joined #openstack-cinder | 21:43 | |
*** xyang has quit IRC | 21:44 | |
*** xyang has joined #openstack-cinder | 21:45 | |
*** lprice has quit IRC | 21:48 | |
*** xinli has quit IRC | 21:58 | |
*** Suyi_ has quit IRC | 21:59 | |
*** Suyi_ has joined #openstack-cinder | 21:59 | |
*** gouthamr has quit IRC | 22:00 | |
*** gouthamr has joined #openstack-cinder | 22:00 | |
*** gouthamr has quit IRC | 22:00 | |
*** alyson_ has quit IRC | 22:03 | |
*** lpetrut has joined #openstack-cinder | 22:12 | |
*** kaisers_ has quit IRC | 22:15 | |
*** tpsilva has quit IRC | 22:18 | |
*** alonma has joined #openstack-cinder | 22:23 | |
*** sdake has quit IRC | 22:24 | |
*** gouthamr has joined #openstack-cinder | 22:25 | |
*** ducttape_ has quit IRC | 22:25 | |
*** ducttape_ has joined #openstack-cinder | 22:26 | |
openstackgerrit | xing-yang proposed openstack/cinder: Skip tests that caused hang https://review.openstack.org/360807 | 22:27 |
*** alonma has quit IRC | 22:27 | |
*** ducttape_ has quit IRC | 22:30 | |
*** ntpttr has quit IRC | 22:31 | |
openstackgerrit | Alexey Khodos proposed openstack/cinder: NexentaStor5: add extend method to NFS driver https://review.openstack.org/297880 | 22:32 |
*** xyang has quit IRC | 22:32 | |
*** salv-orl_ has quit IRC | 22:34 | |
*** rooneym has quit IRC | 22:35 | |
*** ntpttr has joined #openstack-cinder | 22:36 | |
*** sdake has joined #openstack-cinder | 22:37 | |
*** cknight has quit IRC | 22:40 | |
scottda | xyang1: Is there any way to see what volumes are in a group, or what group a volume belongs to? | 22:40 |
*** xyang has joined #openstack-cinder | 22:42 | |
xyang1 | scottda: I did not add that to the view, but they are in the group object | 22:42 |
scottda | xyang1: OK, so not visible using your CLI patches....just checking. | 22:43 |
xyang1 | scottda: yes | 22:43 |
scottda | Might be nice to add someday... | 22:43 |
xyang1 | scottda: we could do an enhancement | 22:43 |
scottda | stuff looks good, BTW. I agree with hemna That it'd be good to see HPE (and other) CI's pass before merging. | 22:43 |
*** alonma has joined #openstack-cinder | 22:44 | |
*** esker has joined #openstack-cinder | 22:44 | |
*** xyang has quit IRC | 22:46 | |
*** xyang has joined #openstack-cinder | 22:46 | |
xyang1 | scottda: how to trigger hpe ci | 22:46 |
hemna | I think I triggered it no? | 22:47 |
hemna | guess I didn't on that one. | 22:47 |
hemna | I just reissued it | 22:47 |
xyang1 | hemna: ok | 22:47 |
hemna | our CI is not managed by my team anymore....... | 22:48 |
*** alonma has quit IRC | 22:49 | |
xyang1 | hemna: I hope we don't wait for days though, the gate is so slow | 22:49 |
hemna | it's horribly slow now :( | 22:49 |
xyang1 | hemna: also I may get another merge conflict:( | 22:49 |
*** Apoorva has quit IRC | 22:50 | |
xyang1 | hemna: then start all over again:( | 22:50 |
hemna | yah, that's the risk on these huge patches | 22:50 |
hemna | man, I'd like to refactor that api code | 22:50 |
hemna | so we can reuse some of the v2 stuffs that won't change | 22:51 |
xyang1 | hemna: put common code under a common folder instead of reusing v2? | 22:54 |
*** xyang has quit IRC | 22:54 | |
hemna | yah or something like that | 22:55 |
hemna | maybe a base compatibility class | 22:55 |
hemna | and just add hooks in the base method that allows for changes... | 22:55 |
hemna | I dunno | 22:55 |
hemna | that can turn into a mess over time too | 22:55 |
scottda | I agree we can/should do something | 22:56 |
*** xyang has joined #openstack-cinder | 22:56 | |
xyang1 | hemna: has your CI being running normally lately? the failure looks like it did not even start with any tests | 22:58 |
*** chlong has quit IRC | 22:58 | |
hemna | it's been puking today | 22:58 |
hemna | I've issued rechecks on some other patches to try and see if it magically fixes itself | 22:58 |
hemna | but at this point that's all I Can do | 22:58 |
*** Apoorva has joined #openstack-cinder | 22:59 | |
*** gouthamr_ has joined #openstack-cinder | 22:59 | |
xyang1 | hemna: actually it passed at patchset 64 | 23:00 |
*** ducttape_ has joined #openstack-cinder | 23:00 | |
xyang1 | hemna: just rebase after that, so should be ok to go | 23:00 |
hemna | ugh our CI puked again | 23:01 |
hemna | *sigh* | 23:01 |
hemna | ok I added a +2 | 23:02 |
xyang1 | hemna: thanks! | 23:02 |
hemna | I can't +A it without our CI saying it's ok | 23:02 |
hemna | but at least I won't hold it up if someone was thinking of waiting for the 3PAR CI to pass | 23:03 |
hemna | have to run to soccer..... | 23:03 |
*** hemna is now known as hemnafk | 23:03 | |
*** gouthamr has quit IRC | 23:03 | |
xyang1 | hemna: ok, have fun | 23:03 |
*** alonma has joined #openstack-cinder | 23:04 | |
*** ducttape_ has quit IRC | 23:08 | |
*** alonma has quit IRC | 23:09 | |
*** chlong has joined #openstack-cinder | 23:12 | |
*** lpetrut has quit IRC | 23:14 | |
*** ebalduf has joined #openstack-cinder | 23:18 | |
*** xyang has quit IRC | 23:18 | |
*** JoseMello has quit IRC | 23:20 | |
*** ducttape_ has joined #openstack-cinder | 23:23 | |
*** ducttape_ has quit IRC | 23:33 | |
*** chlong has quit IRC | 23:35 | |
*** yangyape_ has quit IRC | 23:38 | |
*** xyang has joined #openstack-cinder | 23:41 | |
*** xyang has quit IRC | 23:46 | |
*** ducttape_ has joined #openstack-cinder | 23:47 | |
*** xyang has joined #openstack-cinder | 23:50 | |
*** david-lyle has joined #openstack-cinder | 23:52 | |
*** xyang1 has quit IRC | 23:52 | |
*** rcernin has quit IRC | 23:53 | |
*** xyang has quit IRC | 23:54 | |
*** xyang has joined #openstack-cinder | 23:57 | |
*** leeantho has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!