jgriffith | hemna patrickeast smcginnis can you guys do me a favor when you get a chance and let me know what it is that your FC drivers are returning on that terminate connection call? | 00:07 |
---|---|---|
jgriffith | hemna patrickeast smcginnis Swanson I started an etherpad here: https://etherpad.net/p/cinder-fcResponses-terminate_connection | 00:07 |
smcginnis | jgriffith: A bunch of crap. | 00:07 |
jgriffith | if you guys want to just dump some info in there that would be helpful | 00:08 |
jgriffith | smcginnis LOL | 00:08 |
jgriffith | smcginnis perfect! | 00:08 |
smcginnis | jgriffith: Swanson can probably give a more accurate answer though. | 00:08 |
smcginnis | Or at least more specific. | 00:08 |
jgriffith | The key in that etherpad is also "what it's used for" :) | 00:08 |
hemna | jgriffith, https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/hpe/hpe_3par_fc.py#L378-L393 | 00:08 |
jgriffith | hemna and the "what it's used for" part? | 00:09 |
smcginnis | It _should_ all be pretty consistent between drivers. It needs to be the info the FC zoning needs. | 00:09 |
hemna | the important piece there is returning initiator_target_map | 00:09 |
*** yangyapeng has quit IRC | 00:09 | |
hemna | that piece is returned if and only if there are no more volumes exported from the array to the host | 00:09 |
smcginnis | {'data' | 00:09 |
hemna | the FCZM then tests to see if that's in the return | 00:09 |
hemna | if it is, then it removes the zone | 00:09 |
hemna | else the fczm does nothing | 00:10 |
smcginnis | {'data': {'target_wwn': 'deadbeef', 'initiator_target_map': xxx}} | 00:10 |
jgriffith | hemna if it's just used by the FZM then WTF do we have to care at the manager? | 00:10 |
jgriffith | hemna or anywhere outside of that for that matter? | 00:11 |
hemna | we don't | 00:11 |
hemna | that's what I was trying to say in the meeting | 00:11 |
*** catintheroof has joined #openstack-cinder | 00:11 | |
smcginnis | We could certainly take the code that's building the dict to return into a call explicitly from the driver. | 00:11 |
jgriffith | hemna ahh | 00:11 |
hemna | hmm | 00:12 |
jgriffith | hemna so the only problem is that it's the "opposite" of the way my method works currently? | 00:12 |
hemna | maybe os-brick uses the data on disconnect_volume too | 00:12 |
smcginnis | hemna: Huh, I see we're returning Discard in there too. Is that right? | 00:12 |
jgriffith | in other words, I currently interpret any not None as "outstanding shared-connections" | 00:12 |
hemna | ah yah | 00:13 |
jgriffith | which this would actually indicate, the opposite; the Zone is done, so the ZM may be able to clean up | 00:13 |
* patrickeast catches up | 00:13 | |
hemna | brick uses target_wwn from the return | 00:13 |
patrickeast | jgriffith: yea thats correct | 00:13 |
jgriffith | hemna what does brick do with that? | 00:13 |
hemna | it's used to discover which paths on the system to remove | 00:14 |
*** lixiaoy1 has joined #openstack-cinder | 00:14 | |
jgriffith | sigh | 00:14 |
patrickeast | hemna: how would brick get the data currently though? we don't return it back up through the manager do we? | 00:14 |
jgriffith | patrickeast +1 | 00:14 |
* hemna looks | 00:14 | |
jgriffith | we do not.. maybe the ZM stuff just doesn't even work anyway :) | 00:14 |
patrickeast | nah, it works... but afaik it just removes the zoning | 00:15 |
patrickeast | then the initiator uses os-brick to get its own wwpn/wwns and calls os-brick | 00:15 |
patrickeast | i think | 00:15 |
jgriffith | hemna patrickeast so the idea was to try and make this work without having to go and modify all of the drivers, but it seems like maybe that's not going to work out | 00:15 |
hemna | so brick gets that from the bdm I think | 00:15 |
jgriffith | so maybe what I'll need to do is create a special response and update *EVERYTHING* to use said response | 00:16 |
jgriffith | hemna that would make sense, and be more in line with how the new code expects this to work | 00:16 |
hemna | sorry guys, it's just been a while since I've messed with this | 00:16 |
jgriffith | hemna that's ok, I don't mess with it at all :) | 00:16 |
patrickeast | jgriffith: you do now :P | 00:17 |
jgriffith | I just want to make sure that we have a defined interface and expected responses and actually stick with them | 00:17 |
hemna | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L958 | 00:17 |
jgriffith | patrickeast LOL!! Damn it! | 00:17 |
*** jdurgin has quit IRC | 00:17 | |
hemna | yah, so nova passes that connection_info in to brick from the bdm | 00:17 |
patrickeast | i'm game for defining a more standard response for the drivers to return from terminate_connection | 00:17 |
patrickeast | or even a new driver api that just asks given some host info if its safe to disconnect or not | 00:18 |
smcginnis | Whatever we end up with, let's make sure it's clearly spelled out here: https://github.com/openstack/cinder/blob/master/cinder/interface/volume_driver.py#L203 | 00:18 |
jgriffith | hemna so that's *good* news, because that's how I'm trying to move the new stuff to work, and in cases where that isn't there or doesn't work then use attachment-get | 00:18 |
jgriffith | smcginnis noted! | 00:18 |
hemna | yah so I think the terminate_connection dict passed back is only used by the FCZM at this point | 00:18 |
smcginnis | patrickeast: That could be racy to make it a separate call. | 00:18 |
smcginnis | patrickeast: But that could be possible too. | 00:18 |
*** jerrygb has quit IRC | 00:18 | |
hemna | and I think we wanted to nuke the decorator and just explicitly call the add/remove zone in the drivers | 00:18 |
patrickeast | smcginnis: meh, the whole thing is racy | 00:18 |
jgriffith | hemna we should probably make that an inheritiance/wrapper of some sort | 00:19 |
*** david-lyle has joined #openstack-cinder | 00:19 | |
smcginnis | patrickeast: Hah, fair point. | 00:19 |
hemna | jgriffith, heh, I've tried to enforce that a dozen times | 00:19 |
hemna | via the base FC volume driver | 00:19 |
jgriffith | we don't even have a dozen FC drivers do we :) | 00:19 |
hemna | ABC crap has greatly complicated that | 00:19 |
jgriffith | just kidding | 00:19 |
hemna | so I gave up | 00:19 |
jgriffith | you can't hit me from here | 00:19 |
patrickeast | lol | 00:19 |
hemna | hehe | 00:19 |
jgriffith | hemna hmmm... ABC, shall I rant :) | 00:20 |
jgriffith | nahh | 00:20 |
hemna | kill the alphabet | 00:20 |
jgriffith | hemna BUT... honestly here's the thing | 00:20 |
jgriffith | if somebody doesn't inherit like you say it doesn't matter | 00:20 |
jgriffith | and even that by itself doesn't solve the problem | 00:20 |
hemna | if everyone would have written an FC driver using the base FC class, then we could do all of this in the parent base class | 00:20 |
hemna | bleh | 00:20 |
jgriffith | What I'm getting at is just making sure the drivers all behave the same, if that means there needs to be some wrappers and indirection/helper methods that's cool | 00:21 |
hemna | yah, so I will abdicate that fight at this point | 00:21 |
jgriffith | hemna ahh, yeah; well that's always the case with stuff like this. The theory is great, but reality.. not so much | 00:21 |
hemna | yah I'm all for the same behavior, well at least with respect with what they are supposed to accept and return | 00:21 |
jgriffith | OO programming in general.. it's. a farce :) | 00:21 |
jgriffith | hemna the problem is that you may have different views on what those things are :) | 00:22 |
jgriffith | anyhow | 00:22 |
hemna | frankly the fczm usage has been an evolution from the beginning and hadn't needed to change it | 00:22 |
*** sdague has quit IRC | 00:22 | |
smcginnis | jgriffith: Well, OO programming in a loosely type language is kind of a farce. It can work very well in other languages. :) | 00:22 |
hemna | but I'd much rather make this easier to do | 00:22 |
jgriffith | the info on that etherpad will help, I'll try and confirm that the data isn't even actually going back to the caller or being used (or if folks with FC drivers want to check that would be cool) | 00:23 |
jgriffith | smcginnis hehe.. well that's a fair point | 00:23 |
jgriffith | smcginnis like Java where you have no choice? | 00:23 |
smcginnis | You must implement this... unless you don't want to, that's cool too. | 00:23 |
jgriffith | smcginnis yeah, that's what's F'd up | 00:23 |
hemna | then you stab yourself in the eye with classpath | 00:24 |
jgriffith | and I'd like to have a long talk with the person(s) that started us on the "everything's a snow flake" | 00:24 |
jgriffith | oh well, at least we can try and fix this up nicely | 00:24 |
smcginnis | jgriffith: +1 | 00:25 |
smcginnis | patrickeast: This seemed to regulary affect the Pure driver from showing up in the driver list: https://review.openstack.org/420993 | 00:26 |
smcginnis | patrickeast: So you might have some interest in that. | 00:26 |
*** mtan_____ has joined #openstack-cinder | 00:28 | |
smcginnis | jgriffith: That would be a good point for that. | 00:29 |
patrickeast | smcginnis: interesting, whats the list used for? | 00:29 |
smcginnis | jgriffith: We get all of that connection info there anyway. | 00:29 |
*** mtanino has quit IRC | 00:29 | |
patrickeast | i recall various points in time we talked about using an automated list of drivers for things... but afaik most public ones are manually maintained | 00:29 |
smcginnis | patrickeast: To get the list of all drivers. Most visibly it's used for the published driver list, but I still am hoping to expand that to do additional checks and things. | 00:30 |
smcginnis | patrickeast: There's also a patch somewhere to replace our driver capability wiki table with an automatically generated table. | 00:30 |
jgriffith | smcginnis hmmm? | 00:30 |
hemna | I think it includes the new CI wiki name in the output too | 00:30 |
smcginnis | patrickeast: http://docs.openstack.org/developer/cinder/drivers.html | 00:30 |
smcginnis | jgriffith: Was referring to what you were typing in the etherpad. | 00:31 |
jgriffith | smcginnis yeah, which part? | 00:31 |
hemna | yah, that's I think how those links to the CI are that list | 00:31 |
smcginnis | hemna: Yep. And Unsupported now too if applicable. | 00:31 |
hemna | ooh unsupported too | 00:31 |
smcginnis | jgriffith: connection_is_shared | 00:31 |
hemna | w00t | 00:31 |
smcginnis | jgriffith: We're querying that info anyway. | 00:31 |
jgriffith | smcginnis so I was getting at adding the connection_is_shared key, and if it's not there, or None we interpret it as false | 00:31 |
smcginnis | hemna: Public shaming. :D | 00:31 |
jgriffith | smcginnis oh? | 00:32 |
*** jdurgin has joined #openstack-cinder | 00:32 | |
smcginnis | jgriffith: That sounds good to me. | 00:32 |
hemna | is 3PAR in that list yet? | 00:32 |
smcginnis | jgriffith: If it's not there, then the driver isn't aware of multiattach. | 00:32 |
patrickeast | smcginnis: oh interesting, didn't even know that list was there, i always went off of https://www.openstack.org/marketplace/drivers/ https://wiki.openstack.org/wiki/CinderSupportMatrix or http://docs.openstack.org/newton/config-reference/block-storage/volume-drivers.html | 00:32 |
* patrickeast wonders if there are too many different lists | 00:32 | |
jgriffith | smcginnis right, but there are drivers like Pure that share connections still | 00:32 |
hemna | need a list of lists | 00:32 |
smcginnis | patrickeast: There are. This is one list to rule them all. ;) | 00:33 |
jgriffith | but I don't know how that works today anyway | 00:33 |
jgriffith | :) | 00:33 |
smcginnis | patrickeast: Assuming it actually is able to get all the drivers right. | 00:33 |
patrickeast | smcginnis: haha yea, that would be ideal | 00:33 |
smcginnis | patrickeast: If you notice, that also lists all fczm drivers and backup drivers. | 00:33 |
*** jerrygb has joined #openstack-cinder | 00:34 | |
smcginnis | hemna: While we're on the subject: https://review.openstack.org/#/q/status:open+project:openstack/cinder+branch:master+topic:ci_unsupported | 00:35 |
smcginnis | patrickeast, hemna: Double whammy. | 00:36 |
hemna | smcginnis, so...... | 00:36 |
hemna | 3PAR CI hasn't been passing for quite a while..... | 00:36 |
hemna | a long while | 00:36 |
smcginnis | hemna: I'll run my report again. It's been a few weeks now and last time I ran it there were a few that were right on the edge. | 00:37 |
smcginnis | OpenStack Ocata: The Bloodbath Release | 00:37 |
smcginnis | I hope to have the CI report automatically published to here eventually: http://cinderstats-dellstorage.rhcloud.com/ | 00:37 |
smcginnis | First I should figure out why my review could job doesn't appear to be running. | 00:38 |
smcginnis | Crap, and what happened to my other reports too. | 00:38 |
smcginnis | Hah, guess I've got some work to do there. | 00:38 |
*** jose-phillips has quit IRC | 00:40 | |
hemna | smcginnis, https://goo.gl/4jKMOu | 00:40 |
hemna | that's back to october | 00:40 |
hemna | unless I ran that incorrectly | 00:40 |
smcginnis | hemna: OK, I'll take a look tomorrow. | 00:42 |
hemna | what do you use to check the CI status? | 00:43 |
patrickeast | jgriffith: that proposed dict format on https://etherpad.net/p/cinder-fcResponses-terminate_connection looks good to me, seems like it would be simple enough for drivers to do that, and for the manager to make reasonable assumptions if it isn't there | 00:43 |
*** david-lyle has quit IRC | 00:43 | |
smcginnis | hemna: I've been using a modified version of this: https://github.com/openstack/third-party-ci-tools/tree/master/monitoring/lastcomment-scoreboard | 00:49 |
*** paw_ has joined #openstack-cinder | 00:55 | |
*** paw_ is now known as Guest98732 | 00:55 | |
*** paw has quit IRC | 00:58 | |
*** lgreg has quit IRC | 01:01 | |
*** venkhari has joined #openstack-cinder | 01:06 | |
*** csusuntao has joined #openstack-cinder | 01:07 | |
*** catintheroof has quit IRC | 01:09 | |
*** jerrygb has quit IRC | 01:13 | |
jgriffith | patrickeast cool! I just need to verify with you on the whole shared connection thing and how that works, but I'll get an update proposed tomorrow and let you have a look at it with the code and let me know if it works out or not | 01:14 |
*** wanghao has joined #openstack-cinder | 01:16 | |
*** yangyapeng has joined #openstack-cinder | 01:20 | |
*** trananhkma has quit IRC | 01:24 | |
*** salv-orlando has joined #openstack-cinder | 01:25 | |
*** csusuntao has quit IRC | 01:26 | |
*** cknight has joined #openstack-cinder | 01:31 | |
*** knomura has joined #openstack-cinder | 01:37 | |
openstackgerrit | Merged openstack/cinder: Mark the sheepdog driver as unsupported https://review.openstack.org/419079 | 01:38 |
*** huanxuan has joined #openstack-cinder | 01:40 | |
*** knomura has quit IRC | 01:42 | |
*** mdnadeem has joined #openstack-cinder | 01:44 | |
*** mdnadeem has quit IRC | 01:46 | |
*** salv-orlando has quit IRC | 01:46 | |
*** diablo_rojo has joined #openstack-cinder | 01:51 | |
*** mars has joined #openstack-cinder | 01:54 | |
*** mtan_____ has quit IRC | 01:57 | |
*** bardia has quit IRC | 01:58 | |
*** nicolasbock has quit IRC | 02:03 | |
*** venkhari has quit IRC | 02:12 | |
*** salv-orlando has joined #openstack-cinder | 02:13 | |
*** jerrygb has joined #openstack-cinder | 02:14 | |
*** jamielennox is now known as jamielennox|away | 02:25 | |
*** Apoorva has quit IRC | 02:28 | |
openstackgerrit | wanghao proposed openstack/cinder: Clean up image tmp file if c-vol gets restarted https://review.openstack.org/225081 | 02:31 |
*** salv-orlando has quit IRC | 02:32 | |
*** gcb has joined #openstack-cinder | 02:36 | |
openstackgerrit | Merged openstack/cinder: Prevent driver load failures from objects https://review.openstack.org/420993 | 02:37 |
openstackgerrit | wanghao proposed openstack/cinder: Support to query volume filter by change since/before https://review.openstack.org/352688 | 02:42 |
*** sudipto_ has joined #openstack-cinder | 02:52 | |
*** sudipto has joined #openstack-cinder | 02:52 | |
openstackgerrit | wanghongtaozz proposed openstack/cinder: Modify the spelling mistakes https://review.openstack.org/421037 | 02:53 |
*** salv-orlando has joined #openstack-cinder | 03:00 | |
*** Lee1092 has joined #openstack-cinder | 03:01 | |
*** jamielennox|away is now known as jamielennox | 03:03 | |
*** salv-orlando has quit IRC | 03:05 | |
*** bkopilov has quit IRC | 03:05 | |
*** bkopilov_ has quit IRC | 03:06 | |
*** jose-phillips has joined #openstack-cinder | 03:10 | |
*** jose-phillips has quit IRC | 03:10 | |
*** gouthamr has quit IRC | 03:12 | |
*** jose-phillips has joined #openstack-cinder | 03:13 | |
*** jose-phillips has quit IRC | 03:14 | |
*** jose-phillips has joined #openstack-cinder | 03:14 | |
*** jose-phillips has quit IRC | 03:17 | |
*** jose-phillips has joined #openstack-cinder | 03:18 | |
*** jose-phillips has quit IRC | 03:19 | |
*** jose-phillips has joined #openstack-cinder | 03:20 | |
*** jose-phillips has quit IRC | 03:21 | |
*** jose-phillips has joined #openstack-cinder | 03:22 | |
*** cknight has quit IRC | 03:26 | |
*** jose-phillips has quit IRC | 03:27 | |
*** links has joined #openstack-cinder | 03:32 | |
*** Apoorva has joined #openstack-cinder | 03:34 | |
*** pbandark has joined #openstack-cinder | 03:43 | |
*** mdnadeem has joined #openstack-cinder | 03:56 | |
*** s-shiono has joined #openstack-cinder | 04:02 | |
*** sudipto has quit IRC | 04:09 | |
*** sudipto has joined #openstack-cinder | 04:09 | |
*** psachin has joined #openstack-cinder | 04:09 | |
*** sudipto_ has quit IRC | 04:10 | |
*** sudipto_ has joined #openstack-cinder | 04:11 | |
openstackgerrit | Merged openstack/cinder: RBD: Fix RBD replication on volumes from image source. https://review.openstack.org/418288 | 04:11 |
openstackgerrit | Merged openstack/cinder: Add api version history for 3.23 https://review.openstack.org/419228 | 04:11 |
*** sheel has joined #openstack-cinder | 04:13 | |
*** bkopilov has joined #openstack-cinder | 04:27 | |
*** sudipto has quit IRC | 04:28 | |
*** sudipto_ has quit IRC | 04:28 | |
*** bardia has joined #openstack-cinder | 04:31 | |
*** bkopilov_ has joined #openstack-cinder | 04:34 | |
*** Apoorva has quit IRC | 04:38 | |
*** Apoorva has joined #openstack-cinder | 04:47 | |
*** Apoorva has quit IRC | 04:49 | |
*** tlian has quit IRC | 04:50 | |
*** salv-orlando has joined #openstack-cinder | 05:01 | |
*** salv-orlando has quit IRC | 05:06 | |
*** jerrygb has quit IRC | 05:08 | |
*** Poornima_K has joined #openstack-cinder | 05:11 | |
*** stakeda has joined #openstack-cinder | 05:11 | |
*** houming has joined #openstack-cinder | 05:17 | |
openstackgerrit | Merged openstack/cinder: Dell SC: Missing version history https://review.openstack.org/419686 | 05:18 |
*** houming has quit IRC | 05:20 | |
*** houming has joined #openstack-cinder | 05:21 | |
*** pgadiya has joined #openstack-cinder | 05:22 | |
*** pdeore has joined #openstack-cinder | 05:23 | |
*** sudipto_ has joined #openstack-cinder | 05:26 | |
*** sudipto has joined #openstack-cinder | 05:26 | |
*** adisky_ has joined #openstack-cinder | 05:31 | |
*** david-lyle has joined #openstack-cinder | 05:33 | |
*** Apoorva has joined #openstack-cinder | 05:37 | |
openstackgerrit | wanghongtaozz proposed openstack/cinder: Modify the spelling mistakes https://review.openstack.org/421079 | 05:40 |
*** david-lyle has quit IRC | 05:44 | |
*** Poornima_K has quit IRC | 05:44 | |
*** Jack_I has joined #openstack-cinder | 05:45 | |
*** Poornima_K has joined #openstack-cinder | 05:45 | |
*** bardia has quit IRC | 05:52 | |
*** alonmarx has joined #openstack-cinder | 05:52 | |
*** david-lyle has joined #openstack-cinder | 05:53 | |
*** Jack_V has joined #openstack-cinder | 05:53 | |
*** Jack_I has quit IRC | 05:57 | |
*** Jack_Iv has joined #openstack-cinder | 06:00 | |
*** Jack_Iv has quit IRC | 06:00 | |
*** Jack_Iv has joined #openstack-cinder | 06:01 | |
*** salv-orlando has joined #openstack-cinder | 06:02 | |
*** e0ne has quit IRC | 06:04 | |
*** salv-orlando has quit IRC | 06:07 | |
*** Jack_Iv has quit IRC | 06:11 | |
*** nkrinner_afk is now known as nkrinner | 06:14 | |
*** Jack_Iv has joined #openstack-cinder | 06:20 | |
*** Apoorva has quit IRC | 06:22 | |
*** david-lyle has quit IRC | 06:24 | |
*** Apoorva has joined #openstack-cinder | 06:26 | |
*** Apoorva has quit IRC | 06:28 | |
*** arne_r has joined #openstack-cinder | 06:30 | |
*** sudipto_ has quit IRC | 06:33 | |
*** sudipto has quit IRC | 06:33 | |
*** sudipto has joined #openstack-cinder | 06:33 | |
*** sudipto has quit IRC | 06:33 | |
*** sudipto has joined #openstack-cinder | 06:34 | |
*** sudipto_ has joined #openstack-cinder | 06:34 | |
*** diablo_rojo has quit IRC | 06:34 | |
*** mjura has joined #openstack-cinder | 06:38 | |
*** Jack_Iv has quit IRC | 06:43 | |
openstackgerrit | Merged openstack/cinder: CoprHD: Handle ScaleIO CI failing with version-3.5 https://review.openstack.org/417021 | 06:47 |
*** Jack_Iv has joined #openstack-cinder | 06:51 | |
*** houming has quit IRC | 06:53 | |
*** Jack_Iv has quit IRC | 06:55 | |
*** lpetrut has joined #openstack-cinder | 06:58 | |
*** kongwei has joined #openstack-cinder | 06:59 | |
*** houming has joined #openstack-cinder | 07:00 | |
winston-1 | Hi team, do we have agenda for PTG published somewhere? | 07:03 |
*** lixiaoy1 has quit IRC | 07:04 | |
openstackgerrit | Kazumasa Nomura proposed openstack/cinder: Restrain the unmanage snapshot for the VSP drivers https://review.openstack.org/421095 | 07:04 |
*** kongwei has quit IRC | 07:05 | |
*** houming has quit IRC | 07:06 | |
*** houming has joined #openstack-cinder | 07:07 | |
*** tesseract has joined #openstack-cinder | 07:16 | |
*** lkuchlan_wfh has joined #openstack-cinder | 07:17 | |
openstackgerrit | wanghongtaozz proposed openstack/cinder: Modify the spelling mistakes https://review.openstack.org/421100 | 07:18 |
openstackgerrit | wanghongtaozz proposed openstack/cinder: Modify the spelling mistakes https://review.openstack.org/421101 | 07:25 |
*** huanxuan has quit IRC | 07:29 | |
openstackgerrit | wanghongtaozz proposed openstack/cinder: Modify the spelling mistakes https://review.openstack.org/421104 | 07:30 |
*** ChubYann has quit IRC | 07:32 | |
*** wanghao has quit IRC | 07:39 | |
*** salv-orlando has joined #openstack-cinder | 07:40 | |
*** wanghao has joined #openstack-cinder | 07:40 | |
*** mriedem has quit IRC | 07:41 | |
*** lpetrut has quit IRC | 07:46 | |
*** lpetrut has joined #openstack-cinder | 07:53 | |
*** dmellado has quit IRC | 08:02 | |
*** geguileo has quit IRC | 08:03 | |
*** dmellado has joined #openstack-cinder | 08:04 | |
*** geguileo has joined #openstack-cinder | 08:05 | |
*** takedakn has joined #openstack-cinder | 08:07 | |
*** wanghao_ has joined #openstack-cinder | 08:09 | |
*** salv-orlando has quit IRC | 08:09 | |
*** wanghao has quit IRC | 08:12 | |
*** lkuchlan_wfh has quit IRC | 08:12 | |
*** lkuchlan has joined #openstack-cinder | 08:12 | |
*** wanghao_ has quit IRC | 08:25 | |
*** wanghao has joined #openstack-cinder | 08:25 | |
*** Jack_Iv has joined #openstack-cinder | 08:45 | |
*** markus_z has joined #openstack-cinder | 08:45 | |
markus_z | Needs a second +2 https://review.openstack.org/#/c/413684/5 | 08:46 |
*** pgadiya_ has joined #openstack-cinder | 08:46 | |
*** wanghao has quit IRC | 08:47 | |
*** wanghao_ has joined #openstack-cinder | 08:47 | |
*** e0ne has joined #openstack-cinder | 08:48 | |
*** Jack_I has joined #openstack-cinder | 08:48 | |
openstackgerrit | ZhangHongtao proposed openstack/os-brick: Fix a wrong indentation https://review.openstack.org/421137 | 08:49 |
*** Jack_V has quit IRC | 08:49 | |
*** pgadiya has quit IRC | 08:49 | |
*** Jack_V has joined #openstack-cinder | 08:52 | |
*** Jack_I has quit IRC | 08:56 | |
*** zzzeek has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-cinder | 09:00 | |
*** rha has quit IRC | 09:03 | |
*** markus_z has quit IRC | 09:04 | |
*** Poornima_K has quit IRC | 09:09 | |
*** Lehtu has quit IRC | 09:17 | |
*** Jack_Iv_ has joined #openstack-cinder | 09:19 | |
*** markus_z has joined #openstack-cinder | 09:19 | |
*** alekseyruban has joined #openstack-cinder | 09:20 | |
*** Jack_Iv has quit IRC | 09:21 | |
openstackgerrit | Helen Walsh proposed openstack/cinder: VMAX driver - Implement volume replication for VMAX https://review.openstack.org/409079 | 09:25 |
*** Jack_Iv_ has quit IRC | 09:26 | |
dulek | If anyone want to take a look on simple, non-conflicting patch: https://review.openstack.org/#/c/396264/ | 09:26 |
openstackgerrit | Helen Walsh proposed openstack/cinder: VMAX driver - storage group cleanup on error https://review.openstack.org/411329 | 09:28 |
openstackgerrit | wanghao proposed openstack/cinder: Clean up image tmp file if c-vol gets restarted https://review.openstack.org/225081 | 09:29 |
*** mvk has quit IRC | 09:30 | |
openstackgerrit | Helen Walsh proposed openstack/cinder: VMAX driver - rename and restructure driver https://review.openstack.org/411922 | 09:33 |
*** jordanP has joined #openstack-cinder | 09:38 | |
*** wanghao_ has quit IRC | 09:41 | |
*** swamireddy has quit IRC | 09:43 | |
*** lkuchlan has quit IRC | 09:49 | |
*** lkuchlan has joined #openstack-cinder | 09:49 | |
*** lkuchlan has quit IRC | 09:49 | |
*** lkuchlan has joined #openstack-cinder | 09:50 | |
*** takedakn has quit IRC | 09:52 | |
*** yumiriam has joined #openstack-cinder | 09:57 | |
*** swamireddy has joined #openstack-cinder | 10:01 | |
*** jordanP has quit IRC | 10:04 | |
*** alyson_ has joined #openstack-cinder | 10:05 | |
*** mvk has joined #openstack-cinder | 10:06 | |
*** yangyapeng has quit IRC | 10:07 | |
*** salv-orlando has joined #openstack-cinder | 10:10 | |
*** s-shiono has quit IRC | 10:14 | |
*** salv-orlando has quit IRC | 10:14 | |
*** jose-phillips has joined #openstack-cinder | 10:15 | |
*** haplo37_ has quit IRC | 10:19 | |
*** haplo37_ has joined #openstack-cinder | 10:19 | |
*** flip214 has quit IRC | 10:21 | |
*** lixiaoy1 has joined #openstack-cinder | 10:23 | |
*** flip214 has joined #openstack-cinder | 10:29 | |
*** flip214 has joined #openstack-cinder | 10:29 | |
*** zengyingzhe has quit IRC | 10:30 | |
*** zengyingzhe has joined #openstack-cinder | 10:30 | |
*** lixiaoy1 has quit IRC | 10:31 | |
*** mvk has quit IRC | 10:32 | |
*** tommylikehu has quit IRC | 10:40 | |
*** mvk has joined #openstack-cinder | 10:47 | |
*** tommylikehu has joined #openstack-cinder | 10:48 | |
*** mriedem has joined #openstack-cinder | 11:00 | |
*** sudipto_ has quit IRC | 11:02 | |
*** sudipto has quit IRC | 11:02 | |
*** wanghao has joined #openstack-cinder | 11:06 | |
*** lpetrut has quit IRC | 11:06 | |
*** wanghao has quit IRC | 11:07 | |
*** wanghao has joined #openstack-cinder | 11:08 | |
*** markus_z has quit IRC | 11:11 | |
*** alekseyruban has quit IRC | 11:17 | |
*** Poornima_K has joined #openstack-cinder | 11:18 | |
*** ociuhandu has quit IRC | 11:23 | |
*** flip214 has quit IRC | 11:23 | |
*** jordanP has joined #openstack-cinder | 11:25 | |
*** flip214 has joined #openstack-cinder | 11:25 | |
*** flip214 has joined #openstack-cinder | 11:25 | |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: Add volume to fake snapshot object https://review.openstack.org/407357 | 11:26 |
*** rha has joined #openstack-cinder | 11:27 | |
*** mvk has quit IRC | 11:28 | |
*** houming has quit IRC | 11:28 | |
*** ntpttr has quit IRC | 11:31 | |
*** houming has joined #openstack-cinder | 11:35 | |
*** ntpttr has joined #openstack-cinder | 11:39 | |
*** jose-phillips has quit IRC | 11:39 | |
*** pdeore has quit IRC | 11:40 | |
*** jose-phillips has joined #openstack-cinder | 11:40 | |
*** mvk has joined #openstack-cinder | 11:41 | |
*** JoseMello has joined #openstack-cinder | 11:43 | |
adrianofr | dulek, xyang: Hi. We have a happy CI now https://review.openstack.org/#/c/414544/ | 11:50 |
dulek | adrianofr: +W :) | 11:51 |
adrianofr | dulek: Tks :) | 11:52 |
*** pgadiya_ has quit IRC | 11:58 | |
*** Poornima_K has quit IRC | 11:59 | |
*** yangyapeng has joined #openstack-cinder | 11:59 | |
*** cdelatte has joined #openstack-cinder | 11:59 | |
*** timcl has joined #openstack-cinder | 11:59 | |
*** nicolasbock has joined #openstack-cinder | 12:01 | |
openstackgerrit | ShangXiao proposed openstack/cinder: Modify the spelling mistakes https://review.openstack.org/421235 | 12:03 |
*** wanghao_ has joined #openstack-cinder | 12:09 | |
*** lpetrut has joined #openstack-cinder | 12:10 | |
*** wanghao has quit IRC | 12:12 | |
*** links has quit IRC | 12:12 | |
*** Poornima_K has joined #openstack-cinder | 12:13 | |
*** jose-phillips has quit IRC | 12:14 | |
*** markus_z has joined #openstack-cinder | 12:16 | |
*** bkopilov_ has quit IRC | 12:22 | |
*** bkopilov has quit IRC | 12:23 | |
*** tesseract has quit IRC | 12:23 | |
*** mkoderer has quit IRC | 12:26 | |
*** catintheroof has joined #openstack-cinder | 12:32 | |
*** Lee1092 has quit IRC | 12:36 | |
*** wanghao_ has quit IRC | 12:39 | |
*** lamt has quit IRC | 12:41 | |
*** sdague has joined #openstack-cinder | 12:43 | |
*** Jack_I has joined #openstack-cinder | 12:46 | |
smcginnis | winston-1: We just have this so far: https://etherpad.openstack.org/p/ATL-cinder-ptg-planning | 12:47 |
smcginnis | winston-1: Are you able to attend? | 12:47 |
*** Jack_V has quit IRC | 12:48 | |
*** mriedem has quit IRC | 12:48 | |
*** houming has quit IRC | 12:48 | |
*** gouthamr has joined #openstack-cinder | 12:49 | |
*** Poornima_K has quit IRC | 12:49 | |
openstackgerrit | Merged openstack/cinder: HNAS: Change snapshot names https://review.openstack.org/414544 | 12:51 |
*** gcb has quit IRC | 12:58 | |
*** links has joined #openstack-cinder | 12:58 | |
*** jwcroppe has joined #openstack-cinder | 12:59 | |
*** links has quit IRC | 13:01 | |
*** mars has quit IRC | 13:02 | |
*** dave-mccowan has joined #openstack-cinder | 13:02 | |
openstackgerrit | Helen Walsh proposed openstack/cinder: VMAX driver - Storage assisted volume migration. https://review.openstack.org/397862 | 13:03 |
*** dustins has joined #openstack-cinder | 13:09 | |
openstackgerrit | Pavel Gluschak proposed openstack/cinder: vzstorage: use resize instead of grow for ploop images https://review.openstack.org/400235 | 13:10 |
*** eharney has joined #openstack-cinder | 13:10 | |
*** lamt has joined #openstack-cinder | 13:11 | |
*** crose has joined #openstack-cinder | 13:23 | |
*** cristicalin has joined #openstack-cinder | 13:25 | |
*** pdeore has joined #openstack-cinder | 13:39 | |
*** Jack_Iv has joined #openstack-cinder | 13:40 | |
*** sudipto has joined #openstack-cinder | 13:45 | |
*** sudipto_ has joined #openstack-cinder | 13:45 | |
*** markvoelker has joined #openstack-cinder | 13:45 | |
*** Poornima has joined #openstack-cinder | 13:56 | |
*** tommylikehu_ has joined #openstack-cinder | 13:58 | |
*** mdnadeem has quit IRC | 14:01 | |
*** pdeore has quit IRC | 14:01 | |
*** huanxuan has joined #openstack-cinder | 14:05 | |
*** asettle has joined #openstack-cinder | 14:06 | |
asettle | Hey - wondering if someone is able/around to help me triage a bug. We've been getting a lot of bugs for manuals content with configuration content that I don't know much about. | 14:07 |
asettle | https://bugs.launchpad.net/openstack-manuals/+bug/1644562 | 14:07 |
openstack | Launchpad bug 1644562 in openstack-manuals "Install and configure a storage node in Installation Guide" [Undecided,New] | 14:07 |
asettle | Using the Ubuntu install guide, the reporter was unable to create a volume. cinder-volume does not start. | 14:07 |
asettle | Newton install guide. | 14:07 |
*** cristicalin has quit IRC | 14:08 | |
*** mriedem has joined #openstack-cinder | 14:10 | |
*** salv-orlando has joined #openstack-cinder | 14:10 | |
*** liverpooler has quit IRC | 14:13 | |
*** jerrygb has joined #openstack-cinder | 14:14 | |
smcginnis | asettle: I just did an install from that guide not long ago. Some dependency must have changed. | 14:14 |
smcginnis | asettle: Appears to be from this: Unrecoverable Error: Versioned Objects in DB are capped to unknown version 1.11. | 14:15 |
smcginnis | dulek: You still around? ^^ | 14:15 |
asettle | A successful install from that guide? | 14:15 |
smcginnis | asettle: The newton Ubuntu guide on docs.o.o, right? | 14:15 |
asettle | That's the one, yep smcginnis | 14:16 |
*** ociuhandu has joined #openstack-cinder | 14:16 | |
smcginnis | asettle: Yeah, maybe about a month ago now, but recent enough that I know it was at least working as described recently. :) | 14:17 |
asettle | Oh good :) (thank god) | 14:17 |
smcginnis | asettle: ;) | 14:18 |
asettle | Okay, then I have absolutely no idea how this reporter ended up at this point tbh :/ | 14:18 |
smcginnis | Looks like oslo.versionedobjects was probable updated since I did it. 1.19.0 went out Dec 1 and 1.20.0 went out Dec 6. | 14:18 |
asettle | The reporter needs to update? | 14:18 |
smcginnis | My suspicion is either that or some other library has made a change that broke something. | 14:18 |
smcginnis | asettle: Or we are not capping something that we need to. | 14:19 |
smcginnis | asettle: Either that or they missed something in the setup, but my first assumption is that we broke something, not them. | 14:19 |
asettle | That's a nice assumption :P i'm a lot more ruthless than that. | 14:19 |
asettle | Hm, okay, so - anyway to quickly verify this? Sorry for leaning on you a lot here, I've decided to bug triage my little heart out but it gets harder the more configuration info you need to know across *all* projects. | 14:20 |
smcginnis | asettle: I can only imagine! | 14:20 |
asettle | Hahahha *sigh* *head desk* | 14:21 |
smcginnis | asettle: Well, I have a basic understanding of the versioned objects stuff, but dulek is our resident expert on all of that. | 14:21 |
smcginnis | asettle: He's usually around, so he'll probably be back soon. I'm sure it will be obvious to him. ;) | 14:21 |
asettle | It's always obvious to someone :P | 14:21 |
asettle | The bug and I can wait :) thanks for having a look though smcginnis ! | 14:22 |
smcginnis | asettle: That's the truth. | 14:22 |
asettle | dulek: shoot me a ping when you're in please :) | 14:22 |
smcginnis | asettle: No problem. I'll keep it open in a tab so I remember to follow up if we don't hear anything. | 14:22 |
*** tlian has joined #openstack-cinder | 14:23 | |
asettle | :) wonderful, thanks! Me too - I'll stare at it and hope that via osmosis cinder configuration contextual information will just absorb. | 14:23 |
asettle | Something tells me that won't work, but hey, here's trying. | 14:23 |
smcginnis | asettle: Hah, good luck with that. :P | 14:23 |
asettle | Thank you smcginnis - I very well might need it. | 14:23 |
dulek | I'm on a meeting for 25 minutes and everything collapses. | 14:26 |
*** ducttape_ has quit IRC | 14:26 | |
dulek | asettle: Let me read the scrollback first. :) | 14:26 |
asettle | dulek: it's a rollercoaster from start to finish | 14:26 |
dulek | asettle: http://docs.openstack.org/developer/cinder/upgrade.html#rpc-version-pinning | 14:28 |
dulek | asettle: If that's not clear enough I'll be happy to update it with your feedback. | 14:28 |
asettle | And like magic dulek knows the things. dulek - could you explain to me what exactly you're pointing to? I know as much about cinder as I do about... Icelandic politics. | 14:29 |
*** pbandark has quit IRC | 14:29 | |
dulek | asettle: Basically this error happens if there are old, dead records in services, that reported older versions of either RPC APIs or objects. | 14:29 |
dulek | asettle: Or - the code isn't checked out from exactly the same git ref and versions differ. | 14:30 |
asettle | dulek: oh! Thank you! | 14:31 |
asettle | That makes sense :) | 14:31 |
dulek | asettle: There's one more mention in the 5th point here: http://docs.openstack.org/developer/cinder/upgrade.html#plan-your-upgrade | 14:31 |
dulek | cinder-manage service remove is helpful if orphaned records are the cause. | 14:32 |
*** bkopilov_ has joined #openstack-cinder | 14:32 | |
asettle | Okay! Makes sense :) | 14:32 |
*** bkopilov has joined #openstack-cinder | 14:33 | |
openstackgerrit | Alon Marx proposed openstack/cinder: Open the source code of ibm_storage driver https://review.openstack.org/404958 | 14:35 |
*** knomura has joined #openstack-cinder | 14:35 | |
asettle | Thanks dulek and smcginnis :) I've updated the bug with your comments. | 14:35 |
asettle | These kind of bugs do my head in. | 14:36 |
*** Jack_Iv has quit IRC | 14:36 | |
*** gcb has joined #openstack-cinder | 14:36 | |
dulek | asettle: Awesome. I'll think about providing better feedback for the admin when this occurs. | 14:36 |
smcginnis | asettle: It sounded like they were doing a new install, but maybe it was an upgrade. Or like dulek mentioned, maybe different revs of the code. | 14:36 |
*** psachin has quit IRC | 14:37 | |
dulek | smcginnis: Or they've reused old database. | 14:37 |
smcginnis | dulek: Yeah... whatever is going on, it doesn't appear to be a straight install through the install guide. | 14:38 |
asettle | *Everyone* reports they are doing a straight install from the guide. | 14:38 |
asettle | Some are easier to identify than others. | 14:38 |
smcginnis | asettle: "Honestly, I didn't touch anything" (whole config is changed) :) | 14:39 |
asettle | Ugh. Yes. I had one bug report that was basically like "I've done *everything* you said in the guide, but here's my optional configurations, WHY DONT YOU DOCUMENT THIS" | 14:39 |
asettle | It was a very angry bug report. | 14:39 |
openstackgerrit | Rohan Arora proposed openstack/cinder: Nosec subprocess with shell equal True from Bandit https://review.openstack.org/420979 | 14:40 |
smcginnis | asettle: Oh, I love those. | 14:40 |
*** porrua has joined #openstack-cinder | 14:40 | |
asettle | *so* good. Also I guess the one big problem about getting some bugs in manuals is that we get a lot of troubleshooting questions. | 14:40 |
asettle | I have typed "Please ask your questions in #openstack-PROJECT" more times than I can count. | 14:41 |
smcginnis | asettle: I'm sure! | 14:41 |
*** cristicalin has joined #openstack-cinder | 14:41 | |
asettle | Anyway, cheers guys :) appreciate it! | 14:41 |
smcginnis | asettle: For our storage product it was a joke for a while. *Every* bug was filed against our UI team, because obviously it was a UI problem that an error was displayed. | 14:41 |
asettle | HAHAHA | 14:42 |
asettle | Oh dear. | 14:42 |
asettle | I'm trying to think of ways to reduce some of this bug count and make it easier for everyone to triage. So far I've come up with 'kill it with fire'. | 14:42 |
smcginnis | asettle: Well, any other Cinder issues come up, feel free to point them our way. | 14:43 |
smcginnis | asettle: Hah! | 14:43 |
asettle | smcginnis: will you regret that promise when I suddenly start spending an inordinate amount of time here? :p | 14:43 |
asettle | I'll be that docs weirdo in the corner. | 14:44 |
smcginnis | asettle: haha, I might regret it a little, but I think our docs are very important, so I'll gladly put up with it. ;) | 14:46 |
asettle | \o/ can I quote you on that? | 14:46 |
asettle | "Docs are very important" smcginnis , 2017 | 14:46 |
smcginnis | asettle: :) | 14:46 |
*** cristicalin has quit IRC | 14:47 | |
asettle | I did remove the 'our' to suit my needs. | 14:47 |
*** dustins has quit IRC | 14:47 | |
smcginnis | asettle: Still a fair statement. :) | 14:48 |
*** salv-orlando has quit IRC | 14:50 | |
*** Guest98732 is now known as paw | 14:50 | |
*** paw has quit IRC | 14:50 | |
*** paw has joined #openstack-cinder | 14:51 | |
*** lamt has quit IRC | 14:52 | |
openstackgerrit | Manish proposed openstack/cinder: 3PAR: Incosistency in copied and source CG https://review.openstack.org/419335 | 14:54 |
*** lamt has joined #openstack-cinder | 14:58 | |
asettle | smcginnis: haha I hope so :) | 14:58 |
*** ducttape_ has joined #openstack-cinder | 14:59 | |
*** alonmarx_ has joined #openstack-cinder | 15:02 | |
*** swamireddy has quit IRC | 15:02 | |
*** Julien-zte has joined #openstack-cinder | 15:03 | |
*** rajinir has joined #openstack-cinder | 15:03 | |
*** JoseMello has quit IRC | 15:05 | |
*** cknight has joined #openstack-cinder | 15:05 | |
*** alonmarx has quit IRC | 15:05 | |
*** Poornima has quit IRC | 15:06 | |
*** huanxuan has quit IRC | 15:06 | |
*** swamireddy has joined #openstack-cinder | 15:12 | |
openstackgerrit | Helen Walsh proposed openstack/cinder: VMAX driver - Add CG capability to groups https://review.openstack.org/408176 | 15:12 |
*** pcaruana has quit IRC | 15:15 | |
*** nkrinner is now known as nkrinner_afk | 15:17 | |
*** david-lyle has joined #openstack-cinder | 15:24 | |
*** gcb has quit IRC | 15:26 | |
*** xyang has joined #openstack-cinder | 15:27 | |
*** david-lyle has quit IRC | 15:29 | |
*** david-lyle has joined #openstack-cinder | 15:29 | |
*** akerr has joined #openstack-cinder | 15:32 | |
*** david-lyle has quit IRC | 15:34 | |
*** xyang has quit IRC | 15:41 | |
*** david-lyle has joined #openstack-cinder | 15:42 | |
scottda | ildikov: Ping | 15:45 |
*** dustins has joined #openstack-cinder | 15:45 | |
ildikov | scottda: pong | 15:45 |
scottda | Just checking in...it looks like that nova/volume/cinder.py patch solved the v3 endpoint issue? | 15:46 |
ildikov | it works in my env | 15:46 |
ildikov | I added volumev3 to the context file in Nova as it's in your patch and I don't need the other hacks now | 15:47 |
ildikov | I hardcoded the microversion now for local testing | 15:47 |
ildikov | mriedem added a short note to one of the patches about negotiating about the microversion rather than make it a config option | 15:48 |
scottda | yeah, I saw that. I can add a placeholder microversion in that patch until we land the cinder stuff and know exactly what that will be... | 15:50 |
*** mvk has quit IRC | 15:51 | |
scottda | I figure this nova patch is just for testing ATM. The main focus is to land the Cinder changes. | 15:51 |
openstackgerrit | Rohan Arora proposed openstack/cinder: Use secure random function for AES encryption https://review.openstack.org/410874 | 15:51 |
*** xyang has joined #openstack-cinder | 15:55 | |
*** david-lyle has quit IRC | 15:55 | |
*** kfarr has joined #openstack-cinder | 15:56 | |
*** erhudy has joined #openstack-cinder | 15:58 | |
*** _ducttape_ has joined #openstack-cinder | 15:59 | |
scottda | smcginnis: Do we(you) want to put something on the meeting agenda regarding our idea to sprint on HA/AA and new Cinder-nova API stuff WEd and thurs? | 16:00 |
scottda | #startmeeting cinder_testing | 16:01 |
openstack | Meeting started Tue Jan 17 16:01:49 2017 UTC and is due to finish in 60 minutes. The chair is scottda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:01 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:01 |
openstack | The meeting name has been set to 'cinder_testing' | 16:01 |
erlon | hey | 16:02 |
scottda | ping eharney, xyang1, gouthamr, akerr, smcginnis, cFouts, e0ne, geguileo, dulek, flip214, ntpttr patrickeast, _alastor_, DuncanT, erlon, josemello,mdarnell, karthikp | 16:02 |
e0ne | hi | 16:02 |
scottda | hi erlon . Now that you are hear, we know we'll have something to talk about :) | 16:02 |
xyang | hi | 16:02 |
scottda | #link https://etherpad.openstack.org/p/cinder-ocata-testing | 16:02 |
*** akerr has quit IRC | 16:02 | |
scottda | I pointed this out last week ^^^ | 16:02 |
erlon | scottda: haha, | 16:03 |
*** ducttape_ has quit IRC | 16:03 | |
scottda | Some tracking so that we can make sure things get *some* coverage before the release | 16:03 |
erlon | scottda: nothing much new, Im returning this week from my pto | 16:03 |
scottda | But I don't see much action on that...I'm going to put that link on the main Cinder meeting agenda | 16:03 |
erlon | scottda: I notice that etherpad is very empty, may be folks should update it with details | 16:04 |
scottda | yup | 16:04 |
*** tommylikehu_ has quit IRC | 16:04 | |
erlon | scottda: I added some bullets but still need to track the migration related bugs and try to sort then out | 16:05 |
*** ociuhandu has quit IRC | 16:05 | |
scottda | OK, I added a reminder in the main Cinder agenda | 16:06 |
erlon | scottda: nice | 16:07 |
*** Jack_Iv has joined #openstack-cinder | 16:07 | |
scottda | I also have added something to the PTG etherpad regarding a single Testing priority for Pike release... | 16:07 |
*** sheel has quit IRC | 16:07 | |
erlon | scottda: people should really give some attention to testing. The AA patches are landing and they touch a lot of code | 16:07 |
*** david-lyle has joined #openstack-cinder | 16:07 | |
hemna | what's up | 16:08 |
scottda | I think if we don't have a single focus, we'll end up with the usual list of everything wrong we'd like to fix. | 16:08 |
scottda | hemna: Hi. | 16:08 |
scottda | Anyone have anything about tests they'd like to talk about? | 16:09 |
erlon | scottda: whast do you mean by single focus? | 16:09 |
scottda | erlon: Well, if we come up with the 10 areas we need to write tempest/functional tests for, none of them will get done.... | 16:10 |
scottda | erlon: If we pick one, there is hope that we can focus and perhaps make progress. | 16:10 |
scottda | Then, we could add more if there is time. | 16:10 |
geguileo | erlon: I have a fix for the manage issue | 16:10 |
scottda | smcginnis: had suggested this, and I agree. | 16:10 |
geguileo | erlon: I'm going to look into the retype with migration now | 16:10 |
erlon | scottda: hmm, I see | 16:11 |
scottda | But, of course, people can work on whatever they want (or whatever their employer lets them do) | 16:11 |
openstackgerrit | Merged openstack/os-brick: Fix a wrong indentation https://review.openstack.org/421137 | 16:11 |
erlon | geguileo: I remember I have some patches but didnt submit | 16:11 |
erlon | geguileo: ill put a patch and you can give a look if theres something missing | 16:11 |
scottda | geguileo: I had left some work undone on retype with migration...we hope we can end up calling Nova swap volume, to test that as well. | 16:11 |
geguileo | erlon: lol, then our patches will be fighting one another | 16:11 |
erlon | geguileo: haha | 16:12 |
scottda | geguileo: erlon I think that using LVM will cause a Nova swap_volume if the hostname for both backends is different. Otherwise, it won't call swap_volume. | 16:12 |
geguileo | scottda: I have just fixed the manage one, I have to look at the other case, as it may be related | 16:13 |
*** bswartz has quit IRC | 16:13 | |
erlon | scottda: I dont reacall now, but I believe swap_volume is always being called for the attached migration | 16:14 |
scottda | OK, cool. I think there is a local nova test for swap_volume, but nothing that exercises it from Cinder... | 16:14 |
scottda | and therefore not testing of anything that has Cinder call Nova, and using the novaclient, etc. | 16:15 |
markus_z | scottda: Would you maybe have a look at https://review.openstack.org/#/c/413684/ ? Needs a 2nd +2. | 16:15 |
scottda | erlon: No, I don't think it will with a single-node LVM setup, since the hostname is the smae for both backends. | 16:15 |
scottda | s/smae/same | 16:15 |
scottda | erlon: I thought I had a patch that worked, but there is some logic to optimize things for the case of 2 backends on the same host...I'll try to find it... | 16:16 |
scottda | markus_z: I'll put it in my queue to have a look | 16:16 |
markus_z | scottda: Thanks, that's all I can ask for :) | 16:16 |
*** breitz has joined #openstack-cinder | 16:17 | |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Fix sched/manager calls to filters https://review.openstack.org/421348 | 16:18 |
erlon | geguileo: ^ first :) | 16:19 |
scottda | #link https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2293 | 16:19 |
geguileo | erlon: lol, I still have to add the tests | 16:19 |
geguileo | erlon: And see if it helps with the other bug | 16:19 |
scottda | erlon: That is it, I think | 16:19 |
*** diablo_rojo has joined #openstack-cinder | 16:19 | |
erlon | scottda: yep, theres this case, I found it because I was testing migration between pools in the same backend | 16:21 |
scottda | erlon: So, does your test patch get around this? If not, we'll go with geguileo | 16:21 |
scottda | :) | 16:21 |
erlon | scottda: which is the must be the same behavior you mentioned in LVM | 16:21 |
erlon | scottda: yes | 16:21 |
erlon | scottda: ow wait | 16:22 |
scottda | erlon: I think we really need to check the Nova logs to verify. Otherwise, we'll need an additional test. And this already takes a bit of time to run. | 16:22 |
geguileo | erlon: your patch is incomplete | 16:23 |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Fix retype with migration false positive success https://review.openstack.org/421353 | 16:23 |
*** mjura has quit IRC | 16:23 | |
erlon | geguileo: yeap, that another error | 16:23 |
erlon | I split in those 2 | 16:23 |
scottda | erlon: You don't get to be first to post a patch if it's not complete :) | 16:23 |
erlon | geguileo: scottda: the last one is handling the hostname | 16:24 |
erlon | scottda: haha damn | 16:24 |
erlon | scottda: geguileo: they where hanging here, fell free to -2 if you have another that fix | 16:25 |
geguileo | erlon: I'll look now at reproducing the second issue and do the RCA | 16:26 |
*** lkuchlan has quit IRC | 16:27 | |
erlon | geguileo: ok, leme know if you have problem to reproduce it | 16:27 |
openstackgerrit | int32bit proposed openstack/python-cinderclient: Add snapshot-id filter to get volumes via cli https://review.openstack.org/416510 | 16:27 |
geguileo | erlon: why do we need to say that None is not equal to None for host equivalency? | 16:27 |
erlon | geguileo: I don't think we need to. Actually they should not be considered equal | 16:29 |
erlon | geguileo: if clustering is not configured, both are None, but the hosts are actually different | 16:30 |
geguileo | erlon: Why should they not be considered equal? | 16:30 |
geguileo | erlon: but that should be ok | 16:31 |
geguileo | erlon: clusters are equal but not the hosts | 16:31 |
erlon | the false positive happens here:https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2295 | 16:31 |
*** bswartz has joined #openstack-cinder | 16:31 | |
erlon | geguileo: yeah but if does not have cluster_name set, it will lead to a false positive as will compair None == None | 16:33 |
geguileo | erlon: I'll check it, because then the problem is somewhere else, not in that method | 16:33 |
*** dustins has quit IRC | 16:34 | |
*** dustins_ has joined #openstack-cinder | 16:34 | |
erlon | geguileo: I was trying to understand if the cluster_name that should always have the right values or if the comparation should consider that they could be None, but didn't get to a conclusion, that's why I pinged you the last time | 16:35 |
*** arne_r has quit IRC | 16:36 | |
*** Julien-zte has quit IRC | 16:36 | |
*** e0ne has quit IRC | 16:37 | |
*** Julien-zte has joined #openstack-cinder | 16:37 | |
scottda | Ok, well you two can battle it out for which patch we go with.... | 16:37 |
*** Julien-zte has quit IRC | 16:37 | |
scottda | But please check the Nova swap_volume call. | 16:37 |
*** Julien-zte has joined #openstack-cinder | 16:38 | |
scottda | Anything else about tests today? | 16:38 |
*** Julien-zte has quit IRC | 16:38 | |
erlon | scottda: hmm, I found some tests in tempest that worth to look on | 16:39 |
erlon | scottda: https://review.openstack.org/#/q/project:openstack/tempest+(message:volume+OR+message:cinder)+status:open+-status:merged | 16:39 |
*** Julien-zte has joined #openstack-cinder | 16:39 | |
*** Julien-zte has quit IRC | 16:40 | |
erlon | scottda: it seems a lot of people now and in the past have worked in some testing and just left the work | 16:40 |
*** Julien-zte has joined #openstack-cinder | 16:40 | |
erlon | scottda: so, some of the might be interesting to re-pick | 16:40 |
scottda | erlon: Yes. Thanks for cleaning all of those up. | 16:40 |
scottda | :) | 16:40 |
*** Julien-zte has quit IRC | 16:40 | |
*** Julien-zte has joined #openstack-cinder | 16:41 | |
erlon | scottda: haha, welcome, in advance :) | 16:41 |
erlon | scottda: ill have a look | 16:41 |
*** Julien-zte has quit IRC | 16:41 | |
scottda | I'm kidding, of course. But let me know if you are re-activating work on any, and I'll review. | 16:41 |
*** Julien-zte has joined #openstack-cinder | 16:42 | |
*** Julien-zte has quit IRC | 16:42 | |
* scottda notes his patch is at the top of the list | 16:42 | |
erlon | scottda: ill have a look in the list and ping you about the best ones we and do what we can afford to | 16:43 |
erlon | scottda: welcome again :) | 16:43 |
openstackgerrit | int32bit proposed openstack/python-cinderclient: Add snapshot-id filter to get volumes via cli https://review.openstack.org/416510 | 16:43 |
erlon | scottda: another point I was wondering weather we should pick some of that and move to our intree tests | 16:44 |
scottda | erlon: That could be a good idea (moving in-tree), as that may be why some languished in the review queue. | 16:45 |
smcginnis | +1 | 16:46 |
erlon | scottda: mhm, the bad side is that we loose the eyes of tempest core, but that's is hard to get anyways | 16:46 |
scottda | Yes, the "hard to get" part is what I'm talking about | 16:47 |
smcginnis | erlon: I'm sure if we merge something especially bad, we'll get their attention. ;) | 16:47 |
erlon | scottda: yeap | 16:47 |
smcginnis | scottda: Right, it's lack of attention I think that has prevented us from adding some of these tests. | 16:47 |
erlon | smcginnis: haha, yeah | 16:47 |
scottda | Or it they merge something especially bad... | 16:47 |
smcginnis | scottda: ;) | 16:48 |
scottda | OK, well thanks erlon . Keep us informed as to what you identify (if still in Tempest). | 16:48 |
scottda | I reckon we'll pay attention no matter what if you move them to cinder in-tree | 16:48 |
scottda | OK, anything else? | 16:49 |
xyang | so regarding tempest tests for groups, should I submit them in-tree or in tempest? | 16:50 |
*** salv-orlando has joined #openstack-cinder | 16:51 | |
scottda | xyang: Good question. | 16:51 |
smcginnis | xyang: Hmm, maybe try in tempest, and if there is resistance there move to in-tree? | 16:51 |
xyang | sure | 16:51 |
scottda | +1 | 16:51 |
erlon | scottda: sure, welcome | 16:51 |
smcginnis | We've talked about using our in-tree as kind of an incubator for tempest tests, but I think that one might be good to just go there. | 16:52 |
scottda | yup | 16:52 |
*** dustins_ has quit IRC | 16:52 | |
*** dustins has joined #openstack-cinder | 16:52 | |
xyang | @smcginnis: this one works for LVM, so should be okay I hope | 16:52 |
erlon | xyang: if you are getting good feedback, and they are ready to get merged Id recommend to leave there, otherewise move then to in-tree | 16:52 |
xyang | erlon: ok | 16:53 |
*** salv-orlando has quit IRC | 16:54 | |
scottda | OK, if there's anything else, chime in. Otherwise, thanks everyone | 16:55 |
*** salv-orlando has joined #openstack-cinder | 16:55 | |
smcginnis | Nothing here. Thanks scottda. | 16:55 |
scottda | #endmeeting | 16:55 |
openstack | Meeting ended Tue Jan 17 16:55:44 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:55 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/cinder_testing/2017/cinder_testing.2017-01-17-16.01.html | 16:55 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/cinder_testing/2017/cinder_testing.2017-01-17-16.01.txt | 16:55 |
openstack | Log: http://eavesdrop.openstack.org/meetings/cinder_testing/2017/cinder_testing.2017-01-17-16.01.log.html | 16:55 |
scottda | smcginnis: Did you see my question ^^ about putting the HA/AA and cinder-nova API test&review sprint on the meeting agenda? | 16:56 |
scottda | smcginnis: I could do it, but, of course, you have more Gravitas. | 16:56 |
smcginnis | scottda: Hah! | 16:56 |
smcginnis | scottda: Yeah, sorry, had to bring my daughter to the ortho and just got back half way through the meeting. I did intent to bring that up. | 16:56 |
scottda | cool | 16:57 |
*** stvnoyes has joined #openstack-cinder | 16:57 | |
scottda | Hope you daughter is ok. | 16:57 |
xyang | dulek: ping | 16:58 |
smcginnis | scottda: Yep, just normal check up. | 16:58 |
*** _ducttape_ has quit IRC | 16:59 | |
scottda | ok. So maybe orthodontist, not orthopedist :) | 16:59 |
*** ducttape_ has joined #openstack-cinder | 16:59 | |
smcginnis | Hah, right, orthodontist. Just the usual braces right of passage. | 17:00 |
*** markus_z has quit IRC | 17:00 | |
*** _ducttape_ has joined #openstack-cinder | 17:01 | |
*** oomichi has joined #openstack-cinder | 17:03 | |
*** ducttape_ has quit IRC | 17:04 | |
*** Apoorva has joined #openstack-cinder | 17:06 | |
*** raunak has joined #openstack-cinder | 17:15 | |
*** mvk has joined #openstack-cinder | 17:17 | |
*** yumiriam has quit IRC | 17:18 | |
*** yumiriam has joined #openstack-cinder | 17:18 | |
*** sudipto has quit IRC | 17:24 | |
*** sudipto_ has quit IRC | 17:24 | |
*** knomura has quit IRC | 17:25 | |
*** knomura has joined #openstack-cinder | 17:25 | |
*** david-lyle_ has joined #openstack-cinder | 17:26 | |
*** knomura has quit IRC | 17:30 | |
*** porrua has quit IRC | 17:30 | |
smcginnis | hemna: http://paste.openstack.org/show/595249/ | 17:32 |
*** david-lyle_ has quit IRC | 17:34 | |
*** lpetrut has quit IRC | 17:34 | |
*** Jack_Iv has quit IRC | 17:35 | |
*** bardia has joined #openstack-cinder | 17:35 | |
*** ociuhandu has joined #openstack-cinder | 17:37 | |
patrickeast | smcginnis: haha, that snapshot manage issue is like really having a hard time getting traction | 17:42 |
smcginnis | patrickeast: Kind of mind boggling. :) | 17:43 |
Swanson | The simple fix for everything being hosed that got kiboshed for no adequately explored reason? | 17:44 |
smcginnis | Yep | 17:44 |
patrickeast | thats the one! | 17:45 |
*** knomura has joined #openstack-cinder | 17:45 | |
patrickeast | maybe i'll go stir up trouble in the -qa channel... | 17:47 |
patrickeast | smcginnis: are you in that one? | 17:47 |
smcginnis | patrickeast: Hm, no, not currently. | 17:48 |
smcginnis | patrickeast: I think this one I'm fine "delegating" for now. :D | 17:48 |
Swanson | Fight! Fight! Fight! | 17:49 |
patrickeast | lol | 17:49 |
*** ociuhandu has quit IRC | 17:49 | |
*** ntpttr has quit IRC | 17:50 | |
hemna | smcginnis, where is hp in that ? | 17:50 |
patrickeast | smcginnis: i was going to add it to an agenda item on the qa-meeting but i have a conflict for the one this week :( | 17:51 |
smcginnis | hemna: Line 76? | 17:51 |
hemna | oh ok there it is | 17:51 |
hemna | 22% | 17:51 |
hemna | ouch | 17:51 |
smcginnis | hemna: Sadly, that's not one of the worse ones. | 17:52 |
hemna | don't we have to be 50% + 1 success rate? | 17:52 |
smcginnis | hemna: For now I've just been looking at the last successful run and making sure it wasn't the only successful run. | 17:52 |
*** ntpttr has joined #openstack-cinder | 17:52 | |
hemna | that's probably a low bar to set, but reasonable. all things considered at this point. | 17:53 |
hemna | Tintry 5% | 17:53 |
smcginnis | hemna: Yeah, at this point. | 17:53 |
smcginnis | hemna: Hopefully we can tighten that up eventually. | 17:53 |
smcginnis | hemna: That one was failing for a very long time, so in this case it's maybe OK since it just got back to stable. | 17:54 |
Apoorva | hemna smcginnis hopefully that % will go up for Tintri. Working on making it stable. | 17:54 |
smcginnis | Apoorva: +1! | 17:54 |
hemna | awesome | 17:54 |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Revert "Mark Tintri volume driver as unsupported" https://review.openstack.org/421407 | 17:59 |
smcginnis | Apoorva: Last few comments look good. Seems stable enough and you're involved, so I'm fine reverting that one already. | 17:59 |
*** timcl has quit IRC | 18:00 | |
Apoorva | smcginnis thanks! | 18:00 |
* hemna waits for CI | 18:00 | |
*** david-lyle_ has joined #openstack-cinder | 18:00 | |
*** porrua has joined #openstack-cinder | 18:00 | |
*** timcl has joined #openstack-cinder | 18:01 | |
*** lpetrut has joined #openstack-cinder | 18:02 | |
openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Refactor quota modules https://review.openstack.org/417257 | 18:05 |
*** knomura has quit IRC | 18:06 | |
*** knomura has joined #openstack-cinder | 18:06 | |
*** knomura has quit IRC | 18:11 | |
*** ociuhandu has joined #openstack-cinder | 18:11 | |
*** Jack_I has quit IRC | 18:11 | |
*** ociuhandu has quit IRC | 18:15 | |
*** Jack_I has joined #openstack-cinder | 18:17 | |
openstackgerrit | Helen Walsh proposed openstack/cinder: VMAX driver - Storage assisted volume migration. https://review.openstack.org/397862 | 18:18 |
*** xinli has joined #openstack-cinder | 18:22 | |
*** kambiz has quit IRC | 18:28 | |
*** adisky_ has quit IRC | 18:29 | |
*** xyang has quit IRC | 18:31 | |
*** chris_morrell has joined #openstack-cinder | 18:34 | |
*** chris_morrell has quit IRC | 18:35 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Fix volume manage https://review.openstack.org/421438 | 18:39 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Fix retype with migrate https://review.openstack.org/421439 | 18:40 |
geguileo | erlon: scottda ^ | 18:40 |
scottda | Cool, I'll look on a bit | 18:42 |
*** david-lyle has quit IRC | 18:47 | |
*** bardia has quit IRC | 18:49 | |
*** markvoelker has quit IRC | 18:49 | |
*** david-lyle_ has quit IRC | 18:50 | |
*** Jack_Iv has joined #openstack-cinder | 18:57 | |
*** porrua has quit IRC | 18:57 | |
*** porrua has joined #openstack-cinder | 18:58 | |
*** Jack_I has quit IRC | 18:59 | |
*** yumiriam has quit IRC | 19:00 | |
*** Jack_I has joined #openstack-cinder | 19:00 | |
*** Jack_Iv has quit IRC | 19:01 | |
*** xyang has joined #openstack-cinder | 19:01 | |
openstackgerrit | Alon Marx proposed openstack/cinder: Open the source code of ibm_storage driver https://review.openstack.org/404958 | 19:03 |
*** Jack_V has joined #openstack-cinder | 19:05 | |
bswartz | smcginnis: would appreciate -1 from you here: https://review.openstack.org/#/c/369749 | 19:06 |
*** Jack_I has quit IRC | 19:06 | |
smcginnis | bswartz: Gladly | 19:06 |
*** Jack_I has joined #openstack-cinder | 19:09 | |
*** Jack_Iv has joined #openstack-cinder | 19:10 | |
*** Jack_V has quit IRC | 19:11 | |
*** Jack_I has quit IRC | 19:11 | |
*** Jack_I has joined #openstack-cinder | 19:12 | |
*** Jack_Iv has quit IRC | 19:13 | |
*** jose-phillips has joined #openstack-cinder | 19:13 | |
*** Jack_V has joined #openstack-cinder | 19:14 | |
*** Jack_I has quit IRC | 19:17 | |
*** lamt has quit IRC | 19:27 | |
*** lamt has joined #openstack-cinder | 19:28 | |
*** lamt has quit IRC | 19:28 | |
*** ChubYann has joined #openstack-cinder | 19:37 | |
*** tommylikehu has quit IRC | 19:40 | |
*** jordanP has quit IRC | 19:49 | |
*** david-lyle has joined #openstack-cinder | 19:50 | |
*** bardia_ has joined #openstack-cinder | 19:51 | |
*** timcl has quit IRC | 19:55 | |
*** Jack_V has quit IRC | 19:55 | |
bswartz | smcginnis: ty | 20:08 |
bswartz | smcginnis: they're covering that one in the TC meeting now | 20:08 |
smcginnis | bswartz: Yep, watching. | 20:09 |
*** e0ne has joined #openstack-cinder | 20:10 | |
*** salv-orlando has quit IRC | 20:11 | |
*** timcl has joined #openstack-cinder | 20:13 | |
*** xyang has quit IRC | 20:18 | |
*** xyang has joined #openstack-cinder | 20:20 | |
*** mtanino has joined #openstack-cinder | 20:28 | |
*** lpetrut has quit IRC | 20:47 | |
*** lpetrut has joined #openstack-cinder | 20:49 | |
Swanson | What if the Cinder Back Neds are LVM? What then? | 20:50 |
smcginnis | Swanson: I read that a few times and still have no idea what you're saying. | 20:52 |
Swanson | I smell toast! | 20:52 |
bswartz | s/Neds/Ends/ | 20:52 |
* smcginnis slowly walks away | 20:53 | |
smcginnis | bswartz: You're trying to apply logic to something Swanson said. Down that path lies madness, trust me. :) | 20:53 |
ildikov | smcginnis: LOL | 20:54 |
bswartz | I see | 20:54 |
Swanson | To illustrate smcginnis point, I did mean Neds. | 20:54 |
smcginnis | bswartz: See? | 20:54 |
bswartz | is it possible that Swanson is just an irc bot? | 20:54 |
smcginnis | bswartz: If I didn't know him, I would think so too. | 20:55 |
smcginnis | Some weird cross between a chaos monkey and an IRC bot. | 20:55 |
Swanson | My other job is as a twitter bot. | 20:55 |
bswartz | alexa with fuzz testing turned on? | 20:55 |
smcginnis | :) | 20:55 |
smcginnis | Swanson: Ghost writer for Trumps account? :D | 20:56 |
Swanson | BOTS GET SUCH ABSUE FROM THE MAINSTREAM MEDIA. ITCHY! | 20:57 |
smcginnis | Nailed it. | 20:57 |
*** porrua has quit IRC | 21:00 | |
*** ducttape_ has joined #openstack-cinder | 21:01 | |
*** jdurgin has quit IRC | 21:03 | |
*** _ducttape_ has quit IRC | 21:04 | |
*** alyson_ has quit IRC | 21:07 | |
*** dave-mccowan has quit IRC | 21:09 | |
hemna | asking for eyes...... https://review.openstack.org/#/c/404958/ | 21:13 |
*** lpetrut has quit IRC | 21:13 | |
* smcginnis looks for hemna's picture of eye balls... | 21:15 | |
hemna | https://goo.gl/ejiAeD | 21:15 |
smcginnis | lol | 21:17 |
*** ducttape_ has quit IRC | 21:17 | |
*** cdelatte has quit IRC | 21:17 | |
*** ducttape_ has joined #openstack-cinder | 21:17 | |
*** xyang has quit IRC | 21:18 | |
*** xyang has joined #openstack-cinder | 21:20 | |
*** lamt has joined #openstack-cinder | 21:21 | |
*** jdurgin has joined #openstack-cinder | 21:22 | |
*** adrianofr has quit IRC | 21:29 | |
*** xinli has quit IRC | 21:31 | |
* patrickeast is confused | 21:32 | |
patrickeast | anyone know how our objects are lazy loading things that might be null? | 21:33 |
patrickeast | looking at this method https://github.com/openstack/cinder/blob/master/cinder/objects/snapshot.py#L219 | 21:33 |
smcginnis | patrickeast: It's blowing up there? | 21:34 |
patrickeast | if i try and look at the snapshot["group_snapshot"] | 21:34 |
patrickeast | the db call to look it up by id is coming back with an exception, because it isn't in a group | 21:34 |
patrickeast | which seems right | 21:34 |
patrickeast | but the object call then raises the exception instead of just returning null | 21:34 |
patrickeast | or None, or whatever | 21:34 |
patrickeast | we even specify it can be None https://github.com/openstack/cinder/blob/master/cinder/objects/snapshot.py#L70 | 21:35 |
smcginnis | Hmm, not sure on that. | 21:35 |
*** xyang has quit IRC | 21:36 | |
patrickeast | oh hmm it blows up for "cgsnapshot" too | 21:37 |
patrickeast | i wonder if its supposed to actually support this or not | 21:37 |
*** xyang has joined #openstack-cinder | 21:37 | |
smcginnis | I think that nullable=True has more to do with the database than the objects. | 21:38 |
patrickeast | yea | 21:38 |
*** xyang has quit IRC | 21:38 | |
*** xyang has joined #openstack-cinder | 21:39 | |
smcginnis | But it does seem if it's nullable, we should just be able to get back null and not blow up. | 21:39 |
patrickeast | it kinda looks like those calls should be wrapped with try/catch blocks and just set the value to None | 21:39 |
smcginnis | patrickeast: You may be right. | 21:39 |
patrickeast | maybe i'll put a patch together and let dulek and geguileo look at it when they are up and around | 21:39 |
patrickeast | fix it for now and figure out if its the "right" way later | 21:40 |
*** xyang has quit IRC | 21:40 | |
*** crose has quit IRC | 21:41 | |
smcginnis | patrickeast: That sounds like a decent plan. It would be good to get their take on it. | 21:41 |
patrickeast | smcginnis: oo yea, we do the same kind of thing on the volume object with the glance meta data | 21:45 |
patrickeast | neato | 21:46 |
patrickeast | easy fix then | 21:46 |
smcginnis | patrickeast: So we have to do that for each object? | 21:49 |
*** timcl has quit IRC | 21:49 | |
*** e0ne has quit IRC | 21:49 | |
patrickeast | smcginnis: yea, but i think its the minority of attributes we have to deal with like this | 21:49 |
patrickeast | smcginnis: just the ones that are links to other objects and are OK to be null | 21:49 |
smcginnis | patrickeast: Hmm, I guess. Just another little detail to have to be aware of and look out for though. | 21:50 |
*** timcl has joined #openstack-cinder | 21:50 | |
patrickeast | smcginnis: yea : / | 21:50 |
*** cknight has quit IRC | 21:52 | |
*** diablo_rojo has quit IRC | 21:54 | |
*** gouthamr has quit IRC | 22:01 | |
*** harlowja has quit IRC | 22:01 | |
*** xinli has joined #openstack-cinder | 22:02 | |
*** dustins has quit IRC | 22:10 | |
*** alonmarx_ has quit IRC | 22:12 | |
*** viks has joined #openstack-cinder | 22:17 | |
*** catintheroof has quit IRC | 22:20 | |
Apoorva | smcginnis what does "36 days" signify in <last success: 2016-12-12 11:48:54 (36 days, 5:26:19 old)> from http://paste.openstack.org/show/595249/ | 22:23 |
smcginnis | Apoorva: That it's been 36 days since the last time there was a successful run reported. | 22:24 |
Apoorva | smcginnis In that case Blockbridge EPS CI is out for 48 days and shows 100% success rate? #confused | 22:25 |
smcginnis | Apoorva: 100% of the times when it was reporting was successful. | 22:28 |
*** thiagolib has quit IRC | 22:28 | |
*** salv-orlando has joined #openstack-cinder | 22:28 | |
openstackgerrit | Karthik Prabhu Vinod proposed openstack/cinder: Switch ManageableSnaphots & ManageableVolumes list to OVO https://review.openstack.org/388783 | 22:29 |
Apoorva | smcginnis got it. thanks | 22:29 |
*** tlian has quit IRC | 22:34 | |
*** xyang has joined #openstack-cinder | 22:35 | |
*** xyang has quit IRC | 22:36 | |
*** kfarr has quit IRC | 22:38 | |
*** david-lyle has quit IRC | 22:51 | |
_alastor_ | I'm struggling a bit to get Cinder backed images working in Glance. Does anyone have an example glance.conf or local.conf I could use to get my devstack instance working with it? | 22:56 |
_alastor_ | I keep hitting an "Unauthorized" error in glance and I've tried every username/password/auth_url combination I can think of | 22:57 |
*** xyang has joined #openstack-cinder | 22:57 | |
_alastor_ | I've been working off this page: http://docs.openstack.org/admin-guide/blockstorage-volume-backed-image.html | 22:57 |
*** tlian has joined #openstack-cinder | 22:58 | |
*** xyang has quit IRC | 22:59 | |
*** david-lyle has joined #openstack-cinder | 23:03 | |
*** ducttape_ has quit IRC | 23:07 | |
*** david-lyle has quit IRC | 23:10 | |
*** tommylikehu_ has joined #openstack-cinder | 23:11 | |
*** tommylikehu_ has quit IRC | 23:11 | |
*** tommylik_ has joined #openstack-cinder | 23:11 | |
*** tommylik_ has quit IRC | 23:12 | |
patrickeast | _alastor_: i haven't tried the glance backend for a while, its totally possible it doesn't work anymore :( | 23:12 |
patrickeast | _alastor_: i don't think there are any ci jobs that run with it, only the cache in cinder | 23:12 |
openstackgerrit | Patrick East proposed openstack/cinder: Switch to using generic groups with Pure driver https://review.openstack.org/416854 | 23:12 |
openstackgerrit | Patrick East proposed openstack/cinder: Allow snapshots and volumes to have Null group values https://review.openstack.org/421576 | 23:12 |
_alastor_ | patrickeast: Well, considering how much the SEs want this, if the feature is broken (not THAT it is, just IF it is) I'll be fixing it :) | 23:14 |
*** lamt has quit IRC | 23:15 | |
_alastor_ | patrickeast: Do you know how to force glance to use v2 API? Currently everything seems to be going through v1 which was deprecated in Newton | 23:16 |
patrickeast | _alastor_: i think there is glance_api_version in cinder.conf that can be set | 23:17 |
*** knomura has joined #openstack-cinder | 23:18 | |
_alastor_ | patrickeast: seems weird that the glance api version would be set by cinder.... | 23:18 |
patrickeast | _alastor_: i guess it depends on what you want, if you want cinder to use the v2 api when i calls glance thats the one since its configuring the glance client code in c-* services, if you want glance itself to run exposing a different version then i think it would require changes to glance configs | 23:20 |
patrickeast | s/when i/when it/ | 23:20 |
*** asettle has quit IRC | 23:20 | |
patrickeast | left alone cinder will always use v1 i think | 23:20 |
patrickeast | i remember having some issues with this a while back trying to get different v2 exposed properties on the images | 23:21 |
*** salv-orlando has quit IRC | 23:21 | |
_alastor_ | well, I'm going to say v2 probably doesn't work. Have a gander at that stack trace: http://paste.openstack.org/show/595294/ | 23:22 |
*** knomura has quit IRC | 23:22 | |
*** xyang has joined #openstack-cinder | 23:24 | |
patrickeast | yea that doesn't look so great | 23:26 |
*** xyang has quit IRC | 23:27 | |
*** gouthamr has joined #openstack-cinder | 23:27 | |
*** sdague has quit IRC | 23:28 | |
*** xinli has quit IRC | 23:30 | |
*** s-shiono has joined #openstack-cinder | 23:31 | |
*** s-shiono_ has joined #openstack-cinder | 23:46 | |
*** stakeda has quit IRC | 23:47 | |
*** s-shiono has quit IRC | 23:48 | |
*** dave-mccowan has joined #openstack-cinder | 23:51 | |
*** rajinir has quit IRC | 23:56 | |
openstackgerrit | Raunak Kumar proposed openstack/cinder: Fix for live migration for Nimble Storage https://review.openstack.org/420214 | 23:58 |
*** stakeda has joined #openstack-cinder | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!