Thursday, 2017-01-26

*** gouthamr has joined #openstack-cinder00:02
*** catintheroof has quit IRC00:03
*** esker has quit IRC00:05
jgriffith^^ bahh... stupid stupid stupid.  One more thing to fix00:06
*** ducttape_ has quit IRC00:08
*** s-shiono has joined #openstack-cinder00:09
*** diablo_rojo_phon has quit IRC00:10
*** boltR has joined #openstack-cinder00:18
boltRhello00:18
boltRi'm trying to understand cinder's usage of ceph00:18
boltRit seems like ceph df doesn't show much of a difference if I allocate volumes00:18
boltRis there some kind of optimization that ceph/cinder is doing?00:19
*** s-shiono_ has joined #openstack-cinder00:19
*** s-shiono has quit IRC00:21
*** ducttape_ has joined #openstack-cinder00:24
*** raunak has quit IRC00:28
*** esker has joined #openstack-cinder00:30
*** stakeda has joined #openstack-cinder00:34
*** cknight has joined #openstack-cinder00:40
*** raunak has joined #openstack-cinder00:42
*** raunak has quit IRC00:42
*** raunak has joined #openstack-cinder00:45
*** cknight has quit IRC00:46
*** esker has quit IRC00:49
*** dave-mcc_ has joined #openstack-cinder00:50
*** dave-mccowan has quit IRC00:53
*** knomura has joined #openstack-cinder00:59
*** esker has joined #openstack-cinder01:01
*** knomura has quit IRC01:03
*** ducttape_ has quit IRC01:06
*** Apoorva has quit IRC01:07
*** chenying has quit IRC01:11
*** chenying has joined #openstack-cinder01:11
*** esker has quit IRC01:13
*** shaner has quit IRC01:16
*** dave-mccowan has joined #openstack-cinder01:20
*** dave-mcc_ has quit IRC01:22
openstackgerritRaunak Kumar proposed openstack/cinder: Fix Qos for clone for Nimble Storage Driver  https://review.openstack.org/42493301:24
*** ksumit has joined #openstack-cinder01:25
*** catintheroof has joined #openstack-cinder01:44
*** rajinir has quit IRC01:46
*** catintheroof has quit IRC01:49
*** erlon has quit IRC01:50
*** reduxio has joined #openstack-cinder01:54
*** dave-mcc_ has joined #openstack-cinder01:57
*** raunak has quit IRC01:57
*** reduxio has quit IRC01:58
*** dave-mccowan has quit IRC01:59
*** raunak has joined #openstack-cinder02:02
*** kaisers_ has joined #openstack-cinder02:03
*** bardia has joined #openstack-cinder02:05
*** kaisers has quit IRC02:07
*** cdelatte has quit IRC02:11
*** ducttape_ has joined #openstack-cinder02:19
*** dansmith has quit IRC02:20
*** dansmith has joined #openstack-cinder02:21
*** Jack_Iv has joined #openstack-cinder02:22
*** mtanino has quit IRC02:23
*** ducttape_ has quit IRC02:24
*** Jack_Iv has quit IRC02:26
*** shaner has joined #openstack-cinder02:38
*** jose-phillips has quit IRC02:44
*** raunak has quit IRC02:47
*** thingee has quit IRC02:55
*** sage_ has quit IRC03:00
*** bkopilov has quit IRC03:00
*** dinob has quit IRC03:01
*** sage has joined #openstack-cinder03:02
openstackgerritMerged openstack/cinder: Switch ManageableSnaphots & ManageableVolumes list to OVO  https://review.openstack.org/38878303:05
openstackgerritMerged openstack/cinder: Fix the api-ref CI failure  https://review.openstack.org/42441103:06
*** markvoelker has joined #openstack-cinder03:07
*** bardia has quit IRC03:13
jgriffithwell this is annoying:  openstack: 'volume type create --property volume_backend_name=lvmdriver-1 lvmdriver-1' is not an openstack command. See 'openstack --help'.03:13
*** thingee has joined #openstack-cinder03:22
*** markvoelker has quit IRC03:23
*** newmember has quit IRC03:23
*** rushil has quit IRC03:23
*** pbandark has joined #openstack-cinder03:31
*** markvoelker has joined #openstack-cinder03:33
*** nicolasbock has quit IRC03:39
*** ducttape_ has joined #openstack-cinder03:40
*** rushil has joined #openstack-cinder03:41
*** esker has joined #openstack-cinder03:46
*** gcb has joined #openstack-cinder03:50
*** reduxio has joined #openstack-cinder03:56
*** esker has quit IRC03:59
*** ducttape_ has quit IRC04:00
*** reduxio has quit IRC04:00
*** psachin has joined #openstack-cinder04:03
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/42551904:13
*** ducttape_ has joined #openstack-cinder04:22
*** Lee1092 has joined #openstack-cinder04:27
*** bkopilov has joined #openstack-cinder04:28
*** dave-mcc_ has quit IRC04:32
*** ducttape_ has quit IRC04:34
*** Jack_Iv has joined #openstack-cinder04:38
*** cristicalin has joined #openstack-cinder04:42
openstackgerritwangxiyuan proposed openstack/cinder: [api-ref]Change tenant to project  https://review.openstack.org/41773904:42
*** Jack_Iv has quit IRC04:43
*** SamYaple has joined #openstack-cinder04:43
*** JiaMin_ has joined #openstack-cinder04:44
*** Jack_Iv has joined #openstack-cinder04:49
*** d-bark has joined #openstack-cinder04:49
*** mdnadeem has joined #openstack-cinder04:50
*** raunak has joined #openstack-cinder04:51
*** diablo_rojo has quit IRC04:56
*** alonmarx has joined #openstack-cinder05:01
*** cburgess has quit IRC05:01
jgriffithsmcginnis ildikov So I tried to fix up the show on the client and get to the bottom of the gate failure; sadly though after the earlier rebase I"m hitting something odd with trying to use any of the V3 commands.05:04
jgriffithas in "they don't work"05:04
*** Guest58531 has quit IRC05:04
jgriffithI get "ERROR: 'module' object has no attribute 'service_type'05:04
jgriffithand frankly I am out of time for this evening, but I'll pick it up once again in the AM05:05
ildikovjgriffith: hmm05:05
*** knomura has joined #openstack-cinder05:05
jgriffithildikov ??  Shouldn't you be asleep or something?05:05
*** d-bark has quit IRC05:06
jgriffithThere was a batch of changes on the 23'rd including a chage to the service_type decorator05:07
jgriffithbut I havne't dug in to it yet05:07
ildikovjgriffith: to be honest with #9 show worked for me yeterday05:07
*** cburgess has joined #openstack-cinder05:07
*** mgagne has joined #openstack-cinder05:07
*** mgagne is now known as Guest3353905:07
jgriffithildikov yeah; so prior to me rebasing they all worked05:07
jgriffithildikov I hadn't rebased off of master for the client since I started this :)05:07
ildikovjgriffith: a fix on the server side got merged yesterday, that might have something to do with this?05:08
jgriffithbut I rebased earlier, did some other tests with master (not my patch) and the problem is that V3 calls just don't work05:08
ildikovjgriffith: hmm, I didn't do that either :)05:08
*** cristicalin has quit IRC05:08
jgriffithnothing to do with my specific patch at all, V3 is broken05:08
jgriffithand we don't test it so not surprising I suppose05:09
ildikovjgriffith: oh, isn't there smth microversioning related merged lately?05:09
jgriffithe0ne might have som insight as he did some work in there day before yesterday (or merged then anyway)05:09
jgriffithildikov yup05:09
jgriffith:)05:09
*** knomura has quit IRC05:10
ildikovjgriffith: ok :)05:10
jgriffithV2 cmds still work, V3 cmds are broken05:10
ildikovjgriffith: I will not rebase then... :)05:10
jgriffithildikov good idea :)05:10
*** Jack_Iv has quit IRC05:12
*** raunak has quit IRC05:13
ildikovjgriffith: TBH it always seem to be a temptingly good idea :)05:13
jgriffithildikov yeah, but you can only avoid it for so long :)05:14
jgriffithAhhh!05:15
jgriffithWait, I think I know the problem05:15
jgriffithhaha, Yup... ok, that was actually easy05:16
ildikovjgriffith: did you see the comments from Brian on your patch?05:16
jgriffithno05:16
jgriffithhaha.. well there ya go05:16
jgriffithgeesh05:16
ildikovjgriffith: he is suggesting to remove a decorator, but I guess that's what you  did :)05:16
*** raunak has joined #openstack-cinder05:17
jgriffithNot only is it "ok" to remove them, they MUST be removed :)05:17
jgriffithyes05:17
jgriffithlol05:17
ildikovlol :)05:17
*** Jack_Iv has joined #openstack-cinder05:27
*** cristicalin has joined #openstack-cinder05:30
*** nkrinner_afk is now known as nkrinner05:35
openstackgerritJohn Griffith proposed openstack/python-cinderclient: Attach/Detach V2  https://review.openstack.org/38771605:35
*** Jack_Iv has quit IRC05:36
*** mdnadeem has quit IRC05:36
*** cristicalin has quit IRC05:40
*** Jack_Iv_ has joined #openstack-cinder05:41
*** mdnadeem has joined #openstack-cinder05:48
*** ducttape_ has joined #openstack-cinder05:50
*** ducttape_ has quit IRC05:55
*** reduxio has joined #openstack-cinder05:58
*** gouthamr has quit IRC06:00
*** reduxio has quit IRC06:02
*** Jack_Iv has joined #openstack-cinder06:02
*** kaisers_ has quit IRC06:02
*** mdnadeem has quit IRC06:02
*** mdnadeem has joined #openstack-cinder06:02
*** rushil has quit IRC06:04
*** Jack_Iv_ has quit IRC06:06
*** yangyapeng has quit IRC06:10
*** alonmarx has quit IRC06:12
*** x00350071_ is now known as edisonxiang06:13
*** raunak has quit IRC06:14
*** zhangguoqing has joined #openstack-cinder06:15
*** raunak has joined #openstack-cinder06:19
*** alonma has quit IRC06:25
*** alonma has joined #openstack-cinder06:26
*** adisky_ has joined #openstack-cinder06:34
*** mjura has joined #openstack-cinder06:34
*** Jack_Iv_ has joined #openstack-cinder06:35
*** Jack_Iv has quit IRC06:39
*** Jack_Iv_ has quit IRC06:41
*** Jack_V has joined #openstack-cinder06:42
*** e0ne has joined #openstack-cinder06:45
*** e0ne has quit IRC06:46
*** reduxio has joined #openstack-cinder06:50
*** e0ne has joined #openstack-cinder06:50
*** e0ne has quit IRC06:53
*** ksumit has quit IRC06:55
*** ChubYann has quit IRC06:55
*** e0ne has joined #openstack-cinder06:57
*** e0ne has quit IRC07:00
*** kaisers has joined #openstack-cinder07:03
*** e0ne has joined #openstack-cinder07:04
*** arne_r has joined #openstack-cinder07:04
*** e0ne has quit IRC07:09
*** lkuchlan has joined #openstack-cinder07:09
*** yangyapeng has joined #openstack-cinder07:10
*** tesseract has joined #openstack-cinder07:11
*** e0ne has joined #openstack-cinder07:12
*** e0ne has quit IRC07:14
*** yangyapeng has quit IRC07:15
*** rha has quit IRC07:17
*** e0ne has joined #openstack-cinder07:18
*** ducttape_ has joined #openstack-cinder07:21
*** AlexeyAbashkin has joined #openstack-cinder07:22
*** ducttape_ has quit IRC07:26
*** lennyb has quit IRC07:27
*** lennyb has joined #openstack-cinder07:28
*** isaacb has joined #openstack-cinder07:33
*** kaisers has quit IRC07:33
*** kaisers has joined #openstack-cinder07:36
*** rha has joined #openstack-cinder07:36
*** rha has quit IRC07:37
*** rha has joined #openstack-cinder07:37
*** kaisers has quit IRC07:40
*** Jack_Iv has joined #openstack-cinder07:42
openstackgerritMerged openstack/cinder: Remove race conditions from transfer API  https://review.openstack.org/25749507:43
*** raunak has quit IRC07:44
*** kaisers has joined #openstack-cinder07:45
*** kaisers has quit IRC07:49
*** kaisers has joined #openstack-cinder07:52
*** yangyapeng has joined #openstack-cinder07:55
*** e0ne has quit IRC07:59
*** markvoelker has quit IRC08:12
*** Jack_Iv has quit IRC08:15
*** markvoelker has joined #openstack-cinder08:15
*** JiaMin_ has quit IRC08:17
*** lkuchlan has quit IRC08:19
*** lkuchlan has joined #openstack-cinder08:20
*** Zer0Byte has joined #openstack-cinder08:22
openstackgerritJohnnyChou proposed openstack/cinder: Enhance Infortrend driver  https://review.openstack.org/39428408:23
*** rha has quit IRC08:23
*** rha has joined #openstack-cinder08:25
*** rha has quit IRC08:25
*** rha has joined #openstack-cinder08:25
*** stakeda has quit IRC08:26
*** s-shiono_ has quit IRC08:34
*** reduxio has quit IRC08:35
*** reduxio has joined #openstack-cinder08:35
openstackgerritMerged openstack/cinder: Dell SC: Logging asyncTask if XML returned  https://review.openstack.org/42276308:38
openstackgerritMerged openstack/cinder: Open the source code of ibm_storage driver  https://review.openstack.org/40495808:38
*** reduxio has quit IRC08:40
openstackgerritwangxiyuan proposed openstack/cinder: [api-ref]Change tenant to project  https://review.openstack.org/41773908:43
openstackgerritwangxiyuan proposed openstack/cinder: [api-ref]Change tenant to project  https://review.openstack.org/41773908:44
*** ducttape_ has joined #openstack-cinder08:48
*** reduxio has joined #openstack-cinder08:56
openstackgerritMerged openstack/cinder: NFS snapshots  https://review.openstack.org/14718608:58
openstackgerritMerged openstack/cinder: Make CappedVersionUnknown exception more useful  https://review.openstack.org/42463808:58
openstackgerritMerged openstack/cinder: Brcd zonemanager: Fix unstable command generation  https://review.openstack.org/42428408:58
openstackgerritMerged openstack/cinder: Tests: Fix mock for vzstorage remotefs  https://review.openstack.org/42525608:58
openstackgerritMerged openstack/cinder: Add assert_min_rpc_version decorator  https://review.openstack.org/42466908:58
*** zzzeek has quit IRC09:00
*** zzzeek has joined #openstack-cinder09:00
openstackgerritTakashi Menjo proposed openstack/cinder: Revert "Mark the sheepdog driver as unsupported"  https://review.openstack.org/42558609:00
*** e0ne has joined #openstack-cinder09:01
*** AlexeyAbashkin has quit IRC09:10
*** tommylikehu has quit IRC09:14
*** Zer0Byte has quit IRC09:18
openstackgerritMerged openstack/cinder: Don't drop the volume type's extra spec at DB layer  https://review.openstack.org/40903009:22
*** alonma has quit IRC09:23
*** alonma has joined #openstack-cinder09:23
*** alonma has quit IRC09:24
*** alonma has joined #openstack-cinder09:25
*** e0ne has quit IRC09:27
*** tommylikehu has joined #openstack-cinder09:29
*** reduxio has quit IRC09:34
*** reduxio has joined #openstack-cinder09:35
*** zhangguoqing has quit IRC09:35
*** reduxio has quit IRC09:37
*** gcb has quit IRC09:37
*** reduxio has joined #openstack-cinder09:37
*** e0ne has joined #openstack-cinder09:40
openstackgerritJohnnyChou proposed openstack/cinder: Enhance Infortrend driver  https://review.openstack.org/39428409:45
*** mvk has quit IRC09:47
*** gcb has joined #openstack-cinder09:50
*** yumiriam has joined #openstack-cinder09:50
*** aarefiev_afk is now known as aarefiev09:55
*** isaacb has quit IRC10:01
*** isaacb has joined #openstack-cinder10:03
*** jordanP has joined #openstack-cinder10:05
*** alyson_ has joined #openstack-cinder10:08
*** Jack_Iv has joined #openstack-cinder10:12
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/42551910:17
*** Jack_Iv has quit IRC10:17
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Check if volume node has enough space for image operations  https://review.openstack.org/41586810:19
*** alonma has quit IRC10:24
*** alonma has joined #openstack-cinder10:25
*** alonma has quit IRC10:29
*** alonma has joined #openstack-cinder10:31
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Check if volume node has enough space for image operations  https://review.openstack.org/41586810:33
*** alonma has quit IRC10:35
*** alonma has joined #openstack-cinder10:42
*** alonma has quit IRC10:46
*** lpetrut has joined #openstack-cinder10:51
*** isaacb has quit IRC10:52
*** alonma has joined #openstack-cinder10:52
*** isaacb has joined #openstack-cinder10:53
*** dalgaaf has quit IRC10:55
*** lpetrut has quit IRC10:55
openstackgerritGorka Eguileor proposed openstack/cinder: Small change to microversion header on devref  https://review.openstack.org/42562910:57
*** dalgaaf has joined #openstack-cinder10:59
*** isaacb has quit IRC11:03
*** kaisers has quit IRC11:04
*** kaisers has joined #openstack-cinder11:05
*** Jack_Iv has joined #openstack-cinder11:05
*** kaisers_ has joined #openstack-cinder11:08
*** reduxio has quit IRC11:09
*** kaisers has quit IRC11:09
*** reduxio has joined #openstack-cinder11:09
*** kaisers_ has quit IRC11:12
*** alonma has quit IRC11:13
*** alonma has joined #openstack-cinder11:13
*** reduxio has quit IRC11:14
*** openstackgerrit has quit IRC11:17
*** alonma has quit IRC11:18
*** adisky_ has quit IRC11:19
*** alonma has joined #openstack-cinder11:19
*** alonma has quit IRC11:24
*** reduxio has joined #openstack-cinder11:25
*** alonma has joined #openstack-cinder11:30
*** alonma has quit IRC11:35
*** reduxio has quit IRC11:38
*** alonma has joined #openstack-cinder11:42
*** gcb has quit IRC11:43
*** openstackgerrit has joined #openstack-cinder11:43
openstackgerritKazumasa Nomura proposed openstack/cinder: Specify the ports for compute nodes and copy functions in VSP drivers  https://review.openstack.org/41407611:43
*** nicolasbock has joined #openstack-cinder11:43
*** alonma has quit IRC11:46
*** Jack_Iv has quit IRC11:47
*** reduxio has joined #openstack-cinder11:48
*** ociuhandu has quit IRC11:48
*** alonma has joined #openstack-cinder11:50
*** tommylikehu_ has joined #openstack-cinder11:50
*** isaacb has joined #openstack-cinder11:51
openstackgerritGorka Eguileor proposed openstack/cinder: Refactor volumes summary  https://review.openstack.org/42564311:55
*** lpetrut has joined #openstack-cinder11:59
*** arne_r has quit IRC12:02
*** liverpooler has quit IRC12:03
openstackgerritKazumasa Nomura proposed openstack/cinder: Restrain the unmanage snapshot for the VSP drivers  https://review.openstack.org/42109512:03
*** arne_r has joined #openstack-cinder12:05
*** bkopilov has quit IRC12:05
*** mvk has joined #openstack-cinder12:16
*** sofie has quit IRC12:18
*** zhangguoqing has joined #openstack-cinder12:18
openstackgerritKazumasa Nomura proposed openstack/cinder: Restrain the unmanage snapshot for the VSP drivers  https://review.openstack.org/42109512:26
*** erlon has joined #openstack-cinder12:27
*** catintheroof has joined #openstack-cinder12:27
*** ociuhandu has joined #openstack-cinder12:28
*** alonma has quit IRC12:29
openstackgerritGorka Eguileor proposed openstack/cinder: Fix api-ref status parameter  https://review.openstack.org/42565612:29
*** alonma has joined #openstack-cinder12:30
*** kaisers has joined #openstack-cinder12:32
*** DineshBhor has joined #openstack-cinder12:34
geguileodulek: trivial spureous test: https://review.openstack.org/#/c/425103/12:36
*** kaisers has quit IRC12:37
*** mjura has quit IRC12:38
*** catintheroof has quit IRC12:38
*** catintheroof has joined #openstack-cinder12:38
dulekgeguileo: data=actual_data - why not data=mock.ANY if we've already checked that?12:38
dulekIt seems odd to get the value from mock and then check it. ;)12:39
geguileodulek: I only use mock.ANY when I really don't know or don't care about the value12:39
geguileodulek: But in this case I care and I know the value12:39
geguileodulek: so it kind of made more sense to me12:39
openstackgerritMerged openstack/cinder: Test: Fix assert_has_calls dict order bug (QoS)  https://review.openstack.org/42421412:40
dulekgeguileo: TBH it's not important at all.12:40
*** mjura has joined #openstack-cinder12:40
geguileodulek: Oh, but I understand the question12:40
geguileoit's a reasonable question  :-12:41
geguileo)12:41
dulekNitpicking a quick test fix isn't. :P12:41
geguileolol12:42
*** kaisers has joined #openstack-cinder12:42
*** DineshBhor has quit IRC12:43
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/42551912:49
*** catinthe_ has joined #openstack-cinder12:57
Jack_VHi Folks12:57
Jack_VCider ignores glance_catalog_info and glance_api_version options12:58
*** catintheroof has quit IRC12:59
Jack_Vglance_catalog_info = image:glance:internalURL12:59
Jack_Vglance_api_version = 212:59
Jack_Vbut in logs, cinder-scheduler is using publicURL for some reason12:59
Jack_VI also tried glance_api_servers = http://lglance_api:9292/13:01
*** d-bark has joined #openstack-cinder13:01
Jack_Vopenstack-cinder-9.1.0-2.el7.noarch13:02
Jack_Vpython-cinder-9.1.0-2.el7.noarch13:02
Jack_Vpython2-cinderclient-1.9.0-1.el7.noarch13:02
Jack_Vany info?13:04
openstackgerritAlon Marx proposed openstack/cinder: create consistency group mishandles types  https://review.openstack.org/42449213:09
*** kfarr has joined #openstack-cinder13:10
*** markvoelker has quit IRC13:14
*** lseki has joined #openstack-cinder13:17
*** zhangguoqing has quit IRC13:17
*** zhangguoqing has joined #openstack-cinder13:17
*** tommylikehu_ has quit IRC13:28
*** tommylikehu_ has joined #openstack-cinder13:28
*** lpetrut has quit IRC13:42
*** isaacb has quit IRC13:43
*** bkopilov has joined #openstack-cinder13:45
*** lkuchlan has quit IRC13:49
*** esker has joined #openstack-cinder13:50
*** alonma has quit IRC13:51
*** alonma has joined #openstack-cinder13:51
*** ducttape_ has quit IRC13:53
*** eharney has quit IRC13:55
*** dustins|out is now known as dustins13:55
*** alonma has quit IRC13:55
*** alonma has joined #openstack-cinder13:56
*** isaacb has joined #openstack-cinder13:57
*** kfarr has quit IRC14:02
*** cknight has joined #openstack-cinder14:04
*** esker has quit IRC14:06
*** eantyshev has joined #openstack-cinder14:08
eantyshevHello! I got questions about https://review.openstack.org/#/c/147186/50/cinder/volume/drivers/remotefs.py, as it breaks _do_create_snapshot in almost every scenario, but gate didn't notice14:11
eantyshevspecifically, it adds double call to "qemu-img create", which fails in our Storage CI14:12
scottdaeantyshev: That sounds like a bug. Could you file a bug in Launchpad?14:13
scottdaeantyshev: And it sounds like you know the root cause....14:13
eantyshevI think I do14:13
scottdaeantyshev: Well, you could post a patch as well.14:13
*** ducttape_ has joined #openstack-cinder14:13
openstackgerritHelen Walsh proposed openstack/cinder: VMAX driver - removed incorrect six.text_type  https://review.openstack.org/42571314:14
*** haplo37_ has quit IRC14:15
scottdaDoes anyone know Helen Walsh's irc handle?14:16
*** haplo37_ has joined #openstack-cinder14:18
*** porrua has joined #openstack-cinder14:21
smcginnisscottda: xyang probably can contact her, but she's not around right now.14:22
smcginnisscottda: I don't think I've actually seen Helen on IRC. She must not have a Dunkin Donuts near her. :)14:22
openstackgerritIvan Kolodyazhny proposed openstack/cinder-specs: Generic backup implementation  https://review.openstack.org/37977814:22
scottdasmcginnis: Haha...I see Helen posting patches all the time!14:22
*** jungleboyj has joined #openstack-cinder14:23
smcginnisYeah, seen a lot from her, just don't think I've actually seen her on IRC.14:23
scottdasmcginnis: BTW, thanks for help&reviews with the ibm_storage patches.14:23
smcginnisscottda: I can probably look her up in our corporate directory now that we're coworkers I guess.14:23
smcginnisscottda: No problem - glad we got that one through!14:23
scottdasmcginnis: No, no big deal. We spotted a bug in EMC/VMAX, but I'll point xing to it14:24
smcginnisGood plan14:24
scottdasmcginnis: I just figured that Helen seems to write all the code for VMAX, and  was curious about this mysterious and prolific cinder person...14:25
smcginnisscottda: I've actually wondered myself. ;)14:25
scottdaHaha...really, I'm not sure that there is anyone who posts more patches. Maybe geguileo14:25
scottdamaybe Helen Walsh is geguileo .......14:26
*** eharney has joined #openstack-cinder14:27
smcginnisscottda: Oooh, interesting theory. His alter ego so he can collect paychecks from Red Hat _and_ EMC. :D14:27
geguileolol14:28
*** gouthamr has joined #openstack-cinder14:29
*** liverpooler has joined #openstack-cinder14:30
scottdaWe still can't run py35 tests without installing  python3-dev?14:31
smcginnisYep14:31
scottdaHave we discussed adding that to test-requirements?14:31
smcginnisIt's a bindep really.14:31
*** _ducttape_ has joined #openstack-cinder14:31
smcginnisWe have the same thing with py27.14:31
smcginnisI've been meaning to checkout out our devref setup instructions. We should update that there.14:32
smcginnisscottda: http://docs.openstack.org/developer/cinder/devref/development.environment.html#linux-systems14:32
scottdaI think it actually might be in there....I'll look14:32
*** ducttape_ has quit IRC14:32
smcginnisWe should update those apt/yum/zypper setup instructions.14:32
smcginnisAnd change that yum instruction to whatever the new package manager is that I can never remember because I was so used to typing yum for so many years.14:33
smcginnisCna probably drop Ubuntu 12 now too.14:33
scottdasmcginnis: I'm filing a bug ATM...14:35
smcginnis:D14:35
openstackgerritSean McGinnis proposed openstack/cinder: Rebrand and move EQLX driver to dell_emc folder  https://review.openstack.org/41556514:37
scottdasmcginnis: I quoted you. Feel free to add to https://bugs.launchpad.net/cinder/+bug/165956814:38
openstackLaunchpad bug 1659568 in Cinder "cleanup development.environment.rst" [Undecided,New]14:38
smcginnisscottda: Cool, thanks.14:39
smcginnisHah, nice.14:39
scottdaI like to think of Cinder as "The Hermit Kingdom"14:42
e0nesmcginnis: hi. did you cut final version of cinderclient for Ocata?14:43
e0nesmcginnis: I worry about https://bugs.launchpad.net/python-cinderclient/+bug/1659561 fix14:44
openstackLaunchpad bug 1659561 in python-cinderclient "snapshot-list error if using os_volume_api_version 3-3.21" [High,Confirmed] - Assigned to Michael Dovgal (mdovgal)14:44
smcginnise0ne: I have not yet. I need to do that today, but we have a couple things in flight that I would like to land first.14:44
e0nesmcginnis: thanks for the info14:45
smcginnise0ne: Looks like Michael has identified the root cause on that one.14:45
smcginnisIf we can get a patch up, I think we can still get it through.14:45
e0nesmcginnis: yes. cool14:45
mdovgalsmcginnis, yes. i'm working on it right now14:47
smcginnismdovgal: Awesome - Thank you!14:47
*** _ducttape_ has quit IRC14:47
*** pbandark has quit IRC14:48
*** d-bark has quit IRC14:50
*** mtanino has joined #openstack-cinder14:51
*** Yogi1 has joined #openstack-cinder14:51
*** mtanino has quit IRC14:52
*** rushil has joined #openstack-cinder14:54
openstackgerritEvgeny Antyshev proposed openstack/cinder: Fix double call to "qemu-img create"  https://review.openstack.org/42573914:55
eantysheveharney, smcginnis: Would you please review that^^^14:56
eharneyeantyshev: yes14:56
*** jungleboyj has quit IRC14:56
*** Lee1092 has quit IRC14:56
openstackgerritEvgeny Antyshev proposed openstack/cinder: Fix double call to "qemu-img create"  https://review.openstack.org/42573914:57
*** markvoelker has joined #openstack-cinder14:57
*** crose has joined #openstack-cinder14:58
*** rushil has quit IRC15:00
*** esker has joined #openstack-cinder15:01
*** jungleboyj has joined #openstack-cinder15:03
*** reduxio has quit IRC15:03
*** rushil has joined #openstack-cinder15:05
*** xyang has joined #openstack-cinder15:06
smcginniseharney, eantyshev: I vaguely seem to recall there be a purpose for needing to call qemu-img twice. That might be something in a different place though.15:06
*** lpetrut has joined #openstack-cinder15:10
openstackgerritEvgeny Antyshev proposed openstack/cinder: Fix double call to "qemu-img create"  https://review.openstack.org/42573915:11
*** mtanino has joined #openstack-cinder15:14
openstackgerritMichael Dovgal proposed openstack/python-cinderclient: Fix getting metadata attr error in snapshot-list command  https://review.openstack.org/42574615:19
*** stvnoyes1 has quit IRC15:19
*** stvnoyes has joined #openstack-cinder15:20
mdovgalsmcginnis, done. if you can, please, take a look15:22
smcginnismdovgal: Will do, thanks!15:22
mdovgalsmcginnis, thank you15:22
*** Jack_Iv has joined #openstack-cinder15:25
*** ociuhandu has quit IRC15:27
*** psachin has quit IRC15:29
openstackgerritwangxiyuan proposed openstack/cinder: [api-ref]Add volumes/summary API doc  https://review.openstack.org/41051015:31
openstackgerritwangxiyuan proposed openstack/cinder: [api-ref]Change tenant to project  https://review.openstack.org/41773915:31
*** Jack_Iv has quit IRC15:32
*** Jack_Iv has joined #openstack-cinder15:32
openstackgerritMerged openstack/python-cinderclient: Support filter volumes by group_id  https://review.openstack.org/41006415:33
*** diablo_rojo has joined #openstack-cinder15:35
openstackgerritwangxiyuan proposed openstack/cinder: [api-ref]Fix the volume metadata description error  https://review.openstack.org/41009815:36
*** stevemar has quit IRC15:36
*** stevemar has joined #openstack-cinder15:37
*** reduxio has joined #openstack-cinder15:39
*** catintheroof has joined #openstack-cinder15:39
*** rushil has quit IRC15:39
*** reduxio has quit IRC15:39
*** reduxio has joined #openstack-cinder15:39
*** crushil has joined #openstack-cinder15:40
*** pjm6 has quit IRC15:42
*** catinthe_ has quit IRC15:42
*** lpetrut has quit IRC15:44
*** kfarr has joined #openstack-cinder15:45
*** zhangguoqing has quit IRC15:45
*** alonma has quit IRC15:46
openstackgerritJohn Griffith proposed openstack/python-cinderclient: Test commit  https://review.openstack.org/42576115:46
*** alonma has joined #openstack-cinder15:46
smcginnisjgriffith: I read it anyway. :P15:47
*** openstackgerrit has quit IRC15:48
*** lpetrut has joined #openstack-cinder15:51
jungleboyjjgriffith, Ahhh, my eyes!  It burns!15:53
jungleboyj-2 with extreme prejudice.15:53
*** mvk has quit IRC15:55
*** openstackgerrit has joined #openstack-cinder15:57
openstackgerritScott DAngelo proposed openstack/python-cinderclient: static method to get_server_version  https://review.openstack.org/42011915:57
scottdasmcginnis: I'd like to get that in the next cinderclient release ^^^^15:57
scottdasmcginnis: I'm also going to add another method to that patch in the next hour or so. When do you plan on releasing the client?15:58
smcginnisscottda: Apparently as soon as that merges. :P15:58
scottdaha15:58
smcginnisscottda: It just needs to be some time today. :)15:58
scottdasmcginnis: OK15:58
smcginnisscottda: Have you tested that well locally?15:58
scottdayes.15:59
smcginnisscottda: OK, great. Just let me know when everythings all set.15:59
scottdasmcginnis: cool, thx.15:59
*** Zer0Byte has joined #openstack-cinder16:00
*** nkrinner is now known as nkrinner_afk16:00
jungleboyjsmcginnis, You had to ask the testing czar that?16:02
smcginnis;)16:02
xyang@smcginnis: when are you going to cut o-3 for cinder?16:04
scottdaxyang: FYI https://bugs.launchpad.net/cinder/+bug/165948116:06
openstackLaunchpad bug 1659481 in Cinder "test_emc_vmax.py should not mock volume_types.get_volume_type_extra_spec globally" [Undecided,New]16:06
smcginnisxyang: Probably late today.16:06
xyang@smcginnis: thanks16:07
xyangscottda: let me check16:07
smcginnisIf there's anything important to get in (we still have a week to RC1 though) just let me know.16:07
potssmcginnis: can you merge https://review.openstack.org/#/c/383452/ (it passed the HPMSA CI last night)16:08
*** The_Ball has quit IRC16:08
xyangscottda: we'll fix it16:08
scottdaxyang: cool. We already fixed locally to merge the ibm_storage patch, so no hurry.16:09
*** alonma has quit IRC16:09
smcginnispots: How are things coming with the DotHill and Lenovo CIs?16:09
scottdaxyang: It'll just affect the next patch that follows and uses test of extra_spec16:09
*** alonma has joined #openstack-cinder16:09
potsi'm still struggling getting devstack stable as the provider; the jenkins/zuul/nodepool stuff is ready to go.16:11
xyangscottda: I actually don't know what16:11
xyangscottda: what's the best way to fix this16:12
potsbut the HPMSA CI has been running all this time, and running that patch for a couple of months16:12
xyangscottda: do a with mock.patch.object inside the function?16:12
scottdaxyang: Well, I think we mock per test, instead of globally. But I haven't looked at your tests in that much detail.16:12
scottdaxyang: Maybe16:12
openstackgerritGorka Eguileor proposed openstack/cinder: Add lock acquire/release debug messages  https://review.openstack.org/42576816:13
xyangscottda: I thought that is mock for that test only16:13
potssmcginnis: so the HPMSA driver shouldn't have been marked unsupported16:13
*** The_Ball has joined #openstack-cinder16:13
mdovgalerlon, hi. do you here?16:13
*** alonma has quit IRC16:13
erlonmdovgal: hey16:16
potssmcginnis: you probably recall that it's really just one driver with 3 different brand names, so the HPMSA CI tests all the functionality16:17
mdovgalerlon, remember, yesterday we discussed snapshot bug after the meeting? there one more side effect because of it) do you have a minute?16:18
*** mdnadeem has quit IRC16:19
openstackgerritSean McGinnis proposed openstack/cinder: Rebrand and move EQLX driver to dell_emc folder  https://review.openstack.org/41556516:20
*** alonma has joined #openstack-cinder16:20
mdovgalerlon, just a view problem, but it can disorient somebody16:21
erlonmdovgal: a view? what do you mean?16:23
mdovgalerlon, http://paste.openstack.org/show/596612/16:23
mdovgalerlon, look at the size column16:24
mdovgalerlon, when we create record in db here https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L851, we use volume size and api will return wrong result(16:25
*** alonma has quit IRC16:25
mdovgalbut after the operation will be finished, everything will be ok16:25
*** cfriesen has left #openstack-cinder16:26
*** Zer0Byte has quit IRC16:27
erlonmdovgal: hmm, that is what Im noticing, theres a temporary status where the snapshot has the wrong size16:27
erlonmdovgal: my first impulse is to pass the snapshot, instead of the volume  object to that function, and then there extract the volume, to use where needed and pass the correct size to snapshot.create()16:30
*** knomura has joined #openstack-cinder16:31
*** alonma has joined #openstack-cinder16:32
*** esker has quit IRC16:33
*** lpetrut has quit IRC16:33
*** alonma has quit IRC16:36
*** bardia has joined #openstack-cinder16:37
*** bardia_ has joined #openstack-cinder16:37
*** alonma has joined #openstack-cinder16:38
*** bardia has quit IRC16:41
*** e0ne has quit IRC16:41
*** tommylikehu_ has quit IRC16:42
*** tommylikehu_ has joined #openstack-cinder16:42
*** alonma has quit IRC16:42
*** tommylikehu_ has quit IRC16:43
*** tommylikehu_ has joined #openstack-cinder16:43
mdovgalerlon, at the time when this func is executed here https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L1697, we don't know about the real snapshot size(16:43
mdovgalerlon, and frankly speaking, i'm not sure, that i understood your idea(16:43
*** tommylikehu_ has quit IRC16:43
*** tommylikehu_ has joined #openstack-cinder16:44
*** tommylikehu_ has quit IRC16:44
*** tommylikehu_ has joined #openstack-cinder16:45
*** tommylikehu_ has quit IRC16:45
*** tommylikehu_ has joined #openstack-cinder16:45
jgriffithmdovgal erlon I just want to emphatically and clearly state again that this is NOT a bug, snapshots don't have a size attribute16:46
*** tommylikehu_ has quit IRC16:46
jgriffithit's not a bug * 10000016:46
jgriffith:)16:46
*** tommylikehu_ has joined #openstack-cinder16:46
jgriffithwe will never know the size of a snapshot, unless we ask the specific backend, and in which case it's likely meaningless anyway16:47
*** tommylikehu_ has quit IRC16:47
*** tommylikehu_ has joined #openstack-cinder16:47
erlonjgriffith: is is a bug! if you have a snapshot, that was created with the wrong size, when you create a volume from it, the volume will have the wrong size16:47
eharneywe use snapshot['volume_size'] for GB quota calculations too16:47
*** tommylikehu_ has quit IRC16:47
jgriffithright16:48
erlonjgriffith: that controversial field its not the size of the snapshot, its the size of the volume at the time the snapshot was created16:48
*** lpetrut has joined #openstack-cinder16:48
jgriffitherlon correct16:48
jgriffithI'm saying "snapshot-size" doesn't exist16:48
jgriffithvolume_size yes, and that's what matters16:48
jgriffiththere's no such thing as "snapshot-size"16:49
erlonjgriffith: yes, that was we decided to keep the field name as it is16:49
*** alonma has joined #openstack-cinder16:49
jgriffitherlon I keep logging in and seeing people refer to "snapshot size bug". so hence my concern16:50
jgriffitherlon what's the problem you're trying to solve anyway?16:50
erlonmdovgal: the thing is, what is the quota this snapshot will consume? the first size, or the size after it has discovered the real size16:50
openstackgerritScott DAngelo proposed openstack/python-cinderclient: static method to get_highest_client_server_version  https://review.openstack.org/42578516:50
erlon?16:50
jgriffiththere we go with real-size again :)16:50
jgriffithoh well16:50
jgriffithI tried16:51
scottdasmcginnis: That latest cinderclient patch ^^^ contains the desired method for Nova to use for new APIs. So it'd be good to get that in.16:51
erlonjgriffith: real size of the volume  at the snapshot craetion time16:51
erlonjgriffith: :)16:51
jgriffitherlon yeah, like I said before you're going to have some pretty tough challenges there16:52
erlonjgriffith: its just a way of viewing it16:52
smcginniserlon: jgriffith is correct. We do not track the size of the snapshot. It is the size of the volume at the time the snapshto is created. What are you seeing as a bug?16:52
*** alonmarx has joined #openstack-cinder16:52
smcginnisscottda: Thanks, I'll take a look.16:52
*** alonma has quit IRC16:53
*** xyang has quit IRC16:54
erlonsmcginnis: jgriffith: the bug is, you create a snapshot, store the, volume_size, you extend the volume, and unmanage, both volume and snapshot, after you manage the snapshot, its volume_size should be the same as when it was created, which is not16:54
openstackgerritTom Swanson proposed openstack/cinder: Dell EMC SC: Delete doesn't validate provider_id  https://review.openstack.org/42578816:54
jgriffitherlon oh, well why didn't you say so in the first place :)16:54
*** e0ne has joined #openstack-cinder16:54
scottdasmcginnis: You can test those locally with this:16:54
erlonsmcginnis: jgriffith: then the bug, if you create a volume from that snapshot, what will happen?16:54
*** e0ne has quit IRC16:55
erlonjgriffith: the quotas will be broken as well16:55
scottdahttps://www.irccloud.com/pastebin/QBaAOFQs/test_client16:55
*** tesseract has quit IRC16:55
jgriffitherlon although I'm not sure how that happens, the volume_size column in the snap isn't an FK16:55
jgriffitherlon are you sure it's being changed in the DB?16:55
jgriffitherlon it's an independent key for this very reason16:56
jgriffitherlon https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/models.py#L67316:57
erlonjgriffith: yes, but the problem with manage is that when API first receives that manage request, it creates the snapshot, and saves in the DB with the current volume.size, then, after querying the driver (here mdovgal fixed) it saves the snapshot.volume_size correct16:57
jgriffithso you're saying somwhere in the flow extend-volume is going back and modifying all of the snapshots for the volume?16:57
jgriffitherlon oh f'ing manage snapshots16:57
jgriffithstupid shit16:58
jgriffithyeah, good luck with that16:58
erlonjgriffith: so, theres a leap of time (while volume status is creating) where the volume_size is incorrect, and the possibiliby a quota problem16:58
jgriffitherlon hey, I know a good way to fix it really easy, "DONT allow importing snapshots"16:59
erlonjgriffith: now that you understand you can give us a solution right? ;)16:59
jgriffiththere's no value in it anyway16:59
SwansonI truly hope "f'ing manage snapshots" was the name of the blueprint that added that.16:59
*** isaacb has quit IRC16:59
jgriffithSwanson no, but it was my comment16:59
jgriffitherlon so yeah, you're screwed16:59
erlonmdovgal: is :)17:00
jgriffithok.. mdovgal is screwed :)17:00
jgriffithhe/she could solve it for a specific backend case, but not generally for all of them17:00
*** alonma has joined #openstack-cinder17:00
jgriffithunless we add it as a required part of the api call in the driver17:00
jgriffithwhich is fine I guess17:01
*** rajinir has joined #openstack-cinder17:01
jgriffithbut again I go back to the "why"17:01
jgriffithit's a lot of wonky code for no real value17:01
jgriffithyou want to import a snapshot?  Ok... restore that snapshot outside of Cinder on your device to a volume, and import the volume17:01
erlonjgriffith: yeap, there are a lot of things like that in Cinder17:02
*** raunak has joined #openstack-cinder17:02
jgriffithif you have the dependency problem that some have (ie volumes from snaps rely on the original chain of objects) then yeah, it sucks no matter what17:02
*** ebalduf has quit IRC17:02
jgriffitherlon yeah, there sure are17:02
*** liverpooler has quit IRC17:03
jgriffitherlon I'd love it if we all agreed to be a bit more strict on that17:03
jgriffitherlon barring that, the best solution I can think of is that it's a required parameter for the manage command17:03
SwansonIs gerrit epically slow today?17:03
jgriffithin other words, punt and force the burden back on to the people that want to use the feature (all 3 of them)17:04
erlonjgriffith: the dependency problem happends in a lot of drivers, the remotefs dependents17:04
jgriffitherlon yeah, and I've never thought of a way to deal with that unfortunately17:04
*** liverpooler has joined #openstack-cinder17:04
jgriffithI tried it over beers with some people a long time ago and everything I thought of ended up not working17:04
*** pbandark has joined #openstack-cinder17:04
erlonjgriffith: I never seen a feature being removed, that sounds very rude lol17:05
jgriffithactually it was jdurgin in Portland I think :)17:05
*** ebalduf has joined #openstack-cinder17:05
*** alonma has quit IRC17:05
*** reduxio has quit IRC17:05
jgriffitherlon nah, not rude... *efficient*17:05
*** reduxio has joined #openstack-cinder17:06
erlonjgriffith: I just feel that people have the idea that, you *never* remove a feature, you only add more17:06
erlonjgriffith: so you software gets better and better and bloated, ops17:07
jgriffitherlon and that's the biggest problem with a lot of software out there today17:07
jgriffiththat's silly17:07
jgriffithleads to bloat and eventual death of a software product17:07
jgriffithlook at Windows 7 :)17:07
jgriffithoh... even better, Microsoft Office17:07
jgriffithwe'll leave everything, and keep adding new things around it and let you use either17:08
jgriffithit doesn't work out well17:08
SwansonEverytime you remove a feature a sales person gets a stress test.17:08
jgriffithAND if you do that you REALLY need to have an architecture to support it, we don't17:08
jgriffithsales people aren't my problem anymore :)17:09
*** pbandark has quit IRC17:09
erlonjgriffith: I used the old and good XP for more than 10 years17:09
erlonmoved to 7 now, and Im liking it17:10
*** reduxio has quit IRC17:10
erlonI installed it over Mac OS Snow Leopard17:10
jgriffithhow long did you use Windows 8 for :)17:10
erlonhell yeah!17:10
SwansonI'm still running 8.1.17:10
jgriffithSo take Windows7 and keep all the features, but add a new way to do everything ala Win10 and you get crap17:10
erlonhaha is there a 8 version?17:11
erlonIll use 7 for another 10 good years17:11
*** crushil has quit IRC17:11
SwansonLove 10 at home. Great twitter app.17:11
erlonSwanson: does it have the start button?17:12
erlonSwanson: an operating system without that is useless :P17:12
*** ducttape_ has joined #openstack-cinder17:12
jgriffithwe've digressed to the point of no return17:12
*** xyang has joined #openstack-cinder17:13
Swansonerlon, you can get it back if you want it.17:13
Swansonerlon, it's cortana you can't trust.17:13
*** xyang has quit IRC17:14
erlonow my!17:14
*** mjura has quit IRC17:16
jgriffitherlon mdovgal so back to the problem :)17:20
erlonjgriffith: proceed17:21
jgriffitherlon mdovgal thoughts on requiring a volume-size for the snapshot-manage cmd?17:21
jgriffithor at least a min-size?17:21
jgriffithdoesn't have to be perfect17:21
hemnaany reviews that need to happen today?17:21
jgriffithoh... hey wait17:21
jgriffitherlon mdovgal we don't support reduce, only extend17:22
jgriffitherlon mdovgal so why is this a problem again?17:22
jgriffithif a user reduced the size of their volume after taking a snapshot, and then managed the volume and the snapshot then honestly I can't help them17:23
erlonjgriffith: if is to not be perfect we should keep a solution closer to what mdovgal is proposing, just fixing the quotas after we get the real snapshot size17:23
erlonjgriffith: by the way, if the driver cant return the snapshot size (ie. the size of volume at the snap creation) tje driver cant support the manage17:24
jgriffitherlon mdovgal link to patch?17:24
erlonso, we have a way to know the correct patch17:24
erlonjgriffith: mdovgal: brb17:24
*** arne_r has quit IRC17:24
*** _ducttape_ has joined #openstack-cinder17:26
*** bardia has joined #openstack-cinder17:27
hemnajgriffith, on the cinderclient attach/detach v2 patch.  why do we have --all-tenants and --all_tenants cmdln args?17:29
jgriffithhemna backward compatability17:30
*** ducttape_ has quit IRC17:30
hemnafor a new call?17:30
jgriffithhemna somebody at some point introduced that we should make _ and - both work and now it's everywhere17:30
hemnaugh17:30
jgriffithhemna happy to remove it17:30
hemnaok17:30
jgriffithhonestly if that's your biggest gripe I'm good17:30
hemnanah it's ok17:30
hemnaIt's not a gripe really17:31
hemnaI was just confused by it and curious17:31
jgriffithhemna oh come on, make it a gripe :)17:31
hemnalolz17:31
jgriffithcuz otherwise you'll find something more difficult :(17:31
*** bardia_ has quit IRC17:31
hemnaso I suppose it's 'better' to be consistent with the other calls17:32
hemnaso nm.17:32
jgriffithhemna so if you look at other calls like list it's there too; maybe we should not include it on this one though17:34
jgriffithhemna and I mean other V3 calls17:34
hemnaI see the same sort of pattern with volume-id and volume_id17:34
hemnait's whatever17:34
hemnamaybe I'm just being anal.17:35
jgriffithyeah, and it's dumb17:35
jgriffithI mean the pattern, not you pointing it out17:35
hemnaI'm cool with being consistently dumb.17:35
jgriffithI agree with you17:35
jgriffithLOL17:35
jgriffithsheepl17:35
openstackgerritHelen Walsh proposed openstack/cinder: VMAX driver - remove global mock of volume_types  https://review.openstack.org/42580317:36
*** Yogi1 has quit IRC17:36
*** esker has joined #openstack-cinder17:39
jgriffithsmcginnis any opinion on that?17:41
jgriffithit's sort of a big deal to me cuz once it's done it's done to erlon 's point about never removing a feature :)17:41
*** mriedem has quit IRC17:41
* smcginnis just got back, reading backscroll17:43
*** liverpooler has quit IRC17:43
*** liverpoo1er has joined #openstack-cinder17:43
scottdahemna: that VMAX patch ^^^ is the fix for our driver problem17:48
smcginnisjgriffith: Are you asking about the _ vs -?17:49
hemnaah because they globally mocked it and never removed it, which is what we kinda suspected.17:49
jgriffith@smcginnis yeah, I think I'm going to drop the '_', but can't remember if there's another good reason for them17:49
jgriffithI seem to recall there's something internally that uses those17:49
*** jose-phillips has joined #openstack-cinder17:49
smcginnisjgriffith: I've never seen a good reason. And I was confused about that as well at first. I'd say drop it.17:49
jgriffith@smcginnis k, and if we find a bug because of it no biggy, we can put them back17:50
smcginnisjgriffith: Well, if it's internal then maybe we have a chance of actually fixing it. ;)17:50
hemnaso...what you are saying is...I can gripe?17:50
smcginnisjgriffith: Very true!17:50
jgriffithhemna nope, what I"m saying is that I'm making sure I excercise your quota for the week17:50
jgriffithso now you're done :)17:50
hemnaok, phew.  don't want to let me get out of hand now.17:51
*** ripsomeday has left #openstack-cinder17:51
hemnaI was about to start talking about gerrit UI and stuff.17:51
jgriffithcats and dogs living together... mass hysteria and anarchy17:51
*** _ducttape_ has quit IRC17:55
openstackgerritJohn Griffith proposed openstack/python-cinderclient: Attach/Detach V2  https://review.openstack.org/38771617:55
*** ducttape_ has joined #openstack-cinder17:55
openstackgerritRaunak Kumar proposed openstack/cinder: Fix Qos for clone for Nimble Storage Driver  https://review.openstack.org/42493317:56
*** _ducttape_ has joined #openstack-cinder17:56
*** _ducttape_ has quit IRC17:58
*** Jack_Iv has quit IRC17:59
*** kfarr has quit IRC17:59
*** david-lyle has quit IRC17:59
*** Apoorva has joined #openstack-cinder17:59
*** ducttape_ has quit IRC18:00
smcginnishemna: I doubt anyone is running CI against the driverfixes branch.18:01
hemnaI thought the hp CI was picking up jobs from there too18:02
smcginnishemna: We didn't require it for that branch if they are. I think we explicitly said we don't necessarily expect the code in driverfixes/* to actually run.18:03
hemnaok18:03
smcginnisIn fact, there was some discussion of intentially making sure it didn't so folks didn't think they could just run from there.18:03
hemnaI can remove the -118:03
hemnabut I don't think HP's CI is working at all right now or has been for a long time.18:03
openstackgerritMerged openstack/cinder: Eager load projects when getting types by group  https://review.openstack.org/42515918:03
smcginnishemna: One Pike opens up, looks like there's a whole list of drivers that are going to need the unsupported flag based on the last report I ran. :/18:04
hemnayah18:04
hemnawell, why can't we do it today? :P18:04
smcginnisHaha. We _could_. I would just feel bad doing it this close to the final cut.18:05
*** arch-nemesis has joined #openstack-cinder18:05
smcginnisThough there is an arugment that they are out of CI compliance and it should have the flag.18:05
hemnato vendors that haven't been participating?18:05
hemnaI dunno man.18:05
hemnaI thought this was the entire reason for that flag18:06
hemnavs. before, we nuked em, which was harsh18:06
hemnaI don't feel bad about setting the flag to drivers that aren't participating or making an effort, especially as the deadline is here.18:07
smcginnisI'm running another report now. I'll paste that once it's done.18:07
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/42551918:07
smcginnishemna: That is a fair point.18:07
hemnalets see what other core's think.18:07
smcginnishemna: +118:07
hemnawe aren't nuking their drivers18:07
jgriffithI'm fine with flagging them (now that mines running again) :)18:08
smcginnishah18:08
hemnahehe18:09
openstackgerritMerged openstack/cinder: Fix api-ref status parameter  https://review.openstack.org/42565618:09
openstackgerritMerged openstack/cinder: Small change to microversion header on devref  https://review.openstack.org/42562918:10
*** Jack_Iv has joined #openstack-cinder18:10
*** dinob has joined #openstack-cinder18:12
*** arch-nemesis has quit IRC18:12
*** Jack_Iv has quit IRC18:13
*** xinli has joined #openstack-cinder18:13
*** Jack_Iv has joined #openstack-cinder18:13
*** ebalduf has quit IRC18:14
*** crushil has joined #openstack-cinder18:15
*** ociuhandu has joined #openstack-cinder18:16
*** Jack_Iv has quit IRC18:17
*** knomura has quit IRC18:18
*** alonmarx has quit IRC18:19
*** xyang has joined #openstack-cinder18:19
*** lpetrut has quit IRC18:20
*** dulek has quit IRC18:20
*** ebalduf has joined #openstack-cinder18:20
*** pkoniszewski has quit IRC18:22
*** xek_ has joined #openstack-cinder18:22
*** xek has quit IRC18:22
*** dulek has joined #openstack-cinder18:23
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/42551918:23
smcginnishemna, jgriffith: http://paste.openstack.org/show/596630/18:24
*** pkoniszewski has joined #openstack-cinder18:24
hemna0%18:24
hemnadoh18:24
jgriffithsmcginnis I'm suspicous of any 100% pass rates18:25
hemnajgriffith, +118:25
hemnaheh Lenovo also 0%18:25
hemnawow lots under 40%18:26
jgriffithwow, those numbers are pretty awful18:26
hemna:(18:26
jgriffithnot just the number of 0% but the the average success rates18:26
hemnayah that's very concerning18:26
hemnaso what do you think about marking anyone under 40% ?18:27
hemnaor pick a %18:27
jungleboyjhemna, Yeah, I found out yesterday the person to contact.  I will get on them today.18:29
hemnaso....18:30
hemnafwiw, I'm not sure about that report smcginnis18:30
*** ebalduf has quit IRC18:30
hemnait says the IBM flash system CI last success was 11/28/201618:30
hemnayet, it reports success here:  https://review.openstack.org/#/c/401285/18:31
openstackgerritMerged openstack/python-cinderclient: Fix getting metadata attr error in snapshot-list command  https://review.openstack.org/42574618:31
hemnaso I has confused18:31
*** rcernin has joined #openstack-cinder18:32
hemnaoh18:35
hemnaI think I might know18:35
hemnathat flashsystem-tempest-dsvm-full-iscsi is reporting under IBM Storage CI18:35
hemnaI'll ping our CI guy about that and get that changed.18:36
scottdaOr maybe that's what we want hemna ?18:36
*** jungleboyj has quit IRC18:36
*** alyson_ has quit IRC18:37
scottdaSince they are all in the same Lab now.18:37
hemnayah I'm ok with it, but we need to change the IBM flash system storage drivers CI name then.18:37
hemnaI can throw that patch together18:38
*** ebalduf has joined #openstack-cinder18:38
hemnacan we get it in today?18:38
hemnahmm18:40
* hemna is confused18:40
hemnaugh, the ibm drivers CI name is all borked18:41
scottdaDarn that Jay!18:41
*** jungleboyj has joined #openstack-cinder18:41
hemnaso not a single ibm driver lists "IBM_STORAGE_CI" as it's name18:41
hemnabut there are 3 reporting as it18:42
*** mvk has joined #openstack-cinder18:42
*** ebalduf has quit IRC18:43
*** alonma has joined #openstack-cinder18:46
*** alonmarx has joined #openstack-cinder18:47
*** crushil has quit IRC18:49
*** tommylikehu_ has joined #openstack-cinder18:49
*** ebalduf has joined #openstack-cinder18:51
*** alonma has quit IRC18:51
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: IBM driver update CI_WIKI_NAME  https://review.openstack.org/42583518:51
hemnasmcginnis, ^^18:52
*** jordanP has quit IRC18:53
jungleboyjhemna, smcginnis First CI angrygram sent in Lenovo.18:54
*** tommylikehu_ has quit IRC18:54
hemna0% is kinda suspicious too18:55
hemnaespecially since it says last seen 1/26/201718:55
hemnawould be cool if that report also gave URLs to the last success and last seen18:56
*** yumiriam has quit IRC18:59
*** ebalduf has quit IRC19:00
*** lpetrut has joined #openstack-cinder19:01
*** harlowja has quit IRC19:02
*** xyang has quit IRC19:02
openstackgerritJohn Griffith proposed openstack/cinder: Zero out SolidFire capacity when unreachable  https://review.openstack.org/42584219:03
*** jdurgin1 has quit IRC19:03
*** crushil has joined #openstack-cinder19:05
*** reduxio has joined #openstack-cinder19:05
*** ebalduf has joined #openstack-cinder19:07
hemnasmcginnis, do you have the yaml file with the CI names for lastcomment.py ?19:07
hemnaor are you using the ci.yaml in the repo?19:08
Apoorvahemna http://paste.openstack.org/show/596634/19:09
*** reduxio has quit IRC19:09
hemnahe must have hacked lastcomment.py to output in that format19:10
hemnaApoorva, if that's the up to date list, we should do a pull request to the repo19:10
hemnathe reports I'm generating are useless19:11
hemnaheh19:11
scottdaCould use some eyes on this: https://review.openstack.org/#/c/420119/19:12
scottdastatic method to get_server_version for the cinderclient19:13
hemnawhat's the url ?19:15
smcginnishemna: Back. That might need some more tweaks, but it would be good to get it updated in the repo.19:16
scottdahemna: The cinder endpoint19:16
scottdahemna: Which I guess is not very clear19:17
scottda:(19:17
hemnascottda, yah19:17
scottdaOK, well I can re-spin, but maybe after others chime in...19:17
scottdaSince time is running short, and Jenkins is taking some time.19:18
hemnascottda, what is that supposed to return?19:18
hemnaI'm trying to print it out and it's bitching19:18
scottdaThe min and max APIVersion that the server supports19:18
hemnaoh it's a tuple19:18
scottdahttps://www.irccloud.com/pastebin/1CMhzVvf/19:19
scottdaIt will take the URL from the Service catalog, or just the naked endpoint19:19
hemnaMin = API Version Major: 3, Minor: 0  Max = API Version Major: 3, Minor: 2719:20
hemnaso min = a string that you need to parse19:20
hemnaand so is max19:20
scottdaYeah19:20
hemnahrmm19:20
scottdaI also have this https://review.openstack.org/#/c/425785/19:20
scottdaThat will be better for Nova and Horizon19:21
hemnais this expected to be something that you can take action on, or just print out?19:21
scottdaHorizon will use it (probably better to use the second, #425785)19:21
hemnawouldn't it be better to return a dict that you don't have to parse?  and/or take a param that says just give me a string?19:21
hemnadunno19:21
scottdaHOrizon can then show the appropriate buttons and widgets based on what the server API version is19:22
scottdaNova will use it to see if the new attach APIs are present19:22
hemnaso they have to parse out each of those strings to find the numbers then19:22
scottda2nd patch returns a float19:22
hemnahttp://paste.openstack.org/show/596637/19:23
scottda?19:24
hemnaAPI Version Major: 3, Minor: 019:24
hemnaso they will have to parse that string to find 319:24
hemnato make a decision19:24
scottdatry get_highest_client_server_version19:24
scottda2nd patch19:25
hemnainstead of getting a dict {min: {major: 3, minor: 0}, max: {major: 3, minor: 27}}19:25
hemnasee what I mean?19:25
hemnahuman consumption vs. python consumption is what I'm getting at19:25
scottdaYeah, I'm not sure we even want to expose the first patch. Second is what you really want19:25
scottdaBut I agree with what you are saying..19:25
hemnahttps://review.openstack.org/#/c/420119/19:26
hemnaI'm confused19:26
hemnaare you saying that patch is not right?19:26
hemnaand there is another patch somewhere else that I should use/test instead?19:26
* hemna is confused19:26
smcginnisjgriffith: How did you already get a merge conflict on that client patch.19:27
smcginnisjgriffith: You've just got skillz there.19:27
*** AndroUser has joined #openstack-cinder19:27
hemnascottda, or am I high?  I see your commit message says it returns APIVersion objects19:27
jgriffith@smcginnis really?19:27
smcginnishemna: scottda's the one in Colorado19:27
scottdaha19:27
hemnaso maybe I'm confused because I'm dumping the output as strings, which the APIVersion object converts itself19:27
scottdayes, it does return APIVersion objects19:28
hemnaok19:28
scottdaAnd the second one just returns a float.19:28
hemnaok nm I'm dumb19:28
*** AndroUser has quit IRC19:28
*** xyang has joined #openstack-cinder19:28
scottdasmcginnis: or jgriffith do either of you have a minute to look at https://review.openstack.org/#/c/420119 , before I spin a new patch?19:29
openstackgerritJohn Griffith proposed openstack/python-cinderclient: Attach/Detach V2  https://review.openstack.org/38771619:30
scottdaand https://review.openstack.org/#/c/425785/19:30
jgriffithscottda I am looking at it, trying to grock it a bit19:30
scottdacool. Thx.19:30
scottdaTrigger Warning: contains microversions.19:31
hemnascottda, ok it looks good, minus the verbiage about the url19:31
scottdaCommit message will be changed to state URL is Cinder endpoint...19:31
hemnamaybe a release note?19:31
hemnado we do release notes for minderclient ?19:32
hemnaarg chant...19:32
hemna!!19:32
openstackhemna: Error: "!" is not a valid command.19:32
scottdahemna: yup19:32
hemnastill don't have table flip.   l a m e.19:32
smcginnisDang it~19:33
*** xyang has quit IRC19:33
jgriffithscottda comment/question added19:33
scottdathx19:34
*** xyang has joined #openstack-cinder19:36
smcginnishemna, scottda: Another issue with that IBM Storage CI. Maybe it's still being worked on, but it's only running three tests for at least 5 drivers. Not doing both iSCSI and FC.19:37
hemnasmcginnis, +119:37
hemnaI noticed that too19:38
*** porrua_ has joined #openstack-cinder19:38
hemnaI'll remedy that19:38
smcginnishemna: Thanks!19:39
*** crushil has quit IRC19:39
smcginnisSo I think I'm just waiting for jgriffith's API patch to merge and scottda to get high before I cut the client. Anything else I'm missing?19:40
scottdacough...cough19:41
smcginnis;)19:41
*** porrua has quit IRC19:42
scottdaBugger! Hard to test the https case, since I don't have secure endpoint....19:43
*** xyang has quit IRC19:45
*** david-lyle has joined #openstack-cinder19:45
*** Jack_Iv has joined #openstack-cinder19:45
*** xyang has joined #openstack-cinder19:47
smcginnisscottda: Theoretically it shouldn't really make a difference, right?19:48
openstackgerritScott DAngelo proposed openstack/python-cinderclient: static method to get_server_version  https://review.openstack.org/42011919:48
scottdasmcginnis: Nope19:48
scottdaAnd I added a unit test for that19:48
*** xyang has quit IRC19:50
scottdaWhat do you think about patch for get_highest_client_server_version ?19:52
*** xyang has joined #openstack-cinder19:52
scottdaI'd like to bikeshed on that name for a bit....19:52
scottdaIt's really the min(cinderclient.MAX_VERSION, server.max_version)19:53
waj334What changed in the delete_metadata function between 2.0 and 3.14? I'm getting this error in a functional test: "Failed to unset volume property: API version '3.0' is not supported on 'cinderclient.v3.volumes.delete_metadata' method."19:53
scottdaSo maybe just shorten to "get_high" ?19:53
scottdawaj334: Are you using version 3.0 or 3.14?19:53
smcginnisscottda: I think the name is ok. Maybe get_highest_common_version?19:53
waj334scottda: 3.019:54
scottdasmcginnis: sure, that works19:54
smcginnisscottda: or get_dude_pass_it_over_here()19:54
smcginnis:P19:54
*** xyang has quit IRC19:54
waj334scottda: I think the decorator on that function should be "@api_versions.wraps("2.0", "3.14")" instead of just "@api_versions.wraps("2.0")"19:54
*** mtanino has quit IRC19:55
*** xyang has joined #openstack-cinder19:57
waj334scottda: it has different version for 3.1519:57
waj334scottda: I forgot to mention that this is in the client19:58
scottdawaj334:19:59
scottdahttps://www.irccloud.com/pastebin/Od28YAxb/20:00
scottdaIn 3.15 we added Etag support20:00
*** markvoelker has quit IRC20:00
*** xyang has quit IRC20:01
*** Guest33539 is now known as mgagne20:01
*** mgagne has quit IRC20:01
*** mgagne has joined #openstack-cinder20:01
scottdaBut the client should have older version for v3 <3.1520:02
openstackgerritSean McGinnis proposed openstack/cinder: Rebrand and move EQLX driver to dell_emc folder  https://review.openstack.org/41556520:02
scottdawaj334: So that's a bug20:02
smcginnisI'm going to be releasing the client at midnight, aren't I?20:02
waj334scottda: I'll look into squashing that bug20:03
*** xyang has joined #openstack-cinder20:03
scottdawaj334: I'm working on a fix now20:03
scottdawaj334: If you file the bug, I'll post the patch20:03
potsjungleboyj: hi Jay, I got your message :)20:04
waj334scottda: Aww man. I was gonna do both lol20:05
scottdawaj334: That's fine20:05
scottdawaj334: my patch looks like this:20:06
scottdahttps://www.irccloud.com/pastebin/SSbW2Jx3/20:06
scottdaTest that ^^^  and submit away.20:06
scottdawaj334: Maybe add a unit test20:06
scottdaBut smcginnis wants to get some sleep, and the deadline for getting the client out is midnight tonight.20:07
smcginnisSo no dilly dallying. :)20:07
*** eharney has quit IRC20:08
*** crose has quit IRC20:08
*** harlowja has joined #openstack-cinder20:09
SwansonSo retype with migration does a volume_delete at the end. It sends me a volume that has the id of the old destination (from before it was renamed) and provider_id of that volume. And it calls the original backend with this information.20:10
*** xyang has quit IRC20:10
*** alonmarx has quit IRC20:14
openstackgerritScott DAngelo proposed openstack/python-cinderclient: static method to get_server_version  https://review.openstack.org/42011920:18
*** alonmarx has joined #openstack-cinder20:20
openstackgerritScott DAngelo proposed openstack/python-cinderclient: static method to get_highest_client_server_version  https://review.openstack.org/42578520:24
*** eharney has joined #openstack-cinder20:24
*** mriedem has joined #openstack-cinder20:28
*** knomura has joined #openstack-cinder20:30
openstackgerritTom Swanson proposed openstack/cinder: Dell EMC SC: Delete doesn't validate provider_id  https://review.openstack.org/42578820:31
*** timcl has quit IRC20:32
*** timcl has joined #openstack-cinder20:34
*** knomura has quit IRC20:35
*** lpetrut has quit IRC20:36
*** lpetrut has joined #openstack-cinder20:36
*** diablo_rojo has quit IRC20:44
*** e0ne has joined #openstack-cinder20:44
*** pbandark has joined #openstack-cinder20:45
smcginnisscottda: If you have a moment, mind taking a look at John's client patch? https://review.openstack.org/#/c/387716/20:48
scottdayup, will do20:48
*** diablo_rojo has joined #openstack-cinder20:51
*** e0ne has quit IRC20:54
*** markstur_ has joined #openstack-cinder20:55
*** e0ne has joined #openstack-cinder20:58
*** ebalduf has quit IRC20:59
waj334scottda: I'm looking at what's in the repo for the cinderclient on github and I noticed that the code section for the old delete_metadata function had been removed completely. My local copy that I clone a few days ago has it, but not the current one. Strange20:59
waj334scottda: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/volumes.py21:00
scottdawaj334: So, you are saying that v3/volumes.py used to have 2 functions for delete_metadata, one wrapped with "3.0" and one wrapped with "3.15" ?21:02
scottdaAnd now it does not. (I can confirm that it does not in my fresh clone of the repo)21:02
waj334scottda: One wrapped with "2.0" and another wrapped with "3.15"21:03
scottdawaj334: The bug was introduced with this commit: 603c615ae59a8b6c24811b39ad05f26228ef586821:04
scottdaWe should look at that patch set for other errors that might have been introduced.21:05
jungleboyjpots, What message?21:06
*** reduxio has joined #openstack-cinder21:06
jungleboyjAre you my CI guy?21:07
*** ebalduf has joined #openstack-cinder21:07
*** crose has joined #openstack-cinder21:07
*** e0ne has quit IRC21:09
*** reduxio has quit IRC21:11
*** markstur has quit IRC21:11
*** sam64 has quit IRC21:12
*** sam64 has joined #openstack-cinder21:13
*** crushil has joined #openstack-cinder21:14
*** ebalduf has quit IRC21:16
*** markstur_ is now known as markstur21:16
potsi'm your guy21:16
potsjust writing you an e-mail21:17
*** edmondsw_ has joined #openstack-cinder21:18
*** edmondsw_ has quit IRC21:18
scottdasmcginnis: jgriffith I know there is disagreement about versioning the help, but as it is today we do version it. So attach/detach shell will need that.21:19
smcginnisscottda: Oh, right. Should be a quick fix.21:20
scottdayeah21:20
*** liverpoo1er has quit IRC21:21
scottdasmcginnis: FYI, I'll add a option to show all help, to make it easier to figure out when new features are in...something like "--help-me-get-highest"21:21
scottdaJust need to figure out the best way to do that...21:21
scottdaDon't hold up this release on it.21:22
*** ebalduf has joined #openstack-cinder21:23
*** Jack_V has quit IRC21:24
smcginnisGreat/21:24
smcginnisscottda: Interesting from Nova, for the library usage they limit to what is explictly requested, but for CLI they automatically go with the latest/highest available microversion.21:25
scottdasmcginnis: Sure, that's what Manila does too.21:26
scottdasmcginnis: And I'm fine with that.21:26
scottdaWith those current in-flight patches, it makes it easy.21:26
scottdasmcginnis: I can have a look in a minute. Maybe shove one more thing in :)21:27
scottdasmcginnis: FYI the bug waj334 found may have been introduced with other bugs...I'm looking now..21:28
smcginnisscottda: Cool, thanks for looking at that.21:28
smcginnisI figure we have a few hours yet to still get patches through check/gate queues.21:29
smcginnisjgriffith: Did you see scottda's comments on the versioning? Should be pretty quick, I hope.21:29
*** porrua_ has quit IRC21:31
*** porrua has joined #openstack-cinder21:32
*** crose has quit IRC21:32
jungleboyjpots, Ok, thanks for getting back to me.21:35
scottdawaj334: Are you going to put up a patch for that bug? And have you filed a bug?21:36
jungleboyjsmcginnis, pots is working our CI issues.  :-)  By our I mean the Lenovo and Dothill driver.  :-)21:36
waj334scottda: I'm filing the bug and working on a patch now21:36
scottdaOK21:36
scottdawaj334: Should just be that patch I posted.21:37
smcginnisjungleboyj: Great!21:37
waj334scottda: gotcha21:37
jungleboyjsmcginnis, Look at me making new contacts so quickly.21:37
smcginnisYou're showing off for your new bosses, aren't you. :)21:38
smcginnisjungleboyj: Watch out, they might expect you to get stuff done all the time.21:38
*** alonmarx has quit IRC21:38
jungleboyjMe, show off?  No!  I actually haven't had to try that hard to be a showoff.21:38
smcginnisjungleboyj: It just comes naturally to you/ :D21:39
jungleboyjsmcginnis, You flatterer!21:40
jungleboyjMe really should go to the airport.21:41
smcginnisjungleboyj: When's your flight?21:41
jungleboyj7:25 ...21:41
smcginnisjungleboyj: You'll get back to where people (mostly) know how to drive in the snow. ;)21:42
jungleboyjsmcginnis, Need to get something to eat before the flight.21:43
jungleboyjI should be in Comofort+ again and might get a First class upgrade.21:43
smcginnisjungleboyj: They're not flying you first class?21:43
smcginnis:)21:43
jungleboyj:-p  I have to fly American to the PTG because Delta's tickets are god awful expensive for some reason.21:44
smcginnisYeah, I think I had to get creative on booking that one.21:44
*** xyang has joined #openstack-cinder21:44
jungleboyjIt was weird.  Not sure what was up there.  Anyway, going to head out.  Not looking forward to the 8" of snow on my driveway tonight.21:45
smcginnisTravel safe.21:45
jungleboyjWill do, have a couple episodes of Agents of Shield to watch on the plane.  :-)21:46
*** catintheroof has quit IRC21:47
jungleboyjpots, Got your e-mail.  Thanks.  Will respond soon!21:47
jungleboyjSee you all on the other side!21:47
*** dustins is now known as dustins|out21:48
*** jungleboyj has quit IRC21:52
*** cknight has quit IRC21:54
*** pbandark has quit IRC21:54
*** xyang has quit IRC21:57
ildikovsmcginnis: jgriffith: I can quickly fix scottda's comments in the client patch if we consider it urgent21:58
smcginnisildikov: Sure, I would appreciate that.21:58
smcginnisLooking at the gate queue, it's going to take hours to get through once we approve it.21:58
smcginnisSo the sooner we can get it fixed up and approved, the sooner I will be able to go to bed tonight. :)21:59
ildikovsmcginnis: k, on it21:59
smcginnisildikov: Thank you!21:59
ildikovsmcginnis: I hope the fix will be that easy as it looks :)21:59
openstackgerritSean McGinnis proposed openstack/cinder: Rebrand and move EQLX driver to dell_emc folder  https://review.openstack.org/41556521:59
*** gouthamr has quit IRC22:00
*** esker has quit IRC22:00
*** breitz has quit IRC22:01
*** Jack_Iv has quit IRC22:01
*** xyang has joined #openstack-cinder22:01
*** Jack_Iv has joined #openstack-cinder22:01
*** breitz has joined #openstack-cinder22:01
scottdaildikov: Just paste in what I put in the comments22:03
*** bardia has quit IRC22:03
*** Jack_Iv has quit IRC22:05
ildikovscottda: ok :)22:05
*** Jack_Iv has joined #openstack-cinder22:06
*** Jack_Iv has quit IRC22:07
*** Jack_V has joined #openstack-cinder22:07
openstackgerritIldiko Vancsa proposed openstack/python-cinderclient: Attach/Detach V2  https://review.openstack.org/38771622:09
*** mtanino has joined #openstack-cinder22:09
scottdawaj334: I've got a patch for that bug, and I'm about to post it.22:09
scottdabetter stop me quick....22:10
scottda'cause smcginnis needs some sleep tonight22:10
smcginnis:)22:10
ildikovscottda: smcginnis: done22:10
ildikovsmcginnis: I know how not sleeping goes, so I really tried my best here :)22:10
smcginnisildikov: You were on really late last night. Do you even sleep anymore? :)22:11
ildikovsmcginnis: sleeping is overrated ;)22:11
smcginnisildikov: Hah. Wish I could get by with less. That only works for a day or two for me.22:11
waj334scottda: committing to gerrit now. I was just double checking my work lol22:11
*** Jack_V has quit IRC22:11
ildikovsmcginnis: I have a flight to catch in a bit more than 7 hours actually...22:11
ildikovsmcginnis: so well, maybe no, I don't :)22:12
waj334scottda: Might still need a triple check22:12
scottdawaj334: Just submit. I can review22:12
smcginnisildikov: Now where to?22:13
*** xyang has quit IRC22:14
ildikovsmcginnis: US, so I'll be in TZ finally! :)22:14
smcginnisildikov: Oh nice!22:14
smcginnisildikov: Oh, is the foundation off site?22:14
openstackgerritJustin A Wilson proposed openstack/python-cinderclient: Missing client version 3.0 support for "delete_metadata" method  https://review.openstack.org/42594822:14
ildikovsmcginnis: you're very well informed :)22:14
smcginnisildikov: I have my sources. ;)22:14
ildikovsmcginnis: I know you do ;)22:18
scottdawaj334: Fix is correct. But I think "closes bug " might not connect to Luanchpad correctly22:18
smcginnisscottda: I checked, it did link it correctly.22:19
scottdahemna: jgriffith https://review.openstack.org/#/c/420119/ and https://review.openstack.org/#/c/425785/  look ready.22:19
scottdasmcginnis: waj334 OK, good enough22:19
scottdasmcginnis: BTW, there were no other regressions along with that bug.22:20
*** xyang has joined #openstack-cinder22:20
smcginnisscottda: Great, thanks for checking on that.22:20
smcginnisNever fails though, we'll find some kind of bug tomorrow. ;)22:20
*** gouthamr has joined #openstack-cinder22:23
scottdaor patrickeast thingee we like to get those 2 client patches in today ^^^^22:27
*** xyang has quit IRC22:28
*** lpetrut has quit IRC22:30
smcginnisscottda: Hadn't noticed, but it makes sense - we get pylint errors from those methods that have the same signatures but different api_versions.wraps decorators.22:30
*** porrua has quit IRC22:31
hemnawe really should party after https://review.openstack.org/#/c/387716/ lands22:32
scottdasmcginnis: ok, I thought Gorka fixed that...but can put a "# noqa" by that line22:32
hemnaseriously a big milestone22:32
smcginnisscottda: Some other time...22:33
smcginnishemna: Big as far as the amount of stuff we're cramming into it?22:34
scottdahemna: At 5:30 AM I talked to Alon, and they were partying because of ibm_storage xiv landing. I had to settle for coffee, but it's getting close to 5:00 PM here...22:34
hemnabig as in, we've all been working on that for how long now?  and it's finally in.22:34
hemnaand thanks to jgriffith for coding it up.22:35
scottdaYeah, he's not responding, so maybe he's already celebrating.22:35
hemnasmcginnis, so what did we decide about the driver CIs ?22:35
openstackgerritTom Swanson proposed openstack/cinder: Dell EMC SC: Delete doesn't account for migration  https://review.openstack.org/42578822:35
hemnahaven't heard anything from the other core's in here about it22:36
smcginnishemna: Yep, between the HA and Attach changes going in, this is pretty significant.22:36
smcginnishemna: Especially for a "bug fix release". :)22:36
hemnahehe yah22:36
smcginnishemna: I don't think we really decided on CI.22:36
*** xyang has joined #openstack-cinder22:37
smcginnisI don't really want to delay it too much if we do decide to do anything, but maybe we should discuss it in next week's meeting.22:37
hemnaI thought today was the freeze?22:38
smcginnisFeature freeze.22:39
*** crushil has quit IRC22:39
smcginnisRC1 is next week, so we can still get bug fixes and things core deem important.22:39
*** cknight has joined #openstack-cinder22:42
*** alonma has joined #openstack-cinder22:47
*** xyang has quit IRC22:48
*** tommylikehu_ has joined #openstack-cinder22:51
*** alonma has quit IRC22:52
*** tommylikehu_ has quit IRC22:55
*** alonma has joined #openstack-cinder22:56
*** cknight has quit IRC22:56
*** alonma has quit IRC23:00
*** xinli has quit IRC23:03
*** reduxio has joined #openstack-cinder23:08
*** lseki has quit IRC23:10
*** reduxio has quit IRC23:12
*** tlian has quit IRC23:13
hemnasmcginnis, should we send a warning shot over the bow for the CI folks that are questionable now?23:18
smcginnishemna: Eh, I'm really past trying to contact each of them directly, but if you want to I don't think it's a bad idea.23:18
smcginnishemna: Or were you thinking of something like posting a patch but not approving it yet?23:19
*** tlian has joined #openstack-cinder23:21
SwansonPost a patch. Approve it. Give them until release to beg to be let back in.23:21
patrickeasthemna: smcginnis: you could maybe just post to the like 3rd party announce ML with a list of ones at risk23:21
hemnaok thats not a bad idea23:22
*** diablo_rojo has quit IRC23:29
*** knomura has joined #openstack-cinder23:30
*** ntpttr has quit IRC23:31
*** ntpttr has joined #openstack-cinder23:31
*** tlian has quit IRC23:32
*** knomura has quit IRC23:35
*** cknight has joined #openstack-cinder23:37
*** s-shiono has joined #openstack-cinder23:44
*** david-lyle has quit IRC23:51
*** david-lyle has joined #openstack-cinder23:54
*** cknight1 has joined #openstack-cinder23:55
*** stakeda has joined #openstack-cinder23:56
*** rcernin has quit IRC23:56
*** cknight has quit IRC23:57
openstackgerritMerged openstack/python-cinderclient: static method to get_server_version  https://review.openstack.org/42011923:57
*** rcernin has joined #openstack-cinder23:57
openstackgerritMerged openstack/python-cinderclient: Update param docstring to ducument search_opts  https://review.openstack.org/40793723:58
*** rcernin has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!