*** gouthamr has joined #openstack-cinder | 00:02 | |
*** catintheroof has quit IRC | 00:03 | |
*** esker has quit IRC | 00:05 | |
jgriffith | ^^ bahh... stupid stupid stupid. One more thing to fix | 00:06 |
---|---|---|
*** ducttape_ has quit IRC | 00:08 | |
*** s-shiono has joined #openstack-cinder | 00:09 | |
*** diablo_rojo_phon has quit IRC | 00:10 | |
*** boltR has joined #openstack-cinder | 00:18 | |
boltR | hello | 00:18 |
boltR | i'm trying to understand cinder's usage of ceph | 00:18 |
boltR | it seems like ceph df doesn't show much of a difference if I allocate volumes | 00:18 |
boltR | is there some kind of optimization that ceph/cinder is doing? | 00:19 |
*** s-shiono_ has joined #openstack-cinder | 00:19 | |
*** s-shiono has quit IRC | 00:21 | |
*** ducttape_ has joined #openstack-cinder | 00:24 | |
*** raunak has quit IRC | 00:28 | |
*** esker has joined #openstack-cinder | 00:30 | |
*** stakeda has joined #openstack-cinder | 00:34 | |
*** cknight has joined #openstack-cinder | 00:40 | |
*** raunak has joined #openstack-cinder | 00:42 | |
*** raunak has quit IRC | 00:42 | |
*** raunak has joined #openstack-cinder | 00:45 | |
*** cknight has quit IRC | 00:46 | |
*** esker has quit IRC | 00:49 | |
*** dave-mcc_ has joined #openstack-cinder | 00:50 | |
*** dave-mccowan has quit IRC | 00:53 | |
*** knomura has joined #openstack-cinder | 00:59 | |
*** esker has joined #openstack-cinder | 01:01 | |
*** knomura has quit IRC | 01:03 | |
*** ducttape_ has quit IRC | 01:06 | |
*** Apoorva has quit IRC | 01:07 | |
*** chenying has quit IRC | 01:11 | |
*** chenying has joined #openstack-cinder | 01:11 | |
*** esker has quit IRC | 01:13 | |
*** shaner has quit IRC | 01:16 | |
*** dave-mccowan has joined #openstack-cinder | 01:20 | |
*** dave-mcc_ has quit IRC | 01:22 | |
openstackgerrit | Raunak Kumar proposed openstack/cinder: Fix Qos for clone for Nimble Storage Driver https://review.openstack.org/424933 | 01:24 |
*** ksumit has joined #openstack-cinder | 01:25 | |
*** catintheroof has joined #openstack-cinder | 01:44 | |
*** rajinir has quit IRC | 01:46 | |
*** catintheroof has quit IRC | 01:49 | |
*** erlon has quit IRC | 01:50 | |
*** reduxio has joined #openstack-cinder | 01:54 | |
*** dave-mcc_ has joined #openstack-cinder | 01:57 | |
*** raunak has quit IRC | 01:57 | |
*** reduxio has quit IRC | 01:58 | |
*** dave-mccowan has quit IRC | 01:59 | |
*** raunak has joined #openstack-cinder | 02:02 | |
*** kaisers_ has joined #openstack-cinder | 02:03 | |
*** bardia has joined #openstack-cinder | 02:05 | |
*** kaisers has quit IRC | 02:07 | |
*** cdelatte has quit IRC | 02:11 | |
*** ducttape_ has joined #openstack-cinder | 02:19 | |
*** dansmith has quit IRC | 02:20 | |
*** dansmith has joined #openstack-cinder | 02:21 | |
*** Jack_Iv has joined #openstack-cinder | 02:22 | |
*** mtanino has quit IRC | 02:23 | |
*** ducttape_ has quit IRC | 02:24 | |
*** Jack_Iv has quit IRC | 02:26 | |
*** shaner has joined #openstack-cinder | 02:38 | |
*** jose-phillips has quit IRC | 02:44 | |
*** raunak has quit IRC | 02:47 | |
*** thingee has quit IRC | 02:55 | |
*** sage_ has quit IRC | 03:00 | |
*** bkopilov has quit IRC | 03:00 | |
*** dinob has quit IRC | 03:01 | |
*** sage has joined #openstack-cinder | 03:02 | |
openstackgerrit | Merged openstack/cinder: Switch ManageableSnaphots & ManageableVolumes list to OVO https://review.openstack.org/388783 | 03:05 |
openstackgerrit | Merged openstack/cinder: Fix the api-ref CI failure https://review.openstack.org/424411 | 03:06 |
*** markvoelker has joined #openstack-cinder | 03:07 | |
*** bardia has quit IRC | 03:13 | |
jgriffith | well this is annoying: openstack: 'volume type create --property volume_backend_name=lvmdriver-1 lvmdriver-1' is not an openstack command. See 'openstack --help'. | 03:13 |
*** thingee has joined #openstack-cinder | 03:22 | |
*** markvoelker has quit IRC | 03:23 | |
*** newmember has quit IRC | 03:23 | |
*** rushil has quit IRC | 03:23 | |
*** pbandark has joined #openstack-cinder | 03:31 | |
*** markvoelker has joined #openstack-cinder | 03:33 | |
*** nicolasbock has quit IRC | 03:39 | |
*** ducttape_ has joined #openstack-cinder | 03:40 | |
*** rushil has joined #openstack-cinder | 03:41 | |
*** esker has joined #openstack-cinder | 03:46 | |
*** gcb has joined #openstack-cinder | 03:50 | |
*** reduxio has joined #openstack-cinder | 03:56 | |
*** esker has quit IRC | 03:59 | |
*** ducttape_ has quit IRC | 04:00 | |
*** reduxio has quit IRC | 04:00 | |
*** psachin has joined #openstack-cinder | 04:03 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/425519 | 04:13 |
*** ducttape_ has joined #openstack-cinder | 04:22 | |
*** Lee1092 has joined #openstack-cinder | 04:27 | |
*** bkopilov has joined #openstack-cinder | 04:28 | |
*** dave-mcc_ has quit IRC | 04:32 | |
*** ducttape_ has quit IRC | 04:34 | |
*** Jack_Iv has joined #openstack-cinder | 04:38 | |
*** cristicalin has joined #openstack-cinder | 04:42 | |
openstackgerrit | wangxiyuan proposed openstack/cinder: [api-ref]Change tenant to project https://review.openstack.org/417739 | 04:42 |
*** Jack_Iv has quit IRC | 04:43 | |
*** SamYaple has joined #openstack-cinder | 04:43 | |
*** JiaMin_ has joined #openstack-cinder | 04:44 | |
*** Jack_Iv has joined #openstack-cinder | 04:49 | |
*** d-bark has joined #openstack-cinder | 04:49 | |
*** mdnadeem has joined #openstack-cinder | 04:50 | |
*** raunak has joined #openstack-cinder | 04:51 | |
*** diablo_rojo has quit IRC | 04:56 | |
*** alonmarx has joined #openstack-cinder | 05:01 | |
*** cburgess has quit IRC | 05:01 | |
jgriffith | smcginnis ildikov So I tried to fix up the show on the client and get to the bottom of the gate failure; sadly though after the earlier rebase I"m hitting something odd with trying to use any of the V3 commands. | 05:04 |
jgriffith | as in "they don't work" | 05:04 |
*** Guest58531 has quit IRC | 05:04 | |
jgriffith | I get "ERROR: 'module' object has no attribute 'service_type' | 05:04 |
jgriffith | and frankly I am out of time for this evening, but I'll pick it up once again in the AM | 05:05 |
ildikov | jgriffith: hmm | 05:05 |
*** knomura has joined #openstack-cinder | 05:05 | |
jgriffith | ildikov ?? Shouldn't you be asleep or something? | 05:05 |
*** d-bark has quit IRC | 05:06 | |
jgriffith | There was a batch of changes on the 23'rd including a chage to the service_type decorator | 05:07 |
jgriffith | but I havne't dug in to it yet | 05:07 |
ildikov | jgriffith: to be honest with #9 show worked for me yeterday | 05:07 |
*** cburgess has joined #openstack-cinder | 05:07 | |
*** mgagne has joined #openstack-cinder | 05:07 | |
*** mgagne is now known as Guest33539 | 05:07 | |
jgriffith | ildikov yeah; so prior to me rebasing they all worked | 05:07 |
jgriffith | ildikov I hadn't rebased off of master for the client since I started this :) | 05:07 |
ildikov | jgriffith: a fix on the server side got merged yesterday, that might have something to do with this? | 05:08 |
jgriffith | but I rebased earlier, did some other tests with master (not my patch) and the problem is that V3 calls just don't work | 05:08 |
ildikov | jgriffith: hmm, I didn't do that either :) | 05:08 |
*** cristicalin has quit IRC | 05:08 | |
jgriffith | nothing to do with my specific patch at all, V3 is broken | 05:08 |
jgriffith | and we don't test it so not surprising I suppose | 05:09 |
ildikov | jgriffith: oh, isn't there smth microversioning related merged lately? | 05:09 |
jgriffith | e0ne might have som insight as he did some work in there day before yesterday (or merged then anyway) | 05:09 |
jgriffith | ildikov yup | 05:09 |
jgriffith | :) | 05:09 |
*** knomura has quit IRC | 05:10 | |
ildikov | jgriffith: ok :) | 05:10 |
jgriffith | V2 cmds still work, V3 cmds are broken | 05:10 |
ildikov | jgriffith: I will not rebase then... :) | 05:10 |
jgriffith | ildikov good idea :) | 05:10 |
*** Jack_Iv has quit IRC | 05:12 | |
*** raunak has quit IRC | 05:13 | |
ildikov | jgriffith: TBH it always seem to be a temptingly good idea :) | 05:13 |
jgriffith | ildikov yeah, but you can only avoid it for so long :) | 05:14 |
jgriffith | Ahhh! | 05:15 |
jgriffith | Wait, I think I know the problem | 05:15 |
jgriffith | haha, Yup... ok, that was actually easy | 05:16 |
ildikov | jgriffith: did you see the comments from Brian on your patch? | 05:16 |
jgriffith | no | 05:16 |
jgriffith | haha.. well there ya go | 05:16 |
jgriffith | geesh | 05:16 |
ildikov | jgriffith: he is suggesting to remove a decorator, but I guess that's what you did :) | 05:16 |
*** raunak has joined #openstack-cinder | 05:17 | |
jgriffith | Not only is it "ok" to remove them, they MUST be removed :) | 05:17 |
jgriffith | yes | 05:17 |
jgriffith | lol | 05:17 |
ildikov | lol :) | 05:17 |
*** Jack_Iv has joined #openstack-cinder | 05:27 | |
*** cristicalin has joined #openstack-cinder | 05:30 | |
*** nkrinner_afk is now known as nkrinner | 05:35 | |
openstackgerrit | John Griffith proposed openstack/python-cinderclient: Attach/Detach V2 https://review.openstack.org/387716 | 05:35 |
*** Jack_Iv has quit IRC | 05:36 | |
*** mdnadeem has quit IRC | 05:36 | |
*** cristicalin has quit IRC | 05:40 | |
*** Jack_Iv_ has joined #openstack-cinder | 05:41 | |
*** mdnadeem has joined #openstack-cinder | 05:48 | |
*** ducttape_ has joined #openstack-cinder | 05:50 | |
*** ducttape_ has quit IRC | 05:55 | |
*** reduxio has joined #openstack-cinder | 05:58 | |
*** gouthamr has quit IRC | 06:00 | |
*** reduxio has quit IRC | 06:02 | |
*** Jack_Iv has joined #openstack-cinder | 06:02 | |
*** kaisers_ has quit IRC | 06:02 | |
*** mdnadeem has quit IRC | 06:02 | |
*** mdnadeem has joined #openstack-cinder | 06:02 | |
*** rushil has quit IRC | 06:04 | |
*** Jack_Iv_ has quit IRC | 06:06 | |
*** yangyapeng has quit IRC | 06:10 | |
*** alonmarx has quit IRC | 06:12 | |
*** x00350071_ is now known as edisonxiang | 06:13 | |
*** raunak has quit IRC | 06:14 | |
*** zhangguoqing has joined #openstack-cinder | 06:15 | |
*** raunak has joined #openstack-cinder | 06:19 | |
*** alonma has quit IRC | 06:25 | |
*** alonma has joined #openstack-cinder | 06:26 | |
*** adisky_ has joined #openstack-cinder | 06:34 | |
*** mjura has joined #openstack-cinder | 06:34 | |
*** Jack_Iv_ has joined #openstack-cinder | 06:35 | |
*** Jack_Iv has quit IRC | 06:39 | |
*** Jack_Iv_ has quit IRC | 06:41 | |
*** Jack_V has joined #openstack-cinder | 06:42 | |
*** e0ne has joined #openstack-cinder | 06:45 | |
*** e0ne has quit IRC | 06:46 | |
*** reduxio has joined #openstack-cinder | 06:50 | |
*** e0ne has joined #openstack-cinder | 06:50 | |
*** e0ne has quit IRC | 06:53 | |
*** ksumit has quit IRC | 06:55 | |
*** ChubYann has quit IRC | 06:55 | |
*** e0ne has joined #openstack-cinder | 06:57 | |
*** e0ne has quit IRC | 07:00 | |
*** kaisers has joined #openstack-cinder | 07:03 | |
*** e0ne has joined #openstack-cinder | 07:04 | |
*** arne_r has joined #openstack-cinder | 07:04 | |
*** e0ne has quit IRC | 07:09 | |
*** lkuchlan has joined #openstack-cinder | 07:09 | |
*** yangyapeng has joined #openstack-cinder | 07:10 | |
*** tesseract has joined #openstack-cinder | 07:11 | |
*** e0ne has joined #openstack-cinder | 07:12 | |
*** e0ne has quit IRC | 07:14 | |
*** yangyapeng has quit IRC | 07:15 | |
*** rha has quit IRC | 07:17 | |
*** e0ne has joined #openstack-cinder | 07:18 | |
*** ducttape_ has joined #openstack-cinder | 07:21 | |
*** AlexeyAbashkin has joined #openstack-cinder | 07:22 | |
*** ducttape_ has quit IRC | 07:26 | |
*** lennyb has quit IRC | 07:27 | |
*** lennyb has joined #openstack-cinder | 07:28 | |
*** isaacb has joined #openstack-cinder | 07:33 | |
*** kaisers has quit IRC | 07:33 | |
*** kaisers has joined #openstack-cinder | 07:36 | |
*** rha has joined #openstack-cinder | 07:36 | |
*** rha has quit IRC | 07:37 | |
*** rha has joined #openstack-cinder | 07:37 | |
*** kaisers has quit IRC | 07:40 | |
*** Jack_Iv has joined #openstack-cinder | 07:42 | |
openstackgerrit | Merged openstack/cinder: Remove race conditions from transfer API https://review.openstack.org/257495 | 07:43 |
*** raunak has quit IRC | 07:44 | |
*** kaisers has joined #openstack-cinder | 07:45 | |
*** kaisers has quit IRC | 07:49 | |
*** kaisers has joined #openstack-cinder | 07:52 | |
*** yangyapeng has joined #openstack-cinder | 07:55 | |
*** e0ne has quit IRC | 07:59 | |
*** markvoelker has quit IRC | 08:12 | |
*** Jack_Iv has quit IRC | 08:15 | |
*** markvoelker has joined #openstack-cinder | 08:15 | |
*** JiaMin_ has quit IRC | 08:17 | |
*** lkuchlan has quit IRC | 08:19 | |
*** lkuchlan has joined #openstack-cinder | 08:20 | |
*** Zer0Byte has joined #openstack-cinder | 08:22 | |
openstackgerrit | JohnnyChou proposed openstack/cinder: Enhance Infortrend driver https://review.openstack.org/394284 | 08:23 |
*** rha has quit IRC | 08:23 | |
*** rha has joined #openstack-cinder | 08:25 | |
*** rha has quit IRC | 08:25 | |
*** rha has joined #openstack-cinder | 08:25 | |
*** stakeda has quit IRC | 08:26 | |
*** s-shiono_ has quit IRC | 08:34 | |
*** reduxio has quit IRC | 08:35 | |
*** reduxio has joined #openstack-cinder | 08:35 | |
openstackgerrit | Merged openstack/cinder: Dell SC: Logging asyncTask if XML returned https://review.openstack.org/422763 | 08:38 |
openstackgerrit | Merged openstack/cinder: Open the source code of ibm_storage driver https://review.openstack.org/404958 | 08:38 |
*** reduxio has quit IRC | 08:40 | |
openstackgerrit | wangxiyuan proposed openstack/cinder: [api-ref]Change tenant to project https://review.openstack.org/417739 | 08:43 |
openstackgerrit | wangxiyuan proposed openstack/cinder: [api-ref]Change tenant to project https://review.openstack.org/417739 | 08:44 |
*** ducttape_ has joined #openstack-cinder | 08:48 | |
*** reduxio has joined #openstack-cinder | 08:56 | |
openstackgerrit | Merged openstack/cinder: NFS snapshots https://review.openstack.org/147186 | 08:58 |
openstackgerrit | Merged openstack/cinder: Make CappedVersionUnknown exception more useful https://review.openstack.org/424638 | 08:58 |
openstackgerrit | Merged openstack/cinder: Brcd zonemanager: Fix unstable command generation https://review.openstack.org/424284 | 08:58 |
openstackgerrit | Merged openstack/cinder: Tests: Fix mock for vzstorage remotefs https://review.openstack.org/425256 | 08:58 |
openstackgerrit | Merged openstack/cinder: Add assert_min_rpc_version decorator https://review.openstack.org/424669 | 08:58 |
*** zzzeek has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-cinder | 09:00 | |
openstackgerrit | Takashi Menjo proposed openstack/cinder: Revert "Mark the sheepdog driver as unsupported" https://review.openstack.org/425586 | 09:00 |
*** e0ne has joined #openstack-cinder | 09:01 | |
*** AlexeyAbashkin has quit IRC | 09:10 | |
*** tommylikehu has quit IRC | 09:14 | |
*** Zer0Byte has quit IRC | 09:18 | |
openstackgerrit | Merged openstack/cinder: Don't drop the volume type's extra spec at DB layer https://review.openstack.org/409030 | 09:22 |
*** alonma has quit IRC | 09:23 | |
*** alonma has joined #openstack-cinder | 09:23 | |
*** alonma has quit IRC | 09:24 | |
*** alonma has joined #openstack-cinder | 09:25 | |
*** e0ne has quit IRC | 09:27 | |
*** tommylikehu has joined #openstack-cinder | 09:29 | |
*** reduxio has quit IRC | 09:34 | |
*** reduxio has joined #openstack-cinder | 09:35 | |
*** zhangguoqing has quit IRC | 09:35 | |
*** reduxio has quit IRC | 09:37 | |
*** gcb has quit IRC | 09:37 | |
*** reduxio has joined #openstack-cinder | 09:37 | |
*** e0ne has joined #openstack-cinder | 09:40 | |
openstackgerrit | JohnnyChou proposed openstack/cinder: Enhance Infortrend driver https://review.openstack.org/394284 | 09:45 |
*** mvk has quit IRC | 09:47 | |
*** gcb has joined #openstack-cinder | 09:50 | |
*** yumiriam has joined #openstack-cinder | 09:50 | |
*** aarefiev_afk is now known as aarefiev | 09:55 | |
*** isaacb has quit IRC | 10:01 | |
*** isaacb has joined #openstack-cinder | 10:03 | |
*** jordanP has joined #openstack-cinder | 10:05 | |
*** alyson_ has joined #openstack-cinder | 10:08 | |
*** Jack_Iv has joined #openstack-cinder | 10:12 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/425519 | 10:17 |
*** Jack_Iv has quit IRC | 10:17 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Check if volume node has enough space for image operations https://review.openstack.org/415868 | 10:19 |
*** alonma has quit IRC | 10:24 | |
*** alonma has joined #openstack-cinder | 10:25 | |
*** alonma has quit IRC | 10:29 | |
*** alonma has joined #openstack-cinder | 10:31 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Check if volume node has enough space for image operations https://review.openstack.org/415868 | 10:33 |
*** alonma has quit IRC | 10:35 | |
*** alonma has joined #openstack-cinder | 10:42 | |
*** alonma has quit IRC | 10:46 | |
*** lpetrut has joined #openstack-cinder | 10:51 | |
*** isaacb has quit IRC | 10:52 | |
*** alonma has joined #openstack-cinder | 10:52 | |
*** isaacb has joined #openstack-cinder | 10:53 | |
*** dalgaaf has quit IRC | 10:55 | |
*** lpetrut has quit IRC | 10:55 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Small change to microversion header on devref https://review.openstack.org/425629 | 10:57 |
*** dalgaaf has joined #openstack-cinder | 10:59 | |
*** isaacb has quit IRC | 11:03 | |
*** kaisers has quit IRC | 11:04 | |
*** kaisers has joined #openstack-cinder | 11:05 | |
*** Jack_Iv has joined #openstack-cinder | 11:05 | |
*** kaisers_ has joined #openstack-cinder | 11:08 | |
*** reduxio has quit IRC | 11:09 | |
*** kaisers has quit IRC | 11:09 | |
*** reduxio has joined #openstack-cinder | 11:09 | |
*** kaisers_ has quit IRC | 11:12 | |
*** alonma has quit IRC | 11:13 | |
*** alonma has joined #openstack-cinder | 11:13 | |
*** reduxio has quit IRC | 11:14 | |
*** openstackgerrit has quit IRC | 11:17 | |
*** alonma has quit IRC | 11:18 | |
*** adisky_ has quit IRC | 11:19 | |
*** alonma has joined #openstack-cinder | 11:19 | |
*** alonma has quit IRC | 11:24 | |
*** reduxio has joined #openstack-cinder | 11:25 | |
*** alonma has joined #openstack-cinder | 11:30 | |
*** alonma has quit IRC | 11:35 | |
*** reduxio has quit IRC | 11:38 | |
*** alonma has joined #openstack-cinder | 11:42 | |
*** gcb has quit IRC | 11:43 | |
*** openstackgerrit has joined #openstack-cinder | 11:43 | |
openstackgerrit | Kazumasa Nomura proposed openstack/cinder: Specify the ports for compute nodes and copy functions in VSP drivers https://review.openstack.org/414076 | 11:43 |
*** nicolasbock has joined #openstack-cinder | 11:43 | |
*** alonma has quit IRC | 11:46 | |
*** Jack_Iv has quit IRC | 11:47 | |
*** reduxio has joined #openstack-cinder | 11:48 | |
*** ociuhandu has quit IRC | 11:48 | |
*** alonma has joined #openstack-cinder | 11:50 | |
*** tommylikehu_ has joined #openstack-cinder | 11:50 | |
*** isaacb has joined #openstack-cinder | 11:51 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Refactor volumes summary https://review.openstack.org/425643 | 11:55 |
*** lpetrut has joined #openstack-cinder | 11:59 | |
*** arne_r has quit IRC | 12:02 | |
*** liverpooler has quit IRC | 12:03 | |
openstackgerrit | Kazumasa Nomura proposed openstack/cinder: Restrain the unmanage snapshot for the VSP drivers https://review.openstack.org/421095 | 12:03 |
*** arne_r has joined #openstack-cinder | 12:05 | |
*** bkopilov has quit IRC | 12:05 | |
*** mvk has joined #openstack-cinder | 12:16 | |
*** sofie has quit IRC | 12:18 | |
*** zhangguoqing has joined #openstack-cinder | 12:18 | |
openstackgerrit | Kazumasa Nomura proposed openstack/cinder: Restrain the unmanage snapshot for the VSP drivers https://review.openstack.org/421095 | 12:26 |
*** erlon has joined #openstack-cinder | 12:27 | |
*** catintheroof has joined #openstack-cinder | 12:27 | |
*** ociuhandu has joined #openstack-cinder | 12:28 | |
*** alonma has quit IRC | 12:29 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Fix api-ref status parameter https://review.openstack.org/425656 | 12:29 |
*** alonma has joined #openstack-cinder | 12:30 | |
*** kaisers has joined #openstack-cinder | 12:32 | |
*** DineshBhor has joined #openstack-cinder | 12:34 | |
geguileo | dulek: trivial spureous test: https://review.openstack.org/#/c/425103/ | 12:36 |
*** kaisers has quit IRC | 12:37 | |
*** mjura has quit IRC | 12:38 | |
*** catintheroof has quit IRC | 12:38 | |
*** catintheroof has joined #openstack-cinder | 12:38 | |
dulek | geguileo: data=actual_data - why not data=mock.ANY if we've already checked that? | 12:38 |
dulek | It seems odd to get the value from mock and then check it. ;) | 12:39 |
geguileo | dulek: I only use mock.ANY when I really don't know or don't care about the value | 12:39 |
geguileo | dulek: But in this case I care and I know the value | 12:39 |
geguileo | dulek: so it kind of made more sense to me | 12:39 |
openstackgerrit | Merged openstack/cinder: Test: Fix assert_has_calls dict order bug (QoS) https://review.openstack.org/424214 | 12:40 |
dulek | geguileo: TBH it's not important at all. | 12:40 |
*** mjura has joined #openstack-cinder | 12:40 | |
geguileo | dulek: Oh, but I understand the question | 12:40 |
geguileo | it's a reasonable question :- | 12:41 |
geguileo | ) | 12:41 |
dulek | Nitpicking a quick test fix isn't. :P | 12:41 |
geguileo | lol | 12:42 |
*** kaisers has joined #openstack-cinder | 12:42 | |
*** DineshBhor has quit IRC | 12:43 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/425519 | 12:49 |
*** catinthe_ has joined #openstack-cinder | 12:57 | |
Jack_V | Hi Folks | 12:57 |
Jack_V | Cider ignores glance_catalog_info and glance_api_version options | 12:58 |
*** catintheroof has quit IRC | 12:59 | |
Jack_V | glance_catalog_info = image:glance:internalURL | 12:59 |
Jack_V | glance_api_version = 2 | 12:59 |
Jack_V | but in logs, cinder-scheduler is using publicURL for some reason | 12:59 |
Jack_V | I also tried glance_api_servers = http://lglance_api:9292/ | 13:01 |
*** d-bark has joined #openstack-cinder | 13:01 | |
Jack_V | openstack-cinder-9.1.0-2.el7.noarch | 13:02 |
Jack_V | python-cinder-9.1.0-2.el7.noarch | 13:02 |
Jack_V | python2-cinderclient-1.9.0-1.el7.noarch | 13:02 |
Jack_V | any info? | 13:04 |
openstackgerrit | Alon Marx proposed openstack/cinder: create consistency group mishandles types https://review.openstack.org/424492 | 13:09 |
*** kfarr has joined #openstack-cinder | 13:10 | |
*** markvoelker has quit IRC | 13:14 | |
*** lseki has joined #openstack-cinder | 13:17 | |
*** zhangguoqing has quit IRC | 13:17 | |
*** zhangguoqing has joined #openstack-cinder | 13:17 | |
*** tommylikehu_ has quit IRC | 13:28 | |
*** tommylikehu_ has joined #openstack-cinder | 13:28 | |
*** lpetrut has quit IRC | 13:42 | |
*** isaacb has quit IRC | 13:43 | |
*** bkopilov has joined #openstack-cinder | 13:45 | |
*** lkuchlan has quit IRC | 13:49 | |
*** esker has joined #openstack-cinder | 13:50 | |
*** alonma has quit IRC | 13:51 | |
*** alonma has joined #openstack-cinder | 13:51 | |
*** ducttape_ has quit IRC | 13:53 | |
*** eharney has quit IRC | 13:55 | |
*** dustins|out is now known as dustins | 13:55 | |
*** alonma has quit IRC | 13:55 | |
*** alonma has joined #openstack-cinder | 13:56 | |
*** isaacb has joined #openstack-cinder | 13:57 | |
*** kfarr has quit IRC | 14:02 | |
*** cknight has joined #openstack-cinder | 14:04 | |
*** esker has quit IRC | 14:06 | |
*** eantyshev has joined #openstack-cinder | 14:08 | |
eantyshev | Hello! I got questions about https://review.openstack.org/#/c/147186/50/cinder/volume/drivers/remotefs.py, as it breaks _do_create_snapshot in almost every scenario, but gate didn't notice | 14:11 |
eantyshev | specifically, it adds double call to "qemu-img create", which fails in our Storage CI | 14:12 |
scottda | eantyshev: That sounds like a bug. Could you file a bug in Launchpad? | 14:13 |
scottda | eantyshev: And it sounds like you know the root cause.... | 14:13 |
eantyshev | I think I do | 14:13 |
scottda | eantyshev: Well, you could post a patch as well. | 14:13 |
*** ducttape_ has joined #openstack-cinder | 14:13 | |
openstackgerrit | Helen Walsh proposed openstack/cinder: VMAX driver - removed incorrect six.text_type https://review.openstack.org/425713 | 14:14 |
*** haplo37_ has quit IRC | 14:15 | |
scottda | Does anyone know Helen Walsh's irc handle? | 14:16 |
*** haplo37_ has joined #openstack-cinder | 14:18 | |
*** porrua has joined #openstack-cinder | 14:21 | |
smcginnis | scottda: xyang probably can contact her, but she's not around right now. | 14:22 |
smcginnis | scottda: I don't think I've actually seen Helen on IRC. She must not have a Dunkin Donuts near her. :) | 14:22 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder-specs: Generic backup implementation https://review.openstack.org/379778 | 14:22 |
scottda | smcginnis: Haha...I see Helen posting patches all the time! | 14:22 |
*** jungleboyj has joined #openstack-cinder | 14:23 | |
smcginnis | Yeah, seen a lot from her, just don't think I've actually seen her on IRC. | 14:23 |
scottda | smcginnis: BTW, thanks for help&reviews with the ibm_storage patches. | 14:23 |
smcginnis | scottda: I can probably look her up in our corporate directory now that we're coworkers I guess. | 14:23 |
smcginnis | scottda: No problem - glad we got that one through! | 14:23 |
scottda | smcginnis: No, no big deal. We spotted a bug in EMC/VMAX, but I'll point xing to it | 14:24 |
smcginnis | Good plan | 14:24 |
scottda | smcginnis: I just figured that Helen seems to write all the code for VMAX, and was curious about this mysterious and prolific cinder person... | 14:25 |
smcginnis | scottda: I've actually wondered myself. ;) | 14:25 |
scottda | Haha...really, I'm not sure that there is anyone who posts more patches. Maybe geguileo | 14:25 |
scottda | maybe Helen Walsh is geguileo ....... | 14:26 |
*** eharney has joined #openstack-cinder | 14:27 | |
smcginnis | scottda: Oooh, interesting theory. His alter ego so he can collect paychecks from Red Hat _and_ EMC. :D | 14:27 |
geguileo | lol | 14:28 |
*** gouthamr has joined #openstack-cinder | 14:29 | |
*** liverpooler has joined #openstack-cinder | 14:30 | |
scottda | We still can't run py35 tests without installing python3-dev? | 14:31 |
smcginnis | Yep | 14:31 |
scottda | Have we discussed adding that to test-requirements? | 14:31 |
smcginnis | It's a bindep really. | 14:31 |
*** _ducttape_ has joined #openstack-cinder | 14:31 | |
smcginnis | We have the same thing with py27. | 14:31 |
smcginnis | I've been meaning to checkout out our devref setup instructions. We should update that there. | 14:32 |
smcginnis | scottda: http://docs.openstack.org/developer/cinder/devref/development.environment.html#linux-systems | 14:32 |
scottda | I think it actually might be in there....I'll look | 14:32 |
*** ducttape_ has quit IRC | 14:32 | |
smcginnis | We should update those apt/yum/zypper setup instructions. | 14:32 |
smcginnis | And change that yum instruction to whatever the new package manager is that I can never remember because I was so used to typing yum for so many years. | 14:33 |
smcginnis | Cna probably drop Ubuntu 12 now too. | 14:33 |
scottda | smcginnis: I'm filing a bug ATM... | 14:35 |
smcginnis | :D | 14:35 |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Rebrand and move EQLX driver to dell_emc folder https://review.openstack.org/415565 | 14:37 |
scottda | smcginnis: I quoted you. Feel free to add to https://bugs.launchpad.net/cinder/+bug/1659568 | 14:38 |
openstack | Launchpad bug 1659568 in Cinder "cleanup development.environment.rst" [Undecided,New] | 14:38 |
smcginnis | scottda: Cool, thanks. | 14:39 |
smcginnis | Hah, nice. | 14:39 |
scottda | I like to think of Cinder as "The Hermit Kingdom" | 14:42 |
e0ne | smcginnis: hi. did you cut final version of cinderclient for Ocata? | 14:43 |
e0ne | smcginnis: I worry about https://bugs.launchpad.net/python-cinderclient/+bug/1659561 fix | 14:44 |
openstack | Launchpad bug 1659561 in python-cinderclient "snapshot-list error if using os_volume_api_version 3-3.21" [High,Confirmed] - Assigned to Michael Dovgal (mdovgal) | 14:44 |
smcginnis | e0ne: I have not yet. I need to do that today, but we have a couple things in flight that I would like to land first. | 14:44 |
e0ne | smcginnis: thanks for the info | 14:45 |
smcginnis | e0ne: Looks like Michael has identified the root cause on that one. | 14:45 |
smcginnis | If we can get a patch up, I think we can still get it through. | 14:45 |
e0ne | smcginnis: yes. cool | 14:45 |
mdovgal | smcginnis, yes. i'm working on it right now | 14:47 |
smcginnis | mdovgal: Awesome - Thank you! | 14:47 |
*** _ducttape_ has quit IRC | 14:47 | |
*** pbandark has quit IRC | 14:48 | |
*** d-bark has quit IRC | 14:50 | |
*** mtanino has joined #openstack-cinder | 14:51 | |
*** Yogi1 has joined #openstack-cinder | 14:51 | |
*** mtanino has quit IRC | 14:52 | |
*** rushil has joined #openstack-cinder | 14:54 | |
openstackgerrit | Evgeny Antyshev proposed openstack/cinder: Fix double call to "qemu-img create" https://review.openstack.org/425739 | 14:55 |
eantyshev | eharney, smcginnis: Would you please review that^^^ | 14:56 |
eharney | eantyshev: yes | 14:56 |
*** jungleboyj has quit IRC | 14:56 | |
*** Lee1092 has quit IRC | 14:56 | |
openstackgerrit | Evgeny Antyshev proposed openstack/cinder: Fix double call to "qemu-img create" https://review.openstack.org/425739 | 14:57 |
*** markvoelker has joined #openstack-cinder | 14:57 | |
*** crose has joined #openstack-cinder | 14:58 | |
*** rushil has quit IRC | 15:00 | |
*** esker has joined #openstack-cinder | 15:01 | |
*** jungleboyj has joined #openstack-cinder | 15:03 | |
*** reduxio has quit IRC | 15:03 | |
*** rushil has joined #openstack-cinder | 15:05 | |
*** xyang has joined #openstack-cinder | 15:06 | |
smcginnis | eharney, eantyshev: I vaguely seem to recall there be a purpose for needing to call qemu-img twice. That might be something in a different place though. | 15:06 |
*** lpetrut has joined #openstack-cinder | 15:10 | |
openstackgerrit | Evgeny Antyshev proposed openstack/cinder: Fix double call to "qemu-img create" https://review.openstack.org/425739 | 15:11 |
*** mtanino has joined #openstack-cinder | 15:14 | |
openstackgerrit | Michael Dovgal proposed openstack/python-cinderclient: Fix getting metadata attr error in snapshot-list command https://review.openstack.org/425746 | 15:19 |
*** stvnoyes1 has quit IRC | 15:19 | |
*** stvnoyes has joined #openstack-cinder | 15:20 | |
mdovgal | smcginnis, done. if you can, please, take a look | 15:22 |
smcginnis | mdovgal: Will do, thanks! | 15:22 |
mdovgal | smcginnis, thank you | 15:22 |
*** Jack_Iv has joined #openstack-cinder | 15:25 | |
*** ociuhandu has quit IRC | 15:27 | |
*** psachin has quit IRC | 15:29 | |
openstackgerrit | wangxiyuan proposed openstack/cinder: [api-ref]Add volumes/summary API doc https://review.openstack.org/410510 | 15:31 |
openstackgerrit | wangxiyuan proposed openstack/cinder: [api-ref]Change tenant to project https://review.openstack.org/417739 | 15:31 |
*** Jack_Iv has quit IRC | 15:32 | |
*** Jack_Iv has joined #openstack-cinder | 15:32 | |
openstackgerrit | Merged openstack/python-cinderclient: Support filter volumes by group_id https://review.openstack.org/410064 | 15:33 |
*** diablo_rojo has joined #openstack-cinder | 15:35 | |
openstackgerrit | wangxiyuan proposed openstack/cinder: [api-ref]Fix the volume metadata description error https://review.openstack.org/410098 | 15:36 |
*** stevemar has quit IRC | 15:36 | |
*** stevemar has joined #openstack-cinder | 15:37 | |
*** reduxio has joined #openstack-cinder | 15:39 | |
*** catintheroof has joined #openstack-cinder | 15:39 | |
*** rushil has quit IRC | 15:39 | |
*** reduxio has quit IRC | 15:39 | |
*** reduxio has joined #openstack-cinder | 15:39 | |
*** crushil has joined #openstack-cinder | 15:40 | |
*** pjm6 has quit IRC | 15:42 | |
*** catinthe_ has quit IRC | 15:42 | |
*** lpetrut has quit IRC | 15:44 | |
*** kfarr has joined #openstack-cinder | 15:45 | |
*** zhangguoqing has quit IRC | 15:45 | |
*** alonma has quit IRC | 15:46 | |
openstackgerrit | John Griffith proposed openstack/python-cinderclient: Test commit https://review.openstack.org/425761 | 15:46 |
*** alonma has joined #openstack-cinder | 15:46 | |
smcginnis | jgriffith: I read it anyway. :P | 15:47 |
*** openstackgerrit has quit IRC | 15:48 | |
*** lpetrut has joined #openstack-cinder | 15:51 | |
jungleboyj | jgriffith, Ahhh, my eyes! It burns! | 15:53 |
jungleboyj | -2 with extreme prejudice. | 15:53 |
*** mvk has quit IRC | 15:55 | |
*** openstackgerrit has joined #openstack-cinder | 15:57 | |
openstackgerrit | Scott DAngelo proposed openstack/python-cinderclient: static method to get_server_version https://review.openstack.org/420119 | 15:57 |
scottda | smcginnis: I'd like to get that in the next cinderclient release ^^^^ | 15:57 |
scottda | smcginnis: I'm also going to add another method to that patch in the next hour or so. When do you plan on releasing the client? | 15:58 |
smcginnis | scottda: Apparently as soon as that merges. :P | 15:58 |
scottda | ha | 15:58 |
smcginnis | scottda: It just needs to be some time today. :) | 15:58 |
scottda | smcginnis: OK | 15:58 |
smcginnis | scottda: Have you tested that well locally? | 15:58 |
scottda | yes. | 15:59 |
smcginnis | scottda: OK, great. Just let me know when everythings all set. | 15:59 |
scottda | smcginnis: cool, thx. | 15:59 |
*** Zer0Byte has joined #openstack-cinder | 16:00 | |
*** nkrinner is now known as nkrinner_afk | 16:00 | |
jungleboyj | smcginnis, You had to ask the testing czar that? | 16:02 |
smcginnis | ;) | 16:02 |
xyang | @smcginnis: when are you going to cut o-3 for cinder? | 16:04 |
scottda | xyang: FYI https://bugs.launchpad.net/cinder/+bug/1659481 | 16:06 |
openstack | Launchpad bug 1659481 in Cinder "test_emc_vmax.py should not mock volume_types.get_volume_type_extra_spec globally" [Undecided,New] | 16:06 |
smcginnis | xyang: Probably late today. | 16:06 |
xyang | @smcginnis: thanks | 16:07 |
xyang | scottda: let me check | 16:07 |
smcginnis | If there's anything important to get in (we still have a week to RC1 though) just let me know. | 16:07 |
pots | smcginnis: can you merge https://review.openstack.org/#/c/383452/ (it passed the HPMSA CI last night) | 16:08 |
*** The_Ball has quit IRC | 16:08 | |
xyang | scottda: we'll fix it | 16:08 |
scottda | xyang: cool. We already fixed locally to merge the ibm_storage patch, so no hurry. | 16:09 |
*** alonma has quit IRC | 16:09 | |
smcginnis | pots: How are things coming with the DotHill and Lenovo CIs? | 16:09 |
scottda | xyang: It'll just affect the next patch that follows and uses test of extra_spec | 16:09 |
*** alonma has joined #openstack-cinder | 16:09 | |
pots | i'm still struggling getting devstack stable as the provider; the jenkins/zuul/nodepool stuff is ready to go. | 16:11 |
xyang | scottda: I actually don't know what | 16:11 |
xyang | scottda: what's the best way to fix this | 16:12 |
pots | but the HPMSA CI has been running all this time, and running that patch for a couple of months | 16:12 |
xyang | scottda: do a with mock.patch.object inside the function? | 16:12 |
scottda | xyang: Well, I think we mock per test, instead of globally. But I haven't looked at your tests in that much detail. | 16:12 |
scottda | xyang: Maybe | 16:12 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Add lock acquire/release debug messages https://review.openstack.org/425768 | 16:13 |
xyang | scottda: I thought that is mock for that test only | 16:13 |
pots | smcginnis: so the HPMSA driver shouldn't have been marked unsupported | 16:13 |
*** The_Ball has joined #openstack-cinder | 16:13 | |
mdovgal | erlon, hi. do you here? | 16:13 |
*** alonma has quit IRC | 16:13 | |
erlon | mdovgal: hey | 16:16 |
pots | smcginnis: you probably recall that it's really just one driver with 3 different brand names, so the HPMSA CI tests all the functionality | 16:17 |
mdovgal | erlon, remember, yesterday we discussed snapshot bug after the meeting? there one more side effect because of it) do you have a minute? | 16:18 |
*** mdnadeem has quit IRC | 16:19 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Rebrand and move EQLX driver to dell_emc folder https://review.openstack.org/415565 | 16:20 |
*** alonma has joined #openstack-cinder | 16:20 | |
mdovgal | erlon, just a view problem, but it can disorient somebody | 16:21 |
erlon | mdovgal: a view? what do you mean? | 16:23 |
mdovgal | erlon, http://paste.openstack.org/show/596612/ | 16:23 |
mdovgal | erlon, look at the size column | 16:24 |
mdovgal | erlon, when we create record in db here https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L851, we use volume size and api will return wrong result( | 16:25 |
*** alonma has quit IRC | 16:25 | |
mdovgal | but after the operation will be finished, everything will be ok | 16:25 |
*** cfriesen has left #openstack-cinder | 16:26 | |
*** Zer0Byte has quit IRC | 16:27 | |
erlon | mdovgal: hmm, that is what Im noticing, theres a temporary status where the snapshot has the wrong size | 16:27 |
erlon | mdovgal: my first impulse is to pass the snapshot, instead of the volume object to that function, and then there extract the volume, to use where needed and pass the correct size to snapshot.create() | 16:30 |
*** knomura has joined #openstack-cinder | 16:31 | |
*** alonma has joined #openstack-cinder | 16:32 | |
*** esker has quit IRC | 16:33 | |
*** lpetrut has quit IRC | 16:33 | |
*** alonma has quit IRC | 16:36 | |
*** bardia has joined #openstack-cinder | 16:37 | |
*** bardia_ has joined #openstack-cinder | 16:37 | |
*** alonma has joined #openstack-cinder | 16:38 | |
*** bardia has quit IRC | 16:41 | |
*** e0ne has quit IRC | 16:41 | |
*** tommylikehu_ has quit IRC | 16:42 | |
*** tommylikehu_ has joined #openstack-cinder | 16:42 | |
*** alonma has quit IRC | 16:42 | |
*** tommylikehu_ has quit IRC | 16:43 | |
*** tommylikehu_ has joined #openstack-cinder | 16:43 | |
mdovgal | erlon, at the time when this func is executed here https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L1697, we don't know about the real snapshot size( | 16:43 |
mdovgal | erlon, and frankly speaking, i'm not sure, that i understood your idea( | 16:43 |
*** tommylikehu_ has quit IRC | 16:43 | |
*** tommylikehu_ has joined #openstack-cinder | 16:44 | |
*** tommylikehu_ has quit IRC | 16:44 | |
*** tommylikehu_ has joined #openstack-cinder | 16:45 | |
*** tommylikehu_ has quit IRC | 16:45 | |
*** tommylikehu_ has joined #openstack-cinder | 16:45 | |
jgriffith | mdovgal erlon I just want to emphatically and clearly state again that this is NOT a bug, snapshots don't have a size attribute | 16:46 |
*** tommylikehu_ has quit IRC | 16:46 | |
jgriffith | it's not a bug * 100000 | 16:46 |
jgriffith | :) | 16:46 |
*** tommylikehu_ has joined #openstack-cinder | 16:46 | |
jgriffith | we will never know the size of a snapshot, unless we ask the specific backend, and in which case it's likely meaningless anyway | 16:47 |
*** tommylikehu_ has quit IRC | 16:47 | |
*** tommylikehu_ has joined #openstack-cinder | 16:47 | |
erlon | jgriffith: is is a bug! if you have a snapshot, that was created with the wrong size, when you create a volume from it, the volume will have the wrong size | 16:47 |
eharney | we use snapshot['volume_size'] for GB quota calculations too | 16:47 |
*** tommylikehu_ has quit IRC | 16:47 | |
jgriffith | right | 16:48 |
erlon | jgriffith: that controversial field its not the size of the snapshot, its the size of the volume at the time the snapshot was created | 16:48 |
*** lpetrut has joined #openstack-cinder | 16:48 | |
jgriffith | erlon correct | 16:48 |
jgriffith | I'm saying "snapshot-size" doesn't exist | 16:48 |
jgriffith | volume_size yes, and that's what matters | 16:48 |
jgriffith | there's no such thing as "snapshot-size" | 16:49 |
erlon | jgriffith: yes, that was we decided to keep the field name as it is | 16:49 |
*** alonma has joined #openstack-cinder | 16:49 | |
jgriffith | erlon I keep logging in and seeing people refer to "snapshot size bug". so hence my concern | 16:50 |
jgriffith | erlon what's the problem you're trying to solve anyway? | 16:50 |
erlon | mdovgal: the thing is, what is the quota this snapshot will consume? the first size, or the size after it has discovered the real size | 16:50 |
openstackgerrit | Scott DAngelo proposed openstack/python-cinderclient: static method to get_highest_client_server_version https://review.openstack.org/425785 | 16:50 |
erlon | ? | 16:50 |
jgriffith | there we go with real-size again :) | 16:50 |
jgriffith | oh well | 16:50 |
jgriffith | I tried | 16:51 |
scottda | smcginnis: That latest cinderclient patch ^^^ contains the desired method for Nova to use for new APIs. So it'd be good to get that in. | 16:51 |
erlon | jgriffith: real size of the volume at the snapshot craetion time | 16:51 |
erlon | jgriffith: :) | 16:51 |
jgriffith | erlon yeah, like I said before you're going to have some pretty tough challenges there | 16:52 |
erlon | jgriffith: its just a way of viewing it | 16:52 |
smcginnis | erlon: jgriffith is correct. We do not track the size of the snapshot. It is the size of the volume at the time the snapshto is created. What are you seeing as a bug? | 16:52 |
*** alonmarx has joined #openstack-cinder | 16:52 | |
smcginnis | scottda: Thanks, I'll take a look. | 16:52 |
*** alonma has quit IRC | 16:53 | |
*** xyang has quit IRC | 16:54 | |
erlon | smcginnis: jgriffith: the bug is, you create a snapshot, store the, volume_size, you extend the volume, and unmanage, both volume and snapshot, after you manage the snapshot, its volume_size should be the same as when it was created, which is not | 16:54 |
openstackgerrit | Tom Swanson proposed openstack/cinder: Dell EMC SC: Delete doesn't validate provider_id https://review.openstack.org/425788 | 16:54 |
jgriffith | erlon oh, well why didn't you say so in the first place :) | 16:54 |
*** e0ne has joined #openstack-cinder | 16:54 | |
scottda | smcginnis: You can test those locally with this: | 16:54 |
erlon | smcginnis: jgriffith: then the bug, if you create a volume from that snapshot, what will happen? | 16:54 |
*** e0ne has quit IRC | 16:55 | |
erlon | jgriffith: the quotas will be broken as well | 16:55 |
scottda | https://www.irccloud.com/pastebin/QBaAOFQs/test_client | 16:55 |
*** tesseract has quit IRC | 16:55 | |
jgriffith | erlon although I'm not sure how that happens, the volume_size column in the snap isn't an FK | 16:55 |
jgriffith | erlon are you sure it's being changed in the DB? | 16:55 |
jgriffith | erlon it's an independent key for this very reason | 16:56 |
jgriffith | erlon https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/models.py#L673 | 16:57 |
erlon | jgriffith: yes, but the problem with manage is that when API first receives that manage request, it creates the snapshot, and saves in the DB with the current volume.size, then, after querying the driver (here mdovgal fixed) it saves the snapshot.volume_size correct | 16:57 |
jgriffith | so you're saying somwhere in the flow extend-volume is going back and modifying all of the snapshots for the volume? | 16:57 |
jgriffith | erlon oh f'ing manage snapshots | 16:57 |
jgriffith | stupid shit | 16:58 |
jgriffith | yeah, good luck with that | 16:58 |
erlon | jgriffith: so, theres a leap of time (while volume status is creating) where the volume_size is incorrect, and the possibiliby a quota problem | 16:58 |
jgriffith | erlon hey, I know a good way to fix it really easy, "DONT allow importing snapshots" | 16:59 |
erlon | jgriffith: now that you understand you can give us a solution right? ;) | 16:59 |
jgriffith | there's no value in it anyway | 16:59 |
Swanson | I truly hope "f'ing manage snapshots" was the name of the blueprint that added that. | 16:59 |
*** isaacb has quit IRC | 16:59 | |
jgriffith | Swanson no, but it was my comment | 16:59 |
jgriffith | erlon so yeah, you're screwed | 16:59 |
erlon | mdovgal: is :) | 17:00 |
jgriffith | ok.. mdovgal is screwed :) | 17:00 |
jgriffith | he/she could solve it for a specific backend case, but not generally for all of them | 17:00 |
*** alonma has joined #openstack-cinder | 17:00 | |
jgriffith | unless we add it as a required part of the api call in the driver | 17:00 |
jgriffith | which is fine I guess | 17:01 |
*** rajinir has joined #openstack-cinder | 17:01 | |
jgriffith | but again I go back to the "why" | 17:01 |
jgriffith | it's a lot of wonky code for no real value | 17:01 |
jgriffith | you want to import a snapshot? Ok... restore that snapshot outside of Cinder on your device to a volume, and import the volume | 17:01 |
erlon | jgriffith: yeap, there are a lot of things like that in Cinder | 17:02 |
*** raunak has joined #openstack-cinder | 17:02 | |
jgriffith | if you have the dependency problem that some have (ie volumes from snaps rely on the original chain of objects) then yeah, it sucks no matter what | 17:02 |
*** ebalduf has quit IRC | 17:02 | |
jgriffith | erlon yeah, there sure are | 17:02 |
*** liverpooler has quit IRC | 17:03 | |
jgriffith | erlon I'd love it if we all agreed to be a bit more strict on that | 17:03 |
jgriffith | erlon barring that, the best solution I can think of is that it's a required parameter for the manage command | 17:03 |
Swanson | Is gerrit epically slow today? | 17:03 |
jgriffith | in other words, punt and force the burden back on to the people that want to use the feature (all 3 of them) | 17:04 |
erlon | jgriffith: the dependency problem happends in a lot of drivers, the remotefs dependents | 17:04 |
jgriffith | erlon yeah, and I've never thought of a way to deal with that unfortunately | 17:04 |
*** liverpooler has joined #openstack-cinder | 17:04 | |
jgriffith | I tried it over beers with some people a long time ago and everything I thought of ended up not working | 17:04 |
*** pbandark has joined #openstack-cinder | 17:04 | |
erlon | jgriffith: I never seen a feature being removed, that sounds very rude lol | 17:05 |
jgriffith | actually it was jdurgin in Portland I think :) | 17:05 |
*** ebalduf has joined #openstack-cinder | 17:05 | |
*** alonma has quit IRC | 17:05 | |
*** reduxio has quit IRC | 17:05 | |
jgriffith | erlon nah, not rude... *efficient* | 17:05 |
*** reduxio has joined #openstack-cinder | 17:06 | |
erlon | jgriffith: I just feel that people have the idea that, you *never* remove a feature, you only add more | 17:06 |
erlon | jgriffith: so you software gets better and better and bloated, ops | 17:07 |
jgriffith | erlon and that's the biggest problem with a lot of software out there today | 17:07 |
jgriffith | that's silly | 17:07 |
jgriffith | leads to bloat and eventual death of a software product | 17:07 |
jgriffith | look at Windows 7 :) | 17:07 |
jgriffith | oh... even better, Microsoft Office | 17:07 |
jgriffith | we'll leave everything, and keep adding new things around it and let you use either | 17:08 |
jgriffith | it doesn't work out well | 17:08 |
Swanson | Everytime you remove a feature a sales person gets a stress test. | 17:08 |
jgriffith | AND if you do that you REALLY need to have an architecture to support it, we don't | 17:08 |
jgriffith | sales people aren't my problem anymore :) | 17:09 |
*** pbandark has quit IRC | 17:09 | |
erlon | jgriffith: I used the old and good XP for more than 10 years | 17:09 |
erlon | moved to 7 now, and Im liking it | 17:10 |
*** reduxio has quit IRC | 17:10 | |
erlon | I installed it over Mac OS Snow Leopard | 17:10 |
jgriffith | how long did you use Windows 8 for :) | 17:10 |
erlon | hell yeah! | 17:10 |
Swanson | I'm still running 8.1. | 17:10 |
jgriffith | So take Windows7 and keep all the features, but add a new way to do everything ala Win10 and you get crap | 17:10 |
erlon | haha is there a 8 version? | 17:11 |
erlon | Ill use 7 for another 10 good years | 17:11 |
*** crushil has quit IRC | 17:11 | |
Swanson | Love 10 at home. Great twitter app. | 17:11 |
erlon | Swanson: does it have the start button? | 17:12 |
erlon | Swanson: an operating system without that is useless :P | 17:12 |
*** ducttape_ has joined #openstack-cinder | 17:12 | |
jgriffith | we've digressed to the point of no return | 17:12 |
*** xyang has joined #openstack-cinder | 17:13 | |
Swanson | erlon, you can get it back if you want it. | 17:13 |
Swanson | erlon, it's cortana you can't trust. | 17:13 |
*** xyang has quit IRC | 17:14 | |
erlon | ow my! | 17:14 |
*** mjura has quit IRC | 17:16 | |
jgriffith | erlon mdovgal so back to the problem :) | 17:20 |
erlon | jgriffith: proceed | 17:21 |
jgriffith | erlon mdovgal thoughts on requiring a volume-size for the snapshot-manage cmd? | 17:21 |
jgriffith | or at least a min-size? | 17:21 |
jgriffith | doesn't have to be perfect | 17:21 |
hemna | any reviews that need to happen today? | 17:21 |
jgriffith | oh... hey wait | 17:21 |
jgriffith | erlon mdovgal we don't support reduce, only extend | 17:22 |
jgriffith | erlon mdovgal so why is this a problem again? | 17:22 |
jgriffith | if a user reduced the size of their volume after taking a snapshot, and then managed the volume and the snapshot then honestly I can't help them | 17:23 |
erlon | jgriffith: if is to not be perfect we should keep a solution closer to what mdovgal is proposing, just fixing the quotas after we get the real snapshot size | 17:23 |
erlon | jgriffith: by the way, if the driver cant return the snapshot size (ie. the size of volume at the snap creation) tje driver cant support the manage | 17:24 |
jgriffith | erlon mdovgal link to patch? | 17:24 |
erlon | so, we have a way to know the correct patch | 17:24 |
erlon | jgriffith: mdovgal: brb | 17:24 |
*** arne_r has quit IRC | 17:24 | |
*** _ducttape_ has joined #openstack-cinder | 17:26 | |
*** bardia has joined #openstack-cinder | 17:27 | |
hemna | jgriffith, on the cinderclient attach/detach v2 patch. why do we have --all-tenants and --all_tenants cmdln args? | 17:29 |
jgriffith | hemna backward compatability | 17:30 |
*** ducttape_ has quit IRC | 17:30 | |
hemna | for a new call? | 17:30 |
jgriffith | hemna somebody at some point introduced that we should make _ and - both work and now it's everywhere | 17:30 |
hemna | ugh | 17:30 |
jgriffith | hemna happy to remove it | 17:30 |
hemna | ok | 17:30 |
jgriffith | honestly if that's your biggest gripe I'm good | 17:30 |
hemna | nah it's ok | 17:30 |
hemna | It's not a gripe really | 17:31 |
hemna | I was just confused by it and curious | 17:31 |
jgriffith | hemna oh come on, make it a gripe :) | 17:31 |
hemna | lolz | 17:31 |
jgriffith | cuz otherwise you'll find something more difficult :( | 17:31 |
*** bardia_ has quit IRC | 17:31 | |
hemna | so I suppose it's 'better' to be consistent with the other calls | 17:32 |
hemna | so nm. | 17:32 |
jgriffith | hemna so if you look at other calls like list it's there too; maybe we should not include it on this one though | 17:34 |
jgriffith | hemna and I mean other V3 calls | 17:34 |
hemna | I see the same sort of pattern with volume-id and volume_id | 17:34 |
hemna | it's whatever | 17:34 |
hemna | maybe I'm just being anal. | 17:35 |
jgriffith | yeah, and it's dumb | 17:35 |
jgriffith | I mean the pattern, not you pointing it out | 17:35 |
hemna | I'm cool with being consistently dumb. | 17:35 |
jgriffith | I agree with you | 17:35 |
jgriffith | LOL | 17:35 |
jgriffith | sheepl | 17:35 |
openstackgerrit | Helen Walsh proposed openstack/cinder: VMAX driver - remove global mock of volume_types https://review.openstack.org/425803 | 17:36 |
*** Yogi1 has quit IRC | 17:36 | |
*** esker has joined #openstack-cinder | 17:39 | |
jgriffith | smcginnis any opinion on that? | 17:41 |
jgriffith | it's sort of a big deal to me cuz once it's done it's done to erlon 's point about never removing a feature :) | 17:41 |
*** mriedem has quit IRC | 17:41 | |
* smcginnis just got back, reading backscroll | 17:43 | |
*** liverpooler has quit IRC | 17:43 | |
*** liverpoo1er has joined #openstack-cinder | 17:43 | |
scottda | hemna: that VMAX patch ^^^ is the fix for our driver problem | 17:48 |
smcginnis | jgriffith: Are you asking about the _ vs -? | 17:49 |
hemna | ah because they globally mocked it and never removed it, which is what we kinda suspected. | 17:49 |
jgriffith | @smcginnis yeah, I think I'm going to drop the '_', but can't remember if there's another good reason for them | 17:49 |
jgriffith | I seem to recall there's something internally that uses those | 17:49 |
*** jose-phillips has joined #openstack-cinder | 17:49 | |
smcginnis | jgriffith: I've never seen a good reason. And I was confused about that as well at first. I'd say drop it. | 17:49 |
jgriffith | @smcginnis k, and if we find a bug because of it no biggy, we can put them back | 17:50 |
smcginnis | jgriffith: Well, if it's internal then maybe we have a chance of actually fixing it. ;) | 17:50 |
hemna | so...what you are saying is...I can gripe? | 17:50 |
smcginnis | jgriffith: Very true! | 17:50 |
jgriffith | hemna nope, what I"m saying is that I'm making sure I excercise your quota for the week | 17:50 |
jgriffith | so now you're done :) | 17:50 |
hemna | ok, phew. don't want to let me get out of hand now. | 17:51 |
*** ripsomeday has left #openstack-cinder | 17:51 | |
hemna | I was about to start talking about gerrit UI and stuff. | 17:51 |
jgriffith | cats and dogs living together... mass hysteria and anarchy | 17:51 |
*** _ducttape_ has quit IRC | 17:55 | |
openstackgerrit | John Griffith proposed openstack/python-cinderclient: Attach/Detach V2 https://review.openstack.org/387716 | 17:55 |
*** ducttape_ has joined #openstack-cinder | 17:55 | |
openstackgerrit | Raunak Kumar proposed openstack/cinder: Fix Qos for clone for Nimble Storage Driver https://review.openstack.org/424933 | 17:56 |
*** _ducttape_ has joined #openstack-cinder | 17:56 | |
*** _ducttape_ has quit IRC | 17:58 | |
*** Jack_Iv has quit IRC | 17:59 | |
*** kfarr has quit IRC | 17:59 | |
*** david-lyle has quit IRC | 17:59 | |
*** Apoorva has joined #openstack-cinder | 17:59 | |
*** ducttape_ has quit IRC | 18:00 | |
smcginnis | hemna: I doubt anyone is running CI against the driverfixes branch. | 18:01 |
hemna | I thought the hp CI was picking up jobs from there too | 18:02 |
smcginnis | hemna: We didn't require it for that branch if they are. I think we explicitly said we don't necessarily expect the code in driverfixes/* to actually run. | 18:03 |
hemna | ok | 18:03 |
smcginnis | In fact, there was some discussion of intentially making sure it didn't so folks didn't think they could just run from there. | 18:03 |
hemna | I can remove the -1 | 18:03 |
hemna | but I don't think HP's CI is working at all right now or has been for a long time. | 18:03 |
openstackgerrit | Merged openstack/cinder: Eager load projects when getting types by group https://review.openstack.org/425159 | 18:03 |
smcginnis | hemna: One Pike opens up, looks like there's a whole list of drivers that are going to need the unsupported flag based on the last report I ran. :/ | 18:04 |
hemna | yah | 18:04 |
hemna | well, why can't we do it today? :P | 18:04 |
smcginnis | Haha. We _could_. I would just feel bad doing it this close to the final cut. | 18:05 |
*** arch-nemesis has joined #openstack-cinder | 18:05 | |
smcginnis | Though there is an arugment that they are out of CI compliance and it should have the flag. | 18:05 |
hemna | to vendors that haven't been participating? | 18:05 |
hemna | I dunno man. | 18:05 |
hemna | I thought this was the entire reason for that flag | 18:06 |
hemna | vs. before, we nuked em, which was harsh | 18:06 |
hemna | I don't feel bad about setting the flag to drivers that aren't participating or making an effort, especially as the deadline is here. | 18:07 |
smcginnis | I'm running another report now. I'll paste that once it's done. | 18:07 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/425519 | 18:07 |
smcginnis | hemna: That is a fair point. | 18:07 |
hemna | lets see what other core's think. | 18:07 |
smcginnis | hemna: +1 | 18:07 |
hemna | we aren't nuking their drivers | 18:07 |
jgriffith | I'm fine with flagging them (now that mines running again) :) | 18:08 |
smcginnis | hah | 18:08 |
hemna | hehe | 18:09 |
openstackgerrit | Merged openstack/cinder: Fix api-ref status parameter https://review.openstack.org/425656 | 18:09 |
openstackgerrit | Merged openstack/cinder: Small change to microversion header on devref https://review.openstack.org/425629 | 18:10 |
*** Jack_Iv has joined #openstack-cinder | 18:10 | |
*** dinob has joined #openstack-cinder | 18:12 | |
*** arch-nemesis has quit IRC | 18:12 | |
*** Jack_Iv has quit IRC | 18:13 | |
*** xinli has joined #openstack-cinder | 18:13 | |
*** Jack_Iv has joined #openstack-cinder | 18:13 | |
*** ebalduf has quit IRC | 18:14 | |
*** crushil has joined #openstack-cinder | 18:15 | |
*** ociuhandu has joined #openstack-cinder | 18:16 | |
*** Jack_Iv has quit IRC | 18:17 | |
*** knomura has quit IRC | 18:18 | |
*** alonmarx has quit IRC | 18:19 | |
*** xyang has joined #openstack-cinder | 18:19 | |
*** lpetrut has quit IRC | 18:20 | |
*** dulek has quit IRC | 18:20 | |
*** ebalduf has joined #openstack-cinder | 18:20 | |
*** pkoniszewski has quit IRC | 18:22 | |
*** xek_ has joined #openstack-cinder | 18:22 | |
*** xek has quit IRC | 18:22 | |
*** dulek has joined #openstack-cinder | 18:23 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/425519 | 18:23 |
smcginnis | hemna, jgriffith: http://paste.openstack.org/show/596630/ | 18:24 |
*** pkoniszewski has joined #openstack-cinder | 18:24 | |
hemna | 0% | 18:24 |
hemna | doh | 18:24 |
jgriffith | smcginnis I'm suspicous of any 100% pass rates | 18:25 |
hemna | jgriffith, +1 | 18:25 |
hemna | heh Lenovo also 0% | 18:25 |
hemna | wow lots under 40% | 18:26 |
jgriffith | wow, those numbers are pretty awful | 18:26 |
hemna | :( | 18:26 |
jgriffith | not just the number of 0% but the the average success rates | 18:26 |
hemna | yah that's very concerning | 18:26 |
hemna | so what do you think about marking anyone under 40% ? | 18:27 |
hemna | or pick a % | 18:27 |
jungleboyj | hemna, Yeah, I found out yesterday the person to contact. I will get on them today. | 18:29 |
hemna | so.... | 18:30 |
hemna | fwiw, I'm not sure about that report smcginnis | 18:30 |
*** ebalduf has quit IRC | 18:30 | |
hemna | it says the IBM flash system CI last success was 11/28/2016 | 18:30 |
hemna | yet, it reports success here: https://review.openstack.org/#/c/401285/ | 18:31 |
openstackgerrit | Merged openstack/python-cinderclient: Fix getting metadata attr error in snapshot-list command https://review.openstack.org/425746 | 18:31 |
hemna | so I has confused | 18:31 |
*** rcernin has joined #openstack-cinder | 18:32 | |
hemna | oh | 18:35 |
hemna | I think I might know | 18:35 |
hemna | that flashsystem-tempest-dsvm-full-iscsi is reporting under IBM Storage CI | 18:35 |
hemna | I'll ping our CI guy about that and get that changed. | 18:36 |
scottda | Or maybe that's what we want hemna ? | 18:36 |
*** jungleboyj has quit IRC | 18:36 | |
*** alyson_ has quit IRC | 18:37 | |
scottda | Since they are all in the same Lab now. | 18:37 |
hemna | yah I'm ok with it, but we need to change the IBM flash system storage drivers CI name then. | 18:37 |
hemna | I can throw that patch together | 18:38 |
*** ebalduf has joined #openstack-cinder | 18:38 | |
hemna | can we get it in today? | 18:38 |
hemna | hmm | 18:40 |
* hemna is confused | 18:40 | |
hemna | ugh, the ibm drivers CI name is all borked | 18:41 |
scottda | Darn that Jay! | 18:41 |
*** jungleboyj has joined #openstack-cinder | 18:41 | |
hemna | so not a single ibm driver lists "IBM_STORAGE_CI" as it's name | 18:41 |
hemna | but there are 3 reporting as it | 18:42 |
*** mvk has joined #openstack-cinder | 18:42 | |
*** ebalduf has quit IRC | 18:43 | |
*** alonma has joined #openstack-cinder | 18:46 | |
*** alonmarx has joined #openstack-cinder | 18:47 | |
*** crushil has quit IRC | 18:49 | |
*** tommylikehu_ has joined #openstack-cinder | 18:49 | |
*** ebalduf has joined #openstack-cinder | 18:51 | |
*** alonma has quit IRC | 18:51 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: IBM driver update CI_WIKI_NAME https://review.openstack.org/425835 | 18:51 |
hemna | smcginnis, ^^ | 18:52 |
*** jordanP has quit IRC | 18:53 | |
jungleboyj | hemna, smcginnis First CI angrygram sent in Lenovo. | 18:54 |
*** tommylikehu_ has quit IRC | 18:54 | |
hemna | 0% is kinda suspicious too | 18:55 |
hemna | especially since it says last seen 1/26/2017 | 18:55 |
hemna | would be cool if that report also gave URLs to the last success and last seen | 18:56 |
*** yumiriam has quit IRC | 18:59 | |
*** ebalduf has quit IRC | 19:00 | |
*** lpetrut has joined #openstack-cinder | 19:01 | |
*** harlowja has quit IRC | 19:02 | |
*** xyang has quit IRC | 19:02 | |
openstackgerrit | John Griffith proposed openstack/cinder: Zero out SolidFire capacity when unreachable https://review.openstack.org/425842 | 19:03 |
*** jdurgin1 has quit IRC | 19:03 | |
*** crushil has joined #openstack-cinder | 19:05 | |
*** reduxio has joined #openstack-cinder | 19:05 | |
*** ebalduf has joined #openstack-cinder | 19:07 | |
hemna | smcginnis, do you have the yaml file with the CI names for lastcomment.py ? | 19:07 |
hemna | or are you using the ci.yaml in the repo? | 19:08 |
Apoorva | hemna http://paste.openstack.org/show/596634/ | 19:09 |
*** reduxio has quit IRC | 19:09 | |
hemna | he must have hacked lastcomment.py to output in that format | 19:10 |
hemna | Apoorva, if that's the up to date list, we should do a pull request to the repo | 19:10 |
hemna | the reports I'm generating are useless | 19:11 |
hemna | heh | 19:11 |
scottda | Could use some eyes on this: https://review.openstack.org/#/c/420119/ | 19:12 |
scottda | static method to get_server_version for the cinderclient | 19:13 |
hemna | what's the url ? | 19:15 |
smcginnis | hemna: Back. That might need some more tweaks, but it would be good to get it updated in the repo. | 19:16 |
scottda | hemna: The cinder endpoint | 19:16 |
scottda | hemna: Which I guess is not very clear | 19:17 |
scottda | :( | 19:17 |
hemna | scottda, yah | 19:17 |
scottda | OK, well I can re-spin, but maybe after others chime in... | 19:17 |
scottda | Since time is running short, and Jenkins is taking some time. | 19:18 |
hemna | scottda, what is that supposed to return? | 19:18 |
hemna | I'm trying to print it out and it's bitching | 19:18 |
scottda | The min and max APIVersion that the server supports | 19:18 |
hemna | oh it's a tuple | 19:18 |
scottda | https://www.irccloud.com/pastebin/1CMhzVvf/ | 19:19 |
scottda | It will take the URL from the Service catalog, or just the naked endpoint | 19:19 |
hemna | Min = API Version Major: 3, Minor: 0 Max = API Version Major: 3, Minor: 27 | 19:20 |
hemna | so min = a string that you need to parse | 19:20 |
hemna | and so is max | 19:20 |
scottda | Yeah | 19:20 |
hemna | hrmm | 19:20 |
scottda | I also have this https://review.openstack.org/#/c/425785/ | 19:20 |
scottda | That will be better for Nova and Horizon | 19:21 |
hemna | is this expected to be something that you can take action on, or just print out? | 19:21 |
scottda | Horizon will use it (probably better to use the second, #425785) | 19:21 |
hemna | wouldn't it be better to return a dict that you don't have to parse? and/or take a param that says just give me a string? | 19:21 |
hemna | dunno | 19:21 |
scottda | HOrizon can then show the appropriate buttons and widgets based on what the server API version is | 19:22 |
scottda | Nova will use it to see if the new attach APIs are present | 19:22 |
hemna | so they have to parse out each of those strings to find the numbers then | 19:22 |
scottda | 2nd patch returns a float | 19:22 |
hemna | http://paste.openstack.org/show/596637/ | 19:23 |
scottda | ? | 19:24 |
hemna | API Version Major: 3, Minor: 0 | 19:24 |
hemna | so they will have to parse that string to find 3 | 19:24 |
hemna | to make a decision | 19:24 |
scottda | try get_highest_client_server_version | 19:24 |
scottda | 2nd patch | 19:25 |
hemna | instead of getting a dict {min: {major: 3, minor: 0}, max: {major: 3, minor: 27}} | 19:25 |
hemna | see what I mean? | 19:25 |
hemna | human consumption vs. python consumption is what I'm getting at | 19:25 |
scottda | Yeah, I'm not sure we even want to expose the first patch. Second is what you really want | 19:25 |
scottda | But I agree with what you are saying.. | 19:25 |
hemna | https://review.openstack.org/#/c/420119/ | 19:26 |
hemna | I'm confused | 19:26 |
hemna | are you saying that patch is not right? | 19:26 |
hemna | and there is another patch somewhere else that I should use/test instead? | 19:26 |
* hemna is confused | 19:26 | |
smcginnis | jgriffith: How did you already get a merge conflict on that client patch. | 19:27 |
smcginnis | jgriffith: You've just got skillz there. | 19:27 |
*** AndroUser has joined #openstack-cinder | 19:27 | |
hemna | scottda, or am I high? I see your commit message says it returns APIVersion objects | 19:27 |
jgriffith | @smcginnis really? | 19:27 |
smcginnis | hemna: scottda's the one in Colorado | 19:27 |
scottda | ha | 19:27 |
hemna | so maybe I'm confused because I'm dumping the output as strings, which the APIVersion object converts itself | 19:27 |
scottda | yes, it does return APIVersion objects | 19:28 |
hemna | ok | 19:28 |
scottda | And the second one just returns a float. | 19:28 |
hemna | ok nm I'm dumb | 19:28 |
*** AndroUser has quit IRC | 19:28 | |
*** xyang has joined #openstack-cinder | 19:28 | |
scottda | smcginnis: or jgriffith do either of you have a minute to look at https://review.openstack.org/#/c/420119 , before I spin a new patch? | 19:29 |
openstackgerrit | John Griffith proposed openstack/python-cinderclient: Attach/Detach V2 https://review.openstack.org/387716 | 19:30 |
scottda | and https://review.openstack.org/#/c/425785/ | 19:30 |
jgriffith | scottda I am looking at it, trying to grock it a bit | 19:30 |
scottda | cool. Thx. | 19:30 |
scottda | Trigger Warning: contains microversions. | 19:31 |
hemna | scottda, ok it looks good, minus the verbiage about the url | 19:31 |
scottda | Commit message will be changed to state URL is Cinder endpoint... | 19:31 |
hemna | maybe a release note? | 19:31 |
hemna | do we do release notes for minderclient ? | 19:32 |
hemna | arg chant... | 19:32 |
hemna | !! | 19:32 |
openstack | hemna: Error: "!" is not a valid command. | 19:32 |
scottda | hemna: yup | 19:32 |
hemna | still don't have table flip. l a m e. | 19:32 |
smcginnis | Dang it~ | 19:33 |
*** xyang has quit IRC | 19:33 | |
jgriffith | scottda comment/question added | 19:33 |
scottda | thx | 19:34 |
*** xyang has joined #openstack-cinder | 19:36 | |
smcginnis | hemna, scottda: Another issue with that IBM Storage CI. Maybe it's still being worked on, but it's only running three tests for at least 5 drivers. Not doing both iSCSI and FC. | 19:37 |
hemna | smcginnis, +1 | 19:37 |
hemna | I noticed that too | 19:38 |
*** porrua_ has joined #openstack-cinder | 19:38 | |
hemna | I'll remedy that | 19:38 |
smcginnis | hemna: Thanks! | 19:39 |
*** crushil has quit IRC | 19:39 | |
smcginnis | So I think I'm just waiting for jgriffith's API patch to merge and scottda to get high before I cut the client. Anything else I'm missing? | 19:40 |
scottda | cough...cough | 19:41 |
smcginnis | ;) | 19:41 |
*** porrua has quit IRC | 19:42 | |
scottda | Bugger! Hard to test the https case, since I don't have secure endpoint.... | 19:43 |
*** xyang has quit IRC | 19:45 | |
*** david-lyle has joined #openstack-cinder | 19:45 | |
*** Jack_Iv has joined #openstack-cinder | 19:45 | |
*** xyang has joined #openstack-cinder | 19:47 | |
smcginnis | scottda: Theoretically it shouldn't really make a difference, right? | 19:48 |
openstackgerrit | Scott DAngelo proposed openstack/python-cinderclient: static method to get_server_version https://review.openstack.org/420119 | 19:48 |
scottda | smcginnis: Nope | 19:48 |
scottda | And I added a unit test for that | 19:48 |
*** xyang has quit IRC | 19:50 | |
scottda | What do you think about patch for get_highest_client_server_version ? | 19:52 |
*** xyang has joined #openstack-cinder | 19:52 | |
scottda | I'd like to bikeshed on that name for a bit.... | 19:52 |
scottda | It's really the min(cinderclient.MAX_VERSION, server.max_version) | 19:53 |
waj334 | What changed in the delete_metadata function between 2.0 and 3.14? I'm getting this error in a functional test: "Failed to unset volume property: API version '3.0' is not supported on 'cinderclient.v3.volumes.delete_metadata' method." | 19:53 |
scottda | So maybe just shorten to "get_high" ? | 19:53 |
scottda | waj334: Are you using version 3.0 or 3.14? | 19:53 |
smcginnis | scottda: I think the name is ok. Maybe get_highest_common_version? | 19:53 |
waj334 | scottda: 3.0 | 19:54 |
scottda | smcginnis: sure, that works | 19:54 |
smcginnis | scottda: or get_dude_pass_it_over_here() | 19:54 |
smcginnis | :P | 19:54 |
*** xyang has quit IRC | 19:54 | |
waj334 | scottda: I think the decorator on that function should be "@api_versions.wraps("2.0", "3.14")" instead of just "@api_versions.wraps("2.0")" | 19:54 |
*** mtanino has quit IRC | 19:55 | |
*** xyang has joined #openstack-cinder | 19:57 | |
waj334 | scottda: it has different version for 3.15 | 19:57 |
waj334 | scottda: I forgot to mention that this is in the client | 19:58 |
scottda | waj334: | 19:59 |
scottda | https://www.irccloud.com/pastebin/Od28YAxb/ | 20:00 |
scottda | In 3.15 we added Etag support | 20:00 |
*** markvoelker has quit IRC | 20:00 | |
*** xyang has quit IRC | 20:01 | |
*** Guest33539 is now known as mgagne | 20:01 | |
*** mgagne has quit IRC | 20:01 | |
*** mgagne has joined #openstack-cinder | 20:01 | |
scottda | But the client should have older version for v3 <3.15 | 20:02 |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Rebrand and move EQLX driver to dell_emc folder https://review.openstack.org/415565 | 20:02 |
scottda | waj334: So that's a bug | 20:02 |
smcginnis | I'm going to be releasing the client at midnight, aren't I? | 20:02 |
waj334 | scottda: I'll look into squashing that bug | 20:03 |
*** xyang has joined #openstack-cinder | 20:03 | |
scottda | waj334: I'm working on a fix now | 20:03 |
scottda | waj334: If you file the bug, I'll post the patch | 20:03 |
pots | jungleboyj: hi Jay, I got your message :) | 20:04 |
waj334 | scottda: Aww man. I was gonna do both lol | 20:05 |
scottda | waj334: That's fine | 20:05 |
scottda | waj334: my patch looks like this: | 20:06 |
scottda | https://www.irccloud.com/pastebin/SSbW2Jx3/ | 20:06 |
scottda | Test that ^^^ and submit away. | 20:06 |
scottda | waj334: Maybe add a unit test | 20:06 |
scottda | But smcginnis wants to get some sleep, and the deadline for getting the client out is midnight tonight. | 20:07 |
smcginnis | So no dilly dallying. :) | 20:07 |
*** eharney has quit IRC | 20:08 | |
*** crose has quit IRC | 20:08 | |
*** harlowja has joined #openstack-cinder | 20:09 | |
Swanson | So retype with migration does a volume_delete at the end. It sends me a volume that has the id of the old destination (from before it was renamed) and provider_id of that volume. And it calls the original backend with this information. | 20:10 |
*** xyang has quit IRC | 20:10 | |
*** alonmarx has quit IRC | 20:14 | |
openstackgerrit | Scott DAngelo proposed openstack/python-cinderclient: static method to get_server_version https://review.openstack.org/420119 | 20:18 |
*** alonmarx has joined #openstack-cinder | 20:20 | |
openstackgerrit | Scott DAngelo proposed openstack/python-cinderclient: static method to get_highest_client_server_version https://review.openstack.org/425785 | 20:24 |
*** eharney has joined #openstack-cinder | 20:24 | |
*** mriedem has joined #openstack-cinder | 20:28 | |
*** knomura has joined #openstack-cinder | 20:30 | |
openstackgerrit | Tom Swanson proposed openstack/cinder: Dell EMC SC: Delete doesn't validate provider_id https://review.openstack.org/425788 | 20:31 |
*** timcl has quit IRC | 20:32 | |
*** timcl has joined #openstack-cinder | 20:34 | |
*** knomura has quit IRC | 20:35 | |
*** lpetrut has quit IRC | 20:36 | |
*** lpetrut has joined #openstack-cinder | 20:36 | |
*** diablo_rojo has quit IRC | 20:44 | |
*** e0ne has joined #openstack-cinder | 20:44 | |
*** pbandark has joined #openstack-cinder | 20:45 | |
smcginnis | scottda: If you have a moment, mind taking a look at John's client patch? https://review.openstack.org/#/c/387716/ | 20:48 |
scottda | yup, will do | 20:48 |
*** diablo_rojo has joined #openstack-cinder | 20:51 | |
*** e0ne has quit IRC | 20:54 | |
*** markstur_ has joined #openstack-cinder | 20:55 | |
*** e0ne has joined #openstack-cinder | 20:58 | |
*** ebalduf has quit IRC | 20:59 | |
waj334 | scottda: I'm looking at what's in the repo for the cinderclient on github and I noticed that the code section for the old delete_metadata function had been removed completely. My local copy that I clone a few days ago has it, but not the current one. Strange | 20:59 |
waj334 | scottda: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/volumes.py | 21:00 |
scottda | waj334: So, you are saying that v3/volumes.py used to have 2 functions for delete_metadata, one wrapped with "3.0" and one wrapped with "3.15" ? | 21:02 |
scottda | And now it does not. (I can confirm that it does not in my fresh clone of the repo) | 21:02 |
waj334 | scottda: One wrapped with "2.0" and another wrapped with "3.15" | 21:03 |
scottda | waj334: The bug was introduced with this commit: 603c615ae59a8b6c24811b39ad05f26228ef5868 | 21:04 |
scottda | We should look at that patch set for other errors that might have been introduced. | 21:05 |
jungleboyj | pots, What message? | 21:06 |
*** reduxio has joined #openstack-cinder | 21:06 | |
jungleboyj | Are you my CI guy? | 21:07 |
*** ebalduf has joined #openstack-cinder | 21:07 | |
*** crose has joined #openstack-cinder | 21:07 | |
*** e0ne has quit IRC | 21:09 | |
*** reduxio has quit IRC | 21:11 | |
*** markstur has quit IRC | 21:11 | |
*** sam64 has quit IRC | 21:12 | |
*** sam64 has joined #openstack-cinder | 21:13 | |
*** crushil has joined #openstack-cinder | 21:14 | |
*** ebalduf has quit IRC | 21:16 | |
*** markstur_ is now known as markstur | 21:16 | |
pots | i'm your guy | 21:16 |
pots | just writing you an e-mail | 21:17 |
*** edmondsw_ has joined #openstack-cinder | 21:18 | |
*** edmondsw_ has quit IRC | 21:18 | |
scottda | smcginnis: jgriffith I know there is disagreement about versioning the help, but as it is today we do version it. So attach/detach shell will need that. | 21:19 |
smcginnis | scottda: Oh, right. Should be a quick fix. | 21:20 |
scottda | yeah | 21:20 |
*** liverpoo1er has quit IRC | 21:21 | |
scottda | smcginnis: FYI, I'll add a option to show all help, to make it easier to figure out when new features are in...something like "--help-me-get-highest" | 21:21 |
scottda | Just need to figure out the best way to do that... | 21:21 |
scottda | Don't hold up this release on it. | 21:22 |
*** ebalduf has joined #openstack-cinder | 21:23 | |
*** Jack_V has quit IRC | 21:24 | |
smcginnis | Great/ | 21:24 |
smcginnis | scottda: Interesting from Nova, for the library usage they limit to what is explictly requested, but for CLI they automatically go with the latest/highest available microversion. | 21:25 |
scottda | smcginnis: Sure, that's what Manila does too. | 21:26 |
scottda | smcginnis: And I'm fine with that. | 21:26 |
scottda | With those current in-flight patches, it makes it easy. | 21:26 |
scottda | smcginnis: I can have a look in a minute. Maybe shove one more thing in :) | 21:27 |
scottda | smcginnis: FYI the bug waj334 found may have been introduced with other bugs...I'm looking now.. | 21:28 |
smcginnis | scottda: Cool, thanks for looking at that. | 21:28 |
smcginnis | I figure we have a few hours yet to still get patches through check/gate queues. | 21:29 |
smcginnis | jgriffith: Did you see scottda's comments on the versioning? Should be pretty quick, I hope. | 21:29 |
*** porrua_ has quit IRC | 21:31 | |
*** porrua has joined #openstack-cinder | 21:32 | |
*** crose has quit IRC | 21:32 | |
jungleboyj | pots, Ok, thanks for getting back to me. | 21:35 |
scottda | waj334: Are you going to put up a patch for that bug? And have you filed a bug? | 21:36 |
jungleboyj | smcginnis, pots is working our CI issues. :-) By our I mean the Lenovo and Dothill driver. :-) | 21:36 |
waj334 | scottda: I'm filing the bug and working on a patch now | 21:36 |
scottda | OK | 21:36 |
scottda | waj334: Should just be that patch I posted. | 21:37 |
smcginnis | jungleboyj: Great! | 21:37 |
waj334 | scottda: gotcha | 21:37 |
jungleboyj | smcginnis, Look at me making new contacts so quickly. | 21:37 |
smcginnis | You're showing off for your new bosses, aren't you. :) | 21:38 |
smcginnis | jungleboyj: Watch out, they might expect you to get stuff done all the time. | 21:38 |
*** alonmarx has quit IRC | 21:38 | |
jungleboyj | Me, show off? No! I actually haven't had to try that hard to be a showoff. | 21:38 |
smcginnis | jungleboyj: It just comes naturally to you/ :D | 21:39 |
jungleboyj | smcginnis, You flatterer! | 21:40 |
jungleboyj | Me really should go to the airport. | 21:41 |
smcginnis | jungleboyj: When's your flight? | 21:41 |
jungleboyj | 7:25 ... | 21:41 |
smcginnis | jungleboyj: You'll get back to where people (mostly) know how to drive in the snow. ;) | 21:42 |
jungleboyj | smcginnis, Need to get something to eat before the flight. | 21:43 |
jungleboyj | I should be in Comofort+ again and might get a First class upgrade. | 21:43 |
smcginnis | jungleboyj: They're not flying you first class? | 21:43 |
smcginnis | :) | 21:43 |
jungleboyj | :-p I have to fly American to the PTG because Delta's tickets are god awful expensive for some reason. | 21:44 |
smcginnis | Yeah, I think I had to get creative on booking that one. | 21:44 |
*** xyang has joined #openstack-cinder | 21:44 | |
jungleboyj | It was weird. Not sure what was up there. Anyway, going to head out. Not looking forward to the 8" of snow on my driveway tonight. | 21:45 |
smcginnis | Travel safe. | 21:45 |
jungleboyj | Will do, have a couple episodes of Agents of Shield to watch on the plane. :-) | 21:46 |
*** catintheroof has quit IRC | 21:47 | |
jungleboyj | pots, Got your e-mail. Thanks. Will respond soon! | 21:47 |
jungleboyj | See you all on the other side! | 21:47 |
*** dustins is now known as dustins|out | 21:48 | |
*** jungleboyj has quit IRC | 21:52 | |
*** cknight has quit IRC | 21:54 | |
*** pbandark has quit IRC | 21:54 | |
*** xyang has quit IRC | 21:57 | |
ildikov | smcginnis: jgriffith: I can quickly fix scottda's comments in the client patch if we consider it urgent | 21:58 |
smcginnis | ildikov: Sure, I would appreciate that. | 21:58 |
smcginnis | Looking at the gate queue, it's going to take hours to get through once we approve it. | 21:58 |
smcginnis | So the sooner we can get it fixed up and approved, the sooner I will be able to go to bed tonight. :) | 21:59 |
ildikov | smcginnis: k, on it | 21:59 |
smcginnis | ildikov: Thank you! | 21:59 |
ildikov | smcginnis: I hope the fix will be that easy as it looks :) | 21:59 |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Rebrand and move EQLX driver to dell_emc folder https://review.openstack.org/415565 | 21:59 |
*** gouthamr has quit IRC | 22:00 | |
*** esker has quit IRC | 22:00 | |
*** breitz has quit IRC | 22:01 | |
*** Jack_Iv has quit IRC | 22:01 | |
*** xyang has joined #openstack-cinder | 22:01 | |
*** Jack_Iv has joined #openstack-cinder | 22:01 | |
*** breitz has joined #openstack-cinder | 22:01 | |
scottda | ildikov: Just paste in what I put in the comments | 22:03 |
*** bardia has quit IRC | 22:03 | |
*** Jack_Iv has quit IRC | 22:05 | |
ildikov | scottda: ok :) | 22:05 |
*** Jack_Iv has joined #openstack-cinder | 22:06 | |
*** Jack_Iv has quit IRC | 22:07 | |
*** Jack_V has joined #openstack-cinder | 22:07 | |
openstackgerrit | Ildiko Vancsa proposed openstack/python-cinderclient: Attach/Detach V2 https://review.openstack.org/387716 | 22:09 |
*** mtanino has joined #openstack-cinder | 22:09 | |
scottda | waj334: I've got a patch for that bug, and I'm about to post it. | 22:09 |
scottda | better stop me quick.... | 22:10 |
scottda | 'cause smcginnis needs some sleep tonight | 22:10 |
smcginnis | :) | 22:10 |
ildikov | scottda: smcginnis: done | 22:10 |
ildikov | smcginnis: I know how not sleeping goes, so I really tried my best here :) | 22:10 |
smcginnis | ildikov: You were on really late last night. Do you even sleep anymore? :) | 22:11 |
ildikov | smcginnis: sleeping is overrated ;) | 22:11 |
smcginnis | ildikov: Hah. Wish I could get by with less. That only works for a day or two for me. | 22:11 |
waj334 | scottda: committing to gerrit now. I was just double checking my work lol | 22:11 |
*** Jack_V has quit IRC | 22:11 | |
ildikov | smcginnis: I have a flight to catch in a bit more than 7 hours actually... | 22:11 |
ildikov | smcginnis: so well, maybe no, I don't :) | 22:12 |
waj334 | scottda: Might still need a triple check | 22:12 |
scottda | waj334: Just submit. I can review | 22:12 |
smcginnis | ildikov: Now where to? | 22:13 |
*** xyang has quit IRC | 22:14 | |
ildikov | smcginnis: US, so I'll be in TZ finally! :) | 22:14 |
smcginnis | ildikov: Oh nice! | 22:14 |
smcginnis | ildikov: Oh, is the foundation off site? | 22:14 |
openstackgerrit | Justin A Wilson proposed openstack/python-cinderclient: Missing client version 3.0 support for "delete_metadata" method https://review.openstack.org/425948 | 22:14 |
ildikov | smcginnis: you're very well informed :) | 22:14 |
smcginnis | ildikov: I have my sources. ;) | 22:14 |
ildikov | smcginnis: I know you do ;) | 22:18 |
scottda | waj334: Fix is correct. But I think "closes bug " might not connect to Luanchpad correctly | 22:18 |
smcginnis | scottda: I checked, it did link it correctly. | 22:19 |
scottda | hemna: jgriffith https://review.openstack.org/#/c/420119/ and https://review.openstack.org/#/c/425785/ look ready. | 22:19 |
scottda | smcginnis: waj334 OK, good enough | 22:19 |
scottda | smcginnis: BTW, there were no other regressions along with that bug. | 22:20 |
*** xyang has joined #openstack-cinder | 22:20 | |
smcginnis | scottda: Great, thanks for checking on that. | 22:20 |
smcginnis | Never fails though, we'll find some kind of bug tomorrow. ;) | 22:20 |
*** gouthamr has joined #openstack-cinder | 22:23 | |
scottda | or patrickeast thingee we like to get those 2 client patches in today ^^^^ | 22:27 |
*** xyang has quit IRC | 22:28 | |
*** lpetrut has quit IRC | 22:30 | |
smcginnis | scottda: Hadn't noticed, but it makes sense - we get pylint errors from those methods that have the same signatures but different api_versions.wraps decorators. | 22:30 |
*** porrua has quit IRC | 22:31 | |
hemna | we really should party after https://review.openstack.org/#/c/387716/ lands | 22:32 |
scottda | smcginnis: ok, I thought Gorka fixed that...but can put a "# noqa" by that line | 22:32 |
hemna | seriously a big milestone | 22:32 |
smcginnis | scottda: Some other time... | 22:33 |
smcginnis | hemna: Big as far as the amount of stuff we're cramming into it? | 22:34 |
scottda | hemna: At 5:30 AM I talked to Alon, and they were partying because of ibm_storage xiv landing. I had to settle for coffee, but it's getting close to 5:00 PM here... | 22:34 |
hemna | big as in, we've all been working on that for how long now? and it's finally in. | 22:34 |
hemna | and thanks to jgriffith for coding it up. | 22:35 |
scottda | Yeah, he's not responding, so maybe he's already celebrating. | 22:35 |
hemna | smcginnis, so what did we decide about the driver CIs ? | 22:35 |
openstackgerrit | Tom Swanson proposed openstack/cinder: Dell EMC SC: Delete doesn't account for migration https://review.openstack.org/425788 | 22:35 |
hemna | haven't heard anything from the other core's in here about it | 22:36 |
smcginnis | hemna: Yep, between the HA and Attach changes going in, this is pretty significant. | 22:36 |
smcginnis | hemna: Especially for a "bug fix release". :) | 22:36 |
hemna | hehe yah | 22:36 |
smcginnis | hemna: I don't think we really decided on CI. | 22:36 |
*** xyang has joined #openstack-cinder | 22:37 | |
smcginnis | I don't really want to delay it too much if we do decide to do anything, but maybe we should discuss it in next week's meeting. | 22:37 |
hemna | I thought today was the freeze? | 22:38 |
smcginnis | Feature freeze. | 22:39 |
*** crushil has quit IRC | 22:39 | |
smcginnis | RC1 is next week, so we can still get bug fixes and things core deem important. | 22:39 |
*** cknight has joined #openstack-cinder | 22:42 | |
*** alonma has joined #openstack-cinder | 22:47 | |
*** xyang has quit IRC | 22:48 | |
*** tommylikehu_ has joined #openstack-cinder | 22:51 | |
*** alonma has quit IRC | 22:52 | |
*** tommylikehu_ has quit IRC | 22:55 | |
*** alonma has joined #openstack-cinder | 22:56 | |
*** cknight has quit IRC | 22:56 | |
*** alonma has quit IRC | 23:00 | |
*** xinli has quit IRC | 23:03 | |
*** reduxio has joined #openstack-cinder | 23:08 | |
*** lseki has quit IRC | 23:10 | |
*** reduxio has quit IRC | 23:12 | |
*** tlian has quit IRC | 23:13 | |
hemna | smcginnis, should we send a warning shot over the bow for the CI folks that are questionable now? | 23:18 |
smcginnis | hemna: Eh, I'm really past trying to contact each of them directly, but if you want to I don't think it's a bad idea. | 23:18 |
smcginnis | hemna: Or were you thinking of something like posting a patch but not approving it yet? | 23:19 |
*** tlian has joined #openstack-cinder | 23:21 | |
Swanson | Post a patch. Approve it. Give them until release to beg to be let back in. | 23:21 |
patrickeast | hemna: smcginnis: you could maybe just post to the like 3rd party announce ML with a list of ones at risk | 23:21 |
hemna | ok thats not a bad idea | 23:22 |
*** diablo_rojo has quit IRC | 23:29 | |
*** knomura has joined #openstack-cinder | 23:30 | |
*** ntpttr has quit IRC | 23:31 | |
*** ntpttr has joined #openstack-cinder | 23:31 | |
*** tlian has quit IRC | 23:32 | |
*** knomura has quit IRC | 23:35 | |
*** cknight has joined #openstack-cinder | 23:37 | |
*** s-shiono has joined #openstack-cinder | 23:44 | |
*** david-lyle has quit IRC | 23:51 | |
*** david-lyle has joined #openstack-cinder | 23:54 | |
*** cknight1 has joined #openstack-cinder | 23:55 | |
*** stakeda has joined #openstack-cinder | 23:56 | |
*** rcernin has quit IRC | 23:56 | |
*** cknight has quit IRC | 23:57 | |
openstackgerrit | Merged openstack/python-cinderclient: static method to get_server_version https://review.openstack.org/420119 | 23:57 |
*** rcernin has joined #openstack-cinder | 23:57 | |
openstackgerrit | Merged openstack/python-cinderclient: Update param docstring to ducument search_opts https://review.openstack.org/407937 | 23:58 |
*** rcernin has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!