| *** ducttape_ has quit IRC | 00:00 | |
| *** ducttape_ has joined #openstack-cinder | 00:01 | |
| *** ducttape_ has quit IRC | 00:01 | |
| *** ducttape_ has joined #openstack-cinder | 00:02 | |
| *** ducttape_ has quit IRC | 00:02 | |
| *** ducttape_ has joined #openstack-cinder | 00:02 | |
| *** yangyapeng has quit IRC | 00:12 | |
| *** raunak has joined #openstack-cinder | 00:16 | |
| *** Julien-zte has joined #openstack-cinder | 00:17 | |
| *** lixiaoy1 has joined #openstack-cinder | 00:25 | |
| *** cknight has joined #openstack-cinder | 00:30 | |
| *** salv-orlando has quit IRC | 00:31 | |
| *** catintheroof has quit IRC | 00:31 | |
| *** wanghao has joined #openstack-cinder | 00:33 | |
| *** cknight has quit IRC | 00:33 | |
| *** jamielennox is now known as jamielennox|away | 00:41 | |
| *** jiaopengju has joined #openstack-cinder | 00:41 | |
| *** jiaopengju has joined #openstack-cinder | 00:41 | |
| *** jiaopengju has quit IRC | 00:42 | |
| *** jiaopengju has joined #openstack-cinder | 00:43 | |
| *** namnh has joined #openstack-cinder | 00:43 | |
| *** alonmarx has quit IRC | 00:44 | |
| *** jamielennox|away is now known as jamielennox | 00:44 | |
| *** zsli has joined #openstack-cinder | 00:47 | |
| tommylikehu | ping jgriffith | 00:49 |
|---|---|---|
| *** erhudy has quit IRC | 00:50 | |
| tommylikehu | hey jgriffith, based on my understanding of you genric filter spec, there is not any conflict or redundancy between your proposal and this patch, instead, this ability is needed by your spec right? https://review.openstack.org/#/c/441651/ | 00:51 |
| *** jiaopengju has joined #openstack-cinder | 00:58 | |
| *** salv-orlando has joined #openstack-cinder | 01:01 | |
| openstackgerrit | Merged openstack/cinder master: VMAX driver - Change vendor_name from EMC to Dell EMC https://review.openstack.org/442560 | 01:03 |
| openstackgerrit | Merged openstack/cinder master: Remove TODO related to Nova API version https://review.openstack.org/441338 | 01:03 |
| *** liverpooler has quit IRC | 01:04 | |
| *** kongwei_ has joined #openstack-cinder | 01:06 | |
| *** salv-orlando has quit IRC | 01:06 | |
| *** wanghao has quit IRC | 01:10 | |
| *** wanghao has joined #openstack-cinder | 01:10 | |
| *** kongwei_ has quit IRC | 01:11 | |
| *** mtanino has quit IRC | 01:11 | |
| *** yangyapeng has joined #openstack-cinder | 01:12 | |
| *** Julien-zte has quit IRC | 01:15 | |
| *** zhurong has joined #openstack-cinder | 01:15 | |
| *** Julien-zte has joined #openstack-cinder | 01:15 | |
| *** yangyapeng has quit IRC | 01:17 | |
| *** yangyapeng has joined #openstack-cinder | 01:18 | |
| *** huanxuan has joined #openstack-cinder | 01:21 | |
| *** wanghao_ has joined #openstack-cinder | 01:21 | |
| *** cknight has joined #openstack-cinder | 01:22 | |
| *** zsli_ has joined #openstack-cinder | 01:22 | |
| *** alonma has joined #openstack-cinder | 01:23 | |
| *** wanghao has quit IRC | 01:24 | |
| *** zsli has quit IRC | 01:24 | |
| *** cknight1 has joined #openstack-cinder | 01:25 | |
| *** jiaopengju has quit IRC | 01:26 | |
| *** jiaopengju has joined #openstack-cinder | 01:27 | |
| *** cknight has quit IRC | 01:27 | |
| *** alonma has quit IRC | 01:28 | |
| *** crushil has joined #openstack-cinder | 01:28 | |
| *** alonma has joined #openstack-cinder | 01:29 | |
| *** kongwei_ has joined #openstack-cinder | 01:33 | |
| openstackgerrit | xurong00037997 proposed openstack/cinder master: Remove unused pylintrc https://review.openstack.org/435318 | 01:33 |
| *** alonma has quit IRC | 01:34 | |
| *** jiaopeng_ has joined #openstack-cinder | 01:35 | |
| *** sage_ has quit IRC | 01:37 | |
| *** jiaopengju has quit IRC | 01:38 | |
| *** thingee has quit IRC | 01:38 | |
| *** kongwei_ has quit IRC | 01:44 | |
| *** gcb has joined #openstack-cinder | 01:45 | |
| openstackgerrit | Keisuke Kuroki proposed openstack/cinder master: api-ref: v2 API does not mention GET volume metadata by key https://review.openstack.org/441821 | 01:45 |
| *** thingee has joined #openstack-cinder | 01:47 | |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Don't change volume's status when create backups from snapshots https://review.openstack.org/442241 | 01:56 |
| *** raunak has quit IRC | 01:56 | |
| *** wanghao_ has quit IRC | 01:59 | |
| *** wanghao has joined #openstack-cinder | 02:00 | |
| *** wanghao_ has joined #openstack-cinder | 02:01 | |
| *** wanghao has quit IRC | 02:01 | |
| *** salv-orlando has joined #openstack-cinder | 02:02 | |
| *** redondo-mk has joined #openstack-cinder | 02:06 | |
| *** salv-orlando has quit IRC | 02:07 | |
| *** jiaohaolin1 has joined #openstack-cinder | 02:13 | |
| openstackgerrit | xhzhf proposed openstack/os-brick master: modify test-requirement according to requirements project https://review.openstack.org/436788 | 02:13 |
| *** zsli__ has joined #openstack-cinder | 02:19 | |
| *** wanghao has joined #openstack-cinder | 02:21 | |
| *** wanghao_ has quit IRC | 02:22 | |
| *** zsli_ has quit IRC | 02:22 | |
| jiaohaolin1 | hey guys ，what is the different between ConsistencyGroup and Group ? Does it just change the name ? | 02:22 |
| *** zsli_ has joined #openstack-cinder | 02:24 | |
| *** erlon has joined #openstack-cinder | 02:27 | |
| *** wanghao has quit IRC | 02:27 | |
| *** zsli__ has quit IRC | 02:28 | |
| openstackgerrit | TommyLike proposed openstack/cinder master: Add filter, sorter for group snapshot https://review.openstack.org/441651 | 02:28 |
| *** prashkre has joined #openstack-cinder | 02:29 | |
| *** wanghao has joined #openstack-cinder | 02:34 | |
| *** yuvalb has quit IRC | 02:37 | |
| *** yuvalb has joined #openstack-cinder | 02:38 | |
| *** Apoorva has quit IRC | 02:39 | |
| *** Apoorva has joined #openstack-cinder | 02:40 | |
| *** Apoorva has quit IRC | 02:41 | |
| openstackgerrit | Keisuke Kuroki proposed openstack/cinder master: api-ref: v2 API does not mention GET volume metadata by key https://review.openstack.org/441821 | 02:47 |
| tommylikehu | hey jiaohaolin1, no, please take a look at this doc: https://docs.openstack.org/admin-guide/blockstorage-groups.html | 02:53 |
| *** kongwei_ has joined #openstack-cinder | 02:59 | |
| *** prashkre has quit IRC | 03:01 | |
| *** raunak has joined #openstack-cinder | 03:03 | |
| *** salv-orlando has joined #openstack-cinder | 03:03 | |
| *** ducttape_ has quit IRC | 03:07 | |
| *** salv-orlando has quit IRC | 03:08 | |
| *** dhinesh has quit IRC | 03:13 | |
| *** chlong_ has joined #openstack-cinder | 03:15 | |
| *** chlong has quit IRC | 03:15 | |
| *** frontrunner has quit IRC | 03:16 | |
| *** diablo_rojo has quit IRC | 03:20 | |
| *** kongwei_ has quit IRC | 03:24 | |
| *** wanghao has quit IRC | 03:30 | |
| *** wanghao has joined #openstack-cinder | 03:31 | |
| *** kongwei_ has joined #openstack-cinder | 03:31 | |
| *** alonma has joined #openstack-cinder | 03:38 | |
| *** alonma has quit IRC | 03:43 | |
| *** cknight1 has quit IRC | 03:44 | |
| *** sdague has joined #openstack-cinder | 03:46 | |
| *** alonma has joined #openstack-cinder | 03:49 | |
| *** alonma has quit IRC | 03:53 | |
| *** chenying_ has quit IRC | 03:57 | |
| *** chenying_ has joined #openstack-cinder | 03:58 | |
| *** gouthamr has quit IRC | 04:00 | |
| *** namnh has quit IRC | 04:01 | |
| *** zhurong has quit IRC | 04:01 | |
| *** Poornima has joined #openstack-cinder | 04:04 | |
| *** salv-orlando has joined #openstack-cinder | 04:04 | |
| *** zsli__ has joined #openstack-cinder | 04:05 | |
| *** zsli_ has quit IRC | 04:07 | |
| *** ducttape_ has joined #openstack-cinder | 04:09 | |
| *** kongwei_ has quit IRC | 04:09 | |
| *** mdnadeem has joined #openstack-cinder | 04:09 | |
| *** salv-orlando has quit IRC | 04:09 | |
| *** ducttape_ has quit IRC | 04:13 | |
| *** psachin has joined #openstack-cinder | 04:18 | |
| *** nicolasbock has quit IRC | 04:19 | |
| *** zsli_ has joined #openstack-cinder | 04:24 | |
| *** sdague has quit IRC | 04:26 | |
| *** zsli has joined #openstack-cinder | 04:26 | |
| *** zsli__ has quit IRC | 04:26 | |
| *** zsli_ has quit IRC | 04:28 | |
| *** pdeore has joined #openstack-cinder | 04:36 | |
| *** links has joined #openstack-cinder | 04:41 | |
| *** zsli has quit IRC | 04:43 | |
| *** zsli has joined #openstack-cinder | 04:44 | |
| *** mtanino has joined #openstack-cinder | 04:45 | |
| *** Poornima has quit IRC | 04:47 | |
| *** gcb has quit IRC | 04:47 | |
| *** mahatic_ has joined #openstack-cinder | 04:49 | |
| *** gcb has joined #openstack-cinder | 04:50 | |
| *** zsli has quit IRC | 04:53 | |
| *** zsli has joined #openstack-cinder | 04:54 | |
| *** zsli has quit IRC | 04:55 | |
| *** crushil has quit IRC | 04:57 | |
| *** adisky_ has joined #openstack-cinder | 04:58 | |
| *** zsli has joined #openstack-cinder | 05:00 | |
| *** zsli has quit IRC | 05:02 | |
| *** zsli has joined #openstack-cinder | 05:03 | |
| *** erlon has quit IRC | 05:05 | |
| *** salv-orlando has joined #openstack-cinder | 05:05 | |
| *** zsli has quit IRC | 05:08 | |
| *** ducttape_ has joined #openstack-cinder | 05:09 | |
| *** salv-orlando has quit IRC | 05:09 | |
| openstackgerrit | Keisuke Kuroki proposed openstack/cinder master: api-ref: v2 API does not mention GET volume metadata by key https://review.openstack.org/441821 | 05:14 |
| *** ducttape_ has quit IRC | 05:14 | |
| *** wxy has quit IRC | 05:18 | |
| *** edmondsw has joined #openstack-cinder | 05:20 | |
| *** redondo-mk has quit IRC | 05:23 | |
| *** redondo-mk has joined #openstack-cinder | 05:24 | |
| *** edmondsw has quit IRC | 05:25 | |
| *** redondo-mk has quit IRC | 05:26 | |
| *** Shunli has joined #openstack-cinder | 05:29 | |
| *** markstur has quit IRC | 05:34 | |
| *** mahatic_ has left #openstack-cinder | 05:34 | |
| *** Shunli has quit IRC | 05:41 | |
| *** wanghao_ has joined #openstack-cinder | 05:42 | |
| *** tommylikehu has quit IRC | 05:43 | |
| *** tommylikehu has joined #openstack-cinder | 05:43 | |
| *** wanghao has quit IRC | 05:44 | |
| *** mdnadeem has quit IRC | 05:52 | |
| *** wanghao has joined #openstack-cinder | 05:54 | |
| *** mdnadeem has joined #openstack-cinder | 05:54 | |
| *** tommylikehu1 has joined #openstack-cinder | 05:55 | |
| *** alonma has joined #openstack-cinder | 05:55 | |
| *** wanghao_ has quit IRC | 05:56 | |
| *** Poornima has joined #openstack-cinder | 05:57 | |
| *** tommylikehu has quit IRC | 05:59 | |
| *** tommylikehu1 is now known as tommylikehu | 05:59 | |
| *** Jack_Iv has joined #openstack-cinder | 05:59 | |
| *** alonma has quit IRC | 06:00 | |
| *** wanghao has quit IRC | 06:03 | |
| *** wanghao has joined #openstack-cinder | 06:04 | |
| *** salv-orlando has joined #openstack-cinder | 06:06 | |
| *** alonma has joined #openstack-cinder | 06:07 | |
| *** waj334 has quit IRC | 06:09 | |
| *** waj334 has joined #openstack-cinder | 06:09 | |
| *** ducttape_ has joined #openstack-cinder | 06:10 | |
| *** salv-orlando has quit IRC | 06:11 | |
| *** alonma has quit IRC | 06:11 | |
| *** Shunli has joined #openstack-cinder | 06:13 | |
| *** zsli_ has joined #openstack-cinder | 06:15 | |
| *** ducttape_ has quit IRC | 06:15 | |
| *** zsli__ has joined #openstack-cinder | 06:16 | |
| *** nkrinner_afk is now known as nkrinner | 06:16 | |
| *** lpetrut has joined #openstack-cinder | 06:17 | |
| *** Shunli has quit IRC | 06:17 | |
| *** zsli_ has quit IRC | 06:20 | |
| *** zsli__ has quit IRC | 06:20 | |
| *** gcb has quit IRC | 06:21 | |
| *** jiaopeng_ has quit IRC | 06:22 | |
| *** gcb has joined #openstack-cinder | 06:22 | |
| *** pdeore has quit IRC | 06:22 | |
| *** Shunli has joined #openstack-cinder | 06:23 | |
| *** Shunli has quit IRC | 06:23 | |
| *** yangyapeng has quit IRC | 06:23 | |
| *** zsli_ has joined #openstack-cinder | 06:25 | |
| *** yangyapeng has joined #openstack-cinder | 06:26 | |
| *** jiaopengju has joined #openstack-cinder | 06:27 | |
| *** jiaopengju has quit IRC | 06:27 | |
| *** jiaopengju has joined #openstack-cinder | 06:27 | |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Don't change volume's status when create backups from snapshots https://review.openstack.org/442241 | 06:31 |
| *** alonmarx has joined #openstack-cinder | 06:32 | |
| *** zsli__ has joined #openstack-cinder | 06:34 | |
| *** zsli__ has quit IRC | 06:34 | |
| openstackgerrit | Rick Chen proposed openstack/cinder master: HTTPConnect SSL certificate verification failed https://review.openstack.org/442288 | 06:34 |
| *** zsli__ has joined #openstack-cinder | 06:35 | |
| *** zsli_ has quit IRC | 06:35 | |
| openstackgerrit | Rick Chen proposed openstack/cinder master: HTTPConnect SSL certificate verification failed https://review.openstack.org/442288 | 06:36 |
| *** salv-orlando has joined #openstack-cinder | 06:37 | |
| *** wxy has joined #openstack-cinder | 06:38 | |
| *** pdeore has joined #openstack-cinder | 06:40 | |
| *** zsli__ has quit IRC | 06:40 | |
| *** zsli__ has joined #openstack-cinder | 06:41 | |
| *** pcaruana has joined #openstack-cinder | 06:43 | |
| *** Jack_Iv has quit IRC | 06:46 | |
| *** zsli_ has joined #openstack-cinder | 06:46 | |
| *** Jack_Iv has joined #openstack-cinder | 06:48 | |
| *** zsli__ has quit IRC | 06:48 | |
| *** zsli__ has joined #openstack-cinder | 06:50 | |
| openstackgerrit | Rick Chen proposed openstack/cinder master: HTTPConnect SSL certificate verification failed https://review.openstack.org/442288 | 06:51 |
| *** zsli_ has quit IRC | 06:52 | |
| *** Shunli has joined #openstack-cinder | 06:52 | |
| *** wanghao_ has joined #openstack-cinder | 06:52 | |
| *** Shunli has quit IRC | 06:53 | |
| *** ChubYann has quit IRC | 06:54 | |
| *** markvoelker has quit IRC | 06:54 | |
| *** zsli__ has quit IRC | 06:54 | |
| *** raunak has quit IRC | 06:55 | |
| *** Shunli has joined #openstack-cinder | 06:55 | |
| *** savihou has joined #openstack-cinder | 06:55 | |
| *** wanghao has quit IRC | 06:55 | |
| *** Jack_Iv has quit IRC | 06:56 | |
| *** alonma has joined #openstack-cinder | 06:58 | |
| *** wanghao_ has quit IRC | 06:59 | |
| *** zsli_ has joined #openstack-cinder | 06:59 | |
| *** Shunli has quit IRC | 06:59 | |
| openstackgerrit | Rick Chen proposed openstack/cinder master: HTTPConnect SSL certificate verification failed https://review.openstack.org/442288 | 07:00 |
| *** wanghao has joined #openstack-cinder | 07:00 | |
| *** arne_r has joined #openstack-cinder | 07:00 | |
| *** zsli_ has quit IRC | 07:02 | |
| *** zsli_ has joined #openstack-cinder | 07:02 | |
| *** alonma has quit IRC | 07:02 | |
| *** zsli_ has quit IRC | 07:06 | |
| *** savihou has quit IRC | 07:07 | |
| *** savihou has joined #openstack-cinder | 07:07 | |
| *** alonma has joined #openstack-cinder | 07:09 | |
| *** lpetrut has quit IRC | 07:11 | |
| *** ducttape_ has joined #openstack-cinder | 07:11 | |
| *** Shunli has joined #openstack-cinder | 07:13 | |
| *** chhavi has joined #openstack-cinder | 07:13 | |
| openstackgerrit | chenhb proposed openstack/cinder master: Fix rally job https://review.openstack.org/442976 | 07:14 |
| *** alonma has quit IRC | 07:14 | |
| *** zsli_ has joined #openstack-cinder | 07:14 | |
| *** zsli_ has quit IRC | 07:15 | |
| *** ducttape_ has quit IRC | 07:16 | |
| *** Shunli has quit IRC | 07:17 | |
| *** salv-orl_ has joined #openstack-cinder | 07:23 | |
| *** lpetrut has joined #openstack-cinder | 07:23 | |
| *** alonma has joined #openstack-cinder | 07:25 | |
| *** salv-orlando has quit IRC | 07:26 | |
| *** rmk has quit IRC | 07:27 | |
| *** pjm6 has quit IRC | 07:29 | |
| *** alonma has quit IRC | 07:30 | |
| *** pjm6 has joined #openstack-cinder | 07:30 | |
| *** chhavi has quit IRC | 07:31 | |
| *** alonmarx has quit IRC | 07:32 | |
| openstackgerrit | TommyLike proposed openstack/cinder-specs master: Support regexp based filter https://review.openstack.org/442982 | 07:34 |
| openstackgerrit | TommyLike proposed openstack/cinder-specs master: Support regexp based filter https://review.openstack.org/442982 | 07:36 |
| openstackgerrit | xianming.mao proposed openstack/cinder master: Use function refresh instead of use get_by_id directly https://review.openstack.org/436404 | 07:36 |
| *** alonma has joined #openstack-cinder | 07:36 | |
| *** pgadiya has joined #openstack-cinder | 07:38 | |
| *** rcernin has joined #openstack-cinder | 07:40 | |
| *** alonma has quit IRC | 07:40 | |
| openstackgerrit | xianming.mao proposed openstack/cinder master: cors: update default configuration https://review.openstack.org/393577 | 07:42 |
| *** tesseract has joined #openstack-cinder | 07:43 | |
| *** alonma has joined #openstack-cinder | 07:47 | |
| *** jiaohaolin1 has quit IRC | 07:49 | |
| *** alonma has quit IRC | 07:52 | |
| *** luqitao has joined #openstack-cinder | 07:55 | |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Remove "list_volume" from filter https://review.openstack.org/432809 | 07:57 |
| *** salv-orl_ has quit IRC | 08:00 | |
| *** alonma has joined #openstack-cinder | 08:00 | |
| *** luqitao has quit IRC | 08:00 | |
| *** akapil has joined #openstack-cinder | 08:01 | |
| *** alonma has quit IRC | 08:05 | |
| openstackgerrit | TommyLike proposed openstack/cinder-specs master: Support regexp based filter https://review.openstack.org/442982 | 08:05 |
| *** akapil has quit IRC | 08:06 | |
| *** alonma has joined #openstack-cinder | 08:09 | |
| *** ducttape_ has joined #openstack-cinder | 08:12 | |
| *** markvoelker has joined #openstack-cinder | 08:12 | |
| *** ducttape_ has quit IRC | 08:17 | |
| *** chlong_ has quit IRC | 08:18 | |
| *** akapil has joined #openstack-cinder | 08:19 | |
| *** lixiaoy1 has quit IRC | 08:25 | |
| *** chhavi has joined #openstack-cinder | 08:26 | |
| *** Jack_I has joined #openstack-cinder | 08:29 | |
| *** akapil_ has joined #openstack-cinder | 08:37 | |
| *** akapil_ has quit IRC | 08:39 | |
| *** akapil_ has joined #openstack-cinder | 08:39 | |
| *** akapil has quit IRC | 08:40 | |
| *** sudipto has joined #openstack-cinder | 08:50 | |
| *** sudipto_ has joined #openstack-cinder | 08:50 | |
| *** wanghao_ has joined #openstack-cinder | 08:52 | |
| *** wanghao_ has quit IRC | 08:53 | |
| *** wanghao_ has joined #openstack-cinder | 08:53 | |
| *** wanghao has quit IRC | 08:55 | |
| *** edmondsw has joined #openstack-cinder | 08:57 | |
| *** wanghao has joined #openstack-cinder | 08:58 | |
| *** pgadiya has quit IRC | 08:59 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-cinder | 09:00 | |
| *** salv-orlando has joined #openstack-cinder | 09:00 | |
| *** wanghao_ has quit IRC | 09:01 | |
| *** edmondsw has quit IRC | 09:01 | |
| *** openstackgerrit has quit IRC | 09:03 | |
| *** cebruns__ has quit IRC | 09:04 | |
| *** openstackgerrit has joined #openstack-cinder | 09:04 | |
| openstackgerrit | chenhb proposed openstack/cinder master: Fix rally job gate-rally-dsvm-cinder-ubuntu-xenial-nv https://review.openstack.org/442976 | 09:04 |
| *** salv-orlando has quit IRC | 09:05 | |
| *** pdeore has quit IRC | 09:05 | |
| openstackgerrit | kavitha h r proposed openstack/python-brick-cinderclient-ext master: Python 3.5 is added https://review.openstack.org/443011 | 09:08 |
| openstackgerrit | Keisuke Kuroki proposed openstack/cinder master: api-ref: v2 API does not mention GET volume metadata by key https://review.openstack.org/441821 | 09:08 |
| *** isaacb has joined #openstack-cinder | 09:08 | |
| *** kaisers has quit IRC | 09:10 | |
| *** cebruns_ has joined #openstack-cinder | 09:10 | |
| *** pgadiya has joined #openstack-cinder | 09:12 | |
| *** ducttape_ has joined #openstack-cinder | 09:13 | |
| *** chhavi has quit IRC | 09:16 | |
| *** alonma has quit IRC | 09:16 | |
| *** alonma has joined #openstack-cinder | 09:17 | |
| *** ducttape_ has quit IRC | 09:17 | |
| *** alonma has quit IRC | 09:19 | |
| *** alonma has joined #openstack-cinder | 09:19 | |
| *** mlakat has joined #openstack-cinder | 09:22 | |
| *** kaisers has joined #openstack-cinder | 09:23 | |
| *** kaisers has quit IRC | 09:27 | |
| *** lkuchlan has joined #openstack-cinder | 09:29 | |
| openstackgerrit | wanghao proposed openstack/cinder master: Update guru doc to support file modification events https://review.openstack.org/443026 | 09:29 |
| *** salv-orlando has joined #openstack-cinder | 09:31 | |
| *** s-shiono has quit IRC | 09:32 | |
| *** Julien-zte has quit IRC | 09:34 | |
| *** salv-orlando has quit IRC | 09:35 | |
| *** wanghao has quit IRC | 09:36 | |
| *** ebalduf has quit IRC | 09:43 | |
| *** ebalduf has joined #openstack-cinder | 09:43 | |
| *** pdeore has joined #openstack-cinder | 09:45 | |
| *** kaisers has joined #openstack-cinder | 10:00 | |
| *** gcb has quit IRC | 10:06 | |
| *** gcb has joined #openstack-cinder | 10:07 | |
| *** yangyapeng has quit IRC | 10:09 | |
| *** ducttape_ has joined #openstack-cinder | 10:14 | |
| *** e0ne has joined #openstack-cinder | 10:15 | |
| *** e0ne has quit IRC | 10:15 | |
| *** ducttape_ has quit IRC | 10:19 | |
| *** salv-orlando has joined #openstack-cinder | 10:20 | |
| *** akapil_ has quit IRC | 10:27 | |
| *** akapil has joined #openstack-cinder | 10:29 | |
| *** akapil has quit IRC | 10:30 | |
| *** chhavi has joined #openstack-cinder | 10:33 | |
| openstackgerrit | xianming.mao proposed openstack/cinder master: Remove usage of config option verbose https://review.openstack.org/433486 | 10:35 |
| *** mlakat has quit IRC | 10:36 | |
| *** Haaibo has quit IRC | 10:37 | |
| *** dalgaaf has quit IRC | 10:37 | |
| *** akapil has joined #openstack-cinder | 10:37 | |
| *** Julien-zte has joined #openstack-cinder | 10:40 | |
| *** dalgaaf has joined #openstack-cinder | 10:41 | |
| *** alonma has quit IRC | 10:42 | |
| *** alonma has joined #openstack-cinder | 10:43 | |
| *** alonma has quit IRC | 10:43 | |
| *** alonma has joined #openstack-cinder | 10:44 | |
| *** mlakat has joined #openstack-cinder | 10:47 | |
| *** alonma has quit IRC | 10:49 | |
| *** alonma has joined #openstack-cinder | 10:49 | |
| *** Jack_Iv has joined #openstack-cinder | 10:51 | |
| *** ociuhandu has quit IRC | 10:51 | |
| *** FransUrbo has joined #openstack-cinder | 10:52 | |
| *** Jack_Iv has quit IRC | 10:53 | |
| *** jiaopengju has quit IRC | 10:53 | |
| *** sdague has joined #openstack-cinder | 10:53 | |
| *** Jack_Iv has joined #openstack-cinder | 10:53 | |
| *** alonma has quit IRC | 10:54 | |
| *** Jack_Iv has quit IRC | 10:55 | |
| *** Jack_Iv has joined #openstack-cinder | 10:55 | |
| *** gcb has quit IRC | 10:56 | |
| FransUrbo | Documentation about writing drivers for Cinder? I know I got a link several months ago, but new computer, new browser and partly new bookmarks and it's lost in time :(. | 10:59 |
| *** nicolasbock has joined #openstack-cinder | 11:04 | |
| *** zhurong has joined #openstack-cinder | 11:07 | |
| *** alonma has joined #openstack-cinder | 11:13 | |
| jgriffith | FransUrbo https://wiki.openstack.org/wiki/Cinder#How_To_Contribute_A_Driver | 11:15 |
| *** ducttape_ has joined #openstack-cinder | 11:15 | |
| FransUrbo | Thanx, that's the one! | 11:18 |
| *** ducttape_ has quit IRC | 11:20 | |
| *** catintheroof has joined #openstack-cinder | 11:20 | |
| FransUrbo | Thing is, "it" is calling terminate_connection() very shortly after "Attach volume completed successfully.". Not sure why, nothing in the debug logs that show anything of any use... | 11:24 |
| FransUrbo | Oh, I'm trying to fix my own driver https://github.com/FransUrbo/Openstack-ZFS | 11:24 |
| *** kaisers has quit IRC | 11:28 | |
| *** psachin has quit IRC | 11:28 | |
| *** kaisers has joined #openstack-cinder | 11:34 | |
| *** psachin has joined #openstack-cinder | 11:36 | |
| openstackgerrit | Merged openstack/cinder master: cors: update default configuration https://review.openstack.org/393577 | 11:36 |
| *** akapil has quit IRC | 11:42 | |
| *** chhavi_ has joined #openstack-cinder | 11:44 | |
| *** isaacb has quit IRC | 11:44 | |
| *** chhavi has quit IRC | 11:46 | |
| *** huanxuan has quit IRC | 11:55 | |
| *** pdeore has quit IRC | 11:56 | |
| *** alonma has quit IRC | 12:00 | |
| *** alonma has joined #openstack-cinder | 12:01 | |
| *** alonma_ has joined #openstack-cinder | 12:02 | |
| *** alonma_ has quit IRC | 12:04 | |
| *** alonma_ has joined #openstack-cinder | 12:05 | |
| *** alonma has quit IRC | 12:05 | |
| *** redondo-mk has joined #openstack-cinder | 12:07 | |
| *** akapil has joined #openstack-cinder | 12:13 | |
| *** ducttape_ has joined #openstack-cinder | 12:16 | |
| *** Jack_Iv has quit IRC | 12:17 | |
| *** Poornima has quit IRC | 12:18 | |
| *** ducttape_ has quit IRC | 12:21 | |
| *** gkadam has quit IRC | 12:25 | |
| *** catinthe_ has joined #openstack-cinder | 12:29 | |
| *** catintheroof has quit IRC | 12:29 | |
| *** david-lyle has quit IRC | 12:30 | |
| *** catintheroof has joined #openstack-cinder | 12:30 | |
| *** catinthe_ has quit IRC | 12:31 | |
| *** Julien-zte has quit IRC | 12:31 | |
| *** david-lyle has joined #openstack-cinder | 12:33 | |
| openstackgerrit | Merged openstack/cinder master: Tests: Use six.moves.urllib urlencode https://review.openstack.org/442769 | 12:33 |
| *** zhurong has quit IRC | 12:35 | |
| *** akapil has quit IRC | 12:36 | |
| *** gkadam has joined #openstack-cinder | 12:36 | |
| *** Jack_Iv has joined #openstack-cinder | 12:36 | |
| *** erlon has joined #openstack-cinder | 12:37 | |
| *** Julien-zte has joined #openstack-cinder | 12:37 | |
| *** gkadam has quit IRC | 12:43 | |
| *** salv-orlando has quit IRC | 12:48 | |
| *** porrua has joined #openstack-cinder | 12:49 | |
| *** arne_r has quit IRC | 12:50 | |
| *** salv-orlando has joined #openstack-cinder | 12:54 | |
| *** sdague has quit IRC | 12:55 | |
| *** tommylikehu_ has joined #openstack-cinder | 12:59 | |
| *** tommylikehu_ has quit IRC | 13:01 | |
| *** tommylikehu_ has joined #openstack-cinder | 13:01 | |
| *** frontrunner has joined #openstack-cinder | 13:05 | |
| *** alonma_ has quit IRC | 13:12 | |
| *** psachin has quit IRC | 13:13 | |
| *** alonma has joined #openstack-cinder | 13:13 | |
| *** pgadiya has quit IRC | 13:14 | |
| *** edmondsw has joined #openstack-cinder | 13:14 | |
| openstackgerrit | Merged openstack/python-cinderclient master: Add print_function import https://review.openstack.org/415488 | 13:15 |
| *** alonma has quit IRC | 13:16 | |
| *** alonma has joined #openstack-cinder | 13:17 | |
| *** tommylikehu_ has quit IRC | 13:17 | |
| *** ducttape_ has joined #openstack-cinder | 13:17 | |
| *** tommylikehu_ has joined #openstack-cinder | 13:17 | |
| openstackgerrit | Merged openstack/cinder master: Remove domains *-log-* from compile_catalog https://review.openstack.org/439501 | 13:17 |
| *** tommylikehu_ has quit IRC | 13:19 | |
| *** gouthamr has joined #openstack-cinder | 13:20 | |
| *** mriedem has joined #openstack-cinder | 13:21 | |
| *** ducttape_ has quit IRC | 13:21 | |
| *** salv-orl_ has joined #openstack-cinder | 13:23 | |
| *** links has quit IRC | 13:25 | |
| *** ducttape_ has joined #openstack-cinder | 13:25 | |
| *** salv-orlando has quit IRC | 13:26 | |
| *** gouthamr has quit IRC | 13:26 | |
| openstackgerrit | Sean McGinnis proposed openstack/python-brick-cinderclient-ext master: Add Python 3.5 classifier and venv https://review.openstack.org/390603 | 13:26 |
| *** tommylikehu_ has joined #openstack-cinder | 13:28 | |
| *** yangyapeng has joined #openstack-cinder | 13:29 | |
| *** psachin has joined #openstack-cinder | 13:30 | |
| erlon | jgriffith: smcginnis: xinli: I also prefer the option to add the tempest scenario test that ensure that drivers are doing the correct thing. I wasn't really happy with that generic implementation as well, thats why I was just letting it aside. The test will get other extend errors as well and finger point driver that don't do that correctly. And the good | 13:36 |
| erlon | point is that we move the effort to fix to driver vendors | 13:36 |
| smcginnis | erlon: +1 on that point. :) | 13:37 |
| erlon | jgriffith: smcginnis xinli: FWIW, there are 2 tempest tests already that we can use: https://review.openstack.org/#/c/249100/ https://review.openstack.org/#/c/200108/ | 13:38 |
| *** jiaopengju has joined #openstack-cinder | 13:38 | |
| *** eharney has joined #openstack-cinder | 13:39 | |
| erlon | jgriffith: smcginnis xinli: the scenario test looks very good, don't know why they left that behind | 13:39 |
| smcginnis | erlon: Yeah, I do think it needs to be one of the scenario tests. | 13:39 |
| smcginnis | erlon: The problem with the API test is we have one already, but it just gets the size via the API. And as far as Cinder knows, the new volume is the right size, even if the array didn't actually make it that way. | 13:39 |
| *** mvk has quit IRC | 13:40 | |
| *** tongli has joined #openstack-cinder | 13:41 | |
| erlon | smcginnis: yeah, that is beautifully checked in the scenario test above | 13:41 |
| erlon | smcginnis: we just need to extend it and also do the same for create_from_volume/snapshot | 13:42 |
| smcginnis | erlon: I'll try to remember to point Xing at that. I think it's VMAX or one of those that has to create volumes in 8G increments. | 13:42 |
| smcginnis | erlon: So the test might just have to verify the size is at least the new requested size. :/ | 13:42 |
| smcginnis | Or that CI can just skip the test... | 13:42 |
| erlon | smcginnis: yes, I was thinking about this point as well, but didn't remember any driver that had that limitation | 13:43 |
| *** lamt has joined #openstack-cinder | 13:44 | |
| *** liverpooler has joined #openstack-cinder | 13:44 | |
| smcginnis | As far as I can remember, that's the only one. | 13:44 |
| smcginnis | I hope. :) | 13:44 |
| erlon | smcginnis: we can use multiples of CONF.volume.volume_size | 13:44 |
| erlon | smcginnis: we will find out soon :) | 13:44 |
| erlon | smcginnis: we should also have a error tolerance, for example, some backends dont have the byte precision when extending | 13:45 |
| *** psachin has quit IRC | 13:46 | |
| smcginnis | erlon: Yeah, I was thinking about that too. We probably can't be too exact in the size checking. | 13:46 |
| *** psachin has joined #openstack-cinder | 13:46 | |
| *** gouthamr has joined #openstack-cinder | 13:46 | |
| erlon | smcginnis: just need to pick a reasonable tolerance, 100MB may be? | 13:47 |
| *** mtanino has quit IRC | 13:49 | |
| smcginnis | Not really sure what would be best there. | 13:49 |
| *** Jack_Iv has quit IRC | 13:50 | |
| *** sileht has quit IRC | 13:51 | |
| *** xyang1 has joined #openstack-cinder | 13:54 | |
| *** ducttape_ has quit IRC | 13:54 | |
| *** porrua_ has joined #openstack-cinder | 13:55 | |
| *** sileht has joined #openstack-cinder | 13:55 | |
| *** Poornima has joined #openstack-cinder | 13:57 | |
| *** KeithMnemonic has joined #openstack-cinder | 13:57 | |
| *** porrua has quit IRC | 13:59 | |
| *** sileht has quit IRC | 13:59 | |
| *** zhurong has joined #openstack-cinder | 14:00 | |
| *** isaacb has joined #openstack-cinder | 14:02 | |
| *** sileht has joined #openstack-cinder | 14:04 | |
| *** sileht has quit IRC | 14:04 | |
| *** strigazi_AFK is now known as strigazi | 14:04 | |
| openstackgerrit | Merged openstack/cinder master: Deprecate API v2 https://review.openstack.org/438195 | 14:06 |
| tommylikehu_ | ping xyang1 | 14:07 |
| tommylikehu_ | hey xyang1 can we talk about this patch? https://review.openstack.org/#/c/441651/ do you think we need microversion bump fot this chane? | 14:08 |
| xyang1 | tommylikehu_: hi, in a meeting | 14:08 |
| *** sileht has joined #openstack-cinder | 14:08 | |
| tommylikehu_ | xyang1: sure | 14:08 |
| *** sileht has quit IRC | 14:08 | |
| *** ociuhandu has joined #openstack-cinder | 14:09 | |
| tommylikehu_ | xyang1: any time whe you free | 14:09 |
| *** sileht has joined #openstack-cinder | 14:10 | |
| *** sileht has quit IRC | 14:11 | |
| *** sdague has joined #openstack-cinder | 14:13 | |
| *** sdague has quit IRC | 14:14 | |
| *** sdague has joined #openstack-cinder | 14:14 | |
| *** salv-orl_ has quit IRC | 14:18 | |
| *** lamt has quit IRC | 14:19 | |
| *** e0ne has joined #openstack-cinder | 14:19 | |
| tommylikehu_ | ping jgriffith | 14:19 |
| tommylikehu_ | jgriffith: I am writing another spec for regexp based filter, hope you could take a look at this: https://review.openstack.org/#/c/442982/ | 14:20 |
| *** dave-mccowan has joined #openstack-cinder | 14:21 | |
| e0ne | smcginnis: hi Sean. I'll probably miss the meeting today | 14:21 |
| e0ne | smcginnis: I'll read meeting log and remove -1 depends on what will be desided | 14:21 |
| * smcginnis marks e0ne down on his list | 14:22 | |
| smcginnis | :) | 14:22 |
| e0ne | :) | 14:22 |
| smcginnis | e0ne: OK, we can follow up after as needed. | 14:22 |
| *** arne_r has joined #openstack-cinder | 14:22 | |
| *** wxy| has joined #openstack-cinder | 14:23 | |
| *** esker has joined #openstack-cinder | 14:24 | |
| e0ne | smcginnis: for note: I do not want to have duplicated code in cinder | 14:25 |
| smcginnis | e0ne: Hah, that's good. :) | 14:26 |
| *** sileht has joined #openstack-cinder | 14:26 | |
| *** ducttape_ has joined #openstack-cinder | 14:27 | |
| *** e0ne has quit IRC | 14:28 | |
| *** xinli has joined #openstack-cinder | 14:29 | |
| *** tongli has quit IRC | 14:30 | |
| *** erhudy has joined #openstack-cinder | 14:31 | |
| *** alonma has quit IRC | 14:38 | |
| *** alonma has joined #openstack-cinder | 14:38 | |
| *** jiaopeng_ has joined #openstack-cinder | 14:42 | |
| *** jiaopengju has quit IRC | 14:44 | |
| *** gcb has joined #openstack-cinder | 14:46 | |
| *** sileht has quit IRC | 14:47 | |
| *** esker has quit IRC | 14:48 | |
| *** lamt has joined #openstack-cinder | 14:49 | |
| *** chlong_ has joined #openstack-cinder | 14:49 | |
| *** cknight has joined #openstack-cinder | 14:50 | |
| *** esker has joined #openstack-cinder | 14:50 | |
| *** guyr-infinidat has joined #openstack-cinder | 14:50 | |
| *** sdague has quit IRC | 14:51 | |
| *** crose has joined #openstack-cinder | 14:51 | |
| *** tommylikehu_ has quit IRC | 14:53 | |
| *** lpetrut has quit IRC | 14:53 | |
| *** sileht has joined #openstack-cinder | 14:54 | |
| *** sileht has quit IRC | 14:54 | |
| *** diablo_rojo has joined #openstack-cinder | 14:55 | |
| *** ntpttr_ has joined #openstack-cinder | 14:56 | |
| *** mdnadeem has quit IRC | 14:57 | |
| *** jonesn has joined #openstack-cinder | 15:02 | |
| *** arne_r has quit IRC | 15:02 | |
| *** mvk has joined #openstack-cinder | 15:03 | |
| *** sdague has joined #openstack-cinder | 15:04 | |
| *** zhurong has quit IRC | 15:05 | |
| *** Poornima has quit IRC | 15:06 | |
| *** esker has quit IRC | 15:08 | |
| *** crushil has joined #openstack-cinder | 15:08 | |
| openstackgerrit | Mate Lakat proposed openstack/cinder master: Fix column types in models.py https://review.openstack.org/443165 | 15:09 |
| *** nkrinner is now known as nkrinner_afk | 15:09 | |
| *** sandanar has joined #openstack-cinder | 15:11 | |
| *** esker has joined #openstack-cinder | 15:12 | |
| *** jiaopeng_ has quit IRC | 15:13 | |
| *** sileht has joined #openstack-cinder | 15:13 | |
| *** jiaopengju has joined #openstack-cinder | 15:13 | |
| *** jiaopeng_ has joined #openstack-cinder | 15:14 | |
| *** jiaopengju has quit IRC | 15:18 | |
| *** jiaopeng_ has quit IRC | 15:18 | |
| *** salv-orlando has joined #openstack-cinder | 15:18 | |
| *** salv-orlando has quit IRC | 15:24 | |
| *** Julien-zte has quit IRC | 15:25 | |
| *** Julien-zte has joined #openstack-cinder | 15:26 | |
| *** markstur has joined #openstack-cinder | 15:26 | |
| *** Julien-zte has quit IRC | 15:26 | |
| *** Julien-zte has joined #openstack-cinder | 15:27 | |
| *** Julien-zte has quit IRC | 15:27 | |
| *** Julien-zte has joined #openstack-cinder | 15:27 | |
| *** Julien-zte has quit IRC | 15:28 | |
| *** Julien-zte has joined #openstack-cinder | 15:28 | |
| *** Julien-zte has quit IRC | 15:29 | |
| *** Julien-zte has joined #openstack-cinder | 15:29 | |
| *** Julien-zte has quit IRC | 15:29 | |
| *** Julien-zte has joined #openstack-cinder | 15:30 | |
| *** Julien-zte has quit IRC | 15:30 | |
| *** raunak has joined #openstack-cinder | 15:35 | |
| *** links has joined #openstack-cinder | 15:36 | |
| sandanar | Hi.. I have question on the generic volume groups.. can the generic volume group have volumes grouped from multiple vendor like HPE, Dell for eg. ? | 15:36 |
| *** dustins has joined #openstack-cinder | 15:38 | |
| *** mtanino has joined #openstack-cinder | 15:39 | |
| *** sdague has quit IRC | 15:40 | |
| *** dustins_ has joined #openstack-cinder | 15:43 | |
| *** sdague has joined #openstack-cinder | 15:43 | |
| *** dustins has quit IRC | 15:44 | |
| *** e0ne has joined #openstack-cinder | 15:45 | |
| smcginnis | sandanar: Right now I think we are limiting it to one backend. That's right xyang1? | 15:48 |
| *** mkoderer has joined #openstack-cinder | 15:51 | |
| xyang1 | smcginnis: yes, that's right. | 15:51 |
| *** e0ne has quit IRC | 15:51 | |
| sandanar | smcginnis, xyang1: thanks for your reply | 15:51 |
| *** sudipto has quit IRC | 15:52 | |
| *** sudipto_ has quit IRC | 15:52 | |
| *** raunak has quit IRC | 15:52 | |
| *** rcernin has quit IRC | 15:58 | |
| *** tommylikehu_ has joined #openstack-cinder | 16:00 | |
| *** wxy| has quit IRC | 16:00 | |
| *** diablo_rojo_phon has joined #openstack-cinder | 16:03 | |
| *** lkuchlan has quit IRC | 16:07 | |
| *** chenhb has quit IRC | 16:10 | |
| *** chenhb has joined #openstack-cinder | 16:11 | |
| *** lpetrut has joined #openstack-cinder | 16:11 | |
| *** sam64 has quit IRC | 16:14 | |
| openstackgerrit | Justin A Wilson proposed openstack/cinder master: Add v3 delete volume unit test https://review.openstack.org/443219 | 16:18 |
| xinli | @smcginnis: erlon: any idea or direction for 336092? | 16:19 |
| *** salv-orlando has joined #openstack-cinder | 16:20 | |
| erlon | xinli: so, I also prefer the option to add the tempest scenario test that ensure that drivers are doing the correct thing. I wasn't really happy with that generic implementation as well, thats why I was just letting it aside. The test will get other extend errors as well and finger point driver that don't do that correctly. And the good | 16:20 |
| *** esker has quit IRC | 16:21 | |
| erlon | point is that we move the effort to fix to driver vendors | 16:21 |
| xinli | got it | 16:21 |
| erlon | xinli: so, lets leave that behind and lets work in the tempest tests, there are 2 that we can use: https://review.openstack.org/#/c/249100/ https://review.openstack.org/#/c/200108/ | 16:21 |
| xinli | erlon: review | 16:22 |
| erlon | xinli: ill talk with the author of then, jpitier to see why they wheren't merged yet | 16:23 |
| erlon | xinli: give a look on the scenario test, https://review.openstack.org/#/c/249100/, it is doing almost everything that we want, just need some things to be added | 16:24 |
| erlon | xinli: 1 - support for backends that only support creation of chunked volumes (VMAX for example only can create volumes in 8GB increments) | 16:25 |
| *** salv-orlando has quit IRC | 16:25 | |
| *** crushil has quit IRC | 16:26 | |
| erlon | xinli: 2 - give a error margin to the checker because inside the filesystems, not always a 1GB volumes has a predictable number of blocks | 16:27 |
| *** crushil has joined #openstack-cinder | 16:30 | |
| *** markvoelker has quit IRC | 16:30 | |
| *** alonma has quit IRC | 16:33 | |
| *** alonma has joined #openstack-cinder | 16:34 | |
| *** alonma has quit IRC | 16:34 | |
| *** chhavi_ has quit IRC | 16:35 | |
| *** alonma has joined #openstack-cinder | 16:35 | |
| *** nikeshm has joined #openstack-cinder | 16:35 | |
| nikeshm | patrickeast: hi | 16:36 |
| xyang1 | erlon: not VMAX, it is ScaleIO | 16:39 |
| erlon | xyang1: hmm, ok, thanks for pointing | 16:39 |
| erlon | xyang1: do you know anyone else? | 16:39 |
| xyang1 | erlon: I think Hitachi has some minimum size requirement on the file share side, maybe not on volume | 16:40 |
| erlon | xyang1: yes, but that is another storage, that is HSP | 16:41 |
| xyang1 | erlon: just add an option in tempest so driver can set it if needed | 16:42 |
| erlon | xyang1: I think that we can use the volume_size as we have today | 16:42 |
| *** ducttape_ has quit IRC | 16:43 | |
| erlon | xyang1: then, if we are texting extend we just use volume_size * 2 | 16:43 |
| xyang1 | erlon: that will work | 16:43 |
| *** ducttape_ has joined #openstack-cinder | 16:43 | |
| *** ducttape_ has quit IRC | 16:44 | |
| *** ducttape_ has joined #openstack-cinder | 16:44 | |
| *** JoseMello has joined #openstack-cinder | 16:47 | |
| *** sandanar has quit IRC | 16:52 | |
| *** ducttape_ has quit IRC | 16:54 | |
| *** links has quit IRC | 16:55 | |
| *** alonma has quit IRC | 16:55 | |
| *** ociuhandu has quit IRC | 16:55 | |
| *** alonma has joined #openstack-cinder | 16:56 | |
| tommylikehu_ | ping xyang1, are you available right now? | 16:58 |
| xyang1 | tommylikehu_: hi, yes | 16:58 |
| tommylikehu_ | xyang1: thanks, I am not sure whether we should add a microversion bump for this change : https://review.openstack.org/#/c/441651/ | 16:59 |
| xyang1 | tommylikehu_: well, regarding that, I thought we usually bump microversion in that case, not because I like it | 16:59 |
| *** salv-orlando has joined #openstack-cinder | 16:59 | |
| xyang1 | tommylikehu_: It is an enhancement rather that bug fix | 17:00 |
| *** alonma has quit IRC | 17:00 | |
| smcginnis | If it changes the accepted parameters or the result of the call, it needs a mv. | 17:00 |
| eharney | see https://docs.openstack.org/developer/cinder/devref/api_microversion_dev.html#when-do-i-need-a-new-microversion | 17:00 |
| *** jonesn has quit IRC | 17:00 | |
| *** jonesn has joined #openstack-cinder | 17:01 | |
| tommylikehu_ | I think it's a bug with that bump could be advertising that we are not going to support filter from 3.14 to 3.29 | 17:01 |
| xyang1 | tommylikehu_: it was not supported earlier | 17:01 |
| xyang1 | tommylikehu_: you added that support with this patch | 17:01 |
| tommylikehu_ | xyang1, smcginnis, eharney: ok I will add a microversion for this | 17:02 |
| tommylikehu_ | smcginnis: I checked jgriffith's spec about generialized filter, I think this spec will not be covered by his one https://review.openstack.org/#/c/362747/ | 17:04 |
| tommylikehu_ | smcginnis: so it's still needed, but it would be better if the client side work could be done along with or after his job | 17:05 |
| *** alonma has joined #openstack-cinder | 17:06 | |
| *** tommylikehu_ has quit IRC | 17:08 | |
| *** mlakat has quit IRC | 17:10 | |
| *** alonma has quit IRC | 17:11 | |
| *** crose has quit IRC | 17:12 | |
| *** markvoelker has joined #openstack-cinder | 17:13 | |
| *** alonma has joined #openstack-cinder | 17:15 | |
| *** KeithMnemonic has quit IRC | 17:15 | |
| *** dustins_ is now known as dustins | 17:17 | |
| nikeshm | smcginnis: hi, whats up | 17:17 |
| *** tesseract has quit IRC | 17:18 | |
| *** alonma has quit IRC | 17:20 | |
| *** ntpttr_ has quit IRC | 17:21 | |
| *** psachin has quit IRC | 17:22 | |
| *** Yogi1 has joined #openstack-cinder | 17:38 | |
| *** alonmarx has joined #openstack-cinder | 17:40 | |
| *** ntpttr_ has joined #openstack-cinder | 17:49 | |
| *** KeithMnemonic has joined #openstack-cinder | 17:53 | |
| *** ducttape_ has joined #openstack-cinder | 17:55 | |
| *** ducttape_ has quit IRC | 17:59 | |
| openstackgerrit | Justin A Wilson proposed openstack/cinder master: Add v3 delete volume unit test https://review.openstack.org/443219 | 17:59 |
| *** dhinesh has joined #openstack-cinder | 18:01 | |
| *** Apoorva has joined #openstack-cinder | 18:02 | |
| *** ducttape_ has joined #openstack-cinder | 18:02 | |
| *** ntpttr_ has quit IRC | 18:04 | |
| jgriffith | tommylikehu smcginnis hey there :) | 18:18 |
| jgriffith | so I want to try and simplify this a bit if we can | 18:19 |
| openstackgerrit | Andreas Jaeger proposed openstack/cinder master: Replace obsolete vanity openstack.org URLs https://review.openstack.org/443262 | 18:19 |
| jgriffith | so for example: Maybe have a single spec for adding the *filter* capability aspect to resources. Then just tack a blueprint on to each resource as it's worked out. does that seem reasonable? | 18:19 |
| *** prashkre has joined #openstack-cinder | 18:21 | |
| xinli | @smcginnis: could you please help to restor some patch in driver I have fixed? | 18:23 |
| *** isaacb has quit IRC | 18:27 | |
| smcginnis | xinli: Sure, which ones? | 18:30 |
| smcginnis | jgriffith: That sounds good to me. | 18:30 |
| jgriffith | eharney in other words, if you change anyting going in or coming out. End of story | 18:30 |
| xinli | @smcginnis: 292432 | 18:30 |
| jgriffith | eharney my real question though... can you combine things into a single microversion? | 18:31 |
| jgriffith | eharney so for example if I know I have 3 params I'm adding to an API call in flight, can I batch them and do them all at once, or do I have to have a unique version for each? | 18:32 |
| jgriffith | my belief/interpretation is that I can batch them | 18:32 |
| jgriffith | but I could be completely wrong | 18:32 |
| *** raunak has joined #openstack-cinder | 18:32 | |
| smcginnis | jgriffith: I think if they are all related, that's fine. | 18:34 |
| jgriffith | cool | 18:34 |
| smcginnis | jgriffith: But the discussion at the PTG was that since some (I don't know who) expect to be able to continually deploy from master, each change needs to be incremente.d | 18:34 |
| smcginnis | Really don't like that concept. | 18:34 |
| smcginnis | The concept of continually deploying from master and the concept of incrementing each and every little change. | 18:35 |
| jgriffith | :) | 18:35 |
| jgriffith | yeah, I think we agree on most of this :) | 18:35 |
| jgriffith | honestly it's a great justification IMO to NOT allow new things or changes at all :) | 18:36 |
| smcginnis | xinli: Restored. It needs a rebase at a minimum. | 18:36 |
| jgriffith | really I guess I should be happy and embrace it :) | 18:36 |
| smcginnis | ;) | 18:36 |
| xinli | @smcginnis: I have already done rebase and passed the test | 18:36 |
| smcginnis | xinli: Perfect | 18:36 |
| *** chlong_ has quit IRC | 18:37 | |
| *** rcernin has joined #openstack-cinder | 18:42 | |
| openstackgerrit | Justin A Wilson proposed openstack/cinder master: Model migrate volume's host parameter as OVO https://review.openstack.org/439845 | 18:43 |
| *** ducttape_ has quit IRC | 18:47 | |
| *** mvk has quit IRC | 18:48 | |
| *** sdague has quit IRC | 18:49 | |
| *** sdague has joined #openstack-cinder | 18:50 | |
| *** chlong_ has joined #openstack-cinder | 18:54 | |
| *** Redcavalier has joined #openstack-cinder | 18:55 | |
| *** nikeshm has quit IRC | 18:58 | |
| *** crushil has quit IRC | 18:59 | |
| *** crushil has joined #openstack-cinder | 18:59 | |
| *** diablo_rojo has quit IRC | 19:00 | |
| xinli | @smiginnis: I have been rejected | 19:01 |
| smcginnis | xinli: Not allowing you to update the patch? | 19:01 |
| xinli | @smcginnis: http://paste.openstack.org/show/601979/ | 19:02 |
| smcginnis | xinli: Did you accidentally remove the Change-id line from the commit message? | 19:03 |
| xinli | @smcginnis: double check | 19:03 |
| xinli | @smcginnis: http://paste.openstack.org/show/601980/ | 19:04 |
| smcginnis | xinli: Try moving your "Co-Authored-By" line up before the Change-Id line. Otherwise I'm not sure. Looks OK to me. | 19:05 |
| *** alonmarx has quit IRC | 19:05 | |
| openstackgerrit | Xinli Guan proposed openstack/cinder master: XtremIO: allow a cloned volume with larger size https://review.openstack.org/292432 | 19:06 |
| xinli | @smcginnis: sorry, my mistake to put the C-A in wrong place | 19:07 |
| smcginnis | xinli: Easy mistake. I actually didn't know it made a difference. | 19:07 |
| prashkre | xyang1: Hi. I was going thru consistency groups GET API and found an issue w.r.t filters. | 19:07 |
| prashkre | xyang1: consistency groups GET API is gettting the data from cinder.consistencygroups and cinder.groups tables at https://github.com/openstack/cinder/blob/master/cinder/api/contrib/consistencygroups.py#L130. | 19:08 |
| prashkre | lets consider context is on 'proj2' and when we pass the filters as {'all_tenants': True, 'project_id': 'proj2'} to get consistencygroups from 'proj2'. In the flow https://github.com/openstack/cinder/blob/master/cinder/consistencygroup/api.py#L711 deletes all_tenants when pulling the groups from cinder.consistencygroups and while pulling the | 19:08 |
| prashkre | consistencygroups from cinder.groups table it is going to else block @https://github.com/openstack/cinder/blob/master/cinder/group/api.py#L774 and getting proj1 groups. | 19:08 |
| prashkre | do you have any LP bug to address this? | 19:09 |
| xyang1 | prashkre: no, go ahead and open a bug | 19:10 |
| prashkre | sure. Thanks! | 19:11 |
| *** pcaruana has quit IRC | 19:13 | |
| *** bkopilov_ has joined #openstack-cinder | 19:14 | |
| *** bkopilov has quit IRC | 19:14 | |
| *** Jack_I has quit IRC | 19:18 | |
| *** salv-orl_ has joined #openstack-cinder | 19:23 | |
| *** alonma has joined #openstack-cinder | 19:24 | |
| *** mvk has joined #openstack-cinder | 19:24 | |
| *** breitz has quit IRC | 19:25 | |
| *** salv-orlando has quit IRC | 19:26 | |
| *** breitz has joined #openstack-cinder | 19:26 | |
| *** mkoderer has quit IRC | 19:27 | |
| *** alonma has quit IRC | 19:28 | |
| *** Apoorva_ has joined #openstack-cinder | 19:34 | |
| *** Apoorva has quit IRC | 19:36 | |
| Redcavalier | Hi, I'm running into issues with Cinder after an upgrade from Mitaka to Newton. This isssue seems quite advanced and I couldn't get any answer from the general channel. Essentially, whenever I try to create a volume from an image, I get the following non-descriptive error : TypeError: execv() arg 2 must contain only strings | 19:36 |
| Redcavalier | This happens in the code after the volume is created, but before the image is loaded onto it. Actually, the volume is not even mounted in iscsi yet. It seems to be right before that. | 19:36 |
| smcginnis | Redcavalier: Can you enable debug logging and reproduce the failure? That may help pinpoint where this is happening. | 19:36 |
| smcginnis | Redcavalier: My hunch is some library needs to be updated. | 19:37 |
| Redcavalier | smcginnis, sure, I have debug enabled already. let me give you a pastebin | 19:37 |
| smcginnis | Redcavalier: But the logs should contain a traceback that can help show where that is. | 19:37 |
| *** salv-orl_ has quit IRC | 19:37 | |
| smcginnis | Redcavalier: Perfect. | 19:37 |
| *** alonmarx has joined #openstack-cinder | 19:40 | |
| Redcavalier | smcginnis, http://pastebin.com/HCZ5JE1y | 19:44 |
| Redcavalier | sorry for the formating it's a bit of a mess, but you should be able to see everything relevant there | 19:44 |
| xinli | @smcginnis: could you please restore 294913 | 19:45 |
| *** ducttape_ has joined #openstack-cinder | 19:47 | |
| *** lpetrut has quit IRC | 19:48 | |
| *** prashkre has quit IRC | 19:51 | |
| *** Jack_I has joined #openstack-cinder | 19:51 | |
| *** prashkre has joined #openstack-cinder | 19:52 | |
| smcginnis | Redcavalier: Could you run "pip freeze | grep os-brick"? | 19:55 |
| smcginnis | xinli: Done | 19:56 |
| Redcavalier | smcginnis, os-brick==1.6.1 | 19:56 |
| xinli | @smcginnis: thx | 19:56 |
| *** guyr-infinidat has quit IRC | 19:58 | |
| *** guyr-infinidat has joined #openstack-cinder | 19:58 | |
| smcginnis | Redcavalier: Hmm, best I can tell is it's something in privsep. | 20:02 |
| smcginnis | Redcavalier: It's in the part of the process where /etc/iscsi/initiatorname.iscsi is cat'd to get the iSCSI IQN. | 20:03 |
| smcginnis | Redcavalier: Which is a pretty straightforward operation to perform. | 20:03 |
| smcginnis | Redcavalier: But that calls in to run as administrator and blows up somewhere in there. | 20:03 |
| Redcavalier | smcginnis, ah that's one of the lead I have. I'm completely unfamiliar with privsep though. | 20:03 |
| Redcavalier | smcginnis, Thank you very much, this does help a lot as I have something to look into. We've been at a dead end for a while. | 20:05 |
| smcginnis | Redcavalier: No problem. I'm not super versed in privsep either, but you can check the version installed and see if maybe that needs an update. Or maybe it should have been capped at a certain version and was not. | 20:06 |
| smcginnis | Redcavalier: Not really sure at this point, but that does appear to be where to focus efforts. | 20:06 |
| Redcavalier | smcginnis, I do have another openstack setup that I just updated which works, so I can at least compare between the two setups. | 20:07 |
| smcginnis | Redcavalier: Oh good. Hopefully a good stare-and-compare between the two makes it obvious. | 20:07 |
| Redcavalier | smcginnis, yea. I already did a comparison of the two privsep components though and a md5sum for each return the same value. I'm guessing that privsep executes something or other that doesn't work. May be OS related. I wonder if I can get better logs from privsep. | 20:09 |
| smcginnis | Redcavalier: Hmm, not sure about that. | 20:09 |
| eharney | the '--config-dir', [], piece looks a bit suspect | 20:09 |
| eharney | maybe the list sneaking in there is breaking the list -> string conversion for the command | 20:10 |
| eharney | Redcavalier: can you paste up your cinder.conf too? | 20:11 |
| Redcavalier | eharney, sure | 20:11 |
| openstackgerrit | Xinli Guan proposed openstack/cinder master: Coho: resize volume if cloned image is larger https://review.openstack.org/294913 | 20:11 |
| *** Apoorva_ has quit IRC | 20:13 | |
| *** Apoorva has joined #openstack-cinder | 20:14 | |
| Redcavalier | eharney, http://pastebin.com/A1wbvkvv | 20:14 |
| Redcavalier | please disregard the glance_api_version, it'S supposed to be 2 | 20:14 |
| Redcavalier | I changed it to 1 for testing | 20:14 |
| *** chlong_ has quit IRC | 20:16 | |
| *** redondo-mk has quit IRC | 20:19 | |
| smcginnis | eharney: Maybe /etc/cinder/rootwrap.conf settings? | 20:19 |
| eharney | i think i see what it is... just trying to find a good example | 20:19 |
| eharney | Redcavalier: can you also grab the config options printed out when cinder volume starts and paste that whole thing up? | 20:20 |
| Redcavalier | alright, just a sec | 20:20 |
| eharney | i think i see a bug in privsep | 20:20 |
| smcginnis | eharney: Oh? | 20:21 |
| smcginnis | eharney: Interesting we haven't hit this elsewhere. Is it related to configuration settings? | 20:21 |
| eharney | yes, one sec | 20:21 |
| eharney | https://git.openstack.org/cgit/openstack/oslo.privsep/tree/oslo_privsep/priv_context.py?h=1.17.0#n160 | 20:21 |
| eharney | this does an "is not None" check but doesn't check that it has a real value, so it could be an empty list, i think | 20:22 |
| smcginnis | eharney: Ah. Should just be "if cfg.CONF.config_dir" | 20:23 |
| smcginnis | Or have another explicit check. | 20:23 |
| eharney | yeah | 20:23 |
| smcginnis | Redcavalier: Good catch. LD | 20:23 |
| smcginnis | :D | 20:23 |
| Redcavalier | smcginnis, lol, I only updated my openstack, didn't do anything much tbqh | 20:24 |
| Redcavalier | eharney, is there any specific config value you would like? there's a ton in there | 20:24 |
| *** alonma has joined #openstack-cinder | 20:25 | |
| openstackgerrit | Merged openstack/cinder master: Replace obsolete vanity openstack.org URLs https://review.openstack.org/443262 | 20:25 |
| *** markvoelker has quit IRC | 20:27 | |
| eharney | Redcavalier: curious first about "command line args:" and config_dir and config_file | 20:27 |
| *** chlong_ has joined #openstack-cinder | 20:28 | |
| *** e0ne has joined #openstack-cinder | 20:29 | |
| *** alonma has quit IRC | 20:29 | |
| *** oomichi has joined #openstack-cinder | 20:30 | |
| oomichi | hi, can you take a look at https://review.openstack.org/#/c/441481/ ? It has 2 * +2s already, maybe one more +2 would be nice | 20:31 |
| *** alonma has joined #openstack-cinder | 20:32 | |
| *** diablo_rojo has joined #openstack-cinder | 20:34 | |
| smcginnis | oomichi: Done | 20:35 |
| *** rcernin has quit IRC | 20:36 | |
| oomichi | smcginnis: thanks for your reviews many times | 20:36 |
| *** alonma has quit IRC | 20:36 | |
| Redcavalier | eharney, I ended up copying the whole thing : http://pastebin.com/edTkf5vm | 20:37 |
| smcginnis | oomichi: No problem. Thank you for making sure we're up to date. | 20:37 |
| *** salv-orlando has joined #openstack-cinder | 20:38 | |
| eharney | Redcavalier: thanks. did you change cinder-dist.conf any? | 20:40 |
| *** alonmarx_ has joined #openstack-cinder | 20:40 | |
| *** frontrunner has quit IRC | 20:42 | |
| Redcavalier | eharney, not at all | 20:42 |
| *** salv-orlando has quit IRC | 20:42 | |
| *** e0ne has quit IRC | 20:43 | |
| *** alonmarx has quit IRC | 20:43 | |
| eharney | Redcavalier: what version of oslo.privsep do you have installed? | 20:47 |
| smcginnis | 1.6.1 | 20:47 |
| eharney | that was brick? | 20:47 |
| Redcavalier | yea that's brick | 20:47 |
| eharney | https://bugs.launchpad.net/oslo.privsep/+bug/1616240 seems to fix this | 20:48 |
| openstack | Launchpad bug 1616240 in python-oslo.privsep (Ubuntu Zesty) "Traceback in vif.py execv() arg 2 must contain only strings" [High,Fix released] | 20:48 |
| Redcavalier | privsep is 1.13.1 | 20:48 |
| eharney | hrmm | 20:48 |
| eharney | ok, this fits with my theory earlier | 20:49 |
| smcginnis | eharney: That bug says it was fixed in oslo-privsep, but I don't see a patch. | 20:49 |
| eharney | i'm going to just write a new bug and submit a fix | 20:49 |
| eharney | smcginnis: https://review.openstack.org/#/c/361125/2/oslo_privsep/priv_context.py | 20:49 |
| smcginnis | eharney: Ah, there it is in the comments. | 20:50 |
| smcginnis | eharney: Yeah, I think your idea from before is right. That if statement above there shouldn't be checking explicitly for None. | 20:50 |
| *** ducttape_ has quit IRC | 20:52 | |
| eharney | i would like to know how to actually reproduce this, which i'm not sure about, but i'll try to submit this anyway | 20:52 |
| Redcavalier | eharney, I can't really say how to reproduce it tbqh. I did the same upgrade procedure in both of my infrastructure and one works, while the other got that bug. Plus I tested in a staging infra beforehand which didn't get it. | 20:53 |
| eharney | Redcavalier: is this using RDO packages? | 20:55 |
| Redcavalier | eharney, yes | 20:55 |
| eharney | (the cinder-dist.conf is a giveaway) | 20:55 |
| Redcavalier | got them from that repository : centos-release-openstack-newton-1-1.el7.noarch | 20:56 |
| eharney | the log looks more like the original failure, and the cinder package there didn't require anything newer than privsep 1.9... i'm suspecting this was just hit using an outdated privsep | 20:58 |
| eharney | but not sure, i'd like to find a way to reproduce it | 21:00 |
| *** crushil has quit IRC | 21:05 | |
| Redcavalier | eharney, I'm not even sure there was a privsep using a previous version on this server previously. It's actually the first time I notice oslo-privsep. Was it in Mitaka too? | 21:05 |
| *** ducttape_ has joined #openstack-cinder | 21:05 | |
| eharney | Redcavalier: yes | 21:05 |
| Redcavalier | eharney, ok, so in that case there was definitely the mitaka version installed there before. However, I did upgrade all packages since. | 21:06 |
| *** adisky_ has quit IRC | 21:09 | |
| eharney | oh, now i see what happened | 21:12 |
| eharney | the launchpad bug was wrong, the fix is only in 1.14.0 | 21:12 |
| eharney | er, not wrong, but all the noise about 1.13.x was talking about ubuntu packages, not the upstream release | 21:12 |
| Redcavalier | aaah | 21:13 |
| Redcavalier | so updating to a newer version with pip for instance may fix it? | 21:13 |
| eharney | i can't ever say that pip installing stuff into an RPM distro is a good idea | 21:14 |
| Redcavalier | I do agree, but right now I've got a production setup on which I can't provision VMs, hence why I'm ready to try stuff like that. | 21:15 |
| openstackgerrit | Merged openstack/cinder master: Switch to use stable data_utils https://review.openstack.org/442770 | 21:16 |
| Redcavalier | I could also try to apply the patch by hand though. | 21:17 |
| eharney | this fix is actually in privsep's stable/newton branch, but, no release... | 21:20 |
| Redcavalier | I see, so it's only that it hasn't been packaged by rdo yet | 21:22 |
| eharney | right | 21:22 |
| Redcavalier | I actually know a guy at rdo so I'll poke him | 21:22 |
| *** lpetrut has joined #openstack-cinder | 21:23 | |
| Redcavalier | Thanks for the help. Spent the whole day yesterday until early morning trying to figure this out. Hopefully this will update will fix it. | 21:23 |
| *** JoseMello has quit IRC | 21:25 | |
| xinli | @smcginnis: could you please restore 295480? | 21:26 |
| *** markvoelker has joined #openstack-cinder | 21:27 | |
| *** prashkre has quit IRC | 21:30 | |
| *** salv-orlando has joined #openstack-cinder | 21:31 | |
| *** markvoelker has quit IRC | 21:32 | |
| *** Yogi1 has quit IRC | 21:35 | |
| *** gouthamr has quit IRC | 21:38 | |
| xinli | eharney: Does any core team member have the auth to restore a patch (abandoned one)? | 21:38 |
| *** crushil has joined #openstack-cinder | 21:39 | |
| *** dillaman has quit IRC | 21:43 | |
| xinli | xyang1: I saw your comments, it seems that patch 336092 (generic function won't support). can you help to restore abandoned patch? | 21:44 |
| xyang1 | xinli: which one? | 21:46 |
| xinli | xyang1: 295480. | 21:47 |
| xyang1 | It is already restored | 21:47 |
| xyang1 | By eharney | 21:47 |
| xinli | xyang1: @smcginnis restored it ? | 21:47 |
| xyang1 | xinli: eharney | 21:48 |
| xinli | xyang1: eharney: thank you very much | 21:48 |
| openstackgerrit | Merged openstack/cinder master: Change the default value of used Glance API https://review.openstack.org/441481 | 21:49 |
| *** crushil has quit IRC | 21:53 | |
| *** sdague has quit IRC | 21:55 | |
| *** gouthamr has joined #openstack-cinder | 22:01 | |
| openstackgerrit | Xinli Guan proposed openstack/cinder master: rbd: resize volume not cloned but full copy https://review.openstack.org/295480 | 22:01 |
| *** eharney_ has joined #openstack-cinder | 22:03 | |
| *** jonesn has quit IRC | 22:04 | |
| *** ducttape_ has quit IRC | 22:05 | |
| *** ducttape_ has joined #openstack-cinder | 22:05 | |
| *** eharney has quit IRC | 22:07 | |
| *** eharney_ is now known as eharney | 22:09 | |
| *** dave-mccowan has quit IRC | 22:13 | |
| karthikp_ | erlon: Hi Erlon, wanted to check with you if there is any merit adding a test case for https://github.com/openstack/cinder/blob/f017a8b13b91718bbbebe7c571da96a0d580e54f/cinder/volume/driver.py#L843 | 22:16 |
| karthikp_ | uni test | 22:17 |
| *** edmondsw has quit IRC | 22:20 | |
| *** Redcavalier has quit IRC | 22:23 | |
| *** edmondsw has joined #openstack-cinder | 22:23 | |
| *** chlong_ has quit IRC | 22:24 | |
| xinli | xyqng1: could you please help to restore 328828? | 22:24 |
| *** alonmarx_ has quit IRC | 22:25 | |
| *** edmondsw has quit IRC | 22:28 | |
| xinli | xyang1: could you please help to restore 328828? | 22:28 |
| xyang1 | xinli: done | 22:29 |
| xinli | xyang1: thx | 22:29 |
| *** chhavi_ has joined #openstack-cinder | 22:31 | |
| *** porrua_ has quit IRC | 22:32 | |
| *** lpetrut has quit IRC | 22:33 | |
| *** chhavi_ has quit IRC | 22:35 | |
| *** alonma has joined #openstack-cinder | 22:39 | |
| *** alonma has quit IRC | 22:44 | |
| *** catintheroof has quit IRC | 22:44 | |
| *** mriedem has quit IRC | 22:52 | |
| openstackgerrit | Xinli Guan proposed openstack/cinder master: Fix xio driver bug: cloned with src vol size https://review.openstack.org/328828 | 22:53 |
| *** markvoelker has joined #openstack-cinder | 22:54 | |
| *** ducttape_ has quit IRC | 22:55 | |
| *** ducttape_ has joined #openstack-cinder | 22:55 | |
| *** edmondsw has joined #openstack-cinder | 22:57 | |
| *** xyang1 has quit IRC | 22:58 | |
| openstackgerrit | christopher.uhler proposed openstack/os-brick master: os-brick connector for Veritas HyperScale https://review.openstack.org/442754 | 22:59 |
| *** edmondsw has quit IRC | 23:01 | |
| *** dustins has quit IRC | 23:05 | |
| *** raunak has quit IRC | 23:05 | |
| *** Jack_I has quit IRC | 23:06 | |
| karthikp_ | A quick question...If I have to write a unit case for a method in the volume/manager.py....where would I place that test? | 23:11 |
| *** eharney has quit IRC | 23:12 | |
| *** raunak has joined #openstack-cinder | 23:13 | |
| *** gaurangt has quit IRC | 23:19 | |
| *** gaurangt has joined #openstack-cinder | 23:19 | |
| jgriffith | karthikp_ which method? | 23:27 |
| karthikp_ | jgriffith: remove_export https://github.com/openstack/cinder/blob/e8bbccd42b95894f6fe866ba26cbf069fdd5276c/cinder/volume/manager.py#L1552 | 23:28 |
| *** catintheroof has joined #openstack-cinder | 23:28 | |
| jgriffith | karthikp_ without knowing exactly what you want to do, I'd guess probably volume/test_volume | 23:30 |
| jgriffith | sort of the catch all I'm afraid :( | 23:30 |
| jgriffith | you could create a test_volume_manager.py file :) | 23:30 |
| *** xinli has quit IRC | 23:30 | |
| jgriffith | karthikp_ but I'm curious, because ther'es not much going on in that method... | 23:31 |
| jgriffith | there's a fetch to the db.. and a driver call... that's about it | 23:31 |
| jgriffith | karthikp_ unless you want to make sure "LOG" works :) | 23:31 |
| smcginnis | NOOO | 23:32 |
| jgriffith | @smcginnis uh-oh | 23:32 |
| smcginnis | :) | 23:32 |
| jgriffith | karthikp_ what are you trying to test precisely? | 23:32 |
| karthikp_ | jgriffith: I was adding a unit test case for this method..thats all. I wanted to increase the test coverage. It showed in tox -e cover as uncovered. | 23:32 |
| jgriffith | karthikp_ oh.. please don't | 23:32 |
| jgriffith | coverage for the sake of coverage numbers is horrible IMO | 23:33 |
| jgriffith | karthikp_ you wouldn't actually be testing anything anyway | 23:33 |
| jgriffith | by the time you mock the db call and the driver call what are you testing? | 23:33 |
| jgriffith | try/except and LOG? | 23:33 |
| jgriffith | Really? | 23:33 |
| jgriffith | That's just egregious waste | 23:33 |
| Swanson | Stop! Stop! He's already dead! *sob* | 23:34 |
| jgriffith | Swanson ? | 23:34 |
| jgriffith | Maybe I should just call it a day | 23:34 |
| karthikp_ | jgriffith: Makes sense. Any areas on top of your mind ..that I can look at ..for increasing test coverage? | 23:35 |
| *** ducttape_ has quit IRC | 23:35 | |
| Swanson | jgriffith, I's just messing with you. And I agree with your premise. Doesn't mean that I haven't been beaten into providing pointless unit tests, tho. | 23:35 |
| jgriffith | karthikp_ not off the top of my head; honestly there's always tons of room to make the tests more benefecial | 23:35 |
| jgriffith | we do a lot of testing of nothing as it is | 23:36 |
| jgriffith | Swanson Ohhh! Got ya | 23:36 |
| * jgriffith was wondering if he contradicted an earlier conversation or something :) | 23:36 | |
| *** diablo_rojo has quit IRC | 23:37 | |
| jgriffith | I've been screwing with micro-versions and when/how to use them etc and my brain is pretty much scrambled at this point | 23:37 |
| *** mriedem has joined #openstack-cinder | 23:37 | |
| *** diablo_rojo has joined #openstack-cinder | 23:37 | |
| karthikp_ | jgriffith: Thanks! I am glad I checked with you first :) | 23:37 |
| Swanson | When to use them? When forced. How? minimally. | 23:38 |
| *** ducttape_ has joined #openstack-cinder | 23:38 | |
| *** diablo_rojo_phon has quit IRC | 23:40 | |
| *** tsuzuki has joined #openstack-cinder | 23:52 | |
| *** cknight has quit IRC | 23:52 | |
| openstackgerrit | Tom Swanson proposed openstack/cinder master: WIP Dell EMC SC: Support generic groups https://review.openstack.org/443364 | 23:55 |
| *** david-lyle has quit IRC | 23:56 | |
| *** nicolasbock has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!