*** diablo_rojo has joined #openstack-cinder | 00:05 | |
*** Julien-zte has joined #openstack-cinder | 00:17 | |
*** yongwc has joined #openstack-cinder | 00:28 | |
*** yongwc has quit IRC | 00:31 | |
*** yongwc has joined #openstack-cinder | 00:32 | |
*** dikonoor has joined #openstack-cinder | 00:32 | |
*** Apoorva has quit IRC | 00:37 | |
*** markstur has quit IRC | 00:41 | |
*** markstur has joined #openstack-cinder | 00:42 | |
*** wangyong__ has joined #openstack-cinder | 00:44 | |
*** markstur has quit IRC | 00:46 | |
*** yongwc has quit IRC | 00:46 | |
*** gouthamr has joined #openstack-cinder | 00:46 | |
*** wanghao has joined #openstack-cinder | 00:48 | |
*** Shunli has joined #openstack-cinder | 00:55 | |
*** sdague has quit IRC | 00:58 | |
*** imacdonn_ has joined #openstack-cinder | 00:59 | |
*** wanghao_ has joined #openstack-cinder | 01:02 | |
*** wanghao has quit IRC | 01:02 | |
*** gman-tx has quit IRC | 01:04 | |
*** yangyapeng has joined #openstack-cinder | 01:18 | |
*** zhenguo has joined #openstack-cinder | 01:19 | |
*** Apoorva has joined #openstack-cinder | 01:19 | |
*** yangyapeng has quit IRC | 01:20 | |
*** yangyape_ has joined #openstack-cinder | 01:20 | |
*** Apoorva has quit IRC | 01:20 | |
openstackgerrit | TommyLike proposed openstack/cinder master: Use cg object when invoking update cg method. https://review.openstack.org/460365 | 01:30 |
---|---|---|
*** diablo_rojo has quit IRC | 01:30 | |
*** yangyape_ has quit IRC | 01:30 | |
*** yangyapeng has joined #openstack-cinder | 01:31 | |
*** yangyapeng has quit IRC | 01:35 | |
*** kaisers has quit IRC | 01:37 | |
*** yangyapeng has joined #openstack-cinder | 01:37 | |
*** gcb has joined #openstack-cinder | 01:38 | |
*** gouthamr has quit IRC | 01:42 | |
*** dikonoor has quit IRC | 01:42 | |
*** wangyong__ is now known as yongwc | 01:51 | |
*** chenying__ has joined #openstack-cinder | 01:55 | |
*** chenying_ has quit IRC | 01:55 | |
*** zhurong has joined #openstack-cinder | 02:03 | |
*** rkmrHonjo has joined #openstack-cinder | 02:03 | |
*** huanxuan has joined #openstack-cinder | 02:07 | |
rkmrHonjo | hemna: Hi. My patch https://review.openstack.org/#/c/446401/ got -2 by you. But I'd afraid that you don't understand my report. I replied to you on gerrit. I'd appreciate it if you read it and reply for me. | 02:07 |
*** zhugaoxiao has quit IRC | 02:10 | |
*** wxy has joined #openstack-cinder | 02:14 | |
*** dhinesh has quit IRC | 02:17 | |
*** zhurong has quit IRC | 02:18 | |
openstackgerrit | TommyLike proposed openstack/cinder master: Refactor 'update_group' method https://review.openstack.org/460371 | 02:18 |
*** zul has quit IRC | 02:19 | |
openstackgerrit | Peter Wang proposed openstack/cinder master: Add VNX replication group support https://review.openstack.org/459205 | 02:22 |
*** mriedem has quit IRC | 02:34 | |
*** zhangguoqing has joined #openstack-cinder | 02:34 | |
*** dave-mccowan has quit IRC | 02:36 | |
*** dave-mccowan has joined #openstack-cinder | 02:37 | |
*** dave-mccowan has quit IRC | 02:37 | |
*** zhurong has joined #openstack-cinder | 02:43 | |
*** dave-mcc_ has joined #openstack-cinder | 02:44 | |
*** zhangguoqing has quit IRC | 02:45 | |
*** chlong has joined #openstack-cinder | 02:48 | |
*** liverpooler has quit IRC | 02:50 | |
*** gouthamr has joined #openstack-cinder | 02:51 | |
*** dhinesh has joined #openstack-cinder | 03:11 | |
*** huanxuan_ has joined #openstack-cinder | 03:20 | |
*** huanxuan has quit IRC | 03:23 | |
*** dave-mcc_ has quit IRC | 03:24 | |
*** nicolasbock has quit IRC | 03:27 | |
*** psachin has joined #openstack-cinder | 03:32 | |
*** zhurong has quit IRC | 03:42 | |
*** dhinesh has quit IRC | 03:47 | |
*** dikonoor has joined #openstack-cinder | 03:57 | |
*** gouthamr has quit IRC | 04:01 | |
*** kaisers has joined #openstack-cinder | 04:01 | |
*** rarora has quit IRC | 04:06 | |
*** dikonoor has quit IRC | 04:08 | |
*** abhitechie has joined #openstack-cinder | 04:08 | |
*** Poornima has joined #openstack-cinder | 04:10 | |
*** gkadam has joined #openstack-cinder | 04:12 | |
*** rarora has joined #openstack-cinder | 04:19 | |
*** alonma has joined #openstack-cinder | 04:34 | |
*** chhavi has joined #openstack-cinder | 04:35 | |
*** markstur has joined #openstack-cinder | 04:35 | |
*** kaisers has quit IRC | 04:39 | |
*** Poornima has quit IRC | 04:42 | |
*** stakeda has quit IRC | 04:46 | |
*** stakeda has joined #openstack-cinder | 04:47 | |
*** salv-orlando has joined #openstack-cinder | 04:51 | |
*** adisky_ has joined #openstack-cinder | 04:56 | |
*** pgadiya has joined #openstack-cinder | 04:58 | |
*** dikonoor has joined #openstack-cinder | 05:05 | |
*** kaisers has joined #openstack-cinder | 05:09 | |
*** kaisers_ has joined #openstack-cinder | 05:14 | |
*** kaisers has quit IRC | 05:15 | |
*** isaacb has joined #openstack-cinder | 05:18 | |
*** dikonoor has quit IRC | 05:21 | |
*** alonma has quit IRC | 05:45 | |
*** alonma has joined #openstack-cinder | 05:46 | |
*** e0ne has joined #openstack-cinder | 05:49 | |
*** alonma has quit IRC | 05:50 | |
*** bkopilov has quit IRC | 05:52 | |
*** bkopilov has joined #openstack-cinder | 05:52 | |
*** e0ne has quit IRC | 05:55 | |
*** dikonoor has joined #openstack-cinder | 06:05 | |
*** Poornima has joined #openstack-cinder | 06:11 | |
*** zhurong has joined #openstack-cinder | 06:13 | |
openstackgerrit | fupingxie proposed openstack/cinder master: Spelling error "paramenter" https://review.openstack.org/460408 | 06:13 |
*** rkmrHonjo has quit IRC | 06:15 | |
*** dikonoo has joined #openstack-cinder | 06:16 | |
*** dikonoor has quit IRC | 06:16 | |
*** markstur has quit IRC | 06:28 | |
*** ChubYann has quit IRC | 06:30 | |
*** zhangguoqing has joined #openstack-cinder | 06:42 | |
*** zhangguoqing has quit IRC | 06:42 | |
*** zhangguoqing has joined #openstack-cinder | 06:42 | |
*** alonma has joined #openstack-cinder | 06:43 | |
*** zhangguoqing has quit IRC | 06:43 | |
*** zhangguoqing has joined #openstack-cinder | 06:44 | |
*** pcaruana has joined #openstack-cinder | 06:44 | |
*** Julien-zte has quit IRC | 06:45 | |
*** Julien-zte has joined #openstack-cinder | 06:46 | |
*** salv-orlando has quit IRC | 06:48 | |
*** Julien-zte has quit IRC | 06:54 | |
*** Julien-zte has joined #openstack-cinder | 06:55 | |
*** isaacb has quit IRC | 06:57 | |
*** alonma has quit IRC | 06:57 | |
*** alonma has joined #openstack-cinder | 06:58 | |
*** arne_r has joined #openstack-cinder | 06:59 | |
*** lkuchlan has joined #openstack-cinder | 07:00 | |
*** alonma_ has joined #openstack-cinder | 07:02 | |
*** zhurong has quit IRC | 07:02 | |
*** alonma has quit IRC | 07:02 | |
*** zhurong has joined #openstack-cinder | 07:06 | |
*** salv-orlando has joined #openstack-cinder | 07:07 | |
*** Nakato has quit IRC | 07:08 | |
*** Nakato has joined #openstack-cinder | 07:08 | |
*** tesseract has joined #openstack-cinder | 07:09 | |
*** lkuchlan has quit IRC | 07:09 | |
*** Julien-zte has quit IRC | 07:17 | |
*** Julien-zte has joined #openstack-cinder | 07:18 | |
*** lkuchlan has joined #openstack-cinder | 07:23 | |
*** Julien-zte has quit IRC | 07:28 | |
*** Julien-zte has joined #openstack-cinder | 07:30 | |
*** Nakato has quit IRC | 07:30 | |
*** Nakato has joined #openstack-cinder | 07:31 | |
*** dikonoo has quit IRC | 07:32 | |
*** zhurong has quit IRC | 07:37 | |
openstackgerrit | wzyuliyang proposed openstack/cinder master: Add pigz support for cinder-backup chunked driver compression https://review.openstack.org/450291 | 07:41 |
*** mlakat_ has joined #openstack-cinder | 07:47 | |
*** mlakat has quit IRC | 07:47 | |
*** mlakat_ is now known as mlakat | 07:47 | |
*** e0ne has joined #openstack-cinder | 07:52 | |
*** alonma_ has quit IRC | 07:54 | |
*** alonma_ has joined #openstack-cinder | 07:56 | |
openstackgerrit | Michal Dulko proposed openstack/cinder master: Read XtremIO options from self.configuration https://review.openstack.org/453617 | 07:57 |
openstackgerrit | Michal Dulko proposed openstack/cinder master: Move driver options to "backend" section https://review.openstack.org/453654 | 07:57 |
openstackgerrit | Michal Dulko proposed openstack/cinder master: Read rbd options from self.configuration, not CONF https://review.openstack.org/453598 | 07:57 |
openstackgerrit | Michal Dulko proposed openstack/cinder master: Remove usage of CONF from DISCO driver https://review.openstack.org/458167 | 07:57 |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-cinder | 08:00 | |
*** Julien-zte has quit IRC | 08:00 | |
*** Julien-zte has joined #openstack-cinder | 08:01 | |
*** MasterofJOKers has quit IRC | 08:02 | |
*** MasterofJOKers has joined #openstack-cinder | 08:03 | |
*** zhurong has joined #openstack-cinder | 08:19 | |
*** yongwc has quit IRC | 08:20 | |
*** bkopilov has quit IRC | 08:23 | |
*** pgadiya has quit IRC | 08:26 | |
*** yongwc has joined #openstack-cinder | 08:26 | |
*** Julien-zte has quit IRC | 08:27 | |
*** Julien-zte has joined #openstack-cinder | 08:29 | |
*** alonma_ has quit IRC | 08:31 | |
*** Julien-zte has quit IRC | 08:31 | |
*** Julien-zte has joined #openstack-cinder | 08:33 | |
*** alonma has joined #openstack-cinder | 08:37 | |
*** abhitechie has quit IRC | 08:44 | |
*** Julien-zte has quit IRC | 08:45 | |
*** Julien-zte has joined #openstack-cinder | 08:46 | |
*** e0ne has quit IRC | 08:48 | |
*** e0ne has joined #openstack-cinder | 08:49 | |
*** lpetrut has joined #openstack-cinder | 08:50 | |
*** bkopilov has joined #openstack-cinder | 08:52 | |
openstackgerrit | TommyLike proposed openstack/cinder master: Add support for generalized filtering on list APIs https://review.openstack.org/444598 | 08:53 |
*** yongwc has quit IRC | 09:00 | |
*** yongwc has joined #openstack-cinder | 09:02 | |
*** Julien-zte has quit IRC | 09:03 | |
openstackgerrit | NidhiMittalHada proposed openstack/cinder master: validate_integer doesn't check non int properly https://review.openstack.org/451316 | 09:03 |
*** Julien-zte has joined #openstack-cinder | 09:05 | |
*** zhangguoqing has quit IRC | 09:06 | |
*** yongwc has quit IRC | 09:07 | |
openstackgerrit | fupingxie proposed openstack/cinder master: Spelling error "paramenter" https://review.openstack.org/460408 | 09:08 |
*** Julien-zte has quit IRC | 09:09 | |
*** Julien-zte has joined #openstack-cinder | 09:10 | |
*** Julien-zte has quit IRC | 09:11 | |
*** Julien-zte has joined #openstack-cinder | 09:12 | |
openstackgerrit | wzyuliyang proposed openstack/cinder master: Add pigz support for cinder-backup chunked driver compression https://review.openstack.org/450291 | 09:13 |
openstackgerrit | wzyuliyang proposed openstack/cinder master: Add pigz support for cinder-backup chunked driver compression https://review.openstack.org/450291 | 09:14 |
*** aarefiev_afk is now known as aarefiev | 09:16 | |
*** rarora has quit IRC | 09:18 | |
*** Julien-zte has quit IRC | 09:25 | |
*** Julien-zte has joined #openstack-cinder | 09:27 | |
*** e0ne has quit IRC | 09:30 | |
*** yongwc has joined #openstack-cinder | 09:33 | |
*** dalgaaf has quit IRC | 09:34 | |
*** dalgaaf has joined #openstack-cinder | 09:36 | |
*** e0ne has joined #openstack-cinder | 09:36 | |
*** alonma has quit IRC | 09:40 | |
*** alonma has joined #openstack-cinder | 09:43 | |
*** alonma has quit IRC | 09:44 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Fix host check in is_backend_frozen https://review.openstack.org/448147 | 09:45 |
*** stakeda has quit IRC | 09:45 | |
*** zhangguoqing has joined #openstack-cinder | 09:48 | |
openstackgerrit | wzyuliyang proposed openstack/cinder master: Add pigz support for cinder-backup chunked driver compression https://review.openstack.org/450291 | 09:48 |
*** salv-orl_ has joined #openstack-cinder | 09:49 | |
*** salv-orlando has quit IRC | 09:52 | |
tommylikehu | does anyone would like to take a look at these two simple patches? https://review.openstack.org/#/c/460365/, https://review.openstack.org/#/c/460371/ | 09:55 |
tommylikehu | thanks in advance :) | 09:55 |
*** lpetrut_ has joined #openstack-cinder | 09:58 | |
*** Julien-zte has quit IRC | 09:59 | |
*** ociuhandu has quit IRC | 09:59 | |
*** lpetrut has quit IRC | 10:00 | |
openstackgerrit | wzyuliyang proposed openstack/cinder master: Add pigz support for cinder-backup chunked driver compression https://review.openstack.org/450291 | 10:02 |
*** nicolasbock has joined #openstack-cinder | 10:03 | |
*** alonma has joined #openstack-cinder | 10:03 | |
*** mvk has quit IRC | 10:04 | |
*** alonma_ has joined #openstack-cinder | 10:05 | |
*** Shunli has quit IRC | 10:05 | |
*** alonma has quit IRC | 10:07 | |
*** zul has joined #openstack-cinder | 10:09 | |
*** zhurong has quit IRC | 10:20 | |
*** mlakat has quit IRC | 10:26 | |
*** huanxuan_ has quit IRC | 10:27 | |
*** zhurong has joined #openstack-cinder | 10:28 | |
*** yangyape_ has joined #openstack-cinder | 10:29 | |
*** rarora has joined #openstack-cinder | 10:29 | |
*** psachin has quit IRC | 10:30 | |
*** psachin has joined #openstack-cinder | 10:33 | |
*** mvk has joined #openstack-cinder | 10:34 | |
openstackgerrit | NidhiMittalHada proposed openstack/cinder master: Issue in logs while creating cinder volume https://review.openstack.org/460496 | 10:36 |
*** yangyape_ has quit IRC | 10:37 | |
*** salv-orl_ has quit IRC | 10:38 | |
*** The_Ball has quit IRC | 10:38 | |
*** The_Ball has joined #openstack-cinder | 10:38 | |
*** yangyapeng has quit IRC | 10:38 | |
*** yangyapeng has joined #openstack-cinder | 10:39 | |
*** yangyapeng has quit IRC | 10:43 | |
openstackgerrit | TommyLike proposed openstack/cinder master: Add support for generalized filtering on list APIs https://review.openstack.org/444598 | 10:48 |
*** chhavi has quit IRC | 10:48 | |
*** edmondsw has joined #openstack-cinder | 10:53 | |
*** alonma_ has quit IRC | 10:59 | |
*** alonma has joined #openstack-cinder | 11:02 | |
*** sdague has joined #openstack-cinder | 11:04 | |
*** dave-mccowan has joined #openstack-cinder | 11:09 | |
*** markvoelker_ has joined #openstack-cinder | 11:11 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - Compression, replacing SMI-S with REST https://review.openstack.org/460191 | 11:11 |
*** markvoelker has quit IRC | 11:12 | |
*** lkuchlan has quit IRC | 11:13 | |
*** lkuchlan has joined #openstack-cinder | 11:19 | |
*** jordanP has quit IRC | 11:22 | |
*** alonma has quit IRC | 11:22 | |
*** alonma has joined #openstack-cinder | 11:22 | |
*** zhonghua has quit IRC | 11:23 | |
*** zhonghua has joined #openstack-cinder | 11:23 | |
*** alonma has quit IRC | 11:27 | |
*** alonma has joined #openstack-cinder | 11:27 | |
*** kaisers_ has quit IRC | 11:29 | |
*** kaisers has joined #openstack-cinder | 11:30 | |
*** kaisers has quit IRC | 11:34 | |
*** yangyapeng has joined #openstack-cinder | 11:36 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Updated from global requirements https://review.openstack.org/460512 | 11:37 |
*** markvoelker_ has quit IRC | 11:38 | |
*** Poornima has quit IRC | 11:41 | |
*** kaisers has joined #openstack-cinder | 11:41 | |
*** abishop has joined #openstack-cinder | 11:45 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-brick master: Updated from global requirements https://review.openstack.org/460516 | 11:45 |
*** chhavi has joined #openstack-cinder | 11:53 | |
*** dgonzalez has quit IRC | 12:02 | |
*** dgonzalez has joined #openstack-cinder | 12:07 | |
*** zhonghua has quit IRC | 12:09 | |
*** The_Ball has quit IRC | 12:09 | |
*** zhonghua has joined #openstack-cinder | 12:10 | |
*** takedakn has joined #openstack-cinder | 12:15 | |
*** zhurong has quit IRC | 12:25 | |
*** ociuhandu has joined #openstack-cinder | 12:25 | |
*** gman-tx has joined #openstack-cinder | 12:27 | |
*** dillaman has quit IRC | 12:29 | |
*** dustins has joined #openstack-cinder | 12:31 | |
openstackgerrit | TommyLike proposed openstack/cinder master: Add support for generalized filtering on list APIs https://review.openstack.org/444598 | 12:33 |
*** markvoelker has joined #openstack-cinder | 12:35 | |
*** zhangguoqing has quit IRC | 12:36 | |
*** liverpooler has joined #openstack-cinder | 12:38 | |
*** crushil has joined #openstack-cinder | 12:38 | |
*** gkadam has quit IRC | 12:41 | |
*** dillaman has joined #openstack-cinder | 12:42 | |
*** mlakat has joined #openstack-cinder | 12:42 | |
*** jonesn has joined #openstack-cinder | 12:47 | |
openstackgerrit | Julien Danjou proposed openstack/cinder master: coordination: remove custom Lock object https://review.openstack.org/447503 | 12:48 |
openstackgerrit | Julien Danjou proposed openstack/cinder master: coordination: use tooz builtin heartbeat feature https://review.openstack.org/447079 | 12:48 |
openstackgerrit | Julien Danjou proposed openstack/cinder master: coordination: remove un-used method is_active() https://review.openstack.org/460532 | 12:48 |
*** dillaman has quit IRC | 12:49 | |
*** jdillaman has quit IRC | 12:50 | |
*** arne_r has quit IRC | 12:52 | |
*** zhonghua has quit IRC | 12:53 | |
*** zhonghua has joined #openstack-cinder | 12:53 | |
*** zhangguoqing has joined #openstack-cinder | 12:54 | |
*** zhurong has joined #openstack-cinder | 12:58 | |
*** zhangguoqing has quit IRC | 13:01 | |
*** jdillaman has joined #openstack-cinder | 13:02 | |
*** dillaman has joined #openstack-cinder | 13:02 | |
*** wanghao has joined #openstack-cinder | 13:04 | |
*** wanghao has quit IRC | 13:05 | |
*** zhangguoqing has joined #openstack-cinder | 13:06 | |
*** mriedem has joined #openstack-cinder | 13:06 | |
*** wanghao_ has quit IRC | 13:07 | |
*** salv-orlando has joined #openstack-cinder | 13:12 | |
openstackgerrit | wangxiyuan proposed openstack/cinder master: Fix keystone auth for novaclient https://review.openstack.org/460541 | 13:14 |
*** catintheroof has joined #openstack-cinder | 13:17 | |
jgriffith | tommylikehu ping | 13:18 |
tommylikehu | Hey jgriffith | 13:19 |
*** bswartz has joined #openstack-cinder | 13:19 | |
jgriffith | tommylikehu Hi! | 13:20 |
jgriffith | tommylikehu Hey… I finally reviewed https://review.openstack.org/#/c/444598/17 | 13:20 |
jgriffith | tommylikehu thank you!!!! | 13:20 |
jgriffith | That looks great | 13:20 |
tommylikehu | jgriffith: thanks:) | 13:21 |
*** Julien-zte has joined #openstack-cinder | 13:21 | |
tommylikehu | still working on that. And any suggestion? | 13:21 |
Dinesh_Bhor | jgriffith: hi, have time to take a look at it? https://review.openstack.org/#/c/454562/ | 13:22 |
*** zengyingzhe has quit IRC | 13:25 | |
*** Julien-zte has quit IRC | 13:26 | |
*** zengyingzhe has joined #openstack-cinder | 13:26 | |
*** Julien-zte has joined #openstack-cinder | 13:28 | |
*** Julien-zte has quit IRC | 13:28 | |
*** Julien-zte has joined #openstack-cinder | 13:29 | |
*** Julien-zte has quit IRC | 13:30 | |
*** Julien-zte has joined #openstack-cinder | 13:31 | |
*** alonma has quit IRC | 13:31 | |
*** alonma has joined #openstack-cinder | 13:31 | |
*** Julien-zte has quit IRC | 13:37 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: LIO: Fix terminate_connection AttributeError https://review.openstack.org/458192 | 13:38 |
*** eharney has joined #openstack-cinder | 13:38 | |
*** alonma has quit IRC | 13:38 | |
*** Julien-zte has joined #openstack-cinder | 13:38 | |
*** alonma has joined #openstack-cinder | 13:39 | |
*** alonma has quit IRC | 13:39 | |
*** alonma has joined #openstack-cinder | 13:39 | |
*** diablo_rojo has joined #openstack-cinder | 13:46 | |
*** lamt has joined #openstack-cinder | 13:49 | |
*** dillaman has quit IRC | 13:49 | |
*** adisky_ has quit IRC | 13:49 | |
*** takedakn has quit IRC | 13:51 | |
*** zhaochao has joined #openstack-cinder | 13:55 | |
*** psachin has quit IRC | 13:56 | |
*** xyang has joined #openstack-cinder | 13:58 | |
*** xyang has quit IRC | 14:01 | |
*** dillaman has joined #openstack-cinder | 14:02 | |
jgriffith | tommylikehu no I think it looks really good, I’d suggest breaking the different objects into separate commits if you’re going to keep going with it | 14:07 |
jgriffith | tommylikehu having everything in one patch is going to be hard to get reviewed IMO | 14:07 |
*** yongwc has quit IRC | 14:08 | |
tommylikehu | thanks jgriffith , I don't like that either. I added them all because most of the logic are similiar. if you or anyone else insist on this, I will split it into different ones. | 14:09 |
jgriffith | tommylikehu yeah, I get it.. the logic is identical in all of them | 14:09 |
jgriffith | tommylikehu my thought was just get the first iteration with Volume approved and hammered out / merged before propagating to all the others. In particular never know if somebody might want to change something in how you did it (or propose a change, or find an issue) | 14:10 |
jgriffith | tommylikehu I certainly don’t have a strong enough opinion one way or the other on it, so no worries from me. Multiple patches are nice from a review perspective | 14:11 |
jgriffith | Not so nice from a “get it done” perspective | 14:11 |
tommylikehu | jgriffith: if that way will not add more review's burden for you, I will split it :) | 14:13 |
jgriffith | tommylikehu don’t do it for me :) | 14:14 |
jgriffith | Wait and see what others think | 14:14 |
openstackgerrit | Julien Danjou proposed openstack/cinder master: coordination: remove custom Lock object https://review.openstack.org/447503 | 14:14 |
openstackgerrit | Julien Danjou proposed openstack/cinder master: coordination: use tooz builtin heartbeat feature https://review.openstack.org/447079 | 14:14 |
*** dillaman has quit IRC | 14:14 | |
tommylikehu | jgriffith: thanks | 14:15 |
*** uberjay has quit IRC | 14:18 | |
*** uberjay has joined #openstack-cinder | 14:20 | |
*** felipemonteiro__ has joined #openstack-cinder | 14:21 | |
*** felipemonteiro_ has joined #openstack-cinder | 14:23 | |
*** salv-orlando has quit IRC | 14:23 | |
dr_gogeta86 | xyang1, hi | 14:23 |
dr_gogeta86 | back on track | 14:24 |
dr_gogeta86 | I'm clean up the whole stack right now | 14:24 |
dr_gogeta86 | things to check while offline ? | 14:24 |
hemna | mep | 14:26 |
*** felipemonteiro__ has quit IRC | 14:27 | |
*** diablo_rojo has quit IRC | 14:27 | |
*** yangyape_ has joined #openstack-cinder | 14:27 | |
*** dillaman has joined #openstack-cinder | 14:30 | |
*** yangyapeng has quit IRC | 14:30 | |
*** gouthamr has joined #openstack-cinder | 14:31 | |
*** zhangguoqing has quit IRC | 14:31 | |
*** xyang has joined #openstack-cinder | 14:31 | |
*** zhangguoqing has joined #openstack-cinder | 14:32 | |
*** felipemonteiro has joined #openstack-cinder | 14:33 | |
*** felipemonteiro_ has quit IRC | 14:35 | |
*** zhangguoqing has quit IRC | 14:37 | |
*** salv-orlando has joined #openstack-cinder | 14:38 | |
*** zhurong has quit IRC | 14:39 | |
*** lpetrut_ has quit IRC | 14:40 | |
*** lkuchlan has quit IRC | 14:42 | |
*** darrenc has quit IRC | 14:43 | |
openstackgerrit | Julien Danjou proposed openstack/cinder master: coordination: remove custom Lock object https://review.openstack.org/447503 | 14:53 |
openstackgerrit | Julien Danjou proposed openstack/cinder master: coordination: use tooz builtin heartbeat feature https://review.openstack.org/447079 | 14:53 |
tommylikehu | hey xyang1 , smcginnis this patch backports the bug you reviewed several hour ago :) | 14:53 |
*** alonma has quit IRC | 14:56 | |
*** alonma has joined #openstack-cinder | 14:56 | |
*** cknight has joined #openstack-cinder | 14:57 | |
*** xyang has quit IRC | 14:59 | |
*** alonma has quit IRC | 15:01 | |
*** xyang has joined #openstack-cinder | 15:01 | |
xyang | tommylikehu: no idea which patch you are talking about:) | 15:02 |
tommylikehu | I have no idea either :) I remembered to pasted it here: https://review.openstack.org/#/c/460618/ | 15:03 |
xyang | dr_gogeta86: hi, I didn't find anything obvious in your conf file. So nothing specific. Just make sure your SMI-S provider is working with the backend array. You are using FC? make sure zoning is set up | 15:04 |
*** pcaruana has quit IRC | 15:05 | |
*** zhonghua has quit IRC | 15:07 | |
*** zhonghua has joined #openstack-cinder | 15:08 | |
*** mlakat has quit IRC | 15:11 | |
openstackgerrit | Merged openstack/cinder master: Validate uuid parameters strictly for create volume API https://review.openstack.org/454562 | 15:11 |
openstackgerrit | Merged openstack/cinder master: Volume Type Encryption added to v2 api-ref https://review.openstack.org/459940 | 15:13 |
smcginnis | tommylikehu: How did you backport that patch? It doesn't have the necessary cherry pick information in the commit. | 15:13 |
smcginnis | tommylikehu: Oh, I see others have already commented on there. Sorry. :0 | 15:14 |
tommylikehu | I just pressed the cherry pick button on the website :( | 15:14 |
tommylikehu | smcginnis: anything wrong? | 15:14 |
tommylikehu | smcginnis: or because it's original patch has not been merged? | 15:15 |
*** zigo has quit IRC | 15:17 | |
smcginnis | tommylikehu: Hmm, maybe that doesn't work right through gerrit. Not sure, but it should include the cherry pick info in the commit. | 15:17 |
smcginnis | tommylikehu: I think I've used a workflow similar to this: https://docs.openstack.org/contributor-guide/additional-git-workflow/cherry-pick.html | 15:18 |
tommylikehu | smcginnis: will add it | 15:18 |
smcginnis | tommylikehu: Maybe it doesn't add that until it's merged in master. Can't remember now. | 15:18 |
tommylikehu | add that manually | 15:19 |
dr_gogeta86 | xyang, it's all working ... but pretty slow | 15:19 |
tommylikehu | I could | 15:19 |
smcginnis | tommylikehu: The commit id looks right, so maybe adding it manually would be the easiest at this point. | 15:19 |
xyang | dr_gogeta86: it's slow without the driver involved? | 15:22 |
dr_gogeta86 | no | 15:23 |
xyang | dr_gogeta86: please open a bug with logs uploaded so we can take a look | 15:26 |
cFouts | hi, xyang. If the consistency group to volume group migration script doesn't also upgrade existing extra-specs that have "consistencygroup_support" defined won't that lead to a bad user experience? | 15:26 |
xyang | cFouts: migration script should not change volume type definition | 15:26 |
cFouts | xyang: You can't change extra-specs now when a volume type is in being used by volumes | 15:27 |
xyang | cFouts: you can | 15:27 |
cFouts | xyang: not without specifying another configuration option | 15:27 |
xyang | cFouts: unless some patch was merged that I don't know | 15:27 |
xyang | cFouts: Also consistency group_support is not a required spec | 15:28 |
openstackgerrit | Gyorgy Szombathelyi proposed openstack/cinder master: Modernize the nova client in cinder https://review.openstack.org/460640 | 15:29 |
cFouts | xyang: There was a patch submitted by jgriffith. Looking for it. | 15:29 |
xyang | cFout: you can also keep "consistencygroup_support =True" in capability reporting to be safe | 15:29 |
cFouts | xyang: at some point the extra-specs have to be updated | 15:30 |
cFouts | xyang: unless I am missing something this seems like a bad customer experience during upgrade | 15:30 |
xyang | cFouts: I don't think migration script should change that though | 15:30 |
*** markvoelker has quit IRC | 15:30 | |
openstackgerrit | Gyorgy Szombathelyi proposed openstack/cinder master: Modernize the nova client in cinder https://review.openstack.org/460640 | 15:30 |
*** markvoelker has joined #openstack-cinder | 15:31 | |
xyang | cFouts: you can keep "consistencygroup_support =True" in your driver | 15:31 |
cFouts | xyang: yes but at some point that should be dropped, right? | 15:32 |
xyang | cFouts: it doesn't have to be dropped if we worry that someone keeps it in extra specs forever | 15:32 |
xyang | cFouts: because it was never a required spec, I didn't think it is a problem. However it is definitely possible someone might have it there | 15:33 |
cFouts | xyang: That was why I was expecting to just migrate the extra-spec as well. Otherwise we have a legacy capability that we can't deprecate, right? | 15:33 |
xyang | cFouts: I don't think extra spec for a volume type should be changed by migration script | 15:34 |
xyang | cFouts: may be it can be an extra step for admin to decide to do | 15:34 |
*** aarefiev is now known as aarefiev_afk | 15:35 | |
cFouts | xyang: yeah, the extra step is what I was trying to avoid. Having multiple steps tends to lead to customer support issues | 15:35 |
xyang | cFouts: have you written in your driver doc that consistencygroup_support should be in extra_specs? | 15:35 |
cFouts | xyang: yes | 15:35 |
xyang | cFouts: please show me | 15:36 |
openstackgerrit | Gyorgy Szombathelyi proposed openstack/cinder master: Modernize the nova client in cinder https://review.openstack.org/460640 | 15:36 |
xyang | cFouts: as I said, you can keep the capability in your driver that will make it backward compatible | 15:37 |
cFouts | https://netapp.github.io/openstack-deploy-ops-guide/mitaka/content/cinder.cdot.fc.configuration.html | 15:38 |
*** alonma has joined #openstack-cinder | 15:40 | |
*** gman-tx has quit IRC | 15:41 | |
cFouts | ok, thanks, xyang | 15:42 |
xyang | cFouts: np | 15:42 |
cFouts | xyang: here is the patch I mentioned above: https://github.com/openstack/cinder/commit/b245225d5e67120dfe7aee5e941f381846c89423 | 15:45 |
*** gman-tx has joined #openstack-cinder | 15:47 | |
xyang | cFouts: Now I remembered that patch. we should still give admin an option to change it somehow | 15:47 |
smcginnis | xyang: Why was the extra spec changed for that? I can't remember. | 15:47 |
xyang | cFouts: so in your case, keep that capability in your driver to maintain backward compatibility. In the release notes, still ask user not to use it for new volume types and group types | 15:48 |
xyang | @smcginnis: for generic volume groups, we use "consistent_group_snapshot_enabled", not "consistencygroup_support" which is tightly related to consistency | 15:48 |
smcginnis | xyang: In retrospect, seems like we should have just kept the same extra spec key. | 15:49 |
xyang | @smcginnis: so we could have "replication_group_enabled" and "consistent_replication_group_enabled" | 15:49 |
xyang | @smcginnis: we can't:) | 15:49 |
xyang | @smcginnis: if we want to support different kinds of groups | 15:49 |
*** salv-orl_ has joined #openstack-cinder | 15:50 | |
xyang | @smcginnis: I'd love to keep consistencygroups without adding generic volume groups if everyone loves "consistency" | 15:50 |
*** alonma has quit IRC | 15:50 | |
xyang | @smcginnis: tbarron told me NetApp can't support consistencygroup for replication, so we have to drop "consistency" from the key | 15:51 |
*** gman-tx has quit IRC | 15:52 | |
*** salv-orlando has quit IRC | 15:52 | |
*** imacdonn_ is now known as imacdonn | 15:52 | |
*** alonma has joined #openstack-cinder | 15:52 | |
smcginnis | Well, I'm not saying keep consistency groups. I'm just not clear why we can't use the same extra spec that we used for consistency groups for groups that are consistent. | 15:53 |
tommylikehu | hey xyang , eharney , I added the cherry pick messages manually :) https://review.openstack.org/#/c/460618/ | 15:54 |
*** Apoorva has joined #openstack-cinder | 15:54 | |
xyang | @smcginnis: because "consistencygroup_support" only means consistent group snapshot in Cinder currently. We can't say it means consistent group replication too | 15:55 |
*** gman-tx has joined #openstack-cinder | 15:56 | |
*** e0ne has quit IRC | 15:57 | |
tbarron | xyang: tbarron can't remember that stuff any more, better check with someone else | 15:58 |
Swanson | tbarron, If I made an Ice Barron joke would you get it? | 15:59 |
xyang | tbarron: sorry to reference you:) It's all in the spec review any way. we are not changing back | 15:59 |
tbarron | Swanson: seems like I should remember that and get it but my brain is too mushy | 15:59 |
tbarron | xyang: :D | 15:59 |
*** Julien-zte has quit IRC | 15:59 | |
*** zhaochao has quit IRC | 16:00 | |
Swanson | tbarron, ice bear talks in the third person a lot. | 16:00 |
*** Julien-zte has joined #openstack-cinder | 16:02 | |
*** Julien-zte has quit IRC | 16:02 | |
*** lamt has quit IRC | 16:03 | |
*** eharney has quit IRC | 16:05 | |
*** xyang has quit IRC | 16:06 | |
*** Julien-zte has joined #openstack-cinder | 16:07 | |
* tbarron is going to spend the afternoon on You Tube catching up with Yuria and the Bear | 16:07 | |
*** chlong_ has joined #openstack-cinder | 16:08 | |
*** pewp has quit IRC | 16:08 | |
*** pewp has joined #openstack-cinder | 16:08 | |
*** alonma has quit IRC | 16:13 | |
*** chlong_ has quit IRC | 16:14 | |
Swanson | What is consistent group replication exactly? | 16:17 |
*** eharney has joined #openstack-cinder | 16:18 | |
*** gman-tx has quit IRC | 16:25 | |
*** gouthamr has quit IRC | 16:31 | |
*** salv-orl_ has quit IRC | 16:36 | |
*** gouthamr has joined #openstack-cinder | 16:40 | |
tommylikehu | hey eharney , to be clear , the revert-to-snapshot patches are little outdated. we definitely would not support online volume to be reverted without the effort from nova, I will update the spec and code tomorrow :) | 16:43 |
tommylikehu | we will focus on the detached ones | 16:45 |
smcginnis | eharney: The concern with reverting boot volumes is the volume is "attached", so cinder has no way to know it's safe. | 16:46 |
smcginnis | eharney: So kind of like cinder-backup, we require the volume is 'available'. At least as a first step. | 16:46 |
eharney | smcginnis: it was referring to "bootable" volumes, not "boot volumes" or "attached" volumes | 16:47 |
eharney | the "bootable" flag is not interesting here afaik | 16:47 |
smcginnis | eharney: Oh, right! Wording. Should be boot volumes, not "bootable" volumes. | 16:47 |
*** lamt has joined #openstack-cinder | 16:48 | |
*** ociuhandu has quit IRC | 16:48 | |
tommylikehu | eharney: smcginnis , thanks | 16:49 |
openstackgerrit | Merged openstack/cinder master: Use cg object when invoking update cg method. https://review.openstack.org/460365 | 16:52 |
*** salv-orlando has joined #openstack-cinder | 17:01 | |
*** xyang has joined #openstack-cinder | 17:04 | |
*** yangyape_ has quit IRC | 17:05 | |
smcginnis | ildikov: Slow progress. ;) | 17:06 |
ildikov | smcginnis: well, Cinder and Nova are both really messy IMHO... | 17:07 |
smcginnis | ildikov: I won't argue that. | 17:07 |
*** harlowja has quit IRC | 17:08 | |
ildikov | like we deal with one small thing and a zillion other just fall on our head every second... | 17:08 |
ildikov | so who's the migrate_volume_completion expert here? :) | 17:08 |
smcginnis | ildikov: Not even sure on that. | 17:09 |
ildikov | smcginnis: then I guess I'll have to make myself one... | 17:12 |
*** gman-tx has joined #openstack-cinder | 17:12 | |
smcginnis | ildikov: :) | 17:13 |
*** gman-tx has quit IRC | 17:13 | |
*** gman-tx has joined #openstack-cinder | 17:15 | |
*** ChubYann has joined #openstack-cinder | 17:27 | |
*** dhinesh has joined #openstack-cinder | 17:37 | |
*** tongli has joined #openstack-cinder | 17:41 | |
*** harlowja has joined #openstack-cinder | 17:51 | |
*** pewp has quit IRC | 17:51 | |
*** pewp has joined #openstack-cinder | 17:52 | |
*** mvk has quit IRC | 17:53 | |
*** cknight has quit IRC | 17:56 | |
*** erlon has joined #openstack-cinder | 17:57 | |
*** chhavi has quit IRC | 17:59 | |
*** cknight has joined #openstack-cinder | 17:59 | |
*** jdurgin has joined #openstack-cinder | 18:03 | |
*** yangyapeng has joined #openstack-cinder | 18:06 | |
*** tongli has quit IRC | 18:06 | |
*** yangyapeng has quit IRC | 18:10 | |
*** dustins has quit IRC | 18:18 | |
*** salv-orlando has quit IRC | 18:27 | |
*** e0ne has joined #openstack-cinder | 18:29 | |
*** fnordahl_ has joined #openstack-cinder | 18:38 | |
*** eglute has quit IRC | 18:38 | |
*** fnordahl has quit IRC | 18:38 | |
*** eglute has joined #openstack-cinder | 18:39 | |
*** openstackgerrit has quit IRC | 18:48 | |
*** crushil has quit IRC | 18:52 | |
*** crushil has joined #openstack-cinder | 18:53 | |
*** gman-tx has quit IRC | 18:54 | |
*** openstackgerrit has joined #openstack-cinder | 19:00 | |
openstackgerrit | Merged openstack/cinder master: Spelling error "paramenter" https://review.openstack.org/460408 | 19:00 |
*** gman-tx has joined #openstack-cinder | 19:02 | |
*** crushil has quit IRC | 19:03 | |
*** kfarr has joined #openstack-cinder | 19:03 | |
*** yangyapeng has joined #openstack-cinder | 19:07 | |
*** mvk has joined #openstack-cinder | 19:08 | |
*** felipemonteiro has quit IRC | 19:08 | |
*** yangyapeng has quit IRC | 19:11 | |
*** kfarr has quit IRC | 19:25 | |
*** salv-orlando has joined #openstack-cinder | 19:30 | |
*** xyang has quit IRC | 19:33 | |
*** xyang has joined #openstack-cinder | 19:39 | |
*** xyang has quit IRC | 19:40 | |
*** kaisers has quit IRC | 19:41 | |
*** kaisers has joined #openstack-cinder | 19:42 | |
*** dustins has joined #openstack-cinder | 19:46 | |
*** kaisers has quit IRC | 19:46 | |
*** crushil has joined #openstack-cinder | 19:47 | |
*** kaisers has joined #openstack-cinder | 19:48 | |
*** porrua has quit IRC | 19:49 | |
*** crushil has quit IRC | 19:52 | |
*** e0ne has quit IRC | 20:03 | |
*** felipemonteiro has joined #openstack-cinder | 20:03 | |
*** yangyapeng has joined #openstack-cinder | 20:08 | |
*** felipemonteiro_ has joined #openstack-cinder | 20:08 | |
*** shyama has quit IRC | 20:08 | |
*** e0ne has joined #openstack-cinder | 20:10 | |
*** felipemonteiro has quit IRC | 20:11 | |
*** alonma has joined #openstack-cinder | 20:12 | |
*** yangyapeng has quit IRC | 20:12 | |
*** crushil has joined #openstack-cinder | 20:15 | |
*** eharney has quit IRC | 20:17 | |
*** Cibo_ has joined #openstack-cinder | 20:23 | |
openstackgerrit | Nicholas Jones proposed openstack/cinder master: Delete limited_by_marker from api/common.py https://review.openstack.org/460736 | 20:25 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Updated from global requirements https://review.openstack.org/460512 | 20:26 |
*** liverpooler has quit IRC | 20:26 | |
*** e0ne has quit IRC | 20:34 | |
*** kaisers has quit IRC | 20:38 | |
*** xyang has joined #openstack-cinder | 20:38 | |
*** salv-orlando has quit IRC | 20:39 | |
*** salv-orlando has joined #openstack-cinder | 20:39 | |
*** xyang has quit IRC | 20:48 | |
*** xyang has joined #openstack-cinder | 20:48 | |
*** alonma has quit IRC | 20:49 | |
*** cknight has quit IRC | 20:50 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Updated from global requirements https://review.openstack.org/460512 | 20:54 |
*** jonesn has quit IRC | 20:57 | |
*** tongli has joined #openstack-cinder | 20:59 | |
*** gman-tx has quit IRC | 20:59 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-brick-cinderclient-ext master: Updated from global requirements https://review.openstack.org/458838 | 21:03 |
*** crushil has quit IRC | 21:04 | |
*** dustins has quit IRC | 21:05 | |
*** yangyapeng has joined #openstack-cinder | 21:08 | |
*** gman-tx has joined #openstack-cinder | 21:13 | |
*** edmondsw has quit IRC | 21:14 | |
*** yangyapeng has quit IRC | 21:15 | |
*** tongli has quit IRC | 21:22 | |
*** abishop has quit IRC | 21:26 | |
*** zigo has joined #openstack-cinder | 21:32 | |
*** xyang has quit IRC | 21:47 | |
*** salv-orl_ has joined #openstack-cinder | 21:50 | |
*** Nakato has quit IRC | 21:52 | |
*** salv-orlando has quit IRC | 21:52 | |
*** Nakato has joined #openstack-cinder | 21:53 | |
*** catintheroof has quit IRC | 22:00 | |
*** jose-phillips has joined #openstack-cinder | 22:00 | |
*** salv-orl_ has quit IRC | 22:01 | |
*** Apoorva_ has joined #openstack-cinder | 22:01 | |
*** Apoorva has quit IRC | 22:04 | |
*** yangyapeng has joined #openstack-cinder | 22:12 | |
*** cburgess has quit IRC | 22:12 | |
*** erlon has quit IRC | 22:13 | |
*** jungleboyj has quit IRC | 22:14 | |
*** harlowja has quit IRC | 22:14 | |
*** rha has quit IRC | 22:15 | |
*** cburgess has joined #openstack-cinder | 22:16 | |
*** rushiagr has quit IRC | 22:17 | |
*** sweston has quit IRC | 22:17 | |
*** tdurakov has quit IRC | 22:17 | |
*** yangyapeng has quit IRC | 22:17 | |
*** theanalyst has quit IRC | 22:18 | |
*** rha has joined #openstack-cinder | 22:19 | |
*** rha has quit IRC | 22:19 | |
*** rha has joined #openstack-cinder | 22:19 | |
*** sweston has joined #openstack-cinder | 22:21 | |
*** theanalyst has joined #openstack-cinder | 22:25 | |
*** tdurakov has joined #openstack-cinder | 22:26 | |
*** felipemonteiro_ has quit IRC | 22:28 | |
*** rushiagr has joined #openstack-cinder | 22:32 | |
*** edmondsw has joined #openstack-cinder | 22:37 | |
*** salv-orlando has joined #openstack-cinder | 22:37 | |
*** kaisers has joined #openstack-cinder | 22:38 | |
*** edmondsw has quit IRC | 22:42 | |
*** kaisers has quit IRC | 22:42 | |
*** liverpooler has joined #openstack-cinder | 22:44 | |
*** gman-tx has quit IRC | 22:50 | |
*** diablo_rojo has joined #openstack-cinder | 23:03 | |
*** Kvisle has quit IRC | 23:03 | |
*** Kvisle has joined #openstack-cinder | 23:05 | |
*** salv-orlando has quit IRC | 23:08 | |
*** sdague has quit IRC | 23:08 | |
*** lamt has quit IRC | 23:09 | |
*** diablo_rojo has quit IRC | 23:17 | |
*** tesseract has quit IRC | 23:20 | |
*** harlowja has joined #openstack-cinder | 23:23 | |
*** mriedem has quit IRC | 23:30 | |
*** mriedem has joined #openstack-cinder | 23:30 | |
*** stakeda has joined #openstack-cinder | 23:33 | |
*** Julien-zte has quit IRC | 23:34 | |
*** yangyapeng has joined #openstack-cinder | 23:37 | |
*** Apoorva_ has quit IRC | 23:38 | |
*** Apoorva has joined #openstack-cinder | 23:39 | |
*** markvoelker has quit IRC | 23:40 | |
*** yangyapeng has quit IRC | 23:42 | |
*** dhinesh has quit IRC | 23:53 | |
*** jungleboyj has joined #openstack-cinder | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!