| *** jamielennox|away is now known as jamielennox | 00:02 | |
| *** mtanino has quit IRC | 00:03 | |
| *** sticker has joined #openstack-cinder | 00:22 | |
| *** ska has quit IRC | 00:28 | |
| *** ska has joined #openstack-cinder | 00:42 | |
| *** ska has joined #openstack-cinder | 00:42 | |
| *** hongbin has quit IRC | 00:44 | |
| *** lucasxu has joined #openstack-cinder | 00:46 | |
| *** lucasxu has quit IRC | 00:46 | |
| *** jwcroppe has joined #openstack-cinder | 00:48 | |
| *** zhurong has joined #openstack-cinder | 00:49 | |
| *** wanghao has joined #openstack-cinder | 00:57 | |
| *** zhengyin has joined #openstack-cinder | 00:58 | |
| *** jamielennox is now known as jamielennox|away | 01:00 | |
| *** wanghao has quit IRC | 01:08 | |
| *** wanghao has joined #openstack-cinder | 01:09 | |
| *** jamielennox|away is now known as jamielennox | 01:10 | |
| *** wanghao_ has joined #openstack-cinder | 01:15 | |
| *** wanghao has quit IRC | 01:18 | |
| *** pewp has quit IRC | 01:19 | |
| *** pewp has joined #openstack-cinder | 01:19 | |
| *** Apoorva_ has joined #openstack-cinder | 01:29 | |
| *** zhurong has quit IRC | 01:29 | |
| *** Apoorva_ has quit IRC | 01:29 | |
| *** Apoorva has quit IRC | 01:32 | |
| *** zhaochao has joined #openstack-cinder | 01:34 | |
| *** markvoelker has joined #openstack-cinder | 01:35 | |
| *** dave-mccowan has joined #openstack-cinder | 01:38 | |
| openstackgerrit | TommyLike proposed openstack/cinder master: Clarify some details related blockbox deployment https://review.openstack.org/472101 | 01:39 |
|---|---|---|
| *** r-daneel has quit IRC | 01:47 | |
| *** Julien-zte has joined #openstack-cinder | 01:52 | |
| *** dhinesh has quit IRC | 01:56 | |
| *** zhurong has joined #openstack-cinder | 02:03 | |
| *** Shunli has joined #openstack-cinder | 02:08 | |
| *** markvoelker has quit IRC | 02:09 | |
| *** mriedem has joined #openstack-cinder | 02:34 | |
| *** zsli_ has joined #openstack-cinder | 02:38 | |
| *** zsli__ has joined #openstack-cinder | 02:41 | |
| *** Shunli has quit IRC | 02:41 | |
| *** Shunli has joined #openstack-cinder | 02:43 | |
| *** zsli_ has quit IRC | 02:44 | |
| *** markvoelker has joined #openstack-cinder | 02:44 | |
| *** zsli__ has quit IRC | 02:45 | |
| *** KeithMnemonic1 has joined #openstack-cinder | 02:49 | |
| *** chenying_ has joined #openstack-cinder | 02:51 | |
| *** KeithMnemonic has quit IRC | 02:53 | |
| *** chenying has quit IRC | 02:54 | |
| *** markstur has quit IRC | 03:01 | |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Support metadata for backup resource-1 https://review.openstack.org/471541 | 03:09 |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Use OVO for test_backup https://review.openstack.org/472506 | 03:09 |
| *** Jack_Iv has joined #openstack-cinder | 03:18 | |
| *** salv-orlando has joined #openstack-cinder | 03:21 | |
| *** markstur has joined #openstack-cinder | 03:22 | |
| *** Jack_Iv has quit IRC | 03:23 | |
| *** salv-orlando has quit IRC | 03:26 | |
| *** markstur has quit IRC | 03:27 | |
| *** dikonoor has joined #openstack-cinder | 03:27 | |
| *** gkadam has joined #openstack-cinder | 03:38 | |
| *** Julien-zte has quit IRC | 03:44 | |
| *** dave-mccowan has quit IRC | 03:47 | |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: [WIP]Support metadata for backup resource-2 https://review.openstack.org/472030 | 03:48 |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Support metadata for backup resource-1 https://review.openstack.org/471541 | 03:48 |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Use OVO for test_backup https://review.openstack.org/472506 | 03:48 |
| *** links has joined #openstack-cinder | 04:20 | |
| *** salv-orlando has joined #openstack-cinder | 04:22 | |
| *** zhurong has quit IRC | 04:25 | |
| *** salv-orlando has quit IRC | 04:26 | |
| *** mriedem has quit IRC | 04:27 | |
| *** psachin has joined #openstack-cinder | 04:31 | |
| *** zhurong has joined #openstack-cinder | 04:34 | |
| *** zhengyin has quit IRC | 04:35 | |
| *** aselius has quit IRC | 04:36 | |
| *** adisky__ has joined #openstack-cinder | 04:38 | |
| *** zhengyin has joined #openstack-cinder | 04:40 | |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Use OVO for test_backup https://review.openstack.org/472506 | 04:42 |
| *** salv-orlando has joined #openstack-cinder | 04:44 | |
| *** dhinesh has joined #openstack-cinder | 04:53 | |
| *** Jack_Iv has joined #openstack-cinder | 04:55 | |
| openstackgerrit | Ryan Liang proposed openstack/cinder master: Unity: Use thin clone when cloning volume https://review.openstack.org/471250 | 04:56 |
| *** Guest72612 has quit IRC | 05:06 | |
| *** mfisch` has quit IRC | 05:06 | |
| *** med_ has joined #openstack-cinder | 05:06 | |
| *** mfisch has joined #openstack-cinder | 05:06 | |
| *** mfisch has quit IRC | 05:06 | |
| *** mfisch has joined #openstack-cinder | 05:06 | |
| *** med_ is now known as Guest6511 | 05:06 | |
| *** kwathore has quit IRC | 05:09 | |
| *** links has quit IRC | 05:10 | |
| *** markstur has joined #openstack-cinder | 05:12 | |
| *** aselius_ has joined #openstack-cinder | 05:12 | |
| *** markstur has quit IRC | 05:17 | |
| *** links has joined #openstack-cinder | 05:26 | |
| openstackgerrit | qtlu proposed openstack/cinder master: Api-ref: Update doc for show backups https://review.openstack.org/472526 | 05:30 |
| *** Jack_Iv has quit IRC | 05:31 | |
| *** Jack_Iv has joined #openstack-cinder | 05:32 | |
| openstackgerrit | qtlu proposed openstack/cinder master: Api-ref: Update doc for show backups https://review.openstack.org/472526 | 05:32 |
| *** Jack_Iv has quit IRC | 05:36 | |
| *** kwathore has joined #openstack-cinder | 05:38 | |
| *** pgadiya has joined #openstack-cinder | 05:41 | |
| *** pgadiya has quit IRC | 05:44 | |
| *** dhinesh has quit IRC | 05:46 | |
| *** zhaochao has quit IRC | 05:51 | |
| *** Julien-zte has joined #openstack-cinder | 05:56 | |
| *** nicolasbock has joined #openstack-cinder | 05:57 | |
| *** zhaochao has joined #openstack-cinder | 05:58 | |
| *** nicolasbock has quit IRC | 06:02 | |
| *** ChubYann has quit IRC | 06:05 | |
| *** pgadiya has joined #openstack-cinder | 06:07 | |
| *** zhengyin has quit IRC | 06:08 | |
| *** zhengyin has joined #openstack-cinder | 06:09 | |
| *** zhengyin has quit IRC | 06:27 | |
| *** wanghao_ has quit IRC | 06:27 | |
| *** wanghao has joined #openstack-cinder | 06:27 | |
| *** zhengyin has joined #openstack-cinder | 06:28 | |
| *** wanghao has quit IRC | 06:29 | |
| *** wanghao has joined #openstack-cinder | 06:29 | |
| *** zhengyin has quit IRC | 06:32 | |
| *** sticker has quit IRC | 06:33 | |
| *** zhengyin has joined #openstack-cinder | 06:34 | |
| *** Jack_Iv has joined #openstack-cinder | 06:37 | |
| *** wanghao_ has joined #openstack-cinder | 06:39 | |
| *** zhengyin has quit IRC | 06:40 | |
| *** zhengyin has joined #openstack-cinder | 06:40 | |
| *** wanghao has quit IRC | 06:42 | |
| *** edmondsw has joined #openstack-cinder | 06:43 | |
| *** zhengyin has quit IRC | 06:47 | |
| *** zhengyin has joined #openstack-cinder | 06:47 | |
| *** edmondsw has quit IRC | 06:47 | |
| *** zhengyin has quit IRC | 06:52 | |
| *** salv-orlando has quit IRC | 06:52 | |
| *** zhengyin has joined #openstack-cinder | 06:52 | |
| *** salv-orlando has joined #openstack-cinder | 06:52 | |
| *** tesseract has joined #openstack-cinder | 06:53 | |
| *** zhurong has quit IRC | 06:55 | |
| *** zhurong has joined #openstack-cinder | 06:55 | |
| *** zhurong has quit IRC | 06:57 | |
| *** pgadiya has quit IRC | 07:02 | |
| *** pcaruana has joined #openstack-cinder | 07:05 | |
| *** markstur has joined #openstack-cinder | 07:06 | |
| *** dobson` has quit IRC | 07:07 | |
| *** markvoelker has quit IRC | 07:08 | |
| *** links has quit IRC | 07:09 | |
| *** rcernin has joined #openstack-cinder | 07:09 | |
| *** markstur has quit IRC | 07:11 | |
| *** dobson has joined #openstack-cinder | 07:13 | |
| openstackgerrit | qtlu proposed openstack/cinder master: Show user_id when cinder snapshot-show https://review.openstack.org/472545 | 07:13 |
| *** pgadiya has joined #openstack-cinder | 07:19 | |
| *** aselius_ has quit IRC | 07:21 | |
| *** links has joined #openstack-cinder | 07:25 | |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Support metadata for backup resource-1 https://review.openstack.org/471541 | 07:34 |
| *** wanghao_ has quit IRC | 07:39 | |
| *** wanghao has joined #openstack-cinder | 07:39 | |
| *** mnestratov|2 has joined #openstack-cinder | 07:41 | |
| *** wanghao_ has joined #openstack-cinder | 07:43 | |
| *** wanghao has quit IRC | 07:47 | |
| *** Jack_Iv has quit IRC | 07:57 | |
| *** lhx__ has joined #openstack-cinder | 07:59 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-cinder | 08:00 | |
| *** pgadiya has quit IRC | 08:26 | |
| *** Julien-zte has quit IRC | 08:32 | |
| *** Poornima_K has joined #openstack-cinder | 08:56 | |
| *** markstur has joined #openstack-cinder | 08:56 | |
| *** Poornima_K has quit IRC | 08:56 | |
| *** dalvarezs is now known as dalvarez | 09:00 | |
| *** e0ne has joined #openstack-cinder | 09:05 | |
| *** markvoelker has joined #openstack-cinder | 09:13 | |
| openstackgerrit | Kushal Wathore proposed openstack/cinder master: HPE 3PAR: ISCSI/FC drivers – code refactoring https://review.openstack.org/446475 | 09:30 |
| *** dalgaaf has quit IRC | 09:31 | |
| *** Shunli has quit IRC | 09:31 | |
| *** dalgaaf has joined #openstack-cinder | 09:33 | |
| *** Julien-zte has joined #openstack-cinder | 09:38 | |
| *** markvoelker has quit IRC | 09:42 | |
| *** wanghao_ has quit IRC | 09:45 | |
| *** Julien-zte has quit IRC | 09:48 | |
| *** Julien-zte has joined #openstack-cinder | 09:49 | |
| *** links has quit IRC | 09:51 | |
| *** zhurong has joined #openstack-cinder | 09:55 | |
| *** Julien-zte has quit IRC | 09:59 | |
| *** links has joined #openstack-cinder | 10:03 | |
| *** zhurong has quit IRC | 10:06 | |
| *** bjornar has joined #openstack-cinder | 10:11 | |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Support metadata for backup resource-1 https://review.openstack.org/471541 | 10:17 |
| *** Julien-zte has joined #openstack-cinder | 10:18 | |
| *** edmondsw has joined #openstack-cinder | 10:19 | |
| *** sdague has joined #openstack-cinder | 10:20 | |
| *** kwathore has quit IRC | 10:22 | |
| *** edmondsw has quit IRC | 10:24 | |
| e0ne | smcginnis: hi. please, ping me when you'll be available. I've got a question acording to https://review.openstack.org/#/c/441266/8/lib/cinder | 10:30 |
| *** yongwc has joined #openstack-cinder | 10:36 | |
| *** markvoelker has joined #openstack-cinder | 10:39 | |
| *** salv-orlando has quit IRC | 10:42 | |
| *** salv-orlando has joined #openstack-cinder | 10:43 | |
| *** pgadiya has joined #openstack-cinder | 10:43 | |
| *** nicolasbock has joined #openstack-cinder | 10:45 | |
| *** lpetrut has joined #openstack-cinder | 10:45 | |
| *** salv-orlando has quit IRC | 10:47 | |
| *** psachin has quit IRC | 11:13 | |
| *** markvoelker has quit IRC | 11:13 | |
| *** markstur has quit IRC | 11:18 | |
| openstackgerrit | Gorka Eguileor proposed openstack/python-cinderclient master: Add service cleanup command https://review.openstack.org/363007 | 11:32 |
| *** zhengyin has quit IRC | 11:33 | |
| *** pgadiya has quit IRC | 11:38 | |
| *** Julien-zte has quit IRC | 11:39 | |
| *** edmondsw has joined #openstack-cinder | 11:42 | |
| *** abishop has joined #openstack-cinder | 11:43 | |
| *** gcb has quit IRC | 11:57 | |
| *** liverpooler has joined #openstack-cinder | 12:03 | |
| *** lpetrut has quit IRC | 12:06 | |
| mdovgal | hi, folks. Could somebody take a look at this patch https://review.openstack.org/#/c/446518/ ? It's in progress, but still.... | 12:09 |
| *** markvoelker has joined #openstack-cinder | 12:10 | |
| *** lpetrut has joined #openstack-cinder | 12:16 | |
| openstackgerrit | Gorka Eguileor proposed openstack/os-brick master: Fix slow test_connect_volume_device_not_valid test https://review.openstack.org/472657 | 12:20 |
| *** markvoelker has quit IRC | 12:36 | |
| *** markvoelker has joined #openstack-cinder | 12:36 | |
| *** adisky__ has quit IRC | 12:38 | |
| openstackgerrit | wang yong proposed openstack/cinder master: Inspur Cinder FC/iSCSI driver https://review.openstack.org/439488 | 12:38 |
| *** rushiagr has quit IRC | 12:40 | |
| *** catintheroof has joined #openstack-cinder | 12:40 | |
| *** theanalyst has quit IRC | 12:41 | |
| *** Julien-zte has joined #openstack-cinder | 12:42 | |
| *** bjornar has quit IRC | 12:42 | |
| *** dave-mccowan has joined #openstack-cinder | 12:43 | |
| *** catintheroof has quit IRC | 12:45 | |
| *** catintheroof has joined #openstack-cinder | 12:46 | |
| *** dustins has joined #openstack-cinder | 12:48 | |
| *** links has quit IRC | 12:48 | |
| *** bjornar has joined #openstack-cinder | 12:56 | |
| *** theanalyst has joined #openstack-cinder | 12:59 | |
| *** yongwc has quit IRC | 13:00 | |
| *** jwcroppe has quit IRC | 13:01 | |
| *** lucasxu has joined #openstack-cinder | 13:03 | |
| *** lpetrut_ has joined #openstack-cinder | 13:08 | |
| *** rushiagr has joined #openstack-cinder | 13:13 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - bootable volume errors https://review.openstack.org/472674 | 13:14 |
| *** lucasxu has quit IRC | 13:16 | |
| *** dustins_ has joined #openstack-cinder | 13:18 | |
| *** dustins has quit IRC | 13:19 | |
| *** dustins_ is now known as dustins | 13:20 | |
| *** bjornar has quit IRC | 13:20 | |
| *** lhx__ has quit IRC | 13:21 | |
| *** abhishek_k has joined #openstack-cinder | 13:23 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - Replication, replacing SMI-S with REST https://review.openstack.org/466027 | 13:25 |
| *** abhishekk has quit IRC | 13:25 | |
| *** xyang1 has joined #openstack-cinder | 13:29 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - Live Migration, replacing SMI-S with REST https://review.openstack.org/472279 | 13:32 |
| *** cknight has joined #openstack-cinder | 13:34 | |
| smcginnis | e0ne: Getting ready for a presentation, then travelling the rest of the day. | 13:36 |
| smcginnis | e0ne: I'm online for a little bit, but will need to drop off soon. | 13:37 |
| *** dansmith is now known as superdan | 13:37 | |
| *** mriedem has joined #openstack-cinder | 13:40 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - bootable volume errors https://review.openstack.org/472674 | 13:43 |
| *** ericyoung has joined #openstack-cinder | 13:45 | |
| *** chenying_ has quit IRC | 13:46 | |
| *** chenying_ has joined #openstack-cinder | 13:46 | |
| e0ne | smcginnis: ok, I'll ping you on Monday | 13:47 |
| e0ne | smcginnis: btw, could you please take a look on a simple docs patch https://review.openstack.org/#/c/472676/1? | 13:47 |
| *** chlong has joined #openstack-cinder | 13:51 | |
| *** yongwc has joined #openstack-cinder | 13:53 | |
| *** yongwc has quit IRC | 13:58 | |
| *** mtanino has joined #openstack-cinder | 14:01 | |
| *** nicolasbock has quit IRC | 14:03 | |
| *** lucasxu has joined #openstack-cinder | 14:09 | |
| *** felipemonteiro has joined #openstack-cinder | 14:12 | |
| *** felipemonteiro__ has joined #openstack-cinder | 14:13 | |
| *** lucasxu has quit IRC | 14:14 | |
| *** lucasxu has joined #openstack-cinder | 14:14 | |
| *** mriedem has quit IRC | 14:15 | |
| *** lucasxu has quit IRC | 14:16 | |
| *** tesseract has quit IRC | 14:16 | |
| *** felipemonteiro has quit IRC | 14:17 | |
| *** aselius_ has joined #openstack-cinder | 14:19 | |
| *** lucasxu has joined #openstack-cinder | 14:20 | |
| *** xyang1 has quit IRC | 14:20 | |
| *** tesseract has joined #openstack-cinder | 14:23 | |
| *** lucasxu has quit IRC | 14:23 | |
| *** xyang1 has joined #openstack-cinder | 14:24 | |
| *** jwcroppe has joined #openstack-cinder | 14:25 | |
| *** gkadam_ has joined #openstack-cinder | 14:26 | |
| *** diablo_rojo has joined #openstack-cinder | 14:26 | |
| *** gkadam has quit IRC | 14:26 | |
| *** dikonoor has quit IRC | 14:28 | |
| *** lucasxu has joined #openstack-cinder | 14:29 | |
| *** lucasxu has quit IRC | 14:29 | |
| *** dikonoor has joined #openstack-cinder | 14:30 | |
| *** gkadam_ has quit IRC | 14:31 | |
| *** crushil has joined #openstack-cinder | 14:31 | |
| *** lucasxu has joined #openstack-cinder | 14:33 | |
| *** e0ne has quit IRC | 14:35 | |
| *** salv-orlando has joined #openstack-cinder | 14:42 | |
| *** salv-orl_ has joined #openstack-cinder | 14:44 | |
| *** yongwc has joined #openstack-cinder | 14:44 | |
| *** Dinesh_Bhor has quit IRC | 14:44 | |
| *** lucasxu has quit IRC | 14:47 | |
| *** lucasxu has joined #openstack-cinder | 14:47 | |
| *** salv-orlando has quit IRC | 14:48 | |
| *** yongwc has quit IRC | 14:48 | |
| *** lucasxu has quit IRC | 14:51 | |
| *** lucasxu has joined #openstack-cinder | 14:53 | |
| stvnoyes | jgriffith: I made a couple of changes to cinder and was able to get live migrate working with the new v3 cinder api. this is what I changed - http://paste.openstack.org/show/612141/ | 14:55 |
| jgriffith | stvnoyes Awesome! | 14:55 |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted now to clear an issue arising from an unanticipated SSH API connection flood | 14:56 | |
| jgriffith | stvnoyes now.. all the drivers that have ignored this code for the last 6 months are going to be surprised when it actually does something :) | 14:57 |
| stvnoyes | as long as they return nothing or false they should be OK. have you ever to checked to see if any ever return true? | 14:58 |
| jgriffith | stvnoyes they don't yet, but I know a couple that will need to | 14:58 |
| jgriffith | I'm looking at patrickeast and whoever maintains 3par now | 14:59 |
| jgriffith | Oh, patrickeast has it | 14:59 |
| jgriffith | Nice! | 14:59 |
| jgriffith | err.. maybe | 15:00 |
| jgriffith | anyway... | 15:00 |
| jgriffith | you want to push a patch for the cinder side? | 15:00 |
| jgriffith | :qa | 15:00 |
| stvnoyes | I wasn't sure if that was the best way to see if there were multiple connections. Are you OK with how I did this? | 15:01 |
| jgriffith | stvnoyes first glance, yes for sure! | 15:01 |
| stvnoyes | ok, do you need a bug on this? | 15:02 |
| jgriffith | stvnoyes so that's what this is exactly what that check was added for | 15:02 |
| jgriffith | stvnoyes I don't :) | 15:02 |
| stvnoyes | (do I need a bug to submit a change?) | 15:02 |
| jgriffith | but others are much more regimented than me :) | 15:02 |
| jgriffith | probably good to open one up for tracking | 15:02 |
| stvnoyes | ok, I'll file a bug, just to be copacetic | 15:02 |
| jgriffith | stvnoyes one of us should be :) | 15:03 |
| stvnoyes | :-) my turn today | 15:03 |
| *** markstur has joined #openstack-cinder | 15:03 | |
| jgriffith | deal! | 15:03 |
| *** pewp has quit IRC | 15:06 | |
| *** pewp has joined #openstack-cinder | 15:07 | |
| *** rcernin has quit IRC | 15:08 | |
| *** hongbin has joined #openstack-cinder | 15:11 | |
| *** lucasxu has quit IRC | 15:16 | |
| *** salv-orl_ has quit IRC | 15:16 | |
| *** yongwc has joined #openstack-cinder | 15:16 | |
| *** salv-orlando has joined #openstack-cinder | 15:17 | |
| pewp | hemna (ه’́⌣’̀ه )／ | 15:17 |
| *** yongwc has quit IRC | 15:19 | |
| hemna | stvnoyes, jgriffith so looking at that patch (pastebin url), that code says if there are 1 or more attachments, it's a shared connection ?! | 15:19 |
| *** salv-orlando has quit IRC | 15:20 | |
| hemna | also, fwiw, the lefthand driver uses a shared connection for multi-attach of a volume on the same host. the 3PAR uses a new connection on every attachment of a volume. | 15:21 |
| *** aselius_ has quit IRC | 15:26 | |
| *** aselius has joined #openstack-cinder | 15:26 | |
| *** mtanino__ has joined #openstack-cinder | 15:27 | |
| *** mtanino has quit IRC | 15:28 | |
| *** itlinux has joined #openstack-cinder | 15:40 | |
| ildikov | hemna: it's shared with lvm, I tested it a while back with multi-attach | 15:43 |
| hemna | ildikov, well, that's kinda my point though, is that it's different for every driver. | 15:43 |
| ildikov | hemna: yep :( | 15:44 |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - bootable volume errors https://review.openstack.org/472674 | 15:46 |
| *** lucasxu has joined #openstack-cinder | 15:49 | |
| *** Apoorva has joined #openstack-cinder | 15:52 | |
| *** salv-orlando has joined #openstack-cinder | 15:55 | |
| *** felipemonteiro__ has quit IRC | 15:56 | |
| *** dikonoor has quit IRC | 15:57 | |
| *** r-daneel has joined #openstack-cinder | 16:01 | |
| jgriffith | hemna that came up during the review as the best way to handle multi-attach, if you have a better solution (without a bunch of if/else checks) we can certainly look at changing it | 16:03 |
| hemna | I'm not arguing against the shared connection flag/result/boolean | 16:04 |
| jgriffith | The problem is there's no way to know if a backens shares connections or not without asking them that I'm aware of? | 16:04 |
| jgriffith | Unless you did something like reported in in the capabilites so we'd just "know" what to do and work it that way. But that had a problem IIRC | 16:04 |
| hemna | I'm just saying that particular patch makes an assumption about the backend, which in some driver's cases is not true. | 16:04 |
| jgriffith | hemna oh | 16:04 |
| jgriffith | hemna hmm... which assumption? | 16:05 |
| hemna | I think every driver is going to have to take a look at the shared flag, and make sure they do their own internal tests to return the correct value. | 16:05 |
| jgriffith | hemna yes, we've known that from the start though | 16:05 |
| hemna | the assumption in that code, from what I can tell, is that if there is more than one attachment, that it's shared. | 16:05 |
| jgriffith | I'll have to look at what he has again, perhaps I missed that detail | 16:06 |
| jgriffith | I was referring to the driver response on terminate | 16:06 |
| hemna | has_shared_connection = len(volume.volume_attachment.objects) > 1 | 16:06 |
| hemna | that | 16:06 |
| hemna | :) | 16:06 |
| hemna | that's in the iscsi targets class's terminate_connection | 16:06 |
| *** zhaochao has quit IRC | 16:07 | |
| hemna | which I presume works for lvm | 16:07 |
| jgriffith | hemna right, so drivers need to override that no? | 16:07 |
| hemna | yah | 16:07 |
| jgriffith | hemna it works for anybody that doesn't share targets I believe | 16:07 |
| jgriffith | maybe there's a better way, but I don't know of one other than relying on the driver at terminate_connection | 16:08 |
| *** itlinux has quit IRC | 16:09 | |
| hemna | yah that's fine really | 16:09 |
| hemna | I wasn't arguing against that | 16:09 |
| *** cknight has quit IRC | 16:10 | |
| hemna | I know in the 3PAR and lefthand drivers, I could return that flag as part of initialize_connection too | 16:10 |
| *** lpetrut has quit IRC | 16:10 | |
| hemna | but terminate works just fine | 16:10 |
| *** lpetrut_ has quit IRC | 16:10 | |
| hemna | maybe I'll have access to an array again soon..... | 16:10 |
| jgriffith | initialize is cool, but the problem is you don't know the current state | 16:10 |
| jgriffith | haha! | 16:10 |
| hemna | I was just looking at the 3PAR FC driver | 16:12 |
| hemna | I don't think it'd be terrible to write an 3PAR FC target object | 16:12 |
| jgriffith | hemna well, I gave up on my email on the ML but it would be super easy to just have a target object and override that one thing to return what you want | 16:14 |
| *** diablo_rojo has quit IRC | 16:14 | |
| jgriffith | but it seemed like that was the "wrong" thing to do in some opinions | 16:14 |
| jgriffith | all I know is it works for me :) | 16:14 |
| *** lpetrut_ has joined #openstack-cinder | 16:14 | |
| ildikov | jgriffith: hemna: are you returning true in case the back end shares connections and it has more than one when terminate is called? | 16:15 |
| jgriffith | ildikov well it's completely up to the driver to *know* what it should/shouldn't do in that case IMO | 16:16 |
| jgriffith | ildikov the general case "yes" return True if it knows it's sharing that particular connection | 16:16 |
| jgriffith | but it's also connection specific.... may not be sharing that particular one | 16:17 |
| jgriffith | but sharing another | 16:17 |
| jgriffith | that's why I thought it should be the drivers problem to figure out, it's the only one that really knows I think | 16:17 |
| ildikov | jgriffith: so you say that one particular driver can behave differently on a per connection basis? | 16:18 |
| openstackgerrit | Lucian Petrut proposed openstack/cinder master: SMBFS: enhance volume cloning https://review.openstack.org/472747 | 16:18 |
| jgriffith | ildikov maybe | 16:19 |
| jgriffith | ildikov so like maybe they do shared connection by host | 16:19 |
| *** lpetrut has joined #openstack-cinder | 16:19 | |
| jgriffith | so in that case it only matters based on the number of volumes (>1) attached to that specific host | 16:19 |
| jgriffith | or... maybe it has a relationship with their raid controller | 16:20 |
| jgriffith | and they have more than one | 16:20 |
| jgriffith | maybe they're not actually sharing any connections to the same host in that case because they're using different controllers, but other times they're sharing one? | 16:20 |
| *** ChubYann has joined #openstack-cinder | 16:20 | |
| ildikov | jgriffith: ok, got it | 16:20 |
| jgriffith | the problem is I don't know the intimate details of all 70+ backends in Cinder and how they do connections | 16:20 |
| ildikov | jgriffith: not happy about it, but got the idea :) | 16:21 |
| jgriffith | and most of them do things slightly different here and there | 16:21 |
| jgriffith | sorry :( | 16:21 |
| *** dikonoor has joined #openstack-cinder | 16:21 | |
| ildikov | jgriffith: you shouldn't, drivers should do this "favor" for us to tell what the heck they are doing | 16:21 |
| ildikov | jgriffith: so what I wanted to clarify is that the boolean we would like to get back belongs to the particular connection and it's not a base capability that we mentioned earlier at some point | 16:22 |
| jgriffith | ildikov oh! | 16:23 |
| ildikov | jgriffith: also in case of a per connection basis when multi-attach comes in that can be racy if we don't think detach through | 16:23 |
| jgriffith | Yeah, so that's why the capability thing didn't work when I looked at it | 16:23 |
| ildikov | jgriffith: fair enough, I was just missing the context that it can vary even in case of one particular driver how it handles the different cases | 16:23 |
| *** tesseract has quit IRC | 16:32 | |
| *** pcaruana has quit IRC | 16:34 | |
| *** rcernin has joined #openstack-cinder | 16:45 | |
| *** ericyoung has quit IRC | 16:46 | |
| *** diablo_rojo has joined #openstack-cinder | 16:52 | |
| stvnoyes | jgriffith, hemna, ildikov, just catching up on all this. in the case of migrate, which is a special case, it seems independent of what the driver supports? I don't think capabilities enter into it, at least for this case. | 17:04 |
| stvnoyes | it did seem odd to go deep down into the iscsi driver to return information that exists in the volume object | 17:05 |
| ildikov | stvnoyes: as for detach it's still dependent on the driver | 17:06 |
| ildikov | stvnoyes: when you remove the attachment from the source | 17:07 |
| stvnoyes | it sounds like I should hold off on moving forward with that change? | 17:09 |
| *** gully-foyle has joined #openstack-cinder | 17:13 | |
| *** Apoorva_ has joined #openstack-cinder | 17:14 | |
| *** cknight has joined #openstack-cinder | 17:14 | |
| *** x00350071_ has joined #openstack-cinder | 17:15 | |
| *** mtanino_ has joined #openstack-cinder | 17:15 | |
| ildikov | stvnoyes: hmm, maybe I'm missing smth, so I don't want to make you hold on anything you agreed with the guys here earlier | 17:15 |
| *** zhonghua has joined #openstack-cinder | 17:16 | |
| *** mtanino__ has quit IRC | 17:17 | |
| *** Apoorva has quit IRC | 17:18 | |
| *** zhonghua2 has quit IRC | 17:18 | |
| *** edisonxiang has quit IRC | 17:19 | |
| *** gully-foyle has left #openstack-cinder | 17:19 | |
| stvnoyes | ildikov: ok, I think I understand. Once I finish writing some utests for it, I'll post it and see what folks have to say. | 17:19 |
| *** felipemonteiro has joined #openstack-cinder | 17:20 | |
| ildikov | stvnoyes: sounds good | 17:23 |
| ildikov | stvnoyes: thank you! | 17:23 |
| stvnoyes | jgriffith: ildikov: what is the meaning of has_shared_connection? True if it is currently shared? and if I have 2 attachments to a volume, and attachment_delete deletes one of them, should that attachment_delete return True or False? | 17:25 |
| ildikov | stvnoyes: in my understanding it's true if it's currently shared | 17:25 |
| ildikov | stvnoyes: and after the first delete it should be false | 17:25 |
| stvnoyes | hmmm, as it is currently, attachment_delete will return True in that case. I will look at how to change that. | 17:28 |
| ildikov | I need jgriffith to fully confirm my understanding is correct, I believe it is though :) | 17:29 |
| *** dhinesh has joined #openstack-cinder | 17:30 | |
| stvnoyes | jgriffith: ildikov: the problem is we get a boolean back from terminate_connection, that attachment_delete just returns. But it's the state of the connections prior to the delete. so attach_delete could return the wrong value I suppose. Would seem to be better for terminate connection to return a count? | 17:32 |
| *** ericyoung has joined #openstack-cinder | 17:41 | |
| *** lpetrut has quit IRC | 17:44 | |
| *** lpetrut has joined #openstack-cinder | 17:46 | |
| ildikov | stvnoyes: without the knowledge whether the particular driver shares the particular connection a count is basically useless :( | 17:46 |
| ildikov | stvnoyes: at least my understanding from the above the it can vary on per connection basis even for one driver | 17:47 |
| ildikov | *that it can ... | 17:47 |
| *** mnestratov|2 has quit IRC | 17:48 | |
| *** salv-orlando has quit IRC | 17:50 | |
| *** salv-orlando has joined #openstack-cinder | 17:51 | |
| *** salv-orlando has quit IRC | 17:55 | |
| *** e0ne has joined #openstack-cinder | 18:04 | |
| *** diablo_rojo has quit IRC | 18:10 | |
| *** diablo_rojo has joined #openstack-cinder | 18:24 | |
| *** felipemonteiro has quit IRC | 18:27 | |
| *** spiette has joined #openstack-cinder | 18:29 | |
| *** ericyoung has quit IRC | 18:29 | |
| *** DockerNoodle has joined #openstack-cinder | 18:29 | |
| *** e0ne has quit IRC | 18:30 | |
| *** felipemonteiro has joined #openstack-cinder | 18:32 | |
| *** felipemonteiro__ has joined #openstack-cinder | 18:35 | |
| *** felipemonteiro has quit IRC | 18:38 | |
| *** sdague has quit IRC | 18:51 | |
| *** sdague has joined #openstack-cinder | 19:09 | |
| *** dikonoor has quit IRC | 19:13 | |
| *** itlinux_ has joined #openstack-cinder | 19:27 | |
| openstackgerrit | xing-yang proposed openstack/cinder master: Tests for group replication https://review.openstack.org/472784 | 19:29 |
| openstackgerrit | John Griffith proposed openstack/cinder master: Make migration completion work with Attach-V2 https://review.openstack.org/472786 | 19:36 |
| jgriffith | ildikov still here? | 19:40 |
| ildikov | jgriffith: yes | 19:40 |
| ildikov | jgriffith: reading the commit message of your patch ^ :) | 19:40 |
| jgriffith | hey... ok, so the separate patch for swap.... | 19:41 |
| jgriffith | that's probably good... I'm just looking at what you had though and I'm trying to figure out do we need that? | 19:41 |
| ildikov | jgriffith: I just split it out from the main attach PoC and got some old stuff in it as we changed many things since then | 19:42 |
| jgriffith | what I mean is where do those rpc version changes etc come in from? | 19:42 |
| jgriffith | Ah! Ok, that's what I was wondering | 19:42 |
| ildikov | oh I don't think we need those | 19:42 |
| jgriffith | :) | 19:42 |
| jgriffith | There's a few things in there I couldn't map to swap | 19:42 |
| ildikov | I think when I did that we didn't have the attachment_id in the BDM and then I didn't update the whole thing just snippets, but lemme double check :) | 19:43 |
| jgriffith | yeah, things have changed a lot :) | 19:43 |
| ildikov | jgriffith: hmm, there's one thing though | 19:45 |
| ildikov | I need check how live_migrate handles that | 19:45 |
| ildikov | oh wait, we have two separate volumes here one attachment each, right? | 19:45 |
| jgriffith | yup | 19:46 |
| jgriffith | live-migrate of instances is slightly different, because it's attaching a single volume in two places | 19:47 |
| ildikov | ok, so I guess we have a new BDM for the new volume as well at a certain point | 19:47 |
| jgriffith | this is attaching a volume by trying to not tell cinder it's doing so | 19:47 |
| jgriffith | ildikov right, the nova side of that works (I was amazed) | 19:48 |
| ildikov | I'm looking into the old swap patch and I found a new_attachment_id part, but that should go into the new BDM, which I don't know when and where gets created at this point :) | 19:48 |
| ildikov | and is everything set up for the new volume? | 19:48 |
| jgriffith | well, that's the thing that sucks, is the whole magic swapping of ID's | 19:49 |
| jgriffith | but yeah, the new volume is now an official attach with it's own attachment object etc | 19:49 |
| ildikov | oh my, yeah so we don't have a new BDM, right? | 19:49 |
| jgriffith | the bdm has the update as well | 19:49 |
| jgriffith | right, it's an magic trick where we update the bdm | 19:49 |
| jgriffith | I can go back and verify that | 19:50 |
| jgriffith | but it's the very specific case of cinder-retype --migration-policy on-demand | 19:50 |
| jgriffith | the other volume_update calls don't need any of the special handling | 19:50 |
| jgriffith | They're just attach a second volume, copy src-->destination, detach the original... done | 19:51 |
| ildikov | where do you update the BMD with the new attachment_id? | 19:52 |
| *** salv-orlando has joined #openstack-cinder | 19:57 | |
| ildikov | jgriffith: ok, so I put together one part of the picture | 19:58 |
| jgriffith | sorry... just noticed something else wrong on the cinder side | 19:58 |
| ildikov | jgriffith: in the compute/api.py there's a reserve_volume call: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3887 | 19:58 |
| jgriffith | god this is the worst! | 19:58 |
| ildikov | jgriffith: on the Cinder side you mean? :) | 19:58 |
| jgriffith | yes | 19:59 |
| ildikov | jgriffith: :/ | 19:59 |
| ildikov | jgriffith: what's the issue? | 19:59 |
| *** ska has left #openstack-cinder | 19:59 | |
| jgriffith | so you shouldn't go in and manipulate the ID's of things in the database, because it's a stupid thing to do :) | 20:00 |
| ildikov | jgriffith: I realized why the rpc call modification is in that swap patch | 20:00 |
| jgriffith | The issue is there's a problem with attachments, there's one left over from the original | 20:00 |
| ildikov | jgriffith: well, I have that philosophy in general... :) | 20:01 |
| jgriffith | stupid | 20:01 |
| *** e0ne has joined #openstack-cinder | 20:01 | |
| jgriffith | the code | 20:01 |
| ildikov | jgriffith: hmm, is that the retype case? | 20:01 |
| ildikov | jgriffith: I know what you meant :) | 20:02 |
| jgriffith | yeah... | 20:05 |
| jgriffith | so there are two problems | 20:05 |
| jgriffith | 1. Yes, we're missing an attachment_id update in Nova for the BDM | 20:05 |
| jgriffith | 2. Cinder doesn't know how to delete the frankenstein attachment hack that was done | 20:06 |
| ildikov | lol | 20:06 |
| ildikov | so I have comments on 1. | 20:07 |
| ildikov | I rather not comment on 2. ... | 20:07 |
| *** Apoorva_ has quit IRC | 20:12 | |
| *** Apoorva has joined #openstack-cinder | 20:13 | |
| *** crushil has quit IRC | 20:14 | |
| jgriffith | so the bdm update on nova is easy to fix.... I think | 20:16 |
| jgriffith | I just added a bdm update in the special retype case | 20:16 |
| jgriffith | that should solve that, I'll get it tested. | 20:16 |
| ildikov | jgriffith: we need to reserve the new volume in the API I think | 20:17 |
| ildikov | jgriffith: and that's why I had the modification in the rpc call | 20:17 |
| ildikov | as we need the old attachment_id in the bdm, so we cannot update that in the API | 20:17 |
| jgriffith | but all the swap code is in the manager? | 20:19 |
| jgriffith | ie on the other side of the rpc call | 20:19 |
| ildikov | jgriffith: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3887 | 20:19 |
| ildikov | nothing is just in the manager in Nova :) | 20:20 |
| jgriffith | yeah,but reserve does nothing | 20:22 |
| openstackgerrit | Steve Noyes proposed openstack/cinder master: Update attachment_delete to handle multiple attachments https://review.openstack.org/472796 | 20:22 |
| jgriffith | all it does is sets the volume status to act as a lock | 20:22 |
| jgriffith | it doesn't create an attachment | 20:22 |
| ildikov | jgriffith: but in the new flow we do create the attachment to reserve the volume | 20:23 |
| jgriffith | I don't :) | 20:23 |
| ildikov | I did: https://review.openstack.org/#/c/456971/6/nova/compute/api.py :) | 20:23 |
| jgriffith | It was suggest/requested that we keep reserve as a simple lock so I did | 20:23 |
| jgriffith | Oh, in that case now it's your problem then :) | 20:23 |
| jgriffith | just kidding | 20:23 |
| ildikov | when your version gets reviewed it'll be our problem :) | 20:24 |
| jgriffith | alright... I'll look at this again. I have to go now but I'll hopefully get back this afternoon :( | 20:25 |
| ildikov | ok, you can ping me later, I might still be around | 20:25 |
| *** edmondsw has quit IRC | 20:28 | |
| *** itlinux_ has quit IRC | 20:29 | |
| *** e0ne has quit IRC | 20:33 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Updated from global requirements https://review.openstack.org/472311 | 20:36 |
| *** crushil has joined #openstack-cinder | 20:39 | |
| *** itlinux_ has joined #openstack-cinder | 20:40 | |
| *** sdague has quit IRC | 20:43 | |
| *** salv-orl_ has joined #openstack-cinder | 20:44 | |
| *** lpetrut_ has quit IRC | 20:45 | |
| *** lpetrut has quit IRC | 20:45 | |
| *** salv-orlando has quit IRC | 20:46 | |
| *** mnestratov|2 has joined #openstack-cinder | 20:52 | |
| *** crushil has quit IRC | 20:54 | |
| *** Apoorva_ has joined #openstack-cinder | 20:59 | |
| *** Apoorva has quit IRC | 21:03 | |
| *** KeithMnemonic1 has quit IRC | 21:06 | |
| openstackgerrit | xing-yang proposed openstack/cinder master: Tiramisu: replication group support https://review.openstack.org/352228 | 21:07 |
| *** lucasxu has quit IRC | 21:08 | |
| *** dustins has quit IRC | 21:08 | |
| *** pewp has quit IRC | 21:09 | |
| openstackgerrit | xing-yang proposed openstack/cinder master: Tiramisu: replication group support https://review.openstack.org/352228 | 21:12 |
| *** pewp has joined #openstack-cinder | 21:13 | |
| *** edmondsw has joined #openstack-cinder | 21:35 | |
| *** mnestratov|2 has quit IRC | 21:37 | |
| *** edmondsw has quit IRC | 21:40 | |
| *** felipemonteiro__ has quit IRC | 21:40 | |
| *** abishop has quit IRC | 21:41 | |
| *** DockerNoodle has quit IRC | 21:52 | |
| *** chlong has quit IRC | 21:58 | |
| *** itlinux_ has quit IRC | 22:06 | |
| *** dave-mccowan has quit IRC | 22:06 | |
| *** dave-mccowan has joined #openstack-cinder | 22:07 | |
| openstackgerrit | xing-yang proposed openstack/cinder master: Tests for group replication https://review.openstack.org/472784 | 22:15 |
| *** crushil has joined #openstack-cinder | 22:17 | |
| *** rcernin has quit IRC | 22:19 | |
| *** xyang1 has quit IRC | 22:21 | |
| *** crushil has quit IRC | 22:22 | |
| *** cknight has quit IRC | 22:31 | |
| *** r-daneel has quit IRC | 22:34 | |
| *** catintheroof has quit IRC | 22:42 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: FC: refactor fczm utils decorators to functions https://review.openstack.org/472855 | 22:43 |
| *** salv-orl_ has quit IRC | 22:56 | |
| *** salv-orlando has joined #openstack-cinder | 22:57 | |
| *** jwcroppe has quit IRC | 22:58 | |
| *** salv-orlando has quit IRC | 23:01 | |
| *** jwcroppe has joined #openstack-cinder | 23:14 | |
| *** jwcroppe has quit IRC | 23:18 | |
| *** tommylikehu has quit IRC | 23:23 | |
| *** tommylikehu has joined #openstack-cinder | 23:24 | |
| *** laurent\_ has joined #openstack-cinder | 23:37 | |
| *** laurent\ has quit IRC | 23:39 | |
| *** lucasxu has joined #openstack-cinder | 23:39 | |
| *** lucasxu has quit IRC | 23:40 | |
| *** lucasxu has joined #openstack-cinder | 23:46 | |
| *** lucasxu has quit IRC | 23:47 | |
| smcginnis | jgriffith: All that would go away if it consumers would just say "expose this volume to this host", "stop exposing this volume to this host". | 23:48 |
| smcginnis | Just saying.... | 23:48 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!