| *** edmondsw has joined #openstack-cinder | 00:08 | |
| *** edmondsw has quit IRC | 00:12 | |
| openstackgerrit | Merged openstack/cinder master: FusionStorage: use versioned objects https://review.openstack.org/459614 | 00:22 |
|---|---|---|
| openstackgerrit | Merged openstack/cinder master: RemoteFS: enable image volume cache https://review.openstack.org/458885 | 00:22 |
| *** itlinux_ has joined #openstack-cinder | 00:25 | |
| *** itlinux_ has quit IRC | 00:32 | |
| *** zhurong has joined #openstack-cinder | 00:39 | |
| *** Apoorva_ has joined #openstack-cinder | 00:41 | |
| *** Apoorva has quit IRC | 00:45 | |
| *** Apoorva_ has quit IRC | 00:46 | |
| *** wanghao has joined #openstack-cinder | 00:46 | |
| *** markstur has quit IRC | 00:49 | |
| *** markstur has joined #openstack-cinder | 00:50 | |
| openstackgerrit | TommyLike proposed openstack/python-cinderclient master: Fix PY2/PY3 specific error in testcases https://review.openstack.org/473385 | 00:54 |
| *** markstur has quit IRC | 00:55 | |
| openstackgerrit | TommyLike proposed openstack/python-cinderclient master: Enabled like filter support in client https://review.openstack.org/466214 | 00:56 |
| *** huyang has joined #openstack-cinder | 01:08 | |
| *** zhengyin has joined #openstack-cinder | 01:10 | |
| *** liverpooler has joined #openstack-cinder | 01:16 | |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Remove the redundant volume/snapshot check https://review.openstack.org/474104 | 01:19 |
| *** lucasxu has joined #openstack-cinder | 01:19 | |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Add project_id admin filter to limits API https://review.openstack.org/443437 | 01:21 |
| *** lucasxu has quit IRC | 01:21 | |
| *** gcb has joined #openstack-cinder | 01:30 | |
| *** bkopilov has quit IRC | 01:32 | |
| openstackgerrit | wanghao proposed openstack/cinder master: [api-ref]Fix the wrong description in volume API https://review.openstack.org/474406 | 01:35 |
| *** zengyingzhe has joined #openstack-cinder | 01:36 | |
| *** zhaochao has joined #openstack-cinder | 01:40 | |
| openstackgerrit | wangxiyuan proposed openstack/python-cinderclient master: [WIP]Support volume summary command https://review.openstack.org/474409 | 01:43 |
| *** winston-d_ has joined #openstack-cinder | 01:46 | |
| *** zhangguoqing has joined #openstack-cinder | 01:50 | |
| openstackgerrit | TommyLike proposed openstack/python-cinderclient master: [Optimize] Increase time to wait and add interval https://review.openstack.org/474411 | 01:53 |
| openstackgerrit | Jeremy Zhang proposed openstack/cinder master: Enable some off-by-default checks https://review.openstack.org/474033 | 01:55 |
| *** lhx__ has joined #openstack-cinder | 01:59 | |
| openstackgerrit | wangxiyuan proposed openstack/python-cinderclient master: Support volume summary command https://review.openstack.org/474409 | 02:15 |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient master: Fix 'OS_AUTH_TYPE' doesn't work https://review.openstack.org/472034 | 02:26 |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient master: Test https://review.openstack.org/474424 | 02:28 |
| *** dhinesh has quit IRC | 02:30 | |
| *** markvoelker has quit IRC | 02:32 | |
| *** markvoelker has joined #openstack-cinder | 02:33 | |
| openstackgerrit | wangxiyuan proposed openstack/python-cinderclient master: Support volume summary command https://review.openstack.org/474409 | 02:34 |
| *** markvoelker has quit IRC | 02:37 | |
| *** bkopilov has joined #openstack-cinder | 02:49 | |
| *** nicolasbock has joined #openstack-cinder | 02:51 | |
| *** zhangguoqing has quit IRC | 03:07 | |
| *** itlinux_ has joined #openstack-cinder | 03:10 | |
| *** Shunli has joined #openstack-cinder | 03:14 | |
| *** catintheroof has joined #openstack-cinder | 03:15 | |
| *** lhx__ has quit IRC | 03:16 | |
| *** lhx__ has joined #openstack-cinder | 03:16 | |
| *** crushil has quit IRC | 03:19 | |
| *** isaacb has joined #openstack-cinder | 03:22 | |
| *** isaacb has quit IRC | 03:24 | |
| *** liverpooler has quit IRC | 03:30 | |
| openstackgerrit | Peter Wang proposed openstack/cinder master: VNX: Add QoS support https://review.openstack.org/441786 | 03:31 |
| openstackgerrit | Peter Wang proposed openstack/cinder master: Add VNX replication group support https://review.openstack.org/459205 | 03:32 |
| *** catintheroof has quit IRC | 03:47 | |
| *** markstur has joined #openstack-cinder | 03:49 | |
| *** markstur has quit IRC | 03:49 | |
| *** markstur has joined #openstack-cinder | 03:50 | |
| openstackgerrit | Sofie Huang proposed openstack/cinder master: FalconStor: Support generic group https://review.openstack.org/464112 | 03:50 |
| *** dave-mcc_ has quit IRC | 03:51 | |
| *** nicolasbock has quit IRC | 03:53 | |
| *** zsli_ has joined #openstack-cinder | 03:55 | |
| *** wanghao_ has joined #openstack-cinder | 03:57 | |
| *** wanghao has quit IRC | 03:58 | |
| *** Shunli has quit IRC | 03:58 | |
| *** dhinesh has joined #openstack-cinder | 04:08 | |
| *** stakeda has quit IRC | 04:16 | |
| *** salv-orlando has joined #openstack-cinder | 04:16 | |
| *** salv-orlando has quit IRC | 04:21 | |
| *** gkadam has joined #openstack-cinder | 04:21 | |
| openstackgerrit | Deepak Mourya proposed openstack/cinder-specs master: Remove support for py34. https://review.openstack.org/474445 | 04:21 |
| *** psachin has joined #openstack-cinder | 04:22 | |
| *** stakeda has joined #openstack-cinder | 04:24 | |
| *** gouthamr has quit IRC | 04:24 | |
| *** adisky__ has joined #openstack-cinder | 04:25 | |
| *** zhurong has quit IRC | 04:28 | |
| *** salv-orlando has joined #openstack-cinder | 04:28 | |
| *** markvoelker has joined #openstack-cinder | 04:33 | |
| *** zhurong has joined #openstack-cinder | 04:40 | |
| *** pgadiya has joined #openstack-cinder | 04:42 | |
| *** itlinux_ has quit IRC | 04:44 | |
| *** salv-orl_ has joined #openstack-cinder | 05:05 | |
| *** markvoelker has quit IRC | 05:07 | |
| *** salv-orlando has quit IRC | 05:08 | |
| *** markstur has quit IRC | 05:15 | |
| *** lkuchlan has joined #openstack-cinder | 05:15 | |
| *** markstur has joined #openstack-cinder | 05:16 | |
| openstackgerrit | Deepak Mourya proposed openstack/python-cinderclient master: Replace assertGreaterEqual with assertNotEmpty https://review.openstack.org/474452 | 05:17 |
| gaurangt | is jenkins gate is broken for releasenotes? | 05:19 |
| *** markstur has quit IRC | 05:21 | |
| *** edmondsw has joined #openstack-cinder | 05:32 | |
| *** edmondsw has quit IRC | 05:37 | |
| *** markstur has joined #openstack-cinder | 05:37 | |
| *** markstur has quit IRC | 05:41 | |
| *** abhitechie has joined #openstack-cinder | 05:42 | |
| *** diablo_rojo has joined #openstack-cinder | 05:45 | |
| *** pgadiya has quit IRC | 05:51 | |
| *** zhangguoqing has joined #openstack-cinder | 05:52 | |
| openstackgerrit | Ryan Liang proposed openstack/cinder master: VNX: fix bugs of creating from image cache https://review.openstack.org/474454 | 06:00 |
| *** salv-orl_ has quit IRC | 06:02 | |
| openstackgerrit | Ryan Liang proposed openstack/cinder master: VNX: fix bugs of creating from image cache https://review.openstack.org/474454 | 06:02 |
| *** ChubYann has quit IRC | 06:03 | |
| *** pgadiya has joined #openstack-cinder | 06:04 | |
| *** markvoelker has joined #openstack-cinder | 06:04 | |
| *** rcernin has quit IRC | 06:11 | |
| *** gcb has quit IRC | 06:17 | |
| *** markstur has joined #openstack-cinder | 06:19 | |
| *** markstur has quit IRC | 06:23 | |
| *** dhinesh has quit IRC | 06:26 | |
| *** dhinesh has joined #openstack-cinder | 06:26 | |
| *** gcb has joined #openstack-cinder | 06:28 | |
| openstackgerrit | wangxiyuan proposed openstack/python-cinderclient master: Support volume summary command https://review.openstack.org/474409 | 06:30 |
| *** arnewiebalck_ has joined #openstack-cinder | 06:37 | |
| *** markvoelker has quit IRC | 06:37 | |
| *** rcernin has joined #openstack-cinder | 06:37 | |
| *** tesseract has joined #openstack-cinder | 06:43 | |
| *** dims has quit IRC | 06:44 | |
| *** dims has joined #openstack-cinder | 06:46 | |
| *** dhinesh has quit IRC | 06:53 | |
| *** arnewiebalck_ has quit IRC | 06:56 | |
| *** lkuchlan has quit IRC | 06:56 | |
| *** pcaruana has joined #openstack-cinder | 06:58 | |
| *** sdatko_ has joined #openstack-cinder | 07:12 | |
| *** sdatko has quit IRC | 07:12 | |
| *** salv-orlando has joined #openstack-cinder | 07:12 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/cinder master: Remove duplicated line from _do_attachment_delete https://review.openstack.org/474469 | 07:27 |
| *** arnewiebalck_ has joined #openstack-cinder | 07:30 | |
| *** pewp has quit IRC | 07:30 | |
| *** abhitechie has quit IRC | 07:33 | |
| *** pewp has joined #openstack-cinder | 07:33 | |
| *** hoonetorg has joined #openstack-cinder | 07:34 | |
| *** abhitechie has joined #openstack-cinder | 07:34 | |
| *** markvoelker has joined #openstack-cinder | 07:34 | |
| *** arnewiebalck_ has quit IRC | 07:40 | |
| *** lkuchlan has joined #openstack-cinder | 07:41 | |
| *** gkadam is now known as gkadam-brb | 07:48 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-cinder | 08:00 | |
| *** markvoelker has quit IRC | 08:08 | |
| *** diablo_rojo has quit IRC | 08:11 | |
| *** dosaboy has quit IRC | 08:11 | |
| *** arnewiebalck_ has joined #openstack-cinder | 08:12 | |
| *** mriedem has quit IRC | 08:17 | |
| *** dosaboy has joined #openstack-cinder | 08:19 | |
| *** zhaochao has quit IRC | 08:27 | |
| *** zhaochao has joined #openstack-cinder | 08:28 | |
| *** arnewiebalck_ has quit IRC | 08:29 | |
| *** lpetrut has joined #openstack-cinder | 08:32 | |
| *** psachin has quit IRC | 08:40 | |
| *** psachin has joined #openstack-cinder | 08:41 | |
| *** psachin has quit IRC | 08:43 | |
| *** psachin has joined #openstack-cinder | 08:43 | |
| *** zhengyin has quit IRC | 08:48 | |
| *** zhengyin has joined #openstack-cinder | 08:48 | |
| *** dosaboy has quit IRC | 08:50 | |
| *** abhitechie has quit IRC | 08:51 | |
| *** dosaboy has joined #openstack-cinder | 08:51 | |
| *** dosaboy has quit IRC | 08:53 | |
| *** bjornar has joined #openstack-cinder | 09:04 | |
| *** markvoelker has joined #openstack-cinder | 09:05 | |
| *** edmondsw has joined #openstack-cinder | 09:08 | |
| *** dosaboy has joined #openstack-cinder | 09:08 | |
| *** e0ne has joined #openstack-cinder | 09:12 | |
| *** edmondsw has quit IRC | 09:18 | |
| openstackgerrit | junbo.li proposed openstack/cinder master: Add the missing brace in api/v3/attachment https://review.openstack.org/474508 | 09:21 |
| *** dalgaaf has quit IRC | 09:24 | |
| *** dalgaaf has joined #openstack-cinder | 09:26 | |
| *** zhangguoqing has quit IRC | 09:26 | |
| *** zsli_ has quit IRC | 09:28 | |
| *** psachin has quit IRC | 09:29 | |
| *** markvoelker has quit IRC | 09:38 | |
| *** zhangguoqing has joined #openstack-cinder | 09:41 | |
| *** abhitechie has joined #openstack-cinder | 09:43 | |
| *** abhinavtechie has joined #openstack-cinder | 09:45 | |
| *** abhitechie has quit IRC | 09:47 | |
| *** abhitechie has joined #openstack-cinder | 09:47 | |
| *** abhinavtechie has quit IRC | 09:47 | |
| *** abhitechie has quit IRC | 09:50 | |
| *** stakeda has quit IRC | 09:50 | |
| *** abhitechie has joined #openstack-cinder | 09:50 | |
| *** s-shiono has quit IRC | 09:52 | |
| *** mvk has quit IRC | 09:54 | |
| openstackgerrit | wangxiyuan proposed openstack/cinder master: Support to query volume filter by changes since/before https://review.openstack.org/352688 | 09:54 |
| *** wanghao_ has quit IRC | 09:54 | |
| *** abhitechie has quit IRC | 09:59 | |
| *** abhitechie has joined #openstack-cinder | 09:59 | |
| gaurangt | jenkins job for release notes is failing. Is there a known issue for that? | 10:01 |
| wxy | gaurangt: I guess sphinx 1.6.2 lead this error. 1220b8a67602b8e7-update_rootwrap_volume_filters.yaml and a7401ead26a7c83b-keystone-url.yaml are unreadable for sphinx 1.6.2 | 10:08 |
| *** e0ne has quit IRC | 10:17 | |
| *** nicolasbock has joined #openstack-cinder | 10:19 | |
| *** mvk has joined #openstack-cinder | 10:23 | |
| *** abhishekk has quit IRC | 10:26 | |
| *** markstur has joined #openstack-cinder | 10:28 | |
| *** markstur has quit IRC | 10:32 | |
| *** abhitechie has quit IRC | 10:34 | |
| *** markvoelker has joined #openstack-cinder | 10:34 | |
| *** winston-d has joined #openstack-cinder | 10:37 | |
| *** abhitechie has joined #openstack-cinder | 10:45 | |
| *** sdague has joined #openstack-cinder | 10:48 | |
| *** e0ne has joined #openstack-cinder | 10:49 | |
| *** salv-orlando has quit IRC | 10:56 | |
| openstackgerrit | wzyuliyang proposed openstack/cinder master: Add pigz support for cinder-backup chunked driver compression https://review.openstack.org/450291 | 10:59 |
| *** gkadam-brb is now known as gkadam | 11:00 | |
| *** bkopilov has quit IRC | 11:02 | |
| *** markvoelker has quit IRC | 11:08 | |
| *** e0ne has quit IRC | 11:09 | |
| *** markstur has joined #openstack-cinder | 11:09 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - implement Generic Volume Group feature https://review.openstack.org/474546 | 11:10 |
| openstackgerrit | TommyLike proposed openstack/cinder master: Fix i18n issues https://review.openstack.org/474547 | 11:10 |
| *** markstur has quit IRC | 11:14 | |
| *** ericyoung has joined #openstack-cinder | 11:18 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - bootable volume errors https://review.openstack.org/472674 | 11:19 |
| *** BigDogStl has joined #openstack-cinder | 11:21 | |
| openstackgerrit | TommyLike proposed openstack/python-cinderclient master: DNM. Test environment variables https://review.openstack.org/473165 | 11:27 |
| *** BigDogStl has quit IRC | 11:29 | |
| *** chlong has joined #openstack-cinder | 11:32 | |
| *** salv-orlando has joined #openstack-cinder | 11:34 | |
| *** zhangguoqing has quit IRC | 11:42 | |
| openstackgerrit | howard lee proposed openstack/cinder master: [api-ref]Fix the incorrect description in volume API https://review.openstack.org/474554 | 11:50 |
| *** markvoelker has joined #openstack-cinder | 11:51 | |
| *** markstur has joined #openstack-cinder | 11:51 | |
| *** arnewiebalck_ has joined #openstack-cinder | 11:52 | |
| *** liverpooler has joined #openstack-cinder | 11:55 | |
| *** abishop has joined #openstack-cinder | 11:56 | |
| *** markstur has quit IRC | 11:56 | |
| *** arnewiebalck_ has quit IRC | 11:56 | |
| *** arnewiebalck_ has joined #openstack-cinder | 12:02 | |
| *** pewp has quit IRC | 12:08 | |
| gaurangt | wxy, ok, thanks. Is there any patch already up there which fixes this problem? | 12:09 |
| *** e0ne has joined #openstack-cinder | 12:12 | |
| *** pewp has joined #openstack-cinder | 12:13 | |
| smcginnis | gaurangt: Is this the release notes issue? | 12:21 |
| *** edmondsw has joined #openstack-cinder | 12:22 | |
| smcginnis | There was a reno update yesterday afternoon. Well, afternoon my time. :) | 12:23 |
| *** edmondsw has quit IRC | 12:24 | |
| *** bkopilov has joined #openstack-cinder | 12:24 | |
| *** edmondsw has joined #openstack-cinder | 12:25 | |
| gaurangt | smcginnis, not sure exactly. I don't see any specific error in the releasenotes job for the patch https://review.openstack.org/#/c/469825/. It says job timed out. | 12:26 |
| *** zhurong has quit IRC | 12:26 | |
| *** zhurong has joined #openstack-cinder | 12:28 | |
| smcginnis | gaurangt: Yep, that's the issue then. Hopefully a recheck now would pick up the new reno and it should be OK. | 12:35 |
| *** zhurong has quit IRC | 12:36 | |
| gaurangt | smcginnis, I tried recheck 2 hours back. Still it failed. | 12:37 |
| *** lhx__ has quit IRC | 12:37 | |
| *** lhx__ has joined #openstack-cinder | 12:38 | |
| *** Julien-zte has joined #openstack-cinder | 12:39 | |
| smcginnis | gaurangt: Hmm, that still has reno 2.4.0. IIRC, 2.4.1 is the release that fixes it. | 12:39 |
| *** jdurgin has joined #openstack-cinder | 12:40 | |
| smcginnis | gaurangt: Not sure how/when that will get picked up. | 12:40 |
| smcginnis | Maybe part of the daily image build, but I'm not sure. | 12:40 |
| *** zhengyin has quit IRC | 12:41 | |
| *** jwcroppe has quit IRC | 12:42 | |
| *** e0ne has quit IRC | 12:42 | |
| gaurangt | smcginnis, ok. hopefully soon. | 12:42 |
| *** dustins has joined #openstack-cinder | 12:46 | |
| *** arnewiebalck_ has quit IRC | 12:48 | |
| *** edisonxiang has quit IRC | 12:49 | |
| *** jwcroppe has joined #openstack-cinder | 12:54 | |
| *** catintheroof has joined #openstack-cinder | 13:07 | |
| *** mriedem has joined #openstack-cinder | 13:08 | |
| *** eharney has joined #openstack-cinder | 13:09 | |
| *** gouthamr has joined #openstack-cinder | 13:11 | |
| *** zhangguoqing has joined #openstack-cinder | 13:14 | |
| smcginnis | Constraints job is making its way through the gate right now for reno. | 13:18 |
| smcginnis | Please hold off on rechecking releasenotes failures until that gets updated. | 13:19 |
| *** catinthe_ has joined #openstack-cinder | 13:21 | |
| *** catintheroof has quit IRC | 13:24 | |
| *** catintheroof has joined #openstack-cinder | 13:25 | |
| *** catinthe_ has quit IRC | 13:25 | |
| *** lhx__ has quit IRC | 13:25 | |
| *** catinthe_ has joined #openstack-cinder | 13:26 | |
| *** catinth__ has joined #openstack-cinder | 13:26 | |
| *** catintheroof has quit IRC | 13:26 | |
| *** lucasxu has joined #openstack-cinder | 13:26 | |
| *** dave-mccowan has joined #openstack-cinder | 13:27 | |
| *** catintheroof has joined #openstack-cinder | 13:29 | |
| *** catinthe_ has quit IRC | 13:30 | |
| *** catinth__ has quit IRC | 13:33 | |
| *** mariusv has joined #openstack-cinder | 13:33 | |
| *** cknight has joined #openstack-cinder | 13:36 | |
| *** tomh has joined #openstack-cinder | 13:38 | |
| *** crose has joined #openstack-cinder | 13:40 | |
| *** eharney has quit IRC | 13:42 | |
| tommylikehu | hey jungleboyj , smcginnis could you take a look at these two patches again? https://review.openstack.org/#/c/473385/， https://review.openstack.org/#/c/466214/, thanks :) | 13:44 |
| jungleboyj | tommylikehu: I am on vacation today but will try to look later. :-) | 13:45 |
| smcginnis | tommylikehu: lgtm | 13:46 |
| tommylikehu | jungleboyj: haha :! | 13:46 |
| tommylikehu | enjoy your trip | 13:46 |
| *** zzzeek has quit IRC | 13:46 | |
| *** zzzeek has joined #openstack-cinder | 13:47 | |
| openstackgerrit | TommyLike proposed openstack/python-cinderclient master: DNM. Test environment variables https://review.openstack.org/473165 | 13:49 |
| tommylikehu | smcginnis: do you know who is familiar with i18n logic in cinder? | 13:50 |
| *** zhurong has joined #openstack-cinder | 13:50 | |
| smcginnis | tommylikehu: What part of it? | 13:51 |
| tommylikehu | smcginnis: make the resource translatable with the coordinate of oslo.i18n | 13:52 |
| *** abhitechie has quit IRC | 13:53 | |
| *** mariusv has quit IRC | 13:55 | |
| smcginnis | tommylikehu: Well, strings are translatable. "Resources" other than strings are not. | 13:56 |
| smcginnis | tommylikehu: Basically anything with the marker get pulled out into a queue that the translation team can go through and localize. | 13:56 |
| smcginnis | tommylikehu: That get's added to a catalog. | 13:56 |
| tommylikehu | have you checked this ? https://review.openstack.org/#/c/474547/ | 13:57 |
| tommylikehu | smcginnis: | 13:57 |
| *** lhx__ has joined #openstack-cinder | 13:57 | |
| *** eharney has joined #openstack-cinder | 13:57 | |
| *** crushil has joined #openstack-cinder | 13:57 | |
| smcginnis | tommylikehu: Then at runtime, if the locale matches one of the available catalogs, it will replace those strings with the localized string. | 13:57 |
| tommylikehu | smcginnis: of course you did :) | 13:57 |
| smcginnis | :) | 13:57 |
| smcginnis | tommylikehu: So there's nothing there that gets translated. | 13:58 |
| smcginnis | tommylikehu: If the underlying exception was created with a translated text, then that just gets carried through. | 13:58 |
| *** crose has quit IRC | 13:58 | |
| tommylikehu | smcginnis: I am a little confused, the original ones can't be translated, the latter one can | 13:59 |
| *** jistr is now known as jistr|mtg | 13:59 | |
| smcginnis | tommylikehu: So whether you explicitly get the exception message, or get its string representation by sending it through six.text_type, it all depends on whether that string is already translated or not. | 13:59 |
| smcginnis | tommylikehu: How can the latter ones be translated? | 13:59 |
| tommylikehu | smcginnis: with this sentence: https://github.com/openstack/oslo.i18n/blob/master/oslo_i18n/_translate.py#L45 | 14:00 |
| *** crose has joined #openstack-cinder | 14:00 | |
| tommylikehu | codes | 14:00 |
| *** crose has quit IRC | 14:01 | |
| *** crose has joined #openstack-cinder | 14:01 | |
| openstackgerrit | Gorka Eguileor proposed openstack/os-brick master: Add open-iscsi manual scan support https://review.openstack.org/455394 | 14:01 |
| openstackgerrit | Gorka Eguileor proposed openstack/os-brick master: Refactor iSCSI connect https://review.openstack.org/455393 | 14:02 |
| *** arnewiebalck_ has joined #openstack-cinder | 14:02 | |
| *** charlesr has joined #openstack-cinder | 14:03 | |
| smcginnis | tommylikehu: That just checks that the value is a string. | 14:03 |
| *** crose has quit IRC | 14:03 | |
| *** charlesr has quit IRC | 14:03 | |
| smcginnis | tommylikehu: Which it needs to match up with the translation in the catalog. | 14:03 |
| tommylikehu | smcginnis: it could not depend on whether is already translated or not, i18n have the lazy_load mode, which means the message will be tranlsated when preparing the http response right? | 14:03 |
| smcginnis | tommylikehu: https://github.com/openstack/oslo.i18n/blob/master/oslo_i18n/_message.py#L38 | 14:03 |
| *** crose has joined #openstack-cinder | 14:03 | |
| smcginnis | tommylikehu: If the string is in the catalog. At least from my understanding. | 14:03 |
| tommylikehu | smcginnis: how could the formated string "volume 1234 not found" be in the translating lists | 14:05 |
| tommylikehu | and a message is a instance of string but a string is not a instance of message? | 14:05 |
| smcginnis | tommylikehu: If the exception is created using Exception(_('volume %s not found') % vol) | 14:05 |
| smcginnis | tommylikehu: We could try to find someone from that team that could take a look and correct me if I'm wrong. | 14:06 |
| tommylikehu | smcginnis: yeah, I am also not sure about that :) it just works in my environment | 14:07 |
| *** arnewiebalck_ has quit IRC | 14:07 | |
| *** eharney_ has joined #openstack-cinder | 14:08 | |
| openstackgerrit | Merged openstack/cinder master: Add the missing brace in api/v3/attachment https://review.openstack.org/474508 | 14:09 |
| *** eharney has quit IRC | 14:10 | |
| *** eharney_ is now known as eharney | 14:11 | |
| *** pgadiya has quit IRC | 14:18 | |
| openstackgerrit | TommyLike proposed openstack/cinder master: Fix excepption deserialization error in rpc https://review.openstack.org/474596 | 14:20 |
| *** zhurong has quit IRC | 14:22 | |
| openstackgerrit | TommyLike proposed openstack/cinder master: Fix exception deserialization error in rpc https://review.openstack.org/474596 | 14:25 |
| *** lkuchlan has quit IRC | 14:36 | |
| mriedem | jgriffith: went through just the commit message on https://review.openstack.org/#/c/472786/ | 14:42 |
| mriedem | i think by v2 you mean something different from the v2 API | 14:42 |
| mriedem | but it's confusing | 14:42 |
| mriedem | plus it's unclear to me if you think nova needs to know if cinder initiated the swap or not, because nova doesn't know that | 14:42 |
| jgriffith | mriedem yeah, it's a mess... V2 Attach-API | 14:42 |
| jgriffith | mriedem I can fix the references around the API "v" thing | 14:43 |
| jgriffith | mriedem as far as Nova "knowing" I would prefer they "didn't" but the way the existing code is written it always assumes cinder initiated it (which is bad) | 14:44 |
| mriedem | jgriffith: because of the callback? | 14:45 |
| jgriffith | mriedem It turns out that if Cinder does initiate it though we can tell on the nova side based on the volume.status | 14:45 |
| jgriffith | yes... the callback | 14:45 |
| jgriffith | that does nothing in the Nova initiated case anyway | 14:45 |
| mriedem | jgriffith: but i thought cinder just ignored the callback from nova if cinder didn't initiated? | 14:45 |
| mriedem | *initiate | 14:45 |
| jgriffith | mriedem so in the attach POC I added some logic for that | 14:45 |
| jgriffith | mriedem yes, it does but in does it by.... volume.status | 14:46 |
| mriedem | this is what i was thinking of btw https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L1449 | 14:46 |
| jgriffith | mriedem anyway, on the nova side I added this: https://review.openstack.org/#/c/330285/50/nova/compute/manager.py L#5094 | 14:46 |
| jgriffith | looking | 14:47 |
| mriedem | in the case of https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L1449 then it's just a db state update and no call to the volume manager | 14:47 |
| jgriffith | mriedem right, but it falls apart on the Cinder side because Cinder doesn't *know* how the attachment was created | 14:47 |
| jgriffith | so I moved the status checking for that sort of thing over to nova and just skip the callback altogether if/when we don't care about it | 14:48 |
| jgriffith | I'd like to get rid of all of that nonsense when we can drop the old attach code | 14:48 |
| mriedem | jgriffith: ok so this https://review.openstack.org/#/c/330285/50/nova/compute/manager.py@5094 | 14:49 |
| jgriffith | but that's a year out so until then I tried to get as close as I could while keeping compatabiity | 14:49 |
| jgriffith | mriedem right, that's just a way for Nova to do what Cinder was doing in the callback... but avoid making the call in the first place if it didn't need to | 14:50 |
| jgriffith | mriedem does that make sense? Or do you see a problem with that? | 14:50 |
| mriedem | well, it's tight coupling of volume state outside of cinder | 14:50 |
| mriedem | which was something we were trying to get rid of in removing thins like check_attach on the nova side | 14:50 |
| jgriffith | ok | 14:50 |
| mriedem | i prefer the hack over needing new apis on both sides though | 14:51 |
| mriedem | at least short term | 14:51 |
| ildikov | mriedem: +1 | 14:51 |
| mriedem | does ildikov show up when "check_attach" is mentioned? | 14:51 |
| ildikov | :) | 14:51 |
| jgriffith | haha.. I think it's "attach" that triggers | 14:52 |
| jgriffith | multi/new/check | 14:52 |
| *** Julien-zte has quit IRC | 14:52 | |
| mriedem | we should probably move that logic over to the nova swap volume patch https://review.openstack.org/#/c/456971/7/nova/compute/manager.py@5098 | 14:52 |
| ildikov | mriedem: as I'm in favor of removing those state checks, except this special case I thought to make my opinion visible :) | 14:52 |
| mriedem | to separate things a bit | 14:52 |
| jgriffith | mriedem yeah, note in the review comments I actually was *trying* to do that :) | 14:52 |
| *** lkuchlan has joined #openstack-cinder | 14:53 | |
| jgriffith | thats' where it was supposed to go, but I ended up pushing the whole test branch that I was using :( | 14:53 |
| *** e0ne has joined #openstack-cinder | 14:53 | |
| mriedem | ok i see now | 14:54 |
| mriedem | i didn't realize ildikov had abandoned the swap patch | 14:54 |
| ildikov | I re-opened it after :) | 14:54 |
| mriedem | jgriffith: so ignoring the 3.27 new style attachment stuff, should nova just not be calling the migration callback if cinder never initiated the swap? for old style attachments i mean? | 14:55 |
| ildikov | as we were debating where it makes sense to put the swap changes and finally ended up wanting to keep it separate if possible | 14:55 |
| mriedem | or is that still needed for the in-use status update? | 14:55 |
| jgriffith | mriedem maybe, but for now I didn't want to try and unwind that | 14:56 |
| *** xyang has joined #openstack-cinder | 14:56 | |
| *** Julien-zte has joined #openstack-cinder | 14:56 | |
| *** Julien-zte has quit IRC | 14:56 | |
| jgriffith | mriedem I just tried to leave the code path the same for old style without breaking anything (that's not already broken) | 14:56 |
| mriedem | yeah, i think we need the callback for hte old style attachment swap, | 14:57 |
| mriedem | because otherwise the new volume never goes to in-use | 14:57 |
| *** markstur has joined #openstack-cinder | 14:57 | |
| mriedem | since nova isn't calling os-attach | 14:57 |
| jgriffith | oh, that part... yes | 14:57 |
| jgriffith | I'm sort of bummed out by all of that code honestly | 14:58 |
| mriedem | don't feel bad | 14:58 |
| mriedem | i get depressed by code daily :) | 14:58 |
| jgriffith | we could probably make it much better but trying to do it and support both Attach API's is not going to make that worthwhile | 14:58 |
| mriedem | i'm fine with short term hackery until we can drop the old attach flows | 14:59 |
| mriedem | and then think about newer better api flows | 14:59 |
| jgriffith | Yeah, I think that's our best bet.. or just disable the migration stuff and say it was a bug :) | 14:59 |
| mriedem | sure | 14:59 |
| jgriffith | one great big bug | 14:59 |
| *** jistr|mtg is now known as jistr | 14:59 | |
| *** MVenesio has joined #openstack-cinder | 15:01 | |
| *** crushil has quit IRC | 15:02 | |
| mriedem | i can work on porting those changes over to the other patch in nova quick | 15:02 |
| mriedem | i see i stole author on that patch from ildikov too somehow | 15:03 |
| *** crushil has joined #openstack-cinder | 15:03 | |
| mriedem | that's been happening lately with git review -d & git rebase -i | 15:03 |
| ildikov | mriedem: I'm not that sensitive about my Stackalytics numbers, so don't sweat on that | 15:03 |
| ildikov | cannot confirm the git review stuff as I'm not using it | 15:04 |
| mriedem | i pull changes down with git review -d | 15:04 |
| ildikov | no one could convince me yet to switch over from the plane old git commands | 15:04 |
| *** gkadam has quit IRC | 15:04 | |
| *** mvk has quit IRC | 15:05 | |
| *** rcernin has quit IRC | 15:09 | |
| *** dhinesh has joined #openstack-cinder | 15:11 | |
| *** zhangguoqing has quit IRC | 15:17 | |
| *** felipemonteiro has joined #openstack-cinder | 15:18 | |
| *** lkuchlan has quit IRC | 15:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Updated from global requirements https://review.openstack.org/472311 | 15:22 |
| openstackgerrit | wzyuliyang proposed openstack/cinder master: Add pigz support for cinder-backup chunked driver compression https://review.openstack.org/450291 | 15:22 |
| *** lpetrut has quit IRC | 15:26 | |
| *** bjornar has quit IRC | 15:26 | |
| mriedem | jgriffith: ildikov: ok got the swap changes integrated into the older patch, things are a bit different since in the original patch we're creating the new attachment in the api and sending that down over rpc to the compute, in jgriffith's patch the compute service is creating the new attachment | 15:27 |
| jgriffith | mriedem I can look at fixing that | 15:27 |
| mriedem | jgriffith: i also noticed in yours that https://review.openstack.org/#/c/330285/50/nova/compute/manager.py@5111 we'd only be calling back to cinder in the new style attachment condition, which breaks the old style swap | 15:27 |
| jgriffith | mriedem thanks for cleaning up my mess | 15:27 |
| mriedem | i'll push in a sec | 15:28 |
| jgriffith | mriedem hmm... that shouldn't be the case | 15:28 |
| *** hongbin has joined #openstack-cinder | 15:28 | |
| ildikov | mriedem: I started it in the API as I thought that's the desire | 15:28 |
| jgriffith | mriedem ahh, yeah | 15:28 |
| jgriffith | I see it shoot | 15:28 |
| mriedem | here is the rebased updated patch https://review.openstack.org/456971 | 15:29 |
| mriedem | pulling over the is_cinder_migration logic | 15:29 |
| jgriffith | I tested old-nova/new-cinder, new-nova/new-cinder but NOT new-nova/old-cinder :( | 15:29 |
| openstackgerrit | wzyuliyang proposed openstack/cinder master: Add pigz support for cinder-backup chunked driver compression https://review.openstack.org/450291 | 15:30 |
| jgriffith | ez2fix | 15:30 |
| mriedem | jgriffith: sure, but we're pulling the swap stuff out of https://review.openstack.org/#/c/330285/ right? | 15:30 |
| mriedem | the swap stuff is going into https://review.openstack.org/456971 | 15:30 |
| jgriffith | yes!! | 15:30 |
| mriedem | ok | 15:30 |
| jgriffith | correct | 15:30 |
| mriedem | yeah i think i've got it fixed in https://review.openstack.org/456971 | 15:30 |
| mriedem | we create the new volume attachment in the api so it's "reserved" or whatever early | 15:31 |
| mriedem | that's the replacement for doing reserve_volume on the new_volume in the api | 15:31 |
| mriedem | then we update the new attachment with the host connector in the compute side | 15:31 |
| mriedem | instead of calling initialize_connection | 15:31 |
| *** cknight has quit IRC | 15:31 | |
| mriedem | i've tried to doc as much of this as possible in the code since the conditional spaghetti gets overwhelming | 15:32 |
| ildikov | sounds correct | 15:32 |
| jgriffith | mriedem that update looks right | 15:33 |
| jgriffith | mriedem thanks | 15:33 |
| mriedem | sweet | 15:33 |
| ildikov | mriedem: thanks! | 15:36 |
| jgriffith | tommylikehu smcginnis do you think that whatever's up with that var change to cinderclient-shell is something int he tempest cli lib? | 15:44 |
| jgriffith | tommylikehu smcginnis it's strange because it functions just fine directly | 15:44 |
| *** rcernin has joined #openstack-cinder | 15:44 | |
| smcginnis | jgriffith: It was kind of looking like that to me. | 15:45 |
| smcginnis | But I can't find where. | 15:45 |
| jgriffith | me neither | 15:45 |
| jgriffith | very frustrating | 15:46 |
| jgriffith | the fact that hound only found that var in monasca and those clients is also troubling | 15:46 |
| *** crose has quit IRC | 15:48 | |
| smcginnis | jgriffith: No clue how either of those could be coming in to play here, so that was very confusing. | 15:48 |
| smcginnis | I expected to find more references in the code than that. | 15:48 |
| *** crushil has quit IRC | 15:48 | |
| *** crushil has joined #openstack-cinder | 15:49 | |
| *** e0ne has quit IRC | 15:51 | |
| *** xyang has quit IRC | 15:59 | |
| *** xyang has joined #openstack-cinder | 16:00 | |
| *** xyang has quit IRC | 16:01 | |
| *** crushil has quit IRC | 16:02 | |
| *** crushil has joined #openstack-cinder | 16:03 | |
| *** eharney has quit IRC | 16:05 | |
| *** rcernin has quit IRC | 16:12 | |
| *** dhinesh has quit IRC | 16:15 | |
| *** MVenesio has quit IRC | 16:16 | |
| *** eharney has joined #openstack-cinder | 16:20 | |
| *** xyang has joined #openstack-cinder | 16:21 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Updated from global requirements https://review.openstack.org/472311 | 16:21 |
| *** xyang has quit IRC | 16:22 | |
| *** Apoorva has joined #openstack-cinder | 16:24 | |
| *** itlinux has joined #openstack-cinder | 16:26 | |
| *** Apoorva_ has joined #openstack-cinder | 16:30 | |
| *** MVenesio has joined #openstack-cinder | 16:31 | |
| *** Apoorva has quit IRC | 16:32 | |
| *** jdurgin has quit IRC | 16:33 | |
| *** cknight has joined #openstack-cinder | 16:36 | |
| *** arnewiebalck_ has joined #openstack-cinder | 16:37 | |
| openstackgerrit | Merged openstack/python-cinderclient master: Fix PY2/PY3 specific error in testcases https://review.openstack.org/473385 | 16:39 |
| *** eharney has quit IRC | 16:41 | |
| *** lhx__ has quit IRC | 16:43 | |
| openstackgerrit | Merged openstack/cinder master: Remove duplicated line from _do_attachment_delete https://review.openstack.org/474469 | 16:44 |
| openstackgerrit | Merged openstack/cinder master: Fix boolean opts defined as strings https://review.openstack.org/449756 | 16:44 |
| *** tesseract has quit IRC | 16:46 | |
| *** crushil has quit IRC | 16:51 | |
| *** xyang has joined #openstack-cinder | 16:52 | |
| *** MVenesio has quit IRC | 16:56 | |
| *** crushil has joined #openstack-cinder | 16:56 | |
| *** eharney has joined #openstack-cinder | 17:00 | |
| *** kfarr has joined #openstack-cinder | 17:00 | |
| *** dhinesh has joined #openstack-cinder | 17:04 | |
| *** dhinesh has quit IRC | 17:08 | |
| *** salv-orl_ has joined #openstack-cinder | 17:14 | |
| *** pcaruana has quit IRC | 17:16 | |
| *** salv-orlando has quit IRC | 17:17 | |
| *** arnewiebalck_ has quit IRC | 17:18 | |
| _alastor_ | smcginnis: I think I might be hitting more etcd issues. I've been seeing this error constantly in the cinder-volume logs since the etcd thing was introduced in devstack: https://pastebin.com/raw/2Behpb1v | 17:21 |
| _alastor_ | smcginnis: could be just coincidental | 17:21 |
| *** xyang has quit IRC | 17:21 | |
| *** xyang has joined #openstack-cinder | 17:21 | |
| _alastor_ | smcginnis: It causes about half of tempest to fail | 17:22 |
| _alastor_ | smcginnis: The exception seems to be happening in coordination.py which is why I suspect etcd | 17:24 |
| *** jdurgin has joined #openstack-cinder | 17:34 | |
| xyang | @smcginnis, jungleboyj: do I need to rebase my patch that has the release note failure for it to be merged? A recheck won't resolve it? | 17:37 |
| _alastor_ | smcginnis: checking out master instead of the patch I'm trying to test doesn't help :( | 17:45 |
| *** crushil has quit IRC | 17:54 | |
| *** felipemonteiro has quit IRC | 17:55 | |
| *** crushil has joined #openstack-cinder | 17:55 | |
| *** ChubYann has joined #openstack-cinder | 17:56 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Updated from global requirements https://review.openstack.org/472311 | 17:59 |
| *** mvk has joined #openstack-cinder | 18:03 | |
| *** zzzeek has quit IRC | 18:04 | |
| openstackgerrit | Merged openstack/cinder master: Add CG capability to generic groups in GPFS driver https://review.openstack.org/469825 | 18:07 |
| *** pewp has quit IRC | 18:17 | |
| *** MVenesio has joined #openstack-cinder | 18:17 | |
| *** pewp has joined #openstack-cinder | 18:21 | |
| *** crushil has quit IRC | 18:21 | |
| *** jdurgin has quit IRC | 18:21 | |
| *** crushil has joined #openstack-cinder | 18:21 | |
| *** Apoorva_ has quit IRC | 18:26 | |
| jungleboyj | xyang: The replication one? I thought that it would be fixed by the update to reno in the check/gate, but maybe not. | 18:27 |
| xyang | jungleboyj: yes. I just triggered another recheck | 18:29 |
| xyang | jungleboyj: I saw anther patch passed the release note failure after recheck this morning | 18:29 |
| jungleboyj | Ok, if the recheck doesn't work then I would try a rebase. | 18:30 |
| xyang | jungleboyj: sure, thanks | 18:30 |
| smcginnis | _alastor_: Hah! | 18:31 |
| smcginnis | xyang: You might need to rebase, but not related to the releasenotes job. | 18:32 |
| smcginnis | xyang: I never noticed this until recently, but if you look at the Parent hash below Author, Committer, etc. there is an orange dot. | 18:32 |
| smcginnis | xyang: That was pointed out to me as the reason why a patch that had +W was not getting picked up by the gate queue. | 18:33 |
| smcginnis | xyang: So we can try, but we might be in the same situation here. | 18:33 |
| smcginnis | eharney: You may want to chime in on this one: http://lists.openstack.org/pipermail/openstack-dev/2017-June/118427.html | 18:33 |
| eharney | smcginnis: yeah... looks like folks ran out of steam on https://review.openstack.org/#/c/471352/ | 18:35 |
| smcginnis | eharney: Just interesting to hear glance is hitting the same kind of issues we've been hitting. Repeatedly. | 18:36 |
| eharney | smcginnis: yeah, this unshelve issue actually blocked me fixing glance_store's cinder backend for a while | 18:36 |
| eharney | which, also, has no CI | 18:37 |
| xyang | @smcginnis: oh, I see the orange dot now. I didn't know what you were talking about earlier. Let me just rebase and submit another patch | 18:37 |
| smcginnis | xyang: It's hidden in plain sight. :) | 18:38 |
| xyang | @smcginnis: :) | 18:38 |
| *** xyang has quit IRC | 18:39 | |
| *** dhinesh has joined #openstack-cinder | 18:40 | |
| *** xyang has joined #openstack-cinder | 18:41 | |
| *** nicolasbock has quit IRC | 18:41 | |
| openstackgerrit | xing-yang proposed openstack/cinder master: Tiramisu: replication group support https://review.openstack.org/352228 | 18:42 |
| xyang | @smcginnis, jungleboyj: just rebased. +2's are still there. can you add +A back? https://review.openstack.org/#/c/352228/ | 18:43 |
| *** liverpooler has quit IRC | 18:43 | |
| jungleboyj | xyang: Yep. Doing it now. | 18:44 |
| *** arnewiebalck_ has joined #openstack-cinder | 18:44 | |
| xyang | jungleboyj: thanks | 18:44 |
| jungleboyj | Done. | 18:45 |
| smcginnis | jungleboyj's on top of things on his vacation. :) | 18:46 |
| openstackgerrit | xing-yang proposed openstack/cinder master: Functional tests for group replication https://review.openstack.org/472784 | 18:46 |
| jungleboyj | smcginnis: Yes, keeps me from crying when I look at my parent | 18:46 |
| jungleboyj | 's empty house. | 18:46 |
| smcginnis | jungleboyj: Hah, that last bit is important. | 18:47 |
| jungleboyj | :-) | 18:47 |
| smcginnis | jungleboyj: Without finishing the sentence, that could be kind of mean. :P | 18:47 |
| xyang | jungleboyj: thank you for working on this while on vacation!:) | 18:47 |
| openstackgerrit | Eric Harney proposed openstack/cinder master: Tests: Disallow use of assertTrue(str) https://review.openstack.org/471809 | 18:47 |
| jungleboyj | smcginnis: Got all the electronics out this morning. Just waiting for the movers to get it to the new house now. | 18:47 |
| _alastor_ | smcginnis: Do you know if we can fall back to the old behavior? | 18:52 |
| _alastor_ | smcginnis: That might at least get me off the ground again | 18:52 |
| smcginnis | _alastor_: I'm not sure. Maybe explicitly disable the etcd service? | 18:53 |
| smcginnis | _alastor_: I'm assuming there's something you can set in local.conf that can control that. | 18:53 |
| _alastor_ | smcginnis: Well, I think I may have found my problem. Etcd isn't even listed as a service... | 18:54 |
| _alastor_ | smcginnis: I guess that's something we have to explicitly set in local.conf? | 18:55 |
| smcginnis | _alastor_: From the conversation yesterday, I thought devstack defaulted to installing that now. | 18:55 |
| smcginnis | _alastor_: Well, once you apply my patch, if you run with a loopback address for SERVICE_HOST. | 18:56 |
| smcginnis | _alastor_: Have you pulled the latest devstack? | 18:56 |
| _alastor_ | smcginnis: I applied your patch manually with the latest devstack | 18:56 |
| smcginnis | _alastor_: If it's not enabled, it shouldn't be trying to use etcd | 18:56 |
| smcginnis | Hmmm | 18:56 |
| _alastor_ | It looks like the start_etcd function bails out for me before starting etcd | 18:57 |
| _alastor_ | smcginnis: because I'm using the loopback | 18:57 |
| *** xyang has quit IRC | 18:57 | |
| *** xyang has joined #openstack-cinder | 18:58 | |
| *** xyang has quit IRC | 18:59 | |
| smcginnis | _alastor_: Oh right, that change makes sure it's installed, but it doesn't start it if it doesn't match yet. | 19:00 |
| smcginnis | _alastor_: So more work is needed there. :/ | 19:00 |
| _alastor_ | smcginnis: I could try rebuilding and just remove that entire check from that function | 19:00 |
| smcginnis | _alastor_: Want to comment on that patch? Not sure best approach then unless we explicitly check for 127.0.0.1 and the IPv6 equivalent that I can never remember. | 19:01 |
| _alastor_ | smcginnis: ok, I'll add the info | 19:01 |
| _alastor_ | smcginnis: You're talking about your patch to move the install right? | 19:01 |
| *** mwheckmann has joined #openstack-cinder | 19:02 | |
| smcginnis | _alastor_: Yep | 19:06 |
| *** catinthe_ has joined #openstack-cinder | 19:07 | |
| *** lucasxu has quit IRC | 19:10 | |
| *** catintheroof has quit IRC | 19:11 | |
| *** lucasxu has joined #openstack-cinder | 19:11 | |
| *** mriedem has quit IRC | 19:17 | |
| *** arnewiebalck_ has quit IRC | 19:21 | |
| *** catintheroof has joined #openstack-cinder | 19:22 | |
| *** ericyoung has quit IRC | 19:23 | |
| *** catinthe_ has quit IRC | 19:25 | |
| *** mriedem has joined #openstack-cinder | 19:33 | |
| *** lkuchlan has joined #openstack-cinder | 19:38 | |
| *** mtanino_ has joined #openstack-cinder | 19:44 | |
| *** mtanino_ is now known as mtanino | 19:46 | |
| *** MVenesio has quit IRC | 19:48 | |
| *** itlinux has quit IRC | 19:59 | |
| *** lkuchlan has quit IRC | 19:59 | |
| *** xyang has joined #openstack-cinder | 20:05 | |
| *** xyang has quit IRC | 20:06 | |
| openstackgerrit | Ben Swartzlander proposed openstack/cinder master: NetApp: Fix override of scheduler decision https://review.openstack.org/463312 | 20:06 |
| *** xyang1 has joined #openstack-cinder | 20:07 | |
| *** eharney has quit IRC | 20:10 | |
| *** itlinux has joined #openstack-cinder | 20:12 | |
| *** xyang has joined #openstack-cinder | 20:15 | |
| jgriffith | ehar | 20:34 |
| jgriffith | boo.. he's not home right now | 20:34 |
| smcginnis | Slacker | 20:36 |
| smcginnis | Dave's not here. | 20:37 |
| jgriffith | Nooo man... I'm Dave! | 20:37 |
| jgriffith | I've got the stuff! | 20:37 |
| smcginnis | Who is it? | 20:37 |
| jgriffith | Now open up man I think the cops so me come up here! | 20:37 |
| jgriffith | It's DAVE man!!! | 20:38 |
| smcginnis | No man, I'm Dave man | 20:38 |
| jgriffith | Oh man | 20:38 |
| jgriffith | memories!! | 20:38 |
| smcginnis | :) | 20:38 |
| jgriffith | Actually had that on vinyl... it was my dads | 20:38 |
| smcginnis | Oh nice! | 20:38 |
| jgriffith | lOL | 20:38 |
| jgriffith | hidden under some Black Sabbath records | 20:38 |
| smcginnis | It's a classic. | 20:38 |
| jgriffith | it is | 20:39 |
| *** crushil has quit IRC | 20:42 | |
| *** crushil has joined #openstack-cinder | 20:43 | |
| *** crushil has quit IRC | 20:49 | |
| *** cknight has quit IRC | 20:50 | |
| *** crushil has joined #openstack-cinder | 20:51 | |
| *** lucasxu has quit IRC | 20:55 | |
| openstackgerrit | Merged openstack/cinder master: Updated from global requirements https://review.openstack.org/472311 | 20:59 |
| *** catinthe_ has joined #openstack-cinder | 21:06 | |
| *** catintheroof has quit IRC | 21:09 | |
| *** Apoorva has joined #openstack-cinder | 21:14 | |
| *** dustins has quit IRC | 21:18 | |
| *** gouthamr has quit IRC | 21:23 | |
| *** abishop has quit IRC | 21:24 | |
| *** catinthe_ has quit IRC | 21:28 | |
| *** adisky__ has quit IRC | 21:34 | |
| mriedem | scottda: looks like this is why that bfv retype test failed http://logs.openstack.org/45/470645/5/experimental/gate-tempest-dsvm-neutron-scenario-multinode-lvm-multibackend-ubuntu-xenial-nv/0b421c5/logs/screen-c-vol.txt.gz?level=TRACE#_Jun_06_02_18_21_110268 | 21:36 |
| mriedem | cinder failed to tell nova to swap the volumes | 21:36 |
| mriedem | b/c of policy | 21:36 |
| scottda | mriedem: makes sense. | 21:37 |
| mriedem | i'm not sure why though | 21:37 |
| mriedem | so maybe the test is slow just b/c it times out | 21:38 |
| scottda | You mean slow because it times out every time? | 21:39 |
| mriedem | yes | 21:39 |
| mriedem | Details: Volume af82b615-3c15-4069-9573-70700c452713 failed to reach tempest-scenario-type-tempest-TestVolumeMigrateRetypeAttached-volume-type-993452497-1023449667 volume type (current tempest-scenario-type-tempest-TestVolumeMigrateRetypeAttached-volume-type-557937225-1260793733) within the required time (196 s). | 21:40 |
| scottda | yikes. | 21:40 |
| mriedem | so by default you have to be admin to swap volumes in nova | 21:40 |
| mriedem | i wonder if the test is running under a non-admin creds | 21:40 |
| scottda | Although I recall running local tests that worked, and it does take a long time on the happy path... | 21:41 |
| scottda | I don't think you can retype without admin... | 21:41 |
| mriedem | i think the test is creating the volume types as admin, but everything else as non-admin | 21:41 |
| *** gouthamr has joined #openstack-cinder | 21:42 | |
| mriedem | https://bugs.launchpad.net/tempest/+bug/1698224 | 21:42 |
| openstack | Launchpad bug 1698224 in tempest "test_volume_migrate_attached fails because of policy os_compute_api:os-volumes-attachments:update 403" [Undecided,New] | 21:42 |
| mriedem | i'll poke at it | 21:43 |
| scottda | k | 21:44 |
| *** xyang has quit IRC | 21:44 | |
| *** xyang has joined #openstack-cinder | 21:47 | |
| openstackgerrit | Merged openstack/cinder master: Tiramisu: replication group support https://review.openstack.org/352228 | 21:47 |
| mriedem | aha | 21:48 |
| mriedem | "volume:retype": "rule:admin_or_owner", | 21:48 |
| mriedem | cinder's default retype policy is admin or owner | 21:48 |
| mriedem | so tempest is using the non-admin client to create the volume and instance, and start the retype | 21:48 |
| mriedem | which cinder policy says is fine | 21:48 |
| mriedem | but when cinder tries to tell nova to swap the volume, that fails b/c it's not an admin | 21:48 |
| mriedem | why is "volume_extension:volume_admin_actions:migrate_volume": "rule:admin_api", admin-only by default but retype is admin_or_owner? | 21:48 |
| mriedem | https://review.openstack.org/474789 | 21:51 |
| *** xyang has quit IRC | 21:52 | |
| mriedem | maybe it depends on the migration_policy? | 21:52 |
| *** xyang has joined #openstack-cinder | 21:52 | |
| mriedem | if it's on-demand or never - does cinder still call nova either way? or only if migration_policy=on-demand? | 21:53 |
| smcginnis | mriedem: I think only if on-demand it there is the demand. | 22:02 |
| *** cknight has joined #openstack-cinder | 22:03 | |
| mriedem | umm | 22:03 |
| mriedem | wut? | 22:03 |
| mriedem | i am what i am? | 22:03 |
| mriedem | yeah i dug into some code, | 22:04 |
| mriedem | looks like if policy is 'never' and it requires a migration, it will fail | 22:04 |
| smcginnis | mriedem: Problem with one command that kind of does two things. | 22:04 |
| mriedem | i'm just wondering if i should say something about this in the block storage api ref | 22:04 |
| smcginnis | One of those things also being something that is done by another command. | 22:04 |
| jgriffith | mriedem because I refused to merge until that was set | 22:04 |
| smcginnis | mriedem: Probably would be good to mention that in the ref. | 22:04 |
| jgriffith | and then I -1'd and it got merged anyway | 22:04 |
| mriedem | i just don't know how you'd sanely communicate this | 22:05 |
| jgriffith | the whole thing is a train wreck, try communicating what it does in the first place | 22:05 |
| smcginnis | You're expecting sanity? You've come to the wrong place. o_O :S | 22:05 |
| mriedem | "Note: if the volume is attached to a server instance and the policy is on-demand, by default only admins can perform and complete the operation." | 22:05 |
| mriedem | ^ is my best attempt | 22:05 |
| smcginnis | Trust me, I've had to explain the difference between migration and retype many times. | 22:05 |
| jgriffith | mriedem the reason it's default admin only is because it moves data from one backend to another | 22:06 |
| jgriffith | and because it does a delete of the volume with zero verification | 22:06 |
| mriedem | jgriffith: migration yes, | 22:06 |
| mriedem | jgriffith: retype is admin_or_owner by default | 22:06 |
| smcginnis | mriedem: That explanation looks reasonable. It's at least better than not saying anything. | 22:06 |
| mriedem | but retype can lead to a migration | 22:06 |
| smcginnis | Unless retype is migration. | 22:06 |
| mriedem | right | 22:06 |
| mriedem | then you're f'ed | 22:06 |
| jgriffith | exactly | 22:06 |
| jgriffith | simled | 22:06 |
| jgriffith | simple | 22:06 |
| jgriffith | :) | 22:06 |
| mriedem | hence the need for something in the api-ref i think | 22:06 |
| mriedem | which i can try to wordsmith | 22:07 |
| jgriffith | You should add a note that "if you value your data you shouldn't use this" | 22:08 |
| jgriffith | most failures are silent failures, and most failures are data loss failures | 22:08 |
| mriedem | but surely enterprise users value their data | 22:08 |
| mriedem | their juicy enterprise data | 22:08 |
| mriedem | silent but deadly | 22:08 |
| mriedem | right? | 22:09 |
| jgriffith | mmmmm... enterprise data | 22:09 |
| *** dalgaaf has quit IRC | 22:09 | |
| *** dalgaaf has joined #openstack-cinder | 22:14 | |
| *** KeithMnemonic has quit IRC | 22:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/cinder master: api-ref: clarify retype docs around default policy permissions https://review.openstack.org/474797 | 22:22 |
| *** cknight has quit IRC | 22:29 | |
| jgriffith | mriedem made a minor suggestion | 22:32 |
| jgriffith | take it or leave it | 22:32 |
| *** salv-orl_ has quit IRC | 22:39 | |
| *** xyang has quit IRC | 22:50 | |
| *** cknight has joined #openstack-cinder | 23:00 | |
| *** itlinux has quit IRC | 23:00 | |
| *** Apoorva_ has joined #openstack-cinder | 23:00 | |
| *** Apoorva has quit IRC | 23:03 | |
| *** itlinux_ has joined #openstack-cinder | 23:09 | |
| *** zzzeek has joined #openstack-cinder | 23:09 | |
| *** hoonetorg has quit IRC | 23:10 | |
| *** edmondsw has quit IRC | 23:10 | |
| *** itlinux_ has quit IRC | 23:10 | |
| openstackgerrit | Merged openstack/os-brick master: Refactor iSCSI disconnect https://review.openstack.org/455392 | 23:12 |
| *** cknight has quit IRC | 23:17 | |
| *** sdague has quit IRC | 23:28 | |
| *** jwcroppe has quit IRC | 23:37 | |
| *** jwcroppe has joined #openstack-cinder | 23:38 | |
| jgriffith | smcginnis actually... what if we just changed cinder's default setting to auto? | 23:38 |
| *** jwcroppe has quit IRC | 23:42 | |
| smcginnis | jgriffith: Hmm, even easier still. Then everyone would just get it (which I think we want) unless they specify otherwise. | 23:47 |
| *** Swimingly has quit IRC | 23:47 | |
| *** Swimingly has joined #openstack-cinder | 23:48 | |
| *** Swimingly has joined #openstack-cinder | 23:48 | |
| *** stakeda has joined #openstack-cinder | 23:50 | |
| *** jdurgin has joined #openstack-cinder | 23:50 | |
| *** xyang1 has quit IRC | 23:51 | |
| jgriffith | Yeah, I have a patch ready I can post | 23:56 |
| smcginnis | Nice | 23:56 |
| jgriffith | I was thinking wait a while and get some devstack time on the other patch, but then remembered the whole point was we were double testing anyway | 23:56 |
| *** crushil has quit IRC | 23:58 | |
| *** crushil has joined #openstack-cinder | 23:58 | |
| openstackgerrit | John Griffith proposed openstack/cinder master: Set default lvm_type to auto https://review.openstack.org/474811 | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!