*** hoonetorg has joined #openstack-cinder | 00:03 | |
*** markstur has joined #openstack-cinder | 00:05 | |
*** markstur has quit IRC | 00:10 | |
*** wxy-_ has joined #openstack-cinder | 00:10 | |
*** zhangguoqing has joined #openstack-cinder | 00:11 | |
*** wxy- has quit IRC | 00:12 | |
*** iceyao has joined #openstack-cinder | 00:12 | |
openstackgerrit | Merged openstack/python-cinderclient master: Support revert to snapshot in client https://review.openstack.org/464903 | 00:13 |
---|---|---|
*** yangyape_ has quit IRC | 00:17 | |
*** iceyao has quit IRC | 00:17 | |
*** yangyapeng has joined #openstack-cinder | 00:17 | |
*** wxy-_ has quit IRC | 00:18 | |
*** mriedem has quit IRC | 00:21 | |
*** yangyapeng has quit IRC | 00:22 | |
*** mriedem has joined #openstack-cinder | 00:24 | |
*** iceyao has joined #openstack-cinder | 00:33 | |
*** wxy- has joined #openstack-cinder | 00:35 | |
*** iceyao has quit IRC | 00:37 | |
*** jwcroppe has joined #openstack-cinder | 00:38 | |
openstackgerrit | zhangdaolong proposed openstack/cinder master: Fix Log parameter https://review.openstack.org/480398 | 00:38 |
*** zhurong has joined #openstack-cinder | 00:40 | |
*** wxy- has quit IRC | 00:40 | |
*** Apoorva has quit IRC | 00:43 | |
*** markstur has joined #openstack-cinder | 00:46 | |
*** markstur has quit IRC | 00:51 | |
*** iceyao has joined #openstack-cinder | 00:54 | |
*** iceyao has quit IRC | 00:58 | |
*** stakeda has joined #openstack-cinder | 01:07 | |
*** iceyao has joined #openstack-cinder | 01:14 | |
*** Poornima has quit IRC | 01:15 | |
*** iceyao has quit IRC | 01:18 | |
*** yangyapeng has joined #openstack-cinder | 01:19 | |
*** markstur has joined #openstack-cinder | 01:21 | |
*** yangyapeng has quit IRC | 01:24 | |
*** markstur has quit IRC | 01:26 | |
*** iceyao has joined #openstack-cinder | 01:26 | |
*** yangyapeng has joined #openstack-cinder | 01:28 | |
openstackgerrit | Ngo Quoc Cuong proposed openstack/cinder master: Enable H904 check https://review.openstack.org/480439 | 01:30 |
*** yangyapeng has quit IRC | 01:33 | |
*** yangyapeng has joined #openstack-cinder | 01:34 | |
*** yangyape_ has joined #openstack-cinder | 01:39 | |
*** yangyapeng has quit IRC | 01:39 | |
*** markstur has joined #openstack-cinder | 01:43 | |
openstackgerrit | Peter Wang proposed openstack/cinder master: Add VNX replication group support https://review.openstack.org/459205 | 01:43 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-cinderclient master: Updated from global requirements https://review.openstack.org/478071 | 01:44 |
*** markstur has quit IRC | 01:48 | |
*** lhx__ has joined #openstack-cinder | 01:55 | |
*** mriedem has quit IRC | 02:10 | |
*** bkopilov has quit IRC | 02:12 | |
openstackgerrit | zhangdaolong proposed openstack/cinder master: Fix Log parameter https://review.openstack.org/480398 | 02:20 |
*** edmondsw has joined #openstack-cinder | 02:38 | |
*** edmondsw has quit IRC | 02:39 | |
*** dhinesh has joined #openstack-cinder | 02:39 | |
*** lhx__ has quit IRC | 02:45 | |
*** lhx__ has joined #openstack-cinder | 02:45 | |
*** Shunli has joined #openstack-cinder | 02:49 | |
*** dave-mccowan has quit IRC | 02:53 | |
openstackgerrit | wangxiyuan proposed openstack/python-cinderclient master: Support volume summary command https://review.openstack.org/474409 | 02:54 |
*** iceyao has quit IRC | 02:54 | |
*** mmehan has quit IRC | 03:10 | |
openstackgerrit | TommyLike proposed openstack/cinder master: Add snapshot clean worker decorator https://review.openstack.org/480816 | 03:18 |
*** markstur has joined #openstack-cinder | 03:20 | |
*** markstur has quit IRC | 03:25 | |
*** markvoelker has quit IRC | 03:26 | |
*** markvoelker has joined #openstack-cinder | 03:26 | |
*** stakeda has quit IRC | 03:28 | |
*** gkadam has joined #openstack-cinder | 03:30 | |
*** gkadam has quit IRC | 03:30 | |
*** markvoelker has quit IRC | 03:30 | |
*** gkadam has joined #openstack-cinder | 03:30 | |
*** bkopilov has joined #openstack-cinder | 03:32 | |
*** edmondsw has joined #openstack-cinder | 03:41 | |
*** iceyao has joined #openstack-cinder | 03:43 | |
openstackgerrit | xing-yang proposed openstack/cinder master: Tiramisu: Add groups param to failover_host https://review.openstack.org/477688 | 03:43 |
*** edmondsw has quit IRC | 03:46 | |
*** abhitechie has joined #openstack-cinder | 03:54 | |
*** itlinux has joined #openstack-cinder | 03:55 | |
*** markstur has joined #openstack-cinder | 03:57 | |
*** stakeda has joined #openstack-cinder | 03:57 | |
openstackgerrit | xing-yang proposed openstack/cinder master: Tiramisu: Add groups param to failover_host https://review.openstack.org/477688 | 03:59 |
*** abhitechie has quit IRC | 04:02 | |
openstackgerrit | Chason Chan proposed openstack/cinder master: Switch to openstackdocstheme https://review.openstack.org/480452 | 04:04 |
*** links has joined #openstack-cinder | 04:05 | |
openstackgerrit | Vipin Balachandran proposed openstack/cinder master: VMware: Config option for default adapter type https://review.openstack.org/465186 | 04:06 |
openstackgerrit | Vipin Balachandran proposed openstack/cinder master: VMware: Add volume adapter type extra-spec option https://review.openstack.org/466185 | 04:06 |
*** Nakato has quit IRC | 04:09 | |
*** Nakato has joined #openstack-cinder | 04:10 | |
*** abhitechie has joined #openstack-cinder | 04:13 | |
*** psachin has joined #openstack-cinder | 04:14 | |
*** adisky__ has joined #openstack-cinder | 04:35 | |
*** jwcroppe has quit IRC | 04:57 | |
*** jwcroppe has joined #openstack-cinder | 04:57 | |
*** psachin has quit IRC | 05:01 | |
*** Poornima has joined #openstack-cinder | 05:02 | |
*** Shunli has quit IRC | 05:08 | |
*** pocketprotector- has joined #openstack-cinder | 05:09 | |
*** psachin has joined #openstack-cinder | 05:10 | |
*** laurent\_ has joined #openstack-cinder | 05:12 | |
*** cargonza_ has joined #openstack-cinder | 05:13 | |
*** fmccrthy_ has joined #openstack-cinder | 05:16 | |
*** anish_ has joined #openstack-cinder | 05:17 | |
*** adisky___ has joined #openstack-cinder | 05:17 | |
*** zhonghua2 has joined #openstack-cinder | 05:20 | |
*** dosaboy_ has joined #openstack-cinder | 05:20 | |
*** pocketprotector has quit IRC | 05:22 | |
*** harlowja has quit IRC | 05:22 | |
*** laurent\ has quit IRC | 05:22 | |
*** cargonza has quit IRC | 05:22 | |
*** fmccrthy has quit IRC | 05:22 | |
*** adisky__ has quit IRC | 05:22 | |
*** anish has quit IRC | 05:22 | |
*** zhonghua has quit IRC | 05:22 | |
*** dosaboy has quit IRC | 05:22 | |
*** adisky___ is now known as adisky__ | 05:22 | |
*** markstur_ has joined #openstack-cinder | 05:22 | |
*** cargonza_ is now known as cargonza | 05:22 | |
*** fmccrthy_ is now known as fmccrthy | 05:22 | |
*** markstur has quit IRC | 05:24 | |
*** markvoelker has joined #openstack-cinder | 05:27 | |
*** edmondsw has joined #openstack-cinder | 05:29 | |
*** wanghao has joined #openstack-cinder | 05:32 | |
*** edmondsw has quit IRC | 05:33 | |
*** pgadiya has joined #openstack-cinder | 05:36 | |
*** wanghao has quit IRC | 05:39 | |
*** Poornima has quit IRC | 05:39 | |
*** Poornima has joined #openstack-cinder | 05:39 | |
*** wanghao has joined #openstack-cinder | 05:39 | |
*** Poornima has quit IRC | 05:42 | |
openstackgerrit | zhangdaolong proposed openstack/cinder master: Fix the inappropriate parameter name https://review.openstack.org/480833 | 05:43 |
*** dgonzalez has quit IRC | 05:44 | |
*** wanghao has quit IRC | 05:44 | |
openstackgerrit | Parashuram Hallur proposed openstack/cinder master: Added CG capability to volume group in CoprHD https://review.openstack.org/459610 | 05:45 |
*** wanghao has joined #openstack-cinder | 05:45 | |
*** dgonzalez has joined #openstack-cinder | 05:46 | |
*** Shunli has joined #openstack-cinder | 05:46 | |
*** wanghao has quit IRC | 05:50 | |
*** wanghao has joined #openstack-cinder | 05:51 | |
*** wanghao has quit IRC | 05:58 | |
*** itlinux has quit IRC | 05:58 | |
*** wanghao has joined #openstack-cinder | 05:59 | |
*** rcernin has joined #openstack-cinder | 05:59 | |
*** markvoelker has quit IRC | 06:00 | |
*** wanghao has quit IRC | 06:01 | |
*** markstur_ has quit IRC | 06:01 | |
*** ChubYann has quit IRC | 06:01 | |
*** wanghao has joined #openstack-cinder | 06:02 | |
*** rcernin has quit IRC | 06:04 | |
*** wanghao has quit IRC | 06:07 | |
*** dhinesh has quit IRC | 06:07 | |
*** wanghao has joined #openstack-cinder | 06:07 | |
*** wanghao has quit IRC | 06:11 | |
*** wanghao has joined #openstack-cinder | 06:11 | |
*** wanghao has quit IRC | 06:12 | |
*** wanghao has joined #openstack-cinder | 06:12 | |
*** gouthamr has quit IRC | 06:14 | |
*** rcernin has joined #openstack-cinder | 06:16 | |
*** johnthetubaguy has quit IRC | 06:21 | |
*** wanghao_ has joined #openstack-cinder | 06:21 | |
*** zhaochao has quit IRC | 06:21 | |
*** lhx__ has quit IRC | 06:21 | |
*** lhx__ has joined #openstack-cinder | 06:22 | |
*** wanghao_ has quit IRC | 06:22 | |
*** wanghao_ has joined #openstack-cinder | 06:23 | |
*** wanghao has quit IRC | 06:24 | |
*** rha has quit IRC | 06:24 | |
*** Shunli has quit IRC | 06:24 | |
*** rha has joined #openstack-cinder | 06:27 | |
*** johnthetubaguy has joined #openstack-cinder | 06:27 | |
*** wanghao_ has quit IRC | 06:27 | |
*** wanghao has joined #openstack-cinder | 06:28 | |
*** zhonghua has joined #openstack-cinder | 06:28 | |
*** zhonghua2 has quit IRC | 06:31 | |
*** wanghao has quit IRC | 06:33 | |
*** wanghao has joined #openstack-cinder | 06:33 | |
*** zhaochao has joined #openstack-cinder | 06:36 | |
*** wanghao has quit IRC | 06:37 | |
*** wanghao has joined #openstack-cinder | 06:38 | |
*** Nel1x has quit IRC | 06:41 | |
*** wanghao has quit IRC | 06:45 | |
*** wanghao has joined #openstack-cinder | 06:46 | |
openstackgerrit | junbo.li proposed openstack/cinder master: Add params for API v3 snapshot-create https://review.openstack.org/476831 | 06:49 |
*** wanghao has quit IRC | 06:50 | |
*** wanghao has joined #openstack-cinder | 06:51 | |
*** wanghao has quit IRC | 06:53 | |
*** wanghao has joined #openstack-cinder | 06:54 | |
openstackgerrit | TommyLike proposed openstack/cinder master: Add ability to extend 'in-use' volume https://review.openstack.org/454287 | 06:55 |
openstackgerrit | junbo.li proposed openstack/cinder master: Missing snapshot statuses https://review.openstack.org/480855 | 06:57 |
*** wanghao has quit IRC | 06:57 | |
*** markvoelker has joined #openstack-cinder | 06:58 | |
*** wanghao has joined #openstack-cinder | 06:58 | |
*** belmoreira has joined #openstack-cinder | 06:59 | |
*** bhagyashri_s has quit IRC | 07:00 | |
openstackgerrit | Pranali Deore proposed openstack/cinder master: Modify the length of project_id for Messages https://review.openstack.org/466700 | 07:01 |
openstackgerrit | TommyLike proposed openstack/cinder master: Add ability to extend 'in-use' volume https://review.openstack.org/454287 | 07:02 |
openstackgerrit | Pranali Deore proposed openstack/cinder master: Modify the length of project_id for Messages https://review.openstack.org/466700 | 07:03 |
*** wanghao has quit IRC | 07:03 | |
*** wanghao has joined #openstack-cinder | 07:03 | |
*** tesseract has joined #openstack-cinder | 07:04 | |
*** tesseract-RH has joined #openstack-cinder | 07:04 | |
*** tesseract has quit IRC | 07:04 | |
*** tesseract-RH has quit IRC | 07:04 | |
*** tesseract has joined #openstack-cinder | 07:05 | |
*** abhitechie has quit IRC | 07:06 | |
openstackgerrit | junbo.li proposed openstack/cinder master: Add params for API v3 snapshot-create https://review.openstack.org/476831 | 07:07 |
*** wanghao has quit IRC | 07:07 | |
*** wanghao has joined #openstack-cinder | 07:08 | |
*** abhitechie has joined #openstack-cinder | 07:09 | |
*** Poornima has joined #openstack-cinder | 07:11 | |
*** wanghao has quit IRC | 07:11 | |
*** wanghao has joined #openstack-cinder | 07:11 | |
*** KeithMnemonic2 has joined #openstack-cinder | 07:12 | |
*** sticker_ has joined #openstack-cinder | 07:12 | |
*** reveller_ has joined #openstack-cinder | 07:12 | |
*** chenying_ has joined #openstack-cinder | 07:12 | |
*** reveller has quit IRC | 07:14 | |
*** reveller_ is now known as reveller | 07:14 | |
*** wanghao has quit IRC | 07:14 | |
*** wanghao has joined #openstack-cinder | 07:15 | |
*** sticker has quit IRC | 07:15 | |
*** KeithMnemonic1 has quit IRC | 07:15 | |
*** chenying has quit IRC | 07:16 | |
*** edmondsw has joined #openstack-cinder | 07:17 | |
*** edmondsw has quit IRC | 07:21 | |
*** wanghao has quit IRC | 07:21 | |
*** wanghao has joined #openstack-cinder | 07:22 | |
*** isaacb has joined #openstack-cinder | 07:24 | |
*** Poornima has quit IRC | 07:26 | |
*** wanghao has quit IRC | 07:26 | |
*** _pewp_ has quit IRC | 07:30 | |
*** markvoelker has quit IRC | 07:30 | |
*** _pewp_ has joined #openstack-cinder | 07:33 | |
*** wanghao has joined #openstack-cinder | 07:37 | |
*** zengyingzhe_ has quit IRC | 07:41 | |
*** wanghao has quit IRC | 07:42 | |
*** lkuchlan has joined #openstack-cinder | 07:43 | |
*** e0ne has joined #openstack-cinder | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-cinder | 08:01 | |
openstackgerrit | wang yong proposed openstack/cinder master: Remove the unnecessary pv_list assgin during LVM object init https://review.openstack.org/480892 | 08:08 |
*** pgadiya has quit IRC | 08:09 | |
*** mlakat has quit IRC | 08:16 | |
wiggin15 | Hi everyone. I see there was some change to the CI that makes many vendors fail the tests all the time. | 08:16 |
wiggin15 | There are specific tests that fail consistently, e.g. test_device_tagging. | 08:16 |
wiggin15 | The error is: tempest.lib.exceptions.SSHTimeout: Connection to the 172.24.5.6 via SSH timed out. | 08:16 |
wiggin15 | Here are some of the vendors' logs: | 08:16 |
wiggin15 | Pure Storage: http://openstack-logs.purestorage.com/33/478633/4/check/PureFCDriver-tempest-dsvm-xenial-aio-multipath/fc7adbe/console.html.gz | 08:16 |
wiggin15 | Kaminario: http://54.209.116.144/88/477888/3/check/kaminario-dsvm-tempest-full-FC/b58f07e/console.html.gz | 08:16 |
wiggin15 | Veritas: http://52.42.67.99/16/480816/1/check/dsvm-veritas-access-cinder-driver/0e09d71/console.html | 08:16 |
wiggin15 | Infinidat: http://openstack-ci-logs.aws.infinidat.com/57/480657/2/check/dsvm-tempest-infinibox-fc/9dd3b77/console.html | 08:16 |
wiggin15 | Does anyone know what needs to be changed to fix this? | 08:16 |
*** vivsoni_ has quit IRC | 08:16 | |
*** vivsoni has joined #openstack-cinder | 08:19 | |
*** pgadiya has joined #openstack-cinder | 08:21 | |
*** amito-infinidat has joined #openstack-cinder | 08:22 | |
wiggin15 | I see some vendors just skipped the 4 tests that are failing... That's not such a great policy.. | 08:22 |
tommylikehu | hey geguileo , do you mind to take a look at this patch? https://review.openstack.org/#/c/480816/, thanks :) | 08:23 |
*** Poornima has joined #openstack-cinder | 08:23 | |
*** mlakat has joined #openstack-cinder | 08:24 | |
geguileo | tommylikehu: done | 08:25 |
openstackgerrit | Shunei Shiono proposed openstack/cinder master: Fix volume migration error with NEC driver https://review.openstack.org/480898 | 08:25 |
tommylikehu | geguileo: thanks | 08:26 |
geguileo | tommylikehu: And I'm wondering if we need to add unit tests to check that those decorators get called, to prevent this from happening again | 08:26 |
*** yangyapeng has joined #openstack-cinder | 08:26 | |
*** pgadiya has quit IRC | 08:27 | |
*** markvoelker has joined #openstack-cinder | 08:27 | |
*** wanghao has joined #openstack-cinder | 08:29 | |
tommylikehu | geguileo: that could be a valid option, but we have to update the testcase as well once we decorate more operations. | 08:31 |
geguileo | tommylikehu: The idea would be that each cleanable operation would check that the decorator is called (one test per cleanable) | 08:31 |
*** zhurong has quit IRC | 08:32 | |
*** wanghao has quit IRC | 08:33 | |
tommylikehu | geguileo You mean check the decorator individually in the test_create_volume/test_create_snapshot/....? | 08:33 |
*** wanghao has joined #openstack-cinder | 08:33 | |
*** walshh has quit IRC | 08:37 | |
*** pgadiya has joined #openstack-cinder | 08:39 | |
*** zhurong has joined #openstack-cinder | 08:39 | |
geguileo | tommylikehu: There are 2 options or we check in the create to check that we are creating the worker | 08:39 |
geguileo | tommylikehu: Or just a small test that just checks the decorator is called when the method is | 08:40 |
*** wanghao has quit IRC | 08:41 | |
*** wanghao has joined #openstack-cinder | 08:42 | |
tommylikehu | geguileo: , I guess you already build an example: https://github.com/openstack/cinder/blob/master/cinder/tests/unit/scheduler/test_scheduler.py#L218 | 08:46 |
openstackgerrit | jazeltq proposed openstack/cinder master: Add list-manageable for rbd https://review.openstack.org/480906 | 08:47 |
*** yangyapeng has quit IRC | 08:50 | |
*** wanghao has quit IRC | 08:52 | |
*** wanghao has joined #openstack-cinder | 08:53 | |
geguileo | tommylikehu: yup, something like that (but apparently I didn't do it for the snapshot) | 08:54 |
*** takedakn has joined #openstack-cinder | 08:57 | |
*** gkadam has quit IRC | 08:58 | |
openstackgerrit | Yu Shengzuo proposed openstack/cinder master: Fix the attribute 'replication_driver_data' is always 'false' https://review.openstack.org/479748 | 09:00 |
*** markvoelker has quit IRC | 09:02 | |
*** wanghao has quit IRC | 09:03 | |
*** wanghao has joined #openstack-cinder | 09:05 | |
*** gkadam has joined #openstack-cinder | 09:06 | |
asettle | jungleboyj: what did I do wrong? What bad stuff did I give you? | 09:10 |
*** wanghao has quit IRC | 09:13 | |
*** wanghao has joined #openstack-cinder | 09:13 | |
*** wanghao has quit IRC | 09:17 | |
*** wanghao has joined #openstack-cinder | 09:17 | |
*** kaisers_ has joined #openstack-cinder | 09:19 | |
*** wanghao has quit IRC | 09:21 | |
*** wanghao has joined #openstack-cinder | 09:22 | |
*** wanghao has quit IRC | 09:25 | |
*** wanghao has joined #openstack-cinder | 09:25 | |
openstackgerrit | Gorka Eguileor proposed openstack/python-cinderclient master: Add service cleanup command https://review.openstack.org/363007 | 09:26 |
openstackgerrit | Gorka Eguileor proposed openstack/python-cinderclient master: Add cluster support in migration and manage https://review.openstack.org/387500 | 09:26 |
openstackgerrit | Gorka Eguileor proposed openstack/python-cinderclient master: Add cluster support in manage listings https://review.openstack.org/387501 | 09:26 |
*** abhitechie has quit IRC | 09:26 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: Remove periodic_tasks method from base manager https://review.openstack.org/480659 | 09:27 |
*** abhitechie has joined #openstack-cinder | 09:27 | |
*** lhx__ has quit IRC | 09:30 | |
*** lhx__ has joined #openstack-cinder | 09:30 | |
*** wanghao has quit IRC | 09:30 | |
*** Poornima has quit IRC | 09:30 | |
*** wanghao has joined #openstack-cinder | 09:31 | |
openstackgerrit | TommyLike proposed openstack/cinder master: Add snapshot clean worker decorator https://review.openstack.org/480816 | 09:32 |
*** lhx__ has quit IRC | 09:33 | |
*** jsheeren has joined #openstack-cinder | 09:35 | |
*** wanghao has quit IRC | 09:39 | |
*** wanghao has joined #openstack-cinder | 09:39 | |
openstackgerrit | Ryan Liang proposed openstack/cinder master: VNX: wrong size of volume from image cache https://review.openstack.org/476402 | 09:40 |
*** wanghao has quit IRC | 09:43 | |
*** akapil has joined #openstack-cinder | 09:43 | |
*** gkadam has quit IRC | 09:47 | |
*** gkadam has joined #openstack-cinder | 09:48 | |
*** dalgaaf has quit IRC | 09:52 | |
*** dalgaaf has joined #openstack-cinder | 09:53 | |
*** markvoelker has joined #openstack-cinder | 09:59 | |
openstackgerrit | Yingzhe Zeng proposed openstack/cinder master: Not use admin metadata in Huawei driver anymore https://review.openstack.org/475774 | 10:01 |
*** jsheeren has quit IRC | 10:02 | |
openstackgerrit | Merged openstack/cinder master: Modify the length of project_id for Messages https://review.openstack.org/466700 | 10:04 |
openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - implement Generic Volume Group feature https://review.openstack.org/474546 | 10:06 |
*** akapil has quit IRC | 10:16 | |
openstackgerrit | jazeltq proposed openstack/cinder master: Add list-manageable for rbd https://review.openstack.org/480906 | 10:20 |
*** stakeda has quit IRC | 10:26 | |
*** markvoelker has quit IRC | 10:32 | |
*** yangyape_ has quit IRC | 10:35 | |
*** akapil has joined #openstack-cinder | 10:44 | |
*** bkopilov has quit IRC | 10:45 | |
openstackgerrit | Merged openstack/python-cinderclient master: Fix output of update command https://review.openstack.org/473472 | 10:47 |
*** abhitechie has quit IRC | 10:48 | |
*** abhitechie has joined #openstack-cinder | 10:49 | |
*** lpetrut has joined #openstack-cinder | 10:50 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: (WIP) Add cinder backup service initialize check https://review.openstack.org/446518 | 10:50 |
*** edmondsw has joined #openstack-cinder | 10:53 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: (WIP) Add cinder backup service initialize check https://review.openstack.org/446518 | 10:56 |
*** edmondsw has quit IRC | 10:58 | |
*** akapil has quit IRC | 10:59 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - bootable volume errors https://review.openstack.org/472674 | 11:00 |
*** avishay has joined #openstack-cinder | 11:01 | |
*** markvoelker has joined #openstack-cinder | 11:02 | |
*** akapil has joined #openstack-cinder | 11:04 | |
*** akapil has quit IRC | 11:15 | |
*** abhitechie has quit IRC | 11:16 | |
*** abhitechie has joined #openstack-cinder | 11:23 | |
*** zhonghua has quit IRC | 11:26 | |
*** zhonghua has joined #openstack-cinder | 11:27 | |
*** Julien-zte has joined #openstack-cinder | 11:28 | |
*** avishay has quit IRC | 11:31 | |
*** kaisers_ has quit IRC | 11:37 | |
*** Julien-zte has quit IRC | 11:42 | |
*** Julien-zte has joined #openstack-cinder | 11:45 | |
*** Julien-zte has quit IRC | 11:46 | |
openstackgerrit | zhangdaolong proposed openstack/cinder master: Fix Log parameter https://review.openstack.org/480398 | 11:49 |
*** kaisers_ has joined #openstack-cinder | 11:56 | |
*** abishop has joined #openstack-cinder | 11:58 | |
*** iceyao has quit IRC | 11:59 | |
*** iceyao has joined #openstack-cinder | 11:59 | |
*** Julien-zte has joined #openstack-cinder | 12:00 | |
*** kaisers_ has quit IRC | 12:01 | |
*** kaisers_ has joined #openstack-cinder | 12:02 | |
*** yangyapeng has joined #openstack-cinder | 12:02 | |
*** kaisers_ has quit IRC | 12:06 | |
*** Julien-zte has quit IRC | 12:08 | |
*** kaisers_ has joined #openstack-cinder | 12:08 | |
*** jmlowe has joined #openstack-cinder | 12:08 | |
*** Julien-zte has joined #openstack-cinder | 12:10 | |
openstackgerrit | Merged openstack/cinder master: Use GroupSnapshotStatus enum field https://review.openstack.org/480206 | 12:10 |
*** kaisers_ has quit IRC | 12:12 | |
*** pkoniszewski has joined #openstack-cinder | 12:14 | |
*** edmondsw has joined #openstack-cinder | 12:14 | |
pkoniszewski | hey, i have a question, is provider_location (volume object property) exposed through cinder API? I'm aware that there is provider_id exposed since 3.21 but not sure whether location is also exposed | 12:15 |
*** jmlowe has quit IRC | 12:16 | |
*** Julien-zte has quit IRC | 12:30 | |
tommylikehu | geguileo: Done, https://review.openstack.org/#/c/480816/ thanks:) | 12:31 |
*** bhagyashris has joined #openstack-cinder | 12:32 | |
geguileo | tommylikehu: I didn't mean it like you had to add it to that patch, but I'm glad you did :-) | 12:32 |
*** liverpooler has joined #openstack-cinder | 12:34 | |
*** crushil has quit IRC | 12:34 | |
*** crushil has joined #openstack-cinder | 12:35 | |
*** liverpooler has quit IRC | 12:36 | |
*** liverpooler has joined #openstack-cinder | 12:37 | |
*** chlong_ has joined #openstack-cinder | 12:37 | |
*** kaisers_ has joined #openstack-cinder | 12:39 | |
*** pgadiya has quit IRC | 12:49 | |
*** eharney has joined #openstack-cinder | 12:52 | |
*** takedakn has quit IRC | 12:53 | |
*** jmlowe has joined #openstack-cinder | 12:56 | |
*** mriedem has joined #openstack-cinder | 13:11 | |
*** reveller_ has joined #openstack-cinder | 13:12 | |
*** reveller has quit IRC | 13:14 | |
*** reveller_ is now known as reveller | 13:14 | |
*** lhx_ has joined #openstack-cinder | 13:17 | |
*** gouthamr has joined #openstack-cinder | 13:19 | |
*** lucasxu has joined #openstack-cinder | 13:19 | |
jungleboyj | asettle: I don't think you did anything wrong. It appears that there are more stringent checks happening on syntax in the Cinder doc build. So, the build is failing on those checks. Not a big deal. I am working on fixing them. | 13:21 |
*** zhurong has quit IRC | 13:22 | |
asettle | jungleboyj: okay fair enough :) let me know if you need help! | 13:25 |
*** catintheroof has joined #openstack-cinder | 13:25 | |
openstackgerrit | Alex Szarka proposed openstack/cinder master: Use more specific asserts in tests/unit tests https://review.openstack.org/476482 | 13:26 |
*** zhangguoqing has quit IRC | 13:26 | |
*** catintheroof has quit IRC | 13:36 | |
*** gkadam has quit IRC | 13:36 | |
*** zhonghua has quit IRC | 13:37 | |
*** catintheroof has joined #openstack-cinder | 13:37 | |
*** zhonghua has joined #openstack-cinder | 13:37 | |
*** abhitechie has quit IRC | 13:38 | |
jungleboyj | asettle: Will do. Doug has also been very helpful. Just need to start working through this. Going to work it over the weekend. | 13:39 |
*** kaisers_ has quit IRC | 13:41 | |
*** jwcroppe has quit IRC | 13:43 | |
*** zhonghua has quit IRC | 13:46 | |
*** zhonghua has joined #openstack-cinder | 13:47 | |
smcginnis | pkoniszewski: No, that is treated as internal driver data. | 13:50 |
*** reveller has quit IRC | 13:53 | |
*** arnewiebalck_ has joined #openstack-cinder | 14:00 | |
*** jwcroppe has joined #openstack-cinder | 14:01 | |
*** lkuchlan has quit IRC | 14:01 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-cinderclient master: Updated from global requirements https://review.openstack.org/478071 | 14:03 |
*** pkoniszewski has quit IRC | 14:05 | |
*** zhonghua has quit IRC | 14:08 | |
*** zhonghua has joined #openstack-cinder | 14:09 | |
*** xyang has joined #openstack-cinder | 14:11 | |
*** kaisers_ has joined #openstack-cinder | 14:11 | |
*** pkoniszewski has joined #openstack-cinder | 14:14 | |
*** reveller has joined #openstack-cinder | 14:16 | |
*** kaisers_ has quit IRC | 14:16 | |
*** links has quit IRC | 14:18 | |
*** laurent\_ has quit IRC | 14:41 | |
*** wxy- has joined #openstack-cinder | 14:48 | |
*** Julien-zte has joined #openstack-cinder | 14:53 | |
*** isaacb has quit IRC | 14:57 | |
*** catintheroof has quit IRC | 14:58 | |
*** arnewiebalck_ has quit IRC | 14:59 | |
openstackgerrit | Chaynika Saikia proposed openstack/cinder master: Add async error message for insufficient space for create vol from image https://review.openstack.org/481107 | 15:02 |
*** catintheroof has joined #openstack-cinder | 15:02 | |
*** markstur has joined #openstack-cinder | 15:03 | |
*** psachin has quit IRC | 15:07 | |
openstackgerrit | Chaynika Saikia proposed openstack/cinder master: Add async error message for insufficient space for create vol https://review.openstack.org/481107 | 15:07 |
*** laurent\ has joined #openstack-cinder | 15:09 | |
*** belmoreira has quit IRC | 15:11 | |
*** e0ne has quit IRC | 15:13 | |
*** rcernin has quit IRC | 15:22 | |
*** e0ne has joined #openstack-cinder | 15:28 | |
*** e0ne has quit IRC | 15:28 | |
xyang | mriedem: We have ScaleIO CI and CoprHD ScaleIO CI passing the extend_volume tests now. http://publiclogs.emc.com/scaleio/EMC_ScaleIO/1455/console.html , http://publiclogs.emc.com/vipr_ostack/EMC_CoprHD_ScaleIO/1308/console.html | 15:34 |
xyang | mriedem: Those were not on that extend in-use volume patch yet, but we are going to run on that patch too. | 15:35 |
mriedem | xyang: so can you explain how the tests are passing? tempest is configured with volume_size = 8 which i understand. the test extends the volume to 9GB and i guess the scaleio backend rounds that up to 16? but the test also asserts that the volume is reporting it's size as 9, but in reality it's 16. | 15:37 |
mriedem | which definitely seems like a bug - what is the user getting charged for quota usage? | 15:37 |
mriedem | 9 or 16? | 15:37 |
*** Julien-zte has quit IRC | 15:38 | |
*** Julien-zte has joined #openstack-cinder | 15:39 | |
xyang | mriedem: I haven't looked at the tempest test itself. I'll take a look. We probably didn't return a new size to the manager in extend, but I think we did that in create volume | 15:39 |
xyang | mriedem: it will be out of sync with the quota unfortunately | 15:39 |
smcginnis | We had some discussion on this in Austin, but I don't think we had a good way to handle this. | 15:40 |
xyang | mriedem: as we can't return quota info to manager and have it update it | 15:40 |
xyang | @smcginnis: thanks. yes | 15:40 |
openstackgerrit | Chaynika Saikia proposed openstack/cinder master: Add insufficient space async error in create vol https://review.openstack.org/481107 | 15:51 |
xyang | mriedem: so manager doesn't take any return value from extend_volume of driver so the size is not updated in the db. We did update the size for create_volume. also tempest has that config option that allow us to use 8 as the size to create volume | 15:52 |
xyang | I'll have to step away for a while | 15:53 |
*** tesseract has quit IRC | 15:54 | |
mriedem | xyang: sure, yes, tempest creates the volume using the config, so the volume is created at 8gb and then extended as volume['size'] + 1 so it would be 9gb, but the backend volume driver rounds that up to 16gb | 15:55 |
*** itlinux has joined #openstack-cinder | 15:55 | |
mriedem | so it seems that it's a bug in cinder that the driver.extend_volume doesn't return the actual size and the volume manager would update the volume record in the db with the real value | 15:55 |
mriedem | for quotas and such | 15:55 |
xyang | mriedem: yes, but the size is not updated because there's no way for driver to tell the manager about that currently. I'll be back | 15:56 |
mriedem | e.g. what if i have an 8gb volume and extend to 9gb (really 16) and then because the api says it's at 9gb, i try to extend to 10gb? does the driver fail, or just ignore it since it's already 16? | 15:56 |
*** Apoorva has joined #openstack-cinder | 15:56 | |
mriedem | smcginnis: ^ i guess i should just report a bug? | 15:56 |
mriedem | even though i don't really have any logs or anything | 15:56 |
*** Apoorva has quit IRC | 15:56 | |
smcginnis | mriedem: It's kind of a known issue that users of that storage need to be aware of if they choose to use it for their OpenStack storage. | 15:57 |
smcginnis | mriedem: Really nothing we can do on the Cinder side, and short of rewriting how their storage works, not much can be done on the ScaleIO side either. | 15:57 |
*** Apoorva has joined #openstack-cinder | 15:57 | |
smcginnis | I do think if an extend is requested, it will just skip if the real space is already large enough. Not 100% though. | 15:58 |
*** Nel1x has joined #openstack-cinder | 15:58 | |
smcginnis | Operators probably just need to keep those limitations in mind when setting quotas. | 15:58 |
*** Apoorva has quit IRC | 15:58 | |
mriedem | the volume driver can't report the real size back to the volume manager and have the volume manager update the volume.size in the db? | 15:59 |
smcginnis | mriedem: No, there's too many places where that could cause problems. | 15:59 |
mriedem | huh | 15:59 |
mriedem | i'll take your word for that | 16:00 |
mriedem | let's just put * all over the api ref | 16:00 |
mriedem | * Except for ScaleIO | 16:00 |
*** Apoorva has joined #openstack-cinder | 16:00 | |
smcginnis | Can't find the session notes from Autin. | 16:00 |
smcginnis | I'm sure the discussion was captured in our Youtube videos, but I don't care enough to track that down. | 16:00 |
smcginnis | We didn't really label/organize them well enough to find topics like that. | 16:01 |
mriedem | i plan on updating the api ref a bit after this is done for extending an attached volume, | 16:04 |
mriedem | to put some words in there about async post conditions, | 16:04 |
mriedem | so the user can know what to monitor on the compute side, basically what i'm doing in the tempest test | 16:04 |
smcginnis | +1 | 16:04 |
mriedem | that reminds me, the cinder patch is missing any updates to the api-ref | 16:05 |
smcginnis | bah! | 16:05 |
mriedem | i can do that quick | 16:06 |
*** rcernin has joined #openstack-cinder | 16:21 | |
*** dhinesh has joined #openstack-cinder | 16:21 | |
*** dhinesh has quit IRC | 16:25 | |
*** lhx_ has quit IRC | 16:25 | |
*** eharney has quit IRC | 16:28 | |
*** eharney has joined #openstack-cinder | 16:28 | |
openstackgerrit | Matt Riedemann proposed openstack/cinder master: Add ability to extend 'in-use' volume https://review.openstack.org/454287 | 16:30 |
mriedem | xyang: jgriffith: smcginnis: ^ see how the api-ref changes in there float your boat | 16:30 |
mriedem | i could also separate some of that into another patch if needed, i.e. the note about the scaleio backend size limitation during extend, which is an existing limitation | 16:31 |
*** felipemonteiro has joined #openstack-cinder | 16:36 | |
*** ChubYann has joined #openstack-cinder | 16:36 | |
*** kaisers_ has joined #openstack-cinder | 16:42 | |
*** kaisers_ has quit IRC | 16:46 | |
*** dhinesh has joined #openstack-cinder | 17:10 | |
*** harlowja has joined #openstack-cinder | 17:13 | |
*** markstur has quit IRC | 17:14 | |
*** zzzeek has quit IRC | 17:14 | |
*** markstur has joined #openstack-cinder | 17:14 | |
*** lpetrut has quit IRC | 17:16 | |
*** jmlowe has quit IRC | 17:23 | |
*** zzzeek has joined #openstack-cinder | 17:33 | |
*** jwcroppe has quit IRC | 17:33 | |
*** zzzeek has quit IRC | 17:37 | |
*** zzzeek has joined #openstack-cinder | 17:41 | |
*** xyang has quit IRC | 17:43 | |
*** itlinux has quit IRC | 17:43 | |
*** xyang has joined #openstack-cinder | 17:44 | |
openstackgerrit | Merged openstack/cinder master: Fix wrong usage of rbd.list_snaps return value https://review.openstack.org/455786 | 17:44 |
openstackgerrit | Chaynika Saikia proposed openstack/python-cinderclient master: Add cinder create --poll https://review.openstack.org/475919 | 17:53 |
*** zzzeek has quit IRC | 17:53 | |
*** iceyao has quit IRC | 17:57 | |
*** jwcroppe has joined #openstack-cinder | 17:59 | |
*** zzzeek has joined #openstack-cinder | 18:00 | |
openstackgerrit | Merged openstack/cinder master: Fix the inappropriate parameter name https://review.openstack.org/480833 | 18:00 |
openstackgerrit | xing-yang proposed openstack/python-cinderclient master: Tiramisu: replication group support https://review.openstack.org/352229 | 18:01 |
*** dave-mccowan has joined #openstack-cinder | 18:03 | |
*** jwcroppe has quit IRC | 18:04 | |
*** jwcroppe has joined #openstack-cinder | 18:07 | |
*** zzzeek_ has joined #openstack-cinder | 18:08 | |
*** zzzeek has quit IRC | 18:09 | |
*** lpetrut has joined #openstack-cinder | 18:20 | |
*** lpetrut has quit IRC | 18:22 | |
*** kaisers_ has joined #openstack-cinder | 18:28 | |
*** lpetrut has joined #openstack-cinder | 18:29 | |
*** kaisers_ has quit IRC | 18:32 | |
openstackgerrit | Merged openstack/python-brick-cinderclient-ext master: Actually do the detach with the new attach/detach flow https://review.openstack.org/479373 | 18:37 |
*** ChubYann has quit IRC | 18:37 | |
*** rcernin has quit IRC | 18:38 | |
*** kaisers_ has joined #openstack-cinder | 18:38 | |
openstackgerrit | xing-yang proposed openstack/cinder master: Tiramisu: Add groups param to failover_host https://review.openstack.org/477688 | 18:42 |
*** xyang has quit IRC | 18:44 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Fix v1 API api-ref link https://review.openstack.org/481185 | 18:44 |
smcginnis | Pretty trivial one. | 18:44 |
*** xyang has joined #openstack-cinder | 18:45 | |
*** xyang has quit IRC | 18:46 | |
*** xyang has joined #openstack-cinder | 18:48 | |
*** xyang has quit IRC | 18:49 | |
*** ChubYann has joined #openstack-cinder | 18:51 | |
*** itlinux has joined #openstack-cinder | 18:58 | |
*** jmlowe has joined #openstack-cinder | 19:03 | |
*** shaner has quit IRC | 19:11 | |
*** pcaruana has quit IRC | 19:12 | |
*** adisky__ has quit IRC | 19:14 | |
*** markstur has quit IRC | 19:27 | |
*** prometheanfire has joined #openstack-cinder | 19:31 | |
prometheanfire | os-brick dev'd on here or in -nova? | 19:31 |
prometheanfire | looks like the latest release is failing dsvm-neutron-full http://logs.openstack.org/29/481129/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/acbb146/logs/testr_results.html.gz | 19:31 |
smcginnis | prometheanfire: Here | 19:31 |
prometheanfire | https://review.openstack.org/481129 | 19:32 |
*** shaner has joined #openstack-cinder | 19:32 | |
*** KeithMnemonic2 has quit IRC | 19:35 | |
prometheanfire | recheck had the same problems | 19:36 |
*** KeithMnemonic has joined #openstack-cinder | 19:36 | |
smcginnis | prometheanfire: Yeah, hadn't had a chance to dig into that yet. | 19:36 |
prometheanfire | k, just notifying | 19:36 |
smcginnis | prometheanfire: Saw there were instance build failures. | 19:36 |
smcginnis | But looks like it might actually be related since they were boot from volume tests. | 19:36 |
prometheanfire | ya, doesn't look totally related | 19:36 |
prometheanfire | exactly | 19:36 |
smcginnis | I'll just blame nova for now. :) | 19:37 |
prometheanfire | sure | 19:37 |
prometheanfire | while I have you, you happen to know of any native zfsonlinux driver in dev? | 19:37 |
prometheanfire | (not iscsi nexenta or whatever) | 19:38 |
smcginnis | prometheanfire: No, I haven't heard of any yet. | 19:38 |
smcginnis | Right | 19:38 |
smcginnis | prometheanfire: No, I think the last time anyone's mentioned it was I think when you brought it up last. | 19:38 |
prometheanfire | if I ever have time... | 19:38 |
prometheanfire | yep | 19:38 |
smcginnis | :) | 19:38 |
prometheanfire | should be doable by modifying the lvm driver (as a base) | 19:39 |
smcginnis | I'm guessing since no vendors need it, no one is able to get time to work on one. | 19:39 |
prometheanfire | ya | 19:39 |
smcginnis | prometheanfire: Yeah, I would think it should be a fairly minor modification. | 19:39 |
prometheanfire | also, since it's an open source project that it'd be supporting hard to get people to pay | 19:39 |
eharney | curious failure in that n-cpu log: "VolumeDeviceNotFound: Volume device not found at ." | 19:39 |
smcginnis | eharney: Looks like it could be something with os-brick: http://logs.openstack.org/29/481129/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/acbb146/logs/screen-n-cpu.txt.gz?#_Jul_06_19_02_11_419239 | 19:40 |
patrickeast | probably a none/empty string in there | 19:40 |
*** markstur has joined #openstack-cinder | 19:40 | |
patrickeast | a bunch of those os-brick logs would make more sense if we put quotes around the devices and paths when logging XD | 19:40 |
smcginnis | VolumeDeviceNotFound(device='') | 19:40 |
*** xyang has joined #openstack-cinder | 19:41 | |
prometheanfire | smcginnis: other projects should not be using that version of os-brick yet | 19:41 |
smcginnis | prometheanfire: Right, should still be capped for everyone else. | 19:42 |
smcginnis | Most likely from something here: https://github.com/openstack/os-brick/commit/56c8665d3d342ce90f5d9433966c0f244063b4c1 | 19:44 |
*** xyang1 has joined #openstack-cinder | 19:49 | |
*** iceyao has joined #openstack-cinder | 19:55 | |
*** lbragstad has quit IRC | 19:58 | |
*** diablo_rojo has joined #openstack-cinder | 19:58 | |
*** xyang has quit IRC | 19:59 | |
*** xyang has joined #openstack-cinder | 19:59 | |
*** iceyao has quit IRC | 19:59 | |
*** xyang has quit IRC | 20:01 | |
*** lbragstad has joined #openstack-cinder | 20:03 | |
*** kaisers_ has quit IRC | 20:10 | |
*** kaisers_ has joined #openstack-cinder | 20:11 | |
*** felipemonteiro has quit IRC | 20:14 | |
*** liverpooler has quit IRC | 20:15 | |
*** iceyao has joined #openstack-cinder | 20:16 | |
*** kaisers_ has quit IRC | 20:16 | |
*** iceyao has quit IRC | 20:20 | |
*** sdake has joined #openstack-cinder | 20:26 | |
sdake | hey folks | 20:26 |
sdake | quick question | 20:26 |
sdake | there is "targetcli and "iscsi-target-utils" | 20:27 |
sdake | in kolla we are using iscsi-target-utils for lvm +cinder integration | 20:27 |
sdake | rdo docs recommend targetcli, although it is unclear if either solution has been tested recently as most people use ceph | 20:27 |
sdake | nonetheless we want to get it right | 20:27 |
sdake | should we be setting up using targetcli or iscsi-target-utils | 20:28 |
eharney | targetcli is for the LIO target used with the LVM driver on el7 and optionally Ubuntu | 20:28 |
eharney | scsi-target-utils is the default in Cinder, the userspace iSCSI target | 20:28 |
sdake | hi eharney lon time no talk | 20:29 |
sdake | I am noto really sure what a LIO is | 20:29 |
eharney | an iSCSI target in the kernel | 20:29 |
sdake | and which one is preferrable | 20:29 |
sdake | i assume suerspace iscsi target is preferrable | 20:29 |
sdake | i am petty sure olla uses iscsi-target-utils with LVM | 20:30 |
openstackgerrit | John Griffith proposed openstack/cinder master: Update attachment_delete for multiple attachments https://review.openstack.org/472796 | 20:30 |
jgriffith | ildikov stvnoyes1 ^^. let me know what you think | 20:30 |
eharney | sdake: there are changes proposed around that: https://review.openstack.org/#/c/474999/ | 20:30 |
sdake | eharney interesting thanks | 20:31 |
sdake | eharney ++ | 20:31 |
eharney | sdake: this was just fixed up a bit in devstack too, to remove the scsi-target-utils dep for el7 platforms | 20:31 |
openstackgerrit | Merged openstack/cinder master: Fix v1 API api-ref link https://review.openstack.org/481185 | 20:34 |
*** iceyao has joined #openstack-cinder | 20:40 | |
*** iceyao has quit IRC | 20:44 | |
patrickeast | jgriffith: hey so wrt that change and the "shared_connections" return value thing | 20:45 |
sdake | eharney [13:43:19] <sdake>sbezverk is iscsi-lvm gated in kola-kuberntes | 20:45 |
sdake | [13:44:08] <sbezverk>sdake: if scsi-target-utils is removed then we will not have tgtd and tgtdadm binaries and it will break lvm | 20:45 |
patrickeast | jgriffith: do we actually need to be doing something higher up with it too? looks like we return it from the c-vol side of the rpcapi but don't do anything with it in c-api | 20:45 |
sdake | eharney woud you ind coming over to openstack-kolla for a moment | 20:46 |
patrickeast | jgriffith: if i'm understanding correctly, its just an indicator of whether or not remove export should have been called, right? | 20:46 |
sdake | eharney i didn't implement cinder, I don't understand it - the fella that did is in chnnel now | 20:46 |
patrickeast | s/have been/be/ | 20:46 |
jgriffith | patrickeast sorry... catching up | 20:48 |
patrickeast | jgriffith: no worries, code isn't goin anywhere :D | 20:48 |
jgriffith | patrickeast ideally the only place it matters is remove_export | 20:49 |
patrickeast | i don't think my question changes that particular bug fix, more like a higher level though about the rpcapi behavior | 20:49 |
patrickeast | thought* | 20:49 |
patrickeast | jgriffith: cool, yea so then should we even have a return value for attachment_delete or whatever its called? | 20:50 |
patrickeast | since we just ignore it everywhere? | 20:50 |
jgriffith | You mean providing the info to the caller? | 20:50 |
jgriffith | yeah :) | 20:50 |
patrickeast | jgriffith: i think that was also part of the confusion (at least that i had) with what that return value was for | 20:50 |
patrickeast | since iirc we discussed piping it back up to the actual api caller to inform them about what to do | 20:50 |
jgriffith | Yeah, and the more I look at it and mess with this stuff the more I think I don't want to return that level of info | 20:51 |
jgriffith | patrickeast yeah.. you're right | 20:51 |
jgriffith | we did talk about that and have that idea | 20:51 |
jgriffith | but now I think that's kinda dumb | 20:51 |
jgriffith | if you're not able to figure out what to do with connections on your own then I probably can't help you :) | 20:52 |
patrickeast | yep | 20:52 |
jgriffith | but I'm sure I'm the only one that believes that | 20:52 |
patrickeast | since we do it in a single shot it doesn't provide anything useful | 20:52 |
jgriffith | so I'd like to actually remove that nonsense from the rpc response altogether | 20:52 |
jgriffith | patrickeast right!! | 20:52 |
patrickeast | +1 | 20:52 |
jgriffith | It was a good idea at the time, but now it's just a source for trouble/confusion | 20:53 |
jgriffith | and bugs | 20:53 |
patrickeast | yep yep, simplifies the driver details a bit too | 20:53 |
patrickeast | the only trick that i think we need is something to hint about the way consumers (nova, whatever) should handle the attach/detach workflow with that like well known flag in the connection info | 20:54 |
jgriffith | patrickeast not completely sure I follow? | 20:55 |
patrickeast | so like the uh shared connection thing thats not a shared cinder volume attachment | 20:55 |
patrickeast | hints for like when nova should call os-brick, lock, etc | 20:55 |
jgriffith | oh.. those!!! :) | 20:55 |
patrickeast | :D | 20:56 |
jgriffith | honestly, I wonder if it's better to just have an API call explicitly for that? | 20:56 |
jgriffith | as much as I rant about our API being a bloated dead racoon on the side of the highway | 20:56 |
patrickeast | we could, but imo its just another trait of the attachment | 20:56 |
patrickeast | not so much more different than saying its multipath or FC or whatever | 20:56 |
jgriffith | patrickeast so stuff it in the attachment record? | 20:56 |
patrickeast | in my mind | 20:56 |
patrickeast | yep | 20:56 |
*** butt is now known as hemna | 20:57 | |
jgriffith | oh.. yeah, I see what you're saying now | 20:57 |
jgriffith | that makes a lot of sense to me | 20:57 |
jgriffith | a lot more sense than some of the other shenanigans | 20:57 |
hemna | if you have the attachment_id, can't we just ask for the connection_info for that attachment_id ? | 20:57 |
*** lucasxu has quit IRC | 20:57 | |
patrickeast | hemna: yep, exactly | 20:57 |
jgriffith | hemna yes | 20:57 |
hemna | ok cool | 20:57 |
hemna | :) | 20:57 |
patrickeast | now that we've got the tools for it, should be easy | 20:57 |
hemna | that's one of the reasons I wanted all attachments associated with it's own id | 20:57 |
jgriffith | yeah | 20:57 |
hemna | makes things much easier and straight forward IMHO | 20:58 |
jgriffith | I think we should work that in going forward | 20:58 |
jgriffith | but someobody like you (looking at patrickeast ) needs to take a stab at it since your driver actually utilizes it | 20:58 |
jgriffith | :) | 20:58 |
patrickeast | the only weird part is it breaks the model of nova not really peeking into that property bag of junk we shove into os-brick api's | 20:58 |
jgriffith | patrickeast HA! | 20:58 |
patrickeast | where like today all those things hint os-brick as to what to do, and it looks for things to key off of for its behavior | 20:59 |
jgriffith | have you seen the 84 revision patch set to Nova? | 20:59 |
jgriffith | It peeks into the box quite a bit :) | 20:59 |
patrickeast | you mean the lun thing? | 20:59 |
*** iceyao has joined #openstack-cinder | 20:59 | |
patrickeast | or are there other fun things? :D | 20:59 |
jgriffith | lun, multi-attach and a few other things | 20:59 |
hemna | sadness | 20:59 |
jgriffith | there are things it cares about and checks outside of os-brick | 20:59 |
jgriffith | meh, I don't know; it's kinda important for KVM to know some of those things | 21:00 |
jgriffith | blocksize | 21:00 |
jgriffith | trim :) | 21:00 |
patrickeast | yea, good news for us then | 21:00 |
patrickeast | oh right | 21:00 |
patrickeast | i already broke this with the trim thing | 21:00 |
jgriffith | patrickeast :) | 21:00 |
patrickeast | cool, well then its a trend | 21:00 |
jgriffith | so yeah, I think it's perfectly reasonable | 21:00 |
jgriffith | haha! | 21:00 |
jgriffith | good trend / bad trend | 21:00 |
patrickeast | time will tell ;) | 21:01 |
patrickeast | so i am happy to help, but i don't really know where all in there is the right place to look for it | 21:01 |
*** jmlowe has quit IRC | 21:01 | |
ildikov | it's actually 86 | 21:02 |
ildikov | it only looks into the target_lun to tdo the cast as the os-brick release wasn't really a big success | 21:03 |
ildikov | and yes, Nova will need to know whether or not to call os-brick and do locks for multi-attach | 21:03 |
*** iceyao has quit IRC | 21:03 | |
* ildikov is catching up a bit late, sorry :) | 21:03 | |
ildikov | so there has to be some sort of an info that Nova or any other consumer can use to deal with the shared connections madness | 21:05 |
*** dhinesh has quit IRC | 21:09 | |
*** jmlowe has joined #openstack-cinder | 21:09 | |
jgriffith | eharney so if epel drops target do you guys have to worry about upgrades or have you had LIO set as default long enough that it's not a concern? | 21:11 |
jgriffith | s/target/tgt/ | 21:11 |
*** dhinesh has joined #openstack-cinder | 21:11 | |
eharney | jgriffith: well we never supported scsi-target-utils in our product. So unless it snuck in somewhere in some container stuff I don't know about (i.e. any of it), I don't think we have a problem there | 21:12 |
jgriffith | eharney OH! Haha, well that works out pretty well then :) | 21:12 |
openstackgerrit | xing-yang proposed openstack/cinder master: Tiramisu: Add groups param to failover_host https://review.openstack.org/477688 | 21:14 |
*** jmlowe has quit IRC | 21:25 | |
*** abishop has quit IRC | 21:25 | |
*** lpetrut has quit IRC | 21:30 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - QoS, replacing SMI-S with REST https://review.openstack.org/456759 | 21:32 |
*** itlinux has quit IRC | 21:40 | |
*** itlinux has joined #openstack-cinder | 21:41 | |
*** jmlowe has joined #openstack-cinder | 21:42 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX driver - Compression, replacing SMI-S with REST https://review.openstack.org/460191 | 21:46 |
*** xyang1 has quit IRC | 21:52 | |
*** catintheroof has quit IRC | 21:55 | |
*** dave-mccowan has quit IRC | 22:05 | |
*** felipemonteiro has joined #openstack-cinder | 22:07 | |
*** zhengyin has quit IRC | 22:09 | |
eharney | jgriffith: could you give https://review.openstack.org/#/c/479295/ a look? | 22:10 |
openstackgerrit | Octave Orgeron proposed openstack/cinder master: Enables MySQL Cluster Support for Cinder https://review.openstack.org/433372 | 22:13 |
sdake | eharney jgriffith thanks for joining openstack-kolla and helping us along | 22:22 |
*** edmondsw has quit IRC | 22:23 | |
*** edmondsw has joined #openstack-cinder | 22:28 | |
*** edmondsw has quit IRC | 22:32 | |
*** zhengyin has joined #openstack-cinder | 22:38 | |
*** sbezverk has joined #openstack-cinder | 22:53 | |
sbezverk | jgriffith: ping | 22:53 |
*** edmondsw has joined #openstack-cinder | 22:56 | |
*** eharney has quit IRC | 22:58 | |
*** edmondsw has quit IRC | 23:00 | |
*** lbragstad has quit IRC | 23:03 | |
*** iceyao has joined #openstack-cinder | 23:08 | |
*** iceyao has quit IRC | 23:13 | |
*** takedakn has joined #openstack-cinder | 23:21 | |
*** iceyao has joined #openstack-cinder | 23:28 | |
*** iceyao has quit IRC | 23:33 | |
*** takedakn has quit IRC | 23:35 | |
*** lbragstad has joined #openstack-cinder | 23:36 | |
*** Julien-zte has quit IRC | 23:36 | |
*** takedakn has joined #openstack-cinder | 23:37 | |
*** stakeda has joined #openstack-cinder | 23:38 | |
*** itlinux has quit IRC | 23:43 | |
-openstackstatus- NOTICE: nb03.openstack.org has been cleaned up and rebooted, and should return to building rotation | 23:43 | |
*** takedakn has quit IRC | 23:46 | |
*** tsuzuki has joined #openstack-cinder | 23:46 | |
*** takedakn has joined #openstack-cinder | 23:47 | |
*** takedakn has quit IRC | 23:47 | |
*** iceyao has joined #openstack-cinder | 23:49 | |
*** iceyao has quit IRC | 23:54 | |
*** prometheanfire has left #openstack-cinder | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!