Wednesday, 2017-08-30

*** wN_ has quit IRC00:01
*** wN_ has joined #openstack-cinder00:02
*** yangyapeng has joined #openstack-cinder00:05
*** edmondsw has joined #openstack-cinder00:08
*** yangyapeng has quit IRC00:10
*** edmondsw has quit IRC00:12
*** edmondsw has joined #openstack-cinder00:15
*** edmondsw_ has joined #openstack-cinder00:17
*** edmondsw has quit IRC00:19
*** edmondsw_ has quit IRC00:21
*** wanghao has joined #openstack-cinder00:39
*** edmondsw has joined #openstack-cinder00:40
*** lbragstad has joined #openstack-cinder00:44
*** edmondsw has quit IRC00:44
*** zhurong has joined #openstack-cinder00:45
*** Shunli has joined #openstack-cinder00:46
openstackgerritDou Rui Yuan proposed openstack/cinder master: Correct contributor doc information  https://review.openstack.org/49512301:13
*** wanghao_ has joined #openstack-cinder01:17
*** yangyapeng has joined #openstack-cinder01:20
*** yangyapeng has quit IRC01:20
*** yangyapeng has joined #openstack-cinder01:20
*** wanghao has quit IRC01:21
*** jmlowe has quit IRC01:21
*** sticker has joined #openstack-cinder01:21
*** jmlowe has joined #openstack-cinder01:21
*** crushil has quit IRC01:22
*** jmlowe has quit IRC01:24
*** yangyapeng has quit IRC01:24
*** jmlowe has joined #openstack-cinder01:25
*** zhaochao has joined #openstack-cinder01:26
*** edmondsw has joined #openstack-cinder01:29
*** edmondsw has quit IRC01:33
*** itlinux has joined #openstack-cinder01:34
*** edmondsw has joined #openstack-cinder01:42
*** diablo_rojo has quit IRC01:45
*** edmondsw has quit IRC01:46
*** lhx__ has joined #openstack-cinder01:49
*** tbarron|errand is now known as tbarron01:53
openstackgerritJay Bryant proposed openstack/cinder master: [Doc] Handle Sphinx warnings as errors  https://review.openstack.org/49868601:55
*** edmondsw has joined #openstack-cinder01:56
*** abhishek has joined #openstack-cinder01:57
*** gcb has joined #openstack-cinder01:58
*** kukacz has quit IRC02:00
*** edmondsw has quit IRC02:00
openstackgerritTommyLike proposed openstack/cinder master: Don't lock whole project's resource when reserve/commit  https://review.openstack.org/49828302:01
*** kukacz has joined #openstack-cinder02:01
*** lbragstad has quit IRC02:07
*** abhishek has quit IRC02:10
*** sncder has joined #openstack-cinder02:11
*** bkopilov has quit IRC02:12
*** edmondsw has joined #openstack-cinder02:20
*** edmondsw has quit IRC02:23
*** edmondsw has joined #openstack-cinder02:24
openstackgerritMerged openstack/cinder master: api-ref: Add backup import and export  https://review.openstack.org/49769302:25
*** salv-orlando has joined #openstack-cinder02:26
*** baojg has joined #openstack-cinder02:27
*** edmondsw has quit IRC02:28
*** yangyapeng has joined #openstack-cinder02:29
*** edmondsw has joined #openstack-cinder02:31
*** baojg has quit IRC02:31
*** edmondsw has quit IRC02:35
openstackgerritMerged openstack/cinder master: Convert lenovo driver to use distributed lock manager  https://review.openstack.org/47906902:39
openstackgerritMerged openstack/cinder master: Dell SC: Fix python 3.6 'async' keyword warning  https://review.openstack.org/48271302:39
*** sapd_ has joined #openstack-cinder02:45
*** gouthamr has quit IRC02:46
*** mriedem has quit IRC03:03
*** abhi89 has joined #openstack-cinder03:10
openstackgerrityixuan zhang proposed openstack/cinder master: Storwize: add hyperswap volume support  https://review.openstack.org/49241403:13
*** chlong has quit IRC03:21
*** yangyapeng has quit IRC03:23
abhi89tommylikehu, geguileo : please review https://review.openstack.org/#/c/495663/03:23
*** yangyapeng has joined #openstack-cinder03:24
*** jmlowe has quit IRC03:24
*** jmlowe has joined #openstack-cinder03:24
*** wanghao_ has quit IRC03:32
*** bkopilov has joined #openstack-cinder03:32
*** wanghao has joined #openstack-cinder03:33
*** gkadam_ has joined #openstack-cinder03:33
*** lbragstad has joined #openstack-cinder03:37
*** dave-mccowan has quit IRC03:40
*** links has joined #openstack-cinder03:40
*** stakeda has quit IRC03:58
*** lkuchlan has joined #openstack-cinder03:59
*** lbragstad has quit IRC04:09
*** chhavi has joined #openstack-cinder04:15
*** diablo_rojo has joined #openstack-cinder04:29
*** edmondsw has joined #openstack-cinder04:32
*** edmondsw has quit IRC04:36
*** diablo_rojo has quit IRC04:43
*** gnufied has quit IRC04:44
*** adisky__ has joined #openstack-cinder04:45
*** jmlowe has quit IRC04:47
*** zsli_ has joined #openstack-cinder04:56
*** wanghao_ has joined #openstack-cinder04:57
*** wanghao has quit IRC04:58
*** Shunli has quit IRC04:58
*** salv-orlando has quit IRC04:58
*** armax has quit IRC05:01
*** abhinavtechie has joined #openstack-cinder05:08
*** gcb has quit IRC05:10
*** abhitechie has quit IRC05:11
*** gcb has joined #openstack-cinder05:11
*** chhavi has quit IRC05:12
*** chhavi has joined #openstack-cinder05:12
*** abhi89 has quit IRC05:13
*** abhi89 has joined #openstack-cinder05:13
*** AlhatNeha has quit IRC05:13
*** AlhatNeha has joined #openstack-cinder05:14
*** stakeda has joined #openstack-cinder05:16
*** lpetrut has joined #openstack-cinder05:22
*** salv-orlando has joined #openstack-cinder05:23
*** zsli_ has quit IRC05:27
*** zengyingzhe__ has joined #openstack-cinder05:34
*** lkuchlan has quit IRC05:36
*** zengyingzhe_ has quit IRC05:37
*** chenying has quit IRC05:37
*** chenying has joined #openstack-cinder05:37
*** zengyingzhe has joined #openstack-cinder05:37
*** zengyingzhe__ has quit IRC05:39
*** zengyingzhe_ has joined #openstack-cinder05:43
*** zengyingzhe has quit IRC05:46
*** pgadiya has joined #openstack-cinder05:47
*** rested has joined #openstack-cinder05:53
restedhi, anyone here who managed to make cinder-backup work with ceph on newton?05:54
*** wanghao has joined #openstack-cinder05:59
*** wanghao_ has quit IRC06:02
*** lkuchlan has joined #openstack-cinder06:14
*** sapd_ has quit IRC06:15
*** abhinavtechie has quit IRC06:19
niraj_singhgcb: hi06:20
gcbniraj_singh: hi06:20
niraj_singhgcb: i am a new contributor, i just wanted to ask about Accept header validation in cinder.06:21
*** josecastroleon has quit IRC06:21
*** abhitechie has joined #openstack-cinder06:22
*** edmondsw has joined #openstack-cinder06:32
*** wanghao has quit IRC06:35
*** wanghao has joined #openstack-cinder06:36
*** lpetrut has quit IRC06:36
*** edmondsw has quit IRC06:37
*** alexchadin has joined #openstack-cinder06:41
*** rcernin has joined #openstack-cinder06:42
*** pcaruana has joined #openstack-cinder06:43
alexchadingreetings, cinder team. with whom can I talk to discuss proposal to implement new volume driver?06:48
*** itlinux has quit IRC06:51
*** edmondsw has joined #openstack-cinder06:55
*** lpetrut has joined #openstack-cinder06:56
gcbniraj_singh: welcome , what's question ?06:58
niraj_singhgcb: if we pass Accept header as anything except xml and jason then what should it returns? 200 OK or any exception? On current master it gives 200 OK if we pass anything in Accept header and return response in jason.07:01
*** hoonetorg has quit IRC07:05
*** lpetrut has quit IRC07:07
*** david-lyle has quit IRC07:08
niraj_singhgcb:sorry for spelling mistake its json.07:08
*** david-lyle has joined #openstack-cinder07:08
*** _alastor__ has quit IRC07:09
*** jamielennox has quit IRC07:09
*** gus has quit IRC07:09
*** gus has joined #openstack-cinder07:10
*** _alastor__ has joined #openstack-cinder07:11
gcbI'm not sure,  in my opinion  an exception should be raised,   this is for Cinder,  I suggest  sent out a email to openstack-dev@lists.openstack.org to ask for other's input07:12
*** jamielennox has joined #openstack-cinder07:14
niraj_singhgcb: ok thank you for your inputs.07:15
gcbniraj_singh: you're welcome07:16
*** tesseract has joined #openstack-cinder07:19
tommylikehualexchadin:  Have you read this wiki before? https://wiki.openstack.org/wiki/Cinder/how-to-contribute-a-driver#How_To_Contribute_a_driver_to_Cinder07:20
*** hoonetorg has joined #openstack-cinder07:21
*** zengyingzhe__ has joined #openstack-cinder07:21
*** zengyingzhe_ has quit IRC07:25
alexchadintommylikehu: hi07:27
alexchadintommylikehu: haven't yet07:27
tommylikehualexchadin: hope it works for you, and you can talk to jungleboyj  and smcginnis  later for more details.07:30
alexchadintommylikehu: thanks a lot07:31
alexchadintommylikehu: don't you know, have someone tried to implement OCFS2 driver for Cinder?07:31
alexchadintommylikehu: we have implemented this one in our company and probably want to make it open07:31
tommylikehualexchadin:  no idea,  but this is what we have in cinder now: https://wiki.openstack.org/wiki/CinderSupportMatrix07:34
alexchadintommylikehu: yeap, I've seen it07:34
*** josecastroleon has joined #openstack-cinder07:36
*** edmondsw has quit IRC07:36
*** josecastroleon has quit IRC07:41
*** josecastroleon has joined #openstack-cinder07:59
*** lpetrut has joined #openstack-cinder08:09
*** wanghao_ has joined #openstack-cinder08:14
*** wanghao_ has quit IRC08:15
*** wanghao has quit IRC08:15
*** wanghao has joined #openstack-cinder08:16
*** abhitechie has quit IRC08:24
*** baojg has joined #openstack-cinder08:34
*** baojg has quit IRC08:39
*** psachin has joined #openstack-cinder08:44
abhi89tommylikehu: can you please review https://review.openstack.org/#/c/495663/08:45
*** salv-orlando has quit IRC08:55
*** salv-orlando has joined #openstack-cinder08:57
*** psachin has quit IRC09:12
*** dalgaaf has quit IRC09:17
*** _dalgaaf has joined #openstack-cinder09:17
*** dims has quit IRC09:28
*** wanghao has quit IRC09:35
*** wanghao has joined #openstack-cinder09:35
*** wanghao has quit IRC09:36
*** wanghao has joined #openstack-cinder09:36
*** wanghao has quit IRC09:36
*** baojg has joined #openstack-cinder09:36
*** edmondsw has joined #openstack-cinder09:37
*** wanghao has joined #openstack-cinder09:37
*** wanghao has quit IRC09:37
*** wanghao has joined #openstack-cinder09:38
*** wanghao has quit IRC09:38
*** wanghao has joined #openstack-cinder09:38
*** wanghao has quit IRC09:39
*** wanghao has joined #openstack-cinder09:39
*** wanghao has quit IRC09:40
*** wanghao has joined #openstack-cinder09:40
*** wanghao has quit IRC09:40
*** baojg has quit IRC09:41
*** wanghao has joined #openstack-cinder09:41
*** edmondsw has quit IRC09:42
*** alexchadin has quit IRC09:44
*** alexchadin has joined #openstack-cinder09:56
*** sdague has joined #openstack-cinder09:57
*** e0ne has joined #openstack-cinder09:57
*** dims has joined #openstack-cinder09:58
openstackgerritIvan Kolodyazhny proposed openstack/cinder master: Deprecate service-to-driver mapping for backups  https://review.openstack.org/49681610:04
*** yangyapeng has quit IRC10:05
*** jmlowe has joined #openstack-cinder10:10
*** kavitha has quit IRC10:14
*** salv-orlando has quit IRC10:17
*** gnufied has joined #openstack-cinder10:17
*** salv-orlando has joined #openstack-cinder10:18
*** alexchadin has quit IRC10:22
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - Generic volume group clone performance improvements  https://review.openstack.org/49910410:23
*** abhi89 has quit IRC10:25
*** alexchadin has joined #openstack-cinder10:28
*** dave-mccowan has joined #openstack-cinder10:30
*** e0ne has quit IRC10:39
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - Pike documentation amendments  https://review.openstack.org/49083310:39
*** stakeda has quit IRC10:45
*** zhurong has quit IRC10:52
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - Generic volume group clone performance improvements  https://review.openstack.org/49910410:53
alexchadinsmcginnis: ping10:55
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - Pike documentation amendments  https://review.openstack.org/49083310:57
*** rested has quit IRC10:59
*** lhx__ has quit IRC11:00
*** bkopilov has quit IRC11:04
*** abhi89 has joined #openstack-cinder11:20
abhi89tommylikehu: thanks for the review (https://review.openstack.org/#/c/495663/).. any reason for not approving (+1) the workflow..!11:23
*** Poornima has joined #openstack-cinder11:33
*** Poornima has quit IRC11:36
*** edmondsw has joined #openstack-cinder11:38
*** edmondsw has quit IRC11:43
*** jmlowe_ has joined #openstack-cinder11:45
*** jmlowe has quit IRC11:47
*** pgadiya has quit IRC11:54
*** gkadam_ has quit IRC11:54
*** lhx_ has joined #openstack-cinder11:55
*** psachin has joined #openstack-cinder11:56
*** e0ne has joined #openstack-cinder11:58
*** frickler has joined #openstack-cinder11:58
*** lhx__ has joined #openstack-cinder12:06
*** e0ne has quit IRC12:07
*** lhx_ has quit IRC12:07
*** abhi89 has quit IRC12:07
*** zhaochao has quit IRC12:07
*** lennyb has quit IRC12:07
*** jbernard has quit IRC12:07
*** lifeless has quit IRC12:07
*** ChubYann has quit IRC12:07
*** logan- has quit IRC12:07
*** dpawlik has quit IRC12:07
*** wN has quit IRC12:07
*** sweston has quit IRC12:07
*** jbryce has quit IRC12:07
*** abhi89 has joined #openstack-cinder12:07
*** ChubYann has joined #openstack-cinder12:07
*** psachin has quit IRC12:07
*** e0ne has joined #openstack-cinder12:08
*** rtjure has quit IRC12:09
*** john5223 has quit IRC12:09
*** wN has joined #openstack-cinder12:10
*** wN has quit IRC12:10
*** wN has joined #openstack-cinder12:10
*** tesseract has quit IRC12:11
*** rtjure has joined #openstack-cinder12:12
*** john5223 has joined #openstack-cinder12:14
*** eharney has quit IRC12:18
*** lifeless_ has joined #openstack-cinder12:22
*** zhaochao has joined #openstack-cinder12:22
*** lennyb has joined #openstack-cinder12:22
*** jbernard has joined #openstack-cinder12:22
*** logan- has joined #openstack-cinder12:22
*** dpawlik has joined #openstack-cinder12:22
*** sweston has joined #openstack-cinder12:22
*** jbryce has joined #openstack-cinder12:22
hemnaguwak12:23
*** salv-orlando has quit IRC12:25
*** tesseract has joined #openstack-cinder12:27
*** e0ne has quit IRC12:31
*** abishop has joined #openstack-cinder12:32
*** e0ne has joined #openstack-cinder12:32
openstackgerritJens Harbott (frickler) proposed openstack/cinder master: Make sure that versions are applied as relative URLs  https://review.openstack.org/49912912:33
abhi89Hi all.. https://review.openstack.org/#/c/495663/ has been reviewed.. can someone please approve the workflow so that the patch gets merged..12:34
fricklersmcginnis: I think I have solved about 50% of https://bugs.launchpad.net/cinder/+bug/1713732, do you have time to take a look? ^^ sadly it doesn't seem to fix the tempest issue, which is what I was hoping for when I found this12:34
openstackLaunchpad bug 1713732 in Cinder "Tempest failures in tempest.api.volume.test_volumes_list.VolumesListTestJSON" [Undecided,In progress] - Assigned to Dr. Jens Harbott (j-harbott)12:34
smcginnisfrickler: Wow, thanks for working on that. I'll take a look.12:36
smcginnisalexchadin: Pong12:37
alexchadinsmcginnis: I'd like to discuss additional cinder volume driver with you12:38
alexchadinsmcginnis: if you have some time, of course12:38
smcginnisalexchadin: Just saw the scrollback. No, I'm not aware of any work with OCFS2.12:38
*** abhi89 has quit IRC12:39
alexchadinsmcginnis: we have one that works for us.12:40
alexchadinsmcginnis: it implements all base functions and we would like to push it in upstream12:40
alexchadinsmcginnis: if it is able12:40
smcginnisalexchadin: You'll want to read through this: https://wiki.openstack.org/wiki/Cinder/how-to-contribute-a-driver12:41
smcginnisalexchadin: But you can start with filing a blueprint: https://blueprints.launchpad.net/cinder12:41
alexchadinsmcginnis: tommylikehu already gave me this link, I've read it, thanks12:41
smcginnisalexchadin: Just something basic stating that it is for a new driver for OCFS2. Doesn't need to be too detailed.12:41
alexchadinsmcginnis: I just wonder if cinder team need it :)12:41
smcginnisalexchadin: No12:42
smcginnis:D12:42
alexchadin:D12:42
*** liverpooler has quit IRC12:42
smcginnisalexchadin: But users of Cinder might. :]12:42
alexchadinyou get it ;D12:42
alexchadingot it*12:42
alexchadinsmcginnis: well, thank you12:42
smcginnisalexchadin: Seriously though - someone would need to maintain the driver, so unless there's some commitment to stick around and keep things from breaking...12:43
smcginnisalexchadin: If not, it might be better to just publish it on your own github and let folks know it's there.12:43
smcginnisalexchadin: There will need to be a CI job running to test it. I don't know anything about OCFS2, but I assume that's open source?12:43
smcginnisalexchadin: If so, the OpenStack infra can be used for CI, just someone would need to get jobs set up there for it to run the tests.12:44
alexchadinsmcginnis: I work on OpenStack Watcher for 2.5 years and want to maintain this part of cinder if we submit it12:44
smcginnisalexchadin: Great!12:44
alexchadinsmcginnis: I just wanted to know your opinion about integration this one in Cinder :)12:45
smcginnisalexchadin: That could be really useful, especially once we have multiattach support (based on the real quick read I've done of what ocfs2 is)12:45
*** sncder has quit IRC12:55
*** bkopilov has joined #openstack-cinder12:56
*** abhi89 has joined #openstack-cinder12:59
openstackgerritTommyLike proposed openstack/cinder master: Don't lock whole project's resource when reserve/commit  https://review.openstack.org/49828313:00
*** links has quit IRC13:00
*** gcb has quit IRC13:06
*** mchlumsky has joined #openstack-cinder13:09
*** mchlumsky has quit IRC13:12
*** catintheroof has joined #openstack-cinder13:15
*** gouthamr has joined #openstack-cinder13:19
openstackgerritChuck Fouts proposed openstack/cinder master: NetApp: Fix to support SVM scoped permissions.  https://review.openstack.org/49914813:20
*** eharney has joined #openstack-cinder13:24
*** crushil has joined #openstack-cinder13:35
*** edmondsw has joined #openstack-cinder13:39
*** edmondsw has quit IRC13:43
*** lbragstad has joined #openstack-cinder13:44
*** liverpooler has joined #openstack-cinder13:44
*** chhavi has quit IRC13:47
*** lucasxu has joined #openstack-cinder13:48
*** liverpooler has quit IRC13:55
*** liverpooler has joined #openstack-cinder13:55
*** Arianrhod has joined #openstack-cinder13:58
*** salv-orlando has joined #openstack-cinder14:01
*** chhavi has joined #openstack-cinder14:04
*** mlakat has quit IRC14:04
*** alexchadin has quit IRC14:05
*** links has joined #openstack-cinder14:05
*** links has quit IRC14:06
*** pcaruana has quit IRC14:06
*** edmondsw has joined #openstack-cinder14:07
*** mriedem has joined #openstack-cinder14:07
*** eharney_ has joined #openstack-cinder14:13
*** eharney has quit IRC14:13
*** eharney_ is now known as eharney14:14
*** baojg has joined #openstack-cinder14:14
*** armax has joined #openstack-cinder14:14
*** vivsoni_ has joined #openstack-cinder14:18
*** vivsoni has quit IRC14:18
*** Arianrhod has quit IRC14:19
*** mlakat has joined #openstack-cinder14:22
*** dustins has joined #openstack-cinder14:23
*** dustins has quit IRC14:24
openstackgerritJens Harbott (frickler) proposed openstack/cinder master: Make sure that versions are applied as relative URLs  https://review.openstack.org/49912914:26
*** dustins has joined #openstack-cinder14:26
openstackgerritIvan Kolodyazhny proposed openstack/cinder master: Deprecate service-to-driver mapping for backups  https://review.openstack.org/49681614:29
*** mvk has joined #openstack-cinder14:29
*** ntpttr_laptop has joined #openstack-cinder14:30
ildikovsmcginnis: I like the spirit for multi-attach :)14:32
smcginnisildikov: Keeping the dream alive. :D14:33
ildikovsmcginnis: always warms my heart knowing I'm not the only one :)14:33
smcginnisHaha, nope. You've got company. ;)14:34
ildikov\o/ ;)14:34
ildikovsmcginnis: BTW, as Pike is out, does this mean that if I confirm with jgriffith that the client is good enough as is then we can cut a release? :)14:35
jungleboyjildikov:  You the (wo)man!  Keep multi-attach alive.14:37
jungleboyjildikov:  Yes, I was going to talk about it in the meeting today and cut a cinderclient release if there are no concerns.14:37
ildikovjungleboyj: well, it hasn't really reached the state of alive yet... :D14:37
ildikovjungleboyj: awesomeness, thanks!14:38
jungleboyjildikov: Welcome.  :-)14:38
*** lpetrut has quit IRC14:38
jungleboyjKeep the CPR going.  Eventually it will work.14:40
ildikov:)14:45
openstackgerritMerged openstack/cinder master: Making reservations before group creation  https://review.openstack.org/49566314:48
*** edmondsw has quit IRC14:56
*** crose has joined #openstack-cinder14:59
*** eharney has quit IRC15:01
*** lkuchlan has quit IRC15:04
*** rcernin has quit IRC15:09
*** thegreenhundred has joined #openstack-cinder15:10
openstackgerritSorin Sbarnea proposed openstack/cinder master: Unhide errors from check_uptodate.sh  https://review.openstack.org/49918415:10
openstackgerritSorin Sbarnea proposed openstack/cinder master: Unhide errors from check_uptodate.sh  https://review.openstack.org/49918415:12
lhx__smcginnis, I replied your comment. could you spare some minutes to review? https://review.openstack.org/#/c/498810/15:13
smcginnislhx__: Yeah, saw the comment. Is an update coming?15:13
lhx__smcginnis, hum..., seems no need any update? ;)15:14
*** eharney has joined #openstack-cinder15:15
smcginnislhx__: Please see my first comment on there.15:15
*** mvk has quit IRC15:15
*** itzdilip has joined #openstack-cinder15:18
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - Generic volume group clone performance improvements  https://review.openstack.org/49910415:24
openstackgerritMerged openstack/cinder master: [DOC BLD FIX] Make opts sections lowercase  https://review.openstack.org/48350415:25
openstackgerritMerged openstack/cinder master: [DOC BLD FIX] Fix remote-code-block warnings  https://review.openstack.org/49859115:26
openstackgerritMerged openstack/cinder master: [Doc] Handle Sphinx warnings as errors  https://review.openstack.org/49868615:26
*** itzdilip has quit IRC15:28
openstackgerritMerged openstack/cinder master: RBD - volume create failed when volume need flatten  https://review.openstack.org/47785715:31
eharneysmcginnis: so i'm trying to figure out where i would document these assert details...15:32
smcginniseharney: Yeah, I'm not sure.15:32
smcginniseharney: Maybe even just a comment next to the assertTrue hacking check?15:32
openstackgerritJens Harbott (frickler) proposed openstack/cinder master: WIP: Fix broken URLs when running behind a proxy  https://review.openstack.org/49919615:32
eharneysmcginnis: i guess something in contributor/testing.rst ?15:32
eharneysmcginnis: also that15:33
smcginniseharney: That would be good too.15:33
fricklersmcginnis: ^^that patch is adding a unit test showing what goes wrong with the URLs, but I really don't want to touch the rewriting code15:34
smcginnisfrickler: Good start having a test that we can use to validate. Thanks!15:35
fricklersmcginnis: after having gone through all this, I think the proper solution would be to get rid of public_endpoint completely and handle stuff correctly out of the box in conjunction wit oslo_middleware, like most other services seem to do15:36
*** felipemonteiro has joined #openstack-cinder15:37
smcginnisfrickler: I was wondering why we're the only ones that seem to have that setting.15:38
smcginnisfrickler: That's probably the right thing to do, especially for the sake of consistency.15:38
*** felipemonteiro_ has joined #openstack-cinder15:38
smcginnisfrickler: It really seems like it shouldn't be this difficult. ;)15:38
openstackgerritSorin Sbarnea proposed openstack/cinder master: Unhide errors from check_uptodate.sh  https://review.openstack.org/49918415:38
*** salv-orlando has quit IRC15:41
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - Generic volume group clone performance improvements  https://review.openstack.org/49910415:41
*** felipemonteiro has quit IRC15:41
smcginnisThis probably wasn't the right solution, but it's been there for over two years: https://github.com/openstack/cinder/commit/2eb25ab8803214cb3beb5d8fe3efbf70a462c41415:42
*** salv-orlando has joined #openstack-cinder15:42
*** felipemonteiro_ has quit IRC15:44
*** itlinux has joined #openstack-cinder15:47
*** itlinux has quit IRC15:48
*** thegreenhundred has quit IRC15:48
*** manjaroi3 has joined #openstack-cinder15:48
*** strigazi is now known as strigazi_AFK15:50
lhx__smcginnis, I have to ask if '{"os-complete": null}' is the POST data. I have no idea about the data. http://paste.openstack.org/show/619912/15:51
*** gouthamr has quit IRC15:53
*** pcaruana has joined #openstack-cinder15:54
smcginnislhx__: I believe it would be '{"os-complete" { } }'15:54
smcginnislhx__: Let me find another "action" reference to look at.15:54
smcginnislhx__: Here's a decent example: https://github.com/openstack/cinder/blob/master/api-ref/source/v3/samples/group-replication-enable.json15:55
lhx__smcginnis, thanks so much.:D15:55
smcginnislhx__: No problem. Pretty straight forward once you know, but that's why we need the example in there since it's not obvious,15:56
*** manjaroi3 has quit IRC15:56
*** thegreenhundred has joined #openstack-cinder15:56
lhx__got it15:57
*** thegreenhundred has quit IRC15:58
*** thegreenhundred has joined #openstack-cinder15:58
openstackgerritEric Harney proposed openstack/cinder master: Add contributor doc on assertEqual vs assertFalse  https://review.openstack.org/49921216:02
openstackgerritEric Harney proposed openstack/cinder master: Fix python 3.6 escape char warnings in strings  https://review.openstack.org/49921316:02
*** jmlowe_ has quit IRC16:02
openstackgerritMerged openstack/cinder master: VMAX driver - Pike documentation amendments  https://review.openstack.org/49083316:07
openstackgerritMerged openstack/cinder master: Replace yaml.load() with yaml.safe_load()  https://review.openstack.org/44416016:07
*** salv-orlando has quit IRC16:08
*** abhi89 has quit IRC16:09
*** gouthamr has joined #openstack-cinder16:16
*** wxy- has joined #openstack-cinder16:19
*** ntpttr_laptop has quit IRC16:25
*** markstur has joined #openstack-cinder16:31
*** itlinux has joined #openstack-cinder16:31
*** Apoorva has joined #openstack-cinder16:31
*** markvoelker has joined #openstack-cinder16:32
*** tesseract has quit IRC16:33
openstackgerritSorin Sbarnea proposed openstack/cinder master: Fixed sitepackages conflict with envdir  https://review.openstack.org/49922916:44
*** gkadam_ has joined #openstack-cinder16:57
openstackgerritHanxi Liu proposed openstack/cinder master: [Api-ref] Add api doc for attachment complete  https://review.openstack.org/49881016:58
openstackgerritHanxi Liu proposed openstack/cinder master: [Api-ref] Add api doc for attachment complete  https://review.openstack.org/49881017:00
*** strigazi_AFK is now known as strigazi17:03
*** e0ne has quit IRC17:05
*** markvoelker has quit IRC17:07
*** salv-orlando has joined #openstack-cinder17:09
*** strigazi has quit IRC17:14
*** strigazi has joined #openstack-cinder17:14
*** dims has quit IRC17:14
*** salv-orlando has quit IRC17:14
*** ntpttr_laptop has joined #openstack-cinder17:17
*** dims has joined #openstack-cinder17:18
*** crose has quit IRC17:29
*** diablo_rojo has joined #openstack-cinder17:47
*** lhx__ has quit IRC17:48
openstackgerritEric Harney proposed openstack/cinder master: Add contributor doc on assertEqual vs assertFalse  https://review.openstack.org/49921217:50
openstackgerritEric Harney proposed openstack/cinder master: Fix python 3.6 escape char warnings in strings  https://review.openstack.org/49921317:50
*** rcernin has joined #openstack-cinder17:52
*** edmondsw has joined #openstack-cinder17:55
*** gkadam_ has quit IRC18:01
*** jmlowe has joined #openstack-cinder18:08
*** markvoelker has joined #openstack-cinder18:10
*** salv-orlando has joined #openstack-cinder18:10
*** KeithMnemonic2 has quit IRC18:14
*** salv-orlando has quit IRC18:15
*** chhavi has quit IRC18:17
*** gouthamr has quit IRC18:28
*** e0ne has joined #openstack-cinder18:30
*** ntpttr_laptop has quit IRC18:33
*** markvoelker has quit IRC18:43
*** gouthamr has joined #openstack-cinder18:44
*** xyang1 has joined #openstack-cinder18:52
*** edmondsw has quit IRC19:04
*** markvoelker has joined #openstack-cinder19:06
*** edmondsw has joined #openstack-cinder19:06
*** edmondsw has quit IRC19:10
*** salv-orlando has joined #openstack-cinder19:11
*** edmondsw has joined #openstack-cinder19:14
*** zhaochao has quit IRC19:14
*** mriedem is now known as mriedem_away19:16
*** salv-orlando has quit IRC19:17
*** edmondsw has quit IRC19:18
*** dims has quit IRC19:28
*** catintheroof has quit IRC19:28
*** dims has joined #openstack-cinder19:31
openstackgerritGorka Eguileor proposed openstack/cinder master: Create custom assertTrue and assertFalse  https://review.openstack.org/49927119:33
geguileoeharney: ^ that's on the assertFalse/assertTrue thingy19:34
*** markvoelker has quit IRC19:37
smcginnisgeguileo: Nice, I didn't notice those misuses of assertTrue(a, b).19:37
geguileosmcginnis: I only noticed when the tests failed   XD19:37
smcginnisGood tests. :)19:38
*** markvoelker has joined #openstack-cinder19:38
smcginnisNot really loving things like this though: self.assertTrue(bool(bitset.is_set(16)))19:40
smcginnisSeems like something we're going to have a hard time noticing.19:40
geguileosmcginnis: the problem is that some of those tests seem to be wrong...19:40
geguileosmcginnis: they are actually returning a mock...19:41
geguileosmcginnis: and I'm not in the mood of fixing driver's tests...19:41
smcginnisYeah...19:41
geguileosmcginnis: And that code mimics exactly what they are doing right now19:41
geguileoI fixed some of the tests19:41
smcginnisgeguileo: So in that example above, what happens if it just passes in bitset.is_set(16)?19:42
geguileosmcginnis: I think that case was returning a mock, so if you just pass just that it will ways that mock.Mock(blah,blah) is not True19:42
smcginnisgeguileo: Ah, OK. So they are just mocking wrong in that case, so it's easier for now just using bool()19:43
geguileosmcginnis: yes19:44
geguileosmcginnis: that's why in some cases I replaced it with checks of None, 0, 1, [], etc19:44
geguileobut in some other I left it like that19:44
smcginnisOK, that makes a little more sense now.19:44
geguileoI also left it like bool() in the case of OVO lists that were not empty19:44
geguileoBut used "assertEqual([], ovo.objects)"  when they were empty19:45
*** liverpooler has quit IRC19:48
openstackgerritMerged openstack/python-brick-cinderclient-ext master: Updated from global requirements  https://review.openstack.org/49526519:49
*** markvoelker has quit IRC19:56
*** markstur_ has joined #openstack-cinder19:58
*** edmondsw has joined #openstack-cinder20:00
*** felipemonteiro has joined #openstack-cinder20:00
*** markstur has quit IRC20:01
*** edmondsw_ has joined #openstack-cinder20:01
openstackgerritSean McGinnis proposed openstack/cinder master: api-ref: Clarify os-host GET behavior  https://review.openstack.org/49928520:03
*** edmondsw has quit IRC20:04
*** edmondsw_ has quit IRC20:05
*** lpetrut has joined #openstack-cinder20:10
*** jmlowe has quit IRC20:12
*** salv-orlando has joined #openstack-cinder20:13
*** jmlowe has joined #openstack-cinder20:15
*** felipemonteiro has quit IRC20:17
*** salv-orlando has quit IRC20:18
*** catintheroof has joined #openstack-cinder20:29
*** jose-phillips has joined #openstack-cinder20:29
*** nicolasbock has joined #openstack-cinder20:32
*** gnufied has quit IRC20:34
*** pcaruana has quit IRC20:40
*** ntpttr_laptop has joined #openstack-cinder20:41
*** edmondsw has joined #openstack-cinder20:43
*** edmondsw has quit IRC20:48
*** lucasxu has quit IRC20:49
*** gouthamr has quit IRC20:54
*** jmlowe has quit IRC21:04
*** e0ne has quit IRC21:06
*** gnufied has joined #openstack-cinder21:06
*** gnufied has quit IRC21:08
*** gnufied has joined #openstack-cinder21:08
*** gouthamr has joined #openstack-cinder21:10
*** abishop has quit IRC21:14
*** salv-orlando has joined #openstack-cinder21:14
openstackgerritSean McGinnis proposed openstack/cinder master: Remove API v1  https://review.openstack.org/49934221:17
*** salv-orlando has quit IRC21:19
*** dustins has quit IRC21:19
*** sapd has quit IRC21:26
*** armax has quit IRC21:35
*** edmondsw has joined #openstack-cinder21:39
*** edmondsw_ has joined #openstack-cinder21:40
diablo_rojoWhen does everyone get into CO?21:43
*** eharney has quit IRC21:43
*** gnufied has quit IRC21:43
*** edmondsw has quit IRC21:44
*** jmlowe has joined #openstack-cinder21:45
*** lpetrut has quit IRC21:45
*** edmondsw has joined #openstack-cinder21:45
*** edmondsw_ has quit IRC21:45
*** mriedem_away is now known as mriedem21:47
smcginnisSat21:52
diablo_rojosmcginnis, samesies.21:52
*** thegreenhundred has quit IRC21:56
*** edmondsw has quit IRC22:00
openstackgerritMerged openstack/cinder master: Unhide errors from check_uptodate.sh  https://review.openstack.org/49918422:08
openstackgerritMerged openstack/cinder master: Correct contributor doc information  https://review.openstack.org/49512322:09
*** xyang1 has quit IRC22:12
*** dave-mccowan has quit IRC22:12
*** salv-orlando has joined #openstack-cinder22:15
openstackgerritMerged openstack/cinder master: VMware: Cache storage profile ID  https://review.openstack.org/48728222:15
*** thegreenhundred has joined #openstack-cinder22:18
*** salv-orlando has quit IRC22:20
*** edmondsw has joined #openstack-cinder22:22
*** itlinux has quit IRC22:23
openstackgerritMerged openstack/cinder master: Hpe: reduce duplicate validation  https://review.openstack.org/49832722:24
openstackgerritMerged openstack/cinder master: HPE Lefthand: fix volume retype operation  https://review.openstack.org/49670322:24
*** edmondsw has quit IRC22:26
*** rcernin has quit IRC22:28
*** edmondsw has joined #openstack-cinder22:39
*** thegreenhundred has quit IRC22:39
*** armax has joined #openstack-cinder22:39
*** edmondsw has quit IRC22:43
openstackgerritMerged openstack/cinder master: Fix python 3.6 escape char warnings in strings  https://review.openstack.org/49921322:46
*** markstur_ has quit IRC22:48
*** markstur has joined #openstack-cinder22:53
*** edmondsw has joined #openstack-cinder23:01
*** edmondsw has quit IRC23:06
*** scottda has quit IRC23:12
*** salv-orlando has joined #openstack-cinder23:16
*** gnufied has joined #openstack-cinder23:20
*** salv-orlando has quit IRC23:21
*** itlinux has joined #openstack-cinder23:22
*** Apoorva has quit IRC23:31
*** Apoorva has joined #openstack-cinder23:32
*** Apoorva_ has joined #openstack-cinder23:35
*** Apoorva has quit IRC23:39
*** markvoelker_ has joined #openstack-cinder23:45
*** stakeda has joined #openstack-cinder23:48
*** wxy- has quit IRC23:53
*** edmondsw has joined #openstack-cinder23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!