*** armax has quit IRC | 00:02 | |
*** yangyapeng has joined #openstack-cinder | 00:06 | |
*** ganso has quit IRC | 00:07 | |
*** abishop has quit IRC | 00:08 | |
*** yangyapeng has quit IRC | 00:11 | |
*** felipemonteiro has quit IRC | 00:11 | |
*** itlinux has joined #openstack-cinder | 00:18 | |
*** catintheroof has joined #openstack-cinder | 00:18 | |
*** catintheroof has quit IRC | 00:31 | |
*** sdague has quit IRC | 00:36 | |
*** wanghao_ has quit IRC | 00:43 | |
*** harlowja has quit IRC | 00:48 | |
*** wanghao has joined #openstack-cinder | 00:49 | |
*** Apoorva_ has quit IRC | 00:51 | |
*** stakeda has joined #openstack-cinder | 01:03 | |
*** zhurong has joined #openstack-cinder | 01:15 | |
*** yangyapeng has joined #openstack-cinder | 01:15 | |
openstackgerrit | TommyLike proposed openstack/cinder-specs master: Show resource's total count info in list APIs https://review.openstack.org/500665 | 01:16 |
---|---|---|
*** s-shiono has joined #openstack-cinder | 01:22 | |
*** s-shiono_ has joined #openstack-cinder | 01:24 | |
*** s-shiono has quit IRC | 01:26 | |
*** abhi89 has joined #openstack-cinder | 01:58 | |
itlinux | hello guys.. what's the best way to se the default type since cinder.conf default_type does not work.. | 01:59 |
itlinux | I should say default_volume_type | 01:59 |
*** abhi89 has quit IRC | 02:08 | |
*** bkopilov has quit IRC | 02:10 | |
*** markvoelker has quit IRC | 02:11 | |
*** alkhodos has joined #openstack-cinder | 02:12 | |
*** swamireddy has quit IRC | 02:14 | |
*** alkhodos has quit IRC | 02:16 | |
openstackgerrit | TommyLike proposed openstack/cinder master: Support az filter for snapshot https://review.openstack.org/489945 | 02:27 |
*** markstur_ has quit IRC | 02:31 | |
*** adisky__ has joined #openstack-cinder | 02:34 | |
*** itlinux has quit IRC | 02:37 | |
openstackgerrit | yanghuichan proposed openstack/cinder master: Fix wrong links in Cinder https://review.openstack.org/501129 | 02:40 |
*** itlinux has joined #openstack-cinder | 02:40 | |
*** itlinux has quit IRC | 02:41 | |
*** lhx__ has joined #openstack-cinder | 03:09 | |
*** markvoelker has joined #openstack-cinder | 03:11 | |
*** cknight has joined #openstack-cinder | 03:14 | |
*** abhi89 has joined #openstack-cinder | 03:15 | |
*** cknight has quit IRC | 03:16 | |
*** itlinux has joined #openstack-cinder | 03:19 | |
*** bkopilov has joined #openstack-cinder | 03:28 | |
*** yangyape_ has joined #openstack-cinder | 03:34 | |
openstackgerrit | Hanxi Liu proposed openstack/cinder master: iso8601.is8601.Utc No Longer Exists https://review.openstack.org/501549 | 03:37 |
*** yangyapeng has quit IRC | 03:37 | |
*** lhx__ has quit IRC | 03:38 | |
*** lhx__ has joined #openstack-cinder | 03:38 | |
*** stakeda has quit IRC | 03:39 | |
*** lkuchlan_wfh has joined #openstack-cinder | 03:43 | |
openstackgerrit | Hanxi Liu proposed openstack/cinder master: iso8601.is8601.Utc No Longer Exists https://review.openstack.org/501549 | 03:43 |
*** markvoelker has quit IRC | 03:46 | |
*** yangyape_ has quit IRC | 03:47 | |
openstackgerrit | Hanxi Liu proposed openstack/cinder master: Replace iso8601.is8601.Utc with iso8601.UTC https://review.openstack.org/501549 | 03:47 |
*** yangyapeng has joined #openstack-cinder | 03:48 | |
*** gkadam has joined #openstack-cinder | 03:49 | |
*** swamireddy has joined #openstack-cinder | 03:53 | |
openstackgerrit | yanghuichan proposed openstack/cinder master: Fix wrong links in Cinder https://review.openstack.org/501129 | 03:57 |
*** chhavi has joined #openstack-cinder | 04:02 | |
*** yangyape_ has joined #openstack-cinder | 04:05 | |
*** harlowja has joined #openstack-cinder | 04:06 | |
*** yangyapeng has quit IRC | 04:06 | |
*** armax has joined #openstack-cinder | 04:08 | |
*** swamireddy has quit IRC | 04:19 | |
*** ntpttr_ has joined #openstack-cinder | 04:19 | |
*** armax_ has joined #openstack-cinder | 04:20 | |
*** jistr|off has quit IRC | 04:20 | |
*** armax has quit IRC | 04:21 | |
*** armax_ is now known as armax | 04:21 | |
*** _alastor_ has quit IRC | 04:21 | |
*** _alastor_ has joined #openstack-cinder | 04:21 | |
*** ntpttr has quit IRC | 04:22 | |
*** wN has quit IRC | 04:23 | |
*** swamireddy has joined #openstack-cinder | 04:23 | |
*** jistr has joined #openstack-cinder | 04:24 | |
*** wN has joined #openstack-cinder | 04:26 | |
*** wN has quit IRC | 04:26 | |
*** wN has joined #openstack-cinder | 04:26 | |
*** gouthamr has quit IRC | 04:31 | |
*** esker has quit IRC | 04:37 | |
*** zhurong has quit IRC | 04:38 | |
*** dims has quit IRC | 04:40 | |
*** markvoelker has joined #openstack-cinder | 04:43 | |
*** psachin has joined #openstack-cinder | 04:51 | |
*** boris_42 has joined #openstack-cinder | 04:52 | |
*** pgadiya has joined #openstack-cinder | 05:01 | |
*** zhurong has joined #openstack-cinder | 05:07 | |
*** harlowja has quit IRC | 05:11 | |
*** pcaruana has joined #openstack-cinder | 05:15 | |
*** prometheanfire has quit IRC | 05:16 | |
*** markvoelker has quit IRC | 05:16 | |
*** lhx__ has quit IRC | 05:35 | |
*** diablo_rojo has joined #openstack-cinder | 05:48 | |
*** diablo_rojo has quit IRC | 06:11 | |
*** yangyape_ has quit IRC | 06:12 | |
*** yangyapeng has joined #openstack-cinder | 06:13 | |
*** markvoelker has joined #openstack-cinder | 06:13 | |
*** lhx__ has joined #openstack-cinder | 06:16 | |
*** jmlowe has quit IRC | 06:29 | |
openstackgerrit | Dai Dang Van proposed openstack/cinder-specs master: Manual update sphinx version https://review.openstack.org/482068 | 06:42 |
*** abhi has joined #openstack-cinder | 06:44 | |
*** markvoelker has quit IRC | 06:47 | |
*** rcernin has joined #openstack-cinder | 06:53 | |
*** armax has quit IRC | 07:02 | |
*** gkadam is now known as gkadam-afk | 07:03 | |
*** alexchadin has joined #openstack-cinder | 07:04 | |
*** tesseract has joined #openstack-cinder | 07:13 | |
*** stakeda has joined #openstack-cinder | 07:24 | |
*** markvoelker has joined #openstack-cinder | 07:44 | |
openstackgerrit | Chhavi Agarwal proposed openstack/os-brick master: FC PPC64 device discovery issue https://review.openstack.org/501253 | 07:59 |
*** liverpooler has joined #openstack-cinder | 08:02 | |
openstackgerrit | Tzur Eliyahu proposed openstack/cinder master: ibm_storage - fix enable replication after disable https://review.openstack.org/487063 | 08:06 |
*** markvoelker has quit IRC | 08:17 | |
*** liverpooler has quit IRC | 08:25 | |
*** liverpooler has joined #openstack-cinder | 08:25 | |
openstackgerrit | yixuan zhang proposed openstack/cinder master: Storwize: add NPIV support https://review.openstack.org/501128 | 08:40 |
*** lkuchlan_wfh has quit IRC | 08:51 | |
*** lkuchlan has joined #openstack-cinder | 08:52 | |
*** oomichi has quit IRC | 08:53 | |
*** oomichi has joined #openstack-cinder | 08:54 | |
*** mriedem has quit IRC | 08:55 | |
*** lkuchlan is now known as lkuchlan_wfh | 08:55 | |
*** dalgaaf has quit IRC | 09:07 | |
*** dalgaaf has joined #openstack-cinder | 09:09 | |
kwathore | @Team,tommylikehu: This is regarding "Apply encryption and qos per volume? " topic in https://etherpad.openstack.org/p/cinder-ptg-queens . When this feature will be available or any time line decided in queens cycle? | 09:11 |
kwathore | could you please provide some info about it. | 09:13 |
tommylikehu | hey kwathore I am not sure abou the schedule or deadline ,I guess it's all depends on whether we can reach an agreemt during pike cycle. So if you care about this feature, it would be great if you can add more use case for this feature at the etherpad. | 09:14 |
*** markvoelker has joined #openstack-cinder | 09:14 | |
*** e0ne has joined #openstack-cinder | 09:15 | |
*** mvk has joined #openstack-cinder | 09:16 | |
tommylikehu | s/pike/queen | 09:16 |
kwathore | @tommylikehu: got it. thanks..sure will see some use cases for this | 09:17 |
*** gkadam_ has joined #openstack-cinder | 09:34 | |
*** ChubYann has quit IRC | 09:35 | |
*** gkadam-afk has quit IRC | 09:36 | |
*** ChubYann has joined #openstack-cinder | 09:40 | |
chhavi | eharney:https://review.openstack.org/#/c/501253/ | 09:42 |
*** psachin has quit IRC | 09:43 | |
*** markvoelker has quit IRC | 09:48 | |
*** s-shiono_ has quit IRC | 09:50 | |
*** edmondsw has joined #openstack-cinder | 09:54 | |
*** edmondsw has quit IRC | 09:58 | |
*** yangyapeng has quit IRC | 10:01 | |
openstackgerrit | Jesse Wu proposed openstack/cinder master: Synology: Driver unable to be initialized https://review.openstack.org/474917 | 10:05 |
*** jmlowe has joined #openstack-cinder | 10:08 | |
*** jmlowe_ has joined #openstack-cinder | 10:11 | |
*** jmlowe has quit IRC | 10:14 | |
*** zhurong has quit IRC | 10:23 | |
*** abhi89 has quit IRC | 10:26 | |
*** stakeda has quit IRC | 10:32 | |
*** markvoelker has joined #openstack-cinder | 10:45 | |
*** bkopilov has quit IRC | 10:48 | |
*** gkadam__ has joined #openstack-cinder | 11:05 | |
*** sdague has joined #openstack-cinder | 11:06 | |
*** gkadam_ has quit IRC | 11:07 | |
*** tomh has quit IRC | 11:09 | |
*** psachin has joined #openstack-cinder | 11:16 | |
*** markvoelker has quit IRC | 11:17 | |
*** zhurong has joined #openstack-cinder | 11:20 | |
kwathore | @Team: Please review below cherry-pick: | 11:37 |
kwathore | https://review.openstack.org/#/c/501585/ | 11:37 |
*** liverpooler has quit IRC | 11:44 | |
*** lpetrut has joined #openstack-cinder | 11:46 | |
*** lpetrut has quit IRC | 11:46 | |
openstackgerrit | Hanxi Liu proposed openstack/cinder master: RBD: Create incremental backup for volume in-use failed https://review.openstack.org/432184 | 11:48 |
openstackgerrit | Hanxi Liu proposed openstack/cinder master: RBD: Create incremental backup for volume in-use failed https://review.openstack.org/432184 | 11:50 |
*** abishop has joined #openstack-cinder | 12:05 | |
*** pgadiya has quit IRC | 12:06 | |
*** bkopilov has joined #openstack-cinder | 12:06 | |
*** tomh has joined #openstack-cinder | 12:06 | |
*** dims has joined #openstack-cinder | 12:07 | |
*** catintheroof has joined #openstack-cinder | 12:11 | |
*** markvoelker has joined #openstack-cinder | 12:15 | |
*** dave-mccowan has joined #openstack-cinder | 12:20 | |
*** markvoelker has quit IRC | 12:24 | |
*** markvoelker has joined #openstack-cinder | 12:24 | |
*** alexchadin has quit IRC | 12:24 | |
*** zhurong has quit IRC | 12:25 | |
*** abhi89 has joined #openstack-cinder | 12:27 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Implement keymgr list() method https://review.openstack.org/501398 | 12:27 |
*** edmondsw has joined #openstack-cinder | 12:32 | |
*** catintheroof has quit IRC | 12:33 | |
*** catintheroof has joined #openstack-cinder | 12:38 | |
*** dave-mcc_ has joined #openstack-cinder | 12:39 | |
*** gkadam__ has quit IRC | 12:40 | |
*** dave-mccowan has quit IRC | 12:42 | |
*** edmondsw has quit IRC | 12:43 | |
*** edmondsw has joined #openstack-cinder | 12:43 | |
*** edmondsw has quit IRC | 12:48 | |
*** abhi89 has quit IRC | 12:53 | |
*** edmondsw has joined #openstack-cinder | 12:54 | |
*** liverpooler has joined #openstack-cinder | 12:54 | |
*** lhx__ has quit IRC | 12:57 | |
*** baojg has joined #openstack-cinder | 13:02 | |
*** felipemonteiro has joined #openstack-cinder | 13:03 | |
*** felipemonteiro_ has joined #openstack-cinder | 13:05 | |
*** felipemonteiro has quit IRC | 13:09 | |
*** mriedem has joined #openstack-cinder | 13:09 | |
*** edmondsw_ has joined #openstack-cinder | 13:14 | |
*** mchlumsky has joined #openstack-cinder | 13:15 | |
*** edmondsw has quit IRC | 13:15 | |
*** itlinux has quit IRC | 13:19 | |
*** lkuchlan_wfh has quit IRC | 13:24 | |
*** catintheroof has quit IRC | 13:27 | |
*** catintheroof has joined #openstack-cinder | 13:27 | |
*** edmondsw_ is now known as edmondsw | 13:29 | |
*** gouthamr has joined #openstack-cinder | 13:30 | |
*** felipemonteiro_ has quit IRC | 13:30 | |
*** dustins has joined #openstack-cinder | 13:31 | |
*** esker has joined #openstack-cinder | 13:32 | |
*** catintheroof has quit IRC | 13:37 | |
*** catintheroof has joined #openstack-cinder | 13:37 | |
*** catintheroof has quit IRC | 13:39 | |
openstackgerrit | Merged openstack/cinder master: Fix wrong links in Cinder https://review.openstack.org/501129 | 13:39 |
*** catintheroof has joined #openstack-cinder | 13:40 | |
*** thegreenhundred has joined #openstack-cinder | 13:50 | |
*** dave-mcc_ is now known as dave-mccowan | 13:57 | |
openstackgerrit | Chhavi Agarwal proposed openstack/os-brick master: FC PPC64 device discovery issue https://review.openstack.org/501253 | 14:06 |
*** xyang has joined #openstack-cinder | 14:10 | |
*** crose has joined #openstack-cinder | 14:13 | |
*** chhavi has quit IRC | 14:18 | |
*** chhavi has joined #openstack-cinder | 14:19 | |
lbragstad | smcginnis: jungleboyj are either of you interested in driving the multi-attach volumes session for the baremetal/vm group? | 14:23 |
lbragstad | from a cinder perspective? | 14:23 |
lbragstad | cc mriedem for the nova side? | 14:23 |
jungleboyj | lbragstad: jgriffith and/or ildikov are probably the best drivers there. I should probably attend. | 14:24 |
lbragstad | ok - i'll add their names to https://etherpad.openstack.org/p/queens-PTG-vmbm | 14:24 |
lbragstad | jungleboyj: what about cinder ephemeral storage for instances? | 14:25 |
lbragstad | who would be a good driver for that? | 14:26 |
ildikov | lbragstad: I will make sure I'm there and will try to bring jgriffith with me too, it's not his favorite topic... :) | 14:26 |
lbragstad | perfect! | 14:26 |
lbragstad | i'm just trying to get some level of representation in the room for those discussions | 14:26 |
lbragstad | at those times | 14:26 |
ildikov | When do you plan to have that chat? | 14:26 |
ildikov | lbragstad: +1 | 14:27 |
lbragstad | but the schedule is still in draft so fee free to propose alternatives (i'll send a ML note, too) | 14:27 |
lbragstad | ildikov: https://etherpad.openstack.org/p/queens-PTG-vmbm | 14:27 |
jungleboyj | ildikov: Thank you! | 14:27 |
jungleboyj | lbragstad: For the ephemeral, that was jgriffith again. I also would like to be involved in that. | 14:27 |
ildikov | lbragstad: I need to look into the Cinder and Nova schedules | 14:27 |
ildikov | lbragstad: will try to do that later today | 14:28 |
jungleboyj | ildikov: I have the schedule out there. | 14:28 |
* jungleboyj needs to start putting things on the calendar too. :-) | 14:28 | |
lbragstad | jungleboyj: thanks | 14:28 |
lbragstad | i have you both down for that one | 14:28 |
lbragstad | that discussion is tentatively set for monday afternoon | 14:28 |
jungleboyj | lbragstad: Ok, there is discussion around that in the Cinder/Nova cross project session as well. | 14:29 |
jungleboyj | lbragstad: Let me know when that is so I can try to save time. | 14:29 |
lbragstad | jungleboyj: sounds good - i'll have the schedule somewhat set and fleshed out in a couple hours | 14:30 |
*** edmondsw has quit IRC | 14:30 | |
lbragstad | i'll send a note to the ML about it asking for feedback and alternatives if people see conflicts | 14:30 |
jungleboyj | Ok, Preferably before 4pm as I do have another meeting at that time. | 14:31 |
lbragstad | jungleboyj: done - i have you slated for a time slot right after lunch | 14:33 |
jungleboyj | lbragstad: Nice. Thanks buddy. | 14:34 |
lbragstad | jungleboyj: yessir! | 14:34 |
johnthetubaguy | ildikov: are you around to talk about this patch? https://review.openstack.org/#/c/493323/10 | 14:34 |
* jungleboyj is happy to see johnthetubaguy again! | 14:35 | |
ildikov | johnthetubaguy: are you around in an hour from now? | 14:35 |
* johnthetubaguy waves | 14:35 | |
ildikov | johnthetubaguy: I need to get to a conference location and switch to my laptop from the phone :) | 14:36 |
johnthetubaguy | ildikov: I probably can be, ping me when you are free | 14:36 |
johnthetubaguy | ildikov: no worries | 14:36 |
*** lucasxu has joined #openstack-cinder | 14:36 | |
johnthetubaguy | ildikov: hope the conference isn't making you too edge-ey | 14:37 |
ildikov | johnthetubaguy: will do, and we're supposed to have the Cinder-Nova meeting today too | 14:37 |
*** edmondsw has joined #openstack-cinder | 14:37 | |
johnthetubaguy | ildikov: yeah, could wait till then I guess | 14:37 |
ildikov | johnthetubaguy: lol, I hope to see you next week and then you can tell :) | 14:38 |
ildikov | johnthetubaguy: will try to ping you before | 14:38 |
*** lucasxu has quit IRC | 14:41 | |
*** juzuluag_ has joined #openstack-cinder | 14:53 | |
*** juzuluag_ has quit IRC | 14:54 | |
*** felipemonteiro has joined #openstack-cinder | 14:58 | |
*** felipemonteiro_ has joined #openstack-cinder | 14:59 | |
*** markstur has joined #openstack-cinder | 15:00 | |
*** felipemonteiro has quit IRC | 15:03 | |
*** crose has quit IRC | 15:05 | |
ildikov | johnthetubaguy: I bumped all the versions in this patch where we start to use attachment_create: https://review.openstack.org/#/c/330285/133 | 15:14 |
ildikov | johnthetubaguy: I usually try to keep the patches clean and change what's necessary, so I bumped the versions later | 15:15 |
ildikov | johnthetubaguy: I can change that in the first patch if you think | 15:15 |
*** armax has joined #openstack-cinder | 15:19 | |
*** armax has quit IRC | 15:20 | |
mriedem | what is there to say in the vm/bm room at the ptg about multi-attach? | 15:22 |
mriedem | "we want it." | 15:22 |
mriedem | "ok, we're working on it." | 15:22 |
mriedem | god i can already tell i'm going to hate monday and tuesday | 15:24 |
*** nicolasbock has joined #openstack-cinder | 15:26 | |
ildikov | lbragstad: I'm pretty booked Tuesday afternoon with the ETSI NFV - OpenStack workshop | 15:26 |
ildikov | lbragstad: is there any chance to move the multi-attach discussion to any time earlier? | 15:27 |
*** itlinux has joined #openstack-cinder | 15:27 | |
ildikov | mriedem: and as we are planning to talk about multi-attach for Nova too you will then hate Thursday too? | 15:27 |
lbragstad | ildikov: what if we swap the multi-attach session with the mixed quota session on monday? | 15:27 |
smcginnis | I wish that ETSI thing was at a better time. I'm curious about that. Would be nice to sit in, but no chance for me. | 15:28 |
ildikov | lbragstad: that should work for me | 15:28 |
ildikov | smcginnis: they have their workshop in Denver that week, so we were very constrained on possible time slots with this :( | 15:29 |
lbragstad | ildikov: done - multi-attach is slated for monday at 15:20 | 15:29 |
smcginnis | ildikov: Yeah. I am glad it's taking place. Great that there can be some overlap. | 15:29 |
smcginnis | ildikov: But I want it on MY schedule. :D | 15:29 |
ildikov | smcginnis: but if you know anyone who would be interested, please spread the word as it would be great to get OpenStack developers in the room too | 15:29 |
ildikov | smcginnis: are you fully booked for Tuesday? | 15:30 |
ildikov | lbragstad: awesome, thank you! | 15:30 |
lbragstad | ildikov: yep - thanks for the heads up | 15:30 |
sdague | lbragstad: what are the goals? | 15:30 |
smcginnis | ildikov: I think I'm fully double booked. | 15:30 |
sdague | I get very suspicious of agenda items without goals defined upfront | 15:30 |
ildikov | smcginnis: :( | 15:30 |
*** crose has joined #openstack-cinder | 15:32 | |
jungleboyj | Sounds like mriedem needs a hug already. ;-) | 15:33 |
ildikov | jungleboyj: mriedem: we can do a group hug Monday afternoon ;) | 15:36 |
mriedem | ildikov: the thursday session is a design session more or less | 15:38 |
jungleboyj | ildikov: Works for me. :-) | 15:38 |
ildikov | mriedem: I meant the topic rather than the nature of the session | 15:38 |
ildikov | mriedem: just don't hate me, I'm just a messenger you know :) | 15:39 |
*** juzuluag has joined #openstack-cinder | 15:41 | |
johnthetubaguy | ildikov: OK, got you, I would be tempted to bump them all (and create a constant), but that might just be me | 15:46 |
ildikov | johnthetubaguy: that sounds like a good option too | 15:49 |
ildikov | johnthetubaguy: I'm not strongly opinionated on this one, what the majority prefers works | 15:49 |
ildikov | johnthetubaguy: I tried to keep the change minimal as an intention so we can figure out these details easier and get this done | 15:49 |
*** itlinux has quit IRC | 15:55 | |
*** xyang has quit IRC | 15:58 | |
*** itlinux has joined #openstack-cinder | 15:58 | |
johnthetubaguy | ildikov: yeah, appreciate that, just made me double take for some reason | 16:00 |
*** itlinux has quit IRC | 16:06 | |
*** Apoorva has joined #openstack-cinder | 16:08 | |
*** e0ne has quit IRC | 16:16 | |
openstackgerrit | Chhavi Agarwal proposed openstack/os-brick master: FC PPC64 device discovery issue https://review.openstack.org/501253 | 16:27 |
*** itlinux has joined #openstack-cinder | 16:36 | |
*** armax has joined #openstack-cinder | 16:44 | |
*** rcernin has quit IRC | 16:45 | |
*** itlinux has quit IRC | 16:48 | |
*** edmondsw has quit IRC | 16:49 | |
*** armax has quit IRC | 16:50 | |
*** junbo has quit IRC | 16:50 | |
*** itlinux has joined #openstack-cinder | 16:51 | |
*** edmondsw has joined #openstack-cinder | 16:51 | |
*** edmondsw_ has joined #openstack-cinder | 16:55 | |
*** crushil has quit IRC | 16:55 | |
*** junbo has joined #openstack-cinder | 16:55 | |
*** edmondsw has quit IRC | 16:56 | |
*** edmondsw_ has quit IRC | 16:57 | |
*** edmondsw has joined #openstack-cinder | 16:57 | |
*** edmondsw has quit IRC | 17:00 | |
ildikov | johnthetubaguy: we will also try to get around the Cinder side for multi-attach next week before the joint session | 17:01 |
*** blznblzn2 has quit IRC | 17:01 | |
*** crushil has joined #openstack-cinder | 17:01 | |
*** itlinux has quit IRC | 17:02 | |
*** blznblzn2 has joined #openstack-cinder | 17:03 | |
openstackgerrit | Merged openstack/cinder master: Implement keymgr list() method https://review.openstack.org/501398 | 17:04 |
*** juzuluag has quit IRC | 17:04 | |
mriedem | jgriffith: jungleboyj: smcginnis: you guys skip microversions in cinderclient https://review.openstack.org/#/c/493263/2/cinderclient/api_versions.py ? | 17:06 |
mriedem | like, what if someone requests 3.41-3.43? | 17:06 |
jungleboyj | Oy, what happened there? | 17:08 |
jgriffith | hmm | 17:08 |
jgriffith | Oh.. wait | 17:09 |
jungleboyj | jgriffith: Please tell me we didn't screw up. | 17:09 |
smcginnis | mriedem: I'm not following. That's the max version. | 17:09 |
jgriffith | IIRC I didn't "skip" somebody else never updated... lemme look | 17:09 |
smcginnis | https://github.com/openstack/cinder/blob/master/cinder/api/openstack/rest_api_version_history.rst | 17:09 |
jungleboyj | smcginnis: Oh yeah. | 17:09 |
jungleboyj | This was updating the client to catch up with the server. | 17:10 |
mriedem | yeah, i get that | 17:10 |
jgriffith | jungleboyj smcginnis his point is my commit | 17:10 |
*** edmondsw has joined #openstack-cinder | 17:10 | |
jgriffith | Jumped from 3.40 to 3.44 | 17:10 |
jgriffith | which when you see it is like WTF? | 17:10 |
mriedem | just figured, for example, 3.41 to show the user_id in show snapshot would be implemented first | 17:10 |
jgriffith | mriedem +1 | 17:10 |
smcginnis | So we had server side changes that never made it to the client? | 17:11 |
jgriffith | smcginnis correct | 17:11 |
jgriffith | and still do I believe | 17:11 |
smcginnis | Well that's bs. | 17:11 |
smcginnis | :) | 17:11 |
jgriffith | :) | 17:11 |
* jungleboyj sighs | 17:11 | |
mriedem | and whatever "Support backup CRUD with metadata." means for 3.42 | 17:11 |
mriedem | *3.43 | 17:11 |
mriedem | i suppose that's a new request entry | 17:11 |
mriedem | when doing backup, providing metadata | 17:12 |
smcginnis | Yep | 17:12 |
jgriffith | so honestly I didn't know how else to deal with this | 17:12 |
ildikov | jgriffith: blame me :) | 17:12 |
jgriffith | and I wasn't going to go back and implement the missing steps there | 17:12 |
mriedem | well, part of it is review | 17:12 |
mriedem | in novaclient we require each microversion is implemented in order, | 17:12 |
mriedem | and have a unit test for it, sec | 17:12 |
smcginnis | Yeah, we should have caught that those client side changes never landed. | 17:12 |
jgriffith | mriedem yeah, another thing about MV's that is going to be problematic | 17:12 |
jgriffith | lock step | 17:12 |
jungleboyj | smcginnis: ++ | 17:12 |
mriedem | well, that's the idea | 17:13 |
jgriffith | sequential | 17:13 |
jgriffith | whatevs | 17:13 |
mriedem | this isn't alembic | 17:13 |
jgriffith | haha | 17:13 |
smcginnis | We should really require that there is a client side patch with a depends-on for server side API changes. | 17:13 |
openstackgerrit | Merged openstack/cinder master: Fix attachments on volume show when volume is attaching https://review.openstack.org/500102 | 17:13 |
jgriffith | @smcginnis s/should/need to/ | 17:13 |
smcginnis | Yep | 17:13 |
jgriffith | we really don't have a choice going forward IMO | 17:13 |
jungleboyj | Agreed. | 17:13 |
smcginnis | Still doesn't prevent 3.46 landing before 3.45 though. | 17:14 |
mriedem | https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/v2/test_shell.py#L3088 | 17:14 |
mriedem | ^ is a test for the novaclient cli | 17:14 |
jgriffith | smcginnis which is the problem I had when I looked at it | 17:14 |
mriedem | which looks for version decorated CLI methods, | 17:14 |
mriedem | and allows to skip some if they don't apply | 17:14 |
jgriffith | and it kinda screws things up because say for example 3.44 NEVER lands | 17:14 |
mriedem | but at least then you know things are going in order | 17:14 |
jgriffith | the whole thing is not so great IMO | 17:14 |
*** edmondsw has quit IRC | 17:14 | |
mriedem | on the server side, people are just competing for the next available microversion during dev | 17:15 |
*** itlinux has joined #openstack-cinder | 17:15 | |
mriedem | unless you conciously order them | 17:15 |
jgriffith | smcginnis so then we have server changes dep on client changes that dep on other client changes that dep from other server changes :) | 17:15 |
smcginnis | Theoretically, both changes should probably be 3.45 until whoever wins the race, so I guess it kind of sorts itself out as long as we enforce the client change is present. | 17:15 |
mriedem | smcginnis: that's how we do it | 17:15 |
smcginnis | jgriffith: Sounds like a house of cards. Oh wait... :) | 17:15 |
mriedem | the client change depends on the server change | 17:15 |
jgriffith | smcginnis :) | 17:15 |
mriedem | and the server change is the next highest available microversion that isn't merged yet | 17:16 |
jgriffith | smcginnis if you want some entertainment go look at our gophercloud discussions on how to deal with this stuff | 17:16 |
smcginnis | I'm afraid to. | 17:16 |
smcginnis | We have a 3.23 client change sitting out there yet too. And some of these not even pushed yet. | 17:18 |
jgriffith | yup | 17:18 |
jgriffith | so I bumped to get my change in :) | 17:18 |
jgriffith | which was a dirty trick | 17:18 |
*** harlowja has joined #openstack-cinder | 17:19 | |
smcginnis | jungleboyj: Looks like we have another PTG topic to discuss. | 17:19 |
jgriffith | and I should be punished | 17:19 |
smcginnis | And some quick catch up work to do. | 17:19 |
jungleboyj | smcginnis: Agreed. | 17:19 |
* smcginnis wraps jgriffith's knuckles with a ruler | 17:19 | |
mriedem | well, look who approved it | 17:19 |
jgriffith | thank you sir may I please have another :) | 17:19 |
mriedem | anyway | 17:20 |
* mriedem leaves | 17:20 | |
* jungleboyj is staying quiet lest mriedem wraps me. | 17:20 | |
jgriffith | mriedem cya, thanks for stopping by... always a pleasure :) | 17:20 |
jungleboyj | he he | 17:21 |
*** edmondsw has joined #openstack-cinder | 17:21 | |
*** itlinux has quit IRC | 17:21 | |
jungleboyj | smcginnis: I guess I will tack that on Wednesday as it seems to be an important issue. | 17:21 |
openstackgerrit | Merged openstack/cinder master: VStorage: make logging path configurable https://review.openstack.org/458560 | 17:22 |
*** tesseract has quit IRC | 17:23 | |
smcginnis | jungleboyj: Yeah, good call. | 17:23 |
*** chlong has joined #openstack-cinder | 17:24 | |
*** edmondsw has quit IRC | 17:25 | |
*** psachin has quit IRC | 17:31 | |
*** crose has quit IRC | 17:33 | |
*** edmondsw has joined #openstack-cinder | 17:33 | |
*** gouthamr has quit IRC | 17:33 | |
*** cknight has joined #openstack-cinder | 17:36 | |
*** edmondsw has quit IRC | 17:37 | |
*** edmondsw has joined #openstack-cinder | 17:37 | |
*** e0ne has joined #openstack-cinder | 17:38 | |
*** e0ne_ has joined #openstack-cinder | 17:42 | |
*** e0ne has quit IRC | 17:45 | |
*** chhavi has quit IRC | 17:45 | |
*** xyang has joined #openstack-cinder | 17:46 | |
*** edmondsw has quit IRC | 17:49 | |
*** lkuchlan_wfh has joined #openstack-cinder | 17:53 | |
*** jmlowe has joined #openstack-cinder | 17:55 | |
hemna | oh man. Just saw the thread on screen being removed from devstack. Completely blows. :( | 17:55 |
*** jmlowe_ has quit IRC | 17:57 | |
*** edmondsw has joined #openstack-cinder | 17:59 | |
*** gouthamr has joined #openstack-cinder | 18:01 | |
*** juzuluag has joined #openstack-cinder | 18:02 | |
jungleboyj | hemna: Totally agree! | 18:05 |
jungleboyj | Really wish somone would have pushed back. | 18:06 |
*** jmlowe has quit IRC | 18:06 | |
*** jmlowe has joined #openstack-cinder | 18:06 | |
*** liverpooler has quit IRC | 18:07 | |
*** xyang has quit IRC | 18:10 | |
*** Apoorva has quit IRC | 18:11 | |
*** edmondsw has quit IRC | 18:18 | |
*** lkuchlan_wfh has quit IRC | 18:18 | |
*** edmondsw has joined #openstack-cinder | 18:24 | |
*** dims has quit IRC | 18:34 | |
*** dims has joined #openstack-cinder | 18:36 | |
*** dims has quit IRC | 18:41 | |
*** sdague has quit IRC | 18:42 | |
*** edmondsw has quit IRC | 18:44 | |
*** dims has joined #openstack-cinder | 18:45 | |
*** Apoorva has joined #openstack-cinder | 18:46 | |
e0ne_ | jungleboyj, hemna: FYI, if you don't find it already https://docs.openstack.org/devstack/latest/systemd.html | 18:46 |
e0ne_ | but I agree that screen was good and useful, such as re-join.sh sometimes | 18:46 |
jungleboyj | e0ne_: I know. What I may end up doing is just making sure I have rsyslog running on my devstack systems. I had using journalctl | 18:47 |
*** edmondsw has joined #openstack-cinder | 18:48 | |
*** edmondsw has quit IRC | 18:48 | |
*** boris_42 has quit IRC | 18:50 | |
*** chlong has quit IRC | 18:51 | |
*** chlong_ has joined #openstack-cinder | 18:51 | |
*** edmondsw has joined #openstack-cinder | 18:54 | |
*** xyang has joined #openstack-cinder | 18:57 | |
*** edmondsw has quit IRC | 18:57 | |
*** cknight has quit IRC | 18:57 | |
*** edmondsw has joined #openstack-cinder | 18:57 | |
*** edmondsw has quit IRC | 18:58 | |
*** xyang has quit IRC | 18:59 | |
*** e0ne_ has quit IRC | 19:03 | |
*** edmondsw_ has joined #openstack-cinder | 19:05 | |
*** chlong_ has quit IRC | 19:07 | |
*** alkhodos has joined #openstack-cinder | 19:08 | |
*** chlong_ has joined #openstack-cinder | 19:08 | |
*** edmondsw_ has quit IRC | 19:09 | |
smcginnis | jungleboyj, hemna: This is useful: https://review.openstack.org/501834 | 19:11 |
*** chlong__ has joined #openstack-cinder | 19:12 | |
*** chlong_ has quit IRC | 19:14 | |
*** xyang1 has joined #openstack-cinder | 19:15 | |
*** xyang has joined #openstack-cinder | 19:16 | |
*** xyang has quit IRC | 19:16 | |
*** Nel1x has joined #openstack-cinder | 19:16 | |
*** xyang has joined #openstack-cinder | 19:16 | |
Swanson | Death to screen. | 19:19 |
*** chlong__ has quit IRC | 19:26 | |
* jungleboyj glares at smcginnis | 19:27 | |
jungleboyj | smcginnis: Thanks, that is helpful. | 19:27 |
*** juzuluag has quit IRC | 19:27 | |
*** chlong_ has joined #openstack-cinder | 19:27 | |
*** pcaruana has quit IRC | 19:31 | |
*** chlong_ has quit IRC | 19:32 | |
*** chlong_ has joined #openstack-cinder | 19:33 | |
jungleboyj | smcginnis: How did you remove the authorship colors from the etherpad? | 19:33 |
smcginnis | jungleboyj: You click on the eye in the menu. | 19:35 |
jungleboyj | smcginnis: Thank you. | 19:35 |
*** edmondsw has joined #openstack-cinder | 19:37 | |
smcginnis | I fixed a requirements upgrade issue in several projects, and they have all merged except the one for Cinder. Where's the love?! :D | 19:38 |
smcginnis | https://review.openstack.org/#/c/501472/ | 19:38 |
mriedem | i'm back | 19:39 |
mriedem | https://bugs.launchpad.net/python-cinderclient/+bug/1715732 | 19:39 |
openstack | Launchpad bug 1715732 in python-cinderclient "VolumeAttachmentManager methods aren't using cinderclient.api_versions.wraps decorator for microversion boundaries" [Undecided,New] | 19:39 |
smcginnis | mriedem: Go away. | 19:40 |
smcginnis | mriedem: Yeah, looks legit. Seems we have a lot of work to do and need to get a new client out very soon. | 19:40 |
*** chlong__ has joined #openstack-cinder | 19:41 | |
*** chlong_ has quit IRC | 19:43 | |
mtreinish | jgriffith, smcginnis: have you seen this before: http://logs.openstack.org/76/501776/1/check/gate-cross-cinder-python35/e5acb38/console.html#_2017-09-07_15_49_59_354651 | 19:46 |
mtreinish | that's around where things fall apart, it's not the actual error | 19:46 |
mtreinish | I'm having a hard time figuring out where it's going wrong | 19:46 |
jgriffith | mtreinish I haven't actually | 19:46 |
smcginnis | On DB creation? | 19:46 |
mtreinish | does anything call exit() in the unit tests? | 19:48 |
*** Apoorva has quit IRC | 19:48 | |
mtreinish | smcginnis: I'm not sure it's the db creation, it looks like it logs that every time it creates a db | 19:48 |
mtreinish | part of the problem is the output filter is failing because there is some kind of non-text attachment in the subunit stream | 19:49 |
mtreinish | http://logs.openstack.org/76/501776/1/check/gate-cross-cinder-python35/e5acb38/console.html#_2017-09-07_15_54_02_744517 | 19:49 |
mtreinish | but that's likely caused by an earlier failure | 19:49 |
smcginnis | This looks really odd: Short read - got 4090 bytes, wanted 4227 bytes | 19:49 |
*** armax has joined #openstack-cinder | 19:50 | |
*** itlinux has joined #openstack-cinder | 19:50 | |
smcginnis | mtreinish: Do you know if there were a lot of changes to os-testr? | 19:50 |
mtreinish | smcginnis: this is something I'm debugging as part of the new ostestr release | 19:51 |
mtreinish | it changed the internals from using testr in a subprocess to stestr called directly | 19:51 |
smcginnis | mtreinish: Yeah, just curious what all went into that release. | 19:51 |
smcginnis | Ah, so pretty big then. | 19:51 |
mtreinish | yeah | 19:51 |
mtreinish | but from the actual execution of the tests stestr and testr are more or less identical | 19:51 |
mtreinish | but there might be a difference in how the output is being handled which could be causing this | 19:52 |
smcginnis | Well, I'm close to hitting ESTACKOVERFLOW on my queue right now, but once I catch up I can try to take a look a little more. | 19:52 |
*** itlinux has quit IRC | 19:53 | |
mtreinish | ok, now worries I'll keep digging | 19:53 |
*** edmondsw has quit IRC | 19:53 | |
*** edmondsw has joined #openstack-cinder | 19:53 | |
*** itlinux has joined #openstack-cinder | 19:54 | |
*** edmondsw has quit IRC | 19:58 | |
mtreinish | smcginnis: oh, the other thing worth noting is this only fails on py35 | 20:06 |
mtreinish | py27 worked fine with the new ostestr release | 20:06 |
mtreinish | smcginnis: hmm it worked on the most recent run: http://logs.openstack.org/76/501776/2/check/gate-cross-cinder-python35/9ca5c14/console.html | 20:09 |
smcginnis | mtreinish: Hmm. Hopefully it was just a quirk and not an intermittent issue. | 20:12 |
smcginnis | mtreinish: I wonder if we should recheck that a few times to see if we get consistent results. | 20:12 |
smcginnis | Or just run it locally a few times I suppose would make more sense. :) | 20:12 |
mtreinish | smcginnis: I wouldn't want to do that here, the requirements patches run too many jobs | 20:12 |
mtreinish | that'd eat too many resources | 20:12 |
mtreinish | but running it locally is an option I'll have to build a vm somewhere that has py35 | 20:13 |
smcginnis | Yeah, as I wrote that I actually thought about what that would mean. Probably a bad idea. | 20:13 |
mtreinish | all my systems only have 36 (don't think I have a xenial image handy) | 20:13 |
*** edmondsw has joined #openstack-cinder | 20:14 | |
*** itlinux has quit IRC | 20:15 | |
*** diablo_rojo has joined #openstack-cinder | 20:16 | |
*** crushil has quit IRC | 20:26 | |
*** Apoorva has joined #openstack-cinder | 20:31 | |
*** crushil has joined #openstack-cinder | 20:38 | |
*** armax has quit IRC | 20:40 | |
*** armax has joined #openstack-cinder | 20:40 | |
*** armax has quit IRC | 20:40 | |
*** chlong__ has quit IRC | 20:42 | |
jungleboyj | diablo_rojo: Is lunch time at the PTG 12 to 1:30 ? | 20:45 |
diablo_rojo | Technically its just 12-1 but you can tell people to take an extra half hour. | 20:46 |
diablo_rojo | jungleboyj, ^^ | 20:46 |
jungleboyj | diablo_rojo: Ok, one document had it going to 1:30, wanted to make sure that 12 was the starting time. | 20:46 |
jungleboyj | ildikov: Was worried that it might start at 11. | 20:46 |
jungleboyj | diablo_rojo: Thanks for conforming the 12:00 time. | 20:47 |
jgriffith | smcginnis jungleboyj one thing to keep in mind with the version jump/skip thing.... | 20:47 |
jgriffith | smcginnis jungleboyj 41 just adds a field to the view... 42 removes the in-use check (which is in volume.api I think) | 20:47 |
jgriffith | 43 is in flight | 20:48 |
jgriffith | so... other than merging weird; kinda nothing to see here? | 20:48 |
smcginnis | jgriffith: How did you end up with 44 if we haven't landed 43? | 20:48 |
smcginnis | jgriffith: Or are you saying the client side of it is in flight? | 20:48 |
jgriffith | smcginnis Yeah, saying the client side for 43 was in flight IIRC | 20:48 |
jgriffith | lemme look for it | 20:48 |
jungleboyj | jgriffith: I was wondering what we would do for things that didn't have a client side changes. | 20:48 |
jungleboyj | Figured that was something we needed to talk about. | 20:49 |
smcginnis | So Nova didn't have any response-only changes yet? | 20:49 |
*** catintheroof has quit IRC | 20:49 | |
*** catintheroof has joined #openstack-cinder | 20:49 | |
jungleboyj | That would seem unlikely. :-) | 20:50 |
*** catintheroof has quit IRC | 20:50 | |
smcginnis | mriedem: Have you had any mv bumps that just changed the returned properties? ^^ | 20:51 |
mriedem | changed the returned properties | 20:52 |
mriedem | like, not a new key in the response body? | 20:52 |
mriedem | just a different value? | 20:52 |
*** armax has joined #openstack-cinder | 20:52 | |
mriedem | we've had response only changes, | 20:53 |
mriedem | like the aggregates API was changed to return a uuid for the id field rather than an integer | 20:53 |
mriedem | but, don't think we needed to change the client for that | 20:53 |
* mriedem looks | 20:53 | |
jungleboyj | mriedem: So we are wondering how you handled that. | 20:53 |
mriedem | https://review.openstack.org/#/c/417265/ | 20:54 |
*** wanghao_ has joined #openstack-cinder | 20:54 | |
mriedem | oh i guess this one had a new key in the response | 20:55 |
smcginnis | mriedem: Ah, so it just gets added to the "exclusions" list. | 20:55 |
mriedem | no https://review.openstack.org/#/c/417265/2/novaclient/v2/shell.py@3740 | 20:55 |
*** dave-mccowan has quit IRC | 20:55 | |
mriedem | it added a column to the table output | 20:55 |
smcginnis | https://review.openstack.org/#/c/417265/2/novaclient/tests/unit/v2/test_shell.py@3304 | 20:56 |
mriedem | https://review.openstack.org/#/c/417265/2/novaclient/tests/unit/v2/test_shell.py@3304 is limited | 20:56 |
mriedem | ^ is only check for shell methods which use the api_versions.wraps decorator | 20:56 |
*** abishop has quit IRC | 20:56 | |
mriedem | so it depends on how you implement the shell side of things | 20:56 |
*** wanghao has quit IRC | 20:56 | |
mriedem | i could have done a new method with the decorator, | 20:56 |
mriedem | but i chose to just inline it in the existing method | 20:56 |
*** dustins has quit IRC | 20:56 | |
mriedem | yeah so in 2.41 we returned the int id and uuid as a new key, | 20:57 |
mriedem | we had another one where the id key value changed from an int to a uuid | 20:57 |
mriedem | 2.53 i think | 20:57 |
mriedem | https://review.openstack.org/#/c/485435/ | 20:57 |
mriedem | that one is a lot bigger than just that change, because we changed the formats of several other PUT methods in 2 different APIs | 20:58 |
*** itlinux has joined #openstack-cinder | 20:58 | |
mriedem | it was basically a pretty large rewrite of two apis | 20:58 |
smcginnis | OK, think I got it. Thanks. | 20:59 |
mriedem | so https://review.openstack.org/#/c/485435/6/novaclient/v2/shell.py@3583 | 20:59 |
mriedem | do_service_delete | 20:59 |
mriedem | 2 methods there | 20:59 |
mriedem | could have been one since they both just take an id | 20:59 |
mriedem | but i split them for the help message | 20:59 |
*** scottda_ has joined #openstack-cinder | 20:59 | |
mriedem | so it just kind of depends on the change and what you want to show in the client | 21:00 |
jgriffith | mriedem so part of the confusion I *think*... is for example 3.41 | 21:00 |
mriedem | not all microversions require big changes to the client besides bumping the max version | 21:00 |
jgriffith | 3.41 added a field user_id to snapshot list/detail | 21:00 |
jgriffith | But | 21:00 |
jungleboyj | mriedem: That was what I was wondering. | 21:00 |
mriedem | in the response? | 21:00 |
jgriffith | That's all handled by the view builder on the server side | 21:00 |
jgriffith | mriedem yes | 21:00 |
jungleboyj | mriedem: At a minimum though, there should be a client change that notes a bump on the server side. | 21:00 |
mriedem | so i assume you have a cinder snapshot-show CLI | 21:00 |
jgriffith | there's an additional field in the response from that | 21:01 |
mriedem | if you wanted to show the user_id in the CLI table output for snapshot-show, then that's your CLI side microversion change, but if you don't plan on showing that in the table output... | 21:01 |
jgriffith | So my assumption is that when that change was made since the only modification needed was server side (view builder) that the CLI was never done | 21:01 |
mriedem | the python API binding side for that is probably no change | 21:01 |
*** itlinux has quit IRC | 21:01 | |
jgriffith | mriedem well... no | 21:01 |
jgriffith | mriedem if I wanted to see the user_id in the response from the cli, then I say "OS_VOLUME_API_VERSION=3.41" | 21:02 |
jgriffith | and the CLI just parses out the view/dict that's returned | 21:02 |
mriedem | https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/shell.py#L1716 | 21:02 |
mriedem | no it doesn't | 21:02 |
mriedem | because the table columns are whitelisted | 21:02 |
jgriffith | mriedem yeah, it just so happens that that particular example doesn't work from the CLI :) | 21:03 |
jgriffith | but does work from a python call | 21:03 |
jgriffith | go figure | 21:03 |
mriedem | the python api binding code is less of a problem | 21:03 |
jgriffith | mriedem right | 21:04 |
mriedem | the api code is mostly only affected when a request changes | 21:04 |
mriedem | for new or removed keys | 21:04 |
jgriffith | mriedem yes | 21:04 |
jgriffith | things can get ugly | 21:04 |
jgriffith | what's worse is trying to write other binding for this :( | 21:05 |
jgriffith | but that's another channel | 21:05 |
*** itlinux has joined #openstack-cinder | 21:05 | |
*** itlinux has quit IRC | 21:05 | |
jgriffith | mriedem anyway, I'm in the process of patching the client to add the missing items | 21:05 |
*** esker has quit IRC | 21:05 | |
jgriffith | but enforcing this going forward is going to be *fun*, unless we start being a little more selective about MV bumps which would be nice | 21:05 |
jgriffith | we're kind of abusing the whole thing IMO | 21:06 |
jgriffith | Like this change for example... why we need user_id in the list results for a snapshot is beyond me | 21:07 |
mriedem | well, can a snapshot be created on behalf of another user? | 21:09 |
mriedem | we have a microversion where you can create a keypair as an admin on behalf of another user | 21:10 |
*** itlinux has joined #openstack-cinder | 21:10 | |
mriedem | so in that case, knowing the owner of the keypair is useful in the response | 21:10 |
jgriffith | I'm aware | 21:10 |
jgriffith | and no, it can not | 21:11 |
mriedem | i agree it's an awkward line, and we've started doubling up things into a single microversion recently | 21:11 |
jgriffith | in Cinder, there isn't a mechanism to do that | 21:11 |
mriedem | to avoid having 10 microversions for 10 little things, | 21:11 |
mriedem | we've been merging some similar changes into a single microversion, like with deprecations | 21:11 |
jgriffith | mriedem yeah, I'd still like to see a single mv per release, but people will throw things at me again for saying it out loud | 21:11 |
jgriffith | and yes, I know... "but what about the poor rolling release folks" | 21:12 |
mriedem | the hardest part about doing more things in a single microversion is being able to clearly document what they all are | 21:12 |
jgriffith | blah blah blah | 21:12 |
mriedem | plus, | 21:12 |
mriedem | the giant api patch that contains them all | 21:12 |
jgriffith | Sure, nothing is perfect | 21:12 |
jgriffith | nah, not a single patch | 21:12 |
jgriffith | as you go... open a new MV at beginning of release | 21:12 |
jgriffith | anything new uses it | 21:12 |
jgriffith | end or release, bump | 21:12 |
jgriffith | start over | 21:13 |
jgriffith | rinse, repeat | 21:13 |
mriedem | sure, which isn't CD | 21:13 |
mriedem | but i know you don't care | 21:13 |
mriedem | so let's just stop talking about this | 21:13 |
jgriffith | mriedem well it's not that I don't care | 21:13 |
jgriffith | mriedem I do.. and I think that's a problem that can be solved | 21:13 |
jgriffith | it creates problems with querying where things are at during a release cycle | 21:14 |
* smcginnis would love 1 bump per cycle | 21:14 | |
jgriffith | but anyway | 21:14 |
mriedem | do you care about this? https://review.openstack.org/501874 | 21:14 |
jgriffith | I think MV's is a great step forward, I just think we're learning as we go a little bit and it's worth at least thinking about and discussing things a bit | 21:15 |
jgriffith | I care so much that I gave it a +1 | 21:15 |
smcginnis | One API version to rule them all! | 21:16 |
jgriffith | smcginnis +1 | 21:16 |
jgriffith | wait... no... +2 | 21:16 |
jgriffith | me +0 | 21:16 |
smcginnis | [and a bunch of tiny micro versions to follow it] | 21:16 |
smcginnis | :] | 21:16 |
jgriffith | exactly | 21:17 |
jgriffith | 44 of them to be exact | 21:17 |
smcginnis | jgriffith: Did you see https://review.openstack.org/#/c/499342/ | 21:17 |
smcginnis | +51, -1954 | 21:17 |
jgriffith | I did, thought I approved that last night | 21:17 |
smcginnis | Sweet Christmas | 21:17 |
jgriffith | smcginnis oh.. I remember my hesitation | 21:18 |
jgriffith | added a comment, is it worth posting to ML and informing everyone that we're doing this? | 21:19 |
jgriffith | Or since we have followed the process and allowed ample time just remove it and move on | 21:19 |
jgriffith | I'm leaning towards just removing it and being done | 21:19 |
smcginnis | Oh, missed your comment there. Yeah, probably should. To openstack-operators too. | 21:19 |
smcginnis | We could do that post I suppose. | 21:19 |
smcginnis | I'll do that now though. | 21:19 |
jgriffith | meh, I'm going to merge it | 21:20 |
smcginnis | Just close your eyes and click. | 21:20 |
jgriffith | and hold my breath | 21:20 |
jgriffith | frankly I'm nervous doing anything with API's or Objects etc any more | 21:21 |
jgriffith | There's a 90% chance it's going to be *wrong* | 21:21 |
smcginnis | Yeah... this ones a little overdue IMO though. | 21:21 |
smcginnis | Someone wil complain. | 21:21 |
jgriffith | I agree 10000% | 21:21 |
jgriffith | about it being overdue | 21:21 |
smcginnis | But it's not like we're ripping out the fundamental way that our services are running or anything. | 21:21 |
jgriffith | and about someone complaining :) | 21:21 |
*** armax has quit IRC | 21:22 | |
*** armax has joined #openstack-cinder | 21:25 | |
*** edmondsw has quit IRC | 21:32 | |
*** edmondsw has joined #openstack-cinder | 21:34 | |
*** xyang has quit IRC | 21:37 | |
*** xyang has joined #openstack-cinder | 21:37 | |
*** edmondsw has quit IRC | 21:38 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Use conditional update for group update and delete https://review.openstack.org/500194 | 21:42 |
jungleboyj | Sorry, had to step away for a bit. | 21:42 |
jungleboyj | mriedem: jgriffith Isn't rolling multiple changes into an MV against everything the MVs awere created for? | 21:43 |
jungleboyj | We either need to agree to bump once a release or to go with a per change MV? Otherwise we get bogged down arguing about what goes into what MV. | 21:43 |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Remove Coho volume driver https://review.openstack.org/501327 | 21:44 |
mriedem | jungleboyj: it's 4:45 so i'm not going to talk about it today | 21:45 |
jungleboyj | mriedem: Fair enough. | 21:46 |
*** felipemonteiro_ has quit IRC | 21:46 | |
smcginnis | jungleboyj: ""against everything the MVs | 21:49 |
smcginnis | awere created for? | 21:49 |
smcginnis | I don't think so. It's against those that say it's been a "fundamental principle from the beginning" that you can deploy from master at any point. | 21:50 |
jungleboyj | smcginnis: Yeah, I thought the whole point of the Microversions was to have small independent changes. | 21:50 |
*** itlinux has quit IRC | 21:51 | |
smcginnis | I think it's to be able to have incremental changes. Now whether that increment is granular to an individual commit or an individual official "release" is the part that's somewhat controversial. | 21:51 |
*** armax has quit IRC | 21:53 | |
jgriffith | jungleboyj think of it this way... the ability to query your endpoint and get a version that will depict *exactly* what API calls are available and how they will behave | 21:53 |
*** armax has joined #openstack-cinder | 21:54 | |
jgriffith | jungleboyj so for example xing's change that added groups api had multiple things added for a single MV and that's ok | 21:54 |
jgriffith | it all landed at once and turned on the new API's/Features | 21:54 |
jgriffith | the opposite of that is adding user_id to the response from snapshot-list | 21:54 |
jgriffith | That's a single/minor change | 21:54 |
jgriffith | but it's a behavioral change that you have to advertise to CD type folks inparticular somehow | 21:55 |
jgriffith | (not just CD but anyone for that matter) | 21:55 |
jungleboyj | jgriffith: I see what you mean. So saying a "single change" is incorrect. | 21:55 |
jungleboyj | I think we can agree though that a bump shouldn't include multiple unrelated changes. Correct? | 21:55 |
smcginnis | No. :) | 21:55 |
jgriffith | jungleboyj so that's the debate :) | 21:55 |
jgriffith | for me at least :) | 21:56 |
*** diablo_rojo has quit IRC | 21:56 | |
smcginnis | I'd rather it have multple unrelated changes. | 21:56 |
jgriffith | but you don't want to listen to me, or you'll just get yourself in trouble | 21:56 |
smcginnis | But if I ask for that version, I want all of those unrelated changes there. | 21:56 |
jungleboyj | smcginnis: Why? | 21:56 |
jgriffith | jungleboyj because it's WAY easier to manage and implement | 21:56 |
smcginnis | Because for me, I only care, am I talking to an Ocata cloud, am I talking to a Pike cloud. | 21:56 |
jungleboyj | jgriffith: Sure, if we do one bump per release. | 21:56 |
jungleboyj | smcginnis: Ok, I agree with that. | 21:57 |
jgriffith | and when people are trying to write SDK's and such they have a prayer of not wanting to jump off a bridge | 21:57 |
smcginnis | I don't care, am I talking to a 7e6abe65fea5e27ab2f9ea701e3f13e244d4ce2e cloud. | 21:57 |
jungleboyj | jgriffith: :-) | 21:57 |
jgriffith | smcginnis +1 | 21:57 |
jgriffith | My proposal for consumer sdk's is exactly what smcginnis describes | 21:57 |
jgriffith | otherwise it's madness for me to continually try and do all 44 iterations of a request | 21:58 |
jungleboyj | smcginnis: Ok, so I agree that is easier. But if we aren't going to do all the unrelated changes together for a release then we need to have a reasonable line we draw for what goes together. | 21:58 |
jgriffith | it's fine for things like python | 21:58 |
jgriffith | but in things like golang you don't have that inheritance nonsense to use :) | 21:58 |
smcginnis | Which brings us to the current state of version per commit. | 21:58 |
jgriffith | :) | 21:58 |
jungleboyj | smcginnis: Right. Not saying it is right. It is just how it is. | 21:58 |
jgriffith | Ok... only thing left to catch up is "backup_update" | 21:58 |
smcginnis | If we could agree version per "release" - because hey, it's an actual release - then everyone's life is simplier. | 21:59 |
jgriffith | haha! | 21:59 |
jgriffith | Oh I love this! | 21:59 |
*** armax has quit IRC | 21:59 | |
jgriffith | so backup_update is an extension in contribs | 21:59 |
smcginnis | PArticularly API consumers. | 21:59 |
jungleboyj | smcginnis: Agreed. | 22:00 |
jgriffith | and it has a micro-version | 22:00 |
jgriffith | weeee | 22:00 |
jungleboyj | :-( | 22:00 |
jgriffith | All of those backup calls should've been moved out of contrib when they were updated | 22:01 |
smcginnis | jgriffith: I haven't looked at that one, but I think the way we've been handling that for other extension ones is to leave the base extension bit in contrib and then the mv changes under the v3 api stuff. | 22:03 |
*** diablo_rojo has joined #openstack-cinder | 22:07 | |
*** mchlumsky has quit IRC | 22:10 | |
*** thegreenhundred has quit IRC | 22:11 | |
jungleboyj | smcginnis: Who is driving our policy-in-code work? Was that tommylikehu ? | 22:15 |
jgriffith | smcginnis https://github.com/openstack/cinder/blob/master/cinder/api/contrib/backups.py#L155 | 22:15 |
jgriffith | there's a number of those little things slid in there, which is far easier than moving it etc | 22:16 |
*** diablo_rojo_ has joined #openstack-cinder | 22:21 | |
jgriffith | smcginnis jungleboyj so the question is... should I move those under V3 now, or as a separate patch? Or not at all? | 22:23 |
jgriffith | smcginnis jungleboyj this is the change to catch up the versions: https://gist.github.com/anonymous/d8eaff052d315b2925ea7bc56b0413d6 | 22:24 |
*** diablo_rojo has quit IRC | 22:24 | |
jgriffith | wait | 22:24 |
jgriffith | never mind | 22:24 |
jgriffith | derp | 22:24 |
jgriffith | I'm not changing it on the server side | 22:24 |
jgriffith | that's SEP | 22:24 |
jgriffith | carry on | 22:25 |
jungleboyj | I don't see anything immediately wrong with that. | 22:26 |
jungleboyj | No change is needed for 3.42 ? | 22:26 |
jungleboyj | jgriffith: ^^ Just to clarify. | 22:27 |
jgriffith | jungleboyj 3.42 allows extend on an in-use volume; there's not changes in args, or responses to the call; just the status check on the server side | 22:28 |
*** armax has joined #openstack-cinder | 22:28 | |
jgriffith | an "in-use volume" even :) | 22:28 |
jungleboyj | jgriffith: Ok, so that would have just been a MAX_VERSION change if we had done it right. | 22:28 |
jungleboyj | OMG, as I am going to through the specs review list and looking at that and it is sitting there with that very question in the spec review. Guess that answers the question. | 22:29 |
jgriffith | jungleboyj correct | 22:30 |
smcginnis | We should probably talk about this at some point too. https://review.openstack.org/#/c/478447/ | 22:31 |
jgriffith | no | 22:31 |
jgriffith | :) | 22:31 |
* smcginnis just pours himself another glass of wine | 22:31 | |
jgriffith | smcginnis LOL | 22:31 |
smcginnis | Or is that whine. :) | 22:32 |
jgriffith | smcginnis so I'm in favor of this, we should replace force-delete with a force flag | 22:32 |
jgriffith | smcginnis a little of both perhaps? | 22:32 |
smcginnis | jgriffith: Yeah, I'm leaning that way. Deprecate force-delete, add delete --force with appropriate handling. | 22:32 |
* jungleboyj is about to go have scotch and sirloin | 22:34 | |
smcginnis | jungleboyj: Company expense - go with the filet mignon. | 22:35 |
jungleboyj | smcginnis: jgriffith Yeah, adding --force would be in line with other changes we have made. | 22:35 |
jungleboyj | smcginnis: Actually, Prime Rib. | 22:35 |
jungleboyj | http://www.scotchandsirloin.net/ | 22:36 |
*** xyang has quit IRC | 22:36 | |
smcginnis | I think all Cinder release notes should all start off with "We are exceptionally equipped" now. | 22:37 |
jungleboyj | smcginnis: Indeed! | 22:38 |
jungleboyj | I am just going to wear a tag that says that. | 22:38 |
jgriffith | smcginnis LOL | 22:38 |
smcginnis | OK, I better feed the offspring and dogs before they all start harrassing me. | 22:39 |
*** diablo_rojo__ has joined #openstack-cinder | 22:39 | |
*** sticker has joined #openstack-cinder | 22:41 | |
*** diablo_rojo_ has quit IRC | 22:42 | |
openstackgerrit | Merged openstack/cinder master: Remove API v1 https://review.openstack.org/499342 | 22:42 |
*** diablo_rojo_ has joined #openstack-cinder | 22:43 | |
*** chlong has joined #openstack-cinder | 22:44 | |
*** diablo_rojo__ has quit IRC | 22:46 | |
*** chlong has quit IRC | 22:51 | |
jgriffith | smcginnis ya gotta watch it.. they get hungry enough we'll find your half eaten remains in a week | 22:52 |
*** chlong has joined #openstack-cinder | 22:52 | |
*** Apoorva_ has joined #openstack-cinder | 22:59 | |
tommylikehu | jungleboyj: yes, what's up? | 23:00 |
*** Apoorva has quit IRC | 23:02 | |
*** itlinux has joined #openstack-cinder | 23:04 | |
*** itlinux has quit IRC | 23:04 | |
*** chlong_ has joined #openstack-cinder | 23:04 | |
*** chlong has quit IRC | 23:04 | |
*** armax has quit IRC | 23:05 | |
*** xyang1 has quit IRC | 23:06 | |
*** chlong_ has quit IRC | 23:09 | |
*** gouthamr has quit IRC | 23:09 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Use newer location for iso8601 UTC https://review.openstack.org/501472 | 23:18 |
*** diablo_rojo_ has quit IRC | 23:21 | |
*** diablo_rojo_ has joined #openstack-cinder | 23:22 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Remove Blockbridge volume driver https://review.openstack.org/501328 | 23:24 |
*** Apoorva has joined #openstack-cinder | 23:32 | |
*** Apoorva_ has quit IRC | 23:32 | |
openstackgerrit | John Griffith proposed openstack/python-cinderclient master: Implement UserID in snapshot list response https://review.openstack.org/501897 | 23:33 |
*** diablo_rojo_ has quit IRC | 23:43 | |
*** stakeda has joined #openstack-cinder | 23:49 | |
openstackgerrit | John Griffith proposed openstack/python-cinderclient master: Implement metadata for backup create/update https://review.openstack.org/501902 | 23:53 |
jgriffith | well I'm outa time, but will finish the one up tomorrow and address the bug mriedem filed as well | 23:54 |
jgriffith | and jump start my migrated CI :( | 23:55 |
*** gouthamr has joined #openstack-cinder | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!