| *** sbezverk has quit IRC | 00:06 | |
| *** yangyapeng has quit IRC | 00:11 | |
| *** yangyapeng has joined #openstack-cinder | 00:11 | |
| *** yangyapeng has quit IRC | 00:16 | |
| *** sdague has quit IRC | 00:19 | |
| *** lhx_ has joined #openstack-cinder | 00:24 | |
| *** Shunli has joined #openstack-cinder | 00:42 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 00:42 | |
| *** kaisers1 has joined #openstack-cinder | 00:44 | |
| *** kaisers has quit IRC | 00:46 | |
| *** AlexeyAbashkin has quit IRC | 00:47 | |
| *** wanghao_ has quit IRC | 00:50 | |
| *** wanghao has joined #openstack-cinder | 00:50 | |
| *** kwathore_ has joined #openstack-cinder | 00:57 | |
| *** kwathore has quit IRC | 01:00 | |
| *** lhx_ has quit IRC | 01:06 | |
| openstackgerrit | Merged openstack/cinder master: Deprecate SolidFire Image Caching feature https://review.openstack.org/511623 | 01:06 |
|---|---|---|
| *** stakeda has joined #openstack-cinder | 01:10 | |
| *** wanghao_ has joined #openstack-cinder | 01:16 | |
| *** Apoorva_ has joined #openstack-cinder | 01:17 | |
| *** wanghao has quit IRC | 01:18 | |
| *** yangyapeng has joined #openstack-cinder | 01:18 | |
| *** yangyapeng has quit IRC | 01:19 | |
| *** yangyapeng has joined #openstack-cinder | 01:19 | |
| *** yangyape_ has joined #openstack-cinder | 01:20 | |
| *** Apoorva has quit IRC | 01:20 | |
| *** Apoorva_ has quit IRC | 01:21 | |
| *** yangyapeng has quit IRC | 01:24 | |
| *** yangyape_ has quit IRC | 01:28 | |
| *** yangyapeng has joined #openstack-cinder | 01:29 | |
| openstackgerrit | Guy Kim proposed openstack/cinder master: Update configuration names in ITRI DISCO volume driver https://review.openstack.org/461665 | 01:32 |
| *** felipemonteiro has quit IRC | 01:36 | |
| openstackgerrit | qtlu proposed openstack/cinder master: Fix backup-import error when the deleted record in the same db https://review.openstack.org/502897 | 01:43 |
| *** AlexeyAbashkin has joined #openstack-cinder | 01:45 | |
| *** psachin has joined #openstack-cinder | 01:46 | |
| *** markvoelker has joined #openstack-cinder | 01:47 | |
| *** AlexeyAbashkin has quit IRC | 01:49 | |
| *** dhinesh has quit IRC | 01:56 | |
| openstackgerrit | Peter Wang proposed openstack/cinder master: Unity: Fix duplicate hosts created with same name https://review.openstack.org/511668 | 02:00 |
| *** chenying_ has joined #openstack-cinder | 02:06 | |
| *** mgagne has quit IRC | 02:19 | |
| *** markvoelker has quit IRC | 02:21 | |
| *** thingee has quit IRC | 02:22 | |
| *** mgagne has joined #openstack-cinder | 02:22 | |
| *** mgagne is now known as Guest53680 | 02:22 | |
| *** thingee has joined #openstack-cinder | 02:23 | |
| *** dave-mccowan has quit IRC | 02:41 | |
| openstackgerrit | Guy Kim proposed openstack/cinder master: Update configuration names in ITRI DISCO volume driver https://review.openstack.org/461665 | 02:42 |
| *** AlexeyAbashkin has joined #openstack-cinder | 02:43 | |
| openstackgerrit | qtlu proposed openstack/cinder master: Fix backup-import error when the deleted record in the same db https://review.openstack.org/502897 | 02:46 |
| *** AlexeyAbashkin has quit IRC | 02:48 | |
| *** links has joined #openstack-cinder | 02:51 | |
| *** ChubYann has quit IRC | 02:51 | |
| *** nicolasbock has quit IRC | 03:16 | |
| *** markvoelker has joined #openstack-cinder | 03:18 | |
| *** vivsoni has joined #openstack-cinder | 03:18 | |
| *** wes_dillingham has quit IRC | 03:35 | |
| *** edmondsw has joined #openstack-cinder | 03:38 | |
| *** wanghao_ has quit IRC | 03:40 | |
| *** yangyapeng has quit IRC | 03:40 | |
| *** crushil has joined #openstack-cinder | 03:40 | |
| *** wanghao has joined #openstack-cinder | 03:40 | |
| *** yangyapeng has joined #openstack-cinder | 03:41 | |
| *** edmondsw has quit IRC | 03:45 | |
| *** markvoelker has quit IRC | 03:51 | |
| *** Vipul_ has joined #openstack-cinder | 03:51 | |
| Vipul_ | Hi | 03:52 |
| *** dhinesh has joined #openstack-cinder | 04:01 | |
| *** mvk has joined #openstack-cinder | 04:20 | |
| *** pcaruana has joined #openstack-cinder | 04:27 | |
| *** mvk has quit IRC | 04:31 | |
| *** gkadam_ has joined #openstack-cinder | 04:38 | |
| *** gkadam_ has quit IRC | 04:39 | |
| *** gkadam has joined #openstack-cinder | 04:40 | |
| openstackgerrit | Merged openstack/cinder master: Add ability to specify backup driver via class name https://review.openstack.org/477472 | 04:45 |
| *** markvoelker has joined #openstack-cinder | 04:49 | |
| *** armax has quit IRC | 04:50 | |
| *** armax has joined #openstack-cinder | 04:51 | |
| *** armax has joined #openstack-cinder | 04:51 | |
| *** ChubYann has joined #openstack-cinder | 04:52 | |
| *** armax has quit IRC | 04:52 | |
| *** armax has joined #openstack-cinder | 04:52 | |
| *** pcaruana has quit IRC | 04:56 | |
| *** swamireddy has quit IRC | 05:02 | |
| *** cristicalin has joined #openstack-cinder | 05:10 | |
| *** crushil has quit IRC | 05:17 | |
| *** chlong has joined #openstack-cinder | 05:20 | |
| *** markvoelker has quit IRC | 05:22 | |
| *** cristicalin has quit IRC | 05:23 | |
| *** ChubYann has quit IRC | 05:24 | |
| *** gouthamr has quit IRC | 05:24 | |
| *** edmondsw has joined #openstack-cinder | 05:27 | |
| *** pcaruana has joined #openstack-cinder | 05:30 | |
| *** edmondsw has quit IRC | 05:32 | |
| *** swamireddy has joined #openstack-cinder | 05:37 | |
| *** armaan has joined #openstack-cinder | 05:39 | |
| *** pcaruana has quit IRC | 05:39 | |
| *** rcernin has joined #openstack-cinder | 05:41 | |
| *** armaan has quit IRC | 05:43 | |
| *** cristicalin has joined #openstack-cinder | 05:43 | |
| openstackgerrit | nikesh proposed openstack/cinder master: Kaminario K2: Add non discovery iSCSI multipath https://review.openstack.org/508141 | 05:57 |
| *** spectr has quit IRC | 05:58 | |
| *** spectr has joined #openstack-cinder | 05:58 | |
| *** cah_link__ has joined #openstack-cinder | 06:09 | |
| *** cah_link__ has quit IRC | 06:10 | |
| *** cah_link__ has joined #openstack-cinder | 06:11 | |
| *** cristicalin has quit IRC | 06:17 | |
| *** markvoelker has joined #openstack-cinder | 06:19 | |
| *** lpetrut_ has joined #openstack-cinder | 06:21 | |
| *** e0ne has joined #openstack-cinder | 06:32 | |
| openstackgerrit | Guy Kim proposed openstack/cinder master: Update configuration names in ITRI DISCO volume driver https://review.openstack.org/461665 | 06:34 |
| *** e0ne has quit IRC | 06:35 | |
| *** e0ne has joined #openstack-cinder | 06:35 | |
| *** wanghao_ has joined #openstack-cinder | 06:52 | |
| *** wanghao has quit IRC | 06:52 | |
| *** markvoelker has quit IRC | 06:52 | |
| *** wanghao has joined #openstack-cinder | 06:54 | |
| *** wanghao_ has quit IRC | 06:58 | |
| *** lhx__ has joined #openstack-cinder | 06:59 | |
| openstackgerrit | Shunei Shiono proposed openstack/cinder master: NEC driver: Never use target info in migration_status https://review.openstack.org/511737 | 07:06 |
| *** pcaruana has joined #openstack-cinder | 07:07 | |
| *** lpetrut_ has quit IRC | 07:13 | |
| openstackgerrit | Merged openstack/cinder master: [policy in code] Add support for backup resource https://review.openstack.org/507015 | 07:13 |
| *** edmondsw has joined #openstack-cinder | 07:15 | |
| *** gcb has quit IRC | 07:16 | |
| *** armaan has joined #openstack-cinder | 07:17 | |
| *** edmondsw has quit IRC | 07:20 | |
| *** tesseract has joined #openstack-cinder | 07:22 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 07:24 | |
| *** spectr has quit IRC | 07:26 | |
| *** tesseract has quit IRC | 07:26 | |
| *** rcernin has quit IRC | 07:26 | |
| *** pcaruana has quit IRC | 07:26 | |
| *** e0ne has quit IRC | 07:33 | |
| *** mvk has joined #openstack-cinder | 07:37 | |
| *** rcernin has joined #openstack-cinder | 07:40 | |
| *** spectr has joined #openstack-cinder | 07:40 | |
| *** pcaruana has joined #openstack-cinder | 07:40 | |
| *** armaan has quit IRC | 07:41 | |
| *** spectr has quit IRC | 07:43 | |
| *** pcaruana has quit IRC | 07:44 | |
| *** pcaruana has joined #openstack-cinder | 07:44 | |
| *** spectr has joined #openstack-cinder | 07:44 | |
| *** wanghao_ has joined #openstack-cinder | 07:50 | |
| *** wanghao has quit IRC | 07:50 | |
| *** markvoelker has joined #openstack-cinder | 07:50 | |
| *** wanghao has joined #openstack-cinder | 07:52 | |
| tommylikehu | hey lbragstad , smcginnis , jungleboyj could you review this patch? https://review.openstack.org/#/c/507812/, thanks in advance! | 07:52 |
| *** wanghao_ has quit IRC | 07:55 | |
| openstackgerrit | Huang Zhiteng proposed openstack/cinder master: Check available capacity before creating resources https://review.openstack.org/509011 | 08:09 |
| *** AlexeyAbashkin has quit IRC | 08:10 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 08:11 | |
| *** armaan has joined #openstack-cinder | 08:15 | |
| *** gcb has joined #openstack-cinder | 08:21 | |
| *** markvoelker has quit IRC | 08:23 | |
| *** dhinesh has quit IRC | 08:31 | |
| *** itlinux has joined #openstack-cinder | 08:33 | |
| *** itlinux has quit IRC | 08:36 | |
| openstackgerrit | Boris Pavlovic proposed openstack/cinder master: Switch Rally Task To format V2 https://review.openstack.org/507010 | 08:38 |
| *** johnthetubaguy has quit IRC | 08:39 | |
| *** johnthetubaguy has joined #openstack-cinder | 08:40 | |
| *** e0ne has joined #openstack-cinder | 08:41 | |
| *** armaan has quit IRC | 08:44 | |
| *** kaisers1 has quit IRC | 08:57 | |
| *** rcernin has quit IRC | 08:59 | |
| *** spectr has quit IRC | 08:59 | |
| *** pcaruana has quit IRC | 08:59 | |
| *** wanghao has quit IRC | 09:00 | |
| *** wanghao has joined #openstack-cinder | 09:00 | |
| *** AlexeyAbashkin has quit IRC | 09:03 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 09:03 | |
| *** edmondsw has joined #openstack-cinder | 09:04 | |
| openstackgerrit | Gyorgy Szombathelyi proposed openstack/cinder master: Remove deprecated nova config options https://review.openstack.org/503596 | 09:06 |
| *** edmondsw has quit IRC | 09:08 | |
| *** rcernin has joined #openstack-cinder | 09:12 | |
| *** spectr has joined #openstack-cinder | 09:12 | |
| *** pcaruana has joined #openstack-cinder | 09:13 | |
| *** AlexeyAbashkin has quit IRC | 09:15 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 09:15 | |
| *** markvoelker has joined #openstack-cinder | 09:20 | |
| *** Shunli has quit IRC | 09:22 | |
| *** wanghao has quit IRC | 09:27 | |
| *** gcb has quit IRC | 09:27 | |
| *** belmoreira has joined #openstack-cinder | 09:29 | |
| *** dalgaaf has quit IRC | 09:31 | |
| *** chlong has quit IRC | 09:40 | |
| *** vivsoni_ has joined #openstack-cinder | 09:52 | |
| *** vivsoni has quit IRC | 09:52 | |
| *** markvoelker has quit IRC | 09:53 | |
| *** armaan has joined #openstack-cinder | 09:58 | |
| *** itlinux has joined #openstack-cinder | 10:01 | |
| *** yangyapeng has quit IRC | 10:02 | |
| *** sbezverk has joined #openstack-cinder | 10:14 | |
| *** armaan has quit IRC | 10:17 | |
| *** itlinux has quit IRC | 10:21 | |
| *** lpetrut_ has joined #openstack-cinder | 10:22 | |
| *** sdague has joined #openstack-cinder | 10:24 | |
| *** belmoreira has quit IRC | 10:26 | |
| *** psachin has quit IRC | 10:33 | |
| *** pcaruana has quit IRC | 10:48 | |
| *** ociuhandu has quit IRC | 10:49 | |
| *** markvoelker has joined #openstack-cinder | 10:50 | |
| *** nicolasbock has joined #openstack-cinder | 11:09 | |
| *** armaan has joined #openstack-cinder | 11:10 | |
| *** nicolasbock has quit IRC | 11:14 | |
| openstackgerrit | Ciara Stacke proposed openstack/cinder master: VMAX driver - Cannot extend volumes in a replication relationship https://review.openstack.org/511812 | 11:19 |
| *** edmondsw has joined #openstack-cinder | 11:20 | |
| *** ganso has joined #openstack-cinder | 11:21 | |
| *** cah_link__ has quit IRC | 11:21 | |
| openstackgerrit | Ciara Stacke proposed openstack/cinder master: VMAX driver - Cannot extend volumes in a replication relationship https://review.openstack.org/511812 | 11:22 |
| *** cah_link_ has joined #openstack-cinder | 11:22 | |
| *** markvoelker has quit IRC | 11:23 | |
| *** erlon has joined #openstack-cinder | 11:23 | |
| *** alexchadin has joined #openstack-cinder | 11:24 | |
| *** nicolasbock has joined #openstack-cinder | 11:26 | |
| *** armaan has quit IRC | 11:44 | |
| *** armaan has joined #openstack-cinder | 11:44 | |
| *** abishop has joined #openstack-cinder | 11:56 | |
| *** armaan has quit IRC | 12:01 | |
| *** armaan has joined #openstack-cinder | 12:02 | |
| *** tpsilva has joined #openstack-cinder | 12:02 | |
| *** cah_link_ has quit IRC | 12:03 | |
| *** cah_link_ has joined #openstack-cinder | 12:03 | |
| *** mchlumsky has joined #openstack-cinder | 12:07 | |
| *** felipemonteiro has joined #openstack-cinder | 12:09 | |
| *** wes_dillingham has joined #openstack-cinder | 12:13 | |
| *** felipemonteiro has quit IRC | 12:14 | |
| *** markvoelker has joined #openstack-cinder | 12:15 | |
| *** armaan has quit IRC | 12:21 | |
| *** armaan has joined #openstack-cinder | 12:21 | |
| *** eharney has joined #openstack-cinder | 12:22 | |
| *** ociuhandu has joined #openstack-cinder | 12:30 | |
| *** liverpooler has joined #openstack-cinder | 12:36 | |
| *** ociuhandu has quit IRC | 12:39 | |
| *** dave-mccowan has joined #openstack-cinder | 12:42 | |
| *** stakeda has quit IRC | 12:43 | |
| *** links has quit IRC | 12:45 | |
| *** dave-mccowan has quit IRC | 12:47 | |
| *** pcaruana has joined #openstack-cinder | 12:48 | |
| *** alexchadin has quit IRC | 12:50 | |
| *** alexchadin has joined #openstack-cinder | 12:51 | |
| *** dustins has joined #openstack-cinder | 12:51 | |
| *** spectr has quit IRC | 12:57 | |
| *** ociuhandu has joined #openstack-cinder | 12:58 | |
| *** josecastroleon has quit IRC | 12:59 | |
| *** spectr has joined #openstack-cinder | 13:02 | |
| *** mriedem has joined #openstack-cinder | 13:05 | |
| *** jistr is now known as jistr|mtg | 13:08 | |
| *** jmlowe has quit IRC | 13:12 | |
| *** ociuhandu has quit IRC | 13:14 | |
| *** kaisers has joined #openstack-cinder | 13:20 | |
| *** gkadam has quit IRC | 13:25 | |
| *** lhx__ has quit IRC | 13:26 | |
| *** chlong has joined #openstack-cinder | 13:33 | |
| *** armaan has quit IRC | 13:41 | |
| *** armaan has joined #openstack-cinder | 13:42 | |
| *** rcernin has quit IRC | 13:44 | |
| openstackgerrit | Jeremy Zhang proposed openstack/cinder master: Add v3 api-ref for showing all/specific extra specs for a volume type https://review.openstack.org/511519 | 13:44 |
| *** dansmith is now known as superdan | 13:47 | |
| *** zhaochao has quit IRC | 13:48 | |
| *** dave-mccowan has joined #openstack-cinder | 13:49 | |
| *** gouthamr has joined #openstack-cinder | 13:50 | |
| *** gouthamr has quit IRC | 13:51 | |
| *** gouthamr has joined #openstack-cinder | 13:51 | |
| *** dave-mcc_ has joined #openstack-cinder | 13:55 | |
| *** dave-mccowan has quit IRC | 13:57 | |
| *** jmlowe has joined #openstack-cinder | 13:59 | |
| *** mriedem has quit IRC | 14:03 | |
| *** ociuhandu has joined #openstack-cinder | 14:03 | |
| *** mriedem has joined #openstack-cinder | 14:06 | |
| *** Vipul_ has quit IRC | 14:10 | |
| *** armax has joined #openstack-cinder | 14:11 | |
| *** slunkad has quit IRC | 14:11 | |
| *** alexchadin has quit IRC | 14:12 | |
| *** catintheroof has joined #openstack-cinder | 14:23 | |
| *** Dinesh_Bhor has quit IRC | 14:34 | |
| *** dave-mcc_ is now known as dave-mccowan | 14:35 | |
| *** lhx_ has joined #openstack-cinder | 14:40 | |
| *** KeithMnemonic1 has joined #openstack-cinder | 14:43 | |
| *** rcernin has joined #openstack-cinder | 14:45 | |
| *** spectr has quit IRC | 14:46 | |
| *** e0ne has quit IRC | 14:47 | |
| *** KeithMnemonic has quit IRC | 14:47 | |
| *** pooja_jadhav has quit IRC | 14:51 | |
| *** yangyapeng has joined #openstack-cinder | 14:54 | |
| *** jistr|mtg is now known as jistr | 14:58 | |
| *** rcernin has quit IRC | 15:03 | |
| openstackgerrit | Alan Bishop proposed openstack/cinder-specs master: Migrate ConfKeyManager's fixed-key to Barbican https://review.openstack.org/511900 | 15:07 |
| abishop | jungleboyj, smcginnis: ^^ see https://blueprints.launchpad.net/cinder/+spec/migrate-fixed-key-to-barbican | 15:08 |
| smcginnis | abishop: Thanks! | 15:12 |
| *** yangyapeng has quit IRC | 15:14 | |
| *** yangyapeng has joined #openstack-cinder | 15:15 | |
| ildikov | jgriffith: mriedem: johnthetubaguy: smcginnis: jungleboyj: stvnoyes: are you around for a quick sync? | 15:16 |
| *** bhagyashris has quit IRC | 15:16 | |
| johnthetubaguy | o/ | 15:16 |
| jgriffith | ildikov: 0/ | 15:16 |
| jungleboyj | ildikov: :-) | 15:17 |
| jungleboyj | @! | 15:17 |
| _pewp_ | jungleboyj (=ﾟωﾟ)ﾉ | 15:17 |
| ildikov | hi All :) | 15:18 |
| ildikov | let's dive in | 15:18 |
| ildikov | so good news on new attach patch side, we found a small bug in Nova that caused test failures which is fixed now | 15:19 |
| openstackgerrit | Jeremy Zhang proposed openstack/cinder master: Add v3 api-ref for showing all/specific extra specs for a volume type https://review.openstack.org/511519 | 15:19 |
| ildikov | there's still a comment in refresh_connection_info from mriedem that was also discussed on the PTG in some extent, need to look into that | 15:19 |
| *** yangyapeng has quit IRC | 15:20 | |
| johnthetubaguy | the change in the ceph key one? | 15:20 |
| ildikov | comment is on the latest patch set if anyone feels like chiming in | 15:20 |
| ildikov | johnthetubaguy: ceph key? | 15:20 |
| *** yangyapeng has joined #openstack-cinder | 15:21 | |
| johnthetubaguy | I think that was the use case, something changes in the connection details that needs updating | 15:21 |
| ildikov | johnthetubaguy: we got into a chat earlier on whether or not refresh_connection_info should result in a volume state change | 15:22 |
| johnthetubaguy | I guess it might involved tearing down that shared connection and bringing it back up again? I am not sure | 15:22 |
| johnthetubaguy | (I guess we should follow the spirit of not hiding thing from each other, just because that's easy) | 15:23 |
| johnthetubaguy | anyways, thats probably a distraction | 15:23 |
| jgriffith | We had said at one point that connections (attachment connector fields) would be immutable | 15:23 |
| *** ntpttr_laptop has joined #openstack-cinder | 15:24 | |
| ildikov | L122 here for context: https://etherpad.openstack.org/p/cinder-ptg-queens-thursday-notes | 15:24 |
| jgriffith | if something changes, you need to reset/update etc you get a new attachment instead | 15:24 |
| jgriffith | johnthetubaguy: I don't know for sure if that relates to what you're saying or not | 15:24 |
| johnthetubaguy | kinda does, I could see that making sense | 15:25 |
| jgriffith | but I guess that ship has kinda sailed at this point | 15:25 |
| johnthetubaguy | why sailed? | 15:25 |
| jgriffith | we've sort of broken that model a little already | 15:25 |
| johnthetubaguy | where? | 15:25 |
| * jgriffith is checking something.... | 15:25 | |
| jgriffith | Ahhh... nope, we're still holding that contract | 15:26 |
| jgriffith | attachment-update was what I was concerned about but we still enforce that so we're good | 15:26 |
| * johnthetubaguy phew.... | 15:27 | |
| jgriffith | :) | 15:27 |
| jgriffith | sorry | 15:27 |
| johnthetubaguy | no worries, good to check these things | 15:27 |
| johnthetubaguy | it feels quite similar to the migrate volume stuff, only we know its dead to start with | 15:27 |
| ildikov | :) | 15:27 |
| jgriffith | There was a stage in one of the 145 iterations that this came up :) | 15:27 |
| ildikov | 145 is such a nice number :) | 15:28 |
| ildikov | Matt's concern on patch set #145 is: This refresh method is called from a few places in the compute manager and is just for getting the latest connection_info from the volume backend in Cinder. This was meant to be a replacement call for os-initialize_connection, which didn't change the volume status. Now it seems we have this new issue to get the latest connection_info. | 15:30 |
| jungleboyj | ildikov: Thanks for referencing my notes. Nice to know they are used. | 15:30 |
| ildikov | sorry, on #144 | 15:30 |
| ildikov | jungleboyj: np, good that we have them :) | 15:31 |
| johnthetubaguy | ildikov: seems like we should separate the bug fix into a follow on patch? | 15:31 |
| johnthetubaguy | ildikov: i.e. the refetch of the data from cinder, seems fine, as we should stop storing it in Nova in the new flow and never use Nova's cached copy, I presume | 15:32 |
| ildikov | johnthetubaguy: the bug on reboot is fixed | 15:32 |
| jgriffith | ildikov: umm, I'm not sure about that | 15:32 |
| johnthetubaguy | it feels like there are many bug here, and I am thinking about a different one | 15:32 |
| jgriffith | refectch to Cinder shouldn't cause any status changes, I don't think he's saying that either | 15:33 |
| johnthetubaguy | if adopting the new flow fixes things, that seems all good (I should go read that patch, after this live-migration one) | 15:33 |
| ildikov | one is fixed, if refresh is a concern it's another one | 15:33 |
| ildikov | jgriffith: it uses attachment_update | 15:33 |
| jgriffith | yeah.. don't do that :) | 15:33 |
| johnthetubaguy | oh, so we get the connector, and update that again? | 15:33 |
| jgriffith | That was what I was saying earlier about "that ship has sailed" | 15:33 |
| ildikov | jgriffith: which in a function called 'refresh' shouldn't be that surprising, but well... | 15:34 |
| jgriffith | if you do that we're defeating one of the last remaining differences in the new Attachment API | 15:34 |
| jgriffith | johnthetubaguy: yeah, so querying cinder for the stored connector seems fine | 15:34 |
| jgriffith | but modifying anything IMO is no good | 15:35 |
| ildikov | jgriffith: I think we should be fine here, but thought to point everyone to it, to raise concerns | 15:35 |
| johnthetubaguy | so the bug was where the connector changes, reboot should fix it? | 15:35 |
| ildikov | if any | 15:35 |
| ildikov | johnthetubaguy: https://review.openstack.org/#/c/511209/ | 15:37 |
| ildikov | johnthetubaguy: is what got fixed so we're not supposed to fail on reboot anymore | 15:37 |
| johnthetubaguy | OK, I am really confused, but the above patch seems fine | 15:38 |
| johnthetubaguy | ignore that for now, going through the live-migrate patch right now | 15:38 |
| ildikov | johnthetubaguy: ok, sounds good | 15:38 |
| ildikov | johnthetubaguy: stvnoyes is not around today, but I'm sure he'll fix whatever you find early next week | 15:39 |
| johnthetubaguy | I am kinda hoping I don't find anything, but good to know | 15:39 |
| ildikov | johnthetubaguy: well, me too, but I didn't want to be too pushy ;) | 15:40 |
| jgriffith | johnthetubaguy: ditto :) | 15:40 |
| johnthetubaguy | so detach, we have to go into detaching first? | 15:40 |
| ildikov | in the live migrate path you mean? | 15:40 |
| johnthetubaguy | I guess not for an additional attachment | 15:40 |
| ildikov | no, we create the new attachment before deleting the old one AFAIK | 15:41 |
| johnthetubaguy | yep, we certainly do that, I believe | 15:41 |
| ildikov | we create the attachment in pre_live_migrate | 15:43 |
| jgriffith | ildikov: correct (create before delete) | 15:44 |
| ildikov | jgriffith: cool, thanks for confirming | 15:44 |
| johnthetubaguy | what does volume_api.roll_detaching do? | 15:44 |
| johnthetubaguy | is that rollback the move to the detaching state? | 15:44 |
| johnthetubaguy | sorry, I am derailing the catch up here | 15:46 |
| ildikov | yep, it seems to move the volume back to 'in-use' | 15:48 |
| ildikov | from 'detaching' | 15:48 |
| johnthetubaguy | so if its already in-use its a no-op or a failure? | 15:48 |
| mriedem | i'm late | 15:49 |
| mriedem | johnthetubaguy: you're thinking of a different issue | 15:50 |
| mriedem | for the refresh conn info thing | 15:50 |
| mriedem | that's bug 1452641 | 15:50 |
| openstack | bug 1452641 in OpenStack Compute (nova) "Static Ceph mon IP addresses in connection_info can prevent VM startup" [Medium,Confirmed] https://launchpad.net/bugs/1452641 | 15:50 |
| johnthetubaguy | mriedem: yeah, I thought so | 15:50 |
| johnthetubaguy | mriedem: thanks | 15:50 |
| * smcginnis catches up on the pages of scrollback | 15:50 | |
| *** crose has joined #openstack-cinder | 15:50 | |
| ildikov | johnthetubaguy: I would think it's a no-op, but I always have to re-understand that conditional_update function... :/ | 15:50 |
| johnthetubaguy | ildikov: no worries, its a total edge case, so its just a nit for a follow on patch if thats a problem | 15:51 |
| ildikov | johnthetubaguy: I like the sound of follow-up :) | 15:52 |
| ildikov | smcginnis can correct me in the meantime | 15:52 |
| *** chlong has quit IRC | 15:53 | |
| mriedem | so the issue i brought up was, | 15:53 |
| mriedem | nova today calls os-initialize_connection to get the latest connection_info | 15:53 |
| mriedem | but with the new flow, doing that makes cinder expect an attachment_complete call after that, and the volume gets put into attaching status | 15:53 |
| mriedem | that's not what we (nova) want, | 15:54 |
| mriedem | so we need to know if nova just calls cinder to get the latest version of the attachment and pulls the connection_info off that | 15:54 |
| mriedem | now that it's stored in cinder | 15:54 |
| mriedem | if that works, it's great | 15:54 |
| smcginnis | ildikov: Follow up sounds good to me. | 15:54 |
| ildikov | it should be retrievable from the attachment record | 15:55 |
| mriedem | i'm not sure in what world the connection_info will change 'out of band' on the cinder side | 15:55 |
| *** AlexeyAbashkin has quit IRC | 15:55 | |
| mriedem | but if it does, then cinder is the holder of truth and we're just asking for the latest | 15:55 |
| ildikov | smcginnis: I mean the question on roll_detaching, sorry :) | 15:55 |
| johnthetubaguy | mriedem: +1 just getting it from cinder each time | 15:55 |
| jgriffith | mriedem: yes, and that should work always | 15:55 |
| jgriffith | if there is some case where the connection info can/does change we have a bigger problem.... but would have to just do a new attachment-create to deal with that | 15:56 |
| johnthetubaguy | I think our re-call of initialize_connection breaks some backends, from what I remember | 15:56 |
| johnthetubaguy | jgriffith: see bug 1452641 | 15:56 |
| openstack | bug 1452641 in OpenStack Compute (nova) "Static Ceph mon IP addresses in connection_info can prevent VM startup" [Medium,Confirmed] https://launchpad.net/bugs/1452641 | 15:56 |
| jgriffith | I don't know of any case where a backend could/would modify connection info while a volume is supposed to be connected/in-use | 15:56 |
| johnthetubaguy | but that is a separate concern | 15:56 |
| ildikov | Does this mean we shouldn't call attachment_update in refresh_connection_info? | 15:57 |
| jgriffith | johnthetubaguy: ummmm... well yeah! | 15:57 |
| jgriffith | You go in and reconfigure your backend I'm not sure what one would expect | 15:57 |
| johnthetubaguy | should be attachment_get I think | 15:57 |
| smcginnis | ildikov: Making me read now, huh? Yes, I believe you stated correctly about roll_detaching. | 15:58 |
| ildikov | smcginnis: coolio and sorry for the extra work :) | 15:58 |
| smcginnis | :) | 15:58 |
| johnthetubaguy | ildikov: so you have a link to line in the review this is all about? | 15:58 |
| ildikov | johnthetubaguy: yeah, that's what I'm reading out of the discussion too | 15:58 |
| johnthetubaguy | in case its in front of you already, I am just being lazy really | 15:59 |
| ildikov | johnthetubaguy: maybe we could also rename the function to retrieve_connection_info or something... | 15:59 |
| ildikov | johnthetubaguy: https://review.openstack.org/#/c/330285/144/nova/virt/block_device.py | 15:59 |
| *** Apoorva has joined #openstack-cinder | 16:00 | |
| *** Apoorva has quit IRC | 16:01 | |
| ildikov | jgriffith: any updates on the Cinder side patch with the db migration? | 16:02 |
| mriedem | ildikov: yes that's what i'm saying, | 16:03 |
| mriedem | refresh_connection_info for new style attachment just does an attachment_get()['connection_info'] | 16:03 |
| jgriffith | ildikov: unit tests all still blowing up | 16:03 |
| ildikov | mriedem: cool, then we're on the same page, thanks | 16:03 |
| jgriffith | trying to sort it out now, I have fixed the service object up as per mriedem 's suggestions | 16:03 |
| jgriffith | but still something very bad happening | 16:04 |
| ildikov | one the functional or on the testing side? | 16:04 |
| ildikov | or both? | 16:04 |
| ildikov | s/one/on/ | 16:04 |
| jgriffith | our unit tests aren't unit tests, just incase I haven't mentioned that today :) | 16:04 |
| jgriffith | ildikov: functionally it works fine now, unit tests however not so much | 16:04 |
| ildikov | jgriffith: copied and sorry you had to mention that today | 16:05 |
| ildikov | jgriffith: I feel bad now | 16:05 |
| jgriffith | ildikov: why? | 16:05 |
| ildikov | jgriffith: it's not a pleasant topic for a Friday neither easily fixable as much as I understand | 16:06 |
| jgriffith | oh LOL | 16:06 |
| openstackgerrit | Merged openstack/cinder master: Switch Rally Task To format V2 https://review.openstack.org/507010 | 16:06 |
| jgriffith | nahh, we've known our unit test design is not so great; nothing new | 16:06 |
| ildikov | ok | 16:06 |
| ildikov | do you think it's fixable by early next week? | 16:07 |
| ildikov | I mean the patch itself :) | 16:07 |
| jgriffith | I'm hoping to fix it today | 16:07 |
| ildikov | sounds great! | 16:08 |
| ildikov | ok, I think everyone has homework | 16:08 |
| ildikov | mriedem is off the hook until I fix his comments on the new attach patch :) | 16:08 |
| jungleboyj | :-) | 16:08 |
| johnthetubaguy | ildikov: mriedem: I added a comment next to yours on that review, does it make any sense? | 16:09 |
| ildikov | johnthetubaguy: I need to double check when we actually do driver_attach | 16:11 |
| *** Apoorva has joined #openstack-cinder | 16:11 | |
| ildikov | johnthetubaguy: I think the question here is what design we want as it's doable multiple ways | 16:12 |
| ildikov | johnthetubaguy: see the comment here: https://review.openstack.org/#/c/330285/144/nova/compute/manager.py | 16:14 |
| johnthetubaguy | ildikov: that seems odd, hmm. | 16:17 |
| ildikov | johnthetubaguy: that's why I said that it's a design question, like saying that no matter what when we call bdm.attach that means to put the volume to 'in-use' | 16:18 |
| johnthetubaguy | ildikov: that might be correct, I think we are re-using some methods in odd ways here, will need more time before I can say anything sensible | 16:19 |
| ildikov | johnthetubaguy: if we can clean things up that would be great as well | 16:22 |
| ildikov | johnthetubaguy: we're all in favor of that I would think | 16:23 |
| *** pcaruana has quit IRC | 16:23 | |
| ildikov | jgriffith: mriedem: johnthetubaguy: smcginnis: jungleboyj: ok, I think we're done with the sync for today | 16:25 |
| smcginnis | Ship it. | 16:25 |
| jungleboyj | smcginnis: ++ | 16:26 |
| ildikov | let's get the homework done early next week so we can clean up the new attach patch and get it landed finally | 16:26 |
| * ildikov also appreciates all the votes in advance ;) | 16:26 | |
| *** felipemonteiro has joined #openstack-cinder | 16:27 | |
| smcginnis | ildikov: Homework on the weekend? You're mean. | 16:31 |
| *** felipemonteiro has quit IRC | 16:32 | |
| ildikov | smcginnis: what's weekend again? | 16:32 |
| smcginnis | ildikov: Are you spending yours on an airplane? | 16:32 |
| ildikov | smcginnis: airplane, workshop, airplane, training, conference, airplane would be my next six days | 16:33 |
| smcginnis | ildikov: Fun fun fun. :) | 16:34 |
| smcginnis | Anyone else going to be at All Things Open? eharney? | 16:34 |
| ildikov | ildikov: a blast! :) | 16:34 |
| *** crose has quit IRC | 16:38 | |
| jungleboyj | ildikov: Don't know how you do it? | 16:41 |
| ildikov | jungleboyj: don't question it, I have to face the issue here that way :) | 16:42 |
| *** wes_dillingham has quit IRC | 16:42 | |
| jungleboyj | ildikov: Ok, I will leave it to you. :-) | 16:43 |
| ildikov | jungleboyj: appreciated :) | 16:46 |
| *** ntpttr_laptop has quit IRC | 16:48 | |
| johnthetubaguy | ildikov: any chance you could double check my worry on this live-migrate patch to see if I just miss-read the flow? https://review.openstack.org/#/c/463987/24 | 16:50 |
| openstackgerrit | Eric Young proposed openstack/cinder master: ScaleIO Driver: Backup volume via snapshot https://review.openstack.org/511921 | 16:52 |
| ildikov | johnthetubaguy: will do, just saw your comment | 16:52 |
| *** wes_dillingham has joined #openstack-cinder | 16:53 | |
| johnthetubaguy | ildikov: thanks | 16:58 |
| *** ntpttr_laptop has joined #openstack-cinder | 16:59 | |
| *** e0ne has joined #openstack-cinder | 17:04 | |
| ildikov | johnthetubaguy: so in the new attach patch refresh_connection_info calls attachment_update | 17:07 |
| ildikov | johnthetubaguy: at least currently | 17:07 |
| ildikov | johnthetubaguy: which is the missing piece in your question there I think | 17:08 |
| johnthetubaguy | ildikov: yeah, that would do it | 17:08 |
| ildikov | johnthetubaguy: however we said we want attachment_get there | 17:08 |
| johnthetubaguy | ildikov: well, that wouldn't work in this case of course... sigh | 17:09 |
| ildikov | johnthetubaguy: yeah, need to check the flow again | 17:10 |
| johnthetubaguy | ildikov: so in this case we have done attachment_create, about to do driver_attach, so we need the middle bit | 17:10 |
| ildikov | johnthetubaguy: if we call bdm.attach we have an attachment_update call there | 17:10 |
| *** jgriffith has quit IRC | 17:11 | |
| johnthetubaguy | ildikov: but the driver attach is part of the pre_live_migration call right now | 17:12 |
| *** John has joined #openstack-cinder | 17:12 | |
| *** John is now known as jgriffith | 17:12 | |
| jungleboyj | ildikov: jgriffith patrickeast Good job covering for me in the RedHat PTG Interview. :-) | 17:13 |
| jungleboyj | Thank you. It turned out very well. | 17:13 |
| ildikov | johnthetubaguy: this one you mean: driver.pre_live_migration? | 17:13 |
| johnthetubaguy | ildikov: yes, calls _connect_volume | 17:14 |
| ildikov | jungleboyj: that video is hilarious :D | 17:14 |
| ildikov | johnthetubaguy: ok, got you now | 17:14 |
| *** masber has quit IRC | 17:14 | |
| *** mvk has quit IRC | 17:14 | |
| johnthetubaguy | ildikov: I added a suggested fix on the patch | 17:16 |
| ildikov | johnthetubaguy: cool, I will check | 17:17 |
| jungleboyj | ildikov: Yep, but it got the job done. I could hear your phone ding in the background I think as I was trying to tell you I was coming. | 17:17 |
| ildikov | johnthetubaguy: doesn't sound to be a complicated problem | 17:17 |
| johnthetubaguy | ildikov: in isolation its a simple fix I think | 17:17 |
| ildikov | johnthetubaguy: I will try whether tests are failing without that fix | 17:18 |
| ildikov | johnthetubaguy: if they do we should get the live_migrate patch merged and fix it in the new attach patch | 17:18 |
| ildikov | johnthetubaguy: testing and follow-up is easier that way | 17:18 |
| johnthetubaguy | ildikov: that is the odd bit, how do the tests pass, confuses me | 17:18 |
| johnthetubaguy | oh wait, they pass as the follow on patch fixes it, I get it now | 17:18 |
| ildikov | jungleboyj: I think my phone was silent | 17:19 |
| jungleboyj | Hmmm, ok. Someone's phone dinged. | 17:19 |
| ildikov | johnthetubaguy: the new attach is not enabled in the live_migrate patch, so it runs the old flow | 17:19 |
| ildikov | johnthetubaguy: the new flow patch depends on the live_migrate one, so it passes the tests as it has everything | 17:19 |
| *** lpetrut_ has quit IRC | 17:19 | |
| johnthetubaguy | ildikov: they did tests by adding the two patches together I think | 17:21 |
| ildikov | johnthetubaguy: yes | 17:21 |
| johnthetubaguy | yeah, we just said the same thing differently, doh | 17:21 |
| ildikov | johnthetubaguy: so if this part is the issue we should be able to catch it with tests I would think | 17:21 |
| johnthetubaguy | OK, so I think I have this all in my head, must be time for the weekend (face palm) | 17:22 |
| *** dhinesh has joined #openstack-cinder | 17:22 | |
| ildikov | johnthetubaguy: need to go and find my flight, but I will look into a solution | 17:22 |
| ildikov | johnthetubaguy: true :) | 17:22 |
| johnthetubaguy | ++ have a safe flight | 17:22 |
| *** lhx_ has quit IRC | 17:22 | |
| ildikov | johnthetubaguy: thanks! | 17:22 |
| openstackgerrit | Merged openstack/python-brick-cinderclient-ext master: Updated from global requirements https://review.openstack.org/511632 | 17:22 |
| johnthetubaguy | ildikov: I added comments saying possible just pull out that change in the other patch, and depend on that | 17:22 |
| ildikov | johnthetubaguy: I will check, but would rather not overcomplicate it for review sanity perspective | 17:23 |
| johnthetubaguy | ildikov: I am happy to go with what mriedem feels, my problem is clearly fixed in the follow up patch | 17:24 |
| ildikov | johnthetubaguy: +1 | 17:24 |
| ildikov | johnthetubaguy: thanks for the review | 17:25 |
| *** catintheroof has quit IRC | 17:25 | |
| *** catintheroof has joined #openstack-cinder | 17:25 | |
| *** dhinesh_ has joined #openstack-cinder | 17:25 | |
| johnthetubaguy | ildikov: apologies on the wait, had a few things in the way this week | 17:26 |
| *** AlexeyAbashkin has joined #openstack-cinder | 17:27 | |
| *** mvk has joined #openstack-cinder | 17:27 | |
| *** AlexeyAbashkin has quit IRC | 17:28 | |
| *** dhinesh has quit IRC | 17:29 | |
| *** catintheroof has quit IRC | 17:29 | |
| ildikov | johnthetubaguy: it's ok, I know how that goes | 17:35 |
| *** e0ne has quit IRC | 17:37 | |
| *** armax has quit IRC | 17:42 | |
| *** nicolasbock has quit IRC | 17:42 | |
| *** sgu has joined #openstack-cinder | 17:44 | |
| openstackgerrit | John Griffith proposed openstack/cinder master: Fix migration 112 to use live_data_migration API https://review.openstack.org/510201 | 17:48 |
| *** dosaboy has quit IRC | 17:49 | |
| *** armax has joined #openstack-cinder | 17:52 | |
| *** lpetrut_ has joined #openstack-cinder | 17:55 | |
| jgriffith | service queries are still failing on that ^^ | 17:56 |
| jgriffith | as is an SQLite DateTime entry | 17:57 |
| jgriffith | I've screwed something up pretty good :) | 17:57 |
| ildikov | jgriffith: good job! :) | 18:10 |
| *** armaan has quit IRC | 18:13 | |
| *** Guest53680 is now known as mgagne | 18:14 | |
| *** mgagne has quit IRC | 18:14 | |
| *** mgagne has joined #openstack-cinder | 18:14 | |
| *** eharney has quit IRC | 18:20 | |
| *** ntpttr_laptop has quit IRC | 18:22 | |
| openstackgerrit | Merged openstack/cinder master: Update configuration names in ITRI DISCO volume driver https://review.openstack.org/461665 | 18:24 |
| openstackgerrit | Merged openstack/cinder master: Updated from global requirements https://review.openstack.org/511028 | 18:25 |
| jgriffith | ildikov: haha! Thanks!! I've outdone myself :) | 18:25 |
| *** mriedem1 has joined #openstack-cinder | 18:29 | |
| *** mriedem has quit IRC | 18:31 | |
| *** eharney has joined #openstack-cinder | 18:31 | |
| *** mriedem1 is now known as mriedem | 18:32 | |
| *** eharney has quit IRC | 18:32 | |
| *** eharney has joined #openstack-cinder | 18:32 | |
| *** jmlowe has quit IRC | 18:33 | |
| *** catintheroof has joined #openstack-cinder | 18:33 | |
| *** armax_ has joined #openstack-cinder | 18:40 | |
| *** cah_link_ has quit IRC | 18:40 | |
| *** armax has quit IRC | 18:42 | |
| *** armax_ is now known as armax | 18:42 | |
| *** gouthamr has quit IRC | 18:47 | |
| *** dosaboy has joined #openstack-cinder | 18:48 | |
| *** felipemonteiro has joined #openstack-cinder | 18:48 | |
| *** dosaboy has quit IRC | 18:48 | |
| *** dosaboy has joined #openstack-cinder | 18:50 | |
| *** felipemonteiro_ has joined #openstack-cinder | 18:50 | |
| *** felipemonteiro has quit IRC | 18:53 | |
| *** ChubYann has joined #openstack-cinder | 19:10 | |
| *** lpetrut_ has quit IRC | 19:15 | |
| *** armaan has joined #openstack-cinder | 19:17 | |
| *** sgu has quit IRC | 19:19 | |
| *** gouthamr has joined #openstack-cinder | 19:22 | |
| *** gouthamr_ has joined #openstack-cinder | 19:24 | |
| *** gouthamr has quit IRC | 19:26 | |
| ildikov | jgriffith: Friday the 13th and the next workday is Monday | 19:39 |
| *** ntpttr_laptop has joined #openstack-cinder | 19:39 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 19:40 | |
| ildikov | jgriffith: so you didn't really have a chance :) | 19:40 |
| ildikov | jgriffith: by Tuesday it should all work though, magically :) | 19:40 |
| jgriffith | ildikov: not holding my breath on that, but sounds nice :) | 19:44 |
| *** AlexeyAbashkin has quit IRC | 19:44 | |
| ildikov | jgriffith: no guarantees, I'm still practicing this predicting the future thing... :) | 19:49 |
| *** wes_dillingham has quit IRC | 19:53 | |
| openstackgerrit | Merged openstack/cinder master: Add v3 api-ref for showing all/specific extra specs for a volume type https://review.openstack.org/511519 | 19:59 |
| *** jmlowe has joined #openstack-cinder | 20:02 | |
| *** felipemonteiro__ has joined #openstack-cinder | 20:06 | |
| *** felipemonteiro_ has quit IRC | 20:09 | |
| *** masber has joined #openstack-cinder | 20:10 | |
| *** sdague has quit IRC | 20:13 | |
| *** masber has quit IRC | 20:15 | |
| jgriffith | ahh... good news is I now know precisely what's blowing up | 20:17 |
| *** shaner has quit IRC | 20:18 | |
| *** KeithMnemonic1 has quit IRC | 20:19 | |
| *** shaner has joined #openstack-cinder | 20:21 | |
| *** Apoorva_ has joined #openstack-cinder | 20:30 | |
| smcginnis | Your code? | 20:31 |
| smcginnis | :P | 20:31 |
| *** Apoorva has quit IRC | 20:34 | |
| ildikov | smcginnis: be nice! | 20:36 |
| smcginnis | Hehe | 20:37 |
| smcginnis | Gotta give jgriffith crap when I can! | 20:37 |
| ildikov | smcginnis: and say these things *after* he uploaded the fixed version ;) | 20:37 |
| smcginnis | ildikov: Oh OK, save the heckling until later. Got it. ;) | 20:37 |
| jgriffith | smcginnis: well... yeah :) | 20:37 |
| smcginnis | It's just not as fun though! | 20:38 |
| jgriffith | meh, I'll just abandon the patch and lete somebody else deal with it :) | 20:38 |
| jgriffith | s/lete/let/ | 20:38 |
| ildikov | smcginnis: sorry for killing the joy | 20:38 |
| ildikov | :) | 20:38 |
| smcginnis | jgriffith: You're going to cause ildikov to travel half way around the world to stab me to death now. | 20:38 |
| jgriffith | smcginnis: Perhaps I'll upgrade her seat for her :) | 20:39 |
| smcginnis | LOL | 20:39 |
| ildikov | jgriffith: YES PLEASE! lol :) | 20:39 |
| jgriffith | Well, I would but then I could be considered an accessory to murder, and well; that's no good | 20:40 |
| jgriffith | besides smcginnis is an alright guy | 20:40 |
| jgriffith | now... if you want to just mame him a bit... then we can talk :) | 20:40 |
| smcginnis | Sheesh, guess I'm going to have to be looking over my shoulder in Sydney now! | 20:41 |
| jgriffith | sleep with one eye open mcginnis!!! | 20:44 |
| smcginnis | Considering how poisonous nearly everything is in Australia, I think I'll just stay awake in this case. | 20:45 |
| jgriffith | smcginnis: yeah, that's my plan as well!!! | 20:45 |
| *** edmondsw has quit IRC | 20:45 | |
| jgriffith | going to put myself in a giant zip lock bag with some air holes | 20:46 |
| *** Apoorva_ has quit IRC | 20:46 | |
| jgriffith | on a *somewhat* more serious note.... | 20:46 |
| jgriffith | The problem is that patch adds a service.save on the service_from_db_object call | 20:47 |
| jgriffith | turns out that a huge number of the tests hit that | 20:47 |
| jgriffith | and there's nothing mocking or patching it | 20:48 |
| smcginnis | Oops. | 20:48 |
| jgriffith | so the service.save makes a call to the db and blows up | 20:48 |
| smcginnis | I'm sure we have many, many more cases where tests end up actually doing things they shouldn't that we don't even know about. | 20:48 |
| jgriffith | smcginnis: yeah, we kinda test a LOT of stuff in the unit tests without even knowing it | 20:49 |
| jgriffith | I need to apply this: self.patch('cinder.objects.service.Service.save', return_value=None) | 20:51 |
| ildikov | smcginnis: jgriffith: I was just going for the upgrade | 20:51 |
| jgriffith | to every single test :) | 20:51 |
| ildikov | smcginnis: jgriffith: not a killer type, or not in that meaning at least :) | 20:51 |
| jgriffith | ildikov: I don't think anybody thought you were really capable of such things | 20:52 |
| ildikov | jgriffith: you can use it on class level | 20:52 |
| ildikov | jgriffith: the mock I mean | 20:52 |
| jgriffith | ildikov: sure | 20:52 |
| jgriffith | ildikov: 255 failing tests... | 20:52 |
| jgriffith | added it to volume class, get's me down around 150 or so | 20:52 |
| ildikov | jgriffith: with using it on class level? | 20:52 |
| jgriffith | I guess I could just pick through all fo them | 20:53 |
| ildikov | probably | 20:53 |
| jgriffith | ildikov: yes, unless you mean higher level class | 20:53 |
| jgriffith | but then I'm worried I'm masking somethign that I shouldn't be | 20:53 |
| ildikov | jgriffith: by mocking 'save'? | 20:54 |
| jgriffith | yeah | 20:54 |
| ildikov | jgriffith: the unit test shouldn't access the DB on the first place | 20:54 |
| jgriffith | you know.. the whole "unintended consequences" thing | 20:54 |
| jgriffith | LOL | 20:54 |
| jgriffith | did you seriously just say the unit tests shouldn't access the DB? | 20:55 |
| ildikov | you're scared of accidentally fixing the Cinder tests now? :) | 20:55 |
| jgriffith | haha | 20:55 |
| ildikov | I know, I'm such a next-level genius today :) | 20:56 |
| jgriffith | It's a swarm of magic code and I don't want to be the last person to touch it when it all blows up :) | 20:56 |
| smcginnis | Hah | 20:56 |
| smcginnis | Back to our definitions of unit tests again. | 20:56 |
| jgriffith | lol | 20:56 |
| ildikov | if mocking out 'save' blows up Cinder then we might as well look for another profession | 20:57 |
| ildikov | like making comedy on project status reports in front of a camera :) | 20:57 |
| jgriffith | haha... my answer to Zane would be "people that need a place to run an openstack CI" :) | 20:58 |
| *** abishop has quit IRC | 20:58 | |
| jgriffith | ildikov: that's not a bad idea, I'll take your advice and do just that | 20:59 |
| smcginnis | Might be interesting to see what else blows up. :) | 20:59 |
| ildikov | jgriffith: feel free to blame me if it does not work out | 21:00 |
| jgriffith | all the things that do a service.save fail | 21:00 |
| ildikov | what are they failing with exactly? | 21:00 |
| jgriffith | ildikov: if you really want to know you should pull down my patch and try it for yourself :) | 21:01 |
| jgriffith | see what I did there... :) | 21:01 |
| *** mchlumsky has quit IRC | 21:02 | |
| *** catintheroof has quit IRC | 21:10 | |
| *** wes_dillingham has joined #openstack-cinder | 21:13 | |
| *** dhinesh_ has quit IRC | 21:25 | |
| *** armax has quit IRC | 21:25 | |
| ildikov | jgriffith: :P :) | 21:26 |
| jgriffith | :wq | 21:27 |
| jgriffith | oops | 21:27 |
| *** dustins has quit IRC | 21:28 | |
| mriedem | jungleboyj: jgriffith: smcginnis: cburgess: took me about 7 months but here is the spec https://review.openstack.org/#/c/511965/ | 21:30 |
| smcginnis | mriedem: Nice. Seems like the requests for that have been increasing. | 21:31 |
| mriedem | there is a todo in there that has to be sorted out | 21:31 |
| smcginnis | Or there's a small number that are getting more vocal. | 21:31 |
| mriedem | i'm going to send to the ops and dev list for discussion and awareness | 21:31 |
| mriedem | and then i'm off | 21:31 |
| smcginnis | ++ | 21:31 |
| *** wes_dillingham has quit IRC | 21:32 | |
| *** dave-mccowan has quit IRC | 21:34 | |
| *** felipemonteiro__ has quit IRC | 21:36 | |
| *** armax has joined #openstack-cinder | 21:36 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 21:39 | |
| *** Apoorva has joined #openstack-cinder | 21:41 | |
| *** wes_dillingham has joined #openstack-cinder | 21:44 | |
| *** AlexeyAbashkin has quit IRC | 21:44 | |
| *** wes_dillingham has quit IRC | 22:09 | |
| *** tpsilva has quit IRC | 22:10 | |
| *** gouthamr_ has quit IRC | 22:23 | |
| *** Swimingly has quit IRC | 22:25 | |
| *** Swimingly has joined #openstack-cinder | 22:26 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 22:39 | |
| *** AlexeyAbashkin has quit IRC | 22:43 | |
| *** Apoorva has quit IRC | 22:53 | |
| *** Apoorva has joined #openstack-cinder | 22:53 | |
| *** wes_dillingham has joined #openstack-cinder | 23:11 | |
| *** ntpttr_laptop has quit IRC | 23:12 | |
| *** wes_dillingham has quit IRC | 23:13 | |
| *** gouthamr has joined #openstack-cinder | 23:30 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 23:39 | |
| *** gouthamr_ has joined #openstack-cinder | 23:43 | |
| *** AlexeyAbashkin has quit IRC | 23:43 | |
| *** gouthamr has quit IRC | 23:46 | |
| *** Apoorva has quit IRC | 23:46 | |
| *** superdan is now known as dansmith | 23:47 | |
| *** markvoelker has quit IRC | 23:49 | |
| *** gouthamr_ has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!