Wednesday, 2017-12-06

*** _pewp_ has quit IRC00:20
*** sdague has quit IRC00:20
*** _pewp_ has joined #openstack-cinder00:21
*** jmlowe has quit IRC00:22
*** threestrands has quit IRC00:25
*** sdague has joined #openstack-cinder00:26
*** gmann_afk is now known as gmann00:36
*** dhinesh_ has joined #openstack-cinder00:39
*** dhinesh has quit IRC00:42
*** itlinux has quit IRC01:00
*** dhinesh_ has quit IRC01:05
*** dhinesh has joined #openstack-cinder01:06
*** yangyapeng has joined #openstack-cinder01:14
*** dhinesh has quit IRC01:15
*** dhinesh has joined #openstack-cinder01:21
*** dhinesh_ has joined #openstack-cinder01:26
*** dhinesh has quit IRC01:26
*** psachin has joined #openstack-cinder01:29
*** Dinesh_Bhor has joined #openstack-cinder01:31
*** _pewp_ has quit IRC01:33
*** Dinesh_Bhor has quit IRC01:35
*** Dinesh_Bhor has joined #openstack-cinder01:35
*** _pewp_ has joined #openstack-cinder01:36
*** markvoelker has quit IRC01:38
*** zhurong has joined #openstack-cinder01:50
*** mriedem_away has quit IRC01:50
*** namnh has joined #openstack-cinder01:53
openstackgerritliuyamin proposed openstack/cinder master: TrivialFix: Delete word ‘I’ in admin/blockstorage-backup-disks.rst  https://review.openstack.org/52584601:54
*** dalgaaf has quit IRC02:01
*** dalgaaf has joined #openstack-cinder02:02
openstackgerritliuyamin proposed openstack/cinder master: TrivialFix: Delete word ‘I’ in admin/blockstorage-backup-disks.rst  https://review.openstack.org/52584602:06
*** mriedem has joined #openstack-cinder02:10
*** zhaochao has quit IRC02:19
*** mriedem has quit IRC02:23
*** dave-mccowan has joined #openstack-cinder02:26
*** dave-mccowan has quit IRC02:30
*** markstur has quit IRC02:32
*** Apoorva_ has joined #openstack-cinder02:33
*** zhaochao has joined #openstack-cinder02:34
*** Apoorva has quit IRC02:36
*** Apoorva_ has quit IRC02:37
*** markvoelker has joined #openstack-cinder02:39
*** itlinux has joined #openstack-cinder02:45
*** dave-mccowan has joined #openstack-cinder02:45
*** itlinux has quit IRC02:53
*** moshele has joined #openstack-cinder03:01
*** zhurong has quit IRC03:02
*** zhurong has joined #openstack-cinder03:09
*** lhx_ has joined #openstack-cinder03:10
*** lhx_ has quit IRC03:13
*** abhinavtechie has joined #openstack-cinder03:19
*** abhitechie has quit IRC03:19
*** abhishekk has joined #openstack-cinder03:29
*** markstur has joined #openstack-cinder03:31
*** markstur has quit IRC03:35
*** markstur has joined #openstack-cinder03:38
*** dhinesh_ has quit IRC03:40
*** dhinesh has joined #openstack-cinder03:40
*** abhinavtechie has quit IRC03:52
*** kristaps_ has joined #openstack-cinder03:57
*** v12aml_ has joined #openstack-cinder03:58
*** lvdombrkr has quit IRC03:58
*** v12aml has quit IRC03:59
*** links has joined #openstack-cinder03:59
*** v12aml_ is now known as v12aml03:59
*** ntpttr_ has quit IRC03:59
*** tbarron has quit IRC03:59
*** cfriesen_ has joined #openstack-cinder03:59
*** ntpttr_ has joined #openstack-cinder03:59
*** cfriesen has quit IRC03:59
*** tbarron has joined #openstack-cinder04:00
*** links has quit IRC04:01
*** links has joined #openstack-cinder04:01
openstackgerritJeremy Zhang proposed openstack/cinder master: Fix api-ref for v3 group type specs  https://review.openstack.org/52586804:04
*** dhinesh has quit IRC04:04
*** sdague has quit IRC04:05
*** dhinesh has joined #openstack-cinder04:06
*** Apoorva has joined #openstack-cinder04:12
*** chhavi has joined #openstack-cinder04:18
*** chhavi__ has joined #openstack-cinder04:18
*** zhurong has quit IRC04:21
*** dave-mccowan has quit IRC04:23
*** moshele has quit IRC04:28
*** david-lyle has joined #openstack-cinder04:32
*** gouthamr has quit IRC04:36
*** namnh has quit IRC04:41
*** hoangcx has quit IRC04:41
*** hoangcx has joined #openstack-cinder04:42
*** namnh has joined #openstack-cinder04:42
*** david-lyle has quit IRC04:42
*** sapd_ has quit IRC04:48
*** sapd has joined #openstack-cinder04:50
*** Apoorva_ has joined #openstack-cinder04:54
*** Apoorva has quit IRC04:57
*** Dinesh_Bhor has quit IRC05:01
*** zhurong has joined #openstack-cinder05:09
*** threestrands has joined #openstack-cinder05:09
*** threestrands has quit IRC05:09
*** liverpooler has quit IRC05:27
*** pgadiya has joined #openstack-cinder05:34
*** seitan has joined #openstack-cinder05:46
*** lkuchlan has joined #openstack-cinder05:48
*** Apoorva_ has quit IRC05:59
*** Dinesh_Bhor has joined #openstack-cinder06:00
*** AlexeyAbashkin has joined #openstack-cinder06:07
*** AlexeyAbashkin has quit IRC06:11
*** AlexeyAbashkin has joined #openstack-cinder06:12
*** wanghao has joined #openstack-cinder06:17
*** chhavi__ has quit IRC06:19
chhaviwxy: please review https://review.openstack.org/#/c/524091/06:22
*** AlexeyAbashkin has quit IRC06:26
*** lkuchlan is now known as lkuchlan_away06:29
*** moshele has joined #openstack-cinder06:32
*** markstur has quit IRC06:34
*** markstur has joined #openstack-cinder06:35
*** bkopilov has quit IRC06:35
*** markstur has quit IRC06:39
*** pgadiya has quit IRC06:51
*** gkadam has joined #openstack-cinder06:54
*** dhinesh has quit IRC06:58
openstackgerritwanghongxu proposed openstack/cinder master: fix AttributeError of dell emc driver  https://review.openstack.org/52591307:02
*** rcernin has quit IRC07:02
*** e0ne has joined #openstack-cinder07:06
seitanHello, is there anything more to be done for https://review.openstack.org/#/c/524331/ to be accepted?07:10
*** wanghao has quit IRC07:21
*** rcernin has joined #openstack-cinder07:39
*** wanghao has joined #openstack-cinder07:43
*** wanghao has quit IRC07:45
openstackgerritwanghongxu proposed openstack/cinder master: fix AttributeError of dell emc driver  https://review.openstack.org/52591307:45
*** wanghao has joined #openstack-cinder07:48
*** lkuchlan_away is now known as lkuchlan_wfh07:59
*** ildikov has quit IRC08:03
*** ildikov has joined #openstack-cinder08:04
*** laurent\ has quit IRC08:06
*** knikolla has quit IRC08:06
*** knikolla has joined #openstack-cinder08:07
*** mnaser has quit IRC08:08
*** zhongjun has quit IRC08:08
*** gmann has quit IRC08:09
*** mnaser has joined #openstack-cinder08:11
*** alexchadin has joined #openstack-cinder08:14
*** tesseract has joined #openstack-cinder08:19
openstackgerritJeremy Zhang proposed openstack/cinder master: Fix test case in test_volume_unicode.py  https://review.openstack.org/52598108:25
*** lkuchlan_wfh has quit IRC08:25
*** laurent\ has joined #openstack-cinder08:31
*** e0ne has quit IRC08:32
*** AlexeyAbashkin has joined #openstack-cinder08:32
*** zhurong has quit IRC08:33
*** lkuchlan_wfh has joined #openstack-cinder08:35
*** AlexeyAbashkin has quit IRC08:38
*** imacdonn has quit IRC08:39
*** imacdonn has joined #openstack-cinder08:40
*** AlexeyAbashkin has joined #openstack-cinder08:44
*** AlexeyAbashkin has quit IRC08:49
*** kwathore_ has quit IRC08:52
*** zhurong has joined #openstack-cinder08:54
*** kwathore has joined #openstack-cinder08:57
*** Dinesh_Bhor has quit IRC09:09
*** AlexeyAbashkin has joined #openstack-cinder09:14
*** hamdyk has joined #openstack-cinder09:15
*** armaan has joined #openstack-cinder09:21
*** lhx_ has joined #openstack-cinder09:27
*** armaan has quit IRC09:31
*** zhongjun has joined #openstack-cinder09:35
*** seitan has quit IRC09:35
*** seitan has joined #openstack-cinder09:38
*** wanghao has quit IRC09:43
*** e0ne has joined #openstack-cinder09:48
*** armaan has joined #openstack-cinder09:53
*** linkmark has joined #openstack-cinder09:57
*** sdague has joined #openstack-cinder09:59
*** gmann has joined #openstack-cinder10:05
*** armaan has quit IRC10:16
*** namnh has quit IRC10:25
*** wanghao has joined #openstack-cinder10:33
chhaviwxy, smcginnis: releasenotes document for skip_validation_flag removal, should be grouped under Bug-fixes or Other.10:33
*** ganso has joined #openstack-cinder10:34
*** zhurong has quit IRC10:37
*** alexchadin has quit IRC10:48
openstackgerritMerged openstack/cinder master: INFINIDAT: change CI_WIKI_NAME  https://review.openstack.org/52512110:49
openstackgerritMerged openstack/cinder master: Updated from global requirements  https://review.openstack.org/51908810:49
openstackgerritMerged openstack/cinder master: Fix for volume from image snapshot free space issue  https://review.openstack.org/52433110:49
*** mvk has quit IRC10:52
*** abhishekk has quit IRC11:00
*** hamdyk has quit IRC11:00
*** hamdyk has joined #openstack-cinder11:10
openstackgerritShay Halsband proposed openstack/cinder master: XtremIO: optional clean IG with no mappings  https://review.openstack.org/51539211:12
*** lpetrut has joined #openstack-cinder11:22
*** links has quit IRC11:34
*** yangyapeng has quit IRC11:36
*** yangyapeng has joined #openstack-cinder11:36
*** rcernin has quit IRC11:39
*** lhx_ has quit IRC11:40
*** lhx_ has joined #openstack-cinder11:41
*** links has joined #openstack-cinder11:48
*** alexchadin has joined #openstack-cinder11:49
*** AlexeyAbashkin has quit IRC11:58
*** openstackgerrit has quit IRC12:03
*** hamdyk has quit IRC12:07
*** openstackgerrit has joined #openstack-cinder12:08
openstackgerritChhavi Agarwal proposed openstack/cinder master: Remove skip_validation_flag to False by default  https://review.openstack.org/52409112:08
*** links has quit IRC12:08
*** dave-mccowan has joined #openstack-cinder12:13
*** links has joined #openstack-cinder12:13
*** alexchadin has quit IRC12:16
*** alexchadin has joined #openstack-cinder12:16
*** yangyapeng has quit IRC12:18
*** yangyapeng has joined #openstack-cinder12:18
*** yangyapeng has quit IRC12:25
*** mvk has joined #openstack-cinder12:41
openstackgerritMerged openstack/cinder master: V3 jsonschema validation: Group types  https://review.openstack.org/51964312:43
openstackgerritMerged openstack/cinder master: Fix retype migrating volume with rep_status 'not-capable'  https://review.openstack.org/52247312:43
openstackgerritMerged openstack/cinder master: Tests: Fix Storwize hash randomization failure  https://review.openstack.org/50413512:43
openstackgerritMerged openstack/cinder master: Tests: Cleanup utils.create_volume fields  https://review.openstack.org/52356312:43
openstackgerritMerged openstack/cinder master: Disallow managed volume to be managed again  https://review.openstack.org/52341712:43
*** abishop has joined #openstack-cinder12:45
*** AlexeyAbashkin has joined #openstack-cinder12:46
*** lkuchlan_wfh has quit IRC12:47
*** lhx__ has joined #openstack-cinder12:48
*** lhx_ has quit IRC12:49
*** zhaochao has quit IRC12:50
*** yangyapeng has joined #openstack-cinder12:50
*** zhaochao has joined #openstack-cinder12:52
*** tesseract has quit IRC12:53
*** lkuchlan_wfh has joined #openstack-cinder12:56
*** tesseract has joined #openstack-cinder12:57
*** lhx__ has quit IRC13:02
*** gmann is now known as gmann_afk13:05
*** takedakn has joined #openstack-cinder13:09
*** armaan has joined #openstack-cinder13:09
*** lkuchlan_wfh has quit IRC13:18
*** seitan has quit IRC13:19
*** armaan has quit IRC13:20
*** links has quit IRC13:23
*** lkuchlan_wfh has joined #openstack-cinder13:23
*** wanghao has quit IRC13:24
*** wanghao has joined #openstack-cinder13:24
*** markvoelker has quit IRC13:24
*** wanghao has quit IRC13:24
*** markvoelker has joined #openstack-cinder13:25
*** wanghao has joined #openstack-cinder13:25
*** lhx_ has joined #openstack-cinder13:25
*** wanghao has quit IRC13:25
*** wanghao has joined #openstack-cinder13:25
*** wanghao has quit IRC13:26
*** wanghao has joined #openstack-cinder13:26
*** wanghao has quit IRC13:27
*** wanghao has joined #openstack-cinder13:27
*** wanghao has quit IRC13:28
*** wanghao has joined #openstack-cinder13:28
*** wanghao has quit IRC13:28
*** takedakn has quit IRC13:39
*** mriedem has joined #openstack-cinder13:41
*** takedakn has joined #openstack-cinder13:41
*** alexchadin has quit IRC13:45
*** psachin has quit IRC13:45
*** liverpooler has joined #openstack-cinder14:01
*** david-lyle has joined #openstack-cinder14:13
*** dustins has joined #openstack-cinder14:14
*** mchlumsky has joined #openstack-cinder14:16
*** armax has quit IRC14:17
*** dave-mccowan has quit IRC14:17
*** gkadam has quit IRC14:18
*** takedakn has quit IRC14:18
*** crose has joined #openstack-cinder14:21
*** david-lyle has quit IRC14:31
*** salv-orlando has joined #openstack-cinder14:35
*** dustins has quit IRC14:36
*** tesseract has quit IRC14:37
*** tesseract has joined #openstack-cinder14:44
*** gouthamr has joined #openstack-cinder14:47
*** armax has joined #openstack-cinder14:49
openstackgerritHelen Walsh proposed openstack/cinder-specs master: Bulk Volume Create within Create Group API  https://review.openstack.org/51419614:50
*** armaan has joined #openstack-cinder15:03
*** salv-orlando has quit IRC15:03
*** salv-orlando has joined #openstack-cinder15:10
*** belmoreira has joined #openstack-cinder15:11
*** salv-orlando has quit IRC15:13
chrisyang_0660Our patch just needs a core reviewer to approve, please help, thanks. https://review.openstack.org/#/c/470188/15:16
*** jmlowe has joined #openstack-cinder15:16
*** armaan has quit IRC15:16
jungleboyjchrisyang_0660:  I will take a look today.15:16
*** wanghao has joined #openstack-cinder15:17
*** wanghao has quit IRC15:17
chrisyang_0660jungleboyj: thank you Jay :)15:18
*** lkuchlan_wfh has quit IRC15:25
*** david-lyle has joined #openstack-cinder15:26
chrisyang_0660e0ne: Thanks for the approval.15:28
e0nechrisyang_0660: np15:29
*** chenying has quit IRC15:32
*** zengyingzhe has quit IRC15:32
*** zhonghua2 has quit IRC15:33
*** david-lyle has quit IRC15:34
*** moshele has quit IRC15:35
*** crose has quit IRC15:36
*** Apoorva has joined #openstack-cinder15:37
*** salv-orlando has joined #openstack-cinder15:37
*** hemna_ has joined #openstack-cinder15:37
*** markstur has joined #openstack-cinder15:43
*** lpetrut has quit IRC15:43
openstackgerritHelen Walsh proposed openstack/cinder-specs master: Bulk Volume Create within Create Group API  https://review.openstack.org/51419615:44
*** lpetrut has joined #openstack-cinder15:44
jungleboyje0ne:  Thanks.15:45
e0nejungleboyj: np15:45
*** salv-orlando has quit IRC15:45
*** dustins has joined #openstack-cinder15:47
*** dave-mccowan has joined #openstack-cinder15:48
*** mvk has quit IRC15:48
_pewp_hemna_ |。・ω・|ノ16:01
*** lpetrut has quit IRC16:02
*** rhe00 has joined #openstack-cinder16:05
jungleboyjhemna_:  You are in the wrong channel.  COme to the meeting.16:09
*** erlon has joined #openstack-cinder16:13
*** belmoreira has quit IRC16:22
*** gouthamr has quit IRC16:23
openstackgerritIvan Kolodyazhny proposed openstack/cinder-specs master: Open specs for Rocky release  https://review.openstack.org/52612016:31
*** lpetrut has joined #openstack-cinder16:50
*** AlexeyAbashkin has quit IRC16:54
*** salv-orlando has joined #openstack-cinder16:58
*** e0ne has quit IRC17:07
*** itlinux has joined #openstack-cinder17:08
*** salv-orlando has quit IRC17:09
*** salv-orlando has joined #openstack-cinder17:10
*** david-lyle has joined #openstack-cinder17:10
*** sdague has quit IRC17:13
*** salv-orlando has quit IRC17:14
*** salv-orlando has joined #openstack-cinder17:26
*** salv-orlando has quit IRC17:26
*** salv-orlando has joined #openstack-cinder17:27
*** Apoorva has quit IRC17:27
*** vivek__ has joined #openstack-cinder17:29
*** salv-orlando has quit IRC17:32
*** david-lyle has quit IRC17:32
vivek__Hi Team, I have proposed a fix on driverfixes/ocata.. but zuul check is failing17:32
*** david-lyle has joined #openstack-cinder17:32
vivek__http://logs.openstack.org/19/525719/1/check/openstack-tox-py27/f0c6813/job-output.txt.gz17:32
vivek__this failure seems to be related to python package 'cryptography' VERSION17:33
jungleboyjvivek__:  Yeah, I see that.  I was hoping that eharney would see that as he has been working on driverfixes issues.17:33
vivek__ok17:34
vivek__jungleboy: i suspect there might be something wrong with the latest version of 'cryptography' 2.1.417:37
vivek__may be we can try with 'cryptography' 2.1.3.. to confirm the issue is with 'cryptography' 2.1.417:38
jungleboyjMaybe something we need to cap in driverfixes?17:41
vivek__yes17:43
jungleboyjCan you try submitting a patch with that change?17:43
*** gouthamr has joined #openstack-cinder17:44
*** david-lyle has quit IRC17:45
*** lhx_ has quit IRC17:46
openstackgerritMerged openstack/cinder-specs master: Open specs for Rocky release  https://review.openstack.org/52612017:49
*** abhishekk has joined #openstack-cinder17:54
*** abhishekk has quit IRC17:54
*** chhavi has quit IRC17:56
*** abhishekk has joined #openstack-cinder17:58
smcginnisvivek__, jungleboyj: It's probably not using the right upper constraints for that branch.18:00
*** moshele has joined #openstack-cinder18:04
*** tesseract has quit IRC18:07
*** salv-orlando has joined #openstack-cinder18:10
mriedemjgriffith: correct me if i'm wrong, but when updating an attachment and passing the connector dict, does that connector dict get stored in the AttachmentSpecs which is related to the attachment, and presumably could be something we could get out of the cinder attachments API at some point?18:11
mriedembecause right now in nova we have this workaround where we stash the host connector in the bdm.connection_info https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L31918:12
mriedemif cinder is storing all of that information, we can eventually stop relying on this workaround18:12
*** david-lyle has joined #openstack-cinder18:13
jgriffithmriedem: yes, I store it in the AttachmentSpec, that was one of the main points of this (eliminate need to store in NOva)18:13
*** dustins has quit IRC18:14
mriedemok, tha'ts not exposed out of the rest api though is it?18:14
*** dustins has joined #openstack-cinder18:14
jgriffithSo you can also easily retireve it via  attachment detail18:14
mriedemi'm just adding some todos to the nova code for things we can eventually stop hacking around with the bdm.connection_info if/when we can do the new stuff18:14
mriedemi didn't see it in the attachments view18:14
*** Apoorva has joined #openstack-cinder18:15
*** Apoorva has quit IRC18:15
mriedemhttps://github.com/openstack/cinder/blob/master/cinder/api/v3/views/attachments.py#L2818:15
jgriffithlet me see what's up, my connection i scrap so bare with me18:15
* mriedem gets lunch18:15
mriedemno rush18:15
*** Apoorva has joined #openstack-cinder18:15
jgriffithmriedem: k, if it' sno tthere that's a bug and we need to add it back in18:16
*** david-lyle has quit IRC18:18
*** david-lyle has joined #openstack-cinder18:18
vivek__smcginnis: ok. so in case if we have the fix for it, may i request you to proposed a fix18:19
*** dave-mccowan has quit IRC18:20
*** salv-orlando has quit IRC18:21
vivek__i won't able to get my patch into driverfixes/ocata unless & until this zuul issue fix18:21
*** dhinesh has joined #openstack-cinder18:21
*** salv-orlando has joined #openstack-cinder18:21
*** abhishekk has quit IRC18:22
*** salv-orlando has quit IRC18:26
*** gkadam has joined #openstack-cinder18:32
*** david-lyle has quit IRC18:33
jgriffithmriedem: it is there it turns out http://paste.openstack.org/show/628304/18:36
jgriffithmriedem: *but* there's a pretty serious bug because it's not filtered out for non-admin which it should be18:37
*** e0ne has joined #openstack-cinder18:39
jgriffithmriedem: the raw data is added in paste http://paste.openstack.org/show/628305/18:43
jgriffithI'll log a bug and work on that18:43
mriedemoo yeah yikes18:44
mriedemjgriffith: that's the connection_info though, not the host connector18:45
mriedemi'm asking about the host connector18:45
*** moshele has quit IRC18:45
mriedemwhich is stored in attachmentspecs18:45
mriedembut definitely a bug on showing connection_info for a non-admin, user/pass is right there :)18:45
mriedemprobably a cve...18:46
ildikovjgriffith: mriedem: we use it in Nova already: https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L450-#L45218:46
mriedemildikov: that's the connection_info18:46
mriedemconnection_info != host connector18:46
ildikovmriedem: ah, ok, mixed up the two as always :)18:46
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L37118:46
mriedemthe host connector comes from brick18:47
mriedemconnection_info comes from the backend storage driver18:47
ildikovyep, that part I know18:48
vivek__mriedem, ildikov: are you talking about connector['multipath'] not set properly18:48
ildikovvivek__: no, we would like to store less things in Nova and rather retrieve the info from Cinder18:49
vivek__Even if we set 'volume_use_multipath=True' in nova.conf 'libvirt' section then also "connector['multipath']=False" is populated18:51
vivek__even after multipathd is runing properly18:51
vivek__https://bugs.launchpad.net/nova/+bug/172392818:52
openstackLaunchpad bug 1723928 in os-brick "In case of volume_use_multipath=True, Nova unable to fetch CONF.libvirt.volume_use_multipath value from nova.conf" [Undecided,New]18:52
jgriffithmriedem: ildikov BTW that connection_info in the attachment-spes should include a 1:1 copy of the connector keys as well18:54
mriedemjgriffith: not seeing that,18:54
mriedemthere would be a host or something in there18:55
ildikovjgriffith: I remember playing with that at a certain point18:55
jgriffithmriedem: actually...  you are probably correct.  I think at one point we decided that the only thing of value was the host and instance and the connection_info itself18:55
ildikovwell no, false alarm: https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L20818:56
jgriffithmriedem: storing of the connector itself we decided didn't make sense, because typically if it was needed again it was to get a connection_info object18:56
mriedemwhatever this returns from brick https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L112418:56
mriedemjgriffith: i thought the host connector was stored in the attachmentspecs table?18:56
ildikovjgriffith: mriedem: so currently the attachment translate code doesn't drop it, but also doesn't deal with it explicitly18:57
mriedemhttps://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L434118:57
mriedemjgriffith: ^18:57
mriedemthat's just a key/value table for what's in the connector dict18:58
mriedemmapped to the attachment id18:58
mriedemwould probably be a lot more efficient to just store that as a json blob, but...18:59
mriedemanyway, looks like it's there and we could expose the host connector later if needed19:00
jgriffithmriedem: I'm open to enahncements on that19:00
jgriffithI know that's dirty19:00
mriedemGET /attachments/{id}/connector19:00
mriedemsomething like that19:00
mriedemadmin-only19:00
jgriffithmriedem: yeah... sorry, I missed that it's in there, took you for your word when you said you didn't see it :)19:00
ildikovwe said we will store all these so we can do detach safely with all the info later in case shared targets and multi attach and alien attacks and what not19:01
mriedemyup19:01
ildikovand the connection info is pretty nasty in itself with or without connector... :(19:01
mriedemanyway, nothing depends on that now, just future cleanup work19:01
mriedemi'm adding todos to the nova code about relying on the bdm.connection_info during detach and how we shouldn't do that19:02
ildikovmriedem: feel free to keep on adding the FIXME(ildikov) notes... :)19:02
mriedemi only do that in the multiattach patches19:02
mriedemsince i don't want to own those19:02
jgriffithmriedem: I'll try and get that bug fixed sometime today, let me know if you see something else wonky19:03
ildikovmriedem: sorry, was just kidding and I didn't want you to own those19:03
ildikovmriedem: I thought to quickly remove some connection_info dependency in Nova but it didn't seem a that easy task so thought to deal with that later19:04
mriedemjgriffith: i'm assuming you'll be adding a policy rule for exposing that field, defaulting to admin-only?19:04
*** vivek__ has quit IRC19:05
jgriffithmriedem: yup, because now that I'm looking at it; I know why it's the way it is.  Standalone case needs it as non-admin19:07
jgriffithmriedem: so I'll add a policy to deal with it appropriately19:07
mriedemildikov: now that i'm looking at this, we need to do this in attachment_update too https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L41719:07
mriedemand attachment_create19:08
mriedembecause of this https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L31919:08
mriedemor if we hit that code, it's because we aren't doing something correctly with evacuate19:13
ildikovmriedem: shouldn't it be in connection_info when it comes back from Cinder?19:15
mriedemoh hrm, we don't care about the stashed connector in this new flow because we won't need it https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L35919:15
ildikovOh yeah, attachment_id is the key now everywhere19:17
ildikovI wasn't sure why you brought it up19:17
*** erlon has quit IRC19:17
mriedemwell, things get funny with evacuate19:18
ildikovInteresting viewpoint on what one would call 'funny' :)19:19
*** dave-mccowan has joined #openstack-cinder19:25
*** harlowja has quit IRC19:32
*** moshele has joined #openstack-cinder19:35
*** harlowja has joined #openstack-cinder19:36
*** mvk has joined #openstack-cinder19:39
*** crose has joined #openstack-cinder19:51
*** crose has quit IRC20:05
*** gkadam has quit IRC20:14
*** crose has joined #openstack-cinder20:18
*** crose has quit IRC20:31
*** Anticime1 has quit IRC20:31
*** jdurgin has quit IRC20:31
*** _alastor_ has quit IRC20:31
*** fmccrthy has quit IRC20:31
*** zhenguo has quit IRC20:31
*** dgonzalez has quit IRC20:31
*** moshele has quit IRC20:31
*** dave-mccowan has quit IRC20:31
*** jmlowe has quit IRC20:31
*** gnufied has quit IRC20:31
*** supamatt has quit IRC20:31
*** MasterofJOKers has quit IRC20:31
*** arnewiebalck has quit IRC20:31
*** uberjay has quit IRC20:33
*** aspiers[m] has quit IRC20:35
*** wN_ has quit IRC20:35
*** uberjay has joined #openstack-cinder20:36
*** mikal has quit IRC20:38
*** itlinux has quit IRC20:40
*** markstur has quit IRC20:42
*** mikal has joined #openstack-cinder20:43
*** lpetrut has quit IRC20:45
*** _alastor_ has joined #openstack-cinder20:47
*** Anticime1 has joined #openstack-cinder20:47
*** jdurgin has joined #openstack-cinder20:47
*** fmccrthy has joined #openstack-cinder20:47
*** zhenguo has joined #openstack-cinder20:47
*** dgonzalez has joined #openstack-cinder20:47
*** moshele has joined #openstack-cinder20:47
*** dave-mccowan has joined #openstack-cinder20:47
*** jmlowe has joined #openstack-cinder20:47
*** gnufied has joined #openstack-cinder20:47
*** supamatt has joined #openstack-cinder20:47
*** MasterofJOKers has joined #openstack-cinder20:47
*** arnewiebalck has joined #openstack-cinder20:47
*** moshele has quit IRC20:51
*** itlinux has joined #openstack-cinder20:53
jungleboyjmilestone 2 has been proposed for those interested:  https://review.openstack.org/52618820:56
*** markstur has joined #openstack-cinder20:57
*** harlowja has quit IRC21:00
*** liverpooler has quit IRC21:02
*** harlowja has joined #openstack-cinder21:03
ildikovjungleboyj: hi21:05
ildikovjungleboyj: where are we with the missing microversions in the client?21:05
*** salv-orlando has joined #openstack-cinder21:08
*** kambiz has quit IRC21:09
*** dustins has quit IRC21:12
*** kambiz has joined #openstack-cinder21:12
*** itlinux has quit IRC21:13
*** salv-orlando has quit IRC21:16
*** salv-orlando has joined #openstack-cinder21:17
*** sticker has joined #openstack-cinder21:19
*** salv-orlando has quit IRC21:21
*** ganso has quit IRC21:22
jungleboyjThere were patches up. I had at least one comment. Let me see if that was addressed.21:25
*** itlinux has joined #openstack-cinder21:26
*** zengyingzhe has joined #openstack-cinder21:30
*** zhonghua has joined #openstack-cinder21:30
*** chenying has joined #openstack-cinder21:30
*** harlowja has quit IRC21:32
*** gouthamr has quit IRC21:36
*** sdague has joined #openstack-cinder21:38
*** AlexeyAbashkin has joined #openstack-cinder21:38
*** openstackgerrit has quit IRC21:38
*** _pewp_ has quit IRC21:38
*** winston-d has quit IRC21:38
*** sri_ has quit IRC21:38
*** SamYaple has quit IRC21:38
*** ericyoung has quit IRC21:38
*** lifeless has quit IRC21:38
*** mfisch has quit IRC21:38
*** afazekas has quit IRC21:38
*** diegows has quit IRC21:38
*** david-lyle has joined #openstack-cinder21:39
ildikovjungleboyj: thanks21:39
jungleboyjildikov: yep, will do when back to a computer.21:40
ildikovjungleboyj: no rush, might not be super urgent, but would be great to get that done in general anyway21:41
ildikovjungleboyj: we have the meeting on for tomorrow, I'm available for the first half an hour, but as half of the team is at KubeCon anyway we can sort out things like what's up with the Cinder client quickly21:42
*** liverpooler has joined #openstack-cinder21:44
*** dulek_mobile has joined #openstack-cinder21:44
*** dulek_mobile has quit IRC21:45
*** david-lyle has quit IRC21:47
*** SamYaple has joined #openstack-cinder21:49
jungleboyjildikov: sounds good. Would be nice to take care of that either way.21:51
*** itlinux has quit IRC21:59
*** openstackgerrit has joined #openstack-cinder22:01
*** _pewp_ has joined #openstack-cinder22:01
*** winston-d has joined #openstack-cinder22:01
*** sri_ has joined #openstack-cinder22:01
*** ericyoung has joined #openstack-cinder22:01
*** lifeless has joined #openstack-cinder22:01
*** mfisch has joined #openstack-cinder22:01
*** afazekas has joined #openstack-cinder22:01
*** diegows has joined #openstack-cinder22:01
*** rcernin has joined #openstack-cinder22:01
*** rcernin has quit IRC22:03
*** rcernin has joined #openstack-cinder22:03
*** e0ne has quit IRC22:06
*** e0ne has joined #openstack-cinder22:07
*** e0ne has quit IRC22:07
*** e0ne has joined #openstack-cinder22:08
*** e0ne has quit IRC22:08
*** e0ne has joined #openstack-cinder22:08
*** e0ne has quit IRC22:09
*** e0ne has joined #openstack-cinder22:10
*** moshele has joined #openstack-cinder22:10
*** e0ne has quit IRC22:10
*** e0ne has joined #openstack-cinder22:11
*** e0ne has quit IRC22:11
*** e0ne has joined #openstack-cinder22:12
*** e0ne has quit IRC22:12
*** e0ne has joined #openstack-cinder22:12
*** e0ne has quit IRC22:13
ildikovjungleboyj: I would say necessary, but we can leave it as nice for today :)22:17
*** abishop has quit IRC22:24
*** salv-orlando has joined #openstack-cinder22:27
*** gouthamr has joined #openstack-cinder22:28
*** salv-orlando has quit IRC22:32
*** harlowja has joined #openstack-cinder22:36
*** AlexeyAbashkin has quit IRC22:43
*** stapler117 has joined #openstack-cinder22:53
*** gouthamr has quit IRC22:53
*** gouthamr has joined #openstack-cinder22:56
*** stapler117 is now known as stapler11822:56
*** salv-orlando has joined #openstack-cinder22:57
*** salv-orlando has quit IRC23:05
*** salv-orlando has joined #openstack-cinder23:05
*** wanghao has joined #openstack-cinder23:08
*** wanghao has quit IRC23:08
jungleboyjildikov:  Merging 3.45:  https://review.openstack.org/#/c/52512023:08
jungleboyj3.46:  https://review.openstack.org/#/c/525035/223:09
*** mriedem has left #openstack-cinder23:10
*** salv-orlando has quit IRC23:10
jungleboyjand 3.47 ...23:11
*** wanghao has joined #openstack-cinder23:11
ildikovjungleboyj: nice, thanks!23:12
jungleboyjildikov:  No problem.23:13
jungleboyjSo, jgriffith  has this patch out there:  https://review.openstack.org/#/c/524700/23:14
jungleboyjWas all we needed the MV bump?23:14
jungleboyjOr is there something else that needs to merge23:14
jungleboyjildikov: ^^^23:14
*** wanghao has quit IRC23:15
ildikovjungleboyj: I'm not sure whether the server side patch has merged or not23:15
ildikovI think it did, it needs to be double checked, otherwise just the version bumps in the client and we're good23:16
jungleboyjildikov:   It did.23:16
ildikovOk, cool23:16
jungleboyjOk, he commented that it was WIP because of the missing changes.23:17
jungleboyjIt failed Zuul though so I am rechecking.23:19
*** david-lyle has joined #openstack-cinder23:22
jgriffithildikov: jungleboyj tommylikehu ummmmm.....23:25
*** wanghao has joined #openstack-cinder23:26
jungleboyjjgriffith: What?23:26
*** armaan has joined #openstack-cinder23:26
* jgriffith is confused... is there a bump to 3.47? That's all that's needed here. Or more specifically the impl of 3.47 and bump to 3.4823:27
jgriffithunless you just want to have them independent commits which is reasonable/fair23:27
*** openstack has joined #openstack-cinder23:31
*** ChanServ sets mode: +o openstack23:31
jgriffithno need to try and rewrite history (45 and 46) that I can see23:31
jungleboyjjgriffith:  Right!23:32
jgriffithjungleboyj: so then you don't need https://review.openstack.org/#/c/525035/223:32
*** gmann_afk is now known as gmann23:33
jgriffithOr just ignore me, because it will all work/settle out eventually23:33
jungleboyjWell, that one was kind-of overkill but I thought it was good to have that patch in the line to purposefully bump to 3.46.23:33
*** takedakn has quit IRC23:34
*** moshele has quit IRC23:36
*** stakeda has joined #openstack-cinder23:39
ildikovHaving all the bumps is good, the patch would've been nicer in a chain on top of the 3.45 changes, but at this point I'm not complaining23:39
jungleboyj:-)  I was taking wht I could get.23:40
ildikovjgriffith: I tried my best to keep it on the right track this time, I swear :)23:41
*** edmondsw has joined #openstack-cinder23:42
*** sdague has quit IRC23:42
*** david-lyle has quit IRC23:44
*** armax has quit IRC23:45
*** salv-orlando has joined #openstack-cinder23:46
*** salv-orlando has quit IRC23:50
*** salv-orlando has joined #openstack-cinder23:51
*** chhavi has joined #openstack-cinder23:52
*** salv-orlando has quit IRC23:55
*** david-lyle has joined #openstack-cinder23:57
*** chhavi has quit IRC23:57
*** salv-orlando has joined #openstack-cinder23:57
jungleboyjSo jgriffith and ildikov once the other patches merge, lets merge https://review.openstack.org/#/c/524700/ then I will do a release tomorrow.23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!