*** _pewp_ has quit IRC | 00:20 | |
*** sdague has quit IRC | 00:20 | |
*** _pewp_ has joined #openstack-cinder | 00:21 | |
*** jmlowe has quit IRC | 00:22 | |
*** threestrands has quit IRC | 00:25 | |
*** sdague has joined #openstack-cinder | 00:26 | |
*** gmann_afk is now known as gmann | 00:36 | |
*** dhinesh_ has joined #openstack-cinder | 00:39 | |
*** dhinesh has quit IRC | 00:42 | |
*** itlinux has quit IRC | 01:00 | |
*** dhinesh_ has quit IRC | 01:05 | |
*** dhinesh has joined #openstack-cinder | 01:06 | |
*** yangyapeng has joined #openstack-cinder | 01:14 | |
*** dhinesh has quit IRC | 01:15 | |
*** dhinesh has joined #openstack-cinder | 01:21 | |
*** dhinesh_ has joined #openstack-cinder | 01:26 | |
*** dhinesh has quit IRC | 01:26 | |
*** psachin has joined #openstack-cinder | 01:29 | |
*** Dinesh_Bhor has joined #openstack-cinder | 01:31 | |
*** _pewp_ has quit IRC | 01:33 | |
*** Dinesh_Bhor has quit IRC | 01:35 | |
*** Dinesh_Bhor has joined #openstack-cinder | 01:35 | |
*** _pewp_ has joined #openstack-cinder | 01:36 | |
*** markvoelker has quit IRC | 01:38 | |
*** zhurong has joined #openstack-cinder | 01:50 | |
*** mriedem_away has quit IRC | 01:50 | |
*** namnh has joined #openstack-cinder | 01:53 | |
openstackgerrit | liuyamin proposed openstack/cinder master: TrivialFix: Delete word ‘I’ in admin/blockstorage-backup-disks.rst https://review.openstack.org/525846 | 01:54 |
---|---|---|
*** dalgaaf has quit IRC | 02:01 | |
*** dalgaaf has joined #openstack-cinder | 02:02 | |
openstackgerrit | liuyamin proposed openstack/cinder master: TrivialFix: Delete word ‘I’ in admin/blockstorage-backup-disks.rst https://review.openstack.org/525846 | 02:06 |
*** mriedem has joined #openstack-cinder | 02:10 | |
*** zhaochao has quit IRC | 02:19 | |
*** mriedem has quit IRC | 02:23 | |
*** dave-mccowan has joined #openstack-cinder | 02:26 | |
*** dave-mccowan has quit IRC | 02:30 | |
*** markstur has quit IRC | 02:32 | |
*** Apoorva_ has joined #openstack-cinder | 02:33 | |
*** zhaochao has joined #openstack-cinder | 02:34 | |
*** Apoorva has quit IRC | 02:36 | |
*** Apoorva_ has quit IRC | 02:37 | |
*** markvoelker has joined #openstack-cinder | 02:39 | |
*** itlinux has joined #openstack-cinder | 02:45 | |
*** dave-mccowan has joined #openstack-cinder | 02:45 | |
*** itlinux has quit IRC | 02:53 | |
*** moshele has joined #openstack-cinder | 03:01 | |
*** zhurong has quit IRC | 03:02 | |
*** zhurong has joined #openstack-cinder | 03:09 | |
*** lhx_ has joined #openstack-cinder | 03:10 | |
*** lhx_ has quit IRC | 03:13 | |
*** abhinavtechie has joined #openstack-cinder | 03:19 | |
*** abhitechie has quit IRC | 03:19 | |
*** abhishekk has joined #openstack-cinder | 03:29 | |
*** markstur has joined #openstack-cinder | 03:31 | |
*** markstur has quit IRC | 03:35 | |
*** markstur has joined #openstack-cinder | 03:38 | |
*** dhinesh_ has quit IRC | 03:40 | |
*** dhinesh has joined #openstack-cinder | 03:40 | |
*** abhinavtechie has quit IRC | 03:52 | |
*** kristaps_ has joined #openstack-cinder | 03:57 | |
*** v12aml_ has joined #openstack-cinder | 03:58 | |
*** lvdombrkr has quit IRC | 03:58 | |
*** v12aml has quit IRC | 03:59 | |
*** links has joined #openstack-cinder | 03:59 | |
*** v12aml_ is now known as v12aml | 03:59 | |
*** ntpttr_ has quit IRC | 03:59 | |
*** tbarron has quit IRC | 03:59 | |
*** cfriesen_ has joined #openstack-cinder | 03:59 | |
*** ntpttr_ has joined #openstack-cinder | 03:59 | |
*** cfriesen has quit IRC | 03:59 | |
*** tbarron has joined #openstack-cinder | 04:00 | |
*** links has quit IRC | 04:01 | |
*** links has joined #openstack-cinder | 04:01 | |
openstackgerrit | Jeremy Zhang proposed openstack/cinder master: Fix api-ref for v3 group type specs https://review.openstack.org/525868 | 04:04 |
*** dhinesh has quit IRC | 04:04 | |
*** sdague has quit IRC | 04:05 | |
*** dhinesh has joined #openstack-cinder | 04:06 | |
*** Apoorva has joined #openstack-cinder | 04:12 | |
*** chhavi has joined #openstack-cinder | 04:18 | |
*** chhavi__ has joined #openstack-cinder | 04:18 | |
*** zhurong has quit IRC | 04:21 | |
*** dave-mccowan has quit IRC | 04:23 | |
*** moshele has quit IRC | 04:28 | |
*** david-lyle has joined #openstack-cinder | 04:32 | |
*** gouthamr has quit IRC | 04:36 | |
*** namnh has quit IRC | 04:41 | |
*** hoangcx has quit IRC | 04:41 | |
*** hoangcx has joined #openstack-cinder | 04:42 | |
*** namnh has joined #openstack-cinder | 04:42 | |
*** david-lyle has quit IRC | 04:42 | |
*** sapd_ has quit IRC | 04:48 | |
*** sapd has joined #openstack-cinder | 04:50 | |
*** Apoorva_ has joined #openstack-cinder | 04:54 | |
*** Apoorva has quit IRC | 04:57 | |
*** Dinesh_Bhor has quit IRC | 05:01 | |
*** zhurong has joined #openstack-cinder | 05:09 | |
*** threestrands has joined #openstack-cinder | 05:09 | |
*** threestrands has quit IRC | 05:09 | |
*** liverpooler has quit IRC | 05:27 | |
*** pgadiya has joined #openstack-cinder | 05:34 | |
*** seitan has joined #openstack-cinder | 05:46 | |
*** lkuchlan has joined #openstack-cinder | 05:48 | |
*** Apoorva_ has quit IRC | 05:59 | |
*** Dinesh_Bhor has joined #openstack-cinder | 06:00 | |
*** AlexeyAbashkin has joined #openstack-cinder | 06:07 | |
*** AlexeyAbashkin has quit IRC | 06:11 | |
*** AlexeyAbashkin has joined #openstack-cinder | 06:12 | |
*** wanghao has joined #openstack-cinder | 06:17 | |
*** chhavi__ has quit IRC | 06:19 | |
chhavi | wxy: please review https://review.openstack.org/#/c/524091/ | 06:22 |
*** AlexeyAbashkin has quit IRC | 06:26 | |
*** lkuchlan is now known as lkuchlan_away | 06:29 | |
*** moshele has joined #openstack-cinder | 06:32 | |
*** markstur has quit IRC | 06:34 | |
*** markstur has joined #openstack-cinder | 06:35 | |
*** bkopilov has quit IRC | 06:35 | |
*** markstur has quit IRC | 06:39 | |
*** pgadiya has quit IRC | 06:51 | |
*** gkadam has joined #openstack-cinder | 06:54 | |
*** dhinesh has quit IRC | 06:58 | |
openstackgerrit | wanghongxu proposed openstack/cinder master: fix AttributeError of dell emc driver https://review.openstack.org/525913 | 07:02 |
*** rcernin has quit IRC | 07:02 | |
*** e0ne has joined #openstack-cinder | 07:06 | |
seitan | Hello, is there anything more to be done for https://review.openstack.org/#/c/524331/ to be accepted? | 07:10 |
*** wanghao has quit IRC | 07:21 | |
*** rcernin has joined #openstack-cinder | 07:39 | |
*** wanghao has joined #openstack-cinder | 07:43 | |
*** wanghao has quit IRC | 07:45 | |
openstackgerrit | wanghongxu proposed openstack/cinder master: fix AttributeError of dell emc driver https://review.openstack.org/525913 | 07:45 |
*** wanghao has joined #openstack-cinder | 07:48 | |
*** lkuchlan_away is now known as lkuchlan_wfh | 07:59 | |
*** ildikov has quit IRC | 08:03 | |
*** ildikov has joined #openstack-cinder | 08:04 | |
*** laurent\ has quit IRC | 08:06 | |
*** knikolla has quit IRC | 08:06 | |
*** knikolla has joined #openstack-cinder | 08:07 | |
*** mnaser has quit IRC | 08:08 | |
*** zhongjun has quit IRC | 08:08 | |
*** gmann has quit IRC | 08:09 | |
*** mnaser has joined #openstack-cinder | 08:11 | |
*** alexchadin has joined #openstack-cinder | 08:14 | |
*** tesseract has joined #openstack-cinder | 08:19 | |
openstackgerrit | Jeremy Zhang proposed openstack/cinder master: Fix test case in test_volume_unicode.py https://review.openstack.org/525981 | 08:25 |
*** lkuchlan_wfh has quit IRC | 08:25 | |
*** laurent\ has joined #openstack-cinder | 08:31 | |
*** e0ne has quit IRC | 08:32 | |
*** AlexeyAbashkin has joined #openstack-cinder | 08:32 | |
*** zhurong has quit IRC | 08:33 | |
*** lkuchlan_wfh has joined #openstack-cinder | 08:35 | |
*** AlexeyAbashkin has quit IRC | 08:38 | |
*** imacdonn has quit IRC | 08:39 | |
*** imacdonn has joined #openstack-cinder | 08:40 | |
*** AlexeyAbashkin has joined #openstack-cinder | 08:44 | |
*** AlexeyAbashkin has quit IRC | 08:49 | |
*** kwathore_ has quit IRC | 08:52 | |
*** zhurong has joined #openstack-cinder | 08:54 | |
*** kwathore has joined #openstack-cinder | 08:57 | |
*** Dinesh_Bhor has quit IRC | 09:09 | |
*** AlexeyAbashkin has joined #openstack-cinder | 09:14 | |
*** hamdyk has joined #openstack-cinder | 09:15 | |
*** armaan has joined #openstack-cinder | 09:21 | |
*** lhx_ has joined #openstack-cinder | 09:27 | |
*** armaan has quit IRC | 09:31 | |
*** zhongjun has joined #openstack-cinder | 09:35 | |
*** seitan has quit IRC | 09:35 | |
*** seitan has joined #openstack-cinder | 09:38 | |
*** wanghao has quit IRC | 09:43 | |
*** e0ne has joined #openstack-cinder | 09:48 | |
*** armaan has joined #openstack-cinder | 09:53 | |
*** linkmark has joined #openstack-cinder | 09:57 | |
*** sdague has joined #openstack-cinder | 09:59 | |
*** gmann has joined #openstack-cinder | 10:05 | |
*** armaan has quit IRC | 10:16 | |
*** namnh has quit IRC | 10:25 | |
*** wanghao has joined #openstack-cinder | 10:33 | |
chhavi | wxy, smcginnis: releasenotes document for skip_validation_flag removal, should be grouped under Bug-fixes or Other. | 10:33 |
*** ganso has joined #openstack-cinder | 10:34 | |
*** zhurong has quit IRC | 10:37 | |
*** alexchadin has quit IRC | 10:48 | |
openstackgerrit | Merged openstack/cinder master: INFINIDAT: change CI_WIKI_NAME https://review.openstack.org/525121 | 10:49 |
openstackgerrit | Merged openstack/cinder master: Updated from global requirements https://review.openstack.org/519088 | 10:49 |
openstackgerrit | Merged openstack/cinder master: Fix for volume from image snapshot free space issue https://review.openstack.org/524331 | 10:49 |
*** mvk has quit IRC | 10:52 | |
*** abhishekk has quit IRC | 11:00 | |
*** hamdyk has quit IRC | 11:00 | |
*** hamdyk has joined #openstack-cinder | 11:10 | |
openstackgerrit | Shay Halsband proposed openstack/cinder master: XtremIO: optional clean IG with no mappings https://review.openstack.org/515392 | 11:12 |
*** lpetrut has joined #openstack-cinder | 11:22 | |
*** links has quit IRC | 11:34 | |
*** yangyapeng has quit IRC | 11:36 | |
*** yangyapeng has joined #openstack-cinder | 11:36 | |
*** rcernin has quit IRC | 11:39 | |
*** lhx_ has quit IRC | 11:40 | |
*** lhx_ has joined #openstack-cinder | 11:41 | |
*** links has joined #openstack-cinder | 11:48 | |
*** alexchadin has joined #openstack-cinder | 11:49 | |
*** AlexeyAbashkin has quit IRC | 11:58 | |
*** openstackgerrit has quit IRC | 12:03 | |
*** hamdyk has quit IRC | 12:07 | |
*** openstackgerrit has joined #openstack-cinder | 12:08 | |
openstackgerrit | Chhavi Agarwal proposed openstack/cinder master: Remove skip_validation_flag to False by default https://review.openstack.org/524091 | 12:08 |
*** links has quit IRC | 12:08 | |
*** dave-mccowan has joined #openstack-cinder | 12:13 | |
*** links has joined #openstack-cinder | 12:13 | |
*** alexchadin has quit IRC | 12:16 | |
*** alexchadin has joined #openstack-cinder | 12:16 | |
*** yangyapeng has quit IRC | 12:18 | |
*** yangyapeng has joined #openstack-cinder | 12:18 | |
*** yangyapeng has quit IRC | 12:25 | |
*** mvk has joined #openstack-cinder | 12:41 | |
openstackgerrit | Merged openstack/cinder master: V3 jsonschema validation: Group types https://review.openstack.org/519643 | 12:43 |
openstackgerrit | Merged openstack/cinder master: Fix retype migrating volume with rep_status 'not-capable' https://review.openstack.org/522473 | 12:43 |
openstackgerrit | Merged openstack/cinder master: Tests: Fix Storwize hash randomization failure https://review.openstack.org/504135 | 12:43 |
openstackgerrit | Merged openstack/cinder master: Tests: Cleanup utils.create_volume fields https://review.openstack.org/523563 | 12:43 |
openstackgerrit | Merged openstack/cinder master: Disallow managed volume to be managed again https://review.openstack.org/523417 | 12:43 |
*** abishop has joined #openstack-cinder | 12:45 | |
*** AlexeyAbashkin has joined #openstack-cinder | 12:46 | |
*** lkuchlan_wfh has quit IRC | 12:47 | |
*** lhx__ has joined #openstack-cinder | 12:48 | |
*** lhx_ has quit IRC | 12:49 | |
*** zhaochao has quit IRC | 12:50 | |
*** yangyapeng has joined #openstack-cinder | 12:50 | |
*** zhaochao has joined #openstack-cinder | 12:52 | |
*** tesseract has quit IRC | 12:53 | |
*** lkuchlan_wfh has joined #openstack-cinder | 12:56 | |
*** tesseract has joined #openstack-cinder | 12:57 | |
*** lhx__ has quit IRC | 13:02 | |
*** gmann is now known as gmann_afk | 13:05 | |
*** takedakn has joined #openstack-cinder | 13:09 | |
*** armaan has joined #openstack-cinder | 13:09 | |
*** lkuchlan_wfh has quit IRC | 13:18 | |
*** seitan has quit IRC | 13:19 | |
*** armaan has quit IRC | 13:20 | |
*** links has quit IRC | 13:23 | |
*** lkuchlan_wfh has joined #openstack-cinder | 13:23 | |
*** wanghao has quit IRC | 13:24 | |
*** wanghao has joined #openstack-cinder | 13:24 | |
*** markvoelker has quit IRC | 13:24 | |
*** wanghao has quit IRC | 13:24 | |
*** markvoelker has joined #openstack-cinder | 13:25 | |
*** wanghao has joined #openstack-cinder | 13:25 | |
*** lhx_ has joined #openstack-cinder | 13:25 | |
*** wanghao has quit IRC | 13:25 | |
*** wanghao has joined #openstack-cinder | 13:25 | |
*** wanghao has quit IRC | 13:26 | |
*** wanghao has joined #openstack-cinder | 13:26 | |
*** wanghao has quit IRC | 13:27 | |
*** wanghao has joined #openstack-cinder | 13:27 | |
*** wanghao has quit IRC | 13:28 | |
*** wanghao has joined #openstack-cinder | 13:28 | |
*** wanghao has quit IRC | 13:28 | |
*** takedakn has quit IRC | 13:39 | |
*** mriedem has joined #openstack-cinder | 13:41 | |
*** takedakn has joined #openstack-cinder | 13:41 | |
*** alexchadin has quit IRC | 13:45 | |
*** psachin has quit IRC | 13:45 | |
*** liverpooler has joined #openstack-cinder | 14:01 | |
*** david-lyle has joined #openstack-cinder | 14:13 | |
*** dustins has joined #openstack-cinder | 14:14 | |
*** mchlumsky has joined #openstack-cinder | 14:16 | |
*** armax has quit IRC | 14:17 | |
*** dave-mccowan has quit IRC | 14:17 | |
*** gkadam has quit IRC | 14:18 | |
*** takedakn has quit IRC | 14:18 | |
*** crose has joined #openstack-cinder | 14:21 | |
*** david-lyle has quit IRC | 14:31 | |
*** salv-orlando has joined #openstack-cinder | 14:35 | |
*** dustins has quit IRC | 14:36 | |
*** tesseract has quit IRC | 14:37 | |
*** tesseract has joined #openstack-cinder | 14:44 | |
*** gouthamr has joined #openstack-cinder | 14:47 | |
*** armax has joined #openstack-cinder | 14:49 | |
openstackgerrit | Helen Walsh proposed openstack/cinder-specs master: Bulk Volume Create within Create Group API https://review.openstack.org/514196 | 14:50 |
*** armaan has joined #openstack-cinder | 15:03 | |
*** salv-orlando has quit IRC | 15:03 | |
*** salv-orlando has joined #openstack-cinder | 15:10 | |
*** belmoreira has joined #openstack-cinder | 15:11 | |
*** salv-orlando has quit IRC | 15:13 | |
chrisyang_0660 | Our patch just needs a core reviewer to approve, please help, thanks. https://review.openstack.org/#/c/470188/ | 15:16 |
*** jmlowe has joined #openstack-cinder | 15:16 | |
*** armaan has quit IRC | 15:16 | |
jungleboyj | chrisyang_0660: I will take a look today. | 15:16 |
*** wanghao has joined #openstack-cinder | 15:17 | |
*** wanghao has quit IRC | 15:17 | |
chrisyang_0660 | jungleboyj: thank you Jay :) | 15:18 |
*** lkuchlan_wfh has quit IRC | 15:25 | |
*** david-lyle has joined #openstack-cinder | 15:26 | |
chrisyang_0660 | e0ne: Thanks for the approval. | 15:28 |
e0ne | chrisyang_0660: np | 15:29 |
*** chenying has quit IRC | 15:32 | |
*** zengyingzhe has quit IRC | 15:32 | |
*** zhonghua2 has quit IRC | 15:33 | |
*** david-lyle has quit IRC | 15:34 | |
*** moshele has quit IRC | 15:35 | |
*** crose has quit IRC | 15:36 | |
*** Apoorva has joined #openstack-cinder | 15:37 | |
*** salv-orlando has joined #openstack-cinder | 15:37 | |
*** hemna_ has joined #openstack-cinder | 15:37 | |
*** markstur has joined #openstack-cinder | 15:43 | |
*** lpetrut has quit IRC | 15:43 | |
openstackgerrit | Helen Walsh proposed openstack/cinder-specs master: Bulk Volume Create within Create Group API https://review.openstack.org/514196 | 15:44 |
*** lpetrut has joined #openstack-cinder | 15:44 | |
jungleboyj | e0ne: Thanks. | 15:45 |
e0ne | jungleboyj: np | 15:45 |
*** salv-orlando has quit IRC | 15:45 | |
*** dustins has joined #openstack-cinder | 15:47 | |
*** dave-mccowan has joined #openstack-cinder | 15:48 | |
*** mvk has quit IRC | 15:48 | |
_pewp_ | hemna_ |。・ω・|ノ | 16:01 |
*** lpetrut has quit IRC | 16:02 | |
*** rhe00 has joined #openstack-cinder | 16:05 | |
jungleboyj | hemna_: You are in the wrong channel. COme to the meeting. | 16:09 |
*** erlon has joined #openstack-cinder | 16:13 | |
*** belmoreira has quit IRC | 16:22 | |
*** gouthamr has quit IRC | 16:23 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder-specs master: Open specs for Rocky release https://review.openstack.org/526120 | 16:31 |
*** lpetrut has joined #openstack-cinder | 16:50 | |
*** AlexeyAbashkin has quit IRC | 16:54 | |
*** salv-orlando has joined #openstack-cinder | 16:58 | |
*** e0ne has quit IRC | 17:07 | |
*** itlinux has joined #openstack-cinder | 17:08 | |
*** salv-orlando has quit IRC | 17:09 | |
*** salv-orlando has joined #openstack-cinder | 17:10 | |
*** david-lyle has joined #openstack-cinder | 17:10 | |
*** sdague has quit IRC | 17:13 | |
*** salv-orlando has quit IRC | 17:14 | |
*** salv-orlando has joined #openstack-cinder | 17:26 | |
*** salv-orlando has quit IRC | 17:26 | |
*** salv-orlando has joined #openstack-cinder | 17:27 | |
*** Apoorva has quit IRC | 17:27 | |
*** vivek__ has joined #openstack-cinder | 17:29 | |
*** salv-orlando has quit IRC | 17:32 | |
*** david-lyle has quit IRC | 17:32 | |
vivek__ | Hi Team, I have proposed a fix on driverfixes/ocata.. but zuul check is failing | 17:32 |
*** david-lyle has joined #openstack-cinder | 17:32 | |
vivek__ | http://logs.openstack.org/19/525719/1/check/openstack-tox-py27/f0c6813/job-output.txt.gz | 17:32 |
vivek__ | this failure seems to be related to python package 'cryptography' VERSION | 17:33 |
jungleboyj | vivek__: Yeah, I see that. I was hoping that eharney would see that as he has been working on driverfixes issues. | 17:33 |
vivek__ | ok | 17:34 |
vivek__ | jungleboy: i suspect there might be something wrong with the latest version of 'cryptography' 2.1.4 | 17:37 |
vivek__ | may be we can try with 'cryptography' 2.1.3.. to confirm the issue is with 'cryptography' 2.1.4 | 17:38 |
jungleboyj | Maybe something we need to cap in driverfixes? | 17:41 |
vivek__ | yes | 17:43 |
jungleboyj | Can you try submitting a patch with that change? | 17:43 |
*** gouthamr has joined #openstack-cinder | 17:44 | |
*** david-lyle has quit IRC | 17:45 | |
*** lhx_ has quit IRC | 17:46 | |
openstackgerrit | Merged openstack/cinder-specs master: Open specs for Rocky release https://review.openstack.org/526120 | 17:49 |
*** abhishekk has joined #openstack-cinder | 17:54 | |
*** abhishekk has quit IRC | 17:54 | |
*** chhavi has quit IRC | 17:56 | |
*** abhishekk has joined #openstack-cinder | 17:58 | |
smcginnis | vivek__, jungleboyj: It's probably not using the right upper constraints for that branch. | 18:00 |
*** moshele has joined #openstack-cinder | 18:04 | |
*** tesseract has quit IRC | 18:07 | |
*** salv-orlando has joined #openstack-cinder | 18:10 | |
mriedem | jgriffith: correct me if i'm wrong, but when updating an attachment and passing the connector dict, does that connector dict get stored in the AttachmentSpecs which is related to the attachment, and presumably could be something we could get out of the cinder attachments API at some point? | 18:11 |
mriedem | because right now in nova we have this workaround where we stash the host connector in the bdm.connection_info https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L319 | 18:12 |
mriedem | if cinder is storing all of that information, we can eventually stop relying on this workaround | 18:12 |
*** david-lyle has joined #openstack-cinder | 18:13 | |
jgriffith | mriedem: yes, I store it in the AttachmentSpec, that was one of the main points of this (eliminate need to store in NOva) | 18:13 |
*** dustins has quit IRC | 18:14 | |
mriedem | ok, tha'ts not exposed out of the rest api though is it? | 18:14 |
*** dustins has joined #openstack-cinder | 18:14 | |
jgriffith | So you can also easily retireve it via attachment detail | 18:14 |
mriedem | i'm just adding some todos to the nova code for things we can eventually stop hacking around with the bdm.connection_info if/when we can do the new stuff | 18:14 |
mriedem | i didn't see it in the attachments view | 18:14 |
*** Apoorva has joined #openstack-cinder | 18:15 | |
*** Apoorva has quit IRC | 18:15 | |
mriedem | https://github.com/openstack/cinder/blob/master/cinder/api/v3/views/attachments.py#L28 | 18:15 |
jgriffith | let me see what's up, my connection i scrap so bare with me | 18:15 |
* mriedem gets lunch | 18:15 | |
mriedem | no rush | 18:15 |
*** Apoorva has joined #openstack-cinder | 18:15 | |
jgriffith | mriedem: k, if it' sno tthere that's a bug and we need to add it back in | 18:16 |
*** david-lyle has quit IRC | 18:18 | |
*** david-lyle has joined #openstack-cinder | 18:18 | |
vivek__ | smcginnis: ok. so in case if we have the fix for it, may i request you to proposed a fix | 18:19 |
*** dave-mccowan has quit IRC | 18:20 | |
*** salv-orlando has quit IRC | 18:21 | |
vivek__ | i won't able to get my patch into driverfixes/ocata unless & until this zuul issue fix | 18:21 |
*** dhinesh has joined #openstack-cinder | 18:21 | |
*** salv-orlando has joined #openstack-cinder | 18:21 | |
*** abhishekk has quit IRC | 18:22 | |
*** salv-orlando has quit IRC | 18:26 | |
*** gkadam has joined #openstack-cinder | 18:32 | |
*** david-lyle has quit IRC | 18:33 | |
jgriffith | mriedem: it is there it turns out http://paste.openstack.org/show/628304/ | 18:36 |
jgriffith | mriedem: *but* there's a pretty serious bug because it's not filtered out for non-admin which it should be | 18:37 |
*** e0ne has joined #openstack-cinder | 18:39 | |
jgriffith | mriedem: the raw data is added in paste http://paste.openstack.org/show/628305/ | 18:43 |
jgriffith | I'll log a bug and work on that | 18:43 |
mriedem | oo yeah yikes | 18:44 |
mriedem | jgriffith: that's the connection_info though, not the host connector | 18:45 |
mriedem | i'm asking about the host connector | 18:45 |
*** moshele has quit IRC | 18:45 | |
mriedem | which is stored in attachmentspecs | 18:45 |
mriedem | but definitely a bug on showing connection_info for a non-admin, user/pass is right there :) | 18:45 |
mriedem | probably a cve... | 18:46 |
ildikov | jgriffith: mriedem: we use it in Nova already: https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L450-#L452 | 18:46 |
mriedem | ildikov: that's the connection_info | 18:46 |
mriedem | connection_info != host connector | 18:46 |
ildikov | mriedem: ah, ok, mixed up the two as always :) | 18:46 |
mriedem | https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L371 | 18:46 |
mriedem | the host connector comes from brick | 18:47 |
mriedem | connection_info comes from the backend storage driver | 18:47 |
ildikov | yep, that part I know | 18:48 |
vivek__ | mriedem, ildikov: are you talking about connector['multipath'] not set properly | 18:48 |
ildikov | vivek__: no, we would like to store less things in Nova and rather retrieve the info from Cinder | 18:49 |
vivek__ | Even if we set 'volume_use_multipath=True' in nova.conf 'libvirt' section then also "connector['multipath']=False" is populated | 18:51 |
vivek__ | even after multipathd is runing properly | 18:51 |
vivek__ | https://bugs.launchpad.net/nova/+bug/1723928 | 18:52 |
openstack | Launchpad bug 1723928 in os-brick "In case of volume_use_multipath=True, Nova unable to fetch CONF.libvirt.volume_use_multipath value from nova.conf" [Undecided,New] | 18:52 |
jgriffith | mriedem: ildikov BTW that connection_info in the attachment-spes should include a 1:1 copy of the connector keys as well | 18:54 |
mriedem | jgriffith: not seeing that, | 18:54 |
mriedem | there would be a host or something in there | 18:55 |
ildikov | jgriffith: I remember playing with that at a certain point | 18:55 |
jgriffith | mriedem: actually... you are probably correct. I think at one point we decided that the only thing of value was the host and instance and the connection_info itself | 18:55 |
ildikov | well no, false alarm: https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L208 | 18:56 |
jgriffith | mriedem: storing of the connector itself we decided didn't make sense, because typically if it was needed again it was to get a connection_info object | 18:56 |
mriedem | whatever this returns from brick https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1124 | 18:56 |
mriedem | jgriffith: i thought the host connector was stored in the attachmentspecs table? | 18:56 |
ildikov | jgriffith: mriedem: so currently the attachment translate code doesn't drop it, but also doesn't deal with it explicitly | 18:57 |
mriedem | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L4341 | 18:57 |
mriedem | jgriffith: ^ | 18:57 |
mriedem | that's just a key/value table for what's in the connector dict | 18:58 |
mriedem | mapped to the attachment id | 18:58 |
mriedem | would probably be a lot more efficient to just store that as a json blob, but... | 18:59 |
mriedem | anyway, looks like it's there and we could expose the host connector later if needed | 19:00 |
jgriffith | mriedem: I'm open to enahncements on that | 19:00 |
jgriffith | I know that's dirty | 19:00 |
mriedem | GET /attachments/{id}/connector | 19:00 |
mriedem | something like that | 19:00 |
mriedem | admin-only | 19:00 |
jgriffith | mriedem: yeah... sorry, I missed that it's in there, took you for your word when you said you didn't see it :) | 19:00 |
ildikov | we said we will store all these so we can do detach safely with all the info later in case shared targets and multi attach and alien attacks and what not | 19:01 |
mriedem | yup | 19:01 |
ildikov | and the connection info is pretty nasty in itself with or without connector... :( | 19:01 |
mriedem | anyway, nothing depends on that now, just future cleanup work | 19:01 |
mriedem | i'm adding todos to the nova code about relying on the bdm.connection_info during detach and how we shouldn't do that | 19:02 |
ildikov | mriedem: feel free to keep on adding the FIXME(ildikov) notes... :) | 19:02 |
mriedem | i only do that in the multiattach patches | 19:02 |
mriedem | since i don't want to own those | 19:02 |
jgriffith | mriedem: I'll try and get that bug fixed sometime today, let me know if you see something else wonky | 19:03 |
ildikov | mriedem: sorry, was just kidding and I didn't want you to own those | 19:03 |
ildikov | mriedem: I thought to quickly remove some connection_info dependency in Nova but it didn't seem a that easy task so thought to deal with that later | 19:04 |
mriedem | jgriffith: i'm assuming you'll be adding a policy rule for exposing that field, defaulting to admin-only? | 19:04 |
*** vivek__ has quit IRC | 19:05 | |
jgriffith | mriedem: yup, because now that I'm looking at it; I know why it's the way it is. Standalone case needs it as non-admin | 19:07 |
jgriffith | mriedem: so I'll add a policy to deal with it appropriately | 19:07 |
mriedem | ildikov: now that i'm looking at this, we need to do this in attachment_update too https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L417 | 19:07 |
mriedem | and attachment_create | 19:08 |
mriedem | because of this https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L319 | 19:08 |
mriedem | or if we hit that code, it's because we aren't doing something correctly with evacuate | 19:13 |
ildikov | mriedem: shouldn't it be in connection_info when it comes back from Cinder? | 19:15 |
mriedem | oh hrm, we don't care about the stashed connector in this new flow because we won't need it https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L359 | 19:15 |
ildikov | Oh yeah, attachment_id is the key now everywhere | 19:17 |
ildikov | I wasn't sure why you brought it up | 19:17 |
*** erlon has quit IRC | 19:17 | |
mriedem | well, things get funny with evacuate | 19:18 |
ildikov | Interesting viewpoint on what one would call 'funny' :) | 19:19 |
*** dave-mccowan has joined #openstack-cinder | 19:25 | |
*** harlowja has quit IRC | 19:32 | |
*** moshele has joined #openstack-cinder | 19:35 | |
*** harlowja has joined #openstack-cinder | 19:36 | |
*** mvk has joined #openstack-cinder | 19:39 | |
*** crose has joined #openstack-cinder | 19:51 | |
*** crose has quit IRC | 20:05 | |
*** gkadam has quit IRC | 20:14 | |
*** crose has joined #openstack-cinder | 20:18 | |
*** crose has quit IRC | 20:31 | |
*** Anticime1 has quit IRC | 20:31 | |
*** jdurgin has quit IRC | 20:31 | |
*** _alastor_ has quit IRC | 20:31 | |
*** fmccrthy has quit IRC | 20:31 | |
*** zhenguo has quit IRC | 20:31 | |
*** dgonzalez has quit IRC | 20:31 | |
*** moshele has quit IRC | 20:31 | |
*** dave-mccowan has quit IRC | 20:31 | |
*** jmlowe has quit IRC | 20:31 | |
*** gnufied has quit IRC | 20:31 | |
*** supamatt has quit IRC | 20:31 | |
*** MasterofJOKers has quit IRC | 20:31 | |
*** arnewiebalck has quit IRC | 20:31 | |
*** uberjay has quit IRC | 20:33 | |
*** aspiers[m] has quit IRC | 20:35 | |
*** wN_ has quit IRC | 20:35 | |
*** uberjay has joined #openstack-cinder | 20:36 | |
*** mikal has quit IRC | 20:38 | |
*** itlinux has quit IRC | 20:40 | |
*** markstur has quit IRC | 20:42 | |
*** mikal has joined #openstack-cinder | 20:43 | |
*** lpetrut has quit IRC | 20:45 | |
*** _alastor_ has joined #openstack-cinder | 20:47 | |
*** Anticime1 has joined #openstack-cinder | 20:47 | |
*** jdurgin has joined #openstack-cinder | 20:47 | |
*** fmccrthy has joined #openstack-cinder | 20:47 | |
*** zhenguo has joined #openstack-cinder | 20:47 | |
*** dgonzalez has joined #openstack-cinder | 20:47 | |
*** moshele has joined #openstack-cinder | 20:47 | |
*** dave-mccowan has joined #openstack-cinder | 20:47 | |
*** jmlowe has joined #openstack-cinder | 20:47 | |
*** gnufied has joined #openstack-cinder | 20:47 | |
*** supamatt has joined #openstack-cinder | 20:47 | |
*** MasterofJOKers has joined #openstack-cinder | 20:47 | |
*** arnewiebalck has joined #openstack-cinder | 20:47 | |
*** moshele has quit IRC | 20:51 | |
*** itlinux has joined #openstack-cinder | 20:53 | |
jungleboyj | milestone 2 has been proposed for those interested: https://review.openstack.org/526188 | 20:56 |
*** markstur has joined #openstack-cinder | 20:57 | |
*** harlowja has quit IRC | 21:00 | |
*** liverpooler has quit IRC | 21:02 | |
*** harlowja has joined #openstack-cinder | 21:03 | |
ildikov | jungleboyj: hi | 21:05 |
ildikov | jungleboyj: where are we with the missing microversions in the client? | 21:05 |
*** salv-orlando has joined #openstack-cinder | 21:08 | |
*** kambiz has quit IRC | 21:09 | |
*** dustins has quit IRC | 21:12 | |
*** kambiz has joined #openstack-cinder | 21:12 | |
*** itlinux has quit IRC | 21:13 | |
*** salv-orlando has quit IRC | 21:16 | |
*** salv-orlando has joined #openstack-cinder | 21:17 | |
*** sticker has joined #openstack-cinder | 21:19 | |
*** salv-orlando has quit IRC | 21:21 | |
*** ganso has quit IRC | 21:22 | |
jungleboyj | There were patches up. I had at least one comment. Let me see if that was addressed. | 21:25 |
*** itlinux has joined #openstack-cinder | 21:26 | |
*** zengyingzhe has joined #openstack-cinder | 21:30 | |
*** zhonghua has joined #openstack-cinder | 21:30 | |
*** chenying has joined #openstack-cinder | 21:30 | |
*** harlowja has quit IRC | 21:32 | |
*** gouthamr has quit IRC | 21:36 | |
*** sdague has joined #openstack-cinder | 21:38 | |
*** AlexeyAbashkin has joined #openstack-cinder | 21:38 | |
*** openstackgerrit has quit IRC | 21:38 | |
*** _pewp_ has quit IRC | 21:38 | |
*** winston-d has quit IRC | 21:38 | |
*** sri_ has quit IRC | 21:38 | |
*** SamYaple has quit IRC | 21:38 | |
*** ericyoung has quit IRC | 21:38 | |
*** lifeless has quit IRC | 21:38 | |
*** mfisch has quit IRC | 21:38 | |
*** afazekas has quit IRC | 21:38 | |
*** diegows has quit IRC | 21:38 | |
*** david-lyle has joined #openstack-cinder | 21:39 | |
ildikov | jungleboyj: thanks | 21:39 |
jungleboyj | ildikov: yep, will do when back to a computer. | 21:40 |
ildikov | jungleboyj: no rush, might not be super urgent, but would be great to get that done in general anyway | 21:41 |
ildikov | jungleboyj: we have the meeting on for tomorrow, I'm available for the first half an hour, but as half of the team is at KubeCon anyway we can sort out things like what's up with the Cinder client quickly | 21:42 |
*** liverpooler has joined #openstack-cinder | 21:44 | |
*** dulek_mobile has joined #openstack-cinder | 21:44 | |
*** dulek_mobile has quit IRC | 21:45 | |
*** david-lyle has quit IRC | 21:47 | |
*** SamYaple has joined #openstack-cinder | 21:49 | |
jungleboyj | ildikov: sounds good. Would be nice to take care of that either way. | 21:51 |
*** itlinux has quit IRC | 21:59 | |
*** openstackgerrit has joined #openstack-cinder | 22:01 | |
*** _pewp_ has joined #openstack-cinder | 22:01 | |
*** winston-d has joined #openstack-cinder | 22:01 | |
*** sri_ has joined #openstack-cinder | 22:01 | |
*** ericyoung has joined #openstack-cinder | 22:01 | |
*** lifeless has joined #openstack-cinder | 22:01 | |
*** mfisch has joined #openstack-cinder | 22:01 | |
*** afazekas has joined #openstack-cinder | 22:01 | |
*** diegows has joined #openstack-cinder | 22:01 | |
*** rcernin has joined #openstack-cinder | 22:01 | |
*** rcernin has quit IRC | 22:03 | |
*** rcernin has joined #openstack-cinder | 22:03 | |
*** e0ne has quit IRC | 22:06 | |
*** e0ne has joined #openstack-cinder | 22:07 | |
*** e0ne has quit IRC | 22:07 | |
*** e0ne has joined #openstack-cinder | 22:08 | |
*** e0ne has quit IRC | 22:08 | |
*** e0ne has joined #openstack-cinder | 22:08 | |
*** e0ne has quit IRC | 22:09 | |
*** e0ne has joined #openstack-cinder | 22:10 | |
*** moshele has joined #openstack-cinder | 22:10 | |
*** e0ne has quit IRC | 22:10 | |
*** e0ne has joined #openstack-cinder | 22:11 | |
*** e0ne has quit IRC | 22:11 | |
*** e0ne has joined #openstack-cinder | 22:12 | |
*** e0ne has quit IRC | 22:12 | |
*** e0ne has joined #openstack-cinder | 22:12 | |
*** e0ne has quit IRC | 22:13 | |
ildikov | jungleboyj: I would say necessary, but we can leave it as nice for today :) | 22:17 |
*** abishop has quit IRC | 22:24 | |
*** salv-orlando has joined #openstack-cinder | 22:27 | |
*** gouthamr has joined #openstack-cinder | 22:28 | |
*** salv-orlando has quit IRC | 22:32 | |
*** harlowja has joined #openstack-cinder | 22:36 | |
*** AlexeyAbashkin has quit IRC | 22:43 | |
*** stapler117 has joined #openstack-cinder | 22:53 | |
*** gouthamr has quit IRC | 22:53 | |
*** gouthamr has joined #openstack-cinder | 22:56 | |
*** stapler117 is now known as stapler118 | 22:56 | |
*** salv-orlando has joined #openstack-cinder | 22:57 | |
*** salv-orlando has quit IRC | 23:05 | |
*** salv-orlando has joined #openstack-cinder | 23:05 | |
*** wanghao has joined #openstack-cinder | 23:08 | |
*** wanghao has quit IRC | 23:08 | |
jungleboyj | ildikov: Merging 3.45: https://review.openstack.org/#/c/525120 | 23:08 |
jungleboyj | 3.46: https://review.openstack.org/#/c/525035/2 | 23:09 |
*** mriedem has left #openstack-cinder | 23:10 | |
*** salv-orlando has quit IRC | 23:10 | |
jungleboyj | and 3.47 ... | 23:11 |
*** wanghao has joined #openstack-cinder | 23:11 | |
ildikov | jungleboyj: nice, thanks! | 23:12 |
jungleboyj | ildikov: No problem. | 23:13 |
jungleboyj | So, jgriffith has this patch out there: https://review.openstack.org/#/c/524700/ | 23:14 |
jungleboyj | Was all we needed the MV bump? | 23:14 |
jungleboyj | Or is there something else that needs to merge | 23:14 |
jungleboyj | ildikov: ^^^ | 23:14 |
*** wanghao has quit IRC | 23:15 | |
ildikov | jungleboyj: I'm not sure whether the server side patch has merged or not | 23:15 |
ildikov | I think it did, it needs to be double checked, otherwise just the version bumps in the client and we're good | 23:16 |
jungleboyj | ildikov: It did. | 23:16 |
ildikov | Ok, cool | 23:16 |
jungleboyj | Ok, he commented that it was WIP because of the missing changes. | 23:17 |
jungleboyj | It failed Zuul though so I am rechecking. | 23:19 |
*** david-lyle has joined #openstack-cinder | 23:22 | |
jgriffith | ildikov: jungleboyj tommylikehu ummmmm..... | 23:25 |
*** wanghao has joined #openstack-cinder | 23:26 | |
jungleboyj | jgriffith: What? | 23:26 |
*** armaan has joined #openstack-cinder | 23:26 | |
* jgriffith is confused... is there a bump to 3.47? That's all that's needed here. Or more specifically the impl of 3.47 and bump to 3.48 | 23:27 | |
jgriffith | unless you just want to have them independent commits which is reasonable/fair | 23:27 |
*** openstack has joined #openstack-cinder | 23:31 | |
*** ChanServ sets mode: +o openstack | 23:31 | |
jgriffith | no need to try and rewrite history (45 and 46) that I can see | 23:31 |
jungleboyj | jgriffith: Right! | 23:32 |
jgriffith | jungleboyj: so then you don't need https://review.openstack.org/#/c/525035/2 | 23:32 |
*** gmann_afk is now known as gmann | 23:33 | |
jgriffith | Or just ignore me, because it will all work/settle out eventually | 23:33 |
jungleboyj | Well, that one was kind-of overkill but I thought it was good to have that patch in the line to purposefully bump to 3.46. | 23:33 |
*** takedakn has quit IRC | 23:34 | |
*** moshele has quit IRC | 23:36 | |
*** stakeda has joined #openstack-cinder | 23:39 | |
ildikov | Having all the bumps is good, the patch would've been nicer in a chain on top of the 3.45 changes, but at this point I'm not complaining | 23:39 |
jungleboyj | :-) I was taking wht I could get. | 23:40 |
ildikov | jgriffith: I tried my best to keep it on the right track this time, I swear :) | 23:41 |
*** edmondsw has joined #openstack-cinder | 23:42 | |
*** sdague has quit IRC | 23:42 | |
*** david-lyle has quit IRC | 23:44 | |
*** armax has quit IRC | 23:45 | |
*** salv-orlando has joined #openstack-cinder | 23:46 | |
*** salv-orlando has quit IRC | 23:50 | |
*** salv-orlando has joined #openstack-cinder | 23:51 | |
*** chhavi has joined #openstack-cinder | 23:52 | |
*** salv-orlando has quit IRC | 23:55 | |
*** david-lyle has joined #openstack-cinder | 23:57 | |
*** chhavi has quit IRC | 23:57 | |
*** salv-orlando has joined #openstack-cinder | 23:57 | |
jungleboyj | So jgriffith and ildikov once the other patches merge, lets merge https://review.openstack.org/#/c/524700/ then I will do a release tomorrow. | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!