*** salv-orlando has quit IRC | 00:06 | |
tommylikehu | hey pooja_jadhav, sorry for late response, my point here is that it would be great if we can support boolean value with extra spaces in all of the APIs after json schema changes. | 00:07 |
---|---|---|
*** salv-orlando has joined #openstack-cinder | 00:07 | |
*** salv-orlando has quit IRC | 00:12 | |
*** AlexeyAbashkin has joined #openstack-cinder | 00:13 | |
*** DHE has left #openstack-cinder | 00:13 | |
*** AlexeyAbashkin has quit IRC | 00:18 | |
*** gman-tx has quit IRC | 00:18 | |
*** Dinesh_Bhor has joined #openstack-cinder | 00:42 | |
*** Dinesh_Bhor has quit IRC | 00:42 | |
*** andreas_s has joined #openstack-cinder | 00:45 | |
*** andreas_s has quit IRC | 00:49 | |
*** gman-tx has joined #openstack-cinder | 00:54 | |
*** felipemonteiro_ has quit IRC | 01:03 | |
*** lhx_ has joined #openstack-cinder | 01:05 | |
*** salv-orlando has joined #openstack-cinder | 01:08 | |
*** gman-tx has quit IRC | 01:11 | |
*** salv-orlando has quit IRC | 01:12 | |
*** AlexeyAbashkin has joined #openstack-cinder | 01:13 | |
*** AlexeyAbashkin has quit IRC | 01:18 | |
openstackgerrit | Merged openstack/cinder master: Admin guide documentation for volume multiattach https://review.openstack.org/540047 | 01:51 |
*** salv-orlando has joined #openstack-cinder | 02:08 | |
*** salv-orlando has quit IRC | 02:13 | |
*** mriedem1 has joined #openstack-cinder | 02:29 | |
*** mriedem has quit IRC | 02:29 | |
*** mriedem1 is now known as mriedem | 02:29 | |
*** lhx_ has quit IRC | 02:46 | |
*** kaisers__ has joined #openstack-cinder | 02:57 | |
*** dave-mccowan has joined #openstack-cinder | 03:01 | |
*** kaisers_ has quit IRC | 03:02 | |
*** mriedem has quit IRC | 03:07 | |
*** salv-orlando has joined #openstack-cinder | 03:09 | |
*** salv-orlando has quit IRC | 03:14 | |
*** dave-mcc_ has joined #openstack-cinder | 03:15 | |
*** dave-mccowan has quit IRC | 03:15 | |
*** harlowja_ has quit IRC | 03:23 | |
openstackgerrit | Mohammed Naser proposed openstack/cinder master: Add throughput limits that scale per-GB https://review.openstack.org/545201 | 03:23 |
*** vivsoni has joined #openstack-cinder | 03:24 | |
mnaser | ^ how do people feel about backporting that... i reaaaaally don't want to end up maintaining our own branch, it's pretty important for us to have and it is fairly low impact | 03:29 |
*** abhishekk has joined #openstack-cinder | 03:39 | |
*** dave-mcc_ has quit IRC | 03:41 | |
*** gkadam has joined #openstack-cinder | 03:42 | |
*** gman-tx has joined #openstack-cinder | 03:44 | |
*** gman-tx has quit IRC | 03:52 | |
*** andreas_s has joined #openstack-cinder | 04:13 | |
*** andreas_s has quit IRC | 04:17 | |
*** salv-orlando has joined #openstack-cinder | 04:23 | |
*** psachin has joined #openstack-cinder | 04:26 | |
*** salv-orlando has quit IRC | 04:29 | |
*** lpetrut has joined #openstack-cinder | 04:36 | |
*** harlowja has joined #openstack-cinder | 04:46 | |
*** dalgaaf has quit IRC | 04:55 | |
*** dalgaaf has joined #openstack-cinder | 04:56 | |
*** harlowja has quit IRC | 04:59 | |
*** mdbooth has quit IRC | 05:13 | |
*** lpetrut has quit IRC | 05:13 | |
*** lpetrut has joined #openstack-cinder | 05:19 | |
*** harlowja has joined #openstack-cinder | 05:19 | |
*** salv-orlando has joined #openstack-cinder | 05:25 | |
*** dobson has quit IRC | 05:25 | |
*** harlowja has quit IRC | 05:27 | |
*** salv-orlando has quit IRC | 05:29 | |
*** lpetrut has quit IRC | 05:35 | |
*** dobson has joined #openstack-cinder | 05:37 | |
*** hoonetorg has quit IRC | 05:40 | |
*** hoonetorg has joined #openstack-cinder | 05:53 | |
*** kaisers__ has quit IRC | 05:54 | |
*** kaisers_ has joined #openstack-cinder | 06:02 | |
*** pgadiya has joined #openstack-cinder | 06:08 | |
*** pgadiya has quit IRC | 06:17 | |
openstackgerrit | Ibad Khan proposed openstack/cinder master: QNAP Drivers - Move from httplib to requests https://review.openstack.org/538237 | 06:19 |
*** threestrands has quit IRC | 06:20 | |
*** salv-orlando has joined #openstack-cinder | 06:25 | |
*** openstackstatus has quit IRC | 06:27 | |
*** openstack has joined #openstack-cinder | 06:32 | |
*** ChanServ sets mode: +o openstack | 06:32 | |
*** salv-orlando has joined #openstack-cinder | 06:32 | |
openstackgerrit | Vivek Soni proposed openstack/cinder master: 3PAR: Monitor task of promoting a virtual copy https://review.openstack.org/545214 | 06:55 |
*** andreas_s has joined #openstack-cinder | 06:57 | |
*** andreas_s has quit IRC | 07:01 | |
*** gkadam has quit IRC | 07:04 | |
*** gkadam has joined #openstack-cinder | 07:10 | |
*** pgadiya has quit IRC | 07:18 | |
*** threestrands has joined #openstack-cinder | 07:22 | |
*** threestrands has quit IRC | 07:22 | |
*** threestrands has joined #openstack-cinder | 07:23 | |
*** threestrands has joined #openstack-cinder | 07:23 | |
*** AlexeyAbashkin has joined #openstack-cinder | 07:26 | |
*** pgadiya has joined #openstack-cinder | 07:32 | |
*** gkadam has quit IRC | 07:33 | |
*** threestrands has quit IRC | 07:34 | |
*** rcernin has quit IRC | 07:41 | |
*** lpetrut has joined #openstack-cinder | 07:44 | |
*** andreas_s has joined #openstack-cinder | 08:10 | |
*** alexchadin has joined #openstack-cinder | 08:13 | |
*** alexchadin has quit IRC | 08:24 | |
*** alexchadin has joined #openstack-cinder | 08:25 | |
*** tesseract has joined #openstack-cinder | 08:27 | |
*** salv-orlando has quit IRC | 08:32 | |
*** salv-orlando has joined #openstack-cinder | 08:32 | |
*** e0ne has joined #openstack-cinder | 08:35 | |
*** salv-orlando has quit IRC | 08:37 | |
*** salv-orlando has joined #openstack-cinder | 08:45 | |
*** david-lyle has quit IRC | 08:46 | |
*** e0ne has quit IRC | 08:54 | |
*** yangyapeng has joined #openstack-cinder | 08:57 | |
*** salv-orlando has quit IRC | 09:04 | |
*** salv-orlando has joined #openstack-cinder | 09:05 | |
*** salv-orlando has quit IRC | 09:09 | |
*** belmoreira has joined #openstack-cinder | 09:11 | |
*** pcaruana has joined #openstack-cinder | 09:11 | |
*** frickler has joined #openstack-cinder | 09:19 | |
frickler | are there any docs available for how to deploy https://specs.openstack.org/openstack/cinder-specs/specs/mitaka/cinder-volume-active-active-support.html ? | 09:25 |
*** stephenfin is now known as finucannot | 09:35 | |
*** links has joined #openstack-cinder | 09:47 | |
*** links has quit IRC | 09:49 | |
*** ganso has joined #openstack-cinder | 09:56 | |
*** links has joined #openstack-cinder | 09:58 | |
*** abhishekk has quit IRC | 09:58 | |
*** alexchadin has quit IRC | 10:01 | |
*** links has quit IRC | 10:12 | |
*** openstackgerrit has quit IRC | 10:18 | |
*** luizbag has joined #openstack-cinder | 10:23 | |
*** dosaboy has quit IRC | 10:33 | |
*** stakeda has quit IRC | 10:33 | |
*** e0ne has joined #openstack-cinder | 10:34 | |
*** dosaboy has joined #openstack-cinder | 10:38 | |
vivsoni | Team, please review https://review.openstack.org/#/c/545214/ | 10:49 |
zigo | Hi guys. I have a bunch of failed tests when switching Cinder to Python 3. | 10:53 |
zigo | Namely: cinder.tests.unit.api.contrib.test_backups.BackupsAPITestCase.test_restore_backup_with_body_KeyError | 10:54 |
zigo | cinder.tests.unit.api.test_api_validation.PatternPropertiesTestCase.test_validate_patternProperties_fails | 10:54 |
zigo | cinder.tests.unit.volume.drivers.dell_emc.vmax.test_vmax.VMAXCommonReplicationTest.test_replicate_group | 10:54 |
zigo | plus lots of failed tests in qnap and netapp drivers. | 10:54 |
*** alexchadin has joined #openstack-cinder | 10:54 | |
zigo | I filed a few bugs for them. | 11:07 |
*** alexchadin has quit IRC | 11:10 | |
*** e0ne has quit IRC | 11:12 | |
*** e0ne has joined #openstack-cinder | 11:13 | |
*** alexchadin has joined #openstack-cinder | 11:22 | |
*** tpsilva has joined #openstack-cinder | 11:23 | |
*** armaan has joined #openstack-cinder | 11:27 | |
*** belmoreira has quit IRC | 11:28 | |
*** armaan has quit IRC | 11:35 | |
*** AlexeyAbashkin has quit IRC | 11:37 | |
*** AlexeyAbashkin has joined #openstack-cinder | 11:40 | |
*** alexchadin has quit IRC | 11:41 | |
*** alexchadin has joined #openstack-cinder | 11:42 | |
*** pgadiya has quit IRC | 11:49 | |
zigo | https://bugs.launchpad.net/bugs/1749927 https://bugs.launchpad.net/bugs/1749929 https://bugs.launchpad.net/bugs/1749930 https://bugs.launchpad.net/bugs/1749932 https://bugs.launchpad.net/bugs/1749934 | 11:53 |
openstack | Launchpad bug 1749927 in Cinder "Unit test test_restore_backup_with_body_KeyError fails under Python 3.6" [Undecided,New] | 11:53 |
openstack | Launchpad bug 1749929 in Cinder "Unit test test_validate_patternProperties_fails fails under Python 3.6" [Undecided,New] | 11:53 |
openstack | Launchpad bug 1749930 in Cinder "Unit test VMAXCommonReplicationTest.test_replicate_group fails under Python 3.6" [Undecided,New] | 11:53 |
openstack | Launchpad bug 1749932 in Cinder "4 of netapp unit tests failing in Python 3.6" [Undecided,New] | 11:53 |
openstack | Launchpad bug 1749934 in Cinder "46 failed unit tests for qnap when running in Python 3.6" [Undecided,New] | 11:53 |
*** links has joined #openstack-cinder | 12:03 | |
e0ne | zigo: we've got only python 3.5 support now | 12:06 |
zigo | e0ne: Well, that's the thing, Debian Sid uses Python 3.6, Gentoo has 3.6 too, and Fedora will do 3.6 for Rocky. So these bugs must be addressed at some point. | 12:07 |
e0ne | zigo: do you volunteer to help us with fixes? | 12:08 |
zigo | e0ne: I can attempt to help someone that will try to fix, but I cannot say I will fix the issues myself. I can't do that with all of the 421 OpenStack packages I maintain in Debian, you know. | 12:09 |
e0ne | zigo: I agree that it would be good to fix them, but we don't test with 3.6 on gates | 12:09 |
e0ne | honestly, we even don't have python3 in setup.cfg now:( | 12:10 |
zigo | e0ne: I'm ok with no gating yet, as long as the issues are taken care of. IMO, the most important ones to fix are the first 2 in the list above, since they are not related to a particular driver. | 12:10 |
*** salv-orlando has joined #openstack-cinder | 12:10 | |
zigo | Well, this better change ASAP then, because everyone is moving toward Py 3. | 12:11 |
zigo | Ubuntu will do so for Rocky, and so is RDO. | 12:11 |
*** armaan has joined #openstack-cinder | 12:13 | |
*** psachin has quit IRC | 12:14 | |
*** psachin has joined #openstack-cinder | 12:25 | |
*** elmaciej has joined #openstack-cinder | 12:26 | |
*** elmaciej_ has joined #openstack-cinder | 12:28 | |
*** elmaciej has quit IRC | 12:32 | |
*** belmoreira has joined #openstack-cinder | 12:43 | |
*** dave-mccowan has joined #openstack-cinder | 13:08 | |
*** nicolasbock has joined #openstack-cinder | 13:10 | |
*** nicolasbock has quit IRC | 13:10 | |
*** r-daneel has joined #openstack-cinder | 13:14 | |
*** armaan has quit IRC | 13:19 | |
*** zhongjun has quit IRC | 13:20 | |
*** openstackgerrit has joined #openstack-cinder | 13:22 | |
openstackgerrit | Mohammed Naser proposed openstack/cinder master: Add throughput limits that scale per-GB https://review.openstack.org/545201 | 13:22 |
*** armaan has joined #openstack-cinder | 13:25 | |
*** dave-mccowan has quit IRC | 13:31 | |
*** armaan has quit IRC | 13:32 | |
*** abishop has joined #openstack-cinder | 13:36 | |
*** psachin has quit IRC | 13:42 | |
*** gman-tx has joined #openstack-cinder | 13:43 | |
*** eharney has quit IRC | 13:43 | |
*** gman-tx has quit IRC | 13:47 | |
*** dustins has joined #openstack-cinder | 13:52 | |
*** liverpooler has joined #openstack-cinder | 13:55 | |
*** gman-tx has joined #openstack-cinder | 13:57 | |
*** pchavva has joined #openstack-cinder | 13:59 | |
*** mriedem has joined #openstack-cinder | 14:03 | |
*** dave-mccowan has joined #openstack-cinder | 14:05 | |
lpetrut | Hi, we have a bug fix on the SMB driver, if anyone could please take a look (it already has a +2): https://review.openstack.org/#/c/539593/ Two other patches have been +w-ed but depend on it. | 14:18 |
smcginnis | We target python 2.7 and python 3.5. That's the offical OpenStack-wide stance. | 14:21 |
*** andreas_s has quit IRC | 14:24 | |
*** andreas_s has joined #openstack-cinder | 14:25 | |
*** eharney has joined #openstack-cinder | 14:26 | |
*** felipemonteiro_ has joined #openstack-cinder | 14:30 | |
mriedem | what does this mean exactly? https://docs.openstack.org/cinder/latest/contributor/api_microversion_history.html#id47 | 14:31 |
mriedem | i've created a multiattach capable type following https://docs.openstack.org/cinder/latest/admin/blockstorage-volume-multiattach.html#multiattach-volume-type | 14:31 |
mriedem | is 3.50 only applied when i go to create a volume using that type? | 14:31 |
mriedem | i'm able to create the type and set the extra spec at 3.0 no problem | 14:32 |
*** elmaciej_ has quit IRC | 14:32 | |
*** elmaciej has joined #openstack-cinder | 14:33 | |
smcginnis | Hmm, that should probably be expanded a little. | 14:33 |
*** felipemonteiro__ has joined #openstack-cinder | 14:34 | |
*** andreas_s has quit IRC | 14:35 | |
mriedem | using 3.50 doesn't seem to make a difference when i create the volume, it always fails during scheduling saying there is no backend that supports it... | 14:36 |
mriedem | Feb 16 14:35:59 queens cinder-scheduler[1556]: ERROR cinder.scheduler.flows.create_volume [None req-e5036fa1-c54f-4410-a57b-c2cc5f96fd53 demo None] Failed to run task cinder.scheduler.flows.create_volume.ScheduleCreateVolumeTask;volume:create: No valid backend was found. No weighed backends available: NoValidBackend: No valid backend was found. No weighed backends available | 14:37 |
*** alexchadin has quit IRC | 14:37 | |
smcginnis | Looking at the code, I actually am not sure why 3.50 was added. | 14:37 |
*** felipemonteiro_ has quit IRC | 14:37 | |
mriedem | i created this devstack env on the 9th so lvm should support it | 14:37 |
mriedem | i'm actually trying to test that the policy rule works, such that if i set the policy to disable multiattach and try to create a volume as a non-admin, it should fail, but that doesn't seem to happen | 14:38 |
mriedem | lbragstad: should /etc/cinder/policy.yaml be picked up automatically? | 14:38 |
mriedem | stack@queens:~/devstack$ cat /etc/cinder/policy.yaml | 14:38 |
mriedem | 'volume:multiattach': 'rule:admin' | 14:38 |
smcginnis | I'm looking at the actual patch that added 3.50 and I don't see the policy or the mv being checked. | 14:38 |
mriedem | the microversion might have just been for discoverability | 14:39 |
smcginnis | So if 3.50 or greater is not specified, should we ignore that in the volume type? | 14:39 |
*** elmaciej has quit IRC | 14:39 | |
smcginnis | It's not really an API change to me. | 14:39 |
smcginnis | Oh, true. | 14:39 |
smcginnis | But should we ignore it if mv is < 3.50? | 14:39 |
smcginnis | And if policy is not allowed, should we just not set multiattach, or should we actually fail the op? | 14:40 |
*** elmaciej has joined #openstack-cinder | 14:40 | |
mriedem | i'm just trying to create a demo with the type since that's the recommended way to do this, but i could just use the multiattach flag on the volume too | 14:40 |
mriedem | i need to figure out why the type fails during scheduling though | 14:40 |
mriedem | i just did | 14:40 |
mriedem | $ openstack volume type create --property multiattach="<is> True" multiattach | 14:40 |
mriedem | is that enough? | 14:40 |
mriedem | will it default to lvm otherwise? | 14:41 |
smcginnis | I thought that was it. | 14:41 |
mriedem | oh hmm | 14:41 |
mriedem | stack@queens:~/devstack$ openstack volume type show multiattach | 14:41 |
mriedem | +--------------------+--------------------------------------+ | 14:41 |
mriedem | | Field | Value | | 14:41 |
mriedem | +--------------------+--------------------------------------+ | 14:41 |
mriedem | | access_project_ids | None | | 14:41 |
mriedem | | description | None | | 14:41 |
mriedem | | id | a17cff38-51b4-4250-80f3-cf8954547859 | | 14:41 |
mriedem | | is_public | True | | 14:41 |
mriedem | | name | multiattach | | 14:41 |
mriedem | | properties | | | 14:41 |
mriedem | +--------------------+--------------------------------------+ | 14:41 |
mriedem | the property doesn't seem to be set there | 14:41 |
smcginnis | You can specify backend name to make it explicit, but it _should_ be able to select it based on lvm being the only capable backend. | 14:41 |
smcginnis | Hmmm | 14:41 |
*** dansmith is now known as superdan | 14:43 | |
*** elmaciej_ has joined #openstack-cinder | 14:43 | |
lbragstad | mriedem by picked up automatically? | 14:44 |
lbragstad | do you mean it has overrides in it and they aren't registering? | 14:44 |
mriedem | lbragstad: yeah i just wrote one rule to /etc/cinder/policy.yaml | 14:44 |
mriedem | and it didn't seem to get validated | 14:44 |
mriedem | but now i'm maybe hitting something different | 14:44 |
lbragstad | mriedem yeah - as long as the configuration file specifies the correct policy file, that should be automatic | 14:44 |
openstackgerrit | Merged openstack/cinder master: 3PAR: Monitor task of promoting a virtual copy https://review.openstack.org/545214 | 14:45 |
mriedem | which config? cinder.conf? | 14:45 |
lbragstad | yeah | 14:45 |
mriedem | smcginnis: this time the type looks OK http://paste.openstack.org/show/674484/ | 14:45 |
mriedem | weird | 14:45 |
smcginnis | I blame the user. | 14:45 |
lbragstad | oslo.policy passes options through each services configuration file for common policy stuff | 14:45 |
mriedem | lbragstad: ok cinder.conf might default to policy.json | 14:45 |
* lbragstad digs | 14:45 | |
mriedem | yup #policy_file = policy.json | 14:45 |
lbragstad | https://github.com/openstack/oslo.policy/blob/master/oslo_policy/opts.py | 14:46 |
mriedem | ok i figured policy.yaml was too futuristic | 14:46 |
lbragstad | nice | 14:46 |
*** elmaciej has quit IRC | 14:46 | |
lbragstad | that yaml is some pretty crazy stuff | 14:46 |
lbragstad | if you set the path to point to policy.yaml, it should register that one override automatically in cinder's policies | 14:47 |
mriedem | yeah for the sake of this demo i'll just use policy.json for the defaults | 14:47 |
smcginnis | We are at least checking policy: https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L292 | 14:49 |
smcginnis | But not mv. | 14:49 |
mriedem | yeah testing that now | 14:49 |
mriedem | aha | 14:50 |
mriedem | stack@queens:~$ openstack volume create --image cirros-0.3.5-x86_64-disk --size 1 --type multiattach cirros-multiattach-volume | 14:50 |
mriedem | Policy doesn't allow volume:multiattach to be performed. (HTTP 403) (Request-ID: req-e98ce62f-69b7-44c3-a60d-f711af5d8241) | 14:50 |
mriedem | and that was w/o 3.50 | 14:50 |
smcginnis | Looks like we need to add a check. | 14:50 |
mriedem | for mv? | 14:50 |
mriedem | like i said, i think it's just there for discoverability | 14:51 |
mriedem | but you'd have to confirm with jgriffith | 14:51 |
smcginnis | I guess I could see three options.. | 14:51 |
smcginnis | 1) Must specify 3.50 or later or it gets ignored and is not set to multiattach | 14:51 |
smcginnis | 2) Must specify 3.50 or later or it errors out if multiattach is specified | 14:52 |
smcginnis | 3) It's just a programmatic way to check and we don't give a rats ass what the request comes in with. | 14:52 |
*** jistr is now known as jistr|mtg | 14:52 | |
smcginnis | I guess we've gone the option 3 route with how things are right now. | 14:52 |
mriedem | yeah | 14:52 |
smcginnis | Which honestly is just fine with me. | 14:52 |
mriedem | at this point it'd be bad to go back on that probably | 14:53 |
mriedem | did you guys do an rc2? | 14:53 |
smcginnis | One planned for Monday. | 14:53 |
smcginnis | But I don't really think we should change it, thinking about it. | 14:53 |
mriedem | (2) gets weird with the existing multiattach flag on the volume that's been around since forever | 14:53 |
smcginnis | Could be confusing, especially to end users that don't have visibility into extra specs and such. | 14:53 |
smcginnis | mriedem: Right, that's worse than handling the new style. | 14:54 |
*** andreas_s has joined #openstack-cinder | 14:54 | |
mriedem | default policy probably shows the type extra specs (that's the way it is in nova i think), but i agree that needing to look at extra specs as a user sucks | 14:54 |
mriedem | ok so i'll keep going with this | 14:54 |
jungleboyj | mriedem: ++ | 14:54 |
*** salv-orl_ has joined #openstack-cinder | 14:55 | |
smcginnis | Oh good, my last concern was that we do not check policy on retype. | 14:55 |
smcginnis | But that is covered. | 14:55 |
smcginnis | https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L1656 | 14:55 |
smcginnis | Although, in that case it will fail if going from a multiattach type to a non-multiattach type. | 14:56 |
smcginnis | Which seems a little odd to me. | 14:56 |
mriedem | that should only be for in-use volumes i think | 14:56 |
smcginnis | No, that's outside of the if block | 14:56 |
jungleboyj | smcginnis: That is a bug then. | 14:57 |
mriedem | we don't want to retype from / to multiattach when a volume is attached b/c that triggeres swap volume in nova which could be bad | 14:57 |
smcginnis | It's if the source volume and the target volume have different multiattach settings, so you could be going from a capable one to an incapable one, and it would fail saying your not allowed to do the thing that you're trying not to do. | 14:57 |
mriedem | in ^ it checks the volume status and if it's not available it would fail before the policy check | 14:57 |
smcginnis | mriedem: It's outside of that if block. | 14:57 |
*** mdbooth has joined #openstack-cinder | 14:57 | |
smcginnis | This is where {} comes in handy. | 14:58 |
smcginnis | Or blank lines for readability. | 14:58 |
*** r-daneel has quit IRC | 14:58 | |
*** salv-orlando has quit IRC | 14:58 | |
*** andreas_s has quit IRC | 14:58 | |
mriedem | multiattach_policy is admin_or_owner; so you should be able to retype to/from multiattach capability as long as the volume is available | 14:59 |
mriedem | which is what that code is doing right? | 14:59 |
smcginnis | https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L1656 | 14:59 |
mriedem | right, i don't see the issue | 14:59 |
mriedem | is it that, i could be going from multiattach=True to multiattach=False and fail the policy check? | 15:00 |
mriedem | even though i'm going to multiattach=False? | 15:00 |
*** pooja_jadhav has quit IRC | 15:00 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Only enfore multiattach policy for retype target https://review.openstack.org/545357 | 15:00 |
smcginnis | mriedem: Correct. | 15:00 |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Only enforce multiattach policy for retype target https://review.openstack.org/545357 | 15:01 |
ildikov | mriedem: so the microversion was just for discoverability | 15:02 |
ildikov | mriedem: we didn't have any enforcement like how we do in the Nova API | 15:02 |
mriedem | smcginnis: logic looks good in that patch | 15:02 |
mriedem | back to figuring out why i can't actually create a volume using this type... | 15:03 |
smcginnis | mriedem: Cool. I figured it would make more sense after seeing that. | 15:03 |
mriedem | hmm, yeah i continue to fail in scheduling | 15:03 |
*** andreas_s has joined #openstack-cinder | 15:04 | |
ildikov | mriedem: does it fail with both setting the flag and the volume_type method? | 15:06 |
*** felipemonteiro__ has quit IRC | 15:06 | |
*** felipemonteiro_ has joined #openstack-cinder | 15:06 | |
mriedem | i haven't tried the flag | 15:06 |
mriedem | having a hard time simply deleting volumes | 15:06 |
mriedem | http://paste.openstack.org/show/674508/ | 15:06 |
ildikov | that's weird | 15:07 |
mriedem | no errors in the logs when trying to force delete that volume | 15:07 |
mriedem | but it won't go away | 15:07 |
mriedem | aha | 15:08 |
mriedem | Feb 16 15:08:02 queens cinder-volume[1577]: ERROR cinder.utils [req-50b3a91d-56e4-4ec5-a89d-adc147d57ea4 req-7f8a6455-3e61-48e2-a152-3092221c9784 demo None] Volume driver LVMVolumeDriver not initialized | 15:08 |
*** andreas_s has quit IRC | 15:08 | |
mriedem | which is probably the reason for my schedluing failures | 15:09 |
jungleboyj | smcginnis: Is that another one for RC2? | 15:09 |
ildikov | mriedem: yeah, that explains it | 15:09 |
mriedem | i guess this is preventing c-vol from starting | 15:10 |
mriedem | ERROR cinder.volume.manager Stderr: u' Volume group "stack-volumes-lvmdriver-1" not found\n Cannot process volume group stack-volumes-lvmdriver-1\n' | 15:10 |
mriedem | i don't know how that would be gone | 15:11 |
ildikov | hmm, I don't remember seeing that before | 15:12 |
jungleboyj | smcginnis: Merging this one for you: https://review.openstack.org/#/c/545210/1 | 15:14 |
*** lbragstad has quit IRC | 15:14 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Expand on mv 3.50 description https://review.openstack.org/545361 | 15:14 |
*** jistr|mtg is now known as jistr | 15:15 | |
*** lbragstad has joined #openstack-cinder | 15:16 | |
openstackgerrit | Matt Riedemann proposed openstack/cinder master: Expand on mv 3.50 description https://review.openstack.org/545361 | 15:16 |
smcginnis | mriedem: :P | 15:17 |
smcginnis | jungleboyj: ++ | 15:17 |
jungleboyj | Everything I know about reviewing I learned from mriedem | 15:17 |
jungleboyj | Didn't you have another one that needed BP for Queens? | 15:17 |
mriedem | recreated the vg | 15:20 |
mriedem | restarted c-vol | 15:20 |
mriedem | things are up now | 15:20 |
mriedem | finally force deleted that volume (after changing the policy, yay) | 15:22 |
mriedem | booya | 15:23 |
mriedem | stack@queens:~$ openstack volume show -c name -c multiattach -c status cirros-multiattach-volume | 15:23 |
mriedem | +-------------+---------------------------+ | 15:23 |
mriedem | | Field | Value | | 15:23 |
mriedem | +-------------+---------------------------+ | 15:23 |
mriedem | | multiattach | True | | 15:23 |
mriedem | | name | cirros-multiattach-volume | | 15:23 |
mriedem | | status | available | | 15:23 |
mriedem | +-------------+---------------------------+ | 15:23 |
jungleboyj | smcginnis: You ok with the time I moved Cinder's picture to? | 15:25 |
*** felipemonteiro__ has joined #openstack-cinder | 15:26 | |
smcginnis | jungleboyj: I think that should work for me. | 15:26 |
jungleboyj | Ok and should minimize disruption. | 15:26 |
*** felipemonteiro_ has quit IRC | 15:29 | |
*** lpetrut has quit IRC | 15:31 | |
ildikov | mriedem: \o/ | 15:36 |
ildikov | mriedem: are you recording all the obstacles for the demo too? :) | 15:36 |
*** andreas_s has joined #openstack-cinder | 15:36 | |
mriedem | ildikov: just did, hit another one | 15:37 |
ildikov | :/ | 15:37 |
mriedem | we have novaclient capped at 9.1.1 in queens, and you need novaclient 10.1.0 to get 2.60 support for OSC since OSC uses novaclient | 15:37 |
mriedem | i could just use nova CLI but wanted to only use OSC for the demo | 15:37 |
ildikov | ah, ok | 15:38 |
mriedem | the joys of being a user | 15:39 |
mriedem | something i don't fart around with often enough | 15:39 |
ildikov | yeah, I'm out of practice as well | 15:39 |
*** r-daneel has joined #openstack-cinder | 15:40 | |
jungleboyj | I have been a user lately and it is a difference experience. :-) | 15:40 |
mriedem | it's an easy way to find problems in all of the docs | 15:40 |
jungleboyj | :-) | 15:40 |
*** e0ne_ has joined #openstack-cinder | 15:43 | |
*** e0ne has quit IRC | 15:43 | |
*** david-lyle has joined #openstack-cinder | 15:44 | |
ildikov | I know, when we have the Upstream training I always tell the students to install DevStack and start playing with it; it's guaranteed they will quickly find a bug for themselves to fix | 15:44 |
*** e0ne has joined #openstack-cinder | 15:45 | |
*** swamireddy has quit IRC | 15:47 | |
jungleboyj | :-) | 15:47 |
*** e0ne_ has quit IRC | 15:47 | |
mriedem | heh, hit the latent nova bug where bfv fails in the api, you delete the server and the volume is left 'reserved' | 15:48 |
mriedem | so you have to force detach it | 15:48 |
* mriedem goes to change default policy yet again | 15:48 | |
mriedem | there is no force detach CLI anywhere? | 15:49 |
mriedem | i can reset-state, but that doesn't cleanup the attachments on the volume right? | 15:51 |
ildikov | according to my knowledge it does not | 15:52 |
jungleboyj | mriedem: That is true. | 15:52 |
mriedem | alright, curling it up | 15:54 |
*** r-daneel has quit IRC | 15:55 | |
*** csaikia has joined #openstack-cinder | 15:56 | |
*** pcaruana has quit IRC | 15:57 | |
mriedem | hmm, what am i doing wrong here? | 15:59 |
mriedem | curl -d '{"os-force_detach": {}}' -H "accept: application/json" -H "x-auth-token: $token" http://199.204.45.19/volume/v3/e9d773beeef2435eb59f7c6eeaf685a9/volumes/126c8d4b-c582-484a-8c09-fe901a7dc17f/action | 15:59 |
mriedem | {"badRequest": {"message": "There is no such action: None", "code": 400}} | 15:59 |
*** salv-orl_ has quit IRC | 16:00 | |
*** salv-orlando has joined #openstack-cinder | 16:00 | |
*** felipemonteiro__ has quit IRC | 16:02 | |
*** r-daneel has joined #openstack-cinder | 16:03 | |
*** salv-orlando has quit IRC | 16:05 | |
geguileo | mriedem: I believe you are missing the connector information within the os-force_detach | 16:05 |
geguileo | dictionary | 16:06 |
mriedem | geguileo: it's optional | 16:06 |
mriedem | according to the api-ref | 16:06 |
mriedem | https://developer.openstack.org/api-ref/block-storage/v3/#force-detach-a-volume | 16:06 |
geguileo | oh, true, true | 16:06 |
mriedem | it appears to not even get to the actual method | 16:08 |
*** andreas_s has quit IRC | 16:09 | |
mriedem | AHA | 16:09 |
mriedem | Feb 16 16:08:49 queens devstack@c-api.service[1549]: DEBUG cinder.api.openstack.wsgi [None req-c7279a60-f7ba-4a11-98f2-8fa2b2ec281d demo demo] Unrecognized Content-Type provided in request {{(pid=1723) get_body /opt/stack/cinder/cinder/api/openstack/wsgi.py:724}} | 16:09 |
*** finucannot is now known as stephenfin | 16:10 | |
geguileo | ok, you are missing -H "Content-Type: application/json" | 16:11 |
mriedem | yeah i was using an accept header, needed content-type | 16:12 |
*** david-lyle has quit IRC | 16:15 | |
*** slunkad_ has joined #openstack-cinder | 16:17 | |
*** david-lyle has joined #openstack-cinder | 16:22 | |
*** luizbag has quit IRC | 16:22 | |
*** markvoelker has quit IRC | 16:23 | |
erlon | eharney, hey, can you give a look on these when you have a chance? Added the depends-on and cherry-picked tags | 16:24 |
eharney | erlon: sure | 16:26 |
*** andreas_s has joined #openstack-cinder | 16:27 | |
*** markvoelker_ has joined #openstack-cinder | 16:27 | |
erlon | eharney, this is aquick one too: https://review.openstack.org/#/c/543912/ | 16:28 |
* mriedem obviously doesn't curl much | 16:30 | |
openstackgerrit | Matt Riedemann proposed openstack/cinder master: Provide a hint when performing a volume action can't find the method https://review.openstack.org/545378 | 16:32 |
*** aspiers has quit IRC | 16:33 | |
*** AlexeyAbashkin has quit IRC | 16:33 | |
*** imacdonn has quit IRC | 16:37 | |
*** imacdonn has joined #openstack-cinder | 16:38 | |
*** felipemonteiro has joined #openstack-cinder | 16:45 | |
mriedem | ildikov: oh gdi, | 16:46 |
*** andreas_s has quit IRC | 16:46 | |
mriedem | my devstack is using pike uca so the qemu version is too high for multiattach... :) | 16:46 |
mriedem | time to recreate devstack... | 16:46 |
*** aspiers has joined #openstack-cinder | 16:49 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: Enable hash randomization in unit tests https://review.openstack.org/465636 | 16:50 |
openstackgerrit | Eric Harney proposed openstack/cinder master: QNAP: Pass unit tests with hash randomization enabled https://review.openstack.org/545383 | 16:50 |
smcginnis | eharney: \o/ | 16:50 |
eharney | a few more off the list... more to go | 16:51 |
smcginnis | It's at least progress. | 16:51 |
smcginnis | Sounds like after 18.04 is released in April, or shortly thereafter, python 3 testing will move to 3.6. | 16:51 |
smcginnis | So... I guess we have some extra motivation to get that stuff moving. | 16:52 |
ildikov | mriedem: I wanted to ask about that, but I was sure that if someone, you have the right env :) | 16:53 |
mriedem | i created this devstack env last week before thinking about doinga demo | 16:53 |
mriedem | but probably would have forgotten anyway.. | 16:53 |
mriedem | need to create a multiattach-specific localrc file | 16:54 |
ildikov | yeah, multi-attach is special :) | 16:54 |
mriedem | my ever expanding set of local.confs | 16:54 |
ildikov | never ending story | 16:55 |
smcginnis | That movie confused me so much as a kid. | 16:55 |
*** itlinux has joined #openstack-cinder | 16:55 | |
mriedem | i hadn't seen it until i was in my late 20s with my now wife, | 16:56 |
mriedem | totally didn't see what all of the hubbub was about | 16:56 |
ildikov | smcginnis: lol | 16:56 |
ildikov | it confused me a little too TBH :) | 16:56 |
smcginnis | There's probably about a year and a half window in age where it's good an makes some sense. Otherwise it's either too confusing or you're too old. :) | 16:57 |
*** luizbag has joined #openstack-cinder | 16:58 | |
*** r-daneel has quit IRC | 17:02 | |
*** e0ne has quit IRC | 17:06 | |
*** elmaciej_ has quit IRC | 17:07 | |
Swanson | I have the same opinion of A Clockwork Orange. | 17:08 |
*** felipemonteiro has quit IRC | 17:10 | |
smcginnis | Now that one I saw way too young and was definitely confused by. Only slightly better older after having read the book. | 17:11 |
*** luizbag has quit IRC | 17:11 | |
*** luizbag has joined #openstack-cinder | 17:14 | |
*** links has quit IRC | 17:18 | |
*** itlinux has quit IRC | 17:22 | |
*** swamireddy has joined #openstack-cinder | 17:24 | |
*** itlinux has joined #openstack-cinder | 17:25 | |
jungleboyj | I still haven't seen Never Ending Story. | 17:29 |
*** belmoreira has quit IRC | 17:29 | |
jungleboyj | My freshman year in College writing course was on A Clockwork Orange. | 17:29 |
jungleboyj | Was quite the start to college. | 17:29 |
mnaser | um | 17:30 |
mnaser | https://review.openstack.org/#/c/545201/2/cinder/volume/manager.py L1625 and L1635.. it says its over 80 characters (right at 80), if i indent inwards by 1 space, it says its not properly indented | 17:30 |
mnaser | does anyone mind handholding how clean this up :p | 17:31 |
*** luizbag has quit IRC | 17:32 | |
eharney | mnaser: line break after the *, i think | 17:32 |
smcginnis | mnaser: You'll have to do some funky formatting. | 17:32 |
mnaser | as if it isnt funky enough as is, bleh | 17:32 |
smcginnis | Yeah, what eharney said should work. | 17:32 |
mnaser | OH | 17:32 |
mnaser | i think i could refactor it into a simple for loop instead | 17:32 |
smcginnis | Even better. | 17:32 |
mnaser | because its always <foo>_per_gb which translates to <foo> * <size> | 17:33 |
* mnaser wrote that patch late last night | 17:33 | |
eharney | seems sensible | 17:33 |
openstackgerrit | Mohammed Naser proposed openstack/cinder master: Add throughput limits that scale per-GB https://review.openstack.org/545201 | 17:39 |
mnaser | done.. should be much cleaner | 17:40 |
openstackgerrit | Eric Young proposed openstack/os-brick master: Adding support to extend attached ScaleIO volumes https://review.openstack.org/545404 | 17:45 |
*** harlowja has joined #openstack-cinder | 17:55 | |
*** kaisers_ has quit IRC | 17:55 | |
*** lbragstad has quit IRC | 17:55 | |
*** lbragstad has joined #openstack-cinder | 17:56 | |
*** hemna_ has quit IRC | 17:57 | |
*** mriedem is now known as mriedem_lunch | 17:58 | |
*** hemna_ has joined #openstack-cinder | 18:00 | |
*** mayur_ind has joined #openstack-cinder | 18:04 | |
*** kaisers_ has joined #openstack-cinder | 18:04 | |
*** r-daneel has joined #openstack-cinder | 18:05 | |
*** hemna_ has quit IRC | 18:09 | |
*** salv-orlando has joined #openstack-cinder | 18:10 | |
*** hemna_ has joined #openstack-cinder | 18:11 | |
*** david-lyle has quit IRC | 18:12 | |
*** dustins has quit IRC | 18:15 | |
mayur_ind | hi @smcginnis... where this 'target_conf' option is declared, its not in cinder.conf..... https://review.openstack.org/#/c/539230/3/cinder/volume/drivers/veritas_access/veritas_iscsi.py@48 | 18:16 |
*** hemna_ has quit IRC | 18:20 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: QNAP: Pass unit tests with hash randomization enabled https://review.openstack.org/545383 | 18:23 |
openstackgerrit | Eric Harney proposed openstack/cinder master: Enable hash randomization in unit tests https://review.openstack.org/465636 | 18:23 |
*** AlexeyAbashkin has joined #openstack-cinder | 18:24 | |
*** hemna_ has joined #openstack-cinder | 18:25 | |
*** tesseract has quit IRC | 18:26 | |
openstackgerrit | Mohammed Naser proposed openstack/cinder master: Add throughput limits that scale per-GB https://review.openstack.org/545201 | 18:27 |
*** crose has joined #openstack-cinder | 18:27 | |
*** AlexeyAbashkin has quit IRC | 18:28 | |
*** r-daneel has quit IRC | 18:37 | |
*** r-daneel has joined #openstack-cinder | 18:38 | |
*** psachin has joined #openstack-cinder | 18:41 | |
*** harlowja has quit IRC | 18:44 | |
*** harlowja has joined #openstack-cinder | 18:48 | |
*** kaisers_ has quit IRC | 18:52 | |
*** r-daneel has quit IRC | 18:54 | |
*** lpetrut has joined #openstack-cinder | 18:55 | |
*** r-daneel has joined #openstack-cinder | 18:58 | |
smcginnis | mayur_ind: target_port | 19:08 |
smcginnis | mayur_ind: You can search for it here: https://docs.openstack.org/cinder/latest/sample_config.html | 19:09 |
*** harlowja has quit IRC | 19:10 | |
*** hemna_ has quit IRC | 19:11 | |
*** lpetrut has quit IRC | 19:12 | |
*** mayur_ind has quit IRC | 19:12 | |
*** david-lyle has joined #openstack-cinder | 19:13 | |
*** hemna_ has joined #openstack-cinder | 19:15 | |
*** lpetrut has joined #openstack-cinder | 19:20 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: QNAP: Pass unit tests with hash randomization enabled https://review.openstack.org/545383 | 19:21 |
openstackgerrit | Eric Harney proposed openstack/cinder master: Enable hash randomization in unit tests https://review.openstack.org/465636 | 19:22 |
*** pchavva1 has joined #openstack-cinder | 19:27 | |
*** dustins has joined #openstack-cinder | 19:33 | |
*** erlon has quit IRC | 19:38 | |
openstackgerrit | Merged openstack/cinder master: Provide a hint when performing a volume action can't find the method https://review.openstack.org/545378 | 19:40 |
*** pchavva1 has quit IRC | 19:42 | |
*** pchavva has quit IRC | 19:42 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: Tests: Fix python version check https://review.openstack.org/545441 | 19:44 |
*** mriedem_lunch is now known as mriedem | 19:44 | |
mriedem | gah devstack doesn't add ssh rules to the default security group, by default | 19:47 |
*** harlowja has joined #openstack-cinder | 19:50 | |
smcginnis | Huh, I thought it used to. | 19:51 |
mtreinish | smcginnis: I don't think it ever did | 20:00 |
mtreinish | but it's been a while since I checked | 20:00 |
smcginnis | Guess I've always used my real cloud for accessing the guests then. | 20:01 |
*** r-daneel_ has joined #openstack-cinder | 20:02 | |
*** salv-orlando has quit IRC | 20:03 | |
*** salv-orlando has joined #openstack-cinder | 20:04 | |
*** r-daneel has quit IRC | 20:05 | |
*** r-daneel_ is now known as r-daneel | 20:05 | |
*** dustins_ has joined #openstack-cinder | 20:08 | |
*** salv-orlando has quit IRC | 20:08 | |
*** dustins has quit IRC | 20:08 | |
*** eharney has quit IRC | 20:13 | |
*** lpetrut has quit IRC | 20:16 | |
*** lpetrut has joined #openstack-cinder | 20:17 | |
*** BlackDex has quit IRC | 20:23 | |
*** salv-orlando has joined #openstack-cinder | 20:34 | |
Roamer` | yep, I think "add a security rule for SSH" was an item in a couple of quick setup guides for OpenStack that I read way back when | 20:38 |
*** BlackDex has joined #openstack-cinder | 20:41 | |
*** andreas_s has joined #openstack-cinder | 20:43 | |
openstackgerrit | Brianna Poulos proposed openstack/cinder master: docs: Fix volume encryption link https://review.openstack.org/545451 | 20:45 |
*** andreas_s has quit IRC | 20:47 | |
*** markvoelker_ has quit IRC | 20:55 | |
*** markvoelker has joined #openstack-cinder | 20:56 | |
*** liverpooler has quit IRC | 20:57 | |
*** eharney has joined #openstack-cinder | 21:05 | |
openstackgerrit | Brianna Poulos proposed openstack/python-cinderclient master: Update help text for encryption provider https://review.openstack.org/545456 | 21:08 |
openstackgerrit | Eric Young proposed openstack/os-brick master: Adding support to extend attached ScaleIO volumes https://review.openstack.org/545404 | 21:10 |
*** r-daneel has quit IRC | 21:10 | |
mriedem | yay i found a nova + multiattach bug | 21:19 |
ildikov | mriedem: should I be happy now? :) | 21:20 |
mriedem | sure | 21:20 |
mriedem | it's just a ux problem in nova api | 21:20 |
ildikov | so what's the bug? | 21:20 |
mriedem | i was forgetting to specify 2.60 and the very specific error about needing to use 2.60 was catch by a generic Exception block and turned into a much less useful error message | 21:21 |
mriedem | *caught | 21:21 |
mriedem | had to put some debug code in the API to figure it out | 21:21 |
*** ganso has quit IRC | 21:21 | |
mriedem | https://bugs.launchpad.net/nova/+bug/1750064 | 21:23 |
openstack | Launchpad bug 1750064 in OpenStack Compute (nova) "multiattach volume failures are masked in compute api" [Undecided,New] | 21:23 |
ildikov | hmm, I thought I remembered seeing that error, but that might've been some trace in tempest | 21:23 |
mriedem | Roamer`: yeah copied from https://docs.openstack.org/nova/pike/admin/security-groups.html#create-security-group-rules-for-a-cluster-of-instances | 21:25 |
smcginnis | tbarron: Was there expected to be a v2 at some point? https://github.com/openstack/cinder/blob/master/cinder/backup/chunkeddriver.py#L617 | 21:26 |
tbarron | smcginnis: good question, that was business logic copied from when this was a swift backup only | 21:27 |
tbarron | mebbe DuncanT ^^^ knows | 21:27 |
smcginnis | tbarron: OK, just thought I would check since I didn't see any signs of anything other than v1. ;) | 21:27 |
tbarron | smcginnis: right, at this point I think whatever versioning was imagined is no longer relevant | 21:28 |
smcginnis | tbarron: Given that this code really hasn't been touched since you were working on it, that's probably safe to assume for now. ;) | 21:29 |
*** r-daneel has joined #openstack-cinder | 21:48 | |
*** dustins_ has quit IRC | 21:55 | |
*** lpetrut has quit IRC | 22:00 | |
*** edmondsw has quit IRC | 22:01 | |
*** edmondsw has joined #openstack-cinder | 22:01 | |
*** psachin has quit IRC | 22:04 | |
*** edmondsw has quit IRC | 22:06 | |
*** abishop has quit IRC | 22:09 | |
*** mchlumsky_ has quit IRC | 22:18 | |
*** tpsilva has quit IRC | 22:33 | |
*** zzzeek has quit IRC | 22:38 | |
*** zzzeek has joined #openstack-cinder | 22:42 | |
openstackgerrit | Marga Millet proposed openstack/cinder master: Cinder logs rabbitmq password on connection log https://review.openstack.org/545486 | 23:11 |
*** csaikia has quit IRC | 23:42 | |
*** csaikia has joined #openstack-cinder | 23:42 | |
openstackgerrit | Merged openstack/cinder master: Tests: Fix python version check https://review.openstack.org/545441 | 23:44 |
*** hemna_ has quit IRC | 23:50 | |
*** gman-tx has quit IRC | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!