*** jiaohaolin has left #openstack-cinder | 00:31 | |
*** r-daneel has joined #openstack-cinder | 00:38 | |
*** r-daneel has quit IRC | 00:42 | |
*** r-daneel has joined #openstack-cinder | 00:44 | |
*** dave-mccowan has joined #openstack-cinder | 00:48 | |
*** dpawlik has joined #openstack-cinder | 01:03 | |
*** zhaochao has joined #openstack-cinder | 01:06 | |
*** dpawlik has quit IRC | 01:07 | |
*** kaisers_ has joined #openstack-cinder | 01:14 | |
*** liuzz has joined #openstack-cinder | 01:17 | |
*** kaisers has quit IRC | 01:18 | |
*** edmondsw has joined #openstack-cinder | 01:32 | |
*** edmondsw has quit IRC | 01:36 | |
*** lixiaoy1 has joined #openstack-cinder | 01:42 | |
*** dalgaaf has quit IRC | 01:46 | |
*** dalgaaf has joined #openstack-cinder | 01:49 | |
*** links has joined #openstack-cinder | 02:17 | |
*** namnh has joined #openstack-cinder | 02:18 | |
*** ircuser-1 has joined #openstack-cinder | 02:23 | |
*** psachin has joined #openstack-cinder | 02:42 | |
*** EvilienM is now known as EmilienM | 02:45 | |
*** r-daneel has quit IRC | 02:50 | |
*** dklyle has joined #openstack-cinder | 02:51 | |
*** Dinesh_Bhor has joined #openstack-cinder | 02:54 | |
*** dklyle has quit IRC | 02:57 | |
*** dpawlik has joined #openstack-cinder | 03:03 | |
*** dpawlik has quit IRC | 03:11 | |
*** edmondsw has joined #openstack-cinder | 03:20 | |
*** moshele has quit IRC | 03:21 | |
*** dave-mccowan has quit IRC | 03:23 | |
*** edmondsw has quit IRC | 03:24 | |
*** pooja_jadhav has joined #openstack-cinder | 03:45 | |
openstackgerrit | Neha Alhat proposed openstack/cinder master: V3 jsonschema validation: volume_type_encryption https://review.openstack.org/561140 | 04:00 |
---|---|---|
*** threestrands has joined #openstack-cinder | 04:04 | |
*** namnh has quit IRC | 04:08 | |
*** namnh has joined #openstack-cinder | 04:09 | |
*** gyankum has joined #openstack-cinder | 04:10 | |
*** mmethot has joined #openstack-cinder | 04:10 | |
*** pgadiya has joined #openstack-cinder | 04:25 | |
*** pgadiya has quit IRC | 04:28 | |
*** abhishekk has joined #openstack-cinder | 04:35 | |
*** moshele has joined #openstack-cinder | 04:45 | |
openstackgerrit | Shunei Shiono proposed openstack/cinder master: NEC driver: Delete max volumes per pool limit. https://review.openstack.org/564372 | 04:46 |
*** Dinesh_Bhor has quit IRC | 04:59 | |
*** dpawlik has joined #openstack-cinder | 05:02 | |
*** Nel1x has quit IRC | 05:06 | |
*** dpawlik has quit IRC | 05:06 | |
*** hoonetorg has quit IRC | 05:07 | |
*** hoonetorg has joined #openstack-cinder | 05:20 | |
*** moshele has quit IRC | 05:21 | |
*** lkuchlan has joined #openstack-cinder | 05:22 | |
*** evin has quit IRC | 05:46 | |
*** pcaruana has joined #openstack-cinder | 06:02 | |
*** allegra__ has quit IRC | 06:05 | |
*** allegra__ has joined #openstack-cinder | 06:10 | |
*** evin has joined #openstack-cinder | 06:13 | |
*** lkuchlan has quit IRC | 06:20 | |
*** andreas_s has joined #openstack-cinder | 06:26 | |
*** andreas_s has quit IRC | 06:26 | |
*** hamdyk has joined #openstack-cinder | 06:27 | |
*** andreas_s has joined #openstack-cinder | 06:28 | |
*** armaan has quit IRC | 06:34 | |
*** armaan has joined #openstack-cinder | 06:35 | |
*** armaan has quit IRC | 06:42 | |
*** armaan has joined #openstack-cinder | 06:43 | |
*** Dinesh_Bhor has joined #openstack-cinder | 06:49 | |
*** edmondsw has joined #openstack-cinder | 06:56 | |
*** armaan has quit IRC | 06:58 | |
*** armaan has joined #openstack-cinder | 06:58 | |
*** edmondsw has quit IRC | 07:00 | |
*** dpawlik has joined #openstack-cinder | 07:03 | |
*** dpawlik has quit IRC | 07:08 | |
*** alexchadin has joined #openstack-cinder | 07:12 | |
*** alexchad_ has joined #openstack-cinder | 07:14 | |
*** alexchadin has quit IRC | 07:17 | |
*** alexchad_ is now known as alexchadin | 07:18 | |
openstackgerrit | fupingxie proposed openstack/cinder master: Remove stale pip-missing-reqs tox test https://review.openstack.org/566517 | 07:20 |
*** lkuchlan has joined #openstack-cinder | 07:25 | |
*** threestrands has quit IRC | 07:39 | |
openstackgerrit | Neha Alhat proposed openstack/cinder master: V3 jsonschema validation: scheduler_hints https://review.openstack.org/566525 | 07:50 |
*** moshele has joined #openstack-cinder | 07:55 | |
*** liuzz_ has joined #openstack-cinder | 08:25 | |
*** liuzz has quit IRC | 08:27 | |
*** edmondsw has joined #openstack-cinder | 08:44 | |
*** alexchadin has quit IRC | 08:47 | |
*** edmondsw has quit IRC | 08:49 | |
openstackgerrit | Neha Alhat proposed openstack/cinder master: V3 jsonschema validation: volume_type_encryption https://review.openstack.org/561140 | 08:51 |
*** lixiaoy1 has quit IRC | 08:55 | |
*** dpawlik has joined #openstack-cinder | 09:04 | |
*** kaisers_ has quit IRC | 09:06 | |
*** e0ne has joined #openstack-cinder | 09:07 | |
*** dpawlik has quit IRC | 09:08 | |
*** dpawlik has joined #openstack-cinder | 09:11 | |
openstackgerrit | Pooja Jadhav proposed openstack/cinder master: V3 jsonschema validation: os-services https://review.openstack.org/566530 | 09:11 |
*** alexchadin has joined #openstack-cinder | 09:11 | |
*** dpawlik has quit IRC | 09:16 | |
*** Dinesh_Bhor has quit IRC | 09:32 | |
*** kaisers has joined #openstack-cinder | 09:36 | |
*** armaan has quit IRC | 09:38 | |
*** erlon has quit IRC | 09:39 | |
*** armaan has joined #openstack-cinder | 09:40 | |
*** alexchadin has quit IRC | 09:55 | |
*** afazekas is now known as afazekas|pto | 09:59 | |
openstackgerrit | TommyLike proposed openstack/cinder master: Support filter backend based on operation type https://review.openstack.org/554857 | 10:03 |
*** namnh has quit IRC | 10:15 | |
*** lkuchlan has quit IRC | 10:28 | |
*** edmondsw has joined #openstack-cinder | 10:32 | |
*** moshele has quit IRC | 10:33 | |
*** abhishekk has quit IRC | 10:34 | |
*** moshele has joined #openstack-cinder | 10:34 | |
*** edmondsw has quit IRC | 10:36 | |
*** armaan has quit IRC | 10:45 | |
*** armaan has joined #openstack-cinder | 10:45 | |
*** stakeda has quit IRC | 10:46 | |
*** luizbag has joined #openstack-cinder | 10:53 | |
*** s-shiono has quit IRC | 10:53 | |
*** pgadiya has joined #openstack-cinder | 11:00 | |
*** pgadiya has quit IRC | 11:00 | |
*** andreas_s has quit IRC | 11:11 | |
*** andreas_s has joined #openstack-cinder | 11:11 | |
*** dpawlik has joined #openstack-cinder | 11:12 | |
strigazi | hello, since last week I'm getting the following error when creating a devstack env: error in setup command: Error parsing /opt/stack/cinder/setup.cfg: SyntaxError: '<' operator not allowed in environment markers | 11:12 |
*** andreas_s_ has joined #openstack-cinder | 11:12 | |
strigazi | http://paste.openstack.org/show/720484/ | 11:13 |
strigazi | Has anyone seen this? | 11:13 |
*** dave-mccowan has joined #openstack-cinder | 11:14 | |
*** andreas_s_ has quit IRC | 11:14 | |
*** andreas_s_ has joined #openstack-cinder | 11:14 | |
*** andreas_s has quit IRC | 11:16 | |
*** dpawlik has quit IRC | 11:16 | |
*** andreas_s_ has quit IRC | 11:18 | |
*** andreas_s has joined #openstack-cinder | 11:19 | |
*** andreas_s_ has joined #openstack-cinder | 11:22 | |
*** andreas_s has quit IRC | 11:23 | |
*** dave-mccowan has quit IRC | 11:26 | |
*** dave-mccowan has joined #openstack-cinder | 11:27 | |
*** erlon has joined #openstack-cinder | 11:27 | |
*** moshele has quit IRC | 11:38 | |
*** moshele has joined #openstack-cinder | 11:40 | |
tommylikehu | hey geguileo, done! can you review it again? https://review.openstack.org/#/c/554857/ | 11:40 |
*** abishop has joined #openstack-cinder | 11:40 | |
*** r-daneel has joined #openstack-cinder | 11:53 | |
*** moshele has quit IRC | 11:54 | |
*** moshele has joined #openstack-cinder | 11:55 | |
*** alexchadin has joined #openstack-cinder | 12:09 | |
*** nicolasbock has joined #openstack-cinder | 12:09 | |
geguileo | tommylikehu: thanks, you have my +2 :-) | 12:11 |
*** markvoelker has joined #openstack-cinder | 12:17 | |
tommylikehu | geguileo: thanks :) | 12:25 |
geguileo | np | 12:25 |
*** liverpooler has joined #openstack-cinder | 12:25 | |
*** tpsilva has joined #openstack-cinder | 12:30 | |
*** lkuchlan has joined #openstack-cinder | 12:31 | |
openstackgerrit | TommyLike proposed openstack/cinder master: Add missing image metadata when creating volume from backup https://review.openstack.org/566560 | 12:31 |
*** edmondsw has joined #openstack-cinder | 12:32 | |
*** edmondsw has quit IRC | 12:36 | |
*** edmondsw has joined #openstack-cinder | 12:38 | |
*** edmondsw has quit IRC | 12:42 | |
*** edmondsw has joined #openstack-cinder | 12:44 | |
*** liuzz has joined #openstack-cinder | 12:45 | |
*** liuzz_ has quit IRC | 12:45 | |
*** felipemonteiro has joined #openstack-cinder | 12:48 | |
*** edmondsw has quit IRC | 12:48 | |
*** edmondsw has joined #openstack-cinder | 12:49 | |
*** mmedvede has quit IRC | 12:58 | |
*** lkuchlan has quit IRC | 12:59 | |
*** bhagyashri_s has joined #openstack-cinder | 13:01 | |
*** mmethot_ has joined #openstack-cinder | 13:01 | |
*** jmlowe_ has joined #openstack-cinder | 13:02 | |
*** vivsoni__ has joined #openstack-cinder | 13:02 | |
*** psachin` has joined #openstack-cinder | 13:03 | |
*** links has quit IRC | 13:05 | |
*** lbragstad has joined #openstack-cinder | 13:06 | |
*** felipemonteiro has quit IRC | 13:07 | |
*** zigo_ has joined #openstack-cinder | 13:07 | |
*** eric-young has joined #openstack-cinder | 13:09 | |
*** sdake_ has joined #openstack-cinder | 13:09 | |
*** sdake_ has quit IRC | 13:09 | |
*** sdake_ has joined #openstack-cinder | 13:09 | |
*** storshoo___ has joined #openstack-cinder | 13:09 | |
*** rmk` has joined #openstack-cinder | 13:09 | |
*** armaan has quit IRC | 13:09 | |
*** cburgess_ has joined #openstack-cinder | 13:09 | |
*** johnthetubaguy_ has joined #openstack-cinder | 13:10 | |
*** Reepicheep_ has joined #openstack-cinder | 13:10 | |
*** armaan has joined #openstack-cinder | 13:10 | |
*** mmethot has quit IRC | 13:11 | |
*** psachin has quit IRC | 13:11 | |
*** a_storshoo has quit IRC | 13:11 | |
*** jmlowe has quit IRC | 13:11 | |
*** vivsoni_ has quit IRC | 13:11 | |
*** sdake has quit IRC | 13:11 | |
*** bhagyashris has quit IRC | 13:11 | |
*** openstackgerrit has quit IRC | 13:11 | |
*** rmk has quit IRC | 13:11 | |
*** cburgess has quit IRC | 13:11 | |
*** Reepicheep has quit IRC | 13:11 | |
*** zigo has quit IRC | 13:11 | |
*** johnthetubaguy has quit IRC | 13:11 | |
*** ericyoung has quit IRC | 13:11 | |
*** bswartz has quit IRC | 13:11 | |
*** rmk` is now known as rmk | 13:11 | |
*** rmk has quit IRC | 13:11 | |
*** rmk has joined #openstack-cinder | 13:11 | |
*** dalgaaf has quit IRC | 13:14 | |
*** bswartz has joined #openstack-cinder | 13:17 | |
*** dalgaaf has joined #openstack-cinder | 13:18 | |
*** psachin` has quit IRC | 13:24 | |
*** mmedvede has joined #openstack-cinder | 13:26 | |
*** AlexeyAbashkin has joined #openstack-cinder | 13:28 | |
*** moshele has quit IRC | 13:30 | |
*** armaan has quit IRC | 13:34 | |
*** armaan has joined #openstack-cinder | 13:34 | |
*** pchavva has joined #openstack-cinder | 13:36 | |
*** superdan is now known as dansmith | 13:40 | |
*** dustins has joined #openstack-cinder | 13:42 | |
*** erlon has quit IRC | 13:44 | |
*** eharney has joined #openstack-cinder | 13:46 | |
*** gnufied has joined #openstack-cinder | 13:49 | |
*** lpetrut has joined #openstack-cinder | 13:51 | |
*** chhagarw has joined #openstack-cinder | 13:53 | |
*** r-daneel has quit IRC | 13:56 | |
mnaser | smcginnis: whenever you're around.. is rbd multiattach still a thing that might make it to queens? | 13:57 |
*** erlon has joined #openstack-cinder | 13:57 | |
mnaser | https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/rbd.py#L485-L492 | 13:57 |
mnaser | got my answer | 13:57 |
*** chhagarw has quit IRC | 14:00 | |
*** chhagarw has joined #openstack-cinder | 14:00 | |
*** gyankum has quit IRC | 14:05 | |
*** chhagarw has quit IRC | 14:06 | |
*** evin has quit IRC | 14:10 | |
smcginnis | mnaser: Yeah, there were a few random patches trying to enable that, so Eric added that comment. | 14:10 |
mnaser | smcginnis: gotcha, looks like it'll be a little while before that gets settled down | 14:14 |
*** armaan has quit IRC | 14:16 | |
*** throwsb1 has joined #openstack-cinder | 14:17 | |
*** armaan has joined #openstack-cinder | 14:17 | |
*** arnewiebalck_ has joined #openstack-cinder | 14:17 | |
smcginnis | mnaser: Yeah, I wouldn't expect it any time soon. | 14:18 |
mnaser | smcginnis: no worries, our cinder is on queens now so i was hoping maybe we could break it ;) | 14:19 |
*** armaan has quit IRC | 14:20 | |
*** armaan has joined #openstack-cinder | 14:21 | |
*** ganso has joined #openstack-cinder | 14:24 | |
tpsilva | jungleboyj: ping | 14:26 |
*** hemna_ has joined #openstack-cinder | 14:27 | |
*** r-daneel has joined #openstack-cinder | 14:28 | |
*** moshele has joined #openstack-cinder | 14:29 | |
*** felipemonteiro has joined #openstack-cinder | 14:32 | |
*** hamdyk has quit IRC | 14:34 | |
*** AlexeyAbashkin has quit IRC | 14:36 | |
*** felipemonteiro_ has joined #openstack-cinder | 14:42 | |
*** felipemonteiro has quit IRC | 14:45 | |
jungleboyj | tpsilva: Pong. | 14:47 |
*** arnewiebalck_ has quit IRC | 14:47 | |
*** lpetrut has quit IRC | 14:50 | |
*** lkuchlan has joined #openstack-cinder | 14:51 | |
tpsilva | jungleboyj: hello! have a question | 14:59 |
tpsilva | jungleboyj: after this patch merged: https://review.openstack.org/#/c/555717 | 14:59 |
jungleboyj | tpsilva: Looking. | 15:00 |
tpsilva | we found that our NFS host does not match that particular regex | 15:00 |
tpsilva | jungleboyj: oh wait, not this patch, just a sec | 15:00 |
jungleboyj | Ok. | 15:01 |
tpsilva | jungleboyj: https://review.openstack.org/#/c/528633/ | 15:02 |
tpsilva | this one | 15:02 |
tpsilva | it's the same topic, anyway | 15:02 |
tpsilva | it validates the parameters for the API | 15:02 |
tpsilva | jungleboyj: and now it validates if the hostname matches a regex (https://review.openstack.org/#/c/528633/6/cinder/api/validation/parameter_types.py) when managing a volume | 15:03 |
tpsilva | the problem is, our NFS driver uses the path to the nfs export as its hostname, so it doest not match that regex | 15:04 |
tpsilva | jungleboyj: my question: would it be ok to change this hostname regex to accept our implementation? | 15:05 |
*** dpawlik has joined #openstack-cinder | 15:05 | |
*** markstur has joined #openstack-cinder | 15:05 | |
jungleboyj | tpsilva: smcginnis and I were just talking and if it worked in the past and now doesn't. | 15:06 |
jungleboyj | So, it would seem it is a bug that should be resolved. | 15:06 |
tpsilva | jungleboyj: a bug in our driver? | 15:07 |
jungleboyj | No, a bug introduced by that change. | 15:07 |
*** alexchad_ has joined #openstack-cinder | 15:07 | |
smcginnis | A lot of those schema validation changes do kind of need some runtime and checking for odd cases like these. | 15:07 |
eharney | did the driver CI fail on that change? | 15:08 |
tpsilva | yep, and for some weird reason our manage/unmanage tests are disabled on our CI | 15:08 |
tpsilva | we are looking into that | 15:08 |
tpsilva | eharney: but it started failing on our internal functional tests routine | 15:08 |
tpsilva | unfortunately after ir merged | 15:08 |
tpsilva | s/ir/it | 15:09 |
*** pcaruana has quit IRC | 15:09 | |
tpsilva | ok, it is a simple fix and we actually already have a fix ready to go upstream | 15:09 |
*** alexchadin has quit IRC | 15:09 | |
*** dpawlik has quit IRC | 15:10 | |
*** felipemonteiro_ has quit IRC | 15:10 | |
*** felipemonteiro_ has joined #openstack-cinder | 15:10 | |
*** openstackgerrit has joined #openstack-cinder | 15:10 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Fix google backup driver https://review.openstack.org/566574 | 15:10 |
tpsilva | but it might be interesting to get attention from other vendors to check their drivers as well, if they already didn't | 15:10 |
*** mriedem has joined #openstack-cinder | 15:10 | |
smcginnis | tpsilva: Did third party CI not fail for this? | 15:11 |
tpsilva | smcginnis: nope... our ci is not running manage/unmanage tests, which is the feature that it's failing | 15:11 |
smcginnis | Ah, that's too bad. | 15:12 |
tpsilva | yep, we're looking into why it is disabled | 15:12 |
*** rajinir has joined #openstack-cinder | 15:12 | |
jungleboyj | tpsilva: Ok. Thanks for letting us know. I think it is ok to get a patch up to resolve the issue for your driver. | 15:14 |
tpsilva | jungleboyj: awesome, we'll just set things here downstream and we should have a patch up soon | 15:15 |
tpsilva | thanks everyone! | 15:15 |
smcginnis | The manage/unmanage APIs are hard to tempest test since that particular functionality needs somewhat driver-specific input. | 15:15 |
eharney | do we not have a tempest test that leverages list-manageable for that? | 15:15 |
tpsilva | we test that thoroughly with our functional tests, but it does not run upstream | 15:16 |
jungleboyj | eharney: Not sure. That would be one that would be hard to set up a test for. | 15:16 |
eharney | jungleboyj: how so? | 15:16 |
*** dpawlik has joined #openstack-cinder | 15:16 | |
jungleboyj | Oh, actually I suppose you could unmanage a volume and make sure it then shows up as one that could be managed in. | 15:17 |
*** dpawlik has quit IRC | 15:20 | |
*** felipemonteiro__ has joined #openstack-cinder | 15:22 | |
*** felipemonteiro_ has quit IRC | 15:26 | |
*** sapd_ has quit IRC | 15:32 | |
*** markstur_ has joined #openstack-cinder | 15:37 | |
*** andreas_s_ has quit IRC | 15:40 | |
*** andreas_s has joined #openstack-cinder | 15:40 | |
*** markstur has quit IRC | 15:41 | |
*** alexchad_ has quit IRC | 15:45 | |
*** andreas_s has quit IRC | 15:45 | |
*** lkuchlan has quit IRC | 15:45 | |
*** kaisers has quit IRC | 15:46 | |
*** armaan has quit IRC | 15:49 | |
*** dklyle has joined #openstack-cinder | 15:52 | |
*** moshele has quit IRC | 15:54 | |
*** dklyle has quit IRC | 15:57 | |
*** dklyle has joined #openstack-cinder | 15:57 | |
*** zhaochao has quit IRC | 16:13 | |
*** e0ne has quit IRC | 16:13 | |
*** openstackgerrit has quit IRC | 16:19 | |
*** alexchadin has joined #openstack-cinder | 16:20 | |
*** lpetrut has joined #openstack-cinder | 16:20 | |
*** finucannot is now known as stephenfin | 16:20 | |
*** diablo_rojo has joined #openstack-cinder | 16:20 | |
*** kaisers has joined #openstack-cinder | 16:23 | |
*** alexchadin has quit IRC | 16:24 | |
*** lkuchlan has joined #openstack-cinder | 16:28 | |
*** openstackgerrit has joined #openstack-cinder | 16:31 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: Validate releasenotes with yamllint https://review.openstack.org/566675 | 16:31 |
openstackgerrit | Merged openstack/cinder master: Support filter backend based on operation type https://review.openstack.org/554857 | 16:35 |
smcginnis | eharney: I like that idea, but I don't think that's going to work - https://docs.openstack.org/reno/latest/user/usage.html#updating-stable-branch-release-notes | 16:35 |
smcginnis | eharney: At least without adding a crap-ton pile of ignore-notes to the index pages. | 16:35 |
eharney | smcginnis: i was wondering about that... but not having any way to validate these seems like a bad idea too | 16:37 |
smcginnis | eharney: There's a "reno lint" subcommand. | 16:37 |
smcginnis | But still would have the issue of needing to update old notes. | 16:38 |
smcginnis | eharney: Doug was saying there are some plans in the works to just make these rst files too. | 16:38 |
eharney | i dunno, will think about it some more later... what we have committed so far is quite inconsistent :/ | 16:40 |
*** eharney has quit IRC | 16:40 | |
Swanson | Hey, smcginnis, https://www.washingtonpost.com/news/speaking-of-science/wp/2018/05/04/one-space-between-each-sentence-they-said-science-just-proved-them-wrong-2/?noredirect=on&utm_term=.5611830e0f59 | 16:46 |
smcginnis | Sure, if your head is clamped into place. Otherwise two spacing is just plain wrong! | 16:49 |
smcginnis | :) | 16:49 |
Swanson | 2 spaces is as god intended. | 16:50 |
smcginnis | It's the work of the devil! | 16:51 |
smcginnis | Extra spaces spread things out. So if it's printed, it needs more paper. More paper means cutting down more trees. That leads to global warming and natural disasters. That disrupts established civilations. So double spacing is leading to the end of the world and it's all your fault. :P | 16:52 |
Swanson | No one prints anymore. And twitter doubled the tweet size! All the space in the world. We can go to 3 spaces. | 16:54 |
smcginnis | Pfft | 16:54 |
smcginnis | :) | 16:54 |
Swanson | My typing teacher is rolling over in his grave. | 16:55 |
openstackgerrit | Merged openstack/cinder master: QNAP: driver fails to detach while uploading volume to image https://review.openstack.org/564095 | 17:05 |
*** jmlowe_ has quit IRC | 17:10 | |
*** mriedem has quit IRC | 17:10 | |
erlon | smcginnis, jungleboyj tpsilva: If Im not wrong, the NetApp driver does not runs the upstream tempest tests because we need to pass an specific driver provided handle that only works by default on LVM | 17:14 |
*** dpawlik has joined #openstack-cinder | 17:17 | |
*** alexchadin has joined #openstack-cinder | 17:18 | |
*** dpawlik has quit IRC | 17:21 | |
*** e0ne has joined #openstack-cinder | 17:35 | |
_alastor_ | Anyone here with experience in the OpenStackSDK? I've been trying to hail the SDK folks and had limited success | 17:37 |
*** moshele has joined #openstack-cinder | 17:40 | |
_alastor_ | It's somewhere in the Connection constructor, because volume_api_version is '2' when returned from 'get_one' | 17:50 |
_alastor_ | http://paste.openstack.org/show/720505/ | 17:51 |
*** alexchadin has quit IRC | 17:52 | |
*** lkuchlan has quit IRC | 17:52 | |
_alastor_ | whoops, wrong window | 17:56 |
*** eharney has joined #openstack-cinder | 17:58 | |
*** jmlowe has joined #openstack-cinder | 18:04 | |
Swanson | smcginnis, Jeff sez you're a two space denier. | 18:07 |
Swanson | (Wait, that joke has implications. Pretend I didn't type it.) | 18:12 |
*** jmlowe has quit IRC | 18:13 | |
*** jmlowe has joined #openstack-cinder | 18:15 | |
clarkb | _alastor_: the defaults come from openstacksdk/openstack/config/defaults.json and volume api is defaulted to v2 | 18:15 |
*** mvenesio has joined #openstack-cinder | 18:18 | |
smcginnis | Swanson: LOL | 18:36 |
*** dave-mccowan has quit IRC | 18:36 | |
*** dave-mcc_ has joined #openstack-cinder | 18:36 | |
*** mriedem has joined #openstack-cinder | 18:39 | |
openstackgerrit | Dhinesh Balasubramaniam proposed openstack/cinder master: Hedvig Cinder driver implementation https://review.openstack.org/433341 | 18:41 |
*** kaisers has quit IRC | 18:44 | |
*** kaisers has joined #openstack-cinder | 18:45 | |
e0ne | does anybody know what python2 version do we use at gates? | 18:47 |
_alastor_ | clarkb: I'm adding API v3 support for volume api, but the volume API is defaulting to 3 and ignoring the value in 'volume_api_version' in the config | 18:47 |
clarkb | _alastor_: defaulting to 2 you mean? | 18:48 |
_alastor_ | clarkb: so the _proxy.Proxy object is always v3 when it should be configurable | 18:48 |
_alastor_ | You can see my changes in this review: https://review.openstack.org/#/c/566355/ | 18:48 |
clarkb | as is that should continue to default to v2 since defaults.json isn't updated. YOu are saying it always uses v3 instead? If so interesting and probably beyond my understanding of the sdk | 18:50 |
_alastor_ | clarkb: It's defaulting to 3 which is why I'm confused. I know they treat cinder special in the SDK because of our versioning, but I can't nail down why this is happening | 18:52 |
clarkb | _alastor_: I do know the order of the list in https://review.openstack.org/#/c/566355/3/openstack/block_storage/block_storage_service.py also has some impact as first one there is used in some cases I think | 18:53 |
clarkb | ServiceFilter._get_valid_version returns first item in that list | 18:54 |
_alastor_ | clarkb: Yeah, it uses whichever is first in the list, but changing identity_api_version gets you the correct Keystone proxy even though it has multiple entries | 18:55 |
smcginnis | e0ne: I think it's 2.7.14. Whatever is the default on Xenial. | 18:57 |
smcginnis | e0ne: Might have to ask in -infra to make sure. | 18:57 |
e0ne | smcginnis: thanks. let me check on my second env first | 18:58 |
eharney | e0ne: zuul-info/host-info in the unit test job logs will tell you | 18:58 |
e0ne | I've got strange errors on my macbook since I updated python to 2.7.15 | 18:59 |
e0ne | eharney: thank you, Eric! | 19:00 |
smcginnis | Is it the same as ansible_python? | 19:00 |
eharney | i was assuming so | 19:01 |
smcginnis | Yeah, looks reasonable. I'm seeing 2.7.12. | 19:01 |
smcginnis | e0ne: Can you actually run tests on Mac? I've never been able to get our tests to work on there. | 19:02 |
clarkb | ansible currently always runs under python2 on the host aiui. But you can run your jobs on any python you get installed | 19:02 |
e0ne | smcginnis: unit tests worked for me except test_cmd.py | 19:02 |
smcginnis | clarkb: So py2 jobs are safe to assume running under what's shown for ansible_python_version? | 19:02 |
eharney | there's a dpkg-l.txt.gz on tempest jobs that will show the python package as well | 19:03 |
clarkb | smcginnis: yes unless you manage to do something weird with bindep | 19:03 |
smcginnis | e0ne: I had to mock out some rtslib things, but then I was running in to some other things. | 19:03 |
smcginnis | clarkb: Thanks! | 19:03 |
e0ne | smcginnis: it's pretty sad, but mac doesn't fit good for openstack development :( | 19:04 |
smcginnis | e0ne: Yeah. I at least would like to run the docs jobs. | 19:04 |
*** alexchadin has joined #openstack-cinder | 19:04 | |
smcginnis | e0ne: I started working through some issues. If I ever get it all working I'll submit it. | 19:04 |
smcginnis | e0ne: Even if we can't do a full tox run, if we can at least get most of it to run on Mac I think it would help. | 19:05 |
e0ne | smcginnis: +1 | 19:05 |
*** dave-mccowan has joined #openstack-cinder | 19:07 | |
*** e0ne_ has joined #openstack-cinder | 19:07 | |
*** dave-mcc_ has quit IRC | 19:07 | |
clarkb | _alastor_: seems like CloudRegion.get_service_type() is probably what needs debugging? | 19:08 |
*** eharney has quit IRC | 19:09 | |
*** e0ne has quit IRC | 19:11 | |
_alastor_ | clarkb: I saw that and had a laugh. It seems like a candidate, but that's not the same format as volume_api_version | 19:12 |
*** eharney has joined #openstack-cinder | 19:13 | |
_alastor_ | clarkb: I also tried putting volume_api_version in the format of 'volumev2' etc, but it didn't affect anything | 19:13 |
clarkb | _alastor_: I think its converting volume_api_version to use teh volumev2 and volumev3 types | 19:13 |
clarkb | vol_ver = self.get_api_version('volume') being the first step in that mapping | 19:14 |
_alastor_ | clarkb: Ah, I see. I'll push on that a bit | 19:14 |
_alastor_ | clarkb: Nope, something else. 'volumev2' gets returned from that function as expected, but the proxy is still for v3 | 19:17 |
_alastor_ | clarkb: looks like the constructor argument is v3 already before that function is even called | 19:21 |
*** evin has joined #openstack-cinder | 19:24 | |
clarkb | _alastor_: even though self.get_api_version('volume') returns 2? | 19:24 |
clarkb | weird | 19:24 |
*** jmlowe has quit IRC | 19:27 | |
_alastor_ | clarkb: config.get_api_version('block_store') returns None. | 19:28 |
_alastor_ | So it's defaulting | 19:28 |
_alastor_ | In openstack/service_description.py(127)get_proxy_class() | 19:29 |
clarkb | oh so it likely should be block_storage_api_version ? | 19:30 |
clarkb | I wonder if this is just an internal mixup between using service_type volume and block_store | 19:30 |
_alastor_ | clarkb: I think that's our smoking gun. Here's my config: http://paste.openstack.org/show/720516/ | 19:33 |
_alastor_ | It has volume_api_version, but no block_store | 19:33 |
_alastor_ | *block_storage | 19:34 |
clarkb | ya but it sort of handles both in that get_service_type method | 19:34 |
_alastor_ | clarkb: But it doesn't since get_proxy_class relies on what is returned from the config dict and 'block_storage' isn't populated | 19:36 |
_alastor_ | So instead of constructing 'v2' for the proxy class, it defaults | 19:36 |
clarkb | ya I don't think it is sufficient handling of both | 19:36 |
clarkb | I bet that is the bug | 19:37 |
*** alexchadin has quit IRC | 19:38 | |
_alastor_ | clarkb: A simple patch would be to put the special check for volume/block-store into get_api_version() to ensure volume_api_version is used instead of block_store | 19:39 |
clarkb | or maybe update get_session_endpoint to handle both? | 19:41 |
clarkb | and let the "low level" get_api_version return just what it asked for? | 19:42 |
_alastor_ | clarkb: get_session_endpoint isn't called when instantiating the connection object directly with a config | 19:51 |
_alastor_ | clarkb: At least not the one in cloud_region | 19:51 |
_alastor_ | clarkb: And opening openstackcloud.py causes my vim session to freak out :P | 19:52 |
*** lpetrut has quit IRC | 19:54 | |
*** moshele has quit IRC | 20:02 | |
*** alexchadin has joined #openstack-cinder | 20:03 | |
*** liverpooler has quit IRC | 20:04 | |
_alastor_ | clarkb: even openstackcloud.py doesn't really use get_session_endpoint. There's a single call to it uses to return a boolean (has_service()), but otherwise it's unused | 20:06 |
clarkb | huh | 20:07 |
openstackgerrit | Vipin Balachandran proposed openstack/cinder master: Log backup_service.restore() exception https://review.openstack.org/566728 | 20:21 |
*** eharney has quit IRC | 20:26 | |
*** alexchadin has quit IRC | 20:30 | |
*** pchavva has quit IRC | 20:33 | |
*** mvenesio has quit IRC | 20:38 | |
*** mvenesio has joined #openstack-cinder | 20:39 | |
*** fmccrthy_ has joined #openstack-cinder | 20:45 | |
*** tpsilva_ has joined #openstack-cinder | 20:46 | |
*** xdfil_ has joined #openstack-cinder | 20:46 | |
*** guyr-infinidat_ has joined #openstack-cinder | 20:46 | |
*** chrisyang_0660_ has joined #openstack-cinder | 20:46 | |
*** knikolla_ has joined #openstack-cinder | 20:47 | |
*** simondodsley_ has joined #openstack-cinder | 20:47 | |
*** mriedem has quit IRC | 20:48 | |
*** tezar_ has joined #openstack-cinder | 20:48 | |
*** luizbag has quit IRC | 20:48 | |
*** mvenesio has quit IRC | 20:53 | |
*** tpsilva has quit IRC | 20:53 | |
*** knikolla has quit IRC | 20:53 | |
*** mvk has quit IRC | 20:53 | |
*** tezar has quit IRC | 20:53 | |
*** wN_ has quit IRC | 20:53 | |
*** fmccrthy has quit IRC | 20:53 | |
*** simondodsley has quit IRC | 20:53 | |
*** xdfil has quit IRC | 20:53 | |
*** guyr-infinidat has quit IRC | 20:53 | |
*** chrisyang_0660 has quit IRC | 20:53 | |
*** chrisyang_0660_ is now known as chrisyang_0660 | 20:53 | |
*** knikolla_ is now known as knikolla | 20:53 | |
*** tpsilva_ is now known as tpsilva | 20:53 | |
*** fmccrthy_ is now known as fmccrthy | 20:53 | |
*** guyr-infinidat_ is now known as guyr-infinidat | 20:53 | |
*** simondodsley_ is now known as simondodsley | 20:53 | |
*** xdfil_ is now known as xdfil | 20:53 | |
*** mvk has joined #openstack-cinder | 20:54 | |
*** storshoo___ has quit IRC | 20:55 | |
*** johnthetubaguy_ has quit IRC | 20:56 | |
*** wN_ has joined #openstack-cinder | 20:57 | |
*** johnthetubaguy has joined #openstack-cinder | 20:58 | |
*** a_storshoo has joined #openstack-cinder | 20:58 | |
_alastor_ | clarkb: The only place I can see where we can insert the fix (other than get_api_version) is get_proxy_class in OpenStackServiceDescription | 21:00 |
_alastor_ | clarkb: Because that's the method that needs to return the correct proxy and we can intercept the call to get_api_version based on self.service_type | 21:01 |
*** abishop has quit IRC | 21:10 | |
*** dustins has quit IRC | 21:13 | |
*** edmondsw has quit IRC | 21:15 | |
*** edmondsw has joined #openstack-cinder | 21:15 | |
*** edmondsw has quit IRC | 21:20 | |
*** dpawlik has joined #openstack-cinder | 21:21 | |
*** evin has quit IRC | 21:22 | |
*** dpawlik has quit IRC | 21:26 | |
_alastor_ | jungleboyj smcginnis: should we update the openrc in devstack to use APIv3? | 21:29 |
_alastor_ | It's a oneline change from what I can tell | 21:29 |
_alastor_ | jungleboyj smcginnis: https://github.com/openstack-dev/devstack/blob/master/openrc#L111 | 21:30 |
*** moshele has joined #openstack-cinder | 21:34 | |
clarkb | _alastor_: I guess there is already precedent for that in get_service_type | 21:35 |
clarkb | _alastor_: I would make something that works then mordred and others can weigh in better than I can | 21:36 |
jungleboyj | _alastor_: it isn't set that way already? | 21:36 |
_alastor_ | jungleboyj: Nope, it defaults to 2 unless you set CINDER_VERSION explicitly | 21:36 |
smcginnis | I've been trying to get tempest to switch over to v3 for a long time now. | 21:37 |
smcginnis | We might need that done first, but I suppose we could switch devstack and see. | 21:37 |
smcginnis | I would like it all switched over ideally. | 21:37 |
_alastor_ | clarkb: https://review.openstack.org/#/c/566740/ | 21:37 |
clarkb | _alastor_: cool | 21:38 |
_alastor_ | jungleboyj: Devstack sets up v3 API cinder, it's just the openrc that sets the version used to 2 | 21:39 |
_alastor_ | jungleboyj: https://review.openstack.org/#/c/566747/ | 21:46 |
*** e0ne_ has quit IRC | 21:50 | |
*** throwsb1 has quit IRC | 21:51 | |
jungleboyj | smcginnis: ++ Given that we have deprecated v2 we should get everything moved. | 21:55 |
*** dave-mccowan has quit IRC | 22:01 | |
jungleboyj | _alastor_: Thanks for the patch. | 22:01 |
*** smcginnis[m] has joined #openstack-cinder | 22:03 | |
* hemna_ just discovered the awesomeness that is lnav.... | 22:08 | |
hemna_ | that is all | 22:08 |
*** moshele has quit IRC | 22:13 | |
*** felipemonteiro__ has quit IRC | 22:24 | |
*** rcernin has joined #openstack-cinder | 22:25 | |
*** ganso has quit IRC | 22:25 | |
*** dave-mccowan has joined #openstack-cinder | 22:55 | |
*** _alastor_ has quit IRC | 22:55 | |
-openstackstatus- NOTICE: Any devstack job failure due to rsync errors related to tripleo-incubator can safely be rechecked now | 22:56 | |
*** _alastor_ has joined #openstack-cinder | 23:18 | |
*** cloudnull is now known as cloudkiller | 23:20 | |
*** cloudkiller is now known as cloudnull | 23:21 | |
*** r-daneel has quit IRC | 23:28 | |
*** pooja_jadhav has quit IRC | 23:28 | |
*** pooja_jadhav has joined #openstack-cinder | 23:28 | |
*** Nel1x has joined #openstack-cinder | 23:41 | |
*** stakeda has joined #openstack-cinder | 23:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!