| openstackgerrit | Lucio Seki proposed openstack/cinder stable/pike: NetApp ONTAP: Fix driver force detach operations https://review.openstack.org/592769 | 00:23 |
|---|---|---|
| *** brinzhang has joined #openstack-cinder | 00:26 | |
| openstackgerrit | lvxianguo proposed openstack/cinder-tempest-plugin master: update the hacking url to new https://review.openstack.org/540238 | 00:31 |
| *** nicolasbock has quit IRC | 00:36 | |
| *** zhaochao has joined #openstack-cinder | 01:16 | |
| openstackgerrit | Keith Berger proposed openstack/cinder stable/ocata: HPE Lefthand: fix volume manage operation https://review.openstack.org/592777 | 01:24 |
| *** r-daneel has quit IRC | 01:35 | |
| *** ianychoi has joined #openstack-cinder | 01:47 | |
| *** gcb_ has joined #openstack-cinder | 02:19 | |
| *** Nel1x has joined #openstack-cinder | 02:49 | |
| *** erlon has quit IRC | 02:54 | |
| whoami-rajat | jungleboyj: Sure, Thanks for the effort :) | 03:10 |
| *** Nel1x has quit IRC | 03:11 | |
| *** gkadam_ has joined #openstack-cinder | 03:24 | |
| *** zhaochao has quit IRC | 03:37 | |
| *** zhaochao has joined #openstack-cinder | 03:37 | |
| *** vivsoni_ has quit IRC | 03:59 | |
| *** vivsoni has joined #openstack-cinder | 04:25 | |
| *** gkadam_ has quit IRC | 04:30 | |
| *** abhishekk has joined #openstack-cinder | 04:49 | |
| *** e0ne has joined #openstack-cinder | 05:20 | |
| *** josecastroleon has quit IRC | 05:50 | |
| *** josecastroleon has joined #openstack-cinder | 05:51 | |
| *** Tahvok has quit IRC | 06:06 | |
| *** Tahvok has joined #openstack-cinder | 06:11 | |
| *** e0ne has quit IRC | 06:44 | |
| whoami-rajat | jungleboyj smcginnis : https://review.openstack.org/#/c/589951/ | 06:51 |
| whoami-rajat | The patch has passed Nimble CI tests | 06:51 |
| *** pcaruana has joined #openstack-cinder | 06:54 | |
| *** alexchadin has joined #openstack-cinder | 06:54 | |
| *** rcernin has quit IRC | 06:55 | |
| *** abhishekk has quit IRC | 06:56 | |
| *** dpawlik has joined #openstack-cinder | 07:08 | |
| *** dpawlik has quit IRC | 07:13 | |
| *** dpawlik has joined #openstack-cinder | 07:14 | |
| *** cz2 has left #openstack-cinder | 07:24 | |
| *** josecastroleon has quit IRC | 07:26 | |
| *** rha has joined #openstack-cinder | 07:41 | |
| *** zhenguo has joined #openstack-cinder | 07:50 | |
| *** e0ne has joined #openstack-cinder | 07:59 | |
| *** mvkr has quit IRC | 08:08 | |
| *** josecastroleon has joined #openstack-cinder | 08:12 | |
| openstackgerrit | yenai proposed openstack/os-brick master: Modify the verification in RBDConnector https://review.openstack.org/592925 | 08:16 |
| *** gcb_ has quit IRC | 08:20 | |
| *** e0ne has quit IRC | 08:37 | |
| *** mvkr has joined #openstack-cinder | 08:55 | |
| *** alexchadin has quit IRC | 09:07 | |
| *** alexchadin has joined #openstack-cinder | 09:09 | |
| openstackgerrit | Merged openstack/cinder stable/queens: VMAX Queens driver - incorrect condition for an empty list. https://review.openstack.org/592065 | 09:37 |
| openstackgerrit | yenai proposed openstack/os-brick master: Add staticmethod decorator in InitiatorConnector https://review.openstack.org/592944 | 09:43 |
| *** zhongjun2 has joined #openstack-cinder | 10:00 | |
| *** zhenguo has quit IRC | 10:00 | |
| *** josecastroleon has quit IRC | 10:06 | |
| *** pvc has joined #openstack-cinder | 10:08 | |
| *** e0ne has joined #openstack-cinder | 10:09 | |
| *** alexchadin has quit IRC | 10:15 | |
| *** ociuhandu has joined #openstack-cinder | 10:32 | |
| *** ociuhandu has quit IRC | 10:34 | |
| *** nicolasbock has joined #openstack-cinder | 10:35 | |
| *** alexchadin has joined #openstack-cinder | 10:45 | |
| *** luizbag has joined #openstack-cinder | 10:50 | |
| *** ganso has joined #openstack-cinder | 10:50 | |
| *** alexchadin has quit IRC | 10:51 | |
| *** dklyle has quit IRC | 10:55 | |
| *** david-lyle has joined #openstack-cinder | 10:55 | |
| *** josecastroleon has joined #openstack-cinder | 11:22 | |
| *** alexchadin has joined #openstack-cinder | 11:24 | |
| *** alexchadin has quit IRC | 11:29 | |
| evrardjp | mnaser: cruft is a gift that keeps on giving. I worked a whole cycle (q) on removing many, I have the impression my list now larger than when I started. | 11:32 |
| *** brinzhang has quit IRC | 11:36 | |
| *** alexchadin has joined #openstack-cinder | 11:38 | |
| *** tpsilva has joined #openstack-cinder | 11:45 | |
| *** erlon has joined #openstack-cinder | 11:53 | |
| *** zhongjun2 has quit IRC | 12:10 | |
| *** dpawlik has quit IRC | 12:18 | |
| *** eharney has joined #openstack-cinder | 12:22 | |
| *** dpawlik has joined #openstack-cinder | 12:25 | |
| *** mchlumsky has joined #openstack-cinder | 12:29 | |
| *** dpawlik has quit IRC | 12:29 | |
| *** josecastroleon has quit IRC | 12:52 | |
| *** alexchadin has quit IRC | 12:52 | |
| *** TheJulia is now known as needssleep | 12:55 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder stable/queens: Replace os.makedirs to avoid process race https://review.openstack.org/593044 | 12:57 |
| *** dpawlik has joined #openstack-cinder | 12:58 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder stable/queens: Fix cinder-volume uses latest req-id for all log calls https://review.openstack.org/593046 | 13:02 |
| *** dustins has joined #openstack-cinder | 13:02 | |
| openstackgerrit | Eric Harney proposed openstack/cinder master: Add cinder-tempest-plugin to LIO job https://review.openstack.org/568873 | 13:07 |
| smcginnis | eharney: Thanks for that ^ :) | 13:07 |
| * eharney crosses fingers | 13:08 | |
| openstackgerrit | Keith Berger proposed openstack/cinder stable/ocata: HPE Lefthand: fix volume manage operation https://review.openstack.org/592777 | 13:11 |
| *** pvc has quit IRC | 13:33 | |
| *** imacdonn has quit IRC | 13:42 | |
| *** imacdonn has joined #openstack-cinder | 13:42 | |
| *** wN has joined #openstack-cinder | 13:49 | |
| *** erlon has quit IRC | 13:49 | |
| *** dansmith is now known as steelydan | 13:58 | |
| *** steelydan is now known as SteelyDan | 13:58 | |
| *** cmart has joined #openstack-cinder | 14:02 | |
| *** hoonetorg has quit IRC | 14:02 | |
| *** hoonetorg has joined #openstack-cinder | 14:03 | |
| *** hoonetorg has quit IRC | 14:09 | |
| *** josecastroleon has joined #openstack-cinder | 14:21 | |
| ganso | smcginnis, eharney, jungleboyj: Hello! This backport to queens requires just one more +2 and +W https://review.openstack.org/#/c/592634/ Could one of you please take a look? Thanks in advance! =) | 14:24 |
| eharney | ganso: yes, looks good, thanks | 14:27 |
| *** hoonetorg has joined #openstack-cinder | 14:33 | |
| *** r-daneel has joined #openstack-cinder | 14:44 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Add api-ref for mv 3.55 volume transfer https://review.openstack.org/588666 | 14:53 |
| openstackgerrit | Keith Berger proposed openstack/cinder stable/ocata: HPE Lefthand: fix volume manage operation https://review.openstack.org/592777 | 14:59 |
| *** r-daneel has quit IRC | 15:00 | |
| *** cburgess has quit IRC | 15:02 | |
| *** dpawlik has quit IRC | 15:02 | |
| *** cburgess has joined #openstack-cinder | 15:03 | |
| *** josecastroleon has quit IRC | 15:06 | |
| openstackgerrit | Eric Harney proposed openstack/cinder master: Add cinder-tempest-plugin to LIO job https://review.openstack.org/568873 | 15:07 |
| *** cburgess has quit IRC | 15:08 | |
| *** cburgess has joined #openstack-cinder | 15:09 | |
| *** markstur has joined #openstack-cinder | 15:12 | |
| *** markstur has quit IRC | 15:17 | |
| *** markstur has joined #openstack-cinder | 15:20 | |
| *** erlon has joined #openstack-cinder | 15:23 | |
| *** markstur has quit IRC | 15:25 | |
| *** tswanson has quit IRC | 15:28 | |
| *** e0ne has quit IRC | 15:59 | |
| *** r-daneel has joined #openstack-cinder | 16:04 | |
| *** strigazi has quit IRC | 16:05 | |
| *** strigazi has joined #openstack-cinder | 16:06 | |
| *** strigazi has quit IRC | 16:06 | |
| *** strigazi has joined #openstack-cinder | 16:07 | |
| openstackgerrit | Merged openstack/cinder stable/queens: NetApp ONTAP: Fix driver force detach operations https://review.openstack.org/592634 | 16:09 |
| *** strigazi has quit IRC | 16:13 | |
| *** strigazi has joined #openstack-cinder | 16:14 | |
| *** tswanson has joined #openstack-cinder | 16:32 | |
| *** erlon has quit IRC | 16:34 | |
| *** pas-ha has quit IRC | 16:41 | |
| *** zhaochao has quit IRC | 16:41 | |
| *** pas-ha has joined #openstack-cinder | 16:42 | |
| *** dpawlik has joined #openstack-cinder | 17:36 | |
| *** dpawlik has quit IRC | 17:40 | |
| *** e0ne has joined #openstack-cinder | 17:56 | |
| *** hongbin has joined #openstack-cinder | 18:07 | |
| *** r-daneel_ has joined #openstack-cinder | 18:07 | |
| hongbin | smcginnis: hi sean | 18:07 |
| *** r-daneel has quit IRC | 18:08 | |
| *** r-daneel_ is now known as r-daneel | 18:08 | |
| smcginnis | Hey hongbin. You had a question? | 18:08 |
| hongbin | smcginnis: a question, if i want to multi-attach a cinder volume to two containers that are in the same host | 18:09 |
| hongbin | smcginnis: what is the best practice to do it, i am reading: https://docs.openstack.org/cinder/latest/contributor/attach_detach_conventions.html , and wonder if we need to do the three steps in each attach/detach ? | 18:10 |
| smcginnis | hongbin: Do you currently use Cinder to track attachments? Or do you just attach to a host and then whether it is used with a container or not, Cinder doesn't get involved? | 18:11 |
| smcginnis | If jgriffith is around, I think he's done more container work and might have some good insights. | 18:11 |
| hongbin | smcginnis: in before (without multiattach support), we are attaching the volume to the container host | 18:12 |
| hongbin | smcginnis: after the volume is attached to a host, we mount the volume to a path and bind-mount it to the container | 18:13 |
| smcginnis | hongbin: The important part is that cinder knows when to detach the volume or not. | 18:15 |
| smcginnis | hongbin: So as long as disconnecting it from a second container doesn't trigger a call to cinder to remove the whole attachment, then it's fine just attaching once. | 18:16 |
| hongbin | smcginnis: i see | 18:17 |
| smcginnis | hongbin: If you want to ensure Cinder knows about both attachments, then those calls need to be made so when Cinder is called for one, but there are others still there, we don't remove access to the volume from the container host. | 18:17 |
| smcginnis | hongbin: Looking at the doc you referenced, that isn't anything specific to mutliattach. | 18:17 |
| smcginnis | hongbin: So yes, those three steps need to be done. | 18:18 |
| hongbin | smcginnis: ok, i believe we are using the volume to track the container uuid of each attach | 18:18 |
| hongbin | smcginnis: in particular, that is after this patch: https://review.openstack.org/#/c/590108/3 | 18:18 |
| openstackgerrit | Eric Harney proposed openstack/cinder master: Add cinder-tempest-plugin to LIO job https://review.openstack.org/568873 | 18:20 |
| hongbin | smcginnis: so if we do the three steps (reserve volume, initialize_connection, os_brick.connect_volume, attach) in the same host, i assume cinder will handle that properly without a problem? | 18:22 |
| smcginnis | hongbin: I believe the change in that patch would be good. | 18:22 |
| smcginnis | hongbin: Yep, that's how Nova does it today. | 18:22 |
| hongbin | smcginnis: then, my concern is the detach | 18:23 |
| hongbin | smcginnis: if we do the three steps for detaching the volume multiple times, cinder will terminate the connection in the last detach, is it correct? | 18:24 |
| hongbin | smcginnis: the context is this patch: https://review.openstack.org/#/c/590677/ | 18:27 |
| hongbin | and i am trying to review it | 18:27 |
| openstackgerrit | Merged openstack/cinder master: Add api-ref for mv 3.55 volume transfer https://review.openstack.org/588666 | 18:30 |
| smcginnis | hongbin: That's correct. As long as there are other attachments, the host will still have access to the volume. | 18:32 |
| *** eharney has quit IRC | 18:33 | |
| hongbin | smcginnis: i see | 18:34 |
| hongbin | smcginnis: but weikeyou said this "If a volume is attached to two container that is on the same node, they share device path and LUN group in Disk Array. In this case, "_disconnect_volume"(clean up device path) and "terminate_connection"(remove LUN group in Disk Array) should not be called, and just "cinder_api.detach"(clean up db in Cinder) should | 18:34 |
| hongbin | be called." | 18:34 |
| hongbin | smcginnis: based on what you said, i guess cinder/os-brick will handle the scenario he described properly? just want to confirm | 18:37 |
| patrickeast | hongbin: you should use the cinders attach/detach API's to basically refcount the volume attachment to the compute node and only cleanup the initiator side on the last detach | 18:38 |
| patrickeast | don't call os-brick to terminate the connection until you are really ready for the LUN to go away | 18:38 |
| patrickeast | on the compute node* | 18:38 |
| hongbin | patrickeast: i see | 18:38 |
| patrickeast | it should be basically the same workflow that nova does for like libvirt and cinder attachments | 18:39 |
| smcginnis | There might be some good examples if you can take a look at the nova side of things. | 18:40 |
| hongbin | patrickeast: i see | 18:40 |
| *** josecastroleon has joined #openstack-cinder | 18:40 | |
| hongbin | smcginnis: ack, that is a good idea | 18:40 |
| hongbin | patrickeast: smcginnis thanks for your suggestions | 18:41 |
| smcginnis | hongbin: No problem - good luck! | 18:41 |
| hongbin | :) | 18:41 |
| *** r-daneel_ has joined #openstack-cinder | 18:43 | |
| *** r-daneel has quit IRC | 18:44 | |
| *** r-daneel_ is now known as r-daneel | 18:44 | |
| *** r-daneel has quit IRC | 18:46 | |
| *** josecastroleon has quit IRC | 18:49 | |
| jgriffith | hongbin: smcginnis sounds like you all got it figured out | 18:55 |
| smcginnis | jgriffith: Hopefully | 18:55 |
| jgriffith | But in short, using the old flow on a a volume attached to multiple containers on the same node will be a problem on detach for you | 18:55 |
| jgriffith | Gophercloud does do it's best to use the old admin-meta stuff to try and pretend to ref count and such, but as patrickeast I'd just use the new attach api's | 18:56 |
| hongbin | jgriffith: ack, thanks for the suggestion | 18:57 |
| hongbin | i will mention that on reviewing the patch | 18:58 |
| *** luizbag has quit IRC | 19:01 | |
| *** r-daneel has joined #openstack-cinder | 19:15 | |
| *** tomtom001 has quit IRC | 19:26 | |
| *** woojay has quit IRC | 19:28 | |
| *** erlon has joined #openstack-cinder | 19:47 | |
| *** nicolasbock has quit IRC | 19:50 | |
| KeithMnemonic | smcginnis: one before the weekend? https://review.openstack.org/#/c/592777 | 19:51 |
| *** eharney has joined #openstack-cinder | 19:51 | |
| *** nicolasbock has joined #openstack-cinder | 19:55 | |
| smcginnis | KeithMnemonic: Done | 19:58 |
| KeithMnemonic | thanks! | 20:00 |
| openstackgerrit | Merged openstack/cinder master: ScaleIO: Disable volume creation without padding https://review.openstack.org/592001 | 20:18 |
| *** e0ne has quit IRC | 20:35 | |
| *** erlon has quit IRC | 20:41 | |
| *** erlon has joined #openstack-cinder | 20:56 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder stable/rocky: ScaleIO: Disable volume creation without padding https://review.openstack.org/593188 | 21:04 |
| openstackgerrit | Sean McGinnis proposed openstack/cinder stable/queens: Handling type's multiattach extra specs in API task flow https://review.openstack.org/593191 | 21:10 |
| *** masayukig has quit IRC | 21:10 | |
| *** KeithMnemonic has quit IRC | 21:11 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Remove cinder-tox-compliance job https://review.openstack.org/593192 | 21:14 |
| openstackgerrit | Sean McGinnis proposed openstack/cinder stable/queens: Stop unnecessarily querying storage for stats https://review.openstack.org/593193 | 21:17 |
| *** dustins has quit IRC | 21:18 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder stable/queens: Update delete group snapshot API exception handling https://review.openstack.org/593201 | 21:30 |
| openstackgerrit | Sean McGinnis proposed openstack/cinder stable/queens: Add user messages for extend volume operation https://review.openstack.org/593202 | 21:33 |
| *** erlon has quit IRC | 21:42 | |
| openstackgerrit | Merged openstack/cinder stable/ocata: HPE Lefthand: fix volume manage operation https://review.openstack.org/592777 | 21:45 |
| *** nicolasbock has quit IRC | 21:59 | |
| *** cmart has quit IRC | 22:17 | |
| *** ganso has quit IRC | 22:19 | |
| *** tpsilva has quit IRC | 22:50 | |
| *** r-daneel has quit IRC | 23:01 | |
| *** hongbin has quit IRC | 23:08 | |
| *** gnufied has quit IRC | 23:55 | |
| *** gnufied has joined #openstack-cinder | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!