*** brinzhang has joined #openstack-cinder | 00:18 | |
*** spartakos has quit IRC | 00:30 | |
*** rcernin has quit IRC | 00:50 | |
*** rcernin has joined #openstack-cinder | 00:51 | |
*** erlon has quit IRC | 00:57 | |
*** tonyb has quit IRC | 01:07 | |
*** tonyb has joined #openstack-cinder | 01:09 | |
*** erlon has joined #openstack-cinder | 01:11 | |
*** dominix has joined #openstack-cinder | 01:15 | |
*** erlon has quit IRC | 01:17 | |
openstackgerrit | wanghao proposed openstack/cinder master: Support to query volume filter by changes since/before https://review.openstack.org/352688 | 01:19 |
---|---|---|
*** fnordahl has quit IRC | 01:19 | |
*** fnordahl has joined #openstack-cinder | 01:20 | |
*** zhaochao has joined #openstack-cinder | 01:26 | |
*** tonyb has quit IRC | 01:27 | |
*** tonyb has joined #openstack-cinder | 01:31 | |
*** lbragstad has quit IRC | 01:43 | |
*** lbragstad has joined #openstack-cinder | 01:45 | |
*** sapd1_ has joined #openstack-cinder | 02:03 | |
*** sapd1 has quit IRC | 02:07 | |
*** _hemna has quit IRC | 02:08 | |
*** lbragstad has quit IRC | 02:09 | |
*** sapd1_ has quit IRC | 02:09 | |
*** spartakos has joined #openstack-cinder | 02:09 | |
*** _hemna has joined #openstack-cinder | 02:10 | |
*** sapd1 has joined #openstack-cinder | 02:13 | |
*** nicolasbock has quit IRC | 02:18 | |
dominix | hi there | 02:32 |
dominix | I am wondering if Cinder has some feature able to move block from one kind of disk to another depending if its read often or not | 02:33 |
dominix | like multi tier dispatch | 02:33 |
dominix | moving block from SSD type to SAS and then SATA if less often accessed | 02:34 |
dominix | or move these block from SATA to SAS to SSD if more often accessed. | 02:34 |
dominix | how will you name this feature ? | 02:35 |
*** psachin has joined #openstack-cinder | 02:45 | |
openstackgerrit | wang yong proposed openstack/cinder master: Cinder volume driver for Inspur AS13000 series https://review.openstack.org/562977 | 02:58 |
*** gcb_ has quit IRC | 03:14 | |
*** gcb_ has joined #openstack-cinder | 03:17 | |
*** gkadam has joined #openstack-cinder | 03:31 | |
*** spartakos has quit IRC | 03:35 | |
*** nwonknu has quit IRC | 03:48 | |
*** nwonknu has joined #openstack-cinder | 04:00 | |
*** markvoelker has joined #openstack-cinder | 04:06 | |
*** brinzhang has quit IRC | 04:10 | |
*** markvoelker has quit IRC | 04:11 | |
*** brinzhang has joined #openstack-cinder | 04:11 | |
openstackgerrit | Boxiang Zhu proposed openstack/cinder master: Fix wrong filter of backups in db api https://review.openstack.org/600329 | 04:17 |
*** gcb_ has quit IRC | 04:17 | |
whoami-rajat | smcginnis: ok, thought the same, Thanks | 04:24 |
openstackgerrit | Raunak Kumar proposed openstack/cinder master: nimble storage: retype support https://review.openstack.org/600134 | 04:35 |
*** hoangcx has quit IRC | 04:40 | |
*** hoangcx has joined #openstack-cinder | 04:40 | |
*** stakeda has joined #openstack-cinder | 04:42 | |
*** Bhujay has joined #openstack-cinder | 04:45 | |
*** gcb_ has joined #openstack-cinder | 04:53 | |
*** markvoelker has joined #openstack-cinder | 05:07 | |
*** gkadam_ has joined #openstack-cinder | 05:41 | |
*** gkadam has quit IRC | 05:43 | |
*** gkadam__ has joined #openstack-cinder | 05:45 | |
*** gkadam_ has quit IRC | 05:47 | |
*** gcb_ has quit IRC | 05:53 | |
*** Bhujay has quit IRC | 06:07 | |
*** gcb_ has joined #openstack-cinder | 06:17 | |
*** Bhujay has joined #openstack-cinder | 06:18 | |
*** Luzi has joined #openstack-cinder | 06:18 | |
*** pcaruana has joined #openstack-cinder | 06:25 | |
*** dominix has quit IRC | 06:35 | |
*** markvoelker has quit IRC | 06:45 | |
*** alexchadin has joined #openstack-cinder | 06:54 | |
*** lpetrut has joined #openstack-cinder | 06:57 | |
*** e0ne has joined #openstack-cinder | 06:58 | |
*** rcernin has quit IRC | 07:00 | |
*** Emine has joined #openstack-cinder | 07:06 | |
*** alexchadin has quit IRC | 07:10 | |
*** alexchadin has joined #openstack-cinder | 07:27 | |
*** hoonetorg has quit IRC | 07:34 | |
*** pcaruana has quit IRC | 07:36 | |
*** markvoelker has joined #openstack-cinder | 07:43 | |
*** hoonetorg has joined #openstack-cinder | 07:47 | |
*** pcaruana has joined #openstack-cinder | 07:48 | |
openstackgerrit | Merged openstack/cinder master: fix misspelling of 'configuration' https://review.openstack.org/599302 | 08:00 |
*** gcb_ has quit IRC | 08:10 | |
*** david-lyle has quit IRC | 08:14 | |
*** dklyle has joined #openstack-cinder | 08:15 | |
*** kaisers has quit IRC | 08:19 | |
*** hoangcx has quit IRC | 08:19 | |
*** hoangcx has joined #openstack-cinder | 08:19 | |
*** kaisers has joined #openstack-cinder | 08:25 | |
*** alexchadin has quit IRC | 08:58 | |
*** alexchadin has joined #openstack-cinder | 09:14 | |
*** erlon has joined #openstack-cinder | 09:16 | |
*** alexchadin has quit IRC | 09:24 | |
*** erlon has quit IRC | 09:32 | |
whoami-rajat | Hi cores, the cinder api-version command is failing, please review the patch addressing it https://review.openstack.org/#/c/589191/ | 09:42 |
*** erlon has joined #openstack-cinder | 10:10 | |
*** luizbag has joined #openstack-cinder | 10:15 | |
*** e0ne has quit IRC | 10:15 | |
*** erlon has quit IRC | 10:20 | |
*** erlon has joined #openstack-cinder | 10:26 | |
*** nicolasbock has joined #openstack-cinder | 10:31 | |
*** stakeda has quit IRC | 10:31 | |
*** e0ne has joined #openstack-cinder | 10:39 | |
*** dave-mccowan has joined #openstack-cinder | 10:46 | |
*** ganso has joined #openstack-cinder | 10:49 | |
erlon | geguileo, hey, can you re+2 the CG patch? https://review.openstack.org/#/c/598193/ | 10:56 |
erlon | our internal submit system messed up the fix | 10:56 |
erlon | should be fine now | 10:56 |
geguileo | erlon: lol | 10:58 |
geguileo | done | 10:58 |
erlon | geguileo, thanks! | 11:00 |
geguileo | np | 11:00 |
*** dcdamien has quit IRC | 11:00 | |
erlon | need to get this merge and backported asap, it blocking our RH Certification which will dealine in late this month o.O | 11:01 |
* erlon freaks! | 11:01 | |
*** dcdamien has joined #openstack-cinder | 11:03 | |
*** brinzhang has quit IRC | 11:07 | |
*** brinzhang has joined #openstack-cinder | 11:08 | |
*** erlon has quit IRC | 11:15 | |
*** abishop has joined #openstack-cinder | 11:21 | |
*** abishop has quit IRC | 11:21 | |
*** Emine has quit IRC | 11:23 | |
*** Emine has joined #openstack-cinder | 11:25 | |
*** erlon has joined #openstack-cinder | 11:25 | |
*** eharney has quit IRC | 11:39 | |
*** psachin has quit IRC | 11:51 | |
*** yumiriam has quit IRC | 11:53 | |
*** abishop has joined #openstack-cinder | 11:54 | |
*** alexchadin has joined #openstack-cinder | 12:11 | |
*** markvoelker has quit IRC | 12:22 | |
*** eharney has joined #openstack-cinder | 12:38 | |
*** alexchadin has quit IRC | 12:41 | |
*** e0ne has quit IRC | 12:41 | |
*** alexchadin has joined #openstack-cinder | 12:49 | |
*** lpetrut has quit IRC | 12:54 | |
*** lbragstad has joined #openstack-cinder | 12:54 | |
*** yumiriam has joined #openstack-cinder | 12:55 | |
*** e0ne has joined #openstack-cinder | 12:59 | |
*** mriedem has joined #openstack-cinder | 13:08 | |
*** lbragstad has quit IRC | 13:09 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Tintri: Inherit tests from BaseDriverTestCase https://review.openstack.org/600442 | 13:14 |
*** lbragstad has joined #openstack-cinder | 13:15 | |
*** brinzhang has quit IRC | 13:15 | |
*** mchlumsky has joined #openstack-cinder | 13:32 | |
whoami-rajat | Hi e0ne , jungleboyj , the patch has passed Nible CI tests and the logs are available now, https://review.openstack.org/#/c/589951/ , Please review for W+1 | 13:42 |
*** eharney has quit IRC | 13:43 | |
e0ne | whoami-rajat: +2'ed | 13:47 |
*** finixlei has joined #openstack-cinder | 13:56 | |
*** eharney has joined #openstack-cinder | 13:58 | |
erlon | eharney, smcginnis, someone else in the channel was mentioning a failure on cinder_tempest consistency group tests | 13:59 |
erlon | this fixes it : https://review.openstack.org/#/c/599720/ | 13:59 |
openstackgerrit | Chuck Short proposed openstack/cinder master: Simplify running pylint https://review.openstack.org/597132 | 14:00 |
erlon | but the lvm-lio is failing | 14:00 |
eharney | erlon: great, can we tie this to https://bugs.launchpad.net/cinder/+bug/1789944 ? | 14:00 |
openstack | Launchpad bug 1789944 in Cinder "cinder-tempest-plugin CG tests are broken" [Undecided,New] | 14:00 |
erlon | eharney, yep good idea | 14:02 |
*** finixlei has quit IRC | 14:06 | |
*** finixlei has joined #openstack-cinder | 14:06 | |
erlon | eharney, any idea why zuul is failing? who is the maintainer? | 14:07 |
eharney | erlon: lio-barbican job is failing regularly due to a bug in Nova that's being fixed currently | 14:07 |
eharney | erlon: i'm the maintainer of that job | 14:07 |
erlon | eharney, hmm, would adding a Depends-on to the patch make it pass? | 14:09 |
*** finixlei has quit IRC | 14:18 | |
*** finixlei has joined #openstack-cinder | 14:18 | |
eharney | erlon: the bug is https://bugs.launchpad.net/nova/+bug/1789484 -- looks like it's landed in Nova master now | 14:24 |
openstack | Launchpad bug 1789484 in OpenStack Compute (nova) rocky "n-cpu fails init on timeout calling n-cond-cell1" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 14:24 |
*** finixlei has quit IRC | 14:24 | |
erlon | eharney, it landed on Aug 30, so, may be theres' something else causing the failure | 14:27 |
mriedem | which branch is failing? | 14:27 |
mriedem | master is fixed but rocky is not yet | 14:27 |
mriedem | https://review.openstack.org/#/c/599064/ | 14:27 |
*** finixlei has joined #openstack-cinder | 14:28 | |
eharney | it's failing due to a different long standing issue with backup in that job | 14:29 |
eharney | not that bug above | 14:29 |
*** Bhujay has quit IRC | 14:34 | |
*** Luzi has quit IRC | 14:47 | |
*** itlinux has quit IRC | 14:56 | |
*** r-daneel has quit IRC | 15:17 | |
*** spartakos has joined #openstack-cinder | 15:25 | |
*** alexchadin has quit IRC | 15:38 | |
*** e0ne has quit IRC | 15:42 | |
*** pcaruana has quit IRC | 15:42 | |
*** r-daneel has joined #openstack-cinder | 15:44 | |
*** r-daneel has quit IRC | 15:45 | |
*** finixlei has quit IRC | 15:50 | |
*** itlinux has joined #openstack-cinder | 15:54 | |
*** pcaruana has joined #openstack-cinder | 16:01 | |
*** itlinux_ has joined #openstack-cinder | 16:08 | |
*** itlinux has quit IRC | 16:12 | |
jungleboyj | smcginnis: eharney geguileo erlon ganso I have created a Doodle Poll for the Placement Discussion: | 16:18 |
jungleboyj | https://doodle.com/poll/4twwhy46bxerrthx | 16:18 |
jungleboyj | Sending e-mail to the ML now. | 16:18 |
*** mriedem is now known as mriedem_away | 16:19 | |
* smcginnis needs to figure out his schedule | 16:19 | |
jungleboyj | smcginnis: Yeah, I am starting to see that as well. | 16:21 |
smcginnis | Right now it's just a big nebulous bunch of conflicting things. | 16:22 |
*** zhaochao has quit IRC | 16:22 | |
*** avishay has joined #openstack-cinder | 16:23 | |
jungleboyj | smcginnis: Stop being so popular. | 16:23 |
smcginnis | https://media.giphy.com/media/3o7aTHbH39h8xYePza/giphy.gif | 16:24 |
avishay | Hi all. I'm sometimes seeing that create_volume requests take several minutes to reach cinder-volume. I don't know where it's getting stuck. Running Ocata. Has anyone seen anything like this before? | 16:25 |
jungleboyj | Oh, much needed laugh. Thank you. | 16:25 |
jungleboyj | avishay: !?! There is a name from the past! | 16:25 |
jungleboyj | avishay: I have not seen or heard of anything like that happening? | 16:25 |
avishay | Yes, it is I :) | 16:26 |
*** avishay has quit IRC | 16:31 | |
*** avishay has joined #openstack-cinder | 16:32 | |
avishay | Sorry, got disconnected | 16:32 |
avishay | Any tips on how to find where/why the message is getting stuck would also be most appreciated. | 16:32 |
*** itlinux_ has quit IRC | 16:33 | |
jungleboyj | Are you seeing anything weird from RabbitMQ? | 16:34 |
avishay | nothing in the logs | 16:35 |
jungleboyj | Hmmm. Can you tell if the delay is in the API or scheduler? | 16:37 |
* jungleboyj just dug a camera and the Yeti out of the moving boxes and put them by my computer bag so I don't forget them this time. | 16:37 | |
jungleboyj | smcginnis: Do you have a webcam with a tripod mount? | 16:38 |
avishay | unfortunately there are no logs in scheduler in the create volume flow, so I don't know when it gets there | 16:38 |
smcginnis | jungleboyj: Nope | 16:38 |
avishay | BTW is the lack of logging there on purpose? | 16:38 |
jungleboyj | smcginnis: Bummer. Ok. I will have to MacGyver something together. | 16:38 |
jungleboyj | avishay: No, there should be logging in the scheduler. Could you have something weird happening with multiple schedulers running? | 16:39 |
avishay | No, check the code... No logs | 16:40 |
avishay | Be back in about an hour, need to drive | 16:41 |
whoami-rajat | Hi jungleboyj , smcginnis , tommylikehu , can you please review these patches. | 16:52 |
whoami-rajat | https://review.openstack.org/#/c/599642/ | 16:52 |
whoami-rajat | https://review.openstack.org/#/c/597377/ | 16:52 |
whoami-rajat | https://review.openstack.org/#/c/599686/ | 16:52 |
whoami-rajat | https://review.openstack.org/#/c/597572/ | 16:52 |
whoami-rajat | Thanks. | 16:52 |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Ensure VNX unit tests don't sleep https://review.openstack.org/600481 | 16:55 |
*** itlinux has joined #openstack-cinder | 17:03 | |
*** imacdonn has quit IRC | 17:05 | |
*** imacdonn has joined #openstack-cinder | 17:05 | |
*** penick has joined #openstack-cinder | 17:06 | |
*** gkadam__ has quit IRC | 17:09 | |
*** spartakos has quit IRC | 17:11 | |
*** r-daneel has joined #openstack-cinder | 17:11 | |
*** ChanServ sets mode: -rf | 17:18 | |
*** swamireddy has joined #openstack-cinder | 17:18 | |
*** netapp has joined #openstack-cinder | 17:18 | |
*** psachin has joined #openstack-cinder | 17:18 | |
*** raunak12 has joined #openstack-cinder | 17:24 | |
*** psachin has quit IRC | 17:26 | |
*** pcaruana has quit IRC | 17:27 | |
*** e0ne has joined #openstack-cinder | 17:34 | |
*** spartakos has joined #openstack-cinder | 17:35 | |
*** links has joined #openstack-cinder | 17:38 | |
*** links has quit IRC | 17:38 | |
*** xyang has joined #openstack-cinder | 17:39 | |
*** mvenesio has joined #openstack-cinder | 17:40 | |
*** mriedem_away is now known as mriedem | 17:41 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Fujitsu DX: Add retries for busy error https://review.openstack.org/597572 | 17:43 |
*** eharney has quit IRC | 17:51 | |
*** xyang is now known as xyang_ | 17:56 | |
*** xyang_ is now known as xyang | 17:59 | |
*** e0ne has quit IRC | 18:01 | |
*** pcaruana has joined #openstack-cinder | 18:02 | |
*** links has joined #openstack-cinder | 18:02 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Ds8k: Mock evenlet.sleep calls https://review.openstack.org/600494 | 18:03 |
*** openstackgerrit has quit IRC | 18:05 | |
*** avishay_ has joined #openstack-cinder | 18:06 | |
*** e0ne has joined #openstack-cinder | 18:06 | |
*** avishay has quit IRC | 18:06 | |
*** avishay_ is now known as avishay | 18:06 | |
*** e0ne has quit IRC | 18:08 | |
*** mvenesio has quit IRC | 18:10 | |
*** mvenesio has joined #openstack-cinder | 18:11 | |
*** links has quit IRC | 18:11 | |
*** spartakos has quit IRC | 18:15 | |
*** melwitt is now known as melwitt_awaysick | 18:18 | |
*** erlon has quit IRC | 18:22 | |
imacdonn | core team, please review https://review.openstack.org/#/c/593955/ - IMO, this should be backported to Rocky (at least), since disabling the v2 API is recommended | 18:31 |
smcginnis | That's twice now today that I've pulled up a patch and thought it looked really familiar. :) | 18:33 |
imacdonn | heh | 18:35 |
imacdonn | you're like "what fool coded this? Oh ..." | 18:35 |
smcginnis | Haha, pretty much. :D | 18:35 |
jungleboyj | Once again, smcginnis is the one man Cinder show. ;-) | 18:44 |
imacdonn | :) tnx jungleboyj | 18:44 |
smcginnis | "scatterbrained" might be a better term. | 18:44 |
jungleboyj | smcginnis: Welcome to the club. | 18:47 |
raunak12 | core team, please review https://review.openstack.org/#/c/600134/ ? | 19:00 |
avishay | Hey everyone. I have a system that's acting up. Running Ocata. Not sure why, but I have 500 volumes stuck in "deleting" state. Force delete doesn't help. How do I get rid of them? | 19:05 |
*** e0ne has joined #openstack-cinder | 19:05 | |
*** eharney has joined #openstack-cinder | 19:06 | |
*** openstackgerrit has joined #openstack-cinder | 19:06 | |
openstackgerrit | Miriam Yumi proposed openstack/cinder-tempest-plugin master: Fix consistency groups test credentials https://review.openstack.org/599720 | 19:06 |
avishay | Did it in SQL... | 19:08 |
avishay | In SQL I see many many workers with status="deleting"? | 19:19 |
crazik | avishay: what is your backend? | 19:20 |
avishay | crazik, RBD | 19:20 |
jungleboyj | avishay: You can use reset state to change the state to something other than deleting and then try to delete them again. | 19:20 |
crazik | avishay: any errors in logs? | 19:21 |
jungleboyj | Wonder if there is something weird going on with your DB causing the performance issues. | 19:21 |
crazik | avishay: check cinder logs as well as ceph | 19:21 |
*** jdillaman has quit IRC | 19:22 | |
openstackgerrit | Keith Berger proposed openstack/cinder stable/pike: VMware: Optimize volume creation from image https://review.openstack.org/600528 | 19:23 |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Remove monkey patch examples from UTs https://review.openstack.org/600529 | 19:24 |
avishay | holy crap... 20,000 messages in cinder-volume's queue... | 19:24 |
crazik | not good. | 19:25 |
*** luizbag has quit IRC | 19:25 | |
crazik | looks like cinder-volume service has problems | 19:25 |
avishay | yes... big time | 19:26 |
crazik | logs? | 19:26 |
jungleboyj | Oooh ... I saw this before. | 19:26 |
jungleboyj | Has one of your OSDs filled up? | 19:26 |
jungleboyj | If so, then RBD stops processing all requests and it looks like Cinder has lost its mind. | 19:27 |
jungleboyj | Really, it is just that RBD has stopped and the only clue is a little message put into dmesg somewhere. | 19:27 |
jungleboyj | avishay: ^^^ | 19:27 |
avishay | RBD started rebalancing, don't know if it's related | 19:28 |
crazik | ceph -s ? | 19:29 |
crazik | or ceph health status | 19:29 |
jungleboyj | avishay: I need to run for a while but my best guess is that it is due to Ceph no longer processing requests. I had to go and delete a volume by hand or something to free up space and then it started going again. | 19:30 |
avishay | jungleboyj, thanks! | 19:30 |
*** spartakos has joined #openstack-cinder | 19:30 | |
crazik | avishay: what ceph version? | 19:31 |
jungleboyj | There will be a message in one of the system logs, dmesg or /var/log/messages that indicates that a disk is full. | 19:31 |
jungleboyj | Hope that helps. Let me know what you find out. | 19:31 |
avishay | crazik, https://pastebin.com/6TPF3JNR | 19:32 |
avishay | crazik, luminous | 19:32 |
crazik | do you have ceph-mgr service? | 19:32 |
avishay | jungleboyj, thanks, will do! | 19:32 |
crazik | then you have a simple web status for ceph cluster | 19:32 |
crazik | sorry, I mispelled last command, it should be: ceph health detail | 19:33 |
crazik | but ok | 19:33 |
crazik | usage: 1942 GB used, 14825 GB / 16767 GB avail | 19:34 |
avishay | looks like it's not in great shape | 19:34 |
crazik | I don't have access to my clusters now | 19:35 |
avishay | https://pastebin.com/gU2RqwpY | 19:35 |
*** pcaruana has quit IRC | 19:35 | |
crazik | check ceph pg stat | 19:35 |
avishay | 512 pgs: 4 active+undersized+degraded+remapped+backfilling, 477 active+clean, 31 active+undersized+degraded+remapped+backfill_wait; 960 GB data, 1946 GB used, 14820 GB / 16767 GB avail; 1878 kB/s rd, 857 kB/s wr, 901 op/s; 16088/770199 objects degraded (2.089%); 1549/770199 objects misplaced (0.201%); 500 kB/s, 0 objects/s recovering | 19:36 |
crazik | I have never seend 'undersized' | 19:36 |
crazik | but it may be something like 'osd full' | 19:36 |
*** Emine has quit IRC | 19:37 | |
crazik | well. no | 19:37 |
*** Emine has joined #openstack-cinder | 19:38 | |
KeithMnemonic | smcginnis: jungleboyj I am back! missed you guys too much! | 19:38 |
smcginnis | KeithMnemonic: Welcome back! | 19:38 |
KeithMnemonic | i have 10 vmware patches to land, 1 by 1, like Noahs Ark! ( i guess that was 2 by 2) | 19:39 |
smcginnis | Hah | 19:39 |
KeithMnemonic | or is there a express entrance | 19:39 |
smcginnis | I saw the one and confirmed it was in later branches. Just waiting on zuul results now. | 19:39 |
KeithMnemonic | these are all in rocky | 19:39 |
KeithMnemonic | just need them in pike | 19:39 |
smcginnis | s/rocky/queens/ ? | 19:39 |
KeithMnemonic | they are in the rocky branch already, so i dont have to do queens or rocky | 19:40 |
KeithMnemonic | just put them in pike | 19:40 |
smcginnis | They need to be in queens to go to pike. | 19:40 |
KeithMnemonic | thry are in queens | 19:40 |
KeithMnemonic | and rocky | 19:40 |
smcginnis | p, q, r | 19:40 |
smcginnis | OK, good. | 19:40 |
KeithMnemonic | just not pike | 19:40 |
KeithMnemonic | so much easier this time | 19:40 |
smcginnis | Are they dependent on each other? You could just submit them all if they are not. | 19:41 |
KeithMnemonic | sorry that is what i meant, just need to take them to one branch | 19:41 |
KeithMnemonic | i can check . if they are no dependencies, i can cherry-pick, review, cherty-pick, review,.... | 19:42 |
KeithMnemonic | or do i need to do something diff on my local branch | 19:42 |
smcginnis | You might want to create fresh branches locally for each cherry-pick so you don't make them dependent on each other, if there is no need to have them go in in order. Otherwise, yep, that's about it. | 19:43 |
KeithMnemonic | ok let me go get some through.the local branches are all from stable/pike not my previous working branch? | 19:44 |
smcginnis | Yep, that's right. | 19:44 |
smcginnis | Once it's submitted you could probably just do cherry-pick, git review, git reset --hard HEAD~1, cherry-pick, git review, etc.. | 19:45 |
smcginnis | Otherwise the commits get stacked on each other and gerrit will try to keep that ordering. | 19:45 |
KeithMnemonic | ok so cherry picks first on my working branch? wont that stack the first submit and the second? | 19:46 |
KeithMnemonic | what i mean is did in need the reset now, or after my second review? | 19:47 |
smcginnis | KeithMnemonic: You need to either check out stable/pike first between each, or reset to get rid of the new cherry-pick before doing the next one. | 19:47 |
KeithMnemonic | rgiht so reset first from my curent state, thanks | 19:48 |
smcginnis | Yeah, since you now have your first backport on your local branch, reset before doing the next one unless you want the next one to be dependent on the first one. | 19:48 |
openstackgerrit | Keith Berger proposed openstack/cinder stable/pike: VMware: Add support for cloning attached volumes https://review.openstack.org/600538 | 19:49 |
smcginnis | KeithMnemonic: Hmm, hate to tell you this, but that one adds new functionality to the driver, so that doesn't meet stable policy to allow backporting. | 19:50 |
KeithMnemonic | no problem, let me see if i can get any of the other "fixes" in | 19:51 |
*** bswartz has quit IRC | 19:51 | |
KeithMnemonic | smcginnis: if I look here https://github.com/openstack/cinder/commits/stable/rocky/cinder/volume/drivers/vmware/volumeops.py do "optimize" and improve" typically meet the guidelines? | 19:55 |
smcginnis | KeithMnemonic: In general, yes. | 19:57 |
KeithMnemonic | so if i try and cherry picks this https://review.openstack.org/#/c/514504/ and it is not clean does that mean it is missing a depends on? | 19:58 |
smcginnis | KeithMnemonic: Potentially. You would have to see what the conflicts are and if they are just something shifted around. | 19:59 |
*** johanssone has joined #openstack-cinder | 19:59 | |
KeithMnemonic | yes i did that at first and that i why i figured it would be easiest to just put them all in order | 20:00 |
KeithMnemonic | isd this feature or fix ? https://review.openstack.org/#/c/484086/ maybe that is a new game show | 20:00 |
smcginnis | Looks like that's just capturing some info to the backend, so that one is fine. | 20:01 |
*** yumiriam has quit IRC | 20:02 | |
*** e0ne has quit IRC | 20:02 | |
openstackgerrit | Keith Berger proposed openstack/cinder stable/pike: VMware: Add 'managedBy' info https://review.openstack.org/600545 | 20:09 |
*** avishay has quit IRC | 20:12 | |
*** avishay has joined #openstack-cinder | 20:12 | |
*** avishay has quit IRC | 20:14 | |
*** amrith has joined #openstack-cinder | 20:17 | |
KeithMnemonic | smcginnis: this one is a "no go" ? https://review.openstack.org/#/c/501070/ | 20:22 |
*** nicolasbock has quit IRC | 20:34 | |
*** savvas_ has joined #openstack-cinder | 20:48 | |
*** savvas_ has quit IRC | 20:48 | |
*** savvas has joined #openstack-cinder | 20:49 | |
*** nicolasbock has joined #openstack-cinder | 20:54 | |
*** dims has quit IRC | 20:55 | |
*** dims has joined #openstack-cinder | 21:11 | |
*** crazik has quit IRC | 21:11 | |
*** crazik has joined #openstack-cinder | 21:18 | |
*** crazik has joined #openstack-cinder | 21:18 | |
*** mvenesio has quit IRC | 21:18 | |
*** mvenesio has joined #openstack-cinder | 21:19 | |
*** mvenesio has quit IRC | 21:25 | |
*** dave-mccowan has quit IRC | 22:00 | |
*** mriedem is now known as mriedem_away | 22:02 | |
*** mriedem_away has quit IRC | 22:02 | |
smcginnis | KeithMnemonic: Kind of a grey area, but I think that could be argued as a bug fix since you can't snap an attached volume otherwise. | 22:06 |
KeithMnemonic | ok thanks! | 22:09 |
*** ganso has quit IRC | 22:17 | |
*** dave-mccowan has joined #openstack-cinder | 22:23 | |
*** rcernin has joined #openstack-cinder | 22:29 | |
*** itlinux has quit IRC | 22:34 | |
*** dave-mccowan has quit IRC | 23:01 | |
*** tpsilva has quit IRC | 23:02 | |
*** _alastor_ has quit IRC | 23:03 | |
*** raunak12 has quit IRC | 23:08 | |
*** _alastor_ has joined #openstack-cinder | 23:38 | |
*** _alastor_ has quit IRC | 23:43 | |
*** itlinux has joined #openstack-cinder | 23:45 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!