*** hoangcx has joined #openstack-cinder | 00:41 | |
*** imacdonn has quit IRC | 01:17 | |
*** imacdonn has joined #openstack-cinder | 01:17 | |
*** mschuppert has quit IRC | 01:25 | |
*** brinzhang has joined #openstack-cinder | 01:34 | |
*** rcernin has quit IRC | 01:40 | |
*** rcernin has joined #openstack-cinder | 01:40 | |
*** Bhujay has joined #openstack-cinder | 02:04 | |
*** Bhujay has quit IRC | 02:12 | |
*** imacdonn has quit IRC | 02:35 | |
*** psachin has joined #openstack-cinder | 02:40 | |
*** imacdonn has joined #openstack-cinder | 02:50 | |
*** sapd1 has joined #openstack-cinder | 03:05 | |
*** whoami-rajat has joined #openstack-cinder | 03:06 | |
*** vivsoni has joined #openstack-cinder | 03:25 | |
vivsoni | hi team, please review | 03:32 |
---|---|---|
vivsoni | https://review.openstack.org/#/c/603448/ | 03:32 |
vivsoni | thanks | 03:32 |
*** psachin has quit IRC | 03:48 | |
*** jdillaman1 has quit IRC | 03:55 | |
*** icey has quit IRC | 03:56 | |
*** icey has joined #openstack-cinder | 03:57 | |
*** psachin has joined #openstack-cinder | 04:00 | |
*** AJaeger has left #openstack-cinder | 04:06 | |
*** vivsoni has quit IRC | 04:10 | |
*** pooja_jadhav has joined #openstack-cinder | 04:14 | |
*** vivsoni has joined #openstack-cinder | 04:30 | |
*** vivsoni has quit IRC | 04:37 | |
*** vivsoni has joined #openstack-cinder | 04:37 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Fix multiattach set to false after retype https://review.openstack.org/604040 | 04:38 |
*** vivsoni has quit IRC | 04:43 | |
*** vivsoni has joined #openstack-cinder | 04:46 | |
*** Bhujay has joined #openstack-cinder | 04:58 | |
*** spsurya has joined #openstack-cinder | 05:02 | |
*** dave-mccowan has joined #openstack-cinder | 05:36 | |
openstackgerrit | Dhinesh Balasubramaniam proposed openstack/cinder master: Hedvig Cinder driver implementation https://review.openstack.org/433341 | 05:45 |
*** jiapei has joined #openstack-cinder | 05:46 | |
*** Bhujay has quit IRC | 05:53 | |
*** Bhujay has joined #openstack-cinder | 05:59 | |
*** dpawlik has joined #openstack-cinder | 06:03 | |
*** pcaruana has joined #openstack-cinder | 06:05 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Fix DRBD volume driver creating a 2-volume resource https://review.openstack.org/604684 | 06:13 |
*** e0ne has joined #openstack-cinder | 06:23 | |
*** Luzi has joined #openstack-cinder | 06:28 | |
*** belmoreira has joined #openstack-cinder | 06:36 | |
*** e0ne_ has joined #openstack-cinder | 06:41 | |
*** e0ne has quit IRC | 06:44 | |
*** belmoreira has quit IRC | 06:45 | |
*** belmoreira has joined #openstack-cinder | 06:47 | |
*** rcernin has quit IRC | 07:06 | |
*** ircuser-1 has joined #openstack-cinder | 07:20 | |
*** alexchadin has joined #openstack-cinder | 07:51 | |
*** alexchadin has quit IRC | 08:14 | |
*** nikeshm has quit IRC | 08:16 | |
*** openstackgerrit has quit IRC | 08:22 | |
*** Bhujay has quit IRC | 08:38 | |
*** alexchadin has joined #openstack-cinder | 08:42 | |
*** kukacz has quit IRC | 09:10 | |
*** kukacz has joined #openstack-cinder | 09:12 | |
*** ianychoi_ has joined #openstack-cinder | 09:30 | |
*** Bhujay has joined #openstack-cinder | 09:32 | |
*** ianychoi has quit IRC | 09:34 | |
*** Bhujay has quit IRC | 09:37 | |
*** e0ne_ has quit IRC | 09:38 | |
*** e0ne has joined #openstack-cinder | 09:38 | |
*** sapd1__ has quit IRC | 09:54 | |
*** sapd1_ has joined #openstack-cinder | 09:59 | |
*** Emine has joined #openstack-cinder | 10:01 | |
*** e0ne has quit IRC | 10:08 | |
*** brinzhang has quit IRC | 10:08 | |
*** ganso has joined #openstack-cinder | 10:08 | |
*** dcdamien has joined #openstack-cinder | 10:08 | |
*** jiapei has quit IRC | 10:23 | |
*** e0ne has joined #openstack-cinder | 10:27 | |
*** e0ne has quit IRC | 10:40 | |
*** Bhujay has joined #openstack-cinder | 10:40 | |
*** e0ne has joined #openstack-cinder | 10:49 | |
*** erlon has joined #openstack-cinder | 10:50 | |
*** luizbag has joined #openstack-cinder | 10:54 | |
*** sapd1 has quit IRC | 10:55 | |
*** e0ne has quit IRC | 10:57 | |
*** Bhujay has quit IRC | 11:02 | |
*** Bhujay has joined #openstack-cinder | 11:05 | |
*** Bhujay has quit IRC | 11:06 | |
*** Bhujay has joined #openstack-cinder | 11:07 | |
*** Bhujay has quit IRC | 11:08 | |
*** Bhujay has joined #openstack-cinder | 11:08 | |
*** Bhujay has quit IRC | 11:09 | |
*** Bhujay has joined #openstack-cinder | 11:10 | |
*** Bhujay has quit IRC | 11:11 | |
*** Bhujay has joined #openstack-cinder | 11:11 | |
*** mvkr has quit IRC | 11:17 | |
*** alexchadin has quit IRC | 11:20 | |
*** mvkr has joined #openstack-cinder | 11:29 | |
*** Roamer` has quit IRC | 11:39 | |
*** zul has joined #openstack-cinder | 11:52 | |
*** alexchadin has joined #openstack-cinder | 11:59 | |
*** alexchadin has quit IRC | 12:05 | |
*** alexchadin has joined #openstack-cinder | 12:06 | |
*** e0ne has joined #openstack-cinder | 12:10 | |
*** psachin has quit IRC | 12:13 | |
*** zul has quit IRC | 12:15 | |
*** Bhujay has quit IRC | 12:15 | |
*** tpsilva has joined #openstack-cinder | 12:16 | |
*** Bhujay has joined #openstack-cinder | 12:16 | |
*** mmethot has quit IRC | 12:18 | |
*** mmethot has joined #openstack-cinder | 12:18 | |
*** openstackgerrit has joined #openstack-cinder | 12:18 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Fix multiattach set to false after retype https://review.openstack.org/604040 | 12:18 |
vivsoni | Hi Team, Please review https://review.openstack.org/#/c/603448/ | 12:28 |
*** zul has joined #openstack-cinder | 12:31 | |
*** Bhujay has quit IRC | 12:39 | |
*** Bhujay has joined #openstack-cinder | 12:40 | |
*** Bhujay has quit IRC | 12:41 | |
*** yumiriam has joined #openstack-cinder | 12:41 | |
*** Bhujay has joined #openstack-cinder | 12:41 | |
*** alexchadin has quit IRC | 12:43 | |
*** jiapei has joined #openstack-cinder | 12:47 | |
*** yumiriam has quit IRC | 12:52 | |
*** jdillaman has joined #openstack-cinder | 12:53 | |
*** alexchadin has joined #openstack-cinder | 12:53 | |
*** icey3 has joined #openstack-cinder | 12:58 | |
KeithMnemonic | smcginnis: another one ready when you have a minute https://review.openstack.org/604408 | 12:59 |
KeithMnemonic | hope you had a nice weekend | 13:00 |
*** icey3 has quit IRC | 13:01 | |
*** zul has quit IRC | 13:01 | |
*** mriedem has joined #openstack-cinder | 13:09 | |
*** yumiriam has joined #openstack-cinder | 13:16 | |
*** lbragstad has joined #openstack-cinder | 13:17 | |
*** zul has joined #openstack-cinder | 13:30 | |
*** belmorei_ has joined #openstack-cinder | 13:30 | |
*** belmoreira has quit IRC | 13:32 | |
*** icey has quit IRC | 13:34 | |
*** SteelyDan is now known as dansmith | 13:34 | |
*** e0ne has quit IRC | 13:38 | |
*** e0ne has joined #openstack-cinder | 13:47 | |
*** edmondsw has joined #openstack-cinder | 13:48 | |
*** woojay has joined #openstack-cinder | 13:51 | |
*** dustins has joined #openstack-cinder | 13:55 | |
mriedem | so uh, | 13:56 |
mriedem | https://developer.openstack.org/api-ref/block-storage/v3/#create-a-volume | 13:56 |
mriedem | is the volume_type parameter the volume type id (uuid) or name? | 13:56 |
mriedem | the API reference isn't clear | 13:56 |
mriedem | oh it's either? | 13:57 |
*** chilo has joined #openstack-cinder | 14:01 | |
openstackgerrit | Chuck Short proposed openstack/cinder master: Remove ploop from rootwrap https://review.openstack.org/581370 | 14:03 |
*** Luzi has quit IRC | 14:03 | |
*** icey has joined #openstack-cinder | 14:09 | |
*** belmorei_ has quit IRC | 14:19 | |
*** chilo has quit IRC | 14:26 | |
*** chilo has joined #openstack-cinder | 14:26 | |
*** belmoreira has joined #openstack-cinder | 14:30 | |
geguileo | mriedem: Should accept any of them | 14:32 |
geguileo | mriedem: we call objects.VolumeType.get_by_name_or_id(context, req_volume_type)) | 14:33 |
mriedem | yeah i see that now | 14:34 |
mriedem | i'll update the API reference to be clear | 14:34 |
geguileo | mriedem: thanks | 14:34 |
*** dpawlik has quit IRC | 14:37 | |
*** dpawlik has joined #openstack-cinder | 14:40 | |
*** mchlumsky has joined #openstack-cinder | 14:40 | |
*** dpawlik has quit IRC | 14:40 | |
openstackgerrit | Matt Riedemann proposed openstack/cinder master: api-ref: mark name as optional in volume create API https://review.openstack.org/604803 | 14:43 |
*** mchlumsky has quit IRC | 14:45 | |
*** mchlumsky has joined #openstack-cinder | 14:47 | |
*** dave-mccowan has quit IRC | 14:50 | |
*** gnufied has joined #openstack-cinder | 14:50 | |
mriedem | the volume-type request parameter here is pretty weird https://developer.openstack.org/api-ref/block-storage/v3/#update-quota-classes-for-a-project | 14:51 |
mriedem | the volume type is really a namespace when updating quota class sets right? | 14:51 |
mriedem | like "volumes_lvmdriver-1" | 14:51 |
mriedem | yeah this is more clear https://developer.openstack.org/api-ref/block-storage/v3/#update-quotas-for-a-project | 14:52 |
mriedem | volumes_{volume_type} | 14:52 |
geguileo | mriedem: iirc that needs to be the name, not the uuid | 14:52 |
* geguileo checks | 14:53 | |
mriedem | yeah should be using the "volumes_number_for_type" api ref parameter | 14:53 |
geguileo | jungleboyj: the deadline for the Forum topics is Wednesday, right? | 14:56 |
mriedem | it is yes | 14:56 |
mriedem | https://bugs.launchpad.net/cinder/+bug/1794120 | 14:56 |
openstack | Launchpad bug 1794120 in Cinder "os-quota-class-sets API reference is confusing for volume type usage" [Medium,Triaged] | 14:56 |
geguileo | jungleboyj: the etherpad feels a little lonely | 14:56 |
geguileo | mriedem: can topics be proposed on Wednesday throughout the day? | 14:57 |
jungleboyj | geguileo: Yeah, I noticed it is kind of quiet. | 14:57 |
jungleboyj | I have a few follow up items from the PTG. I can get through those today and can send another note to the ML. | 14:57 |
mriedem | geguileo: the ML email doesn't specify a time | 14:58 |
geguileo | jungleboyj: I remember there was at least 1 item to be added | 14:58 |
mriedem | "The Forum Topic Submission session started September 12 and will run through September 26th. Now is the time to wrangle the topics you gathered during your Brainstorming Phase and start pushing forum topics through. Don't rely only on a PTL to make the agenda... step on up and place the items you consider important front and center." | 14:58 |
jungleboyj | mriedem: Thank you. | 14:58 |
jungleboyj | We can make that a focus of discussion in our Wednesday meeting and get stuff submitted as well geguileo | 14:59 |
geguileo | mriedem: We'll assume it's the last day that they'll accept | 14:59 |
geguileo | jungleboyj: sounds good | 14:59 |
geguileo | jungleboyj: I wasn't sure if we had to summit them by tomorrow, or if we could wait to after the W meeting | 14:59 |
jungleboyj | I interpret through the 26th to be inclusive. I can ping Jimmy to be sure. | 14:59 |
mriedem | ha, the cinder v2 api-ref for os-quota-class-sets is a full copy of the request/response parameters from nova's api | 15:04 |
mriedem | *os-quota-sets | 15:04 |
mriedem | https://developer.openstack.org/api-ref/block-storage/v2/#quota-sets-extension-os-quota-sets | 15:06 |
*** _hemna has quit IRC | 15:07 | |
*** Bhujay has quit IRC | 15:07 | |
openstackgerrit | Matt Riedemann proposed openstack/cinder master: api-ref: fix req/resp params for v3 os-quota-class-sets https://review.openstack.org/604808 | 15:09 |
jungleboyj | geguileo: Yeah, we are good through Wednesday. So, I will send some notes today. | 15:11 |
*** dave-mccowan has joined #openstack-cinder | 15:12 | |
openstackgerrit | Matt Riedemann proposed openstack/cinder master: api-ref: clarify volume_type param in volume create API https://review.openstack.org/604810 | 15:14 |
*** dave-mccowan has quit IRC | 15:17 | |
mriedem | does anyone know if this could be an intermittent/transient thing during volume extend of an attached volume? http://logs.openstack.org/69/595069/2/gate/tempest-full/169db43/controller/logs/screen-n-cpu.txt.gz#_Sep_24_10_55_26_759691 | 15:22 |
mriedem | Sep 24 10:55:26.759691 ubuntu-xenial-rax-ord-0002235107 nova-compute[15157]: WARNING os_brick.initiator.connectors.iscsi [req-eb1112fc-2010-4878-b6ed-7bd6d5c65b82 req-118f3f55-90c0-47b4-98c9-9b8069625dce service nova] Couldn't find iscsi sessions because iscsiadm err: iscsiadm: could not read session targetname: 5 Sep 24 10:55:26.760040 ubuntu-xenial-rax-ord-0002235107 nova-compute[15157]: iscsiadm: could not find session i | 15:22 |
mriedem | for session22 | 15:22 |
*** dave-mccowan has joined #openstack-cinder | 15:23 | |
imacdonn | Sounds like a failure I had in a nova check job on Friday. Since my change had nothing remotely to do with extending volumes, I did a recheck (without analysing logs too deeply), and it worked the second time | 15:24 |
mriedem | well i know this is an intermittent gate failure http://status.openstack.org/elastic-recheck/#1732199 | 15:24 |
mriedem | it's been around since we added support to cinder/nova for extending an in-use volume | 15:24 |
mriedem | it's some kind of race, | 15:24 |
mriedem | i'm just wondering if retrying on the nova side would help | 15:24 |
mriedem | or os-brick | 15:25 |
imacdonn | yeah, it seems like an os-brick thing (tag geguileo) | 15:25 |
imacdonn | pondering what might cause iscsiadm to fail like that | 15:26 |
geguileo | I'm in a meeting, will check as soon as I finish | 15:26 |
*** dustins has quit IRC | 15:26 | |
mriedem | comments added to https://bugs.launchpad.net/nova/+bug/1732199 | 15:28 |
openstack | Launchpad bug 1732199 in OpenStack Compute (nova) "test_extend_attached_volume fails with Unexpected compute_extend_volume result 'Error'" [Medium,Confirmed] | 15:28 |
*** dustins has joined #openstack-cinder | 15:30 | |
mriedem | hmm, n-cpu might be passing stale connection_info to os-brick | 15:32 |
*** dpawlik has joined #openstack-cinder | 15:38 | |
imacdonn | it looks like os-brick is just running "iscsiadm -m session" (not trying to target anything in particular), and getting that error | 15:38 |
mriedem | does volume extend in cinder create a new export? | 15:38 |
mriedem | b/c nova-compute is passing connection_info to os-brick from when the volume was initially attached to the server | 15:38 |
mriedem | oh i guess we don't even get that far yeah | 15:39 |
mriedem | http://logs.openstack.org/69/595069/2/gate/tempest-full/169db43/controller/logs/syslog.txt.gz#_Sep_24_10_55_24 | 15:42 |
mriedem | Sep 24 10:55:24 ubuntu-xenial-rax-ord-0002235107 kernel: connection21:0: detected conn error (1020) | 15:42 |
*** dpawlik has quit IRC | 15:42 | |
*** alexchadin has quit IRC | 15:47 | |
geguileo | I haven't looked into the os-brick extend_volume method before | 15:48 |
geguileo | and it seems to be using a completely different code path than the one used when we do the attachments | 15:50 |
imacdonn | looking at that syslog, there appears to be some other lvm/tgtadm stuff going on at the time ... probably some sort of concurrency issue | 15:50 |
mriedem | doesn't c-vol have periodics that would hit that at the same time? | 15:51 |
mriedem | s/would/could/ | 15:51 |
mriedem | lvdisplay and such? | 15:52 |
imacdonn | seems like it would likely pop up somewhere in cinder | 15:52 |
*** sapd1 has joined #openstack-cinder | 15:53 | |
geguileo | I am new to this bug, so I'm lacking too much context | 15:54 |
geguileo | the failure appears on Nova after the volume has been extended? | 15:54 |
geguileo | and when Nova call os-brick's volume_extend method? | 15:55 |
imacdonn | looks like it, yes | 16:00 |
imacdonn | Sep 24 10:55:26.743054 ubuntu-xenial-rax-ord-0002235107 nova-compute[15157]: DEBUG os_brick.initiator.connectors.iscsi [req-eb1112fc-2010-4878-b6ed-7bd6d5c65b82 req-118f3f55-90c0-47b4-98c9-9b8069625dce service nova] ==> extend_volume: call u"{'args': (<os_brick.initiator.connectors.iscsi.ISCSIConnector object at 0x7fccb3e5f4d0>, {u'device_path': u'/dev/sda', u'target_discovered': False, u'encrypted': False, u'qos_specs': None, u'target_iqn': | 16:00 |
imacdonn | u'iqn.2010-10.org.openstack:volume-26727af1-a60f-4753-baf5-7e7012361915', u'target_portal': u'10.210.68.187:3260', u'volume_id': u'26727af1-a60f-4753-baf5-7e7012361915', u'auth_password': u'***', u'target_lun': 1, u'access_mode': u'rw', u'auth_username': u'AD9ppe4xymUAEPLvToKo', u'auth_method': u'CHAP'}), 'kwargs': {}}" {{(pid=15157) trace_logging_wrapper /usr/local/lib/python2.7/dist-packages/os_brick/utils.py:146}} | 16:00 |
*** e0ne has quit IRC | 16:01 | |
*** lbragstad has quit IRC | 16:10 | |
*** lbragstad has joined #openstack-cinder | 16:18 | |
geguileo | it looks like a retry would solve it | 16:19 |
geguileo | though I'm not sure if this should be added to os-brick itself instead of Nova... | 16:20 |
geguileo | and this could mean that we cannot do an extend while do any other iSCSI operations... | 16:20 |
geguileo | because any other operation could fail due to that iSCSI error message | 16:21 |
* geguileo checking more to confirm suspicions | 16:21 | |
*** spotz is now known as spotz_ | 16:25 | |
*** spotz_ is now known as spotz | 16:25 | |
*** icey has quit IRC | 16:29 | |
*** icey has joined #openstack-cinder | 16:33 | |
imacdonn | geguileo: Do you think the extend is causing the problem? It looked like an innocent victim to me .... | 16:36 |
*** dave-mccowan has quit IRC | 16:38 | |
openstackgerrit | Kumar Prashant proposed openstack/cinder master: VMAX Driver - Fix for invalid device id length https://review.openstack.org/603294 | 16:38 |
jungleboyj | geguileo: I have added some additional topics into the etherpad for the forum | 16:42 |
geguileo | jungleboyj: thanks, will look at it now | 16:43 |
geguileo | imacdonn: I believe the problem is caused by the extend. | 16:43 |
geguileo | I have updated the bug | 16:43 |
*** jiapei has quit IRC | 16:43 | |
geguileo | jungleboyj: I like them!!! | 16:44 |
imacdonn | geguileo: how did you determine that the extend is causing the connection failures ? | 16:44 |
geguileo | jungleboyj: Even if there are other sessions about Edge, it makes sense for us to have one specific for storage | 16:44 |
geguileo | imacdonn: I believe there was nothing else happening on the node at the time (could be wrong though) | 16:45 |
jungleboyj | geguileo: Cool. Tried to look at the PTG and think about things that we had questions as to what the users might be doing. | 16:45 |
imacdonn | geguileo: In the syslog, there is a lvm create at the time .. there is no lvm create for extend, right ? | 16:45 |
imacdonn | Sep 24 10:55:25 ubuntu-xenial-rax-ord-0002235107 sudo[25710]: stack : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/usr/local/bin/cinder-rootwrap /etc/cinder/rootwrap.conf env LC_ALL=C lvcreate -T -V 1g -n volume-939eec7d-e33e-410a-bb56-ec880cd8f1cf stack-volumes-lvmdriver-1/stack-volumes-lvmdriver-1-pool | 16:45 |
geguileo | imacdonn: no, I believe there is a tgtadm update | 16:46 |
geguileo | sorry, tgt-admin | 16:46 |
* geguileo checks again | 16:46 | |
imacdonn | geguileo: there's a bunch of stuff happening around that time ... my point is that it appears that there's some other job running in parallel... so I'm not sure we can assume the extend is to blame | 16:47 |
imacdonn | (although maybe it should handle the failure more elegantly) | 16:47 |
geguileo | imacdonn: it could be a tgt issue as well | 16:47 |
geguileo | imacdonn: does this issue happen on the LIO gate as well? | 16:48 |
imacdonn | I suspect some other job is interacting with the target side while the extend job is trying to refresh its initiator side, and sometimes the timing conflicts | 16:48 |
imacdonn | don't know about LIO | 16:48 |
geguileo | imacdonn: the tgt should have different targets for each volume, not sharing the target | 16:49 |
*** ganso has quit IRC | 16:49 | |
geguileo | so it shouldn't matter | 16:49 |
imacdonn | "shouldn't" :) | 16:49 |
geguileo | what you do in other target should not matter for the one we have connected | 16:49 |
geguileo | well, if it's happening it's a tgt bug | 16:49 |
imacdonn | could be | 16:50 |
imacdonn | I wonder how the connection error is detected ... maybe the trigger was some time back | 16:51 |
imacdonn | What does tgt-admin --update do? Notice that it's being run with the force option | 16:56 |
openstackgerrit | Kumar Prashant proposed openstack/cinder master: VMAX Driver - Place volume in SG as part of unmanage volume https://review.openstack.org/603283 | 16:58 |
*** dpawlik has joined #openstack-cinder | 17:00 | |
*** belmoreira has quit IRC | 17:04 | |
openstackgerrit | Merged openstack/cinder master: Propose example volume protection tests https://review.openstack.org/602489 | 17:06 |
*** mvkr has quit IRC | 17:25 | |
*** dave-mccowan has joined #openstack-cinder | 17:35 | |
*** dpawlik has quit IRC | 17:51 | |
KeithMnemonic | jungleboyj: not sure if smcginnis is online so if you get time can you please review this? https://review.openstack.org/604408 | 17:54 |
jungleboyj | KeithMnemonic: Looking. Yeah, I think he might be out today. I haven't heard from him either. | 17:55 |
KeithMnemonic | thanks! | 17:55 |
jungleboyj | Looks ok. jgriffith Can you take a look too and merge it if possible? | 17:57 |
*** e0ne has joined #openstack-cinder | 18:06 | |
*** mvkr has joined #openstack-cinder | 18:15 | |
*** dpawlik has joined #openstack-cinder | 18:17 | |
*** dpawlik_ has joined #openstack-cinder | 18:17 | |
*** dpawlik has quit IRC | 18:18 | |
imacdonn | jungleboyj: Is there any policy on python style, beyond passing the zuul checks? nit-picking on https://review.openstack.org/604230 is trying my patience a bit... | 18:19 |
jungleboyj | imacdonn: Let me look. | 18:20 |
imacdonn | tnx | 18:20 |
jungleboyj | Yeah, that one does seem to be stuck in a nit-pick loop. | 18:24 |
jungleboyj | Let me respond. | 18:24 |
imacdonn | thanks ... the code that's being picked on is old - either moved around, or replicated ... if the style is wrong, the whole driver code needs to be revamped | 18:27 |
openstackgerrit | Kumar Prashant proposed openstack/cinder master: VMAX Driver - Fix for manage volume if volume is part of SG https://review.openstack.org/604303 | 18:30 |
*** ianychoi_ is now known as ianychoi | 18:54 | |
*** sapd1 has quit IRC | 19:15 | |
*** pcaruana has quit IRC | 19:17 | |
KeithMnemonic | jgriffith: Thanks for any review you can do. https://review.openstack.org/604408 | 19:42 |
*** pck has quit IRC | 19:45 | |
*** pck has joined #openstack-cinder | 19:45 | |
*** dpawlik_ has quit IRC | 19:51 | |
*** dpawlik has joined #openstack-cinder | 19:55 | |
*** dpawlik has quit IRC | 19:56 | |
*** erlon has quit IRC | 20:05 | |
*** dpawlik has joined #openstack-cinder | 20:13 | |
*** dpawlik has quit IRC | 20:18 | |
*** crazik has quit IRC | 20:18 | |
*** luizbag has quit IRC | 20:28 | |
*** e0ne has quit IRC | 20:37 | |
*** dpawlik has joined #openstack-cinder | 20:40 | |
*** amito has quit IRC | 21:10 | |
*** amito has joined #openstack-cinder | 21:11 | |
*** dpawlik has quit IRC | 21:12 | |
openstackgerrit | Merged openstack/cinder master: ZFSSA handle manage nonexistent volume https://review.openstack.org/603925 | 21:13 |
jgriffith | KeithMnemonic: you really should consider just using provider-id strings for that mapping | 21:40 |
jgriffith | it would make your life significantly easier and you wouldn't need to call out to your api at all | 21:41 |
KeithMnemonic | jgriffith: thanks, I was just pulling this change in from the code already in rocky. I can see if there are any more changes that address this in rocky that are not in pike | 21:55 |
jgriffith | KeithMnemonic: yeah, I hear ya; that's why I just pointed it out. Not something for backports, but might be a nice improvement for you this upcoming release :) | 21:56 |
*** mriedem is now known as mriedem_away | 21:57 | |
*** dustins has quit IRC | 22:01 | |
*** Emine has quit IRC | 22:03 | |
*** luizbag has joined #openstack-cinder | 22:13 | |
*** luizbag has quit IRC | 22:13 | |
*** dpawlik has joined #openstack-cinder | 22:16 | |
*** dpawlik has quit IRC | 22:20 | |
*** rcernin has joined #openstack-cinder | 22:45 | |
*** pooja-jadhav has joined #openstack-cinder | 22:51 | |
*** kukacz_ has joined #openstack-cinder | 22:55 | |
*** dims_ has joined #openstack-cinder | 22:59 | |
*** Reepicheep_ has joined #openstack-cinder | 23:00 | |
*** kukacz has quit IRC | 23:00 | |
*** pooja_jadhav has quit IRC | 23:00 | |
*** dims has quit IRC | 23:00 | |
*** cburgess has quit IRC | 23:00 | |
*** strigazi has quit IRC | 23:00 | |
*** Reepicheep has quit IRC | 23:00 | |
*** kambiz has quit IRC | 23:00 | |
*** andreykurilin has quit IRC | 23:03 | |
*** chilo has quit IRC | 23:04 | |
*** andreykurilin has joined #openstack-cinder | 23:05 | |
*** tpsilva has quit IRC | 23:43 | |
*** erlon has joined #openstack-cinder | 23:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!