*** swamireddy has joined #openstack-cinder | 00:01 | |
*** swamireddy has joined #openstack-cinder | 00:01 | |
*** hoangcx has joined #openstack-cinder | 00:53 | |
*** erlon has joined #openstack-cinder | 01:15 | |
*** yikun has joined #openstack-cinder | 01:16 | |
yikun | hello | 01:17 |
---|---|---|
*** tommylikehu has joined #openstack-cinder | 01:31 | |
*** lixiaoy1 has joined #openstack-cinder | 01:34 | |
*** mschuppert has quit IRC | 01:36 | |
*** jiapei has joined #openstack-cinder | 01:39 | |
openstackgerrit | Yikun Jiang proposed openstack/cinder master: Fix wrong uuid recognized when create group https://review.openstack.org/605666 | 01:51 |
*** mhen has quit IRC | 01:58 | |
*** mhen has joined #openstack-cinder | 02:00 | |
openstackgerrit | Yikun Jiang proposed openstack/cinder master: Refactor of _clone_image_volume https://review.openstack.org/606310 | 02:24 |
*** faizy98 has joined #openstack-cinder | 02:25 | |
*** faizy_ has quit IRC | 02:27 | |
openstackgerrit | Yikun Jiang proposed openstack/cinder master: WIP: Make backup init_host more effectively https://review.openstack.org/606800 | 02:28 |
*** dave-mccowan has quit IRC | 02:30 | |
openstackgerrit | yenai proposed openstack/os-brick master: Improve VolumePathsNotFound message details https://review.openstack.org/605576 | 02:56 |
*** LiangFang has joined #openstack-cinder | 03:24 | |
openstackgerrit | yenai proposed openstack/os-brick master: Remove unused connection properties https://review.openstack.org/604287 | 03:29 |
*** kaisers has quit IRC | 03:56 | |
*** kaisers has joined #openstack-cinder | 04:05 | |
*** kaisers has quit IRC | 04:12 | |
*** kaisers has joined #openstack-cinder | 04:19 | |
*** hoangcx has quit IRC | 04:27 | |
*** pooja_jadhav has joined #openstack-cinder | 04:33 | |
*** sheel has joined #openstack-cinder | 05:11 | |
*** tommylikehu has quit IRC | 05:27 | |
*** lixiaoy1 has quit IRC | 05:32 | |
openstackgerrit | Yong Huang proposed openstack/os-brick stable/rocky: The validation of iscsi session should be case insensitive https://review.openstack.org/608578 | 05:51 |
openstackgerrit | Yikun Jiang proposed openstack/cinder master: Extract _get_image_metadata into volume utils https://review.openstack.org/606345 | 06:18 |
openstackgerrit | Yikun Jiang proposed openstack/cinder master: WIP: volume reimage https://review.openstack.org/606346 | 06:18 |
*** e0ne has joined #openstack-cinder | 06:21 | |
openstackgerrit | zhufl proposed openstack/cinder master: api-ref: qos and extra_spec are optional in types view https://review.openstack.org/608585 | 06:31 |
openstackgerrit | zhufl proposed openstack/cinder master: api-ref: qos and extra_spec are optional in types view https://review.openstack.org/608585 | 06:46 |
openstackgerrit | wang yong proposed openstack/cinder master: Cinder volume driver for Inspur AS13000 series https://review.openstack.org/602338 | 07:18 |
*** rcernin has quit IRC | 07:21 | |
*** chenhaw has joined #openstack-cinder | 07:22 | |
openstackgerrit | Yikun Jiang proposed openstack/cinder-specs master: Add volume re-image api https://review.openstack.org/605317 | 07:29 |
openstackgerrit | Yikun Jiang proposed openstack/cinder master: Extract _get_image_metadata into volume utils https://review.openstack.org/606345 | 08:03 |
*** amoralej|off is now known as amoralej | 08:04 | |
openstackgerrit | Yikun Jiang proposed openstack/cinder master: WIP: volume reimage https://review.openstack.org/606346 | 08:04 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.openstack.org/608606 | 08:07 |
*** belmoreira has joined #openstack-cinder | 08:17 | |
*** hoangcx has joined #openstack-cinder | 08:49 | |
*** lemko has joined #openstack-cinder | 09:28 | |
*** faizy_ has joined #openstack-cinder | 09:44 | |
*** faizy98 has quit IRC | 09:48 | |
*** LiangFang has quit IRC | 10:05 | |
*** luizbag has joined #openstack-cinder | 10:21 | |
*** rcernin has joined #openstack-cinder | 10:35 | |
*** dpawlik has joined #openstack-cinder | 10:37 | |
*** Luzi has joined #openstack-cinder | 10:46 | |
*** dave-mccowan has joined #openstack-cinder | 10:47 | |
*** erlon has quit IRC | 11:08 | |
*** psachin has joined #openstack-cinder | 11:12 | |
*** rcernin has quit IRC | 11:17 | |
*** faizy98 has joined #openstack-cinder | 11:22 | |
*** crazik has joined #openstack-cinder | 11:23 | |
*** faizy_ has quit IRC | 11:24 | |
*** belmorei_ has joined #openstack-cinder | 11:48 | |
*** belmoreira has quit IRC | 11:51 | |
*** e0ne has quit IRC | 12:04 | |
*** e0ne has joined #openstack-cinder | 12:13 | |
*** brinzhang has quit IRC | 12:28 | |
openstackgerrit | hongwei.xu proposed openstack/cinder master: Extract user_id from context as the operator id https://review.openstack.org/594124 | 12:44 |
*** crazik has left #openstack-cinder | 12:45 | |
openstackgerrit | Josephine Seifert proposed openstack/cinder-specs master: Spec for the Cinder part of Image Encryption https://review.openstack.org/608663 | 12:54 |
*** psachin has quit IRC | 13:01 | |
*** eharney has joined #openstack-cinder | 13:02 | |
*** e0ne has quit IRC | 13:05 | |
*** dustins has joined #openstack-cinder | 13:13 | |
*** mriedem has joined #openstack-cinder | 13:15 | |
*** raghavendrat has joined #openstack-cinder | 13:22 | |
*** raghavendrat has quit IRC | 13:23 | |
openstackgerrit | Josephine Seifert proposed openstack/cinder-specs master: Spec for the Cinder part of Image Encryption https://review.openstack.org/608663 | 13:24 |
*** erlon has joined #openstack-cinder | 13:30 | |
*** erlon_ has joined #openstack-cinder | 13:31 | |
*** erlon has quit IRC | 13:35 | |
*** zul has quit IRC | 13:38 | |
*** enriquetaso has joined #openstack-cinder | 13:41 | |
*** sheel has quit IRC | 13:50 | |
*** kukacz has quit IRC | 13:54 | |
*** kukacz has joined #openstack-cinder | 13:54 | |
openstackgerrit | Merged openstack/cinder master: Imported Translations from Zanata https://review.openstack.org/608606 | 13:58 |
*** asbishop has joined #openstack-cinder | 14:02 | |
*** ganso has joined #openstack-cinder | 14:05 | |
*** munimeha1 has joined #openstack-cinder | 14:07 | |
*** rosmaita has joined #openstack-cinder | 14:13 | |
*** SteelyDan is now known as dansmith | 14:13 | |
*** gnufied has joined #openstack-cinder | 14:16 | |
*** e0ne has joined #openstack-cinder | 14:17 | |
*** eharney has quit IRC | 14:24 | |
*** lpetrut has joined #openstack-cinder | 14:32 | |
*** faizy_ has joined #openstack-cinder | 14:33 | |
*** faizy98 has quit IRC | 14:36 | |
*** enriquetaso_ has joined #openstack-cinder | 14:45 | |
*** enriquetaso has left #openstack-cinder | 14:45 | |
*** Emine has joined #openstack-cinder | 14:49 | |
*** enriquetaso_ has quit IRC | 14:50 | |
*** itlinux has quit IRC | 14:50 | |
*** gcb_ has joined #openstack-cinder | 14:53 | |
*** e0ne has quit IRC | 14:54 | |
*** faizy98 has joined #openstack-cinder | 14:56 | |
*** lpetrut has quit IRC | 14:57 | |
*** faizy_ has quit IRC | 14:58 | |
*** mriedem has quit IRC | 15:03 | |
*** dklyle has joined #openstack-cinder | 15:04 | |
*** mriedem has joined #openstack-cinder | 15:04 | |
*** enriquetaso_ has joined #openstack-cinder | 15:09 | |
*** e0ne has joined #openstack-cinder | 15:11 | |
*** enriquetaso_ has quit IRC | 15:16 | |
*** Luzi has quit IRC | 15:17 | |
jgriffith | erlon_: so my point was that a simple single line bug included 33 lines of stuff that wasn't really needed. | 15:17 |
jgriffith | erlon_: I aslo find the commit meesage confusing and rather misleading. The multiple statement of "incorrect assumption" are completely irrelevant and well... "incorrect assumptions" | 15:18 |
jgriffith | but regardless, it's your driver so if you're happy with it it's fine by me | 15:18 |
*** Emine has quit IRC | 15:21 | |
*** enriquetaso_ has joined #openstack-cinder | 15:24 | |
*** enriquetaso_ has quit IRC | 15:27 | |
*** enriquetaso has joined #openstack-cinder | 15:27 | |
openstackgerrit | Gaudenz Steinlin proposed openstack/cinder stable/pike: RBD: Don't query Ceph on stats for exclusive pools https://review.openstack.org/607192 | 15:33 |
*** e0ne has quit IRC | 15:40 | |
*** e0ne has joined #openstack-cinder | 15:42 | |
*** itlinux has joined #openstack-cinder | 15:43 | |
*** faizy_ has joined #openstack-cinder | 15:48 | |
*** e0ne has quit IRC | 15:49 | |
*** faizy98 has quit IRC | 15:52 | |
mriedem | will a volume extend operation take longer when it has snapshots? | 15:59 |
mriedem | or should that be unrelated? | 15:59 |
mriedem | https://bugs.launchpad.net/cinder/+bug/1796708 | 16:01 |
openstack | Launchpad bug 1796708 in Cinder "VolumesExtendTest.test_volume_extend_when_volume_has_snapshot intermittently fails with "Extend volume failed.: VolumeNotDeactivated: Volume volume-5514a6ad-abbb-46b3-a464-d73cc67e55af was not deactivated in time."" [Undecided,New] | 16:01 |
smcginnis | mriedem: I would think it would be unrelated, but different storage works in different ways, so not sure if there are some where that could happen. | 16:02 |
mriedem | this is lvm | 16:02 |
mriedem | so seems it should be unrelated | 16:02 |
mriedem | might just be a slow compute node | 16:02 |
smcginnis | I didn't think LVM would make a difference, but I am not really an LVM expert. | 16:02 |
smcginnis | I would go with the slow compute node idea. | 16:02 |
*** gcb_ has quit IRC | 16:03 | |
*** faizy_ has quit IRC | 16:10 | |
*** raunak12 has joined #openstack-cinder | 16:10 | |
*** faizy_ has joined #openstack-cinder | 16:10 | |
*** belmorei_ has quit IRC | 16:11 | |
*** faizy_ has quit IRC | 16:15 | |
*** faizy98 has joined #openstack-cinder | 16:16 | |
*** supamatt has joined #openstack-cinder | 16:19 | |
*** supamatt has quit IRC | 16:19 | |
*** supamatt has joined #openstack-cinder | 16:19 | |
*** faizy98 has quit IRC | 16:20 | |
*** faizy98 has joined #openstack-cinder | 16:23 | |
jungleboyj | smcginnis: ++ | 16:26 |
jungleboyj | I have not heard of snapshots impacting LVM performance in the past. Other storage, maybe. | 16:26 |
*** eharney has joined #openstack-cinder | 16:43 | |
prometheanfire | smcginnis: you know about the new oslo-messaging? http://logs.openstack.org/21/607521/2/check/cross-cinder-py35/e15722e/testr_results.html.gz | 16:48 |
smcginnis | prometheanfire: Wow, no, I hadn't seen that. Looks... bad. | 16:49 |
prometheanfire | yep, not just cinder either | 16:49 |
smcginnis | prometheanfire: Have you pinged the oslo folks? | 16:49 |
prometheanfire | not yet | 16:50 |
imacdonn | I think there was some change in the cinder code in the past w.r.t. _get_transport | 16:58 |
imacdonn | I recall this because it prevents stable/pike cinder (which doesn't have the change) from working on devstack/master | 16:58 |
imacdonn | this, I think https://review.openstack.org/#/c/473716/ | 16:59 |
imacdonn | I was looking at a glance example .. I guess the test are failing in a different way for cinder | 17:03 |
*** raunak12_ has joined #openstack-cinder | 17:04 | |
*** raunak12 has quit IRC | 17:05 | |
*** raunak12_ is now known as raunak12 | 17:05 | |
imacdonn | looks like the cinder test conf fixture needs to be updated to use transport_url instead of rpc_backend (which was deprecated in the Newton era) | 17:06 |
imacdonn | https://bugs.launchpad.net/oslo.messaging/+bug/1712399 | 17:08 |
openstack | Launchpad bug 1712399 in oslo.messaging "Remove the deprecated rpc_backend configuration option" [Medium,Fix released] - Assigned to Steve Kowalik (stevenk) | 17:08 |
*** faizy_ has joined #openstack-cinder | 17:20 | |
*** faizy98 has quit IRC | 17:23 | |
*** e0ne has joined #openstack-cinder | 17:24 | |
*** e0ne has quit IRC | 17:29 | |
smcginnis | Oh, good find imacdonn | 17:38 |
smcginnis | So did oslo.messaging backport a config option removal? | 17:39 |
imacdonn | smcginnis: I think they just finally implemented it .. it's been deprecated, but not removed, for a long time, apparently | 17:39 |
imacdonn | I was able to reproduce the test failures, and updating the general conf fixture makes some of them go away ... there are some third party driver tests that need updating too, though | 17:40 |
jungleboyj | imacdonn: They also just did a Messaging release last week. | 17:47 |
jungleboyj | Might be why we are just seeing this now. | 17:47 |
imacdonn | jungleboyj: yes, it's new in 9.0.0 | 17:47 |
prometheanfire | imacdonn: smcginnis keystone has the problem too | 17:54 |
prometheanfire | kmalloc: ^? | 17:54 |
*** e0ne has joined #openstack-cinder | 17:54 | |
kmalloc | hm. | 17:54 |
prometheanfire | not sure if you three (projects) want to work together on it or anything or if the ml would be good | 17:54 |
imacdonn | prometheanfire: Seems the problems are somewhat obvious ... will probably have to be dealt with individually (by project), IMO | 17:55 |
*** imacdonn has quit IRC | 18:23 | |
*** imacdonn has joined #openstack-cinder | 18:23 | |
smcginnis | I think get-capabilities is my new favorite "what were they thinking" command. | 18:42 |
smcginnis | And the fact that we have GETs that perform actions on things is a close second. | 18:53 |
*** _hemna has quit IRC | 18:54 | |
*** _hemna has joined #openstack-cinder | 18:54 | |
*** faizy_ has quit IRC | 18:55 | |
imacdonn | Getting a new failure running unit tests on master (not with the new oslo.messaging): | 19:00 |
imacdonn | oslo_config.cfg.NoSuchOptError: no such option nfs_sparsed_volumes in group [DEFAULT] | 19:00 |
imacdonn | at least I can't see how it could be related to the oslo.messaging thing | 19:01 |
imacdonn | (and I went back to 8.1.2) | 19:01 |
imacdonn | maybe it's another one of those funky "depends what order things get run in" deals :/ | 19:02 |
*** eharney has quit IRC | 19:02 | |
smcginnis | Maybe. I haven't noticed any changes with that config option. | 19:03 |
*** eharney has joined #openstack-cinder | 19:04 | |
imacdonn | yeah, running tox with concurrency limited to 4 made it go away ... my 48-vCPU dev box seems to be quite good at finding these issues :/ | 19:10 |
smcginnis | Nice dev box! | 19:13 |
imacdonn | you'd think .... but it seems to cause more problems than it's worth sometimes | 19:14 |
jungleboyj | imacdonn: Yikes. And I was all proud of the system I just got. | 19:18 |
imacdonn | heh | 19:18 |
jungleboyj | imacdonn: What is that running on? | 19:18 |
imacdonn | One of these - it's kindof old, actually: http://www.oracle.com/us/products/servers-storage/servers/x86/x4-2-ds-2008629.pdf | 19:19 |
jungleboyj | imacdonn: Oh, I haven't seen a Sun Server in a long time. | 19:20 |
imacdonn | I haven't seen much else in an even longer time ;) | 19:21 |
jungleboyj | :-) I tried to build a Sun Sparc based cluster in College with our old Sparc boxes. | 19:21 |
imacdonn | I worked for Sun before the acquisition, so yeah .. I've literally been there, done that, and got the t-shirt .. quite a few t-shirts ;) | 19:23 |
imacdonn | I even have a Sun Cluster shirt! | 19:23 |
smcginnis | I liked my old Sparc machines. | 19:24 |
jungleboyj | Nice. | 19:27 |
amito | from time to time I get to debug scsi inquiries on a sparc server, not a pleasant sight. | 19:29 |
imacdonn | these quotes are annoying - if you try to pass multiple args, they all get combined into one, and stestr barfs: https://github.com/openstack/cinder/blob/master/tox.ini#L25 | 19:32 |
smcginnis | Hmm, I wonder if {posargs} isn't actually supposed to be quoted there. | 19:33 |
imacdonn | yeah, it's not .. checked other examples (nova) | 19:34 |
imacdonn | with the quotes remove, I can do like: tox -e py27 -- --concurrency=16 cinder.tests.unit.volume.drivers.test_nfs | 19:34 |
imacdonn | (issue mentioned above seems to happen when concurrency is 15 or higher) | 19:36 |
imacdonn | there's also an example of {posargs} not quoted at https://github.com/openstack/cinder/blob/master/tox.ini#L74 | 19:41 |
openstackgerrit | iain MacDonnell proposed openstack/cinder master: Don't quote {posargs} in tox.ini https://review.openstack.org/608758 | 19:44 |
imacdonn | ^ discuss ;) | 19:44 |
*** luizbag has quit IRC | 20:05 | |
imacdonn | anyone know what's the purpose of this? It's causing grief with the new oslo.messaging. With it commented out, the tests all work... https://github.com/openstack/cinder/blob/master/cinder/tests/unit/zonemanager/test_fc_zone_manager.py#L49-L51 | 20:08 |
smcginnis | No idea why that would be mocked on the setup call. My guess is it's not needed. | 20:09 |
smcginnis | It may have been trying to do something for one of the tests, but if so, they were doing it wrong. So I don't think it has any effect where it is now and must not actually be needed for whatever test it was meant for. | 20:10 |
smcginnis | Looks like config used to be modified in that setUp call but has since been removed, so it was probably just missed removing the decorator. | 20:11 |
imacdonn | so... should that be removed in a separate commit, or can it sneak in with changes for the new oslo.messaging ? | 20:12 |
smcginnis | Probably should be a separate commit. If it's just that, should be really easy to get it through quick. Then your other changes can be a dependent commit off of that. | 20:13 |
imacdonn | they're kindof dependent on eachother, to pass CI | 20:14 |
smcginnis | imacdonn: I thought it was only when run with really high concurrency. | 20:16 |
imacdonn | no, that's a different issue | 20:17 |
smcginnis | OK, then it should be fine to include them together in one commit. | 20:17 |
smcginnis | Anyone have multiple backends that could give me a paste of the output from "cinder get-capabilities <host>"? Where backends are host@backend-1, host@backend-2. | 20:18 |
smcginnis | Sorry, with "--debug" on the output too. | 20:18 |
prometheanfire | rosmaita: we were talking about the oslo-messaging thing here too | 20:18 |
smcginnis | rosmaita: If you were looking to do a cinder patch too... :) | 20:19 |
*** e0ne has quit IRC | 20:19 | |
*** e0ne has joined #openstack-cinder | 20:20 | |
prometheanfire | smcginnis: nah, glance | 20:21 |
smcginnis | prometheanfire: Yeah, I was suggesting if he wanted to do the same thing he did for glance with cinder. ;) | 20:21 |
imacdonn | smcginnis: looks like he's proposing to dodge the issue(s) by just not allowing the new version | 20:22 |
smcginnis | imacdonn: Yeah, they've fixed the glitch. | 20:22 |
imacdonn | seems there are at least two separate issues with the new oslo.messaging ... the deprecated option removal (rpc_backend), and the default value thing | 20:23 |
imacdonn | the latter may make this mocked setUp() problem moot ... but kinda seems like it should be removed anyway | 20:24 |
smcginnis | Yeah, I think so. | 20:24 |
*** eharney has quit IRC | 20:32 | |
*** e0ne has quit IRC | 20:48 | |
*** pcaruana has quit IRC | 20:49 | |
openstackgerrit | iain MacDonnell proposed openstack/cinder master: Stop using deprecated rpc_backend option https://review.openstack.org/608768 | 20:53 |
*** prometheanfire has left #openstack-cinder | 20:59 | |
*** itlinux has quit IRC | 21:08 | |
*** erlon_ has quit IRC | 21:54 | |
imacdonn | smcginnis jungleboyj: any concerns about https://review.openstack.org/608758 ? | 22:08 |
*** dustins has quit IRC | 22:09 | |
jungleboyj | imacdonn: No expert on that code but it looks ok to me. | 22:10 |
imacdonn | jungleboyj: thanks! | 22:10 |
jungleboyj | imacdonn: Welcome. | 22:10 |
rosmaita | imacdonn: to test your change with oslo.messaging 9.0.0, put "Depends-On: https://review.openstack.org/#/c/607521/" in your commit message. Although 9.0.0 has been released, it's not actually being used by anyone since the upper-constraint is 8.1.2 | 22:13 |
imacdonn | rosmaita: OK. I think I'll let it run through Check as-is, and consider that as a next step ... thanks | 22:14 |
rosmaita | yeah, that was just a point of information kind of thinkg | 22:15 |
rosmaita | *thing | 22:15 |
imacdonn | yep, thanks | 22:15 |
rosmaita | looks like you are right about 2 separate issues, cinder tests still are still failing against olso masters: http://zuul.openstack.org/builds.html?pipeline=periodic&project=openstack%2Fcinder&job_name=openstack-tox-py27-with-oslo-master | 22:16 |
imacdonn | yeah, there definitely were uses of the removed option in the cinder unit tests | 22:17 |
imacdonn | uses? usages? :/ | 22:17 |
rosmaita | 'uses' works for me | 22:18 |
*** ganso has quit IRC | 22:24 | |
imacdonn | so it passed zuul check as-is ... I'm now wondering which way the the CRD should go ... I think that the requirements change should actually "depends-on" the cinder one | 22:39 |
rosmaita | depends on what you want to do | 22:40 |
imacdonn | well, I'm thinking that their change shouldn't merge until the cinder one has .. so the dependency should reflect that | 22:41 |
rosmaita | right, but if you want to *use* their change in your cinder patch, you need to depend on it | 22:44 |
rosmaita | zuul will apply their change to upper-constraints before your patch runs | 22:44 |
rosmaita | that will raise the u-c to 9.0.0 | 22:44 |
rosmaita | and as long as cinder's requirements.txt says something like "oslo.messaging>=5.8.3", zuul should grab 9.0.0 to test your patch | 22:45 |
rosmaita | gotta go pick up the kid from soccer practice ... ttyl | 22:47 |
imacdonn | k, later | 22:47 |
*** dave-mccowan has quit IRC | 22:49 | |
*** munimeha1 has quit IRC | 22:50 | |
*** rcernin has joined #openstack-cinder | 22:50 | |
*** dave-mccowan has joined #openstack-cinder | 22:50 | |
*** mriedem has quit IRC | 22:57 | |
*** tpsilva has quit IRC | 23:41 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!