Friday, 2018-10-26

*** lixiaoy1 has joined #openstack-cinder00:22
*** _alastor_ has joined #openstack-cinder00:23
*** erlon has joined #openstack-cinder00:24
*** _alastor_ has quit IRC00:28
*** daikk115 has quit IRC00:30
*** Liang__ has joined #openstack-cinder00:32
*** Liang__ is now known as LiangFang00:32
*** itlinux has joined #openstack-cinder00:49
openstackgerritMerged openstack/cinder stable/pike: Added mount fstype based validation of Quobyte mounts
*** bhagyashris has joined #openstack-cinder01:21
*** mhen has quit IRC01:40
*** mhen has joined #openstack-cinder01:42
*** lbragstad has quit IRC01:49
*** lbragstad has joined #openstack-cinder01:49
*** rosmaita has left #openstack-cinder01:53
*** rcernin has joined #openstack-cinder01:55
*** Dinesh_Bhor has joined #openstack-cinder01:55
openstackgerritMerged openstack/cinder master: DS8K: correct the usage for ssl method(SSLContext.wrap_socket)
openstackgerritMerged openstack/cinder master: api-ref: add missing fields in volume group types
openstackgerritMerged openstack/cinder stable/queens: VMAX Queens - 90 endpoint not compatible with unisphere 8.4
openstackgerritLisaLi proposed openstack/cinder master: Set user message on volume create failure
openstackgerritMerged openstack/cinder master: Remove touch command from volume.filters
openstackgerritMerged openstack/cinder master: Remove mount from volume.filters
openstackgerritMerged openstack/cinder master: Remove scsi_id from rootwrap filter
openstackgerritMerged openstack/cinder stable/queens: Fix backup/restore error for ceph rbd backend
openstackgerritMerged openstack/cinder master: api-ref: Fix namespace parameter for backend capabilities
openstackgerritMerged openstack/cinder master: [minifix] Update reno formatting on Quobyte driver defaults change
*** Dinesh_Bhor has quit IRC02:58
*** gnufied has quit IRC03:02
*** Dinesh_Bhor has joined #openstack-cinder03:06
*** dpawlik has quit IRC03:27
*** dpawlik has joined #openstack-cinder03:29
*** brinzhang has quit IRC03:47
*** brinzhang has joined #openstack-cinder03:47
*** udesale has joined #openstack-cinder03:51
*** lpetrut has joined #openstack-cinder03:58
*** Dinesh_Bhor has quit IRC04:11
*** dave-mccowan has quit IRC04:14
*** brinzhang has quit IRC04:31
*** brinzhang has joined #openstack-cinder04:31
*** lpetrut has quit IRC04:34
*** dpawlik has quit IRC04:36
*** _alastor_ has joined #openstack-cinder04:38
*** dpawlik has joined #openstack-cinder04:39
openstackgerritMayur Indalkar proposed openstack/cinder master: Code refactoring for existing veritas access cinder iSCSI driver.
*** _alastor_ has quit IRC04:42
*** Dinesh_Bhor has joined #openstack-cinder05:35
*** Luzi has joined #openstack-cinder05:45
*** mchlumsky_ has joined #openstack-cinder05:46
*** Liang__ has joined #openstack-cinder05:50
*** jgriffit1 has joined #openstack-cinder05:51
*** hemna_ has joined #openstack-cinder05:54
*** dims_ has joined #openstack-cinder05:54
*** LiangFang has quit IRC05:55
*** erlon has quit IRC05:55
*** irclogbot_0 has quit IRC05:55
*** mchlumsky has quit IRC05:55
*** jgriffith has quit IRC05:55
*** dims has quit IRC05:55
*** strigazi has quit IRC05:55
*** hemna has quit IRC05:55
*** mhen has quit IRC05:59
*** erlon has joined #openstack-cinder06:03
*** mhen has joined #openstack-cinder06:07
*** faizy_ has joined #openstack-cinder06:20
*** faizy98 has quit IRC06:24
openstackgerritzengyingzhe proposed openstack/cinder master: Huawei driver refactor
*** erlon has quit IRC07:12
*** rcernin has quit IRC07:22
*** strigazi has joined #openstack-cinder07:26
*** Dinesh_Bhor has quit IRC07:39
*** Dinesh_Bhor has joined #openstack-cinder08:18
openstackgerritOpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata
openstackgerritYikun Jiang proposed openstack/cinder master: Extract copy_image_to_volume into volume utils
openstackgerritYikun Jiang proposed openstack/cinder master: Microversion 3.56 - Support volume re-image
*** lixiaoy1 has quit IRC08:55
openstackgerritYikun Jiang proposed openstack/cinder-specs master: Improve volume transfer records
*** e0ne has joined #openstack-cinder09:16
*** sapd1 has quit IRC09:25
*** lemko has joined #openstack-cinder09:52
*** brinzhang has quit IRC10:01
*** dpawlik has quit IRC10:03
*** dpawlik_ has joined #openstack-cinder10:03
*** luizbag has joined #openstack-cinder10:05
*** erlon has joined #openstack-cinder10:07
*** lpetrut has joined #openstack-cinder10:11
*** bhagyashris has quit IRC10:20
openstackgerritMerged openstack/cinder master: Replace openSUSE experimental check with newer version
*** Liang__ has quit IRC10:31
BlackDexHey hello there. I'm having an issue with cinder (and maybe nova) using multipath.10:37
BlackDexOne of the iscsi path's seems to be down, but cinder still tries to use it10:38
BlackDexdoesn't seem to be really multipath this way as it seems cinder forces a specific IP to be used.10:39
*** _alastor_ has joined #openstack-cinder10:39
*** _alastor_ has quit IRC10:43
*** e0ne has quit IRC10:51
*** e0ne_ has joined #openstack-cinder10:52
*** ganso has joined #openstack-cinder10:52
openstackgerritRuben de Smet proposed openstack/cinder master: Adds peer persistence feature to HPE 3PAR driver
*** dave-mccowan has joined #openstack-cinder11:14
*** tridde is now known as trident11:17
*** Dinesh_Bhor has quit IRC11:22
*** udesale has quit IRC11:28
*** lixiaoy1 has joined #openstack-cinder12:11
openstackgerritGorka Eguileor proposed openstack/cinder master: Fix non iSCSI attach serialization
*** eharney has joined #openstack-cinder12:25
*** e0ne_ has quit IRC12:26
*** rosmaita has joined #openstack-cinder12:26
*** dave-mccowan has quit IRC13:00
smcginnisAny distro folks that know anything about when we can expect libopeniscsiusr to be included?13:06
*** dustins has joined #openstack-cinder13:07
*** tpsilva has joined #openstack-cinder13:09
*** Liang__ has joined #openstack-cinder13:12
*** abishop has joined #openstack-cinder13:12
*** pooja_jadhav has quit IRC13:14
*** dpawlik_ has quit IRC13:18
*** mriedem has joined #openstack-cinder13:19
*** dpawlik has joined #openstack-cinder13:20
*** e0ne has joined #openstack-cinder13:25
*** irclogbot_0 has joined #openstack-cinder13:32
*** gnufied has joined #openstack-cinder13:46
jungleboyjeharney:  You around?13:55
*** Luzi has quit IRC14:03
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Handle rbd.OSError on broken RBD image
*** egafford has joined #openstack-cinder14:19
*** dpawlik has quit IRC14:19
*** dpawlik has joined #openstack-cinder14:24
*** dpawlik has quit IRC14:29
*** lixiaoy1 has quit IRC14:42
*** Liang__ is now known as LiangFang14:49
*** dansmith is now known as SteelyDan15:01
*** _alastor_ has joined #openstack-cinder15:02
*** dave-mccowan has joined #openstack-cinder15:04
*** dave-mccowan has quit IRC15:10
*** itlinux has quit IRC15:13
smcginniseharney: This was waiting to see if your concerns were addressed, but I think it's good to go.
*** zul has quit IRC15:52
*** daikk115 has joined #openstack-cinder15:54
*** itlinux has joined #openstack-cinder15:56
*** lpetrut has quit IRC16:00
*** e0ne has quit IRC16:10
*** dave-mccowan has joined #openstack-cinder16:33
*** mriedem is now known as mriedem_away16:34
*** dave-mccowan has quit IRC16:58
openstackgerritMerged openstack/os-brick master: Improve VolumePathsNotFound message details
*** zul has joined #openstack-cinder17:03
*** lpetrut has joined #openstack-cinder17:08
openstackgerritMerged openstack/cinder master: Add column only when it doesn't exist
*** lemko has quit IRC17:22
*** lbragstad is now known as elbragstad17:37
openstackgerritMerged openstack/cinder master: Handling unexpected python error "NoneType object is not iterable"
openstackgerritMerged openstack/cinder master: hpe 3par driver initialization failure
openstackgerritMerged openstack/cinder master: Update unit test debug instructions
openstackgerritMerged openstack/cinder master: Forbidden to revert volume to a different size snapshot
*** mriedem_away is now known as mriedem18:28
openstackgerritSean McGinnis proposed openstack/python-cinderclient master: Fix incorrect use of flake8:noqa
*** e0ne has joined #openstack-cinder18:35
openstackgerritIvan Kolodyazhny proposed openstack/cinder stable/rocky: Forbidden to revert volume to a different size snapshot
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Handle rbd.OSError on broken RBD image
*** luizbag has quit IRC19:02
*** noonedeadpunk has quit IRC19:08
*** erlon has quit IRC19:09
*** e0ne has quit IRC19:14
*** dave-mccowan has joined #openstack-cinder19:18
*** e0ne has joined #openstack-cinder19:19
*** e0ne has quit IRC19:23
_alastor_jungleboyj: I think the parser being used for filter_function and goodness_function is a bit too restrictive.  It can't handle extra_specs with a ":" character in them, so it essentially prevents any filter_function being written for use with vendor-prefixed volume-type attributes19:25
_alastor_jungleboyj: I have a working prototype that I think would fix the issue19:26
jungleboyj_alastor_:  Ok.  That does sound like a problem.19:26
_alastor_jungleboyj: The reason it can't handle that character is it only allows this format of expression: "<some_variable>.<some_optional_attribute> <some_operator> <some_constant>"19:27
_alastor_jungleboyj: It can handle ternary expressions, but they pretty much have to match that19:27
_alastor_jungleboyj: ":" characters are not valid variable name characters in python so it throws a syntax error in the parser19:28
_alastor_jungleboyj: And it doesn't support index expressions. eg: some_variable['some_attribute']19:28
jungleboyjIs there a bug for this?19:29
_alastor_jungleboyj: Nope.  I just hit it, but wanted to check and see if I'm using it incorrectly19:30
_alastor_jungleboyj: My proposed solution:
_alastor_jungleboyj: Essentially falling back to using a really stripped down eval if the default parser can't handle it19:31
openstackgerritMerged openstack/cinder master: Imported Translations from Zanata
jungleboyj_alastor_:  I don't know that code very well.19:33
jungleboyjThough, the examples above are valid extra-specs.  Right?19:33
jungleboyjAnd extra-specs really can be whatever the vendor wants, why they are 'extra_sepcs'.19:34
jungleboyjSo it seems that the parser would need to handle that.19:34
_alastor_jungleboyj: I don't think anyone but Anthony Lee knows that code well19:35
jungleboyj_alastor_:  Do my assertions above make sense though?19:36
*** lpetrut has quit IRC19:37
_alastor_jungleboyj: It makes sense to me.  For example, I have zero way with the current parser to make a filter_function that is valid with an extra-spec DF:iops_per_gb19:38
_alastor_jungleboyj: Because I'd have to write "extra.DF:iops_per_gb > 5" which fails the parser because of invalid syntax19:39
jungleboyjYeah.  That doesn't seem right.19:40
_alastor_jungleboyj: With my modifications "int(extra.get('DF:iops_per_gb', 0)) > 5" functions as expected19:41
jungleboyjIs that a valid extra spec?19:42
_alastor_jungleboyj: It's valid for my backend.  Anything prefixed is vendor specific19:43
jungleboyjI guess, Like I said before, the extra_specs are whatever the vendors need.  So I guess that answers the question.19:44
_alastor_jungleboyj: ok, I'll file a bug and post a patch.  Just wanted to make sure I wasn't crazy19:45
jungleboyjWell, you don't seem crazy to me but I know I am going crazy.  So ....19:46
smcginnisI wonder if there was a legitimate reason for not allowing vendor extra specs there.19:55
jungleboyjsmcginnis:  What do you mean?19:55
smcginnisI think winston-d really knew that code well. I haven't had to touch it much.19:55
smcginnisMore of an open question/observation. There might have been a reason for it, but I don't know.19:56
_alastor_smcginnis: I think it was to be on the safe side of things since it's impossible to break out of the parser.19:56
_alastor_smcginnis: You can do just as well though with eval by stomping all the builtins19:57
smcginnisCould definitely just have been an oversight too.19:57
_alastor_smcginnis: I intend to keep the original behavior and only when that fails do we fall back to a parser that allows more.  Could probably even make it configurable for the paranoid19:58
smcginnisSounds like a good plan. We can see if anyone with some history can remember any reasons on the review.20:00
*** zul has quit IRC20:25
*** imacdonn has quit IRC20:32
*** imacdonn has joined #openstack-cinder20:32
*** openstackstatus has quit IRC20:42
*** openstack has joined #openstack-cinder20:47
*** ChanServ sets mode: +o openstack20:47
*** dustins has quit IRC21:11
*** eharney has quit IRC21:12
openstackgerritMatt Smith (_alastor_) proposed openstack/cinder master: Adding support for fallback eval-based filter_func parser
*** abishop has quit IRC21:50
*** mriedem has quit IRC21:52
*** itlinux has quit IRC22:05
*** ganso has quit IRC22:18
*** tpsilva has quit IRC22:27
*** rosmaita has left #openstack-cinder22:54
imacdonnsmcginnis: are you still -1 on this?
*** pcaruana has quit IRC23:10
*** rcernin has joined #openstack-cinder23:43
*** rcernin has quit IRC23:51
*** itlinux has joined #openstack-cinder23:51

Generated by 2.15.3 by Marius Gedminas - find it at!