| *** lixiaoy1 has joined #openstack-cinder | 00:22 | |
| *** _alastor_ has joined #openstack-cinder | 00:23 | |
| *** erlon has joined #openstack-cinder | 00:24 | |
| *** _alastor_ has quit IRC | 00:28 | |
| *** daikk115 has quit IRC | 00:30 | |
| *** Liang__ has joined #openstack-cinder | 00:32 | |
| *** Liang__ is now known as LiangFang | 00:32 | |
| *** itlinux has joined #openstack-cinder | 00:49 | |
| openstackgerrit | Merged openstack/cinder stable/pike: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/609698 | 01:02 |
|---|---|---|
| *** bhagyashris has joined #openstack-cinder | 01:21 | |
| *** mhen has quit IRC | 01:40 | |
| *** mhen has joined #openstack-cinder | 01:42 | |
| *** lbragstad has quit IRC | 01:49 | |
| *** lbragstad has joined #openstack-cinder | 01:49 | |
| *** rosmaita has left #openstack-cinder | 01:53 | |
| *** rcernin has joined #openstack-cinder | 01:55 | |
| *** Dinesh_Bhor has joined #openstack-cinder | 01:55 | |
| openstackgerrit | Merged openstack/cinder master: DS8K: correct the usage for ssl method(SSLContext.wrap_socket) https://review.openstack.org/610453 | 01:58 |
| openstackgerrit | Merged openstack/cinder master: api-ref: add missing fields in volume group types https://review.openstack.org/606242 | 01:58 |
| openstackgerrit | Merged openstack/cinder stable/queens: VMAX Queens - 90 endpoint not compatible with unisphere 8.4 https://review.openstack.org/611340 | 01:58 |
| openstackgerrit | LisaLi proposed openstack/cinder master: Set user message on volume create failure https://review.openstack.org/612375 | 01:59 |
| openstackgerrit | Merged openstack/cinder master: Remove touch command from volume.filters https://review.openstack.org/610514 | 02:25 |
| openstackgerrit | Merged openstack/cinder master: Remove mount from volume.filters https://review.openstack.org/611657 | 02:25 |
| openstackgerrit | Merged openstack/cinder master: Remove scsi_id from rootwrap filter https://review.openstack.org/611693 | 02:26 |
| openstackgerrit | Merged openstack/cinder stable/queens: Fix backup/restore error for ceph rbd backend https://review.openstack.org/610996 | 02:26 |
| openstackgerrit | Merged openstack/cinder master: api-ref: Fix namespace parameter for backend capabilities https://review.openstack.org/608397 | 02:26 |
| openstackgerrit | Merged openstack/cinder master: [minifix] Update reno formatting on Quobyte driver defaults change https://review.openstack.org/609688 | 02:26 |
| *** Dinesh_Bhor has quit IRC | 02:58 | |
| *** gnufied has quit IRC | 03:02 | |
| *** Dinesh_Bhor has joined #openstack-cinder | 03:06 | |
| *** dpawlik has quit IRC | 03:27 | |
| *** dpawlik has joined #openstack-cinder | 03:29 | |
| *** brinzhang has quit IRC | 03:47 | |
| *** brinzhang has joined #openstack-cinder | 03:47 | |
| *** udesale has joined #openstack-cinder | 03:51 | |
| *** lpetrut has joined #openstack-cinder | 03:58 | |
| *** Dinesh_Bhor has quit IRC | 04:11 | |
| *** dave-mccowan has quit IRC | 04:14 | |
| *** brinzhang has quit IRC | 04:31 | |
| *** brinzhang has joined #openstack-cinder | 04:31 | |
| *** lpetrut has quit IRC | 04:34 | |
| *** dpawlik has quit IRC | 04:36 | |
| *** _alastor_ has joined #openstack-cinder | 04:38 | |
| *** dpawlik has joined #openstack-cinder | 04:39 | |
| openstackgerrit | Mayur Indalkar proposed openstack/cinder master: Code refactoring for existing veritas access cinder iSCSI driver. https://review.openstack.org/611791 | 04:42 |
| *** _alastor_ has quit IRC | 04:42 | |
| *** Dinesh_Bhor has joined #openstack-cinder | 05:35 | |
| *** Luzi has joined #openstack-cinder | 05:45 | |
| *** mchlumsky_ has joined #openstack-cinder | 05:46 | |
| *** Liang__ has joined #openstack-cinder | 05:50 | |
| *** jgriffit1 has joined #openstack-cinder | 05:51 | |
| *** hemna_ has joined #openstack-cinder | 05:54 | |
| *** dims_ has joined #openstack-cinder | 05:54 | |
| *** LiangFang has quit IRC | 05:55 | |
| *** erlon has quit IRC | 05:55 | |
| *** irclogbot_0 has quit IRC | 05:55 | |
| *** mchlumsky has quit IRC | 05:55 | |
| *** jgriffith has quit IRC | 05:55 | |
| *** dims has quit IRC | 05:55 | |
| *** strigazi has quit IRC | 05:55 | |
| *** hemna has quit IRC | 05:55 | |
| *** mhen has quit IRC | 05:59 | |
| *** erlon has joined #openstack-cinder | 06:03 | |
| *** mhen has joined #openstack-cinder | 06:07 | |
| *** faizy_ has joined #openstack-cinder | 06:20 | |
| *** faizy98 has quit IRC | 06:24 | |
| openstackgerrit | zengyingzhe proposed openstack/cinder master: Huawei driver refactor https://review.openstack.org/514126 | 06:51 |
| *** erlon has quit IRC | 07:12 | |
| *** rcernin has quit IRC | 07:22 | |
| *** strigazi has joined #openstack-cinder | 07:26 | |
| *** Dinesh_Bhor has quit IRC | 07:39 | |
| *** Dinesh_Bhor has joined #openstack-cinder | 08:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.openstack.org/613524 | 08:21 |
| openstackgerrit | Yikun Jiang proposed openstack/cinder master: Extract copy_image_to_volume into volume utils https://review.openstack.org/613280 | 08:25 |
| openstackgerrit | Yikun Jiang proposed openstack/cinder master: Microversion 3.56 - Support volume re-image https://review.openstack.org/606346 | 08:25 |
| *** lixiaoy1 has quit IRC | 08:55 | |
| openstackgerrit | Yikun Jiang proposed openstack/cinder-specs master: Improve volume transfer records https://review.openstack.org/612866 | 09:04 |
| *** e0ne has joined #openstack-cinder | 09:16 | |
| *** sapd1 has quit IRC | 09:25 | |
| *** lemko has joined #openstack-cinder | 09:52 | |
| *** brinzhang has quit IRC | 10:01 | |
| *** dpawlik has quit IRC | 10:03 | |
| *** dpawlik_ has joined #openstack-cinder | 10:03 | |
| *** luizbag has joined #openstack-cinder | 10:05 | |
| *** erlon has joined #openstack-cinder | 10:07 | |
| *** lpetrut has joined #openstack-cinder | 10:11 | |
| *** bhagyashris has quit IRC | 10:20 | |
| openstackgerrit | Merged openstack/cinder master: Replace openSUSE experimental check with newer version https://review.openstack.org/609462 | 10:28 |
| *** Liang__ has quit IRC | 10:31 | |
| BlackDex | Hey hello there. I'm having an issue with cinder (and maybe nova) using multipath. | 10:37 |
| BlackDex | One of the iscsi path's seems to be down, but cinder still tries to use it | 10:38 |
| BlackDex | doesn't seem to be really multipath this way as it seems cinder forces a specific IP to be used. | 10:39 |
| *** _alastor_ has joined #openstack-cinder | 10:39 | |
| *** _alastor_ has quit IRC | 10:43 | |
| *** e0ne has quit IRC | 10:51 | |
| *** e0ne_ has joined #openstack-cinder | 10:52 | |
| *** ganso has joined #openstack-cinder | 10:52 | |
| openstackgerrit | Ruben de Smet proposed openstack/cinder master: Adds peer persistence feature to HPE 3PAR driver https://review.openstack.org/613557 | 11:06 |
| *** dave-mccowan has joined #openstack-cinder | 11:14 | |
| *** tridde is now known as trident | 11:17 | |
| *** Dinesh_Bhor has quit IRC | 11:22 | |
| *** udesale has quit IRC | 11:28 | |
| *** lixiaoy1 has joined #openstack-cinder | 12:11 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Fix non iSCSI attach serialization https://review.openstack.org/613567 | 12:19 |
| *** eharney has joined #openstack-cinder | 12:25 | |
| *** e0ne_ has quit IRC | 12:26 | |
| *** rosmaita has joined #openstack-cinder | 12:26 | |
| *** dave-mccowan has quit IRC | 13:00 | |
| smcginnis | Any distro folks that know anything about when we can expect libopeniscsiusr to be included? | 13:06 |
| *** dustins has joined #openstack-cinder | 13:07 | |
| *** tpsilva has joined #openstack-cinder | 13:09 | |
| *** Liang__ has joined #openstack-cinder | 13:12 | |
| *** abishop has joined #openstack-cinder | 13:12 | |
| *** pooja_jadhav has quit IRC | 13:14 | |
| *** dpawlik_ has quit IRC | 13:18 | |
| *** mriedem has joined #openstack-cinder | 13:19 | |
| *** dpawlik has joined #openstack-cinder | 13:20 | |
| *** e0ne has joined #openstack-cinder | 13:25 | |
| *** irclogbot_0 has joined #openstack-cinder | 13:32 | |
| *** gnufied has joined #openstack-cinder | 13:46 | |
| jungleboyj | eharney: You around? | 13:55 |
| *** Luzi has quit IRC | 14:03 | |
| openstackgerrit | Dmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Handle rbd.OSError on broken RBD image https://review.openstack.org/612741 | 14:04 |
| *** egafford has joined #openstack-cinder | 14:19 | |
| *** dpawlik has quit IRC | 14:19 | |
| *** dpawlik has joined #openstack-cinder | 14:24 | |
| *** dpawlik has quit IRC | 14:29 | |
| *** lixiaoy1 has quit IRC | 14:42 | |
| *** Liang__ is now known as LiangFang | 14:49 | |
| *** dansmith is now known as SteelyDan | 15:01 | |
| *** _alastor_ has joined #openstack-cinder | 15:02 | |
| *** dave-mccowan has joined #openstack-cinder | 15:04 | |
| *** dave-mccowan has quit IRC | 15:10 | |
| *** itlinux has quit IRC | 15:13 | |
| smcginnis | eharney: This was waiting to see if your concerns were addressed, but I think it's good to go. https://review.openstack.org/#/c/602332/ | 15:51 |
| *** zul has quit IRC | 15:52 | |
| *** daikk115 has joined #openstack-cinder | 15:54 | |
| *** itlinux has joined #openstack-cinder | 15:56 | |
| *** lpetrut has quit IRC | 16:00 | |
| *** e0ne has quit IRC | 16:10 | |
| *** dave-mccowan has joined #openstack-cinder | 16:33 | |
| *** mriedem is now known as mriedem_away | 16:34 | |
| *** dave-mccowan has quit IRC | 16:58 | |
| openstackgerrit | Merged openstack/os-brick master: Improve VolumePathsNotFound message details https://review.openstack.org/605576 | 17:02 |
| *** zul has joined #openstack-cinder | 17:03 | |
| *** lpetrut has joined #openstack-cinder | 17:08 | |
| openstackgerrit | Merged openstack/cinder master: Add column only when it doesn't exist https://review.openstack.org/603541 | 17:20 |
| *** lemko has quit IRC | 17:22 | |
| *** lbragstad is now known as elbragstad | 17:37 | |
| openstackgerrit | Merged openstack/cinder master: Handling unexpected python error "NoneType object is not iterable" https://review.openstack.org/611081 | 17:40 |
| openstackgerrit | Merged openstack/cinder master: hpe 3par driver initialization failure https://review.openstack.org/612884 | 17:40 |
| openstackgerrit | Merged openstack/cinder master: Update unit test debug instructions https://review.openstack.org/607700 | 17:41 |
| openstackgerrit | Merged openstack/cinder master: Forbidden to revert volume to a different size snapshot https://review.openstack.org/611491 | 17:44 |
| *** mriedem_away is now known as mriedem | 18:28 | |
| openstackgerrit | Sean McGinnis proposed openstack/python-cinderclient master: Fix incorrect use of flake8:noqa https://review.openstack.org/613660 | 18:29 |
| *** e0ne has joined #openstack-cinder | 18:35 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder stable/rocky: Forbidden to revert volume to a different size snapshot https://review.openstack.org/613664 | 18:41 |
| openstackgerrit | Dmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Handle rbd.OSError on broken RBD image https://review.openstack.org/612741 | 18:48 |
| *** luizbag has quit IRC | 19:02 | |
| *** noonedeadpunk has quit IRC | 19:08 | |
| *** erlon has quit IRC | 19:09 | |
| *** e0ne has quit IRC | 19:14 | |
| *** dave-mccowan has joined #openstack-cinder | 19:18 | |
| *** e0ne has joined #openstack-cinder | 19:19 | |
| *** e0ne has quit IRC | 19:23 | |
| _alastor_ | jungleboyj: I think the parser being used for filter_function and goodness_function is a bit too restrictive. It can't handle extra_specs with a ":" character in them, so it essentially prevents any filter_function being written for use with vendor-prefixed volume-type attributes | 19:25 |
| _alastor_ | jungleboyj: I have a working prototype that I think would fix the issue | 19:26 |
| jungleboyj | _alastor_: Ok. That does sound like a problem. | 19:26 |
| _alastor_ | jungleboyj: The reason it can't handle that character is it only allows this format of expression: "<some_variable>.<some_optional_attribute> <some_operator> <some_constant>" | 19:27 |
| _alastor_ | jungleboyj: It can handle ternary expressions, but they pretty much have to match that | 19:27 |
| _alastor_ | jungleboyj: ":" characters are not valid variable name characters in python so it throws a syntax error in the parser | 19:28 |
| _alastor_ | jungleboyj: And it doesn't support index expressions. eg: some_variable['some_attribute'] | 19:28 |
| jungleboyj | Ok. | 19:29 |
| jungleboyj | Is there a bug for this? | 19:29 |
| _alastor_ | jungleboyj: Nope. I just hit it, but wanted to check and see if I'm using it incorrectly | 19:30 |
| _alastor_ | jungleboyj: My proposed solution: http://paste.openstack.org/show/733153/ | 19:30 |
| _alastor_ | jungleboyj: Essentially falling back to using a really stripped down eval if the default parser can't handle it | 19:31 |
| openstackgerrit | Merged openstack/cinder master: Imported Translations from Zanata https://review.openstack.org/613524 | 19:32 |
| jungleboyj | _alastor_: I don't know that code very well. | 19:33 |
| jungleboyj | Though, the examples above are valid extra-specs. Right? | 19:33 |
| jungleboyj | And extra-specs really can be whatever the vendor wants, why they are 'extra_sepcs'. | 19:34 |
| jungleboyj | So it seems that the parser would need to handle that. | 19:34 |
| _alastor_ | jungleboyj: I don't think anyone but Anthony Lee knows that code well | 19:35 |
| jungleboyj | Ok. | 19:36 |
| jungleboyj | _alastor_: Do my assertions above make sense though? | 19:36 |
| *** lpetrut has quit IRC | 19:37 | |
| _alastor_ | jungleboyj: It makes sense to me. For example, I have zero way with the current parser to make a filter_function that is valid with an extra-spec DF:iops_per_gb | 19:38 |
| _alastor_ | jungleboyj: Because I'd have to write "extra.DF:iops_per_gb > 5" which fails the parser because of invalid syntax | 19:39 |
| jungleboyj | Yeah. That doesn't seem right. | 19:40 |
| _alastor_ | jungleboyj: With my modifications "int(extra.get('DF:iops_per_gb', 0)) > 5" functions as expected | 19:41 |
| jungleboyj | Is that a valid extra spec? | 19:42 |
| _alastor_ | jungleboyj: It's valid for my backend. Anything prefixed is vendor specific | 19:43 |
| jungleboyj | Ok. | 19:43 |
| jungleboyj | I guess, Like I said before, the extra_specs are whatever the vendors need. So I guess that answers the question. | 19:44 |
| _alastor_ | jungleboyj: ok, I'll file a bug and post a patch. Just wanted to make sure I wasn't crazy | 19:45 |
| jungleboyj | Well, you don't seem crazy to me but I know I am going crazy. So .... | 19:46 |
| smcginnis | I wonder if there was a legitimate reason for not allowing vendor extra specs there. | 19:55 |
| jungleboyj | smcginnis: What do you mean? | 19:55 |
| smcginnis | I think winston-d really knew that code well. I haven't had to touch it much. | 19:55 |
| smcginnis | More of an open question/observation. There might have been a reason for it, but I don't know. | 19:56 |
| _alastor_ | smcginnis: I think it was to be on the safe side of things since it's impossible to break out of the parser. | 19:56 |
| _alastor_ | smcginnis: You can do just as well though with eval by stomping all the builtins | 19:57 |
| smcginnis | Could definitely just have been an oversight too. | 19:57 |
| _alastor_ | smcginnis: I intend to keep the original behavior and only when that fails do we fall back to a parser that allows more. Could probably even make it configurable for the paranoid | 19:58 |
| smcginnis | Sounds like a good plan. We can see if anyone with some history can remember any reasons on the review. | 20:00 |
| *** zul has quit IRC | 20:25 | |
| *** imacdonn has quit IRC | 20:32 | |
| *** imacdonn has joined #openstack-cinder | 20:32 | |
| *** openstackstatus has quit IRC | 20:42 | |
| *** openstack has joined #openstack-cinder | 20:47 | |
| *** ChanServ sets mode: +o openstack | 20:47 | |
| *** dustins has quit IRC | 21:11 | |
| *** eharney has quit IRC | 21:12 | |
| openstackgerrit | Matt Smith (_alastor_) proposed openstack/cinder master: Adding support for fallback eval-based filter_func parser https://review.openstack.org/613695 | 21:47 |
| *** abishop has quit IRC | 21:50 | |
| *** mriedem has quit IRC | 21:52 | |
| *** itlinux has quit IRC | 22:05 | |
| *** ganso has quit IRC | 22:18 | |
| *** tpsilva has quit IRC | 22:27 | |
| *** rosmaita has left #openstack-cinder | 22:54 | |
| imacdonn | smcginnis: are you still -1 on this? https://review.openstack.org/611463 | 23:05 |
| *** pcaruana has quit IRC | 23:10 | |
| *** rcernin has joined #openstack-cinder | 23:43 | |
| *** rcernin has quit IRC | 23:51 | |
| *** itlinux has joined #openstack-cinder | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!