Monday, 2018-12-17

*** lixiaoy1 has joined #openstack-cinder00:27
*** brinzhang has joined #openstack-cinder00:40
openstackgerritzhufl proposed openstack/cinder master: api-ref: volume_type_access should be array instead of object
*** bhagyashris has joined #openstack-cinder01:35
*** Dinesh_Bhor has joined #openstack-cinder01:52
*** dave-mccowan has joined #openstack-cinder02:09
*** Dinesh_Bhor has quit IRC02:10
*** Dinesh_Bhor has joined #openstack-cinder02:21
*** mhen has quit IRC02:24
*** mhen has joined #openstack-cinder02:25
*** lixiaoy1 has quit IRC02:41
*** lixiaoy1 has joined #openstack-cinder02:41
*** lixiaoy1 has quit IRC02:42
*** lixiaoy1 has joined #openstack-cinder02:43
lixiaoy1smcginnis, are you here?02:44
*** dave-mccowan has quit IRC02:47
*** psachin has joined #openstack-cinder02:58
*** yongwc has joined #openstack-cinder03:04
openstackgerritLisaLi proposed openstack/cinder master: Driver reinitialization after failure
*** dklyle has joined #openstack-cinder03:20
*** baojg has joined #openstack-cinder03:21
*** lbragstad has joined #openstack-cinder03:26
openstackgerritDou Rui Yuan proposed openstack/cinder master: Update IBM storwise svc driver doc
*** udesale has joined #openstack-cinder03:49
*** baojg has quit IRC03:51
*** Dinesh_Bhor has quit IRC03:51
*** Dinesh_Bhor has joined #openstack-cinder03:52
*** baojg has joined #openstack-cinder03:56
*** itlinux has quit IRC03:59
*** baojg has quit IRC04:26
*** itlinux has joined #openstack-cinder04:29
*** itlinux has quit IRC04:30
*** bhagyashris has quit IRC05:02
*** dklyle has quit IRC05:16
*** itlinux has joined #openstack-cinder05:32
*** rcernin has joined #openstack-cinder05:46
*** markvoelker has joined #openstack-cinder05:47
*** rcernin has quit IRC05:47
*** markvoelker has quit IRC05:51
*** Dinesh_Bhor has quit IRC06:06
*** rcernin has joined #openstack-cinder06:09
*** rcernin has quit IRC06:09
*** rcernin has joined #openstack-cinder06:09
*** rcernin has quit IRC06:09
openstackgerrithjy proposed openstack/cinder master: dddd
*** lixiaoy1 has quit IRC06:13
*** bhagyashris has joined #openstack-cinder06:17
*** Dinesh_Bhor has joined #openstack-cinder06:41
*** bhagyashris has quit IRC06:43
*** itlinux has quit IRC07:09
*** Luzi has joined #openstack-cinder07:23
*** itlinux has joined #openstack-cinder07:24
*** lixiaoy1 has joined #openstack-cinder07:26
*** dpawlik has joined #openstack-cinder07:26
*** Dinesh_Bhor has quit IRC07:29
*** Dinesh_Bhor has joined #openstack-cinder07:35
*** e0ne has joined #openstack-cinder07:35
*** e0ne has quit IRC07:39
*** markvoelker has joined #openstack-cinder07:48
openstackgerritYingxin Cheng proposed openstack/cinder master: [wip] Cinder RSD Driver
*** Dinesh_Bhor has quit IRC07:57
*** helenafm has joined #openstack-cinder08:08
*** pcaruana has joined #openstack-cinder08:18
*** gkadam has joined #openstack-cinder08:35
*** gkadam has quit IRC08:35
*** bhagyashris has joined #openstack-cinder08:41
*** yongwc has quit IRC08:47
*** lixiaoy1 has quit IRC08:56
openstackgerritRyan Liang proposed openstack/cinder stable/ocata: [VNX]Add `force detach` support
*** lpetrut has joined #openstack-cinder09:09
*** Dinesh_Bhor has joined #openstack-cinder09:17
openstackgerritRyan Liang proposed openstack/cinder stable/ocata: [Unity] Add `force detach` support
*** rtjure has quit IRC09:52
openstackgerritRyan Liang proposed openstack/cinder master: Unity: add option to delete attached snapshots
*** Dinesh_Bhor has quit IRC09:56
*** ganso has joined #openstack-cinder09:58
*** e0ne has joined #openstack-cinder10:02
*** bhagyashris has quit IRC10:04
*** lbragstad has quit IRC10:10
*** lemko has joined #openstack-cinder10:35
*** luizbag has joined #openstack-cinder10:46
*** udesale has quit IRC11:10
*** e0ne has quit IRC11:31
*** tpsilva has joined #openstack-cinder11:42
lennybmszwed: ping11:45
*** rtjure has joined #openstack-cinder11:53
*** luizbag has quit IRC11:56
*** helenafm has quit IRC11:57
*** luizbag has joined #openstack-cinder11:58
*** brinzhang has quit IRC12:15
*** Liang__ is now known as LiangFang12:24
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  code cleanup and minor improvements
openstackgerritSven Wegener proposed openstack/cinder master: backup, ceph: do not set ceph backups to incremental
openstackgerritNguyen Hai proposed openstack/cinder-specs master: Add Train specs directory
*** udesale has joined #openstack-cinder12:39
*** e0ne has joined #openstack-cinder12:47
*** lpetrut has quit IRC12:51
*** markvoelker has quit IRC13:05
*** rosmaita has joined #openstack-cinder13:08
*** e0ne has quit IRC13:11
*** e0ne has joined #openstack-cinder13:14
*** Bhujay has joined #openstack-cinder13:15
*** sapd1__ has joined #openstack-cinder13:18
*** luizbag has quit IRC13:18
*** helenafm has joined #openstack-cinder13:22
*** dave-mccowan has joined #openstack-cinder13:26
*** luizbag has joined #openstack-cinder13:30
*** abishop has joined #openstack-cinder13:30
*** Bhujay has quit IRC13:33
*** avishay has joined #openstack-cinder13:38
avishaygeguileo: Hey, how have you been? I am getting some CleanableInUse errors lately (sometimes after the DBDeadlock retries but not only). I am using Galera but writing only to the master. Have you seen this?13:39
*** e0ne has quit IRC13:42
*** dave-mccowan has quit IRC13:42
*** e0ne has joined #openstack-cinder13:45
*** mvkr has quit IRC13:46
*** pcaruana has quit IRC13:50
*** lbragstad has joined #openstack-cinder13:58
*** lbragstad has quit IRC13:59
*** lbragstad has joined #openstack-cinder14:04
*** pcaruana has joined #openstack-cinder14:05
*** dave-mccowan has joined #openstack-cinder14:06
*** mriedem has joined #openstack-cinder14:08
openstackgerritMerged openstack/cinder stable/rocky: Stop cleaning images to be deleted in remotefs driver
*** dave-mccowan has quit IRC14:11
*** mchlumsky has joined #openstack-cinder14:11
openstackgerritSilvan Kaiser proposed openstack/cinder stable/queens: Stop cleaning images to be deleted in remotefs driver
*** lixiaoy1 has joined #openstack-cinder14:13
*** psachin has quit IRC14:17
lixiaoy1jungleboyj, ping14:21
*** mmethot has joined #openstack-cinder14:22
*** mvkr has joined #openstack-cinder14:22
*** lixiaoy1 has quit IRC14:25
*** lixiaoy1 has joined #openstack-cinder14:27
lixiaoy1smcginnis, may I talk with you about your comments in the os-brick change ?14:33
lixiaoy1smcginnis, you left the comments to ask CI status, I am wondering whether we need CI for this update in os-brick.14:34
smcginnislixiaoy1: All core functionality of a driver does need to be implemented.14:45
*** Luzi has quit IRC14:46
smcginnislixiaoy1: There at least needs to be CI showing results on the driver so we can see the os-brick changes are good too.14:46
smcginnislixiaoy1: We do require third party CI on os-brick for connectors, but since this is just using an existing one with a different setting, I think it is recommended there be CI, but having the driver results would at least give us the validation we need.14:47
*** gnufied has joined #openstack-cinder14:49
lixiaoy1smcginnis, OK, I got it. so do you know the deadline for os-brick patch in Stein release?14:49
*** woojay has joined #openstack-cinder14:49
smcginnislixiaoy1: You would need to ask jungleboyj, but I would think at a minimum it would be a week ahead of the stein-2 milestone so it is released and available for the driver to use it by the deadline.14:51
lixiaoy1smcginnis, is it same as the date for Final release for non-client libraries? that is Feb 25 to Mar 0114:51
smcginnislixiaoy1: That is the final deadline for os-brick releases for stein.14:52
lixiaoy1smcginnis, ok, let me check with jungleboyj14:52
smcginnislixiaoy1: But if you need something in their in order to have a working driver this release, that will need to happen before the stein-2 milestone.14:52
lixiaoy1smcginnis, got it14:52
lixiaoy1smcginnis, may I ask you whether you have time between Jan 1st and Jan 10th to help us review RSD driver?14:53
smcginnislixiaoy1: I should have some time. Is the implmentation complete yet and the CI reporting?14:54
lixiaoy1smcginnis, currently it doesn't. it will be ready in the end of December.14:55
smcginnislixiaoy1: OK, the sooner the better to make sure it is ready by the deadline.14:55
lixiaoy1smcginnis, yes. Thank you very much!14:55
lennybe0ne:  breaks installation on Fedora25 mariadb 10.114:57
lixiaoy1smcginnis, another thing is about driver reinitialization. We discussed about this feature in cinder meeting of last week. and I did some update based on discussion. Eric and Alan will help to review the spec. I am wondering whether you also have time to have a look
lixiaoy1smcginnis, as you ever helped review the spec.14:59
smcginnisSure, I will try to get to that today.14:59
lixiaoy1smcginnis, appreciate you help!14:59
*** e0ne has quit IRC15:02
smcginnisAny DB experts working on the CentOS/MariaDB issue folks are hitting yet?15:04
*** LiangFang has quit IRC15:05
*** e0ne has joined #openstack-cinder15:06
e0nelennyb: :(. unfortunately, I don't have with fedora by the hand15:07
*** dpawlik has quit IRC15:17
* jungleboyj is trying to catch up here.15:17
*** dpawlik has joined #openstack-cinder15:18
*** dpawlik has quit IRC15:18
* jungleboyj is not a DB expert.15:28
jungleboyjlixiaoy1:  Will look through the spec today.15:28
*** pcaruana has quit IRC15:29
e0nelennyb: could you please share logs? what error dit you face?15:38
*** itlinux has quit IRC15:40
openstackgerritSven Wegener proposed openstack/cinder master: backup, ceph: do not set ceph backups to incremental
lennybInternalError: (1071, u'Specified key was too long; max key length is 767 bytes')15:44
openstackLaunchpad bug 1808598 in Cinder "db migration issue on CentOS" [Undecided,Confirmed]15:45
lennybe0ne: packages that were installed on this system
openstackgerritIvan Kolodyazhny proposed openstack/os-brick stable/rocky: Tests: Fix PrivRootwrapTestCase failure
*** pcaruana has joined #openstack-cinder15:51
*** avishay has quit IRC15:53
e0nesmcginnis: thanks for the very quick feedback!15:54
smcginnise0ne: Thanks for paying attention to those kinds of things! :)15:54
e0nesmcginnis: you're welcome :)15:54
*** udesale has quit IRC15:57
*** dklyle has joined #openstack-cinder15:59
openstackgerritSean McGinnis proposed openstack/cinder stable/rocky: An alternate way to fix retype notifier test case
*** Bhujay has joined #openstack-cinder16:16
*** N3l1x has joined #openstack-cinder16:23
*** N3l1x_ has joined #openstack-cinder16:23
jungleboyje0ne:  Do we have any chases where we handle DB migrations differently based on the Distro it is running on?16:27
jungleboyjWondering if, in this case, we need to not change the VARCHAR length on fedora and then document the limitation for that version of DB?16:27
e0nejungleboyj: I need to check. AFAR, we can add some checks for different DB16:27
*** pcaruana has quit IRC16:28
jungleboyjThe fix was for an edge case in the first place.16:28
e0nejungleboyj: we can do something like this one
e0neit would be good to check with mariadb16:34
jungleboyje0ne:  The problem we have here is more complicated though due to it being a version of the DB.  Right?16:35
e0nejungleboyj: correct16:36
jungleboyjSo, could we do a try/catch block on the change and in the case that it fails and is maria-db then we could report a warning and move on?16:36
e0nejungleboyj: sound like an option to try.16:38
jungleboyjUnfortunately, this is on an existing migration, but I think, given that it hasn't been released yet and we know it is broken it will be ok to change.16:38
*** _alastor_ has joined #openstack-cinder16:40
*** itlinux has joined #openstack-cinder16:40
e0nejungleboyj: +116:40
jungleboyjLet me update the bug.16:40
jungleboyjAre you able to dig into it or ...16:41
e0nesmcginnis, jungleboyj: according to maybe it's better to remote time checks from the tests?16:41
e0nejungleboyj:  sorry, I'm not sure that I'll have a time to setup env this week16:41
jungleboyje0ne:  Ok.  I haven't done any DB work in a long time but I can try to spin up a VM.16:42
jungleboyje0ne: Yeah, I am not sure why there is a time check in there.16:43
e0nejungleboyj: I'll be able to help you to troubleshoot if needed16:43
jungleboyje0ne:  Ok.  Sounds good.16:43
e0nesmcginnis, jungleboyj, geguileo: I have different results of that tests on my envs starting with Queens release16:43
e0neI hoped that a simple cherry-pick fixes my issue, but it doesn't :(16:44
geguileoe0ne: we could increase the sleep from 2 to 20, and then do a check with 5 seconds16:46
geguileothat should cover even slow systems16:46
e0negeguileo: do we really need it? I don't like sleeps in tests16:48
geguileoe0ne: have you looked at the test_16:48
geguileoe0ne: it's a test to confirm that the timeout works16:48
geguileowhich means that it will abort after 0.05 seconds16:48
e0neI'm trying to figure out how to mock it16:48
geguileoif you mock it, you don't test it16:48
e0nethat's the issue:(16:49
geguileolet me get this straight, we have tests that are a mess and take up to 60 seconds and nobody can figure out why16:49
geguileobut if a test takes .6 seconds on a slow machine is an issue?16:50
e0negeguileo: please, do not mix two different issues16:50
e0negeguileo: I don't say that the current tests is slow or not16:50
e0negeguileo: it just doesn't work in a same way in different environments16:51
geguileoe0ne: the sleep is only being used because we have to be sure that the method actually aborts before the call is completed16:51
geguileoe0ne: what different envs?16:51
e0negeguileo: the tests works good on fast desktop but fails on a slower one16:51
geguileoe0ne: because the overhead of running privsep is giving it trouble16:52
e0negeguileo: ideally, we shouldn't start privsep in unit tests16:53
geguileoOK, it's not running privsep16:55
geguileoit's using putils.execute16:55
e0newe shouldn't execute it too16:55
*** Bhujay has quit IRC16:56
geguileothen you just need to mock a bunch of methods and you are good to go16:56
geguileoone of which should simulate putils.execute16:57
geguileoto call on_execute16:57
e0neI agree now16:57
geguileoand on_completion16:57
geguileoas well as mock the threading.Timer and simulate it16:58
geguileoand mock proc.send_signal16:58
geguileoand that's probably it16:59
*** helenafm has quit IRC17:02
noonedeadpunkFolks, some reviews are welcome
jungleboyjlixiaoy1:  So, to answer your questions from earlier:17:15
openstackgerritIvan Kolodyazhny proposed openstack/os-brick master: Remove time checks from test_custom_execute_timeout_* tests
jungleboyjlixiaoy1:  I think we can get merged given that it is required for your driver.  Ideally it should have 3rd party CI running against it but if you have the third party CI running on the driver that is dependent upon it, it seems like it is covered.17:17
jungleboyjlixiaoy1: Eventually the CI should catch the os-brick changes as well though and run test.17:18
jungleboyjLooking at your driver ... Obviously you will need to get unit test in place for us to merge it.  It looks like you are missing Create Volume from Image and Create Image from Volume.  You also don't say anything about Host Assisted Volume Migration.  I think that those shortcoming need to be addressed before the change can be merged.17:22
jungleboyjI will update the reviews accordingly.17:22
*** sapd1__ has quit IRC17:29
*** e0ne has quit IRC17:46
*** _alastor_ has quit IRC17:57
*** _alastor_ has joined #openstack-cinder17:59
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver - rebranding VMAX to PowerMax
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  changing from 8.4 to 9.0 REST endpoints
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  code cleanup and minor improvements
*** imacdonn has quit IRC18:24
*** imacdonn has joined #openstack-cinder18:24
*** _alastor_ has quit IRC18:31
*** _alastor_ has joined #openstack-cinder18:32
*** dpawlik has joined #openstack-cinder18:32
*** e0ne has joined #openstack-cinder18:42
*** mvkr has quit IRC18:44
*** e0ne has quit IRC18:46
*** mriedem has quit IRC18:48
*** luizbag has quit IRC18:49
*** mriedem has joined #openstack-cinder18:51
*** dpawlik has quit IRC19:01
*** e0ne has joined #openstack-cinder19:01
*** dpawlik has joined #openstack-cinder19:01
*** luizbag has joined #openstack-cinder19:07
*** _alastor_ has quit IRC19:08
*** mchlumsky has quit IRC19:09
*** luizbag has quit IRC19:16
*** mvkr has joined #openstack-cinder19:20
*** alkhodos has joined #openstack-cinder19:27
*** _alastor_ has joined #openstack-cinder19:28
*** N3l1x has quit IRC19:53
*** _alastor_ has quit IRC19:53
*** _alastor_ has joined #openstack-cinder19:55
*** erlon_ has quit IRC20:25
*** _alastor_ has quit IRC20:37
*** _alastor_ has joined #openstack-cinder20:42
openstackgerritFrancois Deppierraz proposed openstack/cinder master: cinder-volume: Stop masking IOError different than ENOSPC
openstackgerritMerged openstack/cinder-specs master: Add user_id attribute to the backup response
*** gouthamr has quit IRC21:06
openstackgerritMerged openstack/cinder-specs master: cinder-manage object delete --db-only
*** _alastor_ has quit IRC21:16
*** gouthamr has joined #openstack-cinder21:17
*** _alastor_ has joined #openstack-cinder21:17
*** hedvig_01 has joined #openstack-cinder21:22
*** ganso has quit IRC21:25
*** rcernin has joined #openstack-cinder21:28
*** gouthamr_ has joined #openstack-cinder21:30
*** gouthamr_ has quit IRC21:37
*** gouthamr_ has joined #openstack-cinder21:41
openstackgerritMerged openstack/cinder-specs master: Appending change for improve-volume-transfer-records bp
*** gouthamr_ has quit IRC21:46
*** dpawlik has quit IRC21:50
*** gouthamr_ has joined #openstack-cinder21:51
*** gouthamr_ has quit IRC21:56
*** _alastor_ has quit IRC22:04
*** _alastor_ has joined #openstack-cinder22:05
*** abishop has quit IRC22:25
*** e0ne has quit IRC22:25
*** tpsilva has quit IRC22:32
*** itlinux has quit IRC22:42
*** _alastor_ has quit IRC23:20
*** _alastor_ has joined #openstack-cinder23:31
*** itlinux has joined #openstack-cinder23:33
*** mriedem has quit IRC23:40
*** _alastor_ has quit IRC23:54

Generated by 2.15.3 by Marius Gedminas - find it at!