| *** _alastor_ has quit IRC | 00:06 | |
| *** tpsilva has joined #openstack-cinder | 00:09 | |
| *** baojg has quit IRC | 00:14 | |
| *** rtjure has quit IRC | 00:14 | |
| *** rtjure has joined #openstack-cinder | 00:22 | |
| *** rosmaita has left #openstack-cinder | 00:29 | |
| *** lixiaoy1 has joined #openstack-cinder | 00:34 | |
| *** _alastor_ has joined #openstack-cinder | 00:40 | |
| *** Liang__ has joined #openstack-cinder | 00:42 | |
| *** _alastor_ has quit IRC | 00:45 | |
| *** brinzhang has joined #openstack-cinder | 00:53 | |
| *** imacdonn has quit IRC | 01:03 | |
| *** imacdonn has joined #openstack-cinder | 01:03 | |
| *** mriedem has quit IRC | 01:20 | |
| *** sapd1_x has joined #openstack-cinder | 01:22 | |
| openstackgerrit | Leopard Ma proposed openstack/cinder master: WIP:Rollback the quota_usages table when failed to create a incremental backup without parent backup https://review.openstack.org/626790 | 01:35 |
|---|---|---|
| openstackgerrit | Yikun Jiang proposed openstack/cinder master: Improve volume transfer records https://review.openstack.org/615716 | 01:41 |
| *** alkhodos has quit IRC | 01:44 | |
| *** dave-mccowan has quit IRC | 01:50 | |
| *** tpsilva has quit IRC | 02:19 | |
| *** mhen has quit IRC | 02:21 | |
| *** mhen has joined #openstack-cinder | 02:22 | |
| openstackgerrit | Chuck Short proposed openstack/cinder master: Remove 'ln' command from rootwrap filter https://review.openstack.org/611645 | 02:39 |
| openstackgerrit | Chuck Short proposed openstack/cinder master: Remove ploop from rootwrap https://review.openstack.org/581370 | 02:47 |
| openstackgerrit | Chuck Short proposed openstack/cinder master: Switch chgrp to oslo.privsep https://review.openstack.org/603407 | 02:51 |
| openstackgerrit | Yikun Jiang proposed openstack/cinder-specs master: Support certificate validation https://review.openstack.org/572254 | 02:58 |
| *** _alastor_ has joined #openstack-cinder | 03:10 | |
| openstackgerrit | Yikun Jiang proposed openstack/cinder master: Support transfer pagination https://review.openstack.org/602181 | 03:10 |
| *** _alastor_ has quit IRC | 03:15 | |
| *** psachin has joined #openstack-cinder | 03:20 | |
| openstackgerrit | Yikun Jiang proposed openstack/cinder master: Add policy test for volume action policy https://review.openstack.org/617544 | 03:37 |
| *** lbragstad has quit IRC | 03:52 | |
| *** udesale has joined #openstack-cinder | 04:05 | |
| *** brinzhang has quit IRC | 04:12 | |
| *** brinzhang has joined #openstack-cinder | 04:13 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: NetApp Doc: Enhance 'netapp_storage_protocol' description https://review.openstack.org/623168 | 05:47 |
| *** jackivanov has joined #openstack-cinder | 05:50 | |
| *** psachin has quit IRC | 06:16 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/python-cinderclient master: More shell completion cache additions https://review.openstack.org/612529 | 06:16 |
| openstackgerrit | Yikun Jiang proposed openstack/cinder master: Add policy test for volume action policy https://review.openstack.org/617544 | 06:28 |
| *** psachin has joined #openstack-cinder | 06:37 | |
| openstackgerrit | Brin Zhang proposed openstack/cinder master: Replace startswith with equal and remove TODO https://review.openstack.org/615117 | 06:46 |
| *** _alastor_ has joined #openstack-cinder | 07:11 | |
| *** rcernin has quit IRC | 07:16 | |
| *** _alastor_ has quit IRC | 07:16 | |
| *** e0ne has joined #openstack-cinder | 07:39 | |
| *** dpawlik has joined #openstack-cinder | 07:45 | |
| *** dpawlik has quit IRC | 07:48 | |
| *** dpawlik has joined #openstack-cinder | 07:48 | |
| *** sapd1_x has quit IRC | 08:02 | |
| *** sapd1 has joined #openstack-cinder | 08:03 | |
| *** pcaruana has joined #openstack-cinder | 08:19 | |
| *** e0ne_ has joined #openstack-cinder | 08:29 | |
| *** e0ne_ has quit IRC | 08:33 | |
| *** e0ne__ has joined #openstack-cinder | 08:33 | |
| *** e0ne has quit IRC | 08:33 | |
| *** dpawlik has quit IRC | 08:52 | |
| *** dpawlik has joined #openstack-cinder | 08:53 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: NetApp Doc: Enhance 'netapp_storage_protocol' description https://review.openstack.org/623168 | 08:58 |
| *** e0ne__ has quit IRC | 09:03 | |
| *** e0ne has joined #openstack-cinder | 09:04 | |
| *** e0ne has quit IRC | 09:05 | |
| *** e0ne_ has joined #openstack-cinder | 09:05 | |
| *** psachin has quit IRC | 09:11 | |
| openstackgerrit | Yikun Jiang proposed openstack/cinder master: Add policy test for volume metadata policy https://review.openstack.org/619977 | 09:15 |
| *** sapd1 has quit IRC | 09:20 | |
| *** sapd1 has joined #openstack-cinder | 09:21 | |
| *** sapd1 has quit IRC | 09:28 | |
| *** psachin has joined #openstack-cinder | 09:29 | |
| openstackgerrit | Yikun Jiang proposed openstack/cinder master: Add policy test for volume extend/retype/update_ro policy https://review.openstack.org/619978 | 09:36 |
| *** sapd1 has joined #openstack-cinder | 09:41 | |
| *** ganso has joined #openstack-cinder | 09:41 | |
| *** gmann is now known as gmann_pto | 09:43 | |
| *** dpawlik has quit IRC | 09:46 | |
| *** dpawlik has joined #openstack-cinder | 09:53 | |
| *** tobias-urdin has joined #openstack-cinder | 09:55 | |
| *** e0ne_ has quit IRC | 10:18 | |
| *** e0ne has joined #openstack-cinder | 10:18 | |
| openstackgerrit | NolwennCauchois proposed openstack/cinder master: Fix quota error when deleting snapshot group https://review.openstack.org/626863 | 10:25 |
| *** Liang__ has quit IRC | 10:34 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Import the cinderlib code https://review.openstack.org/620669 | 10:36 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Add cinderlib docs https://review.openstack.org/620670 | 10:36 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Add cinderlib functional tests https://review.openstack.org/620671 | 10:36 |
| *** luizbag has joined #openstack-cinder | 10:43 | |
| *** udesale has quit IRC | 10:46 | |
| *** brinzhang has quit IRC | 10:54 | |
| *** gkadam has joined #openstack-cinder | 10:56 | |
| *** _alastor_ has joined #openstack-cinder | 11:13 | |
| *** _alastor_ has quit IRC | 11:18 | |
| *** dpawlik has quit IRC | 11:41 | |
| *** dpawlik has joined #openstack-cinder | 11:46 | |
| *** sapd1 has quit IRC | 12:10 | |
| *** erlon has joined #openstack-cinder | 12:36 | |
| *** e0ne has quit IRC | 12:37 | |
| *** dpawlik has quit IRC | 12:47 | |
| *** e0ne has joined #openstack-cinder | 12:49 | |
| *** e0ne has quit IRC | 13:04 | |
| *** erlon has quit IRC | 13:08 | |
| *** dpawlik has joined #openstack-cinder | 13:11 | |
| *** e0ne has joined #openstack-cinder | 13:11 | |
| *** dave-mccowan has joined #openstack-cinder | 13:15 | |
| whoami-rajat | Hi, can anyone help me with the following error, /home/zuul/src/git.openstack.org/openstack/cinder/doc/source/configuration/block-storage/drivers/netapp-volume-driver.rst:83: D000 Inline literal start-string without end-string. | 13:21 |
| whoami-rajat | Here is the patch, | 13:21 |
| whoami-rajat | https://review.openstack.org/#/c/623168/3/doc/source/configuration/block-storage/drivers/netapp-volume-driver.rst | 13:21 |
| *** kaisers_ has joined #openstack-cinder | 13:28 | |
| openstackgerrit | Maciej Szwed proposed openstack/cinder master: Adding SPDK volume driver https://review.openstack.org/564229 | 13:31 |
| openstackgerrit | Maciej Szwed proposed openstack/cinder master: SPDK drivers documentation https://review.openstack.org/609276 | 13:31 |
| *** kaisers_ has left #openstack-cinder | 13:39 | |
| *** mriedem has joined #openstack-cinder | 13:44 | |
| mszwed | smcginnis, jungleboyj I left comment regarding tests set for SPDK CI in gerrit (https://review.openstack.org/#/c/572759/). I saw that you set +1 for Review-Priority but it was removed due to new patch set. I would be greatful for setting it again :) | 13:44 |
| openstackgerrit | Chuck Short proposed openstack/cinder master: Remove lvremove from rootwrap filters https://review.openstack.org/626898 | 13:49 |
| *** psachin has quit IRC | 13:53 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: NetApp Doc: Enhance 'netapp_storage_protocol' description https://review.openstack.org/623168 | 13:55 |
| openstackgerrit | Chuck Short proposed openstack/cinder master: Remove vgc-cluster https://review.openstack.org/626899 | 13:55 |
| *** lbragstad has joined #openstack-cinder | 13:59 | |
| openstackgerrit | Francois Deppierraz proposed openstack/cinder master: cinder-volume: Stop masking IOError different than ENOSPC https://review.openstack.org/612393 | 14:11 |
| *** luizbag has quit IRC | 14:15 | |
| *** rosmaita has joined #openstack-cinder | 14:24 | |
| *** _alastor_ has joined #openstack-cinder | 14:25 | |
| openstackgerrit | NolwennCauchois proposed openstack/cinder master: Fix quota error when deleting snapshot group https://review.openstack.org/626863 | 14:25 |
| *** arne_wiebalck has quit IRC | 14:29 | |
| *** _alastor_ has quit IRC | 14:30 | |
| openstackgerrit | Michael McAleer proposed openstack/cinder master: VMAX Driver - Failover Unisphere Support https://review.openstack.org/570401 | 14:30 |
| *** lbragstad has quit IRC | 14:31 | |
| *** lbragstad has joined #openstack-cinder | 14:33 | |
| openstackgerrit | Nolwenn Cauchois proposed openstack/cinder stable/pike: Consume quota when importing backup resource https://review.openstack.org/626909 | 14:42 |
| *** kaisers_ has joined #openstack-cinder | 14:46 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax driver - rebranding VMAX to PowerMax https://review.openstack.org/620659 | 14:47 |
| *** e0ne has quit IRC | 14:57 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax driver - rebranding VMAX to PowerMax https://review.openstack.org/620659 | 15:02 |
| *** dpawlik has quit IRC | 15:06 | |
| *** sayalilunkad has quit IRC | 15:13 | |
| jungleboyj | mszwed: I have updated the review priority. Leaving the tab open to take a look today. Thank you for the explanation on the test results. | 15:14 |
| openstackgerrit | Nolwenn Cauchois proposed openstack/cinder stable/queens: Consume quota when importing backup resource https://review.openstack.org/626922 | 15:14 |
| *** e0ne has joined #openstack-cinder | 15:16 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX Driver - Failover Unisphere Support https://review.openstack.org/570401 | 15:16 |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax driver - rebranding VMAX to PowerMax https://review.openstack.org/620659 | 15:23 |
| *** luizbag has joined #openstack-cinder | 15:31 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax driver - changing from 8.4 to 9.0 REST endpoints https://review.openstack.org/625297 | 15:32 |
| *** idlemind has quit IRC | 15:37 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax driver - code cleanup and minor improvements https://review.openstack.org/625581 | 15:40 |
| *** sapd1 has joined #openstack-cinder | 15:41 | |
| *** sapd1 has quit IRC | 15:46 | |
| *** jackivanov has quit IRC | 15:47 | |
| *** jackivanov has joined #openstack-cinder | 15:47 | |
| *** jackivanov has quit IRC | 15:53 | |
| *** kaisers_ has quit IRC | 16:06 | |
| *** luizbag has quit IRC | 16:13 | |
| *** e0ne has quit IRC | 16:16 | |
| *** e0ne has joined #openstack-cinder | 16:17 | |
| *** pcaruana has quit IRC | 16:18 | |
| *** tpsilva has joined #openstack-cinder | 16:27 | |
| *** jackivanov has joined #openstack-cinder | 16:27 | |
| *** e0ne has quit IRC | 16:40 | |
| *** e0ne has joined #openstack-cinder | 16:42 | |
| *** mchlumsky has quit IRC | 16:42 | |
| *** e0ne has quit IRC | 16:44 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Handle string status codes in logging https://review.openstack.org/626947 | 16:44 |
| *** luizbag has joined #openstack-cinder | 16:55 | |
| *** jackivanov has quit IRC | 16:56 | |
| *** gkadam has quit IRC | 16:58 | |
| *** gkadam has joined #openstack-cinder | 16:58 | |
| *** sapd1__ has joined #openstack-cinder | 17:11 | |
| *** sapd1_ has quit IRC | 17:12 | |
| *** mriedem is now known as mriedem_afk | 17:14 | |
| *** sapd1 has joined #openstack-cinder | 17:37 | |
| *** mvkr has quit IRC | 17:38 | |
| *** luizbag has quit IRC | 17:48 | |
| *** sapd1 has quit IRC | 17:48 | |
| *** rosmaita has left #openstack-cinder | 18:01 | |
| *** jackivanov has joined #openstack-cinder | 18:09 | |
| hemna | guwak | 18:20 |
| *** carlos_silva has quit IRC | 18:23 | |
| *** lemko has quit IRC | 18:27 | |
| *** hedvig_01 has joined #openstack-cinder | 18:39 | |
| *** jackivanov has quit IRC | 18:41 | |
| hedvig_01 | @smcginnis: Hi, We got some comments from you. We worked on most of them and asked more details for 2 of the comments on the same page. Is it okay to check in the rest of the changes or do we check in together when all the changes are complete? | 18:41 |
| *** mchlumsky has joined #openstack-cinder | 18:45 | |
| *** e0ne has joined #openstack-cinder | 19:20 | |
| smcginnis | hedvig_01: Commented on there. Yes, the rest of the comments should be addressed before pushing up an update. | 19:22 |
| hedvig_01 | okay Thank you. Will do. | 19:22 |
| smcginnis | Thanks | 19:22 |
| hedvig_01 | @smcginnis : https://review.openstack.org/#/c/433341/64/cinder/tests/unit/volume/drivers/test_hedvig.py | 19:25 |
| hedvig_01 | I was talking about this | 19:25 |
| hedvig_01 | I should have mentioned 64. 63 was a mistake | 19:25 |
| hedvig_01 | line 75 | 19:26 |
| smcginnis | Hmm, sorry, but I have to disagree with that statement. That isn't a very good unit test pattern. | 19:31 |
| smcginnis | If you want to validate that the driver did not have any model updates, then it might be better to have "result = self.driver.create_volume(); self.assertNone(result)" | 19:33 |
| smcginnis | That would make it more clear at least. | 19:33 |
| *** mriedem has joined #openstack-cinder | 19:38 | |
| *** mriedem_afk has quit IRC | 19:41 | |
| e0ne | smcginnis, hedvig_01: sorry if I confused you. try-except was my idea. honestly, I checked if cinder already has this pattern before I pushed commends | 19:54 |
| smcginnis | Really they only make sense in unit tests where ddt is passing in multiple values or a helper method is validating multiple things. But in a normal unit test, we really shouldn't have try/except blocks for anything. | 19:55 |
| smcginnis | Either it should be expected to work and you validate the expected things are called and results are returned, or it fails and you let it blow up and the unit test framework takes care of the exception. | 19:56 |
| hedvig_01 | Okay. I shall modify the code to use AssertNone for my positive tests and assertRaises on my negative tests. | 19:57 |
| e0ne | smcginnis: I don't want to argue with you. sometimes I like try-except in tests not only with ddt | 20:00 |
| e0ne | smcginnis, hedvig_01: but in current case, it's only one of the several issues in tests | 20:00 |
| *** jackivanov has joined #openstack-cinder | 20:00 | |
| hedvig_01 | @e0ne: Agreed. We are working on our unit tests at the moment | 20:01 |
| smcginnis | e0ne: What benefit do you see catching something and explicitly calling fail rather than just letting the unit test take care of it? | 20:01 |
| smcginnis | Unit tests are asserting expected behavior. There really shouldn't ever be a need to catch exceptions in them. | 20:01 |
| e0ne | smcginnis: more clear error message | 20:01 |
| hedvig_01 | We just wanted to make sure we address all the comments we before we checkin | 20:01 |
| e0ne | smcginnis: it depends on test framework. in cinder it's pretty good without try-except | 20:02 |
| smcginnis | e0ne: If it's not clear from the exception, I don't think a fail('generic message') is going to make it much better. | 20:02 |
| e0ne | smcginnis: that's why I said 'more clear error message', not something generic | 20:03 |
| smcginnis | The exception should be clear is my point. | 20:03 |
| e0ne | smcginnis: in an ideal world, they are :) | 20:05 |
| *** edmondsw has quit IRC | 20:10 | |
| e0ne | smcginnis: I totally understand your points and looking throw cinder codebase, I won't ask for try-exept in tests | 20:15 |
| *** itlinux has joined #openstack-cinder | 20:22 | |
| mszwed | jungleboyj: thank you :) | 20:24 |
| *** dave-mccowan has quit IRC | 20:24 | |
| *** dave-mccowan has joined #openstack-cinder | 20:30 | |
| *** jackivanov has quit IRC | 20:32 | |
| *** hedvig_0_ has joined #openstack-cinder | 20:44 | |
| *** hedvig_01 has quit IRC | 20:46 | |
| *** jackivanov has joined #openstack-cinder | 20:48 | |
| *** jackivanov has quit IRC | 20:53 | |
| *** jackivanov has joined #openstack-cinder | 21:01 | |
| openstackgerrit | Merged openstack/cinder-specs master: Fix descriptive issues https://review.openstack.org/626434 | 21:11 |
| *** ganso has quit IRC | 21:18 | |
| openstackgerrit | Merged openstack/python-brick-cinderclient-ext master: Use template for lower-constraints https://review.openstack.org/626732 | 21:22 |
| *** jackivanov has quit IRC | 21:35 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Handle 'is_public' filter in volume-type list https://review.openstack.org/627008 | 21:59 |
| *** _alastor_ has joined #openstack-cinder | 22:06 | |
| *** e0ne has quit IRC | 22:35 | |
| *** mvkr has joined #openstack-cinder | 22:37 | |
| *** mriedem is now known as mriedem_away | 22:49 | |
| *** smcginnis is now known as smcginnis_away | 22:49 | |
| *** lbragstad has quit IRC | 22:50 | |
| *** e0ne has joined #openstack-cinder | 22:51 | |
| *** jackivanov has joined #openstack-cinder | 22:54 | |
| -openstackstatus- NOTICE: the gerrit service on review.openstack.org is being restarted to pick up new configuration changes, and will return momentarily | 22:55 | |
| *** e0ne has quit IRC | 23:21 | |
| *** jackivanov has quit IRC | 23:26 | |
| *** dave-mccowan has quit IRC | 23:26 | |
| *** dims has quit IRC | 23:33 | |
| *** e0ne has joined #openstack-cinder | 23:37 | |
| *** e0ne has quit IRC | 23:38 | |
| *** hedvig_0_ has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!