*** riesalexis has quit IRC | 00:06 | |
*** Liang__ has joined #openstack-cinder | 00:47 | |
*** brinzhang has joined #openstack-cinder | 01:03 | |
*** whoami-rajat has joined #openstack-cinder | 01:08 | |
openstackgerrit | Merged openstack/cinder master: Temporary solution for fixing gate test_tpool_size https://review.openstack.org/630648 | 01:49 |
---|---|---|
*** sapd1_x has joined #openstack-cinder | 01:50 | |
*** TxGirlGeek has quit IRC | 01:52 | |
*** Liang__ has quit IRC | 02:09 | |
*** Liang__ has joined #openstack-cinder | 02:10 | |
*** abishop has quit IRC | 02:11 | |
*** Dinesh_Bhor has joined #openstack-cinder | 02:13 | |
*** mriedem has quit IRC | 02:16 | |
*** bhagyashris has joined #openstack-cinder | 02:21 | |
*** mhen has quit IRC | 02:51 | |
*** mhen has joined #openstack-cinder | 02:54 | |
*** psachin has joined #openstack-cinder | 02:59 | |
*** enriquetaso has quit IRC | 03:02 | |
openstackgerrit | Qian Mingyue proposed openstack/cinder master: Move Fujitsu ETERNUS DX related file https://review.openstack.org/631121 | 03:04 |
openstackgerrit | Yafei Yu proposed openstack/cinder master: Ignore .testr.conf https://review.openstack.org/631122 | 03:09 |
openstackgerrit | Yafei Yu proposed openstack/cinder master: Ignore .testr.conf https://review.openstack.org/631122 | 03:10 |
*** Dinesh_Bhor has quit IRC | 03:26 | |
*** Dinesh_Bhor has joined #openstack-cinder | 03:30 | |
*** sapd1_x has quit IRC | 03:36 | |
*** rcernin has quit IRC | 03:46 | |
*** rcernin has joined #openstack-cinder | 03:48 | |
*** udesale has joined #openstack-cinder | 03:50 | |
*** sapd1_x has joined #openstack-cinder | 03:53 | |
*** gnufied has quit IRC | 04:05 | |
*** bhagyashris has quit IRC | 04:28 | |
*** bhagyashris has joined #openstack-cinder | 04:47 | |
*** rcernin has quit IRC | 05:17 | |
*** rcernin has joined #openstack-cinder | 05:19 | |
*** radeks has joined #openstack-cinder | 05:24 | |
*** udesale has quit IRC | 05:35 | |
*** udesale has joined #openstack-cinder | 05:40 | |
*** rcernin has quit IRC | 05:58 | |
*** rcernin has joined #openstack-cinder | 06:00 | |
*** brinzhang has quit IRC | 06:05 | |
*** jdillaman has quit IRC | 06:26 | |
*** jdillaman has joined #openstack-cinder | 06:26 | |
*** radeks has quit IRC | 06:28 | |
*** martinkennelly has quit IRC | 06:33 | |
*** TxGirlGeek has joined #openstack-cinder | 06:34 | |
*** radeks has joined #openstack-cinder | 06:36 | |
*** TxGirlGeek has quit IRC | 06:40 | |
*** e0ne has joined #openstack-cinder | 06:50 | |
*** Luzi has joined #openstack-cinder | 07:03 | |
*** rcernin has quit IRC | 07:04 | |
*** lpetrut has joined #openstack-cinder | 07:06 | |
*** udesale has quit IRC | 07:11 | |
*** pcaruana has joined #openstack-cinder | 07:12 | |
*** faizy98 has joined #openstack-cinder | 07:17 | |
*** abhishekk has joined #openstack-cinder | 07:22 | |
*** abhishekk has left #openstack-cinder | 07:22 | |
*** udesale has joined #openstack-cinder | 07:24 | |
*** faizy98 has quit IRC | 07:27 | |
*** udesale has quit IRC | 07:29 | |
*** udesale has joined #openstack-cinder | 07:29 | |
*** Dinesh_Bhor has quit IRC | 07:42 | |
*** sapd1 has joined #openstack-cinder | 07:45 | |
*** sapd1_x has quit IRC | 07:46 | |
*** radeks has quit IRC | 07:46 | |
*** Dinesh_Bhor has joined #openstack-cinder | 07:48 | |
*** radeks has joined #openstack-cinder | 07:52 | |
openstackgerrit | Ryan Liang proposed openstack/cinder stable/ocata: Unity: fail to detach lun when auto zone enabled https://review.openstack.org/625855 | 07:53 |
*** Dinesh_Bhor has quit IRC | 07:54 | |
*** Dinesh_Bhor has joined #openstack-cinder | 07:57 | |
*** sapd1_x has joined #openstack-cinder | 07:59 | |
*** Dinesh_Bhor has quit IRC | 08:02 | |
openstackgerrit | yenai proposed openstack/cinder-specs master: Correct multiattach value that set in volume type https://review.openstack.org/631157 | 08:03 |
*** radeks has quit IRC | 08:04 | |
*** tkajinam has joined #openstack-cinder | 08:09 | |
*** phuongnh has joined #openstack-cinder | 08:11 | |
openstackgerrit | Merged openstack/cinder master: Add policy test for volume update/del policy https://review.openstack.org/617543 | 08:18 |
*** riesalexis has joined #openstack-cinder | 08:22 | |
*** phuongnh has quit IRC | 08:33 | |
*** phuongnh has joined #openstack-cinder | 08:34 | |
*** tkajinam has quit IRC | 08:41 | |
*** e0ne has quit IRC | 08:45 | |
*** sapd1_x has quit IRC | 08:46 | |
*** martinkennelly has joined #openstack-cinder | 08:50 | |
*** sapd1_x has joined #openstack-cinder | 09:02 | |
*** Dinesh_Bhor has joined #openstack-cinder | 09:02 | |
*** Dinesh_Bhor has quit IRC | 09:08 | |
*** Bhujay has joined #openstack-cinder | 09:14 | |
*** Bhujay has quit IRC | 09:15 | |
*** Bhujay has joined #openstack-cinder | 09:15 | |
*** Bhujay has quit IRC | 09:16 | |
*** Bhujay has joined #openstack-cinder | 09:17 | |
*** Bhujay has quit IRC | 09:18 | |
*** Bhujay has joined #openstack-cinder | 09:18 | |
*** Bhujay has quit IRC | 09:19 | |
*** Bhujay has joined #openstack-cinder | 09:20 | |
*** Bhujay has quit IRC | 09:21 | |
*** Bhujay has joined #openstack-cinder | 09:21 | |
*** Bhujay has quit IRC | 09:22 | |
*** Bhujay has joined #openstack-cinder | 09:23 | |
*** Bhujay has quit IRC | 09:24 | |
*** Bhujay has joined #openstack-cinder | 09:24 | |
*** Bhujay has quit IRC | 09:25 | |
*** Bhujay has joined #openstack-cinder | 09:26 | |
*** Bhujay has quit IRC | 09:27 | |
*** Bhujay has joined #openstack-cinder | 09:27 | |
*** Bhujay has quit IRC | 09:28 | |
*** Bhujay has joined #openstack-cinder | 09:29 | |
*** Bhujay has quit IRC | 09:30 | |
*** Bhujay has joined #openstack-cinder | 09:30 | |
*** Bhujay has quit IRC | 09:31 | |
*** Bhujay has joined #openstack-cinder | 09:32 | |
*** Dinesh_Bhor has joined #openstack-cinder | 09:32 | |
*** luizbag has joined #openstack-cinder | 09:37 | |
*** Bhujay has quit IRC | 09:37 | |
*** Liang__ has quit IRC | 09:43 | |
*** Dinesh_Bhor has quit IRC | 09:52 | |
*** bhagyashris has quit IRC | 09:54 | |
*** Dinesh_Bhor has joined #openstack-cinder | 10:01 | |
*** jbernard has quit IRC | 10:03 | |
*** Bhujay has joined #openstack-cinder | 10:06 | |
*** Bhujay has quit IRC | 10:07 | |
*** Bhujay has joined #openstack-cinder | 10:07 | |
*** Bhujay has quit IRC | 10:08 | |
*** Bhujay has joined #openstack-cinder | 10:09 | |
*** phuongnh has quit IRC | 10:09 | |
openstackgerrit | Qian Mingyue proposed openstack/cinder master: Move Fujitsu ETERNUS DX related file https://review.openstack.org/631121 | 10:10 |
*** Bhujay has quit IRC | 10:10 | |
*** Bhujay has joined #openstack-cinder | 10:10 | |
*** ganso has joined #openstack-cinder | 10:11 | |
*** Bhujay has quit IRC | 10:11 | |
*** Bhujay has joined #openstack-cinder | 10:12 | |
*** Bhujay has quit IRC | 10:13 | |
*** Bhujay has joined #openstack-cinder | 10:13 | |
openstackgerrit | Qian Mingyue proposed openstack/cinder master: Move Fujitsu ETERNUS DX related file https://review.openstack.org/631121 | 10:13 |
*** Bhujay has quit IRC | 10:14 | |
*** Bhujay has joined #openstack-cinder | 10:15 | |
*** Bhujay has quit IRC | 10:16 | |
*** jbernard has joined #openstack-cinder | 10:16 | |
*** Bhujay has joined #openstack-cinder | 10:16 | |
*** Bhujay has quit IRC | 10:17 | |
*** Bhujay has joined #openstack-cinder | 10:18 | |
*** Bhujay has quit IRC | 10:19 | |
*** Bhujay has joined #openstack-cinder | 10:19 | |
*** Bhujay has quit IRC | 10:20 | |
*** Bhujay has joined #openstack-cinder | 10:21 | |
*** Bhujay has quit IRC | 10:22 | |
*** e0ne has joined #openstack-cinder | 10:22 | |
*** Bhujay has joined #openstack-cinder | 10:22 | |
*** Bhujay has quit IRC | 10:23 | |
*** Bhujay has joined #openstack-cinder | 10:24 | |
*** Bhujay has quit IRC | 10:25 | |
*** Bhujay has joined #openstack-cinder | 10:25 | |
*** Bhujay has quit IRC | 10:26 | |
*** Bhujay has joined #openstack-cinder | 10:27 | |
*** Bhujay has quit IRC | 10:28 | |
*** sapd1_x has quit IRC | 10:28 | |
*** Bhujay has joined #openstack-cinder | 10:28 | |
*** Bhujay has quit IRC | 10:29 | |
*** Bhujay has joined #openstack-cinder | 10:30 | |
*** Bhujay has quit IRC | 10:31 | |
*** Bhujay has joined #openstack-cinder | 10:31 | |
*** Bhujay has quit IRC | 10:32 | |
*** Bhujay has joined #openstack-cinder | 10:33 | |
*** Bhujay has quit IRC | 10:34 | |
*** Bhujay has joined #openstack-cinder | 10:34 | |
*** Bhujay has quit IRC | 10:35 | |
*** Bhujay has joined #openstack-cinder | 10:36 | |
*** Bhujay has quit IRC | 10:37 | |
*** erlon_ has joined #openstack-cinder | 10:37 | |
*** Bhujay has joined #openstack-cinder | 10:37 | |
*** Bhujay has quit IRC | 10:38 | |
*** Bhujay has joined #openstack-cinder | 10:39 | |
*** Bhujay has quit IRC | 10:40 | |
*** Bhujay has joined #openstack-cinder | 10:40 | |
*** Bhujay has quit IRC | 10:41 | |
*** sapd1_x has joined #openstack-cinder | 10:41 | |
*** Bhujay has joined #openstack-cinder | 10:42 | |
*** Bhujay has quit IRC | 10:43 | |
*** Bhujay has joined #openstack-cinder | 10:43 | |
*** Bhujay has quit IRC | 10:44 | |
*** Bhujay has joined #openstack-cinder | 10:45 | |
*** Dinesh_Bhor has quit IRC | 10:45 | |
*** Bhujay has quit IRC | 10:46 | |
*** Bhujay has joined #openstack-cinder | 10:46 | |
*** Bhujay has quit IRC | 10:47 | |
*** Bhujay has joined #openstack-cinder | 10:48 | |
*** Bhujay has quit IRC | 10:49 | |
*** Bhujay has joined #openstack-cinder | 10:49 | |
*** Bhujay has quit IRC | 10:50 | |
*** Bhujay has joined #openstack-cinder | 10:51 | |
*** Bhujay has quit IRC | 10:52 | |
*** Bhujay has joined #openstack-cinder | 10:52 | |
*** Bhujay has quit IRC | 10:53 | |
*** Bhujay has joined #openstack-cinder | 10:54 | |
*** Bhujay has quit IRC | 10:55 | |
*** Bhujay has joined #openstack-cinder | 10:55 | |
*** Bhujay has quit IRC | 10:56 | |
openstackgerrit | Merged openstack/cinder master: LinstorDrv : Fix wrong key using when getting device path. https://review.openstack.org/630930 | 10:56 |
*** Bhujay has joined #openstack-cinder | 10:57 | |
*** Bhujay has quit IRC | 10:58 | |
*** Bhujay has joined #openstack-cinder | 10:58 | |
*** Bhujay has quit IRC | 10:59 | |
*** psachin has quit IRC | 10:59 | |
*** Bhujay has joined #openstack-cinder | 11:00 | |
*** Bhujay has quit IRC | 11:01 | |
*** riesalexis has quit IRC | 11:02 | |
*** Bhujay has joined #openstack-cinder | 11:03 | |
*** udesale has quit IRC | 11:12 | |
*** helenafm has joined #openstack-cinder | 11:14 | |
*** Bhujay has quit IRC | 12:06 | |
*** Bhujay has joined #openstack-cinder | 12:07 | |
openstackgerrit | Yingxin Cheng proposed openstack/cinder master: Cinder RSD Driver https://review.openstack.org/621465 | 12:08 |
*** e0ne has quit IRC | 12:17 | |
*** abishop has joined #openstack-cinder | 12:21 | |
*** udesale has joined #openstack-cinder | 12:42 | |
*** Dinesh_Bhor has joined #openstack-cinder | 12:43 | |
*** e0ne has joined #openstack-cinder | 13:04 | |
*** lemko has joined #openstack-cinder | 13:08 | |
*** Dinesh_Bhor has quit IRC | 13:12 | |
*** Dinesh_Bhor has joined #openstack-cinder | 13:13 | |
*** sapd1_x has quit IRC | 13:18 | |
*** davidsha has joined #openstack-cinder | 13:19 | |
*** lseki has joined #openstack-cinder | 13:21 | |
*** Bhujay has quit IRC | 13:25 | |
*** Bhujay has joined #openstack-cinder | 13:25 | |
*** dave-mccowan has joined #openstack-cinder | 13:26 | |
*** Bhujay has quit IRC | 13:26 | |
*** Bhujay has joined #openstack-cinder | 13:27 | |
*** riesalexis has joined #openstack-cinder | 13:27 | |
*** Dinesh_Bhor has quit IRC | 13:27 | |
*** Bhujay has quit IRC | 13:28 | |
*** Bhujay has joined #openstack-cinder | 13:28 | |
*** Bhujay has quit IRC | 13:29 | |
*** Bhujay has joined #openstack-cinder | 13:30 | |
*** Bhujay has quit IRC | 13:31 | |
*** Bhujay has joined #openstack-cinder | 13:31 | |
*** Bhujay has quit IRC | 13:32 | |
*** Bhujay has joined #openstack-cinder | 13:33 | |
*** Bhujay has quit IRC | 13:34 | |
*** Bhujay has joined #openstack-cinder | 13:34 | |
*** Bhujay has quit IRC | 13:35 | |
*** Bhujay has joined #openstack-cinder | 13:36 | |
*** Bhujay has quit IRC | 13:37 | |
*** Bhujay has joined #openstack-cinder | 13:37 | |
*** Bhujay has quit IRC | 13:38 | |
*** Bhujay has joined #openstack-cinder | 13:39 | |
erlon_ | smcginnis, jungleboyj, hey, do you know why a W+1 patch would not be merged? https://review.openstack.org/#/c/620576/ | 13:40 |
*** Bhujay has quit IRC | 13:40 | |
*** Bhujay has joined #openstack-cinder | 13:40 | |
jungleboyj | erlon_: It is still running through the Gate. | 13:41 |
*** Bhujay has quit IRC | 13:41 | |
jungleboyj | http://zuul.openstack.org/status | 13:42 |
*** Bhujay has joined #openstack-cinder | 13:42 | |
*** Bhujay has quit IRC | 13:43 | |
*** Bhujay has joined #openstack-cinder | 13:43 | |
erlon_ | jungleboyj, I have just rechecked it. It was workflowed on Jan 8 | 13:43 |
*** Bhujay has quit IRC | 13:44 | |
jungleboyj | Oh ... strange. I am not sure what happened then. I have seen it happen before but not sure what causes it. | 13:45 |
*** Bhujay has joined #openstack-cinder | 13:45 | |
*** Bhujay has quit IRC | 13:46 | |
*** Bhujay has joined #openstack-cinder | 13:46 | |
*** mvkr has quit IRC | 14:26 | |
smcginnis | erlon_: That's just wasting gate resources. It needs to be rebased off of https://review.openstack.org/#/c/620575/ | 14:28 |
smcginnis | It won't merge until its parent merges and we don't want that. | 14:29 |
jungleboyj | smcginnis: Ugh. Good catch. Shouldn't answer questions early in the morning. | 14:31 |
*** mriedem has joined #openstack-cinder | 14:31 | |
*** radeks has joined #openstack-cinder | 14:39 | |
luizbag | "mornings are for coffee and contemplation" | 14:41 |
*** eharney has joined #openstack-cinder | 14:41 | |
smcginnis | ;) | 14:42 |
jungleboyj | For some reason my coffee came out much weaker than it should have this morning. Not a good thing. | 14:45 |
luizbag | :D | 14:45 |
rosmaita | jungleboyj needs https://www.deathwishcoffee.com/ -- as used by professionals | 14:47 |
jungleboyj | rosmaita: ++ | 14:47 |
*** radeks has quit IRC | 14:49 | |
*** gouthamr has quit IRC | 14:54 | |
smcginnis | I haven't had that for awhile. Good stuff. | 14:55 |
*** enriquetaso has joined #openstack-cinder | 15:01 | |
*** Bhujay has quit IRC | 15:06 | |
woojay | smcginnis: Thank you for the +2 at 3am. | 15:07 |
smcginnis | woojay: Yay insomnia. \o/ | 15:08 |
woojay | oh man... | 15:08 |
rosmaita | sounds like smcginnis doesn't need any death wish coffee | 15:08 |
smcginnis | heh | 15:08 |
jungleboyj | smcginnis: Are you still jet lagged? | 15:21 |
jungleboyj | Or the thought of having a daughter in college keeping you up? :-) | 15:21 |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder-tempest-plugin master: Fix volume revert to snapshot tests https://review.openstack.org/620576 | 15:24 |
smcginnis | jungleboyj: Hah, maybe a little of both? | 15:25 |
jungleboyj | :-) | 15:25 |
openstackgerrit | NolwennCauchois proposed openstack/cinder master: Fix quota error when deleting snapshot group https://review.openstack.org/626863 | 15:27 |
*** Luzi has quit IRC | 15:36 | |
*** lpetrut has quit IRC | 15:46 | |
*** lemko has quit IRC | 15:48 | |
*** gnufied has joined #openstack-cinder | 15:52 | |
*** udesale has quit IRC | 15:56 | |
*** Liang__ has joined #openstack-cinder | 15:56 | |
*** Liang__ is now known as LiangFang | 15:59 | |
*** TxGirlGeek has joined #openstack-cinder | 15:59 | |
openstackgerrit | NolwennCauchois proposed openstack/cinder master: Fix quota error when deleting snapshot group https://review.openstack.org/626863 | 16:01 |
*** carlos_silva has joined #openstack-cinder | 16:03 | |
*** phuongnh has joined #openstack-cinder | 16:05 | |
*** radeks has joined #openstack-cinder | 16:06 | |
*** phuongnh has quit IRC | 16:10 | |
openstackgerrit | Merged openstack/cinder-specs master: Correct multiattach value that set in volume type https://review.openstack.org/631157 | 16:15 |
*** chrisyang_0660 has joined #openstack-cinder | 16:18 | |
chrisyang_0660 | Hi team, please help to review our patch. | 16:24 |
chrisyang_0660 | https://review.openstack.org/#/c/627866/ | 16:24 |
chrisyang_0660 | We just fix our incorrect CI setting, so finally the CI test is passed. | 16:24 |
chrisyang_0660 | Thanks~ | 16:24 |
*** pcaruana has quit IRC | 16:25 | |
*** LiangFang has quit IRC | 16:36 | |
*** gouthamr has joined #openstack-cinder | 16:45 | |
*** mvkr has joined #openstack-cinder | 16:46 | |
*** e0ne_ has joined #openstack-cinder | 16:50 | |
*** e0ne has quit IRC | 16:50 | |
ganso | jungleboyj: hey Jay! quick question: E-series driver has been deprecated. If there is ever a fix for the code that is currently in stable branches, is that fix allowed to be merged in stable branches without being merged on master? Or would not be allowed for this driver to receive fixes anymore because it does not exist in master? | 17:01 |
davidsha | ping | 17:02 |
smcginnis | ganso: Stable policy allows for that. It just needs to go to the most recent stable branch that does contain that driver first before being backported to other stable branches. | 17:02 |
ganso | smcginnis: thanks! | 17:02 |
davidsha | smcginnis: Did you mean Train in your comment or Stein? | 17:04 |
smcginnis | Oh, yep. Too many names. | 17:04 |
jungleboyj | smcginnis: Thanks for clarifying that. | 17:05 |
davidsha | smcginnis, jungleboyj : kk, whats the path forward now? It won't get merged until Train, does a new patch need to be submitted? | 17:05 |
jungleboyj | davidsha: No. Just continue to work the existing patch and keep CI running. | 17:06 |
davidsha | kk, will do! | 17:06 |
jungleboyj | As soon as we open Train for development we will merge the code. | 17:07 |
whoami-rajat | jungleboyj: maybe this is the same case ? https://review.openstack.org/#/c/617503/ | 17:07 |
jungleboyj | davidsha: Appreciate the understanding and we are looking forward to getting the driver in. | 17:07 |
smcginnis | Sorry, I appreciate you and the folks there have been working hard on this. But we need to stick to our deadlines. Looks like it's close enough that there shouldn't be any question of merging as soon as Train opens up. | 17:07 |
jungleboyj | smcginnis: ++ | 17:08 |
*** e0ne_ has quit IRC | 17:18 | |
*** martinkennelly has quit IRC | 17:25 | |
hemna | mep | 17:33 |
hemna | the use_multipath_for_image_xfer option belongs in the driver stanza doesn't it? | 17:34 |
hemna | from what I remember | 17:34 |
hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2092-L2095 | 17:35 |
*** helenafm has quit IRC | 17:47 | |
*** davidsha has quit IRC | 17:49 | |
hemna | man I haven't stood up devstack in ages | 18:25 |
hemna | .... | 18:25 |
*** riesalexis has quit IRC | 18:29 | |
openstackgerrit | Merged openstack/cinder master: Avoid using 'truncate' on Windows https://review.openstack.org/630168 | 18:45 |
*** lseki has quit IRC | 19:04 | |
erlon_ | smcginnis, hey, can you please re-flow that patch? https://review.openstack.org/#/c/620576/ | 19:09 |
smcginnis | erlon_: Done! | 19:10 |
erlon_ | smcginnis, thanks!! | 19:10 |
*** gouthamr_ has joined #openstack-cinder | 19:16 | |
*** mvkr has quit IRC | 19:24 | |
*** luizbag has quit IRC | 19:34 | |
*** mriedem has quit IRC | 19:40 | |
*** carlos_silva has quit IRC | 19:41 | |
*** mriedem has joined #openstack-cinder | 19:41 | |
*** e0ne has joined #openstack-cinder | 19:46 | |
*** eharney has quit IRC | 19:47 | |
*** dklyle has quit IRC | 19:57 | |
*** dklyle has joined #openstack-cinder | 19:57 | |
*** erlon_ has quit IRC | 20:06 | |
*** TxGirlGeek has quit IRC | 20:06 | |
*** zul has quit IRC | 20:09 | |
*** TxGirlGeek has joined #openstack-cinder | 20:10 | |
*** mvkr has joined #openstack-cinder | 20:18 | |
*** erlon has joined #openstack-cinder | 20:35 | |
*** whoami-rajat has quit IRC | 20:37 | |
*** lpetrut has joined #openstack-cinder | 20:43 | |
*** e0ne has quit IRC | 20:44 | |
*** e0ne has joined #openstack-cinder | 20:45 | |
*** TxGirlGeek has quit IRC | 20:45 | |
*** e0ne has quit IRC | 20:48 | |
hemna | arg | 20:54 |
hemna | I think I just found an issue w/ attaches | 20:54 |
hemna | looks like there is an issue with copy volume to image | 20:54 |
*** eharney has joined #openstack-cinder | 20:55 | |
hemna | @smcginnis https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2092-L2101 | 20:55 |
hemna | if remote=True, then the connector properties is incorrect there. | 20:55 |
hemna | because the attach is going to happen on another cinder host, but yet the connector is for the local host. | 20:55 |
hemna | oopsie | 20:56 |
*** TxGirlGeek has joined #openstack-cinder | 20:56 | |
hemna | smcginnis: ping | 21:00 |
hemna | jungleboyj: ping | 21:00 |
jungleboyj | hemna: Ping. | 21:01 |
hemna | read above ? | 21:01 |
hemna | there is a potential issue with attaches that I think I found in the volume manager | 21:01 |
hemna | where the connector isn't the right connector | 21:01 |
jungleboyj | Ugh. Ok. | 21:02 |
hemna | _copy_volume_data() gets the connector from brick | 21:02 |
hemna | then decides if the call is a 'remote' call or not and passes that remote param into _attach_volume() | 21:02 |
hemna | if remote = True, then _attach_volume() will call the api to execute the initialize_connection call on a remote c-vol node | 21:02 |
hemna | in which case the connector is in valid | 21:02 |
hemna | err invalid | 21:03 |
hemna | the connector is only valid for the host that is doing the attach | 21:03 |
hemna | not sure where this idea of remote came from | 21:03 |
smcginnis | Isn't that some of them like the NFS driver? | 21:03 |
smcginnis | I would think we'd be seeing some failures if that's not correct. | 21:04 |
hemna | this is all before the driver is called | 21:04 |
smcginnis | hemna: Did you hit an error, or just notice that it looked odd. | 21:04 |
hemna | I am trying to track down some odd customer deployment behavior related to attaches | 21:04 |
smcginnis | eharney: You know anything about the "remote" connections? | 21:04 |
hemna | and I just realized the issue by reading the code | 21:04 |
hemna | the connector has to be the data from the host that is trying to attach the volume from the backend | 21:05 |
jungleboyj | How is the 'remote' c-vol node determined? | 21:05 |
*** lpetrut has quit IRC | 21:05 | |
hemna | remote is passed in to _copy_volume_data | 21:05 |
hemna | and then parsed and used to determine if the volume manager has to make an rpcapi call or not | 21:06 |
hemna | I'm not sure where it came from originally | 21:06 |
jungleboyj | hemna: Ah, ok. | 21:06 |
smcginnis | Yeah, looks like that's for file. | 21:08 |
*** radeks has quit IRC | 21:08 | |
smcginnis | "Remote" meaning non-attachable. | 21:08 |
jungleboyj | So if remote is used does a new connector need to be created? | 21:08 |
smcginnis | Been that way since at least Newton - https://github.com/openstack/cinder/commit/f586043fa969b9d1dcf4933aacbf615f53691093 | 21:08 |
hemna | yah it's been 4 years | 21:09 |
hemna | heh | 21:09 |
hemna | the connector should always be the data from the host attaching the volume | 21:09 |
smcginnis | I don't believe with those that matters since the connection is a remote filesystem. | 21:10 |
hemna | it was introduced to help volume migration | 21:10 |
hemna | for lvm to ceph, nfs to ceph | 21:10 |
smcginnis | jbernard: Remember enough details to verify current code for that is right? ^^ | 21:11 |
openstackgerrit | Merged openstack/cinder-tempest-plugin master: Fix volume revert to snapshot tests https://review.openstack.org/620576 | 21:12 |
hemna | so if remote is not passed in it's None | 21:16 |
hemna | and then remote becomes False | 21:16 |
hemna | which means the connector is valid | 21:16 |
hemna | but it's true from copy_volume_generic | 21:17 |
hemna | err migrate_volume_generic | 21:19 |
hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2219-L2223 | 21:19 |
*** ganso has quit IRC | 21:20 | |
hemna | so most likely not my customer's situation | 21:21 |
hemna | _migrate_volume_generic is only called if the driver didn't migrate the volume | 21:21 |
hemna | which can happen if the dest and src drivers aren't the same | 21:21 |
hemna | 3par -> lvm | 21:21 |
hemna | lvm -> ceph | 21:21 |
hemna | etc | 21:21 |
*** TxGirlGeek has quit IRC | 21:21 | |
hemna | so in that case I think it's still a potential issue | 21:22 |
hemna | the connector is for the source, not the dest host | 21:22 |
hemna | if c-vol is only running 1 instance on 1 host, then it's fine | 21:23 |
hemna | could be a problem if one is running fault tolerant c-vol's for the same backend on 2 hosts. | 21:23 |
hemna | connector won't be acurate | 21:23 |
*** TxGirlGeek has joined #openstack-cinder | 21:30 | |
*** abishop has quit IRC | 21:46 | |
*** gouthamr has quit IRC | 21:56 | |
*** gouthamr_ is now known as gouthamr | 21:56 | |
*** imacdonn has quit IRC | 22:07 | |
*** imacdonn has joined #openstack-cinder | 22:07 | |
* jbernard reads the backlog | 22:20 | |
jbernard | hemna: if they're fault tolerant, a 'cluster' will be used? | 22:22 |
jbernard | hemna: in that case the orignial host value may be ignored in favor of the cluster name | 22:22 |
jbernard | hemna: but still, im not entirely sure im following the problem | 22:22 |
*** erlon has quit IRC | 22:29 | |
*** itlinux has joined #openstack-cinder | 22:36 | |
openstackgerrit | Merged openstack/cinder master: Add irrelevant-files for integrated test jobs https://review.openstack.org/624975 | 22:43 |
*** rcernin has joined #openstack-cinder | 22:45 | |
*** threestrands has joined #openstack-cinder | 22:51 | |
*** TxGirlGeek has quit IRC | 23:07 | |
*** TxGirlGeek has joined #openstack-cinder | 23:12 | |
*** enriquetaso has quit IRC | 23:30 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!