Monday, 2019-01-28

openstackgerritBrin Zhang proposed openstack/cinder master: api-ref: Add cipher to update an encryption type interface  https://review.openstack.org/62539100:04
*** dklyle has joined #openstack-cinder00:16
*** brinzhang has joined #openstack-cinder00:26
*** dklyle has quit IRC00:31
*** e0ne has quit IRC00:32
*** whoami-rajat has joined #openstack-cinder00:49
*** baojg has joined #openstack-cinder01:00
*** jistr has quit IRC01:00
*** jistr has joined #openstack-cinder01:01
*** zengyingzhe has joined #openstack-cinder01:19
*** mmethot_ has joined #openstack-cinder01:19
*** mmethot_ has quit IRC01:20
*** mmethot has quit IRC01:23
*** zengyingzhe_ has joined #openstack-cinder01:31
*** Dinesh_Bhor has joined #openstack-cinder01:36
*** markvoelker has joined #openstack-cinder01:39
*** khomesh|OOO is now known as khomesh01:47
*** khomesh is now known as khomesh|afk01:49
*** khomesh|afk is now known as khomesh01:50
openstackgerritfutaotao proposed openstack/cinder master: Amend: Add the release notes on FusionStorage Driver Refacto  https://review.openstack.org/63298301:53
openstackgerritfutaotao proposed openstack/cinder master: Amend: Add the release notes on FusionStorage Driver Refacto  https://review.openstack.org/63298301:54
openstackgerritChris Yang proposed openstack/cinder master: QNAP: Add support for QTS 4.4.0  https://review.openstack.org/63295301:56
*** enriquetaso has quit IRC02:00
*** markvoelker has quit IRC02:12
*** tkajinam_ has joined #openstack-cinder02:19
*** tkajinam has quit IRC02:21
*** sapd1 has joined #openstack-cinder02:22
*** phuongnh has joined #openstack-cinder02:25
*** khomesh is now known as khomesh|afk02:29
*** khomesh|afk is now known as khomesh02:46
*** khomesh is now known as khomesh|bfst02:57
*** psachin has joined #openstack-cinder03:01
*** whoami-rajat has quit IRC03:09
*** markvoelker has joined #openstack-cinder03:09
*** mmethot has joined #openstack-cinder03:36
*** sapd1 has quit IRC03:39
*** markvoelker has quit IRC03:42
*** sapd1 has joined #openstack-cinder03:55
*** Dinesh_Bhor has quit IRC04:15
*** Dinesh_Bhor has joined #openstack-cinder04:16
*** Bhujay has joined #openstack-cinder04:24
*** Bhujay has quit IRC04:25
*** Bhujay has joined #openstack-cinder04:26
*** Bhujay has quit IRC04:27
*** spsurya has joined #openstack-cinder04:28
*** Bhujay has joined #openstack-cinder04:28
*** lifeless has quit IRC04:31
*** markvoelker has joined #openstack-cinder04:39
*** lifeless has joined #openstack-cinder04:51
*** khomesh|bfst is now known as khomesh04:55
*** imacdonn has quit IRC04:59
*** imacdonn has joined #openstack-cinder04:59
*** tkajinam_ is now known as tkajinam05:03
*** markvoelker has quit IRC05:11
*** tkajinam has quit IRC05:31
*** Bhujay has quit IRC05:48
*** Bhujay has joined #openstack-cinder06:01
*** baojg has quit IRC06:03
*** tkajinam has joined #openstack-cinder06:13
*** vishakha has joined #openstack-cinder06:19
*** zengyingzhe_ has quit IRC06:27
*** sapd1 has quit IRC06:32
*** imacdonn has quit IRC06:34
openstackgerrityenai proposed openstack/python-cinderclient master: Fix incorrect punctuation  https://review.openstack.org/63343906:40
*** Luzi has joined #openstack-cinder06:47
*** markvoelker has joined #openstack-cinder07:09
*** fnordahl has joined #openstack-cinder07:19
*** gkadam has joined #openstack-cinder07:22
*** ircuser-1 has joined #openstack-cinder07:22
*** markvoelker has quit IRC07:42
*** Bhujay has quit IRC07:44
openstackgerritfutaotao proposed openstack/cinder master: Amend: Add the release notes on FusionStorage Driver Refactor  https://review.openstack.org/63298307:50
*** lpetrut has joined #openstack-cinder07:50
*** pcaruana has joined #openstack-cinder08:01
*** tkajinam has quit IRC08:15
openstackgerritRyan Liang proposed openstack/cinder master: Unity: Add replication support  https://review.openstack.org/63345108:16
*** mszwed has joined #openstack-cinder08:23
*** markvoelker has joined #openstack-cinder08:39
openstackgerritYikun Jiang proposed openstack/cinder master: Support transfer pagination  https://review.openstack.org/60218108:40
*** lpetrut has quit IRC08:57
*** tosky has joined #openstack-cinder09:00
*** markvoelker has quit IRC09:12
*** whoami-rajat has joined #openstack-cinder09:18
*** mmethot has quit IRC09:19
*** mmethot has joined #openstack-cinder09:21
openstackgerritGorka Eguileor proposed openstack/cinder master: Fix VolumeAttachment is not bound to a Session  https://review.openstack.org/63254909:28
openstackgerritGorka Eguileor proposed openstack/cinder master: Import the cinderlib code  https://review.openstack.org/62066909:29
openstackgerritGorka Eguileor proposed openstack/cinder master: Add cinderlib docs  https://review.openstack.org/62067009:29
openstackgerritGorka Eguileor proposed openstack/cinder master: Add cinderlib functional tests  https://review.openstack.org/62067109:29
*** e0ne has joined #openstack-cinder09:38
*** luizbag has joined #openstack-cinder09:41
*** ganso has joined #openstack-cinder09:43
*** e0ne has quit IRC09:58
*** khomesh is now known as khomesh|afk10:00
*** khomesh|afk is now known as khomesh|gone10:00
*** e0ne has joined #openstack-cinder10:02
*** sapd1 has joined #openstack-cinder10:10
*** markvoelker has joined #openstack-cinder10:10
*** erlon has joined #openstack-cinder10:22
*** markvoelker has quit IRC10:43
*** psachin has quit IRC10:45
*** brinzhang has quit IRC10:56
*** e0ne has quit IRC11:03
*** e0ne has joined #openstack-cinder11:10
*** mvkr has joined #openstack-cinder11:11
*** Dinesh_Bhor has quit IRC11:32
*** markvoelker has joined #openstack-cinder11:40
*** psachin has joined #openstack-cinder11:42
*** whoami-rajat has quit IRC11:45
*** lemko has joined #openstack-cinder11:45
*** sapd1 has quit IRC12:04
*** markvoelker has quit IRC12:13
*** e0ne has quit IRC12:20
*** phuongnh has quit IRC12:30
*** e0ne has joined #openstack-cinder12:35
*** pcaruana has quit IRC12:36
*** pcaruana has joined #openstack-cinder12:37
*** khomesh|gone is now known as khomesh13:01
*** rosmaita has joined #openstack-cinder13:05
*** baojg has joined #openstack-cinder13:14
*** e0ne has quit IRC13:17
*** e0ne has joined #openstack-cinder13:20
*** whoami-rajat has joined #openstack-cinder13:26
openstackgerritIvan Kolodyazhny proposed openstack/cinder master: Do not check available space for image convertion on block devices  https://review.openstack.org/63350013:27
*** abishop has joined #openstack-cinder13:29
*** pcaruana has quit IRC13:32
*** psachin has quit IRC13:41
*** mriedem has joined #openstack-cinder13:43
*** enriquetaso has joined #openstack-cinder13:43
*** pcaruana has joined #openstack-cinder13:50
*** mmethot has quit IRC13:53
*** mmethot has joined #openstack-cinder13:53
*** mmethot_ has joined #openstack-cinder14:00
openstackgerritMerged openstack/cinder master: Use renamed template 'integrated-gate-py3'  https://review.openstack.org/62608314:00
openstackgerritMerged openstack/cinder master: api-ref: Add cipher to update an encryption type interface  https://review.openstack.org/62539114:00
*** mmethot_ has quit IRC14:02
*** mmethot_ has joined #openstack-cinder14:03
*** jmlowe has quit IRC14:03
*** mmethot has quit IRC14:04
*** mmethot_ has quit IRC14:07
*** mmethot_ has joined #openstack-cinder14:07
*** mmethot_ has quit IRC14:08
*** mmethot_ has joined #openstack-cinder14:08
*** dave-mccowan has joined #openstack-cinder14:09
*** enriquetaso has quit IRC14:11
*** enriquetaso has joined #openstack-cinder14:16
*** mmethot_ has quit IRC14:25
*** mmethot_ has joined #openstack-cinder14:26
*** avishay has joined #openstack-cinder14:28
avishayHey all, are you still accepting specs for stein?14:28
rosmaitaavishay: "All Cinder Specs must be approved by 10 Jan 2019 (23:59 UTC)."14:31
*** mmethot_ has quit IRC14:33
*** mmethot_ has joined #openstack-cinder14:34
avishayI guess not.  I'm not sure my change is so big as to require a spec.  I opened a blueprint here: https://blueprints.launchpad.net/cinder/+spec/validate-volume-wwn-upon-connect14:35
avishayBasically each driver that wants to support this will return the wwn in initialize_connection, and os-brick will have a simple check to validate the wwn14:35
*** eharney has joined #openstack-cinder14:35
*** itlinux has quit IRC14:37
*** lseki has joined #openstack-cinder14:38
*** arne_wiebalck_ has joined #openstack-cinder14:39
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  code cleanup and minor improvements  https://review.openstack.org/62558114:42
*** mvkr has quit IRC14:44
*** TxGirlGeek has joined #openstack-cinder14:48
smcginnisavishay: I think that can be considered a bug fix. Especially with the data corruption you mention in the bp.14:51
smcginnisavishay: Have you actually seen a case where that corruption has happened?14:52
avishaysmcginnis: several unfortunately14:52
smcginnisThat's not good. We should definitely handle that better then.14:52
rosmaitaavishay: which drivers?14:52
avishaysmcginnis: close the bp and open a bug instead?14:52
avishayrosmaita: Pure, but it's not related to the storage, it's due to cleanup (or lack thereof) of devices on the host14:53
smcginnisavishay: We can probably use the bp, but I would say if there is any question about it that we can point out that it does fix a bug. Just extra ammunition that it should still be accepted.14:53
avishaysmcginnis: OK, so bp but no spec?14:53
avishaySorry, I'm a bit rusty on the process :)14:54
rosmaitait sounds like a bug that requires a coordinated change across all drivers?14:54
avishayThe change doesn't need to be coordinated.  If the wwn is provided, it will be verified.  If not, then no verification will be done.14:54
smcginnisavishay: If it's not an extensive change that we will need to document for other developers to understand, then bp should be good enough. IMO.14:54
avishaysmcginnis: OK, let's try.  Thanks.14:55
rosmaitaavishay: except that the bug can't be closed until all drivers have made the fix, right?14:55
*** TxGirlGeek has quit IRC14:56
avishayrosmaita: smcginnis said to use the bp, not open a bug14:58
smcginnisDo we need to track changes in drivers?14:58
smcginnisIf so, then we should open bugs for each individual one detailing what they need to change so we can track them and make sure the driver maintainers know that they have something they should do.14:59
*** gnufied has joined #openstack-cinder15:04
*** jmlowe has joined #openstack-cinder15:06
*** zul has joined #openstack-cinder15:06
avishayOK, I'll submit the os-brick change first, and if that gets through I'll open the 100 bugs? :)15:08
*** Luzi has quit IRC15:18
*** jdillaman has quit IRC15:18
*** mvkr has joined #openstack-cinder15:19
jungleboyjavishay:  Just catching up here.15:21
avishayjungleboyj: Hey man15:21
jungleboyjavishay:  Hey, long time no talk.  :-)15:21
avishay:)15:21
jungleboyjSo, given data corruption I think we should get this fixed.  Agree we don't need a Spec.15:22
jungleboyjavishay:  Are all drivers impacted by this?15:22
avishayYes15:22
jungleboyjOk ... What is the change required in drivers?15:23
avishaySo far I opened a bug on os-brick, and will add the verification there.  Then I guess I'll take a week to open bugs on all the drivers :)15:23
jungleboyjOk, os-brick bug makes sense as the starting point.15:23
avishayIn initialize_connection to return the expected WWN.  I'll submit the change for Pure.15:23
avishayThen others can see how to do it15:23
jungleboyjOk.  There has got to be a better way to deal with fixing this than opening 80+ bugs.15:24
avishayI sure hope so15:25
rosmaitai would hope so!15:25
jungleboyj:-)  But I feel like we should track it somehow.15:25
smcginnisWe should probably at least bring it up in the weekly meeting and/or the midcycle.15:25
rosmaitaavishay: your plan sounds like the right way to go on this, change in os-brick with a reference implementation on the driver side15:25
jungleboyjsmcginnis:  ++15:25
avishayI checked in launchpad, I hoped I could add many components on the same bug, but each project can only be added once15:26
jungleboyjWould it make sense to open a general bug and associate it with an etherpad where we can list what drivers have fixed this?15:26
jungleboyjOr, list all the drivers and mark which ones have merged a fix.  Guess that would make more sense.15:26
geguileosounds like a nice feature to add15:27
geguileoat it should be "cheap" to implement on the os-brick side15:27
geguileoand like avishay said, drivers can add the feature as they see fit15:27
avishaygeguileo: thanks, was hoping for your feedback15:28
jungleboyjgeguileo:  Feature?  Avoiding data corruption is a good feature.  :-)15:28
geguileoindeeed!!!15:28
avishaygeguileo: do you think it would be even better in os-brick to check for the expected devices before starting the connection and clean them up?  Assuming that if a device exists before the connect it is garbage that needs to be cleaned?15:29
avishay(in addition to validating WWN)15:29
geguileoavishay: that's a lot harder to do...15:29
avishayYes, but worthwhile?15:30
geguileonot "harder" as in really, really hard, but just considerably harder than the simple validation15:30
geguileoin my opinion this all comes down to: Nova not doing things right15:30
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax Driver - Replication Settings Fix  https://review.openstack.org/63211215:30
geguileoSystem not having the right packages installed15:30
geguileoSo I wouldn't put too much effort into ti15:30
geguileoti=it15:30
avishayAgree, I want to add the simple validation first15:31
avishayWell, I think we can still have cases with garbage devices left over, like nova-compute going down in unfortunate times, network issues, etc.15:31
geguileoAnd we should properly document the connection properties15:32
geguileoavishay: those are not garbage devices15:32
geguileoavishay: Nova will have them in the DB15:32
geguileoand will reconnect or clean them up on start, right?15:32
*** mchlumsky has joined #openstack-cinder15:33
avishayWell I guess they should be cleaned up at some point by Nova, yes.  Does it do that?15:34
geguileoavishay: for me that falls into the bag of: "it's Nova's problem"15:35
geguileo};-)15:35
geguileoThere's a point where we don't want to add more and more code in os-brick to take into account all potential things that the users of the library could do wrong15:36
avishayOK, so I guess it's fair that os-brick will validate and Nova will have to clean up15:36
geguileobecause those are endless15:36
geguileo(although the wwn check is awesome)15:36
*** mchlumsky has quit IRC15:36
avishayCool, thanks15:36
*** mchlumsky has joined #openstack-cinder15:37
*** sapd1 has joined #openstack-cinder15:37
*** mvkr has quit IRC15:39
avishayI added it to the agenda for Wednesday's meeting15:40
geguileoavishay: thanks15:42
jungleboyjavishay:  Sounds good and I added a follow-up at the mid-cycle in case we need it.15:50
*** openstackgerrit has quit IRC15:51
*** mvkr has joined #openstack-cinder15:53
avishayCool15:55
*** openstackgerrit has joined #openstack-cinder15:58
openstackgerritChuck Short proposed openstack/cinder master: Remove truncate from rootwrap filters  https://review.openstack.org/63024415:58
*** gkadam has quit IRC16:00
*** TxGirlGeek has joined #openstack-cinder16:04
*** lemko has quit IRC16:05
*** dklyle has joined #openstack-cinder16:06
*** itlinux has joined #openstack-cinder16:06
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver - solve issue of concurrent snapvx operations  https://review.openstack.org/63153416:13
*** _alastor_ has quit IRC16:15
*** _alastor_ has joined #openstack-cinder16:17
*** arne_wiebalck_ has quit IRC16:17
*** baojg has quit IRC16:18
*** avishay has quit IRC16:23
*** sapd1 has quit IRC16:25
e0nejungleboyj: hi. could you please take a look on https://review.openstack.org/#/c/625041/ once you have a time? what should we do to backport it?16:32
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver - do the portgroup check earlier  https://review.openstack.org/63181016:32
jungleboyje0ne:  Hmmm, did I mess that one up?16:33
jungleboyjThe one it is being cherry picked from was back in late 2017.16:33
smcginnisOriginal merged Oct 2017.16:34
jungleboyjThat would have been queens wouldn't it?16:34
smcginnisjungleboyj: Yep - https://releases.openstack.org/queens/schedule.html16:34
e0nejungleboyj, smcginnis: I didn't look on dates. just checked in the stable/* branches16:34
eharneygerrit tells you if you click "Included In" on the review16:34
smcginniseharney: Where is included in?16:35
eharneyhttps://review.openstack.org/#/c/502473/   upper right under the search box16:35
jungleboyjeharney:  Awesome!16:35
jungleboyjThat is really good to know.16:35
smcginnisAh, on the original one.16:35
e0neeharney: thanks! it's really useful feature16:36
jungleboyje0ne:  Fixed.16:36
e0nejungleboyj: thanks. now I'm feeling OK to +2 on it16:37
jungleboyje0ne:  Sure.16:37
e0nejungleboyj: I just want to be sure that I didn't miss anything with stable policies16:37
jungleboyje0ne:  Nope, you missed me not looking close enough at the original patch.16:38
e0nejungleboyj: :)16:38
*** pcaruana has quit IRC16:47
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  move pagination code to request  https://review.openstack.org/63013116:49
*** KeithMnemonic has joined #openstack-cinder17:00
*** dims has quit IRC17:08
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver - handle special case where IG exists  https://review.openstack.org/63324017:10
*** mmethot_ has quit IRC17:26
*** mmethot_ has joined #openstack-cinder17:27
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  code cleanup and minor improvements  https://review.openstack.org/62558117:29
*** mmethot_ has quit IRC17:29
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  code cleanup and minor improvements  https://review.openstack.org/62558117:30
*** sdake has quit IRC17:34
*** whoami-rajat has quit IRC17:35
*** sdake has joined #openstack-cinder17:37
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax Driver - Replication Settings Fix  https://review.openstack.org/63211217:41
*** e0ne has quit IRC17:42
rosmaitasmcginnis: jungleboyj: when you have a few minutes, real quick review -- https://review.openstack.org/#/c/623126/ -- completes the default policy file name business17:46
smcginnisOn it, thanks rosmaita17:51
*** mvkr has quit IRC17:51
rosmaitanp17:51
*** sdake has quit IRC17:51
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver - solve issue of concurrent snapvx operations  https://review.openstack.org/63153417:52
*** sdake_ has joined #openstack-cinder17:52
*** sdake_ has quit IRC17:53
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver - do the portgroup check earlier  https://review.openstack.org/63181017:55
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  move pagination code to request  https://review.openstack.org/63013117:56
openstackgerritSofia Enriquez proposed openstack/cinder stable/ocata: ScaleIO Driver - adding cache and refactoring tests  https://review.openstack.org/63357017:57
*** mvkr has joined #openstack-cinder17:58
*** whoami-rajat has joined #openstack-cinder18:02
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver - handle special case where IG exists  https://review.openstack.org/63324018:04
*** sdake_ has joined #openstack-cinder18:13
*** sdake_ is now known as sdkae18:14
*** mvkr has quit IRC18:51
*** e0ne has joined #openstack-cinder18:59
*** dave-mccowan has quit IRC19:00
*** jmlowe has quit IRC19:08
*** dave-mccowan has joined #openstack-cinder19:09
*** spsurya has quit IRC19:14
*** dims has joined #openstack-cinder19:15
*** luizbag has quit IRC19:15
*** arne_wiebalck_ has joined #openstack-cinder19:30
*** dave-mccowan has quit IRC19:34
*** imacdonn has joined #openstack-cinder19:35
*** mmethot has joined #openstack-cinder19:42
*** jmlowe has joined #openstack-cinder19:44
*** jmlowe has quit IRC20:09
openstackgerritThiago Correa proposed openstack/cinder master: NetApp SolidFire: Fix python3 issues  https://review.openstack.org/63359620:23
openstackgerritSofia Enriquez proposed openstack/cinder stable/ocata: ScaleIO Driver - adding cache and refactoring tests  https://review.openstack.org/63357020:24
*** jmlowe has joined #openstack-cinder20:28
*** whoami-rajat has quit IRC20:35
openstackgerritEric Harney proposed openstack/cinder master: Fix Snapshot object metadata loading  https://review.openstack.org/63359920:35
*** arne_wiebalck_ has quit IRC20:37
*** TxGirlGeek has quit IRC20:40
*** lseki has quit IRC20:45
*** erlon has quit IRC20:45
*** jmlowe has quit IRC20:50
*** TxGirlGeek has joined #openstack-cinder21:02
*** ganso has quit IRC21:18
*** mmethot has quit IRC21:31
*** abishop has quit IRC21:56
*** enriquetaso has quit IRC22:00
*** eharney has quit IRC22:00
*** sdkae has quit IRC22:03
*** sdake has joined #openstack-cinder22:05
*** rcernin has joined #openstack-cinder22:12
*** rcernin has quit IRC22:15
*** rcernin has joined #openstack-cinder22:15
*** itlinux has quit IRC22:27
*** jmlowe has joined #openstack-cinder22:30
*** e0ne has quit IRC22:36
*** sdake has quit IRC22:45
*** sdake has joined #openstack-cinder22:46
*** sdake has quit IRC22:46
*** sdake has joined #openstack-cinder22:48
*** TxGirlGeek has quit IRC22:54
*** sdake has quit IRC22:57
*** sdake has joined #openstack-cinder22:58
*** TxGirlGeek has joined #openstack-cinder23:00
*** sdake has quit IRC23:01
*** sdake has joined #openstack-cinder23:02
*** tkajinam has joined #openstack-cinder23:09
*** mriedem has quit IRC23:15
*** TxGirlGeek has quit IRC23:32
*** mchlumsky has quit IRC23:46
*** TxGirlGeek has joined #openstack-cinder23:46
*** imacdonn has quit IRC23:55
*** imacdonn has joined #openstack-cinder23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!