*** markvoelker has quit IRC | 00:06 | |
*** _alastor_ has quit IRC | 00:11 | |
whoami-rajat | smcginnis: https://review.openstack.org/#/c/616748/ please take a look whenever you get time :) | 00:18 |
---|---|---|
*** david-lyle has joined #openstack-cinder | 00:18 | |
*** mszwed has quit IRC | 00:20 | |
*** dklyle has quit IRC | 00:21 | |
*** sdake has quit IRC | 00:26 | |
*** ganso has quit IRC | 00:37 | |
*** _alastor_ has joined #openstack-cinder | 00:41 | |
*** _alastor_ has quit IRC | 00:45 | |
*** sdake has joined #openstack-cinder | 00:47 | |
*** openstackgerrit has quit IRC | 00:52 | |
*** Liang__ has joined #openstack-cinder | 00:52 | |
*** bhagyashris has joined #openstack-cinder | 00:56 | |
*** mriedem is now known as mriedem_away | 00:57 | |
*** mriedem_away has quit IRC | 01:00 | |
*** gouthamr has left #openstack-cinder | 01:02 | |
*** markvoelker has joined #openstack-cinder | 01:03 | |
*** phuongnh has joined #openstack-cinder | 01:03 | |
*** openstackgerrit has joined #openstack-cinder | 01:03 | |
openstackgerrit | Merged openstack/python-cinderclient master: Remove dsvm-functional-identity-v3-only job https://review.openstack.org/635321 | 01:03 |
*** lixiaoy1 has joined #openstack-cinder | 01:14 | |
*** sdake has quit IRC | 01:14 | |
*** sdake has joined #openstack-cinder | 01:17 | |
*** sapd1 has joined #openstack-cinder | 01:26 | |
*** stakeda has joined #openstack-cinder | 01:27 | |
*** sdake has quit IRC | 01:29 | |
*** Liang__ has quit IRC | 01:31 | |
*** Dinesh_Bhor has joined #openstack-cinder | 01:32 | |
*** sdake has joined #openstack-cinder | 01:33 | |
*** markvoelker has quit IRC | 01:35 | |
*** sdake has quit IRC | 01:39 | |
*** gouthamr has joined #openstack-cinder | 01:48 | |
*** doubletao has joined #openstack-cinder | 02:26 | |
*** Dinesh_Bhor has quit IRC | 02:44 | |
*** Dinesh_Bhor has joined #openstack-cinder | 02:48 | |
*** vishakha has joined #openstack-cinder | 02:58 | |
*** sdake has joined #openstack-cinder | 03:06 | |
*** bswartz has joined #openstack-cinder | 03:22 | |
*** wanghao has joined #openstack-cinder | 03:40 | |
*** wanghao has quit IRC | 03:43 | |
*** zhanglong has quit IRC | 03:50 | |
*** spsurya has joined #openstack-cinder | 03:55 | |
*** udesale has joined #openstack-cinder | 03:55 | |
*** sdake has quit IRC | 04:15 | |
*** enriquetaso has quit IRC | 04:28 | |
*** penick has quit IRC | 05:24 | |
*** zul has quit IRC | 05:26 | |
*** udesale has quit IRC | 05:36 | |
*** udesale has joined #openstack-cinder | 05:42 | |
*** udesale has quit IRC | 05:48 | |
*** udesale has joined #openstack-cinder | 05:48 | |
*** psachin has joined #openstack-cinder | 05:49 | |
*** brinzhang has joined #openstack-cinder | 05:50 | |
*** lixiaoy1 has quit IRC | 05:54 | |
*** lixiaoy1 has joined #openstack-cinder | 05:55 | |
openstackgerrit | Yury Kulazhenkov proposed openstack/os-brick master: rename ScaleIO connector to VxFlex OS https://review.openstack.org/635530 | 05:58 |
*** markvoelker has joined #openstack-cinder | 06:00 | |
*** markvoelker has quit IRC | 06:04 | |
*** imacdonn has quit IRC | 06:13 | |
*** sdake has joined #openstack-cinder | 06:28 | |
*** Dinesh_Bhor has quit IRC | 06:30 | |
*** Dinesh_Bhor has joined #openstack-cinder | 06:39 | |
*** Luzi has joined #openstack-cinder | 06:43 | |
*** gkadam has joined #openstack-cinder | 07:00 | |
*** markvoelker has joined #openstack-cinder | 07:00 | |
*** sdake has quit IRC | 07:07 | |
*** udesale has quit IRC | 07:12 | |
*** udesale has joined #openstack-cinder | 07:19 | |
*** mszwed has joined #openstack-cinder | 07:21 | |
*** udesale has quit IRC | 07:24 | |
*** udesale has joined #openstack-cinder | 07:25 | |
openstackgerrit | Yury Kulazhenkov proposed openstack/os-brick master: rename ScaleIO connector to VxFlex OS https://review.openstack.org/635530 | 07:28 |
*** markvoelker has quit IRC | 07:34 | |
*** e0ne has joined #openstack-cinder | 07:36 | |
*** lixiaoy1 has quit IRC | 08:29 | |
*** markvoelker has joined #openstack-cinder | 08:31 | |
*** tkajinam has quit IRC | 08:36 | |
*** markvoelker has quit IRC | 09:04 | |
*** e0ne has quit IRC | 09:06 | |
*** e0ne has joined #openstack-cinder | 09:07 | |
*** ociuhandu has quit IRC | 09:07 | |
*** davidsha has joined #openstack-cinder | 09:15 | |
*** sunnaichuan has joined #openstack-cinder | 09:16 | |
*** ociuhandu has joined #openstack-cinder | 09:20 | |
*** ociuhandu has quit IRC | 09:25 | |
*** luizbag has joined #openstack-cinder | 09:33 | |
*** ociuhandu has joined #openstack-cinder | 09:34 | |
*** e0ne has quit IRC | 09:34 | |
*** ociuhandu has quit IRC | 09:38 | |
*** ganso has joined #openstack-cinder | 09:57 | |
*** bhagyashris has quit IRC | 10:00 | |
*** markvoelker has joined #openstack-cinder | 10:02 | |
*** ociuhandu has joined #openstack-cinder | 10:12 | |
*** erlon has joined #openstack-cinder | 10:31 | |
*** markvoelker has quit IRC | 10:34 | |
*** e0ne has joined #openstack-cinder | 10:46 | |
*** e0ne_ has joined #openstack-cinder | 10:50 | |
*** phuongnh has quit IRC | 10:50 | |
*** e0ne has quit IRC | 10:52 | |
*** ociuhandu has quit IRC | 11:02 | |
*** ociuhandu has joined #openstack-cinder | 11:03 | |
*** udesale has quit IRC | 11:13 | |
*** brinzhang has quit IRC | 11:14 | |
*** Dinesh_Bhor has quit IRC | 11:21 | |
*** markvoelker has joined #openstack-cinder | 11:30 | |
*** sapd1 has quit IRC | 11:45 | |
*** e0ne has joined #openstack-cinder | 11:56 | |
openstackgerrit | Thiago Correa proposed openstack/cinder master: NetApp SolidFire: Fix python3 issues https://review.openstack.org/633596 | 11:56 |
*** e0ne has quit IRC | 11:57 | |
*** e0ne_ has quit IRC | 11:57 | |
openstackgerrit | Thiago Correa proposed openstack/cinder master: NetApp SolidFire: Fix python3 issues https://review.openstack.org/633596 | 11:58 |
*** markvoelker has quit IRC | 12:04 | |
*** sdake has joined #openstack-cinder | 12:04 | |
*** e0ne has joined #openstack-cinder | 12:08 | |
*** gnufied has quit IRC | 12:09 | |
*** e0ne has quit IRC | 12:12 | |
*** sdake has quit IRC | 12:16 | |
*** e0ne has joined #openstack-cinder | 12:22 | |
*** udesale has joined #openstack-cinder | 12:50 | |
*** markvoelker has joined #openstack-cinder | 13:01 | |
*** abishop_ is now known as abishop | 13:03 | |
*** mriedem has joined #openstack-cinder | 13:08 | |
*** sapd1 has joined #openstack-cinder | 13:08 | |
*** e0ne has quit IRC | 13:11 | |
*** rosmaita has joined #openstack-cinder | 13:15 | |
*** e0ne has joined #openstack-cinder | 13:17 | |
*** e0ne_ has joined #openstack-cinder | 13:20 | |
*** e0ne has quit IRC | 13:23 | |
*** enriquetaso has joined #openstack-cinder | 13:24 | |
*** Dinesh_Bhor has joined #openstack-cinder | 13:34 | |
*** markvoelker has quit IRC | 13:34 | |
*** vishakha has quit IRC | 13:35 | |
*** eharney has quit IRC | 13:37 | |
*** luizbag has quit IRC | 13:39 | |
*** e0ne_ has quit IRC | 13:40 | |
*** Dinesh_Bhor has quit IRC | 13:44 | |
*** e0ne has joined #openstack-cinder | 13:45 | |
*** e0ne_ has joined #openstack-cinder | 13:50 | |
*** e0ne has quit IRC | 13:51 | |
*** jmlowe has quit IRC | 13:54 | |
*** e0ne_ has quit IRC | 14:04 | |
*** sdake has joined #openstack-cinder | 14:08 | |
*** sdake has quit IRC | 14:09 | |
*** sdake has joined #openstack-cinder | 14:11 | |
*** sdake has quit IRC | 14:13 | |
*** sdake has joined #openstack-cinder | 14:13 | |
openstackgerrit | Sofia Enriquez proposed openstack/cinder stable/ocata: ScaleIO Driver - adding cache and refactoring tests https://review.openstack.org/633570 | 14:21 |
*** eharney has joined #openstack-cinder | 14:22 | |
*** Dinesh_Bhor has joined #openstack-cinder | 14:22 | |
*** sdake has quit IRC | 14:23 | |
openstackgerrit | Merged openstack/python-brick-cinderclient-ext master: Add python 3.6 unit test job https://review.openstack.org/616748 | 14:23 |
*** dave-mccowan has joined #openstack-cinder | 14:25 | |
*** e0ne has joined #openstack-cinder | 14:29 | |
*** dave-mccowan has quit IRC | 14:30 | |
*** markvoelker has joined #openstack-cinder | 14:31 | |
*** e0ne_ has joined #openstack-cinder | 14:35 | |
*** e0ne has quit IRC | 14:35 | |
*** lpetrut has joined #openstack-cinder | 14:38 | |
*** e0ne_ has quit IRC | 14:41 | |
openstackgerrit | Michael McAleer proposed openstack/cinder master: PowerMax Driver - Unmanage Snapshot Improvements https://review.openstack.org/636640 | 14:41 |
*** zul has joined #openstack-cinder | 14:43 | |
*** e0ne has joined #openstack-cinder | 14:50 | |
*** sapd1 has quit IRC | 14:52 | |
*** e0ne_ has joined #openstack-cinder | 14:55 | |
*** e0ne has quit IRC | 14:55 | |
openstackgerrit | Eric Harney proposed openstack/python-cinderclient master: Add dependency on requests lib https://review.openstack.org/635549 | 14:58 |
*** penick has joined #openstack-cinder | 14:59 | |
*** jmlowe has joined #openstack-cinder | 14:59 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: Add cinder-tempest-plugin to LIO job https://review.openstack.org/568873 | 15:02 |
*** markvoelker has quit IRC | 15:04 | |
*** sapd1 has joined #openstack-cinder | 15:08 | |
*** Dinesh_Bhor has quit IRC | 15:16 | |
*** jmlowe has quit IRC | 15:18 | |
*** _alastor_ has joined #openstack-cinder | 15:22 | |
*** jmlowe has joined #openstack-cinder | 15:23 | |
*** _alastor_ has quit IRC | 15:26 | |
*** luizbag has joined #openstack-cinder | 15:32 | |
*** lseki has joined #openstack-cinder | 15:39 | |
*** gnufied has joined #openstack-cinder | 15:41 | |
*** supamatt has joined #openstack-cinder | 15:47 | |
*** supamatt has quit IRC | 15:49 | |
*** supamatt has joined #openstack-cinder | 15:49 | |
*** carlos_silva has joined #openstack-cinder | 15:53 | |
*** gkadam has quit IRC | 15:53 | |
*** jmlowe has quit IRC | 15:54 | |
*** ociuhandu has quit IRC | 15:55 | |
*** Luzi has quit IRC | 15:55 | |
*** ociuhandu has joined #openstack-cinder | 15:55 | |
*** jmlowe has joined #openstack-cinder | 15:58 | |
*** lpetrut has quit IRC | 16:00 | |
*** markvoelker has joined #openstack-cinder | 16:01 | |
whoami-rajat | eharney: Hi, i've replied to your concern regarding removing --all-tenants in group listing, https://review.openstack.org/#/c/627359/ | 16:01 |
whoami-rajat | Kindly check and revert for any additional queries. Thanks :) | 16:01 |
eharney | whoami-rajat: i'm not sure the client should be excluding options that are explicitly requested on the command line | 16:02 |
eharney | seems like the wrong thing to do | 16:02 |
eharney | having the client skip an arg because it thinks the server will reject it means we are now embedding server-side decisions in the client as well... | 16:03 |
*** sdake has joined #openstack-cinder | 16:06 | |
whoami-rajat | eharney: i fixed this on the client side as i couldn't find reasons to pass it to server when we already know it won't be of any benefit to the server. | 16:07 |
whoami-rajat | there also isn't proper handling on the server, maybe we can add the admin/non-admin check against the all-tenant attribute on the server side if that seems right. | 16:07 |
eharney | whoami-rajat: if the user adds the arg to the call, it should be passed to the server | 16:07 |
eharney | this fix should just not add it to the call by default | 16:07 |
*** ianychoi has quit IRC | 16:08 | |
*** walshh_ has joined #openstack-cinder | 16:12 | |
whoami-rajat | eharney: then we need to fix this for all other resources as well, as the same approach is followed throughout the client. for example, in volumes list [1], the all-tenants filters if explicitly passed will be removed [2] | 16:15 |
whoami-rajat | [1] https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/volumes.py#L321-L324 | 16:15 |
whoami-rajat | [2] https://github.com/openstack/python-cinderclient/blob/master/cinderclient/base.py#L143-L145 | 16:15 |
*** _alastor_ has joined #openstack-cinder | 16:16 | |
*** walshh_ has quit IRC | 16:17 | |
*** samc-bbc has joined #openstack-cinder | 16:17 | |
*** markvoelker has quit IRC | 16:34 | |
*** jmlowe has quit IRC | 16:38 | |
*** jmlowe has joined #openstack-cinder | 16:44 | |
*** sdake has quit IRC | 16:46 | |
smcginnis | I do think we need to do something on the client side since there are server-side issues out there already in released versions of Cinder. | 16:46 |
smcginnis | But we can do a lot to improve things on the server side going forward. | 16:46 |
*** phuongnh has joined #openstack-cinder | 16:46 | |
*** sdake has joined #openstack-cinder | 16:46 | |
*** e0ne has joined #openstack-cinder | 16:47 | |
eharney | i'm not sure what we should do for the client in this case though | 16:48 |
whoami-rajat | smcginnis: yes. i think consistency around all resources is an important factor as it causes bugs in some features and others seem working fine. | 16:48 |
*** e0ne_ has quit IRC | 16:48 | |
*** phuongnh has quit IRC | 16:51 | |
whoami-rajat | eharney: atleast we can make the client consistent as of now? | 16:53 |
eharney | whoami-rajat: making it consistent by continuing behavior that seems to be wrong isn't really a win though... | 16:53 |
eharney | and the client issues are fairly uninteresting compared to the fact that server doesn't have consistent behavior around these args, which seems like a much bigger issue | 16:54 |
openstackgerrit | Eric Harney proposed openstack/python-cinderclient master: Print API version info for unsupported commands https://review.openstack.org/636677 | 16:56 |
eharney | smcginnis: this is one of the ideas i was kicking around at the midcycle re: client microversion help ^ | 16:56 |
whoami-rajat | eharney: i agree. i will look into making the server consistent. (was just suggesting the quick fix) | 16:57 |
smcginnis | eharney: Cool, thanks. | 16:57 |
smcginnis | whoami-rajat: If we can fix it on the server side, we can then make sure to backport the fix to stable branches to address existing releases. | 16:58 |
*** sdake has quit IRC | 16:58 | |
whoami-rajat | smcginnis: ok. will start working on that. Thanks for all the useful feedback eharney smcginnis | 16:59 |
jungleboyj | smcginnis: Good call to go with a solution that can be backported. | 17:00 |
eharney | could it? seems likely to run into a microversion change... | 17:01 |
*** davidsha has quit IRC | 17:02 | |
*** itlinux has joined #openstack-cinder | 17:05 | |
*** lemko has joined #openstack-cinder | 17:05 | |
smcginnis | Depends on how it's fixed I guess. | 17:06 |
eharney | hmm, reject_invalid_filters was added after group list, so we probably already accidentally changed the API behavior around this once a while ago :/ | 17:06 |
eharney | ah, but that was microversioned, so this problem only shows up on 3.31 and after | 17:08 |
eharney | i guess the question then, is whether all_tenants=0 is actually invalid | 17:08 |
*** itlinux has quit IRC | 17:09 | |
*** itlinux_ has joined #openstack-cinder | 17:09 | |
smcginnis | It's at least redundant. | 17:11 |
*** ociuhandu_ has joined #openstack-cinder | 17:11 | |
*** itlinux_ has quit IRC | 17:14 | |
*** itlinux has joined #openstack-cinder | 17:15 | |
*** luizbag_ has joined #openstack-cinder | 17:15 | |
*** sapd1 has quit IRC | 17:16 | |
*** luizbag has quit IRC | 17:17 | |
whoami-rajat | smcginnis: eharney found out that all resources has invalid_filters check (directly or indirectly[1]) | 17:18 |
whoami-rajat | [1] https://github.com/openstack/cinder/blob/master/cinder/api/v3/volumes.py#L82 | 17:18 |
whoami-rajat | passed the all_tenants attribute manually from cinderclient to API and same error occurs. | 17:18 |
*** psachin has quit IRC | 17:18 | |
eharney | right, but the client clearly assumed that this field was valid before the filtering change went in | 17:20 |
whoami-rajat | eharney: so i will just add the all_tenant check for non-admin users to generate an error. seems like the right approach? | 17:21 |
*** udesale has quit IRC | 17:23 | |
*** jmlowe has quit IRC | 17:23 | |
*** e0ne has quit IRC | 17:25 | |
eharney | whoami-rajat: not until after we codify what the rules are in the server. also, i think that won't work anyway, because isn't all_tenants=0 allowed if the server is customized to allow that field in the resource filters config? | 17:27 |
eharney | i don't see why the client needs to reject anything | 17:28 |
*** sapd1 has joined #openstack-cinder | 17:29 | |
*** itlinux has quit IRC | 17:30 | |
*** markvoelker has joined #openstack-cinder | 17:32 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Reject all_tenants filter for non-admin users https://review.openstack.org/636689 | 17:32 |
whoami-rajat | eharney: i checked the code, it works.please take a look. https://review.openstack.org/636689 . | 17:35 |
whoami-rajat | I've added the check before checking the passed filter against the resource filters file, so changing the resource filters file won't affect it. | 17:35 |
*** itlinux has joined #openstack-cinder | 17:36 | |
whoami-rajat | eharney: after this patch, i think we can remove all_tenants rejection from the client side as well. but i think we need to keep track of all the filters that can be passed as boolean. | 17:36 |
*** sapd1 has quit IRC | 17:37 | |
*** ociuhand_ has joined #openstack-cinder | 17:39 | |
*** itlinux_ has joined #openstack-cinder | 17:39 | |
eharney | whoami-rajat: i don't understand the goal of this patch | 17:40 |
*** itlinux has quit IRC | 17:41 | |
whoami-rajat | eharney: the resource filters file checks the resource against the filter (not against admin or non-admins). i think we need to add explicit checks for admin non-admin like already done here https://review.openstack.org/#/c/636689/1/cinder/api/common.py@415 | 17:42 |
*** ociuhandu has quit IRC | 17:42 | |
whoami-rajat | filter against the resource* | 17:44 |
eharney | whoami-rajat: and your goal is that we should be rejecting some requests that we accept currently? | 17:44 |
whoami-rajat | eharney: since all-tenants is an admin filter, it should raise error if a non-admin user passes it. This is my understanding of the scenario. | 17:45 |
eharney | whoami-rajat: but that's the thing. it's not an admin filter for volumes. and it's not an admin filter for groups if the resource_filters.json file is set to allow it | 17:46 |
eharney | my assumption is that if we want to change the server behavior, we should be making the groups calls act like the volumes calls, not vice versa | 17:47 |
*** ociuhand_ has quit IRC | 17:48 | |
whoami-rajat | eharney: but the volumes calls only work because we have rejected the filter in client (and not done it for groups). if the rejection is removed from the client, all the resources will have the same incorrect behaviour, right? | 17:49 |
eharney | i think we're mixing up a few layers here | 17:50 |
whoami-rajat | eharney: i'm not sure about the purpose of resource_filters file as it is obviously missing the admin non-admin checks in resources that we've added manually before. | 17:51 |
eharney | for the purposes of setting the correct server behavior, it doesn't really matter what cinderclient does | 17:51 |
whoami-rajat | eharney: yes | 17:52 |
eharney | the resource_filters is orthogonal to the admin checks. but the interesting part there is that if you add "group": ["all_tenants"] to resource_filters.json, you can call group-list with the client currently, which passes all_tenants=0, and it works | 17:53 |
eharney | your proposed patch takes away the ability to configure that | 17:53 |
eharney | i think | 17:53 |
*** markvoelker has quit IRC | 18:04 | |
*** erlon has quit IRC | 18:05 | |
*** jmlowe has joined #openstack-cinder | 18:08 | |
*** itlinux_ has quit IRC | 18:08 | |
whoami-rajat | eharney: i remember the correct problem now. | 18:09 |
whoami-rajat | cinder group-list (when done with non-admin user) appends the all_tenants=0 parameter which it shouldn't as it isn't allowed for non-admins and the server errors out when the command is correct. | 18:09 |
whoami-rajat | if my understanding is correct, | 18:09 |
whoami-rajat | 1) all filters are allowed for admins | 18:09 |
whoami-rajat | 2) resource_filters file is for non-admin filter check | 18:09 |
whoami-rajat | 3) the behavior on the server seems correct but with a vague error message (invalid filters found in ...) | 18:09 |
whoami-rajat | this seems like a client problem to me, when the all_tenant filter is automatically appending then how can we verify the user requested it manually or not? | 18:09 |
eharney | my thinking here is that it was a bug to block all_tenants=0 for non-admin users that was accidentally introduced with the filtering code, and this is evidenced by the fact that it's allowed for "volume list" | 18:11 |
eharney | it's only a client problem if you assume that we actually want to block that parameter in the server, which is not at all clear | 18:12 |
whoami-rajat | eharney: my concern here is why is group_list appending the all_tenants=0 automatically and other resources like volume, snapshots etc are not? | 18:15 |
eharney | whoami-rajat: it shouldn't append it automatically in the client, that's also a bug IMO | 18:16 |
eharney | i think that happens because the all-tenants arg on group-list has default=0 when it should default to None | 18:17 |
whoami-rajat | eharney: exactly. i was trying to fix that bug and then you introduced the use case if we pass the all_tenants manually. i think both can be handled at the client side. | 18:17 |
whoami-rajat | eharney: i think so too, let me double check. | 18:18 |
eharney | isn't that part just fixed by adjusting the @utils.arg definition? | 18:18 |
*** erlon has joined #openstack-cinder | 18:18 | |
*** sdake has joined #openstack-cinder | 18:19 | |
*** e0ne has joined #openstack-cinder | 18:22 | |
whoami-rajat | eharney: is this the difference that's causing the problem | 18:23 |
whoami-rajat | https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/shell.py#L53 | 18:23 |
whoami-rajat | https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/shell.py#L1327 | 18:23 |
eharney | whoami-rajat: i think we just have to change 1327 to have default=None, or maybe just remove default= | 18:24 |
*** erlon_ has joined #openstack-cinder | 18:25 | |
eharney | default=0 is probably why it passes in the param when it wasn't specified | 18:25 |
whoami-rajat | eharney: got it, https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/shell.py#L1340 | 18:26 |
*** sapd1 has joined #openstack-cinder | 18:27 | |
whoami-rajat | we're explicitly adding all_tenants=0. removing this line would work i guess. | 18:27 |
openstackgerrit | Avishay Traeger proposed openstack/cinder master: Allow setting Pure host personality https://review.openstack.org/636709 | 18:28 |
*** erlon has quit IRC | 18:28 | |
eharney | do_list() seems to implement all_tenants in a different way, and checks the ALL_TENANTS env var inside the method... hrm | 18:28 |
*** ociuhandu has joined #openstack-cinder | 18:29 | |
eharney | but yeah, should be some minor tweaks to just not pass along that param when nobody asks for it | 18:30 |
whoami-rajat | eharney: yes, group_list is fetching the parameter from env seems odd. | 18:30 |
eharney | whoami-rajat: a lot of calls use that ALL_TENANTS env var, they just seem to read it in different ways | 18:31 |
whoami-rajat | eharney: this was a minor issue. i feel bad for wasting so much of everyone's time :( | 18:31 |
eharney | i dunno, uncovering the whole issue that all_tenants has no consistent policy on the server is worthwhile, we'll need to fix that up at some point too | 18:32 |
whoami-rajat | eharney: ok. should the env fetching be included in other get requests as well? | 18:32 |
eharney | whoami-rajat: isn't it already? | 18:32 |
*** ociuhandu has quit IRC | 18:33 | |
whoami-rajat | eharney: oh yes it is. just done at different places in the code. https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/shell.py#L132 | 18:34 |
whoami-rajat | eharney: yeah i think some of the discussion was worthwhile regarding the server side. i will fix this in client now. Thanks for all the help and time Eric :) | 18:35 |
eharney | whoami-rajat: sure, thanks for looking into it | 18:35 |
*** sdake has quit IRC | 18:37 | |
whoami-rajat | eharney: and one more thing. we should remove the rejecting code of all-tenants=0 when passed manually right? | 18:37 |
*** sunnaichuan has quit IRC | 18:38 | |
openstackgerrit | Avishay Traeger proposed openstack/cinder master: Allow setting Pure host personality https://review.openstack.org/636709 | 18:44 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient master: Remove nonexistent job from gate https://review.openstack.org/636716 | 18:49 |
rosmaita | smcginnis: thanks! | 18:52 |
*** sri_ has quit IRC | 18:52 | |
*** mriedem is now known as mriedem_away | 18:52 | |
*** sri_ has joined #openstack-cinder | 18:52 | |
smcginnis | rosmaita: Thanks for catching that! | 18:54 |
rosmaita | sorry i missed it in the first place ... i'm surprised it didn't break anything, too | 18:54 |
*** markvoelker has joined #openstack-cinder | 19:01 | |
openstackgerrit | Rajat Dhasmana proposed openstack/python-cinderclient master: Fix: cinder group-list not working with non-admin user https://review.openstack.org/627359 | 19:10 |
*** luizbag_ has quit IRC | 19:14 | |
*** ociuhandu has joined #openstack-cinder | 19:16 | |
*** ociuhandu has quit IRC | 19:28 | |
*** eharney has quit IRC | 19:31 | |
*** erlon_ has quit IRC | 19:34 | |
*** markvoelker has quit IRC | 19:34 | |
*** e0ne has quit IRC | 19:47 | |
*** lemko has quit IRC | 19:49 | |
openstackgerrit | Sofia Enriquez proposed openstack/cinder stable/ocata: ScaleIO Driver - adding cache and refactoring tests https://review.openstack.org/633570 | 20:09 |
*** carlos_silva has quit IRC | 20:22 | |
*** eharney has joined #openstack-cinder | 20:25 | |
*** jmlowe has quit IRC | 20:28 | |
*** ociuhandu has joined #openstack-cinder | 20:31 | |
*** markvoelker has joined #openstack-cinder | 20:31 | |
*** lseki has left #openstack-cinder | 20:43 | |
*** samc-bbc has quit IRC | 20:58 | |
*** itlinux has joined #openstack-cinder | 21:03 | |
*** ociuhandu has quit IRC | 21:04 | |
*** mriedem_away is now known as mriedem | 21:04 | |
*** markvoelker has quit IRC | 21:05 | |
*** jmlowe has joined #openstack-cinder | 21:15 | |
*** whoami-rajat has quit IRC | 21:32 | |
*** hedvig_01 has joined #openstack-cinder | 21:34 | |
*** enriquetaso has quit IRC | 21:49 | |
*** itlinux has quit IRC | 21:58 | |
*** rchurch has joined #openstack-cinder | 22:01 | |
*** rchurch_ has quit IRC | 22:01 | |
*** markvoelker has joined #openstack-cinder | 22:02 | |
*** openstackgerrit has quit IRC | 22:22 | |
*** markvoelker has quit IRC | 22:34 | |
*** gouthamr has quit IRC | 22:35 | |
*** gouthamr has joined #openstack-cinder | 22:36 | |
*** cburgess has quit IRC | 22:36 | |
*** cburgess has joined #openstack-cinder | 22:38 | |
*** sapd1 has quit IRC | 22:40 | |
*** sapd1 has joined #openstack-cinder | 22:55 | |
*** david-lyle has quit IRC | 23:02 | |
*** dklyle has joined #openstack-cinder | 23:02 | |
*** tkajinam has joined #openstack-cinder | 23:05 | |
*** sapd1 has quit IRC | 23:16 | |
*** markvoelker has joined #openstack-cinder | 23:31 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!