*** mriedem_afk is now known as mriedem | 00:12 | |
KeithMnemonic | smcginnis, sorry I did not know i needed a release liaisons. Can someone please point me to the list of liaisons? | 00:14 |
---|---|---|
KeithMnemonic | it was this commit that we need 7ce585438f219d5c90839ec496930526024a751e several of our customers using 3par have seen this due to a 3par bug HPE is not in a hurry to fix | 00:15 |
*** irclogbot_3 has joined #openstack-cinder | 00:16 | |
smcginnis | KeithMnemonic: Best to ask jungleboyj since there may be other things we want to get out (or hold) other than the one fix you care about. | 00:23 |
KeithMnemonic | ok thanks! | 00:24 |
KeithMnemonic | jungleboyj: Can you please check stable/pike and see when a new release of os-brick 1.15.X can be released for pike? | 00:25 |
jungleboyj | Yeah, can look into that tomorrow. | 00:26 |
KeithMnemonic | thanks! it is not urgent but if i can at least get a ballpark time frame that would be great | 00:26 |
*** itlinux has joined #openstack-cinder | 01:34 | |
*** ruffian_sheep has joined #openstack-cinder | 01:54 | |
ruffian_sheep | Hi,if I want to do the tempest should I use the newest of openstack like rocky ? | 01:54 |
smcginnis | ruffian_sheep: What are you trying to do | 01:56 |
jungleboyj | :-) | 01:57 |
jungleboyj | ruffian_sheep: It depends. | 01:57 |
*** gnufied has quit IRC | 02:00 | |
*** deiter has quit IRC | 02:01 | |
ruffian_sheep | <@smcginnis> :I wan to build the third party CI of cinder.whoami-rajat tell me to create a file like that https://openstackci.oracle.com/zfssa_ci/refs-changes-77-640077-3-iscsi/stestr_results.html | 02:29 |
ruffian_sheep | <@smcginnis> :So I will do the tempest to create the file. | 02:29 |
ruffian_sheep | <jungleboyj>:Do you means the openstack should always use the dev-stack to build for using the lastest? | 02:30 |
openstackgerrit | Ryan Liang proposed openstack/cinder stable/ocata: VNX Driver: delete_hba() instead of remove_hba() https://review.openstack.org/636215 | 02:40 |
*** psachin has joined #openstack-cinder | 02:47 | |
openstackgerrit | Merged openstack/cinder stable/stein: Update .gitreview for stable/stein https://review.openstack.org/645259 | 02:55 |
openstackgerrit | Merged openstack/cinder stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/645260 | 02:55 |
*** udesale has joined #openstack-cinder | 03:21 | |
*** mriedem has quit IRC | 03:29 | |
*** whoami-rajat has joined #openstack-cinder | 03:41 | |
*** lseki has quit IRC | 03:52 | |
*** erlon has quit IRC | 04:13 | |
*** zhubx007 has quit IRC | 04:17 | |
*** zhubx007 has joined #openstack-cinder | 04:18 | |
*** carlos_silva has quit IRC | 04:26 | |
*** TheJulia has quit IRC | 04:31 | |
*** wxy-xiyuan has quit IRC | 04:31 | |
*** coreycb has quit IRC | 04:31 | |
*** TheJulia has joined #openstack-cinder | 04:31 | |
*** wxy-xiyuan has joined #openstack-cinder | 04:31 | |
*** simondodsley has quit IRC | 04:31 | |
*** spsurya has quit IRC | 04:31 | |
*** PrinzElvis has quit IRC | 04:31 | |
*** amito has quit IRC | 04:32 | |
*** xyang has quit IRC | 04:32 | |
*** lamt has quit IRC | 04:32 | |
*** kmalloc has quit IRC | 04:32 | |
*** jbernard has quit IRC | 04:33 | |
*** chrisyang_0660 has quit IRC | 04:33 | |
*** jbernard has joined #openstack-cinder | 04:33 | |
*** PrinzElvis has joined #openstack-cinder | 04:34 | |
*** xyang has joined #openstack-cinder | 04:34 | |
*** spsurya has joined #openstack-cinder | 04:34 | |
*** coreycb has joined #openstack-cinder | 04:34 | |
*** chrisyang_0660 has joined #openstack-cinder | 04:36 | |
*** lemko has quit IRC | 04:38 | |
*** simondodsley has joined #openstack-cinder | 04:39 | |
*** amito has joined #openstack-cinder | 04:39 | |
*** kmalloc has joined #openstack-cinder | 04:39 | |
*** udesale has quit IRC | 04:47 | |
*** udesale has joined #openstack-cinder | 04:47 | |
*** dviroel_ has quit IRC | 04:49 | |
*** lpetrut has joined #openstack-cinder | 04:52 | |
*** chhagarw has joined #openstack-cinder | 05:19 | |
*** lpetrut has quit IRC | 05:25 | |
openstackgerrit | Qian Mingyue proposed openstack/cinder master: Update Fujitsu ETERNUS DX driver https://review.openstack.org/609645 | 05:44 |
*** tkajinam has quit IRC | 05:59 | |
*** tkajinam has joined #openstack-cinder | 05:59 | |
*** lemko has joined #openstack-cinder | 06:15 | |
*** lpetrut has joined #openstack-cinder | 06:17 | |
*** psachin has quit IRC | 06:20 | |
*** psachin has joined #openstack-cinder | 06:25 | |
*** sapd1_x has joined #openstack-cinder | 06:25 | |
*** david-lyle has joined #openstack-cinder | 06:27 | |
*** dklyle has quit IRC | 06:27 | |
*** david-lyle has quit IRC | 06:29 | |
*** dklyle has joined #openstack-cinder | 06:29 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.openstack.org/645479 | 06:29 |
*** lpetrut has quit IRC | 06:30 | |
*** dims has quit IRC | 06:39 | |
*** dims has joined #openstack-cinder | 06:41 | |
*** Luzi has joined #openstack-cinder | 06:49 | |
ruffian_sheep | whoami-rajat:Hi,do you know if I should use the latest openstack to create the file you sent to me last time?https://openstackci.oracle.com/zfssa_ci/refs-changes-77-640077-3-iscsi/stestr_results.html | 06:58 |
*** chhagarw has quit IRC | 06:59 | |
ruffian_sheep | whoami-rajat:And must the CI including zuul and so on should be build in the same server with openstack? | 07:00 |
*** rcernin has quit IRC | 07:07 | |
*** whoami-rajat has quit IRC | 07:11 | |
*** lpetrut has joined #openstack-cinder | 07:11 | |
*** sapd1_x has quit IRC | 07:20 | |
*** dpawlik_ is now known as dpawlik | 07:21 | |
*** pcaruana has joined #openstack-cinder | 07:27 | |
*** whoami-rajat has joined #openstack-cinder | 07:30 | |
*** chhagarw has joined #openstack-cinder | 07:39 | |
whoami-rajat | ruffian_sheep: Hi, that was an example result from oracle CI | 07:56 |
whoami-rajat | ruffian_sheep: I don't have much experience setting up a CI but this doc[1] has instructions regarding setting up your CI. It might help. | 07:57 |
whoami-rajat | [1] https://docs.openstack.org/infra/openstackci/third_party_ci.html | 07:57 |
*** lpetrut has quit IRC | 08:04 | |
*** helenaAM has joined #openstack-cinder | 08:27 | |
*** tkajinam has quit IRC | 08:34 | |
openstackgerrit | Qian Mingyue proposed openstack/cinder master: Update Fujitsu ETERNUS DX driver https://review.openstack.org/609645 | 08:44 |
*** tobias-urdin has joined #openstack-cinder | 09:15 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Run cinderlib functional tests on LVM-LIO job https://review.openstack.org/620671 | 09:19 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Run cinderlib functional tests on Ceph job https://review.openstack.org/645182 | 09:19 |
*** dviroel_ has joined #openstack-cinder | 09:25 | |
openstackgerrit | guanzuoyu proposed openstack/cinder stable/rocky: RBD: add support for multiattach https://review.openstack.org/645513 | 09:28 |
*** carlos_silva has joined #openstack-cinder | 09:33 | |
*** lpetrut has joined #openstack-cinder | 10:04 | |
*** lpetrut has quit IRC | 10:23 | |
*** chrisyang_0660 has quit IRC | 10:59 | |
*** chrisyang_0660 has joined #openstack-cinder | 10:59 | |
*** whoami-rajat has quit IRC | 10:59 | |
*** spsurya has quit IRC | 10:59 | |
*** spsurya has joined #openstack-cinder | 11:01 | |
*** whoami-rajat has joined #openstack-cinder | 11:01 | |
*** kaisers has quit IRC | 11:12 | |
*** kaisers has joined #openstack-cinder | 11:13 | |
*** chhagarw has quit IRC | 11:35 | |
hemna | mornin | 11:50 |
*** pcaruana has quit IRC | 11:53 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Run cinderlib functional tests on Ceph job https://review.openstack.org/645182 | 11:58 |
openstackgerrit | Merged openstack/cinder master: Imported Translations from Zanata https://review.openstack.org/645479 | 12:00 |
*** abishop has joined #openstack-cinder | 12:06 | |
*** patrickeast_ has joined #openstack-cinder | 12:06 | |
*** arne_wiebalck_ has joined #openstack-cinder | 12:06 | |
*** preece_ has joined #openstack-cinder | 12:07 | |
*** Guest12731 has joined #openstack-cinder | 12:08 | |
*** v12aml_ has joined #openstack-cinder | 12:11 | |
*** eharney has quit IRC | 12:14 | |
*** logan- has quit IRC | 12:14 | |
*** arne_wiebalck has quit IRC | 12:14 | |
*** v12aml has quit IRC | 12:14 | |
*** preece has quit IRC | 12:14 | |
*** patrickeast has quit IRC | 12:14 | |
*** patrickeast_ is now known as patrickeast | 12:14 | |
*** Guest12731 is now known as logan- | 12:14 | |
*** preece_ is now known as preece | 12:14 | |
*** arne_wiebalck_ is now known as arne_wiebalck | 12:14 | |
*** v12aml_ is now known as v12aml | 12:14 | |
*** eharney has joined #openstack-cinder | 12:23 | |
*** erlon has joined #openstack-cinder | 12:28 | |
*** ruffian_sheep has quit IRC | 12:28 | |
lyarwood | https://review.openstack.org/#/c/637224/ - If anyone has time today I'd appreciate some reviews on this openstack/nova bugfix where I'm using the migration_status of a volume to determine when nova should call the os-migrate_volume_completion Cinder API. | 12:32 |
lyarwood | ^ tempest changes can also be found on the bug topic for that change FWIW | 12:33 |
hemna | so I guess nova is still completely depenent on the internal cinder volume status ? | 12:43 |
hemna | :( | 12:43 |
lyarwood | well, not the volume state itself anymore but the migration status yes | 12:44 |
lyarwood | nova still needs to understand when this is a migration or retype etc | 12:44 |
hemna | man that sucks | 12:45 |
lyarwood | we could extend the nova-api call to make this clear tbh | 12:45 |
lyarwood | yeah agreed | 12:45 |
lyarwood | and by making it clear in the n-api call we could also block users doing this manually that causes us no end of issues | 12:45 |
hemna | why does nova care about a retype or not? | 12:45 |
hemna | I guess a retype can result in a new volume from cinder I suppose | 12:46 |
lyarwood | hemna: we only care if cinder has called our swap volume API as we then need to callback to cinder once we are finished | 12:47 |
*** udesale has quit IRC | 12:47 | |
hemna | and a swap volume means a new volume from cinder's perspective I suppose | 12:48 |
lyarwood | hemna: at the moment our swap volume API is admin only but still open to anyone calling it to switch between two existing volumes | 12:48 |
*** udesale has joined #openstack-cinder | 12:48 | |
lyarwood | between existing volumes, with cinder our call to os-migrate_volume_completion switches the volumes around and deletes the old volume | 12:49 |
lyarwood | but anyway, I agree that nova doing this is awful | 12:49 |
lyarwood | and we should either create a seperate nova api that is only used by cinder when retyping/migrating | 12:49 |
hemna | I just don't care for nova knowing/caring about the internal state mgmt of cinder volumes | 12:50 |
hemna | that was one of the reasons for the new attachment protocol between nova/cinder | 12:50 |
hemna | so the comment in the compute/manager.py even says that nova can drop that code once nova doesn't support the v1 attachment protocol | 12:51 |
hemna | I guess at some point we should talk about when that's possible | 12:51 |
hemna | but outside the scope for your patch | 12:52 |
lyarwood | yeah I think that's going to require an additional API on the nova side tbh | 12:52 |
lyarwood | something that isn't overloaded by an existing nova flow | 12:52 |
lyarwood | and just used by cinder when switching between volumes during a retype/migrate | 12:53 |
hemna | yah | 12:53 |
* lyarwood makes a note of this for the PTG | 12:53 | |
*** pcaruana has joined #openstack-cinder | 12:54 | |
hemna | so volume['status'] isn't set for this case by cinder? | 12:56 |
hemna | either in v1 or v2? | 12:56 |
lyarwood | hemna: correct, when migrating and not retyping it isn't set | 12:56 |
hemna | https://review.openstack.org/#/c/638995/ | 12:57 |
lyarwood | so when just using os-migrate_volume | 12:57 |
hemna | that seems related | 12:58 |
lyarwood | gah yeah that would fix this on the c-api side | 12:58 |
lyarwood | would that be something we could backport? | 13:00 |
hemna | since it's a bugfix, I'd say yes | 13:00 |
*** senrique_ has joined #openstack-cinder | 13:01 | |
*** altlogbot_3 has quit IRC | 13:01 | |
*** irclogbot_3 has quit IRC | 13:01 | |
*** irclogbot_3 has joined #openstack-cinder | 13:01 | |
*** altlogbot_1 has joined #openstack-cinder | 13:01 | |
lyarwood | ack thanks, just checking. | 13:02 |
*** lseki has joined #openstack-cinder | 13:02 | |
*** dklyle has quit IRC | 13:07 | |
hemna | lyarwood: ok I added a comment in the cinder review. | 13:07 |
*** erlon has quit IRC | 13:08 | |
lyarwood | hemna: ack thanks | 13:09 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Run cinderlib functional tests on Ceph job https://review.openstack.org/645182 | 13:11 |
*** dklyle has joined #openstack-cinder | 13:12 | |
*** jmlowe has quit IRC | 13:18 | |
*** eharney has quit IRC | 13:20 | |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Don't quote {posargs} in tox.ini https://review.openstack.org/645563 | 13:26 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Fix incorrect use of flake8:noqa https://review.openstack.org/645564 | 13:28 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Replace assertRaisesRegexp with assertRaisesRegex https://review.openstack.org/645565 | 13:28 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Remove i18n.enable_lazy() translation https://review.openstack.org/645566 | 13:29 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Add Python 3.6 classifier to setup.cfg https://review.openstack.org/645567 | 13:30 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Change openstack-dev to openstack-discuss https://review.openstack.org/645569 | 13:31 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Cleanup the home page https://review.openstack.org/645570 | 13:31 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Change cache uniqifier from using md5 to sha-1 https://review.openstack.org/645571 | 13:32 |
smcginnis | rosmaita: I'm not sure about backporting some of those. Are they all needed? | 13:33 |
rosmaita | depends on what you want stable/stein to look like | 13:33 |
rosmaita | i figure they can just be -2d as quickly as discussing | 13:33 |
*** thgcorrea has joined #openstack-cinder | 13:33 | |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Fix bash_completion cache path https://review.openstack.org/645573 | 13:34 |
smcginnis | rosmaita: Nothing I consider harmful, just some I wouldn't have thought worth backporting. But I suppose no reason not to. | 13:34 |
rosmaita | Yeah, i figured it would be faster to just put them all up there than trying to figure out in advance and then put up patches | 13:35 |
rosmaita | they do get better, though, some of the early ones are a bit questionable | 13:36 |
smcginnis | rosmaita: Thanks for doing that. | 13:36 |
rosmaita | np | 13:37 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Change bash completion dir permissions to 0750 https://review.openstack.org/645575 | 13:37 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Re-enable shell UUID completion cache https://review.openstack.org/645577 | 13:38 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: More shell completion cache additions https://review.openstack.org/645582 | 13:39 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Fix doc build error https://review.openstack.org/645583 | 13:41 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Fix incorrect punctuation https://review.openstack.org/645584 | 13:42 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Fix max version handling for help output https://review.openstack.org/645585 | 13:42 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Add dependency on requests lib https://review.openstack.org/645586 | 13:43 |
openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient stable/stein: Fix: cinder group-list not working with non-admin user https://review.openstack.org/645588 | 13:44 |
rosmaita | that's all, folks! | 13:44 |
openstackgerrit | Sean McGinnis proposed openstack/python-brick-cinderclient-ext master: Fix lower-constraint deps handling https://review.openstack.org/645590 | 13:47 |
*** mriedem has joined #openstack-cinder | 13:51 | |
whoami-rajat | ^ are all these merged after client release ? | 13:54 |
whoami-rajat | rosmaita: | 13:54 |
rosmaita | whoami-rajat: yes | 13:54 |
rosmaita | whoami-rajat: https://etherpad.openstack.org/p/cinderclient-master-20-march | 13:55 |
jungleboyj | Wow. | 13:55 |
jungleboyj | rosmaita: So you just took everything and we should look at the backports with a critical eye then? | 13:56 |
rosmaita | jungleboyj: yes, except for 5 or so that i marked as "skip" on the etherpad | 13:56 |
jungleboyj | Ok. Do you have your etherpad linked somewhere? | 13:56 |
rosmaita | jungleboyj: don't know if you saw this yet, i sent it to the ML: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/004152.html | 13:56 |
rosmaita | jungleboyj: just on that email | 13:57 |
mriedem | just came here to ask about this | 13:57 |
mriedem | https://review.openstack.org/#/q/status:open+project:openstack/python-cinderclient+branch:stable/stein | 13:57 |
whoami-rajat | some of them look really old and some of them are doc changes, | 13:58 |
rosmaita | mriedem: explanation is here: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/004152.html | 13:58 |
smcginnis | mriedem: Specific question on that? | 13:58 |
mriedem | yeah i just read it | 13:58 |
mriedem | no...it's just... | 13:58 |
mriedem | kind of annoyed the stable team has to pick this up | 13:59 |
mriedem | well, doesn't *have* to | 13:59 |
jungleboyj | rosmaita: Thanks. I am adding the etherpad to our meet etherpad for future reference. | 13:59 |
* jungleboyj can feel mriedem shaking his head at me | 14:00 | |
mriedem | can you hear me sighing from here? | 14:00 |
jungleboyj | Yep. | 14:00 |
whoami-rajat | rosmaita: when can we expect the client release? | 14:01 |
rosmaita | i need to go get some coffee, all these patches are making me thirsty | 14:01 |
smcginnis | whoami-rajat: Freeze should be lifted right after stein goes out, so we can get a stable release of the client right after that. | 14:02 |
rosmaita | what smcginnis said | 14:02 |
whoami-rajat | smcginnis: ok thanks. i was thinking of fixing the generalized API related stuff on the client side, for starter[1] | 14:04 |
whoami-rajat | [1] https://review.openstack.org/#/c/641698 | 14:04 |
jungleboyj | Sounds good. | 14:05 |
smcginnis | That could be a candidate for inclusion. | 14:05 |
*** gnufied has joined #openstack-cinder | 14:06 | |
*** eharney has joined #openstack-cinder | 14:06 | |
mriedem | that's a feature | 14:06 |
mriedem | not a bug | 14:06 |
mriedem | so not appropriate for stable | 14:07 |
jungleboyj | mriedem: ++ | 14:07 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Run cinderlib functional tests on Ceph job https://review.openstack.org/645182 | 14:08 |
*** erlon has joined #openstack-cinder | 14:08 | |
whoami-rajat | mriedem: IIUC API filtering was a feature merged long ago, i'm just fixing the bugs it caused which were unnoticed for a long time. | 14:09 |
mriedem | adding options in a cli isn't a bug, it's a feature | 14:09 |
mriedem | lack of a feature is not a bug | 14:09 |
whoami-rajat | mriedem: oh, you were refering to the patch, ok. | 14:10 |
mriedem | i'm saying it's not appropriate for stable | 14:10 |
mriedem | i thought you were talking about backporting that change | 14:11 |
whoami-rajat | so this is also related to fix i'm going to make, this option should've been there in the first place. but if this isn't appropriate for the backport we can leave this one. | 14:12 |
*** jmlowe has joined #openstack-cinder | 14:15 | |
KeithMnemonic | jbernard: question on your change https://review.openstack.org/#/c/256091/ does this work for "in-use" volumes? | 14:28 |
whoami-rajat | mriedem: could you please take a look at my response https://review.openstack.org/#/c/641698/1 | 14:32 |
mriedem | replied | 14:33 |
whoami-rajat | mriedem: my query is regarding the release note, do i need to add it ? i've tested it appropriately with all 3 cases and will include the tests for the same. | 14:37 |
mriedem | generally when one adds new CLI options they should add a feature release note yes | 14:39 |
mriedem | "Option x added to command y <plus details>." | 14:39 |
whoami-rajat | mriedem: ok will do. Thanks for the review. | 14:41 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Run cinderlib functional tests on Ceph job https://review.openstack.org/645182 | 14:47 |
*** shilpasd has quit IRC | 14:49 | |
*** Luzi has quit IRC | 14:56 | |
*** Luzi has joined #openstack-cinder | 14:59 | |
*** Luzi has quit IRC | 15:00 | |
jbernard | KeithMnemonic: no, nova handles data movement in that case | 15:02 |
jbernard | KeithMnemonic: completely different code path | 15:02 |
KeithMnemonic | thank! do you know if it can do a "retype" of an in use ceph volume? | 15:04 |
hemna | KeithMnemonic: the ceph driver basically doesn't do much for a retype | 15:13 |
*** dpawlik has quit IRC | 15:14 | |
*** altlogbot_1 has quit IRC | 15:21 | |
*** altlogbot_0 has joined #openstack-cinder | 15:25 | |
jbernard | KeithMnemonic: a retype without migration, should work | 15:29 |
*** irclogbot_3 has quit IRC | 15:30 | |
*** irclogbot_0 has joined #openstack-cinder | 15:31 | |
*** irclogbot_0 has quit IRC | 15:36 | |
*** irclogbot_1 has joined #openstack-cinder | 15:37 | |
hemna | is there a nova API for updating the volume qos specs for an attachment ? | 15:41 |
hemna | I didn't think so, but wanted to ask | 15:41 |
smcginnis | Unless something has changed, it would only look at those settings during an attach. So only way that I knew to change it was to have to detach and reattach. | 15:42 |
*** gaoyan has joined #openstack-cinder | 15:42 | |
hemna | that's what I thought too | 15:42 |
eharney | no, there was a theory that we should build one using the nova events api | 15:42 |
hemna | wading through the nova api is....fun | 15:43 |
eharney | i was wanting this as a follow up for some of the capacity-based qos (i.e. after you extend a volume) | 15:43 |
openstackgerrit | Rajat Dhasmana proposed openstack/python-brick-cinderclient-ext master: Fix lower-constraint deps handling https://review.openstack.org/645590 | 15:45 |
hemna | it would be handy for volume retypes | 15:49 |
eharney | also that | 15:49 |
* hemna is unfamiliar with the events api. | 15:52 | |
hemna | are there some nova docs/examples? | 15:52 |
*** gaoyan has quit IRC | 15:53 | |
eharney | hemna: i think it's this https://developer.openstack.org/api-ref/compute/?expanded=run-events-detail#create-external-events-os-server-external-events | 15:54 |
eharney | presumably it would need new events added to it etc | 15:54 |
hemna | so step 1 is adding the nova event code to handle the request | 15:58 |
hemna | and then cinder side initiating that even when needed | 15:58 |
eharney | yeah, i assume cinder would send an event for a qos update that supplied new values etc | 15:58 |
hemna | yah | 15:59 |
hemna | in theory doesn't seem too difficult | 15:59 |
hemna | the nova side should just be a domain update with libvirt | 15:59 |
eharney | right | 15:59 |
*** mriedem is now known as mriedem_afk | 16:07 | |
*** chhagarw has joined #openstack-cinder | 16:08 | |
*** gaoyan has joined #openstack-cinder | 16:09 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: PowerMax Driver - In-Use Retype Path Fix https://review.openstack.org/640375 | 16:10 |
*** helenaAM has quit IRC | 16:15 | |
*** imacdonn has quit IRC | 16:19 | |
*** imacdonn has joined #openstack-cinder | 16:20 | |
*** gaoyan has quit IRC | 16:21 | |
whoami-rajat | smcginnis: Hi, i'm a bit confused regarding adding this option [1], should i add the tests for it in v3 or should i move this option to v2(as it should originally have been in v2 and tests for it also exists in v2 only) | 16:36 |
whoami-rajat | [1] https://review.openstack.org/#/c/641698/1/cinderclient/v3/shell.py | 16:36 |
smcginnis | whoami-rajat: Wouldn't it apply to both v2 and v3? | 16:41 |
*** dpawlik has joined #openstack-cinder | 16:42 | |
whoami-rajat | smcginnis: i think not, when i apply this option in v3 then v2 tests fail for unrecognized parameter '--is-public', vice-versa for v2. | 16:43 |
*** dpawlik has quit IRC | 16:47 | |
whoami-rajat | maybe i'm missing something but other tests are also written in such a way that they match v2/shell and v3/shell options respectively. | 16:48 |
smcginnis | Waiting, changing v3 causes v2 to fail and changing v3 causes v2 to fail? | 16:48 |
*** e0ne has joined #openstack-cinder | 16:48 | |
whoami-rajat | smcginnis: i added a test in v2/test_shell to run a command 'type-list --is-public=True', since this option is added in v3/shell.py, the test failed with 'unrecognized argument' | 16:50 |
smcginnis | whoami-rajat: Wait, that's backwards. Why update v2 tests for a v3 change? | 16:58 |
*** e0ne has quit IRC | 16:59 | |
*** udesale has quit IRC | 17:00 | |
whoami-rajat | smcginnis: ok got it. cause it's related tests were there in v2. they've manually appended '?is_public=None' instead of adding it to the command just like in 'all_tenants' case. Will fix that in another patch. | 17:01 |
whoami-rajat | smcginnis: will add tests to v3 then. thanks for the help. | 17:02 |
smcginnis | whoami-rajat: Maybe you can somehow inherit from some of the v3 ones. I haven't really looked at how all those are set up lately. | 17:02 |
whoami-rajat | smcginnis: ok will look into that. thanks. | 17:03 |
smcginnis | whoami-rajat: Thanks for digging in to it. | 17:03 |
whoami-rajat | smcginnis: i've to look into it sooner or later anyway :) | 17:04 |
*** eharney has quit IRC | 17:26 | |
*** psachin has quit IRC | 17:48 | |
*** gmann is now known as gmann_afk | 17:52 | |
*** deiter has joined #openstack-cinder | 17:53 | |
*** mriedem_afk is now known as mriedem | 17:55 | |
*** chhagarw has quit IRC | 18:01 | |
*** gmann_afk is now known as gmann | 18:11 | |
*** jdillaman has quit IRC | 18:25 | |
*** _alastor_ has quit IRC | 18:25 | |
*** erlon has quit IRC | 18:25 | |
*** eharney has joined #openstack-cinder | 18:40 | |
*** pcaruana has quit IRC | 18:45 | |
*** rchurch has quit IRC | 18:48 | |
*** eharney has quit IRC | 18:52 | |
*** eharney has joined #openstack-cinder | 18:54 | |
openstackgerrit | Merged openstack/python-cinderclient master: Remove py35 from setup.cfg https://review.openstack.org/639916 | 19:12 |
*** jmlowe has quit IRC | 19:40 | |
*** mriedem has quit IRC | 19:46 | |
*** mriedem has joined #openstack-cinder | 19:47 | |
*** thgcorrea has quit IRC | 19:49 | |
*** jmlowe has joined #openstack-cinder | 20:20 | |
*** rosmaita has left #openstack-cinder | 20:28 | |
*** abishop has quit IRC | 20:47 | |
*** carlos_silva has quit IRC | 21:03 | |
*** mchlumsky has quit IRC | 21:30 | |
*** e0ne has joined #openstack-cinder | 21:54 | |
*** lemko has quit IRC | 21:55 | |
*** zhubx007 has quit IRC | 21:57 | |
*** zhubx007 has joined #openstack-cinder | 21:57 | |
*** walshh_ has quit IRC | 22:06 | |
openstackgerrit | Merged openstack/cinder master: PowerMax Driver - In-Use Retype Path Fix https://review.openstack.org/640375 | 22:13 |
*** dviroel_ has quit IRC | 22:14 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax driver - add 'target_array_model' to metadata https://review.openstack.org/644620 | 22:15 |
*** e0ne has quit IRC | 22:36 | |
*** whoami-rajat has quit IRC | 22:41 | |
*** mriedem has quit IRC | 23:04 | |
*** N3l1x has quit IRC | 23:34 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!