*** radeks has joined #openstack-cinder | 00:08 | |
*** radeks_ has joined #openstack-cinder | 00:17 | |
*** radeks has quit IRC | 00:19 | |
*** hemna has quit IRC | 00:21 | |
*** brinzhang has joined #openstack-cinder | 00:54 | |
*** uberjay has quit IRC | 01:13 | |
*** uberjay has joined #openstack-cinder | 01:13 | |
*** lixiaoy1 has joined #openstack-cinder | 01:21 | |
*** cburgess has quit IRC | 01:46 | |
*** baojg has joined #openstack-cinder | 01:53 | |
*** radeks_ has quit IRC | 02:15 | |
*** threestrands has joined #openstack-cinder | 02:34 | |
*** minmin has joined #openstack-cinder | 02:39 | |
*** baojg has quit IRC | 02:47 | |
*** baojg has joined #openstack-cinder | 02:54 | |
*** hemna has joined #openstack-cinder | 03:07 | |
*** whoami-rajat has joined #openstack-cinder | 03:11 | |
*** psachin has joined #openstack-cinder | 03:30 | |
*** hemna has quit IRC | 03:37 | |
*** dave-mccowan has quit IRC | 03:58 | |
*** udesale has joined #openstack-cinder | 04:01 | |
*** vishalmanchanda has joined #openstack-cinder | 04:53 | |
*** sorrison has quit IRC | 05:00 | |
*** sorrison has joined #openstack-cinder | 05:01 | |
*** davee_ has quit IRC | 05:03 | |
*** davee_ has joined #openstack-cinder | 05:03 | |
*** psachin has quit IRC | 05:16 | |
*** imacdonn has quit IRC | 05:26 | |
*** e0ne has joined #openstack-cinder | 05:31 | |
*** lpetrut has joined #openstack-cinder | 05:40 | |
*** imacdonn has joined #openstack-cinder | 05:40 | |
*** udesale has quit IRC | 05:42 | |
*** udesale has joined #openstack-cinder | 05:42 | |
*** Luzi has joined #openstack-cinder | 05:45 | |
*** hemna has joined #openstack-cinder | 05:46 | |
*** hemna has quit IRC | 05:51 | |
*** radeks_ has joined #openstack-cinder | 05:58 | |
*** e0ne has quit IRC | 06:02 | |
*** hemna has joined #openstack-cinder | 06:22 | |
*** dpawlik has joined #openstack-cinder | 06:38 | |
*** xyang has quit IRC | 06:47 | |
*** coreycb has quit IRC | 06:47 | |
*** TheJulia has quit IRC | 06:47 | |
*** icey has quit IRC | 06:47 | |
*** xyang has joined #openstack-cinder | 06:47 | |
*** TheJulia has joined #openstack-cinder | 06:47 | |
*** icey has joined #openstack-cinder | 06:47 | |
*** coreycb has joined #openstack-cinder | 06:47 | |
*** guilhermesp has quit IRC | 06:48 | |
*** amito has quit IRC | 06:48 | |
*** mnasiadka has quit IRC | 06:48 | |
*** guilhermesp has joined #openstack-cinder | 06:48 | |
*** mnasiadka has joined #openstack-cinder | 06:48 | |
*** amito has joined #openstack-cinder | 06:48 | |
*** hemna has quit IRC | 06:56 | |
*** udesale has quit IRC | 07:00 | |
*** udesale has joined #openstack-cinder | 07:00 | |
*** lpetrut has quit IRC | 07:04 | |
*** zigo has joined #openstack-cinder | 07:06 | |
*** rcernin has quit IRC | 07:08 | |
*** tesseract has joined #openstack-cinder | 07:13 | |
*** ircuser-1 has joined #openstack-cinder | 07:13 | |
*** sahid has joined #openstack-cinder | 07:14 | |
*** udesale has quit IRC | 07:20 | |
*** udesale has joined #openstack-cinder | 07:21 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Bump bandit version https://review.opendev.org/658873 | 07:23 |
---|---|---|
*** threestrands has quit IRC | 07:23 | |
*** pcaruana has joined #openstack-cinder | 07:23 | |
*** udesale has quit IRC | 07:26 | |
*** udesale has joined #openstack-cinder | 07:27 | |
*** hemna has joined #openstack-cinder | 07:28 | |
*** helenafm has joined #openstack-cinder | 07:28 | |
*** psachin has joined #openstack-cinder | 07:43 | |
*** e0ne has joined #openstack-cinder | 07:48 | |
*** hemna has quit IRC | 08:02 | |
*** mvkr has quit IRC | 08:11 | |
*** tkajinam has quit IRC | 08:17 | |
*** hemna has joined #openstack-cinder | 08:30 | |
*** brinzhang has quit IRC | 08:32 | |
*** brinzhang has joined #openstack-cinder | 08:33 | |
*** lixiaoy1 has quit IRC | 08:55 | |
*** hemna has quit IRC | 09:04 | |
*** phasespace has joined #openstack-cinder | 09:11 | |
openstackgerrit | nikesh proposed openstack/cinder master: Fix "connector=None" issue in Kaminario drivers https://review.opendev.org/660062 | 09:28 |
*** s10 has joined #openstack-cinder | 09:29 | |
*** lpetrut has joined #openstack-cinder | 09:30 | |
*** hemna has joined #openstack-cinder | 09:33 | |
*** raghavendrat has joined #openstack-cinder | 09:35 | |
openstackgerrit | Raghavendra Tilay proposed openstack/cinder master: 3PAR: Provide option to specify zone information for bootable volume https://review.opendev.org/657585 | 09:55 |
*** sdinescu has quit IRC | 09:57 | |
*** sdinescu has joined #openstack-cinder | 10:01 | |
raghavendrat | is whoami-rajat: online? | 10:03 |
*** rcernin has joined #openstack-cinder | 10:03 | |
*** hemna has quit IRC | 10:06 | |
*** minmin has quit IRC | 10:15 | |
*** phasespace has quit IRC | 10:26 | |
whoami-rajat | raghavendrat: Hi | 10:27 |
*** yikun has quit IRC | 10:32 | |
*** hemna has joined #openstack-cinder | 10:36 | |
*** rcernin has quit IRC | 10:57 | |
raghavendrat | whoami-rajat: whenever you get time, can you please review - https://review.opendev.org/657585 | 10:58 |
*** baojg has quit IRC | 11:04 | |
*** m75abrams has joined #openstack-cinder | 11:09 | |
*** m75abrams has quit IRC | 11:09 | |
*** m75abrams has joined #openstack-cinder | 11:09 | |
*** hemna has quit IRC | 11:10 | |
*** udesale has quit IRC | 11:16 | |
*** m75abrams has quit IRC | 11:28 | |
*** m75abrams has joined #openstack-cinder | 11:31 | |
*** hemna has joined #openstack-cinder | 11:40 | |
whoami-rajat | raghavendrat: sure | 11:49 |
raghavendrat | thanks | 11:50 |
*** baojg has joined #openstack-cinder | 11:57 | |
openstackgerrit | Liang Fang proposed openstack/python-cinderclient master: upload-to-image returns NoneType error https://review.opendev.org/659749 | 12:05 |
*** brinzhang has quit IRC | 12:09 | |
*** dviroel has joined #openstack-cinder | 12:10 | |
*** baojg has quit IRC | 12:14 | |
*** hemna has quit IRC | 12:14 | |
*** henriqueof has joined #openstack-cinder | 12:20 | |
*** ianychoi has quit IRC | 12:28 | |
*** ianychoi has joined #openstack-cinder | 12:29 | |
*** rosmaita has joined #openstack-cinder | 12:34 | |
*** m75abrams has quit IRC | 12:37 | |
*** m75abrams has joined #openstack-cinder | 12:40 | |
*** hemna has joined #openstack-cinder | 12:45 | |
*** carloss has joined #openstack-cinder | 12:47 | |
*** nikeshm has joined #openstack-cinder | 12:48 | |
*** pck has joined #openstack-cinder | 12:48 | |
nikeshm | hi all, i proposed fix https://review.opendev.org/#/c/660062/1 | 12:48 |
nikeshm | for kaminario bug: https://bugs.launchpad.net/cinder/+bug/1829398 | 12:49 |
openstack | Launchpad bug 1829398 in Cinder "Fix "connector=None" issue in terminate_connection for Kaminario volume drivers " [Undecided,In progress] - Assigned to nikesh (nike-niec) | 12:49 |
nikeshm | CI is passed with change and tempest.api.volume.admin.test_volumes_actions.VolumesActionsTest.test_force_detach_volume is passed | 12:49 |
*** jmlowe has quit IRC | 12:49 | |
*** mriedem has joined #openstack-cinder | 12:51 | |
*** m75abrams has quit IRC | 12:59 | |
rosmaita | nikeshm: good job! will take a look | 13:00 |
*** m75abrams has joined #openstack-cinder | 13:01 | |
*** udesale has joined #openstack-cinder | 13:01 | |
*** Guest84310 has joined #openstack-cinder | 13:05 | |
*** Guest84310 is now known as redrobot | 13:06 | |
*** hemna has quit IRC | 13:19 | |
*** psachin has quit IRC | 13:20 | |
raghavendrat | is hemna_: online? | 13:25 |
*** jroll has quit IRC | 13:25 | |
*** jmlowe has joined #openstack-cinder | 13:26 | |
*** jroll has joined #openstack-cinder | 13:26 | |
raghavendrat | is jungleboyj: online? | 13:31 |
*** pcaruana has quit IRC | 13:33 | |
*** m75abrams has quit IRC | 13:38 | |
*** m75abrams has joined #openstack-cinder | 13:40 | |
*** vishalmanchanda has quit IRC | 13:43 | |
*** lseki has joined #openstack-cinder | 13:45 | |
*** eharney has joined #openstack-cinder | 13:46 | |
jungleboyj | raghavendrat: I am here. | 13:47 |
*** baojg has joined #openstack-cinder | 13:52 | |
*** lpetrut has quit IRC | 13:53 | |
*** hemna has joined #openstack-cinder | 13:54 | |
*** vishalmanchanda has joined #openstack-cinder | 13:54 | |
*** s10 has quit IRC | 14:11 | |
openstackgerrit | nikesh proposed openstack/cinder master: Fix "connector=None" issue in Kaminario drivers https://review.opendev.org/660062 | 14:13 |
*** lpetrut has joined #openstack-cinder | 14:15 | |
nikeshm | rosmaita : thanks for review, addressed the nit | 14:15 |
rosmaita | nikeshm: ty | 14:15 |
*** dpawlik has quit IRC | 14:19 | |
*** lpetrut has quit IRC | 14:26 | |
*** hemna has quit IRC | 14:28 | |
*** raghavendrat has quit IRC | 14:37 | |
*** m75abrams has quit IRC | 14:38 | |
*** m75abrams has joined #openstack-cinder | 14:42 | |
*** enriquetaso has joined #openstack-cinder | 14:45 | |
*** m75abrams has left #openstack-cinder | 14:46 | |
*** Conqueror has joined #openstack-cinder | 14:51 | |
*** mriedem is now known as mriedem_away | 14:53 | |
*** pcaruana has joined #openstack-cinder | 14:53 | |
*** sapd1_x has joined #openstack-cinder | 15:00 | |
*** hemna has joined #openstack-cinder | 15:04 | |
*** Luzi has quit IRC | 15:09 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: Bump hacking version to 1.1.x https://review.opendev.org/652703 | 15:22 |
*** enriquetaso has quit IRC | 15:32 | |
*** baojg has quit IRC | 15:34 | |
*** krtaylor has joined #openstack-cinder | 15:36 | |
*** jmlowe has quit IRC | 15:36 | |
*** jmlowe has joined #openstack-cinder | 15:37 | |
*** hemna has quit IRC | 15:39 | |
*** m75abrams has joined #openstack-cinder | 15:39 | |
*** helenafm has quit IRC | 15:42 | |
*** dpawlik has joined #openstack-cinder | 15:55 | |
*** sapd1_x has quit IRC | 16:06 | |
*** m75abrams has quit IRC | 16:09 | |
*** m75abrams has joined #openstack-cinder | 16:11 | |
*** hemna has joined #openstack-cinder | 16:11 | |
*** sahid has quit IRC | 16:11 | |
*** itlinux_ has quit IRC | 16:26 | |
*** m75abrams has quit IRC | 16:30 | |
*** m75abrams has joined #openstack-cinder | 16:35 | |
*** udesale has quit IRC | 16:40 | |
*** hemna has quit IRC | 16:44 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Bump bandit version https://review.opendev.org/658873 | 16:54 |
hemna_ | heh dig another grave in the HPE cemetary.... | 16:59 |
*** m75abrams has quit IRC | 17:00 | |
jungleboyj | hemna_: Hey now. | 17:00 |
jungleboyj | ;-) | 17:00 |
hemna_ | well...it's a repeating pattern for them | 17:00 |
hemna_ | just saying... | 17:00 |
*** m75abrams has joined #openstack-cinder | 17:02 | |
hemna_ | ok so I think I've gotten all the 3rd party driver libraries in requirements as possible | 17:04 |
hemna_ | there are 3 outstanding still | 17:04 |
hemna_ | pyxcli, python-lefthandclient, vmemclient | 17:04 |
hemna_ | lefthand is a dead product AFAIK | 17:04 |
jungleboyj | Yeah, kind of like IBM Acquiring Red Hat. Hoping for the best ... but ... | 17:04 |
hemna_ | pyxcli is an IBM lib that doesn't do python3 | 17:04 |
hemna_ | same with vmemclient | 17:05 |
jungleboyj | hemna_: Is that the one for the XIV? | 17:05 |
hemna_ | https://review.opendev.org/#/c/658103/ | 17:05 |
hemna_ | https://review.opendev.org/#/c/658104/ | 17:05 |
hemna_ | https://review.opendev.org/#/c/658106/ | 17:05 |
hemna_ | jungleboyj:yah, afaik pyxcli is for the XIV driver | 17:05 |
hemna_ | it fails miserably at py3 | 17:05 |
jungleboyj | :-( | 17:06 |
jungleboyj | And it seems that it is very hard to get storage support from IBM anymore. | 17:06 |
*** e0ne has quit IRC | 17:07 | |
jungleboyj | I did follow up on GPFS from that discussion at the Summit. | 17:07 |
hemna_ | so... | 17:07 |
hemna_ | I think we need to mark those drivers as deprecated | 17:07 |
jungleboyj | They got their CI working but they don't seem to be really supporting things anymore. | 17:07 |
hemna_ | asap | 17:07 |
hemna_ | so they have time to realize they will be dropped next release. | 17:08 |
hemna_ | since our drivers have to work in py36 and py37 | 17:08 |
jungleboyj | hemna_: So there are possibly two different discussions there. | 17:08 |
whoami-rajat | eharney: found two bugs related to issues caused by default_volume_type | 17:08 |
whoami-rajat | [1] https://bugs.launchpad.net/starlingx/+bug/1826259 | 17:08 |
whoami-rajat | [2] https://bugs.launchpad.net/horizon/+bug/1829527 | 17:08 |
openstack | Launchpad bug 1826259 in StarlingX "Create Volume dialog opens (from image panel in Horizon) but getting error default volume type can not be found" [Medium,Triaged] - Assigned to Yan Chen (ychen2u) | 17:08 |
openstack | Launchpad bug 1829527 in OpenStack Dashboard (Horizon) "Default volume type used in Create Volume dialog even when the user doesn't have access to it" [Undecided,Incomplete] | 17:08 |
jungleboyj | So, is the problem that we can't get them into requirements or is it a lack of py3.7 support? | 17:08 |
hemna_ | jungleboyj: both | 17:09 |
jungleboyj | Which are we deprecating on? | 17:09 |
whoami-rajat | s/found/"stole from horizon channel" | 17:09 |
jungleboyj | Oh, so if they get py37 support are we still dropping them. | 17:09 |
jungleboyj | I know we had a long discussion with XIV about their library and at the time said it was acceptable. | 17:09 |
eharney | whoami-rajat: looks like a horizon issue that's existed for a while? | 17:10 |
hemna_ | lefthand, xiv and violin | 17:10 |
hemna_ | how can their drivers work in py37 if the library they depend on doesn't work in py37 | 17:10 |
jungleboyj | hemna_: So the question is if they are planning to work on that. | 17:11 |
hemna_ | no idea, where are they? | 17:11 |
*** dpawlik has quit IRC | 17:11 | |
jungleboyj | hemna_: Good question. I can reach out to XIV. | 17:12 |
eharney | whoami-rajat: or maybe we should restrict making the default type non-public? | 17:12 |
jungleboyj | Could also send an e-mail to the 3rd Party CI people for the other two? | 17:12 |
jungleboyj | eharney: Welcome back! | 17:12 |
eharney | jungleboyj: thanks :) | 17:13 |
hemna_ | I mean, we made a ML post about this | 17:15 |
*** hemna has joined #openstack-cinder | 17:15 | |
hemna_ | python3 in CI or deprecation | 17:15 |
hemna_ | by M2 | 17:15 |
jungleboyj | hemna_: If they are able to fix that, then the remaining problem is that we can't containerize them because of their unique libraries. | 17:15 |
hemna_ | I presume them fixing their driver for py3 also requires fixing pyxcli. as pyxcli is the bulk of the heaving lifting | 17:16 |
whoami-rajat | eharney: yep, that is what i think. we should restrict update of any property of default volume type and keep it public by default. | 17:16 |
hemna_ | so, once they do that, then we can also put that in global reqs | 17:16 |
hemna_ | we just need to keep yelling about this | 17:16 |
jungleboyj | hemna_: Ah, ok. The issue right now is the lack of Py3 support. | 17:16 |
hemna_ | often | 17:16 |
hemna_ | yah, pyxcli can't do py3 | 17:16 |
eharney | whoami-rajat: i'm not sure -- there's probably a reasonable case for having only one type, and not exposing it to users, so that creations w/ no type just use it? | 17:16 |
jungleboyj | Ok. Got it. I will follow up on that one. I will send a ML post and copy the CI maintainers for the other two drivers. | 17:17 |
whoami-rajat | eharney: but keeping default_type non-public won't allow other users to create volumes using it http://paste.openstack.org/show/751672/ | 17:19 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Create extras for pypi install https://review.opendev.org/656724 | 17:19 |
hemna_ | jungleboyj:I pulled lefthand, pyxcli and vmemclient from ^^ patch | 17:19 |
eharney | whoami-rajat: ah, interesting | 17:19 |
hemna_ | the others should be in | 17:20 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Create extras for pypi install https://review.opendev.org/656724 | 17:20 |
jungleboyj | hemna_: Sounds good. | 17:21 |
whoami-rajat | eharney: i think this shouldn't have been allowed in the first place, updating default type to non-public, but maybe there was a usecase associated with it (or maybe not) | 17:22 |
*** lpetrut has joined #openstack-cinder | 17:23 | |
whoami-rajat | eharney: also rajinir presented a case from glance side when cinder is configured as backend for glance, no type is supplied from glance hence default_type is used when creating images | 17:24 |
whoami-rajat | https://review.opendev.org/#/c/651480/5/specs/train/untyped-volumes-to-default-volume-type.rst@45 | 17:24 |
whoami-rajat | but i don't think that will affect our current implementation | 17:24 |
eharney | glance can have a type configured when needed | 17:25 |
hemna_ | can we get some love on the driver exception patches | 17:27 |
*** lpetrut has quit IRC | 17:27 | |
hemna_ | I have more to do, but need these to get merged | 17:27 |
hemna_ | https://review.opendev.org/#/q/status:open+project:openstack/cinder+branch:master+topic:driver_exceptions | 17:28 |
whoami-rajat | hemna_: i'm concerned regarding most of them don't have a running CI. | 17:28 |
hemna_ | yah, CI is a major issue now | 17:30 |
*** enriquetaso has joined #openstack-cinder | 17:30 | |
hemna_ | it used to be a concern, but I think 3rd party CI now is kinda a joke | 17:30 |
hemna_ | so many failures | 17:30 |
hemna_ | and nobody seems to care | 17:30 |
hemna_ | well, vendors don't | 17:31 |
whoami-rajat | eharney: yep it has, but when it's not configured then cinder's default vol type is used. | 17:32 |
whoami-rajat | hemna_: agreed. the exception patches looked okay to merge but i kept waiting for CI to run/pass, it never did. | 17:34 |
rosmaita | hemna_: same here, was waiting for CI | 17:34 |
rosmaita | jungleboyj: what is your advice about how to handle ^^ | 17:34 |
rosmaita | i mean, the changes look non-problematic, but it would be nice to see the CI passing | 17:35 |
eharney | presumably most of those exception paths aren't hit by third-party CI... | 17:35 |
rosmaita | yeah, there is that | 17:35 |
jungleboyj | rosmaita: Yeah, Sean and I talked about this last week. | 17:35 |
jungleboyj | Ideally the 3rd Party CI would be passing, but there is so much not working there right now that hemna_ Would never get this change through. | 17:36 |
jungleboyj | So, kind-of looking the other way there right now and getting these merged. | 17:36 |
hemna_ | so, this is exactly what 3rd party CI was for | 17:36 |
hemna_ | to enforce CI working before driver specific patches could land | 17:37 |
hemna_ | and if CI is so bad that these simple patches aren't passing.... | 17:37 |
hemna_ | why do we have CI ? | 17:37 |
hemna_ | :( | 17:37 |
rosmaita | exactly | 17:37 |
hemna_ | I guess that a major issue which F'd CI was the openstack -> opendev change | 17:37 |
hemna_ | that seems to really expose how fickle CI is | 17:38 |
rosmaita | ok, well if our strategy is "approve based on looks", let's split these up amongst the cores to look at, and get them merged | 17:38 |
whoami-rajat | hmm, tempest seems to run the generic tests related to every driver so yeah it might not even check for those driver-specific exceptions but CI should run today or tomorrow. | 17:38 |
rosmaita | hemna: i think you are right, i am still running into occasional gerrit breakage because openstack->opedev isn't redirecting | 17:38 |
*** m75abrams has quit IRC | 17:40 | |
*** eharney has quit IRC | 17:40 | |
*** m75abrams has joined #openstack-cinder | 17:42 | |
rosmaita | there are 15 patches on https://review.opendev.org/#/q/status:open+project:openstack/cinder+branch:master+topic:driver_exceptions , i will review 657855, 659891, 658172, 657872, 658185, 657859 right now | 17:42 |
jungleboyj | hemna_: rosmaita I agree. | 17:47 |
jungleboyj | CI was designed for these cases. | 17:47 |
jungleboyj | The other option is that we hold off on these patches and I start submitting Unsupported patches for all the CIs that are failing because they aren't handling the change to OpenDev. | 17:48 |
rosmaita | jungleboyj: the problem with that is it puts hemna into rebase hell | 17:49 |
*** hemna has quit IRC | 17:49 | |
rosmaita | but, we could do both | 17:49 |
jungleboyj | rosmaita: That was why I was saying screw CI at the moment. | 17:49 |
rosmaita | works for me | 17:49 |
hemna_ | Honestly, at this point, the right thing is to start marking drivers as unsupported | 17:49 |
hemna_ | and put all those up | 17:49 |
jungleboyj | I can send another note to the mailing list saying that I will start pushing up patches to unsupport drivers if they don't fix this. | 17:49 |
hemna_ | I can deal with rebase hell | 17:50 |
hemna_ | unless we want to shitcan CI for drivers | 17:50 |
hemna_ | and let things be the wild west. | 17:50 |
jungleboyj | hemna_: I don't think that is an option. | 17:50 |
*** tesseract has quit IRC | 17:51 | |
rosmaita | FWIW, i agree with eric that the CI very possibly doesn't exercise these code paths anyway, so i'm willing to approve based on reading & unit tests; at the same time, we should do the unsupported patches warning independently | 17:52 |
hemna_ | I'm just raising the issue | 17:53 |
hemna_ | we should deprecate all failing CI drivers | 17:54 |
hemna_ | or just forget about it and ignore CI | 17:54 |
rosmaita | sure ... my vote is deprecate the failing drivers | 17:54 |
hemna_ | well 3rd party CI that is | 17:54 |
jungleboyj | Ok, so, lets review and get these patches through. I will send one more warning shot to the mailing list this week and note that I will start putting up unsupported patches next week. | 17:57 |
*** markvoelker has joined #openstack-cinder | 17:58 | |
jungleboyj | hemna_: rosmaita ^^ | 17:59 |
rosmaita | on it | 17:59 |
jungleboyj | rosmaita: Was looking for agreement. Not trying to push you on it. :-) | 18:07 |
hemna_ | ok | 18:08 |
rosmaita | on it, and i agree | 18:08 |
rosmaita | :) | 18:09 |
*** hemna has joined #openstack-cinder | 18:15 | |
*** eharney has joined #openstack-cinder | 18:27 | |
*** m75abrams has quit IRC | 18:30 | |
*** m75abrams has joined #openstack-cinder | 18:32 | |
rosmaita | jungleboyj: smcginnis: what's the name of the sheepdog CI ? | 18:34 |
hemna_ | https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/sheepdog.py#L443 | 18:35 |
jungleboyj | How did they get that through? | 18:36 |
jungleboyj | They are not listed in the 3rd Party List. | 18:36 |
hemna_ | was just thinking the same thing myself | 18:37 |
jungleboyj | Bad Dog! | 18:37 |
hemna_ | smh | 18:37 |
jungleboyj | And they are not tracked by Sean's CI. | 18:37 |
jungleboyj | Ok. That one is getting unsupported. | 18:37 |
jungleboyj | I will put up a patch for that. | 18:39 |
eharney | iirc the sheepdog job was turned off because it never succeeded | 18:41 |
jungleboyj | eharney: *SMH* | 18:41 |
eharney | hemna_: jungleboyj: it got through because it's an open source driver that was run in openstack infra like ceph/nfs/etc, so it was correct | 18:41 |
jungleboyj | eharney: Oh ... but it isn't being tested anymore? | 18:42 |
jungleboyj | Doesn't look like it is. | 18:44 |
eharney | see https://review.opendev.org/#/c/529171/ | 18:44 |
eharney | https://review.opendev.org/#/c/557031/ | 18:45 |
*** e0ne has joined #openstack-cinder | 18:45 | |
jungleboyj | *Sigh* | 18:47 |
eharney | pretty simple thing to fix, but nobody who had access to the devstack plugin ever looked at it, i guess | 18:47 |
jungleboyj | So, it failed CI and now the logs are gone. | 18:48 |
jungleboyj | Guess I will recheck again and see what happens. | 18:48 |
*** hemna has quit IRC | 18:48 | |
jungleboyj | If it starts working again then we need to add it back in. | 18:49 |
*** m75abrams has quit IRC | 18:54 | |
*** e0ne has quit IRC | 18:57 | |
openstackgerrit | Jon Bernard proposed openstack/cinder master: RBD: postpone snapshot removal until final volume deleted https://review.opendev.org/281550 | 19:21 |
*** hemna has joined #openstack-cinder | 19:22 | |
*** jmlowe has quit IRC | 19:30 | |
*** markvoelker has quit IRC | 19:41 | |
*** vishalmanchanda has quit IRC | 19:43 | |
*** enriquetaso has quit IRC | 19:44 | |
woojay | jungleboyj: smcginnis: Good afternoon. Y'all have an example I may be able to look at for deprecating a driver? I should have deprecated drbdmanage driver instead of just removing the drbdmanage requirement and save a hassle. Thank you. | 20:05 |
jungleboyj | https://www.irccloud.com/pastebin/PeWKElUG/ | 20:07 |
jungleboyj | eharney: ^^^ Another reason that tempest is failing. | 20:07 |
openstackgerrit | Merged openstack/cinder master: HPE 3PAR-Added support for multiattach feature in hpe3par cinder driver https://review.opendev.org/659443 | 20:07 |
eharney | jungleboyj: a new issue on bionic perhaps? | 20:07 |
jungleboyj | eharney: Looks like it. | 20:07 |
jungleboyj | woojay: Let me find you a patch. | 20:08 |
woojay | Thank you. | 20:08 |
jungleboyj | You want to mark it as unsupported. | 20:08 |
jungleboyj | Noting that it is being removed. | 20:08 |
woojay | I marked it as in 'maintenance mode' last time. is that the same thing? | 20:09 |
jungleboyj | Patch? | 20:09 |
woojay | https://review.opendev.org/#/c/629061/ | 20:09 |
jungleboyj | woojay: Ah, so you already sent a warning shot out. | 20:10 |
jungleboyj | I think you can just remove it. | 20:10 |
woojay | and a release note? | 20:11 |
jungleboyj | So, remove the driver, put in a release note that it was deprecated in S and now being removed and add an upgrade check that yells if anyone is trying to use it. | 20:11 |
jungleboyj | woojay: Here is what the upgrade checker code will look like. | 20:12 |
jungleboyj | rosmaita: Mind taking a look at https://review.opendev.org/#/c/649209/ and https://review.opendev.org/#/c/649193/ | 20:12 |
jungleboyj | I would like those to go in so I can backport them. | 20:12 |
woojay | jungleboyj: Sounds good. I will add drbdmanage to the checker once it's merged and add it to my patch. Thank you! | 20:16 |
jungleboyj | Yeah, hopefully we can get it merged quick here so you just need to rebase on it and add it to your patch. See what happens though. | 20:17 |
woojay | 👍👍 | 20:17 |
*** whoami-rajat has quit IRC | 20:19 | |
hemna_ | eharney:looks like the plugin looks for trusty or xenial only | 20:27 |
*** hemna has quit IRC | 20:33 | |
openstackgerrit | Merged openstack/cinder master: move brocade zone manager exceptions https://review.opendev.org/658172 | 20:34 |
openstackgerrit | Merged openstack/cinder master: move zfssa exception https://review.opendev.org/657872 | 20:34 |
openstackgerrit | Merged openstack/cinder master: Move RBD driver exception to driver https://review.opendev.org/659891 | 20:34 |
openstackgerrit | Merged openstack/cinder master: move smbfs exceptions https://review.opendev.org/658185 | 20:34 |
openstackgerrit | Merged openstack/cinder master: move Nexenta exception https://review.opendev.org/657855 | 20:34 |
jungleboyj | Woo hoo! | 20:34 |
hemna_ | w00t! | 20:35 |
hemna_ | yeah! merge conflict fun ensues | 20:35 |
hemna_ | :) | 20:35 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: move storpool exception https://review.opendev.org/657868 | 20:36 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: move zadara exceptions https://review.opendev.org/657874 | 20:39 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: move vzstorage exceptions https://review.opendev.org/658180 | 20:40 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: move cisco zonemanager exception https://review.opendev.org/658167 | 20:41 |
*** enriquetaso has joined #openstack-cinder | 20:47 | |
jungleboyj | Well what do you know. Both the contacts I have at IBM for XIV are gone. | 20:48 |
* jungleboyj shakes my head | 20:48 | |
*** radeks_ has quit IRC | 20:48 | |
openstackgerrit | nikesh proposed openstack/cinder master: Fix "connector=None" issue in Kaminario drivers https://review.opendev.org/660062 | 21:05 |
*** hemna has joined #openstack-cinder | 21:05 | |
openstackgerrit | Merged openstack/cinder master: move netapp exception https://review.opendev.org/657889 | 21:05 |
*** enriquetaso has quit IRC | 21:07 | |
*** itlinux has joined #openstack-cinder | 21:14 | |
*** jmlowe has joined #openstack-cinder | 21:31 | |
*** jmlowe has quit IRC | 21:31 | |
openstackgerrit | Merged openstack/cinder master: move sheepdog exception https://review.opendev.org/657859 | 21:33 |
*** jmlowe has joined #openstack-cinder | 21:33 | |
*** henriqueof has quit IRC | 21:35 | |
*** hemna has quit IRC | 21:38 | |
*** pcaruana has quit IRC | 21:40 | |
*** mriedem_away has quit IRC | 21:42 | |
*** itlinux has quit IRC | 21:49 | |
*** hemna has joined #openstack-cinder | 22:07 | |
*** tejdeep has joined #openstack-cinder | 22:15 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: move dothill exceptions https://review.opendev.org/657866 | 22:26 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: move cisco zonemanager exception https://review.opendev.org/658167 | 22:27 |
hemna_ | so we should nuke sheepdog then | 22:39 |
hemna_ | http://lists.wpkg.org/pipermail/sheepdog/2019-March/068449.html | 22:39 |
*** hemna has quit IRC | 22:42 | |
*** hemna has joined #openstack-cinder | 22:46 | |
*** tkajinam has joined #openstack-cinder | 22:59 | |
*** hemna has quit IRC | 23:09 | |
*** itlinux has joined #openstack-cinder | 23:18 | |
*** rcernin has joined #openstack-cinder | 23:22 | |
*** itlinux has quit IRC | 23:35 | |
*** itlinux has joined #openstack-cinder | 23:48 | |
*** lseki has quit IRC | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!