| openstackgerrit | Dhinesh Balasubramaniam proposed openstack/cinder master: Migration to py37 Remove the encode and decode calls to avoid conversion to and from bytes https://review.opendev.org/675499 | 00:09 |
|---|---|---|
| *** hedvig_01 has quit IRC | 00:13 | |
| *** lixiaoy1 has joined #openstack-cinder | 00:28 | |
| *** whoami-rajat has quit IRC | 00:34 | |
| *** markvoelker has joined #openstack-cinder | 00:39 | |
| *** zhengMa has joined #openstack-cinder | 00:40 | |
| *** mriedem has quit IRC | 00:52 | |
| *** tejdeep has joined #openstack-cinder | 00:59 | |
| *** spsurya has joined #openstack-cinder | 01:05 | |
| *** baojg has joined #openstack-cinder | 01:23 | |
| *** lixiaoy1 has quit IRC | 01:24 | |
| *** whoami-rajat has joined #openstack-cinder | 01:32 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Hedvig: Migration to py37 https://review.opendev.org/675499 | 01:37 |
| *** SrinivasD has joined #openstack-cinder | 02:17 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Update drivers documentation https://review.opendev.org/675365 | 02:44 |
| *** altlogbot_3 has quit IRC | 02:44 | |
| *** altlogbot_0 has joined #openstack-cinder | 02:44 | |
| openstackgerrit | Chris M proposed openstack/cinder master: Create Seagate driver from dothill driver https://review.opendev.org/671195 | 03:06 |
| *** tejdeep has quit IRC | 03:08 | |
| *** markvoelker has quit IRC | 03:18 | |
| *** redrobot has quit IRC | 03:22 | |
| *** dviroel has quit IRC | 03:30 | |
| *** psachin has joined #openstack-cinder | 03:36 | |
| *** zhengMa has quit IRC | 03:39 | |
| openstackgerrit | Alexandra Settle proposed openstack/cinder master: Fixing 404's and broken links https://review.opendev.org/675514 | 04:03 |
| *** baojg has quit IRC | 04:03 | |
| *** ianychoi_ has quit IRC | 04:44 | |
| *** baojg has joined #openstack-cinder | 04:44 | |
| *** markvoelker has joined #openstack-cinder | 04:48 | |
| openstackgerrit | Alexandra Settle proposed openstack/cinder master: Fixing 404's and broken links https://review.opendev.org/675514 | 04:49 |
| *** tejdeep_ has joined #openstack-cinder | 04:52 | |
| *** markvoelker has quit IRC | 04:52 | |
| *** tejdeep_ has quit IRC | 04:54 | |
| *** zhengMa has joined #openstack-cinder | 04:55 | |
| *** udesale has joined #openstack-cinder | 05:33 | |
| *** dave-mccowan has joined #openstack-cinder | 05:38 | |
| *** e0ne has joined #openstack-cinder | 05:40 | |
| *** e0ne has quit IRC | 05:59 | |
| openstackgerrit | Alexandra Settle proposed openstack/cinder stable/stein: Fixing 404's and broken links https://review.opendev.org/675525 | 06:05 |
| openstackgerrit | Alexandra Settle proposed openstack/cinder stable/rocky: Fixing 404's and broken links https://review.opendev.org/675526 | 06:05 |
| *** hemna has quit IRC | 06:24 | |
| *** bhagyashris has joined #openstack-cinder | 06:24 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Add migrations for default volume type https://review.opendev.org/639180 | 06:25 |
| *** hemna has joined #openstack-cinder | 06:48 | |
| *** tesseract has joined #openstack-cinder | 07:04 | |
| *** gemini_117 has joined #openstack-cinder | 07:06 | |
| gemini_117 | hi , i found to import cinder module take a long time, about 3 or 4 second, does anyone have the same problem? | 07:12 |
| gemini_117 | i import cinder module in my command line. | 07:12 |
| *** zhengMa has quit IRC | 07:13 | |
| gemini_117 | does it neen some initialisation for cinder import? | 07:14 |
| *** raghavendrat has quit IRC | 07:18 | |
| *** tosky has joined #openstack-cinder | 07:23 | |
| *** takamatsu has joined #openstack-cinder | 07:35 | |
| *** rcernin has quit IRC | 07:46 | |
| *** geguileo has quit IRC | 07:46 | |
| *** helenafm has joined #openstack-cinder | 07:52 | |
| *** Guest7890 has joined #openstack-cinder | 07:54 | |
| *** Guest7890 is now known as geguileo | 07:55 | |
| *** bhagyashris has quit IRC | 08:05 | |
| *** psachin has quit IRC | 08:07 | |
| *** psachin has joined #openstack-cinder | 08:08 | |
| *** hemna has quit IRC | 08:12 | |
| whoami-rajat | gemini_117: No, fraction of a second, which release are you using? | 08:17 |
| *** ociuhandu has joined #openstack-cinder | 08:18 | |
| *** david-lyle has joined #openstack-cinder | 08:24 | |
| *** dklyle has quit IRC | 08:24 | |
| gemini_117 | queens version | 08:31 |
| gemini_117 | i'm doing some test with cinderlib， and in the cinderlib source, it import cinder module code. | 08:33 |
| *** lemko has joined #openstack-cinder | 08:36 | |
| *** hemna has joined #openstack-cinder | 08:36 | |
| *** SrinivasD has quit IRC | 08:39 | |
| *** gemini_118 has joined #openstack-cinder | 08:51 | |
| *** gemini_117 has quit IRC | 08:53 | |
| *** gemini_118 is now known as gemini_117 | 08:53 | |
| *** hemna has quit IRC | 09:10 | |
| openstackgerrit | Pawel Kaminski proposed openstack/cinder master: target/spdknvmf: Add max_queue_depth configuration parameter https://review.opendev.org/672064 | 09:11 |
| openstackgerrit | Pawel Kaminski proposed openstack/os-brick master: connectors/nvme: Wait until nvme device shows up in kernel https://review.opendev.org/672031 | 09:11 |
| *** markvoelker has joined #openstack-cinder | 09:18 | |
| *** markvoelker has quit IRC | 09:23 | |
| *** e0ne has joined #openstack-cinder | 09:24 | |
| *** gemini_118 has joined #openstack-cinder | 09:27 | |
| *** tesseract has quit IRC | 09:28 | |
| *** tesseract has joined #openstack-cinder | 09:28 | |
| *** tesseract has quit IRC | 09:29 | |
| *** tesseract has joined #openstack-cinder | 09:29 | |
| *** brinzhang has quit IRC | 09:30 | |
| *** gemini_117 has quit IRC | 09:32 | |
| *** gemini_118 has quit IRC | 09:33 | |
| *** gemini_117 has joined #openstack-cinder | 09:34 | |
| *** claudiub has joined #openstack-cinder | 09:47 | |
| *** hemna has joined #openstack-cinder | 09:54 | |
| *** hoonetorg has quit IRC | 09:57 | |
| claudiub | Hello. regarding the cinder py3 compliance (https://etherpad.openstack.org/p/cinder-py3-ci-review) I see that Cloudbase Cinder SMB3 CI is marked as "NO". We've switched to python3 since June. You can see the smb cinder-volume logs from a relatively recent run here: http://cloudbase-ci.com/cinder/673292/6/smb/windows/logs/hv-cinder-673292-6-smb/cinder-volume.log.gz | 10:00 |
| claudiub | and regarding the note: "Missing c-vol log file", that's because it's on the Windows node (see link above). | 10:01 |
| claudiub | ^ smcginnis jungleboyj | 10:04 |
| *** davidsha has joined #openstack-cinder | 10:05 | |
| *** gemini_117 has quit IRC | 10:07 | |
| *** yaawang has quit IRC | 10:09 | |
| claudiub | also, keep in mind that "Cloudbase Cinder SMB3 CI" contains 2 jobs: "cinder-iscsi" and "cinder-smb". :) | 10:10 |
| *** hemna has quit IRC | 10:12 | |
| *** yaawang has joined #openstack-cinder | 10:16 | |
| *** hoonetorg has joined #openstack-cinder | 10:20 | |
| *** hemna has joined #openstack-cinder | 10:35 | |
| *** dpawlik has quit IRC | 11:21 | |
| *** dpawlik has joined #openstack-cinder | 11:22 | |
| *** carloss has joined #openstack-cinder | 11:37 | |
| hemna | mornin | 11:42 |
| *** markvoelker has joined #openstack-cinder | 11:59 | |
| *** dviroel has joined #openstack-cinder | 12:01 | |
| *** boxiang has quit IRC | 12:50 | |
| *** boxiang has joined #openstack-cinder | 12:51 | |
| *** udesale has quit IRC | 12:56 | |
| *** udesale has joined #openstack-cinder | 12:57 | |
| *** henriqueof has joined #openstack-cinder | 12:58 | |
| *** Guest1857 has joined #openstack-cinder | 12:59 | |
| *** ociuhandu has quit IRC | 13:03 | |
| *** ociuhandu has joined #openstack-cinder | 13:03 | |
| *** ociuhandu has quit IRC | 13:07 | |
| *** mriedem has joined #openstack-cinder | 13:10 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder master: docs: update new driver review page https://review.opendev.org/675619 | 13:13 |
| *** Conqueror has quit IRC | 13:24 | |
| *** ociuhandu has joined #openstack-cinder | 13:27 | |
| *** Conqueror has joined #openstack-cinder | 13:33 | |
| *** ociuhandu has quit IRC | 13:43 | |
| *** ociuhandu has joined #openstack-cinder | 13:44 | |
| *** lbragstad has joined #openstack-cinder | 13:45 | |
| *** davee_ has quit IRC | 13:47 | |
| *** david-lyle is now known as dklyle | 13:48 | |
| *** ociuhandu has quit IRC | 13:49 | |
| *** eharney has joined #openstack-cinder | 13:50 | |
| *** spsurya has quit IRC | 13:54 | |
| *** ociuhandu has joined #openstack-cinder | 13:55 | |
| *** Oline has joined #openstack-cinder | 13:56 | |
| Oline | Hi everyone, I'm having problem with the synology iscsi driver in debian 10.0 | 13:57 |
| Oline | I got this error when trying to start cinder with this driver : | 13:58 |
| Oline | Failed to initialize driver.: TypeError: can only concatenate str (not "bytes") to str | 13:58 |
| *** lbragstad has quit IRC | 13:58 | |
| Oline | line 105 : md5_str = d_i + password + salt | 13:59 |
| openstackgerrit | Thiago Correa proposed openstack/cinder master: NetApp SolidFire: Fix replication https://review.opendev.org/675630 | 13:59 |
| tosky | Oline: that looks like a python3 porting issue; according this etherpad: https://etherpad.openstack.org/p/cinder-py3-ci-review , the Synology CI (which I guess tests that driver) is not properly python3-compliant | 13:59 |
| Oline | the problem seems to be that the "salt" variable is of type byte and not str | 13:59 |
| Oline | @tosky OK, I got to the same conclusion | 14:00 |
| openstackgerrit | Sean McGinnis proposed openstack/cinder stable/stein: Move DotHill release note to correct location https://review.opendev.org/670376 | 14:01 |
| Oline | How could I workaround this ? (I tried lastest version from github, then tried to fix the errors, but I stopped after the 8th errors :s) | 14:02 |
| Oline | I'm runny rocky openstack version from debian packages | 14:03 |
| smcginnis | Oline: Your best bet is probably to run the service under Python 2.7 until they are able to address their Python 3 issues. | 14:04 |
| *** lbragstad has joined #openstack-cinder | 14:05 | |
| Oline | The whole cinder service? | 14:05 |
| Oline | or just there driver? (if so, how can I make cinder just call this driver using python27?) | 14:05 |
| smcginnis | Oline: The driver is in the service, so it would mean running at least the cinder-volume service with py2. | 14:06 |
| eharney | it would be good to file a bug for this at https://bugs.launchpad.net/cinder | 14:10 |
| Oline | @eharney Ok, I can try running cinder-volume with python2 | 14:11 |
| Oline | I'll fill a bug too, thanks for the link to the right place :) | 14:11 |
| *** lbragstad has quit IRC | 14:14 | |
| *** psachin has quit IRC | 14:16 | |
| Oline | smcginnis I just looked for the python2.7 driver version, but it is not shipped within Debian packages. I'm not sure that I'm going to take time to make cinder-volume work with python 2.7 :s Seem that python 2.7 is dropped at the end of the year by openstack. | 14:16 |
| Oline | Maybe I'll try a little more on fixing the python3 issues by myself | 14:17 |
| Oline | Thanks for the help :) | 14:17 |
| smcginnis | Oline: Still supported in Train, but the plan is to drop it in the U release. | 14:18 |
| Oline | @smcginnis That's what I read in the openstack doc about python3. Because I'm not fond of working for future drop software, I'll wait for synology to fix it if I can't myself | 14:19 |
| tosky | Oline: if you stay on debian stable, python 2.7 is going to be supported for the lifetime of buster (10.0) | 14:20 |
| tosky | that's what stable distributions do | 14:21 |
| tosky | moreover, the fix for this may not be backported to rocky (and then you would need to wait for an updated package, which does not always happen, unless you backport the fix yourself) | 14:22 |
| Oline | I usualy backport fix by myself | 14:22 |
| tosky | oki | 14:22 |
| Oline | often I mix using the testing distribution and backporting/packaging myself what I need | 14:23 |
| *** dpawlik has quit IRC | 14:26 | |
| *** boxiang has quit IRC | 14:28 | |
| *** boxiang has joined #openstack-cinder | 14:28 | |
| *** ociuhandu has quit IRC | 14:34 | |
| *** ociuhandu has joined #openstack-cinder | 14:35 | |
| *** boxiang has quit IRC | 14:39 | |
| *** boxiang has joined #openstack-cinder | 14:39 | |
| *** Oline has left #openstack-cinder | 14:39 | |
| *** ociuhandu has quit IRC | 14:40 | |
| *** ociuhandu has joined #openstack-cinder | 14:41 | |
| *** ociuhandu has quit IRC | 14:42 | |
| jungleboyj | eharney: You around. | 14:48 |
| eharney | jungleboyj: in a meeting for now, but what's up? | 14:48 |
| jungleboyj | smcginnis: and I had asked walshh_ to add the status check for this review: https://review.opendev.org/#/c/664860 | 14:48 |
| smcginnis | I didn't. :) | 14:49 |
| eharney | i don't think we can run driver code in the cinder-status command... | 14:49 |
| jungleboyj | smcginnis: Oh, sorry, I thought you were in on that. | 14:49 |
| smcginnis | I actually have the same concerns as eharney | 14:50 |
| smcginnis | I'd rather not do that. | 14:50 |
| jungleboyj | smcginnis: Oh, ok. | 14:50 |
| eharney | there's probably another way that this check could be done if it's really needed, but probably requires some work | 14:50 |
| smcginnis | See my comment on PS10 on that review. | 14:50 |
| jungleboyj | Ok. See that now. Sorry. I thought someone else had agreed with me. | 14:52 |
| jungleboyj | I will pull my request if you guys feel this is the wrong approach. | 14:52 |
| eharney | do we have a doc on these checks in general? | 14:53 |
| smcginnis | Probably would be good to add something to https://docs.openstack.org/cinder/latest/upgrade.html | 14:54 |
| jungleboyj | https://docs.openstack.org/cinder/latest/contributor/rolling.upgrades.html#upgrade-checks | 14:54 |
| jungleboyj | That is what we currently have. | 14:54 |
| *** Conqueror has left #openstack-cinder | 14:54 | |
| eharney | i'm not sure that what this patch was doing really fits with reasonable use cases for this anyway, but let me go read over it a bit | 14:55 |
| smcginnis | THat doesn't seem the right place for that. | 14:55 |
| jungleboyj | Ok. We can move that. | 14:55 |
| smcginnis | The tool is for administrators performing an upgrade, so I don't think they would think to look under the contributor documentation. | 14:56 |
| jungleboyj | Well, that is the documentation for contributors. | 14:57 |
| *** dklyle has quit IRC | 14:58 | |
| *** david-lyle has joined #openstack-cinder | 14:58 | |
| smcginnis | Oh, true. | 14:58 |
| smcginnis | Under rolling upgrades seems a little bit odd to me, but probably not any better places to put it. | 14:59 |
| jungleboyj | Right. When I wrote that I didn't see a better place. | 15:01 |
| jungleboyj | For the User we could add documentation too though. That is a good idea. | 15:01 |
| *** david-lyle is now known as dklyle | 15:16 | |
| tosky | eharney: hi, did you notice my comments on https://review.opendev.org/#/c/671925/? (which is technically part of cinder, even though it is used) | 15:25 |
| *** helenafm has quit IRC | 15:30 | |
| eharney | tosky: looks pretty sensible to me | 15:31 |
| tosky | eharney: do you think it's worth adding jobs against the older branches, so that they are not suddenly broken? | 15:32 |
| eharney | tosky: it would be a good idea, not sure how hard it is to do | 15:34 |
| tosky | eharney: that's really easy, let me send an updated patch | 15:36 |
| eharney | tosky: main question is whether there are any differences in available features across older branches | 15:37 |
| tosky | eharney: from time to time devstack receives new features or cleanups which are not backported | 15:37 |
| eharney | tosky: i mean nfs driver features | 15:38 |
| tosky | eharney: oh, so that the values set by configure_tempest_nfs or configure_cinder_nfs need to change depending on the branch? | 15:39 |
| eharney | tosky: i'm not sure they need to now, but they may when we add multiattach support in some release | 15:39 |
| eharney | or when we add encrypted volume support, etc | 15:40 |
| eharney | maybe for now the branches are all the same | 15:40 |
| tosky | eharney: but then it's even more important to make sure that a change in devstack-plugin-nfs does not break when used against an older branch | 15:40 |
| tosky | before breaking without notice because it works against cinder master | 15:40 |
| *** e0ne has quit IRC | 15:44 | |
| tosky | aaand sent | 15:45 |
| openstackgerrit | Eric Harney proposed openstack/cinder master: Add contributor notes on cinder-status checks https://review.opendev.org/675651 | 15:55 |
| eharney | jungleboyj: smcginnis: maybe this can help start a discussion to solidify some of the guidelines around cinder-status ^ | 15:55 |
| eharney | also added an alternate suggestion for how to do the powermax check to that patch | 15:58 |
| *** udesale has quit IRC | 16:02 | |
| claudiub | Hello. regarding the cinder py3 compliance (https://etherpad.openstack.org/p/cinder-py3-ci-review) I see that Cloudbase Cinder SMB3 CI is marked as "NO". We've switched to python3 since June. You can see the smb cinder-volume logs from a relatively recent run here: http://cloudbase-ci.com/cinder/673292/6/smb/windows/logs/hv-cinder-673292-6-smb/cinder-volume.log.gz | 16:02 |
| claudiub | and regarding the note: "Missing c-vol log file", that's because it's on the Windows node (see link above). | 16:02 |
| jungleboyj | claudiub: Sorry I didn't respond to the ping over night. | 16:04 |
| claudiub | let me know if there's anything else we have to care of :) | 16:05 |
| jungleboyj | Looking. | 16:06 |
| *** dklyle has quit IRC | 16:06 | |
| jungleboyj | claudiub: I am sorry not figuring out how your CI works. You are indeed in compliance. | 16:10 |
| claudiub | \o/ thanks. :) | 16:10 |
| jungleboyj | I am updating the etherpad and will also let Thierry know as he was doing some other follow up. | 16:10 |
| jungleboyj | Thank you for getting that done and for following up. | 16:10 |
| claudiub | np :) | 16:11 |
| *** henriqueof has quit IRC | 16:14 | |
| jungleboyj | claudiub: Ok, everything is updated. | 16:16 |
| *** Guest1857 is now known as redrobot | 16:17 | |
| *** davidsha has quit IRC | 16:26 | |
| *** dklyle has joined #openstack-cinder | 16:26 | |
| *** dklyle has quit IRC | 16:37 | |
| *** dklyle has joined #openstack-cinder | 16:37 | |
| *** tejdeep has joined #openstack-cinder | 16:39 | |
| *** markvoelker has quit IRC | 16:41 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Add "service token" documentation https://review.opendev.org/672145 | 16:42 |
| *** markvoelker has joined #openstack-cinder | 16:44 | |
| *** irclogbot_2 has quit IRC | 16:47 | |
| *** irclogbot_3 has joined #openstack-cinder | 16:47 | |
| *** irclogbot_3 has quit IRC | 16:49 | |
| *** irclogbot_0 has joined #openstack-cinder | 16:49 | |
| *** eharney has quit IRC | 16:50 | |
| *** tesseract has quit IRC | 17:00 | |
| *** dklyle has quit IRC | 17:07 | |
| *** jcosmao has left #openstack-cinder | 17:07 | |
| *** david-lyle has joined #openstack-cinder | 17:07 | |
| *** david-lyle has quit IRC | 17:10 | |
| *** david-lyle has joined #openstack-cinder | 17:10 | |
| *** hedvig_01 has joined #openstack-cinder | 17:15 | |
| *** tejdeep has quit IRC | 17:23 | |
| *** lemko has quit IRC | 17:33 | |
| *** tejdeep has joined #openstack-cinder | 17:44 | |
| *** lemko has joined #openstack-cinder | 17:47 | |
| *** eharney has joined #openstack-cinder | 17:48 | |
| hedvig_01 | @smcginnis : I just check the run-hedvig CI comment. I'm trying to debug this as well. when I run " tox -e all-plugin -- volume" All tests have passed. "- Failed: 0" . I've modified the CI setup to point to the latest patchset. the console output shows "git fetch https://review.opendev.org/openstack/cinder refs/changes/99/675499/2 | 17:51 |
| hedvig_01 | However I still see the same old 87 failures. | 17:51 |
| smcginnis | hedvig_01: What does "I've modified the CI setup to point to the latest patchset" mean? CI should always pull the patch under test to run against. | 17:52 |
| smcginnis | hedvig_01: Based on that last failure, doesn't look like it is using the code it should be - http://os-logserver.hedviginc.com/refs/changes/99/675499/2/logs/screen-c-vol.txt.gz#_Aug_09_02_13_02_746082 | 17:55 |
| hedvig_01 | cd $BASE/new/cinder | 17:56 |
| hedvig_01 | UPSTREAM_REMOTE=https://review.opendev.org/openstack/cinder | 17:56 |
| hedvig_01 | LATEST_PATCHSET=refs/changes/99/675499/2 | 17:56 |
| hedvig_01 | git fetch $UPSTREAM_REMOTE $LATEST_PATCHSET && git cherry-pick FETCH_HEAD | 17:56 |
| hedvig_01 | 17:56 | |
| hedvig_01 | In the pre_test_hook fucntion, I've added | 17:56 |
| hedvig_01 | sorry about the inconsistent paste. | 17:56 |
| smcginnis | This should be removed now - http://os-logserver.hedviginc.com/refs/changes/99/675499/2/console.html#_2019-08-09_01_42_56_696 | 17:58 |
| smcginnis | Not sure if that is causing issues. | 17:58 |
| smcginnis | I don't think there's any need to use devstack-gate. | 17:59 |
| hedvig_01 | Sorry, I'm a little confused. What should be removed? | 17:59 |
| smcginnis | Cherry-picking a specific patch in a pre_test_hook. | 18:00 |
| smcginnis | And I don't think you need to do anything related to devstack-gate. | 18:00 |
| hedvig_01 | okay | 18:00 |
| smcginnis | Looking at your local.conf, CINDER_BRANCH is commented out there. | 18:00 |
| hedvig_01 | cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh | 18:01 |
| smcginnis | I didn't think setting CINDER_REPO to gerrit would work. | 18:01 |
| hedvig_01 | we have this which invokes the devstackgate part of it | 18:01 |
| smcginnis | hedvig_01: What do you need devstack-gate for? | 18:01 |
| smcginnis | IIRC, devstack-gate is deprecated and going away soon. | 18:02 |
| hedvig_01 | This was present during the stein's release. Is there a sample pretesthook function I can refer to? | 18:02 |
| hedvig_01 | CINDER_REPO=https://review.openstack.org/openstack/cinder | 18:02 |
| hedvig_01 | CINDER_BRANCH=refs/changes/99/675499/2 | 18:02 |
| hedvig_01 | we also have this in the CI setup | 18:03 |
| smcginnis | opendev.org/openstack/cinder is the real repo location. | 18:03 |
| hedvig_01 | Agreed | 18:03 |
| smcginnis | CINDER_BRANCH is commented out in that patch's local.conf, so that's probably why you are not getting the changes it's supposed to be testing. | 18:04 |
| smcginnis | Any probably means you've only ever been testing on master. | 18:04 |
| smcginnis | master HEAD more precisely. | 18:04 |
| hedvig_01 | correct. Hence my new changes are not being reflected | 18:04 |
| hedvig_01 | I see a bunch of things in the executeShell of our CI setup | 18:05 |
| hedvig_01 | https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers | 18:05 |
| hedvig_01 | We used this link as reference for the pre_test and the executeshell content | 18:06 |
| hedvig_01 | Are we using the right reference? | 18:06 |
| smcginnis | Ah, so that must be one approach for when the driver is "not merged yet". | 18:07 |
| smcginnis | That wasn't the case for quite awhile now. | 18:07 |
| hedvig_01 | okay. so I'll remove everything from pre_test function. I'll set CINDER_BRANCH=refs/changes/99/675499/2 | 18:09 |
| hedvig_01 | This should suffice right? | 18:10 |
| smcginnis | Maybe what you meant, but just to make it clear - "you" don't change CINDER_BRANCH, but the CI does so it always is pulling down and stacking the patch that needs to be tested. | 18:11 |
| hedvig_01 | oh okay. So how does the CI know which patch needs to be tested? There has to be some parameter to be set which will point to "refs/changes/99/675499/2" right? | 18:12 |
| smcginnis | Yeah | 18:13 |
| hedvig_01 | So do I need to set this parameter? | 18:14 |
| smcginnis | However your CI is set up - there are a bunch of different ways - it should know what ref triggered the job to run and set that in CINDER_BRANCH. | 18:14 |
| hedvig_01 | okay | 18:15 |
| hedvig_01 | I'll modify these params and do a quick test. Thank you so much for the responses. | 18:15 |
| smcginnis | No problem, good luck getting it sorted out. | 18:15 |
| *** boxiang has quit IRC | 18:38 | |
| *** boxiang has joined #openstack-cinder | 18:38 | |
| *** e0ne has joined #openstack-cinder | 19:41 | |
| *** whoami-rajat has quit IRC | 20:12 | |
| *** e0ne has quit IRC | 20:18 | |
| *** lemko has quit IRC | 20:43 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Unisphere version check https://review.opendev.org/664860 | 20:57 |
| *** markvoelker has quit IRC | 21:01 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - QoS Utils Move https://review.opendev.org/669325 | 21:08 |
| *** jrubenst has quit IRC | 21:10 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Train San REST Port Removal https://review.opendev.org/669866 | 21:10 |
| *** markvoelker has joined #openstack-cinder | 21:11 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - SnapVX NoCopy Mode https://review.opendev.org/671235 | 21:12 |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax driver - check cylinder count of source and target volumes https://review.opendev.org/671360 | 21:14 |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Miscellaneous improvements to delete https://review.opendev.org/673292 | 21:17 |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Volume & Snapshot Metadata https://review.opendev.org/673013 | 21:19 |
| *** tejdeep_ has joined #openstack-cinder | 21:19 | |
| *** markvoelker has quit IRC | 21:21 | |
| *** e0ne has joined #openstack-cinder | 21:21 | |
| *** tejdeep has quit IRC | 21:22 | |
| *** e0ne has quit IRC | 21:32 | |
| *** e0ne has joined #openstack-cinder | 21:35 | |
| *** jrubenst has joined #openstack-cinder | 21:38 | |
| *** e0ne has quit IRC | 21:45 | |
| *** mriedem has quit IRC | 22:17 | |
| *** markvoelker has joined #openstack-cinder | 22:23 | |
| *** markvoelker has quit IRC | 22:28 | |
| *** tosky has quit IRC | 23:32 | |
| *** carloss has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!